Guest triggerable assert() isn't exactly nice indeed.
But it's not a show stopper.
It doesn't allow exploiting the host, the guest can only DoS itself.
And you must be priviledged in the guest to do so.
Most likely this is the driver placing the qxl commands in the wrong pci
bar. See commit 86dbc
On Tue, Nov 14, 2017 at 06:13:48PM -0500, prasad.singamse...@oracle.com wrote:
> From: Prasad Singamsetty
>
> This pair of patches extends the intel-iommu to support address
> width to 48 bits. This is required to support qemu guest with large
> memory (>=1TB).
>
> Patch1 implements changes to
As of commit 660c97eef6f8 ("ivshmem: use kvm irqfd for msi notifications"),
QEMU crashes with:
kvm_irqchip_commit_routes: Assertion `ret == 0' failed.
if the ivshmem device is configured with more vectors than what the server
supports. This is caused by the ivshmem_vector_unmask() being called
Adds a rollback path to ivshmem_enable_irqfd() and fixes
ivshmem_disable_irqfd() to bail if irqfd has not been enabled.
To reproduce, run:
ivshmem-server -n 0
and QEMU with:
-device ivshmem-doorbell,chardev=iv
-chardev socket,path=/tmp/ivshmem_socket,id=iv
then load, unload, and load aga
Fixes bugs in the ivshmem device implementation uncovered with the new
Windows ivshmem driver:
https://github.com/virtio-win/kvm-guest-drivers-windows/tree/master/ivshmem
v1->v2:
* Patch 1 - added reproducer info to commit message (Markus)
* Patch 2 - restructured conditionals, fixed comment forma
As of commit 660c97eef6f8 ("ivshmem: use kvm irqfd for msi notifications"),
QEMU crashes with:
ivshmem: msix_set_vector_notifiers failed
msix_unset_vector_notifiers: Assertion `dev->msix_vector_use_notifier &&
dev->msix_vector_release_notifier' failed.
if MSI-X is repeatedly enabled and disabled
On Tue, Nov 14, 2017 at 10:52:54PM +0100, Auger Eric wrote:
[...]
> I meant, in the current intel_iommu code, vtd_find_add_as() creates 1
> IOMMU MR and 1 AS per PCIe device, right?
I think this is the most tricky point - in QEMU IOMMU MR is not really
a 1:1 relationship to devices. For Intel,
From: Ying Fang
QEMU will abort when vhost-user process is restarted during migration when
vhost_log_global_start/stop is called. The reason is clear that
vhost_dev_set_log returns -1 because network connection is temporarily lost.
To handle this situation, let's cancel migration and report it to
On 15.11.2017 00:33, David Gibson wrote:
> On Tue, 14 Nov 2017 12:20:24 +0100
> Thomas Huth wrote:
>
>> Since commit ab06ec43577177a442e8 we test the vmxnet3 device in the
>> pxe-tester, too (when running "make check SPEED=slow"). This now
>> revealed that the code is not working there if the hos
Max Reitz writes:
> On 2017-11-14 15:57, Markus Armbruster wrote:
>> Max Reitz writes:
>>
>>> Signed-off-by: Max Reitz
>>> ---
>>> include/qapi/qmp/qdict.h | 1 +
>>> qobject/qdict.c | 10 ++
>>> 2 files changed, 11 insertions(+)
>>>
>>> diff --git a/include/qapi/qmp/qdict.h
Hi,
I currently think that this patch is wrong and should be reverted.
It fixes a certain use case by hacking the PCI device id, but does
not model the way how that device id is set on the real hardware
correctly.
As far as I know, all i82559 have a default PCI device id of 0x1229.
It can be cha
Some more details about this experiment:
The host is running Ubuntu-16.04 with 4.4.0 Linux kernel and QEMU-2.5.1; The
guest is running Ubuntu-12.04, except Memcached with Ubuntu-16.04.
The exact numbers of the proportions of write-not-dirty pages for the first
2 pre-copy iterations: (0.445 mea
在 2017/11/14 19:40, Marc-André Lureau 写道:
> Hi
>
> On Tue, Nov 14, 2017 at 8:09 AM, fangying wrote:
>> Hi all,
>>
>> We have a vm running migration with vhost-user as network backend, we notice
>> that qemu will abort when openvswitch is restarted
>> when MEMORY_LISTENER_CALL_GLOBAL(log_global
Hi
On Wed, Nov 15, 2017 at 2:16 AM, Stefan Berger
wrote:
> On 11/14/2017 06:40 PM, Marc-André Lureau wrote:
>>
>> Hi
>>
>> On Tue, Nov 14, 2017 at 10:52 PM, Stefan Berger
>> wrote:
>>>
>>> Add a caching layer for the TPM established flag so that we don't
>>> need to go to the emulator every time
Hi
On Wed, Nov 15, 2017 at 2:18 AM, Stefan Berger
wrote:
> On 11/14/2017 06:47 PM, Marc-André Lureau wrote:
>>
>> Hi
>>
>> On Tue, Nov 14, 2017 at 10:52 PM, Stefan Berger
>> wrote:
>>>
>>> Rather than returning ~0, return 0 for every register in case of
>>> failure mode. The '0' is better to ind
On 11/15/2017 05:21 AM, Michael S. Tsirkin wrote:
On Tue, Nov 14, 2017 at 08:02:03PM +0800, Wei Wang wrote:
On 11/14/2017 01:32 AM, Michael S. Tsirkin wrote:
- guest2host_cmd: written by the guest to ACK to the host about the
commands that have been received. The host will clear the correspondi
Hi, guys
I met a strange problem, with qemu 2.8.1:
qemu consumes too many heap memory after several operations and can not release
them anymore:
hot pulg/unplug disk & net, vnc connect/disconnect, guestOS reboot, etc.
01a7a000-3b4efe000 rw-p 00:00 0 [hea
build 32 bit config:
./configure --enable-guest-agent --cross-prefix=i686-w64-mingw32-
--with-vss-sdk="/home/VSSSDK72" --disable-fdt --target-list=i386-softmmu
为了让您的VPlat虚拟机故障和docker故障得到高效的处理，请上报故障到: $VPlat技术支持。
芦志朋 luzhipeng
IT开发工程师 IT Development
Engineer
操作系统产品
The checksum algorithm used by IPv4, TCP and UDP allows a zero value
to be represented by either 0x and 0x. But per RFC 768, a zero
UDP checksum must be transmitted as 0x, as 0x is a special
value meaning no checksum.
Substitute 0x whenever a checksum is computed as zero when
m
Hi Eric,
On Tue, Nov 14, 2017 at 10:52:54PM +0100, Auger Eric wrote:
> Hi Yi L,
>
> On 14/11/2017 14:59, Liu, Yi L wrote:
> > On Tue, Nov 14, 2017 at 09:53:07AM +0100, Auger Eric wrote:
> > Hi Eric,
> >
> >> Hi Yi L,
> >>
> >> On 13/11/2017 10:58, Liu, Yi L wrote:
> >>> On Mon, Nov 13, 2017 at 0
Quoting lu.zhip...@zte.com.cn (2017-11-14 19:41:58)> i used xp version:> > xp
professional 2002 service pack 3>Hmm, doesn't
--cross-prefix=x86_64-w64-mingw32- result in a 64-bit> qemu-ga.exe? How are you
running this on 32-bit Windows XP?
i build two version :32bit and 64 bit , run 32bit
On Tue, Nov 14, 2017 at 6:10 PM, Jason Wang wrote:
>
>
> On 2017年11月15日 07:25, Ed Swierk wrote:
>>
>> The checksum algorithm used by IPv4, TCP and UDP allows a zero value
>> to be represented by either 0x and 0x. But per RFC 768, a zero
>> UDP checksum must be transmitted as 0x, as 0x0
Quoting lu.zhip...@zte.com.cn (2017-11-14 19:41:58)
> i used xp version:
>
> xp professional 2002 service pack 3
Hmm, doesn't --cross-prefix=x86_64-w64-mingw32- result in a 64-bit
qemu-ga.exe? How are you running this on 32-bit Windows XP?
>
> build environment:
>
> root@localhost qemu-2.5.
On Mon, Nov 13, 2017 at 03:07:45PM +0200, Marcel Apfelbaum wrote:
> On 11/11/2017 17:25, Marcel Apfelbaum wrote:
> > Currently there is no MMIO range over 4G
> > reserved for PCI hotplug. Since the 32bit PCI hole
> > depends on the number of cold-plugged PCI devices
> > and other factors, it is ver
On 2017年11月15日 07:25, Ed Swierk wrote:
The checksum algorithm used by IPv4, TCP and UDP allows a zero value
to be represented by either 0x and 0x. But per RFC 768, a zero
UDP checksum must be transmitted as 0x, as 0x is a special
value meaning no checksum.
Substitute 0x whe
On 10/30/2017 12:33 PM, Vladimir Sementsov-Ogievskiy wrote:
> Postcopy migration of dirty bitmaps. Only named dirty bitmaps,
> associated with root nodes and non-root named nodes are migrated.
>
> If destination qemu is already containing a dirty bitmap with the same name
> as a migrated bitmap
i used xp version:
xp professional 2002 service pack 3
build environment:
root@localhost qemu-2.5.0]# cat /etc/redhat-release
CentOS Linux release 7.0.1406 (Core)
为了让您的VPlat虚拟机故障和docker故障得到高效的处理，请上报故障到: $VPlat技术支持。
芦志朋 luzhipeng
IT开发工程师 IT Development
E
Hi Igor,
[...]
+parse_numa_node(ms, &node, NULL);
I get build break here:
numa.c:451:13: error: too few arguments to function ‘parse_numa_node’
parse_numa_node(ms, &node, NULL);
In upstream tree, your commit
cc001888b780 ("numa: fixup parsed NumaNodeOptions earli
Quoting lu.zhip...@zte.com.cn (2017-11-14 05:09:35)
> i test the latest qga in xp , it run ok .
>
>
> my qga config :
>
> Configured with: './configure' '--enable-guest-agent' '--cross-prefix=
> x86_64-w64-mingw32-' '--with-vss-sdk=/home/VSSSDK72' '--disable-fdt'
> '--target-list=x86_64
On 11/14/2017 06:47 PM, Marc-André Lureau wrote:
Hi
On Tue, Nov 14, 2017 at 10:52 PM, Stefan Berger
wrote:
Rather than returning ~0, return 0 for every register in case of
failure mode. The '0' is better to indicate that there's no device
there.
For most registers, 0 makes more sense. However
On 11/14/2017 06:40 PM, Marc-André Lureau wrote:
Hi
On Tue, Nov 14, 2017 at 10:52 PM, Stefan Berger
wrote:
Add a caching layer for the TPM established flag so that we don't
need to go to the emulator every time the flag is read by accessing
the REG_ACCESS register.
What's the impact? Isn't th
On Tue, Nov 7, 2017 at 7:01 AM, Peter Maydell wrote:
> The CPU ID registers ID_AA64PFR0_EL1, ID_PFR1_EL1 and ID_PFR1
> have a field for reporting presence of GICv3 system registers.
> We need to report this field correctly in order for Xen to
> work as a guest inside QEMU emulation. We mustn't inc
- Max Reitz ha scritto:
> stat64_min_slow() and stat64_max_slow() compare the wrong way. This
> makes iotest 136 fail with clang and -m32.
Queued, thanks.
Cc: qemu-sta...@nongnu.org
Paolo
> Signed-off-by: Max Reitz
> ---
> util/stats64.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 d
On Thu, Nov 9, 2017 at 5:53 AM, Daniel P. Berrange wrote:
> My fear is that this approach of building a new e1000-ng device in
> parallel with having the existing e1000 device is going to cause
> long term pain, possibly never getting to a state where the e1000-ng
> device can replace the e1000 de
Hi
On Tue, Nov 14, 2017 at 10:52 PM, Stefan Berger
wrote:
> Rather than returning ~0, return 0 for every register in case of
> failure mode. The '0' is better to indicate that there's no device
> there.
For most registers, 0 makes more sense. However, I wonder if we
shouldn't just fail to start
Hi
On Tue, Nov 14, 2017 at 10:52 PM, Stefan Berger
wrote:
> In case the backend has a failure, such as the tpm_emulator's CMD_INIT
> failing, the TIS goes into failure mode and does not respond to reads
> or writes to MMIO registers. In this case we need to prevent the ACPI
> table from being add
Hi
On Tue, Nov 14, 2017 at 10:52 PM, Stefan Berger
wrote:
> Add a caching layer for the TPM established flag so that we don't
> need to go to the emulator every time the flag is read by accessing
> the REG_ACCESS register.
What's the impact? Isn't this just a "small" optimization? Iotw, why
is t
On Tue, 14 Nov 2017 12:20:24 +0100
Thomas Huth wrote:
> Since commit ab06ec43577177a442e8 we test the vmxnet3 device in the
> pxe-tester, too (when running "make check SPEED=slow"). This now
> revealed that the code is not working there if the host is a big
> endian machine (for example ppc64 or
On 2017-11-14 19:01, Max Reitz wrote:
> bdrv_reopen_prepare() assumes that all BDS options are strings, which is
> not necessarily correct. This series introduces a new qobject_is_equal()
> function which can be used to test whether any options have changed,
> independently of their type.
Aaand on
The checksum algorithm used by IPv4, TCP and UDP allows a zero value
to be represented by either 0x and 0x. But per RFC 768, a zero
UDP checksum must be transmitted as 0x, as 0x is a special
value meaning no checksum.
Substitute 0x whenever a checksum is computed as zero on a U
Hi,
This series failed build test on ppc host. Please find the details below.
Type: series
Subject: [Qemu-devel] [PATCH] qapi: block-core: Clarify events emitted by
'block-job-cancel'
Message-id: 20171114191605.22349-1-kcham...@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script w
The device is supposed to maintain two distinct contexts for transmit
offloads: one has parameters for both segmentation and checksum
offload, the other only for checksum offload. The guest driver can
send two context descriptors, one for each context (the TSE flag
specifies which). Then the guest
sum_needed and cptse flags are received from the guest within each
transmit data descriptor. They are not part of the offload context;
instead, they determine how to apply a previously received context to
the packet being transmitted:
- If cptse is set, perform both segmentation and checksum offlo
The transmit offload implementation in QEMU's e1000 device is
deficient and causes packet data corruption in some situations.
According to the Intel 8254x software developer's manual[1], the
device maintains two separate contexts: the TCP segmentation offload
context includes parameters for both s
stat64_min_slow() and stat64_max_slow() compare the wrong way. This
makes iotest 136 fail with clang and -m32.
Signed-off-by: Max Reitz
---
util/stats64.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/util/stats64.c b/util/stats64.c
index 9968fcceac..389c365a9e 100644
From: Prasad Singamsetty
The current implementation of Intel IOMMU code only supports 39 bits
iova address width. This patch provides a new parameter (x-aw-bits)
for intel-iommu to extend its address width to 48 bits but keeping the
default the same (39 bits). The reason for not changing the defa
From: Prasad Singamsetty
The current implementation of Intel IOMMU code only supports 39 bits
host/iova address width so number of macros use hard coded values based
on that. This patch is to redefine them so they can be used with
variable address widths. This patch doesn't add any new functional
From: Prasad Singamsetty
This pair of patches extends the intel-iommu to support address
width to 48 bits. This is required to support qemu guest with large
memory (>=1TB).
Patch1 implements changes to redefine macros and usage to
allow further changes to add support for 48 bit address width.
T
On Tue, 14 Nov 2017, Paolo Bonzini wrote:
On 21/10/2017 13:24, BALATON Zoltan wrote:
diff --git a/exec.c b/exec.c
index db5ae23..a915817 100644
--- a/exec.c
+++ b/exec.c
@@ -370,7 +370,8 @@ static inline bool section_covers_addr(const
MemoryRegionSection *section,
* the section must cover
This fixes a crash caused by picking the wrong memory region in
address_space_lookup_region seen with client code accessing a device
model that uses alias memory regions.
Signed-off-by: BALATON Zoltan
---
exec.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/exec.c b/exec.c
index 97a24a8..e
Add a caching layer for the TPM established flag so that we don't
need to go to the emulator every time the flag is read by accessing
the REG_ACCESS register.
Signed-off-by: Stefan Berger
v1->v2:
- move the caching to the backend layer since detecting the
TPM 1.2 TSC_ResetEstablishmentBit()
In case the backend has a failure, such as the tpm_emulator's CMD_INIT
failing, the TIS goes into failure mode and does not respond to reads
or writes to MMIO registers. In this case we need to prevent the ACPI
table from being added and the straight-forward way is to indicate that
there's no known
Hi Yi L,
On 14/11/2017 14:59, Liu, Yi L wrote:
> On Tue, Nov 14, 2017 at 09:53:07AM +0100, Auger Eric wrote:
> Hi Eric,
>
>> Hi Yi L,
>>
>> On 13/11/2017 10:58, Liu, Yi L wrote:
>>> On Mon, Nov 13, 2017 at 04:56:01PM +1100, David Gibson wrote:
On Fri, Nov 03, 2017 at 08:01:52PM +0800, Liu, Y
Rather than returning ~0, return 0 for every register in case of
failure mode. The '0' is better to indicate that there's no device
there.
Signed-off-by: Stefan Berger
---
hw/tpm/tpm_tis.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c
ind
From: Stefan Berger
The following patches fix a performance issue (patch 1) and an
error path issue (patches 2 and 3) for 2.11.
Stefan
Stefan Berger (3):
tpm_emulator: Add a caching layer for the TPM Established flag
tpm_tis: Return TPM_VERSION_UNSPEC in case of BE failure
tpm_tis: Ret
Am 06.11.2017 um 21:35 schrieb Mike Nawrocki:
> Adds a new PCI ID for the i82559a (0x8086 0x1030) interface. Enables
> this ID with a new property "use-alt-device-id" to preserve
> compatibility.
>
> Signed-off-by: Mike Nawrocki
> ---
> hw/net/eepro100.c| 12
> include/hw/pci/pc
On Tue, Nov 14, 2017 at 08:02:03PM +0800, Wei Wang wrote:
> On 11/14/2017 01:32 AM, Michael S. Tsirkin wrote:
> > > - guest2host_cmd: written by the guest to ACK to the host about the
> > > commands that have been received. The host will clear the corresponding
> > > bits on the host2guest_cmd regi
Hi,
This series failed build test on s390x host. Please find the details below.
Type: series
Subject: [Qemu-devel] [PATCH] qapi: block-core: Clarify events emitted by
'block-job-cancel'
Message-id: 20171114191605.22349-1-kcham...@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script
On Tue, Nov 14, 2017 at 05:28:36PM +0100, Dariusz Stojaczyk wrote:
> Commit 5c0919d0 [1] introduced virtqueue_size parameter
> for common virtio-scsi path, without updaing the vhost-user-scsi
> code. vhost-user-scsi devices right now report size 0 for each vq.
>
> This patch introduces virtqueue_s
It happened again, both with the e1000 and the rtl8139 NICs under qemu
2.11.0.rc0-7-g4ffa88c99c. Kernel is the official Arch one, right now on
4.13.12.
At this point I have no idea anymore what could be causing this, and am
unable to test without having to remove basic functionality from the VM
(e
It helps but I'm quite sure that lower level security systems (guest)
should never be able to crash higher level security systems
(hypervisor).
PS. It repros in 2.10.0 as well.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://
On 2017-11-14 21:38, John Snow wrote:
>
>
> On 11/14/2017 03:35 PM, Max Reitz wrote:
>> On 2017-11-14 21:30, John Snow wrote:
>>>
>>>
>>> On 11/14/2017 01:46 PM, Max Reitz wrote:
On 2017-11-14 19:45, Thomas Huth wrote:
> On 14.11.2017 14:32, Max Reitz wrote:
> [...]
>> Well, do y
On 11/14/2017 03:35 PM, Max Reitz wrote:
> On 2017-11-14 21:30, John Snow wrote:
>>
>>
>> On 11/14/2017 01:46 PM, Max Reitz wrote:
>>> On 2017-11-14 19:45, Thomas Huth wrote:
On 14.11.2017 14:32, Max Reitz wrote:
[...]
> Well, do you want to document it? I'd rather deprecate it alt
On 2017-11-14 21:30, John Snow wrote:
>
>
> On 11/14/2017 01:46 PM, Max Reitz wrote:
>> On 2017-11-14 19:45, Thomas Huth wrote:
>>> On 14.11.2017 14:32, Max Reitz wrote:
>>> [...]
Well, do you want to document it? I'd rather deprecate it altogether.
>>>
>>> Maybe a first step could be to ch
On 11/14/2017 01:46 PM, Max Reitz wrote:
> On 2017-11-14 19:45, Thomas Huth wrote:
>> On 14.11.2017 14:32, Max Reitz wrote:
>> [...]
>>> Well, do you want to document it? I'd rather deprecate it altogether.
>>
>> Maybe a first step could be to change qemu-img so that it refuses to
>> create new
Hello,
On behalf of the QEMU Team, I'd like to announce the availability of the
second release candidate for the QEMU 2.11 release. This release is meant
for testing purposes and should not be used in a production environment.
http://download.qemu-project.org/qemu-2.11.0-rc1.tar.xz
http://do
On 11/14/2017 12:41 PM, Max Reitz wrote:
> @mem_size and @offset are both size_t, thus subtracting them from one
> another will just return a big size_t if mem_size < offset -- even more
> obvious here because the result is stored in another size_t.
>
> Checking that result to be positive is there
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH v2 for-2.11] hw/net/vmxnet3: Fix code to work on
big endian hosts, too
Type: series
Message-id: 1510658424-16527-1-git-send-email-th...@redhat.com
=== TEST SCRIPT BEGIN
Le 11/11/2017 à 02:48, Zach Riggle a écrit :
> I wrote up a quick example to show that this should work specifically for
> /proc/self/exe:
>
> #define _GNU_SOURCE
> #include
> #include
> #include
> #include
> int main(int argc, char** argv) {
> int fd = open("/proc/self/exe", O_NOFOLLOW |
Hi,
This series failed automatic build test. Please find the testing commands and
their output below. If you have docker installed, you can probably reproduce it
locally.
Subject: [Qemu-devel] [PATCH] qapi: block-core: Clarify events emitted by
'block-job-cancel'
Type: series
Message-id: 2017111
On 11/14/2017 12:30 PM, Anton Nefedov wrote:
> On 14/11/2017 7:50 PM, Eric Blake wrote:
>> On 11/14/2017 04:16 AM, Anton Nefedov wrote:
>>> Misaligned compressed write is not supported.
>>>
>>> Signed-off-by: Anton Nefedov
>>> ---
>>> block/qcow2.c | 4
>>> 1 file changed, 4 insertions(+)
On 11/14/2017 12:01 PM, Max Reitz wrote:
> Add a new test file (check-qobject.c) for unit tests that concern
> QObjects as a whole.
>
> Its only purpose for now is to test the qobject_is_equal() function.
>
> + * Note that qobject_is_equal() is not really an equivalence relation,
> + * so this f
On 11/14/2017 12:01 PM, Max Reitz wrote:
> bdrv_reopen_prepare() assumes that all BDS options are strings, which is
> not necessarily correct. This series introduces a new qobject_is_equal()
> function which can be used to test whether any options have changed,
> independently of their type.
>
>
When you cancel an in-progress live block operation with QMP
`block-job-cancel`, it emits the event: BLOCK_JOB_CANCELLED. However,
when `block-job-cancel` is issued after `drive-mirror` has indicated (by
emitting the event BLOCK_JOB_READY) that the source and destination
remain synchronized:
On 11/14/2017 06:09 AM, Thomas Huth wrote:
> On 14.11.2017 09:54, Yu Ning wrote:
>> Hello,
>>
>> As some of you may have noticed, since QEMU 2.9.0, an accelerator known
>> as “hax” has been available for Windows and macOS builds of QEMU, thanks
>> to the hard work of Vincent Palatin and help from
On 11/14/2017 11:37 AM, Wouter Verhelst wrote:
> On Tue, Nov 14, 2017 at 10:41:39AM -0600, Eric Blake wrote:
>> Another thought - with structured replies, we finally have a way to let
>> the client ask for the server to send resize information whenever the
>> server wants, rather than having to be
On 2017-11-14 19:45, Thomas Huth wrote:
> On 14.11.2017 14:32, Max Reitz wrote:
> [...]
>> Well, do you want to document it? I'd rather deprecate it altogether.
>
> Maybe a first step could be to change qemu-img so that it refuses to
> create new qcow1 images (but still can convert them into othe
On 14.11.2017 14:32, Max Reitz wrote:
[...]
> Well, do you want to document it? I'd rather deprecate it altogether.
Maybe a first step could be to change qemu-img so that it refuses to
create new qcow1 images (but still can convert them into other formats).
So basically make qcow1 read-only?
Th
@mem_size and @offset are both size_t, thus subtracting them from one
another will just return a big size_t if mem_size < offset -- even more
obvious here because the result is stored in another size_t.
Checking that result to be positive is therefore not sufficient to
excluse the case that offset
On 14/11/2017 7:50 PM, Eric Blake wrote:
On 11/14/2017 04:16 AM, Anton Nefedov wrote:
Misaligned compressed write is not supported.
Signed-off-by: Anton Nefedov
---
block/qcow2.c | 4
1 file changed, 4 insertions(+)
Should this one be applied in 2.11?
For the record, this one is p
On 14 November 2017 at 17:23, Max Reitz wrote:
> The following changes since commit 191b5fbfa66e5b23e2150f3c6981d30eb84418a9:
>
> Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request'
> into staging (2017-11-14 16:11:19 +)
>
> are available in the git repository at:
>
>
On 15/10/2017 13:30, BALATON Zoltan wrote:
> I've got a bit further with this but still could use some hints to find
> what is happening. Here are some more details I've found so far.
>
> The memory map I have (see below) is a bit complex but the interesting
> part is that I have sii3112.bar5 as a
Add a new test file (check-qobject.c) for unit tests that concern
QObjects as a whole.
Its only purpose for now is to test the qobject_is_equal() function.
Signed-off-by: Max Reitz
---
tests/Makefile.include | 4 +-
tests/check-qobject.c | 328
On 21/10/2017 13:24, BALATON Zoltan wrote:
> When a section with non-0 offset_within_region field is tested to
> cover an address the offset should be taken into account as well.
>
> This fixes a crash caused by picking the wrong memory region in
> address_space_lookup_region seen with client code
Signed-off-by: Max Reitz
Reviewed-by: Kevin Wolf
Reviewed-by: Eric Blake
---
tests/qemu-iotests/133 | 9 +
tests/qemu-iotests/133.out | 5 +
2 files changed, 14 insertions(+)
diff --git a/tests/qemu-iotests/133 b/tests/qemu-iotests/133
index 9d35a6a1ca..af6b3e1dd4 100755
--- a/
Currently, bdrv_reopen_prepare() assumes that all BDS options are
strings. However, this is not the case if the BDS has been created
through the json: pseudo-protocol or blockdev-add.
Note that the user-invokable reopen command is an HMP command, so you
can only specify strings there. Therefore, s
This generic function (along with its implementations for different
types) determines whether two QObjects are equal.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Alberto Garcia
Reviewed-by: Markus Armbruster
---
include/qapi/qmp/qbool.h | 1 +
include/qapi/qmp/qdict.h |
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Alberto Garcia
Reviewed-by: Markus Armbruster
---
include/qapi/qmp/qdict.h| 1 +
include/qapi/qmp/qnull.h| 30 ++
include/qapi/qmp/qobject.h | 12
include/qapi/qmp/types.h| 1 +
Besides the macro itself, this patch also adds a corresponding
Coccinelle rule.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Alberto Garcia
---
include/qapi/qmp/qlist.h | 3 +++
scripts/coccinelle/qobject.cocci | 3 +++
2 files changed, 6 insertions(+)
diff --git a/in
bdrv_reopen_prepare() assumes that all BDS options are strings, which is
not necessarily correct. This series introduces a new qobject_is_equal()
function which can be used to test whether any options have changed,
independently of their type.
v7:
- Patch 6: Fix a clang warning:
tests/check-q
On Tue, Nov 14, 2017 at 10:41:39AM -0600, Eric Blake wrote:
> Another thought - with structured replies, we finally have a way to let
> the client ask for the server to send resize information whenever the
> server wants, rather than having to be polled by a new client request
> all the time. This
On Fri, 27 Oct 2017, BALATON Zoltan wrote:
On Sat, 21 Oct 2017, BALATON Zoltan wrote:
When a section with non-0 offset_within_region field is tested to
cover an address the offset should be taken into account as well.
This fixes a crash caused by picking the wrong memory region in
address_space
On 2017-11-14 18:28, Peter Maydell wrote:
> On 14 November 2017 at 17:23, Max Reitz wrote:
>> The following changes since commit 191b5fbfa66e5b23e2150f3c6981d30eb84418a9:
>>
>> Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request'
>> into staging (2017-11-14 16:11:19 +)
>>
On 14 November 2017 at 17:23, Max Reitz wrote:
> The following changes since commit 191b5fbfa66e5b23e2150f3c6981d30eb84418a9:
>
> Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request'
> into staging (2017-11-14 16:11:19 +)
>
> are available in the git repository at:
>
>
From: Jeff Cody
Test 194 checks for 'luks' to exclude as an unsupported format,
However, most formats are unsupported, due to migration blockers.
Rather than specifying a blacklist of unsupported formats, whitelist
supported formats (specifically, qcow2, qed, raw, dmg).
Tested-by: Alexey Kardas
From: Jeff Cody
Migration does not work for parallels, and has been broken for a while
(see patch 'block/parallels: Do not update header or truncate image when
INMIGRATE'). The bdrv_invalidate_cache() method needs to be added for
migration to be supported. Until this is done, prohibit migratio
ilable in the git repository at:
>
> git://git.kraxel.org/qemu tags/seabios-1.11-final-20171114-pull-request
>
> for you to fetch changes up to 6350b2a09b8a330cbfaea462a34bbb1b8c63d7b1:
>
> seabios: update to 1.11 final (2017-11-14 15:36:08 +0100)
>
> --
From: Vladimir Sementsov-Ogievskiy
Snapshot-switch actually changes active state of disk so it should
reflect on dirty bitmaps. Otherwise next incremental backup using
these bitmaps will be invalid.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-id: 20171023092945.54532-1-vsement...@virtuo
From: Jeff Cody
The VHDX specification requires that before user data modification of
the vhdx image, the VHDX header file and data GUIDs need to be updated.
In vhdx_open(), if the image is set to RDWR, we go ahead and update the
header.
However, just because the image is set to RDWR does not me
040 tries to invoke pause_drive() on a drive that does not use blkdebug.
Good idea, but let's use blkdebug to make it actually work.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Stefan Hajnoczi
Message-id: 20171109203025.27493-3-mre...@redhat.com
Signed-off-by: Max Reitz
---
1 - 100 of 306 matches
Mail list logo
