[Qemu-devel] [PATCH] Document pretty parameter for mon option

2017-11-13 Thread Vicente Jimenez Aguilar
Documentation: document pretty parameter for mon option Signed-off-by: Vicente Jimenez Aguilar --- qemu-options.hx | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 3728e9b4dd..f06002689d 100644 --- a/qemu-options.hx +++ b/qemu-opt

Re: [Qemu-devel] [PATCH v9 2/8] qemu.py: better control of created files

2017-11-13 Thread Amador Pahim
On Tue, Nov 14, 2017 at 1:08 AM, Murilo Opsfelder Araújo wrote: > On 11/13/2017 07:39 PM, Amador Pahim wrote: >> To launch a VM, we need to create basically two files: the monitor >> socket (if it's a UNIX socket) and the qemu log file. >> >> For the qemu log file, we currently just open the path,

Re: [Qemu-devel] [PATCH v5 15/29] hw/moxie: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Thomas Huth
On 13.11.2017 23:35, Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. Reviewed-by: Thomas Huth

Re: [Qemu-devel] [PATCH v5 26/29] hw/timer: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Thomas Huth
On 13.11.2017 23:36, Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. [...] > diff --git a/hw/timer/omap_gptimer.c b/hw/timer/omap_gptimer.c > in

Re: [Qemu-devel] [PATCH v5 27/29] hw/xen*: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Thomas Huth
On 13.11.2017 23:36, Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. > > find ./* -type f -exec sed -i \ > 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fpr

Re: [Qemu-devel] [PATCH v5 28/29] tcg: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Thomas Huth
On 13.11.2017 23:36, Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. [...] > diff --git a/cpus.c b/cpus.c > index 114c29b6a0..d73df01659 100644

Re: [Qemu-devel] [PATCH v5 29/29] target: Use qemu_log() instead of fprintf(stderr, ...)

2017-11-13 Thread Thomas Huth
On 13.11.2017 23:36, Alistair Francis wrote: > Signed-off-by: Alistair Francis [...] > diff --git a/target/ppc/translate.c b/target/ppc/translate.c > index 998fbed848..8eafe30624 100644 > --- a/target/ppc/translate.c > +++ b/target/ppc/translate.c > @@ -3945,11 +3945,11 @@ static inline void gen_o

[Qemu-devel] [Bug 1726394] Re: Passes through prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, address)

2017-11-13 Thread ChristianEhrhardt
This was blocked migrating on a autopkgtest for a known issue now resolved. TL;DR no bionic images. Resolved now, should migrate soon. While the final fix now accepted in linux-user is slightly different, the difference is only a comment. It is therefore fine if we pick this up on next merge for B

Re: [Qemu-devel] [PATCH 3/3] ivshmem: Improve MSI irqfd error handling

2017-11-13 Thread Markus Armbruster
geoff--- via Qemu-devel writes: > On 2017-11-14 04:27, Markus Armbruster wrote: >> Ladi Prosek writes: >> >>> Adds a rollback path to ivshmem_enable_irqfd() and fixes >>> ivshmem_disable_irqfd() to bail if irqfd has not been enabled. >>> >>> Signed-off-by: Ladi Prosek >> >> Is this a theoretica

Re: [Qemu-devel] [PATCH v10 0/8] scripts/qemu.py fixes and cleanups

2017-11-13 Thread Markus Armbruster
Amador Pahim writes: > Changes v1->v2: > - Style fixes to make checkpatch.pl happy. > - Rebased. > Changes v2->v3: > - Fix typo in patch 3 ("qemu.py: make 'args' public") commit message. > Changes v3->v4: > - Squash the 2 first commits since they are co-dependant. > - Cleanup launch() and sh

Re: [Qemu-devel] [PATCH for-2.11] nbd/client: Use error_prepend() correctly

2017-11-13 Thread Markus Armbruster
Eric Blake writes: > On 11/13/2017 11:14 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> When using error prepend(), it is necessary to end with a space >>> in the format string; otherwise, messages come out incorrectly, >>> such as when connecting to a socket that hangs up immediatel

Re: [Qemu-devel] Command-line option to change ungrab key(s)

2017-11-13 Thread Gerd Hoffmann
Hi, > >>> Would this feature be something you would consider adding to QEMU? > >> > >> As context, virt-manager allows customization for the ungrab sequence, and > >> so do spice-gtk/gtk-vnc at the API level. So conceptually I think it is > >> reasonable for any UI console that is intended as m

[Qemu-devel] unsubscribe

2017-11-13 Thread li.shanlue
unsubscribe

[Qemu-devel] QEMU abort when network serivce is restarted during live migration with vhost-user as the network backend

2017-11-13 Thread fangying
Hi all, We have a vm running migration with vhost-user as network backend, we notice that qemu will abort when openvswitch is restarted when MEMORY_LISTENER_CALL_GLOBAL(log_global_start, Forward) is called. The reasion is clear that vhost_dev_set_log returns -1 because the network connection is

Re: [Qemu-devel] qemu+virgl on systems without dmabuf and/or GBM

2017-11-13 Thread Gerd Hoffmann
On Mon, Nov 13, 2017 at 04:15:30PM -0800, Joe Kniss wrote: > Hi, > > I am developing using qemu with virglrenderer on linux systems that > do not support dmabufs or GBM. I have been successful making this > work using glx and ignoring egl/dmabuf/gbm use in qemu. nvidia? Which user interface?

Re: [Qemu-devel] [PATCH v5 13/29] hw/lm32: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Michael Walle
Am 2017-11-13 23:35, schrieb Alistair Francis: Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(std

Re: [Qemu-devel] [PATCH v6 4/5] crash: export paddr_vmcoreinfo_note()

2017-11-13 Thread Dave Young
On 11/13/17 at 08:29pm, Marc-André Lureau wrote: > The following patch is going to use the symbol from the fw_cfg module, > to call the function and write the note location details in the > vmcoreinfo entry, so qemu can produce dumps with the vmcoreinfo note. > > CC: Andrew Morton > CC: Baoquan H

Re: [Qemu-devel] [RFC v3 01/27] char-io: fix possible race on IOWatchPoll

2017-11-13 Thread Peter Xu
On Mon, Nov 13, 2017 at 04:52:11PM +, Stefan Hajnoczi wrote: > On Mon, Nov 06, 2017 at 05:46:17PM +0800, Peter Xu wrote: > > This is not a problem if we are only having one single loop thread like > > before. However, after per-monitor thread is introduced, this is not > > true any more, and t

Re: [Qemu-devel] [PATCH v2 0/5] backup improvements part 1

2017-11-13 Thread Jeff Cody
On Mon, Nov 13, 2017 at 05:41:13PM -0500, John Snow wrote: > Jeff, I think this ought to go through your tree, but I'll sign off on it. > > Fam: Do you agree? > > (Probably -next material, but I'm sending this email because I'm taking > it out of my review queue and I don't want it to get lost.)

Re: [Qemu-devel] [PATCH v2 1/1] migration/ram.c: do not set 'postcopy_running' in POSTCOPY_INCOMING_END

2017-11-13 Thread Peter Xu
On Mon, Nov 13, 2017 at 04:35:17PM -0200, Daniel Henrique Barboza wrote: > When migrating a VM with 'migrate_set_capability postcopy-ram on' > a postcopy_state is set during the process, ending up with the > state POSTCOPY_INCOMING_END when the migration is over. This > postcopy_state is taken into

[Qemu-devel] [PULL 2/2] xics/kvm: synchonize state before 'info pic'

2017-11-13 Thread David Gibson
From: Greg Kurz When using the emulated XICS, the 'info pic' monitor command shows: CPU 0 XIRR=ff00 ((nil)) PP=ff MFRR=ff ICS 1000..13ff 0x10040060340 1000 MSI 05 00 1001 MSI 05 00 1002 MSI 05 00 1003 MSI ff 00 1004 LSI ff 00 1005 LSI ff 00 1006 LSI ff 00 1007 LSI ff 00 100

[Qemu-devel] [PULL 0/2] ppc-for-2.11 queue 20171114

2017-11-13 Thread David Gibson
The following changes since commit 4e8a737c092d25fe5ff99ac7bff01c222c1c017d: Merge remote-tracking branch 'remotes/kraxel/tags/vga-20171110-pull-request' into staging (2017-11-13 14:33:29 +) are available in the git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-2.11-2017

[Qemu-devel] [PULL 1/2] target/ppc: correct htab shift for hash on radix

2017-11-13 Thread David Gibson
From: Sam Bobroff KVM HV will soon support running a guest in hash mode on a POWER9 host running in radix mode (see [1]), however the guest currently fails to boot. This is because the "htab_shift" value (the size of the MMU's hash table) is added to the device tree before KVM has had a chance t

Re: [Qemu-devel] 答复: Re: [PATCH v2] qga: replace GetIfEntry

2017-11-13 Thread Michael Roth
Quoting lu.zhip...@zte.com.cn (2017-11-09 05:26:15) > i think the code is better > > if (OSver.dwMajorVersion >= 6) { > MIB_IF_ROW2 aMib_ifrow; > typedef NETIOAPI_API (WINAPI *getifentry2_t)(PMIB_IF_ROW2 Row); > memset(&aMib_ifrow, 0, sizeof(aMib_ifrow)); > aMib_ifrow.Int

Re: [Qemu-devel] [RESEND PATCH 2/6] memory: introduce AddressSpaceOps and IOMMUObject

2017-11-13 Thread Peter Xu
On Tue, Nov 14, 2017 at 11:59:34AM +1100, David Gibson wrote: > On Mon, Nov 13, 2017 at 04:28:45PM +0800, Peter Xu wrote: > > On Mon, Nov 13, 2017 at 04:56:01PM +1100, David Gibson wrote: > > > On Fri, Nov 03, 2017 at 08:01:52PM +0800, Liu, Yi L wrote: > > > > From: Peter Xu > > > > > > > > Addre

Re: [Qemu-devel] qemu+virgl on systems without dmabuf and/or GBM

2017-11-13 Thread David Airlie
Hi Joe, > > I am developing using qemu with virglrenderer on linux systems that > do not support dmabufs or GBM. I have been successful making this > work using glx and ignoring egl/dmabuf/gbm use in qemu. > Unfortunately, there is currently no way to configure qemu to use > opengl but disab

[Qemu-devel] [PATCH v6] NUMA: Enable adding NUMA node implicitly

2017-11-13 Thread Dou Liyang
Linux and Windows need ACPI SRAT table to make memory hotplug work properly, however currently QEMU doesn't create SRAT table if numa options aren't present on CLI. Which breaks both linux and windows guests in certain conditions: * Windows: won't enable memory hotplug without SRAT table at all

[Qemu-devel] 答复:Re: 答复: Re: [PATCH v2] qga: replace GetIfEntry

2017-11-13 Thread lu.zhipeng
i not sure that i use latest qga in xp,maybe use the older qga.i will test latest qga in xp 发自我的zMail 原始邮件 发件人:MichaelRoth; 收件人:芦志朋10108272; 抄送人:qemu-devel@nongnu.org; 日期:2017-11-14 07:57:45 主题:Re: 答复: Re: [PATCH v2] qga: replace GetIfEntry Quoting lu.zhip...@zte.com.cn (2017-11-09 05:

[Qemu-devel] [PULL 7/8] Add new PCI ID for i82559a

2017-11-13 Thread Jason Wang
From: Mike Nawrocki Adds a new PCI ID for the i82559a (0x8086 0x1030) interface. The "x-use-alt-device-id" property controls whether this new ID is to be used, and is true by default, and set to false in a compat entry. Signed-off-by: Mike Nawrocki Reviewed-by: Michael S. Tsirkin Signed-off-by

[Qemu-devel] [PULL 8/8] net/socket: fix coverity issue

2017-11-13 Thread Jason Wang
From: Jens Freimann This fixes coverity issue CID1005339. Make sure that saddr is not used uninitialized if the mcast parameter is NULL. Cc: qemu-sta...@nongnu.org Reported-by: Peter Maydell Signed-off-by: Jens Freimann Signed-off-by: Jason Wang --- net/socket.c | 2 +- 1 file changed, 1 in

[Qemu-devel] [PULL 4/8] colo-compare: Fix comments

2017-11-13 Thread Jason Wang
From: Mao Zhongyi Cc: Zhang Chen Cc: Li Zhijian Cc: Jason Wang Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Chen Signed-off-by: Jason Wang --- net/colo-compare.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index 5d2

[Qemu-devel] [PULL 6/8] Fix eepro100 simple transmission mode

2017-11-13 Thread Jason Wang
From: Mike Nawrocki The simple transmission mode was treating the area immediately after the transmit command block (TCB) as if it were a transmit buffer descriptor, when in reality it is simply the packet data. This change simply copies the data following the TCB into the packet buffer. Signed-

[Qemu-devel] [PULL 1/8] net: fix check for number of parameters to -netdev socket

2017-11-13 Thread Jason Wang
From: Jens Freimann Since commit 0f8c289ad "net: fix -netdev socket,fd= for UDP sockets" we allow more than one parameter for -netdev socket. But now we run into an assert when no parameter at all is specified > qemu-system-x86_64 -netdev socket socket.c:729: net_init_socket: Assertion `sock->ha

[Qemu-devel] [PULL 3/8] colo-compare: compare the packet in a specified Connection

2017-11-13 Thread Jason Wang
From: Mao Zhongyi A package from pri_indev or sec_indev only belongs to a particular Connection, so we only need to compare the package in the specified Connection's primary_list and secondary_list, rather than for each the whole Connection list to compare. This is time-consuming and unnecessary.

[Qemu-devel] [PULL 5/8] colo: Consolidate the duplicate code chunk into a routine

2017-11-13 Thread Jason Wang
From: Mao Zhongyi Consolidate the code that extract the ip address(src,dst) and port number(src,dst) of the packet into a separate routine extract_ip_and_port() since the same chunk of code is called from two place. Cc: Zhang Chen Cc: Li Zhijian Cc: Jason Wang Signed-off-by: Mao Zhongyi Sign

[Qemu-devel] [PULL 0/8] Net patches

2017-11-13 Thread Jason Wang
The following changes since commit 4ffa88c99c54d2a30f79e3dbecec50b023eff1c8: Merge remote-tracking branch 'remotes/berrange/tags/pull-qcrypto-2017-11-08-1' into staging (2017-11-10 16:01:35 +) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-re

[Qemu-devel] [PULL 2/8] colo-compare: Insert packet into the suitable position of packet queue directly

2017-11-13 Thread Jason Wang
From: Mao Zhongyi Currently, a packet from pri_dev or sec_dev is fristly pushed at the tail of the primary or secondary packet queue then sorted by the tcp sequence number. Now, this patch use g_queue_insert_sorted to insert the packet directly into the suitable position to avoid ordering all pa

[Qemu-devel] [RFC 2/5] hw/arm/virt: Enable dynamic generation of guest RAM memory regions

2017-11-13 Thread zhuyijun
From: Zhu Yijun Register a ram_memory_region_init notify to allocate memory region from system memory and add them as subregions. Signed-off-by: Zhu Yijun --- hw/arm/virt.c | 21 - include/hw/arm/virt.h | 1 + 2 files changed, 17 insertions(+), 5 deletions(-) diff

[Qemu-devel] [RFC 5/5] hw/arm/virt-acpi-build: Build srat table according to mem_list

2017-11-13 Thread zhuyijun
From: Zhu Yijun In case of accessing memory holes, we build srat table by traversing mem_list. Signed-off-by: Zhu Yijun --- hw/arm/virt-acpi-build.c | 40 +++- 1 file changed, 35 insertions(+), 5 deletions(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/v

Re: [Qemu-devel] [RESEND PATCH 2/6] memory: introduce AddressSpaceOps and IOMMUObject

2017-11-13 Thread David Gibson
On Mon, Nov 13, 2017 at 04:28:45PM +0800, Peter Xu wrote: > On Mon, Nov 13, 2017 at 04:56:01PM +1100, David Gibson wrote: > > On Fri, Nov 03, 2017 at 08:01:52PM +0800, Liu, Yi L wrote: > > > From: Peter Xu > > > > > > AddressSpaceOps is similar to MemoryRegionOps, it's just for address > > > spac

Re: [Qemu-devel] [PATCH v5] NUMA: Enable adding NUMA node implicitly

2017-11-13 Thread Dou Liyang
Hi Michael, [...] Seems to cause build failures: /scm/qemu/numa.c:452:13: error: too many arguments to function ‘parse_numa_node’ parse_numa_node(ms, &node, NULL, NULL); Yes, commit cc001888b780 ("numa: fixup parsed NumaNodeOptions earlier") removed a argument from the functi

[Qemu-devel] [RFC 3/5] hw/arm: add scattered RAM memory region support

2017-11-13 Thread zhuyijun
From: Zhu Yijun Dig out reserved memory holes and collect scattered RAM memory regions by adding mem_list member in arm_boot_info struct. Signed-off-by: Zhu Yijun --- hw/arm/boot.c| 8 hw/arm/virt.c| 101 ++- include/hw/arm

[Qemu-devel] [RFC 4/5] hw/arm/boot: set fdt size cell of memory node from mem_list

2017-11-13 Thread zhuyijun
From: Zhu Yijun In case of accessing memory holes, we create memory fdt node by traversing mem_list and adjust memory address if the addr is not belong to RAM memory region. Signed-off-by: Zhu Yijun --- hw/arm/boot.c | 151 ++ 1 file chan

[Qemu-devel] [RFC 1/5] hw/vfio: Add function for getting reserved_region of device iommu group

2017-11-13 Thread zhuyijun
From: Zhu Yijun With kernel 4.11, iommu/smmu will populate the MSI IOVA reserved window and PCI reserved window which has to be excluded from Guest iova allocations. However, If it falls within the Qemu default virtual memory address space, then reserved regions may get allocated for a Guest VF

[Qemu-devel] [RFC 0/5] arm: Exclude reserved memory regions of iommu to avoid

2017-11-13 Thread zhuyijun
From: Zhu Yijun With kernel 4.11, iommu/smmu will populate the MSI IOVA reserved window and PCI reserved window which has to be excluded from Guest iova allocations. And on certain HiSilicon platforms (hip06/hip07), the GIC ITS and PCIe RC deviates from the standard implementation will reserve

Re: [Qemu-devel] [PATCH v2] hw/arm/aspeed: Unlock SCU when running kernel

2017-11-13 Thread Andrew Jeffery
On Mon, 2017-11-13 at 23:58 +1030, Joel Stanley wrote: > The ASPEED hardware contains a lock register for the SCU that disables > any writes to the SCU when it is locked. The machine comes up with the > lock enabled, but on all known hardware u-boot will unlock it and leave > it unlocked when loadi

Re: [Qemu-devel] [PATCH v8 09/14] migration: add is_active_iterate handler

2017-11-13 Thread John Snow
On 10/30/2017 12:33 PM, Vladimir Sementsov-Ogievskiy wrote: > Only-postcopy savevm states (dirty-bitmap) don't need live iteration, so > to disable them and stop transporting empty sections there is a new > savevm handler. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Juan Quin

Re: [Qemu-devel] [PATCH v8 07/14] migration: include migrate_dirty_bitmaps in migrate_postcopy

2017-11-13 Thread John Snow
On 10/30/2017 12:33 PM, Vladimir Sementsov-Ogievskiy wrote: > Enable postcopy if dirty bitmap migration is endabled. > "enabled" > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Juan Quintela Reviewed-by: John Snow

[Qemu-devel] qemu+virgl on systems without dmabuf and/or GBM

2017-11-13 Thread Joe Kniss via Qemu-devel
Hi, I am developing using qemu with virglrenderer on linux systems that do not support dmabufs or GBM. I have been successful making this work using glx and ignoring egl/dmabuf/gbm use in qemu. Unfortunately, there is currently no way to configure qemu to use opengl but disable egl/dmabuf/gbm.

Re: [Qemu-devel] [PATCH v8.1 05/14] migration: introduce postcopy-only pending

2017-11-13 Thread John Snow
On 10/30/2017 02:19 PM, Vladimir Sementsov-Ogievskiy wrote: > There would be savevm states (dirty-bitmap) which can migrate only in > postcopy stage. The corresponding pending is introduced here. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Juan Quintela > --- > > 8.1: add n

Re: [Qemu-devel] [PATCH v9 2/8] qemu.py: better control of created files

2017-11-13 Thread Murilo Opsfelder Araújo
On 11/13/2017 07:39 PM, Amador Pahim wrote: > To launch a VM, we need to create basically two files: the monitor > socket (if it's a UNIX socket) and the qemu log file. > > For the qemu log file, we currently just open the path, which will > create the file if it does not exist or overwrite the fi

Re: [Qemu-devel] [Qemu-trivial] [PATCH v5 17/29] hw/nvram: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Philippe Mathieu-Daudé
On 11/13/2017 07:35 PM, Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. > > find ./* -type f -exec sed -i \ > 'N;N;N;N;N;N;N;N;N;N;N;N; {s|

Re: [Qemu-devel] [PATCH for-2.11] xics/kvm: synchonize state before 'info pic'

2017-11-13 Thread David Gibson
On Mon, Nov 13, 2017 at 08:42:39PM +0100, Greg Kurz wrote: > When using the emulated XICS, the 'info pic' monitor command shows: > > CPU 0 XIRR=ff00 ((nil)) PP=ff MFRR=ff > ICS 1000..13ff 0x10040060340 > 1000 MSI 05 00 > 1001 MSI 05 00 > 1002 MSI 05 00 > 1003 MSI ff 00 > 1004 LSI ff

Re: [Qemu-devel] [PATCH v8 04/14] block/dirty-bitmap: add bdrv_dirty_bitmap_set_frozen

2017-11-13 Thread John Snow
On 10/30/2017 12:32 PM, Vladimir Sementsov-Ogievskiy wrote: > Make it possible to set bitmap 'frozen' without a successor. > This is needed to protect the bitmap during outgoing bitmap postcopy > migration. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/block/dirty-bitmap.h |

Re: [Qemu-devel] how do we determine correct guest PC for segfaults in atomic helpers for linux-user mode?

2017-11-13 Thread Richard Henderson
On 11/13/2017 08:59 PM, Peter Maydell wrote: > I've been investigating a bug (a javac crash). I'm not sure if it's > the root cause, but I can't figure out how, if we get a guest SEGV in > an atomic helper we report the right faulting PC to the guest. > > Specifically, if you get a SEGV here: > >

Re: [Qemu-devel] [PULL 0/3] Vga 20171110 patches

2017-11-13 Thread Peter Maydell
On 10 November 2017 at 13:26, Gerd Hoffmann wrote: > The following changes since commit b0fbe46ad82982b289a44ee2495b59b0bad8a842: > > Update version for v2.11.0-rc0 release (2017-11-07 16:05:28 +) > > are available in the git repository at: > > git://git.kraxel.org/qemu tags/vga-20171110-p

Re: [Qemu-devel] how do we determine correct guest PC for segfaults in atomic helpers for linux-user mode?

2017-11-13 Thread Philippe Mathieu-Daudé
Hi Peter, On 11/13/2017 04:59 PM, Peter Maydell wrote: > I've been investigating a bug (a javac crash). I'm not sure if it's > the root cause, but I can't figure out how, if we get a guest SEGV in > an atomic helper we report the right faulting PC to the guest. > > Specifically, if you get a SEGV

[Qemu-devel] [PATCH v5 27/29] hw/xen*: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|I

[Qemu-devel] [PATCH v5 25/29] hw/ssi: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|I

Re: [Qemu-devel] [PATCH v5] NUMA: Enable adding NUMA node implicitly

2017-11-13 Thread Michael S. Tsirkin
On Fri, Oct 27, 2017 at 11:15:54AM +0800, Dou Liyang wrote: > Linux and Windows need ACPI SRAT table to make memory hotplug work properly, > however currently QEMU doesn't create SRAT table if numa options aren't > present > on CLI. > > Which breaks both linux and windows guests in certain condit

[Qemu-devel] [PATCH v5 24/29] hw/sparc*: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|I

Re: [Qemu-devel] [PATCH v10 2/8] qemu.py: better control of created files

2017-11-13 Thread Amador Pahim
On 13 Nov 2017 11:24 pm, "Amador Pahim" wrote: To launch a VM, we need to create basically two files: the monitor socket (if it's a UNIX socket) and the qemu log file. For the qemu log file, we currently just open the path, which will create the file if it does not exist or overwrite the file if

[Qemu-devel] [PATCH v5 21/29] hw/s390x: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|I

[Qemu-devel] [PATCH v5 28/29] tcg: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|I

[Qemu-devel] [PATCH v5 17/29] hw/nvram: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|I

[Qemu-devel] [PATCH v5 29/29] target: Use qemu_log() instead of fprintf(stderr, ...)

2017-11-13 Thread Alistair Francis
Signed-off-by: Alistair Francis --- target/cris/translate.c | 2 +- target/ppc/translate.c | 22 +++--- target/sh4/translate.c | 4 ++-- target/unicore32/translate.c | 2 +- 4 files changed, 15 insertions(+), 15 deletions(-) diff --git a/target/cris/translate

[Qemu-devel] [PATCH v5 15/29] hw/moxie: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|I

[Qemu-devel] [PATCH v5 20/29] hw/ppc: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|I

[Qemu-devel] [PATCH v5 12/29] hw/isa: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig

Re: [Qemu-devel] [PATCH v2 0/5] backup improvements part 1

2017-11-13 Thread John Snow
Jeff, I think this ought to go through your tree, but I'll sign off on it. Fam: Do you agree? (Probably -next material, but I'm sending this email because I'm taking it out of my review queue and I don't want it to get lost.) --js On 10/12/2017 09:53 AM, Vladimir Sementsov-Ogievskiy wrote: > Hi

[Qemu-devel] [PATCH v5 02/29] Replace all occurances of __FUNCTION__ with __func__

2017-11-13 Thread Alistair Francis
Replace all occurs of __FUNCTION__ except for the check in checkpatch with the non GCC specific __func__. One line in hcd-musb.c was manually tweaked to pass checkpatch. Signed-off-by: Alistair Francis Cc: Gerd Hoffmann Cc: Andrzej Zaborowski Cc: Stefano Stabellini Cc: Anthony Perard Cc: Joh

[Qemu-devel] [PATCH v5 13/29] hw/lm32: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|I

[Qemu-devel] [PATCH v5 26/29] hw/timer: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|I

[Qemu-devel] [PATCH v5 23/29] hw/sd: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|I

[Qemu-devel] [PATCH v5 04/29] hw/arm: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|I

[Qemu-devel] [PATCH v5 19/29] hw/pci*: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|I

[Qemu-devel] [PATCH v5 22/29] hw/scsi: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|I

[Qemu-devel] [PATCH v5 18/29] hw/openrisc: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|I

[Qemu-devel] [PATCH v5 05/29] hw/dma: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|I

[Qemu-devel] [PATCH v5 16/29] hw/nios2: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|I

[Qemu-devel] [PATCH v5 14/29] hw/mips: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|I

[Qemu-devel] [PATCH v5 06/29] hw/gpio: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|I

[Qemu-devel] [PATCH v5 09/29] hw/ide: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|I

[Qemu-devel] [PATCH v5 11/29] hw/ipmi: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|I

Re: [Qemu-devel] [PATCH for-2.11] hw/net/vmxnet3: Fix code to work on big endian hosts, too

2017-11-13 Thread Philippe Mathieu-Daudé
Hi Thomas, On 11/13/2017 01:57 PM, Thomas Huth wrote: > Since commit ab06ec43577177a442e8 we test the vmxnet3 device in the > pxe-tester, too (when running "make check SPEED=slow"). This now > revealed that the vmxnet3 code is not working right if the host is a big > endian machine (for example pp

[Qemu-devel] [PATCH v5 07/29] hw/i2c: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|I

[Qemu-devel] [PATCH v5 10/29] hw/intc: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig

[Qemu-devel] [PATCH v5 00/29] Remove some of the fprintf(stderr, "*

2017-11-13 Thread Alistair Francis
This is a smaller version of my original series, to hopefully get something merged (although it's getting late for 2.11 now). Continue on improving QEMUs logging/error messages by removing more fprintf()'s. Unfortunatley my Coccinelle skills aren't that great so it's all done in some nasty regex

[Qemu-devel] [PATCH v5 03/29] Fixes after renaming __FUNCTION__ to __func__

2017-11-13 Thread Alistair Francis
Signed-off-by: Alistair Francis Cc: Eric Blake Reviewed-by: Eric Blake --- V3: - Squash onto single lines - Don't fix indentation of case in omap_prcm_apll_update() hw/arm/omap1.c | 8 +++- hw/block/onenand.c | 2 +- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/hw/a

[Qemu-devel] [PATCH v5 01/29] audio: Replace AUDIO_FUNC with __func__

2017-11-13 Thread Alistair Francis
Apparently we don't use __MSC_VER as a compiler anymore and we always require a C99 compiler (which means we always have __func__) so we don't need a special AUDIO_FUNC macro. We can just replace AUDIO_FUNC with __func__ instead. Checkpatch failures were manually fixed. Signed-off-by: Alistair Fr

[Qemu-devel] [PATCH v10 8/8] qemu.py: don't launch again before shutdown()

2017-11-13 Thread Amador Pahim
If a VM is launched, files are created and a cleanup is required before a new launch. This cleanup is executed by shutdown(), so shutdown() must be called even if the VM is manually terminated (i.e. using kill). This patch creates a control to make sure launch() will not be executed again if shutd

[Qemu-devel] [PATCH v10 5/8] qemu.py: use poll() instead of 'returncode'

2017-11-13 Thread Amador Pahim
The 'returncode' Popen attribute is not guaranteed to be updated. It actually depends on a call to either poll(), wait() or communicate(). On the other hand, poll() will: "Check if child process has terminated. Set and return returncode attribute." Let's use the poll() to check whether the proces

[Qemu-devel] [PATCH v10 7/8] qemu.py: launch vm only if it's not running

2017-11-13 Thread Amador Pahim
If we allow launching VM again we will loose track of the first launched VM. Reviewed-by: Fam Zheng Signed-off-by: Amador Pahim --- scripts/qemu.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scripts/qemu.py b/scripts/qemu.py index df2fca9e71..ab172c3670 100644 --- a/scripts/qemu.py

[Qemu-devel] [PATCH v10 6/8] qemu.py: cleanup redundant calls in launch()

2017-11-13 Thread Amador Pahim
Now that shutdown() is guaranteed to always execute self._load_io_log() and self._post_shutdown(), their calls in 'except' became redundant and we can safely replace it by a call to shutdown(). Reviewed-by: Fam Zheng Signed-off-by: Amador Pahim --- scripts/qemu.py | 6 +- 1 file changed, 1

[Qemu-devel] [PATCH v10 4/8] qemu.py: always cleanup on shutdown()

2017-11-13 Thread Amador Pahim
Currently we only cleanup on shutdown() if the VM is running. To make sure we will always cleanup, this patch makes the self._load_io_log() and the self._post_shutdown() to always be called on shutdown(), regardless the VM running state. Reviewed-by: Fam Zheng Signed-off-by: Amador Pahim --- s

[Qemu-devel] [PATCH v10 2/8] qemu.py: better control of created files

2017-11-13 Thread Amador Pahim
To launch a VM, we need to create basically two files: the monitor socket (if it's a UNIX socket) and the qemu log file. For the qemu log file, we currently just open the path, which will create the file if it does not exist or overwrite the file if it does exist. For the monitor socket, if it al

[Qemu-devel] [PATCH v10 0/8] scripts/qemu.py fixes and cleanups

2017-11-13 Thread Amador Pahim
Changes v1->v2: - Style fixes to make checkpatch.pl happy. - Rebased. Changes v2->v3: - Fix typo in patch 3 ("qemu.py: make 'args' public") commit message. Changes v3->v4: - Squash the 2 first commits since they are co-dependant. - Cleanup launch() and shutdown(). - Reorder the commits, putti

[Qemu-devel] [PATCH v10 3/8] qemu.py: refactor launch()

2017-11-13 Thread Amador Pahim
This is just an refactor to separate the exception handler from the actual launch procedure, improving the readability and making future maintenances in this piece of code easier. Reviewed-by: Fam Zheng Signed-off-by: Amador Pahim --- scripts/qemu.py | 29 ++--- 1 file c

[Qemu-devel] [PATCH v10 1/8] qemu.py: remove unused import

2017-11-13 Thread Amador Pahim
Removing 'import sys' as it's not used anywhere. Signed-off-by: Amador Pahim --- scripts/qemu.py | 1 - 1 file changed, 1 deletion(-) diff --git a/scripts/qemu.py b/scripts/qemu.py index 9bfdf6d37d..65d9ad688c 100644 --- a/scripts/qemu.py +++ b/scripts/qemu.py @@ -15,7 +15,6 @@ import errno i

Re: [Qemu-devel] [PATCH v8 03/14] block/dirty-bitmap: add bdrv_dirty_bitmap_release_successor

2017-11-13 Thread John Snow
On 10/30/2017 12:32 PM, Vladimir Sementsov-Ogievskiy wrote: > To just release successor and unfreeze bitmap without any additional > work. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: Denis V. Lunev > --- > include/block/dirty-bitmap.h | 2 ++ > block/dirty-bitmap.c

  1   2   3   4   >