On 2017年11月08日 15:41, Stefan Priebe - Profihost AG wrote:
Hi Paolo,
Am 06.11.2017 um 12:27 schrieb Paolo Bonzini:
On 06/11/2017 12:09, Stefan Priebe - Profihost AG wrote:
HI Paolo,
could this patchset be related?
Uh oh, yes it should. Jason, any ways to fix it? I suppose we need to
disab
Eric Blake writes:
> On 11/07/2017 04:12 AM, Markus Armbruster wrote:
>> Juan Quintela writes:
>>
>>> Alistair Francis wrote:
Replace all occurs of __FUNCTION__ except for the check in checkpatch
with the non GCC specific __func__.
>
+++ b/audio/audio_int.h
@@ -253,7 +
Thomas Huth writes:
> On 31.10.2017 19:33, Peter Maydell wrote:
>> (cc Markus because I know how much he likes weirdnesses in our
>> command line parsing :-))
Heh!
Let me give you a guided tour to this corner of the CLI swamp :)
>> https://stackoverflow.com/questions/46955244/qemu-run-arm-ubun
On Wed, Nov 08, 2017 at 01:30:04PM +1100, Alexey Kardashevskiy wrote:
> On 08/11/17 00:18, Seeteena Thoufeek wrote:
> > The function spapr_phb_vfio_get_loc_code uses wrong path for
> > fetching loc-code from host DT
> >
> > this is the call that needs to be fixed:
> > /* Construct and read from ho
On Tue, Nov 07, 2017 at 03:57:08PM +0800, Fam Zheng wrote:
> On Mon, 11/06 17:46, Peter Xu wrote:
> > @@ -4294,6 +4366,11 @@ static GMainContext *monitor_io_context_get(void)
> > return iothread_get_g_main_context(mon_global.mon_iothread);
> > }
> >
> > +static AioContext *monitor_aio_conte
On Tue, Nov 07, 2017 at 03:11:31PM +0800, Fam Zheng wrote:
> On Mon, 11/06 17:46, Peter Xu wrote:
> > +static GMainContext *monitor_io_context_get(void)
> > +{
> > +return iothread_get_g_main_context(mon_global.mon_iothread);
> > +}
> > +
> > +static void monitor_iothread_init(void)
> > +{
> >
Ticket have to been closed
2017-10-28 16:54 GMT+03:00 Thomas Huth <1268...@bugs.launchpad.net>:
> Triaging old bug tickets... can you still reproduce this issue with the
> latest version of QEMU? Or could we close this ticket nowadays?
>
> ** Changed in: qemu
>Status: New => Incomplete
>
Hi Eduardo
On Tue, Nov 7, 2017 at 5:53 PM, Eduardo Habkost wrote:
> On Tue, Nov 07, 2017 at 05:40:17PM +0100, Marc-André Lureau wrote:
>> Hi,
>>
>> I am working on a TPM CRB device (last sent version:
>> https://lists.gnu.org/archive/html/qemu-devel/2017-10/msg02014.html).
>> It's a sysbus device
Hi Paolo,
Am 06.11.2017 um 12:27 schrieb Paolo Bonzini:
> On 06/11/2017 12:09, Stefan Priebe - Profihost AG wrote:
>> HI Paolo,
>>
>> could this patchset be related?
>
> Uh oh, yes it should. Jason, any ways to fix it? I suppose we need to
> disable UFO in the newest machine types, but do we al
在 2017/11/8 3:35, Eric Blake 写道:
On 11/07/2017 05:00 AM, QingFeng Hao wrote:
+
+##
+# @GuestPanicInformationS390:
+#
+# S390 specific guest panic information (PSW)
+#
+# Since: 2.11
+##
+{'struct': 'GuestPanicInformationS390',
+ 'data': { 'psw-mask': 'uint64',
+ 'psw-addr': 'uint64'
Commit b7a745d added a qemu_bh_cancel call to the completion function
as an optimization to prevent it from unnecessarily rescheduling itself.
This completion function is scheduled from worker_thread, after setting
the state of a ThreadPoolElement to THREAD_DONE.
This was considered to be safe, a
Hi Fam,
On Wed, Nov 8, 2017 at 2:29 AM, Fam Zheng wrote:
>>I/O thread | worker thread
>
> Isn't the left column "workder thread" and the right one "I/O thread"?
>
Yes, you're right. I'm going to switch them back.
Thanks,
Sergio.
It is used to manually trigger the postcopy pause state. It works just
like when we found the migration stream failed during postcopy, but
provide an explicit way for user in case of misterious socket hangs.
Signed-off-by: Peter Xu
---
migration/migration.c | 18 ++
qapi/migrati
HMP version of QMP "migrate-pause".
Signed-off-by: Peter Xu
---
hmp-commands.hx | 14 ++
hmp.c | 9 +
hmp.h | 1 +
3 files changed, 24 insertions(+)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index ffcdc34652..0c9f0cc4f2 100644
--- a/hmp-commands.hx
migrate_incoming command is previously only used when we were providing
"-incoming defer" in the command line, to defer the incoming migration
channel creation.
However there is similar requirement when we are paused during postcopy
migration. The old incoming channel might have been destroyed alr
Switch the state until we try to start the VM on destination side. The
problem is that without doing this we may have a very small window that
we'll be in such a state:
- dst VM is in postcopy-active state,
- main thread is handling MIG_CMD_PACKAGED message, which loads all the
device states,
-
Introducing new return path message MIG_RP_MSG_RECV_BITMAP to send
received bitmap of ramblock back to source.
This is the reply message of MIG_CMD_RECV_BITMAP, it contains not only
the header (including the ramblock name), and it was appended with the
whole ramblock received bitmap on the destina
Allow to return the task tag in fd_start_incoming_migration().
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Peter Xu
---
migration/fd.c | 18 +++---
migration/fd.h | 2 +-
2 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/migration/fd.c b/migration/fd.c
index 30
On the destination side, we cannot wake up all the threads when we got
reconnected. The first thing to do is to wake up the main load thread,
so that we can continue to receive valid messages from source again and
reply when needed.
At this point, we switch the destination VM state from postcopy-p
Freeing the SocketAddress struct in socket_start_incoming_migration is
slightly confusing. Let's free the address in the same context where we
allocated it.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Peter Xu
---
migration/socket.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(
Introducing new migration state "postcopy-recover". If a migration
procedure is paused and the connection is rebuilt afterward
successfully, we'll switch the source VM state from "postcopy-paused" to
the new state "postcopy-recover", then we'll do the resume logic in the
migration thread (along wit
Return the async task tag for exec typed incoming migration in
exec_start_incoming_migration().
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Peter Xu
---
migration/exec.c | 18 +++---
migration/exec.h | 2 +-
2 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/mig
After we updated the dirty bitmaps of ramblocks, we also need to update
the critical fields in RAMState to make sure it is ready for a resume.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Peter Xu
---
migration/ram.c| 37 -
migration/trace-event
Store the task tag for migration types: tcp/unix/fd/exec in current
MigrationIncomingState struct.
For defered migration, no need to store task tag since there is no task
running in the main loop at all. For RDMA, let's mark it as todo.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Peter Xu
Let the thread pause for network issues.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Peter Xu
---
migration/migration.c | 35 +--
migration/migration.h | 1 +
migration/trace-events | 2 ++
3 files changed, 36 insertions(+), 2 deletions(-)
diff --git
This patch implements the first part of core RAM resume logic for
postcopy. ram_resume_prepare() is provided for the work.
When the migration is interrupted by network failure, the dirty bitmap
on the source side will be meaningless, because even the dirty bit is
cleared, it is still possible that
This patch detects the "resume" flag of migration command, rebuild the
channels only if the flag is set.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Peter Xu
---
migration/migration.c | 92 ++-
1 file changed, 69 insertions(+), 23 deletions
Finish the last step to do the final handshake for the recovery.
First source sends one MIG_CMD_RESUME to dst, telling that source is
ready to resume.
Then, dest replies with MIG_RP_MSG_RESUME_ACK to source, telling that
dest is ready to resume (after switch to postcopy-active state).
When sourc
For socket based incoming migration, we attached a background task onto
main loop to handle the acception of connections. We never had a way to
destroy it before, only if we finished the migration.
Let's allow socket_start_incoming_migration() to return the source tag
of the listening async work,
Now when network down for postcopy, the source side will not fail the
migration. Instead we convert the status into this new paused state, and
we will try to wait for a rescue in the future.
If a recovery is detected, migration_thread() will reset its local
variables to prepare for that.
Reviewed
Introducing this new command to be sent when the source VM is ready to
resume the paused migration. What the destination does here is
basically release the fault thread to continue service page faults.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Peter Xu
---
migration/savevm.c | 35
This is hook function to be called when a postcopy migration wants to
resume from a failure. For each module, it should provide its own
recovery logic before we switch to the postcopy-active state.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Peter Xu
---
include/migration/register.h | 2
Though we may not need it, now we init both the src/dst migration
objects in migration_object_init() so that even incoming migration
object would be thread safe (it was not).
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Peter Xu
---
migration/migration.c | 28 +++-
Let the callers take the object, then pass it to migrate_init().
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Peter Xu
---
migration/migration.c | 7 ++-
migration/migration.h | 2 +-
migration/savevm.c| 5 -
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/migra
Allows the fault thread to stop handling page faults temporarily. When
network failure happened (and if we expect a recovery afterwards), we
should not allow the fault thread to continue sending things to source,
instead, it should halt for a while until the connection is rebuilt.
When the dest ma
We will not allow failures to happen when sending data from destination
to source via the return path. However it is possible that there can be
errors along the way. This patch allows the migrate_send_rp_message()
to return error when it happens, and further extended it to
migrate_send_rp_req_page
Add a new vm command MIG_CMD_RECV_BITMAP to request received bitmap for
one ramblock.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Peter Xu
---
migration/savevm.c | 61 ++
migration/savevm.h | 1 +
migration/trace-events | 2 ++
3
Creating new message to reply for MIG_CMD_POSTCOPY_RESUME. One uint32_t
is used as payload to let the source know whether destination is ready
to continue the migration.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Peter Xu
---
migration/migration.c | 37 +
When there is IO error on the incoming channel (e.g., network down),
instead of bailing out immediately, we allow the dst vm to switch to the
new POSTCOPY_PAUSE state. Currently it is still simple - it waits the
new semaphore, until someone poke it for another attempt.
Signed-off-by: Peter Xu
---
Introducing a new state "postcopy-paused", which can be used when the
postcopy migration is paused. It is targeted for postcopy network
failure recovery.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Peter Xu
---
migration/migration.c | 2 ++
qapi/migration.json | 5 -
2 files change
A general helper to notify the fault thread.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Peter Xu
---
migration/postcopy-ram.c | 35 ---
migration/postcopy-ram.h | 2 ++
2 files changed, 22 insertions(+), 15 deletions(-)
diff --git a/migration/postcopy-r
Tree is pushed here for better reference and testing:
github.com/xzpeter postcopy-recovery-support
Please review, thanks.
v4:
- fix two compile errors that patchew reported
- for QMP: do s/2.11/2.12/g
- fix migrate-incoming logic to be more strict
v3:
- add r-bs correspondingly
- in ram_load_p
It will be used when we want to resume one paused migration.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Peter Xu
---
hmp-commands.hx | 7 ---
hmp.c | 4 +++-
migration/migration.c | 2 +-
qapi/migration.json | 5 -
4 files changed, 12 insertions(+), 6 del
It was only used for quitting the page fault thread before. Let it be
something more useful - now we can use it to notify a "wake" for the
page fault thread (for any reason), and it only means "quit" if the
fault_thread_quit is set.
Since we changed what it does, renaming it to userfault_event_fd.
If the postcopy down due to some reason, we can always see this on dst:
qemu-system-x86_64: RP: Received invalid message 0x length 0x
However in most cases that's not the real issue. The problem is that
qemu_get_be16() has no way to show whether the returned data is valid or
not, and we
On 07.11.2017 21:52, Michael Roth wrote:
> The u-boot sources we ship currently cause problems with unpacking on
> a case-insensitive filesystem due to path conflicts. This has been
> fixed in upstream u-boot via commit 610eec7f, but since it is not
> yet included in an official release we implemen
Hi Jeff,
On 11/07/2017 07:27 PM, Jeff Cody wrote:
"Missed in 1bff9606429."
> Signed-off-by: Jeff Cody
Reviewed-by: Philippe Mathieu-Daudé
> ---
> block/curl.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/block/curl.c b/block/curl.c
> index 00a9879..35cf417 100644
> --- a/
Hi Alistair,
On 11/07/2017 10:10 PM, Alistair Francis wrote:
> When cross compiling QEMU for Windows we need to specify the cross
What toolchain do you use?
> version of ranlib to avoid build errors when buildling capstone. This
"building"
> patch ensures we use the same cross prefix on ranlib
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1196426
Title:
Setup virtu
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1060928
Title:
Error in la
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1061778
Title:
signal mask
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1178101
Title:
Could not e
On 11/07/2017 11:28 PM, Philippe Mathieu-Daudé wrote:
> Deprecated since 2.9.0, guests should be able to use "pc" instead.
I forgot to add Paolo's comment:
"but firmware code paths would be different, do we care?"
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/i386/pc_piix.c | 1 +
> 1
Hi Alexey,
On 11/07/2017 11:48 PM, Alexey Kardashevskiy wrote:
> On 08/11/17 13:28, Philippe Mathieu-Daudé wrote:
>> Both are deprecated since 2.9.0
>
> May be so but I could not find where this happened in git history:
>
> [vpl1 qemu]$ git log -n1 --grep 'pc-0.10'
> f6d5a0bad2 2 years, 5 months
The ASPEED hardware contains a lock register for the SCU that disables
any writes to the SCU when it is locked. The machine comes up with the
lock enabled, but on all known hardware u-boot will unlock it and leave
it unlocked when loading the kernel.
This means the kernel expects the SCU to be unl
Using obscure black magic introduced in eaa2ddbb767 :)
In an out-of-tree directory, running "../configure && make help" will generate
some required files (.mak), then clone some submodules, compile at least
the capstone submodule, generate QMP and Trace files, and finally display
the help.
On an
On Tue, 11/07 23:47, Philippe Mathieu-Daudé wrote:
> In Makefiles the $ must be escaped as $$ in shell uses.
>
> Since 8a2390a4f47:
>
> $ make docker
> [...]
> NETWORK=1Enable virtual network interface with default
> backend.
> NETWORK=ACKEND Enable virtual networ
>I have the modified patch staged here:
>
> https://github.com/mdroth/qemu/commit/de597a8b27722ce4f9cc660f930f7dccc712712d>Let
> me know if it looks okay and I'll send a pull request for rc1
the code right, but running QGA on the Windows XP, error: can not find the link
to GetIfEntry2
On 08/11/17 13:28, Philippe Mathieu-Daudé wrote:
> Both are deprecated since 2.9.0
May be so but I could not find where this happened in git history:
[vpl1 qemu]$ git log -n1 --grep 'pc-0.10'
f6d5a0bad2 2 years, 5 months ago Eduardo Habkost piix: Define PC_COMPAT_0_10
Having some pointers in the
In Makefiles the $ must be escaped as $$ in shell uses.
Since 8a2390a4f47:
$ make docker
[...]
NETWORK=1Enable virtual network interface with default backend.
NETWORK=ACKEND Enable virtual network interface with ACKEND.
Once escaped:
$ make docker
[...]
On 08/11/17 00:18, Seeteena Thoufeek wrote:
> The function spapr_phb_vfio_get_loc_code uses wrong path for
> fetching loc-code from host DT
>
> this is the call that needs to be fixed:
> /* Construct and read from host device tree the loc-code */
> path = g_strdup_printf("/proc/device-tree%s/ibm,l
Deprecated since 2.9.0, guests should be able to use "pc" instead.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/i386/pc_piix.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index c462b702ff..df4669c6d3 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_pi
It is obsoleted by the "40p" machine.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/ppc/prep.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c
index 6f8accc397..c032ec3af1 100644
--- a/hw/ppc/prep.c
+++ b/hw/ppc/prep.c
@@ -682,6 +682,7 @@ static void prep_machine
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/gumstix.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/arm/gumstix.c b/hw/arm/gumstix.c
index bba9e9f57a..160f7f089c 100644
--- a/hw/arm/gumstix.c
+++ b/hw/arm/gumstix.c
@@ -129,6 +129,7 @@ static void connex_class_init(ObjectClass *oc,
Both are deprecated since 2.9.0
Signed-off-by: Philippe Mathieu-Daudé
---
hw/i386/pc_piix.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index f79d5cb694..c462b702ff 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -941,6 +941,7 @@ static v
If a machine has the deprecated_reason property set:
- it won't get listed anymore by the "-M help" command,
- a warning will be displayed if the machine is used.
Example:
$ ppc-softmmu/qemu-system-ppc -M prep
qemu-system-ppc: -M prep: warning: The PowerPC PREP platform machine is
deprecated
From: Alistair Francis
The EP108 was an early access development board that is no longer used.
Add an info message to convert any users to the ZCU102 instead. On QEMU
they are both identical.
Signed-off-by: Alistair Francis
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/xlnx-zcu102.c | 6 ++
Hi,
This series intends to provide a simple and common way to deprecate
machines between releases. It may be extended to deprecate devices.
I started with the machines list from:
https://wiki.qemu.org/Features/LegacyRemoval#Deprecated_machines
Comment welcomed :)
Regards,
Phil.
Alistair Fr
On 07/11/17 21:12, Daniel P. Berrange wrote:
> On Tue, Nov 07, 2017 at 04:13:27PM +1100, Alexey Kardashevskiy wrote:
>> On 07/11/17 15:12, Alexey Kardashevskiy wrote:
>>> On 04/11/17 02:33, Daniel P. Berrange wrote:
We short circuit the git submodule update when passed an empty module list.
>>
Hi Sergio,
On Tue, 11/07 23:54, Sergio Lopez wrote:
> Commit b7a745d added a qemu_bh_cancel call to the completion function
> as an optimization to prevent it from unnecessarily rescheduling itself.
>
> This completion function is scheduled from worker_thread, after setting
> the state of a Threa
When cross compiling QEMU for Windows we need to specify the cross
version of ranlib to avoid build errors when buildling capstone. This
patch ensures we use the same cross prefix on ranlib as other toolchain
components.
Signed-off-by: Alistair Francis
Suggested-by: Peter Maydell
---
Makefile
在 2017-11-08 03:43:20，"Michael Roth" 写道：
>Quoting Michael Roth (2017-11-07 11:06:55)
>> Quoting Chen Hanxiao (2017-11-07 05:37:16)
>> > From: Chen Hanxiao
>> >
>> > s/Subection/Subsection
>> >
>> > Reviewed-by: Marc-André Lureau
>> > Signed-off-by: Chen Hanxiao
>>
>> Thanks, applied to qg
On 11/07/2017 04:27 PM, Jeff Cody wrote:
> Signed-off-by: Jeff Cody
> ---
> block/curl.c | 6 ++
> 1 file changed, 6 insertions(+)
Reviewed-by: Eric Blake
>
> diff --git a/block/curl.c b/block/curl.c
> index 00a9879..35cf417 100644
> --- a/block/curl.c
> +++ b/block/curl.c
> @@ -857,6 +85
On Mon, Nov 06, 2017 at 11:37:45AM +, Peter Maydell wrote:
> On 6 November 2017 at 00:53, Brad Smith wrote:
> > OpenBSD/i386 uses elf_i386_obsd for the emulation linker.
> >
> > Signed-off-by: Brad Smith
> >
> >
> > diff --git a/configure b/configure
> > index dd73cce62f..02799d38ac 100755
>
OpenBSD/i386 uses elf_i386_obsd for the emulation linker.
Signed-off-by: Brad Smith
diff --git a/configure b/configure
index dd73cce62f..c9dd747283 100755
--- a/configure
+++ b/configure
@@ -5159,9 +5159,9 @@ if test \( "$cpu" = "i386" -o "$cpu" = "x86_64" \) -a \
"$targetos" != "Darwi
On Mon, Oct 23, 2017 at 12:26 AM, Alistair Francis wrote:
> On Wed, Oct 18, 2017 at 12:31 AM, Alistair Francis
> wrote:
>> There are numorous QEMU machines that only have a single or a handful of
>> valid CPU options. To simplyfy the management of specificying which CPU
>> is/isn't valid let's cr
On Tue, Nov 7, 2017 at 9:53 AM, Peter Maydell wrote:
> On 7 November 2017 at 17:52, Alistair Francis wrote:
>> On Fri, Nov 3, 2017 at 6:40 AM, Gerd Hoffmann wrote:
>>> Hi,
>>>
> "x86_64-w64-mingw32-ar --version" says "GNU ar (GNU Binutils) 2.25"
Hmm, I guess this 'ar' isn't capa
On 07/11/17 21:12, Daniel P. Berrange wrote:
> On Tue, Nov 07, 2017 at 04:13:27PM +1100, Alexey Kardashevskiy wrote:
>> On 07/11/17 15:12, Alexey Kardashevskiy wrote:
>>> On 04/11/17 02:33, Daniel P. Berrange wrote:
We short circuit the git submodule update when passed an empty module list.
>>
Commit b7a745d added a qemu_bh_cancel call to the completion function
as an optimization to prevent it from unnecessarily rescheduling itself.
This completion function is scheduled from worker_thread, after setting
the state of a ThreadPoolElement to THREAD_DONE.
This was considered to be safe, a
On 07/11/17 19:42, Laurent Vivier wrote:
> On 05/07/2016 07:31, David Gibson wrote:
>> From: Alexey Kardashevskiy
>>
>> This adds support for Dynamic DMA Windows (DDW) option defined by
>> the SPAPR specification which allows to have additional DMA window(s)
>>
>> The "ddw" property is enabled by
On 11/07/2017 04:27 PM, Jeff Cody wrote:
> We don't need libssh2 failure to be fatal (we could just opt to not
> register the driver on failure). But, it is probably a good idea to
> avoid external library calls during the block_init(), and call the
> libssh2 global init function on the first usage
> That patch would prevent us from picking up a legitimate ld.so.cache for the
> guest (in a chroot, for instance), so I don't think we should take it.
But in a chroot, QEMU_LD_PREFIX is most likely NOT set. So how about this
pseudocode?
if (strcmp (pathname, "/etc/ld.so.cache") == 0 && getenv
co_sleep_ns() was removed in commit 0b9caf9b, leaving behind a
stale comment. Update the documentation to match the current
usage of this function.
Suggested-by: Paolo Bonzini
Signed-off-by: Eric Blake
---
include/qemu/coroutine.h | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
d
On 11/06/2017 08:53 AM, Alberto Garcia wrote:
> bdrv_close() skips much of its logic when bs->drv is NULL. This is
> fine when we're closing a BlockDriverState that has just been created
> (because e.g the initialization process failed), but it's not enough
> in other cases.
>
> For example, when
This addresses non-functional changes to help curl.c better comply
with the coding styles (comments, indentation, brackets, etc.).
One minor code change is the combination of two if statements into
a single if statement.
Signed-off-by: Jeff Cody
Reviewed-by: Eric Blake
---
block/curl.c | 100 +
We don't need libssh2 failure to be fatal (we could just opt to not
register the driver on failure). But, it is probably a good idea to
avoid external library calls during the block_init(), and call the
libssh2 global init function on the first usage, returning any errors.
Signed-off-by: Jeff Cody
Signed-off-by: Jeff Cody
Reviewed-by: Eric Blake
---
block/ssh.c | 32 ++--
1 file changed, 18 insertions(+), 14 deletions(-)
diff --git a/block/ssh.c b/block/ssh.c
index de81ec8..39cacc1 100644
--- a/block/ssh.c
+++ b/block/ssh.c
@@ -241,7 +241,7 @@ static int parse
If curl_global_init() fails, per the documentation no other curl
functions may be called, so make sure to check the return value.
Also, some minor changes to the initialization latch variable 'inited':
- Make it static in the file, for clarity
- Change the name for clarity
- Make it a bool
Signe
No functional changes, just whitespace manipulation.
Signed-off-by: Jeff Cody
Reviewed-by: Eric Blake
---
block/sheepdog.c | 164 +++
1 file changed, 82 insertions(+), 82 deletions(-)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index 459
Signed-off-by: Jeff Cody
---
block/curl.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/block/curl.c b/block/curl.c
index 00a9879..35cf417 100644
--- a/block/curl.c
+++ b/block/curl.c
@@ -857,6 +857,9 @@ out_noclean:
qemu_mutex_destroy(&s->mutex);
g_free(s->cookie);
g_f
'tag' is already checked in the lines immediately preceding this check,
and set to non-NULL if NULL. No need to check again, it hasn't changed.
Signed-off-by: Jeff Cody
Reviewed-by: Eric Blake
---
block/sheepdog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/sheepd
Changes from v2 -> v3:
Patch 1: Return -EIO for ssh_state_init() (Thanks Eric)
Patch 4: fixed missed line (Thanks Eric)
Patch 7: fixed opaque pointer assignment (Thanks Eric)
git-backport-diff -r master.. -u 81fb084
001/7:[0007] [FC] 'block/ssh: don't call libssh2_init() in block_init()'
002/7:[
That patch would prevent us from picking up a legitimate ld.so.cache for
the guest (in a chroot, for instance), so I don't think we should take
it. (I'm also not a fan of trying to work around specific guest code
issues: I'd much rather this was just fixed in ld.so where it ought to
be, so I'd enco
you
identified as a different issue):
$ QEMU_LD_PREFIX=/usr/sparc64-linux-gnu
~/inst-qemu/2.10+-20171107/bin/qemu-sparc64 hello.sparc64
Hello world
$ QEMU_LD_PREFIX=/usr/mips-linux-gnu ~/inst-qemu/2.10+-20171107/bin/qemu-mips
hello.mips
Hello world
$ QEMU_LD_PREFIX=/usr/mips64-linux-gnuabi64
~/inst-qem
Great, thanks!
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1725267
Title:
armeb regression since qemu version 2.8
Status in QEMU:
Fix Committed
Bug description:
Hi,
I have noticed a regr
c64
hello.sparc64
Segmentation fault (core dumped)
$ QEMU_LD_PREFIX=/usr/sparc64-linux-gnu
~/inst-qemu/2.10+-20171107/bin/qemu-sparc64 hello.sparc64
Segmentation fault (core dumped)
$ QEMU_LD_PREFIX=/usr/mips-linux-gnu ~/inst-qemu/2.9.0/bin/qemu-mips hello.mips
qemu: uncaught target signal
The u-boot sources we ship currently cause problems with unpacking on
a case-insensitive filesystem due to path conflicts. This has been
fixed in upstream u-boot via commit 610eec7f, but since it is not
yet included in an official release we implement this approach as a
temporary workaround.
Once
Fixes the following warning when compiling with gcc 5.4.0 with -O1
optimizations and --enable-debug:
target/arm/translate-a64.c: In function ‘aarch64_tr_translate_insn’:
target/arm/translate-a64.c:2361:8: error: ‘post_index’ may be used
uninitialized in this function [-Werror=maybe-uninitialized]
Some times it's still puzzling, when I got the clean git tree still
seeing crash with correct OpenBIOS file.
[root@zzfp365-lp1 test]# git clone git://git.qemu.org/qemu.git
Cloning into 'qemu'...
remote: Counting objects: 349636, done.
remote: Compressing objects: 100% (66763/66763), done.
remote:
On 11/07/2017 11:26 AM, Kevin Wolf wrote:
> bdrv_set_read_only() is used by some block drivers to override the
> read-only option given by the user. This is not how read-only images
> generally work in QEMU: Instead of second guessing what the user really
> meant (which currently includes making an
1 - 100 of 335 matches
Mail list logo
