[Qemu-devel] [PATCH 15/16] target/xtensa: implement const16

2017-11-03 Thread Max Filippov
const16 is an opcode that shifts 16 lower bits of an address register to the 16 upper bits and puts its immediate operand into the lower 16 bits. It is not controlled by an Xtensa option and doesn't have a fixed opcode. Signed-off-by: Max Filippov --- target/xtensa/translate.c | 14 +

[Qemu-devel] [PATCH 13/16] target/xtensa: implement salt/saltu

2017-11-03 Thread Max Filippov
SALT/SALTU are recent additions to the core Xtensa ISA that do signed/unsigned setcond. Signed-off-by: Max Filippov --- target/xtensa/translate.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c index f644d9fed22a..da1f

[Qemu-devel] [PATCH 11/16] target/xtensa: drop DisasContext::litbase

2017-11-03 Thread Max Filippov
It doesn't help much, always-set bit 0 of the LITBASE SR is easy to compensate with decrement of the l32r immediate argument. Signed-off-by: Max Filippov --- target/xtensa/translate.c | 27 +-- 1 file changed, 5 insertions(+), 22 deletions(-) diff --git a/target/xtensa/t

[Qemu-devel] [PATCH 10/16] target/xtensa: tests: fix memctl SR test

2017-11-03 Thread Max Filippov
memctl SR is not available on dc232b, as it was introduced in more recent hardware release. Now that this information is available through the libisa the test fails. Fix the test. Signed-off-by: Max Filippov --- tests/tcg/xtensa/test_sr.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[Qemu-devel] [PATCH 16/16] target/xtensa: implement disassembler

2017-11-03 Thread Max Filippov
Add disas/xtensa.c and use libisa for instruction decoding/opcode name lookup. Signed-off-by: Max Filippov --- MAINTAINERS | 1 + disas/Makefile.objs | 1 + disas/xtensa.c | 133 include/disas/bfd.h | 1 + target/xtensa/cpu.

[Qemu-devel] [PATCH 12/16] target/xtensa: add internal/noop SRs and opcodes

2017-11-03 Thread Max Filippov
Add two special registers: MMID and DDR: - MMID is write-only and the only side effect of writing to it is output to the trace port, which is not emulated; - DDR is only accessible in debug mode, which is not emulated. Add two debug-mode-only opcodes: - rfdd and rfdo do return from the debug mod

[Qemu-devel] [PATCH 03/16] target/xtensa: extract core opcode translators

2017-11-03 Thread Max Filippov
Move implementations of core opcodes into separate translation functions. Introduce data structures for mapping opcode name to translator function. Make an array of core opcode/translator structures. Signed-off-by: Max Filippov --- target/xtensa/cpu.h | 24 + target/xtensa/translate.c |

[Qemu-devel] [PATCH 14/16] target/xtensa: implement GPIO32

2017-11-03 Thread Max Filippov
GPIO32 is not in the core ISA, but it was widely used in Diamond Cores. This implementation doesn't do actual I/O and doesn't handle the case of GPIO32 state being a part of coprocessor. Signed-off-by: Max Filippov --- target/xtensa/cpu.h | 1 + target/xtensa/translate.c | 53

[Qemu-devel] [PATCH 05/16] target/xtensa: update import_core.sh script for libisa

2017-11-03 Thread Max Filippov
Extract xtensa-modules.c from the overlay, fix up known issues, include it into the core-$NAME.c. Signed-off-by: Max Filippov --- target/xtensa/import_core.sh | 14 ++ 1 file changed, 14 insertions(+) diff --git a/target/xtensa/import_core.sh b/target/xtensa/import_core.sh index ceb

[Qemu-devel] [PATCH 02/16] target/xtensa: import libisa source

2017-11-03 Thread Max Filippov
The canonical way of dealing with Xtensa instructions decoding and encoding is through the libisa. Libisa is a configuration-independent library with a stable interface plus generated configuration-specific xtensa-modules.c file with implementations of decoding and encoding functions. Libisa is MIT

[Qemu-devel] [PATCH 04/16] target/xtensa: extract FPU2000 opcode translators

2017-11-03 Thread Max Filippov
FPU2000 implements basic single-precision floating point operations and can be replaced with a different implementation, like DFPU or HiFi. Move FPU2000 opcode translators into separate functions and list them in a separate array. Signed-off-by: Max Filippov --- target/xtensa/cpu.h | 1 +

[Qemu-devel] [PATCH 09/16] target/xtensa: use libisa for instruction decoding

2017-11-03 Thread Max Filippov
Replace manual opcode analysis with libisa-based code. This makes it possible to support variable-encoding instructions of the core ISA, like const16, and will allow to support advanced Xtensa features, like FLIX and TIE. Signed-off-by: Max Filippov --- target/xtensa/cpu.h |3 + target

[Qemu-devel] [PATCH 01/16] target/xtensa: pass actual frame size to the entry helper

2017-11-03 Thread Max Filippov
Currently 'entry' opcode helper accepts frame size divided by 8, as it is encoded in the opcode. Make it more natural and accept actual frame size instead. Signed-off-by: Max Filippov --- target/xtensa/op_helper.c | 2 +- target/xtensa/translate.c | 2 +- 2 files changed, 2 insertions(+), 2 dele

[Qemu-devel] [PATCH 00/16] target/xtensa: switch to libisa

2017-11-03 Thread Max Filippov
Hello, this series adds libisa to the Xtensa target, changes decoder and instruction translators to use it, switches existing xtensa cores to use it, adds support for a number of new instructions and adds disassembler for Xtensa. Libisa is the canonical way of dealing with Xtensa instructions dec

Re: [Qemu-devel] [PULL 0/3] TCG queued patches

2017-11-03 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 0/3] TCG queued patches Type: series Message-id: 20171103084046.12821-1-richard.hender...@linaro.org === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log -

[Qemu-devel] [Bug 1726394] Re: Passes through prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, address)

2017-11-03 Thread Julian Andres Klode
** Bug watch added: Debian Bug tracker #880582 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=880582 ** Also affects: qemu (Debian) via https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=880582 Importance: Unknown Status: Unknown -- You received this bug notification because yo

[Qemu-devel] [Bug 1726394] Re: Passes through prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, address)

2017-11-03 Thread Julian Andres Klode
** Changed in: qemu (Ubuntu) Status: Triaged => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1726394 Title: Passes through prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, address)

[Qemu-devel] structured reply behavior for read of 0 bytes

2017-11-03 Thread Eric Blake
As currently written, structured reply is documented as: > NBD_REPLY_TYPE_OFFSET_DATA (1) > > This chunk type is in the content chunk category. length MUST be at least 9. > It represents the contents of length - 8 bytes of the file, starting at the > absolute offset from the start of the export

Re: [Qemu-devel] [PATCH] hw: add .min_cpus and .default_cpus fields to machine_class

2017-11-03 Thread Emilio G. Cota
On Fri, Nov 03, 2017 at 21:02:33 +0100, Eduardo Habkost wrote: > On Fri, Nov 03, 2017 at 02:56:10PM -0400, Emilio G. Cota wrote: > > On Fri, Nov 03, 2017 at 14:47:33 -0400, Emilio G. Cota wrote: > > > diff --git a/hw/arm/xlnx-zcu102.c b/hw/arm/xlnx-zcu102.c > > > index e2d15a1..395d1b5 100644 > > >

Re: [Qemu-devel] [Qemu-arm] [PATCH 0/4] softfloat: fix some helper definitions

2017-11-03 Thread Philippe Mathieu-Daudé
> On 11/03/2017 05:26 PM, Laurent Vivier wrote: >> This series fixes some errors found by >> enabling USE_SOFTFLOAT_STRUCT_TYPES. [...] > > I'm getting those errors: > > $ make subdir-arm-softmmu -j2 > > /source/qemu/migration/vmstate-types.c:430:5: error: conversion to > non-scalar type requeste

Re: [Qemu-devel] coroutine question, for NBD debugging

2017-11-03 Thread Eric Blake
On 11/03/2017 03:03 PM, Eric Blake wrote: > In include/qemu/coroutine.h, we have: > > /** > * Yield the coroutine for a given duration > * > * Behaves similarly to co_sleep_ns(), but the sleeping coroutine will be > * resumed when using aio_poll(). > */ > void coroutine_fn co_aio_sleep_ns(Aio

Re: [Qemu-devel] [PATCH v3] softfloat: rename make_float[x80|128]_init to const_float[x80|128]

2017-11-03 Thread Philippe Mathieu-Daudé
On 09/20/2017 10:18 AM, Laurent Vivier wrote: > We already have const_float16(), const_float32() and const_float64(), > so rename make_floatx80_init() and make_float128_init() to now be > const_floatx80() and const_float128(), for consistency. > > Redefine make_float16(), make_float32() and make_f

Re: [Qemu-devel] [Qemu-arm] [PATCH 0/4] softfloat: fix some helper definitions

2017-11-03 Thread Philippe Mathieu-Daudé
Hi Laurent, On 11/03/2017 05:26 PM, Laurent Vivier wrote: > This series fixes some errors found by > enabling USE_SOFTFLOAT_STRUCT_TYPES. > > Most of them are helpers using int types > instead of float types. > This also requires the use of floatXX_val() > and make_floatXX(). > > Laurent Vivier

Re: [Qemu-devel] [PATCH v7 01/13] m25p80: Add support for continuous read out of RDSR and READ_FSR

2017-11-03 Thread mar.krzeminski
W dniu 03.11.2017 o 18:25, francisco iglesias pisze: Hi Marcin, Huge thank you once again! This time not only for reviewing but also for having this patience with me! No problem! I wish you a great wekeend! The same to you, Regards, Marcin Best regards, Francisco Iglesias On 3 Nov 2017

Re: [Qemu-devel] [Qemu-block] [PATCH v2 3/7] qcow2: Prevent allocating compressed clusters at offset 0

2017-11-03 Thread Alberto Garcia
On Fri 03 Nov 2017 09:22:39 PM CET, Alberto Garcia wrote: >>> -assert(offset); >> >> I don't think this assert() was meant as a protection against offset >> being 0. :-) > > After the new check offset is now guaranteed to be 0, so what's the > point of keeping the assert() ? I meant "guara

[Qemu-devel] [PATCH 3/4] tricore: use make_float32() and float32_val()

2017-11-03 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- target/tricore/fpu_helper.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/target/tricore/fpu_helper.c b/target/tricore/fpu_helper.c index 7979bb6692..d233d010c5 100644 --- a/target/tricore/fpu_helper.c ++

[Qemu-devel] [PATCH 4/4] softfloat: use floatXX_val() in XX_minmax()

2017-11-03 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- fpu/softfloat.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 433c5dad2d..331d78e848 100644 --- a/fpu/softfloat.c +++ b/fpu/softfloat.c @@ -7700,11 +7700,9 @@ static inline float ## s float ##

[Qemu-devel] [PATCH 1/4] arm: fix float64 helper definitions

2017-11-03 Thread Laurent Vivier
neon_ceq_f64(), neon_cge_f64() and neon_cgt_f64() take float64 as parameter, fix the definition in helper-a64.h Signed-off-by: Laurent Vivier --- target/arm/helper-a64.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/arm/helper-a64.h b/target/arm/helper-a64.h in

[Qemu-devel] [PATCH 2/4] openrisc: fix float32 and float64 helper definitions

2017-11-03 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- target/openrisc/fpu_helper.c | 52 ++-- target/openrisc/helper.h | 20 - 2 files changed, 36 insertions(+), 36 deletions(-) diff --git a/target/openrisc/fpu_helper.c b/target/openrisc/fpu_helper.c index

[Qemu-devel] [PATCH 0/4] softfloat: fix some helper definitions

2017-11-03 Thread Laurent Vivier
This series fixes some errors found by enabling USE_SOFTFLOAT_STRUCT_TYPES. Most of them are helpers using int types instead of float types. This also requires the use of floatXX_val() and make_floatXX(). Laurent Vivier (4): arm: fix float64 helper definitions openrisc: fix float32 and float6

Re: [Qemu-devel] [PATCH v2 3/7] qcow2: Prevent allocating compressed clusters at offset 0

2017-11-03 Thread Alberto Garcia
On Fri 03 Nov 2017 05:27:59 PM CET, Max Reitz wrote: >> +if (new_cluster == 0) { >> +qcow2_signal_corruption(bs, true, -1, -1, "Preventing >> invalid " >> +"allocation of compressed cluster " >> +

Re: [Qemu-devel] [PATCH v3] softfloat: rename make_float[x80|128]_init to const_float[x80|128]

2017-11-03 Thread Laurent Vivier
Ping? Laurent Le 20/09/2017 à 15:18, Laurent Vivier a écrit : > We already have const_float16(), const_float32() and const_float64(), > so rename make_floatx80_init() and make_float128_init() to now be > const_floatx80() and const_float128(), for consistency. > > Redefine make_float16(), make_fl

Re: [Qemu-devel] [SeaBIOS] seabios serial console vs. sgabios

2017-11-03 Thread Kevin O'Connor
On Thu, Nov 02, 2017 at 05:04:20PM +0100, Gerd Hoffmann wrote: > Hi, > > One problem we have with the serial console support in seabios and > sgabios: It can happen that both are activated. We'll go fix that in > qemu, but that'll work for new qemu versions only, not for the old > already rele

[Qemu-devel] coroutine question, for NBD debugging

2017-11-03 Thread Eric Blake
In include/qemu/coroutine.h, we have: /** * Yield the coroutine for a given duration * * Behaves similarly to co_sleep_ns(), but the sleeping coroutine will be * resumed when using aio_poll(). */ void coroutine_fn co_aio_sleep_ns(AioContext *ctx, QEMUClockType type, but there is no co_sleep_

Re: [Qemu-devel] [PATCH] hw: add .min_cpus and .default_cpus fields to machine_class

2017-11-03 Thread Eduardo Habkost
On Fri, Nov 03, 2017 at 02:56:10PM -0400, Emilio G. Cota wrote: > On Fri, Nov 03, 2017 at 14:47:33 -0400, Emilio G. Cota wrote: > > diff --git a/hw/arm/xlnx-zcu102.c b/hw/arm/xlnx-zcu102.c > > index e2d15a1..395d1b5 100644 > > --- a/hw/arm/xlnx-zcu102.c > > +++ b/hw/arm/xlnx-zcu102.c > > @@ -185,6

Re: [Qemu-devel] [PATCH v3 0/5] Various improvements/bugfixes to submodule handling

2017-11-03 Thread Philippe Mathieu-Daudé
On 11/03/2017 12:33 PM, Daniel P. Berrange wrote: > This short series of patches improves the reliability of the submodule > handling to cope with various dev env scenarios that have since emerged > > v2: https://lists.gnu.org/archive/html/qemu-devel/2017-10/msg06272.html > > Changed in v3: >

[Qemu-devel] [PATCH] linux-user: remove nmi.c and fw-path-provider.c

2017-11-03 Thread Laurent Vivier
linux-user binaries don't need firmware and NMI, so don't add them in this case, move QDEV firmware functions to qdev-fw.c Signed-off-by: Laurent Vivier --- hw/core/Makefile.objs | 5 +-- hw/core/qdev-fw.c | 96 +++ hw/core/qdev.c| 77

[Qemu-devel] [Bug 1689367] Re: In qemu chroot, repeating "qemu: Unsupported syscall: 384" messages. sys_getrandom ?

2017-11-03 Thread pgnet
> run /usr/bin/qemu-arm-static --version in the chroot :/# /usr/bin/qemu-arm --version qemu-arm version 2.10.1 Copyright (c) 2003-2017 Fabrice Bellard and the QEMU Project developers -- You received this bug notification because you are a member of qemu- devel-ml, which is subscr

Re: [Qemu-devel] [PATCH] hw: add .min_cpus and .default_cpus fields to machine_class

2017-11-03 Thread Emilio G. Cota
On Fri, Nov 03, 2017 at 14:47:33 -0400, Emilio G. Cota wrote: > diff --git a/hw/arm/xlnx-zcu102.c b/hw/arm/xlnx-zcu102.c > index e2d15a1..395d1b5 100644 > --- a/hw/arm/xlnx-zcu102.c > +++ b/hw/arm/xlnx-zcu102.c > @@ -185,6 +185,9 @@ static void xlnx_ep108_machine_class_init(ObjectClass > *oc, void

Re: [Qemu-devel] [PULL v1 03/11] sockets: Handle race condition between binds to the same port

2017-11-03 Thread Peter Maydell
On 16 October 2017 at 21:16, Daniel P. Berrange wrote: > From: Knut Omang > > If an offset of ports is specified to the inet_listen_saddr function(), > and two or more processes tries to bind from these ports at the same time, > occasionally more than one process may be able to bind to the same >

[Qemu-devel] [PATCH] hw: add .min_cpus and .default_cpus fields to machine_class

2017-11-03 Thread Emilio G. Cota
max_cpus needs to be an upper bound on the number of vCPUs initialized; otherwise TCG region initialization breaks. Some boards initialize a hard-coded number of vCPUs, which is not captured by the global max_cpus. Fix it by adding the .min_cpus field to machine_class. This commit also changes so

Re: [Qemu-devel] [PATCH v2 2/5] net: fix -netdev socket, fd= for UDP sockets

2017-11-03 Thread Peter Maydell
On 8 August 2017 at 21:38, Jens Freimann wrote: > This patch fixes -netdev socket,fd= for UDP sockets > Currently -netdev socket,fd=<...> results in > > qemu: error: specified mcastaddr "127.0.0.1" (0x7f01) does not > contain a multicast address > qemu-system-x86_64: -netdev > sock

[Qemu-devel] [Bug 1689367] Re: In qemu chroot, repeating "qemu: Unsupported syscall: 384" messages. sys_getrandom ?

2017-11-03 Thread pgnet
> Can you just run /usr/bin/qemu-arm-static --version in the chroot, please ? (or whatever suse calls its statically linked binary). Yep, as soon as I'm sitting back in front of the machine with the chroot on it. Bit later ... > The other interesting question is what version of the (host) kern

Re: [Qemu-devel] [PATCH v3 5/5] build: delay check for empty git submodule list

2017-11-03 Thread Eric Blake
On 11/03/2017 10:33 AM, Daniel P. Berrange wrote: > We short circuit the git submodule update when passed an empty module list. > This accidentally causes the 'status' command to write to the status file. The > test needs to be delayed into the individual commands to avoid this premature > writing

Re: [Qemu-devel] [PATCH v3 4/5] build: don't fail if given a git submodule which does not exist

2017-11-03 Thread Eric Blake
On 11/03/2017 10:33 AM, Daniel P. Berrange wrote: > If going back in time in git history, across a commit that introduces a new > submodule, the 'git-submodule.sh' script will fail, causing rebuild to fail. > > This is because config-host.mak contains a GIT_SUBMODULES variable that lists > a submo

[Qemu-devel] [Bug 1728448] Re: qemu-system-arm segmentation fault with cpu cortex-m*

2017-11-03 Thread Kevin
Thank you for you answer. I wanted to emulate under cortex-M3 because I need to exéutute an executable who will install a kernel but only runs under cortex-M3, for then realized fuzzing on this kernel. But, I will try with freeRTOS. -- You received this bug notification because you are a member

[Qemu-devel] [Bug 1713408] Re: qemu crashes with "GLib-ERROR **: gmem.c" error when a negative value passed to "maxcpus"

2017-11-03 Thread Peter Maydell
Fixed in master, commit c0dd109919, which will be in the upcoming 2.11 release. ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1713408 Title:

Re: [Qemu-devel] [PATCH v3 3/5] build: allow automatic git submodule updates to be disabled

2017-11-03 Thread Eric Blake
On 11/03/2017 10:33 AM, Daniel P. Berrange wrote: > Some people building QEMU use VPATH builds where the source directory is on a > read-only volume. In such a case 'scripts/git-submodules.sh update' will > always > fail and users are required to run it manually themselves on their original > writ

Re: [Qemu-devel] [PULL 33/54] block: Introduce BdrvChildRole.update_filename

2017-11-03 Thread Peter Maydell
On 6 October 2017 at 16:54, Kevin Wolf wrote: > There is no good reason for bdrv_drop_intermediate() to know the active > layer above the subchain it is operating on - even more so, because > the assumption that there is a single active layer above it is not > generally true. > > In order to prepa

Re: [Qemu-devel] [PATCH v3 2/5] build: don't create temporary files in source dir

2017-11-03 Thread Eric Blake
On 11/03/2017 10:33 AM, Daniel P. Berrange wrote: > There are cases where users do VPATH builds with the source directory being on > a read-only volume. In such a case they have to manually run the command > 'git-submodule.sh ...modules...' ahead of time. When checking for status we > should not th

Re: [Qemu-devel] [PATCH v3 1/5] build: allow setting a custom GIT binary for transparent proxying

2017-11-03 Thread Eric Blake
On 11/03/2017 10:33 AM, Daniel P. Berrange wrote: > Some users can't run a bare 'git' command, due to need for a transparent > proxying solution such as 'tsocks'. This adds an argument to configure to > let users specify such a thing: > > ./configure --with-git="tsocks git" > > The submodule sc

[Qemu-devel] [Bug 1689367] Re: In qemu chroot, repeating "qemu: Unsupported syscall: 384" messages. sys_getrandom ?

2017-11-03 Thread Peter Maydell
The other interesting question is what version of the (host) kernel headers the QEMU binary was built against -- if that's earlier than 3.17 then the headers won't define __NR_getrandom for the host system and we won't implement the syscall. -- You received this bug notification because you are a

[Qemu-devel] [PATCH] nvic: Fix ARMv7M MPU_RBAR reads

2017-11-03 Thread Peter Maydell
Fix an incorrect mask expression in the handling of v7M MPU_RBAR reads that meant that we would always report the ADDR field as zero. Signed-off-by: Peter Maydell --- Doesn't affect v8M, which is a different codepath. hw/intc/armv7m_nvic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH v3 0/5] Various improvements/bugfixes to submodule handling

2017-11-03 Thread Peter Maydell
On 3 November 2017 at 15:33, Daniel P. Berrange wrote: > This short series of patches improves the reliability of the submodule > handling to cope with various dev env scenarios that have since emerged Can I ask you to write up a bit for the release notes at https://wiki.qemu.org/ChangeLog/2.11#B

Re: [Qemu-devel] [PATCH] qcow2: fix image corruption after committing qcow2 image into base

2017-11-03 Thread Eric Blake
On 11/03/2017 09:41 AM, Daniel P. Berrange wrote: > After committing the qcow2 image contents into the base image, qemu-img > will call bdrv_make_empty to drop the payload in the layered image. > > When this is done for qcow2 images, it blows away the LUKS encryption > header, making the resulting

Re: [Qemu-devel] [PATCH] docker: Improved image checksum

2017-11-03 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Thanks Fam, this fixes Shippable builds :) > > On 11/03/2017 10:12 AM, Fam Zheng wrote: >> When a base image locally defined by QEMU, such as in the debian images, >> is updated, the dockerfile checksum mechanism in docker.py still skips >> updating the derived i

Re: [Qemu-devel] [PATCH] qcow2: don't permit changing encryption parameters

2017-11-03 Thread Eric Blake
On 11/03/2017 09:39 AM, Daniel P. Berrange wrote: > Currently if trying to change encryption parameters on a qcow2 image, qemu-img > will abort. We already explicitly check for attempt to change encrypt.format > but missed other parameters like encrypt.key-secret. Rather than list each > parameter,

[Qemu-devel] [Bug 1689367] Re: In qemu chroot, repeating "qemu: Unsupported syscall: 384" messages. sys_getrandom ?

2017-11-03 Thread Peter Maydell
Can you just run /usr/bin/qemu-arm-static --version in the chroot, please ? (or whatever suse calls its statically linked binary). -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1689367 Title: In

Re: [Qemu-devel] [libvirt] How to best handle the reoccurring of rom changes breaking cross version migrations?

2017-11-03 Thread Philipp Hahn
Hello Am 03.11.2017 um 08:30 schrieb Christian Ehrhardt: > On Thu, Nov 2, 2017 at 4:34 PM, Daniel P. Berrange > wrote: >> >> On Thu, Nov 02, 2017 at 04:14:06PM +0100, Christian Ehrhardt wrote: >>> Ping - since there wasn't any reply so far - any best practices one could >>> share? >>> >>> Let me

Re: [Qemu-devel] [PATCH] arm: check regime, not current state, for ATS write PAR format

2017-11-03 Thread Stefano Stabellini
On Fri, 3 Nov 2017, Peter Maydell wrote: > In do_ats_write(), rather than using extended_addresses_enabled() to > decide whether the value we get back from get_phys_addr() is a 64-bit > format PAR or a 32-bit one, use arm_s1_regime_using_lpae_format(). > > This is not really the correct answer, be

[Qemu-devel] [Bug 1689367] Re: In qemu chroot, repeating "qemu: Unsupported syscall: 384" messages. sys_getrandom ?

2017-11-03 Thread pgnet
The statically linked qemu files in chroot are cp'd from the host env file $(which qemu-arm) $(which qemu-arm-binfmt) /usr/bin/qemu-arm:ELF 64-bit LSB executable, x86-64, version 1 (GNU/Linux), statically linked, for GNU/Linux 3.0.0, BuildID[sha1]=a6c50ab9b8f1845d

[Qemu-devel] [PATCH] AMD Processor Topology Information

2017-11-03 Thread Stanislav Lanci
V2: Adds information about cache size and topology on leaf 0x801D for family 17h Without the added cache topology guest with SMT suffers latency problems Add CPUID 0x801E for describing AMD Processor Topology Information Disables warning about smt for 17h family of AMD CPUs Signed-off-by:

[Qemu-devel] [Bug 1429841] Re: error "rom: requested regions overlap" for NOLOAD sections

2017-11-03 Thread Peter Maydell
This bug is fixed in QEMU master by commits bf1733392ca2 and f33e5e6299288c, which will be in the upcoming QEMU 2.11 release. (PS: the thing the loader cares about is not elf sections but elf segments in the program header, so the section table and its attributes isn't relevant here, only the prog

[Qemu-devel] [Bug 1689367] Re: In qemu chroot, repeating "qemu: Unsupported syscall: 384" messages. sys_getrandom ?

2017-11-03 Thread Peter Maydell
** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1689367 Title: In qemu chroot, repeating "qemu: Unsupported syscall: 384" messages. sys_getrando

Re: [Qemu-devel] [PATCH v7 01/13] m25p80: Add support for continuous read out of RDSR and READ_FSR

2017-11-03 Thread francisco iglesias
Hi Marcin, Huge thank you once again! This time not only for reviewing but also for having this patience with me! I wish you a great wekeend! Best regards, Francisco Iglesias On 3 Nov 2017 17:18, "mar.krzeminski" wrote: > > > W dniu 03.11.2017 o 01:00, Francisco Iglesias pisze: > > Add suppor

Re: [Qemu-devel] [PATCH v9 0/8] Optimize VMDK I/O by allocating multiple clusters

2017-11-03 Thread John Snow
On 11/02/2017 11:50 PM, Fam Zheng wrote: > On Thu, 11/02 17:02, John Snow wrote: >> >> >> On 10/20/2017 02:53 AM, Ashijeet Acharya wrote: >>> >>> On Fri, Oct 20, 2017 at 11:58 Fam Zheng >> > wrote: >>> >>> On Mon, 10/09 22:12, Fam Zheng wrote: >>> > On Mon, 10/09 1

[Qemu-devel] [Bug 1724485] Re: Invalid assertion in arm_read_memory_func

2017-11-03 Thread Peter Maydell
This should be fixed in QEMU master by commits 6cd61517fb5217098, 7bcdbf51eeb674e4. ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1724485 Tit

[Qemu-devel] [Bug 1689367] Re: In qemu chroot, repeating "qemu: Unsupported syscall: 384" messages. sys_getrandom ?

2017-11-03 Thread Peter Maydell
arm32 syscall 384 is indeed getrandom, but QEMU implemented this in commit f894efd19917321 as of Feb 2016, which should be in 2.6 or later. I've just checked and the LTP test cases for getrandom all pass with qemu-arm-user and do invoke the getrandom syscall and don't provoke the warning from QEMU.

[Qemu-devel] capstone ARM disassembly doesn't include hex of the input insns

2017-11-03 Thread Peter Maydell
Debug disassembly used to look like this: 0x40801a48: e1ad mov r0, sp but now it looks like this: 0x40801a40: ldr sl, [pc, #0x94] Can we have the hex output of the insn bytes back, please? thanks -- PMM

[Qemu-devel] [Bug 1568107] Re: x86_64 linux-user: setup_rt_frame: not implemented

2017-11-03 Thread Peter Maydell
This bug was fixed in 2.9 (we added x86-64 linux-user signal handling support.) ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1568107 Title:

[Qemu-devel] [Bug 1594069] Re: SIMD instructions translated to scalar host instructions

2017-11-03 Thread Peter Maydell
Closing this because it isn't a bug. (It looks like some of the vector TCG improvements are now in progress and might hit master for 2.12; but in any case having an open bug in the system about this serves no useful purpose.) ** Changed in: qemu Status: Confirmed => Invalid -- You receiv

[Qemu-devel] [Bug 1673976] Re: locale-gen dumps core run under arm-linux-user on x86-64 host

2017-11-03 Thread Peter Maydell
** Summary changed: - core dump + locale-gen dumps core run under arm-linux-user on x86-64 host -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1673976 Title: locale-gen dumps core run under arm-lin

[Qemu-devel] [Bug 1723984] Re: ID_MMFR0 has an invalid value on aarch64 cpu (A57, A53)

2017-11-03 Thread Peter Maydell
Thanks for the update -- I'm going to close this bug. (Incidentally, my experience with checks of the "insist we're on a known platform with ID register values we recognize" kind is that they're more trouble than they're worth, especially if you plan running the software in an emulator.) ** Chang

[Qemu-devel] [Bug 1353346] Re: ARMv7-M software-triggered interrupts-- unexpected behaviour

2017-11-03 Thread Peter Maydell
This bug was fixed in QEMU 2.9 as part of the rewrite of M profile exception handling. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1353346 T

[Qemu-devel] [Bug 1480562] Re: register values in sp804 timer

2017-11-03 Thread Peter Maydell
** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1480562 Title: register values in sp804 timer Status in QEMU: Invalid Bug description: In the a

Re: [Qemu-devel] [PATCH v2 0/7] Misc qcow2 corruption checks

2017-11-03 Thread Max Reitz
On 2017-11-03 15:18, Alberto Garcia wrote: > This series contains a few checks that prevent QEMU from crashing > under some scenarios with corrupted qcow2 images. > > The first patch solves the crash reported here: > > https://bugs.launchpad.net/qemu/+bug/1728615 > > And the others solve simil

Re: [Qemu-devel] [PATCH v2 5/7] qcow2: Add iotest for an image with header.refcount_table_offset == 0

2017-11-03 Thread Max Reitz
On 2017-11-03 15:18, Alberto Garcia wrote: > This patch adds a simple iotest in which we try to write to an image > with the refcount table offset set to 0. > > This scenario was already handled by the existing consistency checks, > but we add an explicit test case for completeness. > > Signed-of

Re: [Qemu-devel] [PATCH] linux-user: return EINVAL from prctl(PR_*_SECCOMP)

2017-11-03 Thread Laurent Vivier
Le 03/11/2017 à 17:01, Peter Maydell a écrit : > On 3 November 2017 at 15:52, James Cowgill wrote: >> On 03/11/17 14:29, Laurent Vivier wrote: >>> I think we should allow PR_GET_SECCOMP, and at least all the modes >>> except SECCOMP_MODE_FILTER for PR_SET_SECCOMP. >> >> I tried allowing SECCOMP_MO

[Qemu-devel] [Bug 942659] Re: ARM: CORTEX M, PRIMASK does not disable interrupts

2017-11-03 Thread Peter Maydell
This long-standing bug has been fixed by the rewrite of the M-profile exception handling for QEMU 2.9. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net

Re: [Qemu-devel] [PATCH v2 3/7] qcow2: Prevent allocating compressed clusters at offset 0

2017-11-03 Thread Max Reitz
On 2017-11-03 15:18, Alberto Garcia wrote: > If the refcount data is corrupted then we can end up trying to > allocate a new compressed cluster at offset 0 in the image, triggering > an assertion in qcow2_alloc_bytes() that would crash QEMU: > > qcow2_alloc_bytes: Assertion `offset' failed. > >

Re: [Qemu-devel] [PATCH v7 01/13] m25p80: Add support for continuous read out of RDSR and READ_FSR

2017-11-03 Thread mar.krzeminski
W dniu 03.11.2017 o 01:00, Francisco Iglesias pisze: Add support for continuous read out of the RDSR and READ_FSR status registers until the chip select is deasserted. This feature is supported by amongst others 1 or more flashtypes manufactured by Numonyx (Micron), Windbond, SST, Gigadevice, E

Re: [Qemu-devel] tcg/translate-all.c:169: tb_lock: Assertion `!have_tb_lock' failed when doing cpu_restore_state in usermode

2017-11-03 Thread Peter Maydell
On 6 October 2017 at 18:36, Peter Maydell wrote: > Running the test program > http://people.linaro.org/~peter.maydell/thumb-over-page > (source at http://people.linaro.org/~peter.maydell/thumb-over-page.c) > in the usermode emulator: > ./build/x86/arm-linux-user/qemu-arm ~/linaro/qemu-misc-tests/

Re: [Qemu-devel] [PATCH] linux-user: return EINVAL from prctl(PR_*_SECCOMP)

2017-11-03 Thread Peter Maydell
On 3 November 2017 at 15:52, James Cowgill wrote: > On 03/11/17 14:29, Laurent Vivier wrote: >> I think we should allow PR_GET_SECCOMP, and at least all the modes >> except SECCOMP_MODE_FILTER for PR_SET_SECCOMP. > > I tried allowing SECCOMP_MODE_STRICT and made a small test program. It > seems th

Re: [Qemu-devel] [PATCH] docker: Improved image checksum

2017-11-03 Thread Philippe Mathieu-Daudé
Thanks Fam, this fixes Shippable builds :) On 11/03/2017 10:12 AM, Fam Zheng wrote: > When a base image locally defined by QEMU, such as in the debian images, > is updated, the dockerfile checksum mechanism in docker.py still skips > updating the derived image, because it only looks at the literal

Re: [Qemu-devel] [PATCH v2 1/2] chardev: fix backend events regression with mux chardev

2017-11-03 Thread Kirill A. Shutemov
On Fri, Nov 03, 2017 at 03:28:23PM +, Marc-André Lureau wrote: > Kirill noticied that on recent versions on QEMU he was not able to > trigger SysRq to invoke debug capabilites of Linux Kernel. He tracked > it down to qemu_chr_be_event() ignoring CHR_EVENT_BREAK due s->be > being NULL. The bug

Re: [Qemu-devel] [PATCH v5] nvme: Add tracing

2017-11-03 Thread Philippe Mathieu-Daudé
Cc'ing Trivial ;) On 11/03/2017 10:37 AM, Doug Gale wrote: > Add trace output for commands, errors, and undefined behavior. > Add guest error log output for undefined behavior. > Report invalid undefined accesses to MMIO. > Annotate unlikely error checks with unlikely. > > Signed-off-by: Doug Gal

Re: [Qemu-devel] [PATCH] linux-user: return EINVAL from prctl(PR_*_SECCOMP)

2017-11-03 Thread James Cowgill
Hi, On 03/11/17 14:29, Laurent Vivier wrote: > Le 03/11/2017 à 13:07, James Cowgill a écrit : >> If an application tries to install a seccomp filter using >> prctl(PR_SET_SECCOMP), the filter is likely for the target instead of the >> host >> architecture. This will probably cause qemu to be imme

[Qemu-devel] [PATCH] aio-posix: drop QEMU_AIO_POLL_MAX_NS env var

2017-11-03 Thread Stefan Hajnoczi
This hunk should not have been merged but I forgot to remove it. Let's remove it before it slips into a QEMU release. ¯\_(ツ)_/¯ Reviewed-by: Thomas Huth Signed-off-by: Stefan Hajnoczi --- util/aio-posix.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/util/aio-posix.c b/util/aio-po

[Qemu-devel] [PATCH v3 4/5] build: don't fail if given a git submodule which does not exist

2017-11-03 Thread Daniel P. Berrange
If going back in time in git history, across a commit that introduces a new submodule, the 'git-submodule.sh' script will fail, causing rebuild to fail. This is because config-host.mak contains a GIT_SUBMODULES variable that lists a submodule that only exists in the later commit. config-host.mak w

[Qemu-devel] [PATCH v3 3/5] build: allow automatic git submodule updates to be disabled

2017-11-03 Thread Daniel P. Berrange
Some people building QEMU use VPATH builds where the source directory is on a read-only volume. In such a case 'scripts/git-submodules.sh update' will always fail and users are required to run it manually themselves on their original writable source directory. While this is already supported, it i

[Qemu-devel] [PATCH v3 5/5] build: delay check for empty git submodule list

2017-11-03 Thread Daniel P. Berrange
We short circuit the git submodule update when passed an empty module list. This accidentally causes the 'status' command to write to the status file. The test needs to be delayed into the individual commands to avoid this premature writing of the status file. Signed-off-by: Daniel P. Berrange --

[Qemu-devel] [PATCH v3 2/5] build: don't create temporary files in source dir

2017-11-03 Thread Daniel P. Berrange
There are cases where users do VPATH builds with the source directory being on a read-only volume. In such a case they have to manually run the command 'git-submodule.sh ...modules...' ahead of time. When checking for status we should not then write into the source dir. Signed-off-by: Daniel P. Be

[Qemu-devel] [PATCH v3 0/5] Various improvements/bugfixes to submodule handling

2017-11-03 Thread Daniel P. Berrange
This short series of patches improves the reliability of the submodule handling to cope with various dev env scenarios that have since emerged v2: https://lists.gnu.org/archive/html/qemu-devel/2017-10/msg06272.html Changed in v3: - Avoid use of mktemp - Use '=' instead of '==' (bashism) in c

[Qemu-devel] [PATCH v3 1/5] build: allow setting a custom GIT binary for transparent proxying

2017-11-03 Thread Daniel P. Berrange
Some users can't run a bare 'git' command, due to need for a transparent proxying solution such as 'tsocks'. This adds an argument to configure to let users specify such a thing: ./configure --with-git="tsocks git" The submodule script is also updated to give the user a hint about using this fl

[Qemu-devel] [PATCH v2 1/2] chardev: fix backend events regression with mux chardev

2017-11-03 Thread Marc-André Lureau
Kirill noticied that on recent versions on QEMU he was not able to trigger SysRq to invoke debug capabilites of Linux Kernel. He tracked it down to qemu_chr_be_event() ignoring CHR_EVENT_BREAK due s->be being NULL. The bug was introduced in 2.8, commit a4afa548fc6d ("char: move front end handlers

[Qemu-devel] [PATCH v2 2/2] test: add some chardev mux event tests

2017-11-03 Thread Marc-André Lureau
Check the expected behaviour of qemu_chr_be_event() on a mux chardev. For some reason, sending the event on the base chardev broadcast to all frontends, while sending it on the mux chardev itself should trigger the event on the currently focused chardev frontend. Signed-off-by: Marc-André Lureau

[Qemu-devel] [PATCH v2 0/2] mux chardev events regression fix

2017-11-03 Thread Marc-André Lureau
Hi, The following patches fix and test the behaviour of mux chardev events, after a regression introduced in qemu 2.8.0. v1->v2: - fix incompatible pointer type warning spotted by patchew Marc-André Lureau (2): chardev: fix backend events regression with mux chardev test: add some chardev mu

Re: [Qemu-devel] [PATCH] aio-posix: drop QEMU_AIO_POLL_MAX_NS env var

2017-11-03 Thread Stefan Hajnoczi
On Thu, Nov 02, 2017 at 07:31:13AM +0100, Thomas Huth wrote: > On 26.01.2017 16:38, Stefan Hajnoczi wrote: > > This hunk should not have been merged but I forgot to remove it. Let's > > remove it before it slips into a QEMU release. > > Too late - looks like this patch has never been committed :-

Re: [Qemu-devel] [PATCH] virtio-pci: Don't force Subsystem Vendor ID = Vendor ID

2017-11-03 Thread Michael S. Tsirkin
On Fri, Nov 03, 2017 at 09:23:07AM +0100, Ladi Prosek wrote: > On Fri, Nov 3, 2017 at 8:20 AM, Gerd Hoffmann wrote: > > > >> > > Signed-off-by: Ladi Prosek > >> > > >> > I wonder whether it's a problem that legacy devices ignore > >> > the subsystem ID (that's part of spec). > >> > >> I don't und

Re: [Qemu-devel] [PATCH v4] pci: Set err to errp directly rather than through error_propagate()

2017-11-03 Thread Stefan Hajnoczi
On Thu, Oct 12, 2017 at 10:44:26AM +0800, Mao Zhongyi wrote: > On 09/12/2017 06:16 PM, Stefan Hajnoczi wrote: > > On Sat, Sep 09, 2017 at 02:22:26PM +0800, Mao Zhongyi wrote: > > > ioh3420_interrupts_init() pass error message to local_err, then > > > propagate it to errp by error_propagate(), which

  1   2   3   >