[Qemu-devel] [PATCH qemu] fdc: Exit if ISA controller does not support DMA

2017-10-25 Thread Alexey Kardashevskiy
A "powernv" machine type defines an ISA bus but it does not add any DMA controller to it so it is possible to hit assert(fdctrl->dma) by adding "-machine powernv -device isa-fdc". This replaces assert() with an error message. Signed-off-by: Alexey Kardashevskiy --- Is it a must for ISA to have

Re: [Qemu-devel] [PULL 00/11] Disassembler patches

2017-10-25 Thread Peter Maydell
On 26 October 2017 at 07:07, Peter Maydell wrote: > Hi. This failed to build for Windows: Also, after it failed and I backed out the merge, the next thing I tried to build failed everywhere with: warning: unable to rmdir capstone: Directory not empty error: pathspec 'capstone' did not match any

Re: [Qemu-devel] [PULL 00/11] Disassembler patches

2017-10-25 Thread Peter Maydell
pull-request' into staging (2017-10-24 > 16:05:57 +0100) > > are available in the git repository at: > > git://github.com/rth7680/qemu.git tags/pull-dis-20171025 > > for you to fetch changes up to 383b90bc6a15f4b18ec34f9c0287b26f9a89fcb8: >

Re: [Qemu-devel] [Qemu devel V4 PATCH] msf2: Remove dead code reported by Coverity

2017-10-25 Thread sundeep subbaraya
On Wed, Oct 25, 2017 at 2:15 PM, Darren Kenny wrote: > LGTM now, thanks. > > Reviewed-by: Darren Kenny > Thanks Darren, Sundeep > > Thanks, > > Darren. > > > On Wed, Oct 25, 2017 at 07:59:04AM +0530, Subbaraya Sundeep wrote: > >> Fixed incorrect frame size mask, validated maximum frame >> siz

Re: [Qemu-devel] [PULL 00/11] Disassembler patches

2017-10-25 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 00/11] Disassembler patches Type: series Message-id: 20171025123056.3165-1-richard.hender...@linaro.org === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git lo

Re: [Qemu-devel] [PATCHv4 00/13] sun4m: sparc32_dma tidy-ups

2017-10-25 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCHv4 00/13] sun4m: sparc32_dma tidy-ups Type: series Message-id: 1508947167-5304-1-git-send-email-mark.cave-ayl...@ilande.co.uk === TEST SCRIPT BEGIN === #!/bin/bash BASE=b

Re: [Qemu-devel] Qemu start VM in huge page without '-mem-prealloc' will get memory leak?

2017-10-25 Thread Sam
BTW, I start VM by this command, and then stop it, then memory leak happens. To compare, I start another VM, and wait for about 10 minutes, and then kill it as I does above, then no memory leak happens. So is this a bug of KVM or qemu ? 2017-10-26 11:09 GMT+08:00 Sam : > For qemu-2.6.0, in huge

[Qemu-devel] Qemu start VM in huge page without '-mem-prealloc' will get memory leak?

2017-10-25 Thread Sam
For qemu-2.6.0, in huge page (1G) environment, after kill the qemu process, memory which is alloc for the vm could not be released. Detail is bellow. Or should I use some specific command to stop vm? I want to know if there someone has the same problem? The start up command is: CMD1="$QEMU_CMD -D

Re: [Qemu-devel] [PATCH qemu v3] pci: Initialize pci_dev->name before use

2017-10-25 Thread Alexey Kardashevskiy
On 19/10/17 13:15, Alexey Kardashevskiy wrote: > This moves pci_dev->name initialization earlier so > pci_dev->bus_master_as could get a name instead of an empty string. > > Reviewed-by: Philippe Mathieu-Daudé > Reviewed-by: Peter Xu > Signed-off-by: Alexey Kardashevskiy Ping? > --- > > Ch

Re: [Qemu-devel] [PATCH v6 00/50] tcg tb_lock removal

2017-10-25 Thread Emilio G. Cota
I have given a respin to the tb_lock branch on top of master. Turns out the freezes I was getting were due to the magic we used to rely on (e.g. for icount). Works now! The branch is here: https://github.com/cota/qemu/tree/tb-lock Boot-tested on ppc64, aarch64 and alpha smp guests (<=64) with M

[Qemu-devel] 答复: Re: [PATCH v7 RESEND] qga: Add support network interface statistics inguest-network-get-interfaces command

2017-10-25 Thread lu.zhipeng
>> +if (NO_ERROR == GetIfEntry(&aMib_ifrow)) { thanks, I found may be overflow using GetIfEntry,thus GetIfEntry2 instead of GetIfEntry. 为了让您的VPlat虚拟机故障和docker故障得到高效的处理,请上报故障到: $VPlat技术支持。 芦志朋 luzhipeng IT开发工程师 IT Development Engineer 操作系统产品部/中心研究院/系统产品 OS Product Dept

[Qemu-devel] [PATCH qemu v2] machine: Polish -machine xxx,help

2017-10-25 Thread Alexey Kardashevskiy
The "-machine xxx,help" prints kernel-irqchip possible values as "OnOffSplit", this adds separators to the printed line. Also, since only lower case letters are specified in qapi/common.json, this changes the letter cases too. Signed-off-by: Alexey Kardashevskiy --- aik@fstn1-p1:~$ ./qemu-syste

Re: [Qemu-devel] [PATCH qemu] machine: Polish -machine xxx,help

2017-10-25 Thread Alexey Kardashevskiy
On 26/10/17 12:29, Alexey Kardashevskiy wrote: > The "-machine xxx,help" prints kernel-irqchip possible values as > "OnOffSplit", this adds separators to the printed line. > > Signed-off-by: Alexey Kardashevskiy > --- > > aik@fstn1-p1:~$ ./qemu-system-ppc64 -machine pseries,help 2>&1 | grep > k

[Qemu-devel] [PATCH qemu v2] git-submodule.sh: Do not try writing to source directory if not necessary

2017-10-25 Thread Alexey Kardashevskiy
The new git-submodule.sh script writes .git-submodule-status to the source directory every time no matter what. This makes it conditional. Signed-off-by: Alexey Kardashevskiy --- Changes: v2: * fixed "status" branch too --- scripts/git-submodule.sh | 15 ++- 1 file changed, 10 insert

[Qemu-devel] [PATCH qemu] machine: Polish -machine xxx,help

2017-10-25 Thread Alexey Kardashevskiy
The "-machine xxx,help" prints kernel-irqchip possible values as "OnOffSplit", this adds separators to the printed line. Signed-off-by: Alexey Kardashevskiy --- aik@fstn1-p1:~$ ./qemu-system-ppc64 -machine pseries,help 2>&1 | grep kernel-irqchip Was: pseries-2.11.kernel-irqchip=OnOffSplit (Con

[Qemu-devel] [libfdt][PATCH v4] implement strnlen for systems that need it

2017-10-25 Thread John Arbuckle
Prior the Mac OS 10.7, the function strnlen() was not available. This patch implements strnlen() on Mac OS X versions that are below 10.7. Signed-off-by: John Arbuckle --- v4 changes: - Added check for definition of MAC_OS_X_VERSION_10_7 - Renamed strnlen to fdt_strnlen - Added macro that defines

Re: [Qemu-devel] Block format 'raw' does not support the option 'locking' when disable image locking with option locking=off

2017-10-25 Thread Changlimin
share-rw=on is good for raw format file, but bad for qcow2 format file: Failed to get "write" lock Is another process using the image? Is this intented? BR Chang Limin -Original Message- From: Fam Zheng [mailto:f...@redhat.com] Sent: Wednesday, October 25, 2017 9:31 PM To: changlimin 0

Re: [Qemu-devel] [PATCH v7 RESEND] qga: Add support network interface statistics in guest-network-get-interfaces command

2017-10-25 Thread Michael Roth
Quoting ZhiPeng Lu (2017-09-12 03:54:26) > we can get the network interface statistics inside a virtual machine by > guest-network-get-interfaces command. it is very useful for us to monitor > and analyze network traffic. > > Signed-off-by: ZhiPeng Lu Thanks, applied to qga tree: https://githu

Re: [Qemu-devel] [RFC PATCH qemu] git-submodule.sh: Do not try writing to source directory if not necessary

2017-10-25 Thread Alexey Kardashevskiy
On 26/10/17 08:11, Daniel P. Berrange wrote: > On Wed, Oct 25, 2017 at 07:10:40PM +1100, Alexey Kardashevskiy wrote: >> On 25/10/17 17:57, Daniel P. Berrange wrote: >>> On Wed, Oct 25, 2017 at 12:45:10PM +1100, Alexey Kardashevskiy wrote: On 25/10/17 03:27, Daniel P. Berrange wrote: > On T

Re: [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

2017-10-25 Thread Halil Pasic
On 10/20/2017 04:54 PM, Christian Borntraeger wrote: > Starting a guest with > > hvm > > > > on an IBM z14 results in > > "qemu-system-s390x: Some features requested in the CPU model are not > available in the configuration: gs" > > This is because guarded storage is fenced for c

[Qemu-devel] [PATCH v2] don't hardcode EL1 in extended_addresses_enabled

2017-10-25 Thread Stefano Stabellini
extended_addresses_enabled calls arm_el_is_aa64, hardcoding exception level 1. Instead, add an additional "el" argument to extended_addresses_enabled. The caller will pass the right value. In most cases, it will be arm_current_el(env). However, arm_debug_excp_handler will use arm_debug_target_el(e

Re: [Qemu-devel] [PATCH v2] qga-win: Updating guest_set_time action

2017-10-25 Thread Michael Roth
Quoting Bishara AbuHattoum (2017-08-22 08:55:04) > At the moment, Windows libraries don't provide a way to access > RTC, so, a workaround is to use the Windows w32tm command to > resync the time. > Related bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1183874 > > Signed-off-by: Bis

Re: [Qemu-devel] [Resend][PATCH] qga-win: don't hang if vss hold writes timeout

2017-10-25 Thread Michael Roth
Quoting Chen Hanxiao (2017-10-17 01:41:42) > From: Chen Hanxiao > > When VM is in a heavy IO, if the command "guest-fsfreeze-freeze" > is executed, VSS may timeout when trying to hold writes. > > Inside guest, Event ID 12298(VSS_ERROR_HOLD_WRITES_TIMEOUT) > is logged in the Event Viewer. > > At

Re: [Qemu-devel] [PATCH] s390-ccw: print carriage return with new lines

2017-10-25 Thread Halil Pasic
On 10/25/2017 09:49 PM, Collin L. Walling wrote: >>> -sccb->h.length = sizeof(WriteEventData) + len; >>> +for (p = str; *p; ++p) { >>> +if (data_len > SCCB_DATA_LEN - 1) { >>> +return -EFBIG; >>> +} >> We could also do a partial write or do more that one >> scl

Re: [Qemu-devel] [PATCH] qga-win: fall back to hardcoded user and group names if LookupAccountSidW failed

2017-10-25 Thread Michael Roth
Quoting Tomáš Golembiovský (2017-09-29 16:31:02) > On Fri, 29 Sep 2017 17:11:22 +0800 > Chen Hanxiao wrote: > > > From: Chen Hanxiao > > > > On some of windows (win08 sp2), > > it doesn't work by calling LookupAccountSidW with > > well-known SIDs, > > We got an error: > > error 997 overlapp

Re: [Qemu-devel] Crash with odd chardev setup

2017-10-25 Thread Daniel P. Berrange
On Wed, Oct 25, 2017 at 07:00:14PM +0100, Dr. David Alan Gilbert wrote: > Hi Dan, > I've got a crash in head (and 2.10) which is a bit of a heisenbug; > I can trigger it with: > > ./qemu-system-x86_64 -netdev tap,id=hostnet0,vhost=on,fd=10 -chardev > socket,id=charchannel0,path=/tmp/org.qemu.

Re: [Qemu-devel] [RFC PATCH qemu] git-submodule.sh: Do not try writing to source directory if not necessary

2017-10-25 Thread Daniel P. Berrange
On Wed, Oct 25, 2017 at 07:10:40PM +1100, Alexey Kardashevskiy wrote: > On 25/10/17 17:57, Daniel P. Berrange wrote: > > On Wed, Oct 25, 2017 at 12:45:10PM +1100, Alexey Kardashevskiy wrote: > >> On 25/10/17 03:27, Daniel P. Berrange wrote: > >>> On Tue, Oct 24, 2017 at 07:58:53PM +1100, Alexey Kar

Re: [Qemu-devel] [PATCH v3 02/13] m25p80: Add support for SST READ ID 0x90/0xAB commands

2017-10-25 Thread francisco iglesias
Good day Marcin, Thank you for your excellent review comments! I will correct the patches in the next version of the patch series (v4). Best regards, Francisco Iglesias On 25 October 2017 at 20:12, mar.krzeminski wrote: > > > W dniu 24.10.2017 o 21:51, Francisco Iglesias pisze: > > Add suppor

[Qemu-devel] [Bug 1726394] Re: Passes through prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, address)

2017-10-25 Thread Julian Andres Klode
I worked around this in APT for now by ignoring EFAULT or rather, printing a warning. It would be nice to not do this though. ** Also affects: qemu (Ubuntu) Importance: Undecided Status: New ** Changed in: qemu (Ubuntu) Importance: Undecided => Medium ** Changed in: qemu (Ubuntu)

Re: [Qemu-devel] [PATCH] s390-ccw: print carriage return with new lines

2017-10-25 Thread Collin L. Walling
On 10/20/2017 07:37 AM, Halil Pasic wrote: On 10/20/2017 12:25 PM, Christian Borntraeger wrote: From: "Collin L. Walling" The sclp console in the s390 bios writes raw data, leading console emulators (such as virsh console) to treat a new line ('\n') as just a new line instead of as a Unix lin

Re: [Qemu-devel] [PULL 00/51] tcg queued patches

2017-10-25 Thread Peter Maydell
73652b99b: > > Merge remote-tracking branch > 'remotes/kraxel/tags/usb-20171023-pull-request' into staging (2017-10-24 > 16:05:57 +0100) > > are available in the git repository at: > > git://github.com/rth7680/qemu.git tags/pull-tcg-20171025 > > fo

Re: [Qemu-devel] [PATCH v3] fix WFI/WFE length in syndrome register

2017-10-25 Thread Stefano Stabellini
On Wed, 25 Oct 2017, Peter Maydell wrote: > On 24 October 2017 at 18:59, Stefano Stabellini > wrote: > > WFI/E are often, but not always, 4 bytes long. When they are, we need to > > set ARM_EL_IL_SHIFT in the syndrome register. > > > > Pass the instruction length to HELPER(wfi), use it to decreme

Re: [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

2017-10-25 Thread Jason J. Herne
On 10/20/2017 10:54 AM, Christian Borntraeger wrote: Starting a guest with hvm on an IBM z14 results in "qemu-system-s390x: Some features requested in the CPU model are not available in the configuration: gs" This is because guarded storage is fenced for compat machines that

Re: [Qemu-devel] [PATCH v3 02/13] m25p80: Add support for SST READ ID 0x90/0xAB commands

2017-10-25 Thread mar.krzeminski
W dniu 24.10.2017 o 21:51, Francisco Iglesias pisze: Add support for SST READ ID 0x90/0xAB commands for reading out the flash manufacuter ID and device ID. Signed-off-by: Francisco Iglesias --- hw/block/m25p80.c | 20 1 file changed, 20 insertions(+) diff --git a/hw/b

Re: [Qemu-devel] [PATCH v3 01/13] m25p80: Add support for continuous read out of RDSR and READ_FSR

2017-10-25 Thread mar.krzeminski
W dniu 24.10.2017 o 21:51, Francisco Iglesias pisze: Add support for continuous read out of the RDSR and READ_FSR status registers until the chip select is deasserted. This feature is supported by amongst others 1 or more flashtypes manufactured by Numonyx (Micron), Windbond, SST, Gigadevice, E

Re: [Qemu-devel] [PATCH v3 04/13] m25p80: Add support for n25q512a11 and n25q512a13

2017-10-25 Thread mar.krzeminski
W dniu 24.10.2017 o 21:51, Francisco Iglesias pisze: Add support for Micron (Numonyx) n25q512a11 and n25q512a13 flashes. Signed-off-by: Francisco Iglesias Acked-by: Marcin Krzemiński --- hw/block/m25p80.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/block/m25p80.c b/hw/block

[Qemu-devel] Crash with odd chardev setup

2017-10-25 Thread Dr. David Alan Gilbert
Hi Dan, I've got a crash in head (and 2.10) which is a bit of a heisenbug; I can trigger it with: ./qemu-system-x86_64 -netdev tap,id=hostnet0,vhost=on,fd=10 -chardev socket,id=charchannel0,path=/tmp/org.qemu.guest_agent.0,server,nowait -monitor stdio -vnc :0 and then 'q' to quit. Note I'

Re: [Qemu-devel] [PATCHv4 09/13] lance: move TYPE_LANCE and SysBusPCNetState from lance.c to lance.h

2017-10-25 Thread Peter Maydell
On 25 October 2017 at 16:59, Mark Cave-Ayland wrote: > This enables them to be used outside of lance.c. > > Signed-off-by: Mark Cave-Ayland > CC: Jason Wang > diff --git a/include/hw/net/lance.h b/include/hw/net/lance.h > new file mode 100644 > index 000..c112fbc > --- /dev/null > +++ b/in

Re: [Qemu-devel] [PATCH v3 3/5] migration: No need to return the size of the cache

2017-10-25 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > After the previous commits, we make sure that the value passed is > right, or we just drop an error. So now we return if there is one > error or we have setup correctly the value passed. > > Signed-off-by: Juan Quintela > > -- > > Improve error me

Re: [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

2017-10-25 Thread Marc Hartmayer
On Wed, Oct 25, 2017 at 05:50 PM +0200, David Hildenbrand wrote: > On 25.10.2017 17:09, Boris Fiuczynski wrote: >> On 10/25/2017 12:23 PM, David Hildenbrand wrote: >>> On 25.10.2017 12:18, Christian Borntraeger wrote: Ping, I plan to submit belows patch for 2.11. We can then still look into

Re: [Qemu-devel] [libfdt][PATCH v3] implement strnlen for systems that need it

2017-10-25 Thread Programmingkid
> On Oct 24, 2017, at 8:18 AM, Stefan Hajnoczi wrote: > > On Mon, Oct 23, 2017 at 05:27:26PM +0100, Peter Maydell wrote: >> On 23 October 2017 at 17:09, Stefan Hajnoczi wrote: +/* strnlen() is not available on Mac OS < 10.7 */ +# if (MAC_OS_X_VERSION_MAX_ALLOWED < MAC_OS_X_VERSION_10_

Re: [Qemu-devel] [PATCHv4 00/13] sun4m: sparc32_dma tidy-ups

2017-10-25 Thread Artyom Tarasenko
On Wed, Oct 25, 2017 at 5:59 PM, Mark Cave-Ayland wrote: > This patchset aims to tidy-up the sparc32_dma code by improving the > modelling of the espdma/ledma devices using both QOM and the memory > API which didn't exist when the code was first written. > > The result is that it is now possible t

[Qemu-devel] [PATCHv4 12/13] sparc32_dma: remove is_ledma hack and replace with memory region alias

2017-10-25 Thread Mark Cave-Ayland
This hack originated from before the memory region API was introduced, and increased the size of the ledma DMA device to capture incorrect accesses beyond the end of the ledma device. A full analysis can be found on Artyom's blog at http://tyom.blogspot.co.uk/2010/10/bug-in-all-solaris-versions-af

[Qemu-devel] [PATCHv4 10/13] sparc32_dma: make lance device child of ledma device

2017-10-25 Thread Mark Cave-Ayland
This makes it possible to reference the lance device from the ledma device as required. Signed-off-by: Mark Cave-Ayland Reviewed-by: Artyom Tarasenko --- hw/dma/sparc32_dma.c | 22 ++ hw/sparc/sun4m.c | 31 +++ include/

[Qemu-devel] [PATCHv4 04/13] sun4m: move DMA device wiring from sparc32_dma_init() to sun4m_hw_init()

2017-10-25 Thread Mark Cave-Ayland
By using the sysbus interface it is possible to wire up the esp/le devices to the sun4m DMA controller directly during sun4m_hw_init() instead of passing qemu_irqs into the sparc32_dma_init() function. This is an intermediate step to allow further reorganisation as more logic is moved into the rel

[Qemu-devel] [PATCHv4 13/13] sparc32_dma: add len to esp/le DMA memory tracing

2017-10-25 Thread Mark Cave-Ayland
This is surprisingly useful when trying to debug DMA issues. Signed-off-by: Mark Cave-Ayland Reviewed-by: Artyom Tarasenko Reviewed-by: Philippe Mathieu-Daudé --- hw/dma/sparc32_dma.c |8 hw/dma/trace-events |8 2 files changed, 8 insertions(+), 8 deletions(-) diff

[Qemu-devel] [PATCHv4 03/13] sparc32_dma: move type declarations from sparc32_dma.c to sparc32_dma.h

2017-10-25 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Reviewed-by: Artyom Tarasenko --- hw/dma/sparc32_dma.c | 34 -- include/hw/sparc/sparc32_dma.h | 37 + 2 files changed, 37 insertions(+), 34 deletions(-) diff --git a/hw/dma/sparc32

[Qemu-devel] [PATCHv4 08/13] sparc32_dma: make esp device child of espdma device

2017-10-25 Thread Mark Cave-Ayland
This makes it possible to reference the esp device from the espdma device as required, and by wiring up the device ourselves in sun4m.c we can drop use of the esp_init() function. Signed-off-by: Mark Cave-Ayland Reviewed-by: Artyom Tarasenko --- hw/dma/sparc32_dma.c | 26 +++

[Qemu-devel] [PATCHv4 01/13] sparc32_dma: rename SPARC32_DMA type to SPARC32_DMA_DEVICE

2017-10-25 Thread Mark Cave-Ayland
Also update the function names to match as appropriate. While we're here rename the type from sparc32_dma to sparc32-dma in order to match the current QOM convention. Signed-off-by: Mark Cave-Ayland Reviewed-by: Artyom Tarasenko --- hw/dma/sparc32_dma.c | 67 +-

[Qemu-devel] [PATCHv4 11/13] sparc32_dma: introduce new SPARC32_DMA type container object

2017-10-25 Thread Mark Cave-Ayland
Create a new SPARC32_DMA container object (including an appropriate container memory region) and add instances of the SPARC32_ESPDMA_DEVICE and SPARC32_LEDMA_DEVICE as child objects. The benefit is that most of the gpio wiring complexity between esp/espdma and lance/ledma is now hidden within the S

[Qemu-devel] [PATCHv4 02/13] sparc32_dma: split esp and le into separate DMA devices

2017-10-25 Thread Mark Cave-Ayland
Due to slight differences in behaviour accessing the registers for the esp and le devices, create two separate SPARC32_DMA_DEVICE types and update the sun4m machine to use. Note that by using different device types we already know the size of the register block and the value of is_ledma at init ti

[Qemu-devel] [PATCHv4 00/13] sun4m: sparc32_dma tidy-ups

2017-10-25 Thread Mark Cave-Ayland
This patchset aims to tidy-up the sparc32_dma code by improving the modelling of the espdma/ledma devices using both QOM and the memory API which didn't exist when the code was first written. The result is that it is now possible to remove both the iommu_opaque and is_ledma workarounds from the co

[Qemu-devel] [PATCHv4 09/13] lance: move TYPE_LANCE and SysBusPCNetState from lance.c to lance.h

2017-10-25 Thread Mark Cave-Ayland
This enables them to be used outside of lance.c. Signed-off-by: Mark Cave-Ayland CC: Jason Wang --- hw/net/lance.c | 11 +-- include/hw/net/lance.h | 41 + 2 files changed, 42 insertions(+), 10 deletions(-) create mode 100644 include/

[Qemu-devel] [PATCHv4 05/13] sun4m_iommu: move TYPE_SUN4M_IOMMU declaration to sun4m.h

2017-10-25 Thread Mark Cave-Ayland
This is in preparation to allow the type to be used elsewhere. Signed-off-by: Mark Cave-Ayland Reviewed-by: Artyom Tarasenko Reviewed-by: Philippe Mathieu-Daudé --- hw/dma/sun4m_iommu.c | 14 -- include/hw/sparc/sun4m.h | 16 2 files changed, 16 insertions(

[Qemu-devel] [PATCHv4 07/13] esp: move TYPE_ESP and SysBusESPState from esp.c to esp.h

2017-10-25 Thread Mark Cave-Ayland
This enables them to be used outside of esp.c. Signed-off-by: Mark Cave-Ayland CC: Paolo Bonzini Reviewed-by: Artyom Tarasenko Reviewed-by: Peter Maydell --- hw/scsi/esp.c | 13 - include/hw/scsi/esp.h | 14 ++ 2 files changed, 14 insertions(+), 13 deletion

[Qemu-devel] [PATCHv4 06/13] sparc32_dma: use object link instead of qdev property to pass IOMMU reference

2017-10-25 Thread Mark Cave-Ayland
This enables us to remove the last remaining (opaque) qdev property. Whilst we are here, also update iommu_init() to use TYPE_SUN4M_IOMMU instead of a hardcoded string. Signed-off-by: Mark Cave-Ayland Reviewed-by: Artyom Tarasenko Reviewed-by: Philippe Mathieu-Daudé --- hw/dma/sparc32_dma.c |

[Qemu-devel] [Bug 1371915] Re: Make Uninstall Rule Requested

2017-10-25 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1371915 Title: Make Uninstall Rule Requested Status in QEMU: New Bug description: Enviro

[Qemu-devel] [Bug 1342686] Re: Windows 95 setup hangs

2017-10-25 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

[Qemu-devel] [Bug 1359930] Re: [ARMv5] Integrator/CP regression when reading FPSID register

2017-10-25 Thread Thomas Huth
Patch had been included here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=ed1f13d607e2c64c66bea49d ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/

Re: [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

2017-10-25 Thread David Hildenbrand
On 25.10.2017 17:09, Boris Fiuczynski wrote: > On 10/25/2017 12:23 PM, David Hildenbrand wrote: >> On 25.10.2017 12:18, Christian Borntraeger wrote: >>> Ping, I plan to submit belows patch for 2.11. We can then still look into >>> a libvirt<->qemu interface for limiting host-model depending on mach

[Qemu-devel] [Bug 1361618] Re: sparc cg3 1152x900 display abnormal

2017-10-25 Thread Thomas Huth
Setting this to "invalid" since it's apparently rather a firmware than a QEMU issue. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1361618 Title:

[Qemu-devel] [Bug 1308542] Re: hang in qemu_gluster_init

2017-10-25 Thread Thomas Huth
Closing according to comment #7. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1308542 Title: hang in qemu_gluster_init Status in QEMU: Fi

[Qemu-devel] [Bug 1374905] Re: Pixelation issue in 16-bit color VGA graphics

2017-10-25 Thread Thomas Huth
Did you ever bisect this issue? Does it still occur with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1374905 Title:

[Qemu-devel] [Bug 1336801] Re: 12.04 guest hangs on a 14.04 host server with cirrus graphics

2017-10-25 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

[Qemu-devel] [Bug 1376533] Re: Copyright year should be updated in vl.c

2017-10-25 Thread Thomas Huth
This has been fixed a while ago already, so setting the status to "Fix released" now. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1376533 Tit

Re: [Qemu-devel] [PULL 00/21] Migration pull request

2017-10-25 Thread Peter Maydell
On 23 October 2017 at 17:07, Juan Quintela wrote: > Hi > > This includes: > > - Postocpy bitmap on destination (alexey) > - pre-switchover patches (dave) > - ram_state cleanup (peter) > - reviewed part of set_migrate_state (me) > - grammar fix from eric > - patch reviewed from multifd > > Please,

Re: [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

2017-10-25 Thread David Hildenbrand
On 25.10.2017 17:09, Boris Fiuczynski wrote: > On 10/25/2017 12:23 PM, David Hildenbrand wrote: >> On 25.10.2017 12:18, Christian Borntraeger wrote: >>> Ping, I plan to submit belows patch for 2.11. We can then still look into >>> a libvirt<->qemu interface for limiting host-model depending on mach

[Qemu-devel] [Bug 1373362] Re: qemu-2.1.1 i386-softmmu compile error: q35_dsdt_applesmc_sta undeclared

2017-10-25 Thread Thomas Huth
Closing according to the last comment. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1373362 Title: qemu-2.1.1 i386-softmmu compile error: q3

[Qemu-devel] [Bug 1378407] Re: [feature request] Partition table wrapper for single-filesystem images

2017-10-25 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1378407 Title: [feature request] Partition table wrapper for single-filesystem images Status

[Qemu-devel] [Bug 1290370] Re: FreeBSD 9.2 shell crashes when run with -smp 4 option

2017-10-25 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

Re: [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

2017-10-25 Thread Boris Fiuczynski
On 10/25/2017 12:23 PM, David Hildenbrand wrote: On 25.10.2017 12:18, Christian Borntraeger wrote: Ping, I plan to submit belows patch for 2.11. We can then still look into a libvirt<->qemu interface for limiting host-model depending on machine versions (or not). I think this would be sufficie

Re: [Qemu-devel] [PATCH v3 03/13] m25p80: Add support for BRRD/BRWR and BULK_ERASE (0x60)

2017-10-25 Thread mar.krzeminski
W dniu 24.10.2017 o 21:51, Francisco Iglesias pisze: Add support for the bank address register access commands (BRRD/BRWR) and the BULK_ERASE (0x60) command. Signed-off-by: Francisco Iglesias --- hw/block/m25p80.c | 20 1 file changed, 20 insertions(+) diff --git a/hw

[Qemu-devel] [PULL v1 5/5] tpm: print buffers received from TPM when debugging

2017-10-25 Thread Stefan Berger
Signed-off-by: Stefan Berger Reviewed-by: Marc-André Lureau --- hw/tpm/tpm_tis.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c index 8c5cac5..7402528 100644 --- a/hw/tpm/tpm_tis.c +++ b/hw/tpm/tpm_tis.c @@ -422,6 +422,8 @@ static void tpm_tis_receive_b

[Qemu-devel] [PULL v1 0/5] Merge tpm 2017/10/24

2017-10-25 Thread Stefan Berger
The following series of patches primarily fixes a recent build problem with --disable-tpm. Stefan The following changes since commit 3d7196d43bfe12efe98568cb60057e273652b99b: Merge remote-tracking branch 'remotes/kraxel/tags/usb-20171023-pull-request' into staging (2017-10-24 16:05:57 +

[Qemu-devel] [PULL v1 1/5] tpm: add missing include

2017-10-25 Thread Stefan Berger
From: Philippe Mathieu-Daudé else file including "sysemu/tpm.h" fails to compile: In file included from qemu/stubs/tpm.c:2:0: qemu/include/sysemu/tpm.h:36:19: error: implicit declaration of function ‘object_resolve_path_type’ [-Werror=implicit-function-declaration] Object *obj = obje

[Qemu-devel] [PULL v1 4/5] vl: remove unnecessary #ifdef CONFIG_TPM

2017-10-25 Thread Stefan Berger
From: Philippe Mathieu-Daudé a stub is now provided. Signed-off-by: Philippe Mathieu-Daudé Tested-by: Richard W.M. Jones Reviewed-by: Juan Quintela Signed-off-by: Stefan Berger --- vl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/vl.c b/vl.c index 0723835..ec29909 100644 --- a/vl.c

[Qemu-devel] [PULL v1 3/5] tpm: remove unnecessary #ifdef CONFIG_TPM

2017-10-25 Thread Stefan Berger
From: Philippe Mathieu-Daudé Makefile.objs now checks for $(CONFIG_TPM). Suggested-by: Stefan Berger Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Berger Reviewed-by: Juan Quintela Signed-off-by: Stefan Berger --- tpm.c | 4 1 file changed, 4 deletions(-) diff --git a/tpm

[Qemu-devel] [PULL v1 2/5] tpm: add stubs

2017-10-25 Thread Stefan Berger
From: Philippe Mathieu-Daudé Commit c37cacabf22 moved tpm_cleanup() in the main loop exit, however this function is not available when compiling with --disable-tpm. Provides necessary stubs to keep code clean of #ifdef'fery. Reported-by: BALATON Zoltan Message-Id: <20171023102903.256af745...@z

Re: [Qemu-devel] [PATCH 0/5] Merge tpm 2017/10/24

2017-10-25 Thread Stefan Berger
On 10/25/2017 09:05 AM, Philippe Mathieu-Daudé wrote: Hi Stefan, On 10/25/2017 02:14 AM, Stefan Berger wrote: *The following changes since commit 3d7196d43bfe12efe98568cb60057e273652b99b: Merge remote-tracking branch 'remotes/kraxel/tags/usb-20171023-pull-request' into staging (2017-10-24

Re: [Qemu-devel] [PATCH v3] fix WFI/WFE length in syndrome register

2017-10-25 Thread Peter Maydell
On 24 October 2017 at 18:59, Stefano Stabellini wrote: > WFI/E are often, but not always, 4 bytes long. When they are, we need to > set ARM_EL_IL_SHIFT in the syndrome register. > > Pass the instruction length to HELPER(wfi), use it to decrement pc > appropriately and to pass an is_16bit flag to s

Re: [Qemu-devel] [PULL 0/9] Input 20171023 patches

2017-10-25 Thread Peter Maydell
On 23 October 2017 at 10:19, Gerd Hoffmann wrote: > The following changes since commit e822e81e350825dd94f41ee2538ff1432b812eb9: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2017-10-20 15:04:00 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH] pci-assign: Remove

2017-10-25 Thread Philippe Mathieu-Daudé
> On Fri, Oct 20, 2017 at 10:25:38AM +0200, Paolo Bonzini wrote: >> Legacy PCI device assignment has been removed from Linux in 4.12, >> and had been deprecated 2 years ago there. We can remove it from >> QEMU as well. >> >> The ROM loading code was shared with Xen PCI passthrough, so move >> it t

Re: [Qemu-devel] [RFC 4/6] CLI: add -paused option

2017-10-25 Thread Eduardo Habkost
On Mon, Oct 23, 2017 at 11:49:13AM +0200, Igor Mammedov wrote: > On Fri, 20 Oct 2017 12:21:00 -0200 > Eduardo Habkost wrote: > > > On Fri, Oct 20, 2017 at 12:19:17PM +1100, David Gibson wrote: > > > On Thu, Oct 19, 2017 at 10:15:48PM -0200, Eduardo Habkost wrote: > > > > On Thu, Oct 19, 2017 at

Re: [Qemu-devel] [RFC 4/6] CLI: add -paused option

2017-10-25 Thread Eduardo Habkost
On Mon, Oct 23, 2017 at 01:18:30PM +0200, Igor Mammedov wrote: > On Mon, 23 Oct 2017 11:49:44 +0100 > "Daniel P. Berrange" wrote: > > > On Mon, Oct 23, 2017 at 12:36:20PM +0200, Igor Mammedov wrote: > > > On Mon, 23 Oct 2017 10:53:16 +0100 > > > "Daniel P. Berrange" wrote: > > > > > > > On Mo

Re: [Qemu-devel] [RFC 0/6] enable numa configuration before machine_init() from HMP/QMP

2017-10-25 Thread Eduardo Habkost
On Wed, Oct 25, 2017 at 08:02:06AM +0100, Daniel P. Berrange wrote: > On Wed, Oct 25, 2017 at 08:57:43AM +0200, Eduardo Habkost wrote: > > On Mon, Oct 23, 2017 at 10:45:41AM +0200, Igor Mammedov wrote: > > > On Fri, 20 Oct 2017 17:53:09 -0200 > > > Eduardo Habkost wrote: > > > > > > > On Fri, Oct

Re: [Qemu-devel] Block format 'raw' does not support the option 'locking' when disable image locking with option locking=off

2017-10-25 Thread Fam Zheng
On Wed, 10/25 08:15, Changlimin wrote: > Hi, > When running Oracle RAC, one image is shared between multiple vms, so I want > to disable locking with option locking=off, But Block format 'raw' does not > support the option 'locking'. > How to disable locking? > > The version is git e822e81e35082

Re: [Qemu-devel] [PATCH v2 0/4] tpm: add stubs to fix compiling with --disable-tpm

2017-10-25 Thread Philippe Mathieu-Daudé
Hi Amarnath, On 10/24/2017 03:19 PM, Amarnath Valluri wrote: > On Tue, 2017-10-24 at 09:20 -0300, Philippe Mathieu-Daudé wrote: >> This fixes building with --disable-tpm as reported by Zoltan: >> http://lists.nongnu.org/archive/html/qemu-devel/2017-10/msg05369.html [...] > +1, Nice cleanup in my

Re: [Qemu-devel] [PATCH v7 04/11] target/arm: Don't set INSN_ARM_BE32 for CONFIG_USER_ONLY

2017-10-25 Thread Philippe Mathieu-Daudé
Hi Richard, On 10/21/2017 09:46 PM, Richard Henderson wrote: > This matches translator behaviour in arm_lduw_code. > > Fixes: https://bugs.launchpad.net/qemu/+bug/1724485 > Signed-off-by: Richard Henderson > --- > target/arm/cpu.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-)

Re: [Qemu-devel] [PATCH v7 11/11] disas: Add capstone as submodule

2017-10-25 Thread Philippe Mathieu-Daudé
Hi Richard, >> On 10/21/2017 09:46 PM, Richard Henderson wrote: >>> Do not require the submodule, but use it if present. Allow the >>> command-line to override system or git submodule either way. >>> >>> Signed-off-by: Richard Henderson >>> --- >>> Makefile| 13 + >>> .gitmodule

Re: [Qemu-devel] qemu-img crash when resize a qcow2 file created with preallocation=full/falloc .

2017-10-25 Thread Max Reitz
On 2017-10-25 09:22, Thomas Huth wrote: > On 24.10.2017 05:28, Changlimin wrote: >> Hi, >> I am glad to see that qcow2 file created with preallocation=full/falloc can >> be resized. But when I test it, qemu-img crashs. >> qemu-img: block/qcow2-refcount.c:530: qcow2_refcount_area: Assertion >> `!(

Re: [Qemu-devel] [PATCH 0/5] Merge tpm 2017/10/24

2017-10-25 Thread Philippe Mathieu-Daudé
Hi Stefan, On 10/25/2017 02:14 AM, Stefan Berger wrote: > *The following changes since commit 3d7196d43bfe12efe98568cb60057e273652b99b: > > Merge remote-tracking branch > 'remotes/kraxel/tags/usb-20171023-pull-request' into staging (2017-10-24 > 16:05:57 +0100) > > are available in the git r

Re: [Qemu-devel] Why qemu log start late and qemu start guest so long while using '-mem-prealloc' option?

2017-10-25 Thread Dr. David Alan Gilbert
* Sam (batmanu...@gmail.com) wrote: > Waiting time is different in different server, and different with memory > and cpu usage in one server. > > For HP PowerEdge R720 with 15+ VM running, it's 10+ second. Yes, that doesn't surprise me for a 40GB VM with pre-alloc (depending your total free memor

[Qemu-devel] [PULL 10/11] disas: Remove monitor_disas_is_physical

2017-10-25 Thread Richard Henderson
Even though there is only one monitor, and thus no race on this global data object, there is also no point in having it. We can just as well record the decision in the read_memory_function that we select. Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Be

[Qemu-devel] [PULL 05/11] disas: Remove unused flags arguments

2017-10-25 Thread Richard Henderson
Now that every target is using the disas_set_info hook, the flags argument is unused. Remove it. Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/disas/disas.h | 4 ++-- include/exec/log.h

[Qemu-devel] [PULL 07/11] i386: Support Capstone in disas_set_info

2017-10-25 Thread Richard Henderson
Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- disas.c | 4 target/i386/cpu.c | 7 +++ 2 files changed, 11 insertions(+) diff --git a/disas.c b/disas.c index e392a2926e..63dc573e9f 100644 -

[Qemu-devel] [PULL 08/11] arm: Support Capstone in disas_set_info

2017-10-25 Thread Richard Henderson
Tested-by: Alex Bennée Tested-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- disas.c | 3 +++ target/arm/cpu.c | 21 ++--- 2 files changed, 21 insertions(+), 3 deletions(-) diff --git a/di

[Qemu-devel] [PULL 01/11] target/i386: Convert to disas_set_info hook

2017-10-25 Thread Richard Henderson
Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- disas.c | 22 ++ monitor.c | 21 - target/i386/cpu.c | 12 target/i386/tr

[Qemu-devel] [PULL 11/11] disas: Add capstone as submodule

2017-10-25 Thread Richard Henderson
Do not require the submodule, but use it if present. Allow the command-line to override system or git submodule either way. Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- Makefile| 15 +++ .gitmodules | 3 +++ capsto

[Qemu-devel] [PULL 02/11] target/ppc: Convert to disas_set_info hook

2017-10-25 Thread Richard Henderson
Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- disas.c | 33 - monitor.c | 5 - target/ppc/translate.c | 5 + target/ppc/tra

[Qemu-devel] [PULL 04/11] target/arm: Don't set INSN_ARM_BE32 for CONFIG_USER_ONLY

2017-10-25 Thread Richard Henderson
This matches translator behaviour in arm_lduw_code. Fixes: https://bugs.launchpad.net/qemu/+bug/1724485 Signed-off-by: Richard Henderson --- target/arm/cpu.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 82dad0b721..a92d86f

  1   2   >