Re: [Qemu-devel] [PATCH 26/34] hw/net/ne2000: extract ne2k-isa code from i386/pc to ne2000-isa.c

2017-09-22 Thread David Gibson
On Fri, Sep 22, 2017 at 01:01:03PM -0300, Philippe Mathieu-Daudé wrote: > - add "hw/net/ne2000-isa.h" (and new entry in MAINTAINERS) > - remove the old i386 dependency > > Signed-off-by: Philippe Mathieu-Daudé ppc portion Acked-by: David Gibson > --- > hw/net/ne2000.h | 3 +++ >

Re: [Qemu-devel] [PATCH 2/2] ppc: remove all unused CPU definitions

2017-09-22 Thread David Gibson
On Wed, Sep 20, 2017 at 08:52:21PM +0200, Thomas Huth wrote: > On 19.09.2017 23:36, John Snow wrote: > > Remove *all* unused CPU definitions as indicated by compile-time > > `#if 0` constructs. > > > > Signed-off-by: John Snow > > --- > > target/ppc/cpu-models.h | 223 > > --

Re: [Qemu-devel] [PATCH 30/34] hw/net/pcnet: use TYPE_PCI_PCNET

2017-09-22 Thread David Gibson
On Fri, Sep 22, 2017 at 01:01:07PM -0300, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé ppc portion Acked-by: David Gibson > --- > include/hw/net/pci.h | 1 + > hw/mips/mips_malta.c | 2 +- > hw/net/pcnet-pci.c | 3 +-- > hw/ppc/prep.c| 3 ++- > 4 files chang

Re: [Qemu-devel] [PATCH 22/34] hw/input/i8042: extract API from hw/i386/pc.h

2017-09-22 Thread David Gibson
On Fri, Sep 22, 2017 at 12:40:02PM -0300, Philippe Mathieu-Daudé wrote: > - include vmmouse > - add entries in MAINTAINERS (pckbd.c, i8042.h) > > Signed-off-by: Philippe Mathieu-Daudé ppc portions Acked-by: David Gibson > --- > include/hw/i386/pc.h | 11 --- > include/hw/input/i8

Re: [Qemu-devel] [PATCH 27/34] hw/pci: declare pci_nic_init_nofail() in "hw/net/pci.h"

2017-09-22 Thread David Gibson
On Fri, Sep 22, 2017 at 01:01:04PM -0300, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé ppc portions Acked-by: David Gibson > --- > hw/pci/pci_internal.h | 16 +++ > include/hw/net/pci.h | 20 + > include/hw/pci/pci.h | 4 --- > hw/arm/virt.c

Re: [Qemu-devel] [PATCH 06/34] ppc: remove duplicated includes

2017-09-22 Thread David Gibson
On Fri, Sep 22, 2017 at 12:39:46PM -0300, Philippe Mathieu-Daudé wrote: > applied using ./scripts/clean-includes > > not needed since 7ebaf795560 > > Signed-off-by: Philippe Mathieu-Daudé Acked-by: David Gibson > --- > hw/ppc/spapr_hcall.c | 1 - > target/ppc/kvm.c | 3 --- > 2 files cha

Re: [Qemu-devel] [PATCH 1/2] ppc: remove unused CPU definitions

2017-09-22 Thread David Gibson
On Wed, Sep 20, 2017 at 08:47:43PM +0200, Thomas Huth wrote: > On 19.09.2017 23:36, John Snow wrote: > > Following commit aef77960, remove now-unused definitions from > > cpu-models.h. > > > > Signed-off-by: John Snow > > --- > > target/ppc/cpu-models.h | 32 > >

Re: [Qemu-devel] [PATCH 28/34] hw/net/e1000: use TYPE_PCI_E1000

2017-09-22 Thread David Gibson
On Fri, Sep 22, 2017 at 01:01:05PM -0300, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé ppc portion Acked-by: David Gibson > --- > include/hw/net/pci.h | 2 ++ > hw/alpha/dp264.c | 3 ++- > hw/i386/pc.c | 3 ++- > hw/ppc/ppc440_bamboo.c | 3 ++- > 4 f

Re: [Qemu-devel] [PATCH 32/34] hw/net/ne2000: use TYPE_PCI_NE2000

2017-09-22 Thread David Gibson
On Fri, Sep 22, 2017 at 01:01:09PM -0300, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé ppc portions Acked-by: David Gibson > --- > include/hw/net/pci.h | 1 + > hw/net/ne2000.c | 3 ++- > hw/ppc/mac_newworld.c | 3 ++- > hw/ppc/mac_oldworld.c | 3 ++- > hw/ppc/

Re: [Qemu-devel] [PATCH 01/34] hw: use "qemu/osdep.h" as first #include in source files

2017-09-22 Thread David Gibson
On Fri, Sep 22, 2017 at 12:39:41PM -0300, Philippe Mathieu-Daudé wrote: > applied using ./scripts/clean-includes > > Signed-off-by: Philippe Mathieu-Daudé ppc portion Acked-by: David Gibson > --- > hw/acpi/ipmi-stub.c | 1 + > hw/audio/fmopl.c| 1 - > hw/cpu/core.

Re: [Qemu-devel] [PATCH 24/34] hw/timer/mc146818: rename rtc_init() -> mc146818_init()

2017-09-22 Thread David Gibson
On Fri, Sep 22, 2017 at 01:01:01PM -0300, Philippe Mathieu-Daudé wrote: > and remove the old i386/pc dependency > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: David Gibson > --- > include/hw/timer/mc146818rtc.h | 3 ++- > hw/alpha/dp264.c | 2 +- > hw/i386/pc.c

Re: [Qemu-devel] [PATCH 25/34] hw/timer/m48t59: use TYPE_M48T59_ISA, add entries to MAINTAINERS

2017-09-22 Thread David Gibson
On Fri, Sep 22, 2017 at 01:01:02PM -0300, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé ppc portion Acked-by: David Gibson > --- > include/hw/timer/m48t59.h | 2 ++ > hw/ppc/prep.c | 2 +- > hw/timer/m48t59-isa.c | 2 +- > MAINTAINERS | 2

Re: [Qemu-devel] [PATCH] qga-win: don't hang if vss hold writes timeout

2017-09-22 Thread Tomoki Sekiyama
2017-09-23 12:11 GMT+09:00 Chen Hanxiao : > > 在 2017-09-23 05:12:20,"Tomoki Sekiyama" 写道: > > > > > Thanks for your patch. > > Which version of Windows have you found the hang? > > > > > I tested on win08, win 08 r2 and win2012. > Thank you for the info. The patch looks good to me. Regards,

Re: [Qemu-devel] [PATCH] qga-win: don't hang if vss hold writes timeout

2017-09-22 Thread Chen Hanxiao
在 2017-09-23 05:12:20,"Tomoki Sekiyama" 写道:   >  > Thanks for your patch. > Which version of Windows have you found the hang? >  >  I tested on win08, win 08 r2 and win2012. QGA versions: Use the latest qga-win from https://fedorapeople.org/groups/virt/virtio-win/direct-downloads/archiv

Re: [Qemu-devel] [PATCH 01/20] nvic: Clear the vector arrays and prigroup on reset

2017-09-22 Thread Richard Henderson
On 09/22/2017 09:59 AM, Peter Maydell wrote: > Reset for devices does not include an automatic clear of the > device state (unlike CPU state, where most of the state > structure is cleared to zero). Add some missing initialization > of NVIC state that meant that the device was left in the wrong > s

[Qemu-devel] [PATCH] chardev/baum: fix baum that releases brlapi twice

2017-09-22 Thread Liang Yan
Error process of baum_chr_open needs to set brlapi null, so it won't get released twice in char_braille_finalize, which will cause "/usr/bin/qemu-system-x86_64: double free or corruption (!prev)" Signed-off-by: Liang Yan --- chardev/baum.c | 1 + 1 file changed, 1 insertion(+) diff --git a/char

Re: [Qemu-devel] [PATCH] qga-win: don't hang if vss hold writes timeout

2017-09-22 Thread Tomoki Sekiyama
Thanks for your patch. Which version of Windows have you found the hang? Regards, Tomoki 2017-09-22 11:46 GMT+09:00 Chen Hanxiao : > From: Chen Hanxiao > > When VM is in a heavy IO, if the command "guest-fsfreeze-freeze" > is executed, VSS may timeout when trying to hold writes. > > Inside gues

Re: [Qemu-devel] [PATCH] pci: allow 32-bit PCI IO accesses to pass through the PCI bridge

2017-09-22 Thread Laszlo Ersek
On 09/22/17 14:18, Mark Cave-Ayland wrote: > Whilst the underlying PCI bridge implementation supports 32-bit PCI IO > accesses, unfortunately they are truncated at the legacy 64K limit. > > Signed-off-by: Mark Cave-Ayland > --- > hw/pci/pci_bridge.c |3 ++- > 1 file changed, 2 insertions(+),

Re: [Qemu-devel] [PATCH] pci: allow 32-bit PCI IO accesses to pass through the PCI bridge

2017-09-22 Thread Richard Henderson
On 09/22/2017 07:18 AM, Mark Cave-Ayland wrote: > Whilst the underlying PCI bridge implementation supports 32-bit PCI IO > accesses, unfortunately they are truncated at the legacy 64K limit. > > Signed-off-by: Mark Cave-Ayland > --- > hw/pci/pci_bridge.c |3 ++- > 1 file changed, 2 insertion

Re: [Qemu-devel] [PATCH] MAINTAINERS: Fix subsystem name for "Build and test automation"

2017-09-22 Thread Eric Blake
On 09/21/2017 10:30 PM, Fam Zheng wrote: >>> Build and test automation >>> - >>> +Build and test automation >> >> Would it make sense to use something more specific here? Like "Travis >> and Docker" or so? ... in case we add other subsections in the future? > > Unless we

Re: [Qemu-devel] [PATCH] block/qcow2-bitmap: fix use of uninitialized pointer

2017-09-22 Thread Eric Blake
On 09/22/2017 09:43 AM, Vladimir Sementsov-Ogievskiy wrote: > Without initialization to zero dirty_bitmap field may be not zero > for a bitmap which should not be stored and > qcow2_store_persistent_dirty_bitmaps will erroneously call > store_bitmap for it which leads to SYGSEGV on bdrv_dirty_bitma

Re: [Qemu-devel] [PATCH v2 3/4] fw_cfg: write vmcoreinfo details

2017-09-22 Thread kbuild test robot
Hi Marc-André, [auto build test ERROR on linus/master] [also build test ERROR on v4.14-rc1 next-20170922] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/marcandre-lureau-redhat-com/fw_cfg-add

Re: [Qemu-devel] [RFC v2 33/33] migration: init dst in migration_object_init too

2017-09-22 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Though we may not need it, now we init both the src/dst migration > objects in migration_object_init() so that even incoming migration > object would be thread safe (it was not). > > Signed-off-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert > --- > mi

Re: [Qemu-devel] nbd structured reply

2017-09-22 Thread Eric Blake
On 09/22/2017 09:57 AM, Vladimir Sementsov-Ogievskiy wrote: >> If you have suggestions for improving the NBD spec wording, feel free to >> propose a doc patch. >> > > Thanks, now I understand.. However I don't have good idea of wording.. > > > Another thing: server can send several error and su

Re: [Qemu-devel] [RFC v2 32/33] migration: allow migrate_incoming for paused VM

2017-09-22 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > migrate_incoming command is previously only used when we were providing > "-incoming defer" in the command line, to defer the incoming migration > channel creation. > > However there is similar requirement when we are paused during postcopy > migration. The

Re: [Qemu-devel] [PULL 28/36] tests: Add ubuntu.i386 image

2017-09-22 Thread Programmingkid
> On Sep 22, 2017, at 9:18 AM, Daniel P. Berrange wrote: > > On Fri, Sep 22, 2017 at 08:44:05PM +0800, Fam Zheng wrote: >> On Fri, 09/22 08:10, Programmingkid wrote: >>> Could a Darwin test be added? Both x86 and PowerPC versions would be great. >> >> It's nice to cover macOS in our test, but t

Re: [Qemu-devel] [PATCH] scripts/orderfile: keep MAINTAINERS at bottom

2017-09-22 Thread Eric Blake
On 09/22/2017 11:13 AM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > scripts/git.orderfile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/scripts/git.orderfile b/scripts/git.orderfile > index ac699700b1..34619769c2 100644 > --- a/scripts/git.orderfile >

Re: [Qemu-devel] [PULL 28/36] tests: Add ubuntu.i386 image

2017-09-22 Thread Programmingkid
> On Sep 22, 2017, at 8:44 AM, Fam Zheng wrote: > > On Fri, 09/22 08:10, Programmingkid wrote: >> Could a Darwin test be added? Both x86 and PowerPC versions would be great. > > It's nice to cover macOS in our test, but to be honest I don't know how to do > it. If there isn't any copyright prob

Re: [Qemu-devel] [RFC v2 29/33] migration: return incoming task tag for exec

2017-09-22 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Return the async task tag for exec typed incoming migration in > exec_start_incoming_migration(). > > Signed-off-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert > --- > migration/exec.c | 18 +++--- > migration/exec.h | 2 +- > 2 files cha

Re: [Qemu-devel] [RFC v2 31/33] migration: store listen task tag

2017-09-22 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Store the task tag for migration types: tcp/unix/fd/exec in current > MigrationIncomingState struct. > > For defered migration, no need to store task tag since there is no task > running in the main loop at all. For RDMA, let's mark it as todo. > > Signed-o

Re: [Qemu-devel] [RFC v2 30/33] migration: return incoming task tag for fd

2017-09-22 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Allow to return the task tag in fd_start_incoming_migration(). > > Signed-off-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert > --- > migration/fd.c | 18 +++--- > migration/fd.h | 2 +- > 2 files changed, 12 insertions(+), 8 deletions(-)

Re: [Qemu-devel] [PATCH 30/34] hw/net/pcnet: use TYPE_PCI_PCNET

2017-09-22 Thread Hervé Poussineau
Le 22/09/2017 à 18:01, Philippe Mathieu-Daudé a écrit : Signed-off-by: Philippe Mathieu-Daudé --- include/hw/net/pci.h | 1 + hw/mips/mips_malta.c | 2 +- hw/net/pcnet-pci.c | 3 +-- hw/ppc/prep.c| 3 ++- 4 files changed, 5 insertions(+), 4 deletions(-) Reviewed-by: Hervé Pouss

Re: [Qemu-devel] [PATCH 32/34] hw/net/ne2000: use TYPE_PCI_NE2000

2017-09-22 Thread Hervé Poussineau
Le 22/09/2017 à 18:01, Philippe Mathieu-Daudé a écrit : Signed-off-by: Philippe Mathieu-Daudé --- include/hw/net/pci.h | 1 + hw/net/ne2000.c | 3 ++- hw/ppc/mac_newworld.c | 3 ++- hw/ppc/mac_oldworld.c | 3 ++- hw/ppc/prep.c | 2 +- hw/sparc64/sun4u.c| 3 ++- 6 files

Re: [Qemu-devel] [PATCH 24/34] hw/timer/mc146818: rename rtc_init() -> mc146818_init()

2017-09-22 Thread Hervé Poussineau
Le 22/09/2017 à 18:01, Philippe Mathieu-Daudé a écrit : and remove the old i386/pc dependency Signed-off-by: Philippe Mathieu-Daudé --- include/hw/timer/mc146818rtc.h | 3 ++- hw/alpha/dp264.c | 2 +- hw/i386/pc.c | 2 +- hw/isa/i82378.c| 3 +

Re: [Qemu-devel] [PATCH 22/34] hw/input/i8042: extract API from hw/i386/pc.h

2017-09-22 Thread Hervé Poussineau
Le 22/09/2017 à 17:40, Philippe Mathieu-Daudé a écrit : - include vmmouse - add entries in MAINTAINERS (pckbd.c, i8042.h) Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 11 --- include/hw/input/i8042.h | 30 ++ hw/alpha/dp264.c

Re: [Qemu-devel] [RFC v2 28/33] migration: return incoming task tag for sockets

2017-09-22 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > For socket based incoming migration, we attached a background task onto > main loop to handle the acception of connections. We never had a way to > destroy it before, only if we finished the migration. > > Let's allow socket_start_incoming_migration() to ret

Re: [Qemu-devel] [PATCH 26/34] hw/net/ne2000: extract ne2k-isa code from i386/pc to ne2000-isa.c

2017-09-22 Thread Hervé Poussineau
Le 22/09/2017 à 18:01, Philippe Mathieu-Daudé a écrit : - add "hw/net/ne2000-isa.h" (and new entry in MAINTAINERS) - remove the old i386 dependency Signed-off-by: Philippe Mathieu-Daudé --- hw/net/ne2000.h | 3 +++ include/hw/i386/pc.h| 20 include/

Re: [Qemu-devel] [PATCH 25/34] hw/timer/m48t59: use TYPE_M48T59_ISA, add entries to MAINTAINERS

2017-09-22 Thread Hervé Poussineau
Le 22/09/2017 à 18:01, Philippe Mathieu-Daudé a écrit : Signed-off-by: Philippe Mathieu-Daudé --- include/hw/timer/m48t59.h | 2 ++ hw/ppc/prep.c | 2 +- hw/timer/m48t59-isa.c | 2 +- MAINTAINERS | 2 ++ 4 files changed, 6 insertions(+), 2 deletions(-) Revie

Re: [Qemu-devel] [PATCH 21/34] hw/display/vga: remove the old i386/pc dependency

2017-09-22 Thread Hervé Poussineau
Le 22/09/2017 à 17:40, Philippe Mathieu-Daudé a écrit : move public API to "hw/display/vga.h" and private registers to "hw/display/vga_int_regs.h" Signed-off-by: Philippe Mathieu-Daudé --- ./scripts/get_maintainer.pl -f hw/display/vga* get_maintainer.pl: No maintainers found... hw/display/vg

Re: [Qemu-devel] [PATCH 20/34] hw/timer/i8254: rename pit_init() -> i8254_pit_init()

2017-09-22 Thread Hervé Poussineau
Le 22/09/2017 à 17:40, Philippe Mathieu-Daudé a écrit : - add entry for i82378 in MAINTAINERS - remove the old i386/pc dependency Signed-off-by: Philippe Mathieu-Daudé --- include/hw/timer/i8254.h | 5 +++-- include/hw/timer/i8254_internal.h | 2 +- hw/alpha/dp264.c

Re: [Qemu-devel] [RFC v2 27/33] migration: free SocketAddress where allocated

2017-09-22 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Freeing the SocketAddress struct in socket_start_incoming_migration is > slightly confusing. Let's free the address in the same context where we > allocated it. > > Signed-off-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert > --- > migration/socket.c |

Re: [Qemu-devel] [RFC PATCH] qdev: Mark devices as non-hotpluggable by default

2017-09-22 Thread Cédric Le Goater
On 09/22/2017 09:47 AM, Thomas Huth wrote: > On 21.09.2017 20:50, Eduardo Habkost wrote: >> On Tue, Sep 19, 2017 at 10:55:53AM +0200, Thomas Huth wrote: >>> Historically we've marked all devices as hotpluggable by default. However, >>> most devices are not hotpluggable, and you also need a HotplugH

[Qemu-devel] [PULL v3 00/32] Misc patches for 2017-09-22

2017-09-22 Thread Paolo Bonzini
The following changes since commit b62b7ed0fc9c58e373b8946c9bd2e193be98dae6: Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging (2017-09-20 20:33:48 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fetch

Re: [Qemu-devel] [PULL 00/32] Misc patches for 2017-09-22 (v2)

2017-09-22 Thread Paolo Bonzini
On 22/09/2017 20:09, Peter Maydell wrote: > On 22 September 2017 at 16:04, Paolo Bonzini wrote: >> The following changes since commit b62b7ed0fc9c58e373b8946c9bd2e193be98dae6: >> >> Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into >> staging (2017-09-20 20:33:48 +0100) >> >>

Re: [Qemu-devel] [PATCH RFC] accel: default to an actually available accelerator

2017-09-22 Thread Eduardo Habkost
On Mon, Sep 11, 2017 at 01:51:54PM +0200, Paolo Bonzini wrote: > On 07/09/2017 10:11, Kevin Wolf wrote: > > Am 06.09.2017 um 13:29 hat Cornelia Huck geschrieben: > >> On Wed, 6 Sep 2017 11:49:27 +0200 > >> Cornelia Huck wrote: > >> > >>> configure_accelerator() falls back to tcg if no accelerator

Re: [Qemu-devel] [PULL 00/32] Misc patches for 2017-09-22 (v2)

2017-09-22 Thread Peter Maydell
On 22 September 2017 at 16:04, Paolo Bonzini wrote: > The following changes since commit b62b7ed0fc9c58e373b8946c9bd2e193be98dae6: > > Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging > (2017-09-20 20:33:48 +0100) > > are available in the git repository at: > > git:

Re: [Qemu-devel] [Qemu-trivial] [PATCH 23/34] hw/dma/i8257: rename DMA_init() to i8257_dma_init()

2017-09-22 Thread Philippe Mathieu-Daudé
On 09/22/2017 02:43 PM, Hervé Poussineau wrote: Le 22/09/2017 à 18:01, Philippe Mathieu-Daudé a écrit : [...] +void i8257_dma_init(ISABus *bus, int high_page_enable); + As you're changing the DMA_init prototype, can you add an Error **errp parameter, and pass &error_abort in each caller? S

Re: [Qemu-devel] [PATCH 13/34] hw/ide: remove old i386 dependency

2017-09-22 Thread John Snow
On 09/22/2017 11:39 AM, Philippe Mathieu-Daudé wrote: > and remove a duplicated include > > Signed-off-by: Philippe Mathieu-Daudé Acked-by: John Snow

Re: [Qemu-devel] [PATCH v2 3/4] fw_cfg: write vmcoreinfo details

2017-09-22 Thread kbuild test robot
Hi Marc-André, [auto build test ERROR on linus/master] [also build test ERROR on v4.14-rc1 next-20170922] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/marcandre-lureau-redhat-com/fw_cfg-add

Re: [Qemu-devel] [PATCH 02/34] hw: remove "qemu/osdep.h" from header files

2017-09-22 Thread Philippe Mathieu-Daudé
On 09/22/2017 01:07 PM, Peter Maydell wrote: On 22 September 2017 at 16:39, Philippe Mathieu-Daudé wrote: while here, add entries for ppc4xx_i2c in MAINTAINERS applied using ./scripts/clean-includes Signed-off-by: Philippe Mathieu-Daudé --- This is doing two things at once and would ideall

Re: [Qemu-devel] [PATCH 23/34] hw/dma/i8257: rename DMA_init() to i8257_dma_init()

2017-09-22 Thread Hervé Poussineau
Hi, Le 22/09/2017 à 18:01, Philippe Mathieu-Daudé a écrit : - move the header from hw/isa/ to hw/dma/ - add entry for i82374 in MAINTAINERS - remove the old i386/pc dependency Signed-off-by: Philippe Mathieu-Daudé --- include/hw/{isa/i8257.h => dma/i8257_dma.h} | 6 ++ include/hw/isa/is

[Qemu-devel] qemu-ppc 'tweq' vs gdb

2017-09-22 Thread John Reiser
"qemu-ppc -g 1234 foo" emulating the 32-bit PowerPC instruction 0x7c88 ("tweq r0,r0") terminates with "fatal: Tried to call a TRAP". Instead, when co-operating with gdbserver (-g ) then qemu-ppc should generate a SIGTRAP, just like real execution under gdb. The "tweq r0,r0" and others are use

Re: [Qemu-devel] [PATCH v5 0/7] Generalize MDIO framework

2017-09-22 Thread Alistair Francis
On Fri, Sep 22, 2017 at 10:13 AM, Philippe Mathieu-Daudé wrote: > Hi, > > I have a follow up series using multiples PHY on the MDIO bus based on this > series. I haven't looked at this yet, but it looks interesting. We actually have this concept merged in our tree and it works pretty well. You c

Re: [Qemu-devel] [Qemu-arm] [PATCH 17/20] target/arm: Implement SG instruction

2017-09-22 Thread Peter Maydell
On 22 September 2017 at 16:00, Peter Maydell wrote: > Implement the SG instruction, which we emulate 'by hand' in the > exception handling code path. I've just realised that this patch is correct as far as it goes but it only implements the common path case for SG (where it is in S&NSC memory and

[Qemu-devel] [PATCH v5 4/7] hw/mdio: Mask out read-only bits.

2017-09-22 Thread Philippe Mathieu-Daudé
From: Grant Likely The RST and ANEG_RST bits are commands, not settings. An operating system will get confused (or at least u-boot does) if those bits remain set after writing to them. Therefore, mask them out on write. Similarly, no bits in the ID1, ID2, and remote capability registers are writ

[Qemu-devel] [PATCH v5 7/7] hw/mdio: Use bitbang core for smc91c111 network device

2017-09-22 Thread Philippe Mathieu-Daudé
From: Grant Likely The smc91c111 device has bitbanged MDIO access, but the model doesn't yet implement it. This patch uses the generalized bitbang MDIO support pulled out of etraxfs Ethernet driver. The MDIO state machine is driven by changes in state to the clock control bit in the management r

[Qemu-devel] [PATCH v5 6/7] hw/mdio: Add VMState support

2017-09-22 Thread Philippe Mathieu-Daudé
From: Grant Likely The MDIO model needs to have VMState support before it can be used by devices that support VMState. This patch adds VMState macros for both qemu_mdio and qemu_phy. Signed-off-by: Grant Likely Signed-off-by: Philippe Mathieu-Daudé [PMD: just rebased] --- include/hw/net/mdio.

[Qemu-devel] [PATCH v5 2/7] hw/mdio: Add PHY register definition

2017-09-22 Thread Philippe Mathieu-Daudé
From: Grant Likely Trivial patch to add #defines for defined PHY register address and bit fields Signed-off-by: Grant Likely Signed-off-by: Philippe Mathieu-Daudé --- include/hw/net/mdio.h | 24 ++-- hw/net/mdio.c | 8 2 files changed, 26 insertions(+), 6

[Qemu-devel] [PATCH v5 3/7] hw/mdio: Generalize phy initialization routine

2017-09-22 Thread Philippe Mathieu-Daudé
From: Grant Likely There really isn't anything tdk-specific about tdk_init() other than the phy id registers. The function should instead be generalized for any phy, at least as far as the ID registers are concerned. For the most part the read/write behaviour should be very similar across PHYs.

[Qemu-devel] [PATCH v5 1/7] hw/mdio: Generalize etraxfs MDIO bitbanging emulation

2017-09-22 Thread Philippe Mathieu-Daudé
From: Grant Likely The etraxfs and Xilinx axienet Ethernet models implement quite a nice MDIO core that supports both bitbanging and direct register access. This change factors the common code out into a separate file. There are no functional changes here, just movement of code. The etraxfs and

[Qemu-devel] [PATCH v5 5/7] hw/mdio: Refactor bitbanging state machine

2017-09-22 Thread Philippe Mathieu-Daudé
From: Grant Likely The MDIO state machine has a moderate amount of duplicate code in the state processing that can be consolidated. This patch does so and reorganizes it a bit so that far less code is required. Most of the states simply stream a fixed number of bits in as a single integer and can

[Qemu-devel] [PATCH v5 0/7] Generalize MDIO framework

2017-09-22 Thread Philippe Mathieu-Daudé
Hi, I have a follow up series using multiples PHY on the MDIO bus based on this series. Regards, Phil. Grant's previous work: http://lists.nongnu.org/archive/html/qemu-devel/2013-02/msg00257.html "There is more work to be done, particularly in moving to the common GPIO api, but that work can

Re: [Qemu-devel] [RFC 6/6] linux-user: update default socket.h

2017-09-22 Thread Laurent Vivier
Le 22/09/2017 à 16:02, Carlo Marcelo Arenas Belón a écrit : > * enable SO_REUSEPORT as a sideeffect and add SO_GET_FILTER alias > * make sure 64bit version for ppc is also supported As previously TARGET_PPC64 is not needed. And you should move powerpc bits to linux-user/ppc/sockbits.h Thanks, La

Re: [Qemu-devel] [RFC 5/6] linux-user: fix 64bit versions of sparc and mips

2017-09-22 Thread Laurent Vivier
Le 22/09/2017 à 16:02, Carlo Marcelo Arenas Belón a écrit : > Signed-off-by: Carlo Marcelo Arenas Belón > --- > linux-user/mips64/sockbits.h | 1 + > linux-user/socket.h | 4 ++-- > linux-user/sparc64/sockbits.h | 1 + Who includes the two new files? Moreover TARGET_MIPS/TARGET_SPARC

Re: [Qemu-devel] [PATCH 14/34] hw/ipmi: remove old i386 dependency

2017-09-22 Thread Corey Minyard
On 09/22/2017 10:39 AM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé As mentioned before, I applied this series and did some basic testing, so Reviewed-by: Corey Minyard Tested-by: Corey Minyard --- hw/ipmi/isa_ipmi_bt.c | 1 - hw/ipmi/isa_ipmi_kcs.c | 1 - 2 f

Re: [Qemu-devel] [PATCH 02/34] hw: remove "qemu/osdep.h" from header files

2017-09-22 Thread Corey Minyard
On 09/22/2017 11:07 AM, Peter Maydell wrote: On 22 September 2017 at 16:39, Philippe Mathieu-Daudé wrote: while here, add entries for ppc4xx_i2c in MAINTAINERS applied using ./scripts/clean-includes Signed-off-by: Philippe Mathieu-Daudé --- This is doing two things at once and would ideally

Re: [Qemu-devel] [RFC 4/6] linux-user: refactor socket.h for sparc

2017-09-22 Thread Laurent Vivier
Le 22/09/2017 à 16:02, Carlo Marcelo Arenas Belón a écrit : > fixes SOL_SOCKET and SO_LINGER at least And fix TARGET_SOCK_NONBLOCK and TARGET_SOCK_CLOEXEC values. > > Signed-off-by: Carlo Marcelo Arenas Belón > --- > linux-user/socket.h | 46 ++-- > linux-user/sparc/so

Re: [Qemu-devel] [PATCH 09/34] misc: avoid "include/" in include path

2017-09-22 Thread Peter Maydell
On 22 September 2017 at 16:39, Philippe Mathieu-Daudé wrote: > while here, remove unused #include from aspeed_smc.h > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/input/adb.c | 2 +- > hw/ssi/aspeed_smc.c | 3 +-- > numa.c | 1 - > 3 files changed, 2 insertions(+), 4 dele

Re: [Qemu-devel] [PATCH 07/34] i386/hax: remove duplicated includes

2017-09-22 Thread Peter Maydell
On 22 September 2017 at 16:39, Philippe Mathieu-Daudé wrote: > applied using ./scripts/clean-includes > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/sysemu/hax.h | 1 - > target/i386/hax-darwin.h | 3 --- > target/i386/hax-windows.h | 2 -- > target/i386/hax-darwin.c | 8 ++

Re: [Qemu-devel] [PATCH 08/34] nios2: remove duplicated includes

2017-09-22 Thread Peter Maydell
On 22 September 2017 at 16:39, Philippe Mathieu-Daudé wrote: > applied using ./scripts/clean-includes > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/nios2/cpu.h | 1 - > disas/nios2.c| 3 --- > hw/nios2/boot.c | 1 - > target/nios2/helper.c| 7 ++- >

Re: [Qemu-devel] [RFC 3/6] linux-user: refactor socket.h for mips

2017-09-22 Thread Laurent Vivier
Le 22/09/2017 à 16:02, Carlo Marcelo Arenas Belón a écrit : > fresh bits from linux 4.14, redefine SO_STYLE and {SO,SCM}_TIMESTAMP to > the target values and enables SO_REUSEPORT And you fix TARGET_SOCK_NONBLOCK value. Reviewed-by: Laurent Vivier

Re: [Qemu-devel] [PATCH 06/34] ppc: remove duplicated includes

2017-09-22 Thread Peter Maydell
On 22 September 2017 at 16:39, Philippe Mathieu-Daudé wrote: > applied using ./scripts/clean-includes > > not needed since 7ebaf795560 > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/ppc/spapr_hcall.c | 1 - > target/ppc/kvm.c | 3 --- > 2 files changed, 4 deletions(-) > > diff --git a/

Re: [Qemu-devel] [PATCH 05/34] misc: remove duplicated includes

2017-09-22 Thread Peter Maydell
On 22 September 2017 at 16:39, Philippe Mathieu-Daudé wrote: > exec: housekeeping (funny since 02d0e095031) > > applied using ./scripts/clean-includes > > Signed-off-by: Philippe Mathieu-Daudé > --- > accel/tcg/translate-all.c | 1 - > exec.c | 3 --- > hw/ar

Re: [Qemu-devel] [PULL 0/2] Python next patches

2017-09-22 Thread Peter Maydell
On 22 September 2017 at 15:42, Eduardo Habkost wrote: > The following changes since commit 9ee660e7c138595224b65ddc1c5712549f0a278c: > > Merge remote-tracking branch 'remotes/yongbok/tags/mips-20170921' into > staging (2017-09-21 14:40:32 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] SunOS support

2017-09-22 Thread Peter Tribble
On Fri, Sep 22, 2017 at 5:10 PM, Peter Maydell wrote: > On 22 September 2017 at 16:51, Paolo Bonzini wrote: > > On 22/09/2017 14:05, Peter Maydell wrote: > >> On 20 September 2017 at 19:50, Peter Tribble > wrote: > >>> To introduce myself: I'm a member of the illumos community (the > successor

Re: [Qemu-devel] [PATCH 03/34] block: remove "qemu/osdep.h" from header file

2017-09-22 Thread Peter Maydell
On 22 September 2017 at 16:39, Philippe Mathieu-Daudé wrote: > applied using ./scripts/clean-includes > > Signed-off-by: Philippe Mathieu-Daudé > --- > block/dmg.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/block/dmg.h b/block/dmg.h > index b592d6fa8b..2ecf239ba5 100644 > --- a/bloc

Re: [Qemu-devel] [PATCH 04/34] misc: remove headers implicitly included

2017-09-22 Thread Peter Maydell
On 22 September 2017 at 16:39, Philippe Mathieu-Daudé wrote: > applied using ./scripts/clean-includes > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [RFC 2/6] linux-user: refactor socket.h for alpha

2017-09-22 Thread Laurent Vivier
Le 22/09/2017 à 16:02, Carlo Marcelo Arenas Belón a écrit : > based on fresh bits from linux 4.14 and therefore enabling SO_REUSEPORT > as a side effect > > Signed-off-by: Carlo Marcelo Arenas Belón > --- > linux-user/alpha/sockbits.h | 104 > > linu

[Qemu-devel] [PATCH] scripts/orderfile: keep MAINTAINERS at bottom

2017-09-22 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- scripts/git.orderfile | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/git.orderfile b/scripts/git.orderfile index ac699700b1..34619769c2 100644 --- a/scripts/git.orderfile +++ b/scripts/git.orderfile @@ -27,3 +27,4 @@ Makefile* # code *.c

Re: [Qemu-devel] [PATCH 01/34] hw: use "qemu/osdep.h" as first #include in source files

2017-09-22 Thread Peter Maydell
On 22 September 2017 at 16:39, Philippe Mathieu-Daudé wrote: > applied using ./scripts/clean-includes > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/acpi/ipmi-stub.c | 1 + > hw/audio/fmopl.c| 1 - > hw/cpu/core.c | 1 + > hw/ppc/spapr_cpu_core

[Qemu-devel] [PATCH 32/34] hw/net/ne2000: use TYPE_PCI_NE2000

2017-09-22 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- include/hw/net/pci.h | 1 + hw/net/ne2000.c | 3 ++- hw/ppc/mac_newworld.c | 3 ++- hw/ppc/mac_oldworld.c | 3 ++- hw/ppc/prep.c | 2 +- hw/sparc64/sun4u.c| 3 ++- 6 files changed, 10 insertions(+), 5 deletions(-) diff --git a/include/

Re: [Qemu-devel] [PATCH v7 8/8] tpm: Added support for TPM emulator

2017-09-22 Thread Stefan Berger
On 09/22/2017 08:33 AM, Amarnath Valluri wrote: This change introduces a new TPM backend driver that can communicate with swtpm(software TPM emulator) using unix domain socket interface. QEMU talks to TPM emulator using socket based chardev backend device. talks to the TPM emulator using QEMU's

Re: [Qemu-devel] [RFC 1/6] linux-user: update hppa sockbits

2017-09-22 Thread Laurent Vivier
Le 22/09/2017 à 16:02, Carlo Marcelo Arenas Belón a écrit : > updated to match arch/parisc/include/uapi/asm/socket.h from linux 4.14 > > Signed-off-by: Carlo Marcelo Arenas Belón > --- > linux-user/hppa/sockbits.h | 148 > +++-- > linux-user/socket.h

[Qemu-devel] [PATCH 34/34] misc: drop old i386 dependency

2017-09-22 Thread Philippe Mathieu-Daudé
while here, add an entry for wdt_ib700 in MAINTAINERS Signed-off-by: Philippe Mathieu-Daudé --- hw/char/debugcon.c | 1 - hw/intc/lm32_pic.c | 1 - hw/moxie/moxiesim.c | 1 - hw/sparc/sun4m.c| 1 - hw/watchdog/wdt_ib700.c | 1 - MAINTAINERS | 1 + 6 files change

[Qemu-devel] [PATCH 27/34] hw/pci: declare pci_nic_init_nofail() in "hw/net/pci.h"

2017-09-22 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/pci/pci_internal.h | 16 +++ include/hw/net/pci.h | 20 + include/hw/pci/pci.h | 4 --- hw/arm/virt.c | 1 + hw/mips/mips_malta.c | 1 + hw/pci/pci.c | 67 ++-- hw/pci/p

Re: [Qemu-devel] SunOS support

2017-09-22 Thread Peter Maydell
On 22 September 2017 at 16:51, Paolo Bonzini wrote: > On 22/09/2017 14:05, Peter Maydell wrote: >> On 20 September 2017 at 19:50, Peter Tribble wrote: >>> To introduce myself: I'm a member of the illumos community (the successor >>> to OpenSolaris, to those unfamiliar with us), and I maintain my

[Qemu-devel] [PATCH 26/34] hw/net/ne2000: extract ne2k-isa code from i386/pc to ne2000-isa.c

2017-09-22 Thread Philippe Mathieu-Daudé
- add "hw/net/ne2000-isa.h" (and new entry in MAINTAINERS) - remove the old i386 dependency Signed-off-by: Philippe Mathieu-Daudé --- hw/net/ne2000.h | 3 +++ include/hw/i386/pc.h| 20 include/hw/net/ne2000-isa.h | 33 + h

[Qemu-devel] [PATCH 33/34] hw/alpha: remove old i386 dependency

2017-09-22 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/alpha/alpha_sys.h | 2 -- hw/alpha/pci.c | 2 ++ hw/alpha/typhoon.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/alpha/alpha_sys.h b/hw/alpha/alpha_sys.h index b6d8369ed7..ac685c1c46 100644 --- a/hw/alpha/alpha_sys.

Re: [Qemu-devel] [PATCH 16/34] hw/tpm: remove old i386 dependency

2017-09-22 Thread Stefan Berger
On 09/22/2017 11:39 AM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Berger --- hw/tpm/tpm_passthrough.c | 1 - hw/tpm/tpm_tis.c | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/tpm/tpm_passthrough.c b/hw/tpm/tpm_passthrough.c in

[Qemu-devel] [PATCH 28/34] hw/net/e1000: use TYPE_PCI_E1000

2017-09-22 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- include/hw/net/pci.h | 2 ++ hw/alpha/dp264.c | 3 ++- hw/i386/pc.c | 3 ++- hw/ppc/ppc440_bamboo.c | 3 ++- 4 files changed, 8 insertions(+), 3 deletions(-) diff --git a/include/hw/net/pci.h b/include/hw/net/pci.h index 529591b7f3..b24

[Qemu-devel] [PATCH 24/34] hw/timer/mc146818: rename rtc_init() -> mc146818_init()

2017-09-22 Thread Philippe Mathieu-Daudé
and remove the old i386/pc dependency Signed-off-by: Philippe Mathieu-Daudé --- include/hw/timer/mc146818rtc.h | 3 ++- hw/alpha/dp264.c | 2 +- hw/i386/pc.c | 2 +- hw/isa/i82378.c| 3 ++- hw/mips/mips_fulong2e.c| 2 +- hw/mips/mips_jazz.c

Re: [Qemu-devel] [PATCH 02/34] hw: remove "qemu/osdep.h" from header files

2017-09-22 Thread Peter Maydell
On 22 September 2017 at 16:39, Philippe Mathieu-Daudé wrote: > while here, add entries for ppc4xx_i2c in MAINTAINERS > > applied using ./scripts/clean-includes > > Signed-off-by: Philippe Mathieu-Daudé > --- This is doing two things at once and would ideally be two patches. Still, Reviewed-by:

[Qemu-devel] [PATCH 30/34] hw/net/pcnet: use TYPE_PCI_PCNET

2017-09-22 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- include/hw/net/pci.h | 1 + hw/mips/mips_malta.c | 2 +- hw/net/pcnet-pci.c | 3 +-- hw/ppc/prep.c| 3 ++- 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/include/hw/net/pci.h b/include/hw/net/pci.h index 92111f86f3..5ad5487a91 10

[Qemu-devel] [PATCH 31/34] hw/net/rtl8139: use TYPE_PCI_RTL8139

2017-09-22 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- include/hw/net/pci.h| 1 + hw/arm/realview.c | 3 ++- hw/arm/versatilepb.c| 3 ++- hw/mips/mips_fulong2e.c | 3 ++- hw/net/rtl8139.c| 7 +++ hw/sh4/r2d.c| 5 +++-- 6 files changed, 13 insertions(+), 9 deletions(-) di

[Qemu-devel] [PATCH 25/34] hw/timer/m48t59: use TYPE_M48T59_ISA, add entries to MAINTAINERS

2017-09-22 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- include/hw/timer/m48t59.h | 2 ++ hw/ppc/prep.c | 2 +- hw/timer/m48t59-isa.c | 2 +- MAINTAINERS | 2 ++ 4 files changed, 6 insertions(+), 2 deletions(-) diff --git a/include/hw/timer/m48t59.h b/include/hw/timer/m48t59.h in

[Qemu-devel] [PATCH 29/34] hw/net/e1000e: use TYPE_PCI_E1000E

2017-09-22 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- include/hw/net/pci.h | 1 + hw/net/e1000e.c | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/include/hw/net/pci.h b/include/hw/net/pci.h index b24b5257a5..92111f86f3 100644 --- a/include/hw/net/pci.h +++ b/include/hw/net/pci

[Qemu-devel] [PATCH 23/34] hw/dma/i8257: rename DMA_init() to i8257_dma_init()

2017-09-22 Thread Philippe Mathieu-Daudé
- move the header from hw/isa/ to hw/dma/ - add entry for i82374 in MAINTAINERS - remove the old i386/pc dependency Signed-off-by: Philippe Mathieu-Daudé --- include/hw/{isa/i8257.h => dma/i8257_dma.h} | 6 ++ include/hw/isa/isa.h| 2 -- hw/dma/i82374.c

Re: [Qemu-devel] [PATCH] docker: add installation to build tests

2017-09-22 Thread Paolo Bonzini
On 22/09/2017 14:47, Fam Zheng wrote: > On Fri, 09/22 13:42, Paolo Bonzini wrote: >> Drop ccache on Fedora, because it fails on RHEL 7.4, it is not used >> by any other distro and it is not particularly useful on throwaway >> containers. > > I wonder what exactly failed with ccache? Patchew relies

Re: [Qemu-devel] SunOS support

2017-09-22 Thread Paolo Bonzini
On 22/09/2017 14:05, Peter Maydell wrote: > On 20 September 2017 at 19:50, Peter Tribble wrote: >> To introduce myself: I'm a member of the illumos community (the successor >> to OpenSolaris, to those unfamiliar with us), and I maintain my own illumos >> distribution. >> >> Having seen the scary '

Re: [Qemu-devel] [RFC PATCH qemu] virtio-pci: Replace modern_as with direct access to modern_bar

2017-09-22 Thread Paolo Bonzini
On 22/09/2017 17:12, Alexey Kardashevskiy wrote: > The modern bar is accessed now via yet another address space created just > for that purpose and it does not really need FlatView and dispatch tree > as it has a single memory region so it is just a waste of memory. Things > get even worse when the

  1   2   3   4   >