Re: [Qemu-devel] [PATCH qemu v3 01/13] memory: Postpone flatview and dispatch tree building till all devices are added

2017-09-18 Thread Alexey Kardashevskiy
On 19/09/17 12:09, Alexey Kardashevskiy wrote: > On 19/09/17 00:54, Paolo Bonzini wrote: >> On 18/09/2017 12:16, Alexey Kardashevskiy wrote: >>> Most devices use at least one address space and every time a new address >>> space is added, flat views and dispatch trees are rebuild for all address >>>

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-18 Thread Peter Xu
On Mon, Sep 18, 2017 at 06:09:29PM +0200, Marc-André Lureau wrote: > On Mon, Sep 18, 2017 at 1:26 PM, Dr. David Alan Gilbert > wrote: > > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > >> Hi > >> > >> On Mon, Sep 18, 2017 at 12:55 PM, Dr. David Alan Gilbert > >> wrote: > >> > * Marc-An

Re: [Qemu-devel] [PATCH 5/5] s390x/ccs: add ccw-tester emulated device

2017-09-18 Thread Dong Jia Shi
* Halil Pasic [2017-09-08 12:28:03 +0200]: [snip] > > What Halil pointed out is that the ccw_cb implementation of 3270 > > emulation does not take care of IDALs. This is true. > > > > I can also do that right after this series, if Halil agrees. > > (The 3270 emulation authors are busy of other

Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA

2017-09-18 Thread Dong Jia Shi
* Halil Pasic [2017-09-13 13:50:29 +0200]: > Let's add indirect data addressing support for our virtual channel > subsystem. This implementation does no bother with any kind of > prefetching. We simply step trough the IDAL on demand. > > Signed-off-by: Halil Pasic > --- > hw/s390x/css.c | 109

[Qemu-devel] [Bug 1191326] Re: QNX 4 doesn't boot on qemu >= 1.3

2017-09-18 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1191326 Title: QNX 4 doesn

[Qemu-devel] [Bug 1182490] Re: [qemu-1.5] coroutine-win32.c broken on NULL pointer

2017-09-18 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1182490 Title: [qemu-1.5]

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH] tests: Add a device_add/del HMP test

2017-09-18 Thread Thomas Huth
On 16.09.2017 00:18, Eduardo Habkost wrote: > On Wed, Sep 13, 2017 at 07:45:11AM +0200, Thomas Huth wrote: >> On 12.09.2017 19:37, Eduardo Habkost wrote: >>> On Mon, Sep 11, 2017 at 08:13:21AM +0200, Thomas Huth wrote: On 09.09.2017 22:41, Eduardo Habkost wrote: > On Wed, Sep 06, 2017 at 0

Re: [Qemu-devel] [PATCH v1 2/2] target-arm: Extend PAR format determination

2017-09-18 Thread Edgar E. Iglesias
On Mon, Sep 18, 2017 at 04:50:23PM +0100, Peter Maydell wrote: > On 11 July 2017 at 11:38, Edgar E. Iglesias wrote: > > Another way could also be to have get_phys_addr() fill in generic > > fields in the FaultInfo struct and then have a faultinfo_to_fsr > > mapping function to populate FSR/PAR. Do

Re: [Qemu-devel] [PATCH v2 3/4] virtio-ccw: use ccw data stream

2017-09-18 Thread Dong Jia Shi
* Halil Pasic [2017-09-13 13:50:28 +0200]: > Replace direct access which implicitly assumes no IDA > or MIDA with the new ccw data stream interface which should > cope with these transparently in the future. > > Signed-off-by: Halil Pasic > > --- > > v1 --> v2: > Removed todo comments on poss

[Qemu-devel] [PATCH v2] NUMA: Enable adding NUMA node implicitly

2017-09-18 Thread Dou Liyang
Linux and Windows need ACPI SRAT table to make memory hotplug work properly, however currently QEMU doesn't create SRAT table if numa options aren't present on CLI. Which breaks both linux and windows guests in certain conditions: * Windows: won't enable memory hotplug without SRAT table at all

Re: [Qemu-devel] [PATCH v2 2/4] s390x/css: use ccw data stream

2017-09-18 Thread Dong Jia Shi
* Halil Pasic [2017-09-13 13:50:27 +0200]: > Replace direct access which implicitly assumes no IDA > or MIDA with the new ccw data stream interface which should > cope with these transparently in the future. > > Signed-off-by: Halil Pasic > --- > hw/s390x/css.c | 9 + > 1 file changed,

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-18 Thread Peter Xu
On Mon, Sep 18, 2017 at 11:40:40AM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Fri, Sep 15, 2017 at 04:17:07PM +0100, Dr. David Alan Gilbert wrote: > > > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > > > On Fri, Sep 15, 2017 at 01:29:13PM +0100, Daniel P

Re: [Qemu-devel] [PATCH v2 1/4] s390x/css: introduce css data stream

2017-09-18 Thread Dong Jia Shi
* Halil Pasic [2017-09-13 13:50:26 +0200]: [...] > diff --git a/include/hw/s390x/css.h b/include/hw/s390x/css.h > index 0653d3c9be..79acaf99b7 100644 > --- a/include/hw/s390x/css.h > +++ b/include/hw/s390x/css.h > @@ -75,6 +75,29 @@ typedef struct CMBE { > uint32_t reserved[7]; > } QEMU_PA

Re: [Qemu-devel] [PATCH v8 04/13] tests: Add a test key pair

2017-09-18 Thread Fam Zheng
On Mon, 09/18 10:17, Eric Blake wrote: > On 09/17/2017 09:43 PM, Fam Zheng wrote: > > This will be used by setup test user ssh. > > Shouldn't the commit message have more details about WHY we are checking > in a private key? The conversation last time included useful gems such as: > > Some guests

Re: [Qemu-devel] [PATCH qemu v3 01/13] memory: Postpone flatview and dispatch tree building till all devices are added

2017-09-18 Thread Alexey Kardashevskiy
On 19/09/17 00:54, Paolo Bonzini wrote: > On 18/09/2017 12:16, Alexey Kardashevskiy wrote: >> Most devices use at least one address space and every time a new address >> space is added, flat views and dispatch trees are rebuild for all address >> spaces. This is not a problem for a relatively small

Re: [Qemu-devel] [PATCH] msf2: drop cpu_model to directly use cpu type

2017-09-18 Thread Fam Zheng
On Mon, 09/18 19:11, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > after Igor comment: > http://lists.nongnu.org/archive/html/qemu-devel/2017-09/msg04709.html > > Fam: I'm trying your patchew "apply over series" feature on these 2 series, > hoping they get bot

Re: [Qemu-devel] [PATCH v3 0/6] Convert to realize and improve error handling

2017-09-18 Thread Mao Zhongyi
On 09/19/2017 07:59 AM, John Snow wrote: On 09/18/2017 10:05 AM, Mao Zhongyi wrote: This series mainly implements the conversions of ide, floppy and nvme device to realize. Add some error handling messages and remove the local variable local_err, use errp to propagate the error directly. Als

Re: [Qemu-devel] Disk Image Read Location

2017-09-18 Thread John Snow
On 09/18/2017 02:47 PM, Derrick McKee wrote: > Hi, > Hi Derrick; > I am trying to figure out if a particular disk operation is reading from > the same location in an image file. I am simulating a USB disk, and during Which device handles the USB disk emulation? hw/usb/dev-storage.c? ("usb-st

[Qemu-devel] [PULL 13/13] hw/block/fdc: Convert to realize

2017-09-18 Thread John Snow
From: Mao Zhongyi Convert floppy_drive_init() to realize and rename it to floppy_drive_realize(). Cc: John Snow Cc: Kevin Wolf Cc: Max Reitz Cc: Markus Armbruster Signed-off-by: Mao Zhongyi Reviewed-by: John Snow Message-id: 87119b34f32e2acf7166165fb5d8e6fca787b3bc.1505737465.git.maozy.f

[Qemu-devel] [PULL 12/13] hw/ide: Convert DeviceClass init to realize

2017-09-18 Thread John Snow
From: Mao Zhongyi Replace init with realize in IDEDeviceClass, which has errp as a parameter. So all the implementations now use error_setg instead of error_report for reporting error. Cc: John Snow Cc: Markus Armbruster Cc: Kevin Wolf Cc: Max Reitz Signed-off-by: Mao Zhongyi Reviewed-by:

[Qemu-devel] [PULL 10/13] AHCI: pretty-print FIS to buffer instead of stderr

2017-09-18 Thread John Snow
The current FIS printing routines dump the FIS to screen. adjust this such that it dumps to buffer instead, then use this ability to have FIS dump mechanisms via trace-events instead of compiled defines. Signed-off-by: John Snow Reviewed-by: Stefan Hajnoczi Reviewed-by: Eric Blake Reviewed-by:

Re: [Qemu-devel] [PATCH qemu v3 00/13] memory: Reduce memory use

2017-09-18 Thread Alexey Kardashevskiy
On 19/09/17 00:59, Paolo Bonzini wrote: > On 18/09/2017 12:16, Alexey Kardashevskiy wrote: >> This was inspired by https://bugzilla.redhat.com/show_bug.cgi?id=1481593 >> Previous versions: >> v1: https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg01559.html >> v2: https://lists.gnu.org/archiv

[Qemu-devel] [PULL 11/13] AHCI: remove DPRINTF macro

2017-09-18 Thread John Snow
Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Message-id: 20170901001502.29915-10-js...@redhat.com Signed-off-by: John Snow --- hw/ide/ahci.c | 9 - 1 file changed, 9 deletions(-) d

[Qemu-devel] [PULL 06/13] ATAPI: Replace DEBUG_IDE_ATAPI with tracing events

2017-09-18 Thread John Snow
As part of the ongoing effort to modernize the tracing facilities for the IDE family of devices, remove PRINTFs in the ATAPI device with actual tracing events. Signed-off-by: John Snow Reviewed-by: Stefan Hajnoczi Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Message-id: 20170901

[Qemu-devel] [PULL 07/13] IDE: replace DEBUG_AIO with trace events

2017-09-18 Thread John Snow
Signed-off-by: John Snow Reviewed-by: Stefan Hajnoczi Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Message-id: 20170901001502.29915-6-js...@redhat.com [Edited enum conditional for Clang --js] Signed-off-by: John Snow --- hw/ide/atapi.c| 5 + hw/ide/core.c

[Qemu-devel] [PULL 05/13] IDE: add tracing for data ports

2017-09-18 Thread John Snow
To be used sparingly, but still interesting in the case of small firmwares designed to reproduce bugs in QEMU IDE. Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Message-id: 20170901001502.29915-4-js...@redhat.com Signed-off-by

Re: [Qemu-devel] [PATCH qemu v3 02/13] exec: Explicitely export target AS from address_space_translate_internal

2017-09-18 Thread Alexey Kardashevskiy
On 19/09/17 00:28, Eric Blake wrote: > On 09/18/2017 05:16 AM, Alexey Kardashevskiy wrote: > > Subject line: s/Explicitely/Explicitly/ > >> This is not so mechanical change in order to move to shared FlatViews >> so make it a separate patch. > > Hard to understand; it's unclear whether this is t

[Qemu-devel] [PULL 08/13] AHCI: Replace DPRINTF with trace-events

2017-09-18 Thread John Snow
There are a few hangers-on that will be dealt with individually in forthcoming patches. Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Message-id: 20170901001502.29915-7-js...@redhat.com Signed-off-by: John Snow --- hw/ide/ah

[Qemu-devel] [PULL 13/13] hw/block/fdc: Convert to realize

2017-09-18 Thread John Snow
From: Mao Zhongyi Convert floppy_drive_init() to realize and rename it to floppy_drive_realize(). Cc: John Snow Cc: Kevin Wolf Cc: Max Reitz Cc: Markus Armbruster Signed-off-by: Mao Zhongyi Reviewed-by: John Snow Message-id: 87119b34f32e2acf7166165fb5d8e6fca787b3bc.1505737465.git.maozy.f

[Qemu-devel] [PULL 02/13] hw/ide/microdrive: Mark the dscm1xxxx device with user_creatable = false

2017-09-18 Thread John Snow
From: Thomas Huth QEMU currently aborts with an assertion message when the user is trying to remove a dscm1 again: $ aarch64-softmmu/qemu-system-aarch64 -S -M integratorcp -nographic QEMU 2.9.93 monitor - type 'help' for more information (qemu) device_add dscm1,id=xyz (qemu) device_del x

[Qemu-devel] [PULL 03/13] IDE: replace DEBUG_IDE with tracing system

2017-09-18 Thread John Snow
Remove the DEBUG_IDE preprocessor definition with something more appropriately flexible, using the trace-events subsystem. This will be less prone to bitrot and will more effectively allow us to target just the functions we care about. Signed-off-by: John Snow Reviewed-by: Eric Blake Reviewed-b

[Qemu-devel] [PULL 00/13] Ide patches

2017-09-18 Thread John Snow
The following changes since commit a9158a5cba955b79d580a252cc58ff44d154e370: Merge remote-tracking branch 'remotes/kraxel/tags/audio-20170918-pull-request' into staging (2017-09-18 12:40:54 +0100) are available in the git repository at: https://github.com/jnsnow/qemu.git tag

[Qemu-devel] [PULL 09/13] AHCI: Rework IRQ constants

2017-09-18 Thread John Snow
Create a new enum so that we can name the IRQ bits, which will make debugging them a little nicer if we can print them out. Not handled in this patch, but this will make it possible to get a nice debug printf detailing exactly which status bits are set, as it can be multiple at any given time. As

[Qemu-devel] [PULL 01/13] ide: ahci: unparent children buses before freeing their memory

2017-09-18 Thread John Snow
From: Igor Mammedov Fixes read after freeing error reported https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg04243.html Message-Id: <59a56959-ca12-ea75-33fa-ff07eba1b...@redhat.com> ich9-ahci device creates ide buses and attaches them as QOM children at realize time, however it forge

[Qemu-devel] [PULL 04/13] IDE: Add register hints to tracing

2017-09-18 Thread John Snow
Name the registers for tracing purposes. Signed-off-by: John Snow Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Message-id: 20170901001502.29915-3-js...@redhat.com Signed-off-by: John Snow --- hw/ide/core.c | 88 + hw/ide/trace-

Re: [Qemu-devel] [PATCH v3 0/6] Convert to realize and improve error handling

2017-09-18 Thread John Snow
On 09/18/2017 10:05 AM, Mao Zhongyi wrote: > This series mainly implements the conversions of ide, floppy and nvme > device to realize. Add some error handling messages and remove the local > variable local_err, use errp to propagate the error directly. Also > fix the unusual function name. > >

[Qemu-devel] [RFC v1 0/2] Add a valid_cpu_types property

2017-09-18 Thread Eduardo Habkost
On Mon, Sep 18, 2017 at 06:57:19PM -0300, Philippe Mathieu-Daudé wrote: > add a property to restrict the CPU for SoCs once on machine creation and avoid > duplicate code in each board. > > Signed-off-by: Philippe Mathieu-Daudé The valid_cpu_types approach implemented by Alistair is more generic:

Re: [Qemu-devel] [Qemu-trivial] [PATCH] nbd-client: Use correct macro parenthesization

2017-09-18 Thread Eric Blake
On 09/18/2017 05:13 PM, Philippe Mathieu-Daudé wrote: > Hi Eric, > > On 09/18/2017 06:46 PM, Eric Blake wrote: >> If 'bs' is a complex expression, we were only casting the front half >> rather than the full expression.  Luckily, none of the callers were >> passing bad arguments, but it's better to

Re: [Qemu-devel] [PATCH v2 7/7] block/nbd-client: do not yield from nbd_read_reply_entry

2017-09-18 Thread Eric Blake
On 09/18/2017 08:59 AM, Vladimir Sementsov-Ogievskiy wrote: > Refactor nbd client to not yield from nbd_read_reply_entry. It's > possible now as all reading is done in nbd_read_reply_entry and > all request-related data is stored in per-request s->requests[i]. > > We need here some additional work

Re: [Qemu-devel] [PATCH v2 6/7] block/nbd-client: early fail nbd_read_reply_entry if s->quit is set

2017-09-18 Thread Eric Blake
On 09/18/2017 08:59 AM, Vladimir Sementsov-Ogievskiy wrote: > Do not continue any operation if s->quit is set in parallel. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/nbd-client.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/block/nbd-client.

Re: [Qemu-devel] [PATCH] 9pfs: fix readdir() for 9p2000.u

2017-09-18 Thread Greg Kurz
On Mon, 18 Sep 2017 23:43:17 +0300 Jan Dakinevich wrote: > --- > Greg, > > What do you think about this way? I couldn't reproduce the issue with the symbolic link... can you provide your QEMU command line and the mount options of the 9p filesystem ? Anyway, I had the very same patch in mind be

Re: [Qemu-devel] [Qemu-trivial] [PATCH] nbd-client: Use correct macro parenthesization

2017-09-18 Thread Philippe Mathieu-Daudé
Hi Eric, On 09/18/2017 06:46 PM, Eric Blake wrote: If 'bs' is a complex expression, we were only casting the front half rather than the full expression. Luckily, none of the callers were passing bad arguments, but it's better to be robust up front. Signed-off-by: Eric Blake Reviewed-by: Phi

[Qemu-devel] [PATCH] msf2: drop cpu_model to directly use cpu type

2017-09-18 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- after Igor comment: http://lists.nongnu.org/archive/html/qemu-devel/2017-09/msg04709.html Fam: I'm trying your patchew "apply over series" feature on these 2 series, hoping they get both applied before my patch: Based-on: 1505318697-77161-6-git-send

Re: [Qemu-devel] [Qemu devel v10 PATCH 4/5] msf2: Add Smartfusion2 SoC

2017-09-18 Thread Philippe Mathieu-Daudé
On 09/18/2017 04:23 PM, Subbaraya Sundeep wrote: Smartfusion2 SoC has hardened Microcontroller subsystem and flash based FPGA fabric. This patch adds support for Microcontroller subsystem in the SoC. Signed-off-by: Subbaraya Sundeep Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-D

Re: [Qemu-devel] [PATCH v2 4/7] block/nbd-client: drop reply field from NBDClientSession

2017-09-18 Thread Eric Blake
On 09/18/2017 08:59 AM, Vladimir Sementsov-Ogievskiy wrote: > Drop 'reply' from NBDClientSession. It's used to only deliver request > return code to receiving coroutine. Instead introduce per-request ret > variable to simplify the scheme and make further refactoring possible. > > Signed-off-by: Vl

[Qemu-devel] [RFC PATCH] vl.c: add is_system_on_chip flag to force board default cpu

2017-09-18 Thread Philippe Mathieu-Daudé
add a property to restrict the CPU for SoCs once on machine creation and avoid duplicate code in each board. Signed-off-by: Philippe Mathieu-Daudé --- Based-on: 1505318697-77161-6-git-send-email-imamm...@redhat.com include/hw/boards.h | 3 +++ vl.c| 11 +++ 2 files chan

[Qemu-devel] [PATCH] !fixup arm: missed comment update

2017-09-18 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- Based-on: 1505318697-77161-6-git-send-email-imamm...@redhat.com include/hw/arm/armv7m.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/arm/armv7m.h b/include/hw/arm/armv7m.h index 68cb30d611..9ad316c76e 100644 --- a/includ

[Qemu-devel] [PATCH] nbd-client: Use correct macro parenthesization

2017-09-18 Thread Eric Blake
If 'bs' is a complex expression, we were only casting the front half rather than the full expression. Luckily, none of the callers were passing bad arguments, but it's better to be robust up front. Signed-off-by: Eric Blake --- I plan to take this through my NBD queue, unless it is picked up by

Re: [Qemu-devel] [PATCH v2] hw/sd: fix out-of-bounds check for multi block reads

2017-09-18 Thread Alistair Francis
On Sat, Sep 16, 2017 at 3:35 AM, Michael Olbrich wrote: > The current code checks if the next block exceeds the size of the card. > This generates an error while reading the last block of the card. > Do the out-of-bounds check when starting to read a new block to fix this. > > This issue became vi

Re: [Qemu-devel] [PATCH v4 1/3] Add manpage for QEMU Backup Tool

2017-09-18 Thread Ishani
- On Sep 16, 2017, at 12:41 AM, jsnow js...@redhat.com wrote: > On 09/08/2017 12:41 PM, Ishani Chugh wrote: >> qemu-backup will be a command-line tool for performing full and >> incremental disk backups on running VMs. It is intended as a >> reference implementation for management stack and

Re: [Qemu-devel] [PATCH v4 2/3] backup: Adds Backup Tool

2017-09-18 Thread Ishani
- On Sep 16, 2017, at 12:43 AM, jsnow js...@redhat.com wrote: > On 09/08/2017 12:41 PM, Ishani Chugh wrote: >> qemu-backup will be a command-line tool for performing full and >> incremental disk backups on running VMs. It is intended as a >> reference implementation for management stack and

Re: [Qemu-devel] [PATCH] default-configs: Replace $(and ...) with $(call land, ...)

2017-09-18 Thread Paolo Bonzini
On 18/09/2017 20:32, Thomas Huth wrote: > Using $(and ...) is dangerous here: It only works as long as the first > argument is set to 'y' or completely unset. It does not work if the > first argument is set to 'n' for example. Let's use the "land" make > function instead which has been written exp

Re: [Qemu-devel] [PATCH 00/17] Initial i.MX7 support

2017-09-18 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 00/17] Initial i.MX7 support Message-id: 20170918195100.17593-1-andrew.smir...@gmail.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log

Re: [Qemu-devel] [PATCH] block/throttle-groups.c: allocate RestartData on the heap

2017-09-18 Thread Eric Blake
On 09/18/2017 03:25 PM, Manos Pitsidianakis wrote: > RestartData is the opaque data of the throttle_group_restart_queue_entry > coroutine. By being stack allocated, it isn't available anymore if > aio_co_enter schedules the coroutine with a bottom halve and runs after s/halve/half/ > throttle_gro

[Qemu-devel] [PATCH] block/throttle-groups.c: allocate RestartData on the heap

2017-09-18 Thread Manos Pitsidianakis
RestartData is the opaque data of the throttle_group_restart_queue_entry coroutine. By being stack allocated, it isn't available anymore if aio_co_enter schedules the coroutine with a bottom halve and runs after throttle_group_restart_queue returns. Signed-off-by: Manos Pitsidianakis --- block/t

Re: [Qemu-devel] [PATCH v1 23/27] s390x/tcg: implement STOP and RESET interrupts for TCG

2017-09-18 Thread David Hildenbrand
On 18.09.2017 22:00, David Hildenbrand wrote: > >> static void cpu_inject_io(S390CPU *cpu, uint16_t subchannel_id, >> diff --git a/target/s390x/sigp.c b/target/s390x/sigp.c >> index ce8fda9d01..521dcc75f3 100644 >> --- a/target/s390x/sigp.c >> +++ b/target/s390x/sigp.c >> @@ -498,6 +498,7 @@ void

Re: [Qemu-devel] [PATCH v1 23/27] s390x/tcg: implement STOP and RESET interrupts for TCG

2017-09-18 Thread David Hildenbrand
> static void cpu_inject_io(S390CPU *cpu, uint16_t subchannel_id, > diff --git a/target/s390x/sigp.c b/target/s390x/sigp.c > index ce8fda9d01..521dcc75f3 100644 > --- a/target/s390x/sigp.c > +++ b/target/s390x/sigp.c > @@ -498,6 +498,7 @@ void do_stop_interrupt(CPUS390XState *env) > s390

[Qemu-devel] [PATCH 12/17] i.MX: Add i.MX7 CCM, PMU and ANALOG device

2017-09-18 Thread Andrey Smirnov
Cc: Peter Maydell Cc: qemu-devel@nongnu.org Cc: qemu-...@nongnu.org Cc: yurov...@gmail.com Signed-off-by: Andrey Smirnov --- hw/misc/Makefile.objs | 1 + hw/misc/imx7_ccm.c | 201 + include/hw/misc/imx7_ccm.h | 76 + 3 f

[Qemu-devel] [PATCH 13/17] i.MX: Add code to emulate i.MX2 watchdog IP block

2017-09-18 Thread Andrey Smirnov
Add enough code to emulate i.MX2 watchdog IP block so it would be possible to reboot the machine running Linux Guest. Cc: Peter Maydell Cc: qemu-devel@nongnu.org Cc: qemu-...@nongnu.org Cc: yurov...@gmail.com Signed-off-by: Andrey Smirnov --- hw/misc/Makefile.objs | 1 + hw/misc/imx2_wdt

[Qemu-devel] [PATCH 16/17] i.MX: Add i.MX7 SOC implementation.

2017-09-18 Thread Andrey Smirnov
For now we only support the following devices: * up to 2 Cortex A9 cores (SMP works with PSCI) * A7 MPCORE (identical to A15 MPCORE) * 7 i.MX UARTs * 1 CCM device * 2 Ethernet controllers (FEC) * 3 SD controllers (USDHC) * 1 SNVS device * 1 WDT device Cc: Peter Mayd

[Qemu-devel] [PATCH 15/17] include/qemu: Add sizes.h from Linux

2017-09-18 Thread Andrey Smirnov
Add sizes.h from Linux to have a more readable way of specifying MemoryRegion sizes. Cc: Peter Maydell Cc: qemu-devel@nongnu.org Cc: qemu-...@nongnu.org Cc: yurov...@gmail.com Signed-off-by: Andrey Smirnov --- include/qemu/sizes.h | 47 +++ 1 file cha

[Qemu-devel] [PATCH 08/17] imx_fec: Add support for multiple Tx DMA rings

2017-09-18 Thread Andrey Smirnov
More recent version of the IP block support more than one Tx DMA ring, so add the code implementing that feature. Cc: Peter Maydell Cc: Jason Wang Cc: qemu-devel@nongnu.org Cc: qemu-...@nongnu.org Cc: yurov...@gmail.com Signed-off-by: Andrey Smirnov --- hw/net/imx_fec.c | 97 ++

[Qemu-devel] [PATCH 14/17] i.MX7: Add code to emulate SNVS IP-block

2017-09-18 Thread Andrey Smirnov
Add code to emulate SNVS IP-block. Currently only the bits needed to be able to emulate machine shutdown are implemented. Cc: Peter Maydell Cc: qemu-devel@nongnu.org Cc: qemu-...@nongnu.org Cc: yurov...@gmail.com Signed-off-by: Andrey Smirnov --- hw/misc/Makefile.objs | 1 + hw/misc/imx7

[Qemu-devel] [PATCH 06/17] imx_fec: Use MIN instead of explicit ternary operator

2017-09-18 Thread Andrey Smirnov
Cc: Peter Maydell Cc: Jason Wang Cc: qemu-devel@nongnu.org Cc: qemu-...@nongnu.org Cc: yurov...@gmail.com Signed-off-by: Andrey Smirnov --- hw/net/imx_fec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c index 989c11be5f..8a77136d38 10064

[Qemu-devel] [PATCH 01/17] imx_fec: Do not link to netdev

2017-09-18 Thread Andrey Smirnov
Binding to a particular netdev doesn't seem to belong to this layer and should probably be done as a part of board or SoC specific code. Convert all of the users of this IP block to use qdev_set_nic_properties() instead. Cc: Peter Maydell Cc: Jason Wang Cc: qemu-devel@nongnu.org Cc: qemu-...@no

[Qemu-devel] [PATCH 17/17] Implement support for i.MX7 Sabre board

2017-09-18 Thread Andrey Smirnov
Cc: Peter Maydell Cc: qemu-devel@nongnu.org Cc: qemu-...@nongnu.org Cc: yurov...@gmail.com Signed-off-by: Andrey Smirnov --- hw/arm/Makefile.objs | 2 +- hw/arm/mcimx7d-sabre.c | 100 + 2 files changed, 101 insertions(+), 1 deletion(-) create

[Qemu-devel] [PATCH 11/17] sdhci: Implement write method of ACMD12ERRSTS register

2017-09-18 Thread Andrey Smirnov
Cc: Peter Maydell Cc: qemu-devel@nongnu.org Cc: qemu-...@nongnu.org Cc: yurov...@gmail.com Signed-off-by: Andrey Smirnov --- hw/sd/sdhci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index 73e7910ba9..9249471957 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhc

[Qemu-devel] [PATCH 04/17] imx_fec: Change queue flushing heuristics

2017-09-18 Thread Andrey Smirnov
In current implementation, packet queue flushing logic seem to suffer from a deadlock like scenario if a packet is received by the interface before before Rx ring is initialized by Guest's driver. Consider the following sequence of events: 1. A QEMU instance is started against a TAP device

[Qemu-devel] [PATCH 03/17] imx_fec: Refactor imx_eth_enable_rx()

2017-09-18 Thread Andrey Smirnov
Refactor imx_eth_enable_rx() to have more meaningfull variable name than 'tmp' and to reduce number of logical negations done. Cc: Peter Maydell Cc: Jason Wang Cc: qemu-devel@nongnu.org Cc: qemu-...@nongnu.org Cc: yurov...@gmail.com Signed-off-by: Andrey Smirnov --- hw/net/imx_fec.c | 8 --

[Qemu-devel] [PATCH 10/17] sdhci: Add i.MX specific subtype of SDHCI

2017-09-18 Thread Andrey Smirnov
IP block found on several generations of i.MX family does not use vanilla SDHCI implementation and it comes with a number of quirks. Introduce i.MX SDHCI subtype of SDHCI block to add code necessary to support unmodified Linux guest driver. Cc: Peter Maydell Cc: qemu-devel@nongnu.org Cc: qemu-..

[Qemu-devel] [PATCH 07/17] imx_fec: Emulate SHIFT16 in ENETx_RACC

2017-09-18 Thread Andrey Smirnov
Needed to support latest Linux kernel driver which relies on that functionality. Cc: Peter Maydell Cc: Jason Wang Cc: qemu-devel@nongnu.org Cc: qemu-...@nongnu.org Cc: yurov...@gmail.com Signed-off-by: Andrey Smirnov --- hw/net/imx_fec.c | 23 +++ include/hw/net/imx

[Qemu-devel] [PATCH 05/17] imx_fec: Use ENET_FTRL to determine truncation length

2017-09-18 Thread Andrey Smirnov
Frame truncation length, TRUNC_FL, is determined by the contents of ENET_FTRL register, so convert the code to use it instead of a hardcoded constant. Cc: Peter Maydell Cc: Jason Wang Cc: qemu-devel@nongnu.org Cc: qemu-...@nongnu.org Cc: yurov...@gmail.com Signed-off-by: Andrey Smirnov --- hw/

Re: [Qemu-devel] [PATCH v2 2/7] block/nbd-client: exit reply-reading coroutine on incorrect handle

2017-09-18 Thread Eric Blake
On 09/18/2017 08:59 AM, Vladimir Sementsov-Ogievskiy wrote: > Check reply-handle == request-handle in the same place, where > recv coroutine number is calculated from reply->handle and it's > correctness checked - in nbd_read_reply_entry. > > Also finish nbd_read_reply_entry in case of reply-handl

[Qemu-devel] [PATCH 00/17] Initial i.MX7 support

2017-09-18 Thread Andrey Smirnov
Hi everyone, This patch series contains the work that I've done in order to enable support for i.MX7 emulation in QEMU. Majority of the set are just odd fixes and small features implementation that I had to do to already exisitng code but last 5 commits contain new emulation code. As the one befo

[Qemu-devel] [PATCH 02/17] imx_fec: Do not calculate FEC

2017-09-18 Thread Andrey Smirnov
Save some computation time and avoid calculating CRC's frame Cc: Peter Maydell Cc: Jason Wang Cc: qemu-devel@nongnu.org Cc: qemu-...@nongnu.org Cc: yurov...@gmail.com Signed-off-by: Andrey Smirnov --- hw/net/imx_fec.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a

[Qemu-devel] [PATCH 09/17] imx_fec: Use correct length for packet size

2017-09-18 Thread Andrey Smirnov
Use 'frame_size' instead of 'len' when calling qemu_send_packet(), failing to do so results in malformed packets send in case when that packed is fragmented into multiple DMA transactions. Cc: Peter Maydell Cc: Jason Wang Cc: qemu-devel@nongnu.org Cc: qemu-...@nongnu.org Cc: yurov...@gmail.com S

[Qemu-devel] [Qemu devel v10 PATCH 5/5] msf2: Add Emcraft's Smartfusion2 SOM kit

2017-09-18 Thread Subbaraya Sundeep
Emulated Emcraft's Smartfusion2 System On Module starter kit. Signed-off-by: Subbaraya Sundeep Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- hw/arm/Makefile.objs | 2 +- hw/arm/msf2-som.c| 94 2 files changed

[Qemu-devel] [Qemu devel v10 PATCH 3/5] msf2: Add Smartfusion2 SPI controller

2017-09-18 Thread Subbaraya Sundeep
Modelled Microsemi's Smartfusion2 SPI controller. Signed-off-by: Subbaraya Sundeep Reviewed-by: Alistair Francis Tested-by: Philippe Mathieu-Daudé --- hw/ssi/Makefile.objs | 1 + hw/ssi/mss-spi.c | 404 +++ include/hw/ssi/mss-spi.h | 5

Re: [Qemu-devel] Disk Image Read Location

2017-09-18 Thread Max Reitz
On 2017-09-18 20:47, Derrick McKee wrote: > Hi, > > I am trying to figure out if a particular disk operation is reading from > the same location in an image file. I am simulating a USB disk, and during > an operation the guest OS performs, I would like to know how many times the > backing image f

[Qemu-devel] [Qemu devel v10 PATCH 1/5] msf2: Add Smartfusion2 System timer

2017-09-18 Thread Subbaraya Sundeep
Modelled System Timer in Microsemi's Smartfusion2 Soc. Timer has two 32bit down counters and two interrupts. Signed-off-by: Subbaraya Sundeep Reviewed-by: Alistair Francis Acked-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- hw/timer/Makefile.objs | 1 + hw/timer/mss

[Qemu-devel] [Qemu devel v10 PATCH 4/5] msf2: Add Smartfusion2 SoC

2017-09-18 Thread Subbaraya Sundeep
Smartfusion2 SoC has hardened Microcontroller subsystem and flash based FPGA fabric. This patch adds support for Microcontroller subsystem in the SoC. Signed-off-by: Subbaraya Sundeep Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- defau

[Qemu-devel] [Qemu devel v10 PATCH 0/5] Add support for Smartfusion2 SoC

2017-09-18 Thread Subbaraya Sundeep
Hi Qemu-devel, I am trying to add Smartfusion2 SoC. SoC is from Microsemi and System on Module(SOM) board is from Emcraft systems. Smartfusion2 has hardened Microcontroller(Cortex-M3)based Sub System and FPGA fabric. At the moment only system timer, sysreg and SPI controller are modelled. Testing

[Qemu-devel] [Qemu devel v10 PATCH 2/5] msf2: Microsemi Smartfusion2 System Register block

2017-09-18 Thread Subbaraya Sundeep
Added Sytem register block of Smartfusion2. This block has PLL registers which are accessed by guest. Signed-off-by: Subbaraya Sundeep Reviewed-by: Alistair Francis Acked-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- hw/misc/Makefile.objs | 1 + hw/misc/msf2-sysre

[Qemu-devel] [Bug 1715700] Re: Windows 7 guest won't boot on qemu 2.10 (works on 2.9)

2017-09-18 Thread Aleksei Kovura
Just did a test to be sure: pulled latest git (a9158a5cba955b79d580a252cc58ff44d154e370) - guest didn't launch. Reverted 208fa0e43645edd0b0d8f838857dfc79daff40a8 - guest launched successfully. Can someone please take a look at this? I don't want to get stuck at 2.9.0 :) -- You received this bug

Re: [Qemu-devel] [PATCH v2 5/7] block/nbd-client: nbd_co_send_request: return -EIO if s->quit was set in parallel

2017-09-18 Thread Eric Blake
On 09/18/2017 11:01 AM, Eric Blake wrote: > On 09/18/2017 08:59 AM, Vladimir Sementsov-Ogievskiy wrote: >> It's incorrect to return success rc >= 0 if we skip qio_channel_writev_all() >> call due to s->quit. > > Does this need to cc: qemu-stable for 2.10.1 (or put another way, can we > come up wit

[Qemu-devel] [PATCH v8 19/20] dirty-bitmap: Switch bdrv_set_dirty() to bytes

2017-09-18 Thread Eric Blake
Both callers already had bytes available, but were scaling to sectors. Move the scaling to internal code. In the case of bdrv_aligned_pwritev(), we are now passing the exact offset rather than a rounded sector-aligned value, but that's okay as long as dirty bitmap widens start/bytes to granularit

[Qemu-devel] [PATCH v8 18/20] qcow2: Switch store_bitmap_data() to byte-based iteration

2017-09-18 Thread Eric Blake
Now that we have adjusted the majority of the calls this function makes to be byte-based, it is easier to read the code if it makes passes over the image using bytes rather than sectors. Signed-off-by: Eric Blake Reviewed-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy --- v7: rebase t

[Qemu-devel] [PATCH v8 17/20] qcow2: Switch load_bitmap_data() to byte-based iteration

2017-09-18 Thread Eric Blake
Now that we have adjusted the majority of the calls this function makes to be byte-based, it is easier to read the code if it makes passes over the image using bytes rather than sectors. Signed-off-by: Eric Blake Reviewed-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy --- v5: no chang

[Qemu-devel] [PATCH v8 14/20] dirty-bitmap: Change bdrv_[re]set_dirty_bitmap() to use bytes

2017-09-18 Thread Eric Blake
Some of the callers were already scaling bytes to sectors; others can be easily converted to pass byte offsets, all in our shift towards a consistent byte interface everywhere. Making the change will also make it easier to write the hold-out callers to use byte rather than sectors for their iterat

[Qemu-devel] [PATCH v8 15/20] mirror: Switch mirror_dirty_init() to byte-based iteration

2017-09-18 Thread Eric Blake
Now that we have adjusted the majority of the calls this function makes to be byte-based, it is easier to read the code if it makes passes over the image using bytes rather than sectors. Signed-off-by: Eric Blake Reviewed-by: John Snow --- v6: no change v5: rebase to earlier changes v2-v4: no c

[Qemu-devel] [PATCH v8 20/20] dirty-bitmap: Convert internal hbitmap size/granularity

2017-09-18 Thread Eric Blake
Now that all callers are using byte-based interfaces, there's no reason for our internal hbitmap to remain with sector-based granularity. It also simplifies our internal scaling, since we already know that hbitmap widens requests out to granularity boundaries. Signed-off-by: Eric Blake Reviewed-

[Qemu-devel] [PATCH v8 16/20] qcow2: Switch qcow2_measure() to byte-based iteration

2017-09-18 Thread Eric Blake
This is new code, but it is easier to read if it makes passes over the image using bytes rather than sectors (and will get easier in the future when bdrv_get_block_status is converted to byte-based). Signed-off-by: Eric Blake Reviewed-by: John Snow --- v7: tweak constant given to MIN (no semant

[Qemu-devel] [PATCH v8 12/20] dirty-bitmap: Change bdrv_get_dirty_count() to report bytes

2017-09-18 Thread Eric Blake
Thanks to recent cleanups, all callers were scaling a return value of sectors into bytes; do the scaling internally instead. Signed-off-by: Eric Blake Reviewed-by: John Snow --- v8: no change, add R-b v7: fix one more trace caller [Kevin] v4-v6: no change v3: no change, add R-b v2: no change --

[Qemu-devel] [PATCH v8 11/20] dirty-bitmap: Change bdrv_dirty_iter_next() to report byte offset

2017-09-18 Thread Eric Blake
Thanks to recent cleanups, most callers were scaling a return value of sectors into bytes (the exception, in qcow2-bitmap, will be converted to byte-based iteration later). Update the interface to do the scaling internally instead. In qcow2-bitmap, the code was specifically checking for an error

[Qemu-devel] [PATCH v8 13/20] dirty-bitmap: Change bdrv_get_dirty_locked() to take bytes

2017-09-18 Thread Eric Blake
Half the callers were already scaling bytes to sectors; the other half can eventually be simplified to use byte iteration. Both callers were already using the result as a bool, so make that explicit. Making the change also makes it easier for a future dirty-bitmap patch to offload scaling over to

[Qemu-devel] [PATCH v8 07/20] dirty-bitmap: Track bitmap size by bytes

2017-09-18 Thread Eric Blake
We are still using an internal hbitmap that tracks a size in sectors, with the granularity scaled down accordingly, because it lets us use a shortcut for our iterators which are currently sector-based. But there's no reason we can't track the dirty bitmap size in bytes, since it is (mostly) an inte

[Qemu-devel] [PATCH v8 09/20] qcow2: Switch sectors_covered_by_bitmap_cluster() to byte-based

2017-09-18 Thread Eric Blake
We are gradually converting to byte-based interfaces, as they are easier to reason about than sector-based. Change the qcow2 bitmap helper function sectors_covered_by_bitmap_cluster(), renaming it to bytes_covered_by_bitmap_cluster() in the process. Signed-off-by: Eric Blake Reviewed-by: John Sn

[Qemu-devel] [PATCH v8 10/20] dirty-bitmap: Set iterator start by offset, not sector

2017-09-18 Thread Eric Blake
All callers to bdrv_dirty_iter_new() passed 0 for their initial starting point, drop that parameter. Most callers to bdrv_set_dirty_iter() were scaling a byte offset to a sector number; the exception qcow2-bitmap will be converted later to use byte rather than sector iteration. Move the scaling t

[Qemu-devel] [PATCH v8 08/20] dirty-bitmap: Change bdrv_dirty_bitmap_*serialize*() to take bytes

2017-09-18 Thread Eric Blake
Right now, the dirty-bitmap code exposes the fact that we use a scale of sector granularity in the underlying hbitmap to anything that wants to serialize a dirty bitmap. It's nicer to uniformly expose bytes as our dirty-bitmap interface, matching the previous change to bitmap size. The only calle

[Qemu-devel] [PATCH v8 05/20] dirty-bitmap: Avoid size query failure during truncate

2017-09-18 Thread Eric Blake
We've previously fixed several places where we failed to account for possible errors from bdrv_nb_sectors(). Fix another one by making bdrv_dirty_bitmap_truncate() take the new size from the caller instead of querying itself; then adjust the sole caller bdrv_truncate() to pass the size just determ

  1   2   3   4   >