On 12.09.2017 16:44, Paolo Bonzini wrote:
> The purpose of this series is to separate the "check" sources from
> the tests. After these patches, common.config is reduced to simple
> shell initialization, and common.rc is only included by the tests.
>
> Along the way, a lot of dead code is removed
Add Marc-André Lureau and Peter Xu as dump maintainers.
CC: Marc-André Lureau
Signed-off-by: Peter Xu
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 36eeb42..31ede5f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1248,6 +1248,12 @@ F: d
On Wed, Sep 13, 2017 at 12:23:13PM +1000, Alexey Kardashevskiy wrote:
> On 13/09/17 02:46, Mark Cave-Ayland wrote:
> > On 12/09/17 17:41, Mark Cave-Ayland wrote:
> >
> >> The commit message mentions that prior to the conversion some CPU state
> >> was missing but it doesn't mention anything about
On Tue, Sep 12, 2017 at 12:17:51PM +0200, Marc-André Lureau wrote:
> Hi Peter
>
> On Tue, Sep 12, 2017 at 5:33 AM, Peter Xu wrote:
> > On Mon, Sep 11, 2017 at 03:26:27PM +0200, Cornelia Huck wrote:
> >> It does not really make sense to dump memory that is not there.
> >>
> >> Moreover, that fixes
On 12.09.2017 19:37, Eduardo Habkost wrote:
> On Mon, Sep 11, 2017 at 08:13:21AM +0200, Thomas Huth wrote:
>> On 09.09.2017 22:41, Eduardo Habkost wrote:
>>> On Wed, Sep 06, 2017 at 08:59:32AM +0200, Markus Armbruster wrote:
Thomas Huth writes:
> On 05.09.2017 18:48, Dr. David Alan G
On Tue, Sep 12, 2017 at 04:01:47PM +0200, Laurent Vivier wrote:
> Running QEMU with
> qemu-system-ppc64 -M none -nographic -m 256
> and executing
> dump-guest-memory /dev/null 0 8192
> results in segfault
>
> Fix by checking if we have CPU, and exit with
> error if there is no CPU:
>
>
On Wed, Sep 13, 2017 at 12:24:53AM +0200, Greg Kurz wrote:
> When running with KVM PR, if a new HPT is allocated we need to inform
> KVM about the HPT address and size. This is currently done with a hack
> which is open-coded in several places.
>
> This patch consolidate the code in a dedicated he
On Tue, Sep 12, 2017 at 04:36:30PM +0100, Dr. David Alan Gilbert wrote:
> * Thomas Huth (th...@redhat.com) wrote:
> > On 12.09.2017 16:46, Greg Kurz wrote:
> > > On Tue, 12 Sep 2017 16:01:46 +0200
> > > Laurent Vivier wrote:
> > >
> > >> Fix aarch64 and ppc when dump-guest-memory is
> > >> used w
On Mon, Sep 11, 2017 at 12:58:15PM +0100, Dr. David Alan Gilbert wrote:
> * Peter Xu (pet...@redhat.com) wrote:
> > On Thu, Aug 24, 2017 at 08:27:17PM +0100, Dr. David Alan Gilbert (git)
> > wrote:
> > > From: "Dr. David Alan Gilbert"
> > >
> > > Resolve fault addresses read off the clients UFD
On Tue, Sep 12, 2017 at 06:15:13PM +0100, Dr. David Alan Gilbert wrote:
> * Peter Xu (pet...@redhat.com) wrote:
> > On Thu, Aug 24, 2017 at 08:27:14PM +0100, Dr. David Alan Gilbert (git)
> > wrote:
> > > From: "Dr. David Alan Gilbert"
> > >
> > > We need a better way, but at the moment we need t
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH v7 00/13] tests: Add VM based build tests (for
non-x86_64 and/or non-Linux)
Message-id: 20170913030119.3957-1-f...@redhat.com
Type: series
=== TEST SCRIPT BEGIN ===
#!/b
Signed-off-by: Fam Zheng
---
tests/docker/Makefile.include | 15 ++-
tests/docker/run | 8 +---
2 files changed, 3 insertions(+), 20 deletions(-)
diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index aaab1a4208..7a027d5bd6 100644
--- a/tes
Signed-off-by: Fam Zheng
---
Makefile | 2 ++
configure | 2 +-
tests/vm/Makefile.include | 42 ++
3 files changed, 45 insertions(+), 1 deletion(-)
create mode 100644 tests/vm/Makefile.include
diff --git a/Makefile b/Mak
Signed-off-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 36eeb42d19..42f5454311 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1891,6 +1891,7 @@ S: Maintained
F: .travis.yml
F: .shippable.yml
F: t
The image is prepared following instructions as in:
https://wiki.qemu.org/Hosts/BSD
Signed-off-by: Fam Zheng
---
tests/vm/openbsd | 43 +++
1 file changed, 43 insertions(+)
create mode 100755 tests/vm/openbsd
diff --git a/tests/vm/openbsd b/tests/vm/ope
This is the common code to implement a "VM test" to
1) Download and initialize a pre-defined VM that has necessary
dependencies to build QEMU and SSH access.
2) Archive $SRC_PATH to a .tar file.
3) Boot the VM, and pass the source tar file to the guest.
4) SSH into the VM, untar the s
The image is prepared following instructions as in:
https://wiki.qemu.org/Hosts/BSD
Signed-off-by: Fam Zheng
Reviewed-by: Kamil Rytarowski
---
tests/vm/netbsd | 42 ++
1 file changed, 42 insertions(+)
create mode 100755 tests/vm/netbsd
diff --git a/tes
Signed-off-by: Fam Zheng
---
tests/vm/README | 63 +
1 file changed, 63 insertions(+)
create mode 100644 tests/vm/README
diff --git a/tests/vm/README b/tests/vm/README
new file mode 100644
index 00..7d2fe4ac8d
--- /dev/null
+++ b/t
This will be used by setup test user ssh.
Signed-off-by: Fam Zheng
---
tests/keys/id_rsa | 27 +++
tests/keys/id_rsa.pub | 1 +
2 files changed, 28 insertions(+)
create mode 100644 tests/keys/id_rsa
create mode 100644 tests/keys/id_rsa.pub
diff --git a/tests/keys/
The image is prepared following instructions as in:
https://wiki.qemu.org/Hosts/BSD
Signed-off-by: Fam Zheng
---
tests/vm/freebsd | 42 ++
1 file changed, 42 insertions(+)
create mode 100755 tests/vm/freebsd
diff --git a/tests/vm/freebsd b/tests/vm/free
Signed-off-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Alex Bennée
---
scripts/qemu.py | 7 +++
1 file changed, 7 insertions(+)
diff --git a/scripts/qemu.py b/scripts/qemu.py
index 4d8ee10943..99963053a5 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -157,6 +157,13 @@ cl
Signed-off-by: Fam Zheng
---
scripts/archive-source.sh | 33 +
1 file changed, 33 insertions(+)
create mode 100755 scripts/archive-source.sh
diff --git a/scripts/archive-source.sh b/scripts/archive-source.sh
new file mode 100755
index 00..8b373e3090
--- /
This adds a 32bit guest.
The official LTS cloud image is downloaded and initialized with
cloud-init.
Signed-off-by: Fam Zheng
---
tests/vm/ubuntu.i386 | 88
1 file changed, 88 insertions(+)
create mode 100755 tests/vm/ubuntu.i386
diff --git
v7: Add Alex's rev-by to patch 2.
GPLv2 => GPLv2+ for all new files. [Peter]
Add more description in file header to archive-source.sh for the intended
usage. [Peter]
"output tarball" in usage. [Alex]
Add quotes to "$1". [Peter]
Put generated keys in separate files. [Alex]
Signed-off-by: Fam Zheng
---
.gitignore | 1 +
tests/.gitignore | 1 +
2 files changed, 2 insertions(+)
diff --git a/.gitignore b/.gitignore
index cf65316863..40acfcb9e2 100644
--- a/.gitignore
+++ b/.gitignore
@@ -52,6 +52,7 @@
/vscclient
/vhost-user-scsi
/fsdev/virtfs-proxy-helper
+*.
On 13/09/17 02:46, Mark Cave-Ayland wrote:
> On 12/09/17 17:41, Mark Cave-Ayland wrote:
>
>> The commit message mentions that prior to the conversion some CPU state
>> was missing but it doesn't mention anything about dropping existing
>> fields as part of the conversion process so I suspect that
Hi Alistair,
On Wed, Sep 13, 2017 at 5:20 AM, Alistair Francis
wrote:
> On Thu, Sep 7, 2017 at 12:24 PM, Subbaraya Sundeep
> wrote:
> > Modelled Microsemi's Smartfusion2 SPI controller.
> >
> > Signed-off-by: Subbaraya Sundeep
>
> Reviewed-by: Alistair Francis
>
> Thank you,
Sundeep
> Thank
On Tue, Sep 12, 2017 at 08:48:05PM +0200, Greg Kurz wrote:
> QTAILQ_FOREACH_SAFE() must be used when removing the current element
> inside the loop block.
>
> This fixes a user-after-free error introduced by commit 56258174238eb
> and reported by Coverity (CID 1381017).
>
> Signed-off-by: Greg Ku
On Tue, Sep 12, 2017 at 9:13 AM, Peter Maydell wrote:
> Fix an error that meant we were wiring every UART's overflow
> interrupts into the same inputs 0 and 1 of the OR gate,
> rather than giving each its own input.
>
> Cc: qemu-sta...@nongnu.org
> Signed-off-by: Peter Maydell
Reviewed-by: Alist
On Thu, Sep 7, 2017 at 12:24 PM, Subbaraya Sundeep
wrote:
> Modelled Microsemi's Smartfusion2 SPI controller.
>
> Signed-off-by: Subbaraya Sundeep
Reviewed-by: Alistair Francis
Thanks,
Alistair
> ---
> hw/ssi/Makefile.objs | 1 +
> hw/ssi/mss-spi.c | 404
>
Bah, and that's "read *from an offset of* 0x34 bytes"; I
got confused between count and pos midway through that paragraph.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1716767
Title:
(Currently regpairs_aligned gets checked, but this, rightly, returns
false for SH; alignment is not a requirement of the SH ABI, but
p{read,write}64 are an exception for it.)
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bug
Ok, I was wrong, there's a whole load of code being included inside the
function from a header. The issue seems to be the pread:
20771@1505254578.94:guest_user_syscall cpu=0x62850620
num=0x00b4 arg1=0x0003 arg2=0xf6fe6798
arg3=0x0020 arg4=0x000
Right now, function trace_event_set_vcpu_state_dynamic() asynchronously enables
events in the case a vCPU is executing TCG code. If the vCPU is being created
this makes some events like "guest_cpu_enter" to not be traced.
Signed-off-by: Lluís Vilanova
Reviewed-by: Emilio G. Cota
---
Changes in
Hi,
This series failed automatic build test. Please find the testing commands and
their output below. If you have docker installed, you can probably reproduce it
locally.
Subject: [Qemu-devel] [PATCH v5 00/22] instrument: Add basic event
instrumentation
Message-id: 150525010239.15988.81725866181
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH v5 00/22] instrument: Add basic event
instrumentation
Message-id: 150525010239.15988.8172586618197849619.st...@frigg.lan
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/ba
It includes access to the guest's memory and vCPU registers.
Signed-off-by: Lluís Vilanova
---
instrument/Makefile.objs |1
instrument/qemu-instr/state.h | 104 +
instrument/state.c| 73 +
3 files change
Signed-off-by: Lluís Vilanova
---
bsd-user/syscall.c |3 +++
instrument/control.c| 15 +++
instrument/events.h |5 +
instrument/events.inc.h | 13 +
instrument/load.c |1 +
instrument/qemu-instr
When running with KVM PR, a pseries machine needs to allocate an HPT
in userspace and pass its address and size too KVM. This is done at
machine reset time by hijacking SDR1.
It is very likely that the destination QEMU will allocate the HPT at
a different address, ie, the SDR1 value we get from th
When running with KVM PR, if a new HPT is allocated we need to inform
KVM about the HPT address and size. This is currently done with a hack
which is open-coded in several places.
This patch consolidate the code in a dedicated helper that records
the HPT address and size in the sPAPR context, and
A guest running with KVM PR ends up irresponsive after migration most of the
time. This happens because the HPT allocated by QEMU is likely to have a
different address on the destination than it had on the source, but we push
the source address to KVM.
This v2 is a total rewrite.
Cheers,
--
Greg
Signed-off-by: Lluís Vilanova
---
bsd-user/syscall.c |6 ++
instrument/control.c| 18 ++
instrument/events.h |7 +++
instrument/events.inc.h | 16
instrument/load.c |1 +
instrument
Signed-off-by: Lluís Vilanova
---
include/exec/cpu_ldst_template.h |4 +++
include/exec/cpu_ldst_useronly_template.h |4 +++
include/exec/helper-gen.h |1 +
include/exec/helper-proto.h |1 +
include/exec/helper-tcg.h |1 +
Signed-off-by: Lluís Vilanova
---
Makefile.target |1 +
instrument/control.c| 15 +
instrument/control.h| 36 +-
instrument/control.inc.h| 16 +++---
instrument/events.h | 21 +
ins
Signed-off-by: Lluís Vilanova
---
include/exec/cpu_ldst_template.h | 15 ++
include/exec/cpu_ldst_useronly_template.h | 15 ++
tcg/tcg-op.c | 22 +
trace/mem-internal.h | 22
On 12 September 2017 at 22:47, James Clarke wrote:
> I just ran it myself inside and outside the sh4 chroot. The logging
> output is the same, with the exception of the final line. Something is
> happening once it's decided it's elf; looking at file_tryelf, my guess
> is the fstat call is failing[
Signed-off-by: Lluís Vilanova
---
instrument/control.c|9 +
instrument/events.h |3 +++
instrument/events.inc.h | 11 +++
instrument/load.c |1 +
instrument/qemu-instr/control.h |9 +
qom/cpu.c
Signed-off-by: Lluís Vilanova
---
instrument/control.c|9 +
instrument/events.h |3 +++
instrument/events.inc.h | 11 +++
instrument/load.c | 17 +
instrument/qemu-instr/control.h | 11 +++
stubs/i
I just ran it myself inside and outside the sh4 chroot. The logging
output is the same, with the exception of the final line. Something is
happening once it's decided it's elf; looking at file_tryelf, my guess
is the fstat call is failing[0].
[0] http://sources.debian.net/src/file/1:5.31-1/src/rea
Signed-off-by: Lluís Vilanova
---
accel/stubs/tcg-stub.c|3 +++
accel/tcg/translate-all.c |7 +++
include/exec/exec-all.h |1 +
3 files changed, 11 insertions(+)
diff --git a/accel/stubs/tcg-stub.c b/accel/stubs/tcg-stub.c
index 5dd480b1a2..5226c4a8a4 100644
--- a/accel/stu
Stops all vCPUs to allow performing management operations like TB
invalidations. These are later necessary to ensure translated code does not
reference unloaded instrumentation libraries.
Signed-off-by: Lluís Vilanova
---
instrument/control.c | 66 ++
On 09/12/2017 11:18 PM, James Clarke wrote:
> The "0 == 18446744073709551615 = 0" is actually fine, it's just printing
> "-1" as a 64-bit unsigned integer.
Yeah, I noticed that output was the same on amd64.
> Could you please upload the fill
> output of `file -d /bin/bash 2>&1`?
> https://people
Signed-off-by: Lluís Vilanova
---
instrument/control.c|9
instrument/events.h |5
instrument/events.inc.h | 11 +
instrument/load.c |9
instrument/qemu-instr/control.h | 46 +++
Keep a translation between instrumentation's QICPU and CPUState objects to avoid
exposing QEMU's internals to instrumentation clients.
Signed-off-by: Lluís Vilanova
---
cpus-common.c|9 +
instrument/control.c | 23 +++
instrument/control.h |
Signed-off-by: Lluís Vilanova
---
.gitignore|1
Makefile |3 +
instrument/Makefile.objs |1
instrument/error.h|6 ++
instrument/qemu-instr/types.h | 51 +++
instrument/qemu-instr/types.in
Signed-off-by: Lluís Vilanova
---
Makefile|4 +++
configure |1 +
include/qemu/compiler.h | 19
instrument/Makefile.objs|1 +
instrument/control.c| 28
instrument/co
On 09/12/2017 04:26 PM, Paolo Bonzini wrote:
>
>
>>> +then
>>> +if [ -x "$build_iotests/qemu" ]; then
>>> +export QEMU_PROG="$build_iotests/qemu"
>>> +elif [ -x "$build_root/$arch-softmmu/qemu-system-$arch" ]; then
>>> +export QEMU_PROG="$build_root/$arch-softmmu/qemu-syst
Signed-off-by: Lluís Vilanova
---
hmp-commands.hx | 32
monitor.c | 39 +++
2 files changed, 71 insertions(+)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 1941e19932..2e8ebe8422 100644
--- a/hmp-commands.hx
++
On 09/12/2017 09:44 AM, Paolo Bonzini wrote:
> "check" is full of qemu-iotests--specific details. Separating it
> from "common" does not make much sense anymore.
>
> Signed-off-by: Paolo Bonzini
> ---
> tests/qemu-iotests/check | 533 +++-
> tests/qemu-i
The "0 == 18446744073709551615 = 0" is actually fine, it's just printing
"-1" as a 64-bit unsigned integer. Could you please upload the fill
output of `file -d /bin/bash 2>&1`?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://b
On 09/12/2017 09:44 AM, Paolo Bonzini wrote:
> The variable is almost unused, and one of the two uses is actually
> uninitialized.
>
> Signed-off-by: Paolo Bonzini
> ---
> tests/qemu-iotests/check | 5 +
> tests/qemu-iotests/common.rc | 2 +-
> 2 files changed, 2 insertions(+), 5 deletio
Signed-off-by: Lluís Vilanova
---
MAINTAINERS |1 +
Makefile |1 +
instrument/Makefile.objs |1 +
instrument/qmp.c | 82 ++
monitor.c|4 ++
qapi-schema.json |3 ++
qapi/i
On 09/12/2017 09:44 AM, Paolo Bonzini wrote:
> The variable is used in "common" but defined only after the file
> is sourced.
>
> Signed-off-by: Paolo Bonzini
> ---
> tests/qemu-iotests/check | 2 --
> tests/qemu-iotests/common | 2 ++
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
Revi
> > +then
> > +if [ -x "$build_iotests/qemu" ]; then
> > +export QEMU_PROG="$build_iotests/qemu"
> > +elif [ -x "$build_root/$arch-softmmu/qemu-system-$arch" ]; then
> > +export QEMU_PROG="$build_root/$arch-softmmu/qemu-system-$arch"
> > +else
> > +pushd "$buil
On 09/12/2017 09:44 AM, Paolo Bonzini wrote:
> Split "check" parts from tests part.
>
> For the directory setup, the actual computation of directories goes
> in "check", while the sanity checks go in the tests.
>
> Signed-off-by: Paolo Bonzini
> ---
> tests/qemu-iotests/common| 24 +
Signed-off-by: Lluís Vilanova
---
qemu-options.hx | 19 +++
vl.c| 15 +++
2 files changed, 34 insertions(+)
diff --git a/qemu-options.hx b/qemu-options.hx
index 9f6e2adfff..6947388aab 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -4077,6 +4077,
Signed-off-by: Lluís Vilanova
---
bsd-user/main.c| 17 +
bsd-user/syscall.c |5 +
2 files changed, 22 insertions(+)
diff --git a/bsd-user/main.c b/bsd-user/main.c
index 8a6706a1c8..104844edfc 100644
--- a/bsd-user/main.c
+++ b/bsd-user/main.c
@@ -33,6 +33,7 @@
#inc
Suggested-by: Paolo Bonzini
Signed-off-by: Philippe Mathieu-Daudé
---
Based-on: 20170911213328.9701-5-f4...@amsat.org
accel/tcg/tcg-runtime.c | 54 -
accel/tcg/user-exec.c | 52 +++
2 files changed, 52
Signed-off-by: Lluís Vilanova
---
linux-user/main.c| 21 +
linux-user/syscall.c |4
2 files changed, 25 insertions(+)
diff --git a/linux-user/main.c b/linux-user/main.c
index 03666ef657..ac5c30c1fb 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -36,6
On 09/12/2017 09:44 AM, Paolo Bonzini wrote:
> It only provides functions used by the test programs.
>
> Signed-off-by: Paolo Bonzini
> ---
> tests/qemu-iotests/check | 6 --
> tests/qemu-iotests/common.rc | 13 +
> 2 files changed, 5 insertions(+), 14 deletions(-)
>
Revie
On 09/12/2017 09:44 AM, Paolo Bonzini wrote:
> These are never used by "check", with one exception that does not need
> $QEMU_OPTIONS. Keep them in common.rc, which will be soon included only
> by the tests.
>
> Signed-off-by: Paolo Bonzini
> ---
> tests/qemu-iotests/039.out | 10 +++---
>
Signed-off-by: Lluís Vilanova
---
MAINTAINERS |1
Makefile.objs|4 +
configure|3 +
instrument/Makefile.objs |4 +
instrument/cmdline.c | 128 +++
instrument/cmdline.h | 51 ++
instrum
On 09/12/2017 09:44 AM, Paolo Bonzini wrote:
> Instead of ./check failing when a binary is missing, we try each test
> case now and each one fails with tons of test case diffs. Also, all the
> variables were initialized by "check" prior to "common" being sourced,
> and then (uselessly) checked for
Public bug reported:
We recently discovered that file(1) fails on qemu-sh4-user when running
on an ELF file:
(sid_sh4)root@vs94:/# file /bin/bash
/bin/bash: ERROR: ELF 32-bit LSB executable, Renesas SH, version 1 (SYSV) error
reading (Invalid argument)
(sid_sh4)root@vs94:/#
Running with "-d" yi
Signed-off-by: Lluís Vilanova
---
configure |9 +
1 file changed, 9 insertions(+)
diff --git a/configure b/configure
index fd7e3a5e81..a21d1bceb9 100755
--- a/configure
+++ b/configure
@@ -356,6 +356,7 @@ pie=""
qom_cast_debug="yes"
trace_backends="log"
trace_file="trace"
+instrum
Signed-off-by: Lluís Vilanova
---
MAINTAINERS |6 ++
docs/instrument.txt | 173 +++
2 files changed, 179 insertions(+)
create mode 100644 docs/instrument.txt
diff --git a/MAINTAINERS b/MAINTAINERS
index 36eeb42d19..fb0eaee06a 100644
-
On 11/09/2017 23:37, Peter Maydell wrote:
> On 11 September 2017 at 21:49, Philippe Mathieu-Daudé wrote:
>> this fixes building for ppc64 on ppc32 (changed in 5964fca8a12c):
>>
>> qemu/tcg/ppc/tcg-target.inc.c: In function 'tb_target_set_jmp_target':
>> qemu/include/qemu/compiler.h:86:30: erro
On 09/12/2017 09:44 AM, Paolo Bonzini wrote:
> Some functions in common.rc are never used by the tests. Move
> them out of that file and into common, which is already included
> only by "check".
>
> Code that actually *is* common to "check" and tests can be placed in
> common.config.
>
> Signed-
This series adds an API to add instrumentation events.
It also provides additional APIs for:
* Controlling tracing events.
* Peek/poke guest memory.
TODO:
* Replace qi_event_gen_* with generating calls to arbitrary functions (e.g.,
qi_event_gen_call(num_args, va_list)).
* Flush all TBs when an
On 11/09/2017 21:52, Alistair Francis wrote:
> This series expands on my previous series by converting more existing
> prints to use warn_report() instead of error_report() or fprintf().
>
> As discussed with Paolo and Markus this series combines libqemustub.a into
> libqemuutil.a to avoid circula
On 09/12/2017 02:01 PM, Richard Henderson wrote:
On 09/11/2017 01:49 PM, Philippe Mathieu-Daudé wrote:
-atomic_set((uint64_t *)jmp_addr, pair);
+atomic_set__nocheck((uint64_t *)jmp_addr, pair);
flush_icache_range(jmp_addr, jmp_addr + 8);
} else {
intptr_
- float64 regs[64];
+ float64 regs[64] __attribute__((aligned(16)));
I understand this should be aligned to the biggest vector register the
host support, i.e. for AVX-512 this would be QEMU_ALIGNED(64), is it
correct?
checking datashits:
"INTEL® ADVANCED VECTOR EXTENSIONS"
On 09/12/2017 09:44 AM, Paolo Bonzini wrote:
> This includes shell function, shell variables and command line options
> (randomize.awk does not exist).
>
> Signed-off-by: Paolo Bonzini
> ---
> tests/qemu-iotests/check | 28 -
> tests/qemu-iotests/common| 23 --
Both callers already had bytes available, but were scaling to
sectors. Move the scaling to internal code. In the case of
bdrv_aligned_pwritev(), we are now passing the exact offset
rather than a rounded sector-aligned value, but that's okay
as long as dirty bitmap widens start/bytes to granularit
Now that we have adjusted the majority of the calls this function
makes to be byte-based, it is easier to read the code if it makes
passes over the image using bytes rather than sectors.
Signed-off-by: Eric Blake
Reviewed-by: John Snow
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
v5: no chang
On 09/12/2017 09:44 AM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> ---
> tests/qemu-iotests/check | 4 ++--
> tests/qemu-iotests/common| 2 +-
> tests/qemu-iotests/common.config | 3 ---
> 3 files changed, 3 insertions(+), 6 deletions(-)
Reviewed-by: Eric Blake
--
E
Now that we have adjusted the majority of the calls this function
makes to be byte-based, it is easier to read the code if it makes
passes over the image using bytes rather than sectors.
Signed-off-by: Eric Blake
Reviewed-by: John Snow
---
v6: no change
v5: rebase to earlier changes
v2-v4: no c
This is new code, but it is easier to read if it makes passes over
the image using bytes rather than sectors (and will get easier in
the future when bdrv_get_block_status is converted to byte-based).
Signed-off-by: Eric Blake
Reviewed-by: John Snow
---
v7: tweak constant given to MIN (no semant
Some of the callers were already scaling bytes to sectors; others
can be easily converted to pass byte offsets, all in our shift
towards a consistent byte interface everywhere. Making the change
will also make it easier to write the hold-out callers to use byte
rather than sectors for their iterat
Now that all callers are using byte-based interfaces, there's no
reason for our internal hbitmap to remain with sector-based
granularity. It also simplifies our internal scaling, since we
already know that hbitmap widens requests out to granularity
boundaries.
Signed-off-by: Eric Blake
Reviewed-
Thanks to recent cleanups, all callers were scaling a return value
of sectors into bytes; do the scaling internally instead.
Signed-off-by: Eric Blake
---
v7: fix one more trace caller [Kevin]
v4-v6: no change
v3: no change, add R-b
v2: no change
---
block/dirty-bitmap.c | 4 ++--
block/mirror
All callers to bdrv_dirty_iter_new() passed 0 for their initial
starting point, drop that parameter.
Most callers to bdrv_set_dirty_iter() were scaling a byte offset to
a sector number; the exception qcow2-bitmap will be converted later
to use byte rather than sector iteration. Move the scaling t
Thanks to recent cleanups, most callers were scaling a return value
of sectors into bytes (the exception, in qcow2-bitmap, will be
converted to byte-based iteration later). Update the interface to
do the scaling internally instead.
In qcow2-bitmap, the code was specifically checking for an error
Now that we have adjusted the majority of the calls this function
makes to be byte-based, it is easier to read the code if it makes
passes over the image using bytes rather than sectors.
Signed-off-by: Eric Blake
Reviewed-by: John Snow
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
v7: rebase t
Right now, the dirty-bitmap code exposes the fact that we use
a scale of sector granularity in the underlying hbitmap to anything
that wants to serialize a dirty bitmap. It's nicer to uniformly
expose bytes as our dirty-bitmap interface, matching the previous
change to bitmap size. The only calle
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Change the qcow2 bitmap
helper function sectors_covered_by_bitmap_cluster(), renaming it
to bytes_covered_by_bitmap_cluster() in the process.
Signed-off-by: Eric Blake
Reviewed-by: John Sn
We are still using an internal hbitmap that tracks a size in sectors,
with the granularity scaled down accordingly, because it lets us
use a shortcut for our iterators which are currently sector-based.
But there's no reason we can't track the dirty bitmap size in bytes,
since it is (mostly) an inte
Half the callers were already scaling bytes to sectors; the other
half can eventually be simplified to use byte iteration. Both
callers were already using the result as a bool, so make that
explicit. Making the change also makes it easier for a future
dirty-bitmap patch to offload scaling over to
We've previously fixed several places where we failed to account
for possible errors from bdrv_nb_sectors(). Fix another one by
making bdrv_dirty_bitmap_truncate() report the error rather then
silently resizing bitmaps to -1. Then adjust the sole caller
bdrv_truncate() to both reduce the likeliho
We're already reporting bytes for bdrv_dirty_bitmap_granularity();
mixing bytes and sectors in our return values is a recipe for
confusion. A later cleanup will convert dirty bitmap internals
to be entirely byte-based, but in the meantime, we should report
the bitmap size in bytes.
The only exter
1 - 100 of 397 matches
Mail list logo
