Re: [Qemu-devel] [Help] Windows2012 as Guest 64+cores on KVM Halts

2017-09-04 Thread Vadim Rozenfeld
On 21/02/17 00:18, Gonglei (Arei) wrote: On 20/02/2017 12:54, Gonglei (Arei) wrote: On 20/02/2017 10:19, Gonglei (Arei) wrote: Hi Paolo, On 16/02/2017 02:31, Gonglei (Arei) wrote: And the below patch works for me, I can support max 255 vcpus for WS2012 with hyper-v enlightenments. dif

[Qemu-devel] [PATCH V6 1/3] net/colo-compare.c: Optimize unpredictable tcp options comparison

2017-09-04 Thread Zhang Chen
When network is busy, some tcp options(like sack) will unpredictable occur in primary side or secondary side. it will make packet size not same, but the two packet's payload is identical. colo just care about packet payload, so we skip the option field. Signed-off-by: Zhang Chen --- net/colo-com

[Qemu-devel] [PATCH V6 2/3] net/colo-compare.c: Adjust net queue pop order for performance

2017-09-04 Thread Zhang Chen
The packet_enqueue() use g_queue_push_tail() to enqueue net packet, so it is more efficent way use g_queue_pop_head() to get packet for compare. That will improve the success rate of comparison. In my test the performance of ftp put 1000M file will increase 10% Signed-off-by: Zhang Chen --- net/

[Qemu-devel] [PATCH V6 3/3] net/colo-compare.c: Fix comments and scheme

2017-09-04 Thread Zhang Chen
Signed-off-by: Zhang Chen --- net/colo-compare.c | 59 -- 1 file changed, 31 insertions(+), 28 deletions(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index c31adc6..d5fcfea 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@

[Qemu-devel] [PATCH V6 0/3] Optimize COLO-compare performance

2017-09-04 Thread Zhang Chen
In this serise, we do a lot of job to optimize COLO net performance. Mainly focus on TCP protocol. V6: - Cover rare situation in patch1. V5: - Fix bug in colo_packet_compare_common(). - Fix patch3 ascii graph style. V4: - Remove the old patch1. V3: - Rebase on upstream. - Remove origin p2

Re: [Qemu-devel] [PATCH V5 1/3] net/colo-compare.c: Optimize unpredictable tcp options comparison

2017-09-04 Thread Zhang Chen
On 09/05/2017 10:11 AM, Dou Liyang wrote: Hi Chen, At 09/04/2017 02:14 PM, Zhang Chen wrote: When network is busy, some tcp options(like sack) will unpredictable occur in primary side or secondary side. it will make packet size not same, but the two packet's payload is identical. colo just ca

[Qemu-devel] [Bug 1714750] Re: 2.10.0 cannot be installed on case-insensitive file system

2017-09-04 Thread Stefan Weil
See https://lists.denx.de/pipermail/u-boot/2017-September/304728.html. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1714750 Title: 2.10.0 cannot be installed on case-insensitive file system Statu

Re: [Qemu-devel] [PATCH 2/6] cpu: make cpu_generic_init() abort QEMU on error

2017-09-04 Thread Thomas Huth
On 04.09.2017 16:00, Igor Mammedov wrote: > Almost every user of cpu_generic_init() checks for > returned NULL and then reports failure in a custom way > and aborts process. > Some users assume that call can't fail and don't check > for failure, though they should have checked for it. > > In eithe

Re: [Qemu-devel] [PATCH 3/6] cpu: rename cpu_parse_features() to cpu_parse_cpu_model()

2017-09-04 Thread Thomas Huth
On 04.09.2017 21:06, Igor Mammedov wrote: > On Mon, 4 Sep 2017 12:03:09 -0300 > Philippe Mathieu-Daudé wrote: > >> Hi Igor, >> >> On 09/04/2017 11:00 AM, Igor Mammedov wrote: >>> function not just parses features but also converts CPU model >>> name to CPU type, rename it to reflect what it actua

[Qemu-devel] query-block io-status display

2017-09-04 Thread Jack Schwartz
Hi Luiz, Markus and everyone. I am working on a qemu enhancement to display io-status in each query-block command, not just those for devices which have werror and/or rerror set to stop on error. I'd like to verify the reasons behind the query-block command not reporting io-status if errors

Re: [Qemu-devel] [PULL 3/5] net: fix -netdev socket, fd= for UDP sockets

2017-09-04 Thread Mao Zhongyi
On 08/09/2017 09:50 AM, Michael S. Tsirkin wrote: From: Jens Freimann This patch fixes -netdev socket,fd= for UDP sockets Currently -netdev socket,fd=<...> results in qemu: error: specified mcastaddr "127.0.0.1" (0x7f01) does not contain a multicast address qemu-system-x86_64: -n

[Qemu-devel] [PATCH v3 06/14] hvf: handle fields from CPUState and CPUX86State

2017-09-04 Thread Sergio Andres Gomez Del Real
This commit is a small refactoring of hvf's emulation code: it moves the HVFX86EmulatorState field to CPUX86State, and in general changes, for the emulation functions, the parameter with signature 'CPUState *' for 'CPUX86State *' so we don't have to get the 'env' (which is what we really need) thro

Re: [Qemu-devel] [PATCH v3 08/14] hvf: add compilation rules to Makefile.objs

2017-09-04 Thread Sergio Andrés Gómez del Real
Note that until this patch (8/14) there is no compiling. I tried to put this patch earlier in the patchset but found difficulties because some things need to be done before the hvf code compiles well. Also, the commit message needs to be updated (remove the -enable-hvf part). On Mon, Sep 4, 2017 a

[Qemu-devel] [PATCH v3 14/14] hvf: inject General Protection Fault when vmexit through vmcall

2017-09-04 Thread Sergio Andres Gomez Del Real
This commit injects a GP fault when the guest vmexit's by executing a vmcall instruction. Signed-off-by: Sergio Andres Gomez Del Real --- target/i386/hvf-all.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/i386/hvf-all.c b/target/i386/hvf-all.c index 8fc6a0b5d1..c

[Qemu-devel] [PATCH v3 05/14] hvf: add code to cpus.c and do refactoring in preparation for compiling

2017-09-04 Thread Sergio Andres Gomez Del Real
The files originally added from Google's repository in previous patches won't compile cleanly unless some glue code is added to cpus.c and some other reorganization is done. This patch adds that code and does some general refactoring in preparation for compiling in subsequent patches. Signed-off-b

[Qemu-devel] [PATCH v3 11/14] hvf: refactor cpuid code

2017-09-04 Thread Sergio Andres Gomez Del Real
This patch generalizes some code in cpu.c, sharing code and data between hvf and kvm. It also beings calling the new hvf_get_supported_cpuid where appropriate. Signed-off-by: Sergio Andres Gomez Del Real --- target/i386/cpu-qom.h | 4 +-- target/i386/cpu.c | 76 +

Re: [Qemu-devel] [PATCH v3 00/14] add support for Hypervisor.framework in QEMU

2017-09-04 Thread Sergio Andrés Gómez del Real
This patchset didn't address every issue, so it won't be the definite version. Hopefully however the licensing issue will get fixed with this version. On Mon, Sep 4, 2017 at 10:54 PM, Sergio Andres Gomez Del Real < sergio.g.delr...@gmail.com> wrote: > > Changes in v3: > (1) Fixe

[Qemu-devel] [PATCH v3 13/14] hvf: refactor event injection code for hvf

2017-09-04 Thread Sergio Andres Gomez Del Real
This commit refactors the event-injection code for hvf through using the appropriate fields already provided by CPUX86State. At vmexit, it fills these fields so that hvf_inject_interrupts can just retrieve them without calling into hvf. Signed-off-by: Sergio Andres Gomez Del Real --- target/i386

[Qemu-devel] [PATCH v3 12/14] hvf: implement vga dirty page tracking

2017-09-04 Thread Sergio Andres Gomez Del Real
This commit implements setting the tracking of dirty pages, using hvf's interface to protect guest memory. It uses the MemoryListener callback mechanism through .log_start/stop/sync Signed-off-by: Sergio Andres Gomez Del Real --- include/sysemu/hvf.h | 5 target/i386/hvf-all.c | 74 ++

[Qemu-devel] [PATCH v3 09/14] hvf: use new helper functions for put/get xsave

2017-09-04 Thread Sergio Andres Gomez Del Real
This commit makes use of the helper functions for handling xsave in xsave_helper.c, which are shared with kvm. Signed-off-by: Sergio Andres Gomez Del Real --- target/i386/hvf-utils/x86hvf.c | 63 ++ 1 file changed, 8 insertions(+), 55 deletions(-) diff --

[Qemu-devel] [PATCH v3 03/14] hvf: fix licensing issues; isolate task handling code (GPL v2-only)

2017-09-04 Thread Sergio Andres Gomez Del Real
This patch replaces the license header for those files that were either GPL v2-or-v3, or GPL v2-only; the replacing license is GPL v2-or-later. The code for task switching/handling, which is derived from KVM and hence is GPL v2-only, is isolated in the new files (with this license) x86_task.c/.h S

[Qemu-devel] [PATCH v3 07/14] apic: add function to apic that will be used by hvf

2017-09-04 Thread Sergio Andres Gomez Del Real
This commit adds the function apic_get_highest_priority_irr to apic.c and exports it through the interface in apic.h for use by hvf. Signed-off-by: Sergio Andres Gomez Del Real --- hw/intc/apic.c | 12 include/hw/i386/apic.h | 1 + 2 files changed, 13 insertions(+) diff --

[Qemu-devel] [PATCH v3 08/14] hvf: add compilation rules to Makefile.objs

2017-09-04 Thread Sergio Andres Gomez Del Real
This commit adds to target/i386/Makefile.objs the necessary rules so that the new files for hvf are compiled by the build system. It also adds handling of the -enable-hvf argument in the main function in vl.c. Signed-off-by: Sergio Andres Gomez Del Real --- target/i386/Makefile.objs | 1 + 1 fil

[Qemu-devel] [PATCH v3 01/14] hvf: add support for Hypervisor.framework in the configure script

2017-09-04 Thread Sergio Andres Gomez Del Real
This patch adds to the configure script the code to support the --enable-hvf argument. If the OS is Darwin, it checks for presence of HVF in the system. The patch also adds strings related to HVF in the file qemu-options.hx. QEMU will only support the modern syntax style '-M accel=hvf' no enable hv

[Qemu-devel] [PATCH v3 10/14] hvf: implement hvf_get_supported_cpuid

2017-09-04 Thread Sergio Andres Gomez Del Real
This commit implements hvf_get_supported_cpuid, which returns the set of features supported by both the host processor and the hypervisor. Signed-off-by: Sergio Andres Gomez Del Real --- target/i386/hvf-utils/x86_cpuid.c | 138 ++ 1 file changed, 138 insertion

[Qemu-devel] [PATCH v3 00/14] add support for Hypervisor.framework in QEMU

2017-09-04 Thread Sergio Andres Gomez Del Real
Changes in v3: (1) Fixed licensing issues in patch 3. (2) Revert to late adding of compilation rules in Makefile.objs (patch 8/14); files aren't ready to compile earlier. (3) Make a single patch just for fixing style (patch 4/14). (4) Fix data type for hvf_fd field. (5) A

Re: [Qemu-devel] [PATCH] block: Cleanup BMDS in bdrv_close_all

2017-09-04 Thread Fam Zheng
On Fri, 09/01 13:41, Juan Quintela wrote: > Fam Zheng wrote: > > This fixes the assertion due to op blockers added by BMDS: > > > > block.c:3248: bdrv_delete: Assertion `bdrv_op_blocker_is_empty(bs)' failed. > > > > Reproducer: simply start block migration and quit QEMU before it ends. > > > > Cc:

Re: [Qemu-devel] [PATCH v5 0/6] arm: Make use of DEFINE_PROP_LINK

2017-09-04 Thread Fam Zheng
Hi, Ping for 2.11. Peter, what do you think? On Mon, 07/17 10:38, Fam Zheng wrote: > This is the arm part that was left out from: > > https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg04006.html > > Make use of the new DEFINE_PROP_LINK, in favor of open coded the > object_property_add_l

Re: [Qemu-devel] [PATCH] tests/docker: Clean up paths

2017-09-04 Thread Fam Zheng
On Thu, 08/17 11:57, Fam Zheng wrote: > The 'run' script already creats src, build and install directories under > $TEST_DIR, use it in common.rc. > > Also the tests always run from $QEMU_SRC/tests/docker, so use a relative > $CMD string. > > Signed-off-by: Fam Zheng Queued. Fam

Re: [Qemu-devel] reduce write bandwidth of qcow2 driver while allocating new cluster

2017-09-04 Thread Liu Qing
On Mon, Sep 04, 2017 at 04:17:42PM +0300, Anton Nefedov wrote: > > > On 31/8/2017 9:55 AM, Liu Qing wrote: > >On Wed, Aug 30, 2017 at 01:15:33PM +0300, Anton Nefedov wrote: > >> > >>On 29/08/2017 05:56, Liu Qing wrote: > >>>On Mon, Aug 28, 2017 at 10:46:34AM -0500, Eric Blake wrote: > [adding

Re: [Qemu-devel] [PATCH v8 13/13] qemu.py: don't launch again before shutdown()

2017-09-04 Thread Fam Zheng
On Fri, 09/01 13:28, Amador Pahim wrote: > If a VM is launched, files are created and a cleanup is required before > a new launch. This cleanup is executed by shutdown(), so shutdown() must > be called even if the VM is manually terminated (i.e. using kill). > > This patch creates a control to mak

Re: [Qemu-devel] [PATCH v8 11/13] qemu.py: cleanup redundant calls in launch()

2017-09-04 Thread Fam Zheng
On Fri, 09/01 13:28, Amador Pahim wrote: > Now that shutdown() is guaranteed to always execute self._load_io_log() > and self._post_shutdown(), their calls in 'except' became redundant and > we can safely replace it by a call to shutdown(). > > Due to this change, shutdown() can be now called even

Re: [Qemu-devel] [PATCH v8 12/13] qemu.py: launch vm only if it's not running

2017-09-04 Thread Fam Zheng
On Fri, 09/01 13:28, Amador Pahim wrote: > A new call to launch() with a running VM will fall in exception and > consequently call shutdown(). > > This patch makes launch() to raise an exception when it's called with VM > already running. > > Signed-off-by: Amador Pahim > --- > scripts/qemu.py

Re: [Qemu-devel] [PATCH v8 06/13] qemu.py: make sure we only remove files we create

2017-09-04 Thread Fam Zheng
On Fri, 09/01 13:28, Amador Pahim wrote: > To launch a VM, we need to create basically two files: the monitor > socket (if it's a UNIX socket) and the qemu log file. > > For the qemu log file, we currently just open the path, which will > create the file if it does not exist or overwrite the file

Re: [Qemu-devel] [PATCH v8 10/13] qemu.py: use poll() instead of 'returncode'

2017-09-04 Thread Fam Zheng
On Fri, 09/01 13:28, Amador Pahim wrote: > The 'returncode' Popen attribute is not guaranteed to be updated. It > actually depends on a call to either poll(), wait() or communicate(). > > On the other hand, poll() will: "Check if child process has terminated. > Set and return returncode attribute.

Re: [Qemu-devel] [PATCH v8 08/13] qemu.py: refactor launch()

2017-09-04 Thread Fam Zheng
On Fri, 09/01 13:28, Amador Pahim wrote: > This is just an refactor to separate the exception handler from the > actual launch procedure, improving the readability and making future > maintenances in this piece of code easier. > > Signed-off-by: Amador Pahim Reviewed-by: Fam Zheng

Re: [Qemu-devel] [PATCH v8 09/13] qemu.py: always cleanup on shutdown()

2017-09-04 Thread Fam Zheng
On Fri, 09/01 13:28, Amador Pahim wrote: > Currently we only cleanup on shutdown() if the VM is running. > > To make sure we will always cleanup, this patch makes the cleanup to > always happen in shutdown, regardless the VM running state. > > Signed-off-by: Amador Pahim Reviewed-by: Fam Zheng

Re: [Qemu-devel] [PATCH v8 07/13] qemu.py: close _qemu_log_path on cleanup

2017-09-04 Thread Fam Zheng
On Fri, 09/01 13:28, Amador Pahim wrote: > We are opening the _qemu_log_path during the launch() but we are > forgetting to close it. > > This patch makes sure we will close the self._qemu_log_path during the > cleanup (post_shutdown()). > > Signed-off-by: Amador Pahim > --- > scripts/qemu.py |

Re: [Qemu-devel] [PATCH v8 05/13] qemu.py: include debug information on launch error

2017-09-04 Thread Fam Zheng
On Fri, 09/01 13:28, Amador Pahim wrote: > When launching a VM, if an exception happens and the VM is not > initiated, it might be useful to see the qemu command line and > the qemu command output. > > This patch creates that message. Notice that self._iolog needs to be > cleaned up in the beginni

Re: [Qemu-devel] [PATCH v8 03/13] qemu.py: use os.path.null instead of /dev/null

2017-09-04 Thread Fam Zheng
On Fri, 09/01 13:28, Amador Pahim wrote: > For increased portability, let's use os.path.devnull. > > Signed-off-by: Amador Pahim Reviewed-by: Fam Zheng

Re: [Qemu-devel] [PATCH v8 04/13] qemu.py: improve message on negative exit code

2017-09-04 Thread Fam Zheng
On Fri, 09/01 13:28, Amador Pahim wrote: > The current message shows 'self._args', which contains only part of the > options used in the Qemu command line. > > This patch makes the qemu full args list an instance variable and then > uses it in the negative exit code message. > > Message was moved

Re: [Qemu-devel] [PATCH v8 01/13] qemu.py: fix is_running() return before first launch()

2017-09-04 Thread Fam Zheng
On Fri, 09/01 13:28, Amador Pahim wrote: > is_running() returns None when called before the first time we > call launch(): > > >>> import qemu > >>> vm = qemu.QEMUMachine('qemu-system-x86_64') > >>> vm.is_running() > >>> > > It should return False instead. This patch fixes that. >

Re: [Qemu-devel] [PATCH v8 02/13] qemu.py: avoid writing to stdout/stderr

2017-09-04 Thread Fam Zheng
On Fri, 09/01 13:28, Amador Pahim wrote: > This module should not write directly to stdout/stderr. Instead, it > should either raise exceptions or just log the messages and let the > callers handle them and decide what to do. For example, scripts could > choose to send the log messages stderr or/an

[Qemu-devel] [PATCH v4 6/6] docker: Drop 'set -e' from run script

2017-09-04 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/docker/run | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tests/docker/run b/tests/docker/run index 9eb9165f76..aad91f6ef5 100755 --- a/tests/docker/run +++ b/tests/docker/run @@ -1,4 +1,4 @@ -#!/bin/bash -e +#!/bin/bash # # Docker

[Qemu-devel] [PATCH v4 5/6] docker: Add test-block

2017-09-04 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/docker/test-block | 22 ++ 1 file changed, 22 insertions(+) create mode 100755 tests/docker/test-block diff --git a/tests/docker/test-block b/tests/docker/test-block new file mode 100755 index 00..64d8bbadf7 --- /dev/null +++ b/test

[Qemu-devel] [PATCH v4 3/6] docker: Use unconfined security profile

2017-09-04 Thread Fam Zheng
Some by default blocked syscalls are required to run tests for example userfaultfd. Reviewed-by: Kashyap Chamarthy Signed-off-by: Fam Zheng --- tests/docker/Makefile.include | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index 7

[Qemu-devel] [PATCH v4 4/6] docker: Add nettle-devel to fedora image

2017-09-04 Thread Fam Zheng
The LUKS cases in qemu-iotests requires this. Reviewed-by: Kashyap Chamarthy Signed-off-by: Fam Zheng --- tests/docker/dockerfiles/fedora.docker | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker index 4eaa8ed2a5.

[Qemu-devel] [PATCH v4 2/6] docker: Add test_fail and prep_fail

2017-09-04 Thread Fam Zheng
They both print a message and exit, but with different status code so distinguish real test errors from env preparation failures. Signed-off-by: Fam Zheng --- tests/docker/common.rc | 12 1 file changed, 12 insertions(+) diff --git a/tests/docker/common.rc b/tests/docker/common.rc

[Qemu-devel] [PATCH v4 1/6] docker: Fix return code of build_qemu()

2017-09-04 Thread Fam Zheng
Without "set -e", the "&&" makes sure that the return code reflects the result status, and that make only runs if configure succeeds. Signed-off-by: Fam Zheng --- tests/docker/common.rc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/docker/common.rc b/tests/docker/co

[Qemu-devel] [PATCH v4 0/6] docker: Add test-block

2017-09-04 Thread Fam Zheng
Based-on: 20170905021201.25684-1-f...@redhat.com ([PATCH v6 00/12] tests: Add VM based build tests (for non-x86_64 and/or non-Linux)) A few tweaks to the docker images and running commands allow us to run qemu-iotests in the fedora container. This will be added to the patchew test cases later. v4

Re: [Qemu-devel] [PATCH] e1000: Rename the SEC symbol to SEQEC

2017-09-04 Thread Jason Wang
On 2017年09月05日 07:51, Kamil Rytarowski wrote: Please put it on a pull-request queue. I don't maintain one myself. On 04.09.2017 09:29, Dmitry Fleytman wrote: Reviewed-by: Dmitry Fleytman On 4 Sep 2017, at 10:23 AM, Fam Zheng wrote: On Sun, 09/03 18:37, Kamil Rytarowski wrote: SunOS defi

Re: [Qemu-devel] [PATCH v9 0/4] Improve error reporting

2017-09-04 Thread Jason Wang
On 2017年09月04日 22:35, Mao Zhongyi wrote: v9: * -rebase on upstream -fix the commit message of patch04 v8: * PATCH 02 & 04 -resetting the error message for the user to read. [Markus Armbruster] -fix the indentation and commit message. [Markus Armbruster] v7: * PATCH 01 -fix

Re: [Qemu-devel] [PATCH v3 3/3] docker: Add test-block

2017-09-04 Thread Fam Zheng
On Fri, 09/01 13:35, Eric Blake wrote: > On 09/01/2017 10:22 AM, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > --- > > tests/docker/test-block | 22 ++ > > 1 file changed, 22 insertions(+) > > create mode 100755 tests/docker/test-block > > > > diff --git a/tests/docker/t

[Qemu-devel] [PATCH v6 12/12] docker: Use archive-source.py

2017-09-04 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/docker/Makefile.include | 15 ++- tests/docker/run | 8 +--- 2 files changed, 3 insertions(+), 20 deletions(-) diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index aaab1a4208..7a027d5bd6 100644 --- a/tes

[Qemu-devel] [PATCH v6 10/12] MAINTAINERS: Add tests/vm entry

2017-09-04 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Stefan Hajnoczi --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5ec945c9af..f6b0fd156e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1897,6 +1897,7 @@ S: Maintained F: .travis.yml F: .shippable.yml F: t

[Qemu-devel] [PATCH v6 11/12] tests: Add README for vm tests

2017-09-04 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/vm/README | 63 + 1 file changed, 63 insertions(+) create mode 100644 tests/vm/README diff --git a/tests/vm/README b/tests/vm/README new file mode 100644 index 00..7d2fe4ac8d --- /dev/null +++ b/t

[Qemu-devel] [PATCH v6 05/12] tests: Add ubuntu.i386 image

2017-09-04 Thread Fam Zheng
This adds a 32bit guest. The official LTS cloud image is downloaded and initialized with cloud-init. Signed-off-by: Fam Zheng --- tests/vm/ubuntu.i386 | 88 1 file changed, 88 insertions(+) create mode 100755 tests/vm/ubuntu.i386 diff --git

[Qemu-devel] [PATCH v6 07/12] tests: Add NetBSD image

2017-09-04 Thread Fam Zheng
The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng Reviewed-by: Kamil Rytarowski --- tests/vm/netbsd | 42 ++ 1 file changed, 42 insertions(+) create mode 100755 tests/vm/netbsd diff --git a/tes

[Qemu-devel] [PATCH v6 09/12] Makefile: Add rules to run vm tests

2017-09-04 Thread Fam Zheng
Signed-off-by: Fam Zheng --- Makefile | 2 ++ configure | 2 +- tests/vm/Makefile.include | 42 ++ 3 files changed, 45 insertions(+), 1 deletion(-) create mode 100644 tests/vm/Makefile.include diff --git a/Makefile b/Mak

[Qemu-devel] [PATCH v6 08/12] tests: Add OpenBSD image

2017-09-04 Thread Fam Zheng
The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng --- tests/vm/openbsd | 43 +++ 1 file changed, 43 insertions(+) create mode 100755 tests/vm/openbsd diff --git a/tests/vm/openbsd b/tests/vm/ope

[Qemu-devel] [PATCH v6 02/12] qemu.py: Add "wait()" method

2017-09-04 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Stefan Hajnoczi --- scripts/qemu.py | 7 +++ 1 file changed, 7 insertions(+) diff --git a/scripts/qemu.py b/scripts/qemu.py index 880e3e8219..153f2d1564 100644 --- a/scripts/qemu.py +++ b/scripts/qemu.py @@ -143,6 +143,13 @@ class QEMUMachine(object):

[Qemu-devel] [PATCH v6 04/12] tests: Add vm test lib

2017-09-04 Thread Fam Zheng
This is the common code to implement a "VM test" to 1) Download and initialize a pre-defined VM that has necessary dependencies to build QEMU and SSH access. 2) Archive $SRC_PATH to a .tar file. 3) Boot the VM, and pass the source tar file to the guest. 4) SSH into the VM, untar the s

[Qemu-devel] [PATCH v6 06/12] tests: Add FreeBSD image

2017-09-04 Thread Fam Zheng
The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng --- tests/vm/freebsd | 42 ++ 1 file changed, 42 insertions(+) create mode 100755 tests/vm/freebsd diff --git a/tests/vm/freebsd b/tests/vm/free

[Qemu-devel] [PATCH v6 03/12] scripts: Add archive-source.sh

2017-09-04 Thread Fam Zheng
Signed-off-by: Fam Zheng --- scripts/archive-source.sh | 31 +++ 1 file changed, 31 insertions(+) create mode 100755 scripts/archive-source.sh diff --git a/scripts/archive-source.sh b/scripts/archive-source.sh new file mode 100755 index 00..3cae7f34d3 --- /de

[Qemu-devel] [PATCH v6 00/12] tests: Add VM based build tests (for non-x86_64 and/or non-Linux)

2017-09-04 Thread Fam Zheng
v6: Add license to new file. [Philippe] Change tests/.gitignore. [Philippe] v5: Generate source tar file with a script. Fix tmpdir, use pwd. Reduce default -j to half cores. v4: Drop unused imports and parameters. [Cleber] Use --exclude-vcs (still no --exclude-vcs-ignores because

[Qemu-devel] [PATCH v6 01/12] gitignore: Ignore vm test images

2017-09-04 Thread Fam Zheng
Signed-off-by: Fam Zheng --- .gitignore | 1 + tests/.gitignore | 1 + 2 files changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index cf65316863..40acfcb9e2 100644 --- a/.gitignore +++ b/.gitignore @@ -52,6 +52,7 @@ /vscclient /vhost-user-scsi /fsdev/virtfs-proxy-helper +*.

Re: [Qemu-devel] [PATCH V5 1/3] net/colo-compare.c: Optimize unpredictable tcp options comparison

2017-09-04 Thread Dou Liyang
Hi Chen, At 09/04/2017 02:14 PM, Zhang Chen wrote: When network is busy, some tcp options(like sack) will unpredictable occur in primary side or secondary side. it will make packet size not same, but the two packet's payload is identical. colo just care about packet payload, so we skip the optio

Re: [Qemu-devel] [PATCH v5 03/12] scripts: Add archive-source.sh

2017-09-04 Thread Fam Zheng
On Fri, 09/01 17:31, Philippe Mathieu-Daudé wrote: > On 08/31/2017 03:42 AM, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > --- > > scripts/archive-source.sh | 29 + > > 1 file changed, 29 insertions(+) > > create mode 100755 scripts/archive-source.sh > > > > d

Re: [Qemu-devel] [PATCH v5 01/12] gitignore: Ignore vm test images

2017-09-04 Thread Fam Zheng
On Fri, 09/01 17:32, Philippe Mathieu-Daudé wrote: > On 08/31/2017 03:42 AM, Fam Zheng wrote: > > Reviewed-by: Stefan Hajnoczi > > Reviewed-by: Philippe Mathieu-Daudé > > Signed-off-by: Fam Zheng > > --- > > .gitignore | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/.gitigno

Re: [Qemu-devel] [PATCH v5 05/12] tests: Add ubuntu.i386 image

2017-09-04 Thread Fam Zheng
On Fri, 09/01 16:50, Philippe Mathieu-Daudé wrote: > Hi Fam, > > On 08/31/2017 03:42 AM, Fam Zheng wrote: > > This adds a 32bit guest. > > > > The official LTS cloud image is downloaded and initialized with > > cloud-init. > > > > Signed-off-by: Fam Zheng > > --- > > tests/vm/ubuntu.i386 | 88

Re: [Qemu-devel] [PATCH 1/1] net: Add SunGEM device emulation as found on Apple UniNorth

2017-09-04 Thread David Gibson
On Mon, Sep 04, 2017 at 07:39:38PM +0100, Mark Cave-Ayland wrote: > From: Benjamin Herrenschmidt > > This adds a simplistic emulation of the Sun GEM ethernet controller > found in Apple ASICs. > > Currently we only support the Apple UniNorth 1.x variant, but the > other Apple or Sun variants sho

Re: [Qemu-devel] [PATCH] x86/acpi: build SRAT when memory hotplug is enabled

2017-09-04 Thread Dou Liyang
Hi Eduardo, At 09/04/2017 09:08 PM, Eduardo Habkost wrote: [...] In my opinion, this may also add the hotpluggable memory, and see the following commemts. /* * Entry is required for Windows to enable memory hotplug in OS * and for Linux to enable SWIOTLB when booted with less than

Re: [Qemu-devel] [PATCHv5 01/03] qemu-iothread: IOThread supports theGMainContext event loop

2017-09-04 Thread wang.yong155
>> IOThread uses AioContext event loop and does not run a GMainContext. >> Therefore,chardev cannot work in IOThread,such as the chardev is >> used for colo-compare packets reception. >> >> This patch makes the IOThread run the GMainContext event loop, >> chardev and IOThread can work togethe

Re: [Qemu-devel] [PATCH v5 1/3] hw/acpi-build: Fix SRAT memory building in case of node 0 without RAM

2017-09-04 Thread Dou Liyang
Hi Igor, At 09/04/2017 07:11 PM, Igor Mammedov wrote: [...] +if (mem_base <= HOLE_640K_START && +next_base > HOLE_640K_START) { +mem_len -= next_base - HOLE_640K_START; +if (mem_len > 0) { +numamem = acpi_data_push(table_data, sizeof *n

Re: [Qemu-devel] [PATCH] memory: Rename queue to mrqueue (memory region queue)

2017-09-04 Thread Kamil Rytarowski
+CC jperkin On 05.09.2017 01:57, Kamil Rytarowski wrote: > On 04.09.2017 02:39, Philippe Mathieu-Daudé wrote: >> Hi Kamil, >> >> On 09/03/2017 01:33 PM, Kamil Rytarowski wrote: >>> SunOS declares struct queue in . >> >> I didn't check what is this define for, but I'd rather add in >> include/sysem

Re: [Qemu-devel] [PATCH] memory: Rename queue to mrqueue (memory region queue)

2017-09-04 Thread Kamil Rytarowski
On 04.09.2017 02:39, Philippe Mathieu-Daudé wrote: > Hi Kamil, > > On 09/03/2017 01:33 PM, Kamil Rytarowski wrote: >> SunOS declares struct queue in . > > I didn't check what is this define for, but I'd rather add in > include/sysemu/os-posix.h: > > #ifdef queue > #undef queue > #endif > > If n

Re: [Qemu-devel] [PATCH] e1000: Rename the SEC symbol to SEQEC

2017-09-04 Thread Kamil Rytarowski
Please put it on a pull-request queue. I don't maintain one myself. On 04.09.2017 09:29, Dmitry Fleytman wrote: > Reviewed-by: Dmitry Fleytman > >> On 4 Sep 2017, at 10:23 AM, Fam Zheng wrote: >> >> On Sun, 09/03 18:37, Kamil Rytarowski wrote: >>> SunOS defines SEC in as 1 (commonly used time

Re: [Qemu-devel] [PATCH] tests: Do not include lutil on SunOS

2017-09-04 Thread Kamil Rytarowski
On 04.09.2017 11:32, Peter Maydell wrote: > On 3 September 2017 at 17:49, Kamil Rytarowski wrote: >> This fixes build on SmartOS (Joyent). >> >> Patch cherry-picked from pkgsrc by jperkin (Joyent). >> >> Signed-off-by: Kamil Rytarowski >> --- >> tests/Makefile.include | 2 ++ >> 1 file changed,

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/1] ppc: spapr: Move VCPU ID calculation into sPAPR

2017-09-04 Thread Sam Bobroff
On Mon, Sep 04, 2017 at 12:18:57PM +0200, Greg Kurz wrote: > On Thu, 31 Aug 2017 16:38:46 +1000 > Sam Bobroff wrote: > > > Move the calculation of a CPU's VCPU ID out of the generic PPC code > > (ppc_cpu_realizefn()) and into sPAPR specific code > > (spapr_cpu_core_realize()) where it belongs. >

Re: [Qemu-devel] [PATCH v2] usb-mtp: Add fallback definition of NAME_MAX

2017-09-04 Thread Kamil Rytarowski
On 04.09.2017 19:50, Peter Maydell wrote: > On 4 September 2017 at 18:25, Kamil Rytarowski wrote: >> This fixes build on SmartOS (Joyent). >> >> Patch cherry-picked from pkgsrc by jperkin (Joyent). >> >> Signed-off-by: Kamil Rytarowski >> Reviewed-by: Philippe Mathieu-Daudé >> --- >> include/qe

[Qemu-devel] [PATCH 4/4] ppc: kvm: update HPT pointer in KVM PR after migration

2017-09-04 Thread Greg Kurz
When running with KVM PR, a pseries machine needs to allocate an HPT in userspace and pass its address to KVM. This is done by hijacking the SDR1 slot. It is very likely that the destination QEMU will allocate the HPT at a different address, ie, the SDR1 value we get from the migration stream is w

[Qemu-devel] [PATCH 1/4] spapr: only update SDR1 once per-cpu during CAS

2017-09-04 Thread Greg Kurz
Commit b55d295e3ec9 added the possibility to support HPT resizing with KVM. In the case of PR, we need to pass the userspace address of the HPT to KVM using the SDR1 slot. This is handled by kvmppc_update_sdr1() which uses CPU_FOREACH() to update all CPUs. It is hence not needed to call kvmppc_upda

[Qemu-devel] [PATCH 3/4] ppc: kvm: introduce a helper to update SDR1 for a single CPU

2017-09-04 Thread Greg Kurz
When running with KVM PR, we hijack the SDR1 slot to pass the address of the HPT allocated by QEMU to KVM. On pseries virtual machines, we have to do this when the guest calls the KVMPPC_H_CAS or the H_RESIZE_HPT_COMMIT hypercalls. This is currently handled by kvmppc_update_sdr1() which updates SD

[Qemu-devel] [PATCH 2/4] spapr: introduce a helper to compute the address of the HPT

2017-09-04 Thread Greg Kurz
The formula used to compute the address of the HPT allocated by QEMU is open-coded in several places. This patch moves the magic to a dedicated helper. While here, we also patch the callers to only pass the address to KVM if we indeed have a userland HPT (ie, KVM PR). Signed-off-by: Greg Kurz ---

[Qemu-devel] [PATCH 0/4] ppc: fix migration with KVM PR (nested)

2017-09-04 Thread Greg Kurz
A guest running with KVM PR ends up irresponsive after migration most of the time. This happens because the HPT allocated by QEMU is likely to have a different address on the destination than it had on the source, but we push the source address to KVM. This series does a little cleanup and fixes t

Re: [Qemu-devel] [PATCH v4] target/m68k: Switch fpu_rom from make_floatx80() to make_floatx80_init()

2017-09-04 Thread Laurent Vivier
Le 04/09/2017 à 23:23, Kamil Rytarowski a écrit : > GCC 4.7.2 on SunOS reports that the values assigned to array members are not > real constants: > > target/m68k/fpu_helper.c:32:5: error: initializer element is not constant > target/m68k/fpu_helper.c:32:5: error: (near initialization for 'fpu_rom

Re: [Qemu-devel] [PATCH v3] target/m68k: Switch fpu_rom from make_floatx80() to make_floatx80_init()

2017-09-04 Thread Kamil Rytarowski
On 04.09.2017 21:02, Laurent Vivier wrote: > > I don't want to be picky, but you should use "ULL" instead of "LL" for > the new values. > I was wondering why the integer is shorter.. should be fixed in v4. signature.asc Description: OpenPGP digital signature

[Qemu-devel] [PATCH v4] target/m68k: Switch fpu_rom from make_floatx80() to make_floatx80_init()

2017-09-04 Thread Kamil Rytarowski
GCC 4.7.2 on SunOS reports that the values assigned to array members are not real constants: target/m68k/fpu_helper.c:32:5: error: initializer element is not constant target/m68k/fpu_helper.c:32:5: error: (near initialization for 'fpu_rom[0]') rules.mak:66: recipe for target 'target/m68k/fpu_helpe

Re: [Qemu-devel] [PATCH] configure: Drop AIX host support

2017-09-04 Thread Kamil Rytarowski
On 04.09.2017 19:19, Peter Maydell wrote: > Nobody has mentioned AIX host support on the mailing list for years, > and we have no test systems for it so it is most likely broken. > We've advertised in configure for two releases now that we plan > to drop support for this host OS, and have had no co

Re: [Qemu-devel] qdev_get_machine() can return something non-NULL but not TYPE_MACHINE

2017-09-04 Thread Igor Mammedov
On Mon, 4 Sep 2017 17:36:59 +0100 Peter Maydell wrote: > I just got bitten by qdev_get_machine()'s behaviour on the user-only > emulators, where it can return something that isn't NULL and isn't > an instance of TYPE_MACHINE either. user-only shouldn't get to qdev_get_machine() at all, issue prob

Re: [Qemu-devel] [PATCH] .dir-locals.el: Explicitly set indentation level

2017-09-04 Thread Thiago Jung Bauermann
Thiago Jung Bauermann writes: > At least in some configurations, setting c-file-style is not enough to > conform to the QEMU coding style, so explicitly set c-basic-offset as well. > > Signed-off-by: Thiago Jung Bauermann > --- > > My emacs was using indentation level of 8 spaces and this patch

Re: [Qemu-devel] [PATCH 3/6] cpu: rename cpu_parse_features() to cpu_parse_cpu_model()

2017-09-04 Thread Igor Mammedov
On Mon, 4 Sep 2017 12:03:09 -0300 Philippe Mathieu-Daudé wrote: > Hi Igor, > > On 09/04/2017 11:00 AM, Igor Mammedov wrote: > > function not just parses features but also converts CPU model > > name to CPU type, rename it to reflect what it actualy does. > > Why not squash this with your 1st pa

Re: [Qemu-devel] [PATCH v3] target/m68k: Switch fpu_rom from make_floatx80() to make_floatx80_init()

2017-09-04 Thread Laurent Vivier
Le 04/09/2017 à 19:32, Kamil Rytarowski a écrit : > GCC 4.7.2 on SunOS reports that the values assigned to array members are not > real constants: > > target/m68k/fpu_helper.c:32:5: error: initializer element is not constant > target/m68k/fpu_helper.c:32:5: error: (near initialization for 'fpu_rom

Re: [Qemu-devel] [PATCH] configure: Drop AIX host support

2017-09-04 Thread Laurent Vivier
Le 04/09/2017 à 19:19, Peter Maydell a écrit : > Nobody has mentioned AIX host support on the mailing list for years, > and we have no test systems for it so it is most likely broken. > We've advertised in configure for two releases now that we plan > to drop support for this host OS, and have had

[Qemu-devel] [PATCH] i386: Use designated initializers on feat_names arrays

2017-09-04 Thread Eduardo Habkost
Using designated initializers for feat_names allows us to omit NULL entries, and makes mistakes easier to spot (especially when cherry-picking or merging commits). Arrays that have very few entries were changed to have a designator for every element. Arrays that have almost every item present wer

[Qemu-devel] [PATCH 1/1] net: Add SunGEM device emulation as found on Apple UniNorth

2017-09-04 Thread Mark Cave-Ayland
From: Benjamin Herrenschmidt This adds a simplistic emulation of the Sun GEM ethernet controller found in Apple ASICs. Currently we only support the Apple UniNorth 1.x variant, but the other Apple or Sun variants should mostly be a matter of adding PCI IDs options. We have a very primitive emul

[Qemu-devel] [PATCH 0/1] net: Add SunGEM device emulation as found on Apple UniNorth

2017-09-04 Thread Mark Cave-Ayland
This is a reworking of Ben's original implementation of the SunGEM device from last year: https://lists.gnu.org/archive/html/qemu-devel/2016-08/msg02571.html. The reason for implenting this device is that it allows out-of-the-box networking for most MacOS 9 and MacOS X OSs running under qemu-syst

Re: [Qemu-devel] [PATCH] wm8750: add record buffer underrun check

2017-09-04 Thread P J P
+-- On Fri, 1 Sep 2017, Gerd Hoffmann wrote --+ | diff --git a/hw/audio/wm8750.c b/hw/audio/wm8750.c | index f8b5bebfc2..d2bf2e1da1 100644 | --- a/hw/audio/wm8750.c | +++ b/hw/audio/wm8750.c | @@ -680,8 +680,12 @@ uint32_t wm8750_adc_dat(void *opaque) | WM8750State *s = (WM8750State *) opaque;

Re: [Qemu-devel] [PATCH] configure: Drop AIX host support

2017-09-04 Thread Peter Maydell
On 4 September 2017 at 19:09, Thomas Huth wrote: > On 04.09.2017 19:19, Peter Maydell wrote: >> Nobody has mentioned AIX host support on the mailing list for years, >> and we have no test systems for it so it is most likely broken. >> We've advertised in configure for two releases now that we plan

Re: [Qemu-devel] [PATCH] configure: Drop AIX host support

2017-09-04 Thread Thomas Huth
On 04.09.2017 19:19, Peter Maydell wrote: > Nobody has mentioned AIX host support on the mailing list for years, > and we have no test systems for it so it is most likely broken. > We've advertised in configure for two releases now that we plan > to drop support for this host OS, and have had no co

  1   2   3   4   >