Re: [Qemu-devel] [PATCH for-2.11 v2] file-posix: Clear out first sector in hdev_create

On Fri, 08/11 16:09, Fam Zheng wrote: > People get surprised when, after "qemu-img create -f raw /dev/sdX", they > still see qcow2 with "qemu-img info", if previously the bdev had a qcow2 > header. While this is natural because raw doesn't need to write any > magic bytes during creation, hdev_creat

Re: [Qemu-devel] [PATCHv3 0/2] pci: allow PCI bus slots to be marked as reserved

On 16/07/17 21:27, Mark Cave-Ayland wrote: > For some machines it is impossible to plug devices into a particular PCI bus > slot, e.g. for a real Ultra 5 there are 2 PCI bridges attached to the root > bus behind which all devices must be plugged. Ignoring this rule will cause > problems with inter

Re: [Qemu-devel] [PATCH v5 00/12] tests: Add VM based build tests (for non-x86_64 and/or non-Linux)

Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170831064302.14427-1-f...@redhat.com Subject: [Qemu-devel] [PATCH v5 00/12] tests: Add VM based build tests (for non-x86_64 and/or non-Linux) Type: series === TEST SCRIPT BEGIN === #!/

Re: [Qemu-devel] [PATCH v2] qemu-img: Clarify about relative backing file options

On Fri, 08/04 22:36, Fam Zheng wrote: > It's not too surprising when a user specifies the backing file relative > to the current working directory instead of the top layer image. This > causes error when they differ. Though the error message has enough > information to infer the fact about the misu

Re: [Qemu-devel] [PATCHv5 01/03] qemu-iothread: IOThread supports the GMainContext event loop

On Thu, 08/31 10:18, Fam Zheng wrote: > On Tue, 08/29 15:22, Wang yong wrote: > > From: Wang Yong > > > > IOThread uses AioContext event loop and does not run a GMainContext. > > Therefore,chardev cannot work in IOThread,such as the chardev is > > used for colo-compare packets reception. > > > >

Re: [Qemu-devel] reduce write bandwidth of qcow2 driver while allocating new cluster

On Wed, Aug 30, 2017 at 01:15:33PM +0300, Anton Nefedov wrote: > > On 29/08/2017 05:56, Liu Qing wrote: > >On Mon, Aug 28, 2017 at 10:46:34AM -0500, Eric Blake wrote: > >>[adding qemu-block] > >> > >>On 08/28/2017 12:56 AM, Liu Qing wrote: > >>>Dear list, > >>>Recently I used fio to test qcow2

Re: [Qemu-devel] [PATCH v2 2/3] block-jobs: Optionally unregister live block operations

Eric Blake writes: > On 08/30/2017 12:24 PM, Eduardo Habkost wrote: >> On Wed, Aug 30, 2017 at 01:01:41PM -0400, Jeff Cody wrote: >>> From: Jeffrey Cody >>> >>> If configured without live block operations enabled, unregister the >>> live block operation commands. >>> >>> Signed-off-by: Jeff Cody

[Qemu-devel] [PATCH v5 10/12] MAINTAINERS: Add tests/vm entry

Signed-off-by: Fam Zheng Reviewed-by: Stefan Hajnoczi --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index ccee28b12d..0ed607d003 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1881,6 +1881,7 @@ S: Maintained F: .travis.yml F: .shippable.yml F: t

[Qemu-devel] [PATCH v5 12/12] docker: Use archive-source.py

Signed-off-by: Fam Zheng --- tests/docker/Makefile.include | 15 ++- tests/docker/run | 8 +--- 2 files changed, 3 insertions(+), 20 deletions(-) diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index aaab1a4208..7a027d5bd6 100644 --- a/tes

Re: [Qemu-devel] [PATCHv5 01/03] qemu-iothread: IOThread supports theGMainContext event loop

On Thu, 08/31 11:27, wang.yong...@zte.com.cn wrote: > >> From: Wang Yong > > >> > > >> IOThread uses AioContext event loop and does not run a GMainContext. > > >> Therefore,chardev cannot work in IOThread,such as the chardev is > > >> used for colo-compare packets reception. > > >> > > >>

[Qemu-devel] [PATCH v5 09/12] Makefile: Add rules to run vm tests

Signed-off-by: Fam Zheng --- Makefile | 2 ++ configure | 2 +- tests/vm/Makefile.include | 42 ++ 3 files changed, 45 insertions(+), 1 deletion(-) create mode 100644 tests/vm/Makefile.include diff --git a/Makefile b/Mak

[Qemu-devel] [PATCH v5 06/12] tests: Add FreeBSD image

The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng --- tests/vm/freebsd | 42 ++ 1 file changed, 42 insertions(+) create mode 100755 tests/vm/freebsd diff --git a/tests/vm/freebsd b/tests/vm/free

[Qemu-devel] [PATCH v5 11/12] tests: Add README for vm tests

Signed-off-by: Fam Zheng --- tests/vm/README | 63 + 1 file changed, 63 insertions(+) create mode 100644 tests/vm/README diff --git a/tests/vm/README b/tests/vm/README new file mode 100644 index 00..7d2fe4ac8d --- /dev/null +++ b/t

[Qemu-devel] [PATCH v5 07/12] tests: Add NetBSD image

The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng Reviewed-by: Kamil Rytarowski --- tests/vm/netbsd | 42 ++ 1 file changed, 42 insertions(+) create mode 100755 tests/vm/netbsd diff --git a/tes

[Qemu-devel] [PATCH v5 08/12] tests: Add OpenBSD image

The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng --- tests/vm/openbsd | 43 +++ 1 file changed, 43 insertions(+) create mode 100755 tests/vm/openbsd diff --git a/tests/vm/openbsd b/tests/vm/ope

[Qemu-devel] [PATCH v5 05/12] tests: Add ubuntu.i386 image

This adds a 32bit guest. The official LTS cloud image is downloaded and initialized with cloud-init. Signed-off-by: Fam Zheng --- tests/vm/ubuntu.i386 | 88 1 file changed, 88 insertions(+) create mode 100755 tests/vm/ubuntu.i386 diff --git

[Qemu-devel] [PATCH v5 01/12] gitignore: Ignore vm test images

Reviewed-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Fam Zheng --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index cf65316863..643e23e515 100644 --- a/.gitignore +++ b/.gitignore @@ -52,6 +52,8 @@ /vscclient /vhost-user

[Qemu-devel] [PATCH v5 03/12] scripts: Add archive-source.sh

Signed-off-by: Fam Zheng --- scripts/archive-source.sh | 29 + 1 file changed, 29 insertions(+) create mode 100755 scripts/archive-source.sh diff --git a/scripts/archive-source.sh b/scripts/archive-source.sh new file mode 100755 index 00..84e84961d4 --- /dev/

[Qemu-devel] [PATCH v5 00/12] tests: Add VM based build tests (for non-x86_64 and/or non-Linux)

v5: Generate source tar file with a script. Fix tmpdir, use pwd. Reduce default -j to half cores. v4: Drop unused imports and parameters. [Cleber] Use --exclude-vcs (still no --exclude-vcs-ignores because it's too new). [Philippe] Use gtar if available. [Philippe, Kamil] /dev/

[Qemu-devel] [PATCH v5 02/12] qemu.py: Add "wait()" method

Signed-off-by: Fam Zheng Reviewed-by: Stefan Hajnoczi --- scripts/qemu.py | 7 +++ 1 file changed, 7 insertions(+) diff --git a/scripts/qemu.py b/scripts/qemu.py index 880e3e8219..153f2d1564 100644 --- a/scripts/qemu.py +++ b/scripts/qemu.py @@ -143,6 +143,13 @@ class QEMUMachine(object):

[Qemu-devel] [PATCH v5 04/12] tests: Add vm test lib

This is the common code to implement a "VM test" to 1) Download and initialize a pre-defined VM that has necessary dependencies to build QEMU and SSH access. 2) Archive $SRC_PATH to a .tar file. 3) Boot the VM, and pass the source tar file to the guest. 4) SSH into the VM, untar the s

Re: [Qemu-devel] [PATCH v1 08/11] s390x: allow only 1 CPU with TCG

On Wed, 30 Aug 2017 21:06:55 +0200 Thomas Huth wrote: > On 30.08.2017 19:05, David Hildenbrand wrote: > > Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the > > guest tries to bring these CPUs up but fails), because we don't support > > multiple CPUs on s390x under TCG. > > > > L

[Qemu-devel] [PATCH 1/1] ppc: spapr: Move VCPU ID calculation into sPAPR

Move the calculation of a CPU's VCPU ID out of the generic PPC code (ppc_cpu_realizefn()) and into sPAPR specific code (spapr_cpu_core_realize()) where it belongs. Unfortunately, due to the way things are ordered, we still need to default the VCPU ID in ppc_cpu_realizfn() but at least doing that d

Re: [Qemu-devel] [PATCH 1/9] s390x/css: fix cc handling for XSCH

On Thu, 31 Aug 2017 07:51:17 +0200 Thomas Huth wrote: > On 30.08.2017 18:36, Halil Pasic wrote: > > The function ioinst_handle_xsch is presenting cc 2 when it's supposed to > > present cc 1 and the other way around, because css_do_xsch has the error > > codes mixed up. Fixing the error codes also

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

Stefan Hajnoczi writes: > On Mon, Aug 21, 2017 at 04:29:44PM +0200, Markus Armbruster wrote: >> What is our Python 2 -> 3 migration strategy? >> >> Don't support Python 3 until a flag day, then flip and don't support >> Python 2? > > Add support for Python 3 so that both Python 2.6+ and Python 3

Re: [Qemu-devel] [PATCH 3/9] s390x/css: be more consistent if broken beyond repair

On 30.08.2017 18:36, Halil Pasic wrote: > If we detect that the internally manged state of the subchannel > is broken beyond repair while in do_subchannel_work in case of > virtual we just abort the operation and pretend all went well, > while in case of pass-through we honor the situation with -EN

Re: [Qemu-devel] [PATCH for-2.11 5/6] ppc: simplify cpu model lookup by PVR

On Wed, Aug 30, 2017 at 12:50:33PM +0200, Igor Mammedov wrote: > On Fri, 25 Aug 2017 19:32:29 +1000 > David Gibson wrote: > > > On Fri, Aug 25, 2017 at 09:40:37AM +0200, Igor Mammedov wrote: > > > On Fri, 25 Aug 2017 14:16:44 +1000 > > > David Gibson wrote: > > > > > > > On Thu, Aug 24, 2017

Re: [Qemu-devel] [PATCH 1/9] s390x/css: fix cc handling for XSCH

On 30.08.2017 18:36, Halil Pasic wrote: > The function ioinst_handle_xsch is presenting cc 2 when it's supposed to > present cc 1 and the other way around, because css_do_xsch has the error > codes mixed up. Fixing the error codes also fixes the priority. > > Let us fix this. (Nit: In case you re

Re: [Qemu-devel] [PATCH for-2.11 v3 0/3] hw/ppc: CAS reset on early device hotplug

On Wed, Aug 30, 2017 at 03:21:38PM -0300, Daniel Henrique Barboza wrote: > v3: > - split into 3 patches, first 2 are fixes that are independent of the > reboot code that can be applied separately: > - patch 1: spapr_drc_needed fix > - patch 2: clear pending_events on reboot, following David

Re: [Qemu-devel] [PATCH v2 02/17] MAINTAINERS: add missing Versatile PB entry

On 30.08.2017 23:55, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index b363e1b9c9..5b7891addc 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -515,6 +515,7 @@ M:

Re: [Qemu-devel] [PATCH 1/7] serial: add serial_chr_nonnull() to use the null backend when none provided

On 31.08.2017 05:53, Philippe Mathieu-Daudé wrote: > Suggested-by: Peter Maydell > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/char/serial.h | 1 + > hw/char/serial.c | 13 + > 2 files changed, 14 insertions(+) > > diff --git a/include/hw/char/serial.h b/includ

Re: [Qemu-devel] [PATCH v2 01/17] MAINTAINERS: add missing ARM entries

On 30.08.2017 23:55, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index ccee28b12d..b363e1b9c9 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS >

Re: [Qemu-devel] [PATCH v2 00/17] add missing entries in MAINTAINERS

Cc'ing Markus since I forgot to include him. On 08/30/2017 06:55 PM, Philippe Mathieu-Daudé wrote: Hi, I tried to have a more helpful ./scripts/get_maintainer.pl output, filling missing entries in MAINTAINERS. Regards, Phil. v2: - add R-b & A-b - clean ARM entries (Thomas Huth) - moved files

[Qemu-devel] [PATCH 5/7] hw/char/exynos4210_uart: use serial_chr_nonnull()

Signed-off-by: Philippe Mathieu-Daudé --- This ARRAY_SIZE() first surprised me but was valid :) hw/char/exynos4210_uart.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/hw/char/exynos4210_uart.c b/hw/char/exynos4210_uart.c index 3957e78abf..b6cdfc3006 100644

[Qemu-devel] [PATCH 6/7] hw/char/omap_uart: serial_mm_init() already check for null chr

Signed-off-by: Philippe Mathieu-Daudé --- hw/char/omap_uart.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/char/omap_uart.c b/hw/char/omap_uart.c index 6fd1b9cf6b..1f0ac0a053 100644 --- a/hw/char/omap_uart.c +++ b/hw/char/omap_uart.c @@ -63,8 +63,7 @@ struct omap_u

Re: [Qemu-devel] [PATCH v2 0/7] QOMify MIPS cpu

Cc'ing Xiaoqiang Zhao, I forgot to include him. On 08/30/2017 07:52 PM, Philippe Mathieu-Daudé wrote: Hi, This series is based on Igor's "complete cpu QOMification" [1] but only modify the MIPS part. Igor posted an updated series [2], both series should apply separately. Igor suggested on IRC

[Qemu-devel] [PATCH 7/7] hw/xtensa: serial_mm_init() already check for null chr

Signed-off-by: Philippe Mathieu-Daudé --- hw/xtensa/xtfpga.c | 4 1 file changed, 4 deletions(-) diff --git a/hw/xtensa/xtfpga.c b/hw/xtensa/xtfpga.c index 635a4d4ec3..223f396902 100644 --- a/hw/xtensa/xtfpga.c +++ b/hw/xtensa/xtfpga.c @@ -263,10 +263,6 @@ static void lx_init(const LxBoardD

[Qemu-devel] [PATCH 3/7] hw/arm/fsl_imx*: use serial_chr_nonnull()

Signed-off-by: Philippe Mathieu-Daudé --- include/hw/char/imx_serial.h | 1 + hw/arm/fsl-imx25.c | 9 + hw/arm/fsl-imx31.c | 9 + hw/arm/fsl-imx6.c| 10 +- 4 files changed, 4 insertions(+), 25 deletions(-) diff --git a/include/hw/char/im

[Qemu-devel] [PATCH 2/7] serial: use serial_chr_nonnull() in serial_mm_init()

Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- hw/char/serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/char/serial.c b/hw/char/serial.c index e4c38dc250..57e89468b4 100644 --- a/hw/char/serial.c +++ b/hw/char/serial.c @@ -1050,7 +1050,7 @@ S

[Qemu-devel] [PATCH 0/7] serial: add serial_chr_nonnull()

Hi, This series add the serial_chr_nonnull() which connect to the "null" chardev backend if none is provided. Inspired by Peter's suggestion: http://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg05987.html which also refers to this issue: http://lists.nongnu.org/archive/html/qemu-devel/2017

[Qemu-devel] [PATCH 4/7] hw/mips/malta: use serial_chr_nonnull()

Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/mips_malta.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c index af678f5784..8620e9c42c 100644 --- a/hw/mips/mips_malta.c +++ b/hw/mips/mips_malta.c @@ -1035,11 +1035,7 @@ void

[Qemu-devel] [PATCH 1/7] serial: add serial_chr_nonnull() to use the null backend when none provided

Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- include/hw/char/serial.h | 1 + hw/char/serial.c | 13 + 2 files changed, 14 insertions(+) diff --git a/include/hw/char/serial.h b/include/hw/char/serial.h index c4daf11a14..96bccb39e1 100644 --- a/includ

Re: [Qemu-devel] [RFC v2 0/8] monitor: allow per-monitor thread

On Wed, Aug 30, 2017 at 11:13:11AM +0100, Daniel P. Berrange wrote: > On Wed, Aug 30, 2017 at 09:06:20AM +0200, Markus Armbruster wrote: > > "Daniel P. Berrange" writes: > > > > > On Wed, Aug 23, 2017 at 02:51:03PM +0800, Peter Xu wrote: > > > > >> However, even with the series, it does not mean

Re: [Qemu-devel] [PATCHv5 01/03] qemu-iothread: IOThread supports theGMainContext event loop

>> From: Wang Yong >> >> IOThread uses AioContext event loop and does not run a GMainContext. >> Therefore,chardev cannot work in IOThread,such as the chardev is >> used for colo-compare packets reception. >> >> This patch makes the IOThread run the GMainContext event loop, >> chardev and

Re: [Qemu-devel] [PATCHv5 01/03] qemu-iothread: IOThread supports theGMainContext event loop

>> From: Wang Yong >> >> IOThread uses AioContext >> event loop and does not run a GMainContext.>> Therefore,chardev cannot work >> in IOThread,such as the chardev is>> used for colo-compare packets >> reception.>> >> This patch makes the IOThread run the GMainContext event >> loop,>> chardev a

Re: [Qemu-devel] [PATCHv5 01/03] qemu-iothread: IOThread supports the GMainContext event loop

On Tue, 08/29 15:22, Wang yong wrote: > From: Wang Yong > > IOThread uses AioContext event loop and does not run a GMainContext. > Therefore,chardev cannot work in IOThread,such as the chardev is > used for colo-compare packets reception. > > This patch makes the IOThread run the GMainContext ev

Re: [Qemu-devel] [PATCH 3/3] Backup Tool: Test for Incremental Backup

On Thu, 08/31 00:45, Ishani Chugh wrote: > This patch is the test for incremental backup implementation in Backup tool. > The test employs two basic subtests: > 1) Backing up an empty guest and comparing it with base image. > 2) Writing a pattern to the guest, creating backup, writing >a patter

Re: [Qemu-devel] [PATCH 1/3] Backup Tool: Manpage for Incremental Backup

On Thu, 08/31 00:45, Ishani Chugh wrote: > Adds command description to perform incremental backup and > a full example for the same. > > Signed-off-by: Ishani Chugh > --- > contrib/backup/qemu-backup.texi | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/contrib/backu

Re: [Qemu-devel] [PATCH 2/3] Backup Tool: Support for Incremental Backup

On Thu, 08/31 00:45, Ishani Chugh wrote: > Adds incremental backup functionality. > > Signed-off-by: Ishani Chugh > --- > contrib/backup/qemu-backup.py | 101 > +- > 1 file changed, 99 insertions(+), 2 deletions(-) > > diff --git a/contrib/backup/qemu-ba

Re: [Qemu-devel] [PATCH v7 07/11] qemu.py: include debug information on launch error

On Wed, 08/30 11:55, Cleber Rosa wrote: > > > On 08/18/2017 01:05 PM, Amador Pahim wrote: > > When launching a VM, if an exception happens and the VM is not > > initiated, it might be useful to see the qemu command line and > > the qemu command output. > > > > This patch creates that message. No

Re: [Qemu-devel] [PATCH] block: Cleanup BMDS in bdrv_close_all

On Wed, 08/30 16:04, Juan Quintela wrote: > Fam Zheng wrote: > > On Wed, 08/30 13:49, Juan Quintela wrote: > >> Fam Zheng wrote: > >> > This fixes the assertion due to op blockers added by BMDS: > >> > > >> > block.c:3248: bdrv_delete: Assertion `bdrv_op_blocker_is_empty(bs)' > >> > failed. > >>

Re: [Qemu-devel] [PATCH v3 0/3] QEMU Backup Tool

On Wed, 08/30 22:44, Ishani Chugh wrote: > This patch series is intended to introduce QEMU Backup tool. > qemu-backup will be a command-line tool for performing full and > incremental disk backups on running VMs. It is intended as a > reference implementation for management stack and backup develop

Re: [Qemu-devel] [PATCH] qcow2: allocate cluster_cache/cluster_data on demand

On 31/08/17 03:20, Stefan Hajnoczi wrote: > On Tue, Aug 22, 2017 at 02:56:00PM +1000, Alexey Kardashevskiy wrote: >> On 19/08/17 12:46, Alexey Kardashevskiy wrote: >>> On 19/08/17 01:18, Eric Blake wrote: On 08/18/2017 08:31 AM, Stefan Hajnoczi wrote: > Most qcow2 files are uncompressed so

Re: [Qemu-devel] [PATCH v2 7/9] AHCI: Rework IRQ constants

On 08/29/2017 11:54 PM, Philippe Mathieu-Daudé wrote: > On 08/29/2017 05:49 PM, John Snow wrote: >> Create a new enum so that we can name the IRQ bits, which will make >> debugging >> them a little nicer if we can print them out. Not handled in this >> patch, but >> this will make it possible to

Re: [Qemu-devel] [PATCH v2 5/9] IDE: replace DEBUG_AIO with trace events

CCing Laszlo Ersek literally just for laughs, as he is the most entertaining language lawyer I know of. Laszlo, please feel free to ignore this if you don't care :P On 08/29/2017 11:14 PM, Philippe Mathieu-Daudé wrote: > Hi John, > > On 08/29/2017 05:49 PM, John Snow wrote: >> Signed-off-by: Joh

Re: [Qemu-devel] [PATCH v2 10/17] MAINTAINERS: add missing SSI entries

On Wed, Aug 30, 2017 at 2:55 PM, Philippe Mathieu-Daudé wrote: > Alistair Francis volunteered :) > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Thanks, Alistair > --- > MAINTAINERS | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS

Re: [Qemu-devel] [PATCH v2 14/17] MAINTAINERS: add missing entry for Generic Loader

On Wed, Aug 30, 2017 at 2:55 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Thanks, Alistair > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index a48f633cad..0b77590dc8 100644 >

Re: [Qemu-devel] [PATCH v2 0/7] QOMify MIPS cpu

Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170830225225.27925-1-f4...@amsat.org Subject: [Qemu-devel] [PATCH v2 0/7] QOMify MIPS cpu Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BA

[Qemu-devel] [PATCH v2 6/7] mips: replace cpu_mips_init() with cpu_generic_init()

From: Igor Mammedov now cpu_mips_init() reimplements subset of cpu_generic_init() tasks, so just drop it and use cpu_generic_init() directly. Signed-off-by: Igor Mammedov Reviewed-by: Hervé Poussineau Signed-off-by: Philippe Mathieu-Daudé [PMD: use internal.h instead of cpu.h] Tested-by: Jame

[Qemu-devel] [PATCH v2 7/7] mips: update mips_cpu_list() to use object_class_get_list()

while here, move it from translate_init.c to helper.c Signed-off-by: Philippe Mathieu-Daudé Tested-by: Igor Mammedov Tested-by: James Hogan --- target/mips/helper.c | 46 target/mips/translate_init.c | 10 -- 2 files changed, 46 inse

[Qemu-devel] [PATCH v2 2/7] mips: introduce internal.h and cleanup cpu.h

no logical change, only code movement (and fix a comment typo). Signed-off-by: Philippe Mathieu-Daudé Tested-by: Igor Mammedov Tested-by: James Hogan --- This patch triggers 3 positive falses from checkpatch: ERROR: space prohibited after that '&' (ctx:WxW) #664: FILE: target/mips/internal.h:

[Qemu-devel] [PATCH v2 3/7] mips: split cpu_mips_realize_env() out of cpu_mips_init()

so it can be used in mips_cpu_realizefn() in the next commit Signed-off-by: Philippe Mathieu-Daudé Tested-by: Igor Mammedov Tested-by: James Hogan --- target/mips/internal.h | 1 + target/mips/translate.c | 19 --- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git

[Qemu-devel] [PATCH v2 1/7] mips: move hw/mips/cputimer.c to target/mips/

This timer is a required part of the MIPS32/MIPS64 System Control coprocessor (CP0). Moving it with the other architecture related files will allow an opaque use of CPUMIPSState* in the next commit (introduce "internal.h"). also remove it from 'user' targets, remove an unnecessary include. Signed

[Qemu-devel] [PATCH v2 4/7] mips: call cpu_mips_realize_env() from mips_cpu_realizefn()

Signed-off-by: Philippe Mathieu-Daudé Tested-by: Igor Mammedov Tested-by: James Hogan --- target/mips/cpu.c | 3 +++ target/mips/translate.c | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/target/mips/cpu.c b/target/mips/cpu.c index 68bf423e9d..e3ef835599 100644 --- a

[Qemu-devel] [PATCH v2 5/7] mips: MIPSCPU model subclasses

From: Igor Mammedov Register separate QOM types for each mips cpu model, so it would be possible to reuse generic CPU creation routines. Signed-off-by: Igor Mammedov Signed-off-by: Philippe Mathieu-Daudé [PMD: use internal.h, use void* to hold cpu_def in MIPSCPUClass, mark MIPSCPU abstract] T

[Qemu-devel] [PATCH v2 0/7] QOMify MIPS cpu

Hi, This series is based on Igor's "complete cpu QOMification" [1] but only modify the MIPS part. Igor posted an updated series [2], both series should apply separately. Igor suggested on IRC this series could enter via the Machine core tree, so I added Eduardo and Marcel. Regards, Phil. [1]:

Re: [Qemu-devel] [Qemu-block] [PATCH v2 8/9] AHCI: pretty-print FIS to buffer instead of stderr

On 08/30/2017 05:17 AM, Stefan Hajnoczi wrote: > On Tue, Aug 29, 2017 at 04:49:33PM -0400, John Snow wrote: >> The current FIS printing routines dump the FIS to screen. adjust this >> such that it dumps to buffer instead, then use this ability to have >> FIS dump mechanisms via trace-events inste

Re: [Qemu-devel] [PATCH v6 00/18] make dirty-bitmap byte-based

On 08/30/2017 05:05 PM, Eric Blake wrote: > There are patches floating around to add NBD_CMD_BLOCK_STATUS, > but NBD wants to report status on byte granularity (even if the > reporting will probably be naturally aligned to sectors or even > much higher levels). I've therefore started the task of

Re: [Qemu-devel] [PATCH v3 1/5] qemu-iotests: set TEST_DIR to a unique dir for each test

On Wed, Aug 30, 2017 at 06:15:05PM -0400, John Snow wrote: > > > On 08/30/2017 12:52 PM, Jeff Cody wrote: > > Right now, all qemu-iotests output data into the same scratch directory, > > and so each test needs to be responsible for cleaning up its own files. > > > > Have each test use 'scratch/$

Re: [Qemu-devel] [PATCH v3 4/5] qemu-iotests: make python tests attempt to leave intermediate files

On 08/30/2017 06:35 PM, Eric Blake wrote: > On 08/30/2017 05:28 PM, John Snow wrote: > >> I'm a little iffy on this patch; I know that ./check can take care of >> our temp files for us now, but because each python test is itself a >> little mini-harness, I'm a little leery of moving the teardown

Re: [Qemu-devel] [PATCH v3 5/5] qemu-iotests: add option to save temp files on error

On 08/30/2017 12:52 PM, Jeff Cody wrote: > Now that ./check takes care of cleaning up after each tests, it > can also selectively not clean up. Add option to leave all output from > tests intact if that test encountered an error. > > Note: this currently only works for bash tests, as the python

Re: [Qemu-devel] [PATCH v3 4/5] qemu-iotests: make python tests attempt to leave intermediate files

On 08/30/2017 05:28 PM, John Snow wrote: > I'm a little iffy on this patch; I know that ./check can take care of > our temp files for us now, but because each python test is itself a > little mini-harness, I'm a little leery of moving the teardown to setup > and trying to pre-clean the confetti be

Re: [Qemu-devel] [PATCH v3 4/5] qemu-iotests: make python tests attempt to leave intermediate files

On 08/30/2017 02:33 PM, Eric Blake wrote: > On 08/30/2017 11:52 AM, Jeff Cody wrote: >> Now that 'check' will clean up after tests, try and make python >> tests leave intermediate files so that they might be inspectable >> on failure. >> >> This isn't perfect; the python unittest framework runs m

Re: [Qemu-devel] [PATCH v3 3/5] qemu-iotests: add 'blind_remove' for python tests

On 08/30/2017 02:13 PM, Eric Blake wrote: > On 08/30/2017 11:52 AM, Jeff Cody wrote: >> Add a function to attempt to 'blindly' remove a file, without >> throwing an error if the file doesn't exist. >> >> Signed-off-by: Jeff Cody >> --- >> tests/qemu-iotests/iotests.py | 7 +++ >> 1 file cha

Re: [Qemu-devel] [PATCH v3 2/5] qemu-iotests: remove file cleanup from bash tests

On 08/30/2017 12:52 PM, Jeff Cody wrote: > All files for a given test are now self-contained in a subdirectory, > and therefore the "./check" script can do all file-related cleanup > without any help. > > This removes file cleanups from the bash tests. The only cleanup left > is whatever is nee

Re: [Qemu-devel] [PATCH v3 1/5] qemu-iotests: set TEST_DIR to a unique dir for each test

On 08/30/2017 12:52 PM, Jeff Cody wrote: > Right now, all qemu-iotests output data into the same scratch directory, > and so each test needs to be responsible for cleaning up its own files. > > Have each test use 'scratch/$seq' as its temp directory, so the check > script can do simple cleanup o

Re: [Qemu-devel] [PATCH v1 1/1] target/xtensa: Use the pre-defined MEMTXATTRS_UNSPECIFIED macro

On 30 August 2017 at 19:02, Alistair Francis wrote: > Instead of using the hardcoded (MemTxAttrs){0} for no memory attributes > let's use the already defined MEMTXATTRS_UNSPECIFIED macro instead. > > Signed-off-by: Alistair Francis > --- > > target/xtensa/op_helper.c | 4 ++-- > 1 file changed,

[Qemu-devel] [PATCH v2 14/17] MAINTAINERS: add missing entry for Generic Loader

Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index a48f633cad..0b77590dc8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1164,6 +1164,7 @@ M: Alistair Francis S: Maintained F: hw/core/generic-loader.c F: in

[Qemu-devel] [PATCH v2 13/17] MAINTAINERS: add missing AIO entry

Signed-off-by: Philippe Mathieu-Daudé Acked-by: Fam Zheng Reviewed-by: Stefan Hajnoczi --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 20d65dca73..a48f633cad 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1225,6 +1225,7 @@ F: util/aio-*.c F:

[Qemu-devel] [PATCH v2 15/17] MAINTAINERS: add missing Cryptography entry

Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0b77590dc8..7a0c00550e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1526,6 +1526,7 @@ S: Maintained F: crypto/ F: include/crypto/ F: tests/test-crypto-* +

[Qemu-devel] [PATCH v2 12/17] MAINTAINERS: add missing megasas test entry

Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index fa74b7254b..20d65dca73 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1118,6 +1118,7 @@ L: qemu-bl...@nongnu.org S: Supported F: hw/scsi/megasas.c F: hw/scs

[Qemu-devel] [PATCH v2 07/17] MAINTAINERS: add missing qcow2 entry

Signed-off-by: Philippe Mathieu-Daudé Acked-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index f4e07173c8..eb20365fbb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1841,6 +1841,7 @@ M: Max Reitz L: q

[Qemu-devel] [PATCH v2 17/17] MAINTAINERS: update docs/interop/ entries

moved in commit 7746cf8aab68 Signed-off-by: Philippe Mathieu-Daudé Acked-by: Fam Zheng Acked-by: John Snow --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 452ccd71b4..833a7a6778 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @

[Qemu-devel] [PATCH v2 05/17] MAINTAINERS: add missing VMWare entry

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Dmitry Fleytman --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 223591c231..aa185c1edd 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1126,6 +1126,7 @@ M: Dmitry Fleyt

[Qemu-devel] [PATCH v2 16/17] MAINTAINERS: update docs/devel/ entries

moved in commit ac06724a7158 Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Eric Blake --- MAINTAINERS | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 7a0c00550e..452ccd71b4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1414,7

[Qemu-devel] [PATCH v2 11/17] MAINTAINERS: add missing entries for throttling infra

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi --- MAINTAINERS | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 0a3a50aa25..fa74b7254b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1558,8 +1558,10 @@ M: Alberto Garcia S

[Qemu-devel] [PATCH v2 10/17] MAINTAINERS: add missing SSI entries

Alistair Francis volunteered :) Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index bbe1191883..0a3a50aa25 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -986,10 +986,13 @@ F: hw/scsi/lsi53c895a.c SSI M:

[Qemu-devel] [PATCH v2 08/17] MAINTAINERS: add missing USB entry

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index eb20365fbb..dd5e2c2b6b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1004,6 +1004,7 @@ F: docs/usb2.txt F: docs/usb-storage.txt F:

[Qemu-devel] [PATCH v2 02/17] MAINTAINERS: add missing Versatile PB entry

Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index b363e1b9c9..5b7891addc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -515,6 +515,7 @@ M: Peter Maydell L: qemu-...@nongnu.org S: Maintained F: hw/*/versati

[Qemu-devel] [PATCH v2 09/17] MAINTAINERS: add missing PCI entries

Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index dd5e2c2b6b..bbe1191883 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -928,6 +928,8 @@ F: include/hw/pci/* F: hw/misc/pci-testdev.c F: hw/pci/* F: hw/pci-b

[Qemu-devel] [PATCH v2 06/17] MAINTAINERS: add missing Guest Agent entries

Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index aa185c1edd..f4e07173c8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1434,6 +1434,10 @@ QEMU Guest Agent M: Michael Roth S: Maintained F: qga/ +F: qem

[Qemu-devel] [PATCH v2 03/17] MAINTAINERS: add missing STM32 entry

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Alistair Francis --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5b7891addc..8c75ce477a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -552,6 +552,7 @@ F: hw/char/stm32

[Qemu-devel] [PATCH v2 04/17] MAINTAINERS: add missing entry for vhost

Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8c75ce477a..223591c231 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1029,6 +1029,7 @@ vhost M: Michael S. Tsirkin S: Supported F: hw/*/*vhost* +F: docs/i

[Qemu-devel] [PATCH v2 00/17] add missing entries in MAINTAINERS

Hi, I tried to have a more helpful ./scripts/get_maintainer.pl output, filling missing entries in MAINTAINERS. Regards, Phil. v2: - add R-b & A-b - clean ARM entries (Thomas Huth) - moved files: comment since which commit (Eric Blake) - drop inconsistent patches (default-configs.mak related to

[Qemu-devel] [PATCH v2 01/17] MAINTAINERS: add missing ARM entries

Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index ccee28b12d..b363e1b9c9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -380,6 +380,7 @@ M: Peter Maydell L: qemu-...@nongnu.org S: Main

Re: [Qemu-devel] [PATCH 3/6] tests: Enable the drive_del test also on s390x

On 08/17/2017 02:25 AM, Thomas Huth wrote: > By using the "virtio-xxx" device name aliases instead of the > "virtio-xxx-pci" names, we can use this test on s390x, too, > to check that adding and deleting also works fine with the > virtio-ccw bus. > > Signed-off-by: Thomas Huth > --- > tests/Ma

Re: [Qemu-devel] [Qemu-block] Persistent bitmaps for non-qcow2 formats

On 08/30/2017 09:45 AM, Daniel P. Berrange wrote: > On Wed, Aug 30, 2017 at 02:36:11PM +0100, Stefan Hajnoczi wrote: >> On Tue, Aug 22, 2017 at 03:07:04PM -0400, John Snow wrote: >>> (3) Add either a new flag that turns qcow2's backing file into a full >>> R/W backing file, or add a new extension

Re: [Qemu-devel] Persistent bitmaps for non-qcow2 formats

On 08/30/2017 08:58 AM, Yaniv Lavi (Dary) wrote: > > > We had no reason to switch to anything else so far and I'm sure this > option was not available when we started supporting raw format. > > Yeah, they don't exist yet...! I've looped you in to see if the proposal being discussed would a

Re: [Qemu-devel] [PATCH 02/47] MAINTAINERS: add missing ARM entries

On 07/28/2017 03:55 AM, Thomas Huth wrote: On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 972118e70b..795f89f709 100644 --- a/MAINTAINERS +++

[Qemu-devel] [PATCH v6 17/18] dirty-bitmap: Switch bdrv_set_dirty() to bytes

Both callers already had bytes available, but were scaling to sectors. Move the scaling to internal code. In the case of bdrv_aligned_pwritev(), we are now passing the exact offset rather than a rounded sector-aligned value, but that's okay as long as dirty bitmap widens start/bytes to granularit

  1   2   3   4   5   >