Re: [Qemu-devel] [RFC 0/6] monitor: allow per-monitor thread

2017-08-21 Thread Peter Xu
On Tue, Aug 22, 2017 at 02:33:48PM +0800, Fam Zheng wrote: > On Tue, 08/22 13:59, Peter Xu wrote: > > On Tue, Aug 22, 2017 at 12:15:19PM +0800, Fam Zheng wrote: > > > On Tue, 08/22 10:56, Peter Xu wrote: > > > > I haven't really encountered (c), but I think it's the migrate_cancel > > > > command t

[Qemu-devel] [PATCH] qobject: Explain how QNum works, and why

2017-08-21 Thread Markus Armbruster
Suggested-by: Max Reitz Signed-off-by: Markus Armbruster --- include/qapi/qmp/qnum.h | 21 + 1 file changed, 21 insertions(+) diff --git a/include/qapi/qmp/qnum.h b/include/qapi/qmp/qnum.h index 09d745c..9182129 100644 --- a/include/qapi/qmp/qnum.h +++ b/include/qapi/qmp/qnu

Re: [Qemu-devel] [RFC 0/6] monitor: allow per-monitor thread

2017-08-21 Thread Fam Zheng
On Tue, 08/22 13:59, Peter Xu wrote: > On Tue, Aug 22, 2017 at 12:15:19PM +0800, Fam Zheng wrote: > > On Tue, 08/22 10:56, Peter Xu wrote: > > > I haven't really encountered (c), but I think it's the migrate_cancel > > > command that matters, which should not need BQL as well. > > > > There is bdr

Re: [Qemu-devel] [RFC 0/6] monitor: allow per-monitor thread

2017-08-21 Thread Peter Xu
On Mon, Aug 21, 2017 at 09:51:47PM -0700, no-re...@patchew.org wrote: [...] > TESTtests/qapi-schema/doc-duplicated-return.out > TESTtests/qapi-schema/doc-duplicated-since.out > TESTtests/qapi-schema/doc-empty-arg.out > TESTtests/qapi-schema/doc-empty-section.out > TEST

Re: [Qemu-devel] [Qemu devel v6 PATCH 2/5] msf2: Microsemi Smartfusion2 System Register block.

2017-08-21 Thread sundeep subbaraya
Hi Alistair, I will remove the abort and send next iteration. Thanks, Sundeep On Tue, Aug 1, 2017 at 11:38 AM, sundeep subbaraya wrote: > Hi Philippe, > > Ping again :) > > Thanks, > Sundeep > > On Fri, Jul 21, 2017 at 2:50 PM, sundeep subbaraya > wrote: > >> Hi, >> >> Ping >> >> On Thu, Jul

Re: [Qemu-devel] [RFC 0/6] monitor: allow per-monitor thread

2017-08-21 Thread Peter Xu
On Tue, Aug 22, 2017 at 12:15:19PM +0800, Fam Zheng wrote: > On Tue, 08/22 10:56, Peter Xu wrote: > > I haven't really encountered (c), but I think it's the migrate_cancel > > command that matters, which should not need BQL as well. > > There is bdrv_invalidate_cache_all() in migrate_cancel which

Re: [Qemu-devel] Fwd: QEMU-KVM Source Code Installation.

2017-08-21 Thread Fam Zheng
On Tue, 08/22 10:39, Tushar Bhardwaj wrote: > Respected Sir, > > I studided many articles for QEMU-KVM source code installation which are > confusing. Please guide me how to install QEMU-KVM with source code on > UBUNTU linux distribution. Please don't repeat what has already been answered: http

Re: [Qemu-devel] [PATCH for-2.10] boot-serial-test: prefer tcg accelerator

2017-08-21 Thread Thomas Huth
On 22.08.2017 03:09, David Gibson wrote: > On Wed, Aug 16, 2017 at 12:18:07PM +0100, Peter Maydell wrote: >> On 16 August 2017 at 11:51, Paolo Bonzini wrote: >>> On 16/08/2017 10:26, Cornelia Huck wrote: Prefer to use the tcg accelarator if it is available: This is our only real smoke te

[Qemu-devel] Fwd: QEMU-KVM Source Code Installation.

2017-08-21 Thread Tushar Bhardwaj
Respected Sir, I studided many articles for QEMU-KVM source code installation which are confusing. Please guide me how to install QEMU-KVM with source code on UBUNTU linux distribution. -- "Purity and Simplicity Reflects the Inner Beauty of soul" *Thank you With Regards:Tushar Sharma,* *I

Re: [Qemu-devel] [PATCH] qcow2: allocate cluster_cache/cluster_data on demand

2017-08-21 Thread Alexey Kardashevskiy
On 19/08/17 12:46, Alexey Kardashevskiy wrote: > On 19/08/17 01:18, Eric Blake wrote: >> On 08/18/2017 08:31 AM, Stefan Hajnoczi wrote: >>> Most qcow2 files are uncompressed so it is wasteful to allocate (32 + 1) >>> * cluster_size + 512 bytes upfront. Allocate s->cluster_cache and >>> s->cluster_

Re: [Qemu-devel] [RFC 0/6] monitor: allow per-monitor thread

2017-08-21 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 1503301464-27886-1-git-send-email-pet...@redhat.com Subject: [Qemu-devel] [RFC 0/6] monitor: allow pe

[Qemu-devel] [PATCH v3 09/10] MAINTAINERS: Add tests/vm entry

2017-08-21 Thread Fam Zheng
Signed-off-by: Fam Zheng --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index ccee28b12d..0ed607d003 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1881,6 +1881,7 @@ S: Maintained F: .travis.yml F: .shippable.yml F: tests/docker/ +F: tests/vm/ W:

[Qemu-devel] [PATCH v3 05/10] tests: Add FreeBSD image

2017-08-21 Thread Fam Zheng
The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng --- tests/vm/freebsd | 45 + 1 file changed, 45 insertions(+) create mode 100755 tests/vm/freebsd diff --git a/tests/vm/freebsd b/tests/vm/f

[Qemu-devel] [PATCH v3 08/10] Makefile: Add rules to run vm tests

2017-08-21 Thread Fam Zheng
Signed-off-by: Fam Zheng --- Makefile | 2 ++ configure | 2 +- tests/vm/Makefile.include | 40 3 files changed, 43 insertions(+), 1 deletion(-) create mode 100644 tests/vm/Makefile.include diff --git a/Makefile b/Makef

[Qemu-devel] [PATCH v3 07/10] tests: Add OpenBSD image

2017-08-21 Thread Fam Zheng
The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng --- tests/vm/openbsd | 46 ++ 1 file changed, 46 insertions(+) create mode 100755 tests/vm/openbsd diff --git a/tests/vm/openbsd b/tests/vm/

[Qemu-devel] [PATCH v3 10/10] tests: Add README for vm tests

2017-08-21 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/vm/README | 63 + 1 file changed, 63 insertions(+) create mode 100644 tests/vm/README diff --git a/tests/vm/README b/tests/vm/README new file mode 100644 index 00..a18b285507 --- /dev/null +++ b/t

[Qemu-devel] [PATCH v3 06/10] tests: Add NetBSD image

2017-08-21 Thread Fam Zheng
The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng Reviewed-by: Kamil Rytarowski --- tests/vm/netbsd | 45 + 1 file changed, 45 insertions(+) create mode 100755 tests/vm/netbsd diff --git a/

[Qemu-devel] [PATCH v3 04/10] tests: Add ubuntu.i386 image

2017-08-21 Thread Fam Zheng
This adds a 32bit guest. The official LTS cloud image is downloaded and initialized with cloud-init. Signed-off-by: Fam Zheng --- tests/vm/ubuntu.i386 | 88 1 file changed, 88 insertions(+) create mode 100755 tests/vm/ubuntu.i386 diff --git

[Qemu-devel] [PATCH v3 02/10] qemu.py: Add "wait()" method

2017-08-21 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Stefan Hajnoczi --- scripts/qemu.py | 7 +++ 1 file changed, 7 insertions(+) diff --git a/scripts/qemu.py b/scripts/qemu.py index 880e3e8219..153f2d1564 100644 --- a/scripts/qemu.py +++ b/scripts/qemu.py @@ -143,6 +143,13 @@ class QEMUMachine(object):

[Qemu-devel] [PATCH v3 03/10] tests: Add vm test lib

2017-08-21 Thread Fam Zheng
This is the common code to implement a "VM test" to 1) Download and initialize a pre-defined VM that has necessary dependencies to build QEMU and SSH access. 2) Archive $SRC_PATH to a .tar file. 3) Boot the VM, and pass the source tar file to the guest. 4) SSH into the VM, untar the s

[Qemu-devel] [PATCH v3 00/10] tests: Add VM based build tests (for non-x86_64 and/or non-Linux)

2017-08-21 Thread Fam Zheng
v3: Drop RFC. Add Stefan's and Kamil's reviewed-bys. Use optparse. [Stefan] Drop the VGA patch. [Paolo, Stefan] Improve exit/exit code/doc. [Stefan] Drop unused line from basevm.py. [Stefan] Drop "--target-list" form Makefile. More intelligent '-j'. Add README. [Stef

[Qemu-devel] [PATCH v3 01/10] gitignore: Ignore vm test images

2017-08-21 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Stefan Hajnoczi --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index cf65316863..693e2f3009 100644 --- a/.gitignore +++ b/.gitignore @@ -52,6 +52,8 @@ /vscclient /vhost-user-scsi /fsdev/virtfs-proxy-helper +/t

[Qemu-devel] [PULL 6/7] hw/ppc/spapr_rtc: Mark the RTC device with user_creatable = false

2017-08-21 Thread David Gibson
From: Thomas Huth QEMU currently aborts unexpectedly when a user tries to do something like this: $ qemu-system-ppc64 -nographic -S -nodefaults -monitor stdio QEMU 2.9.92 monitor - type 'help' for more information (qemu) device_add spapr-rtc,id=spapr-rtc (qemu) device_del spapr-rtc ** ERROR:qemu

[Qemu-devel] [PULL 5/7] hw/ppc/spapr: Fix segfault when instantiating a 'pc-dimm' without 'memdev'

2017-08-21 Thread David Gibson
From: Thomas Huth QEMU currently crashes when trying to use a 'pc-dimm' on the pseries machine without specifying its 'memdev' property. This happens because pc_dimm_get_memory_region() does not check whether the 'memdev' property has properly been set by the user. Looking closer at this function

[Qemu-devel] [PULL 7/7] hw/ppc/spapr_iommu: Fix crash when removing the "spapr-tce-table" device

2017-08-21 Thread David Gibson
From: Thomas Huth QEMU currently aborts unexpectedly when the user tries to add and remove a "spapr-tce-table" device: $ qemu-system-ppc64 -nographic -S -nodefaults -monitor stdio QEMU 2.9.92 monitor - type 'help' for more information (qemu) device_add spapr-tce-table,id=x (qemu) device_del x **

[Qemu-devel] [PULL 4/7] spapr: Allow configure-connector to be called multiple times

2017-08-21 Thread David Gibson
From: Bharata B Rao In case of in-kernel memory hot unplug, when the guest is not able to remove all the LMBs that are requested for removal, it will add back any LMBs that have been successfully removed. The DR Connectors of these LMBs wouldn't have been unconfigured and hence the addition of th

Re: [Qemu-devel] Any release-critical issues for 2.10 ?

2017-08-21 Thread David Gibson
On Mon, Aug 21, 2017 at 11:51:00AM +0100, Peter Maydell wrote: > Last call -- are there any release critical issues for 2.10? > If not then I'll tag the current rc3 as the final release tomorrow, > so please reply here to let me know if there's anything we should > be considering as needing an rc4.

[Qemu-devel] [PULL 2/7] target/ppc: 'PVR != host PVR' in KVM_SET_SREGS workaround

2017-08-21 Thread David Gibson
From: Daniel Henrique Barboza Commit d5fc133eed ("ppc: Rework CPU compatibility testing across migration") changed the way cpu_post_load behaves with the PVR setting, causing an unexpected bug in KVM-HV migrations between hosts that are compatible (POWER8 and POWER8E, for example). Even with pvr_

[Qemu-devel] [PULL 0/7] ppc-for-2.10 queue 20170822

2017-08-21 Thread David Gibson
The following changes since commit 1f296733876434118fd766cfef5eb6f29ecab6a8: Update version for v2.10.0-rc3 release (2017-08-15 18:53:31 +0100) are available in the git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-2.10-20170822 for you to fetch changes up to d3234e2851f1630

[Qemu-devel] [PULL 3/7] ppc: fix ppc_set_compat() with KVM PR

2017-08-21 Thread David Gibson
From: Greg Kurz When running in KVM PR mode, kvmppc_set_compat() always fail because the current PR implementation doesn't handle KVM_REG_PPC_ARCH_COMPAT. Now that the machine code inconditionally calls ppc_set_compat_all() at reset time to restore the compat mode default value (commit 66d5c492dd

[Qemu-devel] [PULL 1/7] boot-serial-test: prefer tcg accelerator

2017-08-21 Thread David Gibson
From: Cornelia Huck Prefer to use the tcg accelarator if it is available: This is our only real smoke test for tcg, and fast enough to use it for that. Fixes: 480bc11e6 ("boot-serial-test: fallback to kvm accelerator") Reported-by: Richard Henderson Signed-off-by: Cornelia Huck Signed-off-by:

Re: [Qemu-devel] [PATCH] audio: intel-hda: do not use old_mmio accesses

2017-08-21 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20170821211320.7026-1-mtpa...@gmail.com Subject: [Qemu-devel] [PATCH] audio: intel-hda: do not use old_mmio accesses === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 tota

Re: [Qemu-devel] [RFC 0/6] monitor: allow per-monitor thread

2017-08-21 Thread Fam Zheng
On Tue, 08/22 10:56, Peter Xu wrote: > I haven't really encountered (c), but I think it's the migrate_cancel > command that matters, which should not need BQL as well. There is bdrv_invalidate_cache_all() in migrate_cancel which clearly isn't safe. Is that if block unreachable in this case? If so

Re: [Qemu-devel] [Qemu-arm] [PATCH 4/8] boards.h: Define new flag ignore_memory_transaction_failures

2017-08-21 Thread Philippe Mathieu-Daudé
Hi Peter, On 08/17/2017 07:25 AM, Peter Maydell wrote: On 5 August 2017 at 11:13, Peter Maydell wrote: On 4 August 2017 at 20:23, Richard Henderson wrote: On 08/04/2017 11:09 AM, Philippe Mathieu-Daudé wrote: Since create_unimplemented_device() register overlapped with low priority, why not

Re: [Qemu-devel] [PATCH v3 2/5] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2017-08-21 Thread David Gibson
On Mon, Aug 21, 2017 at 06:05:34PM +0530, Aravinda Prasad wrote: > > > On Thursday 17 August 2017 07:09 AM, David Gibson wrote: > > What's with the extra spaces in the subject line? > > I don't see any. Can you pls point out? I see "ibm, nmi-register" and "ibm, nmi-interlock" > > > > > On We

Re: [Qemu-devel] [RFC PATCH 12/12] ppc: Add aCube Sam460ex board

2017-08-21 Thread David Gibson
On Fri, Aug 18, 2017 at 02:46:42PM +0200, BALATON Zoltan wrote: > On Fri, 18 Aug 2017, David Gibson wrote: > > On Sun, Aug 13, 2017 at 07:04:38PM +0200, BALATON Zoltan wrote: > > > Add emulation of aCube Sam460ex board based on AMCC 460EX embedded SoC. > > > This is not a full implementation yet wi

Re: [Qemu-devel] [PATCH v3 1/5] ppc: spapr: Register and handle HCALL to receive updated RTAS region

2017-08-21 Thread David Gibson
On Mon, Aug 21, 2017 at 03:12:49PM +0530, Aravinda Prasad wrote: > > > On Thursday 17 August 2017 07:04 AM, David Gibson wrote: > > On Wed, Aug 16, 2017 at 02:42:13PM +0530, Aravinda Prasad wrote: > >> Receive updates from SLOF about the updated rtas-base. > >> A separate patch for SLOF [1] adds

[Qemu-devel] [PATCH v4 1/2] hw/acpi-build: Fix SRAT memory building when there is no memory in node0

2017-08-21 Thread Dou Liyang
Currently, Using the fisrt node without memory on the machine makes QEMU unhappy. With this example command line: ... \ -m 1024M,slots=4,maxmem=32G \ -numa node,nodeid=0 \ -numa node,mem=1024M,nodeid=1 \ -numa node,nodeid=2 \ -numa node,nodeid=3 \ Guest reports "No NUMA configuration fo

[Qemu-devel] [PATCH v4 0/2] hw/acpi-build: Fix ACPI SRAT Memory Affinity building

2017-08-21 Thread Dou Liyang
V3 --> v4: -add a new testcase. This patchset fixs an ACPI building bug which caused by no RAM in the first NUAM node. and also add a new testcase for the bug. Dou Liyang (2): hw/acpi-build: Fix SRAT memory building when there is no memory in node0 ACPI/unit-test: Add a new testcase for

[Qemu-devel] [PATCH v4 2/2] ACPI/unit-test: Add a new testcase for RAM allocation in numa node

2017-08-21 Thread Dou Liyang
As QEMU supports the memory-less node, it is possible that there is no RAM in the first numa node(also be called as node0). eg: ... \ -m 128,slots=3,maxmem=1G \ -numa node -numa node,mem=128M \ But, this makes it hard for QEMU to build a known-to-work ACPI SRAT table. Only fixing it is not e

Re: [Qemu-devel] [RFC 0/6] monitor: allow per-monitor thread

2017-08-21 Thread Peter Xu
On Tue, Aug 22, 2017 at 10:15:56AM +0800, Fam Zheng wrote: > On Mon, 08/21 18:28, Dr. David Alan Gilbert wrote: > > > It's not much more than asserting qemu_mutex_iothread_locked(), the > > > problem is > > > the new monitor thread breaks certain assumptions that was true. > > > > > > What is int

Re: [Qemu-devel] [PATCH v6 5/7] qemu.py: use os.path.null instead of /dev/null

2017-08-21 Thread Philippe Mathieu-Daudé
On 07/31/2017 05:51 AM, Amador Pahim wrote: For increased portability, let's use os.path.devnull. Signed-off-by: Amador Pahim Reviewed-by: Philippe Mathieu-Daudé --- scripts/qemu.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/qemu.py b/scripts/qemu.py

Re: [Qemu-devel] [RFC 0/6] monitor: allow per-monitor thread

2017-08-21 Thread Fam Zheng
On Mon, 08/21 18:28, Dr. David Alan Gilbert wrote: > > It's not much more than asserting qemu_mutex_iothread_locked(), the problem > > is > > the new monitor thread breaks certain assumptions that was true. > > > > What is interesting in this is that block layer's nested aio_poll() now not > > o

Re: [Qemu-devel] [PATCH] spapr: Add ibm, processor-storage-keys property to CPU DT node

2017-08-21 Thread David Gibson
On Mon, Aug 21, 2017 at 05:00:36PM -0300, Thiago Jung Bauermann wrote: > LoPAPR says: > > “ibm,processor-storage-keys” > > property name indicating the number of virtual storage keys supported > by the processor described by this node. > > prop-encoded-array: Consists of two cell

Re: [Qemu-devel] [PATCH for-2.10] boot-serial-test: prefer tcg accelerator

2017-08-21 Thread David Gibson
On Wed, Aug 16, 2017 at 12:18:07PM +0100, Peter Maydell wrote: > On 16 August 2017 at 11:51, Paolo Bonzini wrote: > > On 16/08/2017 10:26, Cornelia Huck wrote: > >> Prefer to use the tcg accelarator if it is available: This is our only > >> real smoke test for tcg, and fast enough to use it for th

Re: [Qemu-devel] [PATCH] filter-mirror: segfault when specifying non existent device

2017-08-21 Thread Zhang Chen
On 08/21/2017 11:50 PM, Eduardo Otubo wrote: When using filter-mirror like the example below where the interface 'ndev0' does not exist on the host, QEMU crashes into segmentation fault. $ qemu-system-x86_64 -S -machine pc -netdev user,id=ndev0 -object filter-mirror,id=test-object,netdev=nd

[Qemu-devel] 答复: Re: 答复: Re: [PATCH] vhost: don't set vring call fd to -1 invhost_virtqueue_start for vhost-user

2017-08-21 Thread lu.zhipeng
>On 2017年08月21日 11:28, lu.zhip...@zte.com.cn wrote: >> if (!vdev->use_guest_notifier_mask) {>>> >/* TODO: check and >> handle errors. */>>> > >> -- set right callfd>> }> if >> (k->query_guest_notifie

Re: [Qemu-devel] [PATCH v7 03/16] migration: split common postcopy out of ram postcopy

2017-08-21 Thread John Snow
On 07/11/2017 09:38 AM, Vladimir Sementsov-Ogievskiy wrote: > 11.07.2017 16:06, Dr. David Alan Gilbert wrote: >> * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: >>> Split common postcopy staff from ram postcopy staff. >>> >>> Signed-off-by: Vladimir Sementsov-Ogievskiy >> I'm OK

Re: [Qemu-devel] [PATCH v7 0/4] Add shrink image for qcow2

2017-08-21 Thread John Snow
On 08/17/2017 05:15 AM, Pavel Butsykin wrote: > This patch add shrinking of the image file for qcow2. As a result, this allows > us to reduce the virtual image size and free up space on the disk without > copying the image. Image can be fragmented and shrink is done by punching > holes > in the

Re: [Qemu-devel] [PATCH 2/2 v3] xenfb: Add [feature|request]-raw-pointer

2017-08-21 Thread Stefano Stabellini
On Wed, 26 Jul 2017, Owen Smith wrote: > Writes "feature-raw-pointer" during init to indicate the backend > can pass raw unscaled values for absolute axes to the frontend. > Frontends set "request-raw-pointer" to indicate the backend should > not attempt to scale absolute values to console size. >

Re: [Qemu-devel] [PATCH 1/2 v3] xenfb: Use Input Handlers directly

2017-08-21 Thread Stefano Stabellini
Anthony, The code looks good. I tested this patch with Linux guests and seems to work OK, can you also confirm? One comment below. On Wed, 26 Jul 2017, Owen Smith wrote: > Avoid the unneccessary calls through the input-legacy.c file by > using the qemu_input_handler_*() calls directly. This did

Re: [Qemu-devel] [PATCH] xen: Emit RTC_CHANGE upon TIMEOFFSET ioreq

2017-08-21 Thread Stefano Stabellini
On Mon, 21 Aug 2017, Ross Lagerwall wrote: > When the guest writes to the RTC, Xen emulates it and broadcasts a > TIMEOFFSET ioreq. Emit an RTC_CHANGE QMP message when this happens > rather than ignoring it so that something useful can be done with the > information. Are there any handlers of the

Re: [Qemu-devel] [PATCH v6 00/10] qemu.py: Pylint/style fixes

2017-08-21 Thread John Snow
On 08/18/2017 10:26 AM, Lukáš Doktor wrote: > Hello guys, > > I'm reading the available python modules to exercise qemu and while reading > them > I fixed some issues that caught my attention. It usually starts with a simple > pylint/docstring fixes and slowly graduates to more controversial on

Re: [Qemu-devel] [RFC v4 08/13] ide: enumerate_slots implementation

2017-08-21 Thread John Snow
On 08/18/2017 12:57 PM, Eduardo Habkost wrote: > On Wed, Aug 16, 2017 at 05:46:18PM -0400, John Snow wrote: >> >> >> On 08/14/2017 05:57 PM, Eduardo Habkost wrote: >>> Example output when using "-machine q35": >>> >>> { >>> "available": true, >>> "count": 1, >>> "device-types": [ >>

Re: [Qemu-devel] [PATCH 09/15] hw/ide: Emulate SiI3112 SATA controller

2017-08-21 Thread John Snow
On 08/20/2017 01:23 PM, BALATON Zoltan wrote: > This is a common generic PCI SATA conroller that is also used in PCs > but more importantly guests running on the Sam460ex board prefer this > card and have a driver for it (unlike for other SATA controllers > already emulated). > Oh, interesting.

[Qemu-devel] [PATCH] audio: intel-hda: do not use old_mmio accesses

2017-08-21 Thread Matt Parker
intel-hda is still using the old_mmio accessors for io. This updates the device to use .read and .write accessors instead. --- hw/audio/intel-hda.c | 56 +--- 1 file changed, 9 insertions(+), 47 deletions(-) diff --git a/hw/audio/intel-hda.c b/hw/au

[Qemu-devel] [PATCH 0/2] ui/cocoa.m: enable guest to see control-alt key combinations

2017-08-21 Thread John Arbuckle
Currently if the user needs to send a control-alt key combination, he or she was either out of luck or had to rely on the monitor's sendkey command to do so. With this patch the user can now directly send control-alt key combinations. This is great for Windows guest that may need the control-al

[Qemu-devel] [PATCH 2/2] ui/cocoa.m: send ctrl-alt key combinations to guest if not used by QEMU

2017-08-21 Thread John Arbuckle
Send control-alt key combinations to the guest if not used by the user interface. Signed-off-by: John Arbuckle --- ui/cocoa.m | 8 1 file changed, 8 insertions(+) diff --git a/ui/cocoa.m b/ui/cocoa.m index d3e7907103..6920ea38aa 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -634,6 +634,

[Qemu-devel] [PATCH 1/2] ui/cocoa.m: move ungrab to ctrl-alt-g

2017-08-21 Thread John Arbuckle
Currently the cocoa user interface relys on the user pushing control-alt to ungrab the mouse. This is patch changes the key combination to control-alt-g to be in line with the GTK user interface. Signed-off-by: John Arbuckle --- ui/cocoa.m | 15 --- 1 file changed, 8 insertions(+)

Re: [Qemu-devel] [PATCH v14 3/5] virtio-balloon: VIRTIO_BALLOON_F_SG

2017-08-21 Thread Michael S. Tsirkin
On Fri, Aug 18, 2017 at 03:39:27PM +0800, Wei Wang wrote: > On 08/18/2017 10:22 AM, Michael S. Tsirkin wrote: > > +static void send_balloon_page_sg(struct virtio_balloon *vb, > > +struct virtqueue *vq, > > +void *addr, > > +

Re: [Qemu-devel] [PATCH V2 2/3] xen-pt: bind/unbind interrupt remapping format MSI

2017-08-21 Thread Stefano Stabellini
On Tue, 15 Aug 2017, Lan Tianyu wrote: > Hi Anthony: > > On 2017年08月12日 02:04, Anthony PERARD wrote: > > On Wed, Aug 09, 2017 at 04:51:21PM -0400, Lan Tianyu wrote: > >> From: Chao Gao > >> > >> If a vIOMMU is exposed to guest, guest will configure the msi to remapping > >> format. The original c

Re: [Qemu-devel] virtio: network: lost tcp/ip packets

2017-08-21 Thread Stefan Priebe - Profihost AG
Hello, does nobody have an idea? Greets, Stefam Am 18.08.2017 um 16:40 schrieb Stefan Priebe - Profihost AG: > Hello, > > i've a problem with two VMs running on the SAME host machine using qemu > 2.7.1 or 2.9.0 and vhost_net + virtio. > > Sometimes TCP packets going from machine a to machine b

[Qemu-devel] [PATCH] spapr: Add ibm, processor-storage-keys property to CPU DT node

2017-08-21 Thread Thiago Jung Bauermann
LoPAPR says: “ibm,processor-storage-keys” property name indicating the number of virtual storage keys supported by the processor described by this node. prop-encoded-array: Consists of two cells encoded as with encode-int. The first cell represents the number of virtual stora

Re: [Qemu-devel] [Qemu-block] [PATCH] nbd-client: fix hang after server closes connection

2017-08-21 Thread Eric Blake
On 08/21/2017 11:27 AM, Stefan Hajnoczi wrote: > On Mon, Aug 21, 2017 at 5:15 PM, Stefan Hajnoczi wrote: >> (qemu) quit >> ...hang... > > By the way, the same issue is present in QEMU 2.9. This is not a 2.10 > regression. Most likely, though, it IS a regression introduced in 2.9 and not pre

Re: [Qemu-devel] xhci: move command stop and command abort flag check to the case when the crcr_low register is set

2017-08-21 Thread Jaroslav Jindrák
Hi, that was an error on my part, I was debugging the non-working command ring abort/stop functionality and as the xhci driver implementation I was working on used crcr_low and crcr_high as two separate registers it did not hit me it was actually my way of accessing them that caused the abort/stop

Re: [Qemu-devel] [RFC 0/6] monitor: allow per-monitor thread

2017-08-21 Thread Dr. David Alan Gilbert
* Fam Zheng (f...@redhat.com) wrote: > On Mon, 08/21 16:36, Dr. David Alan Gilbert wrote: > > * Fam Zheng (f...@redhat.com) wrote: > > > On Mon, 08/21 18:05, Peter Xu wrote: > > > > On Mon, Aug 21, 2017 at 04:58:51PM +0800, Fam Zheng wrote: > > > > > On Mon, 08/21 15:44, Peter Xu wrote: > > > > > >

Re: [Qemu-devel] [PATCH v4 0/4] scsi-block: Support werror/rerror

2017-08-21 Thread Paolo Bonzini
- Original Message - > From: "Fam Zheng" > To: qemu-devel@nongnu.org > Cc: "Paolo Bonzini" > Sent: Monday, August 21, 2017 4:10:04 PM > Subject: [PATCH v4 0/4] scsi-block: Support werror/rerror > > v4: Handle more sense keys/ascqs. [Paolo] > Add scsi_sense_buf_to_errno to util/scsi.c

Re: [Qemu-devel] [RFC 0/6] monitor: allow per-monitor thread

2017-08-21 Thread Fam Zheng
On Mon, 08/21 16:36, Dr. David Alan Gilbert wrote: > * Fam Zheng (f...@redhat.com) wrote: > > On Mon, 08/21 18:05, Peter Xu wrote: > > > On Mon, Aug 21, 2017 at 04:58:51PM +0800, Fam Zheng wrote: > > > > On Mon, 08/21 15:44, Peter Xu wrote: > > > > > This is an extended work for migration postcopy

Re: [Qemu-devel] [Qemu-block] [PATCH] nbd-client: fix hang after server closes connection

2017-08-21 Thread Stefan Hajnoczi
On Mon, Aug 21, 2017 at 5:15 PM, Stefan Hajnoczi wrote: > (qemu) quit > ...hang... By the way, the same issue is present in QEMU 2.9. This is not a 2.10 regression. Stefan

Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions

2017-08-21 Thread Halil Pasic
On 08/21/2017 04:58 PM, Pierre Morel wrote: > On 21/08/2017 11:16, Cornelia Huck wrote: >> If we do not provide zpci, pci reconfiguration via sclp is not available >> either. Don't indicate it in the sclp facilities and return an invalid >> command if the guest tries to issue pci configure/deconf

Re: [Qemu-devel] [PATCH v4 2/5] qapi: Add qobject_is_equal()

2017-08-21 Thread Max Reitz
On 2017-08-14 11:07, Markus Armbruster wrote: > Max Reitz writes: > >> On 2017-07-11 13:33, Markus Armbruster wrote: >>> Max Reitz writes: >>> First of all, OK, you don't want QNum(42.0) to equal QNum(42) at all (at least not right now and in the foreseeable future). You're the ma

[Qemu-devel] [PATCH] nbd-client: fix hang after server closes connection

2017-08-21 Thread Stefan Hajnoczi
Commit 72b6ffc76653214b69a94a7b1643ff80df134486 ("nbd-client: Fix regression when server sends garbage") improved NBD client behavior when the connection enters a broken state. The following still does not behave as expected: $ qemu-nbd -p 1234 -x drive0 -f qcow2 test.qcow2 $ qemu-system-x86_

Re: [Qemu-devel] AVMF & OVMF blobs in QEMU tree???

2017-08-21 Thread Laszlo Ersek
On 08/21/17 16:03, Alex Bennée wrote: > > Gerd Hoffmann writes: > >> On Mon, 2017-08-07 at 18:51 +0200, Laszlo Ersek wrote: >>> On 08/07/17 16:40, Peter Maydell wrote: On 7 August 2017 at 15:31, Igor Mammedov wrote: > As I recall there were issues with FAT driver licensing in edk2

Re: [Qemu-devel] [PATCH v4 02/10] kvm: remove hard dependency on pci

2017-08-21 Thread Pierre Morel
On 21/08/2017 11:16, Cornelia Huck wrote: The msi routing code in kvm calls some pci functions: provide some stubs to enable builds without pci. Also, to make this more obvious, guard them via a pci_available boolean (which also can be reused in other places). Fixes: e1d4fb2de ("kvm-irqchip: x8

[Qemu-devel] [PATCH] filter-mirror: segfault when specifying non existent device

2017-08-21 Thread Eduardo Otubo
When using filter-mirror like the example below where the interface 'ndev0' does not exist on the host, QEMU crashes into segmentation fault. $ qemu-system-x86_64 -S -machine pc -netdev user,id=ndev0 -object filter-mirror,id=test-object,netdev=ndev0 This happens because the function filter_mirr

[Qemu-devel] [Bug 1711602] Re: --copy-storage-all failing with qemu 2.10

2017-08-21 Thread Dr. David Alan Gilbert
oh yeh you want to tell gdb to ignore SIGUSR1, something like: handle SIGUSR1 nostop noprint pass -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1711602 Title: --copy-storage-all failing with qem

Re: [Qemu-devel] [PATCH v2 3/6] block: require job-id when device is a node name

2017-08-21 Thread Manos Pitsidianakis
On Mon, Aug 21, 2017 at 05:05:30PM +0200, Alberto Garcia wrote: On Wed 09 Aug 2017 04:02:53 PM CEST, Manos Pitsidianakis wrote: @@ -622,20 +622,14 @@ void *block_job_create(const char *job_id, const BlockJobDriver *driver, return NULL; } -if (job_id == NULL && !(flags & BLOCK

Re: [Qemu-devel] [RFC 0/6] monitor: allow per-monitor thread

2017-08-21 Thread Dr. David Alan Gilbert
* Fam Zheng (f...@redhat.com) wrote: > On Mon, 08/21 18:05, Peter Xu wrote: > > On Mon, Aug 21, 2017 at 04:58:51PM +0800, Fam Zheng wrote: > > > On Mon, 08/21 15:44, Peter Xu wrote: > > > > This is an extended work for migration postcopy recovery. This series > > > > is tested with the following se

Re: [Qemu-devel] [PATCH v4 09/10] s390x/kvm: msi route fixup for non-pci

2017-08-21 Thread Halil Pasic
On 08/21/2017 05:17 PM, Thomas Huth wrote: > On 21.08.2017 17:10, Halil Pasic wrote: > [...] >> The situation is just complicated by the fact that there is code which >> relies on assert(true) asserting for correctness (e.g. virtio goes so far >> to make builds with normal asserts disabled fail).

Re: [Qemu-devel] [PATCH v2 3/6] block: require job-id when device is a node name

2017-08-21 Thread Alberto Garcia
On Wed 09 Aug 2017 04:02:53 PM CEST, Manos Pitsidianakis wrote: > @@ -622,20 +622,14 @@ void *block_job_create(const char *job_id, const > BlockJobDriver *driver, > return NULL; > } > > -if (job_id == NULL && !(flags & BLOCK_JOB_INTERNAL)) { > -job_id = bdrv_get_device_

Re: [Qemu-devel] [PATCH v4 09/10] s390x/kvm: msi route fixup for non-pci

2017-08-21 Thread Thomas Huth
On 21.08.2017 17:10, Halil Pasic wrote: [...] > The situation is just complicated by the fact that there is code which > relies on assert(true) asserting for correctness (e.g. virtio goes so far > to make builds with normal asserts disabled fail). Thus for me it's hard > to assume that the assertio

[Qemu-devel] [Bug 1711602] Re: --copy-storage-all failing with qemu 2.10

2017-08-21 Thread ChristianEhrhardt
As expected by David when I trace on process_incoming_migration_co which prints the "readable" error I see the error pop up on "qemu_loadvm_state" It appears as "Thread 4 "CPU 0/KVM" received signal SIGUSR1" and similar which is just the break down of the guest. Diving "into" qemu_loadvm_state

[Qemu-devel] [Bug 1711602] Re: --copy-storage-all failing with qemu 2.10

2017-08-21 Thread ChristianEhrhardt
After this I was trying to start closer to the issue, so I put a break on "process_incoming_migration_co" (to skip over much of the initial setup). Once that was hit I added "qemu_kvm_cpu_thread_fn" and "qemu_kvm_wait_io_event". Of course when I try that the other functions do not trigger. Maybe

[Qemu-devel] [Bug 1711602] Re: --copy-storage-all failing with qemu 2.10

2017-08-21 Thread ChristianEhrhardt
Since the qemu "lives" in that time I can try to debug what happens. With strace to sniff where things could be I see right before the end: 0.000203 recvmsg(27, {msg_name=NULL, msg_namelen=0, msg_iov=[{iov_base="", iov_len=32768}], msg_iovlen=1, msg_controllen=0, msg_flags=MSG_CMSG_CLOEXEC},

[Qemu-devel] [Bug 1711602] Re: --copy-storage-all failing with qemu 2.10

2017-08-21 Thread ChristianEhrhardt
Hi David, confirming the red-herring on the cpu feature - I had a build without runnign over the weekend so this was easy to test - and still the migration fails. I have about 7 seconds from kicking off the migration until the sync seems to pass its first phase and then qemu is exiting (at least

Re: [Qemu-devel] [PATCH v4 09/10] s390x/kvm: msi route fixup for non-pci

2017-08-21 Thread Halil Pasic
On 08/21/2017 02:13 PM, Cornelia Huck wrote: > On Mon, 21 Aug 2017 14:00:15 +0200 > Halil Pasic wrote: > >> On 08/21/2017 11:16 AM, Cornelia Huck wrote: >>> If we don't provide pci, we cannot have a pci device for which we >>> have to translate to adapter routes: just return -ENODEV. >>> >>> Si

Re: [Qemu-devel] [PATCH v2 0/3] s390x: diag-related things

2017-08-21 Thread Cornelia Huck
On Fri, 18 Aug 2017 13:48:41 +0200 Cornelia Huck wrote: > ...which are a fix in tcg for diag handling and diag288 watchdog changes. > > v1->v2: just reorder patches for less churn [Thomas] > > Cornelia Huck (2): > s390x/tcg: specification exception for unknown diag > s390x: wire up diag288

Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions

2017-08-21 Thread Pierre Morel
On 21/08/2017 11:16, Cornelia Huck wrote: If we do not provide zpci, pci reconfiguration via sclp is not available either. Don't indicate it in the sclp facilities and return an invalid command if the guest tries to issue pci configure/deconfigure. Reviewed-by: Thomas Huth Signed-off-by: Cornel

Re: [Qemu-devel] [PATCH v2 1/6] block: skip implicit nodes in snapshots, blockjobs

2017-08-21 Thread Alberto Garcia
On Tue 15 Aug 2017 03:50:12 PM CEST, Manos Pitsidianakis wrote: >>> +static inline BlockDriverState *child_bs(BlockDriverState *bs) >>> +{ >>> +BdrvChild *child = QLIST_FIRST(&bs->children); >>> +assert(child && !QLIST_NEXT(child, next)); >>> +return child->bs; >>> +} >> >>This aborts i

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

2017-08-21 Thread Markus Armbruster
David Michael writes: > This allows building with "./configure --python=python3", where > the python3 program is at least version 3.6. It preserves > compatibility with Python 2. The changes include: > > - Avoiding "print" usage > - Using bytes with files opened in binary mode > - Switchi

Re: [Qemu-devel] [PATCH v6 5/6] block: add throttle block filter driver

2017-08-21 Thread Alberto Garcia
On Mon 21 Aug 2017 11:31:49 AM CEST, Manos Pitsidianakis wrote: > block/throttle.c uses existing I/O throttle infrastructure inside a > block filter driver. I/O operations are intercepted in the filter's > read/write coroutines, and referred to block/throttle-groups.c > > The driver can be used wit

[Qemu-devel] [PATCH v4 4/4] scsi-block: Support rerror/werror

2017-08-21 Thread Fam Zheng
This makes the werror/rerror options available on the scsi-block device, to allow user specify error handling policy similar to scsi-hd. Signed-off-by: Fam Zheng --- hw/scsi/scsi-disk.c | 38 -- 1 file changed, 24 insertions(+), 14 deletions(-) diff --git a/h

[Qemu-devel] [PATCH v4 2/4] scsi: Improve scsi_sense_to_errno

2017-08-21 Thread Fam Zheng
Tweak the errno mapping to return more accurate/appropriate values. Signed-off-by: Fam Zheng --- util/scsi.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/util/scsi.c b/util/scsi.c index a6710799fc..472eb5bea5 100644 --- a/util/scsi.c +++ b/util/scsi.c @@

[Qemu-devel] [PATCH v4 3/4] scsi: Introduce scsi_sense_buf_to_errno

2017-08-21 Thread Fam Zheng
This recognizes the "fixed" and "descriptor" format sense data, extracts the sense key/asc/ascq fields then converts them to an errno. Signed-off-by: Fam Zheng --- include/scsi/scsi.h | 1 + util/scsi.c | 30 ++ 2 files changed, 31 insertions(+) diff --git a

[Qemu-devel] [PATCH v4 1/4] scsi: Refactor scsi sense interpreting code

2017-08-21 Thread Fam Zheng
So that it can be reused outside of iscsi.c. Also update MAINTAINERS to include the new files in SCSI section. Signed-off-by: Fam Zheng --- MAINTAINERS | 2 ++ block/iscsi.c | 45 - include/scsi/scsi.h | 19 +++ util/Mak

[Qemu-devel] [PATCH v4 0/4] scsi-block: Support werror/rerror

2017-08-21 Thread Fam Zheng
v4: Handle more sense keys/ascqs. [Paolo] Add scsi_sense_buf_to_errno to util/scsi.c. [Paolo] Shorten the comment notes on SCSI constants. v3: Enhance and reuse iscsi sense data translation. [Paolo] First refactor and enhance the code in iscsi for sense data translation, then modify error

Re: [Qemu-devel] [RFC 0/6] monitor: allow per-monitor thread

2017-08-21 Thread Dr. David Alan Gilbert
* Fam Zheng (f...@redhat.com) wrote: > On Mon, 08/21 11:17, Dr. David Alan Gilbert wrote: > > From previous discussions we've had, one suggestion was to have some > > type of 'safe' command; once issued in a thread, the monitor thread > > would only allow other lock-free commands to be issued; it s

Re: [Qemu-devel] [RFC 0/6] monitor: allow per-monitor thread

2017-08-21 Thread Fam Zheng
On Mon, 08/21 11:17, Dr. David Alan Gilbert wrote: > From previous discussions we've had, one suggestion was to have some > type of 'safe' command; once issued in a thread, the monitor thread > would only allow other lock-free commands to be issued; it stops any > accidents of them issuing unsafe c

Re: [Qemu-devel] AVMF & OVMF blobs in QEMU tree???

2017-08-21 Thread Alex Bennée
Gerd Hoffmann writes: > On Mon, 2017-08-07 at 18:51 +0200, Laszlo Ersek wrote: >> On 08/07/17 16:40, Peter Maydell wrote: >> > On 7 August 2017 at 15:31, Igor Mammedov >> > wrote: >> > > As I recall there were issues with FAT driver licensing in edk2, >> > > but I've heard there were some chang

[Qemu-devel] [PATCH] xen: Emit RTC_CHANGE upon TIMEOFFSET ioreq

2017-08-21 Thread Ross Lagerwall
When the guest writes to the RTC, Xen emulates it and broadcasts a TIMEOFFSET ioreq. Emit an RTC_CHANGE QMP message when this happens rather than ignoring it so that something useful can be done with the information. Signed-off-by: Ross Lagerwall --- hw/i386/xen/xen-hvm.c | 2 ++ 1 file changed,

  1   2   3   >