Re: [Qemu-devel] [Qemu-ppc] BookE MMU question

2017-08-19 Thread BALATON Zoltan
On Sun, 20 Aug 2017, KONRAD Frederic wrote: Hi, I think you need to go more in detail in what this map_region function does.. This function is defined in AROS/arch/ppc-sam440/kernel/mmu.c:95 at the link below. I think it basically generates tlbwe instructions to set up a TLB entry to map the

Re: [Qemu-devel] BookE MMU question

2017-08-19 Thread KONRAD Frederic
Hi, I think you need to go more in detail in what this map_region function does.. eg: what is in the MAS registers before the tlbwe happen (checking field by field) and what is the tlb which is created / expected. I got a pretty similar problem with a MAV V2 MMU and fixed size tlb.. But I don't

Re: [Qemu-devel] [PATCH 0/3] ipmi: Fix some minor issues

2017-08-19 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1503178840-21512-1-git-send-email-miny...@acm.org Subject: [Qemu-devel] [PATCH 0/3] ipmi: Fix some minor issues === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(g

[Qemu-devel] [PATCH 3/3] ipmi: Add the platform event message command

2017-08-19 Thread minyard
From: Corey Minyard This lets an event be added to the SEL as if a sensor had generated it. The OpenIPMI driver uses it for storing panic event information. Signed-off-by: Corey Minyard --- hw/ipmi/ipmi_bmc_sim.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/hw/

[Qemu-devel] [PATCH 0/3] ipmi: Fix some minor issues

2017-08-19 Thread minyard
I ran into these testing some stuff in the IPMI driver. Nothing big, but they need to be fixed. -corey

[Qemu-devel] [PATCH 2/3] ipmi: Don't set the timestamp on add events that don't have it

2017-08-19 Thread minyard
From: Corey Minyard According to the spec, event types from 0x0e to 0xff do not have a timestamp. So don't set it when adding those types. This required putting the timestamp in a temporary buffer, since it's still required to set the last addition time. Signed-off-by: Corey Minyard --- hw/i

[Qemu-devel] [PATCH 1/3] ipmi: Fix SEL get/set time commands

2017-08-19 Thread minyard
From: Corey Minyard The minimum message size was wrong for both commands, for getting the time it's zero and for setting the time it's 4. And the data was being pulled from the wrong place in the set time message, it should be the first four bytes. Signed-off-by: Corey Minyard --- hw/ipmi/ipm

Re: [Qemu-devel] [PATCH v14 3/5] virtio-balloon: VIRTIO_BALLOON_F_SG

2017-08-19 Thread kbuild test robot
Hi Wei, [auto build test ERROR on linus/master] [also build test ERROR on v4.13-rc5 next-20170817] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Wei-Wang/lib-xbitmap-Introduce-xbitmap/20170820-

Re: [Qemu-devel] [PATCH v14 1/5] lib/xbitmap: Introduce xbitmap

2017-08-19 Thread kbuild test robot
Hi Matthew, [auto build test WARNING on linus/master] [also build test WARNING on v4.13-rc5 next-20170817] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Wei-Wang/lib-xbitmap-Introduce-xbitmap/2

Re: [Qemu-devel] [Qemu-block] [PATCH v5 08/13] tests: Rely more on global_qtest

2017-08-19 Thread Paolo Bonzini
On 18/08/2017 23:33, John Snow wrote: >> Before the next few patches >> get rid of the qtest_* layer, we first need to update the remaining >> few spots that were using the long form where we can instead rely >> on the short form. >> > Not a big fan of globals and implicit state, but I do at least

Re: [Qemu-devel] [PATCH 3/4] throttle: Remove throttle_fix_bucket() / throttle_unfix_bucket()

2017-08-19 Thread Manos Pitsidianakis
On Thu, Aug 17, 2017 at 05:28:14PM +0300, Alberto Garcia wrote: The throttling code can change internally the value of bkt->max if it hasn't been set by the user. The problem with this is that if we want to retrieve the original value we have to undo this change first. This is ugly and unnecessar

[Qemu-devel] [Bug 1599539] Re: 2.6.0: vvfat driver generates bad FAT entries

2017-08-19 Thread felix
I believe commits f82d92bb028a1d674bab4ccc7e6cde6c04956230 and 6817efea3a0d1bf87be815970cdb014c5a64b628 have fixed this particular bug; although I've since noticed the vvfat driver remains quite fragile, especially FAT32 and writing support. I've got some patches for it of my own, which I might sub

Re: [Qemu-devel] [PATCH 4/4] throttle: Make LeakyBucket.avg and LeakyBucket.max integer types

2017-08-19 Thread Manos Pitsidianakis
On Thu, Aug 17, 2017 at 05:28:15PM +0300, Alberto Garcia wrote: Both the throttling limits set with the throttling.iops-* and throttling.bps-* options and their QMP equivalents defined in the BlockIOThrottle struct are integer values. Those limits are also reported in the BlockDeviceInfo struct

Re: [Qemu-devel] [PATCH 1/4] throttle: Fix wrong variable name in the header documentation

2017-08-19 Thread Manos Pitsidianakis
On Thu, Aug 17, 2017 at 05:28:12PM +0300, Alberto Garcia wrote: The level of the burst bucket is stored in bkt.burst_level, not bkt.burst_lenght. s/lenght/length, otherwise: Reviewed-by: Manos Pitsidianakis Signed-off-by: Alberto Garcia --- include/qemu/throttle.h | 2 +- 1 file changed, 1

[Qemu-devel] [Bug 1711828] [NEW] lock mov non generated #UD

2017-08-19 Thread li
Public bug reported: qemu 2.8.1 debian 9.1 ** Affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1711828 Title: lock mov non generated #UD

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH 09/12] ppc440: Add emulation of plb-pcix controller found in some 440 SoCs

2017-08-19 Thread BALATON Zoltan
On Fri, 18 Aug 2017, luigi burdo wrote: i have sam460 amigaos cdrom iso as my backup and can test it inside qemu. sharing the logs if you needed. It may help if you can do that. You need to compile QEMU from git with this patch series applied and copy the u-boot-sam460-20100605-fixed.bin link

Re: [Qemu-devel] [PATCH] qcow2: allocate cluster_cache/cluster_data on demand

2017-08-19 Thread Alexey Kardashevskiy
On 19/08/17 12:53, Alexey Kardashevskiy wrote: > On 19/08/17 12:46, Alexey Kardashevskiy wrote: >> On 19/08/17 01:18, Eric Blake wrote: >>> On 08/18/2017 08:31 AM, Stefan Hajnoczi wrote: Most qcow2 files are uncompressed so it is wasteful to allocate (32 + 1) * cluster_size + 512 bytes up

Re: [Qemu-devel] [RFC PATCH] osdep.h: Prohibit disabling assert() in supported builds

2017-08-19 Thread Thomas Huth
On 19.08.2017 00:23, Eric Blake wrote: > We already have several files that knowingly require assert() > to work. While we do NOT want to encourage the use of > 'assert(side-effects)' (that is a bad practice that prevents > copy-and-paste of code to other projects that CAN disable > assertions; pl

Re: [Qemu-devel] [RFC PATCH 09/12] ppc440: Add emulation of plb-pcix controller found in some 440 SoCs

2017-08-19 Thread David Gibson
On Fri, Aug 18, 2017 at 01:07:28PM +0200, François Revol wrote: > Hi, > > Le 18/08/2017 à 03:53, David Gibson a écrit : > > On Sun, Aug 13, 2017 at 07:04:38PM +0200, BALATON Zoltan wrote: > > > > You know I'm going to say it, right: needs a commit message. > > > > What's a "plb-pcix", and what's

Re: [Qemu-devel] [PATCH v5 4/6] block: convert ThrottleGroup to object with QOM

2017-08-19 Thread Manos Pitsidianakis
On Fri, Aug 18, 2017 at 03:05:31PM +0200, Alberto Garcia wrote: On Fri 18 Aug 2017 05:10:17 AM CEST, Manos Pitsidianakis wrote: * If no ThrottleGroup is found with the given name a new one is * created. * - * @name: the name of the ThrottleGroup + * This function edits throttle_groups and