Re: [Qemu-devel] [PATCH] tests: Ignore another built executable

2017-05-04 Thread Fam Zheng
On Fri, 04/28 09:54, Daniel P. Berrange wrote: > On Thu, Apr 27, 2017 at 09:23:29PM -0500, Eric Blake wrote: > > Commit 78f86a2b7 added a new test, but forgot to exclude the built > > binary from version control. > > CC Fam > > I wonder if the patchew test system could be made to report an error

Re: [Qemu-devel] [PATCH v3 0/8] Provide support for the software TPM emulator

2017-05-04 Thread Amarnath Valluri
On 05/04/2017 03:28 PM, Stefan Berger wrote: On 05/02/2017 07:52 AM, Amarnath Valluri wrote: Briefly, Theses set of patches introduces: - new TPM backend driver to support software TPM emulators(swtpm(1)). - and few supported fixes/enhancements/cleanup to existing tpm backend code.

Re: [Qemu-devel] [PATCH v2 20/24] machine: call machine init from wrapper

2017-05-04 Thread David Gibson
On Wed, May 03, 2017 at 02:57:14PM +0200, Igor Mammedov wrote: > add machine_run_board_init() wrapper that calls machine > init for now but in follow up patches it will be used > to run generic machine code that should run before > machine init. > > Signed-off-by: Igor Mammedov Reviewed-by: Davi

[Qemu-devel] [PULL v2 00/28] QAPI patches for 2017-05-04

2017-05-04 Thread Markus Armbruster
[v2]: Fix trailing space, note tweaks to PATCH 12 properly in the commit message The following changes since commit e619b14746e5d8c0e53061661fd0e1da01fd4d60: Merge remote-tracking branch 'sthibault/tags/samuel-thibault' into staging (2017-05-02 15:16:29 +0100) are available in the git reposi

Re: [Qemu-devel] [PATCH] tests: Remove redundant assignment

2017-05-04 Thread Michael Tokarev
That's a good one :) Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH v2 2/5] mc146818rtc: precisely count the clock for periodic timer

2017-05-04 Thread Xiao Guangrong
On 05/04/2017 08:31 PM, Paolo Bonzini wrote: On 04/05/2017 13:59, guangrong.x...@gmail.com wrote: From: Tai Yunfang There are two issues in current code: 1) If the period is changed by re-configuring RegA, the coalesced irq will be scaled to reflect the new period, however, it calc

Re: [Qemu-devel] [PATCH] MAINTAINERS: Update paths for AioContext implementation

2017-05-04 Thread Michael Tokarev
Applied to -trivial, mentioning c2b38b2 in commit message, thanks! /mjt

Re: [Qemu-devel] [PATCH] MAINTAINERS: Update paths for main loop

2017-05-04 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH 2/4] string-input-visitor: Support alternate types

2017-05-04 Thread Markus Armbruster
Eduardo Habkost writes: > On Thu, May 04, 2017 at 03:03:36PM -0500, Eric Blake wrote: >> On 05/04/2017 02:42 PM, Eduardo Habkost wrote: >> >> As in: we forbid the combination of a scalar (whether 'int', 'number', >> 'bool', and perhaps 'null') with a plain 'str' (since there's no way t

Re: [Qemu-devel] [PATCH] scripts/qemu-binfmt-conf.sh: Fix shell portability issue

2017-05-04 Thread Michael Tokarev
25.04.2017 16:18, Kamil Rytarowski wrote: > Appease pkgsrc and use portable shell variable comparison. > This switches "==" to "=". It should not be a functional change. Applied to -trivial, thanks! /mjt > Signed-off-by: Kamil Rytarowski > --- > scripts/qemu-binfmt-conf.sh | 4 ++-- > 1 file c

Re: [Qemu-devel] [PATCH] jazz_led: fix bad snprintf

2017-05-04 Thread Michael Tokarev
03.05.2017 13:44, Paolo Bonzini wrote: > Detected by GCC 7's -Wformat-truncation. snprintf writes at most > 2 bytes here including the terminating NUL, so the result is > truncated. In addition, the newline at the end is pointless. > Fix the buffer size and the format string. Polo, that's quite

Re: [Qemu-devel] [PATCH] tests: Ignore another built executable

2017-05-04 Thread Michael Tokarev
28.04.2017 05:23, Eric Blake wrote: > Commit 78f86a2b7 added a new test, but forgot to exclude the built > binary from version control. Applied to -trivial (adding mention of test-hmp to subject), thanks! /mjt

Re: [Qemu-devel] [PATCH v2] scripts: Switch to more portable Perl shebang

2017-05-04 Thread Michael Tokarev
26.04.2017 16:16, Kamil Rytarowski wrote: > The default NetBSD package manager is pkgsrc and it installs Perl > along other third party programs under custom and configurable prefix. > The default prefix for binary prebuilt packages is /usr/pkg, and the > Perl executable lands in /usr/pkg/bin/perl.

Re: [Qemu-devel] [virtio-dev] Vhost-pci RFC2.0

2017-05-04 Thread Wei Wang
On 05/05/2017 12:05 PM, Jason Wang wrote: On 2017年04月19日 14:38, Wang, Wei W wrote: Hi, We made some design changes to the original vhost-pci design, and want to open a discussion about the latest design (labelled 2.0) and its extension (2.1). 2.0 design: One VM shares the entire memory of a

Re: [Qemu-devel] [PATCH V2] migration: expose qemu_announce_self() via qmp

2017-05-04 Thread Markus Armbruster
Germano Veit Michel writes: > Hi guys, > > Finally got some time to prepare V3. > > First of all Dave's trick is really useful to test it: > > ./x86_64-softmmu/qemu-system-x86_64 -nographic -nodefaults -netdev > user,id=netuser -object filter-dump,id=dump,netdev=netuser,file=foo2 > -device e1000,

Re: [Qemu-devel] [virtio-dev] RE: [PATCH v18 1/2] virtio-crypto: Add virtio crypto device specification

2017-05-04 Thread Gonglei (Arei)
> > > On 05/04/2017 03:53 PM, Gonglei (Arei) wrote: > > Sorry, I missed one comment in the previous reply. > > > >> > >>> +\end{itemize*} > >>> + > >> > >> What about extensibility regarding "detailed algorithms"? Is the driver > >> required ignore algorithms > >> it does not "know about"? Should

Re: [Qemu-devel] [virtio-dev] Re: virtio-net: configurable TX queue size

2017-05-04 Thread Wei Wang
On 05/05/2017 10:27 AM, Jason Wang wrote: On 2017年05月04日 18:58, Wang, Wei W wrote: Hi, I want to re-open the discussion left long time ago: https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg06194.html , and discuss the possibility of changing the hardcoded (256) TX queue size to be co

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/5] hw/ppc: removing spapr_drc_detach_cb opaques

2017-05-04 Thread Bharata B Rao
On Thu, May 4, 2017 at 12:50 PM, David Gibson wrote: > On Tue, May 02, 2017 at 04:43:51AM -0300, Daniel Henrique Barboza wrote: > > > > > > On 05/02/2017 12:40 AM, Bharata B Rao wrote: > > > On Sun, Apr 30, 2017 at 10:55 PM, Daniel Henrique Barboza > > > mailto:danie...@linux.vnet.ibm.com>> > > >

Re: [Qemu-devel] [PATCH] COLO-compare: Improve tcp compare trace event readability

2017-05-04 Thread Jason Wang
On 2017年04月27日 11:46, Zhang Chen wrote: Because of previous patch's trace arguments over the limit of UST backend, so I rewrite the patch. Signed-off-by: Zhang Chen --- net/colo-compare.c | 33 ++--- net/trace-events | 3 +-- 2 files changed, 23 insertions(+

Re: [Qemu-devel] [virtio-dev] Vhost-pci RFC2.0

2017-05-04 Thread Jason Wang
On 2017年04月19日 14:38, Wang, Wei W wrote: Hi, We made some design changes to the original vhost-pci design, and want to open a discussion about the latest design (labelled 2.0) and its extension (2.1). 2.0 design: One VM shares the entire memory of another VM 2.1 design: One VM uses an interm

Re: [Qemu-devel] [PATCH v18 1/2] virtio-crypto: Add virtio crypto device specification

2017-05-04 Thread Gonglei (Arei)
> > > On 05/04/2017 04:13 PM, Gonglei (Arei) wrote: > >> > >> > >> On 05/04/2017 03:33 PM, Gonglei (Arei) wrote: > > +\begin{description} > > +\item[VIRTIO_CRYPTO_F_CIPHER_STATELESS_MODE] Requires > VIRTIO_CRYPTO_F_STATELESS_MODE. > > +\item[VIRTIO_CRYPTO_F_HASH_STATELESS_MODE] R

[Qemu-devel] [PATCH 4/5] docker: Add libaio to fedora image

2017-05-04 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/docker/dockerfiles/fedora.docker | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker index 39f6b58..4eaa8ed 100644 --- a/tests/docker/dockerfiles/fedora.docker +++ b

[Qemu-devel] [PATCH 2/5] docker: Add bzip2 and hostname to fedora image

2017-05-04 Thread Fam Zheng
It is used by qemu-iotests. Signed-off-by: Fam Zheng --- tests/docker/dockerfiles/fedora.docker | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker index c4f80ad..39f6b58 100644 --- a/tests/docker/do

[Qemu-devel] [PATCH 3/5] docker: Use unconfined security profile

2017-05-04 Thread Fam Zheng
Some by default blocked syscalls are required to run tests for example userfaultfd. Signed-off-by: Fam Zheng --- tests/docker/Makefile.include | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index 0ed8c3d..09d157c 100644 --- a/tes

[Qemu-devel] [PATCH 5/5] docker: Add test-block

2017-05-04 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/docker/test-block | 21 + 1 file changed, 21 insertions(+) create mode 100755 tests/docker/test-block diff --git a/tests/docker/test-block b/tests/docker/test-block new file mode 100755 index 000..20ef705 --- /dev/null +++ b/tests/docke

[Qemu-devel] [PATCH 1/5] docker: Run tests with current user

2017-05-04 Thread Fam Zheng
We've used --add-current-user to create a user in the image, use it to run tests, because root has too much priviledge, and can surprise test cases. Signed-off-by: Fam Zheng --- tests/docker/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/docker/Makefil

[Qemu-devel] [PATCH 0/5] docker: Add test-block

2017-05-04 Thread Fam Zheng
A few tweaks to the docker images and running commands allow us to run qemu-iotests in the fedora container. This will be added to the patchew test cases later. Fam Zheng (5): docker: Run tests with current user docker: Add bzip2 and hostname to fedora image docker: Use unconfined security p

Re: [Qemu-devel] [PATCH v2 17/24] tests: numa: add case for QMP command query-cpus

2017-05-04 Thread David Gibson
On Wed, May 03, 2017 at 02:57:11PM +0200, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov Reviewed-by: David Gibson > --- > v2: > * fix checkpatch error, move { to newline > --- > tests/numa-test.c | 45 + > 1 file changed, 45 insertions(+) > >

Re: [Qemu-devel] [PATCH v2 14/24] spapr: get numa node mapping from possible_cpus instead of numa_get_node_for_cpu()

2017-05-04 Thread David Gibson
On Wed, May 03, 2017 at 02:57:08PM +0200, Igor Mammedov wrote: > it's safe to remove thread node_id != core node_id error > branch as machine_set_cpu_numa_node() also does mismatch > check and is called even before any CPU is created. > > Signed-off-by: Igor Mammedov Acked-by: David Gibson > -

Re: [Qemu-devel] [PATCH 1/3] colo-compare: serialize compare thread's initialization with main thread

2017-05-04 Thread Jason Wang
On 2017年05月04日 10:51, Hailiang Zhang wrote: Hi Jason, On 2017/4/25 19:33, Jason Wang wrote: On 2017年04月25日 17:59, Hailiang Zhang wrote: On 2017/4/25 16:41, Jason Wang wrote: On 2017年04月24日 14:03, Hailiang Zhang wrote: On 2017/4/24 12:10, Jason Wang wrote: On 2017年04月20日 15:46, zhanghaili

Re: [Qemu-devel] [PATCH v2 12/24] numa: add numa_[has_]node_id() wrappers

2017-05-04 Thread David Gibson
On Wed, May 03, 2017 at 02:57:06PM +0200, Igor Mammedov wrote: > wrappers should make access to [has]node_id fields more readable > > Signed-off-by: Igor Mammedov Reviewed-by: David Gibson Correct, though I'm not sure it actually simplifies things that much. Maybe more in future patches, thoug

Re: [Qemu-devel] virtio-net: configurable TX queue size

2017-05-04 Thread Jason Wang
On 2017年05月04日 18:58, Wang, Wei W wrote: Hi, I want to re-open the discussion left long time ago: https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg06194.html , and discuss the possibility of changing the hardcoded (256) TX queue size to be configurable between 256 and 1024. Yes, I t

[Qemu-devel] [RFC PATCH 1/2] block: Add BDRV_BLOCK_EOF to bdrv_get_block_status()

2017-05-04 Thread Eric Blake
Just as the block layer already sets BDRV_BLOCK_ALLOCATED as a shortcut for subsequent operations, there are also some optimizations that are made easier if we can quickly tell that *pnum will advance us to the end of a file, via a new BDRV_BLOCK_EOF which gets set by the block layer. This just pl

Re: [Qemu-devel] [PATCH] tests: Remove redundant assignment

2017-05-04 Thread Eric Blake
On 05/04/2017 09:04 PM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > tests/postcopy-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Eric Blake > diff --git a/tests/postcopy-test.c b/tests/postcopy-test.c > index de35a18..e86f876 100644 > --- a/tests/postco

[Qemu-devel] [RFC PATCH 2/2] block: Exploit BDRV_BLOCK_EOF for larger zero blocks

2017-05-04 Thread Eric Blake
When we have a BSD with unallocated clusters, but asking the status of its underlying bs->file or backing layer encounters an end-of-file condition, we know that the rest of the unallocated area will read as zeroes. However, pre-patch, this required two separate calls to bdrv_get_block_status(), a

[Qemu-devel] [RFC PATCH 0/2] Enhance block status when crossing EOF

2017-05-04 Thread Eric Blake
As mentioned in my 'qcow2 zero-cluster tweaks' cover letter https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg00722.html I hit a case where we were not fully optimizing a write-zeroes operation when we have a backing file that is shorter than the active layer, and where the request crosses t

[Qemu-devel] [PATCH] tests: Remove redundant assignment

2017-05-04 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/postcopy-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/postcopy-test.c b/tests/postcopy-test.c index de35a18..e86f876 100644 --- a/tests/postcopy-test.c +++ b/tests/postcopy-test.c @@ -41,7 +41,7 @@ static bool ufd_version_chec

[Qemu-devel] [PATCH v7 13/13] MAINTAINERS: Add vfio-ccw maintainer

2017-05-04 Thread Dong Jia Shi
Add Cornelia Huck as the vfio-ccw maintainer. Signed-off-by: Dong Jia Shi --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index cae3b09..c1f9917 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -999,6 +999,11 @@ S: Supported F: hw/vfio/* F: inclu

[Qemu-devel] [PATCH v7 08/13] vfio/ccw: get io region info

2017-05-04 Thread Dong Jia Shi
vfio-ccw provides an MMIO region for I/O operations. We fetch its information via ioctls here, then we can use it performing I/O instructions and retrieving I/O results later on. Signed-off-by: Dong Jia Shi --- hw/vfio/ccw.c | 54 ++ 1 file cha

[Qemu-devel] [PATCH v7 11/13] s390x/css: ccw translation infrastructure

2017-05-04 Thread Dong Jia Shi
From: Xiao Feng Ren Implement a basic infrastructure of handling channel I/O instruction interception for passed through subchannels: 1. Branch the code path of instruction interception handling by SubChannel type. 2. For a passed-through subchannel, issue the ORB to kernel to do ccw transl

[Qemu-devel] [PATCH v7 12/13] vfio/ccw: update sense data if a unit check is pending

2017-05-04 Thread Dong Jia Shi
Concurrent-sense data is currently not delivered. This patch stores the concurrent-sense data to the subchannel if a unit check is pending and the concurrent-sense bit is enabled. Then a TSCH can retreive the right IRB data back to the guest. Signed-off-by: Dong Jia Shi --- hw/vfio/ccw.c | 7 +++

[Qemu-devel] [PATCH v7 07/13] vfio/ccw: vfio based subchannel passthrough driver

2017-05-04 Thread Dong Jia Shi
From: Xiao Feng Ren We use the IOMMU_TYPE1 of VFIO to realize the subchannels passthrough, implement a vfio based subchannels passthrough driver called "vfio-ccw". Support qemu parameters in the style of: "-device vfio-ccw,sysfsdev=$mdev_file_path,devno=xx.x.' Signed-off-by: Xiao Feng Ren

[Qemu-devel] [PATCH v7 09/13] vfio/ccw: get irqs info and set the eventfd fd

2017-05-04 Thread Dong Jia Shi
vfio-ccw resorts to the eventfd mechanism to communicate with userspace. We fetch the irqs info via the ioctl VFIO_DEVICE_GET_IRQ_INFO, register a event notifier to get the eventfd fd which is sent to kernel via the ioctl VFIO_DEVICE_SET_IRQS, then we can implement read operation once kernel sends

[Qemu-devel] [PATCH v7 06/13] s390x/css: device support for s390-ccw passthrough

2017-05-04 Thread Dong Jia Shi
In order to support subchannels pass-through, we introduce a s390 subchannel device called "s390-ccw" to hold the real subchannel info. The s390-ccw devices inherit from the abstract CcwDevice which connect to the existing virtual-css-bus. Signed-off-by: Dong Jia Shi --- hw/s390x/Makefile.objs |

[Qemu-devel] [PATCH v7 03/13] s390x/css: add s390-squash-mcss machine option

2017-05-04 Thread Dong Jia Shi
From: Xiao Feng Ren We want to support real (i.e. not virtual) channel devices even for guests that do not support MCSS-E (where guests may see devices from any channel subsystem image at once). As all virtio-ccw devices are in css 0xfe (and show up in the default css 0 for guests not activating

[Qemu-devel] [PATCH v7 04/13] s390x/css: realize css_sch_build_schib

2017-05-04 Thread Dong Jia Shi
From: Xiao Feng Ren The S390 virtual css support already has a mechanism to build virtual Sub-Channel Information Block and provide virtual subchannels to the guest. However, to pass-through subchannels to a guest, we need to introduce a new mechanism to build its schib according to the real devi

[Qemu-devel] [PATCH v7 10/13] s390x/css: introduce and realize ccw-request callback

2017-05-04 Thread Dong Jia Shi
From: Xiao Feng Ren Introduce a new callback on subchannel to handle ccw-request. Realize the callback in vfio-ccw device. Besides, resort to the event notifier handler to handling the ccw-request results. 1. Pread the I/O results via MMIO region. 2. Update the scsw info to guest. 3. Inject an I/

[Qemu-devel] [PATCH v7 05/13] s390x/css: realize css_create_sch

2017-05-04 Thread Dong Jia Shi
The S390 virtual css support already has a mechanism to create a virtual subchannel and provide it to the guest. However, to pass-through subchannels to a guest, we need to introduce a new mechanism to create the subchannel according to the real device information. Thus we reconstruct css_create_vi

[Qemu-devel] [PATCH v7 02/13] vfio: linux-headers update for vfio-ccw

2017-05-04 Thread Dong Jia Shi
This is a placeholder for a linux-headers update. Signed-off-by: Dong Jia Shi --- linux-headers/linux/vfio.h | 17 + linux-headers/linux/vfio_ccw.h | 28 2 files changed, 45 insertions(+) create mode 100644 linux-headers/linux/vfio_ccw.h diff --

[Qemu-devel] [PATCH v7 00/13] basic channel IO passthrough infrastructure based on vfio

2017-05-04 Thread Dong Jia Shi
The patch series introduce a basic channel I/O passthrough infrastructure based on vfio. - Focus on supporting dasd-eckd(cu_type/dev_type = 0x3990/0x3390) as the target device. - Support new qemu parameters in the style of: -machine s390-ccw-virtio(,s390-squash-mcss=on|off) \ -device vfi

[Qemu-devel] [PATCH v7 01/13] update-linux-headers: update for vfio-ccw

2017-05-04 Thread Dong Jia Shi
Add vfio_ccw.h. Signed-off-by: Dong Jia Shi --- scripts/update-linux-headers.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh index 6a370a8..2f906c4 100755 --- a/scripts/update-linux-headers.sh +++ b/scripts/

Re: [Qemu-devel] [PATCH V2] migration: expose qemu_announce_self() via qmp

2017-05-04 Thread Germano Veit Michel
Hi guys, Finally got some time to prepare V3. First of all Dave's trick is really useful to test it: ./x86_64-softmmu/qemu-system-x86_64 -nographic -nodefaults -netdev user,id=netuser -object filter-dump,id=dump,netdev=netuser,file=foo2 -device e1000,netdev=netuser,mac=00:11:22:33:44:55 -monitor

Re: [Qemu-devel] [PATCH v10 4/6] mm: function to offer a page block on the free list

2017-05-04 Thread kbuild test robot
Hi Wei, [auto build test WARNING on linus/master] [also build test WARNING on v4.11 next-20170504] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Wei-Wang/Extend-virtio-balloon-for-fast-de

Re: [Qemu-devel] [PATCH 1/1] slirp: don't zero ti_i since we acccess it later.

2017-05-04 Thread Samuel Thibault
Hello, lepton, on mer. 03 mai 2017 11:35:05 -0700, wrote: > It sounds like a bug that  caller set up a > right src and dst address and without set right ih_x1. I wouldn't bet on that. ih_x1 is only a filler, the caller can be using the structure only as a C structure, and it's only here just befo

Re: [Qemu-devel] [Qemu-devel RFC v3 4/5] msf2: Add Smartfusion2 SoC.

2017-05-04 Thread Alistair Francis
On Fri, Apr 28, 2017 at 9:51 AM, Subbaraya Sundeep wrote: > Smartfusion2 SoC has hardened Microcontroller subsystem > and flash based FPGA fabric. This patch adds support for > Microcontroller subsystem in the SoC. > > Signed-off-by: Subbaraya Sundeep > --- > default-configs/arm-softmmu.mak |

[Qemu-devel] [PATCH 1/2] block/vxhs: Allow VXHS to be built as a module

2017-05-04 Thread Jeff Cody
In 88d8879, protocol drivers had modularization enabled. As VXHS is a protocol, make sure it is able to be built as a module as well. Signed-off-by: Jeff Cody --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 48a9370..eada141 100755 --

[Qemu-devel] [PATCH 0/2] Minor VXHS fixups

2017-05-04 Thread Jeff Cody
This fixes a couple of small issues with VXHS; modularization, and improved error messaging. Jeff Cody (2): block/vxhs: Allow VXHS to be built as a module block/vxhs: set errp on iio_init() failure block/vxhs.c | 1 + configure| 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) --

[Qemu-devel] [PATCH 2/2] block/vxhs: set errp on iio_init() failure

2017-05-04 Thread Jeff Cody
Signed-off-by: Jeff Cody --- block/vxhs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/vxhs.c b/block/vxhs.c index 9ffe9d3..1f1e5db 100644 --- a/block/vxhs.c +++ b/block/vxhs.c @@ -301,6 +301,7 @@ static int vxhs_open(BlockDriverState *bs, QDict *options, ret = vxhs_init_and_r

Re: [Qemu-devel] [PATCH v2] hw/virtio: fix vhost user fails to startup when MQ

2017-05-04 Thread Marc-André Lureau
On Thu, May 4, 2017 at 8:30 PM Zhiyong Yang wrote: > Qemu2.7~2.9 and vhost user for dpdk 17.02 release work together > to cause failures of new connection when negotiating to set MQ. > (one queue pair works well). >Because there exist some bugs in qemu code when introducing > VHOST_USER_PROT

Re: [Qemu-devel] [PATCH] qemu-img: Check for backing image if specified during create

2017-05-04 Thread John Snow
On 05/04/2017 03:58 PM, Eric Blake wrote: > On 05/04/2017 02:30 PM, John Snow wrote: >> Or, rather, force the open of a backing image if one was specified >> for creation. Using a similar -unsafe option as rebase, allow qemu-img >> to ignore the backing file validation if possible. >> >> It may n

Re: [Qemu-devel] [RFC PATCH 03/20] intel_iommu: add "svm" option

2017-05-04 Thread Raj, Ashok
On Thu, May 04, 2017 at 02:28:53PM -0600, Alex Williamson wrote: > On Thu, 27 Apr 2017 18:53:17 +0800 > Peter Xu wrote: > > > On Wed, Apr 26, 2017 at 06:06:33PM +0800, Liu, Yi L wrote: > > > Expose "Shared Virtual Memory" to guest by using "svm" option. > > > Also use "svm" to expose SVM related

Re: [Qemu-devel] [RFC PATCH 03/20] intel_iommu: add "svm" option

2017-05-04 Thread Alex Williamson
On Thu, 27 Apr 2017 18:53:17 +0800 Peter Xu wrote: > On Wed, Apr 26, 2017 at 06:06:33PM +0800, Liu, Yi L wrote: > > Expose "Shared Virtual Memory" to guest by using "svm" option. > > Also use "svm" to expose SVM related capabilities to guest. > > e.g. "-device intel-iommu, svm=on" > > > > Signed

Re: [Qemu-devel] [PATCH 2/4] string-input-visitor: Support alternate types

2017-05-04 Thread Eduardo Habkost
On Thu, May 04, 2017 at 03:03:36PM -0500, Eric Blake wrote: > On 05/04/2017 02:42 PM, Eduardo Habkost wrote: > > As in: we forbid the combination of a scalar (whether 'int', 'number', > 'bool', and perhaps 'null') with a plain 'str' (since there's no way to > tell whether '1' should

Re: [Qemu-devel] [PATCH 2/4] string-input-visitor: Support alternate types

2017-05-04 Thread Eric Blake
On 05/04/2017 02:42 PM, Eduardo Habkost wrote: As in: we forbid the combination of a scalar (whether 'int', 'number', 'bool', and perhaps 'null') with a plain 'str' (since there's no way to tell whether '1' should parse as an integer or the string "1"); and combining a scalar w

Re: [Qemu-devel] [PATCH] qemu-img: Check for backing image if specified during create

2017-05-04 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] qemu-img: Check for backing image if specified during create Message-id: 20170504193044.16303-1-js...@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash BAS

Re: [Qemu-devel] [PATCH] qemu-img: Check for backing image if specified during create

2017-05-04 Thread Eric Blake
On 05/04/2017 02:30 PM, John Snow wrote: > Or, rather, force the open of a backing image if one was specified > for creation. Using a similar -unsafe option as rebase, allow qemu-img > to ignore the backing file validation if possible. > > It may not always be possible, as in the existing case of

Re: [Qemu-devel] [PATCH 2/4] string-input-visitor: Support alternate types

2017-05-04 Thread Eduardo Habkost
On Thu, May 04, 2017 at 11:10:56AM -0300, Eduardo Habkost wrote: > On Thu, May 04, 2017 at 03:42:59PM +0200, Markus Armbruster wrote: > > Eric Blake writes: > > > > > On 05/04/2017 03:06 AM, Markus Armbruster wrote: > > >> Eduardo Habkost writes: > > >> > > >>> On Wed, May 03, 2017 at 06:07:43P

[Qemu-devel] risugen: test only instructions that begin with the letter F

2017-05-04 Thread G 3
I'm trying to test all the floating point instructions only. They tend to begin with the letter f. Is there a way to have risugen only use instructions that begin with the letter F?

[Qemu-devel] [PATCH] qemu-img: Check for backing image if specified during create

2017-05-04 Thread John Snow
Or, rather, force the open of a backing image if one was specified for creation. Using a similar -unsafe option as rebase, allow qemu-img to ignore the backing file validation if possible. It may not always be possible, as in the existing case of if a filesize for the new image was not specified.

Re: [Qemu-devel] [Qemu-ppc] [PATCHv3 0/4] Clean up compatibility mode handling

2017-05-04 Thread Greg Kurz
On Thu, 04 May 2017 16:32:59 +0200 Andrea Bolognani wrote: > On Thu, 2017-04-27 at 17:28 +1000, David Gibson wrote: > > This is a rebased and revised version of my patches revising CPU > > compatiblity mode handling on ppc, last posted in November.  Since > > then, many of the patches have alread

Re: [Qemu-devel] [PATCH 06/41] migration: Move colo.h to migration/

2017-05-04 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > There are functions only used by migration code. > > Signed-off-by: Juan Quintela > --- > MAINTAINERS | 2 +- > migration/colo-comm.c | 2 +- > migration/colo-failover.c | 2 +- > {include/

Re: [Qemu-devel] [PATCH 08/41] migration: Move page_cache.c to migration/

2017-05-04 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > It is only used by migration, so move it there. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > Makefile.objs | 1 - > migration/Makefile.objs | 2 +- > page_cache

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-05-04 Thread Markus Armbruster
I figure everyone interested has had his say. Let me try to summarize and draw my conclusions. Commands + events can replace asynchronous commands (they did). Asynchronous commands cannot replace events, because "interesting" side effects of commands need to be broadcast. Doesn't mean asynchron

Re: [Qemu-devel] [PATCHv3 2/4] pseries: Move CPU compatibility property to machine

2017-05-04 Thread Greg Kurz
On Thu, 04 May 2017 19:09:11 +0200 Andrea Bolognani wrote: > On Thu, 2017-04-27 at 17:28 +1000, David Gibson wrote: > > @@ -2480,6 +2480,10 @@ static void spapr_machine_initfn(Object *obj) > >  " place of standard EPOW events when > >possible" > > 

Re: [Qemu-devel] [PATCH RFC] i386: expose "TCGTCGTCGTCG" in the 0x40000000 CPUID leaf

2017-05-04 Thread Eduardo Habkost
On Thu, May 04, 2017 at 03:56:58PM +0100, Daniel P. Berrange wrote: > Currently when running KVM, we expose "KVMKVMKVM\0\0\0" in > the 0x4000 CPUID leaf. Other hypervisors (VMWare, > HyperV, Xen, BHyve) all do the same thing, which leaves > TCG as the odd one out. > > The CPUID is used by soft

Re: [Qemu-devel] [PATCH v2] xen/mapcache: store dma information in revmapcache entries for debugging

2017-05-04 Thread Anthony PERARD
On Wed, May 03, 2017 at 02:00:35PM -0700, Stefano Stabellini wrote: > The Xen mapcache is able to create long term mappings, they are called > "locked" mappings. The third parameter of the xen_map_cache call > specifies if a mapping is a "locked" mapping. > > > >From the QEMU point of view there

Re: [Qemu-devel] [PATCH 6/6] file-posix: Remove .bdrv_inactivate/invalidate_cache

2017-05-04 Thread Eric Blake
On 05/04/2017 11:52 AM, Kevin Wolf wrote: > Now that the block layer takes care to request a lot less permissions > for inactive nodes, the special-casing in file-posix isn't necessary any > more. > > Signed-off-by: Kevin Wolf > --- > block/file-posix.c | 33 - >

Re: [Qemu-devel] [PATCH 5/6] block: Fix write/resize permissions for inactive images

2017-05-04 Thread Eric Blake
On 05/04/2017 11:52 AM, Kevin Wolf wrote: > Format drivers for inactive nodes don't need write/resize permissions on > their bs->file and can share write/resize with another VM (in fact, this > is the whole point of keeping images inactive). Represent this fact in > the op blocker system, so that i

[Qemu-devel] [PATCH] block: Simplify BDRV_BLOCK_RAW recursion

2017-05-04 Thread Eric Blake
Since we are already in coroutine context during the body of bdrv_co_get_block_status(), we can shave off a few layers of wrappers when recursing to query the protocol when a format driver returned BDRV_BLOCK_RAW. Note that we are already using the correct recursion later on in the same function,

Re: [Qemu-devel] [virtio-dev] RE: [PATCH v18 1/2] virtio-crypto: Add virtio crypto device specification

2017-05-04 Thread Halil Pasic
On 05/04/2017 03:33 PM, Gonglei (Arei) wrote: >>> +\drivernormative{\subsubsection}{Device configuration layout}{Device Types >> / Crypto Device / Device configuration layout} >>> + >>> +\begin{itemize*} >>> +\item The driver MUST read the ready \field{status} from the bottom bit of >> status to

Re: [Qemu-devel] [PATCH 4/6] block: Inactivate parents before children

2017-05-04 Thread Eric Blake
On 05/04/2017 11:52 AM, Kevin Wolf wrote: > The proper order for inactivating block nodes is that first the parents > get inactivated and then the children. If we do things in this order, we > can assert that we didn't accidentally leave a parent activated when one > of its child nodes is inactive.

Re: [Qemu-devel] [PATCH 3/6] block: Drop permissions when migration completes

2017-05-04 Thread Eric Blake
On 05/04/2017 11:52 AM, Kevin Wolf wrote: > With image locking, permissions affect other qemu processes as well. We > want to be sure that the destination can run, so let's drop permissions > on the source when migration completes. > > Signed-off-by: Kevin Wolf > --- > block.c

Re: [Qemu-devel] [PATCH 2/6] block: New BdrvChildRole.activate() for blk_resume_after_migration()

2017-05-04 Thread Eric Blake
On 05/04/2017 11:52 AM, Kevin Wolf wrote: > Instead of manually calling blk_resume_after_migration() in migration > code after doing bdrv_invalidate_cache_all(), integrate the BlockBackend > activation with cache invalidation into a single function. This is > achieved with a new callback in BdrvChi

Re: [Qemu-devel] [PATCH 1/6] migration: Unify block node activation error handling

2017-05-04 Thread Eric Blake
On 05/04/2017 11:52 AM, Kevin Wolf wrote: > Migration code activates all block driver nodes on the destination when > the migration completes. It does so by calling > bdrv_invalidate_cache_all() and blk_resume_after_migration(). There is > one code path for precopy and one for postcopy migration, r

Re: [Qemu-devel] [PATCHv3 2/4] pseries: Move CPU compatibility property to machine

2017-05-04 Thread Andrea Bolognani
On Thu, 2017-04-27 at 17:28 +1000, David Gibson wrote: > @@ -2480,6 +2480,10 @@ static void spapr_machine_initfn(Object *obj) >  " place of standard EPOW events when >possible" >  " (required for memory hot-unplug >support)",

Re: [Qemu-devel] [PATCH v2 06/24] spapr: add node-id property to sPAPR core

2017-05-04 Thread David Gibson
On Wed, May 03, 2017 at 06:12:17PM +0200, Igor Mammedov wrote: > On Wed, 3 May 2017 11:46:44 -0300 > Eduardo Habkost wrote: > > > On Wed, May 03, 2017 at 02:57:00PM +0200, Igor Mammedov wrote: > > > it will allow switching from cpu_index to core based numa > > > mapping in follow up patches. > >

Re: [Qemu-devel] [PATCH v2 09/24] numa: add check that board supports cpu_index to node mapping

2017-05-04 Thread David Gibson
On Wed, May 03, 2017 at 02:57:03PM +0200, Igor Mammedov wrote: > Default node mapping initialization already checks that board > supports cpu_index to node mapping and refuses to start if > it's not supported. Do the same for explicitly provided > mapping "-numa node,cpus=..." > > Signed-off-by: I

Re: [Qemu-devel] Issue with a manually compiled QEMU

2017-05-04 Thread Dr. David Alan Gilbert
* Fabien GREGOIRE (fabien.grego...@outlook.com) wrote: > Hello, > > > > I have an issue with a manually compiled QEMU working with > virt-manager/libvirt : > > Internal Error: process exited while connecting to monitor: > > qemu could not load PC BIOS 'bios-256k.bin'. > > > > Here are the

[Qemu-devel] [PATCH 6/6] file-posix: Remove .bdrv_inactivate/invalidate_cache

2017-05-04 Thread Kevin Wolf
Now that the block layer takes care to request a lot less permissions for inactive nodes, the special-casing in file-posix isn't necessary any more. Signed-off-by: Kevin Wolf --- block/file-posix.c | 33 - 1 file changed, 33 deletions(-) diff --git a/block/file-p

[Qemu-devel] [PATCH 5/6] block: Fix write/resize permissions for inactive images

2017-05-04 Thread Kevin Wolf
Format drivers for inactive nodes don't need write/resize permissions on their bs->file and can share write/resize with another VM (in fact, this is the whole point of keeping images inactive). Represent this fact in the op blocker system, so that image locking does the right thing without special-

[Qemu-devel] [PATCH 3/6] block: Drop permissions when migration completes

2017-05-04 Thread Kevin Wolf
With image locking, permissions affect other qemu processes as well. We want to be sure that the destination can run, so let's drop permissions on the source when migration completes. Signed-off-by: Kevin Wolf --- block.c | 12 +++- block/block-backend.c | 25 ++

[Qemu-devel] [PATCH 2/6] block: New BdrvChildRole.activate() for blk_resume_after_migration()

2017-05-04 Thread Kevin Wolf
Instead of manually calling blk_resume_after_migration() in migration code after doing bdrv_invalidate_cache_all(), integrate the BlockBackend activation with cache invalidation into a single function. This is achieved with a new callback in BdrvChildRole that is called by bdrv_invalidate_cache_all

[Qemu-devel] [PATCH 4/6] block: Inactivate parents before children

2017-05-04 Thread Kevin Wolf
The proper order for inactivating block nodes is that first the parents get inactivated and then the children. If we do things in this order, we can assert that we didn't accidentally leave a parent activated when one of its child nodes is inactive. Signed-off-by: Kevin Wolf --- block.c | 25 +++

[Qemu-devel] [PATCH 1/6] migration: Unify block node activation error handling

2017-05-04 Thread Kevin Wolf
Migration code activates all block driver nodes on the destination when the migration completes. It does so by calling bdrv_invalidate_cache_all() and blk_resume_after_migration(). There is one code path for precopy and one for postcopy migration, resulting in four function calls, which used to hav

[Qemu-devel] [PATCH 0/6] block: Fix op blockers for inactive images

2017-05-04 Thread Kevin Wolf
Fam's image locking series introduced some special-casing in the file-posix driver that avoids taking locks when the image is inactive. While this works, it really isn't the job of the file-posix driver, but the core block layer should consider that inactive nodes require a lot less permissions. T

Re: [Qemu-devel] (no subject)

2017-05-04 Thread gengdongjiu
Dear James, Thanks a lot for your review and comments. I am very sorry for the late response. 2017-05-04 23:42 GMT+08:00 gengdongjiu : > Hi Dongjiu Geng, > > On 30/04/17 06:37, Dongjiu Geng wrote: >> when happen SEA, deliver signal bus and handle the ioctl that >> inject SEA abort to guest, s

Re: [Qemu-devel] [PULL 00/28] QAPI patches for 2017-05-04

2017-05-04 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 00/28] QAPI patches for 2017-05-04 Message-id: 1493911445-19568-1-git-send-email-arm...@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/5] hw/ppc: removing spapr_drc_detach_cb opaques

2017-05-04 Thread Daniel Henrique Barboza
On 05/04/2017 04:24 AM, David Gibson wrote: On Wed, May 03, 2017 at 05:33:54PM -0300, Daniel Henrique Barboza wrote: Update: I have talked with Michael Roth about the spapr_release_lmb callback, the flow of the LMB releases and so on. He clarified to me that it is not possible to get rid of th

[Qemu-devel] [PATCH v2] hw/virtio: fix vhost user fails to startup when MQ

2017-05-04 Thread Zhiyong Yang
Qemu2.7~2.9 and vhost user for dpdk 17.02 release work together to cause failures of new connection when negotiating to set MQ. (one queue pair works well). Because there exist some bugs in qemu code when introducing VHOST_USER_PROTOCOL_F_REPLY_ACK to qemu. When vhost_user_set_mem_table is invo

Re: [Qemu-devel] [PATCH] block migration: Allow compile time disable

2017-05-04 Thread Eric Blake
On 05/03/2017 05:42 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Many users now prefer to use drive_mirror over NBD as an > alternative to the older migrate -b option; drive_mirror is > more complex to setup but gives you more options (e.g. only > migrating some of

  1   2   3   4   5   >