Re: [Qemu-devel] [RFC 03/19] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE

2017-04-03 Thread Thomas Huth
On 04.04.2017 08:53, Alexander Graf wrote: > > > On 03.04.17 23:00, Eduardo Habkost wrote: >> On Mon, Apr 03, 2017 at 10:15:44PM +0200, Alexander Graf wrote: >>> >>> >>> On 03.04.17 22:10, Eduardo Habkost wrote: On Mon, Apr 03, 2017 at 08:49:16PM +0100, Peter Maydell wrote: > On 1 April

Re: [Qemu-devel] [PATCH v5] qga: Add `guest-get-timezone` command

2017-04-03 Thread Vinzenz Feenstra
Ping > On Mar 23, 2017, at 12:39 PM, Vinzenz 'evilissimo' Feenstra > wrote: > > From: Vinzenz Feenstra > > Adds a new command `guest-get-timezone` reporting the currently > configured timezone on the system. The information on what timezone is > currently is configured is useful in case of Wi

Re: [Qemu-devel] [RFC 03/19] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE

2017-04-03 Thread Alexander Graf
On 03.04.17 23:00, Eduardo Habkost wrote: On Mon, Apr 03, 2017 at 10:15:44PM +0200, Alexander Graf wrote: On 03.04.17 22:10, Eduardo Habkost wrote: On Mon, Apr 03, 2017 at 08:49:16PM +0100, Peter Maydell wrote: On 1 April 2017 at 01:46, Eduardo Habkost wrote: commit 33cd52b5d7b9adfd009e9

[Qemu-devel] [PATCH v2 0/1] qga: Add 'guest-get-host-name' command

2017-04-03 Thread Vinzenz 'evilissimo' Feenstra
From: Vinzenz Feenstra Since v1: - Renamed from FQDN to hostname and expanded documentation Vinzenz Feenstra (1): qga: Add 'guest-get-host-name' command qga/commands.c | 11 +++ qga/qapi-schema.json | 29 + 2 files changed, 40 insertions(+) -- 2.9.

[Qemu-devel] [PATCH v2 1/1] qga: Add 'guest-get-host-name' command

2017-04-03 Thread Vinzenz 'evilissimo' Feenstra
From: Vinzenz Feenstra Retrieving the guest host name is a very useful feature for virtual management systems. This information can help to have more user friendly VM access details, instead of an IP there would be the host name. Also the host name reported can be used to have automated checks fo

Re: [Qemu-devel] [RFC 02/19] s390: Add FIXME for unexplained user_creatable=false line

2017-04-03 Thread Cornelia Huck
On Mon, 3 Apr 2017 16:20:11 -0300 Eduardo Habkost wrote: > On Mon, Apr 03, 2017 at 10:55:38AM +0200, Cornelia Huck wrote: > > On Fri, 31 Mar 2017 21:46:07 -0300 > > Eduardo Habkost wrote: > > > > > TYPE_S390_PCI_HOST_BRIDGE has user_creatable=false but has > > > no comment explaining why. Add a

Re: [Qemu-devel] [PATCH] win32: replace custom mutex and condition variable with native primitives

2017-04-03 Thread Cornelia Huck
On Mon, 3 Apr 2017 18:12:34 + Andrew Baumann wrote: > > From: Cornelia Huck [mailto:cornelia.h...@de.ibm.com] > > Sent: Monday, 3 April 2017 7:20 > > > > On Fri, 24 Mar 2017 15:01:41 -0700 > > Andrew Baumann wrote: > > > > > From: Andrey Shedel > > > > > > The multithreaded TCG implementa

Re: [Qemu-devel] [RfC PATCH 0/4] make display updates thread safe.

2017-04-03 Thread Gerd Hoffmann
On Mo, 2017-04-03 at 19:02 +0200, Paolo Bonzini wrote: > > On 03/04/2017 14:03, Gerd Hoffmann wrote: > > We might clear some more bits, but these are > > outsize the visible area so they should cause visible corruption (and if > > the visible area changes the display code needs to do a full refres

Re: [Qemu-devel] [RfC PATCH 0/4] make display updates thread safe.

2017-04-03 Thread Gerd Hoffmann
Hi, > -unsigned long align = 1 << (TARGET_PAGE_BITS + BITS_PER_LEVEL); > +unsigned long align = 1UL << (TARGET_PAGE_BITS + BITS_PER_LEVEL); > There were 2 issues here: without the UL suffix on align I was getting > incorrect first/last addresses since the high bits of align weren't > be

[Qemu-devel] [PATCH v3 1/1] qga: Add 'guest-get-users' command

2017-04-03 Thread Vinzenz 'evilissimo' Feenstra
From: Vinzenz Feenstra A command that will list all currently logged in users, and the time since when they are logged in. Examples: virsh # qemu-agent-command F25 '{ "execute": "guest-get-users" }' {"return":[{"login-time":1490622289.903835,"user":"root"}]} virsh # qemu-agent-command Win2k12r

[Qemu-devel] [PATCH v3 0/1] qga: Add 'guest-get-users' command

2017-04-03 Thread Vinzenz 'evilissimo' Feenstra
From: Vinzenz Feenstra Changes since v2: - Updated the documentation of login-time to be more precise what the value contains and what time is actually reported and in which format. Changes since v1: - fixed spelling issues in the commit message and schema - added login-time field which specif

Re: [Qemu-devel] [PATCH v3] qemu-ga: add guest-get-osrelease command

2017-04-03 Thread Vinzenz Feenstra
Hi Michael, It’d be really great to get your opinion on this matter. Thanks! > On Apr 3, 2017, at 5:17 PM, Marc-André Lureau > wrote: > > Hi > > On Fri, Mar 31, 2017 at 3:41 PM Eric Blake > wrote: > On 03/31/2017 05:19 AM, Vinzenz 'evilissimo' Feenstra wrote: > > Fr

Re: [Qemu-devel] [RFC PATCH v1 7/9] cpus: move icount preparation out of tcg_exec_cpu

2017-04-03 Thread Pavel Dovgalyuk
I guess you are trying to fix the sympthoms of the case when iothread is trying to access instruction count. Maybe the solution is providing access to current_cpu for the iothread coupled with your patch 8? Pavel Dovgalyuk > -Original Message- > From: Alex Bennée [mailto:alex.ben...@lin

Re: [Qemu-devel] [RFC PATCH v1 8/9] cpus: don't credit executed instructions before they have run

2017-04-03 Thread Pavel Dovgalyuk
> From: Alex Bennée [mailto:alex.ben...@linaro.org] > Outside of the vCPU thread icount time will only be tracked against > timers_state.qemu_icount. We no longer credit cycles until they have > completed the run. Inside the vCPU thread we adjust for passage of > time by looking at how many have ru

[Qemu-devel] [Bug 1678466] Re: using x-vga=on with vfio-pci leads to segfault

2017-04-03 Thread Alex Williamson
Does this resolve the segfault? diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c index e9b493b939db..349085ea12bc 100644 --- a/hw/vfio/pci-quirks.c +++ b/hw/vfio/pci-quirks.c @@ -660,7 +660,7 @@ static void vfio_probe_nvidia_bar5_quirk(VFIOPCIDevice *vdev VFIOConfigWindowQuirk *window

[Qemu-devel] [Bug 740895] Re: qemu freeze when loading msdos with EMM386.EXE NOEMS HIGHSCAN

2017-04-03 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/740895 Title: qemu freeze

[Qemu-devel] [Bug 1679358] [NEW] ARM: SCTLR fields not being preserved

2017-04-03 Thread Yifan
Public bug reported: There are fields in SCTLR that are RAO/SBOP or WI or in the case of the RR field, accessible only in secure mode. Currently it seems that qemu just propagates any write to SCTLR to the register and this screwed up in a bootloader that I am debugging. ** Affects: qemu Imp

[Qemu-devel] [Bug 1678466] Re: using x-vga=on with vfio-pci leads to segfault

2017-04-03 Thread Alex Williamson
It's highly likely that a 7-series GeForce has a different BAR layout than a modern card and should be considered unsupported. Is the "similar card in another slot" also a 7-series or older card? Out of curiosity, add another -v to the lspci output (lspci -vv) so that it identifies which BARs are

[Qemu-devel] [PATCH v11 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"

2017-04-03 Thread Ashish Mittal
These changes use a vxhs test server that is a part of the following repository: https://github.com/VeritasHyperScale/libqnio.git Signed-off-by: Ashish Mittal Reviewed-by: Stefan Hajnoczi --- v11 changelog: (1) No changes. v10 changelog: (1) Redirect o/p of "$QEMU_VXHS -d $TEST_DIR" to /dev/nu

[Qemu-devel] [PATCH v11 0/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-04-03 Thread Ashish Mittal
- Veritas HyperScale block driver in QEMU is designed to provide an accelerated IO path from KVM virtual machines to Veritas HyperScale storage service. - A network IO transfer library that translates block IO from HyperScale block driver to a network IO format to send it to Veritas HyperScale

[Qemu-devel] [PATCH v11 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-04-03 Thread Ashish Mittal
Source code for the qnio library that this code loads can be downloaded from: https://github.com/VeritasHyperScale/libqnio.git Sample command line using JSON syntax: ./x86_64-softmmu/qemu-system-x86_64 -name instance-0008 -S -vnc 0.0.0.0:0 -k en-us -vga cirrus -device virtio-balloon-pci,id=bal

Re: [Qemu-devel] [PATCH v1 2/3] applesmc: consolidate port i/o into single contiguous region

2017-04-03 Thread Gabriel L. Somlo
On Mon, Apr 03, 2017 at 12:27:15PM +0200, Paolo Bonzini wrote: > > > On 03/04/2017 11:32, Alexander Graf wrote: > > > >> Newer AppleSMC revisions support an error status (read) port > >> in addition to the data and command ports currently supported. > >> > >> Register the full 32-bit region at o

[Qemu-devel] [PATCH v3 1/1] slirp: add SOCKS5 support

2017-04-03 Thread Laurent Vivier
When the VM is used behind a firewall, This allows the use of a SOCKS5 proxy server to connect the VM IP stack directly to the Internet. This implementation doesn't manage UDP packets, so they are simply dropped (as with restrict=on), except for the localhost as we need it for DNS. Signed-off-by:

[Qemu-devel] [PATCH v3 0/1] slirp: add SOCKS5 support

2017-04-03 Thread Laurent Vivier
This patch implements the SOCKS5 client part for "-net user" backend. It allows to route all internet traffic of the virtual machine to a SOCKS5 server. But all the local traffic (to the host) is sent to the host. It is needed because this SOCKS5 client doesn't route UDP traffic, and this allows

[Qemu-devel] [Bug 1678466] Re: using x-vga=on with vfio-pci leads to segfault

2017-04-03 Thread sh-dvl
well but even if it's unsupported it shouldn't segfault... the other card is nearly the same this one is a GeForce 7300 GS, the other a GeForce 7300 GT I think, the above output was done with "lspci -vv", but I've do it again: lspci -vv for the "bad card" is: 01:00.0 VGA compatible controller: N

Re: [Qemu-devel] [PATCH v1 1/3] applesmc: cosmetic whitespace and indentation cleanup

2017-04-03 Thread Philippe Mathieu-Daudé
On 04/03/2017 06:12 PM, Gabriel L. Somlo wrote: On Mon, Apr 03, 2017 at 10:34:09AM -0300, Philippe Mathieu-Daudé wrote: Hi Gabriel, On 03/31/2017 01:48 PM, Gabriel L. Somlo wrote: Signed-off-by: Gabriel Somlo --- hw/misc/applesmc.c | 100 +++--

Re: [Qemu-devel] [PATCH v1 1/3] applesmc: cosmetic whitespace and indentation cleanup

2017-04-03 Thread Gabriel L. Somlo
On Mon, Apr 03, 2017 at 10:34:09AM -0300, Philippe Mathieu-Daudé wrote: > Hi Gabriel, > > On 03/31/2017 01:48 PM, Gabriel L. Somlo wrote: > > Signed-off-by: Gabriel Somlo > > --- > > hw/misc/applesmc.c | 100 > > +++-- > > 1 file changed, 51 inser

Re: [Qemu-devel] [PATCH v10 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-04-03 Thread ashish mittal
On Mon, Apr 3, 2017 at 8:11 AM, Stefan Hajnoczi wrote: > On Fri, Mar 31, 2017 at 11:25:02AM -0700, ashish mittal wrote: >> On Mon, Mar 27, 2017 at 6:04 PM, ashish mittal wrote: >> > On Mon, Mar 27, 2017 at 10:27 AM, Stefan Hajnoczi >> > wrote: >> >> On Sun, Mar 26, 2017 at 07:50:35PM -0700, Ash

Re: [Qemu-devel] MTD timeout on bootup

2017-04-03 Thread Alistair Francis
> -Original Message- > From: James Hanley [mailto:jhan...@dgtlrift.com] > Sent: Friday, 31 March 2017 8:29 AM > To: Alistair Francis ; Peter Crosthwaite > ; qemu-devel > Subject: MTD timeout on bootup > > When trying to bootup a pristine zync image from the zc702 tarball, it would > alway

Re: [Qemu-devel] [RFC 03/19] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE

2017-04-03 Thread Eduardo Habkost
On Mon, Apr 03, 2017 at 10:15:44PM +0200, Alexander Graf wrote: > > > On 03.04.17 22:10, Eduardo Habkost wrote: > > On Mon, Apr 03, 2017 at 08:49:16PM +0100, Peter Maydell wrote: > > > On 1 April 2017 at 01:46, Eduardo Habkost wrote: > > > > commit 33cd52b5d7b9adfd009e95f07e6c64dd88ae2a31 unset

Re: [Qemu-devel] [PATCH 01/51] ram: Update all functions comments

2017-04-03 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Peter Xu (pet...@redhat.com) wrote: >> Hi, Juan, >> >> Got several nitpicks below... (along with some questions) >> >> On Thu, Mar 23, 2017 at 09:44:54PM +0100, Juan Quintela wrote: >> >> [...] > >> > @@ -1157,11 +1186,12 @@ static bool get_queued_page(Migrat

Re: [Qemu-devel] [Qemu-block] Making QMP 'block-job-cancel' transactionable

2017-04-03 Thread Eric Blake
On 04/03/2017 03:29 PM, John Snow wrote: > > > On 03/24/2017 08:34 AM, Kashyap Chamarthy wrote: >> While debugging some other issue, I happened to stumble across an old >> libvirt commit[*] that adds support for pivot (whether QEMU should >> switch to a target copy or not) operation as a result o

Re: [Qemu-devel] [Qemu-block] Making QMP 'block-job-cancel' transactionable

2017-04-03 Thread John Snow
On 03/24/2017 08:34 AM, Kashyap Chamarthy wrote: > While debugging some other issue, I happened to stumble across an old > libvirt commit[*] that adds support for pivot (whether QEMU should > switch to a target copy or not) operation as a result of issuing QMP > 'block-job-cancel' to a 'drive-mir

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.9 0/2] block/mirror: Fix use-after-free

2017-04-03 Thread John Snow
On 04/03/2017 01:51 PM, Max Reitz wrote: > And the exciting 2.9 ride continues! > > When mirroring from a BDS with no parents at all (such as those added > with -blockdev or blockdev-add), we have a use-after-free in mirror's > error path. The first patch of this series fixes that, the other add

Re: [Qemu-devel] [RFC 03/19] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE

2017-04-03 Thread Alexander Graf
On 03.04.17 22:10, Eduardo Habkost wrote: On Mon, Apr 03, 2017 at 08:49:16PM +0100, Peter Maydell wrote: On 1 April 2017 at 01:46, Eduardo Habkost wrote: commit 33cd52b5d7b9adfd009e95f07e6c64dd88ae2a31 unset cannot_instantiate_with_device_add_yet in TYPE_SYSBUS, making all kinds of untested

Re: [Qemu-devel] [PATCH v2 1/1] qga: Add 'guest-get-users' command

2017-04-03 Thread Eric Blake
On 04/03/2017 03:08 PM, Vinzenz 'evilissimo' Feenstra wrote: > From: Vinzenz Feenstra > > A command that will list all currently logged in users, and the time > since when they are logged in. > > Examples: > > virsh # qemu-agent-command F25 '{ "execute": "guest-get-users" }' > {"return":[{"logi

Re: [Qemu-devel] [RFC 03/19] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE

2017-04-03 Thread Eduardo Habkost
On Mon, Apr 03, 2017 at 08:49:16PM +0100, Peter Maydell wrote: > On 1 April 2017 at 01:46, Eduardo Habkost wrote: > > commit 33cd52b5d7b9adfd009e95f07e6c64dd88ae2a31 unset > > cannot_instantiate_with_device_add_yet in TYPE_SYSBUS, making > > all kinds of untested devices available to -device and >

[Qemu-devel] [PATCH v2 1/1] qga: Add 'guest-get-users' command

2017-04-03 Thread Vinzenz 'evilissimo' Feenstra
From: Vinzenz Feenstra A command that will list all currently logged in users, and the time since when they are logged in. Examples: virsh # qemu-agent-command F25 '{ "execute": "guest-get-users" }' {"return":[{"login-time":1490622289.903835,"user":"root"}]} virsh # qemu-agent-command Win2k12r

[Qemu-devel] [PATCH v2 0/1] qga: Add 'guest-get-users' command

2017-04-03 Thread Vinzenz 'evilissimo' Feenstra
From: Vinzenz Feenstra Changes since v1: - fixed spelling issues in the commit message and schema - added login-time field which specifies the time the users logged on - applied changes suggested for glib hash table usage - added new link time library dependency for wtsapi32 - setting now _WIN32_

Re: [Qemu-devel] [RFC 13/19] unimplemented-device: Remove user_creatable flag

2017-04-03 Thread Eduardo Habkost
On Mon, Apr 03, 2017 at 08:42:12PM +0100, Peter Maydell wrote: > On 3 April 2017 at 19:30, Eduardo Habkost wrote: > > On Mon, Apr 03, 2017 at 03:08:06PM +0100, Peter Maydell wrote: > >> On 3 April 2017 at 14:54, Eduardo Habkost wrote: > >> > This, on the other hand, currently works: > >> > $ qe

[Qemu-devel] [PULL 4/6] nbd: fix memory leak on socket_connect failed

2017-04-03 Thread Paolo Bonzini
From: yaolujing When TCP connection fails between nbd server and client, the local var, sioc, memory leak. This patch fixes the memory leak. Signed-off-by: yaolujing Reviewed-by: Eric Blake Message-Id: <1491005709-29989-1-git-send-email-yaoluj...@huawei.com> Signed-off-by: Paolo Bonzini ---

Re: [Qemu-devel] [RFC 03/19] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE

2017-04-03 Thread Peter Maydell
On 1 April 2017 at 01:46, Eduardo Habkost wrote: > commit 33cd52b5d7b9adfd009e95f07e6c64dd88ae2a31 unset > cannot_instantiate_with_device_add_yet in TYPE_SYSBUS, making > all kinds of untested devices available to -device and > device_add. > > The problem with that is: setting has_dynamic_sysbus o

[Qemu-devel] [PULL 5/6] exec: revert MemoryRegionCache

2017-04-03 Thread Paolo Bonzini
MemoryRegionCache did not know about virtio support for IOMMUs (because the two features were developed at the same time). Revert MemoryRegionCache to "normal" address_space_* operations for 2.9, as it is simpler than undoing the virtio patches. Signed-off-by: Paolo Bonzini --- exec.c

Re: [Qemu-devel] nbd: Possible regression in 2.9 RCs

2017-04-03 Thread Eric Blake
On 04/03/2017 08:00 AM, Kevin Wolf wrote: >> The question remains whether it is practical not to make an exception. >> As far as I know, libvirt is only guaranteed to support older qemu >> versions, not necessarily future ones. So we should be allowed to break >> existing use cases here until libvi

[Qemu-devel] [PULL 1/6] iscsi: drop unused IscsiAIOCB.qiov field

2017-04-03 Thread Paolo Bonzini
From: Stefan Hajnoczi The IscsiAIOCB.qiov field has been unused since commit 063c3378a9e3c25cc0afac3c72e4823d0621e352 ("block/iscsi: introduce bdrv_co_{readv, writev, flush_to_disk}") back in 2013. Signed-off-by: Stefan Hajnoczi Message-Id: <20170327165005.22038-1-stefa...@redhat.com> Reviewed-

Re: [Qemu-devel] nbd: Possible regression in 2.9 RCs

2017-04-03 Thread Eric Blake
On 04/03/2017 07:39 AM, Max Reitz wrote: >>> As for just allowing the NBD server write access to the device... To me >>> that appears pretty difficult from an implementation perspective. We >>> assert that nobody can write without having requested write access and >>> we make sure that nobody can r

[Qemu-devel] [PULL 3/6] ipmi: Fix macro issues

2017-04-03 Thread Paolo Bonzini
From: Corey Minyard Macro parameters should almost always have () around them when used. llvm reported an error on this. Remove redundant parenthesis and put parenthesis around the entire macros with assignments in case they are used in an expression. Remove some unused macros. Reported in htt

[Qemu-devel] [PULL 6/6] main-loop: Acquire main_context lock around os_host_main_loop_wait.

2017-04-03 Thread Paolo Bonzini
From: "Richard W.M. Jones" When running virt-rescue the serial console hangs from time to time. Virt-rescue runs an ordinary Linux kernel "appliance", but there is only a single idle process running inside, so the qemu main loop is largely idle. With virt-rescue >= 1.37 you may be able to observ

[Qemu-devel] [PULL 0/6] Misc patches for QEMU 2.9.0-rc3

2017-04-03 Thread Paolo Bonzini
The following changes since commit 95b31d709ba343ad237c3630047ee7438bac4065: Merge remote-tracking branch 'remotes/awilliam/tags/vfio-updates-20170331.0' into staging (2017-03-31 18:06:13 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream fo

[Qemu-devel] [PULL 2/6] target-i386: fix "info lapic" segfault on isapc

2017-04-03 Thread Paolo Bonzini
From: Tejaswini Poluri Start QEMU with "qemu-system-x86_64 -nographic -M isapc -serial none-monitor stdio" and enter "info lapic" at the monitor prompt ⇒ Segmentation fault Signed-off-by: Tejaswini Poluri Message-Id: <1490685583-16987-1-git-send-email-tejaswinipolu...@gmail.com> Signed-off-by

Re: [Qemu-devel] [RFC 13/19] unimplemented-device: Remove user_creatable flag

2017-04-03 Thread Peter Maydell
On 3 April 2017 at 19:30, Eduardo Habkost wrote: > On Mon, Apr 03, 2017 at 03:08:06PM +0100, Peter Maydell wrote: >> On 3 April 2017 at 14:54, Eduardo Habkost wrote: >> > This, on the other hand, currently works: >> > $ qemu-system-x86_64 -M q35 -device >> > unimplemented-device,size=1024,name

Re: [Qemu-devel] [PATCH 0/7] Provide support for the software TPM emulator

2017-04-03 Thread Patrick Ohly
On Mon, 2017-04-03 at 18:38 +0100, Dr. David Alan Gilbert wrote: > Or you could just remove the spawning code and use existing sockets; less > code! That would be harder to use reliably in the automated testing that this feature is targeting. With this mechanism, it is guaranteed that both proce

Re: [Qemu-devel] [PATCH for-2.9 2/2] iotests: Add mirror tests for orphaned source

2017-04-03 Thread Eric Blake
On 04/03/2017 12:51 PM, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/041| 46 > +++ > tests/qemu-iotests/041.out| 4 ++-- > tests/qemu-iotests/iotests.py | 15 ++ > 3 files changed, 63 insertions(+), 2 del

[Qemu-devel] [Bug 1679126] Re: null pointer access on migration resume of systemrescuecd boot menu with qxl-vga

2017-04-03 Thread Dr. David Alan Gilbert
I think this is actually anything that's in text mode grub; I've had a RHEL5 and 6 VM do it as well. Thanks for reporting it. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1679126 Title: null poin

Re: [Qemu-devel] [PATCH 7/7] Added support for TPM emulator

2017-04-03 Thread Eric Blake
On 03/31/2017 08:10 AM, Amarnath Valluri wrote: > This change introduces a new TPM backend driver that can communicates with > swtpm(software TPM emulator) using unix domain socket interface. > > Swtpm uses two unix sockets, one for plain TPM commands and responses, and one > for out-of-band contr

Re: [Qemu-devel] [PATCH 5/7] tmp backend: Add new api to read backend tpm options

2017-04-03 Thread Eric Blake
On 03/31/2017 08:10 AM, Amarnath Valluri wrote: > TPM configuration options are backend implementation details and shall not be > part of base TPMBackend object, and these shall not be accessed directly > outside > of the class, hence added a new tpm backend api, tpm_backend_get_tpm_options() > to

Re: [Qemu-devel] [RFC 02/19] s390: Add FIXME for unexplained user_creatable=false line

2017-04-03 Thread Eduardo Habkost
On Mon, Apr 03, 2017 at 10:55:38AM +0200, Cornelia Huck wrote: > On Fri, 31 Mar 2017 21:46:07 -0300 > Eduardo Habkost wrote: > > > TYPE_S390_PCI_HOST_BRIDGE has user_creatable=false but has > > no comment explaining why. Add a FIXME to document that. > > > > Cc: Frank Blaschka > > Cc: Cornelia

Re: [Qemu-devel] [PATCH v2 for-2.10 09/16] block/qcow2: Generalize preallocate()

2017-04-03 Thread Philippe Mathieu-Daudé
Hi Max, On 04/03/2017 01:09 PM, Max Reitz wrote: This patch adds two new parameters to the preallocate() function so we will be able to use it not just for preallocating a new image but also for preallocated image growth. The offset parameter allows the caller to specify a virtual offset from w

Re: [Qemu-devel] [PATCH v2 2/3] libqtest: Add a generic function to run a callback function for every machine

2017-04-03 Thread Philippe Mathieu-Daudé
On 03/30/2017 04:50 AM, Thomas Huth wrote: Some tests need to run single tests for every available machine of the current QEMU binary. To avoid code duplication, let's extract this code that deals with 'query-machines' into a separate function. Signed-off-by: Thomas Huth Reviewed-by: Philippe

Re: [Qemu-devel] hitting intermittent issue with live migration from qemu-kvm-ev 2.3.0 to qemu-kvm-ev 2.6.0

2017-04-03 Thread Stefan Hajnoczi
On Fri, Mar 31, 2017 at 02:12:36PM -0600, Chris Friesen wrote: > I'm running into an issue with live-migrating a guest from a host running > qemu-kvm-ev 2.3.0-31 to a host running qemu-kvm-ev 2.6.0-27.1. This is a > libvirt-tunnelled migration, in the context of upgrading an OpenStack > install to

Re: [Qemu-devel] [PATCH v2 for-2.10 07/16] block/file-posix: Generalize raw_regular_truncate

2017-04-03 Thread Philippe Mathieu-Daudé
On 04/03/2017 01:09 PM, Max Reitz wrote: Currently, raw_regular_truncate() is intended for setting the size of a newly created file. However, we also want to use it for truncating an existing file in which case only the newly added space (when growing) should be preallocated. This also means tha

Re: [Qemu-devel] [PATCH v2 1/3] libqtest: Ignore QMP events when parsing the response for HMP commands

2017-04-03 Thread John Snow
On 03/30/2017 03:50 AM, Thomas Huth wrote: > When running certain HMP commands (like "device_del") via QMP, we > can sometimes get a QMP event in the response first, so that the > "g_assert(ret)" statement in qtest_hmp() triggers and the test > fails. Fix this by ignoring such QMP events while lo

Re: [Qemu-devel] [PATCH for-2.9 4/5] rbd: Peel off redundant RbdAuthMethod wrapper struct

2017-04-03 Thread Eric Blake
On 04/03/2017 06:25 AM, Daniel P. Berrange wrote: > On Mon, Mar 27, 2017 at 07:58:51AM +0200, Markus Armbruster wrote: >> = What to do for 2.9 = >> >> I propose to >> >> * drop both "auth_supported" and "password-secret" from the QAPI schema >> >> * drop "password-secret" from QemuOpts >> >> * hide

Re: [Qemu-devel] [PATCH v2 for-2.10 06/16] block/file-posix: Extract raw_regular_truncate()

2017-04-03 Thread Philippe Mathieu-Daudé
On 04/03/2017 01:09 PM, Max Reitz wrote: This functionality is part of raw_create() which we will be able to reuse nicely in raw_truncate(). Signed-off-by: Max Reitz Reviewed-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Daudé --- block/file-posix.c | 144

Re: [Qemu-devel] [PATCH v2 for-2.10 05/16] block/file-posix: Small fixes in raw_create()

2017-04-03 Thread Philippe Mathieu-Daudé
On 04/03/2017 01:09 PM, Max Reitz wrote: Variables should be declared at the start of a block, and if a certain parameter value is not supported it may be better to return -ENOTSUP instead of -EINVAL. Signed-off-by: Max Reitz Reviewed-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Daudé

Re: [Qemu-devel] [PATCH v4] Allow setting NUMA distance for different NUMA nodes

2017-04-03 Thread Eric Blake
On 04/03/2017 03:38 AM, Andrew Jones wrote: > On Sat, Apr 01, 2017 at 06:25:26PM +0800, He Chen wrote: >> Current, QEMU does not provide a clear command to set vNUMA distance for >> guest although we already have `-numa` command to set vNUMA nodes. >> >> +++ b/qapi-schema.json >> @@ -5644,10 +5644

Re: [Qemu-devel] nbd: Possible regression in 2.9 RCs

2017-04-03 Thread Kashyap Chamarthy
On Fri, Mar 31, 2017 at 05:49:52PM +, Ciprian Barbu wrote: > Hi, [...] > We also use libvirt v1.3.4, which might be a problem, but at least we > want to understand if the commit in question introduced an obvious > problem or if it's all in the details. A tangential question -- Just curious,

Re: [Qemu-devel] [PATCH v5 3/5] slirp: Common lhost/fhost union

2017-04-03 Thread Philippe Mathieu-Daudé
On 04/03/2017 02:18 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" The socket structure has a pair of unions for lhost and fhost addresses; the unions are identical so split them out into a separate union declaration. Signed-off-by: Dr. David Alan Gilbert Reviewed-by

Re: [Qemu-devel] [PATCH for-2.9 1/2] block/mirror: Fix use-after-free

2017-04-03 Thread Philippe Mathieu-Daudé
nice analysis/catch On 04/03/2017 02:51 PM, Max Reitz wrote: If @bs does not have any parents, the only reference to @mirror_top_bs will be held by the BlockJob object after the bdrv_unref() following block_job_create(). However, if block_job_create() fails, this reference will not exist and @mi

Re: [Qemu-devel] [RFC 13/19] unimplemented-device: Remove user_creatable flag

2017-04-03 Thread Eduardo Habkost
On Mon, Apr 03, 2017 at 03:08:06PM +0100, Peter Maydell wrote: > On 3 April 2017 at 14:54, Eduardo Habkost wrote: > > On Mon, Apr 03, 2017 at 02:38:15PM +0100, Peter Maydell wrote: > >> On 3 April 2017 at 14:34, Eduardo Habkost wrote: > >> >> Wouldn't it be better to just not add that, rather tha

Re: [Qemu-devel] [PATCH] win32: replace custom mutex and condition variable with native primitives

2017-04-03 Thread Andrew Baumann via Qemu-devel
> From: Cornelia Huck [mailto:cornelia.h...@de.ibm.com] > Sent: Monday, 3 April 2017 7:20 > > On Fri, 24 Mar 2017 15:01:41 -0700 > Andrew Baumann wrote: > > > From: Andrey Shedel > > > > The multithreaded TCG implementation exposed deadlocks in the win32 > > condition variables: as implemented,

Re: [Qemu-devel] Project idea

2017-04-03 Thread Stefan Hajnoczi
On Fri, Mar 31, 2017 at 09:20:31PM +0300, Mihai-Drosi Caju wrote: > I'd be interested in submitting the following ideas: > I'd like to enchance qemu's debugging capabilities. > I was thinking to add an option to qemu to disable cpu reset on > tripple-fault. > Or adding support for breakpoints in th

Re: [Qemu-devel] Raspberry PI

2017-04-03 Thread John Snow
On 04/02/2017 03:59 PM, John Bradley via Qemu-devel wrote: > Hi, > I've just pulled together a collection of patches from various sources to get > the Raspberry PI emulation working on the March 27 source. Is it worth > sending it in as a patch for inclusion. It allows some of the Circle low >

Re: [Qemu-devel] [PATCH] tests/libqtest.c: Delete possible stale unix sockets

2017-04-03 Thread Stefan Hajnoczi
On Fri, Mar 31, 2017 at 01:36:41PM +0100, Peter Maydell wrote: > Occasionally if a test crashes or is interrupted by the user > at the wrong moment it could leave behind a stale UNIX > socket in /tmp/. This will then cause a subsequent test > run to fail spuriously with > tests/libqtest.c:70:init_

[Qemu-devel] [PATCH for-2.9 1/2] block/mirror: Fix use-after-free

2017-04-03 Thread Max Reitz
If @bs does not have any parents, the only reference to @mirror_top_bs will be held by the BlockJob object after the bdrv_unref() following block_job_create(). However, if block_job_create() fails, this reference will not exist and @mirror_top_bs will have been deleted when we goto fail. The issue

[Qemu-devel] [PATCH for-2.9 2/2] iotests: Add mirror tests for orphaned source

2017-04-03 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/qemu-iotests/041| 46 +++ tests/qemu-iotests/041.out| 4 ++-- tests/qemu-iotests/iotests.py | 15 ++ 3 files changed, 63 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/041 b/tests/q

[Qemu-devel] [PATCH for-2.9 0/2] block/mirror: Fix use-after-free

2017-04-03 Thread Max Reitz
And the exciting 2.9 ride continues! When mirroring from a BDS with no parents at all (such as those added with -blockdev or blockdev-add), we have a use-after-free in mirror's error path. The first patch of this series fixes that, the other adds a patch so we don't regress. What issue will we fi

Re: [Qemu-devel] [PATCH v5 0/5 for 2.10] SLIRP VMStatification

2017-04-03 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170403171843.3363-1-dgilb...@redhat.com Type: series Subject: [Qemu-devel] [PATCH v5 0/5 for 2.10] SLIRP VMStatification === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

Re: [Qemu-devel] [PATCH 0/7] Provide support for the software TPM emulator

2017-04-03 Thread Dr. David Alan Gilbert
* Patrick Ohly (patrick.o...@intel.com) wrote: > On Mon, 2017-04-03 at 18:07 +0100, Daniel P. Berrange wrote: > > On Fri, Mar 31, 2017 at 04:10:09PM +0300, Amarnath Valluri wrote: > > > Briefly, Theses set of patches introduces: > > > - new TPM backend driver to support software TPM emulators(swtp

Re: [Qemu-devel] [PATCH 0/7] Provide support for the software TPM emulator

2017-04-03 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Fri, Mar 31, 2017 at 04:10:09PM +0300, Amarnath Valluri wrote: > > Briefly, Theses set of patches introduces: > > - new TPM backend driver to support software TPM emulators(swtpm(1)). > > - and few supported fixes/enhancements/cleanup to exis

Re: [Qemu-devel] [PATCH 0/7] Provide support for the software TPM emulator

2017-04-03 Thread Patrick Ohly
On Mon, 2017-04-03 at 18:07 +0100, Daniel P. Berrange wrote: > On Fri, Mar 31, 2017 at 04:10:09PM +0300, Amarnath Valluri wrote: > > Briefly, Theses set of patches introduces: > > - new TPM backend driver to support software TPM emulators(swtpm(1)). > > - and few supported fixes/enhancements/clea

Re: [Qemu-devel] [RFC 16/19] generic-sdhci: Remove user_creatable flag

2017-04-03 Thread Alistair Francis
On Fri, Mar 31, 2017 at 5:46 PM, Eduardo Habkost wrote: > generic-sdhci needs to be wired by other devices' code, so it > can't be used with -device. Remove the user_creatable flag from > the device class. > > Cc: Peter Maydell > Cc: "Edgar E. Iglesias" > Cc: David Gibson > Cc: Alexander Graf

[Qemu-devel] [PATCH v5 4/5] slirp: VMStatify socket level

2017-04-03 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Working up the stack, this replaces the slirp_socket_load/save with VMState definitions. A place holder for IPv6 support is added as a comment; it needs testing once the rest of the IPv6 code is there. Signed-off-by: Dr. David Alan Gilbert --- slirp/slirp.c | 2

[Qemu-devel] [PATCH v5 0/5 for 2.10] SLIRP VMStatification

2017-04-03 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Hi, Another crack at slirp vmstatification; v5 fixes the type and value portability issues in the ss_family field. It now always sends this as a 16bit field and always uses Linux's AF_INET or AF_INET6 value on writing. It'll also accept Windows and FreeBSDs va

[Qemu-devel] [PATCH v5 5/5] slirp: VMStatify remaining except for loop

2017-04-03 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" This converts the remaining components, except for the top level loop, to VMState. Signed-off-by: Dr. David Alan Gilbert --- slirp/slirp.c | 48 +++- 1 file changed, 19 insertions(+), 29 deletions(-) diff --git a/slirp

[Qemu-devel] [PATCH v5 3/5] slirp: Common lhost/fhost union

2017-04-03 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The socket structure has a pair of unions for lhost and fhost addresses; the unions are identical so split them out into a separate union declaration. Signed-off-by: Dr. David Alan Gilbert --- slirp/socket.h | 18 -- 1 file changed, 8 insertions(+

Re: [Qemu-devel] [RFC 10/19] sysbus-ahci: Remove user_creatable flag

2017-04-03 Thread Alistair Francis
On Fri, Mar 31, 2017 at 5:46 PM, Eduardo Habkost wrote: > The sysbus-ahci devices are supposed to be created and wired by > code from other devices, like calxeda_init() and > xlnx_zynqmp_realize(), and won't work with -device. Remove the > user_creatable flag from the device class. > > Cc: John Sn

[Qemu-devel] [PATCH v5 1/5] slirp: VMState conversion; tcpcb

2017-04-03 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Convert the migration of the struct tcpcb to use a VMStateDescription, the rest of it will come later. Mostly mechanical, except for conversion of some 'char' to uint8_t to ensure portability. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Samuel Thibault Re

[Qemu-devel] [PATCH v5 2/5] slirp: VMStatify sbuf

2017-04-03 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Convert the sbuf structure to a VMStateDescription. Note this uses the VMSTATE_WITH_TMP mechanism to calculate and reload the offsets based on the pointers. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: David Gibson Reviewed-by: Juan Quintela Acked-by: Samu

Re: [Qemu-devel] [PATCH 0/7] Provide support for the software TPM emulator

2017-04-03 Thread Marc-André Lureau
Hi On Mon, Apr 3, 2017 at 7:08 PM Daniel P. Berrange wrote: > On Fri, Mar 31, 2017 at 04:10:09PM +0300, Amarnath Valluri wrote: > > Briefly, Theses set of patches introduces: > > - new TPM backend driver to support software TPM emulators(swtpm(1)). > > - and few supported fixes/enhancements/cl

Re: [Qemu-devel] [RFC 01/19] qdev: Replace cannot_instantiate_with_device_add_yet with !user_creatable

2017-04-03 Thread Alistair Francis
On Fri, Mar 31, 2017 at 5:46 PM, Eduardo Habkost wrote: > cannot_instantiate_with_device_add_yet was introduced by commit > 837d37167dc446af8a91189108b363c04609e296 to replace no_user. It > was supposed to be a temporary measure. > > When it was introduced, we had 54 > cannot_instantiate_with_devi

Re: [Qemu-devel] [PATCH 0/7] Provide support for the software TPM emulator

2017-04-03 Thread Daniel P. Berrange
On Fri, Mar 31, 2017 at 04:10:09PM +0300, Amarnath Valluri wrote: > Briefly, Theses set of patches introduces: > - new TPM backend driver to support software TPM emulators(swtpm(1)). > - and few supported fixes/enhancements/cleanup to existing tpm backend code. > > The similar idea was initiated

Re: [Qemu-devel] [RFC PATCH v1 0/9] MTTCG and record/replay fixes for rc3

2017-04-03 Thread Paolo Bonzini
On 03/04/2017 14:45, Alex Bennée wrote: > cpus: check cpu->running in cpu_get_icount_raw() > > I'm not sure the race happens and once outside of cpu->running the > icount counters should be zero. However it seems a sensible > precaution. Yeah, I think this is unnecessary with patch 7's

Re: [Qemu-devel] [RFC PATCH v1 8/9] cpus: don't credit executed instructions before they have run

2017-04-03 Thread Paolo Bonzini
On 03/04/2017 14:45, Alex Bennée wrote: > Outside of the vCPU thread icount time will only be tracked against > timers_state.qemu_icount. We no longer credit cycles until they have > completed the run. Inside the vCPU thread we adjust for passage of > time by looking at how many have run so far.

Re: [Qemu-devel] [RfC PATCH 0/4] make display updates thread safe.

2017-04-03 Thread Paolo Bonzini
On 03/04/2017 14:03, Gerd Hoffmann wrote: > We might clear some more bits, but these are > outsize the visible area so they should cause visible corruption (and if > the visible area changes the display code needs to do a full refresh > anyway). True, though this makes the snapshot abstraction a

Re: [Qemu-devel] [PATCH 1/7] tpm-backend: Remove unneeded member variable from backend class

2017-04-03 Thread Marc-André Lureau
Hi On Fri, Mar 31, 2017 at 4:58 PM Amarnath Valluri wrote: > TPMDriverOps inside TPMBackend is not required, as it is supposed to be a > class > member. The only possible reason for keeping in TPMBackend was, to get the > backend type in tpm.c where dedicated backend api, tpm_backend_get_type()

Re: [Qemu-devel] [Qemu-block] New iotest repros failures on virtio external snapshot with iothread

2017-04-03 Thread Stefan Hajnoczi
On Wed, Mar 29, 2017 at 07:01:38PM -0700, Ed Swierk wrote: > Parts of qemu's block code have changed a lot in recent months but are > not well exercised by current tests. > > Subtle bugs have crept in causing assertion failures, hangs and other > crashes in a variety of situations: immediately on

Re: [Qemu-devel] [PATCH for-2.9] configure: on Windows minimum glib version must be 2.30

2017-04-03 Thread Stefan Weil
Am 03.04.2017 um 15:04 schrieb Peter Maydell: In the 2.7 release we stated in the ChangeLog that the minimum glib version for Windows hosts was 2.30, but we didn't update configure to enforce this because we were very close to the release at the point where we noticed the issue, and it only affec

Re: [Qemu-devel] LEON3 timer patch

2017-04-03 Thread Fabien Chouteau
On 30/03/2017 21:30, Gabriele Galeotti wrote: > > Hi all. > According to "GR712RC Dual-Core LEON3FT SPARC V8 Processor User’s Manual", > "11.3 Registers", pg 87-88, Table 55 Timer control register, the IP > "interrupt pending" > bit: > > Interrupt Pending (IP): The core sets this bit to ‘1’ when

Re: [Qemu-devel] [PULL 00/15] Block patches for rc3

2017-04-03 Thread Peter Maydell
On 3 April 2017 at 16:33, Max Reitz wrote: > The following changes since commit 102a3d847891f48c0b13cace19d189217b05a725: > > usb-host: switch to LIBUSB_API_VERSION (2017-04-03 14:41:23 +0100) > > are available in the git repository at: > > git://github.com/XanClic/qemu.git tags/pull-block-201

  1   2   3   >