Re: [Qemu-devel] [PULL 6/6] MAINTAINERS: Remove obsolete stable branches

2017-01-09 Thread Thomas Huth
On 10.01.2017 04:32, Michael S. Tsirkin wrote: > On Thu, Nov 10, 2016 at 11:11:43AM +0100, Thomas Huth wrote: >> There are only very old and orphaned stable branches listed >> in the MAINTAINERS file - so this section is pretty useless >> nowadays. Let's remove it. >> >> Reviewed-by: John Snow >>

Re: [Qemu-devel] [PATCH] hw/ppc/spapr: Allow POWER9 as hot-pluggable CPU for pseries

2017-01-09 Thread Thomas Huth
On 10.01.2017 01:39, David Gibson wrote: > On Mon, Jan 09, 2017 at 01:57:24PM +0100, Thomas Huth wrote: >> Running "qemu-system-ppc64 -M pseries -cpu POWER9" currently does not work >> yet and results in this error message: >> >> qemu-system-ppc64: Unable to find sPAPR CPU Core definition >> >> Si

[Qemu-devel] [Bug 1654826] Re: Holding key down using input-linux freezes guest

2017-01-09 Thread mutedbytes
I have tried without "repeat=on" option, and with 2.8.0 I still seem to be getting weird behavior with mouse dropping out at points, and with keys seemingly being continued to be pressed (ie still running around in an fps game after releasing the key). I also experienced at one point l-ctrl+r-ctrl

Re: [Qemu-devel] [PULL v2 00/11] ui patch queue

2017-01-09 Thread Gerd Hoffmann
Hi, > > git://git.kraxel.org/qemu tags/pull-ui-20170109-1 > Hi. I'm afraid this fails to build on OSX: > > /Users/pm215/src/qemu-for-merges/ui/cocoa.m:688:21: error: use of > undeclared identifier 'MOUSE_EVENT_WHEELUP' > MOUSE

[Qemu-devel] [PATCH] x86: add AVX512_VPOPCNTDQ features

2017-01-09 Thread He Chen
AVX512_VPOPCNTDQ: Vector POPCNT instructions for word and qwords. variable precision. Signed-off-by: He Chen --- target/i386/cpu.c | 2 +- target/i386/cpu.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index b0640f1..ae900b5 100644 --

Re: [Qemu-devel] [PATCH v6 kernel 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration

2017-01-09 Thread Li, Liang Z
Hi guys, Could you help to review this patch set? Thanks! Liang > -Original Message- > From: Li, Liang Z > Sent: Wednesday, December 21, 2016 2:52 PM > To: k...@vger.kernel.org > Cc: virtio-...@lists.oasis-open.org; qemu-devel@nongnu.org; linux- > m...@kvack.org; linux-ker...@vger.kernel

[Qemu-devel] [PULL 40/41] memhp: move DIMM devices into dedicated scope with related common methods

2017-01-09 Thread Michael S. Tsirkin
From: Igor Mammedov Move DIMM devices from global _SB scope to a new \_SB.MHPC container along with common methods used by DIMMs: MCRS, MRST, MPXM, MOST, MEJ00, MSCN, MTFY this reduces AML size on 12 * #slots bytes, i.e. up to 3072 bytes for 265 slots. Signed-off-by: Igor Mammedov Reviewed-b

[Qemu-devel] [PULL 39/41] memhp: don't generate memory hotplug AML if it's not enabled/supported

2017-01-09 Thread Michael S. Tsirkin
From: Igor Mammedov That reduces DSDT by 910 bytes when memory hotplug isn't enabled. While doing so drop intermediate variables/arguments passing around ACPI_MEMORY_HOTPLUG_IO_LEN and making it local to memory_hotplug.c, hardcoding it there as it can't change. Also don't pass around ACPI_MEMOR

Re: [Qemu-devel] Live migration + cpu/mem hotplug

2017-01-09 Thread Bob Chen
Answer my own question: The corresponding cmd-line parameter for memory hot-add by QEMU monitor is, -object memory-backend-ram,id=mem0,size=1024M -device pc-dimm,id=dimm0,memdev=mem0 2017-01-05 18:12 GMT+08:00 Daniel P. Berrange : > On Thu, Jan 05, 2017 at 04:27:26PM +0800, Bob Chen wrote: > > H

[Qemu-devel] [PULL 30/41] vhost-net: Notify the backend about the host MTU

2017-01-09 Thread Michael S. Tsirkin
From: Maxime Coquelin This patch provides a way for virtio-net to notify the backend about the host MTU set by the user. Cc: Michael S. Tsirkin Cc: Aaron Conole Signed-off-by: Maxime Coquelin Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/net/vhost_net.h | 2

Re: [Qemu-devel] [PATCH 00/21] new backup architecture

2017-01-09 Thread Jeff Cody
On Mon, Jan 09, 2017 at 11:04:27AM +, Stefan Hajnoczi wrote: > On Fri, Dec 23, 2016 at 05:28:43PM +0300, Vladimir Sementsov-Ogievskiy wrote: > > Jeff or John: are you reviewing this? It's in my review queue, but it would probably be a good one for John to review as well if he has time. > >

[Qemu-devel] [PULL 27/41] virtio: Introduce virtqueue_drop_all procedure

2017-01-09 Thread Michael S. Tsirkin
From: Yuri Benditovich Add procedure for fast drop of queued packets, acting like pop and push without mapping the buffers into memory. Signed-off-by: Yuri Benditovich Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/virtio/virtio.h | 1 + hw/virtio/virtio.c

[Qemu-devel] [PULL 37/41] memhp: move GPE handler_E03 into build_memory_hotplug_aml()

2017-01-09 Thread Michael S. Tsirkin
From: Igor Mammedov >From this patch all the memory hotplug related AML bits are consolidated in one place within DSTD. Follow up patches will utilize that to simplify memory hotplug related C/AML code. Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsir

[Qemu-devel] [PULL 24/41] balloon: Don't balloon roms

2017-01-09 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" A broken guest can specify physical addresses that correspond to any memory region, but it shouldn't be able to change ROM. Signed-off-by: Dr. David Alan Gilbert Cc: qemu-sta...@nongnu.org Acked-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Mi

[Qemu-devel] [PULL 38/41] memhp: move memory hotplug only defines to memory_hotplug.c

2017-01-09 Thread Michael S. Tsirkin
From: Igor Mammedov Move defines used locally only by memory_hotplug.c into it from header files. Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Marcel Apfelbaum --- include/hw/acpi/memory_hotplug.h | 3 --- include/hw/acpi/pc-ho

Re: [Qemu-devel] [PATCH v2] docs: add document to explain the usage of vNVDIMM

2017-01-09 Thread Haozhong Zhang
On 11/21/16 18:38 +0200, Michael S. Tsirkin wrote: On Mon, Nov 21, 2016 at 02:00:23PM +0800, Haozhong Zhang wrote: On 11/09/16 12:35 +, Stefan Hajnoczi wrote: > On Wed, Nov 09, 2016 at 09:04:48AM +0800, Haozhong Zhang wrote: > > Signed-off-by: Haozhong Zhang > > Reviewed-by: Xiao Guangrong

[Qemu-devel] [PULL 36/41] memhp: merge build_memory_devices() into build_memory_hotplug_aml()

2017-01-09 Thread Michael S. Tsirkin
From: Igor Mammedov It consolidates memory hotplug AML in one place within DSDT Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/memory_hotplug.h | 2 -- hw/acpi/memory_hotplug.c | 14 - hw/i386/acpi-build.c

[Qemu-devel] [PULL 35/41] memhp: consolidate scattered MHPD device declaration

2017-01-09 Thread Michael S. Tsirkin
From: Igor Mammedov since static and dynamic parts of memory MHPD device are now in the same table (DSDT), there is no point keeping them scattered across the table, so consolidate it in one place. There aren't any functional change, only AML text movement from externally refferenced MHPD scope

[Qemu-devel] [PULL 23/41] virtio: fix vq->inuse recalc after migr

2017-01-09 Thread Michael S. Tsirkin
From: Halil Pasic Correct recalculation of vq->inuse after migration for the corner case where the avail_idx has already wrapped but used_idx not yet. Also change the type of the VirtQueue.inuse to unsigned int. This is done to be consistent with other members representing sizes (VRing.num), and

[Qemu-devel] [PULL 41/41] acpi-test: update expected files

2017-01-09 Thread Michael S. Tsirkin
clean up warnings after latest hotplug changes. Signed-off-by: Michael S. Tsirkin --- tests/acpi-test-data/pc/DSDT | Bin 6008 -> 5098 bytes tests/acpi-test-data/pc/DSDT.bridge | Bin 7867 -> 6957 bytes tests/acpi-test-data/pc/DSDT.cphp| Bin 6471 -> 5561 bytes tests/acpi-test-data/

[Qemu-devel] [PULL 34/41] memhp: move build_memory_devices() into memory_hotplug.c

2017-01-09 Thread Michael S. Tsirkin
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Marcel Apfelbaum --- include/hw/acpi/memory_hotplug.h | 2 + hw/acpi/memory_hotplug.c | 124 +++ hw/i386/acpi-build.c

[Qemu-devel] [PULL 31/41] virtio-net: Add MTU feature support

2017-01-09 Thread Michael S. Tsirkin
From: Maxime Coquelin This patch allows advising guest with host MTU's by setting host_mtu parameter. If VIRTIO_NET_F_MTU has been successfully negotiated, MTU value is passed to the backend. Cc: Michael S. Tsirkin Cc: Aaron Conole Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Ts

[Qemu-devel] [PULL 21/41] pcie_aer: Convert pcie_aer_init to Error

2017-01-09 Thread Michael S. Tsirkin
From: Cao jin When user specify invalid value for property aer_log_max, device should fail to create, and report appropriate message. Signed-off-by: Cao jin Reviewed-by: Marcel Apfelbaum Acked-by: Dmitry Fleytman Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include

[Qemu-devel] [PULL 33/41] memhp: move build_memory_hotplug_aml() into memory_hotplug.c

2017-01-09 Thread Michael S. Tsirkin
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Marcel Apfelbaum --- hw/acpi/memory_hotplug.c| 247 + hw/acpi/memory_hotplug_acpi_table.c | 262

[Qemu-devel] [PULL 25/41] net: Add virtio queue interface to update used index from vring state

2017-01-09 Thread Michael S. Tsirkin
From: Yuri Benditovich Bring virtio queue to correct internal state for host-to-guest operations when vhost is temporary stopped. Signed-off-by: Yuri Benditovich Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/virtio/virtio.h | 1 + hw/virtio/virtio.c

[Qemu-devel] [PULL 16/41] cryptodev: wrap the ready flag

2017-01-09 Thread Michael S. Tsirkin
From: Gonglei The ready flag should be set by the children of cryptodev backend interface. Warp the setter/getter functions for it. Signed-off-by: Gonglei Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/sysemu/cryptodev.h | 19 +++ backends/cry

[Qemu-devel] [PULL 26/41] net: vhost stop updates virtio queue state

2017-01-09 Thread Michael S. Tsirkin
From: Yuri Benditovich Make virtio queue suitable for push operation from qemu after vhost was stopped. Signed-off-by: Yuri Benditovich Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/vhost.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/virtio/vhost.

[Qemu-devel] [PULL 22/41] pcie_aer: support configurable AER capa version

2017-01-09 Thread Michael S. Tsirkin
From: Dou Liyang Now, AER capa version is fixed to v2, if assigned device isn't v2, then this value will be inconsistent between guest and host Signed-off-by: Dou Liyang Signed-off-by: Cao jin Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pcie_aer.h

[Qemu-devel] [PULL 32/41] tests: pc: add memory hotplug acpi tables tests

2017-01-09 Thread Michael S. Tsirkin
From: Igor Mammedov This also adds SRAT and DSDT blobs for memory hotplug variant Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Marcel Apfelbaum --- tests/bios-tables-test.c| 24 tests/acpi-t

[Qemu-devel] [PULL 11/41] memory: handle alias for iommu notifier

2017-01-09 Thread Michael S. Tsirkin
From: Jason Wang Cc: Paolo Bonzini Acked-by: Paolo Bonzini Signed-off-by: Jason Wang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Peter Xu --- memory.c | 9 + 1 file changed, 9 insertions(+) diff --git a/memory.c b/memory.c index 33110e9..2bfc37f

[Qemu-devel] [PULL 20/41] virtio-crypto: zeroize the key material before free

2017-01-09 Thread Michael S. Tsirkin
From: Gonglei Common practice with sensitive information (key material, passwords, etc). Prevents sensitive information from being exposed by accident later in coredumps, memory disclosure bugs when heap memory is reused, etc. Sensitive information is sometimes also held in mlocked pages to prev

[Qemu-devel] [PULL 13/41] doc/pcie: correct command line examples

2017-01-09 Thread Michael S. Tsirkin
From: Cao jin Nit picking: Multi-function PCI Express Root Ports should mean that 'addr' property is mandatory, and slot is optional because it defaults to 0, and 'chassis' is mandatory for 2nd & 3rd root port because it defaults to 0 too. Bonus: fix a typo(2->3) Signed-off-by: Cao jin Reviewed

[Qemu-devel] [PULL 29/41] vhost-user: Add MTU protocol feature and op

2017-01-09 Thread Michael S. Tsirkin
From: Maxime Coquelin This patch implements VHOST_USER_PROTOCOL_F_NET_MTU protocol feature and VHOST_USER_NET_SET_MTU request so that the backend gets notified of the user defined host MTU. If backend supports VHOST_USER_PROTOCOL_F_REPLY_ACK, QEMU assumes MTU is valid if success is returned. Vh

[Qemu-devel] [PULL 19/41] virtio-crypto-pci: tag virtio-crypto device hot pluggable

2017-01-09 Thread Michael S. Tsirkin
From: Gonglei After resolving the relationship with cryptodev backend, the virtio crypto device supports hotplug now. Signed-off-by: Gonglei Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-crypto-pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/

[Qemu-devel] [PULL 10/41] acpi: add ATSR for q35

2017-01-09 Thread Michael S. Tsirkin
From: Jason Wang This patch provides ATSR which was a requirement for software that wants to enable ATS on endpoint devices behind a Root Port. This is done simply by setting ALL_PORTS which indicates all PCI-Express Root Ports support ATS transactions. Signed-off-by: Jason Wang Reviewed-by: Mi

[Qemu-devel] [PULL 09/41] virtio-pci: address space translation service (ATS) support

2017-01-09 Thread Michael S. Tsirkin
From: Jason Wang This patches enable the Address Translation Service support for virtio pci devices. This is needed for a guest visible Device IOTLB implementation and will be required by vhost device IOTLB API implementation for intel IOMMU. Cc: Michael S. Tsirkin Signed-off-by: Jason Wang Re

[Qemu-devel] [PULL 28/41] net: virtio-net discards TX data after link down

2017-01-09 Thread Michael S. Tsirkin
From: Yuri Benditovich https://bugzilla.redhat.com/show_bug.cgi?id=1295637 Upon set_link monitor command or upon netdev deletion virtio-net sends link down indication to the guest and stops vhost if one is used. Guest driver can still submit data for TX until it recognizes link loss. If these pac

[Qemu-devel] [PULL 15/41] cryptodev: introduce a new is_used property

2017-01-09 Thread Michael S. Tsirkin
From: Gonglei This property is used to Tag the cryptodev backend is used by virtio-crypto or not. Making cryptodev can't be hot unplugged when it's in use. Cleanup resources when cryptodev is finalized. Signed-off-by: Gonglei Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin -

[Qemu-devel] [PULL 06/41] intel_iommu: allocate new key when creating new address space

2017-01-09 Thread Michael S. Tsirkin
From: Jason Wang We use the pointer to stack for key for new address space, this will break hash table searching, fixing by g_malloc() a new key instead. Cc: Michael S. Tsirkin Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Acked-by: Peter Xu Signed-off-by: Jason Wang Reviewed

[Qemu-devel] [PULL 18/41] virtio-crypto: avoid one cryptodev device is used by multiple virtio crypto devices

2017-01-09 Thread Michael S. Tsirkin
From: Gonglei Add the check condition for cryptodev device in order to avoid one cryptodev device is used by multiple virtio crypto devices. Signed-off-by: Gonglei Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-crypto.c | 16 +++- 1 file ch

[Qemu-devel] [PULL 12/41] memory: handle alias in memory_region_is_iommu()

2017-01-09 Thread Michael S. Tsirkin
From: Jason Wang Cc: Paolo Bonzini Acked-by: Paolo Bonzini Signed-off-by: Jason Wang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Peter Xu --- include/exec/memory.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/exec/memory.h b/include/exec

[Qemu-devel] [PULL 04/41] virtio: convert to use DMA api

2017-01-09 Thread Michael S. Tsirkin
From: Jason Wang Currently, all virtio devices bypass IOMMU completely. This is because address_space_memory is assumed and used during DMA emulation. This patch converts the virtio core API to use DMA API. This idea is - introducing a new transport specific helper to query the dma address spa

[Qemu-devel] [PULL 05/41] intel_iommu: name vtd address space with devfn

2017-01-09 Thread Michael S. Tsirkin
From: Jason Wang To avoid duplicated name and ease debugging. Cc: Michael S. Tsirkin Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Acked-by: Peter Xu Signed-off-by: Jason Wang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/intel_iommu.c | 4 +

[Qemu-devel] [PULL 17/41] virtio-crypto-pci: add check for cryptodev object

2017-01-09 Thread Michael S. Tsirkin
From: Gonglei We must assure each virtio crypto pci device has an vaild cryptodev backend object. Signed-off-by: Gonglei Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-crypto-pci.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/virtio/virt

[Qemu-devel] [PULL 03/41] virtio-crypto: fix possible integer and heap overflow

2017-01-09 Thread Michael S. Tsirkin
From: Gonglei Because the 'size_t' type is 4 bytes in 32-bit platform, which is the same with 'int'. It's easy to make 'max_len' to zero when integer overflow and then cause heap overflow if 'max_len' is zero. Using uint_64 instead of size_t to avoid the integer overflow. Cc: qemu-sta...@nongnu

[Qemu-devel] [PULL 08/41] intel_iommu: support device iotlb descriptor

2017-01-09 Thread Michael S. Tsirkin
From: Jason Wang This patch enables device IOTLB support for intel iommu. The major work is to implement QI device IOTLB descriptor processing and notify the device through iommu notifier. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: Michael S. Tsirkin Signed-off-by: Jason

[Qemu-devel] [PULL 00/41] virtio, vhost, pc: fixes, features

2017-01-09 Thread Michael S. Tsirkin
The following changes since commit 77424a452abe5f941d8cd81f1e85f42bca31c9ef: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2017-01-09 15:30:45 +) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream fo

[Qemu-devel] [PULL 14/41] virtio-crypto: use the correct length for cipher operation

2017-01-09 Thread Michael S. Tsirkin
From: Gonglei In some modes of cipher algorithms, the length of destination data maybe larger then source data, such as ciphertext stealing (CTS). For symmetric algorithms, the length of ciphertext is definitly equal to the plaintext for each crypto operation. So we should use the src_len instea

[Qemu-devel] [PULL 07/41] exec: introduce address_space_get_iotlb_entry()

2017-01-09 Thread Michael S. Tsirkin
From: Jason Wang This patch introduces a helper to query the iotlb entry for a possible iova. This will be used by later device IOTLB API to enable the capability for a dataplane (e.g vhost) to query the IOTLB. Cc: Paolo Bonzini Cc: Peter Crosthwaite Cc: Richard Henderson Acked-by: Paolo Bonz

[Qemu-devel] [PULL 02/41] intel_iommu: allow migration

2017-01-09 Thread Michael S. Tsirkin
From: Peter Xu IOMMU needs to be migrated before all the PCI devices (in case there are devices that will request for address translation). So marking it with a priority higher than the default (which PCI devices and other belong). Migration framework handled the rest. Signed-off-by: Peter Xu R

[Qemu-devel] [PULL 01/41] migration: allow to prioritize save state entries

2017-01-09 Thread Michael S. Tsirkin
From: Peter Xu During migration, save state entries are saved/loaded without a specific order - we just traverse the savevm_state.handlers list and do it one by one. This might not be enough. There are requirements that we need to load specific device's vmstate first before others. For example,

Re: [Qemu-devel] [PATCH for-2.9 00/10] pc: acpi: memory hotplug cleanup/consolidation

2017-01-09 Thread Michael S. Tsirkin
On Mon, Jan 09, 2017 at 03:22:01PM +0100, Igor Mammedov wrote: > On Tue, 6 Dec 2016 00:32:19 +0100 > Igor Mammedov wrote: > > > Series cleanups and consolidates scattered memory hotplug > > code so it could be easily reused by ARM target later. > > > > As result: > > * added memory hotplug var

Re: [Qemu-devel] [PATCH V4 10/10] vhost_net: device IOTLB support

2017-01-09 Thread Michael S. Tsirkin
On Fri, Dec 30, 2016 at 06:09:19PM +0800, Jason Wang wrote: > This patches implements Device IOTLB support for vhost kernel. This is > done through: > > 1) switch to use dma helpers when map/unmap vrings from vhost codes > 2) introduce a set of VhostOps to: >- setting up device IOTLB request c

Re: [Qemu-devel] [PATCH V4 00/10] vhost device IOTLB support

2017-01-09 Thread Michael S. Tsirkin
On Fri, Dec 30, 2016 at 06:09:09PM +0800, Jason Wang wrote: > Hi all: > > As the userspace vitio driver became popular, more and more request > were received for secure DMA environemt (DMAR). So this series tries > to make DMAR works for virtio/vhost. The idea is let virtio/vhost > co-work with us

Re: [Qemu-devel] [PATCH 4/5] pc: Add 2.9 machine-types

2017-01-09 Thread Michael S. Tsirkin
On Sun, Jan 08, 2017 at 05:40:40PM -0200, Eduardo Habkost wrote: > Cc: "Michael S. Tsirkin" > Cc: Laszlo Ersek > Cc: Igor Mammedov > Signed-off-by: Eduardo Habkost Do I understand it correctly that you are merging this through another tree? In that case Reviewed-by: Michael S. Tsirkin > -

Re: [Qemu-devel] [PATCH for-2.9 0/3] hw/pcie: Introduce Generic PCI Express Root Port

2017-01-09 Thread Michael S. Tsirkin
On Wed, Nov 23, 2016 at 02:02:46PM +0200, Marcel Apfelbaum wrote: > The Generic Root Port behaves the same as the > Intel's IOH device with id 3420, without having > Intel specific attributes. > > The device has two purposes: > (1) Can be used on both X86 and ARM machines. > (2) It will allow us

Re: [Qemu-devel] [PATCH] hw/pci: disable pci-bridge's shpc by default

2017-01-09 Thread Michael S. Tsirkin
On Wed, Nov 02, 2016 at 05:16:42PM +0200, Marcel Apfelbaum wrote: > The shpc component is optional while ACPI hotplug is used > for hot-plugging PCI devices into a PCI-PCI bridge. > Disabling the shpc by default will make slot 0 usable at boot time > and not only for hot-plug, without loosing any

Re: [Qemu-devel] [PATCH v4 0/3] virtio-net: Add support to MTU feature

2017-01-09 Thread Michael S. Tsirkin
On Tue, Dec 13, 2016 at 02:17:11PM +0100, Maxime Coquelin wrote: > > > On 12/13/2016 02:07 PM, Daniel P. Berrange wrote: > > On Tue, Dec 13, 2016 at 02:04:52PM +0100, Maxime Coquelin wrote: > > > > > > > > > On 12/12/2016 11:34 AM, Daniel P. Berrange wrote: > > > > On Mon, Dec 12, 2016 at 11:12

Re: [Qemu-devel] [RFC] PCI/migration merge vmstate_pci_device and vmstate_pcie_device

2017-01-09 Thread Michael S. Tsirkin
On Fri, Dec 16, 2016 at 09:35:28AM +, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Wed, Dec 14, 2016 at 07:58:29PM +, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > The vmstate_pci_device and vmstate_pcie_d

Re: [Qemu-devel] [PATCH v4 2/2] pcie_aer: support configurable AER capa version

2017-01-09 Thread Cao jin
On 01/10/2017 11:27 AM, Michael S. Tsirkin wrote: > On Wed, Dec 21, 2016 at 04:21:31PM +0800, Cao jin wrote: >> From: Dou Liyang >> >> Now, AER capa version is fixed to v2, if assigned device isn't v2, >> then this value will be inconsistent between guest and host >> >> Signed-off-by: Dou Liyang

Re: [Qemu-devel] [PULL 6/6] MAINTAINERS: Remove obsolete stable branches

2017-01-09 Thread Michael S. Tsirkin
On Thu, Nov 10, 2016 at 11:11:43AM +0100, Thomas Huth wrote: > There are only very old and orphaned stable branches listed > in the MAINTAINERS file - so this section is pretty useless > nowadays. Let's remove it. > > Reviewed-by: John Snow > Signed-off-by: Thomas Huth Could you add some kind

Re: [Qemu-devel] [PATCH v4 2/2] pcie_aer: support configurable AER capa version

2017-01-09 Thread Michael S. Tsirkin
On Wed, Dec 21, 2016 at 04:21:31PM +0800, Cao jin wrote: > From: Dou Liyang > > Now, AER capa version is fixed to v2, if assigned device isn't v2, > then this value will be inconsistent between guest and host > > Signed-off-by: Dou Liyang > Signed-off-by: Cao jin > Reviewed-by: Michael S. Tsir

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 0/4] ppc: add a IBM 40p machine (RS/6000, PReP)

2017-01-09 Thread David Gibson
On Mon, Jan 09, 2017 at 08:43:47AM +0100, Thomas Huth wrote: > On 07.01.2017 16:23, Hervé Poussineau wrote: > > Hi, > > > > This patchset adds the emulation of the IBM RS/6000 7020 (40p). The real > > machine is > > able to run AIX (up to 4.3.3), Windows NT (up to 4.0 SP1), the beta of OS/2 > >

Re: [Qemu-devel] [PATCH] hw/ppc/spapr: Allow POWER9 as hot-pluggable CPU for pseries

2017-01-09 Thread David Gibson
On Mon, Jan 09, 2017 at 01:57:24PM +0100, Thomas Huth wrote: > Running "qemu-system-ppc64 -M pseries -cpu POWER9" currently does not work > yet and results in this error message: > > qemu-system-ppc64: Unable to find sPAPR CPU Core definition > > Since we want to support the pseries machine with

Re: [Qemu-devel] [PATCH] ppc: Prevent inifnite loop in decrementer auto-reload.

2017-01-09 Thread David Gibson
On Mon, Jan 09, 2017 at 12:23:38PM +0100, Roman Kapl wrote: > If the DECAR register is set to 0, QEMU tries to reload the decrementer with > zero in an inifinite loop. According to PPC documentation, the decrementer is > triggered on 1->0 transition, so avoid reloading the decrementer if if is > al

Re: [Qemu-devel] [PATCH v2 0/3] POWER9 TCG enablements - part10

2017-01-09 Thread David Gibson
On Mon, Jan 09, 2017 at 07:56:12PM +0530, Nikunj A Dadhania wrote: > This series contains 11 new instructions for POWER9 ISA3.0 > VSX Scalar Convert > VSX Scalar Add QP > > Changelog: > v1: > * xsaddqp, xscv[dpqp, qpdp] instructions use register numbering 0-31, this > needs > to be h

Re: [Qemu-devel] [PATCH] pc: fix crash in rtc_set_memory() if initial cpu is marked as hotplugged

2017-01-09 Thread Michael S. Tsirkin
On Fri, Dec 30, 2016 at 03:33:11PM +0100, Igor Mammedov wrote: > 'hotplugged' propperty is meant to be used on migration side when migrating > source with hotplugged devices. > However though it not exacly correct usage of 'hotplugged' property > it's possible to set generic hotplugged property for

Re: [Qemu-devel] [PATCH 1/6] pci: add pci_vga_type(), giving the device name of the chosen VGA device

2017-01-09 Thread Michael S. Tsirkin
On Tue, Jan 03, 2017 at 10:01:25AM +1100, David Gibson wrote: > On Thu, Dec 29, 2016 at 11:12:11PM +0100, Hervé Poussineau wrote: > > This is in fact a split of pci_vga_init() function in two parts. > > > > Signed-off-by: Hervé Poussineau > > Reviewed-by: David Gibson > > I think it needs Mich

Re: [Qemu-devel] [PATCH 1/4] hw/pcie: fix Extended Configuration Space for devices with no Extended Capabilities

2017-01-09 Thread Michael S. Tsirkin
On Wed, Jan 04, 2017 at 09:57:15PM +0200, Marcel Apfelbaum wrote: > Absence of any Extended Capabilities is required to be > indicated by an Extended Capability header with a Capability ID of > h, a Capability Version of 0h, and a Next Capability Offset of 000h. > > Instead of inserting a 'NUL

Re: [Qemu-devel] [PATCH 4/4] hw/virtio: fix Power Management Control Register for PCI Express virtio devices

2017-01-09 Thread Michael S. Tsirkin
On Wed, Jan 04, 2017 at 09:57:18PM +0200, Marcel Apfelbaum wrote: > Make Power Management State flag writable to conform > with the PCI Express spec. > > Signed-off-by: Marcel Apfelbaum Same comment as previously. > --- > hw/virtio/virtio-pci.c | 5 + > include/hw/pci/pcie.h | 2 ++ > 2 f

Re: [Qemu-devel] [PATCH 3/4] hw/virtio: fix Link Control Register for PCI Express virtio devices

2017-01-09 Thread Michael S. Tsirkin
On Wed, Jan 04, 2017 at 09:57:17PM +0200, Marcel Apfelbaum wrote: > Make several Link Control Register flags writable to conform > with the PCI Express spec. > > Signed-off-by: Marcel Apfelbaum Same comment as 2. > --- > hw/pci/pcie.c | 14 ++ > hw/virtio/virtio-pci.c | 3

Re: [Qemu-devel] [PATCH 2/4] hw/virtio: fix error enabling flags in Device Control register

2017-01-09 Thread Michael S. Tsirkin
On Wed, Jan 04, 2017 at 09:57:16PM +0200, Marcel Apfelbaum wrote: > When the virtio devices are PCI Express, make error-enabling flags > writable to respect the PCIe spec. > > Signed-off-by: Marcel Apfelbaum If guest writes there, it won't be able to migrate. So I think this needs a compat flag.

Re: [Qemu-devel] [PULL for-2.9 0/9] virtio, vhost, pc: fixes

2017-01-09 Thread Michael S. Tsirkin
On Tue, Jan 10, 2017 at 09:34:20AM +0800, Fam Zheng wrote: > On Mon, 01/09 17:28, Peter Maydell wrote: > > On 9 January 2017 at 16:48, Michael S. Tsirkin wrote: > > > The strange thing here is that this actually seems to apply patches > > > from list instead of getting the tag from the tree. > >

[Qemu-devel] [PATCH v5 4/7] ppc: Implement bcdus. instruction

2017-01-09 Thread Jose Ricardo Ziviani
bcdus.: Decimal unsigned shift. This instruction works like bcds. but considers only unsigned BCDs (no sign in least meaning 4 bits). Signed-off-by: Jose Ricardo Ziviani --- target/ppc/helper.h | 1 + target/ppc/int_helper.c | 41 +

[Qemu-devel] [PATCH v5 3/7] ppc: Implement bcds. instruction

2017-01-09 Thread Jose Ricardo Ziviani
bcds.: Decimal shift. Given two registers vra and vrb, this instruction shift the vrb value by vra bits into the result register. Signed-off-by: Jose Ricardo Ziviani --- target/ppc/helper.h | 1 + target/ppc/int_helper.c | 40 + ta

[Qemu-devel] [PATCH v5 5/7] ppc: Implement bcdsr. instruction

2017-01-09 Thread Jose Ricardo Ziviani
bcdsr.: Decimal shift and round. This instruction works like bcds. however, when performing right shift, 1 will be added to the result if the last digit was >= 5. Signed-off-by: Jose Ricardo Ziviani --- target/ppc/helper.h | 1 + target/ppc/int_helper.c | 48

[Qemu-devel] [PATCH v5 2/7] host-utils: Implement unsigned quadword left/right shift and unit tests

2017-01-09 Thread Jose Ricardo Ziviani
Implements 128-bit left shift and right shift as well as their testcases. By design, shift silently mods by 128, so the caller is responsible to assert the shift range if necessary. Left shift sets the overflow flag if any non-zero digit is shifted out. Examples: ulshift(&low, &high, 250, &overf

[Qemu-devel] [PATCH v5 1/7] host-utils: Move 128-bit guard macro to .c file

2017-01-09 Thread Jose Ricardo Ziviani
It is not possible to implement functions in host-utils.c for architectures with quadwords because the guard is implemented in the Makefile. This patch move the guard out of the Makefile to the implementation file. Signed-off-by: Jose Ricardo Ziviani --- util/Makefile.objs | 2 +- util/host-util

[Qemu-devel] [PATCH v5 6/7] ppc: Implement bcdtrunc. instruction

2017-01-09 Thread Jose Ricardo Ziviani
bcdtrunc.: Decimal integer truncate. Given a BCD number in vrb and the number of bytes to truncate in vra, the return register will have vrb with such bits truncated. Signed-off-by: Jose Ricardo Ziviani --- target/ppc/helper.h | 1 + target/ppc/int_helper.c | 37

[Qemu-devel] [PATCH v5 7/7] ppc: Implement bcdutrunc. instruction

2017-01-09 Thread Jose Ricardo Ziviani
bcdutrunc. Decimal unsigned truncate. Works like bcdtrunc. with unsigned BCD numbers. Signed-off-by: Jose Ricardo Ziviani --- target/ppc/helper.h | 1 + target/ppc/int_helper.c | 51 + target/ppc/translate/vmx-impl.inc.c | 4 +++

[Qemu-devel] [PATCH v5 0/7] POWER9 TCG enablements - BCD functions - final part

2017-01-09 Thread Jose Ricardo Ziviani
v5: - removes 'unlikely' gcc branch pred. hints from not unlikely places - adds comments in host-utils functions - adds more test cases for shift functions - handles "shift backwards" with signed shifts - rebases branch v4: - improves functions to behave exactly like the target v3: - moves

Re: [Qemu-devel] [PATCH v3 1/3] arm_generic_timer: Add the ARM Generic Timer

2017-01-09 Thread Alistair Francis
On Fri, Jan 6, 2017 at 3:57 AM, Peter Maydell wrote: > On 20 December 2016 at 22:42, Alistair Francis > wrote: >> Add the ARM generic timer. This allows the guest to poll the timer for >> values and also supports secure writes only. >> >> Signed-off-by: Alistair Francis >> --- >> V3: >> - Use A

Re: [Qemu-devel] [PULL for-2.9 0/9] virtio, vhost, pc: fixes

2017-01-09 Thread Fam Zheng
On Mon, 01/09 17:28, Peter Maydell wrote: > On 9 January 2017 at 16:48, Michael S. Tsirkin wrote: > > The strange thing here is that this actually seems to apply patches > > from list instead of getting the tag from the tree. > > That's because it's really supposed to be working on patches sent >

[Qemu-devel] [Bug 1653063] Re: qemu-system-arm hangs with -icount and -nodefaults

2017-01-09 Thread Hansni Bu
** Description changed: - I tested with the latest git repo, (commit: + I tested with release 2.8.0 and the latest git repo, (commit: dbe2b65566e76d3c3a0c3358285c0336ac61e757). My configure options when building QEMU: '../configure' '--prefix=$HOME/local/qemu.git' '--target-list=aarch64-

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v14 0/2] virtio-crypto: virtio crypto device specification

2017-01-09 Thread Gonglei (Arei)
Hi Michael, > > Subject: [virtio-dev] Re: [Qemu-devel] [PATCH v14 0/2] virtio-crypto: virtio > crypto device specification > > On Wed, Jan 04, 2017 at 01:03:21AM +, Gonglei (Arei) wrote: > > Hi Stefan, > > > > > > > > Subject: Re: [Qemu-devel] [PATCH v14 0/2] virtio-crypto: virtio crypto > >

Re: [Qemu-devel] [PATCH v3 0/3] add support for mice with extra/side buttons

2017-01-09 Thread Fabian Lesniak
Ping. I forgot to CC Gerd. http://patchwork.ozlabs.org/patch/703302/ http://patchwork.ozlabs.org/patch/703304/ http://patchwork.ozlabs.org/patch/703303/ Am 06.12.2016 um 20:00 schrieb Fabian Lesniak: This patch implements event handling for 5-button ps/2 mice and appropriate event generatio

Re: [Qemu-devel] [PATCH] virtio-gpu: tag as not hotpluggable

2017-01-09 Thread Michael S. Tsirkin
On Mon, Jan 09, 2017 at 02:55:38PM +0100, Gerd Hoffmann wrote: > qemu can't hotplug display devices. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Michael S. Tsirkin > --- > hw/display/virtio-gpu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/display/virtio-gpu.c b/hw/display

Re: [Qemu-devel] [PATCH v2] vfio/pci: Support error recovery

2017-01-09 Thread Michael S. Tsirkin
On Sat, Dec 31, 2016 at 05:15:36PM +0800, Cao jin wrote: > Support serious device error recovery serious? > > Signed-off-by: Cao jin > --- > drivers/vfio/pci/vfio_pci.c | 70 > +++-- > drivers/vfio/pci/vfio_pci_private.h | 2 ++ > 2 files changed, 70 i

Re: [Qemu-devel] [PATCH v4] [i.MX] fix CS handling during SPI access.

2017-01-09 Thread Peter Maydell
On 9 January 2017 at 22:27, Jean-Christophe DUBOIS wrote: > I might be wrong but I think they are coming out of reset with > their CS line set to low (so they are selected by default) > because this is the default level at reset. If that's true then you're in difficulties, because there's no guar

Re: [Qemu-devel] [PATCH RFC v11 3/4] vfio-pci: pass the aer error to guest

2017-01-09 Thread Michael S. Tsirkin
On Sat, Dec 31, 2016 at 05:13:07PM +0800, Cao jin wrote: > From: Chen Fan > > When physical device has uncorrectable error hanppened, the vfio_pci > driver will signal the uncorrectable error status register value to > corresponding QEMU's vfio-pci device via the eventfd registered by this > devi

Re: [Qemu-devel] vfio/pci: guest error recovery proposal

2017-01-09 Thread Michael S. Tsirkin
On Wed, Dec 28, 2016 at 10:52:13AM +0800, Cao jin wrote: > > > On 12/16/2016 07:02 AM, Michael S. Tsirkin wrote: > > > >> 1) We need to do the right thing for the guest, I don't think we > >> should be presuming that different reset types are equivalent, > >> leaving gaps where we expec

Re: [Qemu-devel] [PATCH] pcie: remove duplicate assertion

2017-01-09 Thread Michael S. Tsirkin
On Fri, Dec 23, 2016 at 10:16:30AM +0800, Cao jin wrote: > "size >= 8" connote "size > 0" > > Signed-off-by: Cao jin Isn't the point to check for overflows? > --- > hw/pci/pcie.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c > index 39b10b852d91..f864c5

Re: [Qemu-devel] [PATCH v4] [i.MX] fix CS handling during SPI access.

2017-01-09 Thread Jean-Christophe DUBOIS
Le 09/01/2017 à 22:45, Peter Maydell a écrit : On 9 January 2017 at 21:19, Jean-Christophe DUBOIS wrote: Hum, ... I think I have a problem. With the default register value (that I get a reset) the CS line is deselected when the CS is high. So at reset I would need to set my 4 CS lines to high

Re: [Qemu-devel] [PATCH] disas/cris.c: Fix Coverity warning about unchecked NULL

2017-01-09 Thread Edgar E. Iglesias
On Mon, Jan 09, 2017 at 09:35:16PM +, Peter Maydell wrote: > On 9 January 2017 at 19:10, wrote: > > Checking PATCH 1/1: disas/cris.c: Fix Coverity warning about unchecked > > NULL... > > ERROR: code indent should never use tabs > > #24: FILE: disas/cris.c:2493: > > +^Iif (sregp == NULL || sr

[Qemu-devel] [Bug 1449687] Re: block migration of qcow2 VMs copies all empty space

2017-01-09 Thread Ansgar Hegerfeld
There is a patch available: https://lists.gnu.org/archive/html/qemu- devel/2016-11/msg03742.html (and those which are mentioned in the responses) ** Changed in: qemu Status: New => Confirmed ** Tags added: sparse -- You received this bug notification because you are a member of qemu- dev

Re: [Qemu-devel] [PATCH v7 00/10] Convert msix_init() to error

2017-01-09 Thread Michael S. Tsirkin
On Mon, Nov 14, 2016 at 03:25:30PM +0800, Cao jin wrote: > v7 changelog: > 1. fix the segfaut bug in patch 2. So drop the all the R-b of it, >please take a look, there is detailed description in the patch. > 2. add the R-b from Hannes Reinecke > > Test: > 1. make check: pass > 2. After applied

Re: [Qemu-devel] [PATCH v4] [i.MX] fix CS handling during SPI access.

2017-01-09 Thread Peter Maydell
On 9 January 2017 at 21:19, Jean-Christophe DUBOIS wrote: > Hum, ... I think I have a problem. > > With the default register value (that I get a reset) the CS line is > deselected when the CS is high. > > So at reset I would need to set my 4 CS lines to high in order to be able to > drive them low

Re: [Qemu-devel] [PATCH v14 0/2] virtio-crypto: virtio crypto device specification

2017-01-09 Thread Michael S. Tsirkin
On Wed, Jan 04, 2017 at 01:03:21AM +, Gonglei (Arei) wrote: > Hi Stefan, > > > > > Subject: Re: [Qemu-devel] [PATCH v14 0/2] virtio-crypto: virtio crypto > > device > > specification > > > > On Mon, Dec 26, 2016 at 02:38:29AM +, Gonglei (Arei) wrote: > > > Both Alex and Stefan mentioned

Re: [Qemu-devel] [PATCH 3/3] vmstate registration: check return values

2017-01-09 Thread Peter Maydell
On 9 January 2017 at 20:13, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Check qdev's call to vmstate_register_with_alias_id; that gets > most of the common uses; there's hundreds of calls via vmstate_register > which could get fixed over time. Not quite that bad, I t

Re: [Qemu-devel] [PATCH] ui: fix format specifier in vnc_client_io_error() to avoid break in build.

2017-01-09 Thread Eric Blake
On 01/08/2017 12:28 PM, Rami Rosen wrote: > When building qemu after setting _VNC_DEBUG to 1 (see ui/vnc.h), > we get the following error and the build breaks: > ... > ui/vnc.c: In function ‘vnc_client_io_error’: > ui/vnc.c:1262:13: error: format ‘%d’ expects argument of type ‘int’, but > argument

  1   2   3   4   >