Re: [Qemu-devel] [PATCH v5 7/9] block: don't make snapshots for filters

2016-12-21 Thread Pavel Dovgalyuk
Kevin, > From: Kevin Wolf [mailto:kw...@redhat.com] > Am 05.12.2016 um 12:49 hat Pavel Dovgalyuk geschrieben: > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > It's not a requirement. But to make replay deterministic we have to > > start with the same image every time. As I know, this may b

Re: [Qemu-devel] [PULL V2 1/3] record/replay: add network support

2016-12-21 Thread Pavel Dovgalyuk
Hi, Jason! Please don't forget this for 2.9. Pavel Dovgalyuk > -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Monday, November 14, 2016 5:54 AM > To: peter.mayd...@linaro.org > Cc: qemu-devel@nongnu.org; Pavel Dovgalyuk; Jason Wang > Subject: [PULL V2 1/3] rec

[Qemu-devel] Performance about x-data-plane

2016-12-21 Thread Weiwei Jia
Hi, With QEMU x-data-plane, I find the performance has not been improved very much. Please see following two settings. Setting 1: I/O thread in host OS (VMM) reads 4KB each time from disk (8GB in total). Pin the I/O thread to pCPU 5 which will serve I/O thread dedicatedly. I find the performance

Re: [Qemu-devel] Strange/wrong behavior with iSCSI Tape devices in QEMU 2.8.0-rc4

2016-12-21 Thread Fam Zheng
On Wed, 12/21 05:44, Holger Schranz wrote: > Hi Fam, > > meanwhile I have sent the requested QEMU CLI direct to John. Your request > I will try after the reinstall with the released version.So please wait > for a while. I don't see the command line, but looking at the other info, the question to

Re: [Qemu-devel] [PATCH for-2.9 V4 2/2] Add a new qmp command to do checkpoint, get replication error

2016-12-21 Thread Zhang Chen
On 12/21/2016 10:25 PM, Eric Blake wrote: On 12/21/2016 12:56 AM, Zhang Chen wrote: +void qmp_xen_get_replication_error(Error **errp) +{ +replication_get_error_all(errp); +} Is this trying to cause a replication error, or is it trying to collect status on whether an error

[Qemu-devel] [PATCH qemu 2/2] spapr_pci: Advertise 16M IOMMU pages when available

2016-12-21 Thread Alexey Kardashevskiy
On sPAPR, IOMMU page size varies and if QEMU is running with RAM backed with hugepages, we can advertise this to the guest so does this patch. Signed-off-by: Alexey Kardashevskiy --- hw/ppc/spapr_pci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c

[Qemu-devel] [PATCH qemu 1/2] exec, kvm, target-ppc: Move getrampagesize() to common code

2016-12-21 Thread Alexey Kardashevskiy
getrampagesize() returns the largest supported page size and mainly used to know if huge pages are enabled. However is implemented in target-ppc/kvm.c and not available in TCG or other architectures. This renames and moves gethugepagesize() to mmap-alloc.c where fd-based analog of it is already i

[Qemu-devel] [PATCH qemu 0/2] exec, spapr_pci: Advertise huge IOMMU pages

2016-12-21 Thread Alexey Kardashevskiy
These are to enable 16mb pages for IOMMU which should reduce the amount of memory used for TCE tables in 256 times (compared to 64k pages case). Please comment. Thanks! Alexey Kardashevskiy (2): exec, kvm, target-ppc: Move getrampagesize() to common code spapr_pci: Advertise 16M IOMMU pages wh

[Qemu-devel] [PATCH] virtio-crypto: use the correct length for cipher operation

2016-12-21 Thread Gonglei
In some modes of cipher algorithms, the length of destination data maybe larger then source data, such as ciphertext stealing (CTS). For symmetric algorithms, the length of ciphertext is definitly equal to the plaintext for each crypto operation. So we should use the src_len instead of dst_len avo

[Qemu-devel] [PATCH RESEND 3/5] virtio-crypto-pci: add check for cryptodev object

2016-12-21 Thread Gonglei
We must assure each virtio crypto pci device has an invaild cryptodev backend object. Signed-off-by: Gonglei --- hw/virtio/virtio-crypto-pci.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/virtio/virtio-crypto-pci.c b/hw/virtio/virtio-crypto-pci.c index a1b0906..14bd12c 100644 ---

Re: [Qemu-devel] [PATCH RESEND 3/5] virtio-crypto-pci: add check for cryptodev object

2016-12-21 Thread Gonglei (Arei)
> > Subject: [PATCH RESEND 3/5] virtio-crypto-pci: add check for cryptodev object > > We must assure each virtio crypto pci device has > an invaild cryptodev backend object. > Oops, a typo. s/an invalid/ a valid/ Michael, can you pls correct it if no other comments? Thanks, -Gonglei > Signed

[Qemu-devel] [PATCH RESEND 0/5] hotplugging support for both cryptdoev and virtio crypto device

2016-12-21 Thread Gonglei
The patch set make the cryptodev object can be hot plugging in safety, and which are preparing works for virtio-crypto device hotplugging. Patch 5 opens the hotplugging capability for virtio crypto device. Gonglei (5): cryptodev: introduce a new is_used property cryptodev: wrap the ready flag

[Qemu-devel] [PATCH RESEND 1/5] cryptodev: introduce a new is_used property

2016-12-21 Thread Gonglei
This property is used to Tag the cryptodev backend is used by virtio-crypto or not. Making cryptodev can't be hot unplugged when it's in use. Cleanup resources when cryptodev is finalized. Signed-off-by: Gonglei --- backends/cryptodev.c | 19 +++ hw/virtio/virtio-crypto.c

[Qemu-devel] [PATCH RESEND 2/5] cryptodev: wrap the ready flag

2016-12-21 Thread Gonglei
The ready flag should be set by the children of cryptodev backend interface. Warp the setter/getter functions for it. Signed-off-by: Gonglei --- backends/cryptodev-builtin.c | 4 backends/cryptodev.c | 15 +++ hw/virtio/virtio-crypto.c| 4 ++-- include/sysemu/crypt

[Qemu-devel] [PATCH RESEND 5/5] virtio-crypto-pci: tag virtio-crypto device hot pluggable

2016-12-21 Thread Gonglei
After resolving the relationship with cryptodev backend, the virtio crypto device supports hotplug now. Signed-off-by: Gonglei --- hw/virtio/virtio-crypto-pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/virtio/virtio-crypto-pci.c b/hw/virtio/virtio-crypto-pci.c index 14bd12c..422aca3

[Qemu-devel] [PATCH RESEND 4/5] virtio-crypto: avoid one cryptodev device is used by multiple virtio crypto devices

2016-12-21 Thread Gonglei
Add the check condition for cryptodev device in order to avoid one cryptodev device is used by multiple virtio crypto devices. Signed-off-by: Gonglei --- hw/virtio/virtio-crypto.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio-crypto.c b/hw/

[Qemu-devel] [PATCH v3] virtio-crypto: zeroize the key material before free

2016-12-21 Thread Gonglei
Common practice with sensitive information (key material, passwords, etc). Prevents sensitive information from being exposed by accident later in coredumps, memory disclosure bugs when heap memory is reused, etc. Sensitive information is sometimes also held in mlocked pages to prevent it being swa

Re: [Qemu-devel] [PATCH] migration: re-active images when migration fails to complete

2016-12-21 Thread Hailiang Zhang
On 2016/12/9 4:02, Dr. David Alan Gilbert wrote: * Hailiang Zhang (zhang.zhanghaili...@huawei.com) wrote: Hi, On 2016/12/6 23:24, Dr. David Alan Gilbert wrote: * Kevin Wolf (kw...@redhat.com) wrote: Am 19.11.2016 um 12:43 hat zhanghailiang geschrieben: commit fe904ea8242cbae2d7e69c052c754b8f

[Qemu-devel] [PATCH qemu] target-ppc: kvm: make use of KVM_CREATE_SPAPR_TCE_64

2016-12-21 Thread Alexey Kardashevskiy
KVM_CAP_SPAPR_TCE capability allows creating TCE tables in KVM which allows having in-kernel acceleration for H_PUT_TCE_xxx hypercalls. However it only supports 32bit DMA windows at zero bus offset. There is a new KVM_CAP_SPAPR_TCE_64 capability which supports 64bit window size, variable page size

Re: [Qemu-devel] [PULL v1 3/7] crypto: add HMAC algorithms framework

2016-12-21 Thread Longpeng (Mike)
Hi Daniel, Can you pick this patch together ? [PATCH for-2.9 v4 1/6] configure: add CONFIG_GCRYPT_HMAC item Or it will be picked by somebody else ? :) On 2016/12/21 22:35, Daniel P. Berrange wrote: > From: "Longpeng(Mike)" > > This patch introduce HMAC algorithms framework. > > Signed-off-by

Re: [Qemu-devel] [Qemu-ppc] [PATCHv3 for-2.9 0/6] HPT resizing for pseries guests (qemu part)

2016-12-21 Thread David Gibson
On Wed, Dec 21, 2016 at 09:38:17AM +0100, Andrea Bolognani wrote: > On Wed, 2016-12-21 at 15:52 +1100, David Gibson wrote: > > > > I'm not sure if we need a knob.  I think in general enabling for > > > > pseries-2.9 and later machine types is correct.  The difficulty is > > > > that for HV guests,

Re: [Qemu-devel] [PATCH] intel_iommu: allow dynamic switch of IOMMU region

2016-12-21 Thread David Gibson
On Wed, Dec 21, 2016 at 06:05:49PM +0800, Peter Xu wrote: > On Wed, Dec 21, 2016 at 01:53:37PM +1100, David Gibson wrote: > > [...] > > > > Could you explain why here device address space has things to do with > > > PCI BARs? I thought BARs are for CPU address space only (so that CPU > > > can ac

Re: [Qemu-devel] [PATCH v3 0/3] Introduce vhost-user-scsi and sample application

2016-12-21 Thread Felipe Franciosi
> On 21 Dec 2016, at 22:17, Felipe Franciosi wrote: > > Based on various discussions on the 2016 KVM Forum, I'm sending over a > vhost-user-scsi implementation for your consideration. > > This patchset introduces a new vhost-user SCSI device. While heavily > based on vhost-scsi, it is implement

[Qemu-devel] [PATCH v3 3/3] vus: Introduce a vhost-user-scsi sample application

2016-12-21 Thread Felipe Franciosi
This commit introduces a vhost-user-scsi backend sample application. It must be linked with libiscsi and libvhost-user. To use it, compile with: make vhost-user-scsi And run as follows: ./vhost-user-scsi -u /tmp/vus.sock -i iscsi://uri_to_target/ The application is currently limited at one LUN o

[Qemu-devel] [PATCH v3 1/3] vhost-scsi: create a vhost-scsi-common abstraction

2016-12-21 Thread Felipe Franciosi
In order to introduce a new vhost-user-scsi host device type, it makes sense to abstract part of vhost-scsi into a common parent class. This commit does exactly that. Signed-off-by: Felipe Franciosi --- hw/scsi/Makefile.objs | 2 +- hw/scsi/vhost-scsi-common.c | 143 +

[Qemu-devel] [PATCH v3 0/3] Introduce vhost-user-scsi and sample application

2016-12-21 Thread Felipe Franciosi
Based on various discussions on the 2016 KVM Forum, I'm sending over a vhost-user-scsi implementation for your consideration. This patchset introduces a new vhost-user SCSI device. While heavily based on vhost-scsi, it is implemented using vhost's userspace counterpart. The device has been coded a

[Qemu-devel] [PATCH v3 2/3] vus: Introduce vhost-user-scsi host device

2016-12-21 Thread Felipe Franciosi
This commit introduces a vhost-user device for SCSI. This is based on the existing vhost-scsi implementation, but done over vhost-user instead. It also uses a chardev to connect to the backend. Unlike vhost-scsi (today), VMs using vhost-user-scsi can be live migrated. To use it, one must configure

Re: [Qemu-devel] [Qemu-block] [PATCH v2] qemu-img: fix in-flight count for qemu-img bench

2016-12-21 Thread John Snow
On 12/07/2016 10:08 AM, Paolo Bonzini wrote: > With aio=native (qemu-img bench -n) one or more requests can be completed > when a new request is submitted. This in turn can cause bench_cb to > recurse before b->in_flight is updated. This causes multiple I/Os > to be submitted with the same offs

[Qemu-devel] [Bug 696530] Re: qemu-0.13.0-r2 special keys different when using -alt-grab

2016-12-21 Thread Thomas Huth
Comment #1 sounds like this issue has been dealt with? Is there still something left that needs to be fixed here? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launc

[Qemu-devel] [Bug 502107] Re: qemu-kvm 0.12.1.2 crashes booting Ubuntu 9.10 with "-vga std"

2016-12-21 Thread Thomas Huth
Triaging old bug tickets ... can you still reproduce this problem with the latest version of QEMU (v2.8)? ** Changed in: qemu Status: Confirmed => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchp

[Qemu-devel] [Bug 1649040] Re: Ubuntu 16.04.1 Grub Splash Doesn't Appear

2016-12-21 Thread Thomas Huth
Why are you using "-vga vmware" ? Can't you use "-vga std" instead? Also, now that QEMU 2.8 has been released, could you please test again with this latest version? Thanks! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.

[Qemu-devel] [Bug 1649042] Re: Ubuntu 16.04.1 LightDM Resolution Not Correct

2016-12-21 Thread Thomas Huth
Why are you using "-vga vmware" ? Can't you use "-vga std" instead? Also, now that QEMU 2.8 has been released, could you please test again with this latest version? Thanks! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.

Re: [Qemu-devel] [PATCH 00/26] New hppa-linux-user target

2016-12-21 Thread Helge Deller
On 18.12.2016 07:56, Thomas Huth wrote: > On 16.12.2016 20:13, Richard Henderson wrote: >> This is a linux-user only port, emulating a 32-bit only version of a >> pa-2.0 cpu. This is good enough to do well with both the gcc and glibc >> testsuites. Helge Deller has provided invaluable assistance

Re: [Qemu-devel] checkpatch.pl false positive (was Re: [PATCH v4 0/7] q35: add negotiable broadcast SMI)

2016-12-21 Thread Eduardo Habkost
On Wed, Dec 21, 2016 at 07:08:29PM +0100, Paolo Bonzini wrote: > > > On 21/12/2016 19:01, Eduardo Habkost wrote: > > The following code replaces the whole "{ .driver = ... }" block > > with "1": > > > > # Flatten any parentheses and braces > > while ($dstat =~ s/\([^\(\)]*\)/1/ || > >

Re: [Qemu-devel] checkpatch.pl false positive (was Re: [PATCH v4 0/7] q35: add negotiable broadcast SMI)

2016-12-21 Thread Paolo Bonzini
On 21/12/2016 19:01, Eduardo Habkost wrote: > The following code replaces the whole "{ .driver = ... }" block > with "1": > > # Flatten any parentheses and braces > while ($dstat =~ s/\([^\(\)]*\)/1/ || > $dstat =~ s/\{[^\{\}]*\}/1/ || > $dstat =~ s/\[[^\{\}

Re: [Qemu-devel] checkpatch.pl false positive (was Re: [PATCH v4 0/7] q35: add negotiable broadcast SMI)

2016-12-21 Thread Eduardo Habkost
On Wed, Dec 21, 2016 at 06:47:01PM +0100, Paolo Bonzini wrote: > > > On 21/12/2016 16:22, Eduardo Habkost wrote: > > On Tue, Dec 20, 2016 at 03:01:17PM -0800, no-re...@patchew.org wrote: > > [...] > >> Checking PATCH 4/7: hw/i386/pc: introduce 2.9 machine types with 0x20 > >> fw_cfg file slots..

Re: [Qemu-devel] [PATCH] smbios: stop ignoring command line options for TARGET_ARM

2016-12-21 Thread Paolo Bonzini
On 21/12/2016 14:59, Igor Mammedov wrote: >> Apparently a misunderstanding of the underlying command line handling >> mechanics. >> >>> Also this patch would break build for targets that don't link smbios.c >>> (i.e. which don't have CONFIG_SMBIOS=y) >> >> Ah, I hadn't spotted that - apologies

Re: [Qemu-devel] checkpatch.pl false positive (was Re: [PATCH v4 0/7] q35: add negotiable broadcast SMI)

2016-12-21 Thread Paolo Bonzini
On 21/12/2016 16:22, Eduardo Habkost wrote: > On Tue, Dec 20, 2016 at 03:01:17PM -0800, no-re...@patchew.org wrote: > [...] >> Checking PATCH 4/7: hw/i386/pc: introduce 2.9 machine types with 0x20 fw_cfg >> file slots... >> ERROR: Macros with multiple statements should be enclosed in a do - whil

Re: [Qemu-devel] Cannot add iothreads label in libvirt xml configuration file

2016-12-21 Thread Weiwei Jia
Sorry to add my libvirt and qemu version. Libvirt version: 2.4.0 QEMU version: 2.3.0 Thanks, Weiwei Jia On Wed, Dec 21, 2016 at 12:11 PM, Weiwei Jia wrote: > Hi, > > I cannot add iothreads > (https://libvirt.org/formatdomain.html#elementsIOThreadsAllocation) in > the libvirt xml configuration

[Qemu-devel] Cannot add iothreads label in libvirt xml configuration file

2016-12-21 Thread Weiwei Jia
Hi, I cannot add iothreads (https://libvirt.org/formatdomain.html#elementsIOThreadsAllocation) in the libvirt xml configuration file. Once I add "4" and other related config for IOthreads into the libvirt xml configuration file with virsh command and save it, these iothreads related configuration

Re: [Qemu-devel] [PATCH 3/4] util: Add VFIO helper library

2016-12-21 Thread Paolo Bonzini
On 21/12/2016 17:19, Fam Zheng wrote: > It's clever! It'd be a bit more complicated than that, though. Things like > queues etc in block/nvme.c have to be preserved, and if we already ensure > that, > ram blocks can be preserved similarly, but indeed bounce buffers can be > handled > that way.

Re: [Qemu-devel] [PATCH 20/67] ahci: clear aiocb in ncq_cb

2016-12-21 Thread Michael Roth
Quoting John Snow (2016-12-19 17:07:17) > Hi, some more considerations: > > > e7bd708ec85e40fd51569bb90c52d6613ffd8f45 > atapi: classify read_cd as conditionally returning data > > This fixes problems with certain operating systems being unable to read > from the CDROM. applied. > > > 99868a

Re: [Qemu-devel] [PATCH v6 05/17] docs: add master qapi texi files

2016-12-21 Thread Markus Armbruster
Marc-André Lureau writes: > The qapi2texi script generates a file to be included in a texi file. Add > "QEMU QMP Reference Manual" and "QEMU Guest Agent Protocol Reference" > master texi files. > > Signed-off-by: Marc-André Lureau This is v5 (which got my R-by) with a "Documentation syntax" sec

Re: [Qemu-devel] [PATCH v10 00/24] qcow2: persistent dirty bitmaps

2016-12-21 Thread Vladimir Sementsov-Ogievskiy
Last patch breaks it. Fix will look like diff --git a/block/qcow2-bitmap.c b/block/qcow2-bitmap.c index b9f3d62..dd987a1 100644 --- a/block/qcow2-bitmap.c +++ b/block/qcow2-bitmap.c @@ -79,7 +79,7 @@ typedef struct Qcow2BitmapTable { } Qcow2BitmapTable; typedef QSIMPLEQ_HEAD(Qcow2BitmapTableLi

Re: [Qemu-devel] [PATCH 3/4] util: Add VFIO helper library

2016-12-21 Thread Fam Zheng
On Wed, 12/21 16:46, Paolo Bonzini wrote: > > > On 20/12/2016 17:31, Fam Zheng wrote: > > +hbitmap_iter_init(&iter, s->free_chunks, 1); > > +if (contiguous) { > > +while (true) { > > +bool satisfy = true; > > +next = hbitmap_iter_next(&iter); > > +

Re: [Qemu-devel] [PATCH 3/4] util: Add VFIO helper library

2016-12-21 Thread Paolo Bonzini
On 20/12/2016 17:31, Fam Zheng wrote: > +hbitmap_iter_init(&iter, s->free_chunks, 1); > +if (contiguous) { > +while (true) { > +bool satisfy = true; > +next = hbitmap_iter_next(&iter); > +if (next < 0) { > +return NULL; > +

Re: [Qemu-devel] [RFC 0/7] Move accel, KVM, Xen, qtest files to accel/ subdir

2016-12-21 Thread Paolo Bonzini
On 21/12/2016 15:15, Eduardo Habkost wrote: >> >> ifeq ($(CONFIG_SOFTMMU),y) >> obj-$(CONFIG_KVM) += kvm-all.c >> obj-$(call lnot, $(CONFIG_KVM)) += kvm-stub.c >> endif >> >> similar to what is done already in Makefile.objs? > I assume you mean: > > ifeq ($(CONFIG_SOFTMMU),y) > obj-$(CONFIG_KV

Re: [Qemu-devel] [PATCH v10 00/24] qcow2: persistent dirty bitmaps

2016-12-21 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 1482332102-131788-1-git-send-email-vsement...@virtuozzo.com Subject: [Qemu-devel] [PATCH v10 00/24] q

[Qemu-devel] checkpatch.pl false positive (was Re: [PATCH v4 0/7] q35: add negotiable broadcast SMI)

2016-12-21 Thread Eduardo Habkost
On Tue, Dec 20, 2016 at 03:01:17PM -0800, no-re...@patchew.org wrote: [...] > Checking PATCH 4/7: hw/i386/pc: introduce 2.9 machine types with 0x20 fw_cfg > file slots... > ERROR: Macros with multiple statements should be enclosed in a do - while loop > #126: FILE: include/hw/compat.h:4: > +#defin

[Qemu-devel] ping Re: [PATCH v4 00/17] Dirty bitmaps postcopy migration

2016-12-21 Thread Vladimir Sementsov-Ogievskiy
Ping Hi all! What about this? 22.11.2016 20:54, Vladimir Sementsov-Ogievskiy wrote: Hi all! There is a new version of dirty bitmap postcopy migration series. v4: clone: tag postcopy-v4 from https://src.openvz.org/scm/~vsementsov/qemu.git online: https://src.openvz.org/users/vsementsov/repos/

[Qemu-devel] [PATCH 09/24] qcow2: add .bdrv_load_autoloading_dirty_bitmaps

2016-12-21 Thread Vladimir Sementsov-Ogievskiy
Auto loading bitmaps are bitmaps in Qcow2, with the AUTO flag set. They are loaded when the image is opened and become BdrvDirtyBitmaps for the corresponding drive. Extra data in bitmaps is not supported for now. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/Makefile.objs | 2 +- blo

[Qemu-devel] [PATCH v10 00/24] qcow2: persistent dirty bitmaps

2016-12-21 Thread Vladimir Sementsov-Ogievskiy
Hi all! There is a new update of qcow2-bitmap series - v10. web: https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=qcow2-bitmap-v10 git: https://src.openvz.org/scm/~vsementsov/qemu.git (tag qcow2-bitmap-v10) v10: 07: rm John's r-b not add Max's r-b fix subject s/dirty bitmap

[Qemu-devel] [PATCH 22/24] block/dirty-bitmap: deep release dirty bitmaps

2016-12-21 Thread Vladimir Sementsov-Ogievskiy
Remove persistent bitmap from its storage on bdrv_release_dirty_bitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 21 ++--- include/block/block_int.h | 3 +++ 2 files changed, 21 insertions(+), 3 deletions(-) diff --git a/block/dirty-bitmap.c b

[Qemu-devel] [PATCH 24/24] qcow2-bitmap: cache bitmap list in BDRVQcow2State

2016-12-21 Thread Vladimir Sementsov-Ogievskiy
Do not reload bitmap list every time it is needed. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-bitmap.c | 121 ++- block/qcow2.c| 2 + block/qcow2.h| 4 ++ 3 files changed, 87 insertions(+), 40 deletions(-) diff

[Qemu-devel] [PATCH 17/24] qmp: add autoload parameter to block-dirty-bitmap-add

2016-12-21 Thread Vladimir Sementsov-Ogievskiy
Optional. Default is false. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev Reviewed-by: Max Reitz --- blockdev.c| 18 -- docs/qmp-commands.txt | 4 qapi/block-core.json | 6 +- 3 files changed, 25 insertions(+), 3 deletions(-)

[Qemu-devel] [PATCH 20/24] qcow2-refcount: rename inc_refcounts() and make it public

2016-12-21 Thread Vladimir Sementsov-Ogievskiy
This is needed for the following patch, which will introduce refcounts checking for qcow2 bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/qcow2-refcount.c | 53 ++ block/qcow2.h | 4 2 files cha

[Qemu-devel] [PATCH 13/24] qcow2: add .bdrv_store_persistent_dirty_bitmaps()

2016-12-21 Thread Vladimir Sementsov-Ogievskiy
Realize block bitmap storing interface, to allow qcow2 images store persistent bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-bitmap.c | 509 +-- block/qcow2.c| 1 + block/qcow2.h| 1 + 3 files changed, 496

[Qemu-devel] [PATCH 18/24] qmp: add x-debug-block-dirty-bitmap-sha256

2016-12-21 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 5 + blockdev.c | 29 + include/block/dirty-bitmap.h | 2 ++ include/qemu/hbitmap.h | 8 qapi/block-core.json | 27 +++

Re: [Qemu-devel] [PATCH 18/24] qmp: add x-debug-block-dirty-bitmap-sha256

2016-12-21 Thread Vladimir Sementsov-Ogievskiy
21.12.2016 17:54, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 5 + blockdev.c | 29 + include/block/dirty-bitmap.h | 2 ++ include/qemu/hbitmap.h | 8

[Qemu-devel] [PATCH 02/24] specs/qcow2: do not use wording 'bitmap header'

2016-12-21 Thread Vladimir Sementsov-Ogievskiy
A bitmap directory entry is sometimes called a 'bitmap header'. This patch leaves only one name - 'bitmap directory entry'. The name 'bitmap header' creates misunderstandings with 'qcow2 header' and 'qcow2 bitmap header extension' (which is extension of qcow2 header) Signed-off-by: Vladimir Sement

[Qemu-devel] [PATCH 01/24] specs/qcow2: fix bitmap granularity qemu-specific note

2016-12-21 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow --- docs/specs/qcow2.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt index 80cdfd0..dda53dd 100644 --- a/docs/specs/qcow2.txt +++ b/docs/specs/qcow2.txt @@ -47

[Qemu-devel] [PATCH 16/24] qmp: add persistent flag to block-dirty-bitmap-add

2016-12-21 Thread Vladimir Sementsov-Ogievskiy
Add optional 'persistent' flag to qmp command block-dirty-bitmap-add. Default is false. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev Reviewed-by: Max Reitz --- blockdev.c| 18 +- docs/qmp-commands.txt | 3 +++ qapi/block-core.json | 7

[Qemu-devel] [PATCH 03/24] hbitmap: improve dirty iter

2016-12-21 Thread Vladimir Sementsov-Ogievskiy
Make dirty iter resistant to resetting bits in corresponding HBitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow --- include/qemu/hbitmap.h | 26 -- util/hbitmap.c | 23 ++- 2 files changed, 26 i

[Qemu-devel] [PATCH 10/24] block/dirty-bitmap: add autoload field to BdrvDirtyBitmap

2016-12-21 Thread Vladimir Sementsov-Ogievskiy
Mirror AUTO flag from Qcow2 bitmap in BdrvDirtyBitmap. This will be needed in future, to save this flag back to Qcow2 for persistent bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/dirty-bitmap.c | 16 block/qcow2-bitmap.c |

[Qemu-devel] [PATCH 07/24] qcow2: add bitmaps extension

2016-12-21 Thread Vladimir Sementsov-Ogievskiy
Add bitmap extension as specified in docs/specs/qcow2.txt. For now, just mirror extension header into Qcow2 state and check constraints. For now, disable image resize if it has bitmaps. It will be fixed later. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.c | 119 +

[Qemu-devel] [PATCH 21/24] qcow2-bitmap: refcounts

2016-12-21 Thread Vladimir Sementsov-Ogievskiy
Calculate refcounts for qcow2 bitmaps. It is needed for qcow2's qemu-img check implementation. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-bitmap.c | 80 ++ block/qcow2-refcount.c | 6 block/qcow2.h | 3 ++ 3 files

[Qemu-devel] [PATCH 19/24] iotests: test qcow2 persistent dirty bitmap

2016-12-21 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iotests/165 | 89 ++ tests/qemu-iotests/165.out | 5 +++ tests/qemu-iotests/group | 1 + 3 files changed, 95 insertions(+) create mode 100755 tests/qemu-iotests/

[Qemu-devel] [PATCH 06/24] block/dirty-bitmap: add deserialize_ones func

2016-12-21 Thread Vladimir Sementsov-Ogievskiy
Add bdrv_dirty_bitmap_deserialize_ones() function, which is needed for qcow2 bitmap loading, to handle unallocated bitmap parts, marked as all-ones. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Kevin Wolf Reviewed-by: John Snow --- block/dirty-bitmap.c | 7 +++ include

[Qemu-devel] [PATCH 08/24] block: introduce auto-loading bitmaps

2016-12-21 Thread Vladimir Sementsov-Ogievskiy
Auto loading bitmaps are bitmaps stored in the disk image, which should be loaded when the image is opened and become BdrvDirtyBitmaps for the corresponding drive. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow --- block.c | 14 ++ include/block

[Qemu-devel] [PATCH 11/24] block: introduce persistent dirty bitmaps

2016-12-21 Thread Vladimir Sementsov-Ogievskiy
New field BdrvDirtyBitmap.persistent means, that bitmap should be saved on bdrv_close, using format driver. Format driver should maintain bitmap storing. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block.c | 32 bl

[Qemu-devel] [PATCH 15/24] qcow2: add .bdrv_can_store_new_dirty_bitmap

2016-12-21 Thread Vladimir Sementsov-Ogievskiy
Realize .bdrv_can_store_new_dirty_bitmap interface. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-bitmap.c | 40 block/qcow2.c| 1 + block/qcow2.h| 4 3 files changed, 45 insertions(+) diff --git a/block/qcow2-bitmap.

[Qemu-devel] [PATCH 05/24] block: fix bdrv_dirty_bitmap_granularity signature

2016-12-21 Thread Vladimir Sementsov-Ogievskiy
Make getter signature const-correct. This allows other functions with const dirty bitmap parameter use bdrv_dirty_bitmap_granularity(). Reviewed-by: Eric Blake Reviewed-by: John Snow Reviewed-by: Kevin Wolf Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 2 +- i

[Qemu-devel] [PATCH 04/24] tests: add hbitmap iter test

2016-12-21 Thread Vladimir Sementsov-Ogievskiy
Test that hbitmap iter is resistant to bitmap resetting. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev Reviewed-by: Max Reitz Reviewed-by: John Snow --- tests/test-hbitmap.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tests/test-hbitmap

[Qemu-devel] [PATCH 23/24] qcow2: add .bdrv_remove_persistent_dirty_bitmap

2016-12-21 Thread Vladimir Sementsov-Ogievskiy
Realize .bdrv_remove_persistent_dirty_bitmap interface. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-bitmap.c | 40 block/qcow2.c| 1 + block/qcow2.h| 3 +++ 3 files changed, 44 insertions(+) diff --git a/block/qcow2-bitm

[Qemu-devel] [PATCH 12/24] block/dirty-bitmap: add bdrv_dirty_bitmap_next()

2016-12-21 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/dirty-bitmap.c | 7 +++ include/block/dirty-bitmap.h | 3 +++ 2 files changed, 10 insertions(+) diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c index 4d026df..fe34d48 100644 --- a/block/dirty-bitma

[Qemu-devel] [PATCH 14/24] block: add bdrv_can_store_new_dirty_bitmap

2016-12-21 Thread Vladimir Sementsov-Ogievskiy
This will be needed to check some restrictions before making bitmap persistent in qmp-block-dirty-bitmap-add (this functionality will be added by future patch) Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block.c | 22 ++ include/b

[Qemu-devel] [PULL v1 6/7] crypto: support HMAC algorithms based on nettle

2016-12-21 Thread Daniel P. Berrange
From: "Longpeng(Mike)" This patch add nettle-backed HMAC algorithms support Signed-off-by: Longpeng(Mike) Signed-off-by: Daniel P. Berrange --- crypto/hmac-nettle.c | 136 +-- 1 file changed, 133 insertions(+), 3 deletions(-) diff --git a/crypt

[Qemu-devel] [PULL v1 3/7] crypto: add HMAC algorithms framework

2016-12-21 Thread Daniel P. Berrange
From: "Longpeng(Mike)" This patch introduce HMAC algorithms framework. Signed-off-by: Longpeng(Mike) Signed-off-by: Daniel P. Berrange --- crypto/Makefile.objs | 4 ++ crypto/hmac-gcrypt.c | 45 ++ crypto/hmac-glib.c | 44 ++ crypto/hmac-nettle.c | 45 ++

[Qemu-devel] [PULL v1 4/7] crypto: support HMAC algorithms based on libgcrypt

2016-12-21 Thread Daniel P. Berrange
From: "Longpeng(Mike)" This patch add HMAC algorithms based on libgcrypt support Signed-off-by: Longpeng(Mike) Signed-off-by: Daniel P. Berrange --- crypto/hmac-gcrypt.c | 111 ++- 1 file changed, 109 insertions(+), 2 deletions(-) diff --git a/

[Qemu-devel] [PULL v1 2/7] crypto: add 3des-ede support when using libgcrypt/nettle

2016-12-21 Thread Daniel P. Berrange
From: "Longpeng(Mike)" Libgcrypt and nettle support 3des-ede, so this patch add 3des-ede support when using libgcrypt or nettle. Reviewed-by: Gonglei Signed-off-by: Longpeng(Mike) Signed-off-by: Daniel P. Berrange --- crypto/cipher-gcrypt.c | 6 +++ crypto/cipher-nettle.c | 37 +++

[Qemu-devel] [PULL v1 5/7] crypto: support HMAC algorithms based on glib

2016-12-21 Thread Daniel P. Berrange
From: "Longpeng(Mike)" This patch add glib-backed HMAC algorithms support Signed-off-by: Longpeng(Mike) Signed-off-by: Daniel P. Berrange --- crypto/hmac-glib.c | 122 + 1 file changed, 122 insertions(+) diff --git a/crypto/hmac-glib.c b/cr

[Qemu-devel] [PULL v1 1/7] cipher: fix leak on initialization error

2016-12-21 Thread Daniel P. Berrange
From: Marc-André Lureau On error path, ctx may be leaked. Assign ctx earlier, and call qcrypto_cipher_free() on error. Spotted thanks to ASAN. Signed-off-by: Marc-André Lureau Signed-off-by: Daniel P. Berrange --- crypto/cipher-nettle.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions

[Qemu-devel] [PULL v1 7/7] crypto: add HMAC algorithms testcases

2016-12-21 Thread Daniel P. Berrange
From: "Longpeng(Mike)" This patch add HMAC algorithms testcases Signed-off-by: Longpeng(Mike) Signed-off-by: Daniel P. Berrange --- tests/Makefile.include | 2 + tests/test-crypto-hmac.c | 266 +++ 2 files changed, 268 insertions(+) create mode

[Qemu-devel] [PULL v1 0/7] Merge qcrypto 2016/12/21

2016-12-21 Thread Daniel P. Berrange
The following changes since commit 82ecffa8c050bf5bbc13329e9b65eac1caa5b55c: Open 2.9 development tree (2016-12-20 16:20:16 +) are available in the git repository at: git://github.com/berrange/qemu tags/pull-qcrypto-2016-12-21-1 for you to fetch changes up to d1c7d71dcec794de02838cbb96a

Re: [Qemu-devel] [PATCH for-2.9 V4 2/2] Add a new qmp command to do checkpoint, get replication error

2016-12-21 Thread Eric Blake
On 12/21/2016 12:56 AM, Zhang Chen wrote: >>> +void qmp_xen_get_replication_error(Error **errp) >>> +{ >>> +replication_get_error_all(errp); >>> +} >> Is this trying to cause a replication error, or is it trying to collect >> status on whether an error has occurred? The name 'get

[Qemu-devel] [PATCH 07/10] aio-posix: remove walking_handlers, protecting AioHandler list with list_lock

2016-12-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- aio-posix.c | 64 - 1 file changed, 38 insertions(+), 26 deletions(-) diff --git a/aio-posix.c b/aio-posix.c index f83b7af..9b13182 100644 --- a/aio-posix.c +++ b/aio-posix.c @@ -16,7 +16,7 @@ #include

Re: [Qemu-devel] [RFC 0/7] Move accel, KVM, Xen, qtest files to accel/ subdir

2016-12-21 Thread Eduardo Habkost
On Wed, Dec 21, 2016 at 02:47:54PM +0100, Paolo Bonzini wrote: > > > On 21/12/2016 14:14, Eduardo Habkost wrote: > > On Wed, Dec 21, 2016 at 12:21:44PM +0100, Paolo Bonzini wrote: > >> > >> > >> On 20/12/2016 18:43, Eduardo Habkost wrote: > >>> This moves the KVM and Xen files to the an accel/ su

[Qemu-devel] [PATCH 04/10] qemu-thread: optimize QemuLockCnt with futexes on Linux

2016-12-21 Thread Paolo Bonzini
This is complex, but I think it is reasonably documented in the source. Signed-off-by: Paolo Bonzini --- docs/lockcnt.txt | 9 +- include/qemu/futex.h | 36 ++ include/qemu/thread.h| 2 + util/lockcnt.c | 282 +++ uti

[Qemu-devel] [PATCH 08/10] aio-win32: remove walking_handlers, protecting AioHandler list with list_lock

2016-12-21 Thread Paolo Bonzini
Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- aio-win32.c | 73 +++-- 1 file changed, 47 insertions(+), 26 deletions(-) diff --git a/aio-win32.c b/aio-win32.c index 1ad459d..900524c 100644 --- a/aio-win32.c +++ b/aio-win32.

Re: [Qemu-devel] [PATCH for-2.9 v3 0/5] Sheepdog cleanups

2016-12-21 Thread Paolo Bonzini
On 29/11/2016 12:32, Paolo Bonzini wrote: > Cleaning up the code and removing duplication makes it simpler to > later adapt it for the multiqueue work. > > Tested against sheepdog 1.0. I also tested taking snapshots and reverting > to older snapshots, but the latter only worked with "dog vdi ro

[Qemu-devel] [PATCH 09/10] aio: document locking

2016-12-21 Thread Paolo Bonzini
Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- docs/multiple-iothreads.txt | 13 + include/block/aio.h | 32 2 files changed, 21 insertions(+), 24 deletions(-) diff --git a/docs/multiple-iothreads.txt b/docs/multiple-iothreads.

[Qemu-devel] [PATCH 06/10] aio: tweak walking in dispatch phase

2016-12-21 Thread Paolo Bonzini
Preparing for the following patch, use QLIST_FOREACH_SAFE and modify the placement of walking_handlers increment/decrement. Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- aio-posix.c | 26 -- aio-win32.c | 26 -- 2 files changed, 24

[Qemu-devel] [PATCH 02/10] qemu-thread: introduce QemuLockCnt

2016-12-21 Thread Paolo Bonzini
A QemuLockCnt comprises a counter and a mutex, with primitives to increment and decrement the counter, and to take and release the mutex. It can be used to do lock-free visits to a data structure whenever mutexes would be too heavy-weight and the critical section is too long for RCU. This could b

[Qemu-devel] [PATCH 10/10] async: optimize aio_bh_poll

2016-12-21 Thread Paolo Bonzini
Avoid entering the slow path of qemu_lockcnt_dec_and_lock if no bottom half has to be deleted. Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- async.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/async.c b/async.c index 2305e11..0d218ab 100644 ---

Re: [Qemu-devel] [Qemu-block] [PATCH 4/4] block: Add VFIO based NVMe driver

2016-12-21 Thread Fam Zheng
On Wed, 12/21 11:59, Stefan Hajnoczi wrote: > On Wed, Dec 21, 2016 at 12:31:39AM +0800, Fam Zheng wrote: > > This is a new protocol driver that exclusively opens a host NVMe > > controller through VFIO. It achieves better latency than linux-aio. > > This is an interesting block driver to have for

[Qemu-devel] [PATCH v2 00/10] aio_context_acquire/release pushdown, part 1

2016-12-21 Thread Paolo Bonzini
This is the first step of pushing down the AioContext lock. Bottom halves are already protected by their own lock, use it also for walking_bh and for the handlers list (including walking_handlers). The (lock, walking_foo) pair is wrapped into the QemuLockCnt primitive. Paolo v1->v2: reb

[Qemu-devel] [PATCH 01/10] aio: rename bh_lock to list_lock

2016-12-21 Thread Paolo Bonzini
This will be used for AioHandlers too. There is going to be little or no contention, so it is better to reuse the same lock. Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- async.c | 20 ++-- include/block/aio.h | 2 +- 2 files changed, 11 insertions(

[Qemu-devel] [PATCH 03/10] aio: make ctx->list_lock a QemuLockCnt, subsuming ctx->walking_bh

2016-12-21 Thread Paolo Bonzini
This will make it possible to walk the list of bottom halves without holding the AioContext lock---and in turn to call bottom half handlers without holding the lock. Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- async.c | 35 --- inclu

[Qemu-devel] [PATCH 05/10] aio-posix: split aio_dispatch_handlers out of aio_dispatch

2016-12-21 Thread Paolo Bonzini
This simplifies the handling of dispatch_fds. Signed-off-by: Paolo Bonzini --- aio-posix.c | 43 +-- 1 file changed, 25 insertions(+), 18 deletions(-) diff --git a/aio-posix.c b/aio-posix.c index 1585571..25198d9 100644 --- a/aio-posix.c +++ b/aio-posix.c

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.8.0 is now available

2016-12-21 Thread Michael Roth
Quoting Holger Schranz (2016-12-20 23:18:00) > Hi Michael, > > could it be, that the link to qemu-2.8.0.tar.bz2 is linked to the > qemu-2.8.0-rc4.tar.bz2? The link for signature seems it is correct. Argh, yes only one link was updated. Both links are correct now. Thanks! > > Best regards > >

  1   2   >