Re: [Qemu-devel] [PATCH 05/20] arm: Move CPU files to target/ folder

2016-12-13 Thread Laurent Vivier
Le 14/12/2016 à 08:43, Thomas Huth a écrit : > On 13.12.2016 19:19, Peter Maydell wrote: >> On 9 December 2016 at 12:17, Thomas Huth wrote: >>> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c >>> index d4160df..60770d4 100644 >>> --- a/hw/arm/virt-acpi-build.c >>> +++ b/hw/arm/vir

Re: [Qemu-devel] [Qemu-stable] [PATCH v2] virtio-bus: Plug devices after features are negotiated

2016-12-13 Thread Cornelia Huck
On Tue, 13 Dec 2016 15:27:45 -0600 Michael Roth wrote: > Quoting Maxime Coquelin (2016-09-13 08:30:30) > > Currently, devices are plugged before features are negotiated. > > If the backend doesn't support VIRTIO_F_VERSION_1, the transport > > needs to rewind some settings. > > > > This is the ca

Re: [Qemu-devel] [PATCH 05/20] arm: Move CPU files to target/ folder

2016-12-13 Thread Thomas Huth
On 13.12.2016 19:19, Peter Maydell wrote: > On 9 December 2016 at 12:17, Thomas Huth wrote: >> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c >> index d4160df..60770d4 100644 >> --- a/hw/arm/virt-acpi-build.c >> +++ b/hw/arm/virt-acpi-build.c >> @@ -33,7 +33,7 @@ >> #include "qe

Re: [Qemu-devel] VNC LED state buggy, interop issue

2016-12-13 Thread Gerd Hoffmann
On Di, 2016-12-13 at 14:10 +0100, Pierre Ossman wrote: > On 13/12/16 09:06, Gerd Hoffmann wrote: > >> b) Remove the assumption from the code and the protocol. > > > > Patches are welcome. > > > > I was just aiming for a consensus on the intended behaviour, rather than > fix the bug right now. :

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-12-13 Thread Stefan Hajnoczi
On Wed, Dec 14, 2016 at 12:06 AM, ashish mittal wrote: > I am requesting feedback on the following design proposal for libqnio. > > This adds an access control mechanism between libqnio client and > server. It is not a full client-server authentication model, and it is > not intended to substitute

Re: [Qemu-devel] [PATCH] display: virtio-gpu-3d: check virgl capabilities max_size

2016-12-13 Thread P J P
+-- On Tue, 13 Dec 2016, Marc-André Lureau wrote --+ | > -resp = g_malloc(sizeof(*resp) + max_size); | > +if (!max_size) { | > +cmd->error = VIRTIO_GPU_RESP_ERR_INVALID_PARAMETER; | > +return; | > +} | > | > +resp = g_malloc(sizeof(*resp) + max_size); | > resp->

[Qemu-devel] [PATCH] display: virtio-gpu-3d: check virgl capabilities max_size

2016-12-13 Thread P J P
From: Prasad J Pandit Virtio GPU device while processing 'VIRTIO_GPU_CMD_GET_CAPSET' command, retrieves the maximum capabilities size to fill in the response object. It continues to fill in capabilities even if retrieved 'max_size' is zero(0), thus resulting in OOB access. Add check to avoid it.

[Qemu-devel] [PATCH] bugfix: vm halt when in reset looping

2016-12-13 Thread hangaohuai
reset mc146818rtc device when RESET event happens. Fix the problem: 1. Guest boot the second cpu, set CMOS_RESET_CODE 0x0a to protect selfboot; 2. VM being reset by others, hmp_system_reset; 3. seabios resume check the CMOS_RESET_CODE, if 0x0a, jump to the BDA resume execution by jump v

[Qemu-devel] QEMU po files / translations (was: Any QEMU 2.8 release blockers?)

2016-12-13 Thread Stefan Weil
On 12/13/16 22:52, Stefan Hajnoczi wrote: I've sent a patch to the list and CCed you. I ran make -C po update. Weird that the line numbers are hardcoded in the .po file format. An addr2line type tool would have been better to avoid the constant outdated line numbers. That said, I don't know a

Re: [Qemu-devel] [PATCH] Update language files for QEMU 2.8.0

2016-12-13 Thread Stefan Weil
On 12/13/16 22:49, Stefan Hajnoczi wrote: Update translation files (change created via 'make -C po update'). Signed-off-by: Stefan Hajnoczi --- po/bg.po | 40 po/de_DE.po| 40 ++-- po/fr_FR.po| 40 ++

[Qemu-devel] Lock contention in QEMU

2016-12-13 Thread Weiwei Jia
Hi Stefan, I find the timeslice of vCPU thread in QEMU/KVM is unstable when there are lots of read requests (for example, read 4KB each time (8GB in total) from one file) from Guest OS. I also find that this phenomenon may be caused by lock contention in QEMU layer. I find this problem under follo

[Qemu-devel] [Bug 1641637] Re: incorrect illegal SSE3 instructions reporting on x86_64

2016-12-13 Thread Ziyue Yang
Hi Jie, I can reproduce this by single-stepping through the bug1 testing code using gdb, and SIGILL was encountered when executing the pabsb SSE3 instruction. Maybe it was due to QEMU's translator, I'll look further into it. ** Changed in: qemu Status: New => Confirmed ** Changed in: qemu

Re: [Qemu-devel] [RFC PATCH 01/13] intel_iommu: allocate new key when creating new address space

2016-12-13 Thread Liu, Yi L
> -Original Message- > From: Qemu-devel [mailto:qemu-devel-bounces+yi.l.liu=intel@nongnu.org] On > Behalf Of Peter Xu > Sent: Wednesday, December 14, 2016 11:06 AM > To: Liu, Yi L ; Jason Wang > Cc: Lan, Tianyu ; Tian, Kevin ; > m...@redhat.com; jan.kis...@siemens.com; bd.a...@gmail.co

Re: [Qemu-devel] [RFC PATCH 01/13] intel_iommu: allocate new key when creating new address space

2016-12-13 Thread Peter Xu
On Mon, Dec 12, 2016 at 04:16:50PM +0800, Liu, Yi L wrote: > On Tue, Dec 06, 2016 at 06:36:16PM +0800, Peter Xu wrote: > > From: Jason Wang > > > > We use the pointer to stack for key for new address space, this will > > break hash table searching, fixing by g_malloc() a new key instead. > > > >

[Qemu-devel] [PATCH v2] audio: es1370: add exit function

2016-12-13 Thread Li Qiang
From: Li Qiang Currently the es1370 device emulation doesn't have a exit function, hot unplug this device will leak some memory. Add a exit function to avoid this. Signed-off-by: Li Qiang --- Changes since the v1: close the streams hw/audio/es1370.c | 19 +++ 1 file changed,

[Qemu-devel] [PATCH v2] audio: ac97: add exit function

2016-12-13 Thread Li Qiang
From: Li Qiang Currently the ac97 device emulation doesn't have a exit function, hot unplug this device will leak some memory. Add a exit function to avoid this. Signed-off-by: Li Qiang --- Changes since the v1: close the streams hw/audio/ac97.c | 18 ++ 1 file changed, 18 in

Re: [Qemu-devel] [PATCH v3 1/2] intel_iommu: check validity for GAW bits in CE

2016-12-13 Thread Peter Xu
On Wed, Dec 14, 2016 at 04:48:42AM +0200, Michael S. Tsirkin wrote: > On Wed, Dec 14, 2016 at 10:09:04AM +0800, Peter Xu wrote: > > Currently vt-d Context Entry (CE) only allows 39/48 bits address width. > > If guest software configured more than that, we complain and report. > > > > Signed-off-by

[Qemu-devel] [PATCH] target-i386: Add Intel SHA_NI instruction support.

2016-12-13 Thread Yi Sun
Add SHA_NI feature bit. Its spec can be found at: https://software.intel.com/sites/default/files/managed/39/c5/325462-sdm-vol-1-2abcd-3abcd.pdf Signed-off-by: Yi Sun --- target-i386/cpu.c | 2 +- target-i386/cpu.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/target-i386/c

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-12-13 Thread David Gibson
On Tue, Dec 13, 2016 at 02:25:44PM +0200, Marcel Apfelbaum wrote: > On 12/07/2016 06:42 PM, Andrea Bolognani wrote: > > [Added Marcel to CC] > > > > > Hi, > > Sorry for the late reply. > > > On Wed, 2016-12-07 at 15:11 +1100, David Gibson wrote: > > > > Is the difference between q35 and pserie

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-12-13 Thread David Gibson
On Tue, Dec 13, 2016 at 09:15:37AM -0600, Benjamin Herrenschmidt wrote: > On Tue, 2016-12-13 at 14:25 +0200, Marcel Apfelbaum wrote: > > > > Hrm, the suggestion of providing both a vanilla-PCI and PCI-E host > > > > bridge came up before.  I think one of us spotted a problem with that, > > > > but

Re: [Qemu-devel] [PATCH v3 1/2] intel_iommu: check validity for GAW bits in CE

2016-12-13 Thread Michael S. Tsirkin
On Wed, Dec 14, 2016 at 10:09:04AM +0800, Peter Xu wrote: > Currently vt-d Context Entry (CE) only allows 39/48 bits address width. > If guest software configured more than that, we complain and report. > > Signed-off-by: Peter Xu > --- > hw/i386/intel_iommu.c | 17 - >

Re: [Qemu-devel] [PATCH] rtl8139: correctly handle PHY reset

2016-12-13 Thread Jason Wang
On 2016年12月14日 03:44, Hervé Poussineau wrote: According to datasheet: "[Bit 15 of Basic Mode Control Register] sets the status and control registers of the PHY (register 0062-0074) in a default state. This bit is self-clearing. 1 = software reset; 0 = normal operation." This fixes the netcard

[Qemu-devel] [PATCH v3 0/2] VT-d supports 48 bits address width

2016-12-13 Thread Peter Xu
V3: - renaming "aw-bits" to "x-aw-bits", and clarify that this parameter is experimental [AlexW] (V2 is mostly a re-written of V1, so no change log is appended) The first patch did some check to make sure the CE GAW bits are always valid. The second patch extended VT-d GAW (Guest Address Width

[Qemu-devel] [PATCH v3 1/2] intel_iommu: check validity for GAW bits in CE

2016-12-13 Thread Peter Xu
Currently vt-d Context Entry (CE) only allows 39/48 bits address width. If guest software configured more than that, we complain and report. Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 17 - hw/i386/intel_iommu_internal.h | 2 ++ 2 files changed, 18 insertions(+

[Qemu-devel] [PATCH v3 2/2] intel_iommu: provide "x-aw-bits" parameter

2016-12-13 Thread Peter Xu
Previously vt-d codes only supports 39 bits iova address width. This patch provide a new parameter for Intel IOMMU to extend its address width to 48 bits (though the default is still 39). After enabling larger address width (48), we should be able to map larger iova addresses in the guest. To chec

Re: [Qemu-devel] [PATCH for-2.9 v2 2/2] intel_iommu: provide "aw-bits" parameter

2016-12-13 Thread Peter Xu
On Tue, Dec 13, 2016 at 06:40:28AM -0700, Alex Williamson wrote: > On Tue, 13 Dec 2016 15:25:03 +0800 > Peter Xu wrote: > > > Previously vt-d codes only supports 39 bits iova address width. This > > patch provide a new parameter for Intel IOMMU to extend its address > > width to 48 bits. > > > >

Re: [Qemu-devel] [PATCH for-2.9 V3 1/3] Migration: Don't load vmdesc when xen is enabled

2016-12-13 Thread Stefano Stabellini
On Fri, 9 Dec 2016, Zhang Chen wrote: > Xen doesn't need this. Could you please elaborate a bit more on what is the problem exactly, and why we don't have any issues with migration with Xen today (COLO use-case aside)? > Signed-off-by: Zhang Chen > --- > migration/savevm.c | 4 > 1 file c

Re: [Qemu-devel] [PATCH] hw/ppc/spapr: Fix boot path of usb-host storage devices

2016-12-13 Thread David Gibson
On Tue, Dec 13, 2016 at 01:44:36PM +0100, Thomas Huth wrote: > When passing through a USB storage device to a pseries guest, it > is currently not possible to automatically boot from the device > if the "bootindex" property has been specified, too (e.g. when using > "-device nec-usb-xhci -device us

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-12-13 Thread ashish mittal
Hi, I am requesting feedback on the following design proposal for libqnio. This adds an access control mechanism between libqnio client and server. It is not a full client-server authentication model, and it is not intended to substitute an authentication mechanism. We wanted to check if the fol

Re: [Qemu-devel] [PATCH 02/54] char: use a const CharDriver

2016-12-13 Thread Eric Blake
On 12/12/2016 04:42 PM, Marc-André Lureau wrote: > No need to allocate & copy fileds, let's use static const struct s/fileds/fields/ > instead. > > Signed-off-by: Marc-André Lureau > --- > backends/baum.c | 8 +++- > backends/msmouse.c| 7 +++- > backends/testdev.c| 7 +++-

Re: [Qemu-devel] [Nbd] [Qemu-block] [PATCH] doc: Propose NBD_FLAG_INIT_ZEROES extension

2016-12-13 Thread Eric Blake
On 12/13/2016 06:18 AM, Wouter Verhelst wrote: > On Tue, Dec 13, 2016 at 08:38:12AM +0100, Kevin Wolf wrote: >> Am 12.12.2016 um 19:12 hat Wouter Verhelst geschrieben: >>> I'm not opposed to this proposal, per se, but there seems to be some >>> disagreement (by Kevin, for instance) on whether this

Re: [Qemu-devel] Any QEMU 2.8 release blockers?

2016-12-13 Thread Stefan Hajnoczi
On Tue, Dec 13, 2016 at 9:39 PM, Stefan Weil wrote: > On 12/13/16 22:04, Stefan Hajnoczi wrote: >> >> On Tue, Dec 13, 2016 at 10:01 AM, Stefan Hajnoczi >> wrote: >>> >>> On Fri, Dec 9, 2016 at 3:34 PM, Stefan Hajnoczi >>> wrote: Hi folks, How is QEMU 2.8.0-rc3 holding up? >>>

[Qemu-devel] [PATCH 10/11] hw/arm/virt: remove VirtGuestInfo

2016-12-13 Thread Andrew Jones
by moving VirtGuestInfo.fw_cfg to VirtMachineState. This is the mach-virt equivalent of "pc: Move PcGuestInfo.fw_cfg to PCMachineState" and "pc: Eliminate PcGuestInfo struct" combined. Signed-off-by: Andrew Jones --- hw/arm/virt-acpi-build.c | 7 +++ hw/arm/virt.c| 18 +++---

[Qemu-devel] [PATCH 11/11] hw/arm/virt-acpi-build: Don't incorrectly claim architectural timer to be edge-triggered

2016-12-13 Thread Andrew Jones
This is the ACPI equivalent to "hw/arm/virt: Don't incorrectly claim architectural timer to be edge-triggered" which fixes the DT for machine types 2.9 and later. Signed-off-by: Andrew Jones --- hw/arm/virt-acpi-build.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) d

[Qemu-devel] [PATCH 08/11] hw/arm/virt-acpi-build: remove redundant members from VirtGuestInfo

2016-12-13 Thread Andrew Jones
Now that we pass VirtMachineState, and guest-info is just part of that state, we can remove all the redundant members and access the VirtMachineState directly. Signed-off-by: Andrew Jones --- hw/arm/virt-acpi-build.c | 72 +--- hw/arm/virt.c

[Qemu-devel] [PATCH 09/11] hw/arm/virt-acpi-build: don't save VirtGuestInfo on AcpiBuildState

2016-12-13 Thread Andrew Jones
We can get to VirtMachineState without the need for saving a pointer on AcpiBuildState. This is the mach-virt equivalent to "acpi: Don't save PcGuestInfo on AcpiBuildState" Signed-off-by: Andrew Jones --- hw/arm/virt-acpi-build.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff

[Qemu-devel] [PATCH 05/11] hw/arm/virt: remove include/hw/arm/virt-acpi-build.h

2016-12-13 Thread Andrew Jones
include/hw/arm/virt-acpi-build.h is only used for VirtGuestInfo, which doesn't even necessarily have to be ACPI specific. Move VirtGuestInfo to include/hw/arm/virt.h, allowing us to remove include/hw/arm/virt-acpi-build.h, and to prepare for even more code motion. Signed-off-by: Andrew Jones ---

[Qemu-devel] [PATCH 06/11] hw/arm/virt: move VirtMachineState/Class to virt.h

2016-12-13 Thread Andrew Jones
In preparation to share more Virt machine state than just guest-info with other mach-virt source files, move the State and Class structures to virt.h Signed-off-by: Andrew Jones --- hw/arm/virt.c | 51 +++ include/hw/arm/virt.h | 39 +++

[Qemu-devel] [PATCH 07/11] hw/arm/virt: pass VirtMachineState instead of VirtGuestInfo

2016-12-13 Thread Andrew Jones
Only two functions take VirtGuestInfo parameters. Now that guest-info is part of VirtMachineState, and VirtMachineState is defined in the virt header, pass that instead. Signed-off-by: Andrew Jones --- hw/arm/virt-acpi-build.c | 3 ++- hw/arm/virt.c| 8 include/hw/arm/virt.h

[Qemu-devel] [PATCH 04/11] hw/arm/virt: eliminate struct VirtGuestInfoState

2016-12-13 Thread Andrew Jones
Instead of allocating a new struct just for VirtGuestInfo and the machine_done Notifier, place them inside VirtMachineState. This is the mach-virt equivalent of "pc: Eliminate struct PcGuestInfoState" Suggested-by: Eduardo Habkost Signed-off-by: Andrew Jones --- hw/arm/virt.c

[Qemu-devel] [PATCH 03/11] hw/arm/virt: use VirtMachineState.smp_cpus

2016-12-13 Thread Andrew Jones
Most places we need smp_cpus we use vms->smp_cpus already. This cleanup makes sure we do everywhere, preparing for the removal of the global smp_cpus someday. Signed-off-by: Andrew Jones --- hw/arm/virt.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/arm/v

[Qemu-devel] [PATCH] Update language files for QEMU 2.8.0

2016-12-13 Thread Stefan Hajnoczi
Update translation files (change created via 'make -C po update'). Signed-off-by: Stefan Hajnoczi --- po/bg.po | 40 po/de_DE.po| 40 ++-- po/fr_FR.po| 40 ++-- po/hu.po

[Qemu-devel] [PATCH 01/11] hw/arm/virt: parameter passing cleanups

2016-12-13 Thread Andrew Jones
Some simple cleanups made possible by "hw/arm/virt: Merge VirtBoardInfo and VirtMachineState" Signed-off-by: Andrew Jones --- hw/arm/virt.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 7eec50a82494..d451bc4f6b9b 1006

[Qemu-devel] [PATCH 00/11] Remove VirtGuestInfo

2016-12-13 Thread Andrew Jones
This series is based on Peter's qemu-arm gicv3-virt branch. It's main goal (patches 04-10), which was suggested by Eduardo, is to remove an unnecessary structure, VirtGuestInfo, which is a maintenance burden, as it requires duplicating Virt machine state. Additionally patches 01-03 do some mach-vir

[Qemu-devel] [PATCH 02/11] hw/arm/virt: use VirtMachineState.gic_version

2016-12-13 Thread Andrew Jones
machvirt_init may need to probe for the gic version. If so, then make sure the result is written to VirtMachineState. With the state up to date, use it instead of a local variable. This is a cleanup that prepares for VirtMachineState to be passed to functions even outside hw/arm/virt.c Signed-off-

Re: [Qemu-devel] Any QEMU 2.8 release blockers?

2016-12-13 Thread Stefan Weil
On 12/13/16 22:04, Stefan Hajnoczi wrote: On Tue, Dec 13, 2016 at 10:01 AM, Stefan Hajnoczi wrote: On Fri, Dec 9, 2016 at 3:34 PM, Stefan Hajnoczi wrote: Hi folks, How is QEMU 2.8.0-rc3 holding up? I'm not aware of release blockers. QEMU 2.8.0 will be released on Tuesday, December 13th if n

Re: [Qemu-devel] Any QEMU 2.8 release blockers?

2016-12-13 Thread Michael Roth
Quoting Stefan Hajnoczi (2016-12-13 15:04:24) > On Tue, Dec 13, 2016 at 10:01 AM, Stefan Hajnoczi wrote: > > On Fri, Dec 9, 2016 at 3:34 PM, Stefan Hajnoczi wrote: > >> Hi folks, > >> How is QEMU 2.8.0-rc3 holding up? > >> > >> I'm not aware of release blockers. QEMU 2.8.0 will be released on >

Re: [Qemu-devel] [Qemu-stable] [PATCH v2] virtio-bus: Plug devices after features are negotiated

2016-12-13 Thread Michael Roth
Quoting Maxime Coquelin (2016-09-13 08:30:30) > Currently, devices are plugged before features are negotiated. > If the backend doesn't support VIRTIO_F_VERSION_1, the transport > needs to rewind some settings. > > This is the case for CCW, for which a post_plugged callback had > been introduced,

Re: [Qemu-devel] [PATCH 00/23] arm: Add virtualization to GICv3, and enable EL2 on 64-bit CPUs

2016-12-13 Thread Andrew Jones
On Tue, Dec 13, 2016 at 10:36:01AM +, Peter Maydell wrote: > This patchset adds support for the Virtualization extensions to QEMU's > GICv3 emulation. This was the last missing piece that was stopping > us from turning on the EL2 support in the CPU model, so the patchset > also adds support for

Re: [Qemu-devel] [PATCH for-2.9 17/17] target-i386: Implement query-cpu-model-expansion QMP command

2016-12-13 Thread Eduardo Habkost
On Tue, Dec 13, 2016 at 08:20:39PM +0100, Markus Armbruster wrote: [...] > >> > +if (type == CPU_MODEL_EXPANSION_TYPE_STATIC) { > >> > +/* static expansion force migration-unsafe features off: */ > >> > +ret->q_static = ret->migration_safe = true; > >> > +qdict_del(prop

Re: [Qemu-devel] Any QEMU 2.8 release blockers?

2016-12-13 Thread Stefan Hajnoczi
On Tue, Dec 13, 2016 at 10:01 AM, Stefan Hajnoczi wrote: > On Fri, Dec 9, 2016 at 3:34 PM, Stefan Hajnoczi wrote: >> Hi folks, >> How is QEMU 2.8.0-rc3 holding up? >> >> I'm not aware of release blockers. QEMU 2.8.0 will be released on >> Tuesday, December 13th if nothing comes up. It will be t

Re: [Qemu-devel] [RFC] qmp: query-device-slots command

2016-12-13 Thread Eduardo Habkost
On Tue, Dec 13, 2016 at 08:51:34PM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Tue, Dec 13, 2016 at 12:04:17PM +0100, Markus Armbruster wrote: > >> Quick interface review only: > >> > >> Eduardo Habkost writes: > >> > >> > This adds a new command to QMP: query-device-slo

Re: [Qemu-devel] [RFC] qmp: query-device-slots command

2016-12-13 Thread Markus Armbruster
Eduardo Habkost writes: > On Tue, Dec 13, 2016 at 12:04:17PM +0100, Markus Armbruster wrote: >> Quick interface review only: >> >> Eduardo Habkost writes: >> >> > This adds a new command to QMP: query-device-slots. It will allow >> > management software to query possible slots where devices ca

[Qemu-devel] [PATCH] rtl8139: correctly handle PHY reset

2016-12-13 Thread Hervé Poussineau
According to datasheet: "[Bit 15 of Basic Mode Control Register] sets the status and control registers of the PHY (register 0062-0074) in a default state. This bit is self-clearing. 1 = software reset; 0 = normal operation." This fixes the netcard detection failure in Minoca OS. Signed-off-by: He

Re: [Qemu-devel] [PATCH for-2.9 17/17] target-i386: Implement query-cpu-model-expansion QMP command

2016-12-13 Thread Markus Armbruster
Eduardo Habkost writes: > On Tue, Dec 13, 2016 at 11:16:01AM +0100, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > Implement query-cpu-model-expansion for target-i386. >> > >> > The code needs to be careful to handle non-migration-safe >> > features ("pmu" and "host-cache-info") ac

Re: [Qemu-devel] [PATCH v2] slirp, disas: Replace min/max with MIN/MAX macros

2016-12-13 Thread Markus Armbruster
Stefan Weil writes: > Am 13.12.2016 um 13:33 schrieb Laurent Vivier: >> Le 29/11/2016 à 16:07, Yuval Shaia a écrit : >>> diff --git a/slirp/slirp.h b/slirp/slirp.h >>> index a1f3139..3877f66 100644 >>> --- a/slirp/slirp.h >>> +++ b/slirp/slirp.h >>> @@ -292,9 +292,4 @@ int tcp_emu(struct socket *

Re: [Qemu-devel] [PATCH 05/20] arm: Move CPU files to target/ folder

2016-12-13 Thread Peter Maydell
On 9 December 2016 at 12:17, Thomas Huth wrote: > diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c > index d4160df..60770d4 100644 > --- a/hw/arm/virt-acpi-build.c > +++ b/hw/arm/virt-acpi-build.c > @@ -33,7 +33,7 @@ > #include "qemu/bitmap.h" > #include "trace.h" > #include "qo

Re: [Qemu-devel] [Qemu-ppc] [RFCv2 12/12] ppc: Rework CPU compatibility testing across migration

2016-12-13 Thread Greg Kurz
On Mon, 5 Dec 2016 15:09:16 +1100 David Gibson wrote: > On Fri, Dec 02, 2016 at 03:48:25PM +0100, Greg Kurz wrote: > > On Wed, 16 Nov 2016 09:17:55 +1100 > > David Gibson wrote: > > > > > Migrating between different CPU versions is quite complicated for ppc. > > > A long time ago, we ensure i

Re: [Qemu-devel] [PATCH] audio: es1370: add exit function

2016-12-13 Thread Marc-André Lureau
good, and could be better, see my ac97 review On Tue, Dec 13, 2016 at 11:57 AM Li Qiang wrote: > ping! > > 2016-11-29 18:48 GMT+08:00 Li Qiang : > > > From: Li Qiang > > > > Currently the es1370 device emulation doesn't have a exit function, > > hot unplug this device will leak some leak. Add a

Re: [Qemu-devel] [PATCH] audio: ac97: add exit function

2016-12-13 Thread Marc-André Lureau
Hi On Tue, Dec 13, 2016 at 11:56 AM Li Qiang wrote: > Ping! > > 2016-11-29 18:33 GMT+08:00 Li Qiang : > > > From: Li Qiang > > > > Currently the ac97 device emulation doesn't have a exit function, > > hot unplug this device will leak some leak. Add a exit function to > > avoid this. > > > > Sig

Re: [Qemu-devel] [PATCH 12/19] tests/tcg: Add tests-tcg hook in Makefile

2016-12-13 Thread Alex Bennée
Pranith Kumar writes: > You can call 'make tests-tcg' to build and run native tcg tests. > > Signed-off-by: Pranith Kumar This breaks the normal make check output: GTESTER tests/ptimer-test CC tests/tmp105-test.o CC tests/libqos/pci.o tests/libqos/pci.c:14:24: fatal error: lib

Re: [Qemu-devel] [PATCH kvm-unit-tests v8 03/10] arm/arm64: add some delay routines

2016-12-13 Thread Alex Bennée
Alex Bennée writes: > Andrew Jones writes: > >> Allow a thread to wait some specified amount of time. Can >> specify in cycles, usecs, and msecs. >> diff --git a/lib/arm/asm/processor.h b/lib/arm/asm/processor.h >> index 6b0d36b87817..857bdd96a3cc 100644 >> --- a/lib/arm/asm/processor.h >> +++

Re: [Qemu-devel] [PATCH kvm-unit-tests v8 03/10] arm/arm64: add some delay routines

2016-12-13 Thread Alex Bennée
Andrew Jones writes: > Allow a thread to wait some specified amount of time. Can > specify in cycles, usecs, and msecs. > > Signed-off-by: Andrew Jones > > --- > v8: rewrote basing on new sysreg framework. Also decided delay > functions warrant their own files (delay.[ch]) > --- > arm/Make

Re: [Qemu-devel] [PATCH] i386: amd_iommu: fix MMIO register count and access

2016-12-13 Thread Michael S. Tsirkin
On Tue, Dec 13, 2016 at 03:42:13PM +0530, P J P wrote: > +-- On Fri, 2 Dec 2016, P J P wrote --+ > | IOMMU MMIO registers are divided in two groups by their offsets. > | Low offsets(<0x2000) registers are grouped into 'amdvi_mmio_low' > | table and higher offsets(>=0x2000) registers are grouped int

Re: [Qemu-devel] [Nbd] [PATCH v5] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-12-13 Thread Alex Bligh
> On 13 Dec 2016, at 16:06, Wouter Verhelst wrote: > >> >> "If a server supports the `base:allocation` metadata context, then writing >> to an extent which has `NBD_STATE_HOLE` clear MUST NOT fail with ENOSPC >> unless for reasons specified in the definition of another context." > > That is es

Re: [Qemu-devel] [PATCH 20/20] Makefile.target: Targets now have to reside in the target/ folder

2016-12-13 Thread Paolo Bonzini
On 09/12/2016 13:27, Laurent Vivier wrote: > Le 09/12/2016 à 13:17, Thomas Huth a écrit : >> Now that all target CPU folders have been moved to target/, we >> do not need to support the old naming scheme of target-xxx >> anymore. >> >> Signed-off-by: Thomas Huth >> --- >> Makefile.target | 4 --

Re: [Qemu-devel] [PATCH v3 0/2] less confusing block file names

2016-12-13 Thread Kevin Wolf
Am 02.12.2016 um 20:48 hat Eric Blake geschrieben: > no real change from v2 other than trivial rebasing and R-by: > https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg07220.html > > but it's been more than a month since the last activity, and the > start of the release cycle is as good a tim

Re: [Qemu-devel] [PATCH 22/23] target-arm: Enable EL2 feature bit on A53 and A57

2016-12-13 Thread Edgar E. Iglesias
On Tue, Dec 13, 2016 at 10:36:23AM +, Peter Maydell wrote: > Enable the ARM_FEATURE_EL2 bit on Cortex-A52 and > Cortex-A57, since this is all now sufficiently implemented > to work with the GICv3. We provide the usual CPU property > to disable it for backwards compatibility with the older > vir

Re: [Qemu-devel] [PATCH v6 2/2] crypto: add virtio-crypto driver

2016-12-13 Thread Halil Pasic
On 12/12/2016 11:05 PM, Michael S. Tsirkin wrote: > On Mon, Dec 12, 2016 at 06:54:07PM +0800, Herbert Xu wrote: >> On Mon, Dec 12, 2016 at 06:25:12AM +, Gonglei (Arei) wrote: >>> Hi, Michael & Herbert >>> >>> Because the virtio-crypto device emulation had been in QEMU 2.8, >>> would you pleas

Re: [Qemu-devel] [PATCH 18/21] qmp: add x-debug-block-dirty-bitmap-sha256

2016-12-13 Thread Max Reitz
On 2016-11-22 at 18:26, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 5 + blockdev.c | 33 + include/block/dirty-bitmap.h | 2 ++ include/qemu/hbitmap.h | 8 +

Re: [Qemu-devel] [Nbd] [PATCH v5] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-12-13 Thread Wouter Verhelst
On Tue, Dec 13, 2016 at 03:24:25PM +, Alex Bligh wrote: > Wouter, > > The spec should only specify how to select a particular namespace, and > > then leave all parsing rules of query strings up to the namespace > > specification. > > I'm not quite sure why you want that, Let's say you want to

Re: [Qemu-devel] [PATCH] display: virtio-gpu-3d: check virgl capabilities max_size

2016-12-13 Thread Marc-André Lureau
Hi On Tue, Dec 13, 2016 at 5:27 PM P J P wrote: > +-- On Tue, 13 Dec 2016, Gerd Hoffmann wrote --+ > | I guess we want throw an error (VIRTIO_GPU_RESP_ERR_INVALID_PARAMETER) > | in the error case then instead of leaving resp->hdr.type unset. > > I see, okay. Does the patch below look okay? > >

Re: [Qemu-devel] [RFC] qmp: query-device-slots command

2016-12-13 Thread Eduardo Habkost
On Tue, Dec 13, 2016 at 04:15:18PM +0200, Marcel Apfelbaum wrote: > On 12/13/2016 02:42 PM, Eduardo Habkost wrote: > > On Tue, Dec 13, 2016 at 12:04:17PM +0100, Markus Armbruster wrote: > > > Quick interface review only: > > > > > > Eduardo Habkost writes: > > > > > > > This adds a new command t

Re: [Qemu-devel] [PATCH v2] slirp, disas: Replace min/max with MIN/MAX macros

2016-12-13 Thread Laurent Vivier
On 29/11/2016 16:07, Yuval Shaia wrote: > Signed-off-by: Yuval Shaia Reviewed-by: Laurent Vivier > --- > v0 -> v1: > * Remove unndeeded "include" as suggested by Fam Zheng > * Change commit message's prefix as suggested by Markus Armbruster > * Utilize MIN macro in two extra

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-12-13 Thread Benjamin Herrenschmidt
On Tue, 2016-12-13 at 14:25 +0200, Marcel Apfelbaum wrote: > > > Hrm, the suggestion of providing both a vanilla-PCI and PCI-E host > > > bridge came up before.  I think one of us spotted a problem with that, > > > but I don't recall what it was now.  I guess one is how libvirt would > > > map it's

Re: [Qemu-devel] [PATCH RFC 0/1] Allow storing the qcow2 L2 cache in disk

2016-12-13 Thread Alberto Garcia
On Tue 13 Dec 2016 02:44:26 PM CET, Max Reitz wrote: But leaving that aside, would that improve anything? I don't think the cache itself adds any significant overhead here, IIRC even in your presentation at KVM Forum 2015 qcow2 was comparable to raw as long as all L2 tables wer

Re: [Qemu-devel] [Nbd] [PATCH v5] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-12-13 Thread Alex Bligh
Wouter, >> But actually, why do we need to be so mean? Why can't we assume >> that if NBD_OPT_SET_META_CONTEXT is not sent, then all the metadata >> contexts should be selected? > > No. If no metadata contexts have been negotiated, then no metadata > context IDs were assigned to contexts, so ther

[Qemu-devel] [PATCH] add fio plugin

2016-12-13 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 3 +- contrib/fio/Makefile | 62 +++ contrib/fio/README| 13 ++ contrib/fio/fio.c | 404 ++ contrib/fio/qemu.fio | 26 +++ contrib/fio/uninclude.awk | 78 ++

[Qemu-devel] [throwaway PATCH] add fio plugin

2016-12-13 Thread Paolo Bonzini
All of the infrastructure is a bit hackish, which is why I've marked this as throwaway, but perhaps someone else would like to use it (or even revive the libtool infrastructure so that it can be included in QEMU). I tested it with fio 2.8 and the master branch. Support for driver options is minim

Re: [Qemu-devel] [Nbd] [PATCH v5] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-12-13 Thread Wouter Verhelst
Alex, (leaving out obvious grammar/language fixes that I have no problem with) On Tue, Dec 13, 2016 at 02:09:19PM +, Alex Bligh wrote: > Wouter, > > Some comments below: > > > On 12 Dec 2016, at 20:43, Wouter Verhelst wrote: > > > +## Metadata querying > > + > > +With the availability

Re: [Qemu-devel] VNC LED state buggy, interop issue

2016-12-13 Thread Pierre Ossman
On 13/12/16 14:15, Daniel P. Berrange wrote: gtk-vnc implements the LED state extension. For testing, I've now pushed my work to get TigerVNC to support this: https://github.com/CendioOssman/tigervnc/tree/ledstate It's implemented for the client and Xvnc. Regards -- Pierre Ossman

Re: [Qemu-devel] [PATCH for-2.9 2/2] intel_iommu: extend supported guest aw to 48 bits

2016-12-13 Thread Michael S. Tsirkin
On Tue, Dec 13, 2016 at 06:17:47AM -0700, Alex Williamson wrote: > On Tue, 13 Dec 2016 14:12:12 +0800 > Peter Xu wrote: > > > On Mon, Dec 12, 2016 at 10:48:28PM -0700, Alex Williamson wrote: > > > On Tue, 13 Dec 2016 13:24:29 +0800 > > > Peter Xu wrote: > > > > > > > On Mon, Dec 12, 2016 at 0

Re: [Qemu-devel] [Nbd] [PATCH v5] doc: Add NBD_CMD_BLOCK_STATUS extension (part 2)

2016-12-13 Thread Wouter Verhelst
On Tue, Dec 13, 2016 at 02:12:48PM +, Alex Bligh wrote: > > > On 12 Dec 2016, at 20:43, Wouter Verhelst wrote: > > > > +- `NBD_OPT_SET_META_CONTEXT` (11) > > + > > +Change the set of active metadata contexts. Issuing this command > > +replaces all previously-set metadata contexts; cl

Re: [Qemu-devel] [Nbd] [PATCH v5] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-12-13 Thread Alex Bligh
Stefan, > What about querying "base:" if the NBD spec adds more standard metadata > contexts in the future? "base:" does not "uniquely identify a server > implementation" but it should still be possible to query it so that > additional contexts can be added to this spec in the future. > > Is the

Re: [Qemu-devel] [PATCH] hw/ppc/spapr: Fix boot path of usb-host storage devices

2016-12-13 Thread Thomas Huth
On 13.12.2016 14:52, Gerd Hoffmann wrote: > On Di, 2016-12-13 at 13:44 +0100, Thomas Huth wrote: >> When passing through a USB storage device to a pseries guest, it >> is currently not possible to automatically boot from the device >> if the "bootindex" property has been specified, too (e.g. when u

Re: [Qemu-devel] [PATCHv3 2/5] pseries: Stubs for HPT resizing

2016-12-13 Thread Laurent Vivier
On 12/12/2016 05:06, David Gibson wrote: > This introduces stub implementations of the H_RESIZE_HPT_PREPARE and > H_RESIZE_HPT_COMMIT hypercalls which we hope to add in a PAPR > extension to allow run time resizing of a guest's hash page table. It > also adds a new machine property for controlli

Re: [Qemu-devel] [PATCH] display: virtio-gpu-3d: check virgl capabilities max_size

2016-12-13 Thread P J P
+-- On Tue, 13 Dec 2016, Gerd Hoffmann wrote --+ | I guess we want throw an error (VIRTIO_GPU_RESP_ERR_INVALID_PARAMETER) | in the error case then instead of leaving resp->hdr.type unset. I see, okay. Does the patch below look okay? === diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virti

Re: [Qemu-devel] [RFC] qmp: query-device-slots command

2016-12-13 Thread Marcel Apfelbaum
On 12/13/2016 02:42 PM, Eduardo Habkost wrote: On Tue, Dec 13, 2016 at 12:04:17PM +0100, Markus Armbruster wrote: Quick interface review only: Eduardo Habkost writes: This adds a new command to QMP: query-device-slots. It will allow management software to query possible slots where devices c

Re: [Qemu-devel] [Nbd] [PATCH v5] doc: Add NBD_CMD_BLOCK_STATUS extension (part 2)

2016-12-13 Thread Alex Bligh
> On 12 Dec 2016, at 20:43, Wouter Verhelst wrote: > > +- `NBD_OPT_SET_META_CONTEXT` (11) > + > +Change the set of active metadata contexts. Issuing this command > +replaces all previously-set metadata contexts; clients must ensure > +that all metadata contexts they're interested in

Re: [Qemu-devel] [Nbd] [PATCH v5] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-12-13 Thread Alex Bligh
Wouter, Some comments below: > On 12 Dec 2016, at 20:43, Wouter Verhelst wrote: ... > +## Metadata querying > + > +With the availability of sparse storage formats, it is often needed to > +query the status of a particular range and read only those blocks of > +data that are actually present on t

Re: [Qemu-devel] [PATCH] hw/ppc/spapr: Fix boot path of usb-host storage devices

2016-12-13 Thread Gerd Hoffmann
On Di, 2016-12-13 at 13:44 +0100, Thomas Huth wrote: > When passing through a USB storage device to a pseries guest, it > is currently not possible to automatically boot from the device > if the "bootindex" property has been specified, too (e.g. when using > "-device nec-usb-xhci -device usb-host,h

Re: [Qemu-devel] [PATCH RFC 0/1] Allow storing the qcow2 L2 cache in disk

2016-12-13 Thread Max Reitz
On 2016-12-13 at 13:55, Alberto Garcia wrote: On Tue 13 Dec 2016 09:02:34 AM CET, Max Reitz wrote: I definitely like how simple your approach is, but from a design standpoint it is not exactly optimal, because O(n) for a cluster lookup is simply worse than O(1). It's actually not O(n) anymore

Re: [Qemu-devel] [PATCH for-2.9 v2 2/2] intel_iommu: provide "aw-bits" parameter

2016-12-13 Thread Alex Williamson
On Tue, 13 Dec 2016 15:25:03 +0800 Peter Xu wrote: > Previously vt-d codes only supports 39 bits iova address width. This > patch provide a new parameter for Intel IOMMU to extend its address > width to 48 bits. > > After enabling larger address width (48), we should be able to map > larger iova

Re: [Qemu-devel] [PATCH 17/19] tests/tcg: Move independent tests to misc dir

2016-12-13 Thread Alex Bennée
Pranith Kumar writes: > Signed-off-by: Pranith Kumar > --- > tests/tcg/misc/Makefile | 81 > +++ > tests/tcg/{ => misc}/linux-test.c | 0 > tests/tcg/{ => misc}/sha1.c | 0 > tests/tcg/{ => misc}/test-mmap.c | 0 > tests/tcg/{ => misc}/t

Re: [Qemu-devel] [PATCH 16/19] tests/tcg: Fix compilation of linux-test.c

2016-12-13 Thread Alex Bennée
Pranith Kumar writes: > Signed-off-by: Pranith Kumar > --- > tests/tcg/linux-test.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/tcg/linux-test.c b/tests/tcg/linux-test.c > index 24fce2b..e676e39 100644 > --- a/tests/tcg/linux-test.c > +++ b/tests/tcg/linux-test.c > @@ -41,

Re: [Qemu-devel] VNC LED state buggy, interop issue

2016-12-13 Thread Pierre Ossman
On 13/12/16 14:15, Daniel P. Berrange wrote: Btw, is there any client that implements this extension yet? I couldn't find anything. gtk-vnc implements the LED state extension. Not enough to actually do anything useful AFAICT. That would be up to the application using gtk-vnc. And I couldn'

Re: [Qemu-devel] [PATCH v5 00/19] Cleanup of TCG tests

2016-12-13 Thread Alex Bennée
Pranith Kumar writes: > Hello, > > This patch series cleans up the tcg tests in tests/tcg folder. > > The tests have bit-rotten and were not compiling or running. I fixed > the Makefiles to make them compile though there are tests which do not > pass. > > The motivation is to add litmus tests to

[Qemu-devel] [RFC PATCH] tests/docker: add basic user mapping support

2016-12-13 Thread Alex Bennée
Currently all docker builds are done by exporting a tarball to the docker container and running the build as the containers root user. Other use cases are possible however and it is possible to map a part of users file-system to the container. This is useful for example for doing cross-builds of ar

Re: [Qemu-devel] [PATCH RFC v2 2/2] ARM: KVM: Enable in-kernel timers with user space gic

2016-12-13 Thread Peter Maydell
On 14 November 2016 at 14:32, Alexander Graf wrote: > When running with KVM enabled, you can choose between emulating the > gic in kernel or user space. If the kernel supports in-kernel virtualization > of the interrupt controller, it will default to that. If not, if will > default to user space e

Re: [Qemu-devel] [PATCH v4 0/3] virtio-net: Add support to MTU feature

2016-12-13 Thread Maxime Coquelin
On 12/13/2016 02:07 PM, Daniel P. Berrange wrote: On Tue, Dec 13, 2016 at 02:04:52PM +0100, Maxime Coquelin wrote: On 12/12/2016 11:34 AM, Daniel P. Berrange wrote: On Mon, Dec 12, 2016 at 11:12:56AM +0100, Maxime Coquelin wrote: Hi Daniel, On 12/12/2016 11:02 AM, Daniel P. Berrange wrote

  1   2   3   >