Re: [Qemu-devel] [PATCH v9 02/12] vfio: VFIO based driver for Mediated devices

> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > Sent: Tuesday, October 18, 2016 5:22 AM > > vfio_mdev driver registers with mdev core driver. > MDEV core driver creates mediated device and calls probe routine of use same case - either 'mdev core' or 'MDEV core' > vfio_mdev driver for each

Re: [Qemu-devel] [PATCH V7 0/2] Add option to configure guest vPMU

On Tue, Oct 25, 2016 at 01:50:01PM -0500, Wei Huang wrote: > > > On 10/25/2016 12:56 PM, Andrew Jones wrote: > > >> > >> Compared with V7, my proposed solution above isn't so different as we > >> thought. Details below. In V7, > >> > >> * has_pmu=off by default. It is turned on in target-arm/cpu

Re: [Qemu-devel] [PATCH v9 01/12] vfio: Mediated device Core driver

> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > Sent: Tuesday, October 18, 2016 5:22 AM > > Design for Mediated Device Driver: > Main purpose of this driver is to provide a common interface for mediated > device management that can be used by different drivers of different > devices. > > T

Re: [Qemu-devel] [PATCH v2] char: cadence: check baud rate generator and divider values

+-- On Tue, 25 Oct 2016, Alistair Francis wrote --+ | I think your email crossed with Peter. Have a look at what he said. | That should clarify everything. I saw, I'll mask values with 0x and 0xFF; But it's not clear if ignoring values 0 - 3, means leaving registers uninitialised and adding

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 00/17] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

Hi Amit, On 2016/10/26 14:09, Amit Shah wrote: Hello, On (Tue) 18 Oct 2016 [20:09:56], zhanghailiang wrote: This is the 21th version of COLO frame series. Rebase to the latest master. I've reviewed the patchset, have some minor comments, but overall it looks good. The changes are contained

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/5] nvram: Refactor OpenBIOS NVRAM code to support -prom-env on pseries, too

On 26.10.2016 02:03, David Gibson wrote: > On Tue, Oct 25, 2016 at 02:22:08PM +0200, Thomas Huth wrote: >> On 24.10.2016 14:04, David Gibson wrote: >>> On Mon, Oct 24, 2016 at 12:36:05PM +0200, Thomas Huth wrote: On 24.10.2016 12:22, Bharata B Rao wrote: > > On Wed, Oct 19, 2016 at 7:4

Re: [Qemu-devel] [PATCH v1] block/vxhs: Add Veritas HyperScale VxHS block device support

On Wed, Oct 26, 2016 at 12:41:28AM -0400, Jeff Cody wrote: > On Tue, Oct 25, 2016 at 03:02:07PM -0700, Ashish Mittal wrote: > > This patch adds support for a new block device type called "vxhs". > > Source code for the library that this code loads can be downloaded from: > > https://github.com/Mitt

[Qemu-devel] [PATCH V8 1/2] arm: Add an option to turn on/off vPMU support

This patch adds a pmu=[on/off] option to enable/disable vPMU support in guest vCPU. It allows virt tools, such as libvirt, to determine the exsitence of vPMU and configure it. Note this option is only available for cortex-a57/cortex-53/ host CPUs, but unavailable on ARMv7 and other processors. Also

[Qemu-devel] [PATCH v2 6/6] target-ppc: Add xvcmpnesp, xvcmpnedp instructions

From: Swapnil Bokade xvcmpnedp[.]: VSX Vector Compare Not Equal Double-Precision xvcmpnesp[.]: VSX Vector Compare Not Equal Single-Precision Signed-off-by: Swapnil Bokade Signed-off-by: Nikunj A Dadhania --- target-ppc/fpu_helper.c | 19 +++ target-ppc/helper.h

[Qemu-devel] [PATCH V8 0/2] Add option to configure guest vPMU

This patchset adds a pmu=[on/off] option to enable/disable vPMU support for guest VM. There are several reasons to justify this option. First, vPMU can be problematic for cross-migration between different SoC as perf counters are architecture-dependent. It is more flexible to have an option to tur

[Qemu-devel] [PATCH v2 4/6] target-ppc: add vrldnm and vrlwnm instructions

From: Bharata B Rao vrldnm: Vector Rotate Left Doubleword then AND with Mask vrlwnm: Vector Rotate Left Word then AND with Mask Signed-off-by: Bharata B Rao Signed-off-by: Nikunj A Dadhania --- disas/ppc.c | 2 ++ target-ppc/helper.h | 2 ++ target-pp

[Qemu-devel] [PATCH V8 2/2] arm: virt: add PMU property to mach-virt machine type

CPU vPMU is now turned ON by default, but this feature wasn't introduced until virt-2.7 machine type. To solve this problem, this patch adds a PMU option in machine state, which is used to control CPU's vPMU status. This PMU option is not exposed to command line and is turned off in virt-2.6 machin

[Qemu-devel] [PATCH v2 5/6] target-ppc: add vprtyb[w/d/q] instructions

From: Ankit Kumar Add following POWER ISA 3.0 instructions. vprtybw: Vector Parity Byte Word vprtybd: Vector Parity Byte Double Word vprtybq: Vector Parity Byte Quad Word Signed-off-by: Ankit Kumar Signed-off-by: Nikunj A Dadhania --- target-ppc/helper.h | 3 +++ target-ppc/i

[Qemu-devel] [PATCH v2 3/6] target-ppc: add vrldnmi and vrlwmi instructions

From: "Gautham R. Shenoy" vrldmi: Vector Rotate Left Dword then Mask Insert vrlwmi: Vector Rotate Left Word then Mask Insert Signed-off-by: Gautham R. Shenoy Signed-off-by: Bharata B Rao ( use extract[32,64] and rol[32,64] ) Signed-off-by: Nikunj A Dadhania --- disas/ppc.c

[Qemu-devel] [PATCH v2 1/6] target-ppc: add xscmp[eq, gt, ge, ne]dp instructions

From: Sandipan Das xscmpeqdp: VSX Scalar Compare Equal Double-Precision xscmpgedp: VSX Scalar Compare Greater Than or Equal Double-Precision xscmpgtdp: VSX Scalar Compare Greater Than Double-Precision xscmpnedp: VSX Scalar Compare Not Equal Double-Precision Signed-off-by: Sandipan Das Signed-of

[Qemu-devel] [PATCH v2 0/6] POWER9 TCG enablements - part7

This series contains 14 new instructions for POWER9 ISA3.0 VSX Scalar compare Vector Rotate Left Dword Vector Rotate Left Word VSX Vector compare not equal Vector Parity Byte Changelog: v1: * Simplify extract routines (Richard) * Added ror/rol fix (Richard) * Added vector par

[Qemu-devel] [PATCH v2 2/6] bitops: fix rol/ror when shift is zero

All the variants for rol/ror have a bug in case where the shift == 0. For example rol32, would generate: return (word << 0) | (word >> 32); Which though works, would be flagged as a runtime error on clang's sanitizer. Suggested-by: Richard Henderson Signed-off-by: Nikunj A Dadhania --- in

[Qemu-devel] [PATCH v2 0/6] POWER9 TCG enablements - part7

This series contains 14 new instructions for POWER9 ISA3.0 VSX Scalar compare Vector Rotate Left Dword Vector Rotate Left Word VSX Vector compare not equal Vector Parity Byte Changelog: v1: * Simplify extract routines (Richard) * Added ror/rol fix (Richard) * Added vector par

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 00/17] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

Hello, On (Tue) 18 Oct 2016 [20:09:56], zhanghailiang wrote: > This is the 21th version of COLO frame series. > > Rebase to the latest master. I've reviewed the patchset, have some minor comments, but overall it looks good. The changes are contained, and common code / existing code paths are no

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 17/17] configure: Support enable/disable COLO feature

On (Tue) 18 Oct 2016 [20:10:13], zhanghailiang wrote: > configure --enable-colo/--disable-colo to switch COLO > support on/off. > COLO feature is enabled by default. > > Signed-off-by: zhanghailiang > Signed-off-by: Li Zhijian > Signed-off-by: Gonglei > Reviewed-by: Dr. David Alan Gilbert Rev

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 16/17] docs: Add documentation for COLO feature

On (Tue) 18 Oct 2016 [20:10:12], zhanghailiang wrote: > Introduce the design of COLO, and how to test it. > > Signed-off-by: zhanghailiang Reviewed-by: Amit Shah > + > +4. After the above steps, you will see, whenever you make changes to PVM, > SVM will be synced. > +You can by issue command

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 15/17] COLO: Implement failover work for secondary VM

On (Tue) 18 Oct 2016 [20:10:11], zhanghailiang wrote: > If users require SVM to takeover work, COLO incoming thread should > exit from loop while failover BH helps backing to migration incoming > coroutine. > > Signed-off-by: zhanghailiang > Signed-off-by: Li Zhijian > Reviewed-by: Dr. David Ala

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 14/17] COLO: Implement the process of failover for primary VM

On (Tue) 18 Oct 2016 [20:10:10], zhanghailiang wrote: > For primary side, if COLO gets failover request from users. > To be exact, gets 'x_colo_lost_heartbeat' command. > COLO thread will exit the loop while the failover BH does the > cleanup work and resumes VM. > > Signed-off-by: zhanghailiang

Re: [Qemu-devel] [PATCH 2/2] hostmem-file: allow option 'size' optional

On 10/25/16 17:50 -0200, Eduardo Habkost wrote: On Mon, Oct 24, 2016 at 05:21:51PM +0800, Haozhong Zhang wrote: If 'size' option of hostmem-file is not given, QEMU will use the file size of 'mem-path' instead. For an empty file, a non-zero size must be specified by the option 'size'. Signed-off

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 13/17] COLO: Introduce state to record failover process

On (Tue) 18 Oct 2016 [20:10:09], zhanghailiang wrote: > When handling failover, COLO processes differently according to > the different stage of failover process, here we introduce a global > atomic variable to record the status of failover. > > We add four failover status to indicate the differen

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 12/17] COLO: Add 'x-colo-lost-heartbeat' command to trigger failover

On (Tue) 18 Oct 2016 [20:10:08], zhanghailiang wrote: > We leave users to choose whatever heartbeat solution they want, > if the heartbeat is lost, or other errors they detect, they can use > experimental command 'x_colo_lost_heartbeat' to tell COLO to do failover, > COLO will do operations accordi

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 11/17] COLO: Synchronize PVM's state to SVM periodically

On (Tue) 18 Oct 2016 [20:10:07], zhanghailiang wrote: > Do checkpoint periodically, the default interval is 200ms. > > Signed-off-by: zhanghailiang > Signed-off-by: Li Zhijian > Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 10/17] COLO: Add checkpoint-delay parameter for migrate-set-parameters

On (Tue) 18 Oct 2016 [20:10:06], zhanghailiang wrote: > Add checkpoint-delay parameter for migrate-set-parameters, so that > we can control the checkpoint frequency when COLO is in periodic mode. > > Cc: Luiz Capitulino > Cc: Eric Blake > Cc: Markus Armbruster > Signed-off-by: zhanghailiang >

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 09/17] COLO: Load VMState into QIOChannelBuffer before restore it

On (Tue) 18 Oct 2016 [20:10:05], zhanghailiang wrote: > We should not destroy the state of SVM (Secondary VM) until we receive > the complete data of PVM's state, in case the primary fails in the process > of sending the state, so we cache the VM's state in secondary side before > load it into SVM.

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 08/17] COLO: Send PVM state to secondary side when do checkpoint

On (Tue) 18 Oct 2016 [20:10:04], zhanghailiang wrote: > VM checkpointing is to synchronize the state of PVM to SVM, just > like migration does, we re-use save helpers to achieve migrating > PVM's state to Secondary side. > > COLO need to cache the data of VM's state in the secondary side before >

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 08/17] COLO: Send PVM state to secondary side when do checkpoint

On (Tue) 18 Oct 2016 [20:10:04], zhanghailiang wrote: > VM checkpointing is to synchronize the state of PVM to SVM, just > like migration does, we re-use save helpers to achieve migrating > PVM's state to Secondary side. > > COLO need to cache the data of VM's state in the secondary side before >

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 06/17] COLO: Introduce checkpointing protocol

On (Tue) 18 Oct 2016 [20:10:02], zhanghailiang wrote: > We need communications protocol of user-defined to control > the checkpointing process. > > The new checkpointing request is started by Primary VM, > and the interactive process like below: > > Checkpoint synchronizing points: > >

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 05/17] COLO: Establish a new communicating path for COLO

On (Tue) 18 Oct 2016 [20:10:01], zhanghailiang wrote: > This new communication path will be used for returning messages > from Secondary side to Primary side. > > Signed-off-by: zhanghailiang > Signed-off-by: Li Zhijian > Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah > @@ -63,8

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 04/17] migration: Switch to COLO process after finishing loadvm

On (Tue) 18 Oct 2016 [20:10:00], zhanghailiang wrote: > Switch from normal migration loadvm process into COLO checkpoint process if > COLO mode is enabled. > > We add three new members to struct MigrationIncomingState, > 'have_colo_incoming_thread' and 'colo_incoming_thread' record the COLO > rela

Re: [Qemu-devel] [PATCH 0/7] blockjobs: preliminary refactoring work, Pt 1

On Fri, Oct 14, 2016 at 02:32:55PM -0400, John Snow wrote: > > > On 10/13/2016 06:56 PM, John Snow wrote: > >This is a follow-up to patches 1-6 of: > >[PATCH v2 00/11] blockjobs: Fix transactional race condition > > > >That series started trying to refactor blockjobs with the goal of > >internali

Re: [Qemu-devel] [PATCH 5/7] Blockjobs: Internalize user_pause logic

On Thu, Oct 13, 2016 at 06:57:00PM -0400, John Snow wrote: > BlockJobs will begin hiding their state in preparation for some > refactorings anyway, so let's internalize the user_pause mechanism > instead of leaving it to callers to correctly manage. > > Signed-off-by: John Snow > --- > blockdev.

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 03/17] migration: Enter into COLO mode after migration if COLO is enabled

On (Tue) 18 Oct 2016 [20:09:59], zhanghailiang wrote: > Add a new migration state: MIGRATION_STATUS_COLO. Migration source side > enters this state after the first live migration successfully finished > if COLO is enabled by command 'migrate_set_capability x-colo on'. > > We reuse migration thread

Re: [Qemu-devel] [PATCH 7/7] blockjobs: fix documentation

On Thu, Oct 13, 2016 at 06:57:02PM -0400, John Snow wrote: > (Trivial) > > Fix wrong function names in documentation. > > Signed-off-by: John Snow > --- > include/block/blockjob_int.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/block/blockjob_int.h b/in

Re: [Qemu-devel] [PATCH 6/7] blockjobs: split interface into public/private, Part 1

On Thu, Oct 13, 2016 at 06:57:01PM -0400, John Snow wrote: > To make it a little more obvious which functions are intended to be > public interface and which are intended to be for use only by jobs > themselves, split the interface into "public" and "private" files. > > Convert blockjobs (e.g. blo

Re: [Qemu-devel] [PATCH 4/7] blockjob: centralize QMP event emissions

On Thu, Oct 13, 2016 at 06:56:59PM -0400, John Snow wrote: > There's no reason to leave this to blockdev; we can do it in blockjobs > directly and get rid of an extra callback for most users. > > All non-internal events, even those created outside of QMP, will > consistently emit events. > > Sign

Re: [Qemu-devel] [PATCH 3/7] Replication/Blockjobs: Create replication jobs as internal

On Thu, Oct 13, 2016 at 06:56:58PM -0400, John Snow wrote: > Bubble up the internal interface to commit and backup jobs, then switch > replication tasks over to using this methodology. > > Signed-off-by: John Snow > --- > block/backup.c| 3 ++- > block/mirror.c| 21 +

Re: [Qemu-devel] [PATCH 2/7] blockjobs: Allow creating internal jobs

On Thu, Oct 13, 2016 at 06:56:57PM -0400, John Snow wrote: > Add the ability to create jobs without an ID. > > Signed-off-by: John Snow > --- > block/backup.c| 2 +- > block/commit.c| 2 +- > block/mirror.c| 3 ++- > block/stream.c| 2 +- > blo

Re: [Qemu-devel] [PATCH 3/4] target-ppc: add vrldnmi and vrlwmi instructions

Richard Henderson writes: > On 10/24/2016 11:02 PM, Nikunj A Dadhania wrote: >> Richard Henderson writes: >> >> >>> We already have rol32 and rol64. >>> >>> Which I see are broken for shift == 0. >> >> I tried with different shift (including 0) in a test program, and the >> result is as expec

Re: [Qemu-devel] [PATCH v1 2/3] target-ppc: add vrldnmi and vrlwmi instructions

Richard Henderson writes: > On 10/24/2016 11:19 PM, Nikunj A Dadhania wrote: >> +begin = extract##size(src2, size - begin_last - 1, num_bits); \ >> +end = extract##size(src2, size - end_last - 1, num_bits); \ >> +shift = extract##size(src2, size - shift_last - 1, num_b

Re: [Qemu-devel] [PATCH v1] block/vxhs: Add Veritas HyperScale VxHS block device support

On Tue, Oct 25, 2016 at 03:02:07PM -0700, Ashish Mittal wrote: > This patch adds support for a new block device type called "vxhs". > Source code for the library that this code loads can be downloaded from: > https://github.com/MittalAshish/libqnio.git > I grabbed the latest of libqnio, compiled i

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 02/17] COLO: migrate COLO related info to secondary node

On (Tue) 18 Oct 2016 [20:09:58], zhanghailiang wrote: > We can determine whether or not VM in destination should go into COLO mode > by referring to the info that was migrated. > > We skip this section if COLO is not enabled (i.e. > migrate_set_capability colo off), so that, It doesn't break compa

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 01/17] migration: Introduce capability 'x-colo' to migration

On (Tue) 18 Oct 2016 [20:09:57], zhanghailiang wrote: > We add helper function colo_supported() to indicate whether > colo is supported or not, with which we use to control whether or not > showing 'x-colo' string to users, they can use qmp command > 'query-migrate-capabilities' or hmp command 'inf

Re: [Qemu-devel] [PATCHv5 00/12] Cleanups to qtest PCI handling

On Tue, Oct 25, 2016 at 03:14:00PM +0200, Greg Kurz wrote: > On Tue, 25 Oct 2016 14:35:52 +1100 > David Gibson wrote: > > > On Mon, Oct 24, 2016 at 03:59:49PM +1100, David Gibson wrote: > > > This series contains a number of cleanups to the libqos code for > > > accessing PCI devices, and to test

Re: [Qemu-devel] [PATCHv5 07/12] libqos: Implement mmio accessors in terms of mem{read, write}

On Wed, Oct 26, 2016 at 12:18:03PM +1100, Alexey Kardashevskiy wrote: > On 25/10/16 23:16, David Gibson wrote: > > On Tue, Oct 25, 2016 at 05:47:43PM +1100, Alexey Kardashevskiy wrote: > >> On 24/10/16 15:59, David Gibson wrote: > >>> In the libqos PCI code we now have accessors both for registers

Re: [Qemu-devel] [PATCH 1/2] exec.c: do not truncate non-empty memory backend file

On 10/25/16 17:30 -0200, Eduardo Habkost wrote: On Mon, Oct 24, 2016 at 05:21:50PM +0800, Haozhong Zhang wrote: For '-object memory-backend-file,mem-path=foo,size=xyz', if the size of file 'foo' does not match the given size 'xyz', the current QEMU will truncate the file to the given size, which

Re: [Qemu-devel] [PATCHv5 08/12] tests: Clean up IO handling in ide-test

On Wed, Oct 26, 2016 at 12:57:26PM +1100, Alexey Kardashevskiy wrote: > On 25/10/16 23:25, David Gibson wrote: > > On Tue, Oct 25, 2016 at 06:01:41PM +1100, Alexey Kardashevskiy wrote: > >> On 24/10/16 15:59, David Gibson wrote: > >>> ide-test uses many explicit inb() / outb() operations for its IO

Re: [Qemu-devel] [PATCH v2 00/18] tcg field extract primitives

On Mon, Oct 24, 2016 at 12:04:33PM -0700, Richard Henderson wrote: > Pinging target maintainers. If I don't get responses by the end of the > week, I'll only push the generic tcg bits and the two targets that I > maintain. Sorry, missed this first time around. The ppc host side looked ok to me,

[Qemu-devel] [PATCH v2] trace: Fix 'char **' compilation error in simple backend

Currently, the generated function body will do "strlen(arg)" but the argument could be 'char **' or 'char * const *'. Avoid that by excluding such cases in is_string check. Reported by patchew's "make docker-test-mingw@fedora". Suggested-by: Eric Blake Signed-off-by: Fam Zheng --- v2: Fix typ

Re: [Qemu-devel] [PATCH] trace: Fix 'char **' compilation error in simple backend

On Tue, 10/25 21:56, Eric Blake wrote: > On 10/25/2016 09:46 PM, Fam Zheng wrote: > > On Tue, 10/25 21:29, Eric Blake wrote: > >> On 10/25/2016 08:59 PM, Fam Zheng wrote: > >>> Currently, the generated function body will do "strlen(arg)" but the > >>> argument could be 'char **'. Avoid that by excl

Re: [Qemu-devel] [Qemu-ppc] [PATCH 14/15] target-ppc: Use tcg_gen_extract_*

On Sat, Oct 15, 2016 at 08:37:49PM -0700, Richard Henderson wrote: > Use the new primitives for RDWINM and RLDICL. > > Cc: qemu-...@nongnu.org > Signed-off-by: Richard Henderson > --- > target-ppc/translate.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/targ

Re: [Qemu-devel] [PATCH 08/15] tcg/ppc: Implement field extraction opcodes

On Sat, Oct 15, 2016 at 08:37:43PM -0700, Richard Henderson wrote: > Signed-off-by: Richard Henderson Reviewed-by: David Gibson > --- > tcg/ppc/tcg-target.h | 4 ++-- > tcg/ppc/tcg-target.inc.c | 10 ++ > 2 files changed, 12 insertions(+), 2 deletions(-) > > diff --git a/tcg/ppc/

Re: [Qemu-devel] [PATCH] trace: Fix 'char **' compilation error in simple backend

On 10/25/2016 09:46 PM, Fam Zheng wrote: > On Tue, 10/25 21:29, Eric Blake wrote: >> On 10/25/2016 08:59 PM, Fam Zheng wrote: >>> Currently, the generated function body will do "strlen(arg)" but the >>> argument could be 'char **'. Avoid that by exclusding such cases in >> >>> def is_string(arg):

Re: [Qemu-devel] [PATCH] trace: Fix 'char **' compilation error in simple backend

On Tue, 10/25 21:29, Eric Blake wrote: > On 10/25/2016 08:59 PM, Fam Zheng wrote: > > Currently, the generated function body will do "strlen(arg)" but the > > argument could be 'char **'. Avoid that by exclusding such cases in > > s/exclusding/excluding/ Yes, I blame the insomnia last night. @.@

[Qemu-devel] [PULL 7/9] net: vmxnet: initialise local tx descriptor

From: Li Qiang In Vmxnet3 device emulator while processing transmit(tx) queue, when it reaches end of packet, it calls vmxnet3_complete_packet. In that local 'txcq_descr' object is not initialised, which could leak host memory bytes a guest. Reported-by: Li Qiang Signed-off-by: Prasad J Pandit

Re: [Qemu-devel] [PATCH] trace: Fix 'char **' compilation error in simple backend

On 10/25/2016 08:59 PM, Fam Zheng wrote: > Currently, the generated function body will do "strlen(arg)" but the > argument could be 'char **'. Avoid that by exclusding such cases in s/exclusding/excluding/ > is_string check. > > Reported by patchew's "make docker-test-mingw@fedora". > > Signed-

[Qemu-devel] [PULL 6/9] e1000e: Don't zero out buffer address in rx descriptor

From: Kevin Wolf The e1000e emulation zeroes out any used rx descriptor and then writes a completely newly constructed value there. By doing this, it doesn't only update the write-back area of the descriptors (as it's supposed to do), but it also clears the buffer address, which real hardware doe

[Qemu-devel] [PULL 9/9] colo-proxy: fix memory leak

From: Zhang Chen Fix memory leak in colo-compare.c and filter-rewriter.c Report by Coverity and add some comments. Signed-off-by: Zhang Chen Reviewed-by: zhanghailiang Signed-off-by: Jason Wang --- net/colo-compare.c| 34 +++--- net/filter-rewriter.c | 17

[Qemu-devel] [PULL 5/9] net: rocker: set limit to DMA buffer size

From: Prasad J Pandit Rocker network switch emulator has test registers to help debug DMA operations. While testing host DMA access, a buffer address is written to register 'TEST_DMA_ADDR' and its size is written to register 'TEST_DMA_SIZE'. When performing TEST_DMA_CTRL_INVERT test, if DMA buffe

[Qemu-devel] [PULL 8/9] net: rtl8139: limit processing of ring descriptors

From: Prasad J Pandit RTL8139 ethernet controller in C+ mode supports multiple descriptor rings, each with maximum of 64 descriptors. While processing transmit descriptor ring in 'rtl8139_cplus_transmit', it does not limit the descriptor count and runs forever. Add check to avoid it. Reported-by

[Qemu-devel] [PULL 2/9] net: pcnet: fix source formatting and indentation

From: Prasad J Pandit Fix indentations and source format at few places. Add braces around 'if' and 'while' statements. Signed-off-by: Prasad J Pandit Signed-off-by: Jason Wang --- hw/net/pcnet.c | 130 + 1 file changed, 67 insertions(+),

[Qemu-devel] [PULL 1/9] net: pcnet: check rx/tx descriptor ring length

From: Prasad J Pandit The AMD PC-Net II emulator has set of control and status(CSR) registers. Of these, CSR76 and CSR78 hold receive and transmit descriptor ring length respectively. This ring length could range from 1 to 65535. Setting ring length to zero leads to an infinite loop in pcnet_rdra

[Qemu-devel] [PULL 4/9] net: eepro100: fix memory leak in device uninit

From: Li Qiang The exit dispatch of eepro100 network card device doesn't free the 's->vmstate' field which was allocated in device realize thus leading a host memory leak. This patch avoid this. Signed-off-by: Li Qiang Signed-off-by: Jason Wang --- hw/net/eepro100.c | 1 + 1 file changed, 1 i

[Qemu-devel] [PULL 0/9] Net patches

The following changes since commit ede0cbeb7892bdf4a19128853a3a3c61a17fb068: Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2016-10-25' into staging (2016-10-25 17:03:11 +0100) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request f

[Qemu-devel] [PULL 3/9] tap-bsd: OpenBSD uses tap(4) now

From: Brad Smith Update the tap-bsd code now that OpenBSD uses tap(4). Signed-off-by: Brad Smith Signed-off-by: Jason Wang --- net/tap-bsd.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/net/tap-bsd.c b/net/tap-bsd.c index c506ac3..6c96922 100644 --- a/net/tap-bsd.c

[Qemu-devel] [PATCH qemu] configure, ppc64: Copy skiboot.lid to build directory when configuring

When configured to compile out of tree, the configure script copies BIOS blobs to the build directory. However since the PPC64 powernv machine ROM has .lid extension, it is ignored and "make check" fails when trying the powernv machine. This adds *.lid to the list of copied blobs. Signed-off-by:

[Qemu-devel] [PATCH] trace: Fix 'char **' compilation error in simple backend

Currently, the generated function body will do "strlen(arg)" but the argument could be 'char **'. Avoid that by exclusding such cases in is_string check. Reported by patchew's "make docker-test-mingw@fedora". Signed-off-by: Fam Zheng --- scripts/tracetool/backend/simple.py | 4 +++- 1 file chan

Re: [Qemu-devel] [PATCH RFC 0/7] COLO block replication supports shared disk case

I did't review p5/p6, I think you can merge p5/p6 into a single one. Also don't forget update qapi/block-core.json with p3. Thanks -Xie On 10/20/2016 09:57 PM, zhanghailiang wrote: COLO block replication doesn't support the shared disk case, Here we try to implement it. Just as the sce

Re: [Qemu-devel] [PATCHv5 08/12] tests: Clean up IO handling in ide-test

On 25/10/16 23:25, David Gibson wrote: > On Tue, Oct 25, 2016 at 06:01:41PM +1100, Alexey Kardashevskiy wrote: >> On 24/10/16 15:59, David Gibson wrote: >>> ide-test uses many explicit inb() / outb() operations for its IO, which >>> means it's not portable to non-x86 platforms. This cleans it up t

Re: [Qemu-devel] [PATCH V4] colo-proxy: fix memory leak

On 2016年10月24日 11:08, Hailiang Zhang wrote: On 2016/10/17 17:23, Zhang Chen wrote: Fix memory leak in colo-compare.c and filter-rewriter.c Report by Coverity and add some comments. Signed-off-by: Zhang Chen --- Reviewed-by: zhanghailiang Applied to -net. Thanks.

Re: [Qemu-devel] [PATCH RFC 3/7] replication: add shared-disk and shared-disk-id options

On 10/20/2016 09:57 PM, zhanghailiang wrote: We use these two options to identify which disk is shared Signed-off-by: zhanghailiang Signed-off-by: Wen Congyang Signed-off-by: Zhang Chen --- block/replication.c | 33 + 1 file changed, 33 insertions(+) diff -

Re: [Qemu-devel] [PATCH 10/10] spapr: Memory hot-unplug support

On Mon, Oct 24, 2016 at 11:47:36PM -0500, Michael Roth wrote: > From: Bharata B Rao > > Add support to hot remove pc-dimm memory devices. > > Since we're introducing a machine-level unplug_request hook, we also > had handling for CPU unplug there as well to ensure CPU unplug > continues to work

Re: [Qemu-devel] [PATCH 07/10] spapr_events: add support for dedicated hotplug event source

On Mon, Oct 24, 2016 at 11:47:33PM -0500, Michael Roth wrote: > Hotplug events were previously delivered using an EPOW interrupt > and were queued by linux guests into a circular buffer. For traditional > EPOW events like shutdown/resets, this isn't an issue, but for hotplug > events there are case

Re: [Qemu-devel] [PATCH 04/10] spapr: improve ibm, architecture-vec-5 property handling

On Wed, Oct 26, 2016 at 10:58:09AM +1100, David Gibson wrote: > On Mon, Oct 24, 2016 at 11:47:30PM -0500, Michael Roth wrote: > > ibm,architecture-vec-5 is supposed to encode all option vector 5 bits > > negotiated between platform/guest. Currently we hardcode this property > > in the boot-time dev

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/5] nvram: Refactor OpenBIOS NVRAM code to support -prom-env on pseries, too

On Tue, Oct 25, 2016 at 02:22:08PM +0200, Thomas Huth wrote: > On 24.10.2016 14:04, David Gibson wrote: > > On Mon, Oct 24, 2016 at 12:36:05PM +0200, Thomas Huth wrote: > >> On 24.10.2016 12:22, Bharata B Rao wrote: > >>> > >>> On Wed, Oct 19, 2016 at 7:46 AM, David Gibson > >>> mailto:da...@gibson

Re: [Qemu-devel] [PATCH 08/10] spapr: Add DRC count indexed hotplug identifier type

On Mon, Oct 24, 2016 at 11:47:34PM -0500, Michael Roth wrote: > From: Bharata B Rao > > Add support for DRC count indexed hotplug ID type which is primarily > needed for memory hot unplug. This type allows for specifying the > number of DRs that should be plugged/unplugged starting from a given >

Re: [Qemu-devel] [PATCH 00/10] spapr: option vector re-work and memory unplug support

On Mon, Oct 24, 2016 at 11:47:26PM -0500, Michael Roth wrote: > This series is based on David's ppc-for-2.8 branch, and is also available > from: > > https://github.com/mdroth/qemu/commits/spapr-hotplug-event-update > > Changes since RFC: > * Submit as v1 now that PAPR Hotplug ACR is accepte

Re: [Qemu-devel] [PATCH 04/10] spapr: improve ibm, architecture-vec-5 property handling

On Mon, Oct 24, 2016 at 11:47:30PM -0500, Michael Roth wrote: > ibm,architecture-vec-5 is supposed to encode all option vector 5 bits > negotiated between platform/guest. Currently we hardcode this property > in the boot-time device tree to advertise a single negotiated > capability, "Form 1" NUMA

Re: [Qemu-devel] [PATCH 01/10] spapr_ovec: initial implementation of option vector helpers

On Mon, Oct 24, 2016 at 11:47:27PM -0500, Michael Roth wrote: > PAPR guests advertise their capabilities to the platform by passing > an ibm,architecture-vec structure via an > ibm,client-architecture-support hcall as described by LoPAPR v11, > B.6.2.3. during early boot. > > Using this informatio

Re: [Qemu-devel] [PATCH 03/10] spapr: add option vector handling in CAS-generated resets

On Mon, Oct 24, 2016 at 11:47:29PM -0500, Michael Roth wrote: > In some cases, ibm,client-architecture-support calls can fail. This > could happen in the current code for situations where the modified > device tree segment exceeds the buffer size provided by the guest > via the call parameters. In

Re: [Qemu-devel] [PATCH] adb: change handler only when recognized

On Tue, Oct 25, 2016 at 09:01:01AM +0200, Hervé Poussineau wrote: > ADB devices must take new handler into account only when they recognize it. > This lets operating systems probe for valid/invalid handles, to know device > capabilities. > > Add a FIXME in keyboard handler, which should use a dif

Re: [Qemu-devel] [PATCH 06/10] spapr: add hotplug interrupt machine options

On Mon, Oct 24, 2016 at 11:47:32PM -0500, Michael Roth wrote: > This adds machine options of the form: > > -machine pseries,modern-hotplug-events=true > -machine pseries,modern-hotplug-events=false > > If false, QEMU will force the use of "legacy" style hotplug events, > which are surfaced th

Re: [Qemu-devel] [PATCH 09/10] spapr: use count+index for memory hotplug

On Mon, Oct 24, 2016 at 11:47:35PM -0500, Michael Roth wrote: > Commit 0a417869: > > spapr: Move memory hotplug to RTAS_LOG_V6_HP_ID_DRC_COUNT type > > dropped per-DRC/per-LMB hotplugs event in favor of a bulk add via a > single LMB count value. This was to avoid overrunning the guest EPOW >

Re: [Qemu-devel] [PATCH v5 15/17] ppc/pnv: Add cut down PSI bridge model and hookup external interrupt

On Tue, Oct 25, 2016 at 09:58:10AM +0200, Cédric Le Goater wrote: > On 10/25/2016 07:30 AM, David Gibson wrote: > > On Sat, Oct 22, 2016 at 11:46:48AM +0200, Cédric Le Goater wrote: > >> From: Benjamin Herrenschmidt > >> > >> The PSI (Processor Service Interface) is one of the engines of the > >>

Re: [Qemu-devel] [PATCH RFC 4/7] replication: Split out backup_do_checkpoint() from secondary_do_checkpoint()

On 10/20/2016 09:57 PM, zhanghailiang wrote: The helper backup_do_checkpoint() will be used for primary related codes. Here we split it out from secondary_do_checkpoint(). Besides, it is unnecessary to call backup_do_checkpoint() in replication starting and normally stop replication path. This

Re: [Qemu-devel] [PATCHv5 07/12] libqos: Implement mmio accessors in terms of mem{read, write}

On 25/10/16 23:16, David Gibson wrote: > On Tue, Oct 25, 2016 at 05:47:43PM +1100, Alexey Kardashevskiy wrote: >> On 24/10/16 15:59, David Gibson wrote: >>> In the libqos PCI code we now have accessors both for registers (byte >>> significance preserving) and for streaming data (byte address order

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v9 00/12] virtio-crypto: introduce framework and device emulation

Hi Michael, > -Original Message- > From: virtio-...@lists.oasis-open.org [mailto:virtio-...@lists.oasis-open.org] > On Behalf Of Michael S. Tsirkin > Sent: Wednesday, October 26, 2016 12:51 AM > Subject: [virtio-dev] Re: [PATCH v9 00/12] virtio-crypto: introduce framework > and device emu

Re: [Qemu-devel] [Qemu-stable] [Qemu-ppc] [PULL 0/4] ppc patches for qemu-2.7 stable branch

Quoting David Gibson (2016-10-24 20:41:29) > On Mon, Oct 17, 2016 at 04:24:31PM -0500, Michael Roth wrote: > > Quoting Peter Maydell (2016-10-17 13:45:21) > > > On 17 October 2016 at 19:13, Michael Roth > > > wrote: > > > > We could do both though: use some ad-hoc way to tag for a particular > >

Re: [Qemu-devel] [PATCH v5 08/13] qapi: Allow blockdev-add for NBD

On 10/25/2016 08:11 AM, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > qapi/block-core.json | 25 ++--- > 1 file changed, 22 insertions(+), 3 deletions(-) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 97b1205..4b4a74c 100644 > --- a/qapi/block-core

Re: [Qemu-devel] [PATCH v4 1/1] qga: minimal support for fstrim for Windows guests

Quoting Denis V. Lunev (2016-10-05 06:13:12) > On 10/04/2016 04:43 PM, Marc-André Lureau wrote: > > Hi > > > > On Mon, Oct 3, 2016 at 6:01 PM Denis V. Lunev > > wrote: > > > > Unfortunately, there is no public Windows API to start trimming the > > filesystem. The on

Re: [Qemu-devel] [PATCH v2 3/4] sockets: add AF_VSOCK support

Quoting Stefan Hajnoczi (2016-10-14 04:00:55) > Add the AF_VSOCK address family so that qemu-ga will be able to use > virtio-vsock. > > The AF_VSOCK address family uses address tuples. The cid is > the unique identifier comparable to an IP address. AF_VSOCK does not > use name resolution so it'

Re: [Qemu-devel] [PATCH RFC] acpi: don't build acpi tables for xen hvm guests

CC'ing maintainers On Tue, 25 Oct 2016, Wei Liu wrote: > Xen's toolstack is in charge of building ACPI tables. Skip acpi table > building if running on Xen. > > This issue is discovered due to direct kernel boot on Xen doesn't boot > anymore, because the new ACPI tables cause the guest to exceed

Re: [Qemu-devel] [PATCH 4/5] curses: add option to specify VGA font encoding

Hello, It seems that in the flurry of qemu-devel mails, I missed this answer. Paolo Bonzini wrote: > > +#ifdef CONFIG_ICONV > > +if (font_charset) { > > +unsigned char ch; > > +wchar_t wch; > > +char *pch, *pwch; > > +size_t sch, swch; > > +iconv_t conv

Re: [Qemu-devel] qemu-ga virtio-serial socket clarification

On Tue, Oct 25, 2016 at 6:27 PM, Stefan Hajnoczi wrote: > On Tue, Oct 25, 2016 at 7:14 PM, Matt Broadstone > wrote: > > I've been attempting an experimental qemu agent using a node.js daemon on > > the host side, and have run into an issue I was hoping someone here might > > be able to help with

[Qemu-devel] [PATCH v6] Add 'offset' and 'size' options

v5 -> v6: - fix alignment check condition - when size is not specified and device size is being used take offset into account v4 -> v5: - added two missing overflow checks - comments from Eric Blake: - renamed 'fail' label to 'end' - fixed optional fields in JSON scheme - no punctuation at

[Qemu-devel] [PATCH v6] raw_bsd: add offset and size options

Added two new options 'offset' and 'size'. This makes it possible to use only part of the file as a device. This can be used e.g. to limit the access only to single partition in a disk image or use a disk inside a tar archive (like OVA). When 'size' is specified we do our best to honour it. Signe

  1   2   3   4   >