From: Li Qiang
9pfs uses g_malloc() to allocate the xattr memory space, if the guest
reads this memory before writing to it, this will leak host heap memory
to the guest. This patch avoid this.
Signed-off-by: Li Qiang
---
hw/9pfs/9p.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
From: Li Qiang
The 'fs.xattr.value' field in V9fsFidState object doesn't consider
the situation that this field has been allocated previously. Every
time, it will be allocated directly. This leads a host memory leak
issue. This patch fix this.
Signed-off-by: Li Qiang
---
hw/9pfs/9p.c | 7
From: Li Qiang
Hello,
This series fix two security issues, the first issue is caused by
uninitialized heap, and the other is caused by no considering free the
buffer allocated previously.
Li Qiang (2):
9pfs: fix information leak in xattr read
9pfs: fix memory leak about xattr value
hw/9p
On 2016/10/5 20:13, Amit Shah wrote:
On (Fri) 30 Sep 2016 [14:27:26], Hailiang Zhang wrote:
On 2016/9/30 13:53, Amit Shah wrote:
In the meanwhile, can you check why the autobuilder fails to compile
with your patchset?
Yes, It was related to the 9th patch, where i used %lu to print value of
The *_exitfn functions cannot fail and should not be
returning int.
This also removes the passthru_exitfn since this callback
does nothing as of now.
This was suggested as a Bite-sized task for code cleanup.
Signed-off-by: Akanksha Srivastava
---
hw/usb/ccid-card-emulated.c | 3 +--
hw/usb/cci
On 10/08/2016 06:32 AM, Anand J wrote:
> I have replied for the questions inline. Also I'll make changes to the
> patch as per the review and send the updated one.
>
> Thanks,
> Anand
>
> On Fri, Oct 7, 2016 at 8:01 PM, Eric Blake wrote:
>
>> On 10/07/2016 03:46 AM, Anand J wrote:
>>> Some file
On 10/08/2016 01:37 PM, Paolo Bonzini wrote:
>> Even though most put/get have no issues now, when somebody writes a new
>> > put, he or she could run into issues if only checking the type
>> > signature. It makes the code more readable.
> No, it doesn't because one is left wondering what is VMS_
Ms.kaneez fizza writes:
> Dear Sir/Ma'am
>
> I am working on a project in which i have to annotate the translation
> buffer of qemu. I have downloaded the qemu version 2.7.0 Please help me to
> locate the code of translation buffer in it.
Look at tb_find and follow the code from there. What do
Am 08.10.2016 um 18:19 schrieb Stefan Weil:
Am 08.10.2016 um 14:07 schrieb Li Qiang:
From: Li Qiang
The exit dispatch of eepro100 network card device doesn't free
the 's->vmstate' field which was allocated in device realize thus
leading a host memory leak. This patch avoid this.
Signed-off-by
Public bug reported:
target-mips/dsp_helper.c:3480:1: error: V629 Consider inspecting the
'0x01 << (size + 1)' expression. Bit shifting of the 32-bit value with a
subsequent expansion to the 64-bit type.
Source code is
temp = temp & ((0x01 << (size + 1)) - 1);
If size >= 32, then better
Am 08.10.2016 um 14:07 schrieb Li Qiang:
From: Li Qiang
The exit dispatch of eepro100 network card device doesn't free
the 's->vmstate' field which was allocated in device realize thus
leading a host memory leak. This patch avoid this.
Signed-off-by: Li Qiang
Thank you for reporting this me
On 10/08/2016 05:00 AM, Laurent Vivier wrote:
> Information about "qemu-trivial" ML can be found in the wiki:
>
> http://wiki.qemu.org/Contribute/TrivialPatches
>
> But the first place where a developer looks is the file MAINTAINERS.
>
> This also allows the get_maintainer.pl script to displ
Dear Sir/Ma'am
I am working on a project in which i have to annotate the translation
buffer of qemu. I have downloaded the qemu version 2.7.0 Please help me to
locate the code of translation buffer in it.
Regards
Kaneez Fizza
MS-R
Computer Science and Engineering
IIT-ROPAR
From: Li Qiang
The exit dispatch of eepro100 network card device doesn't free
the 's->vmstate' field which was allocated in device realize thus
leading a host memory leak. This patch avoid this.
Signed-off-by: Li Qiang
---
hw/net/eepro100.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/h
On 07/10/2016 19:43, Jianjun Duan wrote:
> Even though most put/get have no issues now, when somebody writes a new
> put, he or she could run into issues if only checking the type
> signature. It makes the code more readable.
No, it doesn't because one is left wondering what is VMS_LINKED about.
I have replied for the questions inline. Also I'll make changes to the
patch as per the review and send the updated one.
Thanks,
Anand
On Fri, Oct 7, 2016 at 8:01 PM, Eric Blake wrote:
> On 10/07/2016 03:46 AM, Anand J wrote:
> > Some files contain multiple #includes of the same header file.
>
On Sat, Oct 8, 2016 at 4:24 PM, Richard W.M. Jones wrote:
> On Sat, Oct 08, 2016 at 04:14:06PM +0530, Ashijeet Acharya wrote:
>> Introduce new object 'BlockdevOptionsSsh' in qapi/block-core.json to
>> support blockdev-add for SSH network protocol driver. Use only 'struct
>> InetSocketAddress' sinc
On Sat, Oct 08, 2016 at 04:14:06PM +0530, Ashijeet Acharya wrote:
> Introduce new object 'BlockdevOptionsSsh' in qapi/block-core.json to
> support blockdev-add for SSH network protocol driver. Use only 'struct
> InetSocketAddress' since SSH only supports connection over TCP.
>
> +##
> +# @Blockde
Introduce new object 'BlockdevOptionsSsh' in qapi/block-core.json to
support blockdev-add for SSH network protocol driver. Use only 'struct
InetSocketAddress' since SSH only supports connection over TCP.
Signed-off-by: Ashijeet Acharya
---
qapi/block-core.json | 24 ++--
1 fi
From: Stefan Hajnoczi
Clean up the documentation for -chardev ringbuf. There is a stray
closing parenthesis and the comma is unnecessary.
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Marc-André Lureau
Signed-off-by: Michael Tokarev
---
qemu-options.hx | 2 +-
1 file changed, 1 insertion(+),
From: Thomas Huth
Makefile.objs and trace-events in hw/virtio/ were not covered
by MAINTAINERS yet.
Signed-off-by: Thomas Huth
Signed-off-by: Michael Tokarev
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 3ac5fbc..9e4ca02 100644
--- a/MAI
From: Felix Janda
This removes the last usage of in the code base.
Signed-off-by: Felix Janda
Signed-off-by: Michael Tokarev
---
linux-user/syscall.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 0815f30..52012d4 100644
Information about "qemu-trivial" ML can be found in the wiki:
http://wiki.qemu.org/Contribute/TrivialPatches
But the first place where a developer looks is the file MAINTAINERS.
This also allows the get_maintainer.pl script to display
the qemu-trivial ML address when the mail subject contain
This reverts commit d07cc1f12d8e15c167857852c39190d770763824.
Original commit d07cc1f12d8e15c167857852c39190d770763824 should be
fixing some endianess issue for power, however at least in latest QEMU
I see that all the callers are treating MSIMessage as host endianess
already, so now we should not
On Fri, Oct 07, 2016 at 10:40:45AM +0200, Gerd Hoffmann wrote:
> On Fr, 2016-10-07 at 10:49 +1100, David Gibson wrote:
> > On Thu, Oct 06, 2016 at 04:50:48PM +0200, Laurent Vivier wrote:
> > > Two minor cleanups:
> > > - exit gracefully in case on unsupported target,
> > > - put machine command lin
From: Thomas Huth
audio.h and pcspk.h are recognized as maintained files now.
Signed-off-by: Thomas Huth
Signed-off-by: Michael Tokarev
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index ba50167..94f14ea 100644
--- a/MAINTAINERS
+++ b/MAINTAINE
From: Marc-André Lureau
Since commit b35ba30f8f when it was introduced, phys_page_compact()
takes an unused compacted argument.
ubsan complains about it when launching qemu-x86_64 without arguments:
qemu/exec.c:310:5: runtime error: variable length array bound evaluates to
non-positive value 0
From: Lin Ma
Commit 0c0c1fd9 generated module_block.h automatically, Add it to .gitignore to
avoid checking in it by 'git add .'.
Signed-off-by: Lin Ma
Reviewed-by: Fam Zheng
Signed-off-by: Michael Tokarev
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitig
From: Chen Fan
the bar index names are much similar to the bar memory regions,
distinguish them to improve the code readability.
Signed-off-by: Chen Fan
Signed-off-by: Michael Tokarev
---
hw/display/virtio-vga.c | 4 ++--
hw/virtio/virtio-pci.c | 20 ++--
hw/virtio/virtio-pc
From: Thomas Huth
The default-configs/*-linux-user.mak belong to Linux usermode
emulation, and default-configs/*-bsd-user.mak belong to BSD
usermode emulation.
Signed-off-by: Thomas Huth
Signed-off-by: Michael Tokarev
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINT
From: Thomas Huth
The hw/moxie/ folder and default-configs/moxie-softmmu.mak
obviously belong to the Moxie CPU.
Signed-off-by: Thomas Huth
Signed-off-by: Michael Tokarev
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 9bca506..adc5e4e 1006
On 2016/10/5 21:37, Eric Blake wrote:
On 09/29/2016 03:46 AM, zhanghailiang wrote:
Introduce the design of COLO, and how to test it.
Signed-off-by: zhanghailiang
---
docs/COLO-FT.txt | 190 +++
1 file changed, 190 insertions(+)
create mo
From: Paolo Bonzini
Signed-off-by: Paolo Bonzini
Signed-off-by: Michael Tokarev
---
hw/arm/nseries.c | 3 +--
hw/bt/hci-csr.c | 2 +-
include/hw/bt.h | 2 +-
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c
index fea911e..c86cf80 100644
--- a
From: Thomas Huth
And while we're at it, remove Blue Swirl from the list
of maintainers. Blue has apparently been inactive for
quite a while now, so I assume he's unfortunately
not available as maintainer anymore.
Signed-off-by: Thomas Huth
Signed-off-by: Michael Tokarev
---
MAINTAINERS | 9 +
From: Jonathan Neuschäfer
Signed-off-by: Jonathan Neuschäfer
Reviewed-by: Peter Maydell
Signed-off-by: Michael Tokarev
---
CODING_STYLE | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/CODING_STYLE b/CODING_STYLE
index e7fde15..f53180b 100644
--- a/CODING_STYLE
+++ b/CODING
From: "Daniel P. Berrange"
If the qio_channel_tls_new_(server|client) methods fail,
we disconnect the client. Unfortunately a missing return
means we then go on to try and run the TLS handshake on
a NULL I/O channel. This gives predictably segfaulty
results.
The main way to trigger this is to re
From: Thomas Huth
The hmp-commands-info.hx, hmp.h and include/monitor/hmp-target.h
files were classified as unmaintained. Let's add them to the
HMP section.
Signed-off-by: Thomas Huth
Reviewed-by: Luiz Capitulino
Reviewed-by: Eric Blake
Signed-off-by: Michael Tokarev
---
MAINTAINERS | 5 +++
From: Marc-André Lureau
Fix spelling, the GNU make text functions is not called "find-string"
but "findstring".
Broken in commit 2b2e59e. Fairly harmless: its only use is in
tests/tcg/Makefile, where the bug can cause the I386_TESTS not to
run when they should.
Signed-off-by: Marc-André Lureau
From: Wei Yang
According to linux kernel commit <89c1e79eb30> ("linux/bitmap.h: improve
BITMAP_{LAST,FIRST}_WORD_MASK"), these two macro could be improved.
This patch takes this change and also move them all in header file.
Signed-off-by: Wei Yang
Signed-off-by: Michael Tokarev
---
include/q
From: Thomas Huth
etraxfs_dma.h and etraxfs.h in include/hw/cris/ obviously belong
to the CRIS section in MAINTAINERS.
Signed-off-by: Thomas Huth
Reviewed-by: Edgar E. Iglesias
Signed-off-by: Michael Tokarev
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MA
From: Greg Ungerer
The shipping default setting for the Freescale M5208EVB board is to run
the CPU at 166.67MHz. The current qemu emulation code for this board is
defaulting to 66MHz. This results in time appearing to run way to slowly.
So a "sleep 5" in a standard ColdFire Linux build takes almo
From: Thomas Huth
The get_maintainer.pl script currently thinks that the win32
related files in the util and include folders are currently
unmaintained. Thus let's add some additional wildcards to
match these files.
Signed-off-by: Thomas Huth
Reviewed-by: Stefan Weil
Signed-off-by: Michael Tok
From: Eric Blake
Commits 9ef8112a and efad6682 introduced new tests, but forgot
to ignore the built executables from an in-tree build.
Signed-off-by: Eric Blake
Reviewed-by: Alberto Garcia
Reviewed-by: Fam Zheng
Signed-off-by: Michael Tokarev
---
tests/.gitignore | 2 ++
1 file changed, 2 i
From: Zhang Chen
Signed-off-by: Zhang Chen
Reviewed-by: Eric Blake
Signed-off-by: Michael Tokarev
---
net/filter-mirror.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/filter-mirror.c b/net/filter-mirror.c
index 35df374..0ee58d9 100644
--- a/net/filter-mirror.c
+
From: David Anderson
This makes it easier to parse the schema file for tool generation:
each paragraph is either a non-docstring comment, or a docstring
immediately followed by a Python dict describing an API item.
Signed-off-by: David Anderson
Reviewed-by: Eric Blake
Signed-off-by: Michael To
From: Thomas Huth
The files in tests/rocker/ and docs/specs/rocker.txt
should be listed in the Rocker section of MAINTAINERS.
Signed-off-by: Thomas Huth
Signed-off-by: Michael Tokarev
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index a5751a6
Hi.
Here's another trivial tree pull request. Really trivial stuff
all over, and many changes to MAINTAINERS file from Thomas Huth.
Please consider applying.
Thanks,
/mjt
The following changes since commit 48f592118ab42f83a1a7561c4bfd2b72a100f241:
bsd-user: fix FreeBSD build after d148d90e
From: Thomas Huth
hw/intc/sh_intc.c and hw/timer/sh_timer.c seem to belong to
the R2D machine, as far as I can see.
And concerning the Shix machine, it does not make much sense
to have a "M:" entry here and the "S:" set to "Orphan". So
I'd like to suggest to use "Odd Fixes" here instead.
Signed-
From: Li Qiang
While processing isochronous transfer descriptors(iTD), if the page
select(PG) field value is out of bands it will return. In this
situation the ehci's sg list is not freed thus leading to a memory
leak issue. This patch avoid this.
Signed-off-by: Li Qiang
Reviewed-by: Thomas Hut
From: Thomas Huth
The MIPS section is missing some related header files, and files
in the hw/misc/, hw/intc/ and hw/timer/ folders.
Signed-off-by: Thomas Huth
Signed-off-by: Michael Tokarev
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
in
On 10/03/2016 09:48 PM, Igor Mammedov wrote:
On Fri, 12 Aug 2016 14:54:02 +0800
Xiao Guangrong wrote:
General design issue in this series is regenerating
_FIT data every time inside of _FIT read loop.
The issue here is that if FIT data doesn't fit in one page
RFIT would be called several tim
Applied to -trivial, thanks!
/mjt
01.10.2016 02:40, Felix Janda wrote:
This removes the last usage of in the code base.
Applied to -trivial, thanks!
/mjt
30.09.2016 18:02, Daniel P. Berrange wrote:
If the qio_channel_tls_new_(server|client) methods fail,
we disconnect the client. Unfortunately a missing return
means we then go on to try and run the TLS handshake on
a NULL I/O channel. This gives predictably segfaulty
results.
Applied to -trivial
29.09.2016 07:04, Chen Fan wrote:
the bar index names are much similar to the bar memory regions,
distinguish them to improve the code readability.
-vpci_dev->modern_mem_bar = 2;
-vpci_dev->msix_bar = 4;
+vpci_dev->modern_mem_bar_idx = 2;
+vpci_dev->msix_bar_idx = 4;
...
Ap
30.09.2016 10:26, Thomas Huth wrote:
The MIPS section is missing some related header files, and files
in the hw/misc/, hw/intc/ and hw/timer/ folders.
Applied to -trivial, thanks!
/mjt
30.09.2016 12:32, Thomas Huth wrote:
hw/intc/sh_intc.c and hw/timer/sh_timer.c seem to belong to
the R2D machine, as far as I can see.
And concerning the Shix machine, it does not make much sense
to have a "M:" entry here and the "S:" set to "Orphan". So
I'd like to suggest to use "Odd Fixes" her
30.09.2016 10:07, Thomas Huth wrote:
The default-configs/*-linux-user.mak belong to Linux usermode
emulation, and default-configs/*-bsd-user.mak belong to BSD
usermode emulation.
Applied to -trivial, thanks!
/mjt
Applied to -trivial, thanks!
/mjt
> -原始邮件-
> 发件人: "Amit Shah"
> 发送时间: 2016年9月30日 星期五
> 收件人: "Chunguang Li"
> 抄送: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org,
> pbonz...@redhat.com, stefa...@redhat.com, quint...@redhat.com
> 主题: Re: Re: [Qemu-devel] Migration dirty bitmap: should only mark pages as
> dirty after
On 10/03/2016 09:21 PM, Igor Mammedov wrote:
On Fri, 12 Aug 2016 14:54:08 +0800
Xiao Guangrong wrote:
nvdimm's memory info can not exported via _CRS, instead, it is reported
by NFIT/FIT
This patch let _CRS return zero for both memory address and memory size
if it is a nvdimm device inserted
On 10/03/2016 05:45 PM, Igor Mammedov wrote:
On Fri, 12 Aug 2016 14:54:07 +0800
Xiao Guangrong wrote:
We should let nvdimm acpi know which nvdimm device is being unplugged
before QEMU interrupts the guest so that nvdimm acpi can update its
FIT properly
prepare_unplug() callback is introduce
On 09/30/2016 09:17 PM, Igor Mammedov wrote:
On Fri, 12 Aug 2016 14:54:06 +0800
Xiao Guangrong wrote:
Read FIT whose function index is 0x is reserved by QEMU to read
the piece of FIT buffer. Please refer to docs/specs/acpi_nvdimm.txt for
detailed info
Pls, squash this patch into 3/
On 09/30/2016 10:03 PM, Igor Mammedov wrote:
On Fri, 12 Aug 2016 14:54:10 +0800
Xiao Guangrong wrote:
Add the specification of Read FIT function
should be squashed into 3/8
Okay.
On 09/30/2016 09:14 PM, Igor Mammedov wrote:
On Fri, 12 Aug 2016 14:54:05 +0800
Xiao Guangrong wrote:
_FIT is required for hotplug support, guest will inquire the updated
device info from it if a hotplug event is received
As FIT buffer is not completely mapped into guest address space, so a
On Wed, Oct 05, 2016 at 03:06:55PM +0200, Radim Krčmář wrote:
[...]
> @@ -2472,10 +2473,22 @@ static bool vtd_decide_config(IntelIOMMUState *s,
> Error **errp)
> }
>
> if (s->intr_eim == ON_OFF_AUTO_AUTO) {
> -s->intr_eim = x86_iommu->intr_supported ?
> +s->intr_eim =
On Wed, Oct 05, 2016 at 03:06:54PM +0200, Radim Krčmář wrote:
> The default (auto) emulates the current behavior.
> A user can now control EIM like
> -device intel-iommu,intremap=on,eim=off
>
> Reviewed-by: Igor Mammedov
> Signed-off-by: Radim Krčmář
Reviewed-by: Peter Xu
On 09/30/2016 07:44 PM, Kirti Wankhede wrote:
> On 9/30/2016 8:40 AM, Jike Song wrote:
>> On 09/30/2016 10:58 AM, Jike Song wrote:
>>> On 09/29/2016 11:06 PM, Kirti Wankhede wrote:
On 9/29/2016 7:47 AM, Jike Song wrote:
> +Guangrong
>
> On 08/25/2016 11:53 AM, Kirti Wankh
68 matches
Mail list logo
