Re: [Qemu-devel] [PATCH 0/3] trivial changes of timer & cpus

2016-09-13 Thread Michael Tokarev
14.09.2016 09:54, Cao jin wrote: Hi Michael, I saw Paolo already queued these 3 into his branch and sent the pull request. That's okay, git figure it out. Thank you for notifying me. /mjt

Re: [Qemu-devel] [PATCH 0/3] trivial changes of timer & cpus

2016-09-13 Thread Cao jin
Hi Michael, I saw Paolo already queued these 3 into his branch and sent the pull request. Cao jin On 09/14/2016 02:47 PM, Michael Tokarev wrote: 29.07.2016 14:05, Cao jin wrote: Cc: Paolo Bonzini Cc: Peter Maydell Cc Peter Crosthwaite Cc: Richard Henderson Cao jin (3): timer: update

Re: [Qemu-devel] [PATCH 0/3] trivial changes of timer & cpus

2016-09-13 Thread Michael Tokarev
29.07.2016 14:05, Cao jin wrote: Cc: Paolo Bonzini Cc: Peter Maydell Cc Peter Crosthwaite Cc: Richard Henderson Cao jin (3): timer: update comments cpus: rename local variable to meaningful one cpus: update comments cpus.c | 13 +++-- include/qemu/timer.h | 19

Re: [Qemu-devel] [PATCH v3] help: Update help to remove misleading display information

2016-09-13 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

[Qemu-devel] [PATCH] qemu-char: avoid segfault if user lacks of permisson of a given logfile

2016-09-13 Thread Lin Ma
Function qemu_chr_alloc returns NULL if it failed to open logfile by any reason, says no write permission. For backends tty, stdio and msmouse, They need to check this return value to avoid segfault in this case. Signed-off-by: Lin Ma --- backends/msmouse.c | 3 +++ qemu-char.c| 6 ++

[Qemu-devel] [PATCH V2 1/2] arm64: Add an option to turn on/off vPMU support

2016-09-13 Thread Wei Huang
This patch adds a pmu=[on/off] option to enable/disable vPMU support in guest VM. The pmu option is available only for cortex-a57/cortex-53/ host under both TCG and KVM modes. Additionally pmu can only be turned on under KVM mode, otherwise a warning message will be printed out (e.g. "-M virt,accel

[Qemu-devel] [PATCH V2 0/2] Add option to configure guest vPMU

2016-09-13 Thread Wei Huang
This patchset adds a pmu=[on/off] option to enable/disable vPMU support for guest VM. There are several reasons to justify this option. First, vPMU can be problematic for cross-migration between different SoC as perf counters are architecture-dependent. It is more flexible to have an option to tur

[Qemu-devel] [PATCH V2 2/2] arm: virt: add PMU property to machvirt machine type

2016-09-13 Thread Wei Huang
CPU vPMU is now turned off by default, but it was ON in virt-2.7 machine type. To solve this problem, this patch adds a PMU option in machine state, which is used to control CPU's vPMU status. This PMU option is not exposed to command line and is turned on in virt-2.7 machine type to make sure it i

Re: [Qemu-devel] [PATCH v4 3/3] intel_iommu: allow UNMAP notifiers

2016-09-13 Thread David Gibson
On Fri, Sep 09, 2016 at 10:57:44AM +0800, Peter Xu wrote: > Intel vIOMMU is still lacking of a complete IOMMU notifier mechanism. > Before that is achieved, let's open a door for vhost DMAR support, which > only requires cache invalidations (UNMAP operations). > > Meanwhile, converting hw_error()

[Qemu-devel] [PATCH v4 3/3] target-ppc: tlbie/tlbivax should have global effect

2016-09-13 Thread Nikunj A Dadhania
tlbie (BookS) and tlbivax (BookE) plus the H_CALLs(pseries) should have a global effect. Introduces TLB_NEED_GLOBAL_FLUSH flag. During lazy tlb flush, after taking care of pending local flushes, check broadcast flush(at context synchronizing event ptesync/tlbsync, etc) is needed. Depending on the

Re: [Qemu-devel] [PATCH v4 2/3] memory: introduce IOMMUOps.notify_flag_changed

2016-09-13 Thread David Gibson
On Fri, Sep 09, 2016 at 10:57:43AM +0800, Peter Xu wrote: > The new interface can be used to replace the old notify_started() and > notify_stopped(). Meanwhile it provides explicit flags so that IOMMUs > can know what kind of notifications it is requested for. > > Signed-off-by: Peter Xu > --- >

Re: [Qemu-devel] [PATCH v4 1/3] memory: introduce IOMMUNotifier and its caps

2016-09-13 Thread David Gibson
On Fri, Sep 09, 2016 at 10:57:42AM +0800, Peter Xu wrote: > IOMMU Notifier list is used for notifying IO address mapping changes. > Currently VFIO is the only user. > > However it is possible that future consumer like vhost would like to > only listen to part of its notifications (e.g., cache inva

[Qemu-devel] [PATCH v4 1/3] target-ppc: add TLB_NEED_LOCAL_FLUSH flag

2016-09-13 Thread Nikunj A Dadhania
Signed-off-by: Nikunj A Dadhania --- target-ppc/cpu.h | 1 + target-ppc/helper_regs.h | 4 ++-- target-ppc/mmu-hash64.c | 4 ++-- target-ppc/mmu_helper.c | 6 +++--- 4 files changed, 8 insertions(+), 7 deletions(-) diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h index 1e808c8..7dc

[Qemu-devel] [PATCH v2] pc: apic: fix touch LAPIC when irqchip is split

2016-09-13 Thread Wanpeng Li
From: Wanpeng Li Add -kernel_irqchip=split ./x86-run x86/eventinj.flat qemu-system-x86_64 -enable-kvm -machine kernel_irqchip=split -cpu host -device pc-testdev -device isa-debug-exit,iobase=0xf4,iosize=0x4 -vnc none -serial stdio -device pci-testdev -kernel x86/eventinj.flat enabling apic pagin

[Qemu-devel] [PATCH v4 0/3] ppc: handle broadcast tlb flush

2016-09-13 Thread Nikunj A Dadhania
PowerPC failed to handle broadcast TLB flush operations. Executing instructions that are defined architecturally as synchronizing global TLB should have a global effect. * tlbie on BookS * tlbivax on BookE * H_CALLs (H_REMOVE, H_BULK_REMOVE and H_PROTECT) in case of pseries, since they contai

[Qemu-devel] [PATCH v4 2/3] target-ppc: add flag in chech_tlb_flush()

2016-09-13 Thread Nikunj A Dadhania
We flush the qemu TLB lazily. check_tlb_flush is called whenever we hit a context synchronizing event or instruction that requires a pending flush to be performed. However, we fail to handle broadcast TLB flush operations. In order to fix that efficiently, we want to differenciate whether check_tl

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add include/hw/sh4/ to SH4 section

2016-09-13 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH v2] sh4: fix broken link to documentation

2016-09-13 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add some header files to the PC chipset section

2016-09-13 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH 2/3] memory: add iommu_notify_flag

2016-09-13 Thread Peter Xu
On Wed, Sep 14, 2016 at 02:00:29PM +1000, David Gibson wrote: [...] > > > > > > > > > > > So > > > > > > IIUC this is a question about "naming" but not the > > > > > > implementations... > > > > > > I suppose it is really a matter of taste, and both work for me > > > > > > (either > > > > > >

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add include/hw/tricore/ to TriCore section

2016-09-13 Thread Michael Tokarev
Aplied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH] MAINTAINERS: Fix up F: entry bit rot

2016-09-13 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add include/sysemu/cpus.h

2016-09-13 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH] MAINTAINERS: Fix wildcard for scsi headers

2016-09-13 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add include/hw/unicore32/ to UniCore32 section

2016-09-13 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH] ui/console: Fix non-working backspace key in monitor of gtk UI

2016-09-13 Thread Michael Tokarev
Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH] tcg: Remove duplicate header includes

2016-09-13 Thread Michael Tokarev
Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH] Remove remainders of HPPA backend

2016-09-13 Thread Michael Tokarev
Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH v3 2/3] target-ppc: add flag in chech_tlb_flush()

2016-09-13 Thread David Gibson
On Wed, Sep 14, 2016 at 02:37:03PM +1000, Benjamin Herrenschmidt wrote: > On Wed, 2016-09-14 at 09:23 +0530, Nikunj A Dadhania wrote: > > Hr... this is confusing, let me rephrase ;-) > > > Due to lazy tlb flushes, propagation of the tlb flush is delayed. > Moreover, certain operations need to do

Re: [Qemu-devel] [PATCH v8 3/3] tests: add RTAS command in the protocol

2016-09-13 Thread David Gibson
On Tue, Sep 13, 2016 at 02:52:45PM +0200, Laurent Vivier wrote: > Add a first test to validate the protocol: > > - rtas/get-time-of-day compares the time > from the guest with the time from the host. > > Signed-off-by: Laurent Vivier > Reviewed-by: Greg Kurz Reviewed-by: David Gibson > ---

Re: [Qemu-devel] [PATCH v8 0/3] tests: add RTAS protocol

2016-09-13 Thread David Gibson
On Tue, Sep 13, 2016 at 02:52:42PM +0200, Laurent Vivier wrote: > This series allows to call RTAS commands from the qtest framework, > and defines a first test to call RTAS command "get-time-of-day" > to validate the protocol and test RTAS. > > RTAS command parameters are passed to the guest via t

Re: [Qemu-devel] [PATCH 2/3] memory: add iommu_notify_flag

2016-09-13 Thread David Gibson
On Mon, Sep 12, 2016 at 01:13:41PM +0800, Peter Xu wrote: > On Mon, Sep 12, 2016 at 11:26:04AM +1000, David Gibson wrote: > > On Thu, Sep 08, 2016 at 05:07:32PM +0800, Peter Xu wrote: > > > On Wed, Sep 07, 2016 at 04:41:54PM +1000, David Gibson wrote: > > > > On Wed, Sep 07, 2016 at 02:34:19PM +080

Re: [Qemu-devel] [PATCH] ppc: do not redefine CPUPPCState

2016-09-13 Thread David Gibson
On Tue, Sep 13, 2016 at 06:43:47PM +0200, Paolo Bonzini wrote: > Just include the file that is supposed to bring it in. Applied to ppc-for-2.8, thanks. > Cc: David Gibson > Signed-off-by: Paolo Bonzini > --- > I'm including this in my pull request to fix a clang warning. > > include/hw/

Re: [Qemu-devel] [PATCH v3 2/3] target-ppc: add flag in chech_tlb_flush()

2016-09-13 Thread Nikunj A Dadhania
Benjamin Herrenschmidt writes: > On Wed, 2016-09-14 at 09:23 +0530, Nikunj A Dadhania wrote: > > Hr... this is confusing, let me rephrase ;-) > >> Due to lazy tlb flushes, propagation of the tlb flush is delayed. > Moreover, certain operations need to do broadcast flush, this too can > be >> dela

Re: [Qemu-devel] [PATCH v2] vfio: Add support for mmapping sub-page MMIO BARs

2016-09-13 Thread Yongji Xie
On 2016/9/14 6:55, Alex Williamson wrote: [cc +Paolo] On Thu, 11 Aug 2016 19:05:57 +0800 Yongji Xie wrote: Now the kernel commit 05f0c03fbac1 ("vfio-pci: Allow to mmap sub-page MMIO BARs if the mmio page is exclusive") allows VFIO to mmap sub-page BARs. This is the corresponding QEMU patch.

Re: [Qemu-devel] [PATCH v3 2/3] target-ppc: add flag in chech_tlb_flush()

2016-09-13 Thread Benjamin Herrenschmidt
On Wed, 2016-09-14 at 09:23 +0530, Nikunj A Dadhania wrote: Hr... this is confusing, let me rephrase ;-) > Due to lazy tlb flushes, propagation of the tlb flush is delayed. Moreover, certain operations need to do broadcast flush, this too can be > delayed until we hit the operation that warrant a

Re: [Qemu-devel] qemu 2.7.0 incompatible with host kernel < 3.19

2016-09-13 Thread Michael S. Tsirkin
On Tue, Sep 13, 2016 at 11:09:27PM +0200, Laszlo Ersek wrote: > Hi, > > (CC Michael and Cornelia,) > > On 09/13/16 21:10, Brian Rak wrote: > > I have some KVM hosts that I just upgraded to qemu 2.7.0. When the host > > is running a kernel newer then 3.19, everything works fine. > > > > If the h

Re: [Qemu-devel] [PATCH qemu v2] tap: Allow specifying a bridge

2016-09-13 Thread Alexey Kardashevskiy
On 14/09/16 01:39, Greg Kurz wrote: > On Tue, 13 Sep 2016 09:49:09 -0500 > Eric Blake wrote: > >> On 09/13/2016 02:11 AM, Alexey Kardashevskiy wrote: >>> The tap backend is already using qemu-bridge-helper to attach tap >>> interface to a bridge but (unlike the bridge backend) it always uses >>>

Re: [Qemu-devel] [PATCH v3 2/3] target-ppc: add flag in chech_tlb_flush()

2016-09-13 Thread Nikunj A Dadhania
David Gibson writes: > [ Unknown signature status ] > On Mon, Sep 12, 2016 at 11:18:33AM +0530, Nikunj A Dadhania wrote: >> The flag will be used to indicate whether broadcast tlb flush is needed >> or not. >> >> Moreover, BookS does both ptesync and tlbsync, so make that a nop for >> the server

Re: [Qemu-devel] [PATCH v3 2/3] target-ppc: add flag in chech_tlb_flush()

2016-09-13 Thread Benjamin Herrenschmidt
On Wed, 2016-09-14 at 13:09 +1000, David Gibson wrote: > On Mon, Sep 12, 2016 at 11:18:33AM +0530, Nikunj A Dadhania wrote: > > > > The flag will be used to indicate whether broadcast tlb flush is > > needed > > or not. > > > > Moreover, BookS does both ptesync and tlbsync, so make that a nop > >

Re: [Qemu-devel] [PATCH] pc: apic: fix touch LAPIC when irqchip is split

2016-09-13 Thread Wanpeng Li
2016-09-14 11:40 GMT+08:00 Fam Zheng : > On Tue, 09/13 20:21, no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote: >> Hi, >> >> Your series seems to have some coding style problems. See output below for >> more information: >> >> Type: series >> Message-id: 1473822299-6302-1-git-send-email-wanp

Re: [Qemu-devel] [PATCH] pc: apic: fix touch LAPIC when irqchip is split

2016-09-13 Thread Fam Zheng
On Tue, 09/13 20:21, no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote: > Hi, > > Your series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 1473822299-6302-1-git-send-email-wanpeng...@hotmail.com > Subject: [Qemu-devel] [PA

Re: [Qemu-devel] [PATCH] pc: apic: fix touch LAPIC when irqchip is split

2016-09-13 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1473822299-6302-1-git-send-email-wanpeng...@hotmail.com Subject: [Qemu-devel] [PATCH] pc: apic: fix touch LAPIC when irqchip is split === TEST SCRIPT BEGIN === #!/bin/bash B

Re: [Qemu-devel] [PATCH v3 2/3] target-ppc: add flag in chech_tlb_flush()

2016-09-13 Thread David Gibson
On Mon, Sep 12, 2016 at 11:18:33AM +0530, Nikunj A Dadhania wrote: > The flag will be used to indicate whether broadcast tlb flush is needed > or not. > > Moreover, BookS does both ptesync and tlbsync, so make that a nop for > the server and tlbsync would generate a check flush for BookE This com

[Qemu-devel] [PATCH] pc: apic: fix touch LAPIC when irqchip is split

2016-09-13 Thread Wanpeng Li
From: Wanpeng Li Add -kernel_irqchip=split ./x86-run x86/eventinj.flat qemu-system-x86_64 -enable-kvm -machine kernel_irqchip=split -cpu host -device pc-testdev -device isa-debug-exit,iobase=0xf4,iosize=0x4 -vnc none -serial stdio -device pci-testdev -kernel x86/eventinj.flat enabling apic pagin

Re: [Qemu-devel] [RFC PATCH v1 00/22] x86: Secure Encrypted Virtualization (AMD)

2016-09-13 Thread Michael S. Tsirkin
On Tue, Sep 13, 2016 at 10:46:46AM -0400, Brijesh Singh wrote: > This RFC series provides support for AMD's new Secure Encrypted > Virtualization (SEV) feature. This RFC is based KVM RFC [1]. > > SEV is an extension to the AMD-V architecture which supports running > multiple VMs under the control

Re: [Qemu-devel] [RFC PATCH v1 22/22] loader: reload bios image on ROM reset in SEV-enabled guest

2016-09-13 Thread Michael S. Tsirkin
On Wed, Sep 14, 2016 at 12:59:32AM +0200, Paolo Bonzini wrote: > > > On 13/09/2016 16:50, Brijesh Singh wrote: > > In SEV-enabled mode we need to reload the BIOS image on loader reset, this > > will ensure that BIOS image gets encrypted and included as part of launch > > meausrement on guest rese

Re: [Qemu-devel] [RFC PATCH v1 20/22] fw_cfg: sev: disable dma in real mode

2016-09-13 Thread Michael S. Tsirkin
On Wed, Sep 14, 2016 at 12:53:36AM +0200, Paolo Bonzini wrote: > > > On 13/09/2016 16:50, Brijesh Singh wrote: > > In SEV-enabled guest dma should be performed on shared pages. Since > > the SeaBIOS executes in non PAE mode and does not have access to C-bit > > to create a shared page hence disab

Re: [Qemu-devel] [RFC PATCH v1 10/22] sev: add SEV debug decrypt command

2016-09-13 Thread Michael S. Tsirkin
On Tue, Sep 13, 2016 at 10:48:27AM -0400, Brijesh Singh wrote: > The SEV DEBUG_DECRYPT command is used for decrypting a guest memory > for the debugging purposes. Note that debugging is permitting only > when guest policy allows it. When wouldn't you want to allow it? I don't see value in a "break

Re: [Qemu-devel] [PATCH v2 0/3] Remove the obsolete non-blocking connect

2016-09-13 Thread Cao jin
Hi Paolo, patch 1 seems conflicts with upstream when I rebase(conflicts with 616018352, but very tiny). and patch 2 isn't in your pull request. Do you want me to resend these two? On 08/01/2016 06:08 PM, Paolo Bonzini wrote: On 28/07/2016 11:03, Cao jin wrote: forget to cc maintainers in

Re: [Qemu-devel] [PULL 0/5] virtio,pci: fixes and updates

2016-09-13 Thread Michael S. Tsirkin
On Tue, Sep 13, 2016 at 11:32:32PM +0300, Michael S. Tsirkin wrote: > The following changes since commit 507e4ddc3abf67391bcbc9624fd60b969c159b78: > > Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-fetch' into > staging (2016-09-13 17:55:35 +0100) > > are available in the git r

Re: [Qemu-devel] [PULL 0/5] virtio,pci: fixes and updates

2016-09-13 Thread Michael S. Tsirkin
On Tue, Sep 13, 2016 at 02:27:59PM -0700, no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote: > Hi, > > Your series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 1473798735-6290-1-git-send-email-...@redhat.com > Subject: [Q

Re: [Qemu-devel] [PULL 0/5] virtio,pci: fixes and updates

2016-09-13 Thread Michael S. Tsirkin
On Tue, Sep 13, 2016 at 02:31:39PM -0700, no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote: > Hi, > > Your series failed automatic build test. Please find the testing commands and > their output below. If you have docker installed, you can probably reproduce > it > locally. Oops. I fixed

Re: [Qemu-devel] [PATCH v5] cutils: Rewrite x86 buffer zero checking

2016-09-13 Thread Richard Henderson
On 09/13/2016 04:21 PM, Paolo Bonzini wrote: On 13/09/2016 22:57, Richard Henderson wrote: -#if defined(CONFIG_AVX2_OPT) || (defined(CONFIG_CPUID_H) && defined(__SSE2__)) -#include - +#if (defined(CONFIG_AVX2_OPT) && defined(CONFIG_CPUID_H)) || defined(__SSE2__) Your __SSE2__ version is bet

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v2 02/15] crypto: introduce crypto queue handler

2016-09-13 Thread Gonglei (Arei)
Hi Ola, > -Original Message- > From: Ola Liljedahl [mailto:ola.liljed...@arm.com] > Sent: Tuesday, September 13, 2016 7:53 PM > To: Paolo Bonzini; Daniel P. Berrange; Gonglei (Arei) > Cc: qemu-devel@nongnu.org; virtio-...@lists.oasis-open.org; Huangpeng > (Peter); Luonengjun; m...@redhat

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v2 02/15] crypto: introduce crypto queue handler

2016-09-13 Thread Gonglei (Arei)
Hi Paolo, > -Original Message- > From: virtio-...@lists.oasis-open.org [mailto:virtio-...@lists.oasis-open.org] > On Behalf Of Paolo Bonzini > Sent: Tuesday, September 13, 2016 6:58 PM > To: Daniel P. Berrange; Gonglei (Arei) > Cc: qemu-devel@nongnu.org; virtio-...@lists.oasis-open.org; H

Re: [Qemu-devel] [PATCH qemu] spapr_pci: Add numa node id

2016-09-13 Thread Michael Roth
Quoting Alexey Kardashevskiy (2016-07-27 03:03:38) > This adds a numa id property to a PHB to allow linking passed PCI device > to CPU/memory. It is up to the management stack to do CPU/memory pinning > to the node with the actual PCI device. It looks like x86 relies on PCIBus->numa_node() method

Re: [Qemu-devel] [PATCH v5] cutils: Rewrite x86 buffer zero checking

2016-09-13 Thread Paolo Bonzini
On 13/09/2016 22:57, Richard Henderson wrote: > -#if defined(CONFIG_AVX2_OPT) || (defined(CONFIG_CPUID_H) && > defined(__SSE2__)) > -#include > - > +#if (defined(CONFIG_AVX2_OPT) && defined(CONFIG_CPUID_H)) || > defined(__SSE2__) Your __SSE2__ version is better than mine which required cpuid.

Re: [Qemu-devel] [RFC PATCH v1 17/22] target-i386: add cpuid Fn8000_001f

2016-09-13 Thread Paolo Bonzini
On 13/09/2016 16:49, Brijesh Singh wrote: > Fn8000_001f cpuid provides the memory encryption (aka C-bit) > > Signed-off-by: Brijesh Singh > --- > target-i386/cpu.c |3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index 6a1afab..e039c08 100

Re: [Qemu-devel] [RFC PATCH v1 19/22] exec: set debug attribute in SEV-enabled guest

2016-09-13 Thread Paolo Bonzini
On 13/09/2016 16:49, Brijesh Singh wrote: > When debug version of physical memory read APIs are called on SEV guest > then set the MemTxAttrs.sev_debug attribute to indicate that memory > read/write is requested for debug purposes. > > On SEV guest, the memory region read/write callback will che

Re: [Qemu-devel] [RFC PATCH v1 15/22] i386: sev: register RAM read/write ops for BIOS and PC.RAM region

2016-09-13 Thread Paolo Bonzini
On 13/09/2016 16:49, Brijesh Singh wrote: > > +/* Register SEV read/write ops for the guest RAM */ > +if (kvm_sev_enabled()) > +memory_region_set_ram_ops(ram, kvm_sev_get_ram_ops()); If you don't actually need this one except for -kernel it would be very nice, because then the

Re: [Qemu-devel] [RFC PATCH v1 13/22] hmp: update 'info kvm' to display SEV status

2016-09-13 Thread Paolo Bonzini
On 13/09/2016 16:48, Brijesh Singh wrote: > # > +# @sev: true if SEV is active You should add "(Since 2.8.0)" here. Paolo > # Since: 0.14.0 > ## > -{ 'struct': 'KvmInfo', 'data': {'enabled': 'bool', 'present': 'bool'} } > +{ 'struct': 'KvmInfo', 'data': {'enabled': 'bool', 'present': 'bool'

Re: [Qemu-devel] [RFC PATCH v1 04/22] memattrs: add SEV debug attrs

2016-09-13 Thread Paolo Bonzini
On 13/09/2016 16:47, Brijesh Singh wrote: > The patch adds sev_debug_mode attribute in MemTxAttrs. This attribute > will be set when debug version of memory read/write API's are used in > SEV-enabled guest. > > Signed-off-by: Brijesh Singh > --- > include/exec/memattrs.h |4 > 1 file

Re: [Qemu-devel] [RFC PATCH v1 22/22] loader: reload bios image on ROM reset in SEV-enabled guest

2016-09-13 Thread Paolo Bonzini
On 13/09/2016 16:50, Brijesh Singh wrote: > In SEV-enabled mode we need to reload the BIOS image on loader reset, this > will ensure that BIOS image gets encrypted and included as part of launch > meausrement on guest reset. Just to check if I understand correctly, the secure processor cannot sp

Re: [Qemu-devel] [PATCH v2] vfio: Add support for mmapping sub-page MMIO BARs

2016-09-13 Thread Alex Williamson
[cc +Paolo] On Thu, 11 Aug 2016 19:05:57 +0800 Yongji Xie wrote: > Now the kernel commit 05f0c03fbac1 ("vfio-pci: Allow to mmap > sub-page MMIO BARs if the mmio page is exclusive") allows VFIO > to mmap sub-page BARs. This is the corresponding QEMU patch. > With those patches applied, we could p

Re: [Qemu-devel] [RFC PATCH v1 20/22] fw_cfg: sev: disable dma in real mode

2016-09-13 Thread Paolo Bonzini
On 13/09/2016 16:50, Brijesh Singh wrote: > In SEV-enabled guest dma should be performed on shared pages. Since > the SeaBIOS executes in non PAE mode and does not have access to C-bit > to create a shared page hence disable the dma operation when reading > from fw_cfg interface. > > Signed-off-

Re: [Qemu-devel] [RFC PATCH v1 21/22] hw: add pre and post system reset callback

2016-09-13 Thread Paolo Bonzini
On 13/09/2016 16:50, Brijesh Singh wrote: > This patch adds methods to register a callback in qemu_system_reset(). > > - qemu_register_pre_reset() : function will be called just after > entering into qemu_system_reset(). > - qemu_register_post_reset(): function will be called just before > e

Re: [Qemu-devel] [RFC PATCH v1 05/22] i386: add new option to enable SEV guest

2016-09-13 Thread Paolo Bonzini
On 13/09/2016 16:47, Brijesh Singh wrote: > The patch adds '-sev' option to enable the Secure Encrypted > Virtualization (SEV) guest. If this option is specified, Qemu > assumes that user wants to launch this guest into SEV mode. > > Here are example on how to launch a guest into SEV mode. > >

Re: [Qemu-devel] [RFC PATCH v1 09/22] sev: add SEV launch finish command

2016-09-13 Thread Eduardo Habkost
On Tue, Sep 13, 2016 at 10:48:18AM -0400, Brijesh Singh wrote: > The SEV LAUNCH_FINISH command is used for finalizing the guest launch > process. The commad returned a measurement value that can be handed to > the guest owner to validate the guest before vmrun. > > For more information see [1], se

Re: [Qemu-devel] [RFC PATCH v1 06/22] sev: add initial SEV support

2016-09-13 Thread Eduardo Habkost
(CCing Daniel Berrange in case he has feedback on the nonce/dh_pub_qx/dh_pub_qy loading/parsing at the end of this message) On Tue, Sep 13, 2016 at 02:54:40PM -0500, Brijesh Singh wrote: > Hi Eduardo, > > On 09/13/2016 10:58 AM, Eduardo Habkost wrote: > > > > > > A typical SEV config file looks

Re: [Qemu-devel] [PULL 0/5] virtio,pci: fixes and updates

2016-09-13 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 1473798735-6290-1-git-send-email-...@redhat.com Subject: [Qemu-devel] [PULL 0/5] virtio,pci: fixes an

Re: [Qemu-devel] [PULL 0/5] virtio,pci: fixes and updates

2016-09-13 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1473798735-6290-1-git-send-email-...@redhat.com Subject: [Qemu-devel] [PULL 0/5] virtio,pci: fixes and updates === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(gi

Re: [Qemu-devel] qemu 2.7.0 incompatible with host kernel < 3.19

2016-09-13 Thread Laszlo Ersek
Hi, (CC Michael and Cornelia,) On 09/13/16 21:10, Brian Rak wrote: > I have some KVM hosts that I just upgraded to qemu 2.7.0. When the host > is running a kernel newer then 3.19, everything works fine. > > If the host is running on something lower then 3.19, some guests fail to > start. I not

Re: [Qemu-devel] [Xen-devel] [RFC] e1000: Don't save writes to ICS/ICR masked by IMS

2016-09-13 Thread Konrad Rzeszutek Wilk
On Thu, Sep 01, 2016 at 10:57:48AM -0700, Ed Swierk wrote: > Windows 8, 10 and Server 2012 guests hang intermittently while booting > on Xen 4.5.3 with 1 vCPU and 4 e1000 vNICs, shortly after the Windows > logo appears and the little dots start spinning. > > Running strace on qemu shows its main t

[Qemu-devel] [PATCH v5] cutils: Rewrite x86 buffer zero checking

2016-09-13 Thread Richard Henderson
Handle alignment of buffers, so that the vector paths can be used more often. Signed-off-by: Richard Henderson Signed-off-by: Paolo Bonzini --- util/bufferiszero.c | 236 1 file changed, 162 insertions(+), 74 deletions(-) Tested with Fedora

Re: [Qemu-devel] [RFC PATCH v1 20/22] fw_cfg: sev: disable dma in real mode

2016-09-13 Thread Michael S. Tsirkin
On Tue, Sep 13, 2016 at 03:46:15PM -0500, Brijesh Singh wrote: > Hi Michael, > > On 09/13/2016 01:39 PM, Michael S. Tsirkin wrote: > > On Tue, Sep 13, 2016 at 10:50:06AM -0400, Brijesh Singh wrote: > > > In SEV-enabled guest dma should be performed on shared pages. Since > > > the SeaBIOS executes

Re: [Qemu-devel] [RFC PATCH v1 20/22] fw_cfg: sev: disable dma in real mode

2016-09-13 Thread Brijesh Singh
Hi Michael, On 09/13/2016 01:39 PM, Michael S. Tsirkin wrote: On Tue, Sep 13, 2016 at 10:50:06AM -0400, Brijesh Singh wrote: In SEV-enabled guest dma should be performed on shared pages. Since the SeaBIOS executes in non PAE mode and does not have access to C-bit to create a shared page hence d

[Qemu-devel] [PULL 5/5] hw/i386: AMD IOMMU IVRS table

2016-09-13 Thread Michael S. Tsirkin
From: David Kiarie Add IVRS table for AMD IOMMU. Generate IVRS or DMAR depending on emulated IOMMU. Signed-off-by: David Kiarie --- include/hw/acpi/aml-build.h | 1 + include/hw/i386/x86-iommu.h | 12 +++ hw/acpi/aml-build.c | 2 +- hw/i386/acpi-build.c| 76 ++

[Qemu-devel] [PULL 4/5] hw/i386: Introduce AMD IOMMU

2016-09-13 Thread Michael S. Tsirkin
From: David Kiarie Add AMD IOMMU emulaton to Qemu in addition to Intel IOMMU. The IOMMU does basic translation, error checking and has a minimal IOTLB implementation. This IOMMU bypassed the need for target aborts by responding with IOMMU_NONE access rights and exempts the region 0xfee0-0xfee

[Qemu-devel] [PULL 1/5] virtio-bus: Plug devices after features are negotiated

2016-09-13 Thread Michael S. Tsirkin
From: Maxime Coquelin Currently, devices are plugged before features are negotiated. If the backend doesn't support VIRTIO_F_VERSION_1, the transport needs to rewind some settings. This is the case for CCW, for which a post_plugged callback had been introduced, where max_rev field is just update

[Qemu-devel] [PULL 0/5] virtio,pci: fixes and updates

2016-09-13 Thread Michael S. Tsirkin
The following changes since commit 507e4ddc3abf67391bcbc9624fd60b969c159b78: Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-fetch' into staging (2016-09-13 17:55:35 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_ups

[Qemu-devel] [PULL 3/5] hw/i386/trace-events: Add AMD IOMMU trace events

2016-09-13 Thread Michael S. Tsirkin
From: David Kiarie Signed-off-by: David Kiarie --- hw/i386/trace-events | 29 + 1 file changed, 29 insertions(+) diff --git a/hw/i386/trace-events b/hw/i386/trace-events index 5b99eba..d9646d1 100644 --- a/hw/i386/trace-events +++ b/hw/i386/trace-events @@ -13,3 +13

[Qemu-devel] [PULL 2/5] hw/pci: Prepare for AMD IOMMU

2016-09-13 Thread Michael S. Tsirkin
From: David Kiarie Introduce PCI macros from for use by AMD IOMMU Signed-off-by: David Kiarie --- include/hw/pci/pci.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index e8b83bb..74bb15c 100644 --- a/include/hw/pci/pci.h +++

Re: [Qemu-devel] [Qemu-stable] [ANNOUNCE] QEMU 2.6.1 Stable released

2016-09-13 Thread Peter Lieven
> Am 13.09.2016 um 20:04 schrieb Michael Roth : > > Quoting Peter Lieven (2016-09-13 10:52:04) >> >> Am 13.09.2016 um 17:42 schrieb Stefan Hajnoczi : On Thu, Sep 08, 2016 at 03:58:26PM -0500, Michael Roth wrote: Quoting Stefan Hajnoczi (2016-09-05 12:54:35) >> On Fri,

Re: [Qemu-devel] [RFC PATCH v1 06/22] sev: add initial SEV support

2016-09-13 Thread Michael S. Tsirkin
On Tue, Sep 13, 2016 at 02:54:40PM -0500, Brijesh Singh wrote: > Hi Eduardo, > > On 09/13/2016 10:58 AM, Eduardo Habkost wrote: > > > > > > A typical SEV config file looks like this: > > > > > > > Are those config options documented somewhere? > > > > Various commands and parameters are docum

Re: [Qemu-devel] [RFC PATCH v1 06/22] sev: add initial SEV support

2016-09-13 Thread Brijesh Singh
Hi Eduardo, On 09/13/2016 10:58 AM, Eduardo Habkost wrote: A typical SEV config file looks like this: Are those config options documented somewhere? Various commands and parameters are documented [1] [1] http://support.amd.com/TechDocs/55766_SEV-KM%20API_Spec.pdf [sev-launch] f

Re: [Qemu-devel] [PATCH v5] migrate: Move max-bandwidth and downtime-limit to migrate_set_parameter

2016-09-13 Thread Eric Blake
On 09/09/2016 02:02 PM, Ashijeet Acharya wrote: > Mark old-commands for speed and downtime as deprecated. Maybe s/old-commands for speed and downtime/the old commands 'migrate_set_speed' and 'migrate_set_downtime'/ > Move max-bandwidth and downtime-limit into migrate-set-parameters for > setting

Re: [Qemu-devel] seccomp missing calls in 2.7.0?

2016-09-13 Thread Brian Rak
getrusage is used in a number of places throughout the qemu codebase (notably, in crypto/pbkdf.c). Without this syscall being whitelisted, qemu ends up getting killed by the kernel whenever you try to connect to a VNC console. --- qemu-seccomp.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Qemu-devel] [Bug 889053] Re: x86: FPU_MAX, FPU_MIN incorrect

2016-09-13 Thread T. Huth
The patch mentioned in comment #5 has been included here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=a4d1f142542935b90d2e ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. http

[Qemu-devel] qemu 2.7.0 incompatible with host kernel < 3.19

2016-09-13 Thread Brian Rak
I have some KVM hosts that I just upgraded to qemu 2.7.0. When the host is running a kernel newer then 3.19, everything works fine. If the host is running on something lower then 3.19, some guests fail to start. I noticed this on a Ubuntu 16.04 guest, it fails to find the virtio NIC, and thi

Re: [Qemu-devel] [PULL 00/58] First round of misc patches for QEMU 2.8

2016-09-13 Thread Paolo Bonzini
On 13/09/2016 19:49, Peter Maydell wrote: > On 13 September 2016 at 18:15, Paolo Bonzini wrote: >> The following changes since commit fa9701240951093907076db0943f96972a396ef5: >> >> Merge remote-tracking branch 'remotes/kraxel/tags/pull-vga-20160913-1' >&

Re: [Qemu-devel] [PATCH v3 13/34] tcg: Add atomic helpers

2016-09-13 Thread Alex Bennée
Richard Henderson writes: > On 09/13/2016 10:06 AM, Alex Bennée wrote: >> I get a failure when building on centos6, x86: >> >> CCaarch64-softmmu/tcg/tcg-op.o >> /home/alex/lsrc/qemu.git/tcg/tcg-op.c:2280: error: >> ‘gen_helper_atomic_fetch_addb’ undeclared here (not in a function) >> /hom

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-09-13 Thread Lluís Vilanova
Daniel P Berrange writes: > On Thu, Sep 08, 2016 at 03:23:26PM +0200, Lluís Vilanova wrote: >> Daniel P Berrange writes: >> >> > I previously split the global trace-events file up into one file >> > per-subdirectory to avoid merge conflict hell. >> [...] >> >> Sorry, I could not find the message

Re: [Qemu-devel] [RFC PATCH v1 22/22] loader: reload bios image on ROM reset in SEV-enabled guest

2016-09-13 Thread Michael S. Tsirkin
On Tue, Sep 13, 2016 at 10:50:24AM -0400, Brijesh Singh wrote: > In SEV-enabled mode we need to reload the BIOS image on loader reset, this > will ensure that BIOS image gets encrypted and included as part of launch > meausrement on guest reset. > > Signed-off-by: Brijesh Singh Could you pls exp

[Qemu-devel] [PULL v2 00/58] First round of misc patches for QEMU 2.8

2016-09-13 Thread Paolo Bonzini
The following changes since commit fa9701240951093907076db0943f96972a396ef5: Merge remote-tracking branch 'remotes/kraxel/tags/pull-vga-20160913-1' into staging (2016-09-13 13:56:35 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstrea

[Qemu-devel] [PULL 55/58] cutils: Remove ppc buffer zero checking

2016-09-13 Thread Paolo Bonzini
From: Richard Henderson For ppc64le, gcc6 does extremely poorly with the Altivec code. Moreover, on POWER7 and POWER8, a hand-optimized Altivec version turns out to be no faster than the revised integer version, and therefore not worth the effort. Signed-off-by: Richard Henderson Signed-off-by:

Re: [Qemu-devel] [Qemu-stable] [ANNOUNCE] QEMU 2.6.1 Stable released

2016-09-13 Thread Michael Roth
Quoting Peter Lieven (2016-09-13 10:52:04) > > > > Am 13.09.2016 um 17:42 schrieb Stefan Hajnoczi : > > > >> On Thu, Sep 08, 2016 at 03:58:26PM -0500, Michael Roth wrote: > >> Quoting Stefan Hajnoczi (2016-09-05 12:54:35) > On Fri, Aug 26, 2016 at 01:45:56PM +0200, Peter Lieven wrote: > >>>

[Qemu-devel] [PULL 52/58] cutils: Export only buffer_is_zero

2016-09-13 Thread Paolo Bonzini
From: Richard Henderson Since the two users don't make use of the returned offset, beyond ensuring that the entire buffer is zero, consider the can_use_buffer_find_nonzero_offset and buffer_find_nonzero_offset functions internal. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Richard Hender

Re: [Qemu-devel] [RFC PATCH v1 20/22] fw_cfg: sev: disable dma in real mode

2016-09-13 Thread Michael S. Tsirkin
On Tue, Sep 13, 2016 at 10:50:06AM -0400, Brijesh Singh wrote: > In SEV-enabled guest dma should be performed on shared pages. Since > the SeaBIOS executes in non PAE mode and does not have access to C-bit > to create a shared page hence disable the dma operation when reading > from fw_cfg interfac

[Qemu-devel] [PULL 36/58] default-configs: remove CONFIG_PIIX_PCI

2016-09-13 Thread Paolo Bonzini
From: "Daniel P. Berrange" The CONFIG_PIIX_PCI=y setting was added in commit 70615c38ded2a20ad8282b7dcde95482fc0a7744 Author: Blue Swirl Date: Mon Mar 22 20:18:40 2010 + Compile sound devices only once but nothing in that commit, nor anything pre-existing, ever referenced CONF

  1   2   3   4   5   >