Re: [Qemu-devel] [PATCH 1/3] ppc/pnv: add skeleton PowerNV platform

On Fri, 2016-08-26 at 16:47 +0200, Cédric Le Goater wrote: > >> +static void powernv_machine_class_init(ObjectClass *oc, void > *data) > >> +{ > >> +    MachineClass *mc = MACHINE_CLASS(oc); > >> + > >> +    mc->init = ppc_powernv_init; > >> +    mc->reset = ppc_powernv_reset; > >> +    mc->block_d

Re: [Qemu-devel] [PATCH v2 5/5] 9p: forbid empty extension string

On Fri, Aug 26, 2016 at 02:00:37PM -0500, Eric Blake wrote: > On 08/26/2016 10:07 AM, Greg Kurz wrote: > > A buggy guest using the 9p2000.u protocol can issue a create request and > > pass an empty string as the extension argument. This causes QEMU to crash > > in the case of a hard link or a speci

Re: [Qemu-devel] [PATCH v3] tcg: Optimize fence instructions

Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH v3] tcg: Optimize fence instructions Type: series Message-id: 20160823134825.32578-1-bobby.pr...@

Re: [Qemu-devel] [PATCH v2 5/5] 9p: forbid empty extension string

On 08/26/2016 10:07 AM, Greg Kurz wrote: > A buggy guest using the 9p2000.u protocol can issue a create request and > pass an empty string as the extension argument. This causes QEMU to crash > in the case of a hard link or a special file, and leads to undefined > behavior, depending on the backend

Re: [Qemu-devel] [PATCH v2 4/5] 9p: handle walk of ".." in the root directory

On 08/26/2016 10:07 AM, Greg Kurz wrote: > The 9P spec at http://man.cat-v.org/plan_9/5/intro says: > > All directories must support walks to the directory .. (dot-dot) meaning > parent directory, although by convention directories contain no explicit > entry for .. or . (dot). The parent of the

Re: [Qemu-devel] [PATCH v2 3/5] 9p: forbid . and .. in file names

On 08/26/2016 10:07 AM, Greg Kurz wrote: > According to the 9P spec http://man.cat-v.org/plan_9/5/open about the > create request: > > The names . and .. are special; it is illegal to create files with these > names. > > This patch causes the create and lcreate requests to fail with EINVAL if > t

Re: [Qemu-devel] [PATCH v2 2/5] 9p: disallow the NUL character in all strings

On 08/26/2016 10:07 AM, Greg Kurz wrote: > According to the 9P spec at http://man.cat-v.org/plan_9/5/intro : > > Data items of larger or variable lengths are represented by a > two-byte field specifying a count, n, followed by n bytes of > data. Text strings are represented this way, with the tex

Re: [Qemu-devel] [PATCH v2 1/5] 9p: forbid illegal path names

On 08/26/2016 10:07 AM, Greg Kurz wrote: > Empty path components don't make sense and may cause undefined behavior, > depending on the backend. > > Also, the walk request described in the 9P spec [1] clearly shows that > the client is supposed to send individual path components: the official > lin

Re: [Qemu-devel] [PATCH] crypto: ensure XTS is only used with ciphers with 16 byte blocks

On Fri, Aug 26, 2016 at 01:21:50PM -0500, Eric Blake wrote: > On 08/26/2016 07:47 AM, Daniel P. Berrange wrote: > > The XTS cipher mode needs to be used with a cipher which has > > a block size of 16 bytes. If a mis-matching block size is used, > > the code will either corrupt memory beyond the IV

Re: [Qemu-devel] [PATCH] crypto: ensure XTS is only used with ciphers with 16 byte blocks

On 08/26/2016 07:47 AM, Daniel P. Berrange wrote: > The XTS cipher mode needs to be used with a cipher which has > a block size of 16 bytes. If a mis-matching block size is used, > the code will either corrupt memory beyond the IV array, or > not fully encrypt/decrypt the IV. > > This fixes a memo

Re: [Qemu-devel] [PATCH 3/3] ppc/pnv: add a PowerNVCPUCore object

On 08/16/2016 07:02 AM, Benjamin Herrenschmidt wrote: > On Tue, 2016-08-16 at 12:39 +1000, David Gibson wrote: >> On Fri, Aug 05, 2016 at 11:15:37AM +0200, Cédric Le Goater wrote: >>> >>> This is largy inspired by sPAPRCPUCore with some simplification, no >>> hotplug for instance. But the differenc

Re: [Qemu-devel] [PATCH 3/3] ppc/pnv: add a PowerNVCPUCore object

On 08/16/2016 04:39 AM, David Gibson wrote: > On Fri, Aug 05, 2016 at 11:15:37AM +0200, Cédric Le Goater wrote: >> This is largy inspired by sPAPRCPUCore with some simplification, no >> hotplug for instance. But the differences are small and the objects >> could possibly be merged. >> >> A set of P

Re: [Qemu-devel] [PATCH 2/3] ppc/pnv: add a PnvChip object

On 08/16/2016 04:21 AM, David Gibson wrote: > On Fri, Aug 05, 2016 at 11:15:36AM +0200, Cédric Le Goater wrote: >> This is is an abstraction of a P8 chip which is a set of cores plus >> other 'units', like the pervasive unit, the interrupt controller, the >> memory controller, the on-chip microcont

[Qemu-devel] KVM call for agenda for 2016-08-30

Hi Please, send any topic that you are interested in covering. At the end of Monday I will send an email with the agenda or the cancellation of the call, so hurry up. After discussions on the QEMU Summit, we are going to have always open a KVM call where you can add topics. Call details: By

[Qemu-devel] [PATCH] ipmi: chassis poweroff should use qemu_system_shutdown_request()

When issuing a chassis 'powerdown' control command, the routine qemu_system_shutdown_request() should be used to exit the guest. qemu_system_powerdown_request() will initiate a soft shutdown which is not what is required by the IPMI (28.3 Chassis Control Command): 0h = power down. Force system

[Qemu-devel] [Bug 1617385] [NEW] No snapshot possible with virtio-gpu activated

Public bug reported: I'm using "Qemu" and "Virtual Machine Manager" on Debian-8-Stretch - both newest versions out of the Debian-testing-repository (state 26.08.2016). If I try to save a virtual machine, it fails and I'll get the following error: libvirtError: internal error: unable to execute Q

Re: [Qemu-devel] a question

On 26 August 2016 at 10:31, Michael Rolnik wrote: > I want to partially implement AT STK500 board in order to run FreeRTOS AVR > / ATMegaAVR demo. > if you look into ATmega32 documentation you will see that, for example, > Timer/Countet1 registers are held together at memory addresses [0x46 .. >

[Qemu-devel] [Qemu-ppc] eTSEC device on ppce500

Hi, I am interested in using the eTSEC for ppce500, but looking through the code tree it seems the "etsec_create" function is never called. Perhaps I'm not using the right command when starting QEMU, do we have an example for eTSEC ? What I tried so far is: qemu-system-ppc -M ppce500 -cpu e500mc

[Qemu-devel] [PATCH v2 0/5] 9P security fixes

As reported by Felix Wilhelm, at various places in 9pfs, full paths are created by concatenating a guest originated string to the export path. A malicious guest could forge a relative path and access files outside the export path. A tentative fix was sent recently by Prasad J Pandit, but it was on

[Qemu-devel] [PATCH v2 5/5] 9p: forbid empty extension string

A buggy guest using the 9p2000.u protocol can issue a create request and pass an empty string as the extension argument. This causes QEMU to crash in the case of a hard link or a special file, and leads to undefined behavior, depending on the backend, in the case of a symbolic link. This patch cau

[Qemu-devel] [PATCH v2 2/5] 9p: disallow the NUL character in all strings

According to the 9P spec at http://man.cat-v.org/plan_9/5/intro : Data items of larger or variable lengths are represented by a two-byte field specifying a count, n, followed by n bytes of data. Text strings are represented this way, with the text itself stored as a UTF-8 encoded sequence of Unic

[Qemu-devel] [PATCH v2 1/5] 9p: forbid illegal path names

Empty path components don't make sense and may cause undefined behavior, depending on the backend. Also, the walk request described in the 9P spec [1] clearly shows that the client is supposed to send individual path components: the official linux client never sends portions of path containing the

[Qemu-devel] [PATCH v2 4/5] 9p: handle walk of ".." in the root directory

The 9P spec at http://man.cat-v.org/plan_9/5/intro says: All directories must support walks to the directory .. (dot-dot) meaning parent directory, although by convention directories contain no explicit entry for .. or . (dot). The parent of the root directory of a server's tree is itself. This

[Qemu-devel] [PATCH v2 3/5] 9p: forbid . and .. in file names

According to the 9P spec http://man.cat-v.org/plan_9/5/open about the create request: The names . and .. are special; it is illegal to create files with these names. This patch causes the create and lcreate requests to fail with EINVAL if the file name is either "." or "..". Even if it isn't exp

Re: [Qemu-devel] [PATCH 1/3] ppc/pnv: add skeleton PowerNV platform

On 08/16/2016 04:12 AM, David Gibson wrote: > On Fri, Aug 05, 2016 at 11:15:35AM +0200, Cédric Le Goater wrote: >> From: Benjamin Herrenschmidt >> >> The goal is to emulate a PowerNV system at the level of the skiboot >> firmware, which loads the OS and provides some runtime services. Power >> Sys

[Qemu-devel] Problem at confirm test 2.6 -> 2.7-RCx

Hello, at our test (upgrade from qemu 2.6 -> 2.7[rc2/3/4]) the following problem occur: 2016-08-25T09:42:32.066972+02:00 etcsvms3 systemd[1]: Starting Virtual Machine qemu-8-VTC61CST. 2016-08-25T09:42:32.067331+02:00 etcsvms3 systemd-machined[16661]: New machine qemu-8-VTC61CST. 2016-08-25T09:42

[Qemu-devel] a question

Hi all, I want to partially implement AT STK500 board in order to run FreeRTOS AVR / ATMegaAVR demo. if you look into ATmega32 documentation you will see th

Re: [Qemu-devel] [PATCH v7 2/4] vfio: VFIO driver for mediated devices

On 8/25/2016 2:52 PM, Dong Jia wrote: > On Thu, 25 Aug 2016 09:23:53 +0530 > Kirti Wankhede wrote: > > [...] > > Dear Kirti, > > I just rebased my vfio-ccw patches to this series. > With a little fix, which was pointed it out in my reply to the #3 > patch, it works fine. > Thanks for update

Re: [Qemu-devel] [PATCH v7 3/4] vfio iommu: Add support for mediated devices

Oh, that's the last minute change after running checkpatch.pl :( Thanks for catching that. I'll correct that. Thanks, Kirti On 8/25/2016 12:59 PM, Dong Jia wrote: > On Thu, 25 Aug 2016 09:23:54 +0530 > Kirti Wankhede wrote: > >> @@ -769,6 +1090,33 @@ static int vfio_iommu_type1_attach_group(vo

Re: [Qemu-devel] [Qemu-stable] [ANNOUNCE] QEMU 2.6.1 Stable released

Am 25.08.2016 um 19:23 schrieb Michael Roth: Quoting Peter Lieven (2016-08-25 01:38:13) Am 17.08.2016 um 21:30 schrieb Michael Roth: Hi everyone, I am pleased to announce that the QEMU v2.6.1 stable release is now available: http://wiki.qemu.org/download/qemu-2.6.1.tar.bz2 v2.6.1 is now

Re: [Qemu-devel] Effective way to test PowerPC lwbrx instruction

On Aug 25, 2016, at 10:30 PM, Thomas Huth wrote: On 25.08.2016 18:55, G 3 wrote: On Aug 25, 2016, at 6:03 PM, Thomas Huth wrote: On 25.08.2016 14:54, G 3 wrote: I'm chasing down a bug with QEMU that causes audio to fail on a Mac OS guest. In this file: https://github.com/nixxcode/AppleUS

Re: [Qemu-devel] [Qemu-stable] [PATCH v2 for 2.7] ui: fix refresh of VNC server surface

Am 25.08.2016 um 14:46 schrieb Daniel P. Berrange: On Thu, Aug 25, 2016 at 09:15:52AM +0200, Peter Lieven wrote: Am 24.08.2016 um 17:49 schrieb Daniel P. Berrange: On Wed, Aug 24, 2016 at 04:46:31PM +0100, Peter Maydell wrote: On 23 August 2016 at 07:50, Peter Lieven wrote: Am 16.08.2016 um

Re: [Qemu-devel] [PATCH 2/3] qemu: Implement virtio-pstore device

On Fri, Aug 26, 2016 at 01:48:40PM +0900, Namhyung Kim wrote: > Hi Daniel, > > On Wed, Aug 24, 2016 at 06:00:51PM -0400, Daniel P. Berrange wrote: > > > +fd = open(filename, O_RDONLY); > > > +if (fd < 0) { > > > +error_report("cannot open %s", filename); > > > +goto out; >

Re: [Qemu-devel] [PATCH RFC 00/22] I/O prefetch cache

Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH RFC 00/22] I/O prefetch cache Type: series Message-id: 20160825134421.20231-1-pbutsy...@virtuozzo

Re: [Qemu-devel] [PATCH] fixup! int128: Use __int128 if available

Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH] fixup! int128: Use __int128 if available Type: series Message-id: 1472152170-18562-1-git-send-em

[Qemu-devel] [PATCH] crypto: ensure XTS is only used with ciphers with 16 byte blocks

The XTS cipher mode needs to be used with a cipher which has a block size of 16 bytes. If a mis-matching block size is used, the code will either corrupt memory beyond the IV array, or not fully encrypt/decrypt the IV. This fixes a memory curruption crash when attempting to use cast5-128 with xts,

[Qemu-devel] [PATCH] console: skip same-size resize

virtio-gpu does a set-scanout at each frame (it might be a driver regression). qemu_console_resize() recreate a surface even if the size didn't change, and this shows up in profiling reports because the surface is cleared. With this patch, I get a +15-20% glmark2 improvement. Signed-off-by: Marc-A

[Qemu-devel] [PATCH v2 6/7] qemu-img: clean up dd documentation

The dd section on qemu-img --help was a bit hard to read since it was not well aligned. This patch fixes the display problem and also makes the sentences on the .texi file more consistent with one another (uppercase and conjugasion). Signed-off-by: Reda Sallahi Reviewed-by: Stefan Hajnoczi ---

[Qemu-devel] [PATCH v2 4/7] qemu-img: delete not used variable and an unecessary check

block_count is not used in img_dd() and the C_SKIP check is unecessary so this patch removes both of them. Signed-off-by: Reda Sallahi Reviewed-by: Stefan Hajnoczi --- qemu-img.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index a4d0556..bd

[Qemu-devel] [PATCH v2 7/7] qemu-img: add a test suite for the count option

The count option for dd lacked a test suite so this adds one with four test cases. Signed-off-by: Reda Sallahi Reviewed-by: Stefan Hajnoczi --- tests/qemu-iotests/168 | 75 ++ tests/qemu-iotests/168.out | 51 +++ tests/

[Qemu-devel] [PATCH v2 5/7] qemu-img: add status option to dd

This patch adds the status option to the subcommand dd. With this dd will display by default the number of blocks read/written, the transfer rate, etc. like dd(1). The noxfer and none levels will allow the user to surpress the final transfer statistics and everything except error messages respecti

[Qemu-devel] [PATCH v2 1/7] qemu-img: add seek option to dd

This patch adds the seek option which allows qemu-img dd to skip a number of blocks on the output before copying the input. A test case was added to test the seek option. Signed-off-by: Reda Sallahi Reviewed-by: Stefan Hajnoczi --- qemu-img-cmds.hx | 4 +-- qemu-img.c

[Qemu-devel] [PATCH v2 3/7] qemu-img: add more conv= conversions to dd

This patch adds excl, nocreat, noerror, sync, fsync, fdatasync and sparse to the conversion list. They have the same meaning as the ones on GNU dd(1). Two tests were added to test the conv= option. Signed-off-by: Reda Sallahi --- qemu-img-cmds.hx | 4 +- qemu-img.c |

[Qemu-devel] [PATCH v2 2/7] qemu-img: add iflag and oflag options to dd

This adds the iflag and oflag options which defines the list of flags used for reading and writing respectively. The list is comma-separated. The iflag option supports direct, dsync, sync, count_bytes and skip_bytes and oflag supports direct, dsync, sync and seek_bytes. They are similar to their c

[Qemu-devel] [PATCH v2 0/7] qemu-img dd

Hi everyone, This patchset adds additional options to qemu-img dd. Depends on: [PATCH v5] qemu-img: change opening method for the output in dd Changes from v1: * Use for qemu_{timersub,gettimeofday} instead of timersub and gettimeofday. * Add skip= and seek= options for test case 167. * Put the

[Qemu-devel] [PATCH] trace: Allow events without arguments

Signed-off-by: Lluís Vilanova --- scripts/tracetool/__init__.py |5 + 1 file changed, 5 insertions(+) diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py index be24039..96657e6 100644 --- a/scripts/tracetool/__init__.py +++ b/scripts/tracetool/__init__.py @@ -72,6

[Qemu-devel] [PATCH v5] qemu-img: change opening method for the output in dd

The subcommand dd was creating an output image regardless of whether there was one already created. With this patch we try to check first if the output image exists and resize it if necessary. We also make it mandatory to specify conv=notrunc when the file already exists. Signed-off-by: Reda Sall