Re: [Qemu-devel] [PATCH 2/3] checkpatch: bump most warnings to errors

2016-08-09 Thread Markus Armbruster
Paolo Bonzini writes: > This only leaves a warning-level message for extra-long lines, which > are relatively common and cause patchew to send email that will likely > be ignored. > > Signed-off-by: Paolo Bonzini Are we ready to give up on illegibly long lines? What happened to "[PATCH 2/4] CO

Re: [Qemu-devel] [PATCH 1/3] checkpatch: tweak the files in which TABs are checked

2016-08-09 Thread Markus Armbruster
Paolo Bonzini writes: > Include Python and shell scripts, and make an exception for Perl > scripts we imported from Linux or elsewhere. > > Signed-off-by: Paolo Bonzini > --- > scripts/checkpatch.pl | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/scripts/checkpatc

Re: [Qemu-devel] [RFC 1/2] hw/msi: Allow platform devices to use explicit SID

2016-08-09 Thread David Kiarie
On Wed, Aug 10, 2016 at 8:41 AM, Peter Xu wrote: > On Tue, Aug 09, 2016 at 05:32:16PM +0300, David Kiarie wrote: > > When using IOMMU platform devices like IOAPIC are required to make > > interrupt remapping requests using explicit SID.We affiliate an MSI > > route with a requester ID and a PCI d

Re: [Qemu-devel] [RFC 2/2] hw/i386: enforce SID verification

2016-08-09 Thread David Kiarie
On Wed, Aug 10, 2016 at 8:49 AM, Peter Xu wrote: > On Tue, Aug 09, 2016 at 05:32:17PM +0300, David Kiarie wrote: > > [...] > > > @@ -2252,14 +2250,17 @@ static MemTxResult vtd_mem_ir_write(void > *opaque, hwaddr addr, > > { > > int ret = 0; > > MSIMessage from = {}, to = {}; > > -u

Re: [Qemu-devel] [V15 3/4] hw/i386: Introduce AMD IOMMU

2016-08-09 Thread David Kiarie
On Wed, Aug 10, 2016 at 5:08 AM, Peter Xu wrote: > On Tue, Aug 09, 2016 at 03:52:07PM +0300, David Kiarie wrote: > > [...] > > > > > +if (dma_memory_write(&address_space_memory, s->evtlog_len + > > > s->evtlog_tail, > > > > +&evt, AMDVI_EVENT_LEN)) { > > > > > > Check with MEMTX_OK? >

Re: [Qemu-devel] [PATCH] migration: fix live migration failure with compression

2016-08-09 Thread Li, Liang Z
> Subject: Re: [PATCH] migration: fix live migration failure with compression > > * Liang Li (liang.z...@intel.com) wrote: > > Because of commit 11808bb0c422, which remove some condition checks of > > 'f->ops->writev_buffer', 'qemu_put_qemu_file' should be enhanced to > > clear the 'f_src->iovcnt'

[Qemu-devel] [PULL 2/6] spapr: remove extra type variable

2016-08-09 Thread David Gibson
From: Cédric Le Goater The sPAPR CPU core typename is already available in the upper block. Let's use it and move the check upward also. Signed-off-by: Cédric Le Goater Reviewed-by: Thomas Huth Signed-off-by: David Gibson --- hw/ppc/spapr.c | 15 ++- 1 file changed, 6 insertions(

[Qemu-devel] [PULL 0/6] ppc-for-2.7 queue 20160810

2016-08-09 Thread David Gibson
The following changes since commit 2bb15bddf2607110820d5ce5aa43baac27292fb3: Merge remote-tracking branch 'remotes/jnsnow/tags/ide-pull-request' into staging (2016-08-09 16:53:32 +0100) are available in the git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-2.7-20160810 for

Re: [Qemu-devel] [PATCH v2] spar: remove extra type variable

2016-08-09 Thread David Gibson
On Tue, Aug 09, 2016 at 01:15:05PM +0200, Cédric Le Goater wrote: > The sPAPR CPU core typename is already available in the upper > block. Let's use it and move the check upward also. > > Signed-off-by: Cédric Le Goater I already merged this as part of Thomas' series. > --- > hw/ppc/spapr.c |

[Qemu-devel] [PULL 3/6] ppc: Introduce a function to look up CPU alias strings

2016-08-09 Thread David Gibson
From: Thomas Huth We will need this function to look up the aliases in the spapr-cpu-core code, too. Signed-off-by: Thomas Huth Signed-off-by: David Gibson --- target-ppc/cpu.h| 1 + target-ppc/translate_init.c | 13 + 2 files changed, 14 insertions(+) diff --git a/t

Re: [Qemu-devel] [RFC 2/2] hw/i386: enforce SID verification

2016-08-09 Thread Peter Xu
On Tue, Aug 09, 2016 at 05:32:17PM +0300, David Kiarie wrote: [...] > @@ -2252,14 +2250,17 @@ static MemTxResult vtd_mem_ir_write(void *opaque, > hwaddr addr, > { > int ret = 0; > MSIMessage from = {}, to = {}; > -uint16_t sid = X86_IOMMU_SID_INVALID; > +VTDAddressSpace *as =

[Qemu-devel] [PULL 1/6] ppc64: fix compressed dump with pseries kernel

2016-08-09 Thread David Gibson
From: Laurent Vivier If we don't provide the page size in target-ppc:cpu_get_dump_info(), the default one (TARGET_PAGE_SIZE, 4KB) is used to create the compressed dump. It works fine with Macintosh, but not with pseries as the kernel default page size is 64KB. Without this patch, if we generate

[Qemu-devel] [PULL 6/6] ppc/kvm: Register also a generic spapr CPU core family type

2016-08-09 Thread David Gibson
From: Thomas Huth There is a regression with the "-cpu" parameter introduced by the spapr CPU hotplug code: We used to allow to specify a "CPU family" name with the "-cpu" parameter when running on KVM so that the user does not need to know the gory details of the exact CPU version of the host CP

Re: [Qemu-devel] Dangling change state handler while hot unplugging ahci adapter

2016-08-09 Thread Ashijeet Acharya
On Tue, Aug 9, 2016 at 11:48 PM, John Snow wrote: > > > On 08/09/2016 01:16 PM, Ashijeet Acharya wrote: >> >> Hi again, >> I am still waiting for some guidance...Can I please get some help with >> this? >> >> Also.. I tried hotplugging an AHCI adapter but got the following error: >> Bus 'ahci.0' d

[Qemu-devel] [PULL 4/6] hw/ppc/spapr: Look up CPU alias names instead of hard-coding the aliases

2016-08-09 Thread David Gibson
From: Thomas Huth Hard-coding the CPU alias names in the spapr_cores[] array has two big disadvantages: 1) We register a real type with the CPU alias name in spapr_cpu_core_register_types() - this prevents us from registering a CPU family name in kvm_ppc_register_host_cpu_type() with the s

[Qemu-devel] [PULL 5/6] ppc/kvm: Do not mess up the generic CPU family registration

2016-08-09 Thread David Gibson
From: Thomas Huth The code for registering the sPAPR CPU host core type has been added inbetween the generic CPU host core type and the generic CPU family type. That way the instance_init and the class_init information got lost when registering the generic CPU family type. Fix it by moving the ge

Re: [Qemu-devel] [PATCH qemu] spapr_pci: Add numa node id

2016-08-09 Thread Alexey Kardashevskiy
On 27/07/16 18:03, Alexey Kardashevskiy wrote: > This adds a numa id property to a PHB to allow linking passed PCI device > to CPU/memory. It is up to the management stack to do CPU/memory pinning > to the node with the actual PCI device. > > Signed-off-by: Alexey Kardashevskiy Ping? > --- >

Re: [Qemu-devel] [RFC 1/2] hw/msi: Allow platform devices to use explicit SID

2016-08-09 Thread Peter Xu
On Tue, Aug 09, 2016 at 05:32:16PM +0300, David Kiarie wrote: > When using IOMMU platform devices like IOAPIC are required to make > interrupt remapping requests using explicit SID.We affiliate an MSI > route with a requester ID and a PCI device if present which ensures > that platform devices can

Re: [Qemu-devel] [PATCH V2] add migration capability to bypass the shared memory

2016-08-09 Thread Li, Liang Z
> On Wed, Aug 10, 2016 at 10:22 AM, Li, Liang Z wrote: > > Hi Jiangshan, > > > > Glad to see your patch. It's a simple implementation which could provide > very useful functions. > > > >> +static void migration_bitmap_init(unsigned long *bitmap) { > >> +RAMBlock *block; > >> + > >> +bitmap

Re: [Qemu-devel] [PATCH v2 4/5] target-ppc: add vector bit permute doubleword instruction

2016-08-09 Thread Richard Henderson
On 08/09/2016 03:42 PM, Rajalakshmi Srinivasaraghavan wrote: +void helper_vbpermd(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b) +{ +int i, j; +uint64_t perm = 0; + +VECTOR_FOR_INORDER_I(i, u64) { +perm = 0; +for (j = 0; j < 8; j++) { +int index = VBPERMQ_INDEX(

Re: [Qemu-devel] [PATCH v2 0/5] spapr: Fix regression in CPU alias handling

2016-08-09 Thread David Gibson
On Tue, Aug 09, 2016 at 06:59:56PM +0200, Thomas Huth wrote: > There is a regression with the "-cpu" parameter which has been > introduced by the spapr CPU hotplug code: We used to allow to specify > a "CPU family" name with the "-cpu" parameter when running on KVM so > that the user does not need

Re: [Qemu-devel] [PATCH COLO-Frame v18 17/34] COLO failover: Introduce state to record failover process

2016-08-09 Thread Hailiang Zhang
On 2016/8/9 17:17, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: +error_report("Unkown error for failover, old_state=%d", old_state); Tiny typo; 'Unknown'. Don't bother reposting just for that, we can fix it later; or fix it if you have to rep

Re: [Qemu-devel] [PATCH v2 1/5] target-ppc: add vector insert instructions

2016-08-09 Thread Rajalakshmi Srinivasaraghavan
On 08/09/2016 11:50 PM, Richard Henderson wrote: On 08/09/2016 03:42 PM, Rajalakshmi Srinivasaraghavan wrote: +for (i = 0; i < ARRAY_SIZE(r->element); i++) { \ +result.element[i] = r->element[i]; \ + } \ memcpy, or assig

Re: [Qemu-devel] [PATCH 2/2] intel-iommu: restrict EIM to quirkless KVM

2016-08-09 Thread Peter Xu
On Tue, Aug 09, 2016 at 05:03:33PM +0200, Radim Krčmář wrote: > APIC in QEMU doesn't support x2APIC so exposing EIM is pointless and KVM > has a quirk that needs to be disabled unless we want x2APIC message with > destination 0xff to be misinterpreted as a broadcast. > > Signed-off-by: Radim Krčmá

Re: [Qemu-devel] [PATCH V2] add migration capability to bypass the shared memory

2016-08-09 Thread Lai Jiangshan
On Wed, Aug 10, 2016 at 10:22 AM, Li, Liang Z wrote: > Hi Jiangshan, > > Glad to see your patch. It's a simple implementation which could provide very > useful functions. > >> +static void migration_bitmap_init(unsigned long *bitmap) { >> +RAMBlock *block; >> + >> +bitmap_clear(bitmap, 0,

Re: [Qemu-devel] [PATCH v3 8/9] vl: Switch qemu_uuid to QemuUUID

2016-08-09 Thread Jeff Cody
On Wed, Aug 10, 2016 at 09:28:56AM +0800, Fam Zheng wrote: > On Tue, 08/09 17:45, Jeff Cody wrote: > > > diff --git a/util/uuid.c b/util/uuid.c > > > index 80c89f0..5d8bc88 100644 > > > --- a/util/uuid.c > > > +++ b/util/uuid.c > > > @@ -61,18 +61,19 @@ char *qemu_uuid_unparse_strdup(const QemuUUID

[Qemu-devel] [PATCH RFC] msix_init: input params *_offset isn't the real one

2016-08-09 Thread Cao jin
The parameter table_offset & pba_offset is kind of confusing, they shouldn't include bir field. Signed-off-by: Cao jin --- According to the passed arguments, I guess all the callers of msix_init() has the same feeling with me, but I am not quite sure about this, so, RFC. hw/pci/msix.c | 7 +++-

Re: [Qemu-devel] [PATCH] curl: Cast fd to int for DPRINTF

2016-08-09 Thread Fam Zheng
On Mon, 08/01 13:04, Fam Zheng wrote: > Currently "make docker-test-mingw@fedora" has a warning like: > > /tmp/qemu-test/src/block/curl.c: In function 'curl_sock_cb': > /tmp/qemu-test/src/block/curl.c:172:6: warning: format '%d' expects > argument of type 'int', but argument 4 has type

[Qemu-devel] [PATCH v9] qemu-img: add the 'dd' subcommand

2016-08-09 Thread Reda Sallahi
This patch adds a basic dd subcommand analogous to dd(1) to qemu-img. For the start, this implements the bs, if, of and count options and requires both if and of to be specified (no stdin/stdout if not specified) and doesn't support tty, pipes, etc. The image format must be specified with -O for

Re: [Qemu-devel] [PATCH V2] add migration capability to bypass the shared memory

2016-08-09 Thread Li, Liang Z
Hi Jiangshan, Glad to see your patch. It's a simple implementation which could provide very useful functions. > +static void migration_bitmap_init(unsigned long *bitmap) { > +RAMBlock *block; > + > +bitmap_clear(bitmap, 0, last_ram_offset() >> TARGET_PAGE_BITS); > +rcu_read_lock(); >

Re: [Qemu-devel] [PULL 2/2] docker: Add "--enable-werror" to configure command line

2016-08-09 Thread Fam Zheng
On Tue, 08/09 17:21, Paolo Bonzini wrote: > > > On 05/08/2016 11:04, Fam Zheng wrote: > > We don't have .git in the docker checkout, add this to enable -Werror > > explicitly. > > > > Signed-off-by: Fam Zheng > > Message-id: 1469453510-658-1-git-send-email-f...@redhat.com > > --- > > tests/doc

Re: [Qemu-devel] [PATCH 0/3] checkpatch tweaks

2016-08-09 Thread Fam Zheng
On Tue, 08/09 17:47, Paolo Bonzini wrote: > My proposal after having watched patchew complain for a couple days > about patches being sent on the list. Looks good to me, I think patchew will just work as you want (be silent with long line warnings) once these are merged. Fam

Re: [Qemu-devel] [PATCH 1/3] checkpatch: tweak the files in which TABs are checked

2016-08-09 Thread Fam Zheng
On Tue, 08/09 17:47, Paolo Bonzini wrote: > Include Python and shell scripts, and make an exception for Perl > scripts we imported from Linux or elsewhere. > > Signed-off-by: Paolo Bonzini > --- > scripts/checkpatch.pl | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git

Re: [Qemu-devel] [V15 3/4] hw/i386: Introduce AMD IOMMU

2016-08-09 Thread Peter Xu
On Tue, Aug 09, 2016 at 03:52:07PM +0300, David Kiarie wrote: [...] > > > +if (dma_memory_write(&address_space_memory, s->evtlog_len + > > s->evtlog_tail, > > > +&evt, AMDVI_EVENT_LEN)) { > > > > Check with MEMTX_OK? > > > > I'm not sure what exactly you mean here. I mean we have re

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-08-09 Thread Fam Zheng
On Tue, 08/09 18:11, Daniel P. Berrange wrote: > so we don't have to go digging into the docker test systemm to > try and reverse engineer this info Actually, digging this info is pretty easy if you already use docker test locally (if you don't, may I ask why?). Just append DEBUG=1 and you can mes

Re: [Qemu-devel] [V15 3/4] hw/i386: Introduce AMD IOMMU

2016-08-09 Thread Peter Xu
On Tue, Aug 09, 2016 at 08:46:09PM +0300, David Kiarie wrote: > On Tue, Aug 9, 2016 at 8:44 AM, Peter Xu wrote: > > > On Tue, Aug 02, 2016 at 11:39:06AM +0300, David Kiarie wrote: > > > > [...] > > > > > +/* external write */ > > > +static void amdvi_writew(AMDVIState *s, hwaddr addr, uint16_t va

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-08-09 Thread Fam Zheng
On Tue, 08/09 18:11, Daniel P. Berrange wrote: > > Can we get this report to include details of the > > a) the software versions of gcc, binutils, and any -devel packages > we're building against > > b) the exact arguments + env variables used to invoke configure, > not merely its

Re: [Qemu-devel] [PATCH v3 8/9] vl: Switch qemu_uuid to QemuUUID

2016-08-09 Thread Fam Zheng
On Tue, 08/09 17:45, Jeff Cody wrote: > > diff --git a/util/uuid.c b/util/uuid.c > > index 80c89f0..5d8bc88 100644 > > --- a/util/uuid.c > > +++ b/util/uuid.c > > @@ -61,18 +61,19 @@ char *qemu_uuid_unparse_strdup(const QemuUUID *uuid) > > uu[13], uu[14], uu[15]); > > }

Re: [Qemu-devel] [PATCH v3 1/9] util: Add UUID API

2016-08-09 Thread Fam Zheng
On Tue, 08/09 15:46, Jeff Cody wrote: > So the short of it: I think this new function should be explicitly called > something like "qemu_uuid_bswap()", and do blind bswaps. That makes it a > drop in replacement for VDI. Right, I should make it bswap. Fam

Re: [Qemu-devel] [PATCH V2] add migration capability to bypass the shared memory

2016-08-09 Thread Fam Zheng
On Wed, 08/10 08:54, Lai Jiangshan wrote: > When the migration capability 'bypass-shared-memory' > is set, the shared memory will be bypassed when migration. > > It is the key feature to enable several excellent features for > the qemu, such as qemu-local-migration, qemu-live-update, > extremely-f

Re: [Qemu-devel] [PATCH v6 1/2] virtio-crypto: Add virtio crypto device specification

2016-08-09 Thread Gonglei (Arei)
Hi guys, Thanks for your good comments, we should come to an agreement on droping version filed In virtio crypto specific. And I'll update a new version soon. Regards, -Gonglei > -Original Message- > From: Zeng, Xin [mailto:xin.z...@intel.com] > Sent: Tuesday, August 09, 2016 9:42 PM >

Re: [Qemu-devel] [PATCH] add migration capability to bypass the shared memory

2016-08-09 Thread Lai Jiangshan
On Wed, Aug 10, 2016 at 3:12 AM, Dr. David Alan Gilbert wrote: > * Lai Jiangshan (jiangshan...@gmail.com) wrote: >> The feature vm-template makes the containers(VMs) can >> be started in 130ms and save 80M memory for every >> container(VM). So that the hyper containers are fast >> and high-density

Re: [Qemu-devel] [PATCH v2 1/1] block/gluster: improve defense over string to int conversion

2016-08-09 Thread Jeff Cody
On Tue, Aug 09, 2016 at 02:20:09PM +0530, Prasanna Kumar Kalever wrote: > using atoi() for converting string to int may be error prone in case if > string supplied in the argument is not a fold of numerical number, > > This is not a bug because in the existing code, > > static QemuOptsList runtim

[Qemu-devel] [PATCH V2] add migration capability to bypass the shared memory

2016-08-09 Thread Lai Jiangshan
When the migration capability 'bypass-shared-memory' is set, the shared memory will be bypassed when migration. It is the key feature to enable several excellent features for the qemu, such as qemu-local-migration, qemu-live-update, extremely-fast-save-restore, vm-template, vm-fast-live-clone, yet

Re: [Qemu-devel] [PATCH v10 3/8] loader: Allow a custom AddressSpace when loading ROMs

2016-08-09 Thread Alistair Francis
On Tue, Aug 9, 2016 at 11:44 AM, Peter Maydell wrote: > On 3 August 2016 at 21:06, Alistair Francis > wrote: >> When loading ROMs allow the caller to specify an AddressSpace to use for >> the load. >> >> Signed-off-by: Alistair Francis >> --- >> V10: >> - Set the rom address space instead of l

Re: [Qemu-devel] [RFC v2 PATCH] tcg: Optimize fence instructions

2016-08-09 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 20160809231246.4537-1-bobby.pr...@gmail.com Type: series Subject: [Qemu-devel] [RFC v2 PATCH] tcg: Optimize fence

Re: [Qemu-devel] [PULL 3/3] hw/net: Fix a heap overflow in xlnx.xps-ethernetlite

2016-08-09 Thread Alistair Francis
On Tue, Aug 9, 2016 at 12:34 AM, Jason Wang wrote: > From: chaojianhu > > The .receive callback of xlnx.xps-ethernetlite doesn't check the length > of data before calling memcpy. As a result, the NetClientState object in > heap will be overflowed. All versions of qemu with xlnx.xps-ethernetlite >

[Qemu-devel] [RFC v2 PATCH] tcg: Optimize fence instructions

2016-08-09 Thread Pranith Kumar
This commit optimizes fence instructions. Two optimizations are currently implemented. These are: 1. Unnecessary duplicate fence instructions If the same fence instruction is detected consecutively, we remove one instance of it. ex: mb; mb => mb, strl; strl => strl 2. Merging weaker fe

Re: [Qemu-devel] [PATCH v10 8/8] docs: Add a generic loader explanation document

2016-08-09 Thread Alistair Francis
On Tue, Aug 9, 2016 at 11:19 AM, Peter Maydell wrote: > On 3 August 2016 at 21:06, Alistair Francis > wrote: >> Signed-off-by: Alistair Francis >> --- >> V10: >> - Split the data loading and PC setting >> V9: >> - Clarify the image loading options >> V8: >> - Improve documentation >> V6: >>

Re: [Qemu-devel] [PATCH v8] qemu-img: add the 'dd' subcommand

2016-08-09 Thread Max Reitz
On 09.08.2016 23:20, Reda Sallahi wrote: > This patch adds a basic dd subcommand analogous to dd(1) to qemu-img. > > For the start, this implements the bs, if, of and count options and requires > both if and of to be specified (no stdin/stdout if not specified) and doesn't > support tty, pipes, et

Re: [Qemu-devel] [PATCH v10 7/8] generic-loader: Add a generic loader

2016-08-09 Thread Alistair Francis
On Tue, Aug 9, 2016 at 11:17 AM, Peter Maydell wrote: > On 3 August 2016 at 21:06, Alistair Francis > wrote: >> Add a generic loader to QEMU which can be used to load images or set >> memory values. >> >> Signed-off-by: Alistair Francis >> --- >> V10: >> - Split out the PC setting and data loa

Re: [Qemu-devel] [PATCH] optionrom: fix compilation with mingw docker target

2016-08-09 Thread Paolo Bonzini
- Original Message - > From: "Peter Maydell" > To: "Paolo Bonzini" > Cc: "QEMU Developers" , "Richard W.M. Jones" > > Sent: Tuesday, August 9, 2016 11:47:17 PM > Subject: Re: [Qemu-devel] [PATCH] optionrom: fix compilation with mingw > docker target > > On 9 August 2016 at 21:56, Pa

Re: [Qemu-devel] [PATCH] optionrom: fix compilation with mingw docker target

2016-08-09 Thread Peter Maydell
On 9 August 2016 at 21:56, Paolo Bonzini wrote: > Two fixes are needed. First, mingw does not have -D_FORTIFY_SOURCE, > hence --enable-debug disables optimization. This is not acceptable > for ROMs, which should override CFLAGS to force inclusion of -O2. > > Second, PE stores global constructors

Re: [Qemu-devel] [PATCH v3 8/9] vl: Switch qemu_uuid to QemuUUID

2016-08-09 Thread Jeff Cody
On Tue, Aug 09, 2016 at 02:50:06PM +0800, Fam Zheng wrote: > Update all qemu_uuid users as well, especially get rid of the duplicated > low level g_strdup_printf, sscanf and snprintf calls with QEMU UUID API. > > Since qemu_uuid_parse is quite tangled with qemu_uuid, it's switching to > QemuUUID i

Re: [Qemu-devel] [PATCH v3 1/9] util: Add UUID API

2016-08-09 Thread Jeff Cody
On Tue, Aug 09, 2016 at 02:49:59PM +0800, Fam Zheng wrote: > A number of different places across the code base use CONFIG_UUID. Some > of them are soft dependency, some are not built if libuuid is not > available, some come with dummy fallback, some throws runtime error. > > It is hard to maintain

[Qemu-devel] [PATCH v8] qemu-img: add the 'dd' subcommand

2016-08-09 Thread Reda Sallahi
This patch adds a basic dd subcommand analogous to dd(1) to qemu-img. For the start, this implements the bs, if, of and count options and requires both if and of to be specified (no stdin/stdout if not specified) and doesn't support tty, pipes, etc. The image format must be specified with -O for

Re: [Qemu-devel] [PATCH 2/5] softfloat: Fix warn about implicit conversion from int to int8_t

2016-08-09 Thread Peter Maydell
On 9 August 2016 at 20:16, Aurelien Jarno wrote: > On 2016-08-09 15:02, Pranith Kumar wrote: >> Change the flag type to 'int' to fix the implicit conversion error. >> >> Suggested-by: Peter Maydell >> Signed-off-by: Pranith Kumar >> --- >> fpu/softfloat-specialize.h | 2 +- >> include/fpu/softf

Re: [Qemu-devel] [PATCH v2] ACPI: Add -acpifadt to allow FADT revision changes

2016-08-09 Thread Zheng, Lv
Hi, > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Subject: Re: [PATCH v2] ACPI: Add -acpifadt to allow FADT revision changes > > > > On 08/08/2016 10:16, Lv Zheng wrote: > > This patch allows FADT to be built with different revisions. When the > revision

[Qemu-devel] [PATCH] optionrom: fix compilation with mingw docker target

2016-08-09 Thread Paolo Bonzini
Two fixes are needed. First, mingw does not have -D_FORTIFY_SOURCE, hence --enable-debug disables optimization. This is not acceptable for ROMs, which should override CFLAGS to force inclusion of -O2. Second, PE stores global constructors and destructors using the following linker script snippet

Re: [Qemu-devel] [PATCH v6] qemu-img: add the 'dd' subcommand

2016-08-09 Thread Max Reitz
On 09.08.2016 20:39, Reda Sallahi wrote: > Hi Max, > Thanks for the review! > > On 8/8/16, Max Reitz wrote: >> On 25.07.2016 07:58, Reda Sallahi wrote: >>> +if (in->bsz == 0) { >>> +error_report("invalid number: '%s'", arg); >> >> It's not an invalid number, it's just an invalid block

[Qemu-devel] [V15 2/4] hw/i386/trace-events: Add AMD IOMMU trace events

2016-08-09 Thread David Kiarie
Signed-off-by: David Kiarie --- hw/i386/trace-events | 29 + 1 file changed, 29 insertions(+) diff --git a/hw/i386/trace-events b/hw/i386/trace-events index b4882c1..592de3a 100644 --- a/hw/i386/trace-events +++ b/hw/i386/trace-events @@ -13,3 +13,32 @@ mhp_pc_dimm_as

[Qemu-devel] [V15 3/4] hw/i386: Introduce AMD IOMMU

2016-08-09 Thread David Kiarie
Add AMD IOMMU emulaton to Qemu in addition to Intel IOMMU. The IOMMU does basic translation, error checking and has a minimal IOTLB implementation. This IOMMU bypassed the need for target aborts by responding with IOMMU_NONE access rights and exempts the region 0xfee0-0xfeef from translatio

[Qemu-devel] [V15 1/4] hw/pci: Prepare for AMD IOMMU

2016-08-09 Thread David Kiarie
Introduce PCI macros from for use by AMD IOMMU Signed-off-by: David Kiarie --- include/hw/pci/pci.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index 929ec2f..5ff92de 100644 --- a/include/hw/pci/pci.h +++ b/include/hw/pci/pci

[Qemu-devel] [V15 0/4] AMD IOMMU

2016-08-09 Thread David Kiarie
Hi all, This patchset adds basic AMD IOMMU emulation support to Qemu. Change since v14 -MMIO register reading/write bug fix [Peter] -Endian-ness issue fix[Peter] -Bitfields layouts in IOMMU commands fix[Peter] -IVRS changed IVHD device entry from type 3 to 1 to save a few bytes -c

Re: [Qemu-devel] [PATCH] checkpatch: ignore automatically imported Linux headers

2016-08-09 Thread Paolo Bonzini
On 09/08/2016 19:38, Radim Krčmář wrote: > Linux uses tabs for indentation and checkpatch always complained about > automatically imported headers. update-linux-headers.sh could be modified to > expand tabs, but there is no real reason to complain about any ugly code in > Linux headers, so skip

Re: [Qemu-devel] [PATCH 1/5] atomic: strip "const" from variables declared with typeof

2016-08-09 Thread Paolo Bonzini
On 09/08/2016 21:02, Pranith Kumar wrote: > From: Paolo Bonzini > > With the latest clang, we have the following warning: > > /home/pranith/devops/code/qemu/include/qemu/seqlock.h:62:21: warning: > passing 'typeof (*&sl->sequence) *' (aka 'const unsigned int *') to parameter > of type 'u

Re: [Qemu-devel] [PATCH 00/56] Patch Round-up for stable 2.6.1, freeze on 2016-08-12

2016-08-09 Thread Bruce Rogers
Michael, Please add 0968c91 Xen PCI passthrough: fix passthrough failure when no interrupt pin to the list for 2.6.1. Thanks! Bruce Rogers >>> Michael Roth 8/8/2016 3:03 PM >>> Hi everyone, The following new patches are queued for QEMU stable v2.6.1: https://github.com/mdroth/qemu/

Re: [Qemu-devel] [Qemu-stable] [PATCH 00/56] Patch Round-up for stable 2.6.1, freeze on 2016-08-12

2016-08-09 Thread Michael Roth
Quoting Michael Roth (2016-08-08 16:03:31) > Hi everyone, > > The following new patches are queued for QEMU stable v2.6.1: > > https://github.com/mdroth/qemu/commits/stable-2.6-staging > > The release is planned for 2016-08-17: > > http://wiki.qemu.org/Planning/2.6 > > Please respond here

Re: [Qemu-devel] [PATCH v3 1/9] util: Add UUID API

2016-08-09 Thread Jeff Cody
On Tue, Aug 09, 2016 at 02:49:59PM +0800, Fam Zheng wrote: > A number of different places across the code base use CONFIG_UUID. Some > of them are soft dependency, some are not built if libuuid is not > available, some come with dummy fallback, some throws runtime error. > > It is hard to maintain

Re: [Qemu-devel] [PATCH v3 12/15] monitor: use qmp_dispatch()

2016-08-09 Thread Marc-André Lureau
Hi On Tue, Aug 9, 2016 at 9:35 PM Markus Armbruster wrote: > Marc-André Lureau writes: > > > Hi > > > > - Original Message - > >> Marc-André Lureau writes: > >> > >> > Hi > >> > > >> > - Original Message - > >> >> marcandre.lur...@redhat.com writes: > >> >> > >> >> > From: Marc

[Qemu-devel] Using memory mapped IO to read and write in guest memory data

2016-08-09 Thread lkn2993
Hi all. I have been searching thoroughly for the latest requirement I need to fulfill using QEMU. The scenario is like this: • I have another simulator which is a C program, this program has a shared memory which can be exposed to a file when need be, it can also write to an address or read fro

Re: [Qemu-devel] [PATCH 2/5] softfloat: Fix warn about implicit conversion from int to int8_t

2016-08-09 Thread Aurelien Jarno
On 2016-08-09 15:02, Pranith Kumar wrote: > Change the flag type to 'int' to fix the implicit conversion error. > > Suggested-by: Peter Maydell > Signed-off-by: Pranith Kumar > --- > fpu/softfloat-specialize.h | 2 +- > include/fpu/softfloat.h| 4 ++-- > 2 files changed, 3 insertions(+), 3 d

Re: [Qemu-devel] [PATCH] add migration capability to bypass the shared memory

2016-08-09 Thread Dr. David Alan Gilbert
* Lai Jiangshan (jiangshan...@gmail.com) wrote: > When the migration capability 'bypass-shared-memory' > is set, the shared memory will be bypassed when migration. > > It is the key feature to enable several excellent features for > the qemu, such as qemu-local-migration, qemu-live-update, > extre

[Qemu-devel] [PATCH 5/5] target-arm: Fix warn about implicit conversion

2016-08-09 Thread Pranith Kumar
Clang warns about an implicit conversion as follows: /mnt/devops/code/qemu/target-arm/neon_helper.c:1075:1: warning: implicit conversion from 'int' to 'int8_t' (aka 'signed char') changes value from 128 to -128 [-Wconstant-conversion] NEON_VOP_ENV(qrshl_s8, neon_s8, 4) ^~

Re: [Qemu-devel] [RFC for 2.8 2/3] configure: filter 64 bit machines on 32 bit builds

2016-08-09 Thread Peter Maydell
On 9 August 2016 at 20:08, Alex Bennée wrote: > Squash or move to the position before? There's not much code here and in any case it assumes the existence of variables only set in the previous patch, so I'd just squash. PS: >>> +if test "$cpu_width" = "32"; then >>> +case $target in

Re: [Qemu-devel] [RFC for 2.8 2/3] configure: filter 64 bit machines on 32 bit builds

2016-08-09 Thread Alex Bennée
Squash or move to the position before? On 9 August 2016 at 17:15, Peter Maydell wrote: > On 9 August 2016 at 16:55, Alex Bennée wrote: >> If the user doesn't specify any targets we build a default_target_list >> from the target .mak fragements. If we don't filter out the 64 bit >> targets when b

[Qemu-devel] [PATCH 1/5] atomic: strip "const" from variables declared with typeof

2016-08-09 Thread Pranith Kumar
From: Paolo Bonzini With the latest clang, we have the following warning: /home/pranith/devops/code/qemu/include/qemu/seqlock.h:62:21: warning: passing 'typeof (*&sl->sequence) *' (aka 'const unsigned int *') to parameter of type 'unsigned int *' discards qualifiers [-Wincompatible-pointe

[Qemu-devel] [PATCH 4/5] clang: Fix warning reg. expansion to 'defined'

2016-08-09 Thread Pranith Kumar
Clang produces the following warning. The warning is detailed here: https://reviews.llvm.org/D15866. Fix the warning. /home/pranith/devops/code/qemu/hw/display/qxl.c:507:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined] ^ /home/pranith/devops/code

[Qemu-devel] [PATCH 3/5] Disable warn about left shifts of negative values

2016-08-09 Thread Pranith Kumar
It seems like there's no good reason for the compiler to exploit the undefinedness of left shifts. GCC explicitly documents that they do not use at all this possibility and, while they also say this is subject to change, they have been saying this for 10 years (since the wording appeared in the GC

[Qemu-devel] [PATCH 2/5] softfloat: Fix warn about implicit conversion from int to int8_t

2016-08-09 Thread Pranith Kumar
Change the flag type to 'int' to fix the implicit conversion error. Suggested-by: Peter Maydell Signed-off-by: Pranith Kumar --- fpu/softfloat-specialize.h | 2 +- include/fpu/softfloat.h| 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fpu/softfloat-specialize.h b/fp

Re: [Qemu-devel] [PATCH v6 2/4] vfio: VFIO driver for mediated PCI device

2016-08-09 Thread Alex Williamson
On Thu, 4 Aug 2016 00:33:52 +0530 Kirti Wankhede wrote: > MPCI VFIO driver registers with MDEV core driver. MDEV core driver creates > mediated device and calls probe routine of MPCI VFIO driver. This driver > adds mediated device to VFIO core module. > Main aim of this module is to manage all VF

Re: [Qemu-devel] [PATCH v6 3/4] vfio iommu: Add support for mediated devices

2016-08-09 Thread Alex Williamson
On Thu, 4 Aug 2016 00:33:53 +0530 Kirti Wankhede wrote: > VFIO IOMMU drivers are designed for the devices which are IOMMU capable. > Mediated device only uses IOMMU APIs, the underlying hardware can be > managed by an IOMMU domain. > > Aim of this change is: > - To use most of the code of TYPE1

Re: [Qemu-devel] [PATCH v6 1/4] vfio: Mediated device Core driver

2016-08-09 Thread Alex Williamson
On Thu, 4 Aug 2016 00:33:51 +0530 Kirti Wankhede wrote: > Design for Mediated Device Driver: > Main purpose of this driver is to provide a common interface for mediated > device management that can be used by different drivers of different > devices. > > This module provides a generic interface

Re: [Qemu-devel] [PATCH v7] qemu-img: add the 'dd' subcommand

2016-08-09 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 20160809183904.25692-1-fullma...@gmail.com Type: series Subject: [Qemu-devel] [PATCH v7] qemu-img: add the 'dd' su

Re: [Qemu-devel] [RFC 2/2] hw/i386: enforce SID verification

2016-08-09 Thread David Kiarie
On Tue, Aug 9, 2016 at 9:41 PM, Valentine Sinitsyn < valentine.sinit...@gmail.com> wrote: > > > On 09.08.2016 19:32, David Kiarie wrote: > >> Platform device are now able to make interrupt request with >> explicit SIDs hence we can safely expect triggered AddressSpace ID >> to match the requesting

Re: [Qemu-devel] [PATCH v10 3/8] loader: Allow a custom AddressSpace when loading ROMs

2016-08-09 Thread Peter Maydell
On 3 August 2016 at 21:06, Alistair Francis wrote: > When loading ROMs allow the caller to specify an AddressSpace to use for > the load. > > Signed-off-by: Alistair Francis > --- > V10: > - Set the rom address space instead of leaving it NULL > - Cleanup ordering logic > V9: > - Fixup the ROM

[Qemu-devel] [PATCH v7] qemu-img: add the 'dd' subcommand

2016-08-09 Thread Reda Sallahi
This patch adds a basic dd subcommand analogous to dd(1) to qemu-img. For the start, this implements the bs, if, of and count options and requires both if and of to be specified (no stdin/stdout if not specified) and doesn't support tty, pipes, etc. The image format must be specified with -O for

Re: [Qemu-devel] [RFC 2/2] hw/i386: enforce SID verification

2016-08-09 Thread Valentine Sinitsyn
On 09.08.2016 19:32, David Kiarie wrote: Platform device are now able to make interrupt request with explicit SIDs hence we can safely expect triggered AddressSpace ID to match the requesting ID Signed-off-by: David Kiarie --- hw/i386/intel_iommu.c | 82 +++---

Re: [Qemu-devel] [PATCH v6] qemu-img: add the 'dd' subcommand

2016-08-09 Thread Reda Sallahi
Hi Max, Thanks for the review! On 8/8/16, Max Reitz wrote: > On 25.07.2016 07:58, Reda Sallahi wrote: >> +if (in->bsz == 0) { >> +error_report("invalid number: '%s'", arg); > > It's not an invalid number, it's just an invalid block size. In my > understanding, those are two different

Re: [Qemu-devel] [PATCH 56/56] ide: fix halted IO segfault at reset

2016-08-09 Thread John Snow
Definitely add this one: 7f951b2d7765f68ae1e563c2fed44071ca774790 atapi: fix halted DMA reset And maybe these: 16275edb342342625cd7e7ac2048436474465b50 macio: set res_count value to 0 after non-block ATAPI DMA transfers 5839df7b71540a2af2580bb53ad1e2005bb175e6 ahci: fix sglist leak on retry 9

Re: [Qemu-devel] [PATCH v10 8/8] docs: Add a generic loader explanation document

2016-08-09 Thread Peter Maydell
On 3 August 2016 at 21:06, Alistair Francis wrote: > Signed-off-by: Alistair Francis > --- > V10: > - Split the data loading and PC setting > V9: > - Clarify the image loading options > V8: > - Improve documentation > V6: > - Fixup documentation > V4: > - Re-write to be more comprehensive >

Re: [Qemu-devel] [PATCH v2 1/5] target-ppc: add vector insert instructions

2016-08-09 Thread Richard Henderson
On 08/09/2016 03:42 PM, Rajalakshmi Srinivasaraghavan wrote: +for (i = 0; i < ARRAY_SIZE(r->element); i++) { \ +result.element[i] = r->element[i]; \ +} \

Re: [Qemu-devel] Dangling change state handler while hot unplugging ahci adapter

2016-08-09 Thread John Snow
On 08/09/2016 01:16 PM, Ashijeet Acharya wrote: Hi again, I am still waiting for some guidance...Can I please get some help with this? Also.. I tried hotplugging an AHCI adapter but got the following error: Bus 'ahci.0' does not support hotplugging Steps I followed: 1. launch vm with ahci en

Re: [Qemu-devel] [PATCH v10 7/8] generic-loader: Add a generic loader

2016-08-09 Thread Peter Maydell
On 3 August 2016 at 21:06, Alistair Francis wrote: > Add a generic loader to QEMU which can be used to load images or set > memory values. > > Signed-off-by: Alistair Francis > --- > V10: > - Split out the PC setting and data loading > V9: > - Fix error messages > - Updated some incorrect logi

Re: [Qemu-devel] [PATCH] checkpatch: ignore automatically imported Linux headers

2016-08-09 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Message-id: 20160809173841.716-1-rkrc...@redhat.com Type: series Subject: [Qemu-devel] [PATCH] checkpatch: ignore automatically imported Linux headers === TEST SCRIPT BEGIN === #!/bin/bash BASE=bas

Re: [Qemu-devel] [RFC for 2.8 1/3] configure: check CPU width and disable larger guests

2016-08-09 Thread Richard Henderson
On 08/09/2016 09:25 PM, Alex Bennée wrote: - ia64|ppc|ppc64|s390|s390x|sparc64|x32) + ppc|s390|x32) cpu="$cpu" +cpu_width=32 + ;; + ia64|ppc64|s390x|sparc64) +cpu="$cpu" +cpu_width=64 ;; i386|i486|i586|i686|i86pc|BePC) cpu="i386" +cpu_width=32 ;; x86_64|a

Re: [Qemu-devel] [PATCH v10 5/8] loader: Add AddressSpace loading support to uImages

2016-08-09 Thread Peter Maydell
On 3 August 2016 at 21:06, Alistair Francis wrote: > Add a new function load_uimage_as() that allows the caller to > specify an AddressSpace to use when loading the uImage. The > original load_uimage() function doesn't have any change in > functionality. > > Signed-off-by: Alistair Francis > ---

[Qemu-devel] [PATCH] checkpatch: ignore automatically imported Linux headers

2016-08-09 Thread Radim Krčmář
Linux uses tabs for indentation and checkpatch always complained about automatically imported headers. update-linux-headers.sh could be modified to expand tabs, but there is no real reason to complain about any ugly code in Linux headers, so skip all hunk-related checks. Signed-off-by: Radim Krčm

Re: [Qemu-devel] [PATCH v10 6/8] loader: Add AddressSpace loading support to targphys

2016-08-09 Thread Peter Maydell
On 3 August 2016 at 21:06, Alistair Francis wrote: > Add a new function load_image_targphys_as() that allows the caller > to specify an AddressSpace to use when loading a targphys. The > original load_image_targphys() function doesn't have any change in > functionality. > > Signed-off-by: Alistair

Re: [Qemu-devel] Dangling change state handler while hot unplugging ahci adapter

2016-08-09 Thread Ashijeet Acharya
Hi again, I am still waiting for some guidance...Can I please get some help with this? Also.. I tried hotplugging an AHCI adapter but got the following error: Bus 'ahci.0' does not support hotplugging Steps I followed: 1. launch vm with ahci enabled 2. (qemu) drive_add 0 file=test.qcow2,cache=no

  1   2   3   4   >