Re: [Qemu-devel] [PATCH for-2.8 16/18] pc: add 'etc/boot-cpus' fw_cfg file for machine with more than 255 CPUs

2016-08-06 Thread Michael S. Tsirkin
On Fri, Aug 05, 2016 at 11:46:15AM +0200, Igor Mammedov wrote: > Currently firmware uses 1 byte at 0x5F offset in RTC CMOS > to get number of CPUs present at boot. However 1 byte is > not enough to handle more than 255 CPUs. So add a new > fw_cfg file that would allow QEMU to tell it. > For compat

Re: [Qemu-devel] [PATCH] debugcon: Add -debugport option to allow changing debug console port number

2016-08-06 Thread Michael S. Tsirkin
On Fri, Aug 05, 2016 at 06:19:39PM +0800, Lv Zheng wrote: > Changing debugcon port to 0x402 allows the seabios AML table pre-defined > DBUG() control method to be able to dump the AML debugging information to > the re-directed debugging console. > > If the debug port number is configurable, users

[Qemu-devel] [PATCH RFC] hw/misc/macio/cuda.c: erratic mouse fix

2016-08-06 Thread Programmingkid
For everyone who is having a problem with the mouse pointer acting erratically, this patch should offer some relief. By decreasing the polling rate of the ADB mouse, the mouse pointer becomes more manageable. I was always able to reproduce the erratic mouse issue by playing an mp3 in QuickTime P

[Qemu-devel] [PATCH 1/1] seqlock: Fix warning reg. incompatible cast

2016-08-06 Thread Pranith Kumar
With the latest clang, we have the following warning. We are not using the const qualifier consistently in other functions. So remove it from the only one that uses it to fix the warning. /home/pranith/devops/code/qemu/include/qemu/seqlock.h:62:21: warning: passing 'typeof (*&sl->sequence) *' (ak

[Qemu-devel] [PATCH] spice: Fix warning reg. 'defined' in macro

2016-08-06 Thread Pranith Kumar
Clang produces the following warning. The warning is detailed here: https://reviews.llvm.org/D15866 /home/pranith/devops/code/qemu/hw/display/qxl.c:507:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined] #if SPICE_NEEDS_SET_MM_TIME ^ /home/pranith/d

[Qemu-devel] [PATCH] target-mips: Fix warning about shifting negative value

2016-08-06 Thread Pranith Kumar
With latest clang you get the following warning: warning: shifting a negative signed value is undefined [-Wshift-negative-value] Fix the warning by changing negative shift to inverse 0 shift. Signed-off-by: Pranith Kumar --- target-mips/translate.c | 10 +- 1 file changed, 5 insertions

Re: [Qemu-devel] [PATCH] ppc: Stop dumping state on all exceptions in linux-user

2016-08-06 Thread Benjamin Herrenschmidt
On Sat, 2016-08-06 at 15:23 +0530, Richard Henderson wrote: > On 08/03/2016 05:09 PM, Benjamin Herrenschmidt wrote: > > > > As far user-with-softmmu, I'm not too sure... softmmu significantly > > increases the overhead of load and stores. Maybe after we add 128-bit > > integers to TGC to alleviate

Re: [Qemu-devel] [PATCH 5/5] ppc: Improve generation of conditional traps

2016-08-06 Thread Benjamin Herrenschmidt
On Sat, 2016-08-06 at 14:33 +0530, Richard Henderson wrote: > On 07/31/2016 10:43 AM, Benjamin Herrenschmidt wrote: > > > > Translate most conditions to TCG conditions and avoid the helper > > for most of the common cases. > > > > > > Signed-off-by: Benjamin Herrenschmidt > > --- > >  target-ppc

Re: [Qemu-devel] [PULL 1/1] Add optionrom compatible with fw_cfg DMA version

2016-08-06 Thread Brad Smith
On 07/14/16 09:52, Paolo Bonzini wrote: diff --git a/pc-bios/optionrom/Makefile b/pc-bios/optionrom/Makefile index 2cdda87..d88ce11 100644 --- a/pc-bios/optionrom/Makefile +++ b/pc-bios/optionrom/Makefile @@ -9,22 +9,46 @@ $(call set-vpath, $(SRC_PATH)/pc-bios/optionrom) .PHONY : all clean buil

Re: [Qemu-devel] R: [PATCH v2] Unbreak FreeBSD build after optionrom update.

2016-08-06 Thread Brad Smith
On 08/01/16 06:47, Paolo Bonzini wrote: On 26/07/2016 23:07, Sean Bruno wrote: Thanks for the pointer to the right fix. Confirmed that your changes DTRT for FreeBSD. I still need the LD_EMULATION addition, which I have sent to the list as a separate patch for review. Great, thanks! Paolo

[Qemu-devel] [PATCH] iotest 055: refactor and speed up

2016-08-06 Thread Vladimir Sementsov-Ogievskiy
Source disk is created and filled with test data before each test case. Instead initialize it once for the whole unit. performance: qcow2: 25s -> 15s raw: 16s -> 11s Actually, changed only TestSetSpeed: before this patch it used different image_len and data pattern. Alse TestSetSpeed used diffe

[Qemu-devel] Dangling change state handler while hot unplugging ahci adapter

2016-08-06 Thread Ashijeet Acharya
Hi, I was working on a patch regarding a device lifecycle bitesize task and I wanted to clear my queries about what the task is exactly. Do I need to create a new function ahci_unrealize() in the hw/ide/ahci.c file which calls for qemu_del_vm_change_state_handler() to free the handler at the time

Re: [Qemu-devel] [PATCH] block/iscsi: Adding iser support in Libiscsi-QEMU

2016-08-06 Thread Roy Shterman
Hi, I checked my patch and found only warnings about long lines (over 80 characters), Splitting those lines will make the code much less verbose in my opinion. If you still think I should split those lines I will do it gladly. Other than that I couldn't find any coding style issue in my patch.

Re: [Qemu-devel] [Question] virtio-serial misses irq delivery on migration?

2016-08-06 Thread Gonglei (Arei)
Hi all, I might catch the bug. Now, we rely on a vm_clock timer to assure that the vcpus are started before we invoke send_control_event(),which queue a message in the virtio ring and trigger a irq. In actually, we can't attach our initial intention under a special situation: 1. the process of

Re: [Qemu-devel] [RFC PATCH v1 2/2] utils: Add prefetch for Thunderx platform

2016-08-06 Thread Richard Henderson
On 08/02/2016 03:50 PM, vijay.kil...@gmail.com wrote: +#define VEC_PREFETCH(base, index) \ +asm volatile ("prfm pldl1strm, [%x[a]]\n" : : [a]"r"(&base[(index)])) Is this not __builtin_prefetch(base + index) ? I.e. you can defined this generically for all targets. +#if defined (__aarc

[Qemu-devel] [PATCH v3 2/2] usb-mtp: added object properties

2016-08-06 Thread Isaac Lozano
Windows uses object properties to determine the size of a file, so to add object properties, we must also add a minimum set of new commands and object properties. Most object properties are data that we already have, except for the unique persistant object identifier. Windows doesn't use this prope

[Qemu-devel] [PATCH v3 0/2] usb-mtp: Added support for sending files larger than 4gb

2016-08-06 Thread Isaac Lozano
Added support for sending files larger than 4gb from the host to the guest. The first patch adds support on Linux guests. The second patch is to add support on Windows guests. Windows requires object properties to read the file size from. We have to implement a minimum set of commands and object p

Re: [Qemu-devel] [PATCH] ppc: Stop dumping state on all exceptions in linux-user

2016-08-06 Thread Richard Henderson
On 08/03/2016 05:09 PM, Benjamin Herrenschmidt wrote: As far user-with-softmmu, I'm not too sure... softmmu significantly increases the overhead of load and stores. Maybe after we add 128-bit integers to TGC to alleviate that a bit ? :-) It wouldn't be mandatory, but there are certain bugs we c

Re: [Qemu-devel] [PATCH] tcg: Merge GETPC and GETRA

2016-08-06 Thread Richard Henderson
On 08/03/2016 01:12 PM, Benjamin Herrenschmidt wrote: I'm not sure if there are other cases with softmmu for example, where we do get an exact host PC and thus where the -2 might take us back too far. I don't think there are. Almost everywhere we have the call return address. It's only this c

Re: [Qemu-devel] [PATCH 1/5] ppc: Don't generate dead code on unconditional branches

2016-08-06 Thread Richard Henderson
On 07/31/2016 10:43 AM, Benjamin Herrenschmidt wrote: We are always generating the "else" case of the condition even when generating an unconditional branch that will never hit it. Signed-off-by: Benjamin Herrenschmidt --- target-ppc/translate.c | 14 +- 1 file changed, 9 insertion

Re: [Qemu-devel] [PATCH 5/5] ppc: Improve generation of conditional traps

2016-08-06 Thread Richard Henderson
On 07/31/2016 10:43 AM, Benjamin Herrenschmidt wrote: Translate most conditions to TCG conditions and avoid the helper for most of the common cases. Signed-off-by: Benjamin Herrenschmidt --- target-ppc/translate.c | 168 ++--- 1 file changed, 132 ins

Re: [Qemu-devel] [PATCH 4/5] ppc: Improve a few more helper flags

2016-08-06 Thread Richard Henderson
On 07/31/2016 10:43 AM, Benjamin Herrenschmidt wrote: Mostly turn "store" type of helpers into TCG_CALL_NO_WG because they can take exceptions. Also fixup_thrm doesn't read nor write the tracked environment. Signed-off-by: Benjamin Herrenschmidt --- target-ppc/helper.h | 14 +++--- 1 f

Re: [Qemu-devel] [PATCH 3/5] ppc: Improve the exception helpers flags

2016-08-06 Thread Richard Henderson
On 07/31/2016 10:43 AM, Benjamin Herrenschmidt wrote: They generate exceptions, but they don't update the environment Signed-off-by: Benjamin Herrenschmidt --- target-ppc/helper.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 2/5] ppc: Improve flags for helpers loading/writing the time facilities

2016-08-06 Thread Richard Henderson
On 07/31/2016 10:43 AM, Benjamin Herrenschmidt wrote: Those helpers never load from or store to the TCG tracked environment, not do they generate synchronous exceptions (they might generate an s/not/nor/ asynchronous interrupt but that's not an issue here). So we can make them all use TCG_CA