Re: [Qemu-devel] [PATCH v5 12/18] qht: QEMU's fast, resizable and scalable Hash Table

2016-05-20 Thread Emilio G. Cota
Hi Sergey, Any 'Ack' below means the change has made it to my tree. On Sat, May 21, 2016 at 01:13:20 +0300, Sergey Fedorov wrote: > > +#include "qemu/osdep.h" > > +#include "qemu-common.h" > > There's no need in qemu-common.h Ack > > +#include "qemu/seqlock.h" > > +#include "qemu/qdist.h" > >

[Qemu-devel] [PATCH 8/9] virtio-blk: dataplane multiqueue support

2016-05-20 Thread Stefan Hajnoczi
Monitor ioeventfds for all virtqueues in the device's AioContext. This is not true multiqueue because requests from all virtqueues are processed in a single IOThread. In the future it will be possible to use multiple IOThreads when the QEMU block layer supports multiqueue. Signed-off-by: Stefan

[Qemu-devel] [PATCH 1/9] virtio-blk: use batch notify in non-dataplane case

2016-05-20 Thread Stefan Hajnoczi
Commit 5b2ffbe4d99843fd8305c573a100047a8c962327 ("virtio-blk: dataplane: notify guest as a batch") deferred guest notification to a BH in order batch notifications. This optimization is not specific to dataplane so move it to the generic virtio-blk code that is shared by both dataplane and non-dat

[Qemu-devel] [PATCH 9/9] virtio-blk: add num-queues device property

2016-05-20 Thread Stefan Hajnoczi
Multiqueue virtio-blk can be enabled as follows: qemu -device virtio-blk-pci,num-queues=8 Signed-off-by: Stefan Hajnoczi --- hw/block/virtio-blk.c | 15 +-- include/hw/virtio/virtio-blk.h | 1 - 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/hw/block/vir

[Qemu-devel] [PATCH 0/9] virtio-blk: multiqueue support

2016-05-20 Thread Stefan Hajnoczi
The virtio_blk guest driver has supported multiple virtqueues since Linux 3.17. This patch series adds multiple virtqueues to QEMU's virtio-blk emulated device. Ming Lei sent patches previously but these were not merged. This series implements virtio-blk multiqueue for QEMU from scratch since the

[Qemu-devel] [PATCH 6/9] vmstate: add VMSTATE_VARRAY_UINT32_ALLOC

2016-05-20 Thread Stefan Hajnoczi
A variable-sized array that is allocated upon load(). The size variable is a uint32_t. Signed-off-by: Stefan Hajnoczi --- include/migration/vmstate.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 84ee355..1622638

Re: [Qemu-devel] [PATCH v4 0/5] ADB improvements

2016-05-20 Thread Peter Maydell
On 21 May 2016 at 00:11, Programmingkid wrote: > On May 20, 2016, at 6:48 PM, Peter Maydell wrote: > >> On 20 May 2016 at 23:38, Programmingkid wrote: > Thank you for looking at the patches so quickly. Have > you seen my patches for the USB keyboard yet? > > 1/3 > https://patchwork.ozlabs.org/pat

[Qemu-devel] [PATCH 3/9] virtio-blk: associate request with a virtqueue

2016-05-20 Thread Stefan Hajnoczi
Multiqueue requires that each request knows to which virtqueue it belongs. Signed-off-by: Stefan Hajnoczi --- hw/block/virtio-blk.c | 16 +--- include/hw/virtio/virtio-blk.h | 4 +++- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/hw/block/virtio-blk.c b/hw

[Qemu-devel] [PATCH 5/9] virtio-blk: multiqueue batch notify

2016-05-20 Thread Stefan Hajnoczi
The batch notification BH needs to know which virtqueues to notify when multiqueue is enabled. Use a bitmap to track the virtqueues that with pending notifications. Signed-off-by: Stefan Hajnoczi --- hw/block/virtio-blk.c | 20 include/hw/virtio/virtio-blk.h | 1 +

[Qemu-devel] [PATCH 2/9] virtio-blk: tell dataplane which vq to notify

2016-05-20 Thread Stefan Hajnoczi
Let the virtio_blk_data_plane_notify() caller decide which virtqueue to notify. This will allow the function to be used with multiqueue. Signed-off-by: Stefan Hajnoczi --- hw/block/dataplane/virtio-blk.c | 8 +++- hw/block/dataplane/virtio-blk.h | 2 +- hw/block/virtio-blk.c | 2 +

Re: [Qemu-devel] undefined symbol _nettle_cast5_set_key

2016-05-20 Thread Eric Blake
On 05/20/2016 04:46 PM, Programmingkid wrote: >>> Undefined symbols for architecture x86_64: >>> "_nettle_cast5_set_key", referenced from: >>> _qcrypto_cipher_new in cipher.o >> >> What version of nettle are you compiling against? Obviously it's an >> older version, but is it one that we need

[Qemu-devel] [PULL 05/21] vl: Add DT_COCOA DisplayType value

2016-05-20 Thread Eduardo Habkost
Instead of reusing DT_SDL for Cocoa, use DT_COCOA to indicate that a Cocoa display was requested. configure already ensures CONFIG_COCOA and CONFIG_SDL are never set at the same time. The only case where DT_SDL is used outside a #ifdef CONFIG_SDL block is in the no_frame/alt_grab/ctrl_grab check.

Re: [Qemu-devel] [PATCH v4 0/5] ADB improvements

2016-05-20 Thread Peter Maydell
On 20 May 2016 at 23:38, Programmingkid wrote: > This patch series makes several improvements to the ADB code. To test this > code, > please implement the patches in the order below. > > John Arbuckle (5): > adb-keys.h: initial commit > adb.c: add support for QKeyCode > adb.c: correct sever

[Qemu-devel] [PATCH 7/9] virtio-blk: live migrate s->rq with multiqueue

2016-05-20 Thread Stefan Hajnoczi
Each request in s->rq belongs to a virtqueue. When multiqueue is enabled we can no longer default to the first virtqueue. Explicitly migrate virtqueue indices when needed. The migration stream looks like this: [s->rq][mq_rq_indices, ~QEMU_VM_SUBSECTION][virtio subsections] This patch adds th

[Qemu-devel] [PULL 11/21] spice: Initialization stubs on qemu-spice.h

2016-05-20 Thread Eduardo Habkost
This reduces the number of CONFIG_SPICE #ifdefs in vl.c. Cc: Gerd Hoffmann Reviewed-by: Gerd Hoffmann Signed-off-by: Eduardo Habkost --- include/ui/qemu-spice.h | 13 + vl.c| 4 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/include/ui/qem

Re: [Qemu-devel] undefined symbol _nettle_cast5_set_key

2016-05-20 Thread Programmingkid
On May 20, 2016, at 6:50 PM, Eric Blake wrote: > On 05/20/2016 04:46 PM, Programmingkid wrote: Undefined symbols for architecture x86_64: "_nettle_cast5_set_key", referenced from: _qcrypto_cipher_new in cipher.o >>> >>> What version of nettle are you compiling against? Obvious

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2016-05-20 Thread Jools Wills
I get a hang doing this most times in an emulated ARM chroot with qemu- arm-static (Raspbian). Host machine is x86_64 Ubuntu 16.04 running qemu 2.5.0. git clone --depth 1 https://github.com/libretro/picodrive.git cd picodrive && git submodule update --init -- You received this bug notification

[Qemu-devel] [PATCH 4/9] virtio-blk: add VirtIOBlockConf->num_queues

2016-05-20 Thread Stefan Hajnoczi
The num_queues field is always 1 for the time being. A later patch will make it a configurable device property so that multiqueue can be enabled. Signed-off-by: Stefan Hajnoczi --- hw/block/virtio-blk.c | 1 + include/hw/virtio/virtio-blk.h | 1 + 2 files changed, 2 insertions(+) diff

[Qemu-devel] [PULL 10/21] gtk: Initialization stubs

2016-05-20 Thread Eduardo Habkost
This reduces the number of CONFIG_GTK #ifdefs in vl.c. Signed-off-by: Eduardo Habkost --- include/ui/console.h | 17 + vl.c | 7 +-- 2 files changed, 18 insertions(+), 6 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index 7ac997f..52a

Re: [Qemu-devel] [PATCH v4 1/5] adb-keys.h: initial commit

2016-05-20 Thread Eric Blake
On 05/20/2016 04:39 PM, Programmingkid wrote: > Add the adb-keys.h file. It maps ADB transition key codes with values. > > Signed-off-by: John Arbuckle > --- > *v4 changes: > Replaced ADB_KEY_LEFT_COMAND and ADB_KEY_RIGHT_COMAND with ADB_KEY_COMMAND. Your mails still aren't threading correctly.

Re: [Qemu-devel] undefined symbol _nettle_cast5_set_key

2016-05-20 Thread Eric Blake
On 05/20/2016 01:15 PM, Programmingkid wrote: > Noticed this bug after a 'git pull'. My repo is at commit > 65603e2fc18b48e6e55a3dd693669413141694ec - > tci: do not include exec/exec-all.h > > I am building QEMU on Mac OS 10.6 with GCC 4.9. > Here is the full message: > > LINK qemu-nbd > Unde

Re: [Qemu-devel] [PATCH v4 0/5] ADB improvements

2016-05-20 Thread Programmingkid
On May 20, 2016, at 6:48 PM, Peter Maydell wrote: > On 20 May 2016 at 23:38, Programmingkid wrote: >> This patch series makes several improvements to the ADB code. To test this >> code, >> please implement the patches in the order below. >> >> John Arbuckle (5): >> adb-keys.h: initial commit

[Qemu-devel] [PULL 00/21] Machine Core queue, 2016-05-20

2016-05-20 Thread Eduardo Habkost
The following changes since commit 65603e2fc18b48e6e55a3dd693669413141694ec: tci: do not include exec/exec-all.h (2016-05-20 15:07:46 +0100) are available in the git repository at: git://github.com/ehabkost/qemu.git tags/machine-pull-request for you to fetch changes up to e8f2d2722eb84a8096

[Qemu-devel] [PATCH v7 11/15] qapi: Change Netdev into a flat union

2016-05-20 Thread Eric Blake
From: Kővágó, Zoltán Except qapi-schema.json, this patch was generated by: find . -name .git -prune -o -type f \! -name '*~' -print0 | \ xargs -0 sed -i \ -e 's/NetClientOptionsKind/NetClientDriver/g' \ -e 's/NET_CLIENT_OPTIONS_KIND_/NET_CLIENT_DRIVER_/g' \ -e 's/netdev->opts/netde

[Qemu-devel] [PATCH v7 08/15] block: Simplify block_set_io_throttle

2016-05-20 Thread Eric Blake
Now that we can support boxed commands, use it to greatly reduce the number of parameters (and likelihood of getting out of sync) when adjusting throttle parameters. Signed-off-by: Eric Blake --- v7: new patch --- qapi/block-core.json | 20 -- blockdev.c | 111 +++

[Qemu-devel] [PULL 18/21] machine: add properties to compat_props incrementaly

2016-05-20 Thread Eduardo Habkost
From: Igor Mammedov Switch to adding compat properties incrementaly instead of completly overwriting compat_props per machine type. That removes data duplication which we have due to nested [PC|SPAPR]_COMPAT_* macros. It also allows to set default device properties from default foo_machine_optio

[Qemu-devel] [PATCH v7 09/15] block: Simplify drive-mirror

2016-05-20 Thread Eric Blake
Now that we can support boxed commands, use it to greatly reduce the number of parameters (and likelihood of getting out of sync) when adjusting drive-mirror parameters. Signed-off-by: Eric Blake --- v7: new patch --- qapi/block-core.json | 17 - blockdev.c | 72 ++

[Qemu-devel] [PATCH v4 4/5] adb.c: prevent NO_KEY value from going to guest

2016-05-20 Thread Programmingkid
The NO_KEY value should not be sent to the guest. This patch drops that value. Signed-off-by: John Arbuckle --- v4 changes: Added NO_KEY related code to this patch. Added removal of "= 0" code near end of qcode_to_adb_keycode. hw/input/adb.c | 23 --- 1 file changed, 8 inser

[Qemu-devel] [PULL 01/21] pc-dimm: correct comment of MemoryHotplugState

2016-05-20 Thread Eduardo Habkost
From: Cao jin correct comment and remove an unused macro. commit adcb4ee6 already correct its type Signed-off-by: Cao jin Signed-off-by: Eduardo Habkost --- include/hw/mem/pc-dimm.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/include/hw/mem/pc-dimm.h b/include/hw/me

Re: [Qemu-devel] [PATCH v7 00/15] qapi netdev_add introspection (post-introspection cleanups subset F)

2016-05-20 Thread Eric Blake
On 05/20/2016 04:40 PM, Eric Blake wrote: > The end is nearly in sight! Last August, I started a process of > cleaning up qapi on top of Markus' introspection work. Several > hundred emails later, and numerous intermediate series out of > the way, I'm finally at the end of my queue of patches tha

[Qemu-devel] [PULL 15/21] vl: Move DisplayType typedef to vl.c

2016-05-20 Thread Eduardo Habkost
Now the type is only used inside vl.c and doesn't need to be in a header file. Signed-off-by: Eduardo Habkost --- include/sysemu/sysemu.h | 10 -- vl.c| 9 + 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/include/sysemu/sysemu.h b/include/sys

[Qemu-devel] [PULL 04/21] vl: Replace *_vga_available() functions with class_names field

2016-05-20 Thread Eduardo Habkost
Instead of requiring a separate function for each VGA interface, just enumerate the corresponding class names on struct VGAInterfaceInfo. Reviewed-by: Eric Blake Reviewed-by: Marcel Apfelbaum Signed-off-by: Eduardo Habkost --- vl.c | 70 +++--

[Qemu-devel] [PULL 03/21] vl: Table-based select_vgahw()

2016-05-20 Thread Eduardo Habkost
Instead of implementing separate check functions for each vga interface type, add a table enumerating the possible VGA interfaces. Reviewed-by: Eric Blake Reviewed-by: Marcel Apfelbaum Signed-off-by: Eduardo Habkost --- include/sysemu/sysemu.h | 1 + vl.c| 115 +++

Re: [Qemu-devel] undefined symbol _nettle_cast5_set_key

2016-05-20 Thread Programmingkid
On May 20, 2016, at 6:43 PM, Eric Blake wrote: > On 05/20/2016 01:15 PM, Programmingkid wrote: >> Noticed this bug after a 'git pull'. My repo is at commit >> 65603e2fc18b48e6e55a3dd693669413141694ec - >> tci: do not include exec/exec-all.h >> >> I am building QEMU on Mac OS 10.6 with GCC 4.9.

[Qemu-devel] [PULL 13/21] vl: Replace DT_NOGRAPHIC with machine option

2016-05-20 Thread Eduardo Habkost
All DisplayType values are just UI options that don't affect any hardware emulation code, except for DT_NOGRAPHIC. Replace DT_NOGRAPHIC with DT_NONE plus a new "-machine graphics=on|off" option, so hardware emulation code don't need to use the display_type variable. Cc: Michael Walle Cc: Blue Swi

[Qemu-devel] [PULL 02/21] vl: Use exit(1) when requested VGA interface is unavailable

2016-05-20 Thread Eduardo Habkost
Instead of using exit(0), use exit(1) when an unavailable VGA interface is used in the command-line to indicate it's an error. Reviewed-by: Eric Blake Reviewed-by: Marcel Apfelbaum Signed-off-by: Eduardo Habkost --- vl.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) dif

[Qemu-devel] [PULL 16/21] vl: Make display_remote a local variable

2016-05-20 Thread Eduardo Habkost
The variable is used only inside main(), so it can be local. Signed-off-by: Eduardo Habkost --- vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vl.c b/vl.c index aaf9134..a44e155 100644 --- a/vl.c +++ b/vl.c @@ -131,7 +131,6 @@ const char *bios_name = NULL; enum vga_ret

[Qemu-devel] [PATCH v4 5/5] adb.c: add power key support

2016-05-20 Thread Programmingkid
Add support for the power key. Signed-off-by: John Arbuckle --- v4 changes Removed double-quote from end of comment. Removed debug printf statement. v3 change Add several suggested comments. Moved the location of an else statement in the adb_keyboard_event() function. hw/input/adb.c | 43 +

[Qemu-devel] [PULL 06/21] vnc: Initialization stubs

2016-05-20 Thread Eduardo Habkost
This reduces the number of CONFIG_VNC #ifdefs in the vl.c code. The only user-visible difference is that this will make QEMU complain about syntax when using "-display vnc" ("VNC requires a display argument vnc=") even if CONFIG_VNC is disabled. Signed-off-by: Eduardo Habkost --- include/ui/con

[Qemu-devel] [PULL 21/21] Use &error_fatal when initializing crypto on qemu-{img, io, nbd}

2016-05-20 Thread Eduardo Habkost
In addition to making the code simpler, this will replace the long error messages: cannot initialize crypto: Unable to initialize GNUTLS library: [...] cannot initialize crypto: Unable to initialize gcrypt with shorter messages: Unable to initialize GNUTLS library: [...] Unable to initializ

[Qemu-devel] [PULL 17/21] vl: Simplify global property registration

2016-05-20 Thread Eduardo Habkost
There's no need to use qdev_prop_register_global_list() and an array, if we are registering a single GlobalProperty struct. Use qdev_prop_register_global() instead. Reviewed-by: Igor Mammedov Signed-off-by: Eduardo Habkost --- vl.c | 39 +++ 1 file changed, 1

[Qemu-devel] [PULL 12/21] milkymist: Move DT_NOGRAPHIC check outside milkymist_tmu2_create()

2016-05-20 Thread Eduardo Habkost
DT_NOGRAPHIC handling will be moved to a MachineState field, and it will be easier to change milkymist_init() to check that field. Cc: Michael Walle Signed-off-by: Eduardo Habkost --- hw/lm32/milkymist-hw.h | 4 hw/lm32/milkymist.c| 4 +++- 2 files changed, 3 insertions(+), 5 deletions

[Qemu-devel] [PULL 08/21] sdl: Initialization stubs

2016-05-20 Thread Eduardo Habkost
This reduces the number of CONFIG_SDL #ifdefs in vl.c. Signed-off-by: Eduardo Habkost --- include/ui/console.h | 16 vl.c | 6 ++ 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index f5fa9cb..f3e74

[Qemu-devel] [PULL 07/21] curses: curses_display_init() stub

2016-05-20 Thread Eduardo Habkost
One less #ifdef in vl.c. Signed-off-by: Eduardo Habkost --- include/ui/console.h | 9 + vl.c | 2 -- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index 6640348..f5fa9cb 100644 --- a/include/ui/console.h +++ b/i

[Qemu-devel] [PULL 14/21] vl: Make display_type a local variable

2016-05-20 Thread Eduardo Habkost
Now display_type is only used inside main(), and don't need to be a global variable. Signed-off-by: Eduardo Habkost --- include/sysemu/sysemu.h | 1 - vl.c| 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h i

[Qemu-devel] [PULL 09/21] cocoa: cocoa_display_init() stub

2016-05-20 Thread Eduardo Habkost
One less #ifdef in vl.c. Signed-off-by: Eduardo Habkost --- include/ui/console.h | 9 + vl.c | 2 -- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index f3e749d..7ac997f 100644 --- a/include/ui/console.h +++ b/i

[Qemu-devel] [PULL 19/21] vl: Use &error_fatal when parsing VNC options

2016-05-20 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- vl.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/vl.c b/vl.c index 0228843..bc22903 100644 --- a/vl.c +++ b/vl.c @@ -2151,11 +2151,7 @@ static DisplayType select_display(const char *p) #endif } else if (strstart(p,

[Qemu-devel] [PULL 20/21] vl: Use &error_fatal when parsing monitor options

2016-05-20 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- vl.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/vl.c b/vl.c index bc22903..b1562d8 100644 --- a/vl.c +++ b/vl.c @@ -2404,7 +2404,6 @@ static int mon_init_func(void *opaque, QemuOpts *opts, Error **errp) static void monitor_parse(

Re: [Qemu-devel] [PATCH v4 7/8] Add ENET/Gbps Ethernet support to FEC device

2016-05-20 Thread Jean-Christophe DUBOIS
Le 19/05/2016 20:37, Peter Maydell a écrit : On 19 May 2016 at 19:14, Jean-Christophe DUBOIS wrote: Le 19/05/2016 05:48, Jason Wang a écrit : On 2016年05月19日 06:23, Jean-Christophe Dubois wrote: It's ok to decide with "is-fec", but is it better to use a new type for that? Well, there is a lo

Re: [Qemu-devel] [PATCH v2 1/1] block: clarify error message for qmp-eject

2016-05-20 Thread John Snow
On 05/20/2016 10:48 AM, Markus Armbruster wrote: > John Snow writes: > >> If you use HMP's eject but the CDROM tray is locked, you may get a >> confusing error message informing you that the "tray isn't open." >> >> As this is the point of eject, we can do a little better and help >> clarify th

[Qemu-devel] [PATCH v4 3/5] adb.c: correct several key assignments

2016-05-20 Thread Programmingkid
The original pc_to_adb_keycode mapping did have several keys that were incorrectly mapped. This patch fixes these mappings. Signed-off-by: John Arbuckle --- v4 changes: Removed NO_KEY related code. Kept all the "= 0" code near the end of the qcode_to_adb_keycode. hw/input/adb.c | 12 ++-

[Qemu-devel] [QEMU PATCH v2] target-i386: Add Skylake-Client CPU model

2016-05-20 Thread Eduardo Habkost
Introduce Skylake-Client CPU model, which inherits the features from Broadwell and supports some additional features that are: MPX, XSAVEC, and XGETBV1. Signed-off-by: Eduardo Habkost Signed-off-by: Xiao Guangrong Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Remove XSAVES, edited comm

Re: [Qemu-devel] [PATCH v4 7/8] Add ENET/Gbps Ethernet support to FEC device

2016-05-20 Thread Jean-Christophe DUBOIS
Le 20/05/2016 04:34, Jason Wang a écrit : On 2016年05月20日 02:14, Jean-Christophe DUBOIS wrote: Le 19/05/2016 05:48, Jason Wang a écrit : On 2016年05月19日 06:23, Jean-Christophe Dubois wrote: The ENET device (present in i.MX6) is "derived" from FEC and backward compatible with it. This patch

[Qemu-devel] [PATCH v4 2/5] adb.c: add support for QKeyCode

2016-05-20 Thread Programmingkid
The old pc scancode translation is replaced with QEMU's QKeyCode. Signed-off-by: John Arbuckle --- *v4 changes Replaced ADB_KEY_LEFT_COMMAND with ADB_KEY_COMMAND. Removed ADB_KEY_RIGHT_COMMAND comment. *v3 changes Kept original pc_to_adb_keycode mapping. *v2 changes Changed order of this patch.

Re: [Qemu-devel] [PATCH v5 12/18] qht: QEMU's fast, resizable and scalable Hash Table

2016-05-20 Thread Sergey Fedorov
Wow, that's really great stuff! On 14/05/16 06:34, Emilio G. Cota wrote: > diff --git a/include/qemu/qht.h b/include/qemu/qht.h > new file mode 100644 > index 000..c2ab8b8 > --- /dev/null > +++ b/include/qemu/qht.h > @@ -0,0 +1,66 @@ > +/* > + * Copyright (C) 2016, Emilio G. Cota > + * > + *

Re: [Qemu-devel] [PATCH v4 6/8] i.MX: move FEC device to a register array structure.

2016-05-20 Thread Jean-Christophe DUBOIS
Le 20/05/2016 04:26, Jason Wang a écrit : On 2016年05月19日 14:10, Jean-Christophe DUBOIS wrote: Le 19/05/2016 05:28, Jason Wang a écrit : On 2016年05月19日 06:23, Jean-Christophe Dubois wrote: This is to prepare for the ENET Gb device of the i.MX6. Signed-off-by: Jean-Christophe Dubois --- C

[Qemu-devel] [PATCH v7 15/15] schema: Drop pointless empty type CpuInfoOther

2016-05-20 Thread Eric Blake
Now that we can represent an empty type anonymously in a flat union, we can drop one such empty types that existed solely for CpuInfo. However, we can't drop Abort or NetdevNoneOptions, as those were used by simple unions. Signed-off-by: Eric Blake --- v7: new patch --- qapi-schema.json | 12 +

[Qemu-devel] [PATCH v7 07/15] qapi: Implement boxed types for commands/events

2016-05-20 Thread Eric Blake
Turn on the ability to pass command and event arguments in a single boxed parameter. For structs, it makes it possible to pass a single qapi type instead of a breakout of all struct members; for unions, it is now possible to use a union as the data for a command or event. Generated code is unchan

[Qemu-devel] [PATCH v7 10/15] qapi-event: Reduce chance of collision with event data

2016-05-20 Thread Eric Blake
When an event has data that is not boxed, we are exposing all of its members alongside our local variables. So far, we haven't hit a collision, but it may be a matter of time before someone wants to name a QMP data element 'err' or similar. We can separate the names by making the public function

[Qemu-devel] [PATCH v7 12/15] net: Use correct type for bool flag

2016-05-20 Thread Eric Blake
is_netdev is only used as a bool, so make it one. Signed-off-by: Eric Blake --- v7: no change v6: rebase to latest context --- include/net/net.h| 2 +- hw/usb/dev-network.c | 2 +- net/net.c| 12 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/inclu

[Qemu-devel] [PATCH v7 02/15] net: use Netdev instead of NetClientOptions in client init

2016-05-20 Thread Eric Blake
From: Kővágó, Zoltán This way we no longer need NetClientOptions and can convert Netdev into a flat union. Signed-off-by: Kővágó, Zoltán Reviewed-by: Eric Blake Message-Id: <93ffdfed7054529635e6acb935150d95dc173a12.1441627176.git.dirty.ice...@gmail.com> [rework net_client_init1() to pass Net

[Qemu-devel] [PATCH v7 13/15] net: Complete qapi-fication of netdev_add

2016-05-20 Thread Eric Blake
We finally have all the required pieces for doing a type-safe representation of netdev_add as a flat union, where the discriminator 'type' now selects which additional members may appear in the "arguments" JSON object sent over QMP, while making no changes to the set of previously-valid QMP command

[Qemu-devel] [PATCH v7 05/15] qapi: Add type.is_empty() helper

2016-05-20 Thread Eric Blake
And use it in qapi-types and qapi-event. In the near future, we want to lift our artificial restriction of no variants at the top level of an event, at which point, inlining our check for whether members is empty will no longer be sufficient; but adding an inline check for variants everywhere we a

[Qemu-devel] [PATCH v7 14/15] qapi: Allow anonymous branch types in flat union

2016-05-20 Thread Eric Blake
Recent commits added support for an anonymous type as the base of a flat union; with a bit more work, we can also allow an anonymous struct as a branch of a flat union. This probably most useful when a branch adds no additional members beyond the common elements of the base (that is, the branch st

[Qemu-devel] [PATCH v7 06/15] qapi: Plumb in 'box' to qapi generator lower levels

2016-05-20 Thread Eric Blake
A future patch will add support for passing a qapi union type as the 'data' of a command. But to do that, the user function for implementing the command, as called by the generated marshal command, must take the corresponding C struct as a single boxed pointer, rather than a breakdown into one par

[Qemu-devel] [PATCH v7 04/15] qapi: Hide tag_name data member of variants

2016-05-20 Thread Eric Blake
Clean up the only remaining external use of the tag_name field of QAPISchemaObjectTypeVariants, by explicitly listing the generated 'type' tag for all variants in the testsuite. Then we can mark the tag_name field as private by adding a leading underscore to prevent any further use. Signed-off-by

[Qemu-devel] [PATCH v7 03/15] qapi: Require all branches of flat union enum to be covered

2016-05-20 Thread Eric Blake
We were previously enforcing that all flat union branches were found in the corresponding enum, but not that all enum values were covered by branches. The resulting generated code would abort() if the user passes the uncovered enum value. Signed-off-by: Eric Blake --- v7: new patch --- scripts

[Qemu-devel] [PATCH v7 00/15] qapi netdev_add introspection (post-introspection cleanups subset F)

2016-05-20 Thread Eric Blake
The end is nearly in sight! Last August, I started a process of cleaning up qapi on top of Markus' introspection work. Several hundred emails later, and numerous intermediate series out of the way, I'm finally at the end of my queue of patches that were originally sent in v5: https://lists.gnu.or

[Qemu-devel] [PATCH v7 01/15] qapi: Consolidate object visitors

2016-05-20 Thread Eric Blake
Rather than having two separate visitor callbacks with items already broken out, pass the actual QAPISchemaObjectType object to the visitor. This lets the visitor access things like type.is_implicit() without needing another parameter, resolving a TODO from previous patches. For convenience and c

[Qemu-devel] [PATCH v4 1/5] adb-keys.h: initial commit

2016-05-20 Thread Programmingkid
Add the adb-keys.h file. It maps ADB transition key codes with values. Signed-off-by: John Arbuckle --- *v4 changes: Replaced ADB_KEY_LEFT_COMAND and ADB_KEY_RIGHT_COMAND with ADB_KEY_COMMAND. *v3 changes: Removed note. *v2 changes: Changed order of this patch. include/hw/input/adb-keys.h | 1

[Qemu-devel] [PATCH v4 0/5] ADB improvements

2016-05-20 Thread Programmingkid
This patch series makes several improvements to the ADB code. To test this code, please implement the patches in the order below. John Arbuckle (5): adb-keys.h: initial commit adb.c: add support for QKeyCode adb.c: correct several key assignments adb.c: prevent NO_KEY value from going to g

Re: [Qemu-devel] [PATCH] gt64xxx: access right I/O port when activating byte swapping

2016-05-20 Thread Aurelien Jarno
On 2016-05-20 15:05, Hervé Poussineau wrote: > Incidentally, this fixes YAMON on big endian guest. > > Signed-off-by: Hervé Poussineau > --- > hw/mips/gt64xxx_pci.c | 62 > +-- > 1 file changed, 60 insertions(+), 2 deletions(-) > > diff --git a/h

[Qemu-devel] undefined symbol _nettle_cast5_set_key

2016-05-20 Thread Programmingkid
Noticed this bug after a 'git pull'. My repo is at commit 65603e2fc18b48e6e55a3dd693669413141694ec - tci: do not include exec/exec-all.h I am building QEMU on Mac OS 10.6 with GCC 4.9. Here is the full message: LINK qemu-nbd Undefined symbols for architecture x86_64: "_nettle_cast5_set_key"

[Qemu-devel] [PATCH 1/2] linux-user: Handle msgrcv error case correctly

2016-05-20 Thread Peter Maydell
The msgrcv ABI is a bit odd -- the msgsz argument is a size_t, which is unsigned, but it must fail EINVAL if the value is negative when cast to a long. We were incorrectly passing the value through an "unsigned int", which meant that if the guest was 32-bit longs and the host was 64-bit longs an in

[Qemu-devel] [PATCH] virtio: drop duplicate virtio_queue_get_id() function

2016-05-20 Thread Stefan Hajnoczi
The virtio_queue_get_id() function is the lesser used duplicate of virtio_get_queue_index(). Use the latter instead. Signed-off-by: Stefan Hajnoczi --- hw/scsi/virtio-scsi.c | 2 +- hw/virtio/virtio.c | 7 --- include/hw/virtio/virtio.h | 1 - 3 files changed, 1 insertion(+), 9

[Qemu-devel] [PATCH 2/2] linux-user: Use g_try_malloc() in do_msgrcv()

2016-05-20 Thread Peter Maydell
In do_msgrcv() we want to allocate a message buffer, whose size is passed to us by the guest. That means we could legitimately fail, so use g_try_malloc() and handle the error case, in the same way that do_msgsnd() does. Signed-off-by: Peter Maydell --- linux-user/syscall.c | 6 +- 1 file ch

[Qemu-devel] [PATCH 0/2] linux-user: fix some msgrcv edge cases

2016-05-20 Thread Peter Maydell
These patches fix a couple of issues with handling edge cases in our linux-user msgrcv implementation: * we weren't dealing with negative msgsz correctly (should fail EINVAL) * we were using g_malloc() rather than g_try_malloc() for an allocatino whose size is controlled by the guest (Both th

[Qemu-devel] [PATCH] tests: avoid coroutine pool test crash

2016-05-20 Thread Stefan Hajnoczi
Skip the test_co_queue test case if the coroutine pool is not enabled. The test case does not work without the pool because it touches memory belonging to a freed coroutine (on purpose). Reported-by: Eduardo Habkost Signed-off-by: Stefan Hajnoczi --- tests/test-coroutine.c | 10 +- 1 fi

[Qemu-devel] [PATCH v3] block: Fix bdrv_next() memory leak

2016-05-20 Thread Kevin Wolf
The bdrv_next() users all leaked the BdrvNextIterator after completing the iteration. Simply changing bdrv_next() to free the iterator before returning NULL at the end of list doesn't work because some callers exit the loop before looking at all BDSes. This patch moves the BdrvNextIterator from th

[Qemu-devel] [Bug 1287195] Re: validate_guest_space incorrectly enabled on AArch64

2016-05-20 Thread Peter Maydell
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1287195 Title: validate_guest_space incorrectly enabled on AArch64 Status in QEMU:

[Qemu-devel] [Bug 1075272] Re: socket type mapping wrong for mips app-level emulation

2016-05-20 Thread Peter Maydell
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1075272 Title: socket type mapping wrong for mips app-level emulation Status in QEMU:

[Qemu-devel] [Bug 1580459] Re: Windows (10?) guest freezes entire host on shutdown if using PCI passthrough

2016-05-20 Thread Jimi
Also, yeah, the Linux one is called SteamOS, but it is actually just an almost identical install of Arch. SteamOS wasn't playing nice with most of my hardware when I tried to install it. ** Attachment added: "SteamOS.xml" https://bugs.launchpad.net/qemu/+bug/1580459/+attachment/4667053/+files/

[Qemu-devel] [Bug 1580459] Re: Windows (10?) guest freezes entire host on shutdown if using PCI passthrough

2016-05-20 Thread Jimi
I should also post my "scripts" (libvirt XML files in my case): But, since the Windows VM and Linux VM are completely identical beyond the OS that's installed, I don't think our VM configurations have anything to do with this bug. I mean, they aren't completely identical right now because I remove

[Qemu-devel] [PATCH v2] block: Fix bdrv_next() memory leak

2016-05-20 Thread Kevin Wolf
The bdrv_next() users all leaked the BdrvNextIterator after completing the iteration. Simply changing bdrv_next() to free the iterator before returning NULL at the end of list doesn't work because some callers exit the loop before looking at all BDSes. This patch moves the BdrvNextIterator from th

[Qemu-devel] [Bug 1580459] Re: Windows (10?) guest freezes entire host on shutdown if using PCI passthrough

2016-05-20 Thread kachaffeous
Here is my startup script. #!/bin/bash echo "Starting virtual machine..." cp /usr/share/edk2.git/ovmf-x64/OVMF_VARS-pure-efi.fd /tmp/my_vars.fd sudo \ qemu-system-x86_64 \ -name "Windows 10" \ -enable-kvm \ -m 12288 \ -cpu host,kvm=off \ -smp threads=2,cores=4,sockets=1 \ -vga no

Re: [Qemu-devel] [PATCH] crypto: assert that qcrypto_hash_digest_len is in range

2016-05-20 Thread Daniel P. Berrange
On Fri, May 20, 2016 at 09:52:36AM -0600, Eric Blake wrote: > On 05/20/2016 03:09 AM, Paolo Bonzini wrote: > > Otherwise unintended results could happen. For example, > > Coverity reports a division by zero in qcrypto_afsplit_hash. > > While this cannot really happen, it shows that the contract >

[Qemu-devel] [PATCH 2/4] hw/misc: add a TMP42{1,2,3} device model

2016-05-20 Thread Cédric Le Goater
Largely inspired by the TMP105 temperature sensor, this patch brings to Qemu a model for TMP42{1,2,3} temperature sensors. Specs can be found here : http://www.ti.com/lit/gpn/tmp421 Signed-off-by: Cédric Le Goater --- hw/misc/Makefile.objs | 1 + hw/misc/tmp421.c | 395 +

[Qemu-devel] [PATCH v2 3/3] cpus: call the core nmi injection function

2016-05-20 Thread Bandan Das
We can call the common function here directly since x86 specific actions will be taken care of by the arch specific nmi handler Signed-off-by: Bandan Das --- cpus.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/cpus.c b/cpus.c index eb34b4f..481f78a 100644 --- a/cpus.c +++ b

[Qemu-devel] [PATCH v2 1/3] target-i386: add a generic x86 nmi handler

2016-05-20 Thread Bandan Das
Instead of having x86 ifdefs in core nmi code, this change adds a arch specific handler that the nmi common code can call. Signed-off-by: Bandan Das --- hw/i386/pc.c | 20 1 file changed, 20 insertions(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 99437e0..e29ccc8 10064

Re: [Qemu-devel] [PATCH 4/4] cpus: call the core nmi injection function

2016-05-20 Thread Bandan Das
Paolo Bonzini writes: > On 20/05/2016 00:15, Bandan Das wrote: >> void qmp_inject_nmi(Error **errp) >> { >> -#if defined(TARGET_I386) >> -CPUState *cs; >> - >> -CPU_FOREACH(cs) { >> -X86CPU *cpu = X86_CPU(cs); >> - >> -if (!cpu->apic_state) { >> -cpu_interrup

[Qemu-devel] [PATCH] i2c: add aspeed i2c crontroller

2016-05-20 Thread Cédric Le Goater
The Aspeed AST2400 integrates a set of 14 I2C/SMBus bus controllers directly connected to ab APB bus which can be programmed as a master or slave. This patch offers a device model for the master mode only, slave mode is not supported. On the TODO list, we also have : - improve and harden the st

[Qemu-devel] [PATCH v2 2/3] nmi: remove x86 specific nmi handling

2016-05-20 Thread Bandan Das
nmi_monitor_handle is wired to call the x86 nmi handler. So, we can directly use it at call sites. Signed-off-by: Bandan Das --- hw/core/nmi.c | 24 hw/watchdog/watchdog.c | 2 +- include/hw/nmi.h | 1 - 3 files changed, 1 insertion(+), 26 deletions(-)

[Qemu-devel] [PATCH v2 0/3] Minor nmi cleanups

2016-05-20 Thread Bandan Das
v2: 2/4: Remove inject_nmi and call nmi_monitor_handle() directly 3/4: rm -rf 4/4: Call nmi_monitor_handle and pass cpu index The primary change is a arch specific x86 nmi function which can be called by the core nmi handler. Bandan Das (3): target-i386: add a generic x86 nmi handler nmi: rem

Re: [Qemu-devel] GSoC 2016: Introductory email

2016-05-20 Thread Alex Bennée
Pranith Kumar writes: > Hello all, > > I've been selected to participate in GSoC 2016 in the Qemu project. I will be > mentored by Alex Bennée and will be working on solving memory consistency > issues in the MTTCG project. In particular we are targeting to get ARM guests > working on x86 hosts

Re: [Qemu-devel] [PATCH] crypto: assert that qcrypto_hash_digest_len is in range

2016-05-20 Thread Eric Blake
On 05/20/2016 03:09 AM, Paolo Bonzini wrote: > Otherwise unintended results could happen. For example, > Coverity reports a division by zero in qcrypto_afsplit_hash. > While this cannot really happen, it shows that the contract > of qcrypto_hash_digest_len can be improved. > > Signed-off-by: Paol

Re: [Qemu-devel] [RFC PATCH qemu] spapr_iommu, vfio, memory: Notify IOMMU about starting/stopping listening

2016-05-20 Thread Alex Williamson
On Fri, 20 May 2016 18:04:42 +1000 Alexey Kardashevskiy wrote: > The sPAPR TCE tables manage 2 copies when VFIO is using an IOMMU - > a guest view of the table and a hardware TCE table. If there is no VFIO > presense in the address space, then just the guest view is used, if > this is the case, i

Re: [Qemu-devel] vfio IGD assignment (was Re: [PATCH v6 0/8] Series short description)

2016-05-20 Thread Alex Williamson
On Fri, 20 May 2016 14:19:19 +0200 Gerd Hoffmann wrote: > On Mi, 2016-05-18 at 12:45 -0600, Alex Williamson wrote: > > On Wed, 18 May 2016 16:24:49 +0200 > > Gerd Hoffmann wrote: > > > > > Hi, > > > > > > > I believe we're no longer blocked by SeaBIOS being willing to > > > > consume the

Re: [Qemu-devel] [PATCH v4 0/4] QOM'ify hw/char devices

2016-05-20 Thread Paolo Bonzini
On 20/05/2016 16:52, Markus Armbruster wrote: > xiaoqiang zhao writes: > >> 在 2016年05月19日 21:45, mich...@walle.cc 写道: >>> Am 2016-05-19 13:32, schrieb Paolo Bonzini: Michael, can you test patches 3 and 4? >>> >>> Doesn't work for me: >>> $ qemu-system-lm32 -kernel serial.bin -serial vc -

Re: [Qemu-devel] [PATCH v4 0/4] QOM'ify hw/char devices

2016-05-20 Thread Markus Armbruster
xiaoqiang zhao writes: > 在 2016年05月19日 21:45, mich...@walle.cc 写道: >> Am 2016-05-19 13:32, schrieb Paolo Bonzini: >>> Michael, can you test patches 3 and 4? >> >> Doesn't work for me: >> $ qemu-system-lm32 -kernel serial.bin -serial vc -serial vc >> Unexpected error in parse_chr() at >> /home/m

Re: [Qemu-devel] [PATCH 3/3] virtio-gpu: Warn if UI config will disable virgl

2016-05-20 Thread Cole Robinson
On 05/20/2016 01:53 AM, Gerd Hoffmann wrote: > On Mi, 2016-05-18 at 12:40 -0400, Cole Robinson wrote: >> Give users a hint if their config is wrong. >> >> Signed-off-by: Cole Robinson >> --- >> If virgl support is built into qemu, virgl=on is the default, so this >> could be noisy in cases where p

  1   2   >