On 04/14/2016 08:46 AM, Fam Zheng wrote:
On Thu, 04/14 08:04, Denis V. Lunev wrote:
unfortunately no. If the lock will be on the image file,
we will have get it on the target node on QEMU start
and re-acquire it in bdrv_invalidate_cache.
From my POW you should not get the lock if
BDRV_O_INACTI
On 04/14/2016 09:23 AM, Fam Zheng wrote:
On Thu, 04/14 09:14, Denis V. Lunev wrote:
On 04/14/2016 08:46 AM, Fam Zheng wrote:
On Thu, 04/14 08:04, Denis V. Lunev wrote:
unfortunately no. If the lock will be on the image file,
we will have get it on the target node on QEMU start
and re-acquire i
On Thu, 04/14 09:14, Denis V. Lunev wrote:
> On 04/14/2016 08:46 AM, Fam Zheng wrote:
> >On Thu, 04/14 08:04, Denis V. Lunev wrote:
> >>unfortunately no. If the lock will be on the image file,
> >>we will have get it on the target node on QEMU start
> >>and re-acquire it in bdrv_invalidate_cache.
>
On Thu, 04/14 08:04, Denis V. Lunev wrote:
> unfortunately no. If the lock will be on the image file,
> we will have get it on the target node on QEMU start
> and re-acquire it in bdrv_invalidate_cache.
>
> From my POW you should not get the lock if
> BDRV_O_INACTIVE is set.
That is what I meant.
On 2016-04-13 19:46, Peter Xu wrote:
> On Wed, Apr 13, 2016 at 07:44:54AM -0700, Jan Kiszka wrote:
> [...]
>>> One thing I am curious about: I see that in vtd spec 5.1.5.1:
>>>
>>> "RTE bits 10:8 is programmed to 000b (Fixed) to force the SHV
>>> (SubHandle Valid) field as Clear in the interrupt ad
On Wed, Apr 13, 2016 at 07:39:53AM -0700, Jan Kiszka wrote:
> On 2016-04-13 00:27, Peter Xu wrote:
> > On Mon, Apr 11, 2016 at 03:32:18PM +0300, Michael S. Tsirkin wrote:
> >> On Mon, Apr 11, 2016 at 05:19:10PM +0800, Peter Xu wrote:
> >>> v2 changes:
> >>> - patch 1
> >>> - rename "int_remap" to
On 04/14/2016 05:36 AM, Fam Zheng wrote:
On Wed, 04/13 13:18, Denis V. Lunev wrote:
On 04/13/2016 12:09 PM, Fam Zheng wrote:
Too many troubles have been caused by two processes writing to the same image
unexpectedly. This series introduces automatical image locking into QEMU to
avoid such trage
Return the negated value of accel_initialised is meaningless,
and the caller vl doesn't check it.
Signed-off-by: Wei Jiangang
---
accel.c| 4 +---
include/sysemu/accel.h | 2 +-
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/accel.c b/accel.c
index 0510b90..403eb5
On Thu, 2016-04-14 at 11:34 +0800, Changlong Xie wrote:
> On 04/14/2016 11:19 AM, Wei, Jiangang wrote:
> > ping...
> > Any comments?
> > On Tue, 2016-03-15 at 18:07 +0800, Wei Jiangang wrote:
> >> Return the negated value of accel_initialised is meaningless,
> >> and the caller vl doesn't check it.
On Wed, 13 Apr 2016 21:14:44 +0300
"Michael S. Tsirkin" wrote:
> On Wed, Apr 13, 2016 at 08:11:36PM +0200, Thomas Huth wrote:
> > On 13.04.2016 19:55, Michael S. Tsirkin wrote:
> > > On Wed, Apr 13, 2016 at 07:38:12PM +0200, Thomas Huth wrote:
> > >> On 13.04.2016 19:07, Michael S. Tsirkin wr
On 04/13/2016 09:02 PM, Stefan Hajnoczi wrote:
On Mon, Apr 11, 2016 at 04:22:58PM +0800, Changlong Xie wrote:
+static coroutine_fn int replication_co_writev(BlockDriverState *bs,
+ int64_t sector_num,
+ int
On Wed, 13 Apr 2016 16:15:25 +0300
"Michael S. Tsirkin" wrote:
> On Wed, Apr 13, 2016 at 01:52:44PM +0200, Thomas Huth wrote:
> > The balloon code currently calls madvise() with TARGET_PAGE_SIZE
> > as length parameter, and an address which is directly based on
> > the page address supplied by th
On Wed, 13 Apr 2016 13:52:44 +0200
Thomas Huth wrote:
> The balloon code currently calls madvise() with TARGET_PAGE_SIZE
> as length parameter, and an address which is directly based on
> the page address supplied by the guest. Since the virtio-balloon
> protocol is always based on 4k based addre
Hi,
> From: Cornelia Huck [mailto:cornelia.h...@de.ibm.com]
> Sent: Thursday, April 14, 2016 12:30 AM
> To: Gonglei (Arei)
> Subject: Re: [RFC v2] virtio-crypto specification
>
> On Tue, 12 Apr 2016 09:03:33 +
> "Gonglei (Arei)" wrote:
>
> > > From: Cornelia Huck [mailto:cornelia.h...@de.ib
On 04/14/2016 11:19 AM, Wei, Jiangang wrote:
ping...
Any comments?
On Tue, 2016-03-15 at 18:07 +0800, Wei Jiangang wrote:
Return the negated value of accel_initialised is meaningless,
and the caller vl doesn't check it.
Signed-off-by: Wei Jiangang
---
accel.c | 4 +---
1 file changed, 1 ins
I send V2 with minor fix
- fix patch title typo 'chanage' -> 'change'
- coding sytle: 'return ;' -> 'return;'
- add Acked tag
pls review the V2.
Best regards
Li Zhijian
On 04/13/2016 07:57 PM, Paolo Bonzini wrote:
On 13/04/2016 11:27, Li Zhijian wrote:
Previously, qemu will abort at followin
Previously, qemu will abort at following scenario:
(qemu) stop
(qemu) system_reset
(qemu) system_reset
(qemu) 2016-04-13T20:54:38.979158Z qemu-system-x86_64: invalid runstate
transition: 'prelaunch' -> 'prelaunch'
Signed-off-by: Li Zhijian
Acked-by: Paolo Bonzini
---
from v1
- fix patch title t
ping...
Any comments?
On Tue, 2016-03-15 at 18:07 +0800, Wei Jiangang wrote:
> Return the negated value of accel_initialised is meaningless,
> and the caller vl doesn't check it.
>
> Signed-off-by: Wei Jiangang
> ---
> accel.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff
On Wed, Apr 13, 2016 at 07:44:54AM -0700, Jan Kiszka wrote:
[...]
> > One thing I am curious about: I see that in vtd spec 5.1.5.1:
> >
> > "RTE bits 10:8 is programmed to 000b (Fixed) to force the SHV
> > (SubHandle Valid) field as Clear in the interrupt address
> > generated."
> >
> > So... In
On Wed, 04/13 13:18, Denis V. Lunev wrote:
> On 04/13/2016 12:09 PM, Fam Zheng wrote:
> >Too many troubles have been caused by two processes writing to the same image
> >unexpectedly. This series introduces automatical image locking into QEMU to
> >avoid such tragedy. With this, the user won't be a
On Wed, 04/13 10:19, Daniel P. Berrange wrote:
> On Wed, Apr 13, 2016 at 05:09:49PM +0800, Fam Zheng wrote:
> > Too many troubles have been caused by two processes writing to the same
> > image
> > unexpectedly. This series introduces automatical image locking into QEMU to
> > avoid such tragedy.
On Wed, 04/13 10:21, Daniel P. Berrange wrote:
> On Wed, Apr 13, 2016 at 05:09:54PM +0800, Fam Zheng wrote:
> > Because virtlockd in libvirt already uses the fcntl lock on the image file,
> > we
> > have to workaround this by locking a digest-mapped temporary file.
> >
> > Signed-off-by: Fam Zhen
On Wed, 04/13 23:18, Matthew Schumacher wrote:
> I can reproduce this at will, and can provide more information per a
> dev's request.
Could you please try v2.6.0-rc1?
Fam
On 04/13/2016 08:47 PM, Stefan Hajnoczi wrote:
On Mon, Apr 11, 2016 at 04:22:57PM +0800, Changlong Xie wrote:
+/*
+ * The caller of the function MUST make sure vm stopped
+ */
+void replication_start_all(ReplicationMode mode, Error **errp)
+{
+ReplicationState *rs, *next;
+
+QLIST_FOREAC
On 04/13/2016 12:17 PM, Daniel P. Berrange wrote:
> The iSCSI block driver has a very strange approach whereby it
> does not accept options directly as part of the -drive arg,
> but instead takes them indirectly from a -iscsi arg. To make
> up -driver and -iscsi args, it takes the iSCSI target na
On 04/12/2016 05:38 AM, Alex Williamson wrote:
On Tue, 5 Apr 2016 19:42:02 +0800
Cao jin wrote:
From: Chen Fan
for supporting aer recovery, host and guest would run the same aer
recovery code, that would do the secondary bus reset if the error
is fatal, the aer recovery process:
1. error
Instead of requiring a separate function for each VGA interface,
just enumerate the corresponding class names on struct
VGAInterfaceInfo.
Reviewed-by: Eric Blake
Signed-off-by: Eduardo Habkost
---
vl.c | 70 +++-
1 file changed, 23
Instead of using exit(0), use exit(1) when an unavailable VGA
interface is used in the command-line to indicate it's an error.
Reviewed-by: Eric Blake
Signed-off-by: Eduardo Habkost
---
vl.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/vl.c b/vl.c
index 9df
Instead of implementing separate check functions for each vga
interface type, add a table enumerating the possible VGA
interfaces.
Reviewed-by: Eric Blake
Signed-off-by: Eduardo Habkost
---
Changes v1 -> v2:
* Keep assert(vga_interface_type == VGA_NONE) line
Suggested-by: Eric Blake
* Fix spa
Instead of duplicating class lookup and strstart() code for each
VGA interface type, use a table to implement select_vgahw().
Changes v1 -> v2:
* Keep assert(vga_interface_type == VGA_NONE) line
Suggested-by: Eric Blake
* Fix spacing on select_vgahw() definition
Suggested-by: Eric Blake
* In
Public bug reported:
Information:
OS: Slackware64-Current
Compiled with: gcc version 5.3.0 (GCC) / glibc 2.23
Compiled using:
CFLAGS="-O2 -fPIC" \
CXXFLAGS="-O2 -fPIC" \
LDFLAGS="-L/usr/lib64" \
./configure \
--prefix=/usr \
--sysconfdir=/etc \
--localstatedir=/var \
--libdir=/usr/lib6
Excellent - thanks once again for all your help!
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1450881
Title:
qemu-system-sparc MUTEX_HELD assert and libC lock errors
Status in QEMU:
New
Bug de
On Wed, Apr 13, 2016 at 11:43:56PM +0200, Marc-André Lureau wrote:
> On Wed, Apr 13, 2016 at 7:32 PM, Yuanhan Liu
> wrote:
> >>
> >> > I'm asking because I found a seg fault issue sometimes,
> >> > due to opaque is NULL.
> >
> > Oh, I was wrong, it's u being NULL, but not opaque.
> >> >
> >>
> >>
On Wed, Apr 13, 2016 at 7:32 PM, Yuanhan Liu
wrote:
>>
>> > I'm asking because I found a seg fault issue sometimes,
>> > due to opaque is NULL.
>
> Oh, I was wrong, it's u being NULL, but not opaque.
>> >
>>
>> I would be interested to see the backtrace or have a reproducer.
>
> It's a normal test
> On Apr 13, 2016, at 1:07 PM, John Snow wrote:
>
> Why do you want to use IDE? If you are looking for performance, why not
> a virtio device?
I’m just trying to understand how IDE emulation works and see where the
overhead comes in. Thank you for the detailed explanation. I really appreciate
On Wed, Apr 13, 2016 at 01:50:53PM +0100, Dr. David Alan Gilbert wrote:
> * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote:
>
> > +if ( ((b + 1) % 255) == last_byte && !hit_edge) {
>
> Ahem, that should be 256.
>
> I'm going to bisect the kernel and see where we get to.
> Andrea'
On 04/13/2016 11:38 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> Refactor the code to advance the QListEntry pointer at the point
>> where visit_type_FOO() is called, rather than visit_next_list().
>> This will allow a future patch to move the visit of the list head
>> into visit_start_
On 13 April 2016 at 11:08, wrote:
> From: Marc-André Lureau
>
> The following changes since commit d44122ecd0fa62d20762bdd8f214f077cb8e011b:
>
> Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging
> (2016-04-12 17:47:15 +0100)
>
> are available in the git repository at
On Wed, Apr 13, 2016 at 06:41:48PM +, Aleksandar Markovic wrote:
> Hello, Eduardo,
>
> I greatly appreciate your time spent on this matter and your unfailing
> attention to detail.
>
> For Alpha and Xtensa, this is for sure, they will zero their CPU objects, as
> you hinted:
>
> target-alp
Hello, Eduardo,
I greatly appreciate your time spent on this matter and your unfailing
attention to detail.
For Alpha and Xtensa, this is for sure, they will zero their CPU objects, as
you hinted:
target-alpha/cpu.c:
162 cpu_class = object_class_by_name(TYPE("ev67"));
163 }
On Wed, Apr 13, 2016 at 05:51:15AM -0400, Marc-André Lureau wrote:
> Hi
>
> - Original Message -
> > Hi Marc,
> >
> > First of all, sorry again for late response!
> >
> > Last time I tried with your first version, I found few issues related
> > with reconnect, mainly on the acked_feautre
On Wed, Apr 13, 2016 at 08:11:36PM +0200, Thomas Huth wrote:
> On 13.04.2016 19:55, Michael S. Tsirkin wrote:
> > On Wed, Apr 13, 2016 at 07:38:12PM +0200, Thomas Huth wrote:
> >> On 13.04.2016 19:07, Michael S. Tsirkin wrote:
> >>> On Wed, Apr 13, 2016 at 04:51:49PM +0200, Thomas Huth wrote:
> >>>
On Wed, Apr 13, 2016 at 08:11:36PM +0200, Thomas Huth wrote:
> On 13.04.2016 19:55, Michael S. Tsirkin wrote:
> > On Wed, Apr 13, 2016 at 07:38:12PM +0200, Thomas Huth wrote:
> >> On 13.04.2016 19:07, Michael S. Tsirkin wrote:
> >>> On Wed, Apr 13, 2016 at 04:51:49PM +0200, Thomas Huth wrote:
> >>>
On 13.04.2016 19:55, Michael S. Tsirkin wrote:
> On Wed, Apr 13, 2016 at 07:38:12PM +0200, Thomas Huth wrote:
>> On 13.04.2016 19:07, Michael S. Tsirkin wrote:
>>> On Wed, Apr 13, 2016 at 04:51:49PM +0200, Thomas Huth wrote:
On 13.04.2016 15:15, Michael S. Tsirkin wrote:
> On Wed, Apr 13,
On 04/13/2016 03:25 AM, Huaicheng Li (coperd) wrote:
>
>> On Mar 14, 2016, at 10:09 PM, Huaicheng Li wrote:
>>
>>
>>> On Mar 13, 2016, at 8:42 PM, Fam Zheng wrote:
>>>
>>> On Sun, 03/13 14:37, Huaicheng Li (coperd) wrote:
Hi all,
What I’m confused about is that:
If on
On 13.04.2016 19:07, Michael S. Tsirkin wrote:
> On Wed, Apr 13, 2016 at 04:51:49PM +0200, Thomas Huth wrote:
>> On 13.04.2016 15:15, Michael S. Tsirkin wrote:
>>> On Wed, Apr 13, 2016 at 01:52:44PM +0200, Thomas Huth wrote:
...
Then, there's yet another problem: If the host page size is bigge
On Wed, Apr 13, 2016 at 07:38:12PM +0200, Thomas Huth wrote:
> On 13.04.2016 19:07, Michael S. Tsirkin wrote:
> > On Wed, Apr 13, 2016 at 04:51:49PM +0200, Thomas Huth wrote:
> >> On 13.04.2016 15:15, Michael S. Tsirkin wrote:
> >>> On Wed, Apr 13, 2016 at 01:52:44PM +0200, Thomas Huth wrote:
> ...
On Wed, Apr 13, 2016 at 06:17:29PM +0200, Markus Armbruster wrote:
> "Michael S. Tsirkin" writes:
>
> > On Wed, Apr 13, 2016 at 10:59:35AM +0200, Markus Armbruster wrote:
> >> I have a hard time coming up with realistic unclean breakage.
> >
> > The issue is that Linux is now exposing fw cfg to u
On Wed, Apr 13, 2016 at 06:19:55PM +0200, Markus Armbruster wrote:
> "Michael S. Tsirkin" writes:
>
> > On Wed, Apr 13, 2016 at 10:59:35AM +0200, Markus Armbruster wrote:
> >> If we can protect them without
> >> complicating or breaking stuff, sure, why not. But not at all costs.
> >
> > The stu
As noted, Xenial kernel is not supporting POWER7 cpu.
** Changed in: linux (Ubuntu)
Status: Confirmed => Invalid
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1563887
Title:
qemu-system-ppc
Eric Blake writes:
> Refactor the code to advance the QListEntry pointer at the point
> where visit_type_FOO() is called, rather than visit_next_list().
> This will allow a future patch to move the visit of the list head
> into visit_start_list(), and get rid of the 'first' flag.
>
> Signed-off-b
On 13 April 2016 at 00:36, John Snow wrote:
> The following changes since commit d44122ecd0fa62d20762bdd8f214f077cb8e011b:
>
> Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging
> (2016-04-12 17:47:15 +0100)
>
> are available in the git repository at:
>
> https://gith
Under Linux, it is working fine.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1569988
Title:
[2.6] user network broken reaching foreign servers on Win64
Status in QEMU:
New
Bug description:
On Wed, Apr 13, 2016 at 04:51:49PM +0200, Thomas Huth wrote:
> On 13.04.2016 15:15, Michael S. Tsirkin wrote:
> > On Wed, Apr 13, 2016 at 01:52:44PM +0200, Thomas Huth wrote:
> >> The balloon code currently calls madvise() with TARGET_PAGE_SIZE
> >> as length parameter, and an address which is dire
** Changed in: qemu
Status: Confirmed => Invalid
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1563887
Title:
qemu-system-ppc64 freezes on starting image on ppc64le
Status in QEMU:
Invali
On Tue, Apr 12, 2016 at 08:46:56PM +0200, Paolo Bonzini wrote:
> Hi all, if you are CCed there is a feature you wrote or maintain that
> needs further work in the ChangeLog
> (http://wiki.qemu.org/ChangeLog/2.6). In particular:
>
> Andrew/Peter:
> * New partial Raspberry Pi 1 and 2 emulation with
Am 23.03.2016 um 04:33 hat Jeff Cody geschrieben:
> Fixes for a regression in vpc_create(), as well as a few issues with VHD
> format
> compatibility.
Thanks, applied to the block brannch.
Kevin
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
backends/hostmem-file.c | 8
1 file changed, 8 insertions(+)
diff --git a/backends/hostmem-file.c b/backends/hostmem-file.c
index b17a1f1..5c4b808 100644
--- a/backends/hostmem-file.c
+++ b/backends/hostmem-file.c
@@ -121,11
Am 23.03.2016 um 04:33 hat Jeff Cody geschrieben:
> Signed-off-by: Jeff Cody
> ---
> block/vpc.c | 70
> ++---
> 1 file changed, 35 insertions(+), 35 deletions(-)
>
> diff --git a/block/vpc.c b/block/vpc.c
> index 5dd9950..0b48cf4 100644
>
Public bug reported:
Both on master and, starting with 2016-03-22 builds from
http://qemu.weilnetz.de/w64/, user mode network can't reach foreign
servers. For example, wget http://mifritscher resolves the DNS, but then
the message "network target couldn't be reached" occures. 2016-03-03
works fine
Am 13.04.2016 um 17:40 hat Jeff Cody geschrieben:
> On Tue, Mar 22, 2016 at 11:33:38PM -0400, Jeff Cody wrote:
> > Commit 'b8f45cdf7827e39f9a1e6cc446f5972cc6144237' switched VPC
> > over to using blk_pwrite() instead of bdrv_pwrite_sync(). The
> > return value of bdrv_pwrite_sync() was always 0 fo
On 04/13/2016 10:06 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> Commit e8316d7 mistakenly passed consume=true
>
> in qmp_input_optional(), right?
yes
>
>> when checking if
>> an optional member was present, but the mistake was silently
On 04/13/2016 10:36 AM, Eric Blake wrote:
>>static void qmp_input_pop(QmpInputVisitor *qiv, Error **errp)
>>{
>>assert(qiv->nb_stack > 0);
>>
>>if (qiv->strict) {
>>GHashTable * const top_ht = qiv->stack[qiv->nb_stack - 1].h;
>>if (top_ht) {
>>
On 04/13/2016 09:53 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> Management of the top of stack was a bit verbose; creating a
>> temporary variable and adding some comments makes the existing
>> code more legible before the next few patches improve things.
>> No semantic changes other t
On Tue, 12 Apr 2016 09:03:33 +
"Gonglei (Arei)" wrote:
> > From: Cornelia Huck [mailto:cornelia.h...@de.ibm.com]
> > Sent: Tuesday, April 12, 2016 4:00 PM
> > Subject: Re: [RFC v2] virtio-crypto specification
> >
> > On Tue, 5 Apr 2016 09:14:09 +
> > "Gonglei (Arei)" wrote:
> >
> >
>
On 04/13/2016 07:49 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> We have three classes of QAPI visitors: input, output, and dealloc.
>> Currently, all implementations of these visitors have one thing in
>> common based on their visitor type: the implementation used for the
>> visit_type
"Michael S. Tsirkin" writes:
> On Wed, Apr 13, 2016 at 10:59:35AM +0200, Markus Armbruster wrote:
>> If we can protect them without
>> complicating or breaking stuff, sure, why not. But not at all costs.
>
> The stuff we break is precisely the stuff our warnings
> say might break at any time. So
The iSCSI block driver has a very strange approach whereby it
does not accept options directly as part of the -drive arg,
but instead takes them indirectly from a -iscsi arg. To make
up -driver and -iscsi args, it takes the iSCSI target name
and uses that as an ID value for the -iscsi arg lookup.
"Michael S. Tsirkin" writes:
> On Wed, Apr 13, 2016 at 10:59:35AM +0200, Markus Armbruster wrote:
>> I have a hard time coming up with realistic unclean breakage.
>
> The issue is that Linux is now exposing fw cfg to userspace.
> So it's use is about to expand significantly.
>
> This is what I am
On 04/13/2016 06:48 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> Rather than having two separate visitor callbacks with items
>> already broken out, pass the actual QAPISchemaObjectType object
>> to the visitor. This lets the visitor access things like
>> type.is_implicit() without nee
Eric Blake writes:
> Commit e8316d7 mistakenly passed consume=true
in qmp_input_optional(), right?
> when checking if
> an optional member was present, but the mistake was silently
> ignored since the code happily let us extract a member more than
>
Eric Blake writes:
> Management of the top of stack was a bit verbose; creating a
> temporary variable and adding some comments makes the existing
> code more legible before the next few patches improve things.
> No semantic changes other than asserting that we are always
> visiting a QObject, an
On Wed, Apr 13, 2016 at 5:45 PM, Gerd Hoffmann wrote:
> On Mi, 2016-04-13 at 16:43 +0200, Ladi Prosek wrote:
>> VIRTIO_INPUT_CFG_ABS_INFO was not implemented for pass-through input
>> devices. This patch follows the existing design and pre-fetches the
>> config for all absolute axes using EVIOCGAB
Build target was changed to P8 starting with Xenial. Previously it had
been a P7 target. I would expect Xenial kernel to have problems booting
on a P7 model. IMO this kernel bug is invalid.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to
On Mi, 2016-04-13 at 16:43 +0200, Ladi Prosek wrote:
> VIRTIO_INPUT_CFG_ABS_INFO was not implemented for pass-through input
> devices. This patch follows the existing design and pre-fetches the
> config for all absolute axes using EVIOCGABS at realize time.
Just in time for the input pull request
From: Ladi Prosek
The write path for pass-through devices, commonly used for controlling
keyboard LEDs via EV_LED, was not implemented. This commit adds the
necessary plumbing to connect the status virtio queue to the host evdev
file descriptor.
Signed-off-by: Ladi Prosek
Message-id: 1459511146
Read absolute and relative axis information, only classify
devices as mouse/tablet in case the x axis is present.
Signed-off-by: Gerd Hoffmann
---
ui/input-linux.c | 30 +-
1 file changed, 25 insertions(+), 5 deletions(-)
diff --git a/ui/input-linux.c b/ui/input-linu
From: Ladi Prosek
VIRTIO_INPUT_CFG_EV_BITS with subsel of EV_LED was always
returning an empty bitmap for pass-through input devices.
Signed-off-by: Ladi Prosek
Message-id: 1459418028-7473-1-git-send-email-lpro...@redhat.com
Signed-off-by: Gerd Hoffmann
---
hw/input/virtio-input-host.c | 1 +
changes since commit d44122ecd0fa62d20762bdd8f214f077cb8e011b:
Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging
(2016-04-12 17:47:15 +0100)
are available in the git repository at:
git://git.kraxel.org/qemu tags/pull-input-20160413-1
for you to fetch cha
Signed-off-by: Gerd Hoffmann
Reviewed-by: Eric Blake
Message-id: 1460441239-867-1-git-send-email-kra...@redhat.com
---
include/hw/virtio/virtio-input.h | 14 --
include/qemu/bswap.h | 19 +++
2 files changed, 19 insertions(+), 14 deletions(-)
diff --git a
virtio-input is simple enough that it doesn't need to xfer any state.
Still we have to wire up savevm manually, so the generic pci and virtio
are saved correctly.
Additionally we need to do some post-load processing to figure whenever
the guest uses the device or not, so we can give input routing
From: Ladi Prosek
The reported maximum was wrong. The X and Y coordinates are 0-based
so if size is 8000 maximum must be 7FFF.
Signed-off-by: Ladi Prosek
Message-id: 1460128893-10244-1-git-send-email-lpro...@redhat.com
Signed-off-by: Gerd Hoffmann
---
hw/input/virtio-input-hid.c | 4 ++--
1 f
From: Ladi Prosek
VIRTIO_INPUT_CFG_ABS_INFO was not implemented for pass-through input
devices. This patch follows the existing design and pre-fetches the
config for all absolute axes using EVIOCGABS at realize time.
Signed-off-by: Ladi Prosek
Message-id: 1460558603-18331-1-git-send-email-lpro.
From: Ladi Prosek
KEY_PAUSE is flat out missing. KEY_SYSRQ already has a keycode
assigned but it's not what I'm seeing on my system. The mapping
doesn't appear to have to be unique so both keycodes now map to
KEY_SYSRQ which is what the "Keyboard PrintScreen", HID usage ID
0x46, translates to.
S
"_x" must be "(_x)" otherwise things fail if you pass in expressions.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Eric Blake
Message-id: 1460440299-26654-1-git-send-email-kra...@redhat.com
---
include/hw/virtio/virtio-input.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
dif
On Wednesday 13 April 2016 15:18:20 Daniel P. Berrange wrote:
> The iSCSI block driver has a very strange approach whereby it
> does not accept options directly as part of the -drive arg,
> but instead takes them indirectly from a -iscsi arg. To make
> up -driver and -iscsi args, it takes the iSCSI
On Tue, Mar 22, 2016 at 11:33:38PM -0400, Jeff Cody wrote:
> Commit 'b8f45cdf7827e39f9a1e6cc446f5972cc6144237' switched VPC
> over to using blk_pwrite() instead of bdrv_pwrite_sync(). The
> return value of bdrv_pwrite_sync() was always 0 for success, and
> create_dynamic_disk() in one instance che
On 12 April 2016 at 17:18, Kevin Wolf wrote:
> The following changes since commit 42bb626f7ebc9197d2943b897a99e127315275ab:
>
> Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request'
> into staging (2016-04-12 09:34:52 +0100)
>
> are available in the git repository at:
>
>
>
I should also mention that the original command used will work if we
specify which cpu type to use:
qemu-system-ppc64 -m 256 \
-cpu POWER8 \
-display none -nographic \
-net nic -net user,net=10.0.0.0/8,host=10.0.0.1,hostfwd=tcp::-:22 \
-machine pseries \
-drive file=xenial-server-cl
On 13.04.2016 15:15, Michael S. Tsirkin wrote:
> On Wed, Apr 13, 2016 at 01:52:44PM +0200, Thomas Huth wrote:
>> The balloon code currently calls madvise() with TARGET_PAGE_SIZE
>> as length parameter, and an address which is directly based on
>> the page address supplied by the guest. Since the vi
On 2016-04-13 03:06, Peter Xu wrote:
> On Tue, Apr 12, 2016 at 08:39:21PM -0700, Jan Kiszka wrote:
>> On 2016-04-12 20:33, Peter Xu wrote:
>>> On Tue, Apr 12, 2016 at 08:39:02AM -0700, Jan Kiszka wrote:
On 2016-04-12 02:02, Peter Xu wrote:
>>>
>>> [...]
>>>
> Yes, I should consider other x
On Wed, Apr 13, 2016 at 10:59:35AM +0200, Markus Armbruster wrote:
> If we can protect them without
> complicating or breaking stuff, sure, why not. But not at all costs.
The stuff we break is precisely the stuff our warnings
say might break at any time. So since you believe users
might be relied
VIRTIO_INPUT_CFG_ABS_INFO was not implemented for pass-through input
devices. This patch follows the existing design and pre-fetches the
config for all absolute axes using EVIOCGABS at realize time.
Signed-off-by: Ladi Prosek
---
hw/input/virtio-input-host.c | 46
On 04/13/2016 06:38 AM, Pavel Borzenkov wrote:
>> I'm also starting to think that it is worth FIRST documenting an
>> extension for advertising block sizes, so that we can then couch
>> BLOCK_STATUS in those terms (a server MUST NOT subdivide status into
>> finer granularity than the advertised blo
On 2016-04-13 00:27, Peter Xu wrote:
> On Mon, Apr 11, 2016 at 03:32:18PM +0300, Michael S. Tsirkin wrote:
>> On Mon, Apr 11, 2016 at 05:19:10PM +0800, Peter Xu wrote:
>>> v2 changes:
>>> - patch 1
>>> - rename "int_remap" to "intr" in several places [Marcel]
>>> - remove "Intel" specific words
The iSCSI block driver has a very strange approach whereby it
does not accept options directly as part of the -drive arg,
but instead takes them indirectly from a -iscsi arg. To make
up -driver and -iscsi args, it takes the iSCSI target name
and uses that as an ID value for the -iscsi arg lookup.
On Tue, Apr 12, 2016 at 04:57:42PM +0200, Pino Toscano wrote:
> Hi,
>
> to overcome the limitations of the options handling [1], I'm planning
> to move more options for iSCSI also as block options, so it is possible
> to specify them with -drive.
>
> The only patch in this series is for initiator
Hi Jevon,
On Sun, 10 Apr 2016 14:55:55 +0800
Jevon Qiao wrote:
> Hi Greg,
>
> Thank you for spending time reviewing this patch.
> On 7/4/16 23:50, Greg Kurz wrote:
> > On Tue, 15 Mar 2016 00:02:48 +0800
> > Jevon Qiao wrote:
> >
> >> Ceph as a promising unified distributed storage system is
Eric Blake writes:
> Our existing input visitors were not very consistent on errors
> in a function taking 'TYPE **obj'. While all of them set '*obj'
Suggest to list the methods. I guess it's start_struct(),
start_alternate(), type_str(), type_any().
> to allocated storage on success, it was n
Thanks, you are right, this area is changed in patch #1 too. However, it was
not intended to be that way. Patch #1 should leave this function as-is, and the
entire change for this function should be in this patch. I will organize the
code as intended in the next version of the series. Yours, Ale
1 - 100 of 181 matches
Mail list logo
