On Wed, Feb 17, 2016 at 07:46:15AM +, Tian, Kevin wrote:
> > From: Neo Jia
> > Sent: Wednesday, February 17, 2016 3:26 PM
> >
> >
>
> >
> > If your most concern is having this kind of path doesn't provide enough
> > information of the virtual device, we can add more sysfs attributes within
> From: Neo Jia [mailto:c...@nvidia.com]
> Sent: Wednesday, February 17, 2016 3:32 PM
>
> On Wed, Feb 17, 2016 at 07:52:53AM +0100, Gerd Hoffmann wrote:
> > Hi,
> >
> > > The answer is simple, having a UUID as part of the device name will give
> > > you a
> > > unique sysfs path that will be op
> From: Neo Jia
> Sent: Wednesday, February 17, 2016 3:26 PM
>
>
> >
> > Qemu doesn't need to know the relation between virtual/physical devices at
> > all. It's just a path regardless of how vgpu name is created (either with
> > your
> > UUID proposal or my descriptive string proposal)
>
> No,
Hi Daniel,
Thank you for reviewing my code, please see my reply in-line.
On 15/2/16 17:17, Daniel P. Berrange wrote:
On Sun, Feb 14, 2016 at 01:06:40PM +0800, Jevon Qiao wrote:
diff --git a/configure b/configure
index 83b40fc..cecece7 100755
--- a/configure
+++ b/configure
@@ -1372,6 +1377,7 @@
On Wed, Feb 17, 2016 at 07:52:53AM +0100, Gerd Hoffmann wrote:
> Hi,
>
> > The answer is simple, having a UUID as part of the device name will give
> > you a
> > unique sysfs path that will be opened by QEMU.
>
> A descriptive name will work too, and I think it'll be easier to make
> those nam
On Wed, Feb 17, 2016 at 06:02:36AM +, Tian, Kevin wrote:
> > From: Neo Jia
> > Sent: Wednesday, February 17, 2016 1:38 PM
> > > > >
> > > > >
> > > >
> > > > Hi Kevin,
> > > >
> > > > The answer is simple, having a UUID as part of the device name will
> > > > give you a
> > > > unique sysfs pa
Hi Aneesh,
Thank you for reviewing my code, please see my reply in-line.
On 14/2/16 21:38, Aneesh Kumar K.V wrote:
Jevon Qiao writes:
The following patch is to fix alignment issue when host filesystem block
size
is larger than client msize.
Thanks,
Jevon
That is not the right format to send
Hi,
> The answer is simple, having a UUID as part of the device name will give you a
> unique sysfs path that will be opened by QEMU.
A descriptive name will work too, and I think it'll be easier to make
those names persistent because you don't have to store the uuids
somewhere to re-create the
Signed-off-by: Fam Zheng
---
scripts/kvm/kvm_stat | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat
index 3cf1181..517fbec 100755
--- a/scripts/kvm/kvm_stat
+++ b/scripts/kvm/kvm_stat
@@ -800,7 +800,7 @@ def check_access(options):
> From: Neo Jia
> Sent: Wednesday, February 17, 2016 1:38 PM
> > > >
> > > >
> > >
> > > Hi Kevin,
> > >
> > > The answer is simple, having a UUID as part of the device name will give
> > > you a
> > > unique sysfs path that will be opened by QEMU.
> > >
> > > vgpu-vendor-0 and vgpu-vendor-1 will
On Tue, Feb 16, 2016 at 10:09:43PM -0700, Eric Blake wrote:
> * PGP Signed by an unknown key
>
> On 02/16/2016 10:04 PM, Tian, Kevin wrote:
>
>
> ...rather than making readers scroll through 16k bytes of repetitions of
> the same things they saw earlier in the thread, but getting worse with
> ea
On Wed, Feb 17, 2016 at 05:04:31AM +, Tian, Kevin wrote:
> > From: Neo Jia
> > Sent: Wednesday, February 17, 2016 12:18 PM
> >
> > On Wed, Feb 17, 2016 at 03:31:24AM +, Tian, Kevin wrote:
> > > > From: Neo Jia [mailto:c...@nvidia.com]
> > > > Sent: Tuesday, February 16, 2016 4:49 PM
> > >
On 02/15/2016 01:54 PM, Jason Wang wrote:
On 02/04/2016 03:43 PM, Zhang Chen wrote:
From: ZhangChen
Using qtest qmp interface to implement following cases:
1) add/remove filter-mirror
2) add a filter-mirror then delete the netdev
3) add/remove more than one filter-mirrors
4) add more than o
On 02/16/2016 10:04 PM, Tian, Kevin wrote:
>> From: Neo Jia
[meta-comment]
...
On Wed, 2016-02-03 at 09:28 +0100, Gerd Hoffmann wrote:
> Hi,
>
>> Actually I have a long puzzle in this area. Definitely libvirt
>> will
>> use
UUI
> From: Neo Jia
> Sent: Wednesday, February 17, 2016 12:18 PM
>
> On Wed, Feb 17, 2016 at 03:31:24AM +, Tian, Kevin wrote:
> > > From: Neo Jia [mailto:c...@nvidia.com]
> > > Sent: Tuesday, February 16, 2016 4:49 PM
> > >
> > > On Tue, Feb 16, 2016 at 08:10:42AM +, Tian, Kevin wrote:
> > >
On 01/25/2016 10:04 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> For empty structs, such as the 'Abort' helper type used as part
>> of the 'transaction' command, we were emitting a no-op
>> visit_type_FOO_fields(). Optimize things to instead omit calls
>> for empty structs. Generated
Hi Peter,
I have access till
"PRD03-GENC-010952 Version 11.0" updated 18/04/15.
infocenter.arm.com has only SMMUv2 made public
Please let me know if there is a new version available
- to public.
- through channels, I have to work with my organizational contact to get
to the new one.
I am not
On Wed, Feb 17, 2016 at 03:31:24AM +, Tian, Kevin wrote:
> > From: Neo Jia [mailto:c...@nvidia.com]
> > Sent: Tuesday, February 16, 2016 4:49 PM
> >
> > On Tue, Feb 16, 2016 at 08:10:42AM +, Tian, Kevin wrote:
> > > > From: Neo Jia [mailto:c...@nvidia.com]
> > > > Sent: Tuesday, February 1
On 02/15/2016 03:06 PM, Zhang Chen wrote:
On 02/15/2016 01:23 PM, Jason Wang wrote:
On 02/04/2016 05:00 PM, Zhang Chen wrote:
On 02/04/2016 03:43 PM, Zhang Chen wrote:
From: ZhangChen
Filter-mirror is a netfilter plugin.
It gives qemu the ability to copy and mirror guest's
net packet.
> From: Neo Jia [mailto:c...@nvidia.com]
> Sent: Tuesday, February 16, 2016 4:49 PM
>
> On Tue, Feb 16, 2016 at 08:10:42AM +, Tian, Kevin wrote:
> > > From: Neo Jia [mailto:c...@nvidia.com]
> > > Sent: Tuesday, February 16, 2016 3:53 PM
> > >
> > > On Tue, Feb 16, 2016 at 07:40:47AM +, Tia
On Thu, 01/28 16:08, Gerd Hoffmann wrote:
> Actually fixes linux not finding virtio 1.0 device virtqueues after
> reboot. Which is new I think, any chance linux kernel virtio code
> became more strict in 4.3?
>
> Signed-off-by: Gerd Hoffmann
Reviewed-by: Fam Zheng
Tested-by: Fam Zheng
> ---
On Tue, 02/16 16:53, Paolo Bonzini wrote:
> The current implementation of bdrv_qed_drain can cause a double
> completion of a request.
>
> The problem is that bdrv_qed_drain calls qed_plug_allocating_write_reqs
> unconditionally, but this is not correct if an allocating write
> is queued. In this
On 02/16/2016 07:00 PM, Igor Mammedov wrote:
On Tue, 16 Feb 2016 02:35:41 +0800
Xiao Guangrong wrote:
On 02/16/2016 01:24 AM, Igor Mammedov wrote:
On Mon, 15 Feb 2016 23:53:13 +0800
Xiao Guangrong wrote:
On 02/15/2016 09:32 PM, Igor Mammedov wrote:
On Mon, 15 Feb 2016 13:45:59 +0200
"Mi
On Thu, Feb 11, 2016 at 05:06:00PM -0500, Gabriel L. Somlo wrote:
> Generate an ACPI DSDT node for fw_cfg on pc and arm guests.
>
> New since v7:
>
> - edited commit blurb on 3/5 to match updated content, i.e. that
> the ACPI node is now inserted into the DSDT (no longer the SSDT).
When we added support for a user-specified prefix for an enum
type (commit 351d36e), we forgot to teach the qapi-visit code
to honor that prefix in the case of using a prefixed enum as
the discriminator for a flat union. While there is still some
on-list debate on whether we want to keep prefixes,
On 02/16/2016 09:08 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> Empty unions serve no purpose, and while we compile with gcc
>> which permits them, strict C99 forbids them. We could inject
>> a dummy member (and in fact, we do for empty structs), but while
>
> gen_variants() injects
Hi! I have strange think, i'm try to run qemu with -qmp flag, when i'm
run qemu with -qmp tcp:localhost:,server,nowait inside linux
console all works fine and telnet gets qemu banner, but when i'm run
inside golang programm telnet connected but does not get banner.
qemu args identical.
the diff
On 16 February 2016 at 21:47, Jean-Christophe DUBOIS
wrote:
> In QEMU, other Cortex A9 (Versatilepb.c, Exynos, Zynq ...) are also setting
> has_el3 to false ...
So these generally are the "legacy" platforms which were
added before we ever had EL3 support in QEMU. For them it's hard
to turn the EL
Le 16/02/2016 22:06, Peter Maydell a écrit :
On 16 February 2016 at 20:49, Jean-Christophe DUBOIS
wrote:
Le 16/02/2016 16:31, Peter Maydell a écrit :
On 8 February 2016 at 22:08, Jean-Christophe Dubois
wrote:
+object_property_set_bool(OBJECT(&s->cpu[i]), false,
+
QEMU provides two fw_cfg files to support IGD. The first holds the
OpRegion data which holds the Video BIOS Table (VBT). This needs to
be copied into reserved memory and the address stored in the ASL
Storage register of the device at 0xFC offset in PCI config space.
The OpRegion is generally 8KB.
---
hw/vfio/common.c |2
hw/vfio/pci-quirks.c | 476 +
hw/vfio/pci.c | 68 ++
hw/vfio/pci.h |9 +
include/hw/vfio/vfio-common.h |2
trace-events |7 +
6 files ch
Wrong braces on the restore of the cached TCGv SV and V bit could lead to
a wrong PSW. While at this it removes unnecessary braces for the restore
of the cached TCGv AV and SAV bits.
Signed-off-by: Bastian Koppelmann
---
target-tricore/helper.c | 8
1 file changed, 4 insertions(+), 4 de
Devices like Intel graphics are known to not only have bad checksums,
but also the wrong device ID. This is not so surprising given that
the video BIOS is typically part of the system firmware image rather
that embedded into the device and needs to support any IGD device
installed into the system.
Signed-off-by: Alex Williamson
---
linux-headers/linux/vfio.h | 101 +++-
1 file changed, 99 insertions(+), 2 deletions(-)
diff --git a/linux-headers/linux/vfio.h b/linux-headers/linux/vfio.h
index aa276bc..759b850 100644
--- a/linux-headers/linux/vfio.h
This could be setup later by device specific code, such as IGD
initialization.
Signed-off-by: Alex Williamson
---
hw/vfio/pci.c | 82 +
hw/vfio/pci.h |2 +
2 files changed, 50 insertions(+), 34 deletions(-)
diff --git a/hw/vfio/pci.c
The sparse mmap capability in a vfio region info allows vfio to tell
us which sub-areas of a region may be mmap'd. Thus rather than
assuming a single mmap covers the entire region and later frobbing it
ourselves for things like the PCI MSI-X vector table, we can read that
directly from vfio.
Sign
In preparation for supporting capability chains on regions, wrap
ioctl(VFIO_DEVICE_GET_REGION_INFO) so we don't duplicate the code for
each caller.
Signed-off-by: Alex Williamson
---
hw/vfio/common.c | 18 +
hw/vfio/pci.c | 81 +---
Match common vfio code with setup, exit, and finalize functions for
BAR, quirk, and VGA management. VGA is also changed to dynamic
allocation to match the other MemoryRegions.
Signed-off-by: Alex Williamson
---
hw/vfio/pci-quirks.c | 38 -
hw/vfio/pci.c| 114 +
Both platform and PCI vfio drivers create a "slow", I/O memory region
with one or more mmap memory regions overlayed when supported by the
device. Generalize this to a set of common helpers in the core that
pulls the region info from vfio, fills the region data, configures
slow mapping, and adds he
vfio-pci currently requires a host= parameter, which comes in the
form of a PCI address in [domain:] notation. We
expect to find a matching entry in sysfs for that under
/sys/bus/pci/devices/. vfio-platform takes a similar approach, but
defines the host= parameter to be a string, which can be mat
v3:
Quite a bit of restructuring, functional differences include exposing
another fw_cfg file to indicate the size of the stolen memory region.
We really have no need to copy anything into stolen memory, so while
we tell SeaBIOS about it via a fw_cfg file, the data pointer is NULL
so it can't be r
On 12.02.2016 17:33, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> The various load/store variants under disas_ldst_reg can all reuse the
> same decoding for opc, size, rt and is_vector.
>
> This patch unifies the decoding in preparation for generating
> instruction syndromes for data a
On 12.02.2016 17:33, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> Use extract32 instead of open coding the bit masking when decoding
> is_signed and is_extended. This streamlines the decoding with some
> of the other ldst variants.
>
> No functional change.
>
> Signed-off-by: Edgar E.
On 16 February 2016 at 20:49, Jean-Christophe DUBOIS
wrote:
> Le 16/02/2016 16:31, Peter Maydell a écrit :
>> On 8 February 2016 at 22:08, Jean-Christophe Dubois
>> wrote:
>>> +object_property_set_bool(OBJECT(&s->cpu[i]), false,
>>> + "has_el3", &error_abor
Eric Blake writes:
> On 02/16/2016 10:03 AM, Markus Armbruster wrote:
>> Eric Blake writes:
>>
>>> Right now, we emit the branches of union types as a boxed pointer,
>>> and it suffices to have a forward declaration of the type. However,
>>> a future patch will swap things to directly use the
The only remaining users of machine_init() only call
qemu_add_opts(). Rename machine_init() to opts_init() and move it
closer to the qemu_add_opts() calls on vl.c.
Cc: "Michael S. Tsirkin"
Cc: Igor Mammedov
Cc: Gerd Hoffmann
Signed-off-by: Eduardo Habkost
---
fsdev/qemu-fsdev-opts.c | 2 +-
h
machine_init() will be gone, but we don't need it if we just
initialize the channel_subsys fields statically.
Cc: Cornelia Huck
Cc: Christian Borntraeger
Cc: Richard Henderson
Cc: Alexander Graf
Signed-off-by: Eduardo Habkost
---
hw/s390x/css.c | 22 +-
1 file changed, 9
There's no need to use g_malloc0() to allocate the channel_subsys
struct, just use a static variable.
Cc: Cornelia Huck
Cc: Christian Borntraeger
Cc: Richard Henderson
Cc: Alexander Graf
Signed-off-by: Eduardo Habkost
---
hw/s390x/css.c | 177 -
There are currently three types of users of machine_init():
* type_register*() callers
* The channel_subsys initialization of at hw/s390x/css.c
* qemu_add_opts() callers
This series:
* Changes type_register*() callers to use type_init()
* Changes s390x/css to simply initialize channel_subsys field
Change all machine_init() users that simply call type_register*()
to use type_init().
Cc: Evgeny Voevodin
Cc: Maksim Kozlov
Cc: Igor Mitsyanko
Cc: Dmitry Solodkiy
Cc: Peter Maydell
Cc: Rob Herring
Cc: Andrzej Zaborowski
Cc: Michael Walle
Cc: "Hervé Poussineau"
Cc: Aurelien Jarno
Cc: Leon
Le 16/02/2016 16:31, Peter Maydell a écrit :
On 8 February 2016 at 22:08, Jean-Christophe Dubois
wrote:
For now we only support the following devices:
* up to 4 Cortex A9 cores
* A9 MPCORE (SCU, GIC, TWD)
* 5 i.MX UARTs
* 2 EPIT timers
* 1 GPT timer
* 3 I2C controllers
* 7 GPIO controllers
* 6
Eduardo Habkost writes:
> This fixes the following bugs in error reporting:
>
> $ qemu-system-x86_64 -icount rr=x -vnc :0
> qemu-system-x86_64: -vnc :0: Invalid icount rr option: x
>
> $ qemu-system-x86_64 -m size= -vnc :0
> qemu-system-x86_64: -vnc :0: missing 'size' option value
>
> The
Laszlo Ersek writes:
> On 02/16/16 15:57, Markus Armbruster wrote:
>> We set machine_class to the default first, and update it to the real
>> one later. Any use of machine_class in between is almost certainly
>> wrong. Set it once and for all instead.
>>
>> Signed-off-by: Markus Armbruster
>>
Marcel Apfelbaum writes:
> On 02/16/2016 04:57 PM, Markus Armbruster wrote:
>> We set machine_class to the default first, and update it to the real
>> one later. Any use of machine_class in between is almost certainly
>> wrong. Set it once and for all instead.
>>
>> Signed-off-by: Markus Armbru
On 02/16/2016 12:07 PM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> There's no reason to do two malloc's for an alternate type visiting
>> a QAPI struct; let's just inline the struct directly as the C union
>> branch of the struct.
>>
>> Surprisingly, no clients were actually using the str
On Tue, Feb 16, 2016 at 05:28:58PM +, Peter Maydell wrote:
> The current documentation of chardev mux=on is rather brief and opaque;
> expand it to hopefully be a bit more helpful.
>
> Signed-off-by: Peter Maydell
> ---
> There was some discussion on #qemu yesterday evening about multiplexing
First, I'd say that if you are converting an image over to use on
Hyper-V, you would probably be better served using the VHDX format
(completely different from VHD) - it is the newer format (and completely
different from VHD), and is supported by QEMU as well. It is better
defined and more consist
On 12 February 2016 at 14:34, Edgar E. Iglesias
wrote:
> From: "Edgar E. Iglesias"
>
> Add support for generating the instruction syndrome for Data Aborts.
> These syndromes are used by hypervisors for example to trap and emulate
> memory accesses.
>
> We save the decoded data out-of-band with th
On 12 February 2016 at 14:34, Edgar E. Iglesias
wrote:
> From: "Edgar E. Iglesias"
>
> Add the ARMInsnSyndrome type including helper functions to
> encode and decode it into an u32. This is in preparation for
> Instruction Syndrome generation for Data Aborts.
>
> No functional change.
I find thi
Eric Blake writes:
> There's no reason to do two malloc's for an alternate type visiting
> a QAPI struct; let's just inline the struct directly as the C union
> branch of the struct.
>
> Surprisingly, no clients were actually using the struct member prior
> to this patch; some testsuite coverage
On 07.10.2015 02:01, John Snow wrote:
On 09/05/2015 12:43 PM, Vladimir Sementsov-Ogievskiy wrote:
This function loads block dirty bitmap from qcow2.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-dirty-bitmap.c | 155 +
block/qcow2.c
On 12.02.2016 17:33, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> Signed-off-by: Edgar E. Iglesias
> ---
> target-arm/internals.h | 4 +++-
> target-arm/op_helper.c | 6 --
> 2 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/target-arm/internals.h b/target-arm/int
Hello Gerd,
+-- On Tue, 16 Feb 2016, Gerd Hoffmann wrote --+
| Moves up the check so it is done for every control xfer. Good.
...
| Why this is needed? All control transfers go through do_token_setup
| first, so with the check moved in do_token_setup we should never ever
| trigger it here ..
From: Prasad J Pandit
When processing remote NDIS control message packets,
the USB Net device emulator uses a fixed length(4096) data buffer.
The incoming informationBufferOffset & Length combination could
overflow and cross that range. Check control message buffer
offsets and length to avoid it.
From: Prasad J Pandit
Hello,
When processing remote NDIS control message packets, the USB Net
device emulator uses a fixed length(4096) data buffer. The incoming
packet length could exceed that OR informationBufferOffset & Length
combination could overflow and cross that range. These two patches
From: Prasad J Pandit
When processing remote NDIS control message packets, the USB Net
device emulator uses a fixed length(4096) data buffer. The incoming
packet length could exceed this limit. Add a check to avoid it.
Signed-off-by: Prasad J Pandit
---
hw/usb/core.c | 18 +-
1
On 07.10.2015 00:27, John Snow wrote:
On 09/05/2015 12:43 PM, Vladimir Sementsov-Ogievskiy wrote:
Adds qcow2_read_dirty_bitmaps, reading Dirty Bitmap Directory as
specified in docs/specs/qcow2.txt
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-dirty-bitmap.c | 155 +
On 1 February 2016 at 13:51, Eric Auger wrote:
> This patch allows the instantiation of the vfio-amd-xgbe device
> from the QEMU command line (-device vfio-amd-xgbe,host="").
>
> The guest is exposed with a device tree node that combines the description
> of both XGBE and PHY (representation suppo
On 1 February 2016 at 13:51, Eric Auger wrote:
> This series allows to set up AMD XGBE passthrough. This was tested on AMD
> Seattle.
>
> The first upstreamed device supporting KVM platform passthrough was the
> Calxeda Midway XGMAC. Compared to this latter, the XGBE XGMAC exposes a
> much more co
On 1 February 2016 at 13:51, Eric Auger wrote:
> qemu_fdt_setprop asserts in case of error hence no need to check
> the returned value.
>
> Signed-off-by: Eric Auger
>
Reviewed-by: Peter Maydell
thanks
-- PMM
On 1 February 2016 at 13:51, Eric Auger wrote:
> This new helper routine returns a NULL terminated array of
> node paths matching a node name and a compat string.
>
> Signed-off-by: Eric Auger
Reviewed-by: Peter Maydell
thanks
-- PMM
On 1 February 2016 at 13:51, Eric Auger wrote:
> This function returns the host device tree blob from sysfs
> (/proc/device-tree). It uses a recursive function inspired
> from dtc read_fstree.
>
> Signed-off-by: Eric Auger
Reviewed-by: Peter Maydell
thanks
-- PMM
If you create a subformat option I would humbly recommend focusing on
Hyper-V and Azure compat, and then create an option that enforces the
legacy behavior with your patch. This is essentially what some Linux
distros have started to do.
--
You received this bug notification because you are a mem
On 16 February 2016 at 16:34, Paolo Bonzini wrote:
> The following changes since commit 80b5d6bfc1280fa06e2514a414690c0e5b4b514b:
>
> Merge remote-tracking branch 'remotes/rth/tags/pull-i386-20160215' into
> staging (2016-02-15 11:45:11 +)
>
> are available in the git repository at:
>
> g
On 29 January 2016 at 16:53, Eric Auger wrote:
> This series enables KVM PCI/MSI passthrough with mach-virt.
>
> A new memory region type is introduced (reserved iova). On
> vfio_listener_region_add this IOVA region is registered to the kernel with
> VFIO_IOMMU_MAP_DMA (using the new VFIO_DMA_MAP_
On 29 January 2016 at 16:53, Eric Auger wrote:
> Registers a 16x64kB reserved iova region. Currently this iova
> region is used by the host kernel to map host MSI controller frames
> (GICv2m, GITS_TRANSLATER). The host kernel needs this iova window
> since it cannot program the PCIe device with MS
On 29 January 2016 at 16:53, Eric Auger wrote:
> The platform bus currently is used to map dynamically instantiable
> platform device MMIO regions. The platform bus also can be seen as a
> pool of free guest physical addresses. We would like to use that pool
> to allocate a contiguous reserved IOV
On 29 January 2016 at 16:53, Eric Auger wrote:
> This patch stores information about assigned legacy interrupt numbers in
> GPEX host structure.
> This is used during GPEX INTx number determination from a pin during
> INTx routing.
>
> Signed-off-by: Pranavkumar Sawargaonkar
> Signed-off-by: Tush
Convert the pxa2xx_mmci device to be a sysbus device.
In this commit we only change the device itself, and leave
the interface to the SD card using the old non-SDBus APIs.
Signed-off-by: Peter Maydell
Reviewed-by: Peter Crosthwaite
---
hw/sd/pxa2xx_mmci.c | 74 +
Update the SDHCI code to use the new SDBus APIs.
This commit introduces the new command line options required
to connect a disk to sdhci-pci:
-device sdhci-pci -drive id=mydrive,[...] -device sd,drive=mydrive
Signed-off-by: Peter Maydell
---
hw/sd/sdhci.c | 97
The following commits will remove support for the old sdhci-pci
command line syntax using the x-drive property:
-device sdhci-pci,x-drive=mydrive -drive id=mydrive,[...]
and replace it with an explicit sd device:
-device sdhci-pci -drive id=mydrive,[...] -device sd,drive=mydrive
(This is OK beca
Move the creation of the SD card device from the sdhci_sysbus
device itself into the boards that create these devices.
This allows us to remove the cannot_instantiate_with_device_add
notation because we no longer call drive_get_next in the device
model.
Signed-off-by: Peter Maydell
---
hw/arm/xi
Now the PXA2xx MMCI device is QOMified itself, we can
update it to use the SDBus APIs to talk to the SD card.
Signed-off-by: Peter Maydell
---
hw/sd/pxa2xx_mmci.c | 80 +++--
1 file changed, 66 insertions(+), 14 deletions(-)
diff --git a/hw/sd/pxa
There is no point in manually iterating through the bdrv_states list
when there is bdrv_next().
Signed-off-by: Max Reitz
---
block.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/block.c b/block.c
index f3597ac..69fc696 100644
--- a/block.c
+++ b/block.c
@@ -33
Convert the pxa2xx_mmci device from manual save/load
functions to a VMStateDescription structure.
This is a migration compatibility break.
Signed-off-by: Peter Maydell
Reviewed-by: Peter Crosthwaite
---
hw/sd/pxa2xx_mmci.c | 156 +---
1 file chan
Signed-off-by: Max Reitz
---
block.c | 31 +++
blockdev.c| 7 ---
include/block/block.h | 1 -
include/block/block_int.h | 4
4 files changed, 3 insertions(+), 40 deletions(-)
diff --git a/block.c b/block.c
index 69fc6
This series attempts to QOMify sd.c (the actual SD card model),
including a proper QOM bus between the controller and the card.
TLDR: just a rebase and fix of #includes so it builds on current
master. Still need review on patches 4, 5, 6, and 8.
This series removes the experimental x-drive prope
This function iterates over all BDSs attached to a BB. We are going to
need it when rewriting bdrv_next() so it no longer uses bdrv_states.
Signed-off-by: Max Reitz
---
block/block-backend.c | 24
include/sysemu/block-backend.h | 1 +
2 files changed, 25 insert
Turn the SD card into a QOM device.
This conversion only changes the device itself; the various
functions which are effectively methods on the device are not
touched at this point.
Signed-off-by: Peter Maydell
Reviewed-by: Peter Crosthwaite
---
hw/sd/sd.c | 99 ++
Add a reset function to the pxa2xx_mmci device; previously it had
no handling for system reset at all.
Signed-off-by: Peter Maydell
Reviewed-by: Peter Crosthwaite
---
hw/sd/pxa2xx_mmci.c | 30 ++
1 file changed, 30 insertions(+)
diff --git a/hw/sd/pxa2xx_mmci.c b/hw
The monitor does hold references to some BlockBackends so it should have
a list of those BBs; blk_backends is a different list, as it contains
references to all BBs (after a follow-up patch, that is), and that
should not be changed because we do need such a list.
monitor_remove_blk() is idempotent
Move bdrv_commit_all() and bdrv_flush_all() to the BlockBackend level.
Signed-off-by: Max Reitz
---
block.c | 20
block/block-backend.c | 44 +++
block/io.c| 20
Add a QOM bus for SD cards to plug in to.
Note that since sd_enable() is used only by one board and there
only as part of a broken implementation, we do not provide it in
the SDBus API (but instead add a warning comment about the old
function). Whoever converts OMAP and the nseries boards to QOM
w
Instead of using the bdrv_states list, iterate over all the
BlockDriverStates attached to BlockBackends, and over all the
monitor-owned BDSs afterwards (except for those attached to a BB).
Signed-off-by: Max Reitz
---
block.c | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(
Replace bdrv_commmit_all() and bdrv_flush_all() by their BlockBackend
equivalents.
Signed-off-by: Max Reitz
---
blockdev.c | 2 +-
cpus.c | 5 +++--
qemu-char.c | 3 ++-
3 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 8eff47d..46cd8a9 100644
---
This function first removed the BlockBackend from the blk_backends list
and cleared its name so it would no longer be found by blk_name(); since
blk_next() now iterates through monitor_block_backends (which the BB is
removed from in hmp_drive_del()), this is no longer necessary.
Second, bdrv_make_
Convert the sd_reset() function into a proper Device reset method.
Signed-off-by: Peter Maydell
Reviewed-by: Alistair Francis
Reviewed-by: Peter Crosthwaite
---
hw/sd/sd.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index 1681728..edd4
Signed-off-by: Max Reitz
---
monitor.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/monitor.c b/monitor.c
index 73eac17..7620e20 100644
--- a/monitor.c
+++ b/monitor.c
@@ -42,6 +42,7 @@
#include "ui/console.h"
#include "ui/input.h"
#include "sysemu/blockdev.h"
+#i
There may be BlockBackends which are not returned by blk_by_name(), but
do exist and have a name. blk_name_taken() allows testing whether a
specific name is in use already, independent of whether the BlockBackend
with that name is accessible through blk_by_name().
Signed-off-by: Max Reitz
---
bl
Later, we will remove bdrv_commit_all() and move its contents here, and
in order to replace bdrv_commit_all() calls by calls to blk_commit_all()
before doing so, we need to add it as an alias now.
Signed-off-by: Max Reitz
---
block/block-backend.c | 5 +
include/sysemu/block-backend
1 - 100 of 382 matches
Mail list logo
