Re: [Qemu-devel] [PATCH v2] arm64: kernel: fix architected PMU registers unconditional access

2016-01-22 Thread Guenter Roeck
On 01/13/2016 06:50 AM, Lorenzo Pieralisi wrote: The Performance Monitors extension is an optional feature of the AArch64 architecture, therefore, in order to access Performance Monitors registers safely, the kernel should detect the architected PMU unit presence through the ID_AA64DFR0_EL1 regis

[Qemu-devel] [PATCH] cuda.c: return error for unknown commands

2016-01-22 Thread Alyssa Milburn
This avoids MacsBug hanging at startup in the absence of ADB mouse input, by replying with an error (which is also what MOL does) when it sends an unknown command (0x1c). Signed-off-by: Alyssa Milburn --- hw/misc/macio/cuda.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/misc/macio

Re: [Qemu-devel] [PATCH v7 15/15] iotests: Add "qemu-img map" test for VMDK extents

2016-01-22 Thread Max Reitz
On 22.01.2016 04:06, Fam Zheng wrote: > Reviewed-by: Eric Blake > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/059 | 10 ++ > tests/qemu-iotests/059.out | 38 ++ > 2 files changed, 48 insertions(+) > > diff -

Re: [Qemu-devel] [PATCH v7 01/15] block: Add "file" output parameter to block status query functions

2016-01-22 Thread Max Reitz
On 22.01.2016 04:06, Fam Zheng wrote: > The added parameter can be used to return the BDS pointer which the > valid offset is referring to. Its value should be ignored unless > BDRV_BLOCK_OFFSET_VALID in ret is set. > > Until block drivers fill in the right value, let's clear it explicitly > right

[Qemu-devel] [PATCH v3 3/4] Revert "hw/block/fdc: Implement tray status"

2016-01-22 Thread Max Reitz
This reverts the changes that commit 2e1280e8ff95b3145bc6262accc9d447718e5318 applied to hw/block/fdc.c. That commit changed tests/fdc-test.c, too, because after it, one less TRAY_MOVED event would be emitted when executing 'change' on an empty drive. However, now, no TRAY_MOVED events will be emi

[Qemu-devel] [PATCH v3 2/4] blockdev: Fix 'change' for slot devices

2016-01-22 Thread Max Reitz
'change' and related operations did not work when used on guest devices featuring removable media but no actual tray, because blk_dev_is_tray_open() always returned false for them and the blockdev-{insert,remove}-medium commands required it to return true. Fix this by making blockdev-{insert,remov

[Qemu-devel] [PATCH v3 4/4] block/qapi: Emit tray_open only if there is a tray

2016-01-22 Thread Max Reitz
Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Alberto Garcia --- block/qapi.c | 2 +- qapi/block-core.json | 4 ++-- tests/qemu-iotests/067.out | 4 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/block/qapi.c b/block/qapi.c index a49c118.

[Qemu-devel] [PATCH v3 0/4] blockdev: Fix 'change' for slot devices

2016-01-22 Thread Max Reitz
The series "BlockBackend and media" intended all block devices with removable media to implement a tray model; if the devices does not have a tray, it should emulate one. While this may make sense from a technical perspective (blockdev-*-tray are guest device controlling operations, invoking blk_d

[Qemu-devel] [PATCH v3 1/4] block: Add blk_dev_has_tray()

2016-01-22 Thread Max Reitz
Pull out the check whether a block device has a tray from blk_dev_is_tray_open() into its own function so both attributes (whether there is a tray vs. whether that tray is open) can be queried independently. Cc: qemu-stable Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Alberto G

Re: [Qemu-devel] [RFC PATCH 0/2] Early release of -drive QemuOpts

2016-01-22 Thread Max Reitz
On 22.01.2016 15:01, Paolo Bonzini wrote: > > > On 08/01/2016 18:37, Paolo Bonzini wrote: >> In short, this patch gets rid of blockdev_mark_auto_del and >> blockdev_auto_del. >> >> With these patches, it is possible to create a new -drive with the same >> id as soon as the DEVICE_DELETED event is

Re: [Qemu-devel] [PATCH v2 2/4] blockdev: Fix 'change' for slot devices

2016-01-22 Thread Max Reitz
On 22.01.2016 10:58, Alberto Garcia wrote: > On Wed 20 Jan 2016 07:29:19 PM CET, Max Reitz wrote: >> @@ -2424,6 +2442,15 @@ static void qmp_blockdev_insert_anon_medium(const >> char *device, >> >> blk_insert_bs(blk, bs); >> >> +if (!blk_dev_has_tray(blk)) { >> +/* For tray-les

Re: [Qemu-devel] [PATCH v3] vfio/common: Check iova with limit not with size

2016-01-22 Thread Alex Williamson
On Fri, 2016-01-22 at 15:14 -0700, Alex Williamson wrote: > On Thu, 2016-01-21 at 14:15 +0100, Pierre Morel wrote: > > > > On 01/20/2016 04:46 PM, Alex Williamson wrote: > > > On Wed, 2016-01-20 at 16:14 +0100, Pierre Morel wrote: > > > > On 01/12/2016 07:16 PM, Alex Williamson wrote: > > > > > On

Re: [Qemu-devel] [PATCH v3] vfio/common: Check iova with limit not with size

2016-01-22 Thread Alex Williamson
On Thu, 2016-01-21 at 14:15 +0100, Pierre Morel wrote: > > On 01/20/2016 04:46 PM, Alex Williamson wrote: > > On Wed, 2016-01-20 at 16:14 +0100, Pierre Morel wrote: > > > On 01/12/2016 07:16 PM, Alex Williamson wrote: > > > > On Tue, 2016-01-12 at 16:11 +0100, Pierre Morel wrote: > > > > > In vfio

Re: [Qemu-devel] [PATCH] qmp: add query-block-dirty-bitmap

2016-01-22 Thread Denis V. Lunev
On 01/22/2016 08:07 PM, Vladimir Sementsov-Ogievskiy wrote: Add qmp command to query dirty bitmap. This is needed for external backup. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 41 blockdev.c| 21 +

Re: [Qemu-devel] [PATCH] qmp: add query-block-dirty-bitmap

2016-01-22 Thread Denis V. Lunev
On 01/22/2016 08:28 PM, Vladimir Sementsov-Ogievskiy wrote: On 22.01.2016 20:22, Denis V. Lunev wrote: On 01/22/2016 08:07 PM, Vladimir Sementsov-Ogievskiy wrote: { 'command': 'query-block', 'returns': ['BlockInfo'] } +## +# @BlockDirtyRegion: +# +# Region in bytes. +# +# @start: first byte

Re: [Qemu-devel] [PATCH v5 10/12] fdc: rework pick_geometry

2016-01-22 Thread John Snow
On 01/22/2016 03:51 PM, John Snow wrote: > This one is the crazy one. > > fd_revalidate currently uses pick_geometry to tell if the diskette > geometry has changed upon an eject/insert event, but it won't allow us > to insert a 1.44MB diskette into a 2.88MB drive. This is inflexible. > > The ne

[Qemu-devel] [PATCH v5 09/12] fdc: add physical disk sizes

2016-01-22 Thread John Snow
2.88MB capable drives can accept 1.44MB floppies, for instance. To rework the pick_geometry function, we need to know if our current drive can even accept the type of disks we're considering. NB: This allows us to distinguish between all of the "total sectors" collisions between 1.20MB and 1.44MB

[Qemu-devel] [PATCH v5 10/12] fdc: rework pick_geometry

2016-01-22 Thread John Snow
This one is the crazy one. fd_revalidate currently uses pick_geometry to tell if the diskette geometry has changed upon an eject/insert event, but it won't allow us to insert a 1.44MB diskette into a 2.88MB drive. This is inflexible. The new algorithm applies a new heuristic to guessing disk geom

[Qemu-devel] [PATCH v5 07/12] fdc: Add fallback option

2016-01-22 Thread John Snow
Currently, QEMU chooses a drive type automatically based on the inserted media. If there is no disk inserted, it chooses a 1.44MB drive type. Change this behavior to be configurable, but leave it defaulted to 1.44. This is not earnestly intended to be used by a user or a management library, but r

[Qemu-devel] [PATCH v5 11/12] qtest/fdc: Support for 2.88MB drives

2016-01-22 Thread John Snow
The old test assumes a 1.44MB drive. Assert that the QEMU default drive is now either 1.44 or 2.88. Reviewed-by: Eric Blake Signed-off-by: John Snow --- tests/fdc-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fdc-test.c b/tests/fdc-test.c index b5a4696..526d45

[Qemu-devel] [PATCH v5 12/12] fdc: change auto fallback drive for ISA FDC to 288

2016-01-22 Thread John Snow
The 2.88 drive is more suitable as a default because it can still read 1.44 images correctly, but the reverse is not true. Since there exist virtio-win drivers that are shipped on 2.88 floppy images, this patch will allow VMs booted without a floppy disk inserted to later insert a 2.88MB floppy an

[Qemu-devel] [PATCH v5 06/12] fdc: add pick_drive

2016-01-22 Thread John Snow
Split apart pick_geometry by creating a pick_drive routine that will only ever called during device bring-up instead of relying on pick_geometry to be used in both cases. With this change, the drive field is changed to be 'write once'. It is not altered after the initialization routines exit. med

[Qemu-devel] [PATCH v5 08/12] fdc: add drive type option

2016-01-22 Thread John Snow
This patch adds a new explicit Floppy Drive Type option. The existing behavior in QEMU is to automatically guess a drive type based on the media inserted, or if a diskette is not present, arbitrarily assign one. This behavior can be described as "auto." This patch adds the option to pick an explic

[Qemu-devel] [PATCH v5 03/12] fdc: add drive type qapi enum

2016-01-22 Thread John Snow
Change the floppy drive type to a QAPI enum type, to allow us to specify the floppy drive type from the CLI in a forthcoming patch. Reviewed-by: Eric Blake Signed-off-by: John Snow --- hw/block/fdc.c | 80 +- hw/i386/pc.c | 17 ++

[Qemu-devel] [PATCH v5 04/12] fdc: add disk field

2016-01-22 Thread John Snow
Currently, 'drive' is used both to represent the current diskette type as well as the current drive type. This patch adds a 'disk' field that is updated explicitly to match the type of the disk. As of this patch, disk and drive are always the same, but forthcoming patches to change the behavior o

[Qemu-devel] [PATCH v5 02/12] fdc: reduce number of pick_geometry arguments

2016-01-22 Thread John Snow
Modify this function to operate directly on FDrive objects instead of unpacking and passing all of those parameters manually. Reduces the complexity in the caller and reduces the number of args to just one. Reviewed-by: Eric Blake Signed-off-by: John Snow --- hw/block/fdc.c | 50 +++

[Qemu-devel] [PATCH v5 00/12] fdc: fix 2.88mb floppy diskette support

2016-01-22 Thread John Snow
Yes, it's been broken for ten years. No, it's not a CVE. The problem is that QEMU doesn't have a configuration option for the type of floppy drive you want. It determines that based on the type of diskette inserted at boot time. If you don't insert one, it always chooses a 1.44MB type. If you wa

[Qemu-devel] [PATCH v5 05/12] fdc: Throw an assertion on misconfigured fd_formats table

2016-01-22 Thread John Snow
pick_geometry is a convoluted function that makes it difficult to tell at a glance what QEMU's current behavior for choosing a floppy drive type is when it can't quite identify the diskette. The code iterates over all entries in the candidate geometry table ("fd_formats") and if our specific drive

[Qemu-devel] [PATCH v5 01/12] fdc: move pick_geometry

2016-01-22 Thread John Snow
Code motion: I want to refactor this function to work with FDrive directly, so shuffle it below that definition. Reviewed-by: Eric Blake Signed-off-by: John Snow --- hw/block/fdc.c | 90 +- 1 file changed, 45 insertions(+), 45 deletions(-)

Re: [Qemu-devel] [PATCH v4] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties

2016-01-22 Thread Valentin Rakush
Hi Eric, hi Daniel, Re dashes in the command name AFAICC, the QOM related command in HMP use dash "-". For example, qom-list and qom-set. If we will change dash "-" to underscore "_" then qom_type_prop_list will be consistent with old HMP commands (created before year 2013), but will _not_ be con

Re: [Qemu-devel] [PATCH v9 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-01-22 Thread Dr. David Alan Gilbert
* Alberto Garcia (be...@igalia.com) wrote: > On Thu 21 Jan 2016 05:58:42 PM CET, Eric Blake wrote: > In general, what do you do to make sure that the data in a new Quorum > child is consistent with that of the rest of the array? > >>> > >>> Quorum can have more than one child when it sta

Re: [Qemu-devel] [PATCH v9 26/37] qapi: Simplify excess input reporting in input visitors

2016-01-22 Thread Eric Blake
On 01/22/2016 12:24 PM, Markus Armbruster wrote: > Eric Blake writes: > >> When reporting that an unvisited member remains at the end of an >> input visit for a struct, we were using g_hash_table_find() >> coupled with a callback function that always returns true, to >> locate an arbitrary member

[Qemu-devel] COLO: how to flip a secondary to a primary?

2016-01-22 Thread Dr. David Alan Gilbert
Hi, I've been looking at what's needed to add a new secondary after a primary failed; from the block side it doesn't look as hard as I'd expected, perhaps you can tell me if I'm missing something! The normal primary setup is: quorum Real disk nbd client The normal secondary setu

Re: [Qemu-devel] [PATCH v9 26/37] qapi: Simplify excess input reporting in input visitors

2016-01-22 Thread Markus Armbruster
Eric Blake writes: > When reporting that an unvisited member remains at the end of an > input visit for a struct, we were using g_hash_table_find() > coupled with a callback function that always returns true, to > locate an arbitrary member of the hash table. But if all we > need is an arbitrary

Re: [Qemu-devel] [PATCH v9 25/37] spapr_drc: Expose 'null' in qom-get when there is no fdt

2016-01-22 Thread Markus Armbruster
Eric Blake writes: > Now that the QMP output visitor supports an explicit null > output, we should utilize it to make it easier to diagnose > the difference between a missing fdt vs. a present-but-empty > one. Please spell out that we change the value from {} to null. > > (Note that this revert

Re: [Qemu-devel] [PATCH] hw/pci-host/uninorth.c: Add support for Apple's PCI bridge register 0x48

2016-01-22 Thread Mark Cave-Ayland
On 22/01/16 18:26, Programmingkid wrote: > On Jan 22, 2016, at 11:46 AM, Mark Cave-Ayland wrote: > >> On 22/01/16 16:09, Programmingkid wrote: >> >>> Apple has custom PCI bridge registers that are not a part of any known >>> standard. This patch implements register 0x48. With this patch the >>>

Re: [Qemu-devel] [PATCH v9 24/37] qmp: Tighten output visitor rules

2016-01-22 Thread Markus Armbruster
Eric Blake writes: > Add a new qmp_output_visitor_reset(), which must be called before > reusing an exising QmpOutputVisitor on a new root object. Tighten > assertions to require that qmp_output_get_qobject() can only be > called after pairing a visit_end_* for every visit_start_* (rather > than

Re: [Qemu-devel] [PATCH v4] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties

2016-01-22 Thread Eric Blake
On 01/22/2016 05:15 AM, Valentin Rakush wrote: > This patch adds support for qom-type-prop-list command to list object > class properties. A later patch will use this functionality to > implement x86_64-cpu properties. > > Signed-off-by: Valentin Rakush > Cc: Luiz Capitulino > Cc: Eric Blake >

Re: [Qemu-devel] [PATCH] qmp: add query-block-dirty-bitmap

2016-01-22 Thread Eric Blake
On 01/22/2016 10:07 AM, Vladimir Sementsov-Ogievskiy wrote: > Add qmp command to query dirty bitmap. This is needed for external > backup. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block.c | 41 > blockdev.c| 21 +++

Re: [Qemu-devel] [PATCH] hw/pci-host/uninorth.c: Add support for Apple's PCI bridge register 0x48

2016-01-22 Thread Programmingkid
On Jan 22, 2016, at 11:46 AM, Mark Cave-Ayland wrote: > On 22/01/16 16:09, Programmingkid wrote: > >> Apple has custom PCI bridge registers that are not a part of any known >> standard. This patch implements register 0x48. With this patch the >> AppleMacRiscPCI kernel extension no longer print

Re: [Qemu-devel] [PATCH] char: fix parameter name / type in BSD codepath

2016-01-22 Thread Peter Maydell
You typoed the qemu-devel address... thanks -- PMM On 22 January 2016 at 17:35, Daniel P. Berrange wrote: > The BSD impl of qemu_chr_open_pp_fd had mis-declared > its parameter type as ChardevBackend instead of > ChardevCommon. It had also mistakenly used the variable > name 'common' instead of

Re: [Qemu-devel] [PATCH] qmp: add query-block-dirty-bitmap

2016-01-22 Thread Vladimir Sementsov-Ogievskiy
On 22.01.2016 20:22, Denis V. Lunev wrote: On 01/22/2016 08:07 PM, Vladimir Sementsov-Ogievskiy wrote: Add qmp command to query dirty bitmap. This is needed for external backup. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 41 +++

Re: [Qemu-devel] [FreeBSD] Build Failure, qemu-char.c

2016-01-22 Thread Sean Bruno
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 01/22/16 09:02, Daniel P. Berrange wrote: > On Fri, Jan 22, 2016 at 08:52:36AM -0800, Sean Bruno wrote: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 >> >> >> >> On 01/22/16 08:47, Peter Maydell wrote: >> >>> This one is just straightfo

Re: [Qemu-devel] [PATCH v9 23/37] qmp: Support explicit null during input visit

2016-01-22 Thread Markus Armbruster
Eric Blake writes: > Implement the new type_null() callback for the qmp input visitor. > While we don't yet have a use for this in qapi (the generator > will need some tweaks first), one usage is already envisioned: > when changing blockdev parameters, it would be nice to have a > difference betw

[Qemu-devel] [PATCH] qmp: add query-block-dirty-bitmap

2016-01-22 Thread Vladimir Sementsov-Ogievskiy
Add qmp command to query dirty bitmap. This is needed for external backup. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 41 blockdev.c| 21 + include/block/block.h | 2 ++ qapi/block-core.json |

[Qemu-devel] [PATCH RFC] external backup api

2016-01-22 Thread Vladimir Sementsov-Ogievskiy
Hi all. This is the early begin of the series which aims to add external backup api. This is needed to allow backup software use our dirty bitmaps. Vmware and Parallels Cloud Server have this feature. There is only one patch here, about querying dirty bitmap from qemu by qmp command. It is just

Re: [Qemu-devel] [FreeBSD] Build Failure, qemu-char.c

2016-01-22 Thread Daniel P. Berrange
On Fri, Jan 22, 2016 at 08:52:36AM -0800, Sean Bruno wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > > > On 01/22/16 08:47, Peter Maydell wrote: > > > This one is just straightforwardly BSD-only code that hasn't been > > compile-tested. > > > >> qemu-char.c:4265:36: warning: inc

Re: [Qemu-devel] [PATCH v9 22/37] qapi: Add visit_type_null() visitor

2016-01-22 Thread Markus Armbruster
Eric Blake writes: > Right now, qmp-output-visitor happens to produce a QNull result > if nothing is actually visited between the creation of the visitor > and the request for the resulting QObject. A stronger protocol > would require that a QMP output visit MUST visit something. But > to still

Re: [Qemu-devel] [FreeBSD] Build Failure, qemu-char.c

2016-01-22 Thread Sean Bruno
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 01/22/16 08:47, Peter Maydell wrote: > This one is just straightforwardly BSD-only code that hasn't been > compile-tested. > >> qemu-char.c:4265:36: warning: incompatible pointer types passing >> 'ChardevCommon *' (aka 'struct ChardevCommon *

Re: [Qemu-devel] [FreeBSD] Build Failure, qemu-char.c

2016-01-22 Thread Peter Maydell
On 22 January 2016 at 16:39, Sean Bruno wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > Started seeing a build failure after the updates to qemu-char.c Ccing Dan whose commit that is... > I think clang is not doing something that gcc does implicitly? > > qemu-char.c:1843:26: error

Re: [Qemu-devel] [PATCH] hw/pci-host/uninorth.c: Add support for Apple's PCI bridge register 0x48

2016-01-22 Thread Mark Cave-Ayland
On 22/01/16 16:09, Programmingkid wrote: > Apple has custom PCI bridge registers that are not a part of any known > standard. This patch implements register 0x48. With this patch the > AppleMacRiscPCI kernel extension no longer prints these error messages for > the mac99 target: > AppleMacRiscP

[Qemu-devel] [FreeBSD] Build Failure, qemu-char.c

2016-01-22 Thread Sean Bruno
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Started seeing a build failure after the updates to qemu-char.c I think clang is not doing something that gcc does implicitly? qemu-char.c:1843:26: error: use of undeclared identifier 'common' chr = qemu_chr_alloc(common, errp);

Re: [Qemu-devel] [PATCH 1/2] hmp: add hmp command for incremental backup

2016-01-22 Thread Eric Blake
On 01/21/2016 07:04 PM, 张敏 wrote: >>> -.args_type = "reuse:-n,full:-f,device:B,target:s,format:s?", >>> -.params = "[-n] [-f] device target [format]", >>> +.args_type = >>> "reuse:-n,full:-f,device:B,target:s,bitmap:s?,format:s?", >>> +.params = "[-n] [-f

[Qemu-devel] [PATCH v2 01/10] hw/sd/sdhci.c: Remove x-drive property

2016-01-22 Thread Peter Maydell
The following commits will remove support for the old sdhci-pci command line syntax using the x-drive property: -device sdhci-pci,x-drive=mydrive -drive id=mydrive,[...] and replace it with an explicit sd device: -device sdhci-pci -drive id=mydrive,[...] -device sd,drive=mydrive (This is OK beca

Re: [Qemu-devel] [PATCH 2/8] qmp: create qmp_savevm command

2016-01-22 Thread Denis V. Lunev
On 01/22/2016 06:31 PM, Markus Armbruster wrote: "Denis V. Lunev" writes: On 01/19/2016 09:11 PM, Markus Armbruster wrote: "Denis V. Lunev" writes: On 01/18/2016 06:58 PM, Markus Armbruster wrote: "Denis V. Lunev" writes: 'name' attribute is made mandatory in distinction with HMP comma

[Qemu-devel] [PATCH v2 05/10] hw/sd/sdhci.c: Update to use SDBus APIs

2016-01-22 Thread Peter Maydell
Update the SDHCI code to use the new SDBus APIs. This commit introduces the new command line options required to connect a disk to sdhci-pci: -device sdhci-pci -drive id=mydrive,[...] -device sd,drive=mydrive Signed-off-by: Peter Maydell --- hw/sd/sdhci.c | 97

[Qemu-devel] [PATCH v2 09/10] hw/sd/pxa2xx_mmci: Convert to VMStateDescription

2016-01-22 Thread Peter Maydell
Convert the pxa2xx_mmci device from manual save/load functions to a VMStateDescription structure. This is a migration compatibility break. Signed-off-by: Peter Maydell Reviewed-by: Peter Crosthwaite --- hw/sd/pxa2xx_mmci.c | 156 +--- 1 file chan

[Qemu-devel] [PATCH v2 03/10] hw/sd/sd.c: Convert sd_reset() function into Device reset method

2016-01-22 Thread Peter Maydell
Convert the sd_reset() function into a proper Device reset method. Signed-off-by: Peter Maydell Reviewed-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- hw/sd/sd.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 745e9d6..b62f

[Qemu-devel] [PATCH v2 08/10] hw/sd/pxa2xx_mmci: Update to use new SDBus APIs

2016-01-22 Thread Peter Maydell
Now the PXA2xx MMCI device is QOMified itself, we can update it to use the SDBus APIs to talk to the SD card. Signed-off-by: Peter Maydell --- hw/sd/pxa2xx_mmci.c | 80 +++-- 1 file changed, 66 insertions(+), 14 deletions(-) diff --git a/hw/sd/pxa

[Qemu-devel] [PATCH v2 04/10] hw/sd: Add QOM bus which SD cards plug in to

2016-01-22 Thread Peter Maydell
Add a QOM bus for SD cards to plug in to. Note that since sd_enable() is used only by one board and there only as part of a broken implementation, we do not provide it in the SDBus API (but instead add a warning comment about the old function). Whoever converts OMAP and the nseries boards to QOM w

[Qemu-devel] [PATCH v2 02/10] hw/sd/sd.c: QOMify

2016-01-22 Thread Peter Maydell
Turn the SD card into a QOM device. This conversion only changes the device itself; the various functions which are effectively methods on the device are not touched at this point. Signed-off-by: Peter Maydell Reviewed-by: Peter Crosthwaite --- hw/sd/sd.c | 99 ++

[Qemu-devel] [PATCH v2 00/10] hw/sd: QOMify sd.c (and pxa2xx_mmci)

2016-01-22 Thread Peter Maydell
This series attempts to QOMify sd.c (the actual SD card model), including a proper QOM bus between the controller and the card. This series removes the experimental x-drive property on sdhci-pci; the syntax for using that device changes: instead of using the x-drive property: -device sdhci-pci

[Qemu-devel] [PATCH v2 10/10] hw/sd/pxa2xx_mmci: Add reset function

2016-01-22 Thread Peter Maydell
Add a reset function to the pxa2xx_mmci device; previously it had no handling for system reset at all. Signed-off-by: Peter Maydell Reviewed-by: Peter Crosthwaite --- hw/sd/pxa2xx_mmci.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/hw/sd/pxa2xx_mmci.c b/hw

[Qemu-devel] [PATCH v2 07/10] hw/sd/pxa2xx_mmci: convert to SysBusDevice object

2016-01-22 Thread Peter Maydell
Convert the pxa2xx_mmci device to be a sysbus device. In this commit we only change the device itself, and leave the interface to the SD card using the old non-SDBus APIs. Signed-off-by: Peter Maydell Reviewed-by: Peter Crosthwaite --- hw/sd/pxa2xx_mmci.c | 74 +

[Qemu-devel] [PATCH v2 06/10] sdhci_sysbus: Create SD card device in users, not the device itself

2016-01-22 Thread Peter Maydell
Move the creation of the SD card device from the sdhci_sysbus device itself into the boards that create these devices. This allows us to remove the cannot_instantiate_with_device_add notation because we no longer call drive_get_next in the device model. Signed-off-by: Peter Maydell --- hw/arm/xi

Re: [Qemu-devel] [PATCH 2/8] qmp: create qmp_savevm command

2016-01-22 Thread Markus Armbruster
"Denis V. Lunev" writes: > On 01/19/2016 09:11 PM, Markus Armbruster wrote: >> "Denis V. Lunev" writes: >> >>> On 01/18/2016 06:58 PM, Markus Armbruster wrote: "Denis V. Lunev" writes: > 'name' attribute is made mandatory in distinction with HMP command. > > The patch also

[Qemu-devel] [PATCH] hw/pci-host/uninorth.c: Add support for Apple's PCI bridge register 0x48

2016-01-22 Thread Programmingkid
Apple has custom PCI bridge registers that are not a part of any known standard. This patch implements register 0x48. With this patch the AppleMacRiscPCI kernel extension no longer prints these error messages for the mac99 target: AppleMacRiscPCI: bad range 2(8000:0100) AppleMacRiscPCI:

[Qemu-devel] [PULL 4/7] fpu: Replace uint32 typedef with uint32_t

2016-01-22 Thread Peter Maydell
Replace the uint32 softfloat-specific typedef with uint32_t. This change was made with find include hw fpu target-* -name '*.[ch]' | xargs sed -i -e 's/\buint32\b/uint32_t/g' together with manual removal of the typedef definition, manual undoing of various mis-hits, and another couple of fixes f

[Qemu-devel] [PATCH v5] i2c-tiny-usb is a small usb to i2c bridge

2016-01-22 Thread Tim Sander
i2c-tiny-usb is a small usb to i2c bridge: http://www.harbaum.org/till/i2c_tiny_usb/index.shtml It is pretty simple and has no usb endpoints just a control. Reasons for adding this device: * Linux device driver available * adding an additional i2c bus via command line e.g. -device usb-i2c-tiny,

Re: [Qemu-devel] [PATCH] mips: Clean up includes

2016-01-22 Thread Leon Alrae
On 18/01/16 17:35, Peter Maydell wrote: > Clean up includes so that osdep.h is included first and headers > which it implies are not included manually. > > This commit was created with scripts/clean-includes. > > Signed-off-by: Peter Maydell > --- > disas/mips.c | 1 + > hw/mips/add

[Qemu-devel] [PULL 1/7] fpu: Replace int64 typedef with int64_t

2016-01-22 Thread Peter Maydell
Replace the int64 softfloat-specific typedef with int64_t. This change was made with find include fpu target-* -name '*.[ch]' | xargs sed -i -e 's/\bint64\b/int64_t/g' together with manual removal of the typedef definition, and manual undoing of some mis-hits where macro arguments were being use

[Qemu-devel] [PULL 5/7] fpu: Replace int8 typedef with int8_t

2016-01-22 Thread Peter Maydell
Replace the int8 softfloat-specific typedef with int8_t. This change was made with find include hw fpu target-* -name '*.[ch]' | xargs sed -i -e 's/\bint8\b/int8_t/g' together with manual removal of the typedef definition, and manual undoing of various mis-hits. Signed-off-by: Peter Maydell Re

[Qemu-devel] [PULL 6/7] fpu: Replace uint8 typedef with uint8_t

2016-01-22 Thread Peter Maydell
Replace the uint8 softfloat-specific typedef with uint8_t. This change was made with find include hw fpu target-* -name '*.[ch]' | xargs sed -i -e 's/\buint8\b/uint8_t/g' together with manual removal of the typedef definition and manual fixing of more erroneous uses found via test compilation.

[Qemu-devel] [PULL 3/7] fpu: Replace int32 typedef with int32_t

2016-01-22 Thread Peter Maydell
Replace the int32 softfloat-specific typedef with int32_t. This change was made with find hw include fpu target-* -name '*.[ch]' | xargs sed -i -e 's/\bint32\b/int32_t/g' together with manual removal of the typedef definition, and manual undoing of some mis-hits where macro arguments were being

[Qemu-devel] [PULL 2/7] fpu: Replace uint64 typedef with uint64_t

2016-01-22 Thread Peter Maydell
Replace the uint64 softfloat-specific typedef with uint64_t. This change was made with find include fpu target-* -name '*.[ch]' | xargs sed -i -e 's/\buint64\b/uint64_t/g' together with manual removal of the typedef definition, and manual undoing of some mis-hits where macro arguments were being

[Qemu-devel] [PULL 0/7] softfloat queue

2016-01-22 Thread Peter Maydell
ranch 'remotes/gkurz/tags/for-upstream' into staging (2016-01-22 14:44:12 +) are available in the git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-softfloat-20160122 for you to fetch changes up to 7ceac86f49b564954f5bde477c4281f407be1399: softfloat:

Re: [Qemu-devel] [PATCH v13 00/10] Block replication for continuous checkpoints

2016-01-22 Thread Dr. David Alan Gilbert
Hi, I can trigger a segfault if I wire in the block replication together with a quorum instance; it only triggers with both of them present but, it looks like the problem is a disagreement about the number of quorum members; I'm triggering this on the 'colo-v2.4-periodic-mode' branch that is pos

[Qemu-devel] [PULL 7/7] softfloat: fix return type of roundAndPackFloat16

2016-01-22 Thread Peter Maydell
From: Aurelien Jarno The roundAndPackFloat16 function should return a float16 value, not a float32 one. Fix that. Cc: Peter Maydell Signed-off-by: Aurelien Jarno Reviewed-by: Peter Maydell Message-id: 1452700993-6570-1-git-send-email-aurel...@aurel32.net Signed-off-by: Peter Maydell --- fpu

Re: [Qemu-devel] [PULL 0/2] 9p minor cleanup

2016-01-22 Thread Peter Maydell
On 22 January 2016 at 14:38, Greg Kurz wrote: > Since it is a bit transversal, I prefer to have this merged sooner than > later. > > Thanks ! > > The following changes since commit 911a4efd0caec9a9c65746a8bd78bc4fc212b379: > > seabios: fix submodule (2016-01-22 11:36:29 +) > > are available

[Qemu-devel] [PATCH] rng-random: implement request queue

2016-01-22 Thread Ladi Prosek
If the guest adds a buffer to the virtio queue while another buffer is still pending and hasn't been filled and returned by the rng device, rng-random internally discards the pending request, which leads to the second buffer getting stuck in the queue. For the guest this manifests as delayed comple

Re: [Qemu-devel] [libvirt] ARM KVM GICv3 Support

2016-01-22 Thread Daniel P. Berrange
On Wed, Jan 06, 2016 at 01:30:16PM +, Peter Maydell wrote: > On 6 January 2016 at 12:49, Andrea Bolognani wrote: > > That's correct, having a QMP command that lists the values gic-version > > can have on the current host would be just great. > > > > If we had that, we could validate the GIC ve

[Qemu-devel] [PATCH 1/3] pc: acpi: merge SSDT into DSDT

2016-01-22 Thread Igor Mammedov
Since both tables are built dynamically now, there is no point in keeping ASL in them in separate tables. So do the same as we do for ARM where we have only DSDT table, i.e. move SSDT ASL into DSDT and drop SSDT altogether. This patch doesn't change moved SSDT ASL in any way, but it opens a way to

[Qemu-devel] [PATCH 0/3] merge SSDT into DSDT

2016-01-22 Thread Igor Mammedov
Merging both tables will allow for futher ASL simplification and cleanups per device/subsystem And it also allows to reduce number of expected binary blobs for ACPI tests which reduces tests maintenance. Boot tested with RHEL72, WS2003, WS2012R2 guests. git tree for testing: https://github.com/im

[Qemu-devel] [PATCH] memory: exit when hugepage allocation fails if mem-prealloc

2016-01-22 Thread Luiz Capitulino
When -mem-prealloc is passed on the command-line, the expected behavior is to exit if the hugepage allocation fails. However, this behavior is broken since commit cc57501dee which made hugepage allocation fall back to regular ram in case of faliure. This commit restores the expected behavior for

[Qemu-devel] [PULL 2/2] fsdev: use error_report() instead of fprintf(stderr)

2016-01-22 Thread Greg Kurz
Only fix the code that gets built into QEMU. Reviewed-by: Markus Armbruster Signed-off-by: Greg Kurz --- fsdev/qemu-fsdev.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/fsdev/qemu-fsdev.c b/fsdev/qemu-fsdev.c index ccfec139ab2b..55e2f7a0fb58 100644 --- a/fsdev/qemu

[Qemu-devel] [PULL 1/2] 9pfs: use error_report() instead of fprintf(stderr)

2016-01-22 Thread Greg Kurz
Reviewed-by: Markus Armbruster Signed-off-by: Greg Kurz --- hw/9pfs/9p-handle.c | 5 +++-- hw/9pfs/9p-local.c | 15 --- hw/9pfs/9p-proxy.c | 12 ++-- hw/9pfs/9p.c| 2 +- 4 files changed, 18 insertions(+), 16 deletions(-) diff --git a/hw/9pfs/9p-handle.c b/hw/9pfs

[Qemu-devel] [PULL 0/2] 9p minor cleanup

2016-01-22 Thread Greg Kurz
Since it is a bit transversal, I prefer to have this merged sooner than later. Thanks ! The following changes since commit 911a4efd0caec9a9c65746a8bd78bc4fc212b379: seabios: fix submodule (2016-01-22 11:36:29 +) are available in the git repository at: https://github.com/gkurz/qemu.git

[Qemu-devel] [PATCH 2/3] tests: pc: acpi: drop not needed 'expected SSDT' blobs

2016-01-22 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- tests/acpi-test-data/pc/SSDT | Bin 2486 -> 0 bytes tests/acpi-test-data/pc/SSDT.bridge | Bin 4345 -> 0 bytes tests/acpi-test-data/q35/SSDT| Bin 691 -> 0 bytes tests/acpi-test-data/q35/SSDT.bridge | Bin 708 -> 0 bytes 4 files changed, 0 inserti

[Qemu-devel] [PATCH 3/3] tests: pc: acpi: add expected DSDT.bridge blobs and update DSDT blobs

2016-01-22 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- tests/acpi-test-data/pc/DSDT | Bin 3028 -> 5478 bytes tests/acpi-test-data/pc/DSDT.bridge | Bin 0 -> 7337 bytes tests/acpi-test-data/q35/DSDT| Bin 7666 -> 8321 bytes tests/acpi-test-data/q35/DSDT.bridge | Bin 0 -> 8338 bytes 4 files changed, 0

Re: [Qemu-devel] [PATCH] dimm: Correct type of MemoryHotplugState->base

2016-01-22 Thread Igor Mammedov
On Fri, 22 Jan 2016 15:21:05 +0100 Paolo Bonzini wrote: > On 22/01/2016 11:02, Igor Mammedov wrote: > > On Thu, 21 Jan 2016 12:37:51 +1100 > > David Gibson wrote: > > > >> The 'base' field of MemoryHotplugState is ram_addr_t, which indicates that > >> it exists in the abstract address space o

Re: [Qemu-devel] [PATCH] dimm: Correct type of MemoryHotplugState->base

2016-01-22 Thread Paolo Bonzini
On 22/01/2016 11:02, Igor Mammedov wrote: > On Thu, 21 Jan 2016 12:37:51 +1100 > David Gibson wrote: > >> The 'base' field of MemoryHotplugState is ram_addr_t, which indicates that >> it exists in the abstract address space of RAM regions. >> >> However, the actual usage of this field indicates

Re: [Qemu-devel] [Minios-devel] [PATCH v8 0/] Begin to disentangle libxenctrl and provide some stable libraries

2016-01-22 Thread Ian Campbell
On Fri, 2016-01-15 at 13:22 +, Ian Campbell wrote: > In <1431963008.4944.80.ca...@citrix.com> I proposed stabilising some > parts of the libxenctrl API/ABI by disaggregating into separate > libraries. > > This is v8 of that set of series against: > xen > qemu-xen > qemu-xen-traditi

Re: [Qemu-devel] [RFC PATCH 0/2] Early release of -drive QemuOpts

2016-01-22 Thread Paolo Bonzini
On 08/01/2016 18:37, Paolo Bonzini wrote: > In short, this patch gets rid of blockdev_mark_auto_del and > blockdev_auto_del. > > With these patches, it is possible to create a new -drive with the same > id as soon as the DEVICE_DELETED event is delivered (which equals to > unrealize). > > I'm s

Re: [Qemu-devel] [PATCH v1] kvm/x86: Hyper-V tsc page setup

2016-01-22 Thread Andrey Smetanin
On 01/22/2016 04:21 PM, Paolo Bonzini wrote: On 22/01/2016 14:13, Andrey Smetanin wrote: We(@virtuozzo.com) will be very thankful to you for the patch which integrates Hyper-V tsc page with kvm clock. We even may do work by yourself, but our priority now is Hyper-V VMBus initialization (w

[Qemu-devel] [PATCH v18 9/9] pc/q53: by default put vmgenid device as an function of ISA bridge

2016-01-22 Thread Igor Mammedov
it will save a PCI slot that would be used otherwise. Signed-off-by: Igor Mammedov Suggested-by: Michael S. Tsirkin --- hw/i386/pc_piix.c | 12 hw/i386/pc_q35.c | 12 include/hw/i386/ich9.h | 3 ++- include/hw/i386/pc.h | 1 + 4 files changed, 27 inserti

Re: [Qemu-devel] [PATCH v1] kvm/x86: Hyper-V tsc page setup

2016-01-22 Thread Paolo Bonzini
On 22/01/2016 14:13, Andrey Smetanin wrote: >> > > We(@virtuozzo.com) will be very thankful to you for the patch which > integrates Hyper-V tsc page with kvm clock. We even may do work by > yourself, but our priority now is Hyper-V VMBus initialization > (which is not in dependency on Hyper-V ts

[Qemu-devel] [PATCH v18 8/9] pc: put PIIX3 in slot 1 explicitly and cleanup functions assignment

2016-01-22 Thread Igor Mammedov
currently slot for PIIX3 bridge is selected dynamically but it's always in slot 1 for existing machine types. However it's easy to regress if another PCI device were added before PIIX3 is created and also requires passing around devfn of the created bridge. Replace dynamic slot assignment with a st

[Qemu-devel] [PATCH v18 4/9] tests: add a unit test for the vmgenid device.

2016-01-22 Thread Igor Mammedov
* test that guest can read GUID provided on CLI from buffer accessing it at HPA which is available via 'vmgid-addr' property when device is inintialized. * test setting GUID at runtime and check that it's updated at expected HPA. Signed-off-by: Gal Hammer Signed-off-by: Igor Mammedov ---

[Qemu-devel] [PATCH v18 6/9] qmp/hmp: add set-vm-generation-id commands

2016-01-22 Thread Igor Mammedov
Add set-vm-generation-id command to set Virtual Machine Generation ID counter. QMP command example: { "execute": "set-vm-generation-id", "arguments": { "guid": "324e6eaf-d1d1-4bf6-bf41-b9bb6c91fb87" } } HMP command example: set-vm-generation-id 324e6e

[Qemu-devel] [PATCH v18 5/9] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands

2016-01-22 Thread Igor Mammedov
Add commands to query Virtual Machine Generation ID counter. QMP command example: { "execute": "query-vm-generation-id" } HMP command example: info vm-generation-id Signed-off-by: Igor Mammedov --- v18: - add a new QMP type GuidInfo instead of reusing UuidInfo Eric Blake --- hmp

  1   2   3   >