So, what's the status of this issue now?
(it is CVE-2015-8619 btw, maybe worth to mention this in the commit message)
Thanks,
/mjt
Hi,
The patch has been reviewed by: Marcel Apfelbaum
, but still not seeing it in upstream, is it missed?
On 12/22/2015 10:11 PM, Marcel Apfelbaum wrote:
On 12/22/2015 02:50 PM, Cao jin wrote:
Signed-off-by: Cao jin
---
v3 changelog:
1. As per Paolo`s review, also Marcel`s test suggestio
From: Chen Gang
Simply enable it, and notice about 80 columns coding styles.
Signed-off-by: Chen Gang
---
linux-user/syscall.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 6c64ba6..8d4bcf6 100644
--- a/linux-user/syscal
On Sat, Jan 9, 2016 at 9:39 AM, Dmitry Osipenko wrote:
> Allow to switch between periodic <-> oneshot modes while timer is running.
>
"Allow switching"
> Signed-off-by: Dmitry Osipenko
> ---
> hw/core/ptimer.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git
On Sat, Jan 9, 2016 at 9:39 AM, Dmitry Osipenko wrote:
> ptimer_get_count() might be called while QEMU timer already been expired.
> In that case ptimer would return counter = 0, which might be undesirable
> in case of polled timer. Do counter wrap around for periodic timer to keep
> it distribute
On Sat, Jan 9, 2016 at 9:39 AM, Dmitry Osipenko wrote:
> Multiple issues here related to the timer with a adjusted .limit value:
>
> 1) ptimer_get_count() returns incorrect counter value for the disabled
> timer after loading the counter with a small value, because adjusted limit
> value is used i
From: Cornelia Huck
There's no such thing as "PCI queues" in the virtio core.
Signed-off-by: Cornelia Huck
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/virtio/virtio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/virtio/virtio.c b/hw/virt
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/i386/acpi-build.c | 56 ++
hw/i386/q35-acpi-dsdt.dsl | 57 ---
2 files changed
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/i386/acpi-build.c | 10 ++
hw/i386/q35-acpi-dsdt.dsl | 5 -
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i38
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/i386/acpi-build.c | 2 ++
hw/i386/q35-acpi-dsdt.dsl | 79 ---
2 files changed, 2 insertions(+), 79 deletions(-)
diff --g
From: "Dr. David Alan Gilbert"
The 'virtqueue_state' and 'ringsize' can be saved using VMSTATE
macros rather than hand coded .get/.put
Signed-off-by: Dr. David Alan Gilbert
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
Reviewed-by: Amit Shah
---
hw/virtio/virtio.c | 87 +
From: Igor Mammedov
QEMU now uses internally composed DSDT so drop now
empty *.dsl templates and related *.generated
binary blobs.
Also since templates are not used anymore/obolete
remove utility scripts used for extracting/patching
AML blobs compiled by IASL and for updating them
in git tree.
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/i386/acpi-build.c | 54 +++
hw/i386/q35-acpi-dsdt.dsl | 46
2 files changed, 54 i
From: "Dr. David Alan Gilbert"
At the moment we have VMSTATE_STRUCT_ARRAY that requires
the field is declared as an array of fixed size.
We also have VMSTATE_STRUCT_VARRAY_UINT* that allows
a field declared as a pointer, but requires that the length
is a field member in the structure being loaded
From: Roman Kagan
Factor out and expose the function to locate the floppy controller in
the system.
It will allow to dynamically populate the relevant objects in the ACPI
tables.
Signed-off-by: Roman Kagan
Cc: "Michael S. Tsirkin"
Cc: Eduardo Habkost
Cc: Igor Mammedov
Cc: John Snow
Cc: Kevi
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/i386/acpi-build.c | 47 +++
hw/i386/q35-acpi-dsdt.dsl | 34 --
2 files changed, 55 inserti
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/i386/acpi-build.c | 61 +++
hw/i386/q35-acpi-dsdt.dsl | 57 ---
2 files changed, 6
From: Tetsuya Mukawa
If virtio-net driver allocates memory in ivshmem shared memory,
vhost-net will work correctly, but vhost-user will not work because
a fd of shared memory will not be sent to vhost-user backend.
This patch fixes ivshmem to store file descriptor of shared memory.
It will be use
From: Igor Mammedov
leave Scope(\_SB) definition in DSDT so that iasl
would be able to compile DSDT since we are still
need definition block for table.
After Q35 ASL is converted, DSDT templates will
be completly replaced by AML API generated tables.
Signed-off-by: Igor Mammedov
Reviewed-by: Mi
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/i386/acpi-build.c | 21 +
hw/i386/q35-acpi-dsdt.dsl | 12
2 files changed, 21 insertions(+), 12 deletions(-)
diff --git a/hw/i386/ac
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/i386/acpi-build.c | 235 +--
1 file changed, 115 insertions(+), 120 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i3
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/i386/acpi-build.c | 10 ++
hw/i386/acpi-dsdt.dsl | 9 -
2 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/ac
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/i386/acpi-build.c | 51 ++-
hw/i386/q35-acpi-dsdt.dsl | 9 -
2 files changed, 33 insertions(+), 27 deletions(-)
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/i386/acpi-build.c | 14 +-
hw/i386/q35-acpi-dsdt.dsl | 13 -
2 files changed, 9 insertions(+), 18 deletions(-)
diff --git a/hw/i386/acpi-buil
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/i386/acpi-build.c | 77 +++
hw/i386/acpi-dsdt.dsl | 49
2 files changed, 82 insertions(+)
From: Igor Mammedov
and also move PRQx fields declaration as it can't be
split out into separate patch since fields use
PCI0.ISA.P40C operation region and OperationRegion
must be declared in the same table as a Field that
uses it. If this condition is not statisfied Windows
will BSOD ans IASL (ma
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/i386/acpi-build.c | 30 +-
hw/i386/acpi-dsdt.dsl | 40
hw/i386/q35-acpi-dsdt.dsl | 36 ---
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/i386/acpi-build.c | 8
hw/i386/q35-acpi-dsdt.dsl | 10 --
2 files changed, 8 insertions(+), 10 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/i386/acpi-build.c | 9 +
hw/i386/q35-acpi-dsdt.dsl | 40
2 files changed, 17 insertions(+), 32 deletions(-)
diff --
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/i386/acpi-build.c | 22 ++
hw/i386/acpi-dsdt-isa.dsl | 12
2 files changed, 22 insertions(+), 12 deletions(-)
diff --git a/hw/i386/a
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/i386/acpi-build.c | 26 +++---
hw/i386/q35-acpi-dsdt.dsl | 8
2 files changed, 15 insertions(+), 19 deletions(-)
diff --git a/hw/i386/a
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
include/hw/acpi/cpu_hotplug.h | 5 +
hw/acpi/cpu_hotplug_acpi_table.c | 28
hw/i386/acpi-build.c | 3 ++-
hw/acpi/Makefil
From: Igor Mammedov
PCI routing table for expander buses is build with help
of build_prt() using AML API. And it's almost the same
as PRT for PCI0 bus except of power-management device.
So make existing build_prt() build PRT table for PCI0
bus as well.
Signed-off-by: Igor Mammedov
Reviewed-by:
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/i386/acpi-build.c | 36
hw/i386/acpi-dsdt-dbug.dsl | 41 -
hw/i386/acpi-dsdt.dsl |
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/i386/acpi-build.c | 43 +++
hw/i386/acpi-dsdt.dsl | 40
2 files changed, 43 insertions(+)
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/i386/acpi-build.c | 20
hw/i386/acpi-dsdt.dsl | 11 ---
2 files changed, 20 insertions(+), 11 deletions(-)
diff --git a/hw/i386/acpi-build.c
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/i386/acpi-build.c | 174 ---
1 file changed, 94 insertions(+), 80 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
include/hw/acpi/cpu_hotplug.h | 2 ++
hw/acpi/cpu_hotplug_acpi_table.c | 23 +++
hw/i386/acpi-build.c | 5 +++--
hw/i386/acpi-dsdt-cpu
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/i386/acpi-build.c | 48 +++
hw/i386/acpi-dsdt-isa.dsl | 52 ---
hw/i386/acpi-dsdt.
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/i386/acpi-build.c | 36
hw/i386/acpi-dsdt-isa.dsl | 16
2 files changed, 36 insertions(+), 16 deletions(-)
diff
From: Igor Mammedov
most of MEMORY_foo defines are not shared
with ASL anymore and are used only inside of
memory_hotplug_acpi_table.c, so move them
there and make them strings. As result we
can replace stringify(MEMORY_foo) with just
MEMORY_foo, which makes code a bit cleaner.
No AML change int
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
include/hw/acpi/aml-build.h | 2 ++
include/hw/acpi/cpu_hotplug.h | 1 +
include/hw/acpi/pc-hotplug.h | 1 +
hw/acpi/cpu_hotplug_acpi_table.c | 64
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/i386/acpi-build.c | 40
hw/i386/acpi-dsdt-isa.dsl | 18 --
2 files changed, 40 insertions(+), 18 deletions(-)
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/i386/acpi-build.c | 26 ++
hw/i386/acpi-dsdt-isa.dsl | 9 -
2 files changed, 26 insertions(+), 9 deletions(-)
diff --git a/hw/i386/a
From: Igor Mammedov
before consolidating memhp code in memory_hotplug_acpi_table.c
and for simplifying review, first factor out memhp code into
new function build_memory_devices() in i386/acpi-build.c
Signed-off-by: Igor Mammedov
PS:
no functional change, only code movement.
Reviewed-by
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/acpi/memory_hotplug_acpi_table.c | 13 +
hw/i386/acpi-dsdt-mem-hotplug.dsl | 8
2 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/hw/
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
include/hw/timer/hpet.h| 1 +
hw/i386/acpi-build.c | 53 ++
hw/timer/hpet.c| 2 +-
hw/i386/acpi-dsdt-hpet.
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/i386/acpi-build.c | 21 +
hw/i386/acpi-dsdt-isa.dsl | 10 --
2 files changed, 21 insertions(+), 10 deletions(-)
diff --git a/hw/i386/acpi
From: Igor Mammedov
move remnants of MHPD device from DSDT into SSDT.
i.e. Device(MHPD), _UID, _HID
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/acpi/memory_hotplug_acpi_table.c | 6 +-
hw/i386/acpi-dsdt-mem-hotplug.dsl | 7
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/acpi/memory_hotplug_acpi_table.c | 15 +++
hw/i386/acpi-dsdt-mem-hotplug.dsl | 10 --
2 files changed, 15 insertions(+), 10 deletions(-)
diff --git
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/i386/acpi-dsdt-cpu-hotplug.dsl | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/i386/acpi-dsdt-cpu-hotplug.dsl
b/hw/i386/acpi-dsdt-cpu-hotplug.dsl
index 1aff746..53e
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
include/hw/acpi/cpu_hotplug.h | 1 +
include/hw/acpi/pc-hotplug.h | 1 -
hw/acpi/cpu_hotplug_acpi_table.c | 2 +-
hw/i386/acpi-build.c | 12
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/acpi/memory_hotplug_acpi_table.c | 92 +
hw/i386/acpi-dsdt-mem-hotplug.dsl | 72 -
2 files changed, 92 in
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/acpi/memory_hotplug_acpi_table.c | 14 ++
hw/i386/acpi-dsdt-mem-hotplug.dsl | 9 -
2 files changed, 14 insertions(+), 9 deletions(-)
diff --git a/h
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
include/hw/acpi/cpu_hotplug.h | 1 +
hw/acpi/cpu_hotplug_acpi_table.c | 22 ++
hw/i386/acpi-build.c | 3 ++-
hw/i386/acpi-dsdt-cpu-hot
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/acpi/memory_hotplug_acpi_table.c | 23 +++
hw/i386/acpi-dsdt-mem-hotplug.dsl | 15 ---
2 files changed, 23 insertions(+), 15 deletions(-)
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
include/hw/acpi/memory_hotplug.h| 4
hw/acpi/memory_hotplug_acpi_table.c | 30 ++
hw/i386/acpi-build.c| 3 +++
hw/acpi/
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/acpi/memory_hotplug_acpi_table.c | 14 ++
hw/i386/acpi-dsdt-mem-hotplug.dsl | 8
2 files changed, 14 insertions(+), 8 deletions(-)
diff --git a/hw
From: Laszlo Ersek
The ACPI specification (minimally versions 1.0b through 6.0) define the
FADT.CENTURY field as:
The RTC CMOS RAM index to the century of data value (hundred and
thousand year decimals). If this field contains a zero, then the RTC
centenary feature is not supported. If thi
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/acpi/memory_hotplug_acpi_table.c | 60 +
hw/i386/acpi-dsdt-mem-hotplug.dsl | 27 +
2 files changed, 61 insertions(+),
From: Igor Mammedov
in addition remove no longer needed acpi-dsdt-mem-hotplug.dsl.
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
include/hw/acpi/memory_hotplug.h | 5 +
include/hw/acpi/pc-hotplug.h | 2 --
hw/i386/acpi-build.c
From: Igor Mammedov
print ASL difference if there is any when
executing 'make V=1 check'.
Use 'DIFF' environment variable to determine
which diff utility to use and if it's not set
notify user by printing warning that DIFF is
not set if run in verbose mode and there is
difference in ASL.
Signed-
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/acpi/memory_hotplug_acpi_table.c | 2 ++
hw/i386/acpi-dsdt-mem-hotplug.dsl | 3 +--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/acpi/memory_hotplug
From: Haozhong Zhang
In the current nvdimm_build_nfit(), the pointer 'header' initially equals
to table_data->data + table_data->len. However, the following
g_array_append_vals(table_data, structures->data, structures->len)
may resize and relocate table_data->data[]. Therefore, the usage of 'head
From: Cao jin
Fix the bug introduced by 595a4f07: function host_pci_config_read() should be
pass-by-reference, not value.
This probably means this function never worked for anyone.
Signed-off-by: Cao jin
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/pci-host/piix.c
The following changes since commit 6bb9ead762bf749af11ea225fc2a74db1b93c105:
Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20160108-1' into
staging (2016-01-08 12:50:19 +)
are available in the git repository at:
git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_ups
On Fri, Jan 08, 2016 at 06:34:15PM +0100, Igor Mammedov wrote:
> build fail with warnings on w32 compiler:
>
> hw/acpi/memory_hotplug_acpi_table.c:
> In function ‘build_memory_hotplug_aml’:
> hw/acpi/memory_hotplug_acpi_table.c:148:
> warning: integer constant is too large for ‘long’ type
> hw/acp
Currently ptimer users are used to store copy of the limit value, because
ptimer doesn't provide facility to retrieve the limit. Let's provide it.
Signed-off-by: Dmitry Osipenko
---
hw/core/ptimer.c| 5 +
include/hw/ptimer.h | 1 +
2 files changed, 6 insertions(+)
diff --git a/hw/core/p
Current ARM MPTimer implementation uses QEMUTimer for the actual timer,
this implementation isn't complete and mostly tries to duplicate of what
generic ptimer is already doing fine.
Conversion to ptimer brings the following benefits and fixes:
- Simple timer pausing implementation
Allow to switch between periodic <-> oneshot modes while timer is running.
Signed-off-by: Dmitry Osipenko
---
hw/core/ptimer.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/core/ptimer.c b/hw/core/ptimer.c
index 0a54212..6960738 100644
--- a/hw/core/ptimer.c
Changelog for ARM MPTimer QEMUTimer to ptimer conversion:
V2: Fixed changing periodic timer counter value "on the fly". I added a
test to the gist to cover that issue.
V3: Fixed starting the timer with load = 0 and counter != 0, added tests
to the gist for this issue. Chan
Multiple issues here related to the timer with a adjusted .limit value:
1) ptimer_get_count() returns incorrect counter value for the disabled
timer after loading the counter with a small value, because adjusted limit
value is used instead of the original.
For instance:
1) ptimer_stop(t)
Currently ptimer would print error message and clear enable flag for an
arming timer that has delta = load = 0. That actually could be a valid case
for some hardware, like instant IRQ trigger for oneshot timer or continuous
in periodic mode. Support those cases by printing error message only when
p
Delta value must be updated on period/freq change, otherwise running timer
would be restarted (counter reloaded with old delta). Only m68k/mcf520x
and arm/arm_timer devices are currently doing freq change correctly, i.e.
stopping the timer. Perform delta update to fix affected devices and
eliminate
ptimer_get_count() might be called while QEMU timer already been expired.
In that case ptimer would return counter = 0, which might be undesirable
in case of polled timer. Do counter wrap around for periodic timer to keep
it distributed. In order to achieve more accurate emulation behaviour of
cert
Hello,
during regular operations within linux guest with USB EHCI frontend I
am seeing process crashes with an assert during regular operations
like dpkg install:
hw/usb/dev-storage.c:334: usb_msd_handle_reset: Assertion `s->req ==
((void *)0)' failed.
This does happen when real block backend is
3On 08.12.2015 10:39, Gerhard Wiesinger wrote:
Hello,
Yesterday I looked at my munin statistics on my KVM host and I swar
that performance gets worser: load is getting higher, interrupts are
getting higher and are high as well as context switches. VMs and
applications didn't change that way.
Thanks Leon,
I'll make sure future patches are sent inline.
Regards,
Miodrag
From: Leon Alrae
Sent: Friday, January 08, 2016 5:09 PM
To: Miodrag Dinic; Aurelien Jarno
Cc: qemu-devel@nongnu.org; Petar Jovanovic
Subject: Re: [Qemu-devel] [PATCH v2] target-
+-- On Sat, 9 Jan 2016, Wolfgang Bumiller wrote --+
| > could say: if (!strcmp(keyname_buf, "<")).
|
| keyname_len+1 (size instead of length) to include the \0, then yes I think
| strcmp can be used this way. The +1 should be fine there (since >= covers
| it).
Yes, right.
--
- P J P
47AF CE69 3A
On 01/09/2016 06:50 AM, Eric Blake wrote:
On 01/08/2016 01:37 AM, Cao jin wrote:
buf[rc] = 0;
rc = qemu_strtoul(buf, &endptr, base, &value);
Do you still need a local 'value' variable, or can you just reuse pvalue
here?
I guess so, or else it won`t compile, because, *pval
I don't mind ACKing this change if we could agree on some kind of
regression test for this. (I have an RDMA card at home that I could run
tests on if need be).
The way that virt-test goes about this is not sufficient. The way I do
testing for RDMA is that I not only confirm that
the migration
On 01/09/2016 06:50 AM, Eric Blake wrote:
On 01/08/2016 01:37 AM, Cao jin wrote:
To catch the error msg. Also modify the caller
Signed-off-by: Cao jin
---
hw/xen/xen-host-pci-device.c | 134 ++-
hw/xen/xen-host-pci-device.h | 5 +-
hw/xen/xen_pt.
On 01/09/2016 01:35 AM, Eric Blake wrote:
On 01/08/2016 01:37 AM, Cao jin wrote:
strtol() don`t guarantee errno to be ERANGE on overflow.
I stand slightly corrected: C99 requires ERANGE on overflow, but not
EINVAL; it is POSIX that adds EINVAL, but does not properly require it.
At any rate
> On January 8, 2016 at 6:32 PM P J P wrote:
>
>
> +-- On Fri, 8 Jan 2016, Wolfgang Bumiller wrote --+
> | On Fri, Jan 08, 2016 at 07:29:31PM +0530, P J P wrote:
> | > + if (!strncmp(keyname_buf, "<-", 2))
> | > and remove the 'keyname_len' altogether.
> |
> | This wouldn't catch '<' without
84 matches
Mail list logo
