Re: [Qemu-devel] [PATCH 07/11] tricore: avoid "naked" qemu_log

2015-12-12 Thread Peter Maydell
On 12 December 2015 at 19:47, Bastian Koppelmann wrote: > On 12/12/2015 11:36 AM, Paolo Bonzini wrote: >> Cc: Bastian Koppelmann >> Signed-off-by: Paolo Bonzini >> --- >> target-tricore/helper.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> > > This doesn't look like something

Re: [Qemu-devel] [PATCH] target-*: Get rid of "PC advancement" trick

2015-12-12 Thread Sergey Fedorov
On 12/12/15 02:39, Richard Henderson wrote: On 12/10/2015 10:47 AM, Sergey Fedorov wrote: The "PC advancement" trick was used just after recognizing that a breakpoint exception was going to be generated. This trick has had two points: 1. Guarantee that tb->size isn't zero: there are many place

Re: [Qemu-devel] [PATCH 07/11] tricore: avoid "naked" qemu_log

2015-12-12 Thread Bastian Koppelmann
On 12/12/2015 11:36 AM, Paolo Bonzini wrote: > Cc: Bastian Koppelmann > Signed-off-by: Paolo Bonzini > --- > target-tricore/helper.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > This doesn't look like something which should go into 2.5, so I'll add this into my queue for 2.6.

[Qemu-devel] Monitoring memory writes

2015-12-12 Thread Igor R
In my QEMU-based project I would like to perform "extensive" tracing of basic blocks (translation blocks). I.e. in addition to what the existing tracing mechanism does, I'd like to log registers modified by TB and memory (RAM) written by TB. As for registers, it seems to be trivial. My main problem

Re: [Qemu-devel] [PATCH 1/1] Fix do_rt_sigreturn on m68k linux userspace emulation

2015-12-12 Thread Michael Karcher
On 09.12.2015 23:03, Laurent Vivier wrote: > > Le 09/12/2015 21:54, Michael Karcher a écrit : >> do_rt_sigreturn forgets to initialize the signal mask variable before >> trying to use it to restore the mask, so the signal mask is undefined >> after do_rt_sigreturn. This bug has been in all the time

Re: [Qemu-devel] [PATCH 11/11] linux-user: convert DEBUG_SIGNAL logging to tracepoints

2015-12-12 Thread Laurent Vivier
Le 12/12/2015 11:39, Paolo Bonzini a écrit : > "Unimplemented" messages go to stderr, everything else goes to tracepoints > > Signed-off-by: Paolo Bonzini > --- > bsd-user/signal.c | 2 - > linux-user/signal.c | 118 > ++-- > trace-events

Re: [Qemu-devel] [PATCH 10/11] linux-user: avoid "naked" qemu_log

2015-12-12 Thread Laurent Vivier
Le 12/12/2015 11:36, Paolo Bonzini a écrit : > Ensure that all log writes are protected by qemu_loglevel_mask or, > in serious cases, go to both the log and stderr. > > Signed-off-by: Paolo Bonzini > --- > linux-user/main.c | 71 > --- > 1 f

Re: [Qemu-devel] [PATCH 0/3] vmw_pvscsi: Fine-tune device capabilities

2015-12-12 Thread Shmulik Ladkani
Hi, On Thu, 19 Nov 2015 16:25:47 +0100 Paolo Bonzini wrote: > On 19/11/2015 15:21, Shmulik Ladkani wrote: > > Various fixes to what the vmw_pvscsi device reports in its PCI > > configuration space, to better align with VMware virtual hardware > > as exposed by ESXi/Workstation. > > > > Shmulik L

[Qemu-devel] [PATCH] rtc: introduce nmi disable bit handler for cmos

2015-12-12 Thread Gonglei
The Non-Maskable Interrupt (NMI) Enable bit is 0x80 bit of Port 0x70 (and its aliases). This bit must be 0b to enable the hardware chipset to send a Non-Maskable Interrupt. When set to a 1b, NMI's are disabled. This bit is commonly accessed by applications, BIOS, and even the operating system since

[Qemu-devel] [PATCH v3 6/7] vmxnet3: Introduce 'x-disable-pcie' backword compatability property

2015-12-12 Thread Shmulik Ladkani
Following the previous patch which changed vmxnet3 to be a pci express device, this patch introduces a boolean property 'x-disable-pcie' whose default is false. Setting 'x-disable-pcie' to 'on' preserves the old 'pci device' (non express) behavior. This allows migration to older versions. Signed-

[Qemu-devel] [PATCH v3 5/7] vmxnet3: The vmxnet3 device is a PCIE endpoint

2015-12-12 Thread Shmulik Ladkani
Report the 'express endpoint' capability if on a PCIE bus. Signed-off-by: Shmulik Ladkani --- hw/net/vmxnet3.c | 53 - 1 file changed, 52 insertions(+), 1 deletion(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 14d4dcb..7ded287 1006

[Qemu-devel] [PATCH v3 7/7] vmxnet3: Report the Device Serial Number capability

2015-12-12 Thread Shmulik Ladkani
Report the DSN extended PCI capability at 0x100. DSN value is a transformation of device MAC address, as calculated by VMware virtual hardware. DSN is reported only if device is pcie. Signed-off-by: Shmulik Ladkani --- hw/net/vmxnet3.c | 28 ++-- 1 file changed, 26 inser

[Qemu-devel] [PATCH v3 3/7] vmxnet3: Introduce 'x-old-msi-offsets' backword compatability property

2015-12-12 Thread Shmulik Ladkani
Following the previous patches, where vmxnet3's pci's msi/msix capability offsets and msix's PBA table offsets have been changed, this patch introduces a boolean property 'x-old-msi-offsets' to vmxnet3, whose default is false. Setting 'x-old-msi-offsets' to 'on' preserves the old offsets behavior,

[Qemu-devel] [PATCH v3 4/7] vmxnet3: coding: Introduce VMXNET3Class

2015-12-12 Thread Shmulik Ladkani
Introduce a class type for vmxnet3, and the usual DEVICE_CLASS/DEVICE_GET_CLASS macros. No semantic change. Signed-off-by: Shmulik Ladkani --- hw/net/vmxnet3.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index d1fe888..14d4dcb 100644 --- a

[Qemu-devel] [PATCH v3 0/7] vmxnet3: Fine-tune device capabilities

2015-12-12 Thread Shmulik Ladkani
Various fixes to what the vmxnet3 device reports in its PCI configuration space, in order to be aligned with VMware virtual hardware exposed by ESXi/Workstation. Since v2: Introduce the compatability properties in separate patches, per Jason Wang's comment Since v1: Added migration compa

[Qemu-devel] [PATCH v3 1/7] vmxnet3: Change offsets of msi/msix pci capabilities

2015-12-12 Thread Shmulik Ladkani
Place device reported PCI capabilities at the same offsets as placed by the VMware virtual hardware: MSI at [84], MSI-X at [9c]. Signed-off-by: Shmulik Ladkani --- hw/net/vmxnet3.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/hw/net/vmxnet3.c b/hw/net/v

[Qemu-devel] [PATCH v3 2/7] vmxnet3: Change the offset of the MSIX PBA table

2015-12-12 Thread Shmulik Ladkani
Place the PBA table at 0x1000, as placed by VMware virtual hardware. Signed-off-by: Shmulik Ladkani --- hw/net/vmxnet3.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index d323895..97f0aea 100644 --- a/hw/net/vmxnet3.c +++ b/hw/net/

[Qemu-devel] [PATCH 11/11] linux-user: convert DEBUG_SIGNAL logging to tracepoints

2015-12-12 Thread Paolo Bonzini
"Unimplemented" messages go to stderr, everything else goes to tracepoints Signed-off-by: Paolo Bonzini --- bsd-user/signal.c | 2 - linux-user/signal.c | 118 ++-- trace-events| 11 + 3 files changed, 69 insertions(+), 62 deletion

Re: [Qemu-devel] [PATCH 1/1 v2] Fix do_rt_sigreturn on m68k linux userspace emulation

2015-12-12 Thread Laurent Vivier
Le 12/12/2015 11:13, Michael Karcher a écrit : > do_rt_sigreturn uses an uninitialised local variable instead of fetching > the old signal mask directly from the signal frame when restoring the mask, > so the signal mask is undefined after do_rt_sigreturn. As the signal > frame data is in target-

[Qemu-devel] [PATCH 04/11] microblaze: avoid "naked" qemu_log

2015-12-12 Thread Paolo Bonzini
Cc: Edgar E. Iglesias Signed-off-by: Paolo Bonzini --- target-microblaze/helper.c| 2 +- target-microblaze/mmu.c | 20 ++-- target-microblaze/op_helper.c | 8 target-microblaze/translate.c | 2 +- 4 files changed, 16 insertions(+), 16 deletions(-) diff --gi

[Qemu-devel] [PATCH 09/11] user: introduce "-d page"

2015-12-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- bsd-user/main.c | 4 ++-- include/qemu/log.h | 1 + linux-user/elfload.c | 8 linux-user/main.c| 4 ++-- qemu-log.c | 2 ++ 5 files changed, 11 insertions(+), 8 deletions(-) diff --git a/bsd-user/main.c b/bsd-user/main.c index adf2de

[Qemu-devel] [PATCH 01/11] qemu-log: introduce qemu_log_separate

2015-12-12 Thread Paolo Bonzini
In some cases, the same message is printed both on stderr and in the log. Avoid duplicate output in the default case where stderr _is_ the log, and standardize this to stderr+log where it used to use stdio+log. Signed-off-by: Paolo Bonzini --- exec.c| 2 +- include/qemu/log.

[Qemu-devel] [PATCH 08/11] xtensa: avoid "naked" qemu_log

2015-12-12 Thread Paolo Bonzini
Cc: Max Filippov Signed-off-by: Paolo Bonzini --- target-xtensa/gdbstub.c | 8 target-xtensa/helper.c | 4 ++-- target-xtensa/op_helper.c | 20 ++-- target-xtensa/translate.c | 28 ++-- target-xtensa/xtensa-semi.c | 2 +- 5 files c

[Qemu-devel] [PATCH 05/11] s390x: avoid "naked" qemu_log

2015-12-12 Thread Paolo Bonzini
Convert to debug-only qemu_log. Cc: Alexander Graf Signed-off-by: Paolo Bonzini --- target-s390x/cc_helper.c | 2 +- target-s390x/misc_helper.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target-s390x/cc_helper.c b/target-s390x/cc_helper.c index bfce3f1..c4ee002 100

[Qemu-devel] [PATCH 07/11] tricore: avoid "naked" qemu_log

2015-12-12 Thread Paolo Bonzini
Cc: Bastian Koppelmann Signed-off-by: Paolo Bonzini --- target-tricore/helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target-tricore/helper.c b/target-tricore/helper.c index 1808b28..1b70429 100644 --- a/target-tricore/helper.c +++ b/target-tricore/helper.c @@ -

[Qemu-devel] [PATCH 00/11] Avoid always-active qemu_log calls

2015-12-12 Thread Paolo Bonzini
qemu_log calls should generally be wrapped by DEBUG_* preprocessor symbols or (preferred) qemu_log_mask should be used instead. This avoids that the upcoming integration of logging and tracing prints some log messages to stderr unconditionally. Similarly, most occurrences of qemu_log_enabled() s

[Qemu-devel] [PATCH 03/11] cris: avoid "naked" qemu_log

2015-12-12 Thread Paolo Bonzini
Cc: Edgar E. Iglesias Signed-off-by: Paolo Bonzini --- hw/char/etraxfs_ser.c | 2 +- target-cris/helper.h| 1 - target-cris/op_helper.c | 5 - target-cris/translate.c | 2 +- target-cris/translate_v10.c | 2 +- 5 files changed, 3 insertions(+), 9 deletions(-) diff --gi

[Qemu-devel] [PATCH 10/11] linux-user: avoid "naked" qemu_log

2015-12-12 Thread Paolo Bonzini
Ensure that all log writes are protected by qemu_loglevel_mask or, in serious cases, go to both the log and stderr. Signed-off-by: Paolo Bonzini --- linux-user/main.c | 71 --- 1 file changed, 31 insertions(+), 40 deletions(-) diff --git a/lin

[Qemu-devel] [PATCH 06/11] ppc: cleanup logging

2015-12-12 Thread Paolo Bonzini
Avoid "naked" qemu_log, bring documentation for DEBUG #defines up to date. Cc: David Gibson Signed-off-by: Paolo Bonzini --- target-ppc/excp_helper.c | 1 + target-ppc/mmu-hash32.c | 12 ++-- target-ppc/mmu-hash64.c | 9 + target-ppc/mmu_helper.c | 15 ++

[Qemu-devel] [PATCH 02/11] alpha: convert "naked" qemu_log to tracepoint

2015-12-12 Thread Paolo Bonzini
Cc: Richard Henderson Signed-off-by: Paolo Bonzini --- hw/alpha/pci.c | 3 ++- trace-events | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/alpha/pci.c b/hw/alpha/pci.c index d839dd5..5226e43 100644 --- a/hw/alpha/pci.c +++ b/hw/alpha/pci.c @@ -10,6 +10,7 @@ #include

Re: [Qemu-devel] [PATCH 1/1] Fix do_rt_sigreturn on m68k linux userspace emulation

2015-12-12 Thread Laurent Vivier
Le 12/12/2015 10:55, Michael Karcher a écrit : > On 09.12.2015 23:03, Laurent Vivier wrote: >> >> Le 09/12/2015 21:54, Michael Karcher a écrit : >>> do_rt_sigreturn forgets to initialize the signal mask variable before >>> trying to use it to restore the mask, so the signal mask is undefined >>>

Re: [Qemu-devel] [RFC PATCH 0/8] Towards an Heterogeneous QEMU

2015-12-12 Thread Christian Pinto
Hello Peter, Apologies for the highly delayed response. On Nov 13, 2015 08:02, "Peter Crosthwaite" wrote: > > Hi Christian, > > Sorry about the delayed response. > > On Tue, Oct 27, 2015 at 3:30 AM, Christian Pinto < c.pi...@virtualopensystems.com> wrote: >> >> >> >> On 25/10/2015 22:38, Peter C

[Qemu-devel] [PATCH 1/1 v2] Fix do_rt_sigreturn on m68k linux userspace emulation

2015-12-12 Thread Michael Karcher
do_rt_sigreturn uses an uninitialised local variable instead of fetching the old signal mask directly from the signal frame when restoring the mask, so the signal mask is undefined after do_rt_sigreturn. As the signal frame data is in target-endian order, target_to_host_sigset instead of target_to_

[Qemu-devel] [PATCH 0/1 v2] Fix do_rt_sigreturn on m68k linux userspace emulation

2015-12-12 Thread Michael Karcher
Changelog: v2: Avoid unneeded copy, use correct endianness. Michael Karcher (1): Fix do_rt_sigreturn on m68k linux userspace emulation linux-user/signal.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.1.4