Re: [Qemu-devel] [PULL 04/05] seccomp: add setuid, setgid, chroot and setgroups to whitelist

2015-11-01 Thread Paolo Bonzini
On 30/10/2015 14:44, Eduardo Otubo wrote: > From: Namsun Ch'o > > The seccomp sandbox doesn't whitelist setuid, setgid, or setgroups, which are > needed for -runas to work. It also doesn't whitelist chroot, which is needed > for the -chroot option. Unfortunately, QEMU enables seccomp before it

Re: [Qemu-devel] [RFC PATCH 0/5] Introduce Intel 82574 GbE Controller Emulation (e1000e)

2015-11-01 Thread Dmitry Fleytman
> On 2 Nov 2015, at 05:35 AM, Jason Wang wrote: > > > > On 10/31/2015 01:52 PM, Dmitry Fleytman wrote: >> Hello Jason, >> >> Thanks for reviewing. See my answers inline. >> >> >>> On 30 Oct 2015, at 07:28 AM, Jason Wang >> >>>

[Qemu-devel] [v2 RESEND 2/4] migration: rename qemu_savevm_state_cancel

2015-11-01 Thread Liang Li
The function qemu_savevm_state_cancel is called after the migration in migration_thread, it seems strange to 'cancel' it after completion, rename it to qemu_savevm_state_cleanup looks better. Signed-off-by: Liang Li --- include/sysemu/sysemu.h | 2 +- migration/migration.c | 2 +- migration/sa

[Qemu-devel] [v2 RESEND 4/4] migration: code clean up

2015-11-01 Thread Liang Li
Just clean up code, no behavior change. Signed-off-by: Liang Li --- migration/block.c | 9 ++--- migration/ram.c | 9 ++--- 2 files changed, 4 insertions(+), 14 deletions(-) diff --git a/migration/block.c b/migration/block.c index ecfe005..cf9d9f8 100644 --- a/migration/block.c +++ b/

[Qemu-devel] [v2 RESEND 3/4] migration: rename cancel to cleanup in SaveVMHandles

2015-11-01 Thread Liang Li
'cleanup' seems more appropriate than 'cancel'. Signed-off-by: Liang Li --- include/migration/vmstate.h | 2 +- migration/block.c | 2 +- migration/ram.c | 2 +- migration/savevm.c | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/mig

[Qemu-devel] [v2 RESEND 0/4] Fix long vm downtime during live migration

2015-11-01 Thread Liang Li
The patch 3ea3b7fa9af067982f34b of kvm introduces a lazy collapsing of small sptes into large sptes mechanism, which intend to solve the performance drop issue if live migration fails or is canceled. The rmap will be scanned in the KVM_SET_USER_MEMORY_REGION ioctl context when dirty logging is stop

[Qemu-devel] [v2 RESEND 1/4] migration: defer migration_end & blk_mig_cleanup

2015-11-01 Thread Liang Li
Because of the patch 3ea3b7fa9af067982f34b of kvm, which introduces a lazy collapsing of small sptes into large sptes mechanism, now migration_end() is a time consuming operation because it calls memroy_global_dirty_log_stop(), which will trigger the dropping of small sptes operation and takes abou

Re: [Qemu-devel] [PATCH v3 1/2] qemu-iotests: fix cleanup of background processes

2015-11-01 Thread Markus Armbruster
Max Reitz writes: > On 30.10.2015 20:25, Jeff Cody wrote: >> Commit 934659c switched the iotests to run qemu and qemu-nbd from a bash >> subshell, in order to catch segfaults. Unfortunately, this means the >> process PID cannot be captured via '$!'. We stopped killing qemu and >> qemu-nbd proces

Re: [Qemu-devel] [PATCH v2] hw/misc: Add support for ADC controller in Xilinx Zynq 7000

2015-11-01 Thread Peter Crosthwaite
I've made a v3 of this, some comments on changes below. On Sun, Sep 13, 2015 at 12:08 PM, Peter Crosthwaite wrote: > On Sat, Sep 12, 2015 at 2:08 PM, Guenter Roeck wrote: >> Add support for the Xilinx XADC core used in Zynq 7000. >> >> References: >> - Zynq-7000 All Programmable SoC Technical Re

Re: [Qemu-devel] [RESEND V10 0/3] Move sdhci.h to include/hw/sd

2015-11-01 Thread Sai Pavan Boddu
> -Original Message- > From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Saturday, October 31, 2015 11:27 PM > To: Sai Pavan Boddu > Cc: qemu-devel@nongnu.org Developers; Peter Maydell; Stefan Hajnoczi; > Alistair Francis; Edgar Iglesias; Sai Pavan Boddu > Subject: Re: [

Re: [Qemu-devel] [RFC PATCH 0/5] Introduce Intel 82574 GbE Controller Emulation (e1000e)

2015-11-01 Thread Jason Wang
On 10/31/2015 01:52 PM, Dmitry Fleytman wrote: > Hello Jason, > > Thanks for reviewing. See my answers inline. > > >> On 30 Oct 2015, at 07:28 AM, Jason Wang > > wrote: >> >> >> >> On 10/28/2015 01:44 PM, Jason Wang wrote: >>> >>> On 10/26/2015 01:00 AM, Leonid Bloch w

Re: [Qemu-devel] [PATCH v4 3/3] aio: Introduce aio-epoll.c

2015-11-01 Thread Fam Zheng
On Fri, 10/30 10:07, Stefan Hajnoczi wrote: > On Fri, Oct 30, 2015 at 12:06:29PM +0800, Fam Zheng wrote: > > To comply with aio_{disable,enable}_external, we always use ppoll when > > aio_external_disabled() is true. > > All file descriptors are added to the epoll fd. Does that mean epoll > will

[Qemu-devel] [PATCH] ivshmem-server: fix possible OVERRUN

2015-11-01 Thread arei.gonglei
From: Gonglei >>> CID 1337991: Memory - illegal accesses (OVERRUN) >>> Decrementing "i". The value of "i" is now 65534. 218 while (i--) { 219 event_notifier_cleanup(&peer->vectors[i]); 220 } Signed-off-by: Gonglei --- contrib/ivshmem-server/ivshmem-server.

Re: [Qemu-devel] [PATCH] target-tilegx: Implement floating point instructions

2015-11-01 Thread Chen Gang
Sorry, based on this patch, after fix 5 issues, it still has issues. The issues which I have fixed are:  - Fix floating point fdouble multiply related instructions issues  - Process every overflow cases.  - Process absolute multiply carrying just like absolute add has done.  - Process the near

[Qemu-devel] [Bug 1512134] [NEW] Multiboot v1 memory map offset wrong

2015-11-01 Thread Tristan Parisot
Public bug reported: I'm developping a multiboot kernel for multiboot v1 My multiboot header contains the V1 magic (0x1BADB002) and the flags 0x00010243 (with enabled memory detection, and boot loader name) When booted in multiboot, Qemu gives me two pointers: unsigned long mmap_length; unsign

[Qemu-devel] [Bug 1512134] Re: Multiboot v1 memory map offset wrong

2015-11-01 Thread Tristan Parisot
I forgot to tell how i detected the issue: I print all the fields, and in "type", i had the size of the next entry (and in size, i have always zero, which corresponds to the high part of addr) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

Re: [Qemu-devel] [PATCH] blockdev: acquire AioContext in hmp_commit()

2015-11-01 Thread Denis V. Lunev
On 10/30/2015 06:57 PM, Stefan Hajnoczi wrote: This one slipped through. Although we acquire AioContext when committing all devices we don't for just a single device. AioContext must be acquired before calling bdrv_*() functions to synchronize access with other threads that may be using the Aio

Re: [Qemu-devel] Periodic timer for VIRTUAL_CLOCK causes deadlock in icount mode

2015-11-01 Thread James Nutaro
A follow up to my previous email. I see the same behavior with the command qemu-system-i386 -sdl -icount 1 linux-0.2.img On Sun, Nov 1, 2015 at 9:09 AM, James Nutaro wrote: > I have encountered the following unexpected behavior while trying to > synchronize the virtual clock in qemu to a simulat

[Qemu-devel] Segmentation fault when running qemu-system-s390x

2015-11-01 Thread Philipp Kern
[Resent with the correct list address] Hi, I get a segmentation fault when trying to run qemu-system-s390x with a simple Debian kernel and initrd. According to git bisect: 0a1c71cec63e95f9b8d0dc96d049d2daa00c5210 is the first bad commit commit 0a1c71cec63e95f9b8d0dc96d049d2daa00c5210 Author: Pe

[Qemu-devel] Periodic timer for VIRTUAL_CLOCK causes deadlock in icount mode

2015-11-01 Thread James Nutaro
I have encountered the following unexpected behavior while trying to synchronize the virtual clock in qemu to a simulation clock in another software package. Is this something to be expected, or a bug that can be fixed? The issue can be reliably reproduced by making the following changes to qemu.

Re: [Qemu-devel] [PATCH 1/4] fifolock: create rfifolock_is_locked helper

2015-11-01 Thread Denis V. Lunev
On 10/30/2015 06:41 PM, Stefan Hajnoczi wrote: On Wed, Oct 28, 2015 at 06:01:02PM +0300, Denis V. Lunev wrote: +int rfifolock_is_locked(RFifoLock *r); Please use bool instead of int. diff --git a/util/rfifolock.c b/util/rfifolock.c index afbf748..8ac58cb 100644 --- a/util/rfifolock.c +++ b/u

[Qemu-devel] [PATCH V4] hw/virtio: Add PCIe capability to virtio devices

2015-11-01 Thread Marcel Apfelbaum
The virtio devices are converted to PCI-Express if they are plugged into a PCI-Express bus and the 'modern' protocol is enabled. Devices plugged directly into the Root Complex as Integrated Endpoints remain PCI. Signed-off-by: Marcel Apfelbaum --- v3 -> v4: - Addressed Eduardo Habkost's comment

[Qemu-devel] [Bug 1509336] Re: USB passthru not work with Mac OS X El Capitan

2015-11-01 Thread Okra
My problem was solved by using the UEFI boot loader and I followed the instructions at the following links: https://github.com/tianocore/tianocore.github.io/wiki/How-to-build-OVMF http://www.linux-kvm.org/downloads/lersek/ovmf-whitepaper-c770f8c.txt Also remove the "-bios" option above and adde

Re: [Qemu-devel] [PATCH V3] hw/virtio: Add PCIe capability to virtio devices

2015-11-01 Thread Marcel Apfelbaum
On 10/30/2015 05:20 PM, Eduardo Habkost wrote: On Thu, Oct 29, 2015 at 01:56:28PM +0200, Marcel Apfelbaum wrote: [...] index 095de5d..0a08531 100644 --- a/include/hw/compat.h +++ b/include/hw/compat.h @@ -2,7 +2,51 @@ #define HW_COMPAT_H #define HW_COMPAT_2_4 \ -/* empty */ +