Re: [Qemu-devel] [PATCH COLO-Frame v9 05/32] migration: Integrate COLO checkpoint process into migration

2015-10-09 Thread zhanghailiang
On 2015/10/10 0:53, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: Add a migrate state: MIGRATION_STATUS_COLO, enter this migration state after the first live migration successfully finished. Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian Signed-

Re: [Qemu-devel] [PATCH v4 3/5] acpi: pc: add fw_cfg device node to ssdt

2015-10-09 Thread Gabriel L. Somlo
On Thu, Oct 01, 2015 at 01:33:50PM +0200, Igor Mammedov wrote: > On Thu, 1 Oct 2015 10:27:15 +0200 > Laszlo Ersek wrote: > > > On 10/01/15 09:02, Igor Mammedov wrote: > > > On Sun, 27 Sep 2015 17:29:00 -0400 > > > "Gabriel L. Somlo" wrote: > > > > > >> Add a fw_cfg device node to the ACPI SSDT,

Re: [Qemu-devel] [PATCH V1] sdhci: Fix hostctl2 write logic.

2015-10-09 Thread Sai Pavan Boddu
Hi Peter, > -Original Message- > From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Thursday, October 08, 2015 9:22 PM > To: Alistair Francis > Cc: Sai Pavan Boddu; Peter Maydell; Stefan Hajnoczi; qemu- > de...@nongnu.org Developers; Edgar Iglesias; Alistair Francis > Subj

[Qemu-devel] [PATCH v8 00/27] vhost-user: add migration support

2015-10-09 Thread marcandre . lureau
From: Marc-André Lureau Hi, The following series implement shareable log for vhost-user to support memory tracking during live migration. On qemu-side, the solution is fairly straightfoward since vhost already supports the dirty log, only vhost-user couldn't access the log memory until then. Th

Re: [Qemu-devel] [PATCH 2/2] kvm/x86: Hyper-V kvm exit

2015-10-09 Thread Roman Kagan
On Fri, Oct 09, 2015 at 04:41:15PM +0200, Paolo Bonzini wrote: > On 09/10/2015 15:39, Denis V. Lunev wrote: > > A new vcpu exit is introduced to notify the userspace of the > > changes in Hyper-V synic configuraion triggered by guest writing to the > > corresponding MSRs. > > Why is this exit nece

[Qemu-devel] [PATCH v8 04/27] build-sys: split util-obj- on multi-lines

2015-10-09 Thread marcandre . lureau
From: Marc-André Lureau Make it easier to add new unrelated units with shorter lines. Signed-off-by: Marc-André Lureau --- util/Makefile.objs | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/util/Makefile.objs b/util/Makefile.objs index 372e037..f217901 100644 -

[Qemu-devel] [PATCH 09/12] block: Add "drained begin/end" for transactional blockdev-backup

2015-10-09 Thread Fam Zheng
Similar to the previous patch, make sure that external events are not dispatched during transaction operations. Signed-off-by: Fam Zheng --- blockdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index 232bc21..015afbf 100644 --- a/blockdev.c ++

[Qemu-devel] [RFC 1/3] arm: boot: Add board specific setup code API

2015-10-09 Thread Peter Crosthwaite
Add an API for boards to inject their own preboot software (or firmware) seqeuence. The software then returns to bootloader via the link register. This allows boards to do their own little bits of firmware setup without needed to replace the bootloader completely (which is the requirement for exis

[Qemu-devel] [RFC 3/3] arm: xilinx_zynq: Add linux pre-boot

2015-10-09 Thread Peter Crosthwaite
Add a Linux-specific pre-boot routine that matches the device specific bootloaders behaviour. This is needed for modern Linux that expects the ARM PLL in SLCR to be a more even value (not 26). FIXME: The blob population should only happen on Linux boots. Signed-off-by: Peter Crosthwaite --- hw/

[Qemu-devel] [RFC 2/3] arm: highbank: Implement dummy monitor

2015-10-09 Thread Peter Crosthwaite
Firstly, enable monitor mode and PSCI, both are which are features of this board. In addition to PSCI, this board also uses SMC for cache maintainence ops. This means we need a secure monitor to catch these and nop them. Use the ARM boot board setup blob to implement this. FIXME: The blob populat

[Qemu-devel] [RFC 0/3] ARM: Machine specific boot blobs

2015-10-09 Thread Peter Crosthwaite
Hi, This adds support for machine specific primary boot blobs. This can be used to install little bits of firmware or boot code without having to throw the whole QEMU bootloader out and BYO (with device drivers and all). It is then used to fix two boards, Zynq and Highbank, both which have small

Re: [Qemu-devel] [PULL 12/25] vhost: use a function for each call

2015-10-09 Thread Thibaut Collet
On Thu, Oct 8, 2015 at 11:17 PM, Michael S. Tsirkin wrote: > From: Marc-André Lureau > > Replace the generic vhost_call() by specific functions for each > function call to help with type safety and changing arguments. > > While doing this, I found that "unsigned long long" and "uint64_t" were > u

[Qemu-devel] [RFC] Block device size rounding

2015-10-09 Thread Peter Crosthwaite
I have in interesting problem with SD cards, where if you pass a block device that is not multiple-of-512k size the last bit gets chopped off. The problem is the card can only report a 512kX size to the guest, so a significant rounding is needed one way or the other. The current round-down policy c

Re: [Qemu-devel] [PATCH 1/4] hw/core: Add iommu to machine properties

2015-10-09 Thread Peter Crosthwaite
On Fri, Oct 9, 2015 at 5:17 AM, David kiarie wrote: > On Thu, Oct 8, 2015 at 9:10 PM, Marcel Apfelbaum > wrote: >> On 10/09/2015 05:53 AM, David Kiarie wrote: >>> >>> From: David >>> >>> Add iommu to machine properties in preparation of introducing >>> AMD IOMMU >>> >>> Signed-off-by: David

[Qemu-devel] [PULL 1/2] docs: update the usage example of "dtrace" backend in tracing.txt

2015-10-09 Thread Stefan Hajnoczi
From: Lin Ma The usage example of dtrace is quite ancient, We have tracetool.py with different parameters instead of the original tracetool shell script for a long time, So update the old information. Signed-off-by: Lin Ma Message-id: 1441954730-17341-1-git-send-email-...@suse.com Signed-off-by

[Qemu-devel] [PATCH] arm: imx25-pdk: Fix machine name

2015-10-09 Thread Peter Crosthwaite
ARM uses dashes instead of underscores for machine names. Fix imx25_pdk which has not seen a release yet (so there is no legacy yet). Cc: Jean-Christophe Dubois Signed-off-by: Peter Crosthwaite --- hw/arm/imx25_pdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/imx

[Qemu-devel] [PATCH] misc: zynq_slcr: Fix MMIO writes

2015-10-09 Thread Peter Crosthwaite
The /4 for offset calculation in MMIO writes was happening twice giving wrong write offsets. Fix. While touching the code, change the if-else to be a short returning if and convert the debug message to a GUEST_ERROR, which is more accurate for this condition. Cc: qemu-sta...@nongnu.org Cc: Guente

[Qemu-devel] [PULL 1/5] sdhci: Pass drive parameter to sdhci-pci via qdev property

2015-10-09 Thread Stefan Hajnoczi
From: Kevin O'Connor Commit 19109131 disabled the sdhci-pci support because it used drive_get_next(). This patch reenables sdhci-pci and changes it to pass the drive via a qdev property - for example: -device sdhci-pci,drive=drive0 -drive id=drive0,if=sd,file=myimage Reviewed-by: Stefan Hajnoc

Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE

2015-10-09 Thread Fabio Fantoni
Il 27/01/2015 09:26, Markus Armbruster ha scritto: > Eric Blake writes: > >> On 01/26/2015 01:48 AM, Javier Celaya wrote: >>> Sorry, I forgot to patch the command-line help. Hope it helps. >>> > Recently, SPICE included the lz4 compression algorithm. This patch adds > a command line option

Re: [Qemu-devel] [PATCH 03/17] spec: add qcow2-dirty-bitmaps specification

2015-10-09 Thread Max Reitz
On 08.10.2015 22:28, John Snow wrote: [...] > (NB: I never got Max's original reply, so this reply is more to Max than > to Denis or Vladimir.) Let's hope you'll see this one, then. :-) > I'll see your wall of text and raise you my own wall of text... > > We consider the ability to use persist

Re: [Qemu-devel] [PATCH 05/12] aio: introduce aio_{disable, enable}_clients

2015-10-09 Thread Fam Zheng
On Fri, 10/09 16:31, Kevin Wolf wrote: > Am 09.10.2015 um 07:45 hat Fam Zheng geschrieben: > > Signed-off-by: Fam Zheng > > --- > > aio-posix.c | 3 ++- > > aio-win32.c | 3 ++- > > async.c | 42 ++ > > include/block/aio.h | 30

Re: [Qemu-devel] [PATCH] block: switch from g_slice allocator to malloc

2015-10-09 Thread Paolo Bonzini
On 09/10/2015 10:15, Kevin Wolf wrote: > > I did it about six months ago. Sorry for not digging up the results > > when posting: > > > > baseline: 193 kiops > > tcmalloc: 202 kiops > > tcmalloc + G_SLICE=always-malloc: 210 kiops > > Thanks. Do you have numbers for g_malloc + G_SLICE=always-mal

Re: [Qemu-devel] [Qemu-block] [PATCH v5 3/4] qmp: add monitor command to add/remove a child

2015-10-09 Thread Max Reitz
On 09.10.2015 18:42, Dr. David Alan Gilbert wrote: > * Max Reitz (mre...@redhat.com) wrote: >> On 08.10.2015 08:15, Markus Armbruster wrote: >>> Max Reitz writes: >>> On 22.09.2015 09:44, Wen Congyang wrote: > The new QMP command name is x-blockdev-child-add, and > x-blockdev-child-d

Re: [Qemu-devel] [PATCH] vmxnet3: Add support for VMXNET3_CMD_GET_ADAPTIVE_RING_INFO command

2015-10-09 Thread Jason Wang
On 10/01/2015 03:00 PM, Shmulik Ladkani wrote: > Ping... > > On Fri, 18 Sep 2015 08:55:04 +0300, shmulik.ladk...@ravellosystems.com wrote: >> Some drivers (e.g. vmware-tools) issue the VMXNET3_CMD_GET_ADAPTIVE_RING_INFO >> command. >> >> Currently, due to lack of support, a bogus value (-1) is re

Re: [Qemu-devel] [PATCH v2 2/2] target-arm: Fix CPU breakpoint handling

2015-10-09 Thread Peter Maydell
On 9 October 2015 at 14:53, Sergey Fedorov wrote: > On 08.10.2015 21:40, Peter Maydell wrote: >> On 28 September 2015 at 11:07, Sergey Fedorov wrote: >>> A QEMU breakpoint match is not definitely an architectural breakpoint >>> match. If an exception is generated unconditionally during translatio

[Qemu-devel] [PATCH v8 08/27] vhost: document log resizing

2015-10-09 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- hw/virtio/vhost.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index c0ed5b2..67e09fe 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -334,6 +334,8 @@ static inline void vhost_d

Re: [Qemu-devel] [PATCH v10 02/10] Backup: clear all bitmap when doing block checkpoint

2015-10-09 Thread Eric Blake
On 09/25/2015 12:17 AM, Wen Congyang wrote: s/bitmap/bitmaps/ in the subject line. The subject line says "what", but you are missing a commit body that says "why". > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > Reviewed-by: Jeff Cody > --- -- Eric B

Re: [Qemu-devel] [PATCH 1/1] migration: fix expected_downtime

2015-10-09 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Igor Redko (red...@virtuozzo.com) wrote: >> On 28.09.2015 22:22, Dr. David Alan Gilbert wrote: >> >* Denis V. Lunev (d...@openvz.org) wrote: >> >>From: Igor Redko >> >> >> >>To get this estimation we must divide pending_size by bandwidth >> >>according to descr

[Qemu-devel] [PATCH 12/12] qed: Implement .bdrv_drain

2015-10-09 Thread Fam Zheng
The "need_check_timer" is used to clear the "NEED_CHECK" flag in the image header after a grace period once metadata update has finished. In compliance to the bdrv_drain semantics we should make sure it remains deleted once .bdrv_drain is called. Call the qed_need_check_timer_cb manually to update

Re: [Qemu-devel] [PATCH 4/5] tests/i44fx-test: No need for zeroing memory before memset

2015-10-09 Thread Laszlo Ersek
On 10/09/15 08:46, Markus Armbruster wrote: > Laszlo Ersek writes: > >> On 10/08/15 21:35, Thomas Huth wrote: >>> Change a g_malloc0 into g_malloc since the following >>> memset fills the whole buffer anyway. >>> >>> Cc: Laszlo Ersek >>> Signed-off-by: Thomas Huth >>> --- >>> tests/i440fx-test

Re: [Qemu-devel] [PATCH] armv7-m: exit on external reset request

2015-10-09 Thread Peter Crosthwaite
On Fri, Oct 9, 2015 at 10:25 AM, Michael Davidsaver wrote: > > > On 10/09/2015 12:59 PM, Peter Maydell wrote: >> On 8 October 2015 at 16:40, Michael Davidsaver wrote: >>> ... >>> case 0xd0c: /* Application Interrupt/Reset Control. */ >>> if ((value >> 16) == 0x05fa) { >>> +

[Qemu-devel] [PULL 5/5] sdhci.c: Limit the maximum block size

2015-10-09 Thread Stefan Hajnoczi
From: Alistair Francis It is possible for the guest to set an invalid block size which is larger then the fifo_buffer[] array. This could cause a buffer overflow. To avoid this limit the maximum size of the blksize variable. Signed-off-by: Alistair Francis Reported-by: Intel Security ATR Revi

[Qemu-devel] [PATCH v8 14/27] vhost: use a function for each call

2015-10-09 Thread marcandre . lureau
From: Marc-André Lureau Replace the generic vhost_call() by specific functions for each function call to help with type safety and changing arguments. While doing this, I found that "unsigned long long" and "uint64_t" were used interchangeably and causing compilation warnings, using uint64_t ins

[Qemu-devel] [Bug 1504513] [NEW] Socket leak on each call to qemu_socket()

2015-10-09 Thread Mark Pizzolato
Public bug reported: On any host platform where SOCK_CLOEXEC is defined (Linux at least), a socket is leaked on each call to qemu_socket() AND the socket returned hasn't been created with the desired SOCK_CLOEXEC attribute. The qemu_socket routine is: Line 272 of util/osdep.c: /* * Opens a sock

[Qemu-devel] [PULL 0/2] Tracing patches

2015-10-09 Thread Stefan Hajnoczi
The following changes since commit 1d27b91723c252d9a97151dc1959cfd89c5816cb: Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20151007.0' into staging (2015-10-08 16:50:34 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/tracing-pull-requ

[Qemu-devel] [PATCH 2/2] kvm/x86: Hyper-V kvm exit

2015-10-09 Thread Denis V. Lunev
From: Andrey Smetanin A new vcpu exit is introduced to notify the userspace of the changes in Hyper-V synic configuraion triggered by guest writing to the corresponding MSRs. Signed-off-by: Andrey Smetanin Reviewed-by: Roman Kagan Signed-off-by: Denis V. Lunev CC: Vitaly Kuznetsov CC: "K. Y.

[Qemu-devel] simple qmp core dump

2015-10-09 Thread Eric Blake
Just noticed this core dump (I was actually trying to exceed the 1024 hard-baked limit in qmp-input-visitor.c which tries to set an Error object, but it looks like that limit was unreachable due to this earlier assertion): $ printf '{"execute":"qmp_capabilities","id":%1025s' " " | tr ' ' { | .

[Qemu-devel] [PULL 02/20] MAINTAINERS: Specify QObject include and test files

2015-10-09 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-Id: <144317-29831-3-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 79ffe88..f9a46ec 100644 --- a/MAINT

[Qemu-devel] [PATCH 3/3] armv7-m: add MPU to cortex-m3 and cortex-m4

2015-10-09 Thread Michael Davidsaver
The M series MPU is almost the same as the already implemented R series MPU. So use the M series and translate as best we can. The HFNMIENA bit in MPU_CTRL is not implemented. Implement CFSR and MMFAR to report fault address to MemManage handler. Add MPU feature flag to cortex-m3 and -m4. ---

[Qemu-devel] [PATCH 08/12] block: Add "drained begin/end" for transactional backup

2015-10-09 Thread Fam Zheng
This ensures the atomicity of the transaction by avoiding processing of external requests such as those from ioeventfd. Move the assignment to state->bs up right after bdrv_drained_begin, so that we can use it in the clean callback. The abort callback will still check bs->job and state->job, so it

Re: [Qemu-devel] [PATCH] Add syscalls for -runas and -chroot to the seccomp sandbox

2015-10-09 Thread Eduardo Otubo
On Fri, Oct 09, 2015 at 08=54=33AM +0200, Markus Armbruster wrote: > namn...@sigaint.org writes: > > >> ps.: the threads are still being broken by your emails and it's a pain > >> to track down all of them in order to read. Please fix it. > > > > I'm really sorry, I am not able to sign up to Googl

Re: [Qemu-devel] [PATCH v12 2/5] apic: use per CPU AS to map APIC MMIO for TCG

2015-10-09 Thread Zhu Guihua
On 10/03/2015 03:21 AM, Eduardo Habkost wrote: On Fri, Oct 02, 2015 at 03:24:24PM -0300, Eduardo Habkost wrote: On Tue, Sep 22, 2015 at 02:29:01PM +0200, Igor Mammedov wrote: On Wed, 16 Sep 2015 17:19:12 +0800 Zhu Guihua wrote: TCG supports per CPU address space, and the emulation quality i

Re: [Qemu-devel] [PATCH 1/2] [RFC] arm_gic_common.h: add gicv2 aliases for defines

2015-10-09 Thread Peter Maydell
On 6 October 2015 at 15:37, Andrew Jones wrote: > I'm not sure if arm_gic_common.h is supposed to be common, not > only between tcg and kvm, but also v2 and v3, but it currently > is (arm_gicv3_common.h includes it, and it's the only gic header > included by hw/arm/virt.c). I don't think it shoul

Re: [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-10-09 Thread Kevin Wolf
Am 08.10.2015 um 18:44 hat John Snow geschrieben: > On 10/08/2015 08:06 AM, Peter Lieven wrote: > > Hi all, > > > > short summary from my side. The whole thing seems to get complicated, > > let me explain why: > > > > 1) During review I found that the code in ide_atapi_cmd_reply_end can't > > wor

Re: [Qemu-devel] [PATCH 2/3] virtio-9p: add unrealize handler

2015-10-09 Thread Michael S. Tsirkin
On Fri, Oct 09, 2015 at 09:23:49AM +0200, Greg Kurz wrote: > On Wed, 07 Oct 2015 14:20:28 +0530 > "Aneesh Kumar K.V" wrote: > > > Stefan Hajnoczi writes: > > > > > On Mon, Oct 05, 2015 at 11:07:23AM +0200, Greg Kurz wrote: > > >> If the user tries to hot unplug a virtio-9p device, it seems to s

[Qemu-devel] [PULL 08/20] qapi: Test for various name collisions

2015-10-09 Thread Markus Armbruster
From: Eric Blake Expose some weaknesses in the generator: we don't always forbid the generation of structs that contain multiple members that map to the same C or QMP name. This has already been marked FIXME in qapi.py in commit d90675f, but having more tests will make sure future patches produc

Re: [Qemu-devel] [PATCH v2] Remove macros IO_READ_PROTO and IO_WRITE_PROTO

2015-10-09 Thread Gerd Hoffmann
On Mi, 2015-10-07 at 21:34 +0200, Markus Armbruster wrote: > Copying maintainer. Please use scripts/get_maintainer.pl to find them > yourself. Thanks, picked up now. Including the subsystem in the subject (i.e. "audio: remove macros ...") is useful too. cheers, Gerd

[Qemu-devel] [PATCH v2 1/4] hw/dma/pxa2xx: Remove superfluous memset

2015-10-09 Thread Thomas Huth
g_malloc0 already clears the memory, so no need for the additional memset here. And while we're at it, also convert the g_malloc0 to the preferred g_new0. Signed-off-by: Thomas Huth --- hw/dma/pxa2xx_dma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/dma/pxa2xx_dma.c

[Qemu-devel] [PULL 10/11] gtk/opengl: add opengl context and scanout support (egl)

2015-10-09 Thread Gerd Hoffmann
This allows virtio-gpu to render in 3d mode. Uses egl, for gtk versions 3.14 and older. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau --- include/ui/gtk.h | 16 +++ ui/gtk-egl.c | 131 +++ ui/gtk.c | 7 +++ 3 f

Re: [Qemu-devel] [PATCH v2] spice: Allow to set password even if disable-ticketing was used

2015-10-09 Thread Christophe Fergeau
Hey, On Fri, Aug 14, 2015 at 05:10:57PM +0200, Christophe Fergeau wrote: > Before commit b1ea7b79e1, it was possible to start with -spice > disable-ticketing, and then use the "set_password spice" command to > enable ticketing with SPICE. Since commit b1ea7b79e1 this is no longer > possible as qem

[Qemu-devel] [PULL 01/20] docs: Move files from docs/qmp/ to docs/

2015-10-09 Thread Markus Armbruster
Giving QMP its own subdirectory in docs/ is hardly worthwhile when we have just four files, and one of them isn't even in the subdirectory. Move the files from docs/qmp/ to docs/, renaming docs/qmp/README to docs/qmp-intro. Update MAINTAINERS. The new pattern also captures the fourth file docs/wr

[Qemu-devel] [PATCH v8 13/27] vhost-user: add a migration blocker

2015-10-09 Thread marcandre . lureau
From: Marc-André Lureau If VHOST_USER_PROTOCOL_F_LOG_SHMFD is not announced, block vhost-user migration. The blocker is removed in vhost_dev_cleanup(). Signed-off-by: Marc-André Lureau --- hw/virtio/vhost-user.c | 9 + hw/virtio/vhost.c | 16 2 files changed, 21

[Qemu-devel] [PULL 0/5] Block patches

2015-10-09 Thread Stefan Hajnoczi
The following changes since commit 1d27b91723c252d9a97151dc1959cfd89c5816cb: Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20151007.0' into staging (2015-10-08 16:50:34 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull-reques

Re: [Qemu-devel] [PATCH v9 00/24] Generate ACPI v5.1 tables and expose them to guest over fw_cfg on ARM

2015-10-09 Thread Laszlo Ersek
On 10/10/15 00:34, liang yan wrote: > Hello, Shannon, >> From: Shannon Zhao >> >> This patch series generate seven ACPI tables for machine virt on ARM. >> The set of generated tables are: >> - RSDP >> - RSDT >> - MADT >> - GTDT >> - FADT >> - DSDT >> - MCFG (For PCIe host bridge) >> >> These table

[Qemu-devel] [PATCH v8 05/27] util: add linux-only memfd fallback

2015-10-09 Thread marcandre . lureau
From: Marc-André Lureau Implement memfd_create() fallback if not available in system libc. memfd_create() is still not included in glibc today, atlhough it's been available since Linux 3.17 in Oct 2014. memfd has numerous advantages over traditional shm/mmap for ipc memory sharing with fd handle

Re: [Qemu-devel] [PATCH v8 27/27] seccomp: add memfd_create to whitelist

2015-10-09 Thread Eduardo Otubo
On Fri, Oct 09, 2015 at 05=17=41PM +0200, marcandre.lur...@redhat.com wrote: > From: Eduardo Otubo > > This is used by memfd code. > > Signed-off-by: Eduardo Otubo > Signed-off-by: Marc-André Lureau > --- > qemu-seccomp.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --g

[Qemu-devel] [Bug 1465935] Re: kvm_irqchip_commit_routes: Assertion `ret == 0' failed

2015-10-09 Thread Stefan Bader
SRU Justification: Impact: Moving around interrupt handling on SMP (like irqbalance does) in qemu instances can cause the qemu guest to crash due to an internal accounting mismatch. Fix: Backported patch from upstream qemu Testcase: See above. Verified for Trusty with provided test qemu package(

[Qemu-devel] [PATCH v8 11/27] vhost: alloc shareable log

2015-10-09 Thread marcandre . lureau
From: Marc-André Lureau If the backend is requires it, allocate shareable memory. vhost_log_get() now uses 2 globals "vhost_log" and "vhost_log_shm", that way there is a common non-shareable log and a common shareable one. Signed-off-by: Marc-André Lureau --- hw/virtio/vhost.c | 57 ++

Re: [Qemu-devel] [PULL 00/19] Trivial patches for 2015-10-08

2015-10-09 Thread Peter Maydell
On 8 October 2015 at 17:52, Michael Tokarev wrote: > Another trivial-patches pull request. > Everything's trivial in there this time. > > Please consider applying/pulling. > > Thank you! > > /mjt > > The following changes since commit 31c9bd164ddb653915b9029ba0edd40cd57530d9: > > Merge remote-tr

Re: [Qemu-devel] [PATCH v10 09/10] support replication driver in blockdev-add

2015-10-09 Thread Eric Blake
On 09/25/2015 12:17 AM, Wen Congyang wrote: > Signed-off-by: Wen Congyang > --- Not sure if the commit message body should be empty, but no real suggestions on what to put there. > qapi/block-core.json | 21 ++--- > 1 file changed, 18 insertions(+), 3 deletions(-) > Reviewed-b

[Qemu-devel] [PATCH v8 22/27] vhost-user-test: remove useless static check

2015-10-09 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c index 827c0c4..4be5583 100644 --- a/tests/vhost-user-test.c +++ b/tests/vhost-user-test.c @@ -186,7 +186,6 @@

[Qemu-devel] [Bug 1498144] Re: Failure booting hurd with qemu-system-i386 on ARM

2015-10-09 Thread PeteVine
In case anyone's interested I've just discovered booting in recovery mode (root already logged in) doesn't exhibit the problem with non- working keyboard. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs

Re: [Qemu-devel] [PATCH COLO-Frame v9 04/32] migration: Add state records for migration incoming

2015-10-09 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > For migration destination, we also need to know its state, > we will use it in COLO. > > Here we add a new member 'state' for MigrationIncomingState, > and also use migrate_set_state() to modify its value. > We fix the first parameter of mi

Re: [Qemu-devel] [PULL 04/26] target-*: Introduce and use cpu_breakpoint_test

2015-10-09 Thread Sergey Fedorov
On 07.10.2015 12:43, Richard Henderson wrote: > Reduce the boilerplate required for each target. At the same time, > move the test for breakpoint after calling tcg_gen_insn_start. > > Note that arm and aarch64 do not use cpu_breakpoint_test, but still > move the inline test down after tcg_gen_insn

Re: [Qemu-devel] [PULL 00/25] virtio,pc features, fixes

2015-10-09 Thread Peter Maydell
On 8 October 2015 at 22:16, Michael S. Tsirkin wrote: > The following changes since commit 1d27b91723c252d9a97151dc1959cfd89c5816cb: > > Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20151007.0' > into staging (2015-10-08 16:50:34 +0100) > > are available in the git repository

Re: [Qemu-devel] [PATCH v2 1/4] hw/dma/pxa2xx: Remove superfluous memset

2015-10-09 Thread Eric Blake
On 10/09/2015 09:56 AM, Thomas Huth wrote: > g_malloc0 already clears the memory, so no need for > the additional memset here. And while we're at it, > also convert the g_malloc0 to the preferred g_new0. > > Signed-off-by: Thomas Huth > --- > hw/dma/pxa2xx_dma.c | 3 +-- > 1 file changed, 1 inse

Re: [Qemu-devel] [PATCH] target-tilegx: Let prefetch nop instructions return before allocating dest temporary register

2015-10-09 Thread Chen Gang
On 10/10/15 06:10, Richard Henderson wrote: > On 10/09/2015 09:48 AM, Chen Gang wrote: >> On 10/7/15 18:17, Chen Gang wrote: >>> On 10/7/15 17:19, Richard Henderson wrote: On 10/04/2015 10:15 PM, Chen Gang wrote: >> From 40ec3f1c75b4c97e3e0495c9e465be898f48a652 Mon Sep 17 00:00:00 2001 >

[Qemu-devel] [PATCH v8 10/27] vhost-user: add vhost_user_requires_shm_log()

2015-10-09 Thread marcandre . lureau
From: Marc-André Lureau Check if the backend has VHOST_USER_PROTOCOL_F_LOG_SHMFD feature and require a shared log. Signed-off-by: Marc-André Lureau --- hw/virtio/vhost-user.c| 14 -- include/hw/virtio/vhost-backend.h | 4 2 files changed, 16 insertions(+), 2 delet

Re: [Qemu-devel] [PATCH v7 04/14] qapi: Don't use info as witness of implicit object type

2015-10-09 Thread Eric Blake
On 10/07/2015 10:27 AM, Markus Armbruster wrote: >> def visit_needed(self, entity): >> # Visit everything except implicit objects >> -return not isinstance(entity, QAPISchemaObjectType) or entity.info >> +return not entity.is_implicit(QAPISchemaObjectType) > > The al

Re: [Qemu-devel] [PATCH 2/2] kvm/x86: Hyper-V kvm exit

2015-10-09 Thread Paolo Bonzini
On 09/10/2015 16:53, Roman Kagan wrote: >> > Why is this exit necessary? > The guest writes to synic-related MSRs and that should take "immediate" > effect. > > E.g. it may decide to disable or relocate the message page by writing to > SIMP MSR. The host is then supposed to stop accessing the o

Re: [Qemu-devel] [PATCH v9 00/24] Generate ACPI v5.1 tables and expose them to guest over fw_cfg on ARM

2015-10-09 Thread liang yan
Hello, Shannon, From: Shannon Zhao This patch series generate seven ACPI tables for machine virt on ARM. The set of generated tables are: - RSDP - RSDT - MADT - GTDT - FADT - DSDT - MCFG (For PCIe host bridge) These tables are created dynamically using the function of aml-build.c, taking into

[Qemu-devel] [PATCH v3 12/16] block: Introduce parents list

2015-10-09 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Fam Zheng --- block.c | 3 +++ include/block/block_int.h | 2 ++ 2 files changed, 5 insertions(+) diff --git a/block.c b/block.c index a2d6238..980437f 100644 --- a/block.c +++ b/block.c @@ -1090,6 +1090,7 @@ stati

Re: [Qemu-devel] [PULL v3 11/12] qdev: Protect device-list-properties against broken devices

2015-10-09 Thread Andreas Färber
Am 09.10.2015 um 16:36 schrieb Markus Armbruster: > Several devices don't survive object_unref(object_new(T)): they crash > or hang during cleanup, or they leave dangling pointers behind. > > This breaks at least device-list-properties, because > qmp_device_list_properties() needs to create a devi

Re: [Qemu-devel] [PATCH] target-tilegx: Let prefetch nop instructions return before allocating dest temporary register

2015-10-09 Thread Richard Henderson
On 10/09/2015 09:48 AM, Chen Gang wrote: On 10/7/15 18:17, Chen Gang wrote: On 10/7/15 17:19, Richard Henderson wrote: On 10/04/2015 10:15 PM, Chen Gang wrote: From 40ec3f1c75b4c97e3e0495c9e465be898f48a652 Mon Sep 17 00:00:00 2001 From: Chen Gang Date: Sun, 4 Oct 2015 17:34:17 +0800 Subject:

Re: [Qemu-devel] [PATCH v3 6/6] tcg/mips: Support r6 SEL{NE, EQ}Z instead of MOVN/MOVZ

2015-10-09 Thread James Hogan
On Thu, Oct 08, 2015 at 06:31:32PM +0200, Aurelien Jarno wrote: > On 2015-10-02 13:24, James Hogan wrote: > > Extend MIPS movcond implementation to support the SELNEZ/SELEQZ > > instructions introduced in MIPS r6 (where MOVN/MOVZ have been removed). > > > > Whereas the "MOVN/MOVZ rd, rs, rt" instr

Re: [Qemu-devel] [PATCH 1/2] kvm/x86: Hyper-V synthetic interrupt controller

2015-10-09 Thread Roman Kagan
On Fri, Oct 09, 2015 at 04:42:33PM +0200, Paolo Bonzini wrote: > You need to add SYNIC vectors to the EOI exit bitmap, so that APICv > (Xeon E5 or higher, Ivy Bridge or newer) is handled correctly. You also > need to check the auto EOI exit bitmap in __apic_accept_irq, and avoid > going through kv

[Qemu-devel] [PATCH v3 04/16] quorum: Convert to BdrvChild

2015-10-09 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Alberto Garcia Reviewed-by: Fam Zheng --- block/quorum.c | 65 ++ 1 file changed, 34 insertions(+), 31 deletions(-) diff --git a/block/quorum.c b/block/quorum.c index 8fe53b4.

Re: [Qemu-devel] [PATCH 0/4] AMD IOMMU v1

2015-10-09 Thread Valentine Sinitsyn
Hi David, Thanks for your efforts. On 09.10.2015 07:53, David Kiarie wrote: David (4): hw/core: Add iommu to machine properties hw/pci-host: Add AMD IOMMU to PIIX and Q35 pcs hw/i386: Introduce AMD IOMMU hw/acpi: ACPI table for AMD IOMMU hw/core/machine.c | 25 + hw/

Re: [Qemu-devel] [PATCH 1/4] hw/core: Add iommu to machine properties

2015-10-09 Thread David kiarie
On Thu, Oct 8, 2015 at 9:10 PM, Marcel Apfelbaum wrote: > On 10/09/2015 05:53 AM, David Kiarie wrote: >> >> From: David >> >> Add iommu to machine properties in preparation of introducing >> AMD IOMMU >> >> Signed-off-by: David Kiarie >> --- >> hw/core/machine.c | 25

[Qemu-devel] [PULL 2/5] virtio-blk: use blk_io_plug/unplug for Linux AIO batching

2015-10-09 Thread Stefan Hajnoczi
The raw-posix block driver implements Linux AIO batching so multiple requests can be submitted with a single io_submit(2) system call. Batching is currently only used by virtio-scsi and virtio-blk-data-plane. Enable batching for regular virtio-blk so the number of io_submit(2) system calls is redu

[Qemu-devel] [PULL 16/20] qapi: Consistent generated code: prefer common indentation

2015-10-09 Thread Markus Armbruster
From: Eric Blake We had some pointless differences in the generated code for visit, command marshalling, and events; unifying them makes it easier for future patches to consolidate to common helper functions. This is one patch of a series to clean up these differences. This patch adjusts gen_vis

[Qemu-devel] [PULL v3 08/12] libqtest: New hmp() & friends

2015-10-09 Thread Markus Armbruster
New convenience function hmp() to facilitate use of human-monitor-command in tests. Use it to simplify its existing uses. To blend into existing libqtest code, also add qtest_hmpv() and qtest_hmp(). That, and the egregiously verbose GTK-Doc comment format make this patch look bigger than it is.

[Qemu-devel] [PATCH v2] target-arm: Add MDCR_EL2

2015-10-09 Thread Sergey Fedorov
Signed-off-by: Sergey Fedorov --- Changes in v2: * Reset value is simply made zero target-arm/cpu.h| 1 + target-arm/helper.c | 11 +++ 2 files changed, 12 insertions(+) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index cc1578c..51d8ed1 100644 --- a/target-arm/cpu.h +++ b/ta

Re: [Qemu-devel] [PATCH 1/2] kvm/x86: Hyper-V synthetic interrupt controller

2015-10-09 Thread Paolo Bonzini
On 09/10/2015 17:53, Roman Kagan wrote: > > I really don't like this auto-EOI extension, but I guess that's the > > spec. :( If it wasn't for it, you could do everything very easily in > > userspace using Google's proposed MSR exit. > I guess you're right. We'd probably have to (ab)use MSI for S

Re: [Qemu-devel] [PULL 12/25] vhost: use a function for each call

2015-10-09 Thread Michael S. Tsirkin
On Fri, Oct 09, 2015 at 08:40:27AM +0200, Thibaut Collet wrote: > Hi Michael, > > this patch is not correct. If we apply QEMU enters in a dead lock if > we have several queue pairs for virttio/vhost and vhost backend > crashes during the initialisation sequence > I have sent some comments yesterda

[Qemu-devel] [PATCH 06/12] block: Introduce "drained begin/end" API

2015-10-09 Thread Fam Zheng
The semantics is that after bdrv_drained_begin(bs), bs will not get new external requests until the matching bdrv_drained_end(bs). Signed-off-by: Fam Zheng --- block.c | 2 ++ block/io.c| 18 ++ include/block/block.h | 19 +++

Re: [Qemu-devel] [Qemu-block] [PATCH 03/17] spec: add qcow2-dirty-bitmaps specification

2015-10-09 Thread Eric Blake
On 10/09/2015 11:07 AM, Max Reitz wrote: > > Except maybe the last bit, because "512 byte sector" basically is > meaningless when talking about a qcow2 file (which works in terms of > clusters), At KVM Forum, Kevin was mentioning an idea of adding an incompatible feature to qcow2 that would let

[Qemu-devel] [PULL v3 04/12] hw: do not pass NULL to memory_region_init from instance_init

2015-10-09 Thread Markus Armbruster
From: Paolo Bonzini This causes the region to outlive the object, because it attaches the region to /machine. This is not nice for the "realize" method, but much worse for "instance_init" because it can cause dangling pointers after a simple object_new/object_unref pair. Reported-by: Markus Arm

[Qemu-devel] [PULL v3 00/12] Fix device introspection regressions

2015-10-09 Thread Markus Armbruster
QMP command device-list-properties regressed in 2.1: it can crash or leave dangling pointers behind. -device FOO,help regressed in 2.2: it no longer works for non-pluggable devices. I tried to fix that some time ago[*], but my fix failed review. This is my second, more comprehensive try. PATCH

Re: [Qemu-devel] [PATCH v2] migration: disallow migrate_add_blocker during migration

2015-10-09 Thread John Snow
On 10/09/2015 03:42 PM, Eric Blake wrote: > On 09/30/2015 11:07 AM, John Snow wrote: >> If a migration is already in progress and somebody attempts >> to add a migration blocker, this should rightly fail. >> >> Add an errp parameter and a retcode return value to migrate_add_blocker. >> >> This is

Re: [Qemu-devel] [PATCH v2] migration: disallow migrate_add_blocker during migration

2015-10-09 Thread Eric Blake
On 09/30/2015 11:07 AM, John Snow wrote: > If a migration is already in progress and somebody attempts > to add a migration blocker, this should rightly fail. > > Add an errp parameter and a retcode return value to migrate_add_blocker. > > This is part one of two for a solution to prohibit e.g. b

[Qemu-devel] [PATCH v3 05/16] block: Convert bs->file to BdrvChild

2015-10-09 Thread Kevin Wolf
This patch removes the temporary duplication between bs->file and bs->file_child by converting everything to BdrvChild. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Alberto Garcia Reviewed-by: Fam Zheng --- block.c | 63 ++

Re: [Qemu-devel] [PATCH 2/2] hw/arm/virt: don't use a15memmap directly

2015-10-09 Thread Andrew Jones
On Fri, Oct 09, 2015 at 05:45:24PM +0100, Peter Maydell wrote: > On 6 October 2015 at 15:37, Andrew Jones wrote: > > We should always go through VirtBoardInfo when we need the memmap. > > To avoid using a15memmap directly, in this case, we need to defer > > the max-cpus check from class init time

Re: [Qemu-devel] [PATCH v7 10/14] qapi: Detect collisions in C member names

2015-10-09 Thread Eric Blake
On 10/09/2015 08:11 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Detect attempts to declare two object members that would result >> in the same C member name, by keying the 'seen' dictionary off >> of the C name rather than the qapi name. It also requires passing >> info through some o

[Qemu-devel] [PULL 2/2] trace: remove malloc tracing

2015-10-09 Thread Stefan Hajnoczi
From: Paolo Bonzini The malloc vtable is not supported anymore in glib, because it broke when constructors called g_malloc. Remove tracing of g_malloc, g_realloc and g_free calls. Note that, for systemtap users, glib also provides tracepoints glib.mem_alloc, glib.mem_free, glib.mem_realloc, gli

[Qemu-devel] [PULL 04/20] qapi: Sort qapi-schema tests

2015-10-09 Thread Markus Armbruster
From: Eric Blake Recent changes to qapi have provided quite a bit of churn in the makefile, because we are inconsistent on what order test names appear in, and on whether to re-wrap the list of tests or just add arbitrary line lengths. Writing the list in a sorted fashion, one test per line, wil

[Qemu-devel] [PATCH v3 16/16] block: Remove bdrv_swap()

2015-10-09 Thread Kevin Wolf
bdrv_swap() is unused now. Remove it and all functions that have no other users than bdrv_swap(). In particular, this removes the .bdrv_rebind callbacks from block drivers. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Alberto Garcia Reviewed-by: Fam Zheng --- block.c

Re: [Qemu-devel] [PATCH 04/12] dataplane: Mark host notifiers' client type as "external"

2015-10-09 Thread Kevin Wolf
Am 09.10.2015 um 07:45 hat Fam Zheng geschrieben: > They will be excluded by type in the nested event loops in block layer, > so that unwanted events won't be processed there. > > Signed-off-by: Fam Zheng Reviewed-by: Kevin Wolf

[Qemu-devel] [PULL 20/20] qapi: Simplify gen_visit_fields() error handling

2015-10-09 Thread Markus Armbruster
From: Eric Blake Since we have consolidated all generated code to use 'err' as the name of the local variable for error detection, we can simplify the decision on whether to skip error detection (useful for deallocation paths) to be a boolean. Signed-off-by: Eric Blake Message-Id: <1443565276-4

[Qemu-devel] [PATCH] scripts/text2pod.pl: Escape left brace

2015-10-09 Thread Fam Zheng
Latest perl now deprecates "{" literal in regex and print warnings like "unescaped left brace in regex is deprecated". Add escapes to keep it happy. Signed-off-by: Fam Zheng --- roms/ipxe | 2 +- scripts/texi2pod.pl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

  1   2   3   >