Re: [Qemu-devel] [PATCH] ppc/spapr: Allow VIRTIO_VGA

2015-09-15 Thread Gerd Hoffmann
On Mi, 2015-09-16 at 07:08 +1000, Benjamin Herrenschmidt wrote: > On Tue, 2015-09-15 at 11:19 +0200, Gerd Hoffmann wrote: > > On Di, 2015-09-15 at 15:51 +1000, Benjamin Herrenschmidt wrote: > > > It works fine with the Linux driver out of the box > > > > Do you actually want the vga compatibility

Re: [Qemu-devel] [PATCH 1/2] target-i386: disable LINT0 after reset

2015-09-15 Thread Gerd Hoffmann
On Mi, 2015-09-16 at 07:23 +0200, Jan Kiszka wrote: > On 2015-09-15 23:19, Alex Williamson wrote: > > On Mon, 2015-04-13 at 02:32 +0300, Nadav Amit wrote: > >> Due to old Seabios bug, QEMU reenable LINT0 after reset. This bug is long > >> gone > >> and therefore this hack is no longer needed. Sin

Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child

2015-09-15 Thread Wen Congyang
On 09/15/2015 03:49 PM, Markus Armbruster wrote: > Wen Congyang writes: > >> On 09/14/2015 10:36 PM, Markus Armbruster wrote: >>> Wen Congyang writes: >>> Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- blockdev.c | 47 ++

Re: [Qemu-devel] [RFC PATCH] libcacard: move it to a standalone project

2015-09-15 Thread Gerd Hoffmann
Hi, > > Where are we going to host virglrenderer? Whatever we do for libcacard, > > we should probably also do for virglrenderer. > > I hadn't considered where to host virglrenderer yet, I was initially > considering > shipping it with mesa but gave up that idea, so I was contemplating just >

Re: [Qemu-devel] [PATCH 1/2] target-i386: disable LINT0 after reset

2015-09-15 Thread Nadav Amit
I'll try to reproduce the problem today. Nadav On Sep 16, 2015 8:23 AM, "Jan Kiszka" wrote: > On 2015-09-15 23:19, Alex Williamson wrote: > > On Mon, 2015-04-13 at 02:32 +0300, Nadav Amit wrote: > >> Due to old Seabios bug, QEMU reenable LINT0 after reset. This bug is > long gone > >> and theref

Re: [Qemu-devel] [RFC 00/20] Do away with TB retranslation

2015-09-15 Thread Dennis Luehring
Am 15.09.2015 um 22:19 schrieb Richard Henderson: Indeed. It would indeed be good to add a bunch of bare-metal tests. Pre-compiled and checked in so that one doesn't have to have a suite of cross-compilers in order to use them. OTOH, I don't see myself (or anyone else) really having the time to

Re: [Qemu-devel] [PATCH v2] target-mips: Fix RDHWR on CP0.Count

2015-09-15 Thread Aurelien Jarno
On 2015-09-08 11:34, Alex Smith wrote: > For RDHWR on the CP0.Count register, env->CP0_Count was being returned. > This value is a delta against the QEMU_CLOCK_VIRTUAL clock, not the > correct current value of CP0.Count. Use cpu_mips_get_count() instead. > > Signed-off-by: Alex Smith > Cc: Aureli

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-15 Thread Wen Congyang
On 09/15/2015 07:12 PM, Markus Armbruster wrote: > Wen Congyang writes: > >> On 09/15/2015 03:37 PM, Markus Armbruster wrote: >>> Wen Congyang writes: >>> On 09/14/2015 11:47 PM, Eric Blake wrote: > On 09/14/2015 08:27 AM, Markus Armbruster wrote: >> Wen Congyang writes: >> >>>

Re: [Qemu-devel] [PATCH 1/2] target-i386: disable LINT0 after reset

2015-09-15 Thread Jan Kiszka
On 2015-09-15 23:19, Alex Williamson wrote: > On Mon, 2015-04-13 at 02:32 +0300, Nadav Amit wrote: >> Due to old Seabios bug, QEMU reenable LINT0 after reset. This bug is long >> gone >> and therefore this hack is no longer needed. Since it violates the >> specifications, it is removed. >> >> Sig

Re: [Qemu-devel] [PATCH 11/12] qapi: add md5 checksum of last dirty bitmap level to query-block

2015-09-15 Thread Markus Armbruster
John Snow writes: > On 09/15/2015 12:29 PM, Eric Blake wrote: >> On 08/07/2015 03:32 AM, Vladimir Sementsov-Ogievskiy wrote: >>> From: Vladimir Sementsov-Ogievskiy >>> >>> Reviewed-by: John Snow >>> Signed-off-by: Vladimir Sementsov-Ogievskiy >>> --- >>> block.c| 1 + >>> incl

Re: [Qemu-devel] [PATCH 0/2] target-mips: minor clean up in mtc0 and mfc0

2015-09-15 Thread Aurelien Jarno
On 2015-09-14 13:45, Leon Alrae wrote: > This patchset removes the gen_mtc0_store64() which is actually incorrect > as MTC0 instruction in MIPS64 is supposed to move entire content (if > dst CP0 register is 64-bit) without sign extending. It also removes the > gen_mfc0_load64() and replaces the pai

Re: [Qemu-devel] [RFCv2 1/2] spapr: Remove unnecessary owner field from sPAPRDRConnector

2015-09-15 Thread David Gibson
On Mon, Sep 14, 2015 at 04:24:23PM +0200, Paolo Bonzini wrote: > > > On 14/09/2015 16:06, Alexey Kardashevskiy wrote: > > > > === * There is no way for a child to determine what its parent > > is. It is not * a bidirectional relationship. This is by > > design. === > > > >>>

Re: [Qemu-devel] [PATCH] spapr_pci: fix device tree props for MSI/MSI-X

2015-09-15 Thread David Gibson
On Tue, Sep 15, 2015 at 04:34:59PM -0500, Michael Roth wrote: > PAPR requires ibm,req#msi and ibm,req#msi-x to be present in the > device node to define the number of msi/msi-x interrupts the device > supports, respectively. > > Currently we have ibm,req#msi-x hardcoded to a non-sensical constant

Re: [Qemu-devel] [PATCH] ppc/spapr: Fix buffer overflow in spapr_populate_drconf_memory()

2015-09-15 Thread David Gibson
On Tue, Sep 15, 2015 at 09:34:20PM +0200, Thomas Huth wrote: > The buffer that is allocated in spapr_populate_drconf_memory() > is used for setting both, the "ibm,dynamic-memory" and the > "ibm,associativity-lookup-arrays" property. However, only the > size of the first one is taken into account wh

Re: [Qemu-devel] [RFCv2 2/2] spapr: Don't use QOM [*] syntax for DR connectors.

2015-09-15 Thread David Gibson
On Mon, Sep 14, 2015 at 11:03:00PM -0500, Michael Roth wrote: > Quoting David Gibson (2015-09-13 20:41:53) > > The dynamic reconfiguration (hotplug) code for the pseries machine type > > uses a "DR connector" QOM object for each resource it will be possible > > to hotplug. Each of these is added t

[Qemu-devel] [PATCH] MAINTAINERS: Stefan will not maintain net subsystem

2015-09-15 Thread Jason Wang
Talked with Stefan, he will not maintain net subsystem. Cc: Stefan Hajnoczi Cc: Michael S. Tsirkin Signed-off-by: Jason Wang --- MAINTAINERS | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 688979b..2f4e8cf 100644 --- a/MAINTAINERS +++ b/MAI

Re: [Qemu-devel] [PATCH 6/7] vhost-user: add multiple queue support

2015-09-15 Thread Yuanhan Liu
On Wed, Sep 16, 2015 at 10:06:56AM +0800, Yuanhan Liu wrote: > On Tue, Sep 15, 2015 at 09:02:07AM -0600, Eric Blake wrote: > > On 09/15/2015 01:10 AM, Yuanhan Liu wrote: > > > From: Changchun Ouyang > > > > > > This patch is initially based a patch from Nikolay Nikolaev. > > > > > > Here is the

[Qemu-devel] [PATCH] hw/ide/ahci: advance IO buffer offset in multi-sector PIO transfer

2015-09-15 Thread Laszlo Ersek
The "MdeModulePkg/Bus/Ata/AtaAtapiPassThru" driver in edk2 submits a three sector long PIO read, when booting off various Fedora installer ISOs in UEFI mode. With DEBUG_IDE, DEBUG_IDE_ATAPI, DEBUG_AIO and DEBUG_AHCI enabled, plus a DPRINTF(ad->port_no, "offset=%d\n", offset); at the beginning o

[Qemu-devel] [PATCH v2 1/2] PCI-e device multi-function hot-add support

2015-09-15 Thread Cao jin
Enable pcie device multifunction hot, just ensure the function 0 added last, then driver will got the notification to scan all the function in the slot. Signed-off-by: Cao jin --- hw/pci/pcie.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/pci/pcie.c b

[Qemu-devel] [PATCH v2 2/2] PCI-e device multi-function hot-add support

2015-09-15 Thread Cao jin
In case user regret when hot-add multi-function, we should roll back, device_del the function added but still not worked. Signed-off-by: Cao jin --- hw/pci/pcie.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index 89bf61b..497f390 100644 -

Re: [Qemu-devel] [PATCH 2/2] PCI-e device multi-function hot-add support

2015-09-15 Thread Cao jin
Hi Igor, sorry I missed you mail. On 09/11/2015 10:35 PM, Igor Mammedov wrote: On Thu, 10 Sep 2015 20:12:23 +0800 Cao jin wrote: In case user regret when hot-add multi-function, we should roll back, device_del the function added but still not worked. Signed-off-by: Cao jin --- hw/pci/

Re: [Qemu-devel] [PATCH 6/7] vhost-user: add multiple queue support

2015-09-15 Thread Yuanhan Liu
On Tue, Sep 15, 2015 at 09:02:07AM -0600, Eric Blake wrote: > On 09/15/2015 01:10 AM, Yuanhan Liu wrote: > > From: Changchun Ouyang > > > > This patch is initially based a patch from Nikolay Nikolaev. > > > > Here is the latest version for adding vhost-user multiple queue support, > > by creatin

Re: [Qemu-devel] [PATCH 1/2] vhost-user: add multiple queue support

2015-09-15 Thread Yuanhan Liu
On Tue, Sep 15, 2015 at 08:56:05AM -0600, Eric Blake wrote: > On 09/15/2015 01:10 AM, Yuanhan Liu wrote: > > From: Changchun Ouyang > > > > This patch is initially based a patch from Nikolay Nikolaev. > > Subject line confusion - this is titled 1/2, but in reply to a cover > letter titled 0/7, a

[Qemu-devel] [PATCH v2 0/2] PCI-e device multi-function hot-add support

2015-09-15 Thread Cao jin
Support PCI-e device hot-add multi-function via device_add, just ensure add the function 0 is added last. While allow user to roll back in the middle via device_del, in case user regret. According to Alex`s comment, v2 has following update: 1. patch 1/2 remove if() which seems breaks the assumptio

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-15 Thread Chen, Tiejun
On 9/15/2015 7:00 PM, Paolo Bonzini wrote: On 15/09/2015 11:55, Stefano Stabellini wrote: On Mon, 14 Sep 2015, Paolo Bonzini wrote: > On 10/09/2015 12:29, Stefano Stabellini wrote: > > +if (lseek(config_fd, pos, SEEK_SET) != pos) { > > +return -errno; > > +} > > do { > >

Re: [Qemu-devel] [PATCH V1] sdhci: Fix hostctl2 write logic.

2015-09-15 Thread Alistair Francis
On Sun, Sep 13, 2015 at 1:36 PM, Peter Crosthwaite wrote: > On Fri, Sep 11, 2015 at 3:30 AM, Sai Pavan Boddu > wrote: >> From: Peter Crosthwaite >> >> This should be a shifted MASKED_WRITE like all other instances of >> non-word aligned registers. >> >> Signed-off-by: Peter Crosthwaite Looks g

Re: [Qemu-devel] [RFC PATCH] libcacard: move it to a standalone project

2015-09-15 Thread Dave Airlie
On 15 September 2015 at 23:37, Paolo Bonzini wrote: > On 15/09/2015 15:28, Daniel P. Berrange wrote: >> I have looked through the new libcacard git repository you created >> from QEMU history, and reviewed the extra patches you added on top >> for the build system and it all looks sane to me. So t

[Qemu-devel] [PATCH] spapr_pci: fix device tree props for MSI/MSI-X

2015-09-15 Thread Michael Roth
PAPR requires ibm,req#msi and ibm,req#msi-x to be present in the device node to define the number of msi/msi-x interrupts the device supports, respectively. Currently we have ibm,req#msi-x hardcoded to a non-sensical constant that happens to be 2, and are missing ibm,req#msi entirely. The result o

Re: [Qemu-devel] [PATCH 1/2] target-i386: disable LINT0 after reset

2015-09-15 Thread Alex Williamson
On Mon, 2015-04-13 at 02:32 +0300, Nadav Amit wrote: > Due to old Seabios bug, QEMU reenable LINT0 after reset. This bug is long gone > and therefore this hack is no longer needed. Since it violates the > specifications, it is removed. > > Signed-off-by: Nadav Amit > --- > hw/intc/apic_common.c

Re: [Qemu-devel] [RFC PATCH 2/2] target-ppc: add CPU IRQ state to PPC VMStateDescription

2015-09-15 Thread Mark Cave-Ayland
On 15/09/15 00:10, Alexey Kardashevskiy wrote: > On 09/15/2015 05:30 AM, Mark Cave-Ayland wrote: >> Commit a90db15 "target-ppc: Convert ppc cpu savevm to VMStateDescription" >> appears to drop the internal CPU IRQ state from the migration stream. >> Whilst >> testing migration on g3beige/mac99 mac

Re: [Qemu-devel] [PATCH] ppc/spapr: Allow VIRTIO_VGA

2015-09-15 Thread Benjamin Herrenschmidt
On Tue, 2015-09-15 at 11:19 +0200, Gerd Hoffmann wrote: > On Di, 2015-09-15 at 15:51 +1000, Benjamin Herrenschmidt wrote: > > It works fine with the Linux driver out of the box > > Do you actually want the vga compatibility bits on pseries? Yes, our firmware SLOF uses them (via MMIO BARs) for the

Re: [Qemu-devel] Compiling Qemu from Cygwin

2015-09-15 Thread Eric Blake
On 09/15/2015 02:10 PM, Stefan Weil wrote: >> >> CCqga/commands-win32.o >>> qga/commands-win32.c: In function ‘qmp_guest_set_user_password’: >>> qga/commands-win32.c:1254:55: warning: passing argument 2 of >>> ‘g_base64_decode’ from incompatible pointer type >>> rawpasswddata = (char *)g

[Qemu-devel] Compiling Qemu from Cygwin

2015-09-15 Thread Mike Ladouceur
Stefan, I got your email from the #qemu channel on OFTC. I was told you may be able to assist me. I'm trying to compile Qemu from within Cygwin. At first I was getting an error about not being able to find zlib.h even though it is in fact installed on the "system". I commented out the code that e

[Qemu-devel] [PATCH: 1/2] rdma: changed companies, use an email that doesn't change

2015-09-15 Thread mhines
From: "Michael R. Hines" Is change this kosher --- changing the header like this? I often see really outdated emails in other projects sometimes, so I'm not sure if that's to preserve some kind of providence or something. Signed-off-by: Michael R. Hines --- migration/rdma.c | 2 +- 1 file chan

[Qemu-devel] [Bug 1488363] Re: qemu 2.4.0 hangs using vfio for pci passthrough of graphics card

2015-09-15 Thread Martin
** Also affects: qemu (Gentoo Linux) Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1488363 Title: qemu 2.4.0 hangs using vfio for pci passthrough of grap

[Qemu-devel] [PATCH: 2/2] maintainers: changed companies, use an email that doesn't change

2015-09-15 Thread mhines
From: "Michael R. Hines" Is there a procedure for updating this file besides just updating the file? Signed-off-by: Michael R. Hines --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 688979b..c455533 100644 --- a/MAINTAINERS +++ b/MAINTAI

Re: [Qemu-devel] [RFC 00/20] Do away with TB retranslation

2015-09-15 Thread Richard Henderson
On 09/10/2015 11:55 AM, Alex Bennée wrote: > I've only had a quick glance so far but I'm fairly familiar with the > concept from a previous life. I'll aim to do a full review later once > I've gotten through my MTTCG review backlog. > > Anyway some quick points: > > * You can save data by only m

Re: [Qemu-devel] Compiling Qemu from Cygwin

2015-09-15 Thread Stefan Weil
Am 15.09.2015 um 20:48 schrieb Mike Ladouceur: > Stefan, > > I got your email from the #qemu channel on OFTC. I was told you may be > able to assist me. I'm trying to compile Qemu from within Cygwin. At first > I was getting an error about not being able to find zlib.h even though it > is in fact

Re: [Qemu-devel] [PATCH 18/20] tcg: Save insn data and use it in cpu_restore_state_from_tb

2015-09-15 Thread Richard Henderson
On 09/10/2015 06:49 AM, Peter Maydell wrote: >> +tcg_debug_assert(num_insns >= 0); > > This is claiming that every TB will have at least one insn_start, > right? I think that most targets will violate that in the breakpoint > case, because the "if we have a bp for this insn then generate a > d

Re: [Qemu-devel] [RFT PATCH v1 0/3] net: smc91c111 can_receive fixes

2015-09-15 Thread Richard Purdie
On Tue, 2015-09-15 at 11:02 -0700, Peter Crosthwaite wrote: > On Mon, Sep 14, 2015 at 2:09 PM, Richard Purdie > wrote: > > Hi Peter, > > > > On Thu, 2015-09-10 at 21:23 -0700, Peter Crosthwaite wrote: > >> This should hopefully fix your bug, while addressing the extra concern > >> I raised. > >> >

[Qemu-devel] [PULL 0/6] target-i386 exception improvments

2015-09-15 Thread Richard Henderson
2015-09-15 15:42:58 +0100) are available in the git repository at: git://github.com/rth7680/qemu.git tags/pull-target-i386-20150915 for you to fetch changes up to 4054cdec0423c7190bfc733c27c303d513d531ab: target-i386: exception handling for other helper functions (2015-09-15 12:3

[Qemu-devel] [PULL 2/6] target-i386: exception handling for FPU instructions

2015-09-15 Thread Richard Henderson
From: Pavel Dovgalyuk This patch fixes exception handling for FPU instructions and removes obsolete PC update from translate.c. Reviewed-by: Aurelien Jarno Reviewed-by: Richard Henderson Signed-off-by: Pavel Dovgalyuk Signed-off-by: Richard Henderson --- target-i386/fpu_helper.c | 164

Re: [Qemu-devel] [PATCH 11/12] qapi: add md5 checksum of last dirty bitmap level to query-block

2015-09-15 Thread John Snow
On 09/15/2015 12:29 PM, Eric Blake wrote: > On 08/07/2015 03:32 AM, Vladimir Sementsov-Ogievskiy wrote: >> From: Vladimir Sementsov-Ogievskiy >> >> Reviewed-by: John Snow >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> block.c| 1 + >> include/qemu/hbitmap.h | 8 +

[Qemu-devel] [PULL 5/6] target-i386: exception handling for seg_helper functions

2015-09-15 Thread Richard Henderson
From: Pavel Dovgalyuk This patch fixes exception handling for seg_helper functions. Signed-off-by: Pavel Dovgalyuk Signed-off-by: Richard Henderson --- target-i386/helper.h | 4 +- target-i386/seg_helper.c | 616 +-- target-i386/translate.c |

[Qemu-devel] [PULL 3/6] target-i386: exception handling for div instructions

2015-09-15 Thread Richard Henderson
From: Pavel Dovgalyuk This patch fixes exception handling for div instructions and removes obsolete PC update from translate.c. Reviewed-by: Richard Henderson Reviewed-by: Aurelien Jarno Signed-off-by: Pavel Dovgalyuk Signed-off-by: Richard Henderson --- target-i386/int_helper.c | 32 +

[Qemu-devel] [PULL 6/6] target-i386: exception handling for other helper functions

2015-09-15 Thread Richard Henderson
From: Pavel Dovgalyuk This patch fixes exception handling for other helper functions. Signed-off-by: Pavel Dovgalyuk Signed-off-by: Richard Henderson --- target-i386/cc_helper.c | 2 +- target-i386/misc_helper.c | 8 target-i386/ops_sse.h | 2 +- 3 files changed, 6 insertions(+

[Qemu-devel] [PULL 1/6] target-i386: introduce new raise_exception functions

2015-09-15 Thread Richard Henderson
From: Pavel Dovgalyuk This patch introduces new versions of raise_exception functions that receive TB return address as an argument. Reviewed-by: Aurelien Jarno Reviewed-by: Richard Henderson Signed-off-by: Pavel Dovgalyuk Signed-off-by: Richard Henderson --- target-i386/cpu.h | 4

Re: [Qemu-devel] [PATCH v4 03/11] qemu-log: correct help text for -d cpu

2015-09-15 Thread Richard Henderson
On 09/15/2015 12:28 PM, Peter Maydell wrote: > On 4 August 2015 at 20:16, Richard Henderson wrote: >> On 08/04/2015 12:08 PM, Alex Bennée wrote: > Would that make sense as a debug option or should we have a specific set > of TCG options to alter its behaviour? That's what I'

[Qemu-devel] [PULL 4/6] target-i386: exception handling for memory helpers

2015-09-15 Thread Richard Henderson
From: Pavel Dovgalyuk This patch fixes exception handling for memory helpers and removes obsolete PC update from translate.c. Reviewed-by: Aurelien Jarno Signed-off-by: Pavel Dovgalyuk Signed-off-by: Richard Henderson --- target-i386/mem_helper.c | 39 ++-

[Qemu-devel] [PATCH] ppc/spapr: Fix buffer overflow in spapr_populate_drconf_memory()

2015-09-15 Thread Thomas Huth
The buffer that is allocated in spapr_populate_drconf_memory() is used for setting both, the "ibm,dynamic-memory" and the "ibm,associativity-lookup-arrays" property. However, only the size of the first one is taken into account when allocating the memory. So if the length of the second property is

Re: [Qemu-devel] [PATCH v4 03/11] qemu-log: correct help text for -d cpu

2015-09-15 Thread Peter Maydell
On 4 August 2015 at 20:16, Richard Henderson wrote: > On 08/04/2015 12:08 PM, Alex Bennée wrote: Would that make sense as a debug option or should we have a specific set of TCG options to alter its behaviour? >>> >>> >>> That's what I'm saying -- probably a separate debug option is bette

Re: [Qemu-devel] [Xen-devel] [Patch V1 2/3] xen/usb: add capability for passing through isoc jobs to host devices

2015-09-15 Thread Konrad Rzeszutek Wilk
On Thu, Sep 03, 2015 at 12:45:12PM +0200, Juergen Gross wrote: > When Xen is using the qemu usb framework for pure passthrough of I/Os > to host devices the handling of isoc jobs is rather complicated if > multiple isoc frames are transferred with one call. > > Instead of calling the framework wit

Re: [Qemu-devel] [PATCH] ide: fix ATAPI command permissions

2015-09-15 Thread John Snow
On 09/15/2015 02:50 PM, Markus Armbruster wrote: > John Snow writes: > >> On 09/15/2015 02:11 PM, Markus Armbruster wrote: >>> John Snow writes: >>> On 09/15/2015 02:53 AM, Markus Armbruster wrote: > John Snow writes: > >> We're a little too lenient with what we'll let an ATA

Re: [Qemu-devel] [PATCH] ide: fix ATAPI command permissions

2015-09-15 Thread Markus Armbruster
John Snow writes: > On 09/15/2015 02:11 PM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 09/15/2015 02:53 AM, Markus Armbruster wrote: John Snow writes: > We're a little too lenient with what we'll let an ATAPI drive handle. > Clamp down on the IDE command executio

[Qemu-devel] [PATCH 7/8] target-i386: Handle I/O breakpoints

2015-09-15 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-i386/bpt_helper.c | 99 +++- target-i386/cpu.h| 2 + target-i386/helper.h | 1 + target-i386/translate.c | 20 +- 4 files changed, 94 insertions(+), 28 deletions(-) diff --git a/target-

[Qemu-devel] [PATCH 8/8] target-i386: Check CR4[DE] for processing DR4/DR5

2015-09-15 Thread Richard Henderson
Introduce helper_get_dr so that we don't have to put CR4[DE] into the scarce HFLAGS resource. At the same time, rename helper_movl_drN_T0 to helper_set_dr and set the helper flags. Signed-off-by: Richard Henderson --- target-i386/bpt_helper.c | 46 +-

[Qemu-devel] [PATCH 6/8] target-i386: Optimize setting dr[0-3]

2015-09-15 Thread Richard Henderson
If the debug register is not enabled, we need do nothing besides update the register. Signed-off-by: Richard Henderson --- target-i386/bpt_helper.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/target-i386/bpt_helper.c b/target-i386/bpt_helper.c index 10bbf9f..f

[Qemu-devel] [PATCH 5/8] target-i386: Move hw_*breakpoint_* functions

2015-09-15 Thread Richard Henderson
They're only used from bpt_helper.c now. Signed-off-by: Richard Henderson --- target-i386/bpt_helper.c | 29 - target-i386/cpu.h| 27 --- 2 files changed, 28 insertions(+), 28 deletions(-) diff --git a/target-i386/bpt_helper.c b/target

[Qemu-devel] [PATCH 4/8] target-i386: Re-introduce optimal breakpoint removal

2015-09-15 Thread Richard Henderson
Before the last patch, we had an efficient loop that disabled local breakpoints on task switch. Re-add that, but in a more general way that handles changes to the global enable bits too. Signed-off-by: Richard Henderson --- target-i386/bpt_helper.c | 34 -- 1 fil

[Qemu-devel] [PATCH 3/8] target-i386: Introduce cpu_x86_update_dr7

2015-09-15 Thread Richard Henderson
This moves the last of the iteration over breakpoints into the bpt_helper.c file. This also allows us to make several breakpoint functions static. Signed-off-by: Richard Henderson --- target-i386/bpt_helper.c | 29 ++--- target-i386/cpu.h| 4 ++-- target-i386/ma

[Qemu-devel] [PATCH 1/8] target-i386: Move breakpoint related functions to new file

2015-09-15 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-i386/Makefile.objs | 2 +- target-i386/bpt_helper.c | 182 ++ target-i386/helper.c | 128 target-i386/misc_helper.c | 34 - 4 files changed, 183 insertions(+),

[Qemu-devel] [PATCH 0/8] target-i386: Implement debug extensions

2015-09-15 Thread Richard Henderson
Best guess, since I can't find any code that actually uses them. Linux actively turns them off at boot... r~ Richard Henderson (8): target-i386: Move breakpoint related functions to new file target-i386: Make check_hw_breakpoints static target-i386: Introduce cpu_x86_update_dr7 target-i

[Qemu-devel] [PATCH 2/8] target-i386: Make check_hw_breakpoints static

2015-09-15 Thread Richard Henderson
The function is now only used from within a single file. Signed-off-by: Richard Henderson --- target-i386/bpt_helper.c | 2 +- target-i386/cpu.h| 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/target-i386/bpt_helper.c b/target-i386/bpt_helper.c index 6f6537d..c071c24

[Qemu-devel] Canceled Event: Dr Velano @ Wed Sep 16, 2015 17:50 - 18:50 (shlomopongr...@gmail.com)

2015-09-15 Thread shlomopongratz
BEGIN:VCALENDAR PRODID:-//Google Inc//Google Calendar 70.9054//EN VERSION:2.0 CALSCALE:GREGORIAN METHOD:CANCEL BEGIN:VEVENT DTSTART:20150916T145000Z DTEND:20150916T155000Z DTSTAMP:20150915T184155Z ORGANIZER;CN=Shlomo Pongratz:mailto:shlomopongr...@gmail.com UID:mhfgd22vmap7kbtja2d8p70...@google.com

Re: [Qemu-devel] [PATCH] ide: fix ATAPI command permissions

2015-09-15 Thread John Snow
On 09/15/2015 02:11 PM, Markus Armbruster wrote: > John Snow writes: > >> On 09/15/2015 02:53 AM, Markus Armbruster wrote: >>> John Snow writes: >>> We're a little too lenient with what we'll let an ATAPI drive handle. Clamp down on the IDE command execution table to remove CD_OK per

Re: [Qemu-devel] [PATCH v7 00/26] qapi: QMP introspection

2015-09-15 Thread Markus Armbruster
Commit 351d36e "qapi: allow override of default enum prefix naming" got in first. The rebase is non-trivial, so a full respin is necessary. Clock for pull request will be reset...

Re: [Qemu-devel] [PATCH RFC v5 00/32] qapi: QMP introspection

2015-09-15 Thread Markus Armbruster
Commit 351d36e "qapi: allow override of default enum prefix naming" got in first. The rebase is non-trivial, so a full respin is necessary. Clock for pull request will be reset...

Re: [Qemu-devel] [PATCH] ide: fix ATAPI command permissions

2015-09-15 Thread Markus Armbruster
John Snow writes: > On 09/15/2015 02:53 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> We're a little too lenient with what we'll let an ATAPI drive handle. >>> Clamp down on the IDE command execution table to remove CD_OK permissions >>> from commands that are not and have never been

Re: [Qemu-devel] [RFT PATCH v1 0/3] net: smc91c111 can_receive fixes

2015-09-15 Thread Peter Crosthwaite
On Mon, Sep 14, 2015 at 2:09 PM, Richard Purdie wrote: > Hi Peter, > > On Thu, 2015-09-10 at 21:23 -0700, Peter Crosthwaite wrote: >> This should hopefully fix your bug, while addressing the extra concern >> I raised. >> >> There was also inconsistent behaviour with corking packets through a >> so

Re: [Qemu-devel] [PATCH v2] add macro file for coccinelle

2015-09-15 Thread Michael Tokarev
07.09.2015 13:21, Paolo Bonzini wrote: > Coccinelle chokes on some idioms from compiler.h and queue.h. > Extract those in a macro file, to be used with "--macro-file > scripts/cocci-macro-file.h". Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH v2] Add .dir-locals.el file to configure emacs coding style

2015-09-15 Thread Michael Tokarev
15.09.2015 19:22, Markus Armbruster wrote: > "Daniel P. Berrange" writes: [] >> Personally I be fine with both the minimal approach or the more >> comprehensive approach of Peter's, but I'd probably tend towards >> the minimal approach to avoid the warnings problem. > > Seconded. > > The "minima

Re: [Qemu-devel] [PATCH v2 09/18] nvdimm: build ACPI NFIT table

2015-09-15 Thread Igor Mammedov
On Tue, 15 Sep 2015 18:12:43 +0200 Paolo Bonzini wrote: > > > On 14/08/2015 16:52, Xiao Guangrong wrote: > > NFIT is defined in ACPI 6.0: 5.2.25 NVDIMM Firmware Interface Table (NFIT) > > > > Currently, we only support PMEM mode. Each device has 3 tables: > > - SPA table, define the PMEM regio

Re: [Qemu-devel] [RFC PATCH] os-android: Add support to android platform, built by ndk-r10

2015-09-15 Thread Houcheng Lin
Hi Paolo, (Please ignore the previous mail that did not include "qemu-devel") Thanks for your review and suggestions. I'll fix this patch accordingly and please see my replies below. best regards, Houcheng Lin 2015-09-15 17:41 GMT+08:00 Paolo Bonzini : > This is okay and can be done unconditio

Re: [Qemu-devel] [PATCH v7 25/42] Postcopy: Maintain sentmap and calculate discard

2015-09-15 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > Where postcopy is preceeded by a period of precopy, the destination will > > have received pages that may have been dirtied on the source after the > > page was sent. T

Re: [Qemu-devel] [PATCH v2 3/5] acpi: pc: add fw_cfg device node to ssdt

2015-09-15 Thread Eduardo Habkost
On Mon, Sep 14, 2015 at 04:54:25PM -0400, Gabriel L. Somlo wrote: > On Mon, Sep 14, 2015 at 04:34:02PM -0400, Gabriel L. Somlo wrote: > > > > So I'll replace the "if (guest_info->fw_cfg)" check with > > > > "if machine-type >= (pc-q35-2.5 or pc-i440fx-2.5))", in v3, > > > > as soon as the patches f

Re: [Qemu-devel] [Question] QEMU 2.3 Assertion with `existing->mr->subpage || existing->mr == &io_mem_unassigned' failed

2015-09-15 Thread Paolo Bonzini
On 15/09/2015 11:20, Gonglei wrote: > On 2015/9/15 14:33, Gonglei wrote: >> On 2015/9/15 9:16, Gonglei wrote: >>> On 2015/9/14 17:28, Paolo Bonzini wrote: On 14/09/2015 10:01, Gonglei (Arei) wrote: > [2015-09-11 13:42:44] domain is rebooting > qemu-kvm: /home/abuild/rpmbui

Re: [Qemu-devel] [PATCH v7 04/11] target-mips: improve exception handling

2015-09-15 Thread Leon Alrae
On 28/08/2015 10:08, Pavel Dovgaluk wrote: >> From: Aurelien Jarno [mailto:aurel...@aurel32.net] >> On 2015-08-13 14:12, Leon Alrae wrote: >>> On 10/07/2015 10:57, Pavel Dovgalyuk wrote: @@ -2364,14 +2363,12 @@ static void gen_st_cond (DisasContext *ctx, uint32_t opc, int rt, #if d

Re: [Qemu-devel] [PATCH 06/12] qapi: add dirty-bitmaps migration capability

2015-09-15 Thread Eric Blake
On 08/07/2015 03:32 AM, Vladimir Sementsov-Ogievskiy wrote: > From: Vladimir Sementsov-Ogievskiy > > Reviewed-by: John Snow > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/migration/migration.h | 1 + > migration/migration.c | 9 + > qapi-schema.json

Re: [Qemu-devel] [PATCH v3 2/2] hw/arm/virt-acpi-build: Add DBG2 table

2015-09-15 Thread Peter Maydell
On 15 September 2015 at 17:42, Andrew Jones wrote: > On Tue, Sep 15, 2015 at 03:44:41PM +0100, Leif Lindholm wrote: >> Add a DBG2 table, describing the pl011 UART. >> >> Signed-off-by: Leif Lindholm >> --- >> hw/arm/virt-acpi-build.c | 88 >> +++- >>

Re: [Qemu-devel] I want to recover my QEMU password.

2015-09-15 Thread SkyKiDS
SkyKiDS is mine, and Skykids is maybe mine, too, but could be removed. Any helps? 2015-09-12 14:09 GMT+09:00 Stefan Weil : > Am 11.09.2015 um 17:38 schrieb SkyKiDS: > > Hi, there! > > > > Long long time ago, in 2010, I am a member of QEMU wiki, just had an > > account, and contributed some news

Re: [Qemu-devel] [PATCH] ide: fix ATAPI command permissions

2015-09-15 Thread John Snow
On 09/15/2015 02:53 AM, Markus Armbruster wrote: > John Snow writes: > >> We're a little too lenient with what we'll let an ATAPI drive handle. >> Clamp down on the IDE command execution table to remove CD_OK permissions >> from commands that are not and have never been ATAPI commands. >> >> Fo

[Qemu-devel] [PATCH v3 43/46] ivshmem: add hostmem backend

2015-09-15 Thread marcandre . lureau
From: Marc-André Lureau Instead of handling allocation, teach ivshmem to use a memory backend. This allows to use hugetlbfs backed memory now. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c| 84 tests/ivshmem-test.c | 12

Re: [Qemu-devel] [PATCH v3 2/2] hw/arm/virt-acpi-build: Add DBG2 table

2015-09-15 Thread Andrew Jones
On Tue, Sep 15, 2015 at 03:44:41PM +0100, Leif Lindholm wrote: > Add a DBG2 table, describing the pl011 UART. > > Signed-off-by: Leif Lindholm > --- > hw/arm/virt-acpi-build.c | 88 > +++- > 1 file changed, 87 insertions(+), 1 deletion(-) > > diff --

Re: [Qemu-devel] [PATCH PULL v3 00/11] Extract TLS handling code from VNC server

2015-09-15 Thread Peter Maydell
On 15 September 2015 at 15:36, Daniel P. Berrange wrote: > The following changes since commit 007e620a7576e4ce2ea6955541e87d8ae8ed32ae: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2015-09-14 18:51:09 +0100) > > are available in the git repository at: > >

[Qemu-devel] [PATCH v3 42/46] ivshmem: make ivshmem_get_size() more generic

2015-09-15 Thread marcandre . lureau
From: Marc-André Lureau Use a more explicit function name parse_mem_size(). I guess such function could be common (or exists already somewhere). Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/misc/ivshmem

Re: [Qemu-devel] [PATCH v2] Add .dir-locals.el file to configure emacs coding style

2015-09-15 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Tue, Sep 15, 2015 at 09:31:08AM -0600, Eric Blake wrote: >> ping >> >> On 08/24/2015 06:15 PM, John Snow wrote: >> > >> > >> > On 06/18/2015 10:05 AM, Markus Armbruster wrote: >> >> Peter Maydell writes: >> >> >> >>> On 18 June 2015 at 10:28, Markus Armbruste

[Qemu-devel] [PATCH v3 40/46] tests: add ivshmem qtest

2015-09-15 Thread marcandre . lureau
From: Marc-André Lureau Adds 4 ivshmemtests: - single qemu instance and basic IO - pair of instances, check memory sharing - pair of instances with server, and MSIX - hot plug/unplug A temporary shm is created as well as a directory to place server socket, both should be clear on exit and abort.

[Qemu-devel] [PATCH v3 38/46] msix: implement pba write (but read-only)

2015-09-15 Thread marcandre . lureau
From: Marc-André Lureau qpci_msix_pending() writes on pba region, causing qemu to SEGV: Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x77fba8c0 (LWP 25882)] 0x in ?? () (gdb) bt #0 0x in () #1 0x556556c5 in m

Re: [Qemu-devel] [PATCH v2 08/18] nvdimm: init backend memory mapping and config data area

2015-09-15 Thread Paolo Bonzini
On 07/09/2015 16:11, Igor Mammedov wrote: > > here is common concepts that could be reused. > - on physical system both DIMM and NVDIMM devices use > the same slots. We could share QEMU's '-m slots' option between > both devices. An alternative to not sharing would be to introduce >

[Qemu-devel] [PATCH v3 45/46] ivshmem: rename MSI eventfd_table

2015-09-15 Thread marcandre . lureau
From: Marc-André Lureau The array is used to have vector specific data, so use a more descriptive name. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 976f

[Qemu-devel] [PATCH v3 36/46] ivshmem: add check on protocol version in QEMU

2015-09-15 Thread marcandre . lureau
From: David Marchand Send a protocol version as the first message from server, clients must close communication if they don't support this protocol version. Older QEMUs should be fine with this change in the protocol since they overrides their own vm_id on reception of an id associated to no eve

Re: [Qemu-devel] [PATCH 11/12] qapi: add md5 checksum of last dirty bitmap level to query-block

2015-09-15 Thread Eric Blake
On 08/07/2015 03:32 AM, Vladimir Sementsov-Ogievskiy wrote: > From: Vladimir Sementsov-Ogievskiy > > Reviewed-by: John Snow > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block.c| 1 + > include/qemu/hbitmap.h | 8 > qapi/block-core.json | 4 +++- > util/hbitm

[Qemu-devel] [PATCH v3 44/46] ivshmem: remove EventfdEntry.vector

2015-09-15 Thread marcandre . lureau
From: Marc-André Lureau No need to store an extra int for the vector number when it can be computed easily by looking at the position in the array. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/misc/ivshmem

[Qemu-devel] [PATCH v3 06/46] ivshmem: remove unnecessary dup()

2015-09-15 Thread marcandre . lureau
From: Marc-André Lureau qemu_chr_fe_get_msgfd() transfers ownership, there is no need to dup the fd. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 21 ++--- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index dd1

[Qemu-devel] [PATCH v3 33/46] ivshmem-server: use a uint16 for client ID

2015-09-15 Thread marcandre . lureau
From: Marc-André Lureau In practice, the number of VM is limited to MAXUINT16 in ivshmem, so use the same limit on the server (removes a theorical infinite loop) Signed-off-by: Marc-André Lureau --- contrib/ivshmem-server/ivshmem-server.c | 11 ++- contrib/ivshmem-server/ivshmem-server

Re: [Qemu-devel] [PATCH 03/17] spec: add qcow2-dirty-bitmaps specification

2015-09-15 Thread Eric Blake
On 09/05/2015 10:43 AM, Vladimir Sementsov-Ogievskiy wrote: > Persistent dirty bitmaps will be saved into qcow2 files. It may be used > as 'internal' bitmaps (for qcow2 drives) or as 'external' bitmaps for > other drives (there may be qcow2 file with zero disk size but with > several dirty bitmaps

[Qemu-devel] [PATCH v3 37/46] contrib: remove unnecessary strdup()

2015-09-15 Thread marcandre . lureau
From: Marc-André Lureau getopt() optarg points to argv memory, no need to dup those values, fixes small leaks detected by clang-analyzer. Signed-off-by: Marc-André Lureau --- contrib/ivshmem-client/main.c | 2 +- contrib/ivshmem-server/main.c | 6 +++--- 2 files changed, 4 insertions(+), 4 del

[Qemu-devel] [PATCH v3 32/46] ivshmem-client: check the number of vectors

2015-09-15 Thread marcandre . lureau
From: Marc-André Lureau Check the number of vectors received from the server, to avoid out of bound array access. Signed-off-by: Marc-André Lureau --- contrib/ivshmem-client/ivshmem-client.c | 4 1 file changed, 4 insertions(+) diff --git a/contrib/ivshmem-client/ivshmem-client.c b/cont

[Qemu-devel] [PATCH v3 29/46] ivshmem: error on too many eventfd received

2015-09-15 Thread marcandre . lureau
From: Marc-André Lureau The number of eventfd that can be handled per peer is limited by the number of vectors. Return an error when receiving too many of them. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/misc/ivshmem.c b

[Qemu-devel] [PATCH v3 39/46] qtest: add qtest_add_abrt_handler()

2015-09-15 Thread marcandre . lureau
From: Marc-André Lureau Allow a test to add abort handlers, use GHook for all handlers. There is currently no way to remove a handler, but it could be later added if needed. Signed-off-by: Marc-André Lureau --- tests/libqtest.c | 37 - tests/libqtest.h | 2

  1   2   3   4   >