Re: [Qemu-devel] [PATCH 5/5] block: Drop bdrv_find_whitelisted_format()

2015-08-26 Thread Alberto Garcia
On Wed 26 Aug 2015 07:47:52 PM CEST, Max Reitz wrote: > It is unused by now, so we can drop it. > > Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH 3/5] block: Drop drv parameter from bdrv_open_inherit()

2015-08-26 Thread Alberto Garcia
On Wed 26 Aug 2015 07:47:50 PM CEST, Max Reitz wrote: > Now that this parameter is effectively unused, we can drop it and just > pass NULL to bdrv_fill_options(). > > Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH 4/5] block: Drop drv parameter from bdrv_fill_options()

2015-08-26 Thread Alberto Garcia
On Wed 26 Aug 2015 07:47:51 PM CEST, Max Reitz wrote: > Now that this parameter is effectively unused, we can drop it and > change the function accordingly. > > Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH 2/5] block: Drop drv parameter from bdrv_open()

2015-08-26 Thread Alberto Garcia
On Wed 26 Aug 2015 07:47:49 PM CEST, Max Reitz wrote: > Now that this parameter is effectively unused, we can drop it and just > pass NULL on to bdrv_open_inherit(). > > Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH 1/5] block: Always pass NULL as drv for bdrv_open()

2015-08-26 Thread Alberto Garcia
On Wed 26 Aug 2015 07:47:48 PM CEST, Max Reitz wrote: > Change all callers of bdrv_open() to pass the driver name in the options > QDict instead of passing its BlockDriver pointer. > > Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [ARM SMBIOS V5 PATCH 0/2]SMBIOS Support for ARM

2015-08-26 Thread Laszlo Ersek
On 08/26/15 21:04, Wei Huang wrote: > SMBIOS tables present userful system hardware info to management > applications, such as DMI tools. Even though SMBIOS was originally > developed for Intel x86, it has been extended to both Itanium and > ARM (32bit & 64bit). More and more ARM server releases,

Re: [Qemu-devel] [ARM SMBIOS V5 PATCH 1/2] smbios: add smbios 3.0 support

2015-08-26 Thread Laszlo Ersek
On 08/26/15 21:04, Wei Huang wrote: > This patch adds support for SMBIOS 3.0 entry point. When caller invokes > smbios_set_defaults(), it can specify entry point as 2.1 or 3.0. Then > smbios_get_tables() will return the entry point table in right format. > > Acked-by: Gabriel Somlo > Tested-by: G

Re: [Qemu-devel] Debian 7.8.0 SPARC64 on qemu - anything i can do to speedup the emulation?

2015-08-26 Thread Dennis Luehring
Am 26.08.2015 um 21:47 schrieb Richard Henderson: Anyway, this sort of setup is exactly what I did for Alpha. The PALcode (hypervisor-ish) layer used for qemu looks nothing like the PALcode layer used for real hardware. can post your qemu parameters for installing/starting your alpha emulatio

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-26 Thread Markus Armbruster
Programmingkid writes: > On Aug 26, 2015, at 6:08 PM, John Snow wrote: > >> >> >> On 08/26/2015 05:48 PM, Programmingkid wrote: >>> >>> On Aug 26, 2015, at 2:45 PM, Peter Maydell wrote: >>> On 26 August 2015 at 18:16, Programmingkid wrote: > That is assuming they have the time

Re: [Qemu-devel] [FIX PATCH] spapr_rtas: Prevent QEMU crash during hotplug without a prior device_add

2015-08-26 Thread Bharata B Rao
On Wed, Aug 26, 2015 at 09:17:09AM -0500, Michael Roth wrote: > Quoting Bharata B Rao (2015-08-25 23:04:11) > > If drmgr is used in the guest to hotplug a device before a device_add > > has been issued via the QEMU monitor, QEMU segfaults in configure_connector > > call. This occurs due to accessin

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-26 Thread Jason Wang
On 08/26/2015 10:51 PM, Greg Kurz wrote: > On Wed, 26 Aug 2015 15:21:59 +0100 > Peter Maydell wrote: > >> On 26 August 2015 at 11:04, Jason Wang wrote: >>> Wildcard mmio eventfd use zero size, but it will lead abort() since it >>> was illegal in adjust_endianness(). Fix this by allowing zero si

Re: [Qemu-devel] Plan for using softmmu with linux-user

2015-08-26 Thread Chen Gang
On 2015年08月19日 16:01, gchen gchen wrote: > On 2015年08月15日 04:45, Chen Gang wrote: >> On 8/14/15 22:44, Richard Henderson wrote: >>> On 08/14/2015 02:37 AM, gchen gchen wrote: - If I implement SW64 tcg backend, I guess, I cann't get help from qemu upstream: I don't think SW64 is valuab

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-26 Thread Programmingkid
On Aug 26, 2015, at 6:08 PM, John Snow wrote: > > > On 08/26/2015 05:48 PM, Programmingkid wrote: >> >> On Aug 26, 2015, at 2:45 PM, Peter Maydell wrote: >> >>> On 26 August 2015 at 18:16, Programmingkid >>> wrote: That is assuming they have the time and/or the interest in solving this

Re: [Qemu-devel] [PATCH RFC 0/5] Network traffic dumping via netfilter

2015-08-26 Thread Jason Wang
On 08/27/2015 10:33 AM, Thomas Huth wrote: > The "-net dump" option only works with the "-net" option. So far, it > is not possible to dump network traffic with the "-netdev" option yet. > This patch series now fixes this ugliness by enabling dumping for the > netdev devices via the new netfilter

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-26 Thread Programmingkid
On Aug 26, 2015, at 6:04 PM, John Snow wrote: > > > On 08/26/2015 06:01 PM, Jeff Cody wrote: >> On Wed, Aug 26, 2015 at 02:17:17PM -0400, Programmingkid wrote: >>> >>> On Aug 26, 2015, at 2:08 PM, Jeff Cody wrote: >>> On Wed, Aug 26, 2015 at 01:29:04PM -0400, Programmingkid wrote: >

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-26 Thread Programmingkid
On Aug 26, 2015, at 6:01 PM, Jeff Cody wrote: > On Wed, Aug 26, 2015 at 02:17:17PM -0400, Programmingkid wrote: >> >> On Aug 26, 2015, at 2:08 PM, Jeff Cody wrote: >> >>> On Wed, Aug 26, 2015 at 01:29:04PM -0400, Programmingkid wrote: On Aug 26, 2015, at 1:25 PM, Jeff Cody wrote: >>>

Re: [Qemu-devel] [PATCH v2] i386: keep cpu_model field in MachineState uptodate

2015-08-26 Thread Zhu Guihua
On 08/26/2015 11:11 PM, Eduardo Habkost wrote: On Mon, Aug 24, 2015 at 05:42:09PM +0800, Zhu Guihua wrote: Update cpu_model in MachineState for i386, so that the field can be used for cpu hotplug, instead of using a static variable. Signed-off-by: Zhu Guihua [...] -void pc_cpus_init(const c

Re: [Qemu-devel] [PATCH v8 00/11] Add a netfilter object and netbuffer filter

2015-08-26 Thread Jason Wang
On 08/26/2015 05:59 PM, Yang Hongyang wrote: > This patch add a new object netfilter, capture all network packets. > Also implement a netbuffer based on this object. > the "buffer" netfilter could be used by VM FT solutions like > MicroCheckpointing, to buffer/release packets. Or to simulate > pa

Re: [Qemu-devel] [PATCH RFC 4/5] net/dump: Provide the dumping facility as a net filter

2015-08-26 Thread Yang Hongyang
On 08/27/2015 10:33 AM, Thomas Huth wrote: Add glue code to use the dumping functions as a netdev filter, too. Overall looks good to me, thanks. Note that the QAPI part might change later, so there might be some rebase work later, thanks again! Signed-off-by: Thomas Huth --- net/dump.c

[Qemu-devel] [PATCH v2] sheepdog: add reopen support

2015-08-26 Thread Liu Yuan
From: Liu Yuan With reopen supported, block-commit (and offline commit) is now supported for image files whose base image uses the Sheepdog protocol driver. Cc: qemu-devel@nongnu.org Cc: Jeff Cody Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan --- v2: - free AioHandler [Jeff Cod

Re: [Qemu-devel] [PATCH v8 10/11] filter/buffer: update command description and help

2015-08-26 Thread Yang Hongyang
On 08/26/2015 11:55 PM, Markus Armbruster wrote: Yang Hongyang writes: now that we have a buffer netfilter, update the command description and help. Signed-off-by: Yang Hongyang CC: Luiz Capitulino CC: Markus Armbruster --- v8: add more description for the filter to the TEXI section ---

Re: [Qemu-devel] [PATCH v8 01/11] net: add a new object netfilter

2015-08-26 Thread Yang Hongyang
On 08/26/2015 10:04 PM, Markus Armbruster wrote: Missed a bunch of revisions of this series, please excuse gaps in my understanding. Thank you for the review. Yang Hongyang writes: Add the framework for a new netfilter object and a new -netfilter CLI option as a basis for the following pa

[Qemu-devel] [PATCH RFC 3/5] net/dump: Separate the NetClientState from the DumpState

2015-08-26 Thread Thomas Huth
With the upcoming dumping-via-netfilter patch, the DumpState should not be related to NetClientState anymore, so move the related information to a new struct called DumpNetClient. Signed-off-by: Thomas Huth --- net/dump.c | 73 +- 1 fil

[Qemu-devel] [PATCH RFC 5/5] net/dump: Add documentation

2015-08-26 Thread Thomas Huth
Add a short description for the command line options. Signed-off-by: Thomas Huth --- qemu-options.hx | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 390e055..21cf129 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@

[Qemu-devel] [PATCH RFC 0/5] Network traffic dumping via netfilter

2015-08-26 Thread Thomas Huth
The "-net dump" option only works with the "-net" option. So far, it is not possible to dump network traffic with the "-netdev" option yet. This patch series now fixes this ugliness by enabling dumping for the netdev devices via the new netfilter infrastructure. It can be used like this for example

[Qemu-devel] [PATCH RFC 2/5] net/dump: Rework net-dump init functions

2015-08-26 Thread Thomas Huth
Move the creation of the dump client from net_dump_init() into net_init_dump(), so we can later use the former function for dump via netfilter, too. Also rename net_dump_init() to net_dump_state_init() to make it easier distinguishable from net_init_dump(). Signed-off-by: Thomas Huth --- net/dum

[Qemu-devel] [PATCH RFC 1/5] net/dump: Add support for receive_iov function

2015-08-26 Thread Thomas Huth
Adding a proper receive_iov function to the net dump module. This will make it easier to support the dump filter feature for the -netdev option in later patches. Signed-off-by: Thomas Huth --- net/dump.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH RFC 4/5] net/dump: Provide the dumping facility as a net filter

2015-08-26 Thread Thomas Huth
Add glue code to use the dumping functions as a netdev filter, too. Signed-off-by: Thomas Huth --- net/dump.c | 54 ++ net/filter.c | 1 + net/filters.h| 2 ++ qapi-schema.json | 20 +++- 4 files changed, 76 inse

Re: [Qemu-devel] [PATCH v8 00/11] Add a netfilter object and netbuffer filter

2015-08-26 Thread Yang Hongyang
On 08/26/2015 11:58 PM, Markus Armbruster wrote: Yang Hongyang writes: This patch add a new object netfilter, capture all network packets. Also implement a netbuffer based on this object. the "buffer" netfilter could be used by VM FT solutions like MicroCheckpointing, to buffer/release packe

Re: [Qemu-devel] [PATCH v8 00/11] Add a netfilter object and netbuffer filter

2015-08-26 Thread Yang Hongyang
On 08/27/2015 09:05 AM, Thomas Huth wrote: On 26/08/15 11:59, Yang Hongyang wrote: This patch add a new object netfilter, capture all network packets. Also implement a netbuffer based on this object. the "buffer" netfilter could be used by VM FT solutions like MicroCheckpointing, to buffer/rel

Re: [Qemu-devel] [PATCH v2 0/2] rtl8139: Fix buffer overflow in standard mode

2015-08-26 Thread Vlad Yasevich
On 08/26/2015 03:51 PM, Vladislav Yasevich wrote: > When rtl8139 card is running in standard mode, it is very easy > to overlflow and the receive buffer and get into a siutation > where all packets are dropped. Simply reproduction case is > to ping the guest from the host with 6500 byte packets.

Re: [Qemu-devel] [PATCH v8 00/11] Add a netfilter object and netbuffer filter

2015-08-26 Thread Thomas Huth
On 26/08/15 11:59, Yang Hongyang wrote: > This patch add a new object netfilter, capture all network packets. > Also implement a netbuffer based on this object. > the "buffer" netfilter could be used by VM FT solutions like > MicroCheckpointing, to buffer/release packets. Or to simulate > packet de

[Qemu-devel] Mount image file feature

2015-08-26 Thread G 3
I want to share files between my host and guest computer. A feature I want to add would be a new menu item in the Machine menu called "Mount Image File...". When the user selects it, a file open dialog box displays. The user can then select the image file with the file he wants to use. After pushin

Re: [Qemu-devel] is there a limit on the number of in-flight I/O operations?

2015-08-26 Thread Josh Durgin
On 08/26/2015 04:47 PM, Andrey Korolyov wrote: On Thu, Aug 27, 2015 at 2:31 AM, Josh Durgin wrote: On 08/26/2015 10:10 AM, Andrey Korolyov wrote: On Thu, May 14, 2015 at 4:42 PM, Andrey Korolyov wrote: On Wed, Aug 27, 2014 at 9:43 AM, Chris Friesen wrote: On 08/25/2014 03:50 PM, Chris F

Re: [Qemu-devel] is there a limit on the number of in-flight I/O operations?

2015-08-26 Thread Andrey Korolyov
On Thu, Aug 27, 2015 at 2:31 AM, Josh Durgin wrote: > On 08/26/2015 10:10 AM, Andrey Korolyov wrote: >> >> On Thu, May 14, 2015 at 4:42 PM, Andrey Korolyov wrote: >>> >>> On Wed, Aug 27, 2014 at 9:43 AM, Chris Friesen >>> wrote: On 08/25/2014 03:50 PM, Chris Friesen wrote: > I

[Qemu-devel] [PATCH v4 13/13] qga: start a man page

2015-08-26 Thread marcandre . lureau
From: Marc-André Lureau Add a simple man page for the qemu agent. Signed-off-by: Marc-André Lureau Reviewed-by: Michael Roth --- Makefile | 14 +- qemu-doc.texi | 6 +++ qemu-ga.texi | 136 ++ 3 files changed, 154 insertions

[Qemu-devel] [PATCH v4 11/13] qga: add an optional qemu-ga.conf system configuration

2015-08-26 Thread marcandre . lureau
From: Marc-André Lureau Learn to configure the agent with a system configuration. This may simplify command-line handling, especially when the blacklist is long. Among the other benefits, this may standardize the configuration of an init service (instead of distro-specific init keys/files) Sig

[Qemu-devel] [PATCH v4 10/13] qga: free a bit more

2015-08-26 Thread marcandre . lureau
From: Marc-André Lureau Now that main() has a single exit point, we can free a few more allocations. Signed-off-by: Marc-André Lureau Reviewed-by: Denis V. Lunev --- qga/main.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/qga/main.c b/qga/main.c index 6518e1f..710

[Qemu-devel] [PATCH v4 08/13] qga: fill default options in main()

2015-08-26 Thread marcandre . lureau
From: Marc-André Lureau Fill all default options during main(). This is a preparation patch to allow to dump the configuration. Signed-off-by: Marc-André Lureau Reviewed-by: Michael Roth Reviewed-by: Denis V. Lunev --- qga/main.c | 34 +- 1 file changed, 17 in

[Qemu-devel] [PATCH v4 09/13] qga: move agent run in a separate function

2015-08-26 Thread marcandre . lureau
From: Marc-André Lureau Once the options are populated, move the running state to a run_agent() function. Signed-off-by: Marc-André Lureau Reviewed-by: Michael Roth Reviewed-by: Denis V. Lunev --- qga/main.c | 166 + 1 file changed,

[Qemu-devel] [PATCH v4 05/13] qga: rename 'path' to 'channel_path'

2015-08-26 Thread marcandre . lureau
From: Marc-André Lureau 'path' is already a global function, rename the variable since it's going to be in global scope in a later patch. Signed-off-by: Marc-André Lureau Reviewed-by: Michael Roth Reviewed-by: Denis V. Lunev --- qga/main.c | 9 + 1 file changed, 5 insertions(+), 4 de

[Qemu-devel] [PATCH v4 12/13] qga: add --dump-conf option

2015-08-26 Thread marcandre . lureau
From: Marc-André Lureau This new option allows to review the agent configuration, and ease the task of writing a configuration file. Signed-off-by: Marc-André Lureau Reviewed-by: Michael Roth --- qga/main.c | 64 ++ 1 file changed, 6

Re: [Qemu-devel] [PATCH v4 12/13] qga: add --dump-conf option

2015-08-26 Thread Marc-André Lureau
Hi On Thu, Aug 27, 2015 at 1:34 AM, wrote: > +if (keyfile) { > +g_key_file_free(keyfile); > +} > +} I forgot the if () can be removed now. -- Marc-André Lureau

[Qemu-devel] [PATCH v4 04/13] qga: make split_list() return allocated strings

2015-08-26 Thread marcandre . lureau
From: Marc-André Lureau In order to avoid any confusion, let's allocate new strings when splitting. Signed-off-by: Marc-André Lureau --- qga/commands-posix.c | 6 +++--- qga/commands-win32.c | 4 ++-- qga/main.c | 22 +- 3 files changed, 14 insertions(+), 18 del

[Qemu-devel] [PATCH v4 03/13] qga: move string split in separate function

2015-08-26 Thread marcandre . lureau
From: Marc-André Lureau The function is going to be reused in a later patch. Signed-off-by: Marc-André Lureau Reviewed-by: Michael Roth --- qga/main.c | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/qga/main.c b/qga/main.c index 10bb2f7.

[Qemu-devel] [PATCH v4 07/13] qga: move option parsing to separate function

2015-08-26 Thread marcandre . lureau
From: Marc-André Lureau Move option parsing out of giant main(). Signed-off-by: Marc-André Lureau Reviewed-by: Michael Roth Reviewed-by: Denis V. Lunev --- qga/main.c | 165 +++-- 1 file changed, 96 insertions(+), 69 deletions(-) diff

[Qemu-devel] [PATCH v4 06/13] qga: copy argument strings

2015-08-26 Thread marcandre . lureau
From: Marc-André Lureau Following patch will return allocated strings, so we must correctly initialize alloc & free them. The nice side effect is that we no longer have to check for "fixed_state_dir" to call ga_install_service() with a NULL state dir. The default values are set after parsing the

[Qemu-devel] [PATCH v4 01/13] qga: misc spelling

2015-08-26 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake Reviewed-by: Denis V. Lunev Reviewed-by: Michael Roth --- qga/qapi-schema.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json index 18e3cc3..6b0bd

[Qemu-devel] [PATCH v4 00/13] qemu-ga: add a configuration file

2015-08-26 Thread marcandre . lureau
From: Marc-André Lureau Hi, The following patches for the qemu agent add support for an optionnal configuration file, and a man page. v3->v4: - some spelling fixes - add a patch to allocate in split_list() - add more details in "copy argument strings" patch - add some g_free() in config_parse()

[Qemu-devel] [PATCH v4 02/13] qga: use exit() when parsing options

2015-08-26 Thread marcandre . lureau
From: Marc-André Lureau The option parsing is going to be moved to a separate function, use exit() consistently. Signed-off-by: Marc-André Lureau Reviewed-by: Denis V. Lunev Reviewed-by: Eric Blake Reviewed-by: Michael Roth --- qga/main.c | 24 1 file changed, 12 in

Re: [Qemu-devel] is there a limit on the number of in-flight I/O operations?

2015-08-26 Thread Josh Durgin
On 08/26/2015 10:10 AM, Andrey Korolyov wrote: On Thu, May 14, 2015 at 4:42 PM, Andrey Korolyov wrote: On Wed, Aug 27, 2014 at 9:43 AM, Chris Friesen wrote: On 08/25/2014 03:50 PM, Chris Friesen wrote: I think I might have a glimmering of what's going on. Someone please correct me if I get

Re: [Qemu-devel] [PATCH v1 2/3] object.c: object_class_dynamic_cast return NULL if the class has no type

2015-08-26 Thread John Snow
On 08/26/2015 06:15 PM, Peter Crosthwaite wrote: > On Wed, Aug 26, 2015 at 2:46 PM, John Snow wrote: >> >> >> On 08/26/2015 05:02 PM, Peter Crosthwaite wrote: [snip] >>> >>> So there a few problems in the way of a correct solution. The caller >>> for ahci_lower_irq does not have access to the

Re: [Qemu-devel] [PATCH QEMU] vmstate: Remove redefinition of VMSTATE_UINT32_ARRAY

2015-08-26 Thread Sören Brinkmann
On Fri, 2015-08-14 at 09:48AM +0100, Peter Maydell wrote: > On 14 August 2015 at 07:16, Soren Brinkmann > wrote: > > The macro is defined twice in identical ways. > > > > Signed-off-by: Soren Brinkmann > > --- > > I have the feeling I'm missing a tiny one-letter difference or some > > ifdef, but

Re: [Qemu-devel] [PATCH v1 2/3] object.c: object_class_dynamic_cast return NULL if the class has no type

2015-08-26 Thread Peter Maydell
On 26 August 2015 at 23:15, Peter Crosthwaite wrote: > On Wed, Aug 26, 2015 at 2:46 PM, John Snow wrote: >> For the uninitiated, how does MSI work with Sysbus? > > No such thing :) Interrupts in Sysbus shouldn't really exist and those > that do are just a thin wrapper around raw pins. The short a

[Qemu-devel] [PATCH 3/4] build: qemu-ga: fix VSS dependencies

2015-08-26 Thread Michael Roth
Currently VSS dll/tlb files for use in w32 builds are only built as a result of having been added to the general 'tools' target alongside qemu-ga. This is fine for default make target, but if we build qemu-ga directly via `make qemu-ga.exe`, the VSS files are not created. Fix this by moving the VS

[Qemu-devel] [PATCH 1/4] configure: qemu-ga: move MSI installer probe after qga probe

2015-08-26 Thread Michael Roth
MSI probe assumes that qemu-ga support has been probed already, but in cases where --enable-guest-agent/--disable-guest-agent have not been passed to configure, qemu-ga support may end up getting enabled later, as is the case with w32 builds. This leads to MSI probe prematurely reporting error due

[Qemu-devel] [PATCH 4/4] Makefile: qemu-ga: fix msi target error message

2015-08-26 Thread Michael Roth
'msi' target reports error if we attempt to use it when QEMU hasn't been ./configure'd to enable it. The parenthesis cause an interpreter error if we don't enclose the error in quotes. Signed-off-by: Michael Roth --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Ma

[Qemu-devel] [0/4] qemu-ga: various w32 build fix-ups for MSI/VSS support

2015-08-26 Thread Michael Roth
These patches are based on the qga-dev tree: https://github.com/mdroth/qemu/commits/qga-dev and are also available from: https://github.com/mdroth/qemu/commits/qga-dev-build-fixes These are minor fixes/refactorings to improve the build process for qemu-ga. Makefile | 10 ++ configure |

[Qemu-devel] [PATCH 2/4] configure: qemu-ga: explicitly enable qemu-ga MSI support when probed

2015-08-26 Thread Michael Roth
Currently, if we don't explicitly disable support for MSI installer via --disable-guest-agent-msi, the configure variable that tracks the flag, 'guest_agent_msi', never gets set unless one of the probes fails. Subsequent code then treats this unset value the same as if it were a "yes" value (via !=

Re: [Qemu-devel] [PATCH v3] opts: produce valid command line in qemu_opts_print

2015-08-26 Thread Kővágó Zoltán
2015-08-26 15:15 keltezéssel, Markus Armbruster írta: Stefan Hajnoczi writes: On Tue, Jul 7, 2015 at 3:42 PM, Kővágó, Zoltán wrote: This will let us print options in a format that the user would actually write it on the command line (foo=bar,baz=asd,etc=def), without prepending a spurious co

Re: [Qemu-devel] [PATCH] qemu-ga: Fixed paths issue with MSI build

2015-08-26 Thread Michael Roth
Quoting Leonid Bloch (2015-08-26 07:07:16) > Previously, if building out-of-tree, the MSI build would fail since it wasn't > able to find the needed files. > > Signed-off-by: Leonid Bloch Thanks, applied to qga tree: https://github.com/mdroth/qemu/commits/qga > --- > Makefile

Re: [Qemu-devel] [PATCH v3 0/4] qemu-ga: Fixes to the QEMU GA MSI installer

2015-08-26 Thread Michael Roth
Quoting Leonid Bloch (2015-08-03 12:54:20) > The main purpose here is to fix a bug that caused the QEMU GA VSS service to > be unregistered on reinstallation using the .msi file. > Also, two fixes are introduced to the .wxs file, which is used to create the > MSI with Wixl: GUID capitalization an

Re: [Qemu-devel] [PATCH v1 2/3] object.c: object_class_dynamic_cast return NULL if the class has no type

2015-08-26 Thread Peter Crosthwaite
On Wed, Aug 26, 2015 at 2:46 PM, John Snow wrote: > > > On 08/26/2015 05:02 PM, Peter Crosthwaite wrote: >> On Wed, Aug 26, 2015 at 1:36 PM, Alistair Francis >> wrote: >>> On Tue, Aug 25, 2015 at 12:43 AM, Peter Crosthwaite >>> wrote: On Mon, Aug 24, 2015 at 4:36 PM, Alistair Francis

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-26 Thread John Snow
On 08/26/2015 05:48 PM, Programmingkid wrote: > > On Aug 26, 2015, at 2:45 PM, Peter Maydell wrote: > >> On 26 August 2015 at 18:16, Programmingkid wrote: >>> That is assuming they have the time and/or the interest in solving this >>> problem. I >>> suppose giving them some time to respond wo

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-26 Thread John Snow
On 08/26/2015 06:01 PM, Jeff Cody wrote: > On Wed, Aug 26, 2015 at 02:17:17PM -0400, Programmingkid wrote: >> >> On Aug 26, 2015, at 2:08 PM, Jeff Cody wrote: >> >>> On Wed, Aug 26, 2015 at 01:29:04PM -0400, Programmingkid wrote: On Aug 26, 2015, at 1:25 PM, Jeff Cody wrote: >

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-26 Thread Jeff Cody
On Wed, Aug 26, 2015 at 02:17:17PM -0400, Programmingkid wrote: > > On Aug 26, 2015, at 2:08 PM, Jeff Cody wrote: > > > On Wed, Aug 26, 2015 at 01:29:04PM -0400, Programmingkid wrote: > >> > >> On Aug 26, 2015, at 1:25 PM, Jeff Cody wrote: > >> > >>> On Wed, Aug 26, 2015 at 06:31:57PM +0200, Ma

Re: [Qemu-devel] [PATCH v5 6/9] crypto: add sanity checking of TLS x509 credentials

2015-08-26 Thread Eric Blake
On 08/26/2015 09:05 AM, Daniel P. Berrange wrote: > If the administrator incorrectly sets up their x509 certificates, > the errors seen at runtime during connection attempts are very > obscure and difficult to diagnose. This has been a particular > problem for people using openssl to generate their

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-26 Thread Programmingkid
On Aug 26, 2015, at 2:45 PM, Peter Maydell wrote: > On 26 August 2015 at 18:16, Programmingkid wrote: >> That is assuming they have the time and/or the interest in solving this >> problem. I >> suppose giving them some time to respond would be reasonable. I'm thinking if >> no consensus has bee

Re: [Qemu-devel] [PATCH v1 2/3] object.c: object_class_dynamic_cast return NULL if the class has no type

2015-08-26 Thread John Snow
On 08/26/2015 05:02 PM, Peter Crosthwaite wrote: > On Wed, Aug 26, 2015 at 1:36 PM, Alistair Francis > wrote: >> On Tue, Aug 25, 2015 at 12:43 AM, Peter Crosthwaite >> wrote: >>> On Mon, Aug 24, 2015 at 4:36 PM, Alistair Francis >>> wrote: On Mon, Aug 17, 2015 at 4:37 PM, Peter Crosthwait

[Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-08-26 Thread Serge Hallyn
** Changed in: qemu (Ubuntu Trusty) Assignee: Serge Hallyn (serge-hallyn) => (unassigned) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1422307 Title: qemu-nbd corrupts files Status in QEMU:

Re: [Qemu-devel] [PATCH v5 5/9] crypto: introduce new module for TLS x509 credentials

2015-08-26 Thread Eric Blake
On 08/26/2015 09:05 AM, Daniel P. Berrange wrote: > Introduce a QCryptoTLSCredsX509 class which is used to > manage x509 certificate TLS credentials. This will be > the preferred credential type offering strong security > characteristics > > Example CLI configuration: > > $QEMU -object tls-creds

Re: [Qemu-devel] [PATCH v5 4/9] crypto: introduce new module for TLS anonymous credentials

2015-08-26 Thread Eric Blake
On 08/26/2015 09:05 AM, Daniel P. Berrange wrote: > Introduce a QCryptoTLSCredsAnon class which is used to > manage anonymous TLS credentials. Use of this class is > generally discouraged since it does not offer strong > security, but it is required for backwards compatibility > with the current VN

[Qemu-devel] [PATCH 3/4] ide-test: add cdrom pio test

2015-08-26 Thread John Snow
Add a simple read test for ATAPI devices, using the PIO mechanism. Signed-off-by: John Snow --- tests/ide-test.c | 144 +++ 1 file changed, 144 insertions(+) diff --git a/tests/ide-test.c b/tests/ide-test.c index 4a07e3a..90524e3 100644 --- a/

[Qemu-devel] [PATCH 2/4] qtest/ahci: export generate_pattern

2015-08-26 Thread John Snow
Share the pattern function for ide and ahci test. Signed-off-by: John Snow --- tests/ahci-test.c | 26 -- tests/libqos/libqos.c | 26 ++ tests/libqos/libqos.h | 1 + 3 files changed, 27 insertions(+), 26 deletions(-) diff --git a/tests/ahci-t

[Qemu-devel] [PATCH 4/4] ide-test: add cdrom dma test

2015-08-26 Thread John Snow
Now, test the DMA functionality of the ATAPI drive. Signed-off-by: John Snow --- tests/ide-test.c | 90 1 file changed, 72 insertions(+), 18 deletions(-) diff --git a/tests/ide-test.c b/tests/ide-test.c index 90524e3..f4a913d 100644 --- a

[Qemu-devel] [PATCH 1/4] qtest/ahci: use generate_pattern everywhere

2015-08-26 Thread John Snow
Fix the pattern generation to actually be interesting, and make sure all buffers in the ahci-test actually use it. Signed-off-by: John Snow --- tests/ahci-test.c | 23 ++- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git a/tests/ahci-test.c b/tests/ahci-test.c ind

[Qemu-devel] [PATCH 0/4] ide: simple ATAPI tests

2015-08-26 Thread John Snow
We don't have any CDROM tests yet. So, add some for the PCI/BMDMA HBA. For convenience, this branch is available at: https://github.com/jnsnow/qemu.git branch ide-atapi-test https://github.com/jnsnow/qemu/tree/ide-at

Re: [Qemu-devel] [PATCH v1 2/3] object.c: object_class_dynamic_cast return NULL if the class has no type

2015-08-26 Thread Peter Crosthwaite
On Wed, Aug 26, 2015 at 1:36 PM, Alistair Francis wrote: > On Tue, Aug 25, 2015 at 12:43 AM, Peter Crosthwaite > wrote: >> On Mon, Aug 24, 2015 at 4:36 PM, Alistair Francis >> wrote: >>> On Mon, Aug 17, 2015 at 4:37 PM, Peter Crosthwaite >>> wrote: On Mon, Aug 17, 2015 at 3:33 PM, Andreas

Re: [Qemu-devel] [PATCH v1 2/3] object.c: object_class_dynamic_cast return NULL if the class has no type

2015-08-26 Thread Alistair Francis
On Tue, Aug 25, 2015 at 12:43 AM, Peter Crosthwaite wrote: > On Mon, Aug 24, 2015 at 4:36 PM, Alistair Francis > wrote: >> On Mon, Aug 17, 2015 at 4:37 PM, Peter Crosthwaite >> wrote: >>> On Mon, Aug 17, 2015 at 3:33 PM, Andreas Färber wrote: Am 18.08.2015 um 00:24 schrieb Alistair Francis

[Qemu-devel] [Bug 1488363] Re: qemu 2.4.0 hangs using vfio for pci passthrough of graphics card

2015-08-26 Thread Peter Maloney
I ran a bisect, and here's the result: b8eb5512fd8a115f164edbbe897cdf8884920ccb is the first bad commit commit b8eb5512fd8a115f164edbbe897cdf8884920ccb Author: Nadav Amit Date: Mon Apr 13 02:32:08 2015 +0300 target-i386: disable LINT0 after reset Due to old Seabios bug, QEMU reen

[Qemu-devel] [PATCH 2/2] rtl8139: correctly track full receive buffer in standard mode

2015-08-26 Thread Vladislav Yasevich
In standard operation mode, when the receive ring buffer is full, the buffer actually appears empty to the driver since the RxBufAddr (the location we wirte new data to) and RxBufPtr (the location guest would stat reading from) are the same. As a result, the call to rtl8139_RxBufferEmpty ends up re

[Qemu-devel] [PATCH 1/2] rtl8139: Do not consume the packet during overflow in standard mode.

2015-08-26 Thread Vladislav Yasevich
When operation in standard mode, we currently return the size of packet during buffer overflow. This consumes the overflow packet. Return 0 instead so we can re-process the overflow packet when we have room. This fixes issues with lost/dropped fragments of large messages. Signed-off-by: Vladisl

[Qemu-devel] [PATCH v2 0/2] rtl8139: Fix buffer overflow in standard mode

2015-08-26 Thread Vladislav Yasevich
When rtl8139 card is running in standard mode, it is very easy to overlflow and the receive buffer and get into a siutation where all packets are dropped. Simply reproduction case is to ping the guest from the host with 6500 byte packets. There are actually 2 problems here. 1) When the rtl8129

Re: [Qemu-devel] Debian 7.8.0 SPARC64 on qemu - anything i can do to speedup the emulation?

2015-08-26 Thread Richard Henderson
On 08/26/2015 09:17 AM, Artyom Tarasenko wrote: After some debugging I think it's caused by memory faults. On every MMU miss / access fault TB is re-translated multiple times till the faulting instruction is found. That shouldn't happen. Are you certain it's not multiple MMU misses/faults? A

Re: [Qemu-devel] [PATCH] block: Override the driver in the filename with the user-specified one

2015-08-26 Thread Alberto Garcia
On Wed 26 Aug 2015 04:53:06 PM CEST, Max Reitz wrote: > Yet another thing is the problem described in the patch's commit > message. Why and how is the driver option inherited by the snapshot? I think you're right and my description was wrong, this happens before the snapshot is created, when bdrv

Re: [Qemu-devel] [PATCH] target-i386: add a list of enforceable CPU models to the help output

2015-08-26 Thread Peter Lieven
> Am 26.08.2015 um 21:00 schrieb Eduardo Habkost : > >> On Wed, Aug 26, 2015 at 08:46:42PM +0200, Peter Lieven wrote: >>> Am 26.08.2015 um 20:38 schrieb Eduardo Habkost: On Mon, Aug 24, 2015 at 09:36:23PM +0200, Peter Lieven wrote: > Am 24.08.2015 um 17:46 schrieb Eric Blake: >> On

Re: [Qemu-devel] QEMU developers on DebConf15?

2015-08-26 Thread Stefan Weil
Am 05.08.2015 um 13:08 schrieb Peter Maydell: > If there are multiple QEMU maintainers going to Debconf, it would > be great if you could arrange to meet up and sign each others' GPG keys > at some point -- that would help us increase the web of trust for > signed pull requests. Done with three Q

Re: [Qemu-devel] [PATCHv2] block/nfs: cache allocated filesize for read-only files

2015-08-26 Thread Jeff Cody
On Wed, Aug 26, 2015 at 08:49:06PM +0200, Peter Lieven wrote: > Am 26.08.2015 um 17:31 schrieb Jeff Cody: > > On Mon, Aug 24, 2015 at 10:13:16PM +0200, Max Reitz wrote: > >> On 24.08.2015 21:34, Peter Lieven wrote: > >>> Am 24.08.2015 um 20:39 schrieb Max Reitz: > On 24.08.2015 10:06, Peter Li

Re: [Qemu-devel] [PATCH] target-i386: add a list of enforceable CPU models to the help output

2015-08-26 Thread Eduardo Habkost
On Wed, Aug 26, 2015 at 08:38:35PM +0200, Peter Lieven wrote: > Am 26.08.2015 um 17:54 schrieb Eduardo Habkost: > > On Mon, Aug 24, 2015 at 11:17:04AM +0200, Peter Lieven wrote: > >> this patch adds a probe that lists all enforceable and migrateable > >> CPU models to the -cpu help output. The idea

Re: [Qemu-devel] [PATCH v3 12/12] qga: start a man page

2015-08-26 Thread Denis V. Lunev
On 08/26/2015 01:05 PM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Add a simple man page for the qemu agent. Signed-off-by: Marc-André Lureau Reviewed-by: Michael Roth --- Makefile | 14 +- qemu-doc.texi | 6 +++ qemu-ga.texi | 136 +++

[Qemu-devel] [PULL 0/1] tci queue

2015-08-26 Thread Stefan Weil
The following changes since commit 47c9dfee808f9455d732aea7c4390ad0972bbd84: Merge remote-tracking branch 'remotes/kraxel/tags/pull-cve-2015-5225-20150826-1' into staging (2015-08-26 17:45:09 +0100) are available in the git repository at: git://qemu.weilnetz.de/qemu.git tag

[Qemu-devel] [PULL 1/1] exec-all: Translate TCI return addresses backwards too

2015-08-26 Thread Stefan Weil
From: Peter Crosthwaite This subtraction of return addresses applies directly to TCI as well as host-TCG. This fixes Linux boots for at least Microblaze, CRIS, ARM and SH4 when using TCI. [sw: Removed indentation for preprocessor statement] [sw: The patch also fixes Linux boot for x86_64] Revie

[Qemu-devel] [ARM SMBIOS V5 PATCH 1/2] smbios: add smbios 3.0 support

2015-08-26 Thread Wei Huang
This patch adds support for SMBIOS 3.0 entry point. When caller invokes smbios_set_defaults(), it can specify entry point as 2.1 or 3.0. Then smbios_get_tables() will return the entry point table in right format. Acked-by: Gabriel Somlo Tested-by: Gabriel Somlo Tested-by: Leif Lindholm Signed-o

[Qemu-devel] [ARM SMBIOS V5 PATCH 2/2] smbios: implement smbios support for mach-virt

2015-08-26 Thread Wei Huang
This patch generates smbios tables for ARM mach-virt. Also add CONFIG_SMBIOS=y for ARM default config. Acked-by: Gabriel Somlo Tested-by: Gabriel Somlo Reviewed-by: Laszlo Ersek Reviewed-by: Shannon Zhao Tested-by: Leif Lindholm Signed-off-by: Wei Huang --- default-configs/arm-softmmu.mak |

[Qemu-devel] [ARM SMBIOS V5 PATCH 0/2]SMBIOS Support for ARM

2015-08-26 Thread Wei Huang
SMBIOS tables present userful system hardware info to management applications, such as DMI tools. Even though SMBIOS was originally developed for Intel x86, it has been extended to both Itanium and ARM (32bit & 64bit). More and more ARM server releases, such as RHEL Server for ARM, start to integ

Re: [Qemu-devel] [PATCH v3 11/12] qga: add --dump-conf option

2015-08-26 Thread Marc-André Lureau
- Original Message - > On 08/26/2015 01:05 PM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > This new option allows to review the agent configuration, > > and ease the task of writing a configuration file. > > > > Signed-off-by: Marc-André Lureau > > Reviewed-by

Re: [Qemu-devel] [PATCH v3 11/12] qga: add --dump-conf option

2015-08-26 Thread Denis V. Lunev
On 08/26/2015 01:05 PM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau This new option allows to review the agent configuration, and ease the task of writing a configuration file. Signed-off-by: Marc-André Lureau Reviewed-by: Michael Roth --- qga/main.c | 62 +++

Re: [Qemu-devel] [PATCH] target-i386: add a list of enforceable CPU models to the help output

2015-08-26 Thread Eduardo Habkost
On Wed, Aug 26, 2015 at 08:46:42PM +0200, Peter Lieven wrote: > Am 26.08.2015 um 20:38 schrieb Eduardo Habkost: > > On Mon, Aug 24, 2015 at 09:36:23PM +0200, Peter Lieven wrote: > >> Am 24.08.2015 um 17:46 schrieb Eric Blake: > >>> On 08/24/2015 03:17 AM, Peter Lieven wrote: > this patch adds

Re: [Qemu-devel] [PATCH v3 05/12] qga: copy argument strings

2015-08-26 Thread Denis V. Lunev
On 08/26/2015 09:41 PM, Marc-André Lureau wrote: On Wed, Aug 26, 2015 at 8:27 PM, Denis V. Lunev wrote: lets consider this patch. You have done 2 things: - changed initialisation order and dropped nasty temporary variables - introduced alloc/free code But in the next patch each line with alloc

Re: [Qemu-devel] [PATCHv2] block/nfs: cache allocated filesize for read-only files

2015-08-26 Thread Peter Lieven
Am 26.08.2015 um 17:31 schrieb Jeff Cody: > On Mon, Aug 24, 2015 at 10:13:16PM +0200, Max Reitz wrote: >> On 24.08.2015 21:34, Peter Lieven wrote: >>> Am 24.08.2015 um 20:39 schrieb Max Reitz: On 24.08.2015 10:06, Peter Lieven wrote: > If the file is readonly its not expected to grow so >>

  1   2   3   4   >