Re: [Qemu-devel] Subject: [PATCH 01/16] linux-user: tilegx: Firstly add architecture related features

2015-08-20 Thread Eric Blake
On 08/20/2015 11:30 PM, Eric Blake wrote: > On 08/20/2015 10:09 AM, gchen gchen wrote: ^^^ > > In the subject line, > s/Firstly add/Add/ > > ('Firstly' is seldom used in English, and certainly not in the context > you were trying to use it) > >> They are based

Re: [Qemu-devel] Subject: [PATCH 01/16] linux-user: tilegx: Firstly add architecture related features

2015-08-20 Thread Eric Blake
On 08/20/2015 10:09 AM, gchen gchen wrote: In the subject line, s/Firstly add/Add/ ('Firstly' is seldom used in English, and certainly not in the context you were trying to use it) > They are based on Linux kernel tilegx architecture for 64 bit binary, > and also based on tilegx ABI reference do

Re: [Qemu-devel] [PATCH v2] qemu-img: Fix crash in amend invocation

2015-08-20 Thread Eric Blake
On 08/20/2015 04:00 PM, Max Reitz wrote: > Example: > $ ./qemu-img create -f qcow2 /tmp/t.qcow2 64M > $ ./qemu-img amend -f qcow2 -o backing_file=/tmp/t.qcow2, -o help \ > /tmp/t.qcow2 > > This should not crash. This actually is tested by iotest 082, but not > caught due to the segmentation fa

Re: [Qemu-devel] [PATCH 2/2] ide/atapi: partially avoid deadlock if the storage backend is dead

2015-08-20 Thread Eric Blake
On 08/20/2015 01:14 AM, Peter Lieven wrote: > the blk_drain_all() that is executed if the guest issues a DMA cancel > leads to a stuck main loop if the storage backend (e.g. a NFS share) > is unresponsive. > > This scenario is a common case for CDROM images mounted from an > NFS share. In this cas

Re: [Qemu-devel] [PATCH 1/2] block/io: allow AIOCB without callback

2015-08-20 Thread Eric Blake
On 08/20/2015 01:14 AM, Peter Lieven wrote: > If the backend storage is unresponsive and we cancel a request due to > a timeout we cannot immediately destroy the AIOCB because the storage > might complete the original request laster if it is responsive again. s/laster/later/ > For this purpose al

Re: [Qemu-devel] Debian 7.8.0 SPARC64 on qemu - anything i can do to speedup the emulation?

2015-08-20 Thread Dennis Luehring
Am 21.08.2015 um 07:49 schrieb Richard Henderson: On 08/20/2015 09:32 PM, Dennis Luehring wrote: > gcc prime.c -o prime.out -lm > > prime.out runtime > > tcg-indirect: ~9.3 sec (best result) > qemu.org-git: ~11 sec > without-optimization: ~9.9 sec (worst result) I presume this is integer prime f

Re: [Qemu-devel] Debian 7.8.0 SPARC64 on qemu - anything i can do to speedup the emulation?

2015-08-20 Thread Richard Henderson
On 08/20/2015 09:32 PM, Dennis Luehring wrote: gcc prime.c -o prime.out -lm prime.out runtime tcg-indirect: ~9.3 sec (best result) qemu.org-git: ~11 sec without-optimization: ~9.9 sec (worst result) I presume this is integer prime factoring? g++ src/pugixml.cpp -g -Wall -Wextra -Werror -ped

[Qemu-devel] [PATCH v13r 04/14] target-tilegx: Add opcode basic implementation from Tilera Corporation

2015-08-20 Thread Richard Henderson
From: Chen Gang It is copied from Linux kernel "arch/tile/include/uapi/arch/ opcode_tilegx.h". Signed-off-by: Chen Gang Reviewed-by: Peter Maydell Message-Id: Signed-off-by: Richard Henderson --- target-tilegx/opcode_tilegx.h | 1406 + 1 file changed,

[Qemu-devel] [PATCH v13r 11/14] target-tilegx: Add TILE-Gx building files

2015-08-20 Thread Richard Henderson
From: Chen Gang Add related configuration and make files for tilegx. The target can now build, though not run anything. Signed-off-by: Chen Gang Reviewed-by: Peter Maydell Message-Id: Signed-off-by: Richard Henderson --- configure | 2 ++ default-configs/tilegx-l

[Qemu-devel] [PATCH v13r 10/14] target-tilegx: Framework for decoding bundles

2015-08-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-tilegx/translate.c | + 1 file changed, insertions(+) create mode 100644 target-tilegx/translate.c diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c new file mode 100644 index

[Qemu-devel] [PATCH v13r 08/14] target-tilegx: Add cpu basic features for linux-user

2015-08-20 Thread Richard Henderson
From: Chen Gang It implements minimized cpu features for linux-user. Signed-off-by: Chen Gang Reviewed-by: Peter Maydell Message-Id: Signed-off-by: Richard Henderson --- target-tilegx/cpu.c | 143 ++ target-tilegx/cpu.h | 175 +

[Qemu-devel] [PATCH v13r 07/14] target-tilegx: Add special register information from Tilera Corporation

2015-08-20 Thread Richard Henderson
From: Chen Gang The related copy is from Linux kernel "arch/tile/include/uapi/arch/ spr_def_64.h". Signed-off-by: Chen Gang Reviewed-by: Peter Maydell Message-Id: Signed-off-by: Richard Henderson --- target-tilegx/spr_def_64.h | 216 + 1 file chan

[Qemu-devel] [PATCH v13r 05/14] target-tilegx: Modify opcode_tilegx.h to fit QEMU usage

2015-08-20 Thread Richard Henderson
From: Chen Gang Use 'inline' instead of '__inline', and also use 'uint64_t' instead of "unsigned long long" Signed-off-by: Chen Gang Reviewed-by: Peter Maydell Message-Id: Signed-off-by: Richard Henderson --- target-tilegx/opcode_tilegx.h | 220 +- 1

[Qemu-devel] [PATCH v13r 13/14] target-tilegx: Handle arithmetic instructions

2015-08-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 95 --- 1 file changed, 89 insertions(+), 6 deletions(-) diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c index 2778cde..7805da4 100644 --- a/target-tilegx/translate.c +

[Qemu-devel] [PATCH v13r 06/14] target-tilegx: Modify _SPECIAL_ opcodes

2015-08-20 Thread Richard Henderson
Both ADDX_SPECIAL_0_OPCODE_Y1 and ADD_SPECIAL_0_OPCODE_Y1 do not appear to be "special" in any way, except that they don't follow the normal naming convention using _RRR_. Signed-off-by: Richard Henderson --- target-tilegx/opcode_tilegx.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCH v13r 14/14] target-tilegx: Handle most bit manipulation instructions

2015-08-20 Thread Richard Henderson
Omitting crc instructions. Signed-off-by: Richard Henderson --- target-tilegx/helper.c| 23 ++ target-tilegx/helper.h| 2 ++ target-tilegx/translate.c | 60 ++- 3 files changed, 84 insertions(+), 1 deletion(-) diff --git a/tar

[Qemu-devel] [PATCH v13r 02/14] linux-user: Support tilegx architecture in linux-user

2015-08-20 Thread Richard Henderson
From: Chen Gang Add main working flow feature, system call processing feature, and elf64 tilegx binary loading feature, based on Linux kernel tilegx 64-bit implementation. Signed-off-by: Chen Gang Reviewed-by: Peter Maydell Message-Id: Signed-off-by: Richard Henderson --- include/elf.h

[Qemu-devel] [PATCH v13r 01/14] linux-user: tilegx: Firstly add architecture related features

2015-08-20 Thread Richard Henderson
From: Chen Gang They are based on Linux kernel tilegx architecture for 64 bit binary, and also based on tilegx ABI reference document, and also reference from other targets implementations. Signed-off-by: Chen Gang Reviewed-by: Peter Maydell Message-Id: Signed-off-by: Richard Henderson ---

[Qemu-devel] [PATCH v13r 12/14] target-tilegx: Handle simple logical operations

2015-08-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 112 -- 1 file changed, 109 insertions(+), 3 deletions(-) diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c index 8f3bfc3..2778cde 100644 --- a/target-tilegx/translate.c

[Qemu-devel] [PATCH v13r 09/14] target-tilegx: Add several helpers for instructions translation

2015-08-20 Thread Richard Henderson
From: Chen Gang The related instructions are exception, cntlz, cnttz, shufflebytes. Signed-off-by: Chen Gang Message-Id: [rth: Remove incorrect implementation of add_saturate.] Signed-off-by: Richard Henderson --- target-tilegx/helper.c | 70 ++

[Qemu-devel] [PATCH v13r 03/14] linux-user: Conditionalize syscalls which are not defined in tilegx

2015-08-20 Thread Richard Henderson
From: Chen Gang Some of architectures (e.g. tilegx), several syscall macros are not supported, so switch them. Signed-off-by: Chen Gang Reviewed-by: Peter Maydell Message-Id: Signed-off-by: Richard Henderson --- linux-user/syscall.c | 50 +- 1

[Qemu-devel] [PATCH v13r 00/14] Revised tilegx-linux-user decoding

2015-08-20 Thread Richard Henderson
Patches 1-9 & 11 are your already reviewed non-decoding patches, with the fixes for application to mainline folded in. Patch 10 is a new framework for decoding the tilegx bundle that doesn't have nearly so much redundant code. The patch is still large, over 1000 lines, but over 500 of those are s

Re: [Qemu-devel] [PATCH 00/16 v1] tilegx: Firstly add tilegx target for linux-user

2015-08-20 Thread Richard Henderson
First off, this isn't v1. The previous patch set you posted was v12. On 08/20/2015 02:32 PM, Chen Gang wrote: Chen Gang (16): linux-user: tilegx: Firstly add architecture related features linux-user: Support tilegx architecture in linux-user linux-user/syscall.c: conditionalize syscall

[Qemu-devel] [PATCH] target-i386: enable cflushopt/clwb/pcommit instructions

2015-08-20 Thread Xiao Guangrong
These instructions are used by NVDIMM drivers and the specification locates at: https://software.intel.com/sites/default/files/managed/0d/53/319433-022.pdf Let them be enabled on Broadwell on default Signed-off-by: Xiao Guangrong --- target-i386/cpu.c | 14 +- target-i386/cpu.h | 3

[Qemu-devel] [PATCH v7 RESEND 07/11] netfilter: print filter info associate with the netdev

2015-08-20 Thread Yang Hongyang
From: Yang Hongyang When execute "info network", print filter info also. current info printed is simple, can add more info later. Signed-off-by: Yang Hongyang --- v7: initial patch --- include/net/filter.h | 1 + net/filter.c | 22 ++ net/net.c| 11

[Qemu-devel] [PATCH v7 RESEND 09/11] netfilter: add a netbuffer filter

2015-08-20 Thread Yang Hongyang
This filter is to buffer/release packets, this feature can be used when using MicroCheckpointing, or other Remus like VM FT solutions, you can also use it to simulate the network delay. It has an interval option, if supplied, this filter will release packets by interval. Usage: -netdev tap,id=bn0

[Qemu-devel] [PATCH v7 RESEND 08/11] net/queue: export qemu_net_queue_append_iov

2015-08-20 Thread Yang Hongyang
Signed-off-by: Yang Hongyang --- include/net/queue.h | 7 +++ net/queue.c | 12 ++-- 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/include/net/queue.h b/include/net/queue.h index 1d65e47..e139cc7 100644 --- a/include/net/queue.h +++ b/include/net/queue.h @@

[Qemu-devel] [PATCH v7 RESEND 03/11] netfilter: add netfilter_{add|del} commands

2015-08-20 Thread Yang Hongyang
add netfilter_{add|del} commands This is mostly the same with netdev_{add|del} commands. When we delete the netdev, we also delete the netfilter object attached to it, because if the netdev is removed, the filters which attached to it is useless. Signed-off-by: Yang Hongyang CC: Luiz Capitulino

[Qemu-devel] [PATCH v7 RESEND 10/11] filter/buffer: update command description and help

2015-08-20 Thread Yang Hongyang
now that we have a buffer netfilter, update the command description and help. Signed-off-by: Yang Hongyang CC: Luiz Capitulino CC: Markus Armbruster --- hmp-commands.hx | 2 +- qemu-options.hx | 5 - qmp-commands.hx | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/hmp

[Qemu-devel] [PATCH v7 RESEND 05/11] move out net queue structs define

2015-08-20 Thread Yang Hongyang
Signed-off-by: Yang Hongyang --- include/net/queue.h | 19 +++ net/queue.c | 19 --- 2 files changed, 19 insertions(+), 19 deletions(-) diff --git a/include/net/queue.h b/include/net/queue.h index fc02b33..1d65e47 100644 --- a/include/net/queue.h +++ b/inc

[Qemu-devel] [PATCH v7 RESEND 11/11] tests: add test cases for netfilter object

2015-08-20 Thread Yang Hongyang
Using qtest qmp interface to implement following cases: 1) add/remove netfilter 2) add a netfilter then delete the netdev 3) add/remove more than one netfilters 4) add more than one netfilters and then delete the netdev Signed-off-by: Yang Hongyang --- tests/.gitignore | 1 + tests/Makef

[Qemu-devel] [PATCH v7 RESEND 04/11] netfilter: hook packets before net queue send

2015-08-20 Thread Yang Hongyang
Capture packets that will be sent. Signed-off-by: Yang Hongyang --- v5: do not check ret against iov_size pass sent_cb to filters --- net/net.c | 66 +++ 1 file changed, 66 insertions(+) diff --git a/net/net.c b/net/net.c index 74f

[Qemu-devel] [PATCH v7 RESEND 01/11] net: add a new object netfilter

2015-08-20 Thread Yang Hongyang
Add the framework for a new netfilter object and a new -netfilter CLI option as a basis for the following patches. Signed-off-by: Yang Hongyang CC: Paolo Bonzini CC: Eric Blake Reviewed-by: Thomas Huth --- include/net/filter.h| 15 +++ include/sysemu/sysemu.h | 1 + net/Makef

[Qemu-devel] [PATCH v7 RESEND 06/11] netfilter: add an API to pass the packet to next filter

2015-08-20 Thread Yang Hongyang
add an API qemu_netfilter_pass_to_next() to pass the packet to next filter. Signed-off-by: Yang Hongyang --- v5: fold params to NetPacket struct --- include/net/filter.h | 3 +++ net/filter.c | 33 + 2 files changed, 36 insertions(+) diff --git a/includ

[Qemu-devel] [PATCH v7 RESEND 00/11] Add a netfilter object and netbuffer filter

2015-08-20 Thread Yang Hongyang
This patch add a new object netfilter, capture all network packets. Also implement a netbuffer based on this object. the "buffer" netfilter could be used by VM FT solutions like MicroCheckpointing, to buffer/release packets. Or to simulate packet delay. You can also get the series from: https://gi

[Qemu-devel] [PATCH v7 RESEND 02/11] init/cleanup of netfilter object

2015-08-20 Thread Yang Hongyang
QTAILQ_ENTRY global_list but used by filter layer, so that we can manage all filters together. QTAILQ_ENTRY next used by netdev, filter belongs to the specific netdev is in this queue. This is mostly the same with init/cleanup of netdev object. Signed-off-by: Yang Hongyang --- v7: add check for v

Re: [Qemu-devel] Debian 7.8.0 SPARC64 on qemu - anything i can do to speedup the emulation?

2015-08-20 Thread Dennis Luehring
Am 20.08.2015 um 19:19 schrieb Richard Henderson: This isn't surprising, because at the moment tcg optimizations are almost completely ineffective for sparc. The way the register windows are implemented means that there are very few proper tcg temporaries to optimize. I've just updated an old b

Re: [Qemu-devel] [PATCH v7 00/11] Add a netfilter object and netbuffer filter

2015-08-20 Thread Yang Hongyang
This is outdate, sorry for the noise, I will resend it later... On 08/21/2015 12:30 PM, Yang Hongyang wrote: This patch add a new object netfilter, capture all network packets. Also implement a netbuffer based on this object. the "buffer" netfilter could be used by VM FT solutions like MicroChec

[Qemu-devel] [PATCH v7 03/11] netfilter: add netfilter_{add|del} commands

2015-08-20 Thread Yang Hongyang
add netfilter_{add|del} commands This is mostly the same with netdev_{add|del} commands. When we delete the netdev, we also delete the netfilter object attached to it, because if the netdev is removed, the filters which attached to it is useless. Signed-off-by: Yang Hongyang CC: Luiz Capitulino

[Qemu-devel] [PATCH v7 11/11] tests: add test cases for netfilter object

2015-08-20 Thread Yang Hongyang
Using qtest qmp interface to implement following cases: 1) add/remove netfilter 2) add a netfilter then delete the netdev 3) add/remove more than one netfilters 4) add more than one netfilters and then delete the netdev Signed-off-by: Yang Hongyang --- tests/.gitignore | 1 + tests/Makef

[Qemu-devel] [PATCH v7 04/11] netfilter: hook packets before net queue send

2015-08-20 Thread Yang Hongyang
Capture packets that will be sent. Signed-off-by: Yang Hongyang --- v5: do not check ret against iov_size pass sent_cb to filters --- net/net.c | 66 +++ 1 file changed, 66 insertions(+) diff --git a/net/net.c b/net/net.c index 74f

[Qemu-devel] [PATCH v7 09/11] netfilter: add a netbuffer filter

2015-08-20 Thread Yang Hongyang
This filter is to buffer/release packets, this feature can be used when using MicroCheckpointing, or other Remus like VM FT solutions, you can also use it to simulate the network delay. It has an interval option, if supplied, this filter will release packets by interval. Usage: -netdev tap,id=bn0

[Qemu-devel] [PATCH v7 02/11] init/cleanup of netfilter object

2015-08-20 Thread Yang Hongyang
QTAILQ_ENTRY global_list but used by filter layer, so that we can manage all filters together. QTAILQ_ENTRY next used by netdev, filter belongs to the specific netdev is in this queue. This is mostly the same with init/cleanup of netdev object. Signed-off-by: Yang Hongyang --- v7: add check for v

[Qemu-devel] [PATCH v7 10/11] filter/buffer: update command description and help

2015-08-20 Thread Yang Hongyang
now that we have a buffer netfilter, update the command description and help. Signed-off-by: Yang Hongyang CC: Luiz Capitulino CC: Markus Armbruster --- hmp-commands.hx | 2 +- qemu-options.hx | 5 - qmp-commands.hx | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/hmp

[Qemu-devel] [PATCH v7 08/11] net/queue: export qemu_net_queue_append_iov

2015-08-20 Thread Yang Hongyang
Signed-off-by: Yang Hongyang --- include/net/queue.h | 7 +++ net/queue.c | 12 ++-- 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/include/net/queue.h b/include/net/queue.h index 1d65e47..e139cc7 100644 --- a/include/net/queue.h +++ b/include/net/queue.h @@

[Qemu-devel] [PATCH v7 07/11] netfilter: print filter info associate with the netdev

2015-08-20 Thread Yang Hongyang
From: Yang Hongyang when execute "info network", print filter info also. Signed-off-by: Yang Hongyang --- v7: initial patch --- include/net/filter.h | 1 + net/filter.c | 22 ++ net/net.c| 11 +++ 3 files changed, 34 insertions(+) diff --git a/

[Qemu-devel] [PATCH v7 01/11] net: add a new object netfilter

2015-08-20 Thread Yang Hongyang
Add the framework for a new netfilter object and a new -netfilter CLI option as a basis for the following patches. Signed-off-by: Yang Hongyang CC: Paolo Bonzini CC: Eric Blake Reviewed-by: Thomas Huth --- include/net/filter.h| 15 +++ include/sysemu/sysemu.h | 1 + net/Makef

[Qemu-devel] [PATCH v7 06/11] netfilter: add an API to pass the packet to next filter

2015-08-20 Thread Yang Hongyang
add an API qemu_netfilter_pass_to_next() to pass the packet to next filter. Signed-off-by: Yang Hongyang --- v5: fold params to NetPacket struct --- include/net/filter.h | 3 +++ net/filter.c | 33 + 2 files changed, 36 insertions(+) diff --git a/includ

[Qemu-devel] [PATCH v7 00/11] Add a netfilter object and netbuffer filter

2015-08-20 Thread Yang Hongyang
This patch add a new object netfilter, capture all network packets. Also implement a netbuffer based on this object. the "buffer" netfilter could be used by VM FT solutions like MicroCheckpointing, to buffer/release packets. Or to simulate packet delay. You can also get the series from: https://gi

[Qemu-devel] [PATCH v7 05/11] move out net queue structs define

2015-08-20 Thread Yang Hongyang
Signed-off-by: Yang Hongyang --- include/net/queue.h | 19 +++ net/queue.c | 19 --- 2 files changed, 19 insertions(+), 19 deletions(-) diff --git a/include/net/queue.h b/include/net/queue.h index fc02b33..1d65e47 100644 --- a/include/net/queue.h +++ b/inc

Re: [Qemu-devel] [PATCH v2 0/3] SysFS driver for QEMU fw_cfg device

2015-08-20 Thread Gabriel L. Somlo
On Thu, Aug 20, 2015 at 07:21:48AM +0200, Ard Biesheuvel wrote: > On 19 August 2015 at 22:49, Gabriel L. Somlo wrote: > >> > From: "Gabriel L. Somlo" > >> >> Several different architectures supported by QEMU are set up with a > >> >> "firmware configuration" (fw_cfg) device, used to pass configur

[Qemu-devel] [PATCH 05/16] target-tilegx/opcode_tilegx.h: Modify it to fit QEMU usage

2015-08-20 Thread gchen gchen
Use 'inline' instead of '__inline', and also use 'uint64_t' instead of "unsigned long long" Signed-off-by: Chen Gang Reviewed-by: Peter Maydell --- target-tilegx/opcode_tilegx.h | 220 +- 1 file changed, 110 insertions(+), 110 deletions(-) diff --git a/tar

[Qemu-devel] [PATCH 06/16] target-tilegx: Add special register information from Tilera Corporation

2015-08-20 Thread gchen gchen
The related copy is from Linux kernel "arch/tile/include/uapi/arch/ spr_def_64.h". Signed-off-by: Chen Gang Reviewed-by: Peter Maydell --- target-tilegx/spr_def_64.h | 216 + 1 file changed, 216 insertions(+) create mode 100644 target-tilegx/spr_def_64.

Re: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: drop _ADR entry from SPCR

2015-08-20 Thread Leif Lindholm
On Thu, Aug 20, 2015 at 07:09:57PM +0800, Shannon Zhao wrote: > >>>Could somebody who understands ACPI and the ramifications > >>>here let me know if I should apply this patch, please? > >>>(since we're now post-2.4) > >> > >>I presume my opinion is clear, but I'm cc:ing some of the Linaro ACPI > >

Re: [Qemu-devel] [PATCH 15/25] paaudio: do not create multiple connections to the same server

2015-08-20 Thread Marc-André Lureau
Hi On Thu, Aug 6, 2015 at 8:28 PM, Kővágó, Zoltán wrote: > Signed-off-by: Kővágó, Zoltán > --- > audio/paaudio.c | 301 > > 1 file changed, 175 insertions(+), 126 deletions(-) > > diff --git a/audio/paaudio.c b/audio/paaudio.c > index a5

Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-08-20 Thread John Snow
On 08/19/2015 02:55 AM, Dr. David Alan Gilbert wrote: > * Eduardo Habkost (ehabk...@redhat.com) wrote: >> Migration with q35 was not possible before commit >> 04329029a8c539eb5f75dcb6d8b016f0c53a031a, because q35 unconditionally creates >> an ich9-ahci device, that was marked as unmigratable. So

Re: [Qemu-devel] [PATCH v6 02/10] init/cleanup of netfilter object

2015-08-20 Thread Jason Wang
On 08/21/2015 12:41 AM, Yang Hongyang wrote: > > > On 08/10/2015 05:18 PM, Jason Wang wrote: >> >> >> On 08/07/2015 10:46 AM, Yang Hongyang wrote: >>> QTAILQ_ENTRY global_list but used by filter layer, so that we can >>> manage all filters together. >>> QTAILQ_ENTRY next used by netdev, filter be

[Qemu-devel] [PATCH] block/nfs: fix calculation of allocated file size

2015-08-20 Thread Peter Lieven
st.st_blocks is always counted in 512 byte units. Do not use st.st_blksize as multiplicator which may be larger. Cc: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven --- block/nfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/nfs.c b/block/nfs.c index c026ff6..02e

Re: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: drop _ADR entry from SPCR

2015-08-20 Thread G Gregory
On 20 August 2015 at 11:18, Leif Lindholm wrote: > On Thu, Aug 20, 2015 at 01:24:39AM +0100, Peter Maydell wrote: >> On 6 August 2015 at 14:25, Andrew Jones wrote: >> > On Thu, Aug 06, 2015 at 01:55:14PM +0100, Leif Lindholm wrote: >> >> On Thu, Aug 06, 2015 at 02:28:03PM +0200, Andrew Jones wrot

[Qemu-devel] [PATCH 04/16] target-tilegx: Add opcode basic implementation from Tilera Corporation

2015-08-20 Thread gchen gchen
It is copied from Linux kernel "arch/tile/include/uapi/arch/ opcode_tilegx.h". Signed-off-by: Chen Gang Reviewed-by: Peter Maydell --- target-tilegx/opcode_tilegx.h | 1406 + 1 file changed, 1406 insertions(+) create mode 100644 target-tilegx/opcode_tilegx.

[Qemu-devel] [PATCH RFC 0/5] qapi: support anonymous inline base

2015-08-20 Thread Eric Blake
Existing flat unions have to specify a separate base class: { 'struct':'Base', 'data': { common... } } { 'union':'Flat', 'base': 'Base', 'discriminator':... } but we often don't care about reusing the base member by itself. Since we already support anonymous structs for commands, it is not that m

[Qemu-devel] [PATCH 03/16 v1] linux-user/syscall.c: conditionalize syscalls which are not defined in tilegx

2015-08-20 Thread Chen Gang
Some of architectures (e.g. tilegx), several syscall macros are not supported, so switch them. Signed-off-by: Chen Gang Reviewed-by: Peter Maydell --- linux-user/syscall.c | 50 +- 1 file changed, 49 insertions(+), 1 deletion(-) diff --git a/linu

Re: [Qemu-devel] [PATCH v5 4/4] sPAPR: Support RTAS call ibm, errinjct

2015-08-20 Thread Thomas Huth
On 18/08/15 17:26, Gavin Shan wrote: > On Tue, Aug 18, 2015 at 11:04:59AM -0700, Thomas Huth wrote: >> On 17/08/15 18:47, Gavin Shan wrote: >>> The patch supports RTAS call "ibm,errinjct" to allow injecting >>> EEH errors to VFIO PCI devices. The implementation is similiar >>> to EEH support for VF

[Qemu-devel] [PATCH 03/16] linux-user/syscall.c: conditionalize syscalls which are not defined in tilegx

2015-08-20 Thread gchen gchen
Some of architectures (e.g. tilegx), several syscall macros are not supported, so switch them. Signed-off-by: Chen Gang Reviewed-by: Peter Maydell --- linux-user/syscall.c | 50 +- 1 file changed, 49 insertions(+), 1 deletion(-) diff --git a/linux-

Re: [Qemu-devel] [PATCH COLO-Frame v8 24/34] COLO NIC: Implement colo nic device interface configure()

2015-08-20 Thread Dr. David Alan Gilbert
* Li Zhijian (lizhij...@cn.fujitsu.com) wrote: > On 08/05/2015 06:42 PM, Dr. David Alan Gilbert wrote: > >* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > >>Implement colo nic device interface configure() > >>add a script to configure nic devices: > >>${QEMU_SCRIPT_DIR}/colo-proxy-script.s

[Qemu-devel] [PATCH 05/16 v1] target-tilegx/opcode_tilegx.h: Modify it to fit QEMU usage

2015-08-20 Thread Chen Gang
Use 'inline' instead of '__inline', and also use 'uint64_t' instead of "unsigned long long" Signed-off-by: Chen Gang Reviewed-by: Peter Maydell --- target-tilegx/opcode_tilegx.h | 220 +- 1 file changed, 110 insertions(+), 110 deletions(-) diff --git a/t

Re: [Qemu-devel] [PATCH 01/12] hbitmap: serialization

2015-08-20 Thread Stefan Hajnoczi
On Fri, Aug 07, 2015 at 12:32:33PM +0300, Vladimir Sementsov-Ogievskiy wrote: > +/** > + * hbitmap_serialize_part > + * @hb: HBitmap to oprate on. s/oprate/operate/ > + * @buf: Buffer to store serialized bitmap. > + * @start: First bit to store. > + * @count: Number of bits to store. > + * > + *

[Qemu-devel] [PATCH 04/10] arm: Rename virt machine class to use MACHINE_TYPE_NAME

2015-08-20 Thread Eduardo Habkost
Machine class names should use the "-machine" suffix to allow class-name-based machine class lookup to work. Rename the arm virt machine class using the MACHINE_TYPE_NAME macro. Cc: Peter Maydell Signed-off-by: Eduardo Habkost --- hw/arm/virt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 dele

Re: [Qemu-devel] [PATCH v2] hmp: Allow for error message hints on HMP

2015-08-20 Thread Eric Blake
On 08/18/2015 02:48 PM, Eric Blake wrote: > Commits 7216ae3d and d2828429 disabled some error message hints, > all because a change to use modern error reporting meant that the > hint would be output prior to the actual error. Fix this by making > hints a first-class member of Error. > > For exam

Re: [Qemu-devel] [PATCH] Block: don't do copy-on-read in before_write_notifier

2015-08-20 Thread Wen Congyang
On 08/20/2015 01:02 AM, Jeff Cody wrote: > On Wed, Aug 19, 2015 at 01:43:41PM +0800, Wen Congyang wrote: >> On 08/19/2015 01:41 PM, Paolo Bonzini wrote: >>> On 18/08/2015 19:54, Wen Congyang wrote: We will copy data in before_write_notifier to do backup. It is a nested I/O request, so we

[Qemu-devel] [PATCH 0/2] ide/atapi: partially avoid deadlock if the storage backend is dead

2015-08-20 Thread Peter Lieven
the blk_drain_all() that is executed if the guest issues a DMA cancel leads to a stuck main loop if the storage backend (e.g. a NFS share) is unresponsive. This scenario is a common case for CDROM images mounted from an NFS share. In this case a broken NFS server can take down the whole VM even if

[Qemu-devel] [PATCH 2/2] ide/atapi: partially avoid deadlock if the storage backend is dead

2015-08-20 Thread Peter Lieven
the blk_drain_all() that is executed if the guest issues a DMA cancel leads to a stuck main loop if the storage backend (e.g. a NFS share) is unresponsive. This scenario is a common case for CDROM images mounted from an NFS share. In this case a broken NFS server can take down the whole VM even if

Re: [Qemu-devel] [PATCH] configure: Don't permit SDL or GTK on OSX

2015-08-20 Thread Peter Maydell
On 14 August 2015 at 16:10, Peter Maydell wrote: > The cocoa GUI frontend assumes it is the only GUI (it redefines > main() so it always gets control before the rest of QEMU), so > it does not play well with other UIs like SDL or GTK. (Mostly > people building QEMU on OSX don't have the necessary

Re: [Qemu-devel] [PATCH 6/9] target-arm/arm-semi.c: Support widening APIs to 64 bits

2015-08-20 Thread Christopher Covington
On Thu, Aug 13, 2015 at 9:35 AM, Peter Maydell wrote: > The 64-bit A64 semihosting API has some pervasive changes from > the 32-bit version: > * all parameter blocks are arrays of 64-bit values, not 32-bit > * the semihosting call number is passed in W0 > * the return value is a 64-bit value in

Re: [Qemu-devel] [PATCH 4/7] machine: DEFINE_MACHINE macro

2015-08-20 Thread Eduardo Habkost
On Tue, Aug 18, 2015 at 12:08:51PM -0700, Eduardo Habkost wrote: > The macro will allow easy registration of a TYPE_MACHINE subclass, using > only the machine name and a MachineClass initialization function as > parameter. > > Signed-off-by: Eduardo Habkost I will need to redo this patch after s

Re: [Qemu-devel] [PATCH 08/25] qapi: support nested structs in OptsVisitor

2015-08-20 Thread Marc-André Lureau
Hi On Thu, Aug 6, 2015 at 8:28 PM, Kővágó, Zoltán wrote: > The current OptsVisitor flattens the whole structure, if there are same > named fields under different paths (like `in' and `out' in `Audiodev'), > the current visitor can't cope with them (for example setting > `frequency=44100' will set

[Qemu-devel] [PATCH 1/2] block/io: allow AIOCB without callback

2015-08-20 Thread Peter Lieven
If the backend storage is unresponsive and we cancel a request due to a timeout we cannot immediately destroy the AIOCB because the storage might complete the original request laster if it is responsive again. For this purpose allow to set the callback to NULL and ignore it in this case. Signed-of

Re: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: drop _ADR entry from SPCR

2015-08-20 Thread Peter Maydell
On 6 August 2015 at 14:25, Andrew Jones wrote: > On Thu, Aug 06, 2015 at 01:55:14PM +0100, Leif Lindholm wrote: >> On Thu, Aug 06, 2015 at 02:28:03PM +0200, Andrew Jones wrote: >> > In the least I wouldn't want to get burned twice, so I'd prefer to >> > see the SPCR code actually get into Linux fi

Re: [Qemu-devel] [kvm-s390] qemu-system-s390x: cannot use stdio by multiple character devices

2015-08-20 Thread Alexander Graf
On 20.08.15 01:20, tu bo wrote: > Hi Alex: > > Ping you again just in case you did not get my mail :-) > > On 08/13/2015 03:52 PM, tu bo wrote: >> Hi Alex: >> >> I added one disk device for test case 068(qemu/tests/qemu-iotests/068, >> which is for for loading a saved VM state from a qcow2 ima

Re: [Qemu-devel] [PATCH 0/5] audio: multi channel audio support

2015-08-20 Thread Gerd Hoffmann
Hi, > Currently you have to specify the number of channels you want to use > when creating the usb-audio device, see the last commit for details. > To do this I currently dynamically allocate the whole USBDesc structure, > which looks ugly. If there's a better way, please let me know! You can

[Qemu-devel] [PATCH 08/16 v1] target-tilegx: Add several helpers for instructions translation

2015-08-20 Thread Chen Gang
The related instructions are exception, cntlz, cnttz, shufflebytes, and add_saturate. Signed-off-by: Chen Gang --- target-tilegx/helper.c | 83 ++ target-tilegx/helper.h | 5 +++ 2 files changed, 88 insertions(+) create mode 100644 target-tilegx/

Re: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: drop _ADR entry from SPCR

2015-08-20 Thread Andrew Jones
On Thu, Aug 20, 2015 at 12:21:31PM +0100, Leif Lindholm wrote: > On Thu, Aug 20, 2015 at 07:09:57PM +0800, Shannon Zhao wrote: > > >>>Could somebody who understands ACPI and the ramifications > > >>>here let me know if I should apply this patch, please? > > >>>(since we're now post-2.4) > > >> > >

Re: [Qemu-devel] [PATCH] target-s390x: Mask the SIGP order_code to 8bit.

2015-08-20 Thread Thomas Huth
On 18/08/15 04:50, Philipp Kern wrote: > According to "CPU Signaling and Response", "Signal-Processor Orders", > the order field is bit position 56-63. Without this, the Linux > guest kernel is sometimes unable to stop emulation and enters > an infinite loop of "XXX unknown sigp: 0x0005

Re: [Qemu-devel] [PATCH 13/25] audio: add audiodev properties to frontends

2015-08-20 Thread Marc-André Lureau
looks good, Reviewed-by: Marc-André Lureau On Thu, Aug 6, 2015 at 8:28 PM, Kővágó, Zoltán wrote: > Finally add audiodev= options to audio frontends so users can specify > which backend to use when multiple backends exist. Not specifying an > audiodev= option currently causes the first audiode

Re: [Qemu-devel] [PATCH v5 4/4] sPAPR: Support RTAS call ibm, errinjct

2015-08-20 Thread Gavin Shan
On Wed, Aug 19, 2015 at 08:48:20AM -0700, Thomas Huth wrote: >On 18/08/15 17:26, Gavin Shan wrote: >> On Tue, Aug 18, 2015 at 11:04:59AM -0700, Thomas Huth wrote: >>> On 17/08/15 18:47, Gavin Shan wrote: The patch supports RTAS call "ibm,errinjct" to allow injecting EEH errors to VFIO PCI

[Qemu-devel] [PATCH RFC 4/5] qapi: Simplify visits of optional fields

2015-08-20 Thread Eric Blake
None of the visitor callbacks would set an error when testing if an optional field was present; make this part of the interface contract by eliminating the errp argument. Then, for less code, reflect the determined boolean value back to the caller instead of making the caller read the boolean afte

[Qemu-devel] [PATCH 01/16 v1] linux-user: tilegx: Firstly add architecture related features

2015-08-20 Thread Chen Gang
They are based on Linux kernel tilegx architecture for 64 bit binary, and also based on tilegx ABI reference document, and also reference from other targets implementations. Signed-off-by: Chen Gang Reviewed-by: Peter Maydell --- linux-user/tilegx/syscall.h| 40 + linux-user/tilegx

Re: [Qemu-devel] [PATCH v2 0/3] SysFS driver for QEMU fw_cfg device

2015-08-20 Thread Gabriel L. Somlo
Hi Ard, On Wed, Aug 19, 2015 at 11:42:02AM +0200, Ard Biesheuvel wrote: > (missed some cc's) > > On 19 August 2015 at 11:38, Ard Biesheuvel wrote: > > From: "Gabriel L. Somlo" > >> Several different architectures supported by QEMU are set up with a > >> "firmware configuration" (fw_cfg) device,

[Qemu-devel] [PATCH 06/16 v1] target-tilegx: Add special register information from Tilera Corporation

2015-08-20 Thread Chen Gang
The related copy is from Linux kernel "arch/tile/include/uapi/arch/ spr_def_64.h". Signed-off-by: Chen Gang Reviewed-by: Peter Maydell --- target-tilegx/spr_def_64.h | 216 + 1 file changed, 216 insertions(+) create mode 100644 target-tilegx/spr_def_

Re: [Qemu-devel] [Bug 1329956] Re: multi-core FreeBSD guest hangs after warm reboot

2015-08-20 Thread John Nielsen
Yes it is. Not sure what version first fixed it but I know 4.1 works. > On Aug 20, 2015, at 2:30 AM, Venkateswara Rao Dokku > wrote: > > Can you please tell me whether the issue is fixed with the latest > kernel? If so, what version has the fix? > > -- > You received this bug notification bec

[Qemu-devel] [PATCH 00/16] tilegx: Firstly add tilegx target for linux-user

2015-08-20 Thread gchen gchen
Hello All: After the implementation, it can let normal tilegx program working (e.g. sh, vi, cp, mv ...). And the known left issues are: - At present, it can not pass gcc testsuite (it causes some programs pending). - The floating point implementation is not included, since at present, it is only

Re: [Qemu-devel] [PATCH 00/16] tilegx: Firstly add tilegx target for linux-user

2015-08-20 Thread gchen gchen
Oh, sorry, my hotmail seems has issues, I shall try to send all patches again after fix it tomorrow. On 8/21/15 01:04, gchen gchen wrote: > Hello All: > > After the implementation, it can let normal tilegx program working (e.g. > sh, vi, cp, mv ...). And the known left issues are: > > - At prese

[Qemu-devel] [PATCH RFC 2/5] qapi: Generate consistent variable names

2015-08-20 Thread Eric Blake
Code consolidation is easier if similar code uses the same variable naming conventions. Prefer 'err' over 'local_err' in the command and event marshallers, and prefer 'v' over 'm' as the name of the Visitor object in the visitor code. The resulting changes have no impact to compiled code behavior

Re: [Qemu-devel] [PATCH 14/25] audio: audiodev= parameters no longer optional when -audiodev present

2015-08-20 Thread Marc-André Lureau
Hi On Thu, Aug 6, 2015 at 8:28 PM, Kővágó, Zoltán wrote: > Signed-off-by: Kővágó, Zoltán > --- > audio/audio.c | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/audio/audio.c b/audio/audio.c > index 10b9871..7468b94 100644 > --- a/audio/audio.c > +++ b/audio

[Qemu-devel] [PATCH RFC 5/5] qapi: Allow anonymous base for flat union

2015-08-20 Thread Eric Blake
Rather than requiring all flat unions to explicitly create a separate base struct, we want to allow the qapi schema to specify the common fields via an inline dictionary. This is similar to how commands can specify inline types for the arguments. Now that the feature is legal, we can drop the form

Re: [Qemu-devel] [PATCH v6 02/10] init/cleanup of netfilter object

2015-08-20 Thread Yang Hongyang
On 08/10/2015 05:18 PM, Jason Wang wrote: On 08/07/2015 10:46 AM, Yang Hongyang wrote: QTAILQ_ENTRY global_list but used by filter layer, so that we can manage all filters together. QTAILQ_ENTRY next used by netdev, filter belongs to the specific netdev is in this queue. This is mostly the s

[Qemu-devel] [PATCH 02/16 v1] linux-user: Support tilegx architecture in linux-user

2015-08-20 Thread Chen Gang
Add main working flow feature, system call processing feature, and elf64 tilegx binary loading feature, based on Linux kernel tilegx 64-bit implementation. Signed-off-by: Chen Gang Reviewed-by: Peter Maydell --- include/elf.h | 2 + linux-user/elfload.c | 23 linux-user

[Qemu-devel] [PATCH 07/16 v1] target-tilegx: Add cpu basic features for linux-user

2015-08-20 Thread Chen Gang
It implements minimized cpu features for linux-user. Signed-off-by: Chen Gang Reviewed-by: Peter Maydell --- target-tilegx/cpu.c | 143 ++ target-tilegx/cpu.h | 175 2 files changed, 318 insertions(+)

Re: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: drop _ADR entry from SPCR

2015-08-20 Thread Leif Lindholm
On Thu, Aug 20, 2015 at 01:24:39AM +0100, Peter Maydell wrote: > On 6 August 2015 at 14:25, Andrew Jones wrote: > > On Thu, Aug 06, 2015 at 01:55:14PM +0100, Leif Lindholm wrote: > >> On Thu, Aug 06, 2015 at 02:28:03PM +0200, Andrew Jones wrote: > >> > In the least I wouldn't want to get burned tw

Re: [Qemu-devel] [PATCH v2 1/6] cputlb: Add functions for flushing TLB for a single MMU index

2015-08-20 Thread Edgar E. Iglesias
On Fri, Aug 14, 2015 at 11:41:14AM +0100, Peter Maydell wrote: > Guest CPU TLB maintenance operations may be sufficiently > specialized to only need to flush TLB entries corresponding > to a particular MMU index. Implement cputlb functions for > this, to avoid the inefficiency of flushing TLB entri

  1   2   >