Re: [Qemu-devel] [PATCH v2 6/7] error: Revamp interface documentation

2015-07-29 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> "Dr. David Alan Gilbert" writes: >> >> > * Markus Armbruster (arm...@redhat.com) wrote: >> >> Signed-off-by: Markus Armbruster >> >> Reviewed-by: Eric Blake >> >> --- >> >> include/qapi/error.h | 177 >> >>

Re: [Qemu-devel] [PATCH 09/12] netfilter: add a netbuffer filter

2015-07-29 Thread Yang Hongyang
On 07/30/2015 01:13 PM, Jason Wang wrote: [...] + +#include "net/filter.h" +#include "net/queue.h" +#include "filters.h" +#include "qemu-common.h" +#include "qemu/error-report.h" + +typedef struct FILTERBUFFERState { +NetFilterState nf; +NetClientState dummy; /* used to send buffered pack

Re: [Qemu-devel] [PATCH V3 1/2] tests: introduce basic pci test for virtio-net

2015-07-29 Thread Fam Zheng
On Fri, 07/17 15:25, Jason Wang wrote: > Signed-off-by: Jason Wang > --- > Changes from V2: > - Remove duplicated code of gtest_start() > Changes from V1: > - replace the magic value 12 with a macro Series: Reviewed-by: Fam Zheng

Re: [Qemu-devel] [PATCH V2 2/2] tests/vhost-user: check vhost-user feature negotiation

2015-07-29 Thread Michael S. Tsirkin
On Wed, Jul 29, 2015 at 11:06:49PM +0300, Marcel Apfelbaum wrote: > Check the backend receives all declared virtio features > that are also supported by QEMU virtio. > > Signed-off-by: Marcel Apfelbaum > --- > tests/vhost-user-test.c | 19 --- > 1 file changed, 16 insertions(+),

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: fix overlapping metadata update

2015-07-29 Thread Vasiliy Tolstov
2015-07-29 12:31 GMT+03:00 Liu Yuan : > Technically, it won't affect the performance because index updates are not > range > but concrete in terms of underlying 4M block size. Only 2 or 3 indexes in a > range will be updated and 90+% updates will be only 1. So if 2 updates stride > a > large rang

[Qemu-devel] [PATCH v4 14/14] tests: add BlockJobTxn unit test

2015-07-29 Thread Fam Zheng
From: Stefan Hajnoczi The BlockJobTxn unit test verifies that both single jobs and pairs of jobs behave as a transaction group. Either all jobs complete successfully or the group is cancelled. Signed-off-by: Stefan Hajnoczi Signed-off-by: Fam Zheng --- tests/Makefile| 3 + test

Re: [Qemu-devel] [PATCH V2 1/2] vhost-user: sync backend features

2015-07-29 Thread Michael S. Tsirkin
On Wed, Jul 29, 2015 at 11:06:48PM +0300, Marcel Apfelbaum wrote: > Complete vhost-user negotiation by syncing synching. > the features > supported by the backend. > > Signed-off-by: Marcel Apfelbaum > --- > hw/virtio/vhost-user.c | 17 + > 1 file changed, 17 insertions(+) > >

Re: [Qemu-devel] [PATCH RFC v2 26/47] qapi-types: Convert to QAPISchemaVisitor, fixing flat unions

2015-07-29 Thread Markus Armbruster
Eric Blake writes: > On 07/01/2015 02:22 PM, Markus Armbruster wrote: >> Fixes flat unions to get the base's base members. Test case is from >> commit 2fc0043, in qapi-schema-test.json: >> > >> -def generate_alternate_qtypes(expr): >> +def gen_alternate_qtypes_decl(name): >> +return mcgen('

[Qemu-devel] [PATCH v4 13/14] qmp-commands.hx: Update the supported 'transaction' operations

2015-07-29 Thread Fam Zheng
From: Kashyap Chamarthy Although the canonical source of reference for QMP commands is qapi-schema.json, for consistency's sake, update qmp-commands.hx to state the list of supported transactionable operations, namely: drive-backup blockdev-backup blockdev-snapshot-internal-sync

[Qemu-devel] [PATCH v4 11/14] block/backup: support block job transactions

2015-07-29 Thread Fam Zheng
From: Stefan Hajnoczi Join the transaction when the 'transactional-cancel' QMP argument is true. This ensures that the sync bitmap is not thrown away if another block job in the transaction is cancelled or fails. This is critical so incremental backup with multiple disks can be retried in case

[Qemu-devel] [PATCH v4 09/14] block: add block job transactions

2015-07-29 Thread Fam Zheng
Sometimes block jobs must execute as a transaction group. Finishing jobs wait until all other jobs are ready to complete successfully. Failure or cancellation of one job cancels the other jobs in the group. Signed-off-by: Stefan Hajnoczi [Rewrite the implementation which is now contained in bloc

[Qemu-devel] [PATCH v4 08/14] blockjob: Simplify block_job_finish_sync

2015-07-29 Thread Fam Zheng
With job->completed and job->ret to replace BlockFinishData. Signed-off-by: Fam Zheng --- blockjob.c | 27 ++- 1 file changed, 6 insertions(+), 21 deletions(-) diff --git a/blockjob.c b/blockjob.c index 293b62a..36c18e0 100644 --- a/blockjob.c +++ b/blockjob.c @@ -185,43

[Qemu-devel] [PATCH v4 06/14] blockjob: Add .commit and .abort block job actions

2015-07-29 Thread Fam Zheng
Signed-off-by: Fam Zheng --- include/block/blockjob.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/include/block/blockjob.h b/include/block/blockjob.h index 3e7ad21..a7b497c 100644 --- a/include/block/blockjob.h +++ b/include/block/blockjob.h @@ -50,6 +50,24 @@ typedef

[Qemu-devel] [PATCH v4 07/14] blockjob: Add "completed" and "ret" in BlockJob

2015-07-29 Thread Fam Zheng
They are set when block_job_completed is called. Signed-off-by: Fam Zheng Reviewed-by: John Snow --- blockjob.c | 3 +++ include/block/blockjob.h | 9 + 2 files changed, 12 insertions(+) diff --git a/blockjob.c b/blockjob.c index ec12887..293b62a 100644 --- a/blockjob.c +

[Qemu-devel] [PATCH v4 10/14] blockdev: make BlockJobTxn available to qmp 'transaction'

2015-07-29 Thread Fam Zheng
From: Stefan Hajnoczi Provide a BlockJobTxn to actions executed in a qmp 'transaction' command. This allows actions to make their block jobs either complete as a group or fail/cancel together. The next patch adds the first user. Signed-off-by: Stefan Hajnoczi Reviewed-by: Fam Zheng Reviewed-

[Qemu-devel] [PATCH v4 05/14] blockjob: Introduce reference count

2015-07-29 Thread Fam Zheng
So that block_job_complete_sync can be simplified. Signed-off-by: Fam Zheng --- block/mirror.c | 2 +- blockjob.c | 22 ++ include/block/blockjob.h | 18 +++--- 3 files changed, 30 insertions(+), 12 deletions(-) diff --git a/block/mirror.

[Qemu-devel] [PATCH v4 03/14] block: rename BlkTransactionState and BdrvActionOps

2015-07-29 Thread Fam Zheng
From: John Snow These structures are misnomers, somewhat. (1) BlockTransactionState is not state for a transaction, but is rather state for a single transaction action. Rename it "BlkActionState" to be more accurate. (2) The BdrvActionOps describes operations for the BlkActionState,

[Qemu-devel] [PATCH v4 01/14] qapi: Add transaction support to block-dirty-bitmap operations

2015-07-29 Thread Fam Zheng
From: John Snow This adds two qmp commands to transactions. block-dirty-bitmap-add allows you to create a bitmap simultaneously alongside a new full backup to accomplish a clean synchronization point. block-dirty-bitmap-clear allows you to reset a bitmap back to as-if it were new, which can als

[Qemu-devel] [PATCH v4 12/14] iotests: 124 - transactional failure test

2015-07-29 Thread Fam Zheng
From: John Snow Use a transaction to request an incremental backup across two drives. Coerce one of the jobs to fail, and then re-run the transaction. Verify that no bitmap data was lost due to the partial transaction failure. To support the 'transactional-cancel' QMP argument name it's necessa

[Qemu-devel] [PATCH v4 04/14] backup: Extract dirty bitmap handling as a separate function

2015-07-29 Thread Fam Zheng
This will be reused by the coming new transactional completion code. Signed-off-by: Fam Zheng Reviewed-by: John Snow --- block/backup.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/block/backup.c b/block/backup.c index 965654d..9776d9c 100644

[Qemu-devel] [PATCH v4 02/14] iotests: add transactional incremental backup test

2015-07-29 Thread Fam Zheng
From: John Snow Test simple usage cases for using transactions to create and synchronize incremental backups. Signed-off-by: John Snow Reviewed-by: Max Reitz Reviewed-by: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Reviewed-by: Fam Zheng Signed-off-by: Fam Zheng --- tests/qemu-iotests/

[Qemu-devel] [PATCH v4 00/14] block: incremental backup transactions using BlockJobTxn

2015-07-29 Thread Fam Zheng
v4: Address comments from John and Stefan, including: Rename function: backup_cleanup_sync_bitmap. Rename and add comments for .commit and .abort. Call .commit and .abort for both txn and non-txn. Drop patch 9 in v3. Improve the txn implementation. Acquire context locks as acces

Re: [Qemu-devel] [PATCH for-2.4 v2 0/2] vhost: check if vhost has capacity for hotplugged memory

2015-07-29 Thread Michael S. Tsirkin
On Thu, Jul 30, 2015 at 09:25:55AM +0300, Michael S. Tsirkin wrote: > On Thu, Jul 30, 2015 at 08:22:18AM +0200, Igor Mammedov wrote: > > On Wed, 29 Jul 2015 18:03:36 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Jul 29, 2015 at 01:49:47PM +0200, Igor Mammedov wrote: > > > > v1->v2: > >

Re: [Qemu-devel] [PATCH for-2.4 v2 0/2] vhost: check if vhost has capacity for hotplugged memory

2015-07-29 Thread Michael S. Tsirkin
On Thu, Jul 30, 2015 at 08:22:18AM +0200, Igor Mammedov wrote: > On Wed, 29 Jul 2015 18:03:36 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Jul 29, 2015 at 01:49:47PM +0200, Igor Mammedov wrote: > > > v1->v2: > > > * replace probbing with checking for > > > /sys/module/vhost/parameters/

Re: [Qemu-devel] [PATCH for-2.4 v2 0/2] vhost: check if vhost has capacity for hotplugged memory

2015-07-29 Thread Igor Mammedov
On Wed, 29 Jul 2015 18:03:36 +0300 "Michael S. Tsirkin" wrote: > On Wed, Jul 29, 2015 at 01:49:47PM +0200, Igor Mammedov wrote: > > v1->v2: > > * replace probbing with checking for > > /sys/module/vhost/parameters/max_mem_regions and > > if it's missing has non wrong value return > >

Re: [Qemu-devel] [PATCH for-2.4 v2 1/2] vhost: add vhost_has_free_slot() interface

2015-07-29 Thread Michael S. Tsirkin
On Thu, Jul 30, 2015 at 08:16:54AM +0200, Igor Mammedov wrote: > On Wed, 29 Jul 2015 18:11:14 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Jul 29, 2015 at 01:49:48PM +0200, Igor Mammedov wrote: > > > it will allow for other parts of QEMU check if it's safe > > > to map memory region during h

Re: [Qemu-devel] [PATCH for-2.4 v2 1/2] vhost: add vhost_has_free_slot() interface

2015-07-29 Thread Igor Mammedov
On Wed, 29 Jul 2015 18:11:14 +0300 "Michael S. Tsirkin" wrote: > On Wed, Jul 29, 2015 at 01:49:48PM +0200, Igor Mammedov wrote: > > it will allow for other parts of QEMU check if it's safe > > to map memory region during hotplug/runtime. > > That way hotplug path will have a chance to cancel > >

[Qemu-devel] [Bug 1479632] [NEW] dos crashing no sound

2015-07-29 Thread BJC2014
Public bug reported: I use this command when I use sound in a program there is no sound and sometimes the program crashes or hangs with no mouse working. I can though reset with the system with the control menu, but this is further hard to use, because there is no option to scroll through all

Re: [Qemu-devel] [PATCH 10/12] netbuffer: add a public api filter_buffer_release_all

2015-07-29 Thread Yang Hongyang
On 07/30/2015 01:25 PM, Jason Wang wrote: On 07/29/2015 06:51 PM, Yang Hongyang wrote: add a public api filter_buffer_release_all to release all buffered packets. also introduce qemu_find_netfilters_by_model to find all buffer filters. Signed-off-by: Yang Hongyang --- include/net/filter.h

[Qemu-devel] [PATCH for-2.4] Update language files for QEMU 2.4.0

2015-07-29 Thread Stefan Weil
Signed-off-by: Stefan Weil --- ui/gtk.c changed since the last update, and so the line numbers changed, too. There are also some new texts which up to now were only translated for de_DE, fr_FR and zh_CH. it.po is nearly complete. Regards Stefan po/de_DE.po| 36 ++---

Re: [Qemu-devel] [PATCH 11/12] filter/buffer: add an interval option to buffer filter

2015-07-29 Thread Yang Hongyang
Hi Jason, Thank you for review! On 07/30/2015 01:27 PM, Jason Wang wrote: On 07/29/2015 06:51 PM, Yang Hongyang wrote: the buffer filter will release packets by interval. Signed-off-by: Yang Hongyang Looks liked it's better to squash this patch into the buffer? I don't know if it's b

Re: [Qemu-devel] [PATCH v2] gdbstub: Implement Xfer:auxv:read

2015-07-29 Thread Bhushan Attarde
Hi Peter, Thanks for the review. >> if ((ptr != NULL && addr > len) > ||(ptr == NULL && addr > total_len)) { >> This if is rather confusing. Why should ptr == or != NULL make a difference? >> What is ptr == NULL actually encoding? I think it is enough just to check if (addr > total_len) w

Re: [Qemu-devel] [PATCH 11/12] filter/buffer: add an interval option to buffer filter

2015-07-29 Thread Jason Wang
On 07/29/2015 06:51 PM, Yang Hongyang wrote: > the buffer filter will release packets by interval. > > Signed-off-by: Yang Hongyang Looks liked it's better to squash this patch into the buffer? And should we stop the timer during vm stop? > --- > net/filter-buffer.c | 24 +

Re: [Qemu-devel] [PATCH 10/12] netbuffer: add a public api filter_buffer_release_all

2015-07-29 Thread Jason Wang
On 07/29/2015 06:51 PM, Yang Hongyang wrote: > add a public api filter_buffer_release_all to release all > buffered packets. > also introduce qemu_find_netfilters_by_model to find all buffer > filters. > > Signed-off-by: Yang Hongyang > --- > include/net/filter.h | 5 + > net/filter-buffer

Re: [Qemu-devel] [PATCH 09/12] netfilter: add a netbuffer filter

2015-07-29 Thread Jason Wang
On 07/29/2015 06:51 PM, Yang Hongyang wrote: > This filter is to buffer/release packets, this feature can be used > when using macrocheckpoing, or other Remus like VM FT solutions, you > can also use it to simulate the network delay. > It has an interval option, if supplied, this filter will rele

Re: [Qemu-devel] [PATCH 05/12] netfilter: hook packets before receive

2015-07-29 Thread Jason Wang
On 07/29/2015 06:51 PM, Yang Hongyang wrote: > Capture packets that will be sent. > > Signed-off-by: Yang Hongyang > --- > include/net/filter.h | 16 + > net/net.c| 65 > +++- > 2 files changed, 80 insertions(+), 1 deletio

Re: [Qemu-devel] [POC] colo-proxy in qemu

2015-07-29 Thread Jason Wang
On 07/20/2015 02:42 PM, Li Zhijian wrote: > Hi, all > > We are planning to implement colo-proxy in qemu to cache and compare > packets. > This module is one of the important component of COLO project and now > it is > still in early stage, so any comments and feedback are warmly welcomed, > thank

Re: [Qemu-devel] [PATCH COLO-Frame v8 23/34] tap: Make launch_script() public

2015-07-29 Thread zhanghailiang
On 2015/7/30 11:32, Jason Wang wrote: On 07/29/2015 05:43 PM, zhanghailiang wrote: On 2015/7/29 17:24, Jason Wang wrote: On 07/29/2015 05:17 PM, zhanghailiang wrote: On 2015/7/29 16:57, Jason Wang wrote: On 07/29/2015 04:45 PM, zhanghailiang wrote: We also change the parameters of laun

Re: [Qemu-devel] Debian 7.8.0 SPARC64 on qemu - anything i can do to speedup the emulation?

2015-07-29 Thread Dennis Luehring
Am 29.07.2015 um 17:01 schrieb Aurelien Jarno: The point is that emulation has a cost, and it's quite difficult to to lower it and thus improve the emulation speed. so its just not strange for you to see an 1/100...200 of the native x64 speed under qemu/SPARC64 i hoped that someone will jump u

Re: [Qemu-devel] Debian 7.8.0 SPARC64 on qemu - anything i can do to speedup the emulation?

2015-07-29 Thread Dennis Luehring
so your aarch64 is just less todo for qemu - not EVERY >= 16bit memory access needs swapping or needs check for unaligned access to emulate bus-erros Am 29.07.2015 um 16:41 schrieb Karel Gardas: ubuntu@ubuntu:~$ ./a.out endianess: little try to access unaligned word equal to 0x1234: YES

Re: [Qemu-devel] [PATCH COLO-Frame v8 23/34] tap: Make launch_script() public

2015-07-29 Thread Jason Wang
On 07/29/2015 05:43 PM, zhanghailiang wrote: > On 2015/7/29 17:24, Jason Wang wrote: >> >> >> On 07/29/2015 05:17 PM, zhanghailiang wrote: >>> On 2015/7/29 16:57, Jason Wang wrote: On 07/29/2015 04:45 PM, zhanghailiang wrote: > We also change the parameters of launch_script().

[Qemu-devel] [ANNOUNCE] QEMU 2.4.0-rc3 is now available

2015-07-29 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the fourth release candidate for the QEMU 2.4 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-2.4.0-rc3.tar.bz2 You can help imp

Re: [Qemu-devel] [PATCH 09/12] netfilter: add a netbuffer filter

2015-07-29 Thread Yang Hongyang
On 07/30/2015 09:45 AM, Li Zhijian wrote: On 07/29/2015 06:51 PM, Yang Hongyang wrote: This filter is to buffer/release packets, this feature can be used when using macrocheckpoing, or other Remus like VM FT solutions, you s/macrocheckpoing/MicroCheckpointing/ the cover letter have the same

Re: [Qemu-devel] [PATCH 09/12] netfilter: add a netbuffer filter

2015-07-29 Thread Li Zhijian
On 07/29/2015 06:51 PM, Yang Hongyang wrote: This filter is to buffer/release packets, this feature can be used when using macrocheckpoing, or other Remus like VM FT solutions, you s/macrocheckpoing/MicroCheckpointing/ the cover letter have the same typo -- Best regards. Li Zhijian

Re: [Qemu-devel] [PATCH v2 11/11] block: Only poll block layer fds in bdrv_aio_poll

2015-07-29 Thread Fam Zheng
On Wed, 07/29 14:03, Paolo Bonzini wrote: > > > On 29/07/2015 13:53, Fam Zheng wrote: > >> > Yes, though I think you'd end up reverting patches 10 and 11 in the end. > > We will add outer disable/enable pairs to prevent another threads's aio_poll > > from sneaking in between bdrv_aio_poll calls,

Re: [Qemu-devel] [PATCH v2] arm: change vendor ID for virtio-mmio

2015-07-29 Thread Shannon Zhao
On 2015/7/30 3:16, Michael S. Tsirkin wrote: > ACPI spec 5.0 allows the use of PCI vendor IDs. > But virtio-mmio is not a PCI device, it's a platform device. Why do we drop the previous way using "QEMU"? Something I missed? > Since we have one for virtio, it seems neater to use that > rathe

Re: [Qemu-devel] [PATCH v1 1/3] ahci: Separate the AHCI state structure into the header

2015-07-29 Thread Alistair Francis
On Wed, Jul 29, 2015 at 3:21 PM, John Snow wrote: > > > On 07/27/2015 02:37 PM, Alistair Francis wrote: >> Pull the AHCI state structure out into the header. This allows >> other containers to access the struct. This is required to add >> the device to modern SoC containers. >> > > Is there a reas

Re: [Qemu-devel] [PATCH RFC v2 26/47] qapi-types: Convert to QAPISchemaVisitor, fixing flat unions

2015-07-29 Thread Eric Blake
On 07/01/2015 02:22 PM, Markus Armbruster wrote: > Fixes flat unions to get the base's base members. Test case is from > commit 2fc0043, in qapi-schema-test.json: > > -def generate_alternate_qtypes(expr): > +def gen_alternate_qtypes_decl(name): > +return mcgen(''' > > -name = expr['alt

Re: [Qemu-devel] [PATCH v1 1/3] ahci: Separate the AHCI state structure into the header

2015-07-29 Thread John Snow
On 07/27/2015 02:37 PM, Alistair Francis wrote: > Pull the AHCI state structure out into the header. This allows > other containers to access the struct. This is required to add > the device to modern SoC containers. > Is there a reason this structure needs to be directly inlined into XlnxZynqM

Re: [Qemu-devel] [PATCH] target-arm: Fix arm_el_is_aa64() function to support EL2 and EL3

2015-07-29 Thread Sergey Sorokin
17.07.2015, 19:28, "Peter Maydell" : >On 17 July 2015 at 17:01, Sergey Sorokin wrote: >> Function arm_el_is_aa64() was fixed to support EL2 and EL3. >> It is needed for a future support of EL2 and/or EL3, >> and 32 bit EL1 support for ARMv8 cpu. >> ARM_FEATURE_AARCH64 flag means that the highest

Re: [Qemu-devel] [PATCH] bsd-user: Fix operand to cpu_x86_exec

2015-07-29 Thread Peter Maydell
On 29 July 2015 at 19:40, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > This buglet, from whenever we re-orged the parameters, means > that all x86-bsd-user invocations die instantly. > > > r~ > --- > bsd-user/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [Qemu-devel] [PATCH for-2.5 04/10] tcg/optimize: allow constant to have copies

2015-07-29 Thread Alex Bennée
Aurelien Jarno writes: > On 2015-07-29 17:12, Alex Bennée wrote: >> >> Aurelien Jarno writes: >> >> > Now that copies and constants are tracked separately, we can allow >> > constant to have copies, deferring the choice to use a register or a >> > constant to the register allocation pass. Thi

[Qemu-devel] [PATCH v1 12/15] irq: Add opaque setter routine

2015-07-29 Thread Alistair Francis
From: Peter Crosthwaite Add a routine to set or override the opaque data of an IRQ. Qdev currently always initialises IRQ opaque as the device itself. This allows you to override to a custom opaque in the case where there is extra or different data needed. Signed-off-by: Peter Crosthwaite ---

[Qemu-devel] [PATCH v1 10/15] qdev: Define qdev_get_gpio_out

2015-07-29 Thread Alistair Francis
From: Peter Crosthwaite An API similar to the existing qdev_get_gpio_in() except gets outputs. Useful for: 1: Implementing lightweight devices that don't want to keep pointers to their own GPIOs. They can get their GPIO pointers at runtime from QOM using this API. 2: testing or debugging code w

[Qemu-devel] [PATCH v1 08/15] dma: Add Xilinx Zynq devcfg device model

2015-07-29 Thread Alistair Francis
From: Peter Crosthwaite Minimal device model for devcfg module of Zynq. DMA capabilities and interrupt generation supported. Signed-off-by: Peter Crosthwaite --- Changed since v4: Create device state header. Use REG/FIELD/EX macros Use register init_block32 Remove un-needed timer code Changed s

[Qemu-devel] [PATCH v1 06/15] register: Add block initialise helper

2015-07-29 Thread Alistair Francis
From: Peter Crosthwaite Add a helper that will scan a static RegisterAccessInfo Array and populate a container MemoryRegion with registers as defined. Signed-off-by: Peter Crosthwaite --- hw/core/register.c| 28 include/hw/register.h | 21 +

[Qemu-devel] [PATCH v1 09/15] xilinx_zynq: add devcfg to machine model

2015-07-29 Thread Alistair Francis
From: Peter Crosthwaite Signed-off-by: Peter Crosthwaite --- Changed since v3: Author reset. Changed since v1: Added manual parenting of devcfg node (evil but needed for early access to canonical path by devcfgs realize fn). hw/arm/xilinx_zynq.c |8 1 files changed, 8 insertions(+

[Qemu-devel] [PATCH v1 15/15] xlnx-zynqmp: Connect the ZynqMP IOU SLCR

2015-07-29 Thread Alistair Francis
Connect the I/O Unit System Level Control Registers device to the ZynqMP model. Unfortunately the GPIO links can not be connected yet as the SD device is not yet attached to the ZynqMP machine. Signed-off-by: Alistair Francis --- hw/arm/xlnx-zynqmp.c | 15 +++ include/hw/a

[Qemu-devel] [PATCH v1 04/15] register: Define REG and FIELD macros

2015-07-29 Thread Alistair Francis
From: Peter Crosthwaite Define some macros that can be used for defining registers and fields. The REG32 macro will define A_FOO, for the byte address of a register as well as R_FOO for the uint32_t[] register number (A_FOO / 4). The FIELD macro will define FOO_BAR_MASK, FOO_BAR_SHIFT and FOO_B

[Qemu-devel] [PATCH v1 07/15] bitops: Add ONES macro

2015-07-29 Thread Alistair Francis
From: Peter Crosthwaite Little macro that just gives you N ones (justified to LSB). Signed-off-by: Peter Crosthwaite --- include/qemu/bitops.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/qemu/bitops.h b/include/qemu/bitops.h index 8164225..27bf98d 100644

[Qemu-devel] [PATCH v1 13/15] register: Add GPIO API

2015-07-29 Thread Alistair Francis
From: Peter Crosthwaite Add GPIO functionality to the register API. This allows association and automatic connection of GPIOs to bits in registers. GPIO inputs will attach to handlers that automatically set read-only bits in registers. GPIO outputs will be updated to reflect their field value whe

[Qemu-devel] [PATCH v1 14/15] misc: Introduce ZynqMP IOU SLCR

2015-07-29 Thread Alistair Francis
From: Peter Crosthwaite IOU = I/O Unit SLCR = System Level Control Registers This IP is a misc collections of control registers that switch various properties of system IPs. Currently the only thing implemented is the SD_SLOTTYPE control (implemented as a GPIO output). Signed-off-by: Peter Cros

[Qemu-devel] [PATCH v1 05/15] register: QOMify

2015-07-29 Thread Alistair Francis
From: Peter Crosthwaite QOMify registers as a child of TYPE_DEVICE. This allows registers to define GPIOs. Define an init helper that will do QOM initialisation as well as setup the r/w fast paths. Signed-off-by: Peter Crosthwaite --- hw/core/register.c| 34

[Qemu-devel] [PATCH v1 00/15] data-driven device registers

2015-07-29 Thread Alistair Francis
>From Peter: Hi All. This is a new scheme I've come up with handling device registers in a data driven way. My motivation for this is to factor out a lot of the access checking that seems to be replicated in every device. See P1 commit message for further discussion. P1 is the main patch, adds the

[Qemu-devel] [PATCH v1 01/15] register: Add Register API

2015-07-29 Thread Alistair Francis
From: Peter Crosthwaite This API provides some encapsulation of registers and factors our some common functionality to common code. Bits of device state (usually MMIO registers), often have all sorts of access restrictions and semantics associated with them. This API allow you to define what thos

[Qemu-devel] [PATCH v1 11/15] qdev: Add qdev_pass_all_gpios API

2015-07-29 Thread Alistair Francis
From: Peter Crosthwaite For passing all GPIOs of all names from a contained device to a container. Signed-off-by: Peter Crosthwaite --- hw/core/qdev.c |9 + include/hw/qdev-core.h |1 + 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/hw/core/qdev.c b/hw

[Qemu-devel] [PATCH v1 02/15] register: Add Memory API glue

2015-07-29 Thread Alistair Francis
From: Peter Crosthwaite Add memory io handlers that glue the register API to the memory API. Just translation functions at this stage. Although it does allow for devices to be created without all-in-one mmio r/w handlers. Signed-off-by: Peter Crosthwaite --- changed from v2: Added fast path to

[Qemu-devel] [PATCH v1 03/15] register: Add support for decoding information

2015-07-29 Thread Alistair Francis
From: Peter Crosthwaite Allow defining of optional address decoding information in register definitions. This is useful for clients that want to associate registers with specific addresses. Signed-off-by: Peter Crosthwaite --- changed since v4: Remove extraneous unused defintions. include/hw/

Re: [Qemu-devel] [PATCH RFC v2 07/47] qapi: Generate a nicer struct for flat unions

2015-07-29 Thread Eric Blake
On 07/29/2015 01:33 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 07/01/2015 02:21 PM, Markus Armbruster wrote: >>> The struct generated for a flat union is weird: the members of its >>> base are at the end, except for the union tag, which is renamed to >>> 'kind' and put at the begin

[Qemu-devel] [PATCH V2 0/2] vhost-user: sync backend

2015-07-29 Thread Marcel Apfelbaum
To be used on top of: [PATCH 0/4] vhost-user: protocol updates https://lists.gnu.org/archive/html/qemu-devel/2015-07/msg03842.html v1 -> v2: - Addressed Michael S. Tsirkin's comments: - Prefer a white-list of supported features - Add a unit-test to show the problem we are trying to sol

[Qemu-devel] [PATCH V2 1/2] vhost-user: sync backend features

2015-07-29 Thread Marcel Apfelbaum
Complete vhost-user negotiation by syncing the features supported by the backend. Signed-off-by: Marcel Apfelbaum --- hw/virtio/vhost-user.c | 17 + 1 file changed, 17 insertions(+) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index c4428a1..b522437 100644 --- a/

[Qemu-devel] [PATCH V2 2/2] tests/vhost-user: check vhost-user feature negotiation

2015-07-29 Thread Marcel Apfelbaum
Check the backend receives all declared virtio features that are also supported by QEMU virtio. Signed-off-by: Marcel Apfelbaum --- tests/vhost-user-test.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c i

[Qemu-devel] [PATCH] qcow2: Speed up no-op copy_sectors()

2015-07-29 Thread Max Reitz
For qcow2 files without backing files, copy_sectors() often does not really do anything: It reads zeros from the qcow2 file and then writes them back to the protocol layer. If the protocol layer has zero initialization, this is probably completely unnecessary. So this patch introduces a way for co

[Qemu-devel] [PATCH 1/1] qemu-ga: Prevent QEMU-GA VSS provider from being unregistered on reinstall

2015-07-29 Thread Leonid Bloch
Previously, running the .msi would unregister the QEMU GA VSS service if QEMU GA was already installed on the machine, and then register it only if QEMU GA was NOT previously installed. This behavior caused the service to be registered only after the INITIAL installation, and any subsequent run

Re: [Qemu-devel] [PATCH] No change in userland tools after resizing qcow2 image

2015-07-29 Thread John Snow
On 07/20/2015 09:56 PM, 김태하 wrote: >> On 07/19/2015 05:24 AM, Taeha Kim wrote: >>> Hello, >>> >>> >>> There is no change in userland tools after resizing qcow2 image except >>> file utility. >>> >>> For example when resize qcow2 image, the "file" utility is detectable >>> increased size. >>> Howe

[Qemu-devel] [PATCH for-2.4] macio: re-add TRIM support

2015-07-29 Thread Aurelien Jarno
Commit bd4214fc dropped TRIM support by mistake. Given it is still advertised to the host when using a drive with discard=on, this cause the IDE bus to hang when the host issues a TRIM command. This patch fixes that by re-adding the TRIM code, ported to the new new DMA implementation. Cc: Mark Ca

[Qemu-devel] [PATCH v2] arm: change vendor ID for virtio-mmio

2015-07-29 Thread Michael S. Tsirkin
ACPI spec 5.0 allows the use of PCI vendor IDs. Since we have one for virtio, it seems neater to use that rather than LNRO. For the device ID, use 103F which is a legacy ID that isn't used in virtio PCI spec - seems to make sense since virtio-mmio is a legacy device but we don't know the correct d

Re: [Qemu-devel] [PATCH v2 06/45] ivshmem: remove unnecessary dup()

2015-07-29 Thread Eric Blake
On 07/27/2015 06:32 PM, Marc-André Lureau wrote: > From: Marc-André Lureau > > qemu_chr_fe_get_msgfd() transfer ownership, there is no need to dup the fd. s/transfer/transfers/ > > Signed-off-by: Marc-André Lureau Interesting difference in From: vs. S-o-b:; you may want to check your configu

Re: [Qemu-devel] [PATCH v3 0/5] cutils: Add qemu_strto*l() wrappers

2015-07-29 Thread Eric Blake
On 07/19/2015 05:02 PM, Carlos L. Torres wrote: > From: "Carlos L. Torres" > > Introduce qemu_ wrappers for strtol/strtoul/strtoll/strtoull > C functions, ensure that errno is checked, and if NULL is > passed as the endptr argument, then whole string has to be > a valid number on the given base,

[Qemu-devel] [PATCH] bsd-user: Fix operand to cpu_x86_exec

2015-07-29 Thread Richard Henderson
Signed-off-by: Richard Henderson --- This buglet, from whenever we re-orged the parameters, means that all x86-bsd-user invocations die instantly. r~ --- bsd-user/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bsd-user/main.c b/bsd-user/main.c index f46728b..ee68daa

Re: [Qemu-devel] [PATCH v2 6/7] error: Revamp interface documentation

2015-07-29 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> Signed-off-by: Markus Armbruster > >> Reviewed-by: Eric Blake > >> --- > >> include/qapi/error.h | 177 > >> -

Re: [Qemu-devel] [PATCH] vhost-user: sync backend features

2015-07-29 Thread Marcel Apfelbaum
On 07/29/2015 09:15 PM, Michael S. Tsirkin wrote: On Wed, Jul 29, 2015 at 09:11:18PM +0300, Marcel Apfelbaum wrote: On 07/29/2015 09:05 PM, Michael S. Tsirkin wrote: On Wed, Jul 29, 2015 at 08:43:47PM +0300, Marcel Apfelbaum wrote: On 07/29/2015 08:20 PM, Michael S. Tsirkin wrote: On Wed, Jul

Re: [Qemu-devel] [PATCH] vhost-user: sync backend features

2015-07-29 Thread Michael S. Tsirkin
On Wed, Jul 29, 2015 at 09:11:18PM +0300, Marcel Apfelbaum wrote: > On 07/29/2015 09:05 PM, Michael S. Tsirkin wrote: > >On Wed, Jul 29, 2015 at 08:43:47PM +0300, Marcel Apfelbaum wrote: > >>On 07/29/2015 08:20 PM, Michael S. Tsirkin wrote: > >>>On Wed, Jul 29, 2015 at 08:11:58PM +0300, Marcel Apfe

Re: [Qemu-devel] [PATCH] vhost-user: sync backend features

2015-07-29 Thread Marcel Apfelbaum
On 07/29/2015 09:05 PM, Michael S. Tsirkin wrote: On Wed, Jul 29, 2015 at 08:43:47PM +0300, Marcel Apfelbaum wrote: On 07/29/2015 08:20 PM, Michael S. Tsirkin wrote: On Wed, Jul 29, 2015 at 08:11:58PM +0300, Marcel Apfelbaum wrote: Complete vhost-user negotiation by syncing the features suppor

Re: [Qemu-devel] [PATCH] vhost-user: sync backend features

2015-07-29 Thread Michael S. Tsirkin
On Wed, Jul 29, 2015 at 08:43:47PM +0300, Marcel Apfelbaum wrote: > On 07/29/2015 08:20 PM, Michael S. Tsirkin wrote: > >On Wed, Jul 29, 2015 at 08:11:58PM +0300, Marcel Apfelbaum wrote: > >>Complete vhost-user negotiation by syncing the features > >>supported by the backend. > >> > >>Signed-off-by

Re: [Qemu-devel] [PATCH for-2.4 0/3] Migration regressions with Xen.

2015-07-29 Thread Anthony PERARD
This is a critical issue for Xen as migration either with the same version of QEMU, or from a previous version of QEMU is broken. Any suggestion on how to move forward? On Tue, Jul 28, 2015 at 04:54:42PM +0100, Anthony PERARD wrote: > Hi, > > We've spotted several regression which prevent migrat

Re: [Qemu-devel] [PULL for-2.4 0/3] Block patches

2015-07-29 Thread Peter Maydell
On 29 July 2015 at 14:50, Stefan Hajnoczi wrote: > The following changes since commit b83d017d88b2c4710c7a4614ecf9f845e4db80ba: > > Merge remote-tracking branch 'remotes/stefanha/tags/net-pull-request' into > staging (2015-07-28 19:02:04 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] Using the one disk image file on 2 virtual machines at the same time

2015-07-29 Thread John Snow
On 07/29/2015 01:29 PM, Manjong Han wrote: > Thanks, Stefan. > > 2015-07-29 17:46 GMT+09:00 Stefan Hajnoczi : >> >> You should probably use qcow2 backing files instead: >> >> 10G.qcow2 <-- vm001.qcow2 >> ^-- vm002.qcow2 >> >> The command to create these files is: >> >> qemu-img c

Re: [Qemu-devel] [PATCH] vhost-user: sync backend features

2015-07-29 Thread Marcel Apfelbaum
On 07/29/2015 08:20 PM, Michael S. Tsirkin wrote: On Wed, Jul 29, 2015 at 08:11:58PM +0300, Marcel Apfelbaum wrote: Complete vhost-user negotiation by syncing the features supported by the backend. Signed-off-by: Marcel Apfelbaum --- To be used on top of: [PATCH 0/4] vhost-user: protocol u

Re: [Qemu-devel] Using the one disk image file on 2 virtual machines at the same time

2015-07-29 Thread Manjong Han
Thanks, Stefan. 2015-07-29 17:46 GMT+09:00 Stefan Hajnoczi : > > You should probably use qcow2 backing files instead: > > 10G.qcow2 <-- vm001.qcow2 > ^-- vm002.qcow2 > > The command to create these files is: > > qemu-img create -f qcow2 -o backing_file=10G.qcow2 vm001.qcow2. > > Bo

Re: [Qemu-devel] [PATCH RFC v2 45/47] qapi: New QMP command query-schema for QMP schema introspection

2015-07-29 Thread Markus Armbruster
Eric Blake writes: > On 07/29/2015 03:19 AM, Markus Armbruster wrote: Longest line is a bit over 4KiB for me. >>> >>> If we break up string literals, at least use some indentation to make it >>> obvious that multiple lines merge to a single array entry. For example >>> (after patch 47):

Re: [Qemu-devel] [PATCH v2 4/9] vhost: alloc shareable log

2015-07-29 Thread Michael S. Tsirkin
On Wed, Jul 29, 2015 at 01:04:51PM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > * Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > > > If the backend is of type VHOST_BACKEND_TYPE_USER, allocate > > > shareable memory. > > > > > > Note: vhost_log_get() can use

Re: [Qemu-devel] [PATCH RFC v2 29/47] qapi: Replace dirty is_c_ptr() by method c_null()

2015-07-29 Thread Markus Armbruster
Eric Blake writes: > On 07/29/2015 02:32 AM, Markus Armbruster wrote: > 2. We can leak retval only when qmp_FOO() returns non-null and local_err is non-null. This must not happen, because: a. local_err must be null before the call, and b. the call must not

Re: [Qemu-devel] [PATCH] vhost-user: sync backend features

2015-07-29 Thread Michael S. Tsirkin
On Wed, Jul 29, 2015 at 08:11:58PM +0300, Marcel Apfelbaum wrote: > Complete vhost-user negotiation by syncing the features > supported by the backend. > > Signed-off-by: Marcel Apfelbaum > --- > To be used on top of: > [PATCH 0/4] vhost-user: protocol updates > https://lists.gnu.org/archive/h

[Qemu-devel] [PATCH] vhost-user: sync backend features

2015-07-29 Thread Marcel Apfelbaum
Complete vhost-user negotiation by syncing the features supported by the backend. Signed-off-by: Marcel Apfelbaum --- To be used on top of: [PATCH 0/4] vhost-user: protocol updates https://lists.gnu.org/archive/html/qemu-devel/2015-07/msg03842.html Currently the vhost-user supported feature

Re: [Qemu-devel] [PATCH v2 4/9] vhost: alloc shareable log

2015-07-29 Thread Dr. David Alan Gilbert
* Marc-André Lureau (mlur...@redhat.com) wrote: > Hi > > - Original Message - > > * Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > > > If the backend is of type VHOST_BACKEND_TYPE_USER, allocate > > > shareable memory. > > > > > > Note: vhost_log_get() can use a global "vhost_lo

Re: [Qemu-devel] [PATCH v2 4/9] vhost: alloc shareable log

2015-07-29 Thread Marc-André Lureau
Hi - Original Message - > * Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > > If the backend is of type VHOST_BACKEND_TYPE_USER, allocate > > shareable memory. > > > > Note: vhost_log_get() can use a global "vhost_log" that can be shared by > > several vhost devices. We may want

Re: [Qemu-devel] [PATCH RFC v2 27/47] qapi-visit: Convert to QAPISchemaVisitor, fixing bugs

2015-07-29 Thread Eric Blake
On 07/29/2015 02:00 AM, Markus Armbruster wrote: We don't have any code that demonstrates this, but probably should. I ran into it while working up my POC of what it would take to unbox inherited structs (http://thread.gmane.org/gmane.comp.emulators.qemu/353204) >>> >>> Is thi

[Qemu-devel] [Bug 1478360] Re: Cant compile on ubuntu 14.04 x64

2015-07-29 Thread Vido
Tnx for noticing about fix great news -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1478360 Title: Cant compile on ubuntu 14.04 x64 Status in QEMU: Fix Committed Bug description: ./configure

[Qemu-devel] [Bug 1478360] Re: Cant compile on ubuntu 14.04 x64

2015-07-29 Thread Vido
chroot . ./qemu-mips-static ./cspd qemu: uncaught target signal 11 (Segmentation fault) - core dumped and I come across solution that disabling threading will solve this issue -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://b

  1   2   3   4   >