Re: [Qemu-devel] [PATCH qemu 1/5] vfio: Switch from TARGET_PAGE_MASK to qemu_real_host_page_mask

2015-07-12 Thread David Gibson
On Fri, Jul 10, 2015 at 08:43:44PM +1000, Alexey Kardashevskiy wrote: > These started switching from TARGET_PAGE_MASK (hardcoded as 4K) to > a real host page size: > 4e51361d7 "cpu-all: complete "real" host page size API" and > f7ceed190 "vfio: cpu: Use "real" page size API" > > This finished the

Re: [Qemu-devel] [PATCH v4 4/7] pc: fix QEMU crashing when more than ~50 memory hotplugged

2015-07-12 Thread Michael S. Tsirkin
On Fri, Jul 10, 2015 at 12:12:36PM +0200, Igor Mammedov wrote: > On Thu, 9 Jul 2015 16:46:43 +0300 > "Michael S. Tsirkin" wrote: > > > On Thu, Jul 09, 2015 at 03:43:01PM +0200, Paolo Bonzini wrote: > > > > > > > > > On 09/07/2015 15:06, Michael S. Tsirkin wrote: > > > > > QEMU asserts in vhost

Re: [Qemu-devel] [PATCH] virtio-rng: Bump up quota value only when guest requests entropy

2015-07-12 Thread Pankaj Gupta
Hi Amit, Thanks for the review. > > On (Fri) 10 Jul 2015 [15:04:00], Pankaj Gupta wrote: > >    Timer was added in virtio-rng to rate limit the > > entropy. It used to trigger at regular intervals to > > bump up the quota value. The value of quota and timer > > slice is decided based on entropy

Re: [Qemu-devel] [PATCH 5/5] virtio-net: unbreak any layout

2015-07-12 Thread Paolo Bonzini
On 13/07/2015 07:46, Jason Wang wrote: > -if (out_sg[0].iov_len < n->guest_hdr_len) { > +s = iov_to_buf(out_sg, out_num, 0, &hdr, sizeof(hdr)); > +if (s != sizeof(hdr)) { > error_report("virtio-net header incorrect"); > exit(1)

Re: [Qemu-devel] [PULL 12/62] framebuffer: check memory_region_is_logging

2015-07-12 Thread Paolo Bonzini
On 13/07/2015 00:02, Peter Maydell wrote: > (I'm wondering if we somehow manage to spend all our time > trying to service the GUI and no time making forward > progress in the guest, though I don't have a clear idea > in mind of why this would be so Perhaps because Xlib calls (and hence GTK+ call

Re: [Qemu-devel] [PATCH v3 3/5] Introduce irqchip type specification for KVM

2015-07-12 Thread Pavel Fedin
Hello! > Besides we discussed this together before and you know I think we can > manage without this patch file by using kvm_create_device in trial mode > for v2 and v3 - but we did not agree on this -. Because we don't want "some GIC". We want particular GIC version, and this seems to be logi

Re: [Qemu-devel] [PATCH 4/5] Revert "virtio-net: enable virtio 1.0"

2015-07-12 Thread Cornelia Huck
On Mon, 13 Jul 2015 13:46:50 +0800 Jason Wang wrote: > This reverts commit df91055db5c9cee93d70ca8c08d72119a240b987. > > This is because: > - vhost support virtio 1.0 now > - transport code (e.g virtio-pci) set this feature when modern is > enabled, setting this unconditionally will break disa

Re: [Qemu-devel] [PATCH 0/3] hw/net: Drop unnecessary .can_receive functions

2015-07-12 Thread Jason Wang
On 07/01/2015 03:10 PM, Fam Zheng wrote: > These are all repeating the default, and since we're cleaning up .can_receive, > let's get these out of the way. > > Fam > > > Fam Zheng (3): > musicpal: Drop eth_can_receive > etraxfs_eth: Drop eth_can_receive > lan9118: Drop lan9118_can_receive >

Re: [Qemu-devel] [PATCH] virtio-rng: Bump up quota value only when guest requests entropy

2015-07-12 Thread Amit Shah
On (Fri) 10 Jul 2015 [15:04:00], Pankaj Gupta wrote: >Timer was added in virtio-rng to rate limit the > entropy. It used to trigger at regular intervals to > bump up the quota value. The value of quota and timer > slice is decided based on entropy source rate in host. It doesn't necessaril

[Qemu-devel] [PATCH V2 2/2] tests: test rx recovery from cont

2015-07-12 Thread Jason Wang
Rx should be recovered after cont. Signed-off-by: Jason Wang --- Changes from V1: - query status before sending cont, this makes sure that the packet were queued. --- tests/virtio-net-test.c | 52 + 1 file changed, 52 insertions(+) diff --git a/

[Qemu-devel] [PATCH V2 1/2] tests: introduce basic pci test for virtio-net

2015-07-12 Thread Jason Wang
Signed-off-by: Jason Wang --- Changes from V1: - replace the magic value 12 with a macro --- tests/Makefile | 2 +- tests/virtio-net-test.c | 186 ++-- 2 files changed, 180 insertions(+), 8 deletions(-) diff --git a/tests/Makefile b/tests/Ma

[Qemu-devel] [PATCH 4/5] Revert "virtio-net: enable virtio 1.0"

2015-07-12 Thread Jason Wang
This reverts commit df91055db5c9cee93d70ca8c08d72119a240b987. This is because: - vhost support virtio 1.0 now - transport code (e.g virtio-pci) set this feature when modern is enabled, setting this unconditionally will break disable-modern=on. Cc: Cornelia Huck Signed-off-by: Jason Wang ---

[Qemu-devel] [PATCH 3/5] virtio-blk: set VIRTIO_F_ANY_LAYOUT when 1.0 is supported

2015-07-12 Thread Jason Wang
Chapter 6.3 of spec said " Transitional devices MUST offer, and if offered by the device transitional drivers MUST accept the following: VIRTIO_F_ANY_LAYOUT (27) " So this patch sets VIRTIO_F_ANY_LAYOUT when 1.0 is supported. Cc: Stefan Hajnoczi Cc: Kevin Wolf Cc: qemu-bl...@nongnu.org Signed

[Qemu-devel] [PATCH 5/5] virtio-net: unbreak any layout

2015-07-12 Thread Jason Wang
Commit 032a74a1c0fcdd5fd1c69e56126b4c857ee36611 ("virtio-net: byteswap virtio-net header") breaks any layout by requiring out_sg[0].iov_len >= n->guest_hdr_len. Fixing this by copying header to temporary buffer and copying it back after byteswap. Fixes 032a74a1c0fcdd5fd1c69e56126b4c857ee36611 ("vi

[Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-12 Thread Jason Wang
VIRTIO_BLK_F_SCSI was no longer supported in 1.0. So disable it. Cc: Stefan Hajnoczi Cc: Kevin Wolf Cc: qemu-bl...@nongnu.org Signed-off-by: Jason Wang --- hw/block/virtio-blk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c

[Qemu-devel] [PATCH 1/5] virtio-pci: ignore unaligned read/write in virtio_address_space_read()/write()

2015-07-12 Thread Jason Wang
We abort on unaligned read/write in virtio_address_space_read()/write() but since len in under control of guest so qemu will simply crash when booting a modern guest (guest is try to read when len is zero). Fix this by ignoring unaligned write or read. Fixes 1e40356ce5f6ccfa0bb57104a533c62952c560c

Re: [Qemu-devel] [PATCH 0/3] hw/net: Drop unnecessary .can_receive functions

2015-07-12 Thread Fam Zheng
On Wed, 07/01 15:10, Fam Zheng wrote: > These are all repeating the default, and since we're cleaning up .can_receive, > let's get these out of the way. Cc'ing net maintainers. Fam

Re: [Qemu-devel] [PATCH v2] net: Flush queued packets when guest resumes

2015-07-12 Thread Jason Wang
On 07/10/2015 05:24 PM, Fam Zheng wrote: > On Wed, 07/08 17:40, Jason Wang wrote: >> >> On 07/07/2015 05:03 PM, Fam Zheng wrote: >>> On Tue, 07/07 15:44, Jason Wang wrote: On 07/07/2015 09:21 AM, Fam Zheng wrote: > Since commit 6e99c63 "net/socket: Drop net_socket_can_send" and friends,

Re: [Qemu-devel] [Qemu-block] [PATCH 0/3] mirror: Fix guest responsiveness during bitmap scan

2015-07-12 Thread Fam Zheng
On Fri, 07/10 14:16, Alexandre DERUMIER wrote: > So, I think patch 3/3 is enough. (could be great to have it for qemu 2.4) Stefan, are you happy with this series? Fam

Re: [Qemu-devel] [PATCH] virtio-net: Drop net_virtio_info.can_receive

2015-07-12 Thread Jason Wang
On 07/08/2015 06:50 PM, Stefan Hajnoczi wrote: > On Tue, Jul 07, 2015 at 04:45:41PM +0800, Jason Wang wrote: >> >> On 07/06/2015 11:21 PM, Stefan Hajnoczi wrote: >>> On Mon, Jul 06, 2015 at 11:32:25AM +0800, Jason Wang wrote: On 07/02/2015 08:46 PM, Stefan Hajnoczi wrote: > On Tue, Jun 3

Re: [Qemu-devel] [PATCH 3/8] disas: m68k: QOMify target specific disas setup

2015-07-12 Thread Greg Ungerer
On 12/07/15 12:00, Peter Crosthwaite wrote: > From: Peter Crosthwaite > > Move the target_disas() m68k specifics to the QOM disas_set_info hook > and delete the #ifdef specific code in disas.c. > > Cc: Greg Ungerer I see no problems. Reviewed-by: Greg Ungerer > Cc: Laurent Vivier > Signed

Re: [Qemu-devel] [PATCH] target-ppc: Add POWER8E_v2.1 CPU model.

2015-07-12 Thread Alexey Kardashevskiy
On 07/10/2015 07:19 PM, Andrea Bolognani wrote: On Fri, 2015-07-10 at 15:19 +1000, Alexey Kardashevskiy wrote: If I'm reading the kernel source[1] correctly, there are actually subtle differences other than the number of cores: #define CPU_FTRS_POWER8 (/* Bunch of features here */) #d

Re: [Qemu-devel] [PATCH] more check for replaced node

2015-07-12 Thread Wen Congyang
On 07/02/2015 10:48 PM, Stefan Hajnoczi wrote: > On Wed, Jul 01, 2015 at 04:49:40PM +0800, Wen Congyang wrote: >> On 07/01/2015 04:39 PM, Stefan Hajnoczi wrote: >>> On Thu, Jun 25, 2015 at 02:55:10PM +0800, Wen Congyang wrote: Signed-off-by: Wen Congyang --- block.c |

Re: [Qemu-devel] [PATCH qemu v10 10/14] spapr_pci: Enable vfio-pci hotplug

2015-07-12 Thread David Gibson
On Sun, Jul 12, 2015 at 09:41:27AM -0500, Michael Roth wrote: > Quoting Alexey Kardashevskiy (2015-07-11 23:59:45) > > On 07/11/2015 07:33 AM, Michael Roth wrote: > > > Quoting Alexey Kardashevskiy (2015-07-05 21:11:06) > > >> sPAPR IOMMU is managing two copies of an TCE table: > > >> 1) a guest vi

Re: [Qemu-devel] [PATCH v4 1/1] s390 pci infrastructure modelling

2015-07-12 Thread zyimin
On 7/9/2015 5:57 PM, Michael S. Tsirkin wrote: On Thu, Jul 09, 2015 at 05:30:08PM +0800, zyimin wrote: On 7/9/2015 3:48 PM, Michael S. Tsirkin wrote: On Wed, Jul 08, 2015 at 01:44:55PM +0800, Yi Min Zhao wrote: @@ -588,9 +606,172 @@ static const TypeInfo s390_pcihost_info = { } }; +

Re: [Qemu-devel] [PATCH v4 1/1] vhost user: add support of live migration

2015-07-12 Thread Linhaifeng
On 2015/7/10 21:05, Paolo Bonzini wrote: On 26/06/2015 11:22, Thibaut Collet wrote: Some vhost client/backend are able to support live migration. To provide this service the following features must be added: 1. Add the VIRTIO_NET_F_GUEST_ANNOUNCE capability to vhost-net when netdev backend

Re: [Qemu-devel] [PATCH v3 0/7] cpu: add i386 cpu hot remove support

2015-07-12 Thread Zhu Guihua
On 07/09/2015 10:25 PM, Eduardo Otubo wrote: On Fri, Jun 26, 2015 at 11=37=43AM +0800, Zhu Guihua wrote: Hi, On 06/24/2015 09:28 PM, Eduardo Otubo wrote: Hello Zhu, Are you still working on this feature? Could you provide a rebased version of this series? Sorry for late reply. Yes, we are s

Re: [Qemu-devel] [PULL 12/62] framebuffer: check memory_region_is_logging

2015-07-12 Thread Peter Maydell
On 12 July 2015 at 15:09, Paolo Bonzini wrote: > > > On 10/07/2015 17:44, Peter Maydell wrote: >> I've just noticed that one of my vexpress-a9 test images has >> regressed, and git bisect suggests this commit (d55d42078bfb50) >> is at fault. >> >> Test image (512MB) >> http://people.linaro.org/~pe

[Qemu-devel] [PATCH] PR/66760, ipa-inline-analysis.c compile-time hog

2015-07-12 Thread Paolo Bonzini
From: bonz...@gnu.org In this PR, a lot of time is spent doing the same ipa_load_from_parm_agg query over and over. Luckily a memoization scheme is already there, it's just not used by ipa-inline-analysis.c. The patch moves the cache struct (struct func_body_info) to ipa-prop.h and modify ipa-in

Re: [Qemu-devel] [PATCH qemu v10 10/14] spapr_pci: Enable vfio-pci hotplug

2015-07-12 Thread Michael Roth
Quoting Alexey Kardashevskiy (2015-07-11 23:59:45) > On 07/11/2015 07:33 AM, Michael Roth wrote: > > Quoting Alexey Kardashevskiy (2015-07-05 21:11:06) > >> sPAPR IOMMU is managing two copies of an TCE table: > >> 1) a guest view of the table - this is what emulated devices use and > >> this is whe

Re: [Qemu-devel] [PULL 12/62] framebuffer: check memory_region_is_logging

2015-07-12 Thread Paolo Bonzini
On 10/07/2015 17:44, Peter Maydell wrote: > I've just noticed that one of my vexpress-a9 test images has > regressed, and git bisect suggests this commit (d55d42078bfb50) > is at fault. > > Test image (512MB) > http://people.linaro.org/~peter.maydell/vexpress-3.8.tgz > Untar anywhere, and run wi

Re: [Qemu-devel] [PATCH 0/8] Disas QOMification, round 2

2015-07-12 Thread Andreas Färber
Am 12.07.2015 um 03:59 schrieb Peter Crosthwaite: > Continue QOMifying target-specific disassembly. Convert all arches except for > X86 and PPC. They will be round 3 and are non-trivial. > > This brings us close to no arch-specific code in disas.c allow conversion to > common-obj and preparing the

Re: [Qemu-devel] [PATCH 5/8] disas: lm32: QOMify target specific disas setup

2015-07-12 Thread Michael Walle
Am 12. Juli 2015 04:00:02 MESZ, schrieb Peter Crosthwaite : >From: Peter Crosthwaite > >Move the target_disas() lm32 specifics to the QOM disas_set_info hook >and delete the #ifdef specific code in disas.c. > >Cc: Michael Walle >Signed-off-by: Peter Crosthwaite Acked-by: Michael Walle

Re: [Qemu-devel] [PATCH 3/8] disas: m68k: QOMify target specific disas setup

2015-07-12 Thread Laurent Vivier
Le 12/07/2015 04:00, Peter Crosthwaite a écrit : > From: Peter Crosthwaite > > Move the target_disas() m68k specifics to the QOM disas_set_info hook > and delete the #ifdef specific code in disas.c. > > Cc: Greg Ungerer > Cc: Laurent Vivier > Signed-off-by: Peter Crosthwaite > --- > Testing