Re: [Qemu-devel] [RFC v3 7/8] memory: extend memory_region_add_subregion() to support error reporting

2015-07-08 Thread Michael S. Tsirkin
On Wed, Jul 08, 2015 at 08:41:43PM +0200, Igor Mammedov wrote: > On Wed, 8 Jul 2015 20:30:42 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Jul 08, 2015 at 04:58:37PM +0200, Igor Mammedov wrote: > > > On Wed, 8 Jul 2015 12:09:10 +0100 > > > Peter Maydell wrote: > > > > > > > On 8 July 2015 a

Re: [Qemu-devel] [PATCH v2] cpu_defs: Simplify CPUTLB padding logic

2015-07-08 Thread Richard Henderson
On 07/09/2015 04:26 AM, Peter Crosthwaite wrote: There was a complicated subtractive arithmetic for determining the padding on the CPUTLBEntry structure. Simplify this with a union. Signed-off-by: Peter Crosthwaite --- Changed since v1: Remove un-needed anonymous union (Paolo review) --- inclu

Re: [Qemu-devel] [PATCH v6 09/10] target-i386: exception handling for other helper functions

2015-07-08 Thread Richard Henderson
On 07/08/2015 10:46 AM, Pavel Dovgaluk wrote: Then it is better to remove these changes from the patch? Yes please. r~

Re: [Qemu-devel] [RFC] peripheral/register/bitfield objects - new MCU model

2015-07-08 Thread Liviu Ionescu
> On 08 Jul 2015, at 23:22, Peter Crosthwaite > wrote: > > ... an RFC on list for something very similar, if you want to weigh > in or find it useful, let me know! yes, if you are not in a hurry to commit your patches, I guess together we can find a suitable solution. as already mentioned, m

Re: [Qemu-devel] [PATCH] KVM: x86: Add host physical address width capability

2015-07-08 Thread Laszlo Ersek
On 07/09/15 08:09, Paolo Bonzini wrote: > > > On 09/07/2015 00:36, Bandan Das wrote: >> Let userspace inquire the maximum physical address width >> of the host processors; this can be used to identify maximum >> memory that can be assigned to the guest. >> >> Reported-by: Laszlo Ersek >> Signed-

Re: [Qemu-devel] [PATCH v11 02/19] i.MX: Move serial initialization to init/realize of DeviceClass.

2015-07-08 Thread Peter Crosthwaite
sorry accidental send, comments inline below. On Wed, Jul 8, 2015 at 11:36 PM, Peter Crosthwaite wrote: > On Wed, Jul 8, 2015 at 10:55 PM, Jean-Christophe DUBOIS > wrote: >> Le 08/07/2015 22:49, Peter Crosthwaite a écrit : >>> >>> On Wed, Jul 8, 2015 at 11:42 AM, Jean-Christophe Dubois >>> wrot

Re: [Qemu-devel] [PATCH v11 02/19] i.MX: Move serial initialization to init/realize of DeviceClass.

2015-07-08 Thread Peter Crosthwaite
On Wed, Jul 8, 2015 at 10:55 PM, Jean-Christophe DUBOIS wrote: > Le 08/07/2015 22:49, Peter Crosthwaite a écrit : >> >> On Wed, Jul 8, 2015 at 11:42 AM, Jean-Christophe Dubois >> wrote: >>> >>> Move constructor to DeviceClass methods >>> * imx_serial_init >>> * imx_serial_realize >>> >>> imx3

[Qemu-devel] Virtualising qmp_query_cpus() arch specifics

2015-07-08 Thread Peter Crosthwaite
Hi All, So for my multi-arch work, one of the eventual requirements is to remove all #define TARGET_FOO from core code. I came across this in cpus.c/qmp_query_cpus(): #if defined(TARGET_I386) X86CPU *x86_cpu = X86_CPU(cpu); CPUX86State *env = &x86_cpu->env; #elif defined(TARGET_PP

Re: [Qemu-devel] [RFC] CMSIS based Cortex-M MCU definitions

2015-07-08 Thread Liviu Ionescu
since this reply actually refers to CMSIS, I moved the discussion on the other thread. > On 09 Jul 2015, at 05:42, Peter Crosthwaite > wrote: > > On Wed, Jul 8, 2015 at 6:50 PM, Liviu Ionescu wrote: >> >>> ... my interest is to generate the entire MCU description from the CMSIS >>> .pdsc an

Re: [Qemu-devel] [PATCH] KVM: x86: Add host physical address width capability

2015-07-08 Thread Paolo Bonzini
On 09/07/2015 00:36, Bandan Das wrote: > Let userspace inquire the maximum physical address width > of the host processors; this can be used to identify maximum > memory that can be assigned to the guest. > > Reported-by: Laszlo Ersek > Signed-off-by: Bandan Das > --- > arch/x86/kvm/x86.c

Re: [Qemu-devel] [PATCH v11 02/19] i.MX: Move serial initialization to init/realize of DeviceClass.

2015-07-08 Thread Jean-Christophe DUBOIS
Le 08/07/2015 22:49, Peter Crosthwaite a écrit : On Wed, Jul 8, 2015 at 11:42 AM, Jean-Christophe Dubois wrote: Move constructor to DeviceClass methods * imx_serial_init * imx_serial_realize imx32_serial_properties is renamed to imx_serial_properties. Rework of Qdev construction helper fu

Re: [Qemu-devel] [PATCH v5] vhost-user: add multi queue support

2015-07-08 Thread Maxime Leroy
Hi Michael, On Wed, Jul 8, 2015 at 4:29 PM, Michael S. Tsirkin wrote: > On Thu, May 28, 2015 at 09:23:06AM +0800, Ouyang Changchun wrote: >> Based on patch by Nikolay Nikolaev: >> Vhost-user will implement the multi queue support in a similar way >> to what vhost already has - a separate thread f

Re: [Qemu-devel] [PATCH for-2.5 1/4] block: add BlockLimits.max_iov field

2015-07-08 Thread Peter Lieven
Am 08.07.2015 um 17:30 schrieb Stefan Hajnoczi: The maximum number of struct iovec elements depends on the BlockDriverState. The raw-posix protocol has a maximum of IOV_MAX but others could have different values. Instead of assuming raw-posix and hardcoding IOV_MAX in several places, put the li

[Qemu-devel] [PATCH 2/3] mirror: Use block_job_relax_cpu during bitmap scanning

2015-07-08 Thread Fam Zheng
Sleeping for 0 second may not be as effective as we want, use block_job_relax_cpu. Signed-off-by: Fam Zheng --- block/mirror.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/mirror.c b/block/mirror.c index 62db031..ca55578 100644 --- a/block/mirror.c +++ b/block/mirror

[Qemu-devel] [PATCH 3/3] mirror: Speed up bitmap initial scanning

2015-07-08 Thread Fam Zheng
Limiting to sectors_per_chunk for each bdrv_is_allocated_above is slow, because the underlying protocol driver would issue much more queries than necessary. We should coalesce the query. Signed-off-by: Fam Zheng --- block/mirror.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletion

[Qemu-devel] [PATCH 0/3] mirror: Fix guest responsiveness during bitmap scan

2015-07-08 Thread Fam Zheng
This supersedes: http://patchwork.ozlabs.org/patch/491415/ and [1] which is currently in Jeff's tree. Although [1] fixed the QMP responsiveness, Alexandre DERUMIER reported that guest responsiveness still suffers when we are busy in the initial dirty bitmap scanning loop of mirror job. That is b

[Qemu-devel] [PATCH 1/3] blockjob: Introduce block_job_relax_cpu

2015-07-08 Thread Fam Zheng
block_job_sleep_ns is called by block job coroutines to yield the execution to VCPU threads and monitor etc. It is pointless to sleep for 0 or a few nanoseconds, because that equals to a "yield + enter" with no intermission in between (the timer fires immediately in the same iteration of event loop

[Qemu-devel] [PATCH v2] cpu_defs: Simplify CPUTLB padding logic

2015-07-08 Thread Peter Crosthwaite
There was a complicated subtractive arithmetic for determining the padding on the CPUTLBEntry structure. Simplify this with a union. Signed-off-by: Peter Crosthwaite --- Changed since v1: Remove un-needed anonymous union (Paolo review) --- include/exec/cpu-defs.h | 21 ++--- 1 fi

[Qemu-devel] [PATCH COLO-Frame v7 00/34] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

2015-07-08 Thread zhanghailiang
This is the 7th version of COLO. Here is only COLO frame part, include: VM checkpoint, failover, proxy API, block replication API, not include block replication. The block part is sent as a separate series. As usuall, we provide two branch which one is 'colo-v1.4-basic', and the other is 'colo-v

[Qemu-devel] [PATCH COLO-Frame v7 21/34] COLO NIC: Init/remove colo nic devices when add/cleanup tap devices

2015-07-08 Thread zhanghailiang
When go into COLO mode, we need to some init work for all VM's nics. Here we use a list to record these nic, and for now we only support the 'tap' nic backend. Cc: Stefan Hajnoczi Cc: Jason Wang Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian --- include/net/colo-nic.h | 5 net/M

[Qemu-devel] [PATCH COLO-Frame v7 26/34] COLO NIC: Some init work related with proxy module

2015-07-08 Thread zhanghailiang
Implement communication protocol with proxy module by using nfnetlink, which requires libnfnetlink libs. Tell proxy module to do initialization work and moreover ask kernel to acknowledge the request. It's is necessary for the first time because Netlink is not a reliable protocol. Cc: Stefan Hajn

[Qemu-devel] [PATCH COLO-Frame v7 19/34] COLO failover: Don't do failover during loading VM's state

2015-07-08 Thread zhanghailiang
We should not do failover work while the main thread is loading VM's state, otherwise it will destroy the consistent of VM's memory and device state. Here we add a new failover status 'RELAUNCH' which means we should relaunch the process of failover. Signed-off-by: zhanghailiang Signed-off-by: L

[Qemu-devel] [PATCH COLO-Frame v7 27/34] COLO: Handle nfnetlink message from proxy module

2015-07-08 Thread zhanghailiang
Proxy module will send message to qemu through nfnetlink. Now, the message only contains the result of packets comparation. We use a global variable 'packet_compare_different' to store the result. And this variable should be accessed by using atomic related function, such as 'atomic_set' 'atomic_x

[Qemu-devel] [PATCH COLO-Frame v7 04/34] colo-comm/migration: skip colo info section for special cases

2015-07-08 Thread zhanghailiang
For older machine types, we skip the colo info section when do migration, in this way, we can migrate successfully between older mainchine and the new one. We also skip this section if colo is not enabled (i.e. migrate_set_capability colo on), so that, It not break compatibility with migration ho

[Qemu-devel] [PATCH COLO-Frame v7 28/34] COLO: Do checkpoint according to the result of packets comparation

2015-07-08 Thread zhanghailiang
Only do checkpoint, when the PVM's and SVM's output net packets are inconsistent, We also limit the min time between two continuous checkpoint action, to give VM a change to run. Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian --- include/net/colo-nic.h | 2 ++ migration/colo.c |

[Qemu-devel] [PATCH COLO-Frame v7 20/34] COLO: Add new command parameter 'forward_nic' 'colo_script' for net

2015-07-08 Thread zhanghailiang
The 'forward_nic' should be assigned with network name, for exmple, 'eth2'. It will be parameter of 'colo_script', 'colo_script' should be assigned with an scirpt path. We parse these parameter in tap. Cc: Stefan Hajnoczi Cc: Jason Wang Cc: Eric Blake Cc: Markus Armbruster Signed-off-by: zhan

[Qemu-devel] [PATCH COLO-Frame v7 34/34] COLO: Add block replication into colo process

2015-07-08 Thread zhanghailiang
Make sure master start block replication after slave's block replication started. Signed-off-by: zhanghailiang Signed-off-by: Wen Congyang Signed-off-by: Yang Hongyang Signed-off-by: Li Zhijian --- migration/colo.c | 71 +--- trace-events

Re: [Qemu-devel] [PULL v2 05/22] cpu: Convert cpu_index into a bitmap

2015-07-08 Thread Peter Crosthwaite
On Wed, Jul 8, 2015 at 8:16 PM, Bharata B Rao wrote: > On Wed, Jul 08, 2015 at 09:07:30PM +0200, Andreas Färber wrote: >> Am 07.07.2015 um 19:16 schrieb Andreas Färber: >> > From: Bharata B Rao >> > >> > Currently CPUState::cpu_index is monotonically increasing and a newly >> > created CPU always

[Qemu-devel] [PATCH COLO-Frame v7 31/34] COLO NIC: Implement NIC checkpoint and failover

2015-07-08 Thread zhanghailiang
Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian --- include/net/colo-nic.h | 2 ++ migration/colo.c | 21 ++--- net/colo-nic.c | 23 +++ 3 files changed, 43 insertions(+), 3 deletions(-) diff --git a/include/net/colo-nic.h b/include/net/

[Qemu-devel] [PATCH COLO-Frame v7 18/34] qmp event: Add event notification for COLO error

2015-07-08 Thread zhanghailiang
If some errors happen during VM's COLO FT stage, it's import to notify the users this event, Togehter with 'colo_lost_heartbeat', users can intervene in COLO's failover work immediately. If users don't want to get involved in COLO's failover verdict, it is still necessary to notify users that we ex

[Qemu-devel] [PATCH COLO-Frame v7 24/34] colo-nic: Handle secondary VM's original net device configure

2015-07-08 Thread zhanghailiang
For secondary VM, we need to reconfigure its original net devices, Before go into COLO mode, we detach its original net devices (here is tap) from its default configure (here is bridge), and attach the net devices to forward bridge. When exit from COLO mode, we resume its origianl configure. Signe

[Qemu-devel] [PATCH COLO-Frame v7 16/34] COLO failover: Introduce state to record failover process

2015-07-08 Thread zhanghailiang
When handling failover, we do different things according to the different stage of failover process, here we introduce a global atomic variable to record the status of failover. We add four failover status to indicate the different stage of failover process. You should use the helpers to get and s

[Qemu-devel] [PATCH COLO-Frame v7 23/34] COLO NIC: Implement colo nic device interface configure()

2015-07-08 Thread zhanghailiang
Implement colo nic device interface configure() add a script to configure nic devices: ${QEMU_SCRIPT_DIR}/colo-proxy-script.sh Cc: Stefan Hajnoczi Cc: Jason Wang Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian --- include/net/tap.h| 17 net/colo-nic.c

[Qemu-devel] [PATCH COLO-Frame v7 17/34] COLO failover: Implement COLO primary/secondary vm failover work

2015-07-08 Thread zhanghailiang
If there are some errors happen, we will give users(administrators) time to get involved in failover verdict, which they can decide which side should take over the work by using 'colo_lost_heartbeat' command. Note: The default verdict is primary VM takes over work while secondary VM exit. So if us

[Qemu-devel] [PATCH COLO-Frame v7 30/34] COLO: Add colo-set-checkpoint-period command

2015-07-08 Thread zhanghailiang
With this command, we can control the period of checkpoint, if there is no comparison of net packets. Cc: Luiz Capitulino Cc: Eric Blake Cc: Markus Armbruster Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian --- hmp-commands.hx| 15 +++ hmp.c | 7 +

[Qemu-devel] [PATCH COLO-Frame v7 03/34] COLO: migrate colo related info to slave

2015-07-08 Thread zhanghailiang
We can know if VM in destination should go into COLO mode by refer to the info that been migrated from PVM. Signed-off-by: zhanghailiang Signed-off-by: Yang Hongyang Signed-off-by: Lai Jiangshan Signed-off-by: Gonglei --- include/migration/colo.h | 2 ++ migration/Makefile.objs | 1 + migr

[Qemu-devel] [PATCH COLO-Frame v7 01/34] configure: Add parameter for configure to enable/disable COLO support

2015-07-08 Thread zhanghailiang
configure --enable-colo/--disable-colo to switch COLO support on/off. COLO support is off by default. Signed-off-by: zhanghailiang Signed-off-by: Yang Hongyang Signed-off-by: Gonglei Signed-off-by: Lai Jiangshan --- configure | 11 +++ 1 file changed, 11 insertions(+) diff --git a/co

[Qemu-devel] [PATCH COLO-Frame v7 25/34] COLO NIC: Implement colo nic init/destroy function

2015-07-08 Thread zhanghailiang
When in colo mode, call colo nic init/destroy function. Cc: Stefan Hajnoczi Cc: Jason Wang Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian --- include/net/colo-nic.h | 3 +++ migration/colo.c | 15 +++ net/colo-nic.c | 69 +

[Qemu-devel] [PATCH COLO-Frame v7 13/34] arch_init: Start to trace dirty pages of SVM

2015-07-08 Thread zhanghailiang
we will use this dirty bitmap together with VM's cache RAM dirty bitmap to decide which page in cache should be flushed into VM's RAM. Signed-off-by: zhanghailiang --- migration/ram.c | 16 1 file changed, 16 insertions(+) diff --git a/migration/ram.c b/migration/ram.c index de

[Qemu-devel] [PATCH COLO-Frame v7 33/34] COLO: Implement shutdown checkpoint

2015-07-08 Thread zhanghailiang
For Secondary VM, we forbid it shutdown directly when in COLO mode, FOR Primary VM's shutdown, we should do some work to ensure the consistent action between PVM and SVM. Cc: Paolo Bonzini Signed-off-by: zhanghailiang Signed-off-by: Lai Jiangshan Signed-off-by: Li Zhijian --- include/sysemu/

[Qemu-devel] [PATCH COLO-Frame v7 12/34] COLO VMstate: Load VM state into qsb before restore it

2015-07-08 Thread zhanghailiang
We should not destroy the state of secondary until we receive the whole state from the primary, in case the primary fails in the middle of sending the state, so, here we cache the device state in Secondary before restore it. Besides, we should call qemu_system_reset() before load VM state, which c

[Qemu-devel] [PATCH COLO-Frame v7 14/34] COLO RAM: Flush cached RAM into SVM's memory

2015-07-08 Thread zhanghailiang
During the time of VM's running, PVM/SVM may dirty some pages, we will transfer PVM's dirty pages to SVM and store them into SVM's RAM cache at next checkpoint time. So, the content of SVM's RAM cache will always be some with PVM's memory after checkpoint. Instead of flushing all content of SVM's

[Qemu-devel] [PATCH COLO-Frame v7 11/34] COLO RAM: Load PVM's dirty page into SVM's RAM cache temporarily

2015-07-08 Thread zhanghailiang
The ram cache is initially the same as SVM/PVM's memory. At checkpoint, we cache the dirty RAM of PVM into RAM cache in the slave (so that RAM cache always the same as PVM's memory at every checkpoint), we will flush cached RAM to SVM after we receive all PVM's vmstate (RAM/device). Signed-off-by

[Qemu-devel] [PATCH COLO-Frame v7 09/34] QEMUSizedBuffer: Introduce two help functions for qsb

2015-07-08 Thread zhanghailiang
Introduce two new QEMUSizedBuffer APIs which will be used by COLO to buffer VM state: One is qsb_put_buffer(), which put the content of a given QEMUSizedBuffer into QEMUFile, this is used to send buffered VM state to secondary. Another is qsb_fill_buffer(), read 'size' bytes of data from the file i

[Qemu-devel] [PATCH COLO-Frame v7 29/34] COLO: Improve checkpoint efficiency by do additional periodic checkpoint

2015-07-08 Thread zhanghailiang
Besides normal checkpoint which according to the result of net packets comparing, We do additional checkpoint periodically, it will reduce the number of dirty pages when do one checkpoint, if we don't do checkpoint for a long time (This is a special case when the net packets is always consistent).

[Qemu-devel] [PATCH COLO-Frame v7 08/34] COLO: Add a new RunState RUN_STATE_COLO

2015-07-08 Thread zhanghailiang
Guest will enter this state when paused to save/restore VM state under colo checkpoint. Cc: Eric Blake Cc: Markus Armbruster Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Lai Jiangshan Reviewed-by: Dr. David Alan Gilbert --- qapi-schema.json | 5 - vl.c

[Qemu-devel] [PATCH COLO-Frame v7 32/34] COLO: Disable qdev hotplug when VM is in COLO mode

2015-07-08 Thread zhanghailiang
COLO do not support qdev hotplug migration, disable it. Signed-off-by: zhanghailiang Signed-off-by: Yang Hongyang --- migration/colo.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/migration/colo.c b/migration/colo.c index 3dc7eee..f5bad95 100644 --- a/migration/colo.c +++ b/

[Qemu-devel] [PATCH COLO-Frame v7 07/34] COLO: Implement colo checkpoint protocol

2015-07-08 Thread zhanghailiang
We need communications protocol of user-defined to control the checkpoint process. The new checkpoint request is started by Primary VM, and the interactive process like below: Checkpoint synchronizing points, Primary Secondary NEW @

[Qemu-devel] [PATCH COLO-Frame v7 05/34] migration: Integrate COLO checkpoint process into migration

2015-07-08 Thread zhanghailiang
Add a migrate state: MIGRATION_STATUS_COLO, enter this migration state after the first live migration successfully finished. Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Lai Jiangshan --- include/migration/colo.h | 3 +++ include/migration/migration.h | 2 ++ migra

[Qemu-devel] [PATCH COLO-Frame v7 06/34] migration: Integrate COLO checkpoint process into loadvm

2015-07-08 Thread zhanghailiang
Switch from normal migration loadvm process into COLO checkpoint process if COLO mode is enabled. Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian Signed-off-by: Lai Jiangshan Signed-off-by: Yang Hongyang --- include/migration/colo.h | 13 + migration/colo-comm.c| 10 +++

[Qemu-devel] [PATCH COLO-Frame v7 02/34] migration: Introduce capability 'colo' to migration

2015-07-08 Thread zhanghailiang
We add helper function colo_supported() to indicate whether colo is supported or not, with which we use to control whether or not showing 'colo' string to users, they can use qmp command 'query-migrate-capabilities' or hmp command 'info migrate_capabilities' to learn if colo is supported. Cc: Juan

[Qemu-devel] [PATCH COLO-Frame v7 22/34] tap: Make launch_script() public

2015-07-08 Thread zhanghailiang
We also change the parameters of launch_script(). Cc: Stefan Hajnoczi Cc: Jason Wang Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian --- include/net/tap.h | 2 ++ net/tap.c | 31 ++- 2 files changed, 20 insertions(+), 13 deletions(-) diff --git a/i

[Qemu-devel] [PATCH COLO-Frame v7 15/34] COLO failover: Introduce a new command to trigger a failover

2015-07-08 Thread zhanghailiang
We leave users to use whatever heartbeat solution they want, if the heartbeat is lost, or other errors they detect, they can use command 'colo_lost_heartbeat' to tell COLO to do failover, COLO will do operations accordingly. For example, If send the command to PVM, Primary will exit COLO mode, and

[Qemu-devel] [PATCH COLO-Frame v7 10/34] COLO: Save VM state to slave when do checkpoint

2015-07-08 Thread zhanghailiang
We should save PVM's RAM/device to slave when needed. For VM state, we will cache them in slave, we use QEMUSizedBuffer to store the data, we need know the data size of VM state, so in master, we use qsb to store VM state temporarily, and then migrate the data to slave. Signed-off-by: zhanghailia

Re: [Qemu-devel] [PULL v2 05/22] cpu: Convert cpu_index into a bitmap

2015-07-08 Thread Bharata B Rao
On Wed, Jul 08, 2015 at 09:07:30PM +0200, Andreas Färber wrote: > Am 07.07.2015 um 19:16 schrieb Andreas Färber: > > From: Bharata B Rao > > > > Currently CPUState::cpu_index is monotonically increasing and a newly > > created CPU always gets the next higher index. The next available > > index is

Re: [Qemu-devel] [RFC v2 18/34] HACK: monitor: uninclude cpu_ldst

2015-07-08 Thread Peter Crosthwaite
On Sat, May 30, 2015 at 11:11 PM, Peter Crosthwaite wrote: > This won't work in multi-arch where this service is not provided to > core code. The architecture specific uses of this in monitor.c should > have their functionality migrated out of monitor.c to arch specific > virtualised hooks. For th

Re: [Qemu-devel] [RFC] peripheral/register/bitfield objects - new MCU model

2015-07-08 Thread Peter Crosthwaite
On Wed, Jul 8, 2015 at 6:50 PM, Liviu Ionescu wrote: > >> On 08 Jul 2015, at 23:22, Peter Crosthwaite >> wrote: >> >> I have an RFC on list for something very similar, if you want to weigh >> in or find it useful, let me know! This is a real problem. >> >> https://lists.nongnu.org/archive/html/q

Re: [Qemu-devel] [PATCH] target-ppc: Add POWER8E_v2.1 CPU model.

2015-07-08 Thread Alexey Kardashevskiy
On 07/09/2015 02:35 AM, Andrea Bolognani wrote: On Wed, 2015-07-08 at 17:02 +1000, Alexey Kardashevskiy wrote: I think it's because libvirt likes to specify a specific CPU - and if it gets the new PVR from the host, qemu won't understand it. A specific CPU in this case is "POWER8", I added t

Re: [Qemu-devel] [PULL 14/28] runstate: migration allows more transitions now

2015-07-08 Thread Wen Congyang
On 07/08/2015 07:06 PM, Juan Quintela wrote: > zhanghailiang wrote: >> Hi, >> >> If testing migration with '-S' for qemu command line, (migrate >> directly without executing 'cont' command), >> qemu process in the destination will abort with the follow message: >> >> ERROR: invalid runstate transi

Re: [Qemu-devel] [PULL 14/28] runstate: migration allows more transitions now

2015-07-08 Thread zhanghailiang
On 2015/7/8 19:06, Juan Quintela wrote: zhanghailiang wrote: Hi, If testing migration with '-S' for qemu command line, (migrate directly without executing 'cont' command), qemu process in the destination will abort with the follow message: ERROR: invalid runstate transition: 'inmigrate' -> 'p

Re: [Qemu-devel] [PATCH COLO-BLOCK v7 00/17] Block replication for continuous checkpoints

2015-07-08 Thread Wen Congyang
On 07/09/2015 09:55 AM, Dr. David Alan Gilbert wrote: > * Wen Congyang (we...@cn.fujitsu.com) wrote: >> On 07/08/2015 11:49 PM, Michael R. Hines wrote: >>> On 07/07/2015 08:38 PM, Wen Congyang wrote: On 07/08/2015 12:56 AM, Michael R. Hines wrote: > On 07/07/2015 04:23 AM, Paolo Bonzini wr

Re: [Qemu-devel] [PATCH COLO-BLOCK v7 00/17] Block replication for continuous checkpoints

2015-07-08 Thread Dr. David Alan Gilbert
* Wen Congyang (we...@cn.fujitsu.com) wrote: > On 07/08/2015 11:49 PM, Michael R. Hines wrote: > > On 07/07/2015 08:38 PM, Wen Congyang wrote: > >> On 07/08/2015 12:56 AM, Michael R. Hines wrote: > >>> On 07/07/2015 04:23 AM, Paolo Bonzini wrote: > On 07/07/2015 11:13, Dr. David Alan Gilbert w

Re: [Qemu-devel] [RFC] peripheral/register/bitfield objects - new MCU model

2015-07-08 Thread Liviu Ionescu
> On 08 Jul 2015, at 23:22, Peter Crosthwaite > wrote: > > I have an RFC on list for something very similar, if you want to weigh > in or find it useful, let me know! This is a real problem. > > https://lists.nongnu.org/archive/html/qemu-devel/2015-04/msg03612.html ok, so the problem is real.

Re: [Qemu-devel] [PATCH COLO-BLOCK v8 09/18] Backup: clear all bitmap when doing block checkpoint

2015-07-08 Thread Wen Congyang
On 07/09/2015 09:28 AM, Dr. David Alan Gilbert wrote: > * Wen Congyang (we...@cn.fujitsu.com) wrote: >> Signed-off-by: Wen Congyang >> Signed-off-by: zhanghailiang >> Signed-off-by: Gonglei >> Cc: Jeff Cody >> --- >> block/backup.c | 13 + >> blockjob.c | 10

Re: [Qemu-devel] [snabb-devel] Re: [PATCH v5] vhost-user: add multi queue support

2015-07-08 Thread Ouyang, Changchun
> -Original Message- > From: snabb-de...@googlegroups.com [mailto:snabb- > de...@googlegroups.com] On Behalf Of Maxime Leroy > Sent: Thursday, July 9, 2015 6:01 AM > To: Michael S. Tsirkin > Cc: Ouyang, Changchun; snabb-de...@googlegroups.com; Marcel > Apfelbaum; qemu-devel@nongnu.org; Ni

Re: [Qemu-devel] [PATCH 01/10] util, qga: drop guest_file_toggle_flags

2015-07-08 Thread Michael Roth
Quoting Denis V. Lunev (2015-07-08 17:40:30) > On 09/07/15 00:16, Michael Roth wrote: > > Quoting Denis V. Lunev (2015-06-30 05:25:14) > >> From: Olga Krishtal > >> > >> guest_file_toggle_flags is a copy from semi-portable qemu_set_nonblock. > >> The latter is not working properly for Windows due

Re: [Qemu-devel] [PATCH 06/10] qga: guest exec functionality for Windows guests

2015-07-08 Thread Michael Roth
Quoting Denis V. Lunev (2015-07-08 17:47:51) > On 09/07/15 01:02, Michael Roth wrote: > > Quoting Denis V. Lunev (2015-07-07 03:06:08) > >> On 07/07/15 04:31, Michael Roth wrote: > >>> Quoting Denis V. Lunev (2015-06-30 05:25:19) > From: Olga Krishtal > > Child process' stdin/stdout

Re: [Qemu-devel] [PATCH COLO-BLOCK v8 09/18] Backup: clear all bitmap when doing block checkpoint

2015-07-08 Thread Dr. David Alan Gilbert
* Wen Congyang (we...@cn.fujitsu.com) wrote: > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > Cc: Jeff Cody > --- > block/backup.c | 13 + > blockjob.c | 10 ++ > include/block/blockjob.h | 12 > 3

Re: [Qemu-devel] [PULL 27/28] migration: protect migration_bitmap

2015-07-08 Thread Wen Congyang
On 07/09/2015 04:35 AM, Paolo Bonzini wrote: > > > On 08/07/2015 21:13, Kevin Wolf wrote: >> Am 07.07.2015 um 15:09 hat Juan Quintela geschrieben: >>> From: Li Zhijian >>> >>> Signed-off-by: Li Zhijian >>> Signed-off-by: Wen Congyang >>> Signed-off-by: Juan Quintela >>> --- >>> migration/ram

Re: [Qemu-devel] [PATCH 02/10 v11] linux-user: Support tilegx architecture in linux-user

2015-07-08 Thread gchen gchen
On 07/09/2015 03:24 AM, Chris Metcalf wrote: > On 06/04/2015 08:32 AM, Chen Gang wrote: >> On 06/03/2015 11:47 PM, Richard Henderson wrote: >>> That said, I don't have the system architecture manual >>> handy to check the full details. >> Fortunately, Chris knows more about it, and provide more val

Re: [Qemu-devel] [PATCH COLO-BLOCK v7 00/17] Block replication for continuous checkpoints

2015-07-08 Thread Wen Congyang
On 07/08/2015 11:49 PM, Michael R. Hines wrote: > On 07/07/2015 08:38 PM, Wen Congyang wrote: >> On 07/08/2015 12:56 AM, Michael R. Hines wrote: >>> On 07/07/2015 04:23 AM, Paolo Bonzini wrote: On 07/07/2015 11:13, Dr. David Alan Gilbert wrote: >>> This log is very stange. The NBD client c

Re: [Qemu-devel] SATA CD-ROM booting failure with latest OVMF

2015-07-08 Thread John Snow
On 07/03/2015 10:15 AM, Hannes Reinecke wrote: > Hi all, > > I've updated OVMF to use the SATA controller, so that I could > finally use the Q35 machine specification with OVMF. > > However, upon doing so I found that the (SATA) CD-ROM wouldn't work > anymore; directories on the CD-ROM can be r

Re: [Qemu-devel] [PATCH 06/10] qga: guest exec functionality for Windows guests

2015-07-08 Thread Denis V. Lunev
On 09/07/15 01:02, Michael Roth wrote: Quoting Denis V. Lunev (2015-07-07 03:06:08) On 07/07/15 04:31, Michael Roth wrote: Quoting Denis V. Lunev (2015-06-30 05:25:19) From: Olga Krishtal Child process' stdin/stdout/stderr can be associated with handles for communication via read/write inter

[Qemu-devel] [PATCH] target-i386: Sanity check host processor physical address width

2015-07-08 Thread Bandan Das
If a Linux guest is assigned more memory than is supported by the host processor, the guest is unable to boot. That is expected, however, there's no message indicating the user what went wrong. This change prints a message to stderr if KVM has the corresponding capability. Reported-by: Laszlo Ers

Re: [Qemu-devel] [PATCH 01/10] util, qga: drop guest_file_toggle_flags

2015-07-08 Thread Denis V. Lunev
On 09/07/15 00:16, Michael Roth wrote: Quoting Denis V. Lunev (2015-06-30 05:25:14) From: Olga Krishtal guest_file_toggle_flags is a copy from semi-portable qemu_set_nonblock. The latter is not working properly for Windows due to reduced Windows Posix implementation. On Windows OS there is a

[Qemu-devel] [PATCH] KVM: x86: Add host physical address width capability

2015-07-08 Thread Bandan Das
Let userspace inquire the maximum physical address width of the host processors; this can be used to identify maximum memory that can be assigned to the guest. Reported-by: Laszlo Ersek Signed-off-by: Bandan Das --- arch/x86/kvm/x86.c | 3 +++ include/uapi/linux/kvm.h | 1 + 2 files chan

Re: [Qemu-devel] [PATCH 06/10] qga: guest exec functionality for Windows guests

2015-07-08 Thread Michael Roth
Quoting Denis V. Lunev (2015-07-07 03:06:08) > On 07/07/15 04:31, Michael Roth wrote: > > Quoting Denis V. Lunev (2015-06-30 05:25:19) > >> From: Olga Krishtal > >> > >> Child process' stdin/stdout/stderr can be associated > >> with handles for communication via read/write interfaces. > >> > >> Th

Re: [Qemu-devel] [PATCH 5/6] ARM: enable ARM_FEATURE_MPU for Cortex-M3/M4

2015-07-08 Thread Peter Crosthwaite
On Wed, Jul 8, 2015 at 12:56 AM, Alex Züpke wrote: > Am 07.07.2015 um 22:50 schrieb Peter Crosthwaite: >> On Tue, Jul 7, 2015 at 11:25 AM, Alex Zuepke >> wrote: >>> >>> Signed-off-by: Alex Zuepke >>> --- >>> hw/arm/armv7m.c | 17 - >>> target-arm/cpu.c|2 ++ >>> t

Re: [Qemu-devel] [PATCH 01/10] util, qga: drop guest_file_toggle_flags

2015-07-08 Thread Michael Roth
Quoting Denis V. Lunev (2015-07-07 03:19:07) > On 30/06/15 13:25, Denis V. Lunev wrote: > > From: Olga Krishtal > > > > guest_file_toggle_flags is a copy from semi-portable qemu_set_nonblock. > > The latter is not working properly for Windows due to reduced Windows > > Posix implementation. > > >

Re: [Qemu-devel] [PATCH 01/10] util, qga: drop guest_file_toggle_flags

2015-07-08 Thread Michael Roth
Quoting Denis V. Lunev (2015-06-30 05:25:14) > From: Olga Krishtal > > guest_file_toggle_flags is a copy from semi-portable qemu_set_nonblock. > The latter is not working properly for Windows due to reduced Windows > Posix implementation. > > On Windows OS there is a separate API for changing fl

Re: [Qemu-devel] [PATCH v11 12/19] i.MX: Add SOC support for i.MX31

2015-07-08 Thread Peter Crosthwaite
On Wed, Jul 8, 2015 at 11:42 AM, Jean-Christophe Dubois wrote: > For now we support the following devices: > * CPU: ARM1136 > * Interrupt Controller: AVIC > * CCM > * UART x 2 > * EPIT x 2 > * GPT > > Signed-off-by: Jean-Christophe Dubois Reviewed-by: Peter Crosthwaite > --- > > Ch

Re: [Qemu-devel] [PATCH v11 02/19] i.MX: Move serial initialization to init/realize of DeviceClass.

2015-07-08 Thread Peter Crosthwaite
On Wed, Jul 8, 2015 at 11:42 AM, Jean-Christophe Dubois wrote: > Move constructor to DeviceClass methods > * imx_serial_init > * imx_serial_realize > > imx32_serial_properties is renamed to imx_serial_properties. > > Rework of Qdev construction helper function. > > Signed-off-by: Jean-Christophe

Re: [Qemu-devel] [PULL v3 00/12] Final changes for 2.4-rc0

2015-07-08 Thread Peter Maydell
On 8 July 2015 at 12:19, Paolo Bonzini wrote: > The following changes since commit f6e3035f75e5c6a73485335765ae070304c7a110: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream-smm' into > staging (2015-07-06 23:37:53 +0100) > > are available in the git repository at: > > git:

Re: [Qemu-devel] [PATCH v3 14/16] acpi: Add a way for devices to add ACPI tables

2015-07-08 Thread Paolo Bonzini
On 08/07/2015 21:26, Igor Mammedov wrote: > > This was suggested by Michael, so I think you should read the reviews > > of earlier versions first. > > That is basically the same as hooks in v1 only the other way around > with all drawbacks attached. > > Just dropping this universal way to scatt

Re: [Qemu-devel] [PULL 27/28] migration: protect migration_bitmap

2015-07-08 Thread Paolo Bonzini
On 08/07/2015 21:13, Kevin Wolf wrote: > Am 07.07.2015 um 15:09 hat Juan Quintela geschrieben: >> From: Li Zhijian >> >> Signed-off-by: Li Zhijian >> Signed-off-by: Wen Congyang >> Signed-off-by: Juan Quintela >> --- >> migration/ram.c | 23 +-- >> 1 file changed, 17 inse

Re: [Qemu-devel] [PATCH v10 18/21] i.MX: Add SOC support for i.MX25

2015-07-08 Thread Peter Crosthwaite
On Wed, Jul 8, 2015 at 10:58 AM, Jean-Christophe DUBOIS wrote: > Le 06/07/2015 09:42, Peter Crosthwaite a écrit : >> >> Many of the same comments I had before for IMX31 apply. >> >> Liviu, CCd is actually working on a simlar problem for multiple SoCs >> of the same family using a mostly the same d

Re: [Qemu-devel] [RFC] peripheral/register/bitfield objects - new MCU model

2015-07-08 Thread Peter Crosthwaite
On Wed, Jul 8, 2015 at 1:14 PM, Liviu Ionescu wrote: > as anyone who did it knows, describing memory mapped peripherals is tedious. > as far as I know, qemu support ends at defining memory regions and > implementing the read/write callbacks for all accesses in this region. > > while implementing

[Qemu-devel] [RFC] CMSIS based Cortex-M MCU definitions

2015-07-08 Thread Liviu Ionescu
one interesting consequence of using a peripheral/register/bitfield model is that it allows to partly automate the creation of a new MCU. the natural source for peripheral registers and bitfields are the SVD files, while the natural source for MCU families/subfamilies/devices are the CMSIS PACK

[Qemu-devel] [RFC] peripheral/register/bitfield objects - new MCU model

2015-07-08 Thread Liviu Ionescu
as anyone who did it knows, describing memory mapped peripherals is tedious. as far as I know, qemu support ends at defining memory regions and implementing the read/write callbacks for all accesses in this region. while implementing several Cortex-M devices (currently STM32F103, F107, F407, F4

Re: [Qemu-devel] [PATCH 1/4] linux-user: Exit 0 when -h is used

2015-07-08 Thread Meador Inge
On Mon, Jul 06, 2015 at 09:43:20PM +0200, Laurent Vivier wrote: > Global comment: you should use EXIT_SUCCESS and EXIT_FAILURE from stdlib.h Will fix. Thanks. -- Meador

Re: [Qemu-devel] [PULL 0/2] Ide patches

2015-07-08 Thread Peter Maydell
On 8 July 2015 at 19:09, John Snow wrote: > The following changes since commit c8232b39bb18a91cde39b8e0b60e731a4ce782b1: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2015-07-08 13:36:19 +0100) > > are available in the git repository at: > > https://github.c

Re: [Qemu-devel] [PATCH 02/10 v11] linux-user: Support tilegx architecture in linux-user

2015-07-08 Thread Chris Metcalf
On 06/04/2015 08:32 AM, Chen Gang wrote: On 06/03/2015 11:47 PM, Richard Henderson wrote: That said, I don't have the system architecture manual handy to check the full details. Fortunately, Chris knows more about it, and provide more valuable details for it. And welcome any members to provide

[Qemu-devel] [PATCH for-2.4 5/5] block: Fix backing file child when modifying graph

2015-07-08 Thread Kevin Wolf
This patch moves bdrv_attach_child() from the individual places that add a backing file to a BDS to bdrv_set_backing_hd(), which is called by all of them. It also adds bdrv_detach_child() there. For normal operation (starting with one backing file chain and not changing it until the topmost image

[Qemu-devel] [PATCH for-2.4 1/5] block: Move bdrv_attach_child() calls up the call chain

2015-07-08 Thread Kevin Wolf
Let the callers of bdrv_open_inherit() call bdrv_attach_child(). It needs to be called in all cases where bdrv_open_inherit() succeeds (i.e. returns 0) and a child_role is given. bdrv_attach_child() is moved upwards to avoid a forward declaration. Signed-off-by: Kevin Wolf --- block.c | 41

[Qemu-devel] [PATCH for-2.4 3/5] block: Introduce bdrv_unref_child()

2015-07-08 Thread Kevin Wolf
This is the counterpart for bdrv_open_child(). It decreases the reference count of the child BDS and removes it from the list of children of the given parent BDS. Signed-off-by: Kevin Wolf --- block.c | 23 +-- include/block/block.h | 1 + 2 files changed, 22 i

[Qemu-devel] [PATCH for-2.4 2/5] block: Introduce bdrv_open_child()

2015-07-08 Thread Kevin Wolf
It is the same as bdrv_open_image(), except that it doesn't only return success or failure, but the newly created BdrvChild object for the new child node. As the BdrvChild object already contains a BlockDriverState pointer (and this is supposed to become the only pointer so that bdrv_append() and

[Qemu-devel] [PATCH for-2.4 4/5] block: Reorder cleanups in bdrv_close()

2015-07-08 Thread Kevin Wolf
Block drivers may still want to access their child nodes in their .bdrv_close handler. If they unref and/or detach a child by themselves, this should not result in a double free. There is additional code for backing files, which are just a special case of child nodes. The same applies for them. S

[Qemu-devel] [PATCH for-2.4 0/5] block: Fix backing file child when modifying graph

2015-07-08 Thread Kevin Wolf
This series is extracted from my work towards removing bdrv_swap(), which is targeted for 2.5. It contains a fix for dangling pointers when modifying the BDS graph and its dependencies. I didn't bother to split patches of which only a part is required, nor did I remove references to the future bdr

Re: [Qemu-devel] [PULL v2 00/22] QOM CPUState patch queue 2015-07-07

2015-07-08 Thread Peter Maydell
On 8 July 2015 at 20:01, Peter Crosthwaite wrote: > So you have caught about 10 broken PULLs in the last 48h :) I'm > guessing you have something heavily scripted, is the test system > available? Id like to run as much as I can over the multi-arch work in > total as that has widespread change. My

Re: [Qemu-devel] [PATCH v3 14/16] acpi: Add a way for devices to add ACPI tables

2015-07-08 Thread Igor Mammedov
On Wed, 8 Jul 2015 19:44:16 +0200 Paolo Bonzini wrote: > > > On 07/07/2015 10:08, Igor Mammedov wrote: > > > Some devices, like IPMI, need to add ACPI table entries to report > > > their presence. Add a method for adding these entries. > > > > I think that it's not up to device to define in wh

  1   2   3   4   >