Re: [Qemu-devel] [PATCH v8 8/8] vmport: Add VMware all ring hack

2015-07-04 Thread Michael S. Tsirkin
On Fri, Jul 03, 2015 at 03:50:19PM +0200, Paolo Bonzini wrote: > > > On 03/07/2015 15:08, Don Slutz wrote: > >>> > >> Creating it at the pc level and propagating makes code > >> messy but I'd go along with it if it made sense from > >> user's point of view, but it does not seem to make sense: > >

Re: [Qemu-devel] [PATCH] replaced get_ticks_per_sec() with constant

2015-07-04 Thread Emil Condrea
Stefan, do you know if this patch was applied? Thanks On Tue, Mar 31, 2015 at 8:16 PM, Emil Condrea wrote: > Thanks, Stefan. > > On Mon, Mar 30, 2015 at 4:01 PM, Stefan Hajnoczi > wrote: > >> On Sat, Mar 28, 2015 at 06:22:11PM +0200, Emil Condrea wrote: >> > This replaces all calls to get_tick

Re: [Qemu-devel] [PATCH v9 09/20] i.MX: Remove Qdev EPIT construction helper function.

2015-07-04 Thread Peter Crosthwaite
On Sat, Jul 4, 2015 at 7:34 AM, Jean-Christophe Dubois wrote: > Signed-off-by: Jean-Christophe Dubois > --- > > Changes since v1: > * not present on v1 > > Changes since v2: > * not present on v2 > > Changes since v3: > * not present on v3 > > Changes since v4: > * not present on

Re: [Qemu-devel] [PATCH v9 07/20] i.MX: improve CCM emulator log consistency

2015-07-04 Thread Peter Crosthwaite
Same comments as for CCM RE commit message generalisation. With these commit message rewrites, I suggest change the first one to be the right commit message format and for the rest git commit --amend -c And tweak as needed. Regards, Peter On Sat, Jul 4, 2015 at 7:34 AM, Jean-Christophe Dubois

Re: [Qemu-devel] [PATCH v9 06/20] i.MX: Split CCM emulator in a header file and a source file

2015-07-04 Thread Peter Crosthwaite
You need a commit message body. In trival ones like this I usally just repeat the what with some why. "Split CCM state struct and register defs into a header file to prepare support for use in a SoC device" On Sat, Jul 4, 2015 at 7:34 AM, Jean-Christophe Dubois wrote: > Signed-off-by: Jean-Chris

Re: [Qemu-devel] [PATCH v9 05/20] i.MX: improve AVIC emulator log consistency

2015-07-04 Thread Peter Crosthwaite
On Sat, Jul 4, 2015 at 7:34 AM, Jean-Christophe Dubois wrote: > Signed-off-by: Jean-Christophe Dubois > --- > > Changes since v1: > * not present on v1 > > Changes since v2: > * not present on v2 > > Changes since v3: > * not present on v3 > > Changes since v4: > * not present on

Re: [Qemu-devel] [PATCH v9 04/20] i.MX: Split AVIC emulator in a header file and a source file

2015-07-04 Thread Peter Crosthwaite
On Sat, Jul 4, 2015 at 7:34 AM, Jean-Christophe Dubois wrote: > Signed-off-by: Jean-Christophe Dubois > --- > > Changes since v1: > * not present on v1 > > Changes since v2: > * not present on v2 > > Changes since v3: > * not present on v3 > > Changes since v4: > * not present on

Re: [Qemu-devel] [PATCH v9 02/20] i.MX: Remove Qdev serial construction helper function.

2015-07-04 Thread Peter Crosthwaite
On Sat, Jul 4, 2015 at 7:34 AM, Jean-Christophe Dubois wrote: > Move constructor to DEVICE_CLASS methods > * imx_serial_init A nit, but this is not a DEVICE_CLASS thing. > * imx_serial_realize > > Signed-off-by: Jean-Christophe Dubois > --- > > Changes since v1: > * not present on v1 > >

Re: [Qemu-devel] [PATCH v9 01/20] i.MX: Split UART emulator in a header file and a source file

2015-07-04 Thread Peter Crosthwaite
On Sat, Jul 4, 2015 at 7:34 AM, Jean-Christophe Dubois wrote: > Signed-off-by: Jean-Christophe Dubois > --- > > Changes since v1: > * not present on v1 > > Changes since v2: > * not present on v2 > > Changes since v3: > * not present on v3 > > Changes since v4: > * not present on

[Qemu-devel] [Bug 1289898] Re: qemu-system-ppc64 easily cause file corruption

2015-07-04 Thread wzis
After got qemu 2.3.0, I tested on CentOS6.6, the qemu-system-ppc64 also causes filesystem corruption for the big endian RHEL5.9 for power. So this should confirm the qemu for ppc has bug from at least 1.7 onward. -- You received this bug notification because you are a member of qemu- devel-ml, wh

[Qemu-devel] [Bug 1289898] Re: qemu-system-ppc64 easily cause file corruption

2015-07-04 Thread wzis
And seems no developer cares about this issue. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1289898 Title: qemu-system-ppc64 easily cause file corruption Status in QEMU: New Bug description:

Re: [Qemu-devel] [Qemu-ppc] [PATCHv2 0/4] Start allowing ISA to be configured out

2015-07-04 Thread Benjamin Herrenschmidt
On Thu, 2015-07-02 at 15:53 +1000, David Gibson wrote: > default-configs/ppc64-softmmu.mak | 2 +- Note: My native POWER8 work will need ISA back here, so maybe don't remove it ? The P8 chip has an LPC bus which is effectively an serialized variant of an ISA bus and I'm representing it as s

[Qemu-devel] [RFC PATCH 1/2] qdev: Add a hook for a bus to device if it can add devices

2015-07-04 Thread Benjamin Herrenschmidt
This allows a bus class to tell whether a given bus has room for any new device. max_dev isn't sufficient as the rules can depend on some arguments or can differ between instances of a bus. This will be used by PCI in a subsequent patches Signed-off-by: Benjamin Herrenschmidt --- include/hw/qdev

[Qemu-devel] [PATCH] pci: Don't call pci_irq_handler() for a negative intx

2015-07-04 Thread Benjamin Herrenschmidt
Under some circumstances, pci_intx() can return -1 (when the interrupt pin in the config space is 0 which normally means no interrupt). I have seen cases of pci_set_irq() being called on such devices, in turn causing pci_irq_handler() to be called with "-1" as an argument which doesn't seem like a

[Qemu-devel] [PATCH] pcie: Set the "link active" in the link status register

2015-07-04 Thread Benjamin Herrenschmidt
Some firmwares can test that and assume the device hasn't come up if that bit isn't set Signed-off-by: Benjamin Herrenschmidt --- hw/pci/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index 14c7711..8bb166b 100644 --- a/hw/pci/pcie.c +++

[Qemu-devel] [RFC PATCH 1/2] qdev: Add a hook for a bus to device if it can add devices

2015-07-04 Thread Benjamin Herrenschmidt
This allows a bus class to tell whether a given bus has room for any new device. max_dev isn't sufficient as the rules can depend on some arguments or can differ between instances of a bus. This will be used by PCI in a subsequent patches Signed-off-by: Benjamin Herrenschmidt --- include/hw/qdev

[Qemu-devel] [RFC PATCH 2/2] pci: Use the new can_add_device() to enforce devfn_min/max

2015-07-04 Thread Benjamin Herrenschmidt
This adds a devfn_max field to PCIBus and adds a pci_can_add_device() function which, if no "addr" (aka devfn) is specified, will tell whether there is any slot free between devfn_min and devfn_max. This will be used by some PCI root complex implementations that support only one direct child to av

[Qemu-devel] [PATCH] pci: Fix pci_device_iommu_address_space() bus propagation

2015-07-04 Thread Benjamin Herrenschmidt
he current code walks up the bus tree for an iommu, however it passes to the iommu_fn() callback the bus/devfn of the immediate child of the level where the callback was found, rather than the original bus/devfn where the search started from. This prevents iommu's like POWER8 (and in fact also Q35

Re: [Qemu-devel] [PATCH 2/3] arm_mptimer: Fix ONE-SHOT -> PERIODIC mode change

2015-07-04 Thread Dmitry Osipenko
04.07.2015 22:36, Peter Crosthwaite пишет: Your do-nothing code paths are now inconsistent between the 0 and 1 cases. I think this if can be consolidated with: if (value & 1) { if ((old & 1) && (tb->count != 0)) { break; } if (tb->control & 2) { ... }

Re: [Qemu-devel] [PATCH] virtio-pci: implement cfg capability

2015-07-04 Thread Michael S. Tsirkin
On Thu, Jul 02, 2015 at 09:02:58PM +0200, Paolo Bonzini wrote: > > > On 02/07/2015 21:00, Michael S. Tsirkin wrote: > > On Thu, Jul 02, 2015 at 08:48:14PM +0200, Paolo Bonzini wrote: > >> > >> > >> On 02/07/2015 15:00, Michael S. Tsirkin wrote: > >>> +cfg = (void *)(proxy->pci_dev.config

Re: [Qemu-devel] [PATCH 3/3] arm_mptimer: Respect IT bit state

2015-07-04 Thread Dmitry Osipenko
Hello Peter, 04.07.2015 22:39, Peter Crosthwaite пишет: You also need to trigger timerblock_update_irq on change of state for the control bit itself. "case 8: /* Control. */" in the _write handler needs to call this fn. Right, as it will mask/unmask interrupt line. Good catch, thanks. -- D

Re: [Qemu-devel] [PATCH 3/3] arm_mptimer: Respect IT bit state

2015-07-04 Thread Peter Crosthwaite
On Thu, Jul 2, 2015 at 3:52 PM, Dmitry Osipenko wrote: > Timer fires interrupt regardless of current IT(interrupt enable) bit state. > Fix it by making timer to respect IT state. > > Signed-off-by: Dmitry Osipenko > --- > hw/timer/arm_mptimer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletio

Re: [Qemu-devel] [PATCH 2/3] arm_mptimer: Fix ONE-SHOT -> PERIODIC mode change

2015-07-04 Thread Peter Crosthwaite
On Thu, Jul 2, 2015 at 3:52 PM, Dmitry Osipenko wrote: > Timer won't start periodic ticking if ONE-SHOT -> PERIODIC mode change > happened > after one-shot tick was completed. Fix it by starting ticking only if timer > was > disabled previously and isn't ticking right now. > > Signed-off-by: Dmi

Re: [Qemu-devel] [PATCH 3/5] hw/arm/boot: Configure secure GIC to make IRQs NS if booting an NS kernel

2015-07-04 Thread Peter Crosthwaite
On Thu, Jul 2, 2015 at 5:41 AM, Peter Maydell wrote: > On 30 June 2015 at 21:10, Peter Crosthwaite > wrote: >> On Tue, Jun 30, 2015 at 12:42 PM, Peter Maydell >> wrote: >>> On 30 June 2015 at 20:01, Peter Crosthwaite >>> wrote: So I actually had my own patches for this one that went in a d

Re: [Qemu-devel] [PATCH] virtio-net: Drop net_virtio_info.can_receive

2015-07-04 Thread Michael S. Tsirkin
On Fri, Jul 03, 2015 at 12:17:38PM +0800, Fam Zheng wrote: > On Fri, 07/03 09:12, Fam Zheng wrote: > > On Thu, 07/02 18:46, Michael S. Tsirkin wrote: > > > On Thu, Jul 02, 2015 at 01:46:26PM +0100, Stefan Hajnoczi wrote: > > > > On Tue, Jun 30, 2015 at 04:35:24PM +0800, Jason Wang wrote: > > > > >

Re: [Qemu-devel] [PATCH v2 1/1] KVM s390 pci infrastructure modelling

2015-07-04 Thread Michael S. Tsirkin
On Fri, Jul 03, 2015 at 07:09:59PM +0800, Hong Bo Li wrote: > >But I would like to note that pci device drivers require driver handshake > >before device goes away. > >IIUC s390 hotplug is immediate, which is a problem. > >Maybe doing the change will help make sure device removal is acked > >by gue

Re: [Qemu-devel] [PATCH v10 7/7] qemu-iotests: s390x: fix test 130

2015-07-04 Thread Max Reitz
On 02.07.2015 11:01, tu bo wrote: I got one issue after running checkpatch.pl below, [gavin@oc646435 qemu]$ ./scripts/checkpatch.pl home/gavin/patch/v8/0007-qemu-iotests-s390x-fix-test-130.patch // ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8// #52: FILE: tests/

Re: [Qemu-devel] [PATCH 1/1] block: update BlockDriverState's children in bdrv_set_backing_hd()

2015-07-04 Thread Max Reitz
On 01.07.2015 21:41, Alberto Garcia wrote: On Wed 01 Jul 2015 06:05:32 PM CEST, Max Reitz wrote: @@ -1120,6 +1128,11 @@ void bdrv_set_backing_hd(BlockDriverState *bs, BlockDriverState *backing_hd) bs->backing_blocker = NULL; goto out; } + +bdrv_attach_child(bs

[Qemu-devel] [PATCH v9 20/20] i.MX: Add qtest support for I2C device emulator.

2015-07-04 Thread Jean-Christophe Dubois
This is using a ds1338 RTC chip on the I2C bus. This RTC chip is not present on the real 3DS PDK board. Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * not present on v1 Changes since v2: * use a common header file for I2C regs definition Changes since v3: * rework GP

[Qemu-devel] [PATCH v9 17/20] i.MX: Add FEC Ethernet Emulator

2015-07-04 Thread Jean-Christophe Dubois
This is based on mcf_fec.c FEC implementation for Coldfire * A generic PHY was added (borrowwed from LAN9118) * The buffer management is also modified as buffers are slightly different between Coldfire and i.MX Signed-off-by: Jean-Christophe Dubois Reviewed-by: Peter Crosthwaite --- Ch

[Qemu-devel] [PATCH v9 16/20] i.MX: Add I2C controller emulator

2015-07-04 Thread Jean-Christophe Dubois
The slave mode is not implemented. Signed-off-by: Jean-Christophe Dubois Reviewed-by: Peter Crosthwaite --- Changes since v1: * none Changes since v2: * use QOM cast * reworked debug printf * use CamelCase for state type * warn with qemu_log_mask(LOG_GUEST_ERROR) or qemu_lo

[Qemu-devel] [PATCH v9 19/20] i.MX: Add the i.MX25 3DS PDK plateform

2015-07-04 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * Added a ds1338 I2C device for qtest purpose. Changes since v2: * none Changes since v3: * Rework GPL header * use I2C constructor helper. Changes since v4: * use sysbus_create_simple() instead of I2C c

[Qemu-devel] [PATCH v9 14/20] i.MX: Add SOC support for i.MX31

2015-07-04 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not present on v4 Changes since v5: * not present on v5 Changes since v6: * not present on v

[Qemu-devel] [PATCH v9 12/20] i.MX: Remove Qdev GPT construction helper function.

2015-07-04 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not present on v4 Changes since v5: * not present on v5 Changes since v6: * not present on v

[Qemu-devel] [PATCH v9 15/20] i.MX: KZM now uses the standalone i.MX31 SOC support

2015-07-04 Thread Jean-Christophe Dubois
Tested by booting a minimal linux system on the emulated plateform Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not present on v4 Changes since v

[Qemu-devel] [PATCH v9 13/20] i.MX: Fix Coding style for GPT emulator

2015-07-04 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not present on v4 Changes since v5: * not present on v5 Changes since v6: * not present on v

[Qemu-devel] [PATCH v9 11/20] i.MX: Split GPT emulator in a header file and a source file

2015-07-04 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not present on v4 Changes since v5: * not present on v5 Changes since v6: * not present on v

[Qemu-devel] [PATCH v9 08/20] i.MX: Split EPIT emulator in a header file and a source file

2015-07-04 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not present on v4 Changes since v5: * not present on v5 Changes since v6: * not present on v

[Qemu-devel] [PATCH v9 10/20] i.MX: Fix Coding style for EPIT emulator

2015-07-04 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not present on v4 Changes since v5: * not present on v5 Changes since v6: * not present on v

[Qemu-devel] [PATCH v9 06/20] i.MX: Split CCM emulator in a header file and a source file

2015-07-04 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not present on v4 Changes since v5: * not present on v5 Changes since v6: * not present on v

[Qemu-devel] [PATCH v9 07/20] i.MX: improve CCM emulator log consistency

2015-07-04 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not present on v4 Changes since v5: * not present on v5 Changes since v6: * not present on v

[Qemu-devel] [PATCH v9 18/20] i.MX: Add SOC support for i.MX25

2015-07-04 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not present on v4 Changes since v5: * not present on v5 Changes since v6: * not present on v

[Qemu-devel] [PATCH v9 09/20] i.MX: Remove Qdev EPIT construction helper function.

2015-07-04 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not present on v4 Changes since v5: * not present on v5 Changes since v6: * not present on v

[Qemu-devel] [PATCH v9 04/20] i.MX: Split AVIC emulator in a header file and a source file

2015-07-04 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not present on v4 Changes since v5: * not present on v5 Changes since v6: * not present on v

[Qemu-devel] [PATCH v9 05/20] i.MX: improve AVIC emulator log consistency

2015-07-04 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not present on v4 Changes since v5: * not present on v5 Changes since v6: * not present on v

[Qemu-devel] [PATCH v9 03/20] i.MX:Fix Coding style for UART emulator.

2015-07-04 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois --- hanges since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not present on v4 Changes since v5: * not present on v5 Changes since v6: * not present on v6

[Qemu-devel] [PATCH v9 02/20] i.MX: Remove Qdev serial construction helper function.

2015-07-04 Thread Jean-Christophe Dubois
Move constructor to DEVICE_CLASS methods * imx_serial_init * imx_serial_realize Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not present on v4

[Qemu-devel] [PATCH v9 01/20] i.MX: Split UART emulator in a header file and a source file

2015-07-04 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not present on v4 Changes since v5: * not present on v5 Changes since v6: * not present on v

[Qemu-devel] [PATCH v9 00/20] i.MX: Add i.MX25 support through the 3DS evaluation board.

2015-07-04 Thread Jean-Christophe Dubois
This series of patches add the support for the i.MX25 processor through the Freescale 3DS evaluation board. For now a limited set of devices are supported. * GPT timers (from i.MX31) * EPIT timers (from i.MX31) * Serial ports (from i.MX31) * Ethernet FEC port * I2C controller

Re: [Qemu-devel] [PATCH COLO-BLOCK v7 00/17] Block replication for continuous checkpoints

2015-07-04 Thread Wen Congyang
At 2015/7/3 23:30, Dr. David Alan Gilbert Wrote: * Wen Congyang (we...@cn.fujitsu.com) wrote: Block replication is a very important feature which is used for continuous checkpoints(for example: COLO). Usage: Please refer to docs/block-replication.txt You can get the patch here: https://github.

Re: [Qemu-devel] [PATCH for-2.4] hw/intc/arm_gic_common.c: Reset all registers

2015-07-04 Thread Edgar E. Iglesias
On 04/07/2015 9:24 pm, "Peter Maydell" wrote: > > On 4 July 2015 at 00:11, Edgar E. Iglesias wrote: > > > > > > On Tue, Jun 30, 2015 at 4:25 AM, Peter Maydell > > wrote: > >> > >> The arm_gic_common reset function was missing reset code for > >> several of the GIC's state fields: > >> * bpr[] >

Re: [Qemu-devel] [PATCH v8 8/8] vmport: Add VMware all ring hack

2015-07-04 Thread Paolo Bonzini
On 03/07/2015 15:08, Don Slutz wrote: >>> >> Creating it at the pc level and propagating makes code >> messy but I'd go along with it if it made sense from >> user's point of view, but it does not seem to make sense: >> to me this looks more like a CPU feature than a machine property. >> Or the p

[Qemu-devel] TAP network breaks after debugger break-in

2015-07-04 Thread Max Filippov
Hello, I'm using QEMU with TAP network and after the commit 0a2df857a703 "Merge remote-tracking branch 'remotes/stefanha/tags/net-pull-request' into staging" I've noticed that activation of debugger connected to QEMU's gdbstub during network I/O almost always breaks network connection: network sto

Re: [Qemu-devel] [PATCH v8 6/8] vmport_rpc: Add QMP access to vmport_rpc object.

2015-07-04 Thread Markus Armbruster
Don Slutz writes: > On 07/03/15 13:56, Markus Armbruster wrote: >> Don Slutz writes: >> >>> On 07/02/15 10:11, Markus Armbruster wrote: Don Slutz writes: [...] > diff --git a/qapi-schema.json b/qapi-schema.json > index 106008c..5d9e9e2 100644 > --- a/qapi-schema.json > +++