Re: [Qemu-devel] [PATCH v2 0/4] acpi: xsdt support

2015-06-08 Thread Michael S. Tsirkin
On Tue, Jun 09, 2015 at 08:35:38AM +0200, Michael S. Tsirkin wrote: > On Tue, Jun 09, 2015 at 02:02:31AM -0400, Paolo Bonzini wrote: > > I would just patch OVMF to ignore the RSDT if there is an XSDT. > > > > Alternatively, can you check for ACPI 2.0 support via _OSI, and load the > > ACPI 2.0 bi

Re: [Qemu-devel] Adding new migration-parameters - any easier way?

2015-06-08 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> "Dr. David Alan Gilbert" writes: >> >> > * Eric Blake (ebl...@redhat.com) wrote: >> >> On 06/05/2015 03:50 AM, Dr. David Alan Gilbert wrote: >> >> > Hi, >> >> > Is there any way that we could make it easier t

Re: [Qemu-devel] [PATCH v2 0/4] acpi: xsdt support

2015-06-08 Thread Michael S. Tsirkin
On Tue, Jun 09, 2015 at 02:02:31AM -0400, Paolo Bonzini wrote: > I would just patch OVMF to ignore the RSDT if there is an XSDT. > > Alternatively, can you check for ACPI 2.0 support via _OSI, and load the ACPI > 2.0 bits via LoadTable? Hopefully XP does not BSOD if the invalid (for ACPI > 1.0)

Re: [Qemu-devel] [PATCH 7/7] qdev-monitor: Propagate errors through qdev_device_add()

2015-06-08 Thread Markus Armbruster
Eric Blake writes: > On 06/08/2015 12:57 PM, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster >> --- >> include/monitor/qdev.h | 2 +- >> qdev-monitor.c | 36 +++- >> vl.c | 7 +-- >> 3 files changed, 21 insertions(+),

Re: [Qemu-devel] [PATCH 5/7] qdev-monitor: Convert qbus_find() to Error

2015-06-08 Thread Markus Armbruster
Eric Blake writes: > On 06/08/2015 12:57 PM, Markus Armbruster wrote: >> As usual, the conversion breaks printing explanatory messages after >> the error: actual printing of the error gets delayed, so the >> explanations precede rather than follow it. >> >> Pity. Disable them for now. See also

Re: [Qemu-devel] [PATCH v2 0/4] acpi: xsdt support

2015-06-08 Thread Paolo Bonzini
I would just patch OVMF to ignore the RSDT if there is an XSDT. Alternatively, can you check for ACPI 2.0 support via _OSI, and load the ACPI 2.0 bits via LoadTable? Hopefully XP does not BSOD if the invalid (for ACPI 1.0) opcodes are in a Then block or in a separate method... Then you can use

[Qemu-devel] [PULL v2 8/9] QemuOpts: Convert qemu_opt_foreach() to Error

2015-06-08 Thread Markus Armbruster
Retain the function value for now, to permit selective conversion of its callers. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- include/qemu/option.h | 7 +-- net/vhost-user.c | 7 --- qdev-monitor.c| 5 +++-- ui/spice-core.c | 5 +++-- util/qemu-config

[Qemu-devel] [PULL v2 5/9] QemuOpts: Convert qemu_opts_foreach() to Error

2015-06-08 Thread Markus Armbruster
Retain the function value for now, to permit selective conversion of its callers. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Acked-by: Kevin Wolf --- block/blkdebug.c | 6 ++-- hw/core/qdev-properties-system.c | 5 +-- include/qemu/option.h| 4 +--

[Qemu-devel] [PULL v2 7/9] QemuOpts: Drop qemu_opt_foreach() parameter abort_on_failure

2015-06-08 Thread Markus Armbruster
When the argument is non-zero, qemu_opt_foreach() stops on callback returning non-zero, and returns that value. When the argument is zero, it doesn't stop, and returns the callback's value from the last iteration. The two callers that pass zero could just as well pass one: * qemu_spice_init()'s

[Qemu-devel] [PULL v2 9/9] vhost-user: Improve -netdev/netdev_add/-net/... error reporting

2015-06-08 Thread Markus Armbruster
When -netdev vhost-user fails, it first reports a specific error, then one or more generic ones, like this: $ qemu-system-x86_64 -netdev vhost-user,id=foo,chardev=xxx qemu-system-x86_64: -netdev vhost-user,id=foo,chardev=xxx: chardev "xxx" not found qemu-system-x86_64: -netdev vhost-u

[Qemu-devel] [PULL v2 6/9] blkdebug: Simplify passing of Error through qemu_opts_foreach()

2015-06-08 Thread Markus Armbruster
Cc: Kevin Wolf Cc: qemu-bl...@nongnu.org Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Acked-by: Kevin Wolf --- block/blkdebug.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index be0d273..1e92607 100644 --- a/blo

[Qemu-devel] [PULL v2 4/9] QemuOpts: Drop qemu_opts_foreach() parameter abort_on_failure

2015-06-08 Thread Markus Armbruster
When the argument is non-zero, qemu_opts_foreach() stops on callback returning non-zero, and returns that value. When the argument is zero, it doesn't stop, and returns the bit-wise inclusive or of all the return values. Funky :) The callers that pass zero could just as well pass one, because th

[Qemu-devel] [PULL v2 0/9] Error reporting patches

2015-06-08 Thread Markus Armbruster
The following changes since commit ee09f84e6bf5383a23c9624115c26b72aa1e076c: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2015-06-08 15:57:41 +0100) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-error-2015-06-09 for yo

[Qemu-devel] [PULL v2 3/9] vl: Fail right after first bad -object

2015-06-08 Thread Markus Armbruster
Failure to create an object with -object is a fatal error. However, we delay the actual exit until all -object are processed. On the one hand, this permits detection of genuine additional errors. On the other hand, it can muddy the waters with uninteresting additional errors, e.g. when a later -

[Qemu-devel] [PULL v2 1/9] vl: Report failure to sandbox at most once

2015-06-08 Thread Markus Armbruster
It's reported once per -sandbox on. Stop on the first failure, like we do for other options. Not fixed: "-sandbox on -sandbox off" should leave the sandbox off. It doesn't. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Qemu-devel] [PULL v2 2/9] vl: Print -device help at most once

2015-06-08 Thread Markus Armbruster
We print it once for each -device help. Not helpful. Stop after the first one. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vl.c b/vl.c index dd56a82..680f4d8 100644 --- a/vl.c +++ b/vl.c @@ -4049,7 +4049

Re: [Qemu-devel] [PULL 0/9] Error reporting patches

2015-06-08 Thread Markus Armbruster
Peter Maydell writes: > On 8 June 2015 at 19:02, Markus Armbruster wrote: >> The following changes since commit ee09f84e6bf5383a23c9624115c26b72aa1e076c: >> >> Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' >> into staging (2015-06-08 15:57:41 +0100) >> >> are available in th

Re: [Qemu-devel] [PATCH v2 0/4] acpi: xsdt support

2015-06-08 Thread Michael S. Tsirkin
On Tue, Jun 09, 2015 at 02:08:03AM +0200, Laszlo Ersek wrote: > On 06/08/15 20:14, Michael S. Tsirkin wrote: > > XSDT support allows using ACPI 2 features while > > avoiding breaking legacy windows XP guests: > > ACPI 2 tables are linked from XSDT only, > > ACPI 1 tables from both RSDT and XSDT, th

Re: [Qemu-devel] [PATCH v2 1/9] target-microblaze: Rename the usefpu variable

2015-06-08 Thread Alistair Francis
On Fri, Jun 5, 2015 at 6:04 PM, Peter Crosthwaite wrote: > On Thu, Jun 4, 2015 at 11:39 PM, Alistair Francis > wrote: >> Rename the usefpu variable to use_fpu. >> >> Signed-off-by: Alistair Francis > > Reviewed-by: Peter Crosthwaite Thanks Peter Alistair > >> --- >> target-microblaze/cpu-qo

Re: [Qemu-devel] [RFC v8.1 06/13] vfio: add check host bus reset is support or not

2015-06-08 Thread Chen Fan
On 06/04/2015 11:59 PM, Alex Williamson wrote: On Wed, 2015-06-03 at 08:52 +0800, Chen Fan wrote: On 06/03/2015 12:47 AM, Alex Williamson wrote: On Tue, 2015-06-02 at 15:54 +0800, Chen Fan wrote: On 05/28/2015 05:32 AM, Alex Williamson wrote: On Wed, 2015-05-27 at 10:46 +0800, Chen Fan wrote

[Qemu-devel] [RFC v9 13/18] vfio: add sec_bus_reset notifier to notify physical bus reset is needed

2015-06-08 Thread Chen Fan
Signed-off-by: Chen Fan --- hw/vfio/pci.c | 81 +++ 1 file changed, 81 insertions(+) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 97af143..a4e8658 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -156,6 +156,7 @@ typedef struct VFIOPCI

[Qemu-devel] [RFC v9 18/18] vfio: add 'aer' property to expose aercap

2015-06-08 Thread Chen Fan
add 'aer' property to let user able to decide whether expose the aer capability. by default we should disable aer feature, because it needs configuration restrictions. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c in

[Qemu-devel] [RFC v9 15/18] vfio: do hot bus reset when do virtual secondary bus reset

2015-06-08 Thread Chen Fan
when do virtual secondary bus reset, the vfio device under this bus need to do host bus reset to reset the device. so add this case. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 6507f39..655ac59 100644

[Qemu-devel] [RFC v9 11/18] vfio: add check host bus reset is support or not

2015-06-08 Thread Chen Fan
we introduce a has_bus_reset capability to sign the vfio devices if support host bus reset. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 169 ++ 1 file changed, 169 insertions(+) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 06006ce..97a

[Qemu-devel] [RFC v9 14/18] vfio: improve vfio_pci_hot_reset to support more case

2015-06-08 Thread Chen Fan
the vfio_pci_hot_reset differentiate the single and multi in-used devices for reset. but sometimes we own the group without any devices, that also should support hot reset. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/vfio/pci.c b/

[Qemu-devel] [RFC v9 12/18] pci: add bus reset_notifiers callbacks for host bus reset

2015-06-08 Thread Chen Fan
Particularly, For vfio devices, Once need to recovery devices by bus reset such as AER, we always need to reset the host bus to recovery the devices under the bus, so we need to add pci bus callbacks to specify to do host bus reset. Signed-off-by: Chen Fan --- hw/pci/pci.c | 16 +

[Qemu-devel] [RFC v9 17/18] vfio-pci: pass the aer error to guest

2015-06-08 Thread Chen Fan
when the vfio device encounters an uncorrectable error in host, the vfio_pci driver will signal the eventfd registered by this vfio device, the results in the qemu eventfd handler getting invoked. this patch is to pass the error to guest and have the guest driver recover from the error. Signed-of

[Qemu-devel] [RFC v9 09/18] vfio: add ref for group to support own affected groups

2015-06-08 Thread Chen Fan
Signed-off-by: Chen Fan --- hw/vfio/common.c | 12 include/hw/vfio/vfio-common.h | 1 + 2 files changed, 13 insertions(+) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index 4230f83..eff1930 100644 --- a/hw/vfio/common.c +++ b/hw/vfio/common.c @@ -832,6 +832,7 @@ VF

[Qemu-devel] [RFC v9 08/18] vfio: improve vfio_get_group to support adding group without devices

2015-06-08 Thread Chen Fan
Pre-adding all affected groups for aer devices, it could ensure the affected groups are owned in VM. Signed-off-by: Chen Fan --- hw/vfio/common.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index b1045da..4230f83 100644

[Qemu-devel] [RFC v9 16/18] pcie_aer: expose pcie_aer_msg() interface

2015-06-08 Thread Chen Fan
For vfio device, we need to propagate the aer error to Guest OS. we use the pcie_aer_msg() to send aer error to guest. Signed-off-by: Chen Fan --- hw/pci/pcie_aer.c | 2 +- include/hw/pci/pcie_aer.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/pci/pcie_aer.c b/

[Qemu-devel] [RFC v9 07/18] vfio: add aer support for vfio device

2015-06-08 Thread Chen Fan
Calling pcie_aer_init to initilize aer related registers for vfio device, then reload physical related registers to expose device capability. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 86 ++- 1 file changed, 85 insertions(+), 1 deletion(-

[Qemu-devel] [RFC v9 10/18] get all affected groups for each device support aer

2015-06-08 Thread Chen Fan
Add the affected groups without any devices into VM, it can keep the VM ownship the all groups. and use a reference to make the group visible. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 115 ++ 1 file changed, 108 insertions(+), 7 deletion

[Qemu-devel] [RFC v9 05/18] vfio: add pcie extanded capability support

2015-06-08 Thread Chen Fan
For vfio pcie device, we could expose the extended capability on PCIE bus. in order to avoid config space broken, we introduce a copy config for parsing extended caps. and rebuild the pcie extended config space. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 73 +

[Qemu-devel] [RFC v9 06/18] aer: impove pcie_aer_init to support vfio device

2015-06-08 Thread Chen Fan
pcie_aer_init was used to emulate an aer capability for pcie device, but for vfio device, the aer config space size is mutable and is not always equal to PCI_ERR_SIZEOF(0x48). it depends on where the TLP Prefix register required, so here we add a size argument. Signed-off-by: Chen Fan --- hw/pci

[Qemu-devel] [RFC v9 03/18] pcie: modify the capability size assert

2015-06-08 Thread Chen Fan
because the capabilities need to be DWORD aligned, so the size should DWORD aligned too, and then the last capability size can to be the greatest 0x1000. e.g. if I have a capability starting 4 bytes from the end, 0xFFC. The max size should be 4 bytes, 0x1000 - 0xFFC, not 3 bytes, 0xFFF - 0xFFC. S

[Qemu-devel] [RFC v9 02/18] vfio: squeeze out vfio_pci_do_hot_reset for support bus reset

2015-06-08 Thread Chen Fan
squeeze out vfio_pci_do_hot_reset to do host bus reset when AER recovery. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 75 +++ 1 file changed, 44 insertions(+), 31 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 4a97ccc..e056c

[Qemu-devel] [RFC v9 04/18] vfio: make the 4 bytes aligned for capability size

2015-06-08 Thread Chen Fan
Signed-off-by: Chen Fan --- hw/vfio/pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index e056c49..52e8ad4 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -2481,7 +2481,8 @@ static void vfio_unmap_bars(VFIOPCIDevice *vdev) */ static u

[Qemu-devel] [RFC v9 01/18] vfio: extract vfio_get_hot_reset_info as a single function

2015-06-08 Thread Chen Fan
the function is used to get affected devices by bus reset. so here extract it, and can used for aer soon. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 66 +++ 1 file changed, 48 insertions(+), 18 deletions(-) diff --git a/hw/vfio/pci.c b/hw

[Qemu-devel] [RFC v9 00/18] vfio-pci: pass the aer error to guest

2015-06-08 Thread Chen Fan
For now, for vfio pci passthough devices when qemu receives an error from host aer report, there just terminate the guest, but usually user want to know what error occurred but stop the guest, so this patches add aer capability support for vfio device, and pass the error to guest, and have guest dr

[Qemu-devel] [PATCH] pc: cleanup and convert TMP ACPI device description to AML API

2015-06-08 Thread Igor Mammedov
remove some code duplication in acpi-build.c and drop 5 ASL and binary blobs files with TPM ACPI device description, replacing them with 1 small hunk written in AML API. Signed-off-by: Igor Mammedov --- hw/i386/Makefile.objs | 3 +- hw/i386/acpi-build.c| 40 ++---

[Qemu-devel] [PATCH] hw/arm/virt-acpi-build: Fix table revision and some comments

2015-06-08 Thread Shannon Zhao
From: Shannon Zhao The table revision is not the ACPI spec version. Fix the wrong revision and also some comments. Signed-off-by: Shannon Zhao --- hw/arm/virt-acpi-build.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acp

Re: [Qemu-devel] [PATCH COLO-Frame v5 25/29] COLO: Add colo-set-checkpoint-period command

2015-06-08 Thread zhanghailiang
On 2015/6/6 2:45, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: With this command, we can control the period of checkpoint, if there is no comparison of net packets. This should use the MigrationParameter stuff that's gone into qemu recently; in my local

Re: [Qemu-devel] [PATCH 2/2] hw/arm/virt-acpi-build: Add SPCR table

2015-06-08 Thread Shannon Zhao
On 2015/6/8 22:00, Andrew Jones wrote: > Signed-off-by: Andrew Jones > --- > hw/arm/virt-acpi-build.c | 44 +++- > 1 file changed, 43 insertions(+), 1 deletion(-) > > diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c > index a9373ccaca6cb.

Re: [Qemu-devel] [PATCH v2] net: Add support of VIRTIO_NET_F_GUEST_ANNOUNCE for vhost-net/vhost-user

2015-06-08 Thread Jason Wang
On 06/09/2015 12:13 AM, Michael S. Tsirkin wrote: > On Mon, Jun 08, 2015 at 04:13:59PM +0100, Stefan Hajnoczi wrote: >> On Mon, Jun 8, 2015 at 3:05 PM, Thibaut Collet >> wrote: I think Jason is pointing out that your patch lacks support for guests that do not negotiate VIRTIO_NET_F_GU

Re: [Qemu-devel] "iothread: release iothread around aio_poll" causes random hangs at startup

2015-06-08 Thread Fam Zheng
On Tue, 06/02 16:36, Christian Borntraeger wrote: > Paolo, > > I bisected > commit a0710f7995f914e3044e5899bd8ff6c43c62f916 > Author: Paolo Bonzini > AuthorDate: Fri Feb 20 17:26:52 2015 +0100 > Commit: Kevin Wolf > CommitDate: Tue Apr 28 15:36:08 2015 +0200 > > iothread: release i

Re: [Qemu-devel] Cant make the IPMI simulator work, help needed.

2015-06-08 Thread Corey Minyard
On 06/08/2015 12:24 AM, RamakrishnaDeepak Battu wrote: > Thank you Corey. > > I haven't noticed the port 623, I changed it. > > If I ran this command alone: > /usr/local/bin/qemu-system-x86_64 --enable-kvm -nographic -net > nic,model=e1000,macaddr=52:54:00:12:34:59 -net > user,hostfwd=tcp::-

Re: [Qemu-devel] [PATCH COLO-Frame v5 11/29] COLO VMstate: Load VM state into qsb before restore it

2015-06-08 Thread zhanghailiang
On 2015/6/6 2:02, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: We should cache the device state before restore it, besides, we should call qemu_system_reset() before load VM state, which can ensure the data is intact. I think the description could be be

[Qemu-devel] [PATCH 6/6] iotests: Add test cases for blockdev-mirror

2015-06-08 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/qemu-iotests/041 | 100 +++-- tests/qemu-iotests/041.out | 4 +- 2 files changed, 80 insertions(+), 24 deletions(-) diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041 index 59a8f73..922f53c 100755 --- a/te

[Qemu-devel] [PATCH 5/6] qmp: Add blockdev-mirror command

2015-06-08 Thread Fam Zheng
This will start a mirror job from a named device to another named device, its relation with drive-mirror is similar with blockdev-backup to drive-backup. In blockdev-mirror, the target node should be prepared by blockdev-add, which will be responsible for assigning a name to the new node, so 'node

[Qemu-devel] [PATCH 4/6] block: Add check on mirror target

2015-06-08 Thread Fam Zheng
Signed-off-by: Fam Zheng --- blockdev.c| 3 +++ include/block/block.h | 1 + 2 files changed, 4 insertions(+) diff --git a/blockdev.c b/blockdev.c index c32a9a9..44030da 100644 --- a/blockdev.c +++ b/blockdev.c @@ -2929,6 +2929,9 @@ static void blockdev_mirror_common(BlockDriverState

[Qemu-devel] [PATCH 2/6] block: Rename BLOCK_OP_TYPE_MIRROR to BLOCK_OP_TYPE_MIRROR_SOURCE

2015-06-08 Thread Fam Zheng
It's necessary to distinguish source and target before we can add blockdev-mirror, because we would want a concrete type of operation to check on target bs before starting. Signed-off-by: Fam Zheng --- blockdev.c | 2 +- hw/block/dataplane/virtio-blk.c | 2 +- include/block/

[Qemu-devel] [PATCH 3/6] block: Extract blockdev part of qmp_drive_mirror

2015-06-08 Thread Fam Zheng
This is the part that will be reused by blockdev-mirror. Signed-off-by: Fam Zheng --- blockdev.c | 158 +++-- 1 file changed, 92 insertions(+), 66 deletions(-) diff --git a/blockdev.c b/blockdev.c index b573e56..c32a9a9 100644 --- a/blockd

[Qemu-devel] [PATCH 0/6] qmp: Add blockdev-mirror

2015-06-08 Thread Fam Zheng
This is the counterpart of blockdev-backup. The biggest value of this command is to allow full flexibility on target image open options, via blockdev-add. For example this could help solve the target provisioning issue in: http://lists.gnu.org/archive/html/qemu-devel/2015-06/msg02139.html Because

[Qemu-devel] [PATCH 1/6] block: Add blocker on mirror target

2015-06-08 Thread Fam Zheng
In block/backup.c, we already check and add blocker on the target bs, which is necessary so that it won't be intervened with other operations. In block/mirror.c we should also protect the mirror target bs, because it could have a node-name (drive-mirror ... node-name=XXX), and on top of that it's

Re: [Qemu-devel] [PATCH 0/6] pci/isa: QOMify

2015-06-08 Thread Gonglei
On 2015/6/1 19:31, Paolo Bonzini wrote: > > > On 01/06/2015 12:25, Michael S. Tsirkin wrote: Hi, Michael, Paolo Can you please ack or review those patches? Regards, -Gonglei >> I think this belongs in the QOM tree, not mine. > > Recently Gerd at least has taken simi

Re: [Qemu-devel] QEMU's CVE Procedures

2015-06-08 Thread Gonglei
On 2015/6/8 21:07, Daniel P. Berrange wrote: > On Mon, Jun 08, 2015 at 08:44:25PM +0800, Gonglei wrote: >> On 2015/6/6 6:16, John Snow wrote: >>> (6) What about qemu-stable? >>> >>> Our stable process is somewhat lacking with respect to the CVE >>> process. It is good that we occasionally publish s

[Qemu-devel] [PATCH v3 02/16] ipmi: Add a local BMC simulation

2015-06-08 Thread minyard
From: Corey Minyard This provides a minimal local BMC, basically enough to comply with the spec and provide a complete watchdog timer (including a sensor, SDR, and event). Signed-off-by: Corey Minyard --- default-configs/i386-softmmu.mak |1 + default-configs/x86_64-softmmu.mak |1 +

[Qemu-devel] [PATCH v3 03/16] ipmi: Add an external connection simulation interface

2015-06-08 Thread minyard
From: Corey Minyard This adds an interface for IPMI that connects to a remote BMC over a chardev (generally a TCP socket). The OpenIPMI lanserv simulator describes this interface, see that for interface details. Signed-off-by: Corey Minyard --- default-configs/i386-softmmu.mak | 1 + defa

[Qemu-devel] [PATCH v3 04/16] ipmi: Add an ISA KCS low-level interface

2015-06-08 Thread minyard
From: Corey Minyard This provides the simulation of the KCS hardware interface. Signed-off-by: Corey Minyard --- default-configs/i386-softmmu.mak | 1 + default-configs/x86_64-softmmu.mak | 1 + hw/ipmi/Makefile.objs | 1 + hw/ipmi/isa_ipmi_kcs.c | 452

[Qemu-devel] [PATCH v3 00/16] Add an IPMI device to QEMU

2015-06-08 Thread minyard
I have reworked the QEMU IPMI patches, and I believe this design improves greatly on the previous one. The suggestions made all resulted in better design. To start an IPMI interface with this, you would use: -device ipmi-bmc-sim,id=bmc0 -device isa-ipmi-bt,bmc=bmc0 Note that I did not make th

[Qemu-devel] [PATCH v3 05/16] ipmi: Add a BT low-level interface

2015-06-08 Thread minyard
From: Corey Minyard This provides the simulation of the BT hardware interface for IPMI. Signed-off-by: Corey Minyard --- default-configs/i386-softmmu.mak | 1 + default-configs/x86_64-softmmu.mak | 1 + hw/ipmi/Makefile.objs | 1 + hw/ipmi/isa_ipmi_bt.c | 489

[Qemu-devel] [PATCH v3 01/16] Add a base IPMI interface

2015-06-08 Thread minyard
From: Corey Minyard Add the basic IPMI types and infrastructure to QEMU. Low-level interfaces and simulation interfaces will register with this; it's kind of the go-between to tie them together. Signed-off-by: Corey Minyard --- default-configs/i386-softmmu.mak | 1 + default-configs/x86_6

[Qemu-devel] [PATCH v3 06/16] ipmi: Add tests

2015-06-08 Thread minyard
From: Corey Minyard Test the KCS interface with a local BMC and a BT interface with an external BMC. Signed-off-by: Corey Minyard --- tests/Makefile| 4 + tests/ipmi-bt-test.c | 441 ++ tests/ipmi-kcs-test.c | 295 +

[Qemu-devel] [PATCH v3 11/16] smbios: Add a function to directly add an entry

2015-06-08 Thread minyard
From: Corey Minyard There was no way to directly add a table entry to the SMBIOS table, even though the BIOS supports this. So add a function to do this. This is in preparation for the IPMI handler adding it's SMBIOS table entry. Signed-off-by: Corey Minyard --- hw/i386/smbios.c | 153

[Qemu-devel] [PATCH v3 13/16] ipmi: Add SMBIOS table entry

2015-06-08 Thread minyard
From: Corey Minyard Add an IPMI table entry to the SMBIOS. Signed-off-by: Corey Minyard Acked-by: Michael S. Tsirkin --- default-configs/i386-softmmu.mak | 1 + default-configs/x86_64-softmmu.mak | 1 + hw/ipmi/Makefile.objs | 1 + hw/ipmi/ipmi_smbios.c | 89 +++

[Qemu-devel] [PATCH v3 15/16] ipmi: Add ACPI table entries

2015-06-08 Thread minyard
From: Corey Minyard Use the new ACPI table construction tools to create an ACPI entry for IPMI. Signed-off-by: Corey Minyard Acked-by: Michael S. Tsirkin --- hw/ipmi/Makefile.objs | 1 + hw/ipmi/ipmi_acpi.c | 122 ++ 2 files changed, 123 ins

[Qemu-devel] [PATCH v3 14/16] acpi: Add a way for devices to add ACPI tables

2015-06-08 Thread minyard
From: Corey Minyard Some devices, like IPMI, need to add ACPI table entries to report their presence. Add a method for adding these entries. Signed-off-by: Corey Minyard --- hw/acpi/Makefile.objs | 1 + hw/acpi/acpi-dev-tables.c | 80 ++

[Qemu-devel] [PATCH v3 08/16] ipmi: Add migration capability to the IPMI devices.

2015-06-08 Thread minyard
From: Corey Minyard Signed-off-by: Corey Minyard --- hw/ipmi/ipmi_bmc_extern.c | 34 ++ hw/ipmi/ipmi_bmc_sim.c| 30 ++ hw/ipmi/isa_ipmi_bt.c | 24 hw/ipmi/isa_ipmi_kcs.c| 26

[Qemu-devel] [PATCH v3 16/16] bios: Add tests for the IPMI ACPI and SMBIOS entries

2015-06-08 Thread minyard
From: Corey Minyard Signed-off-by: Corey Minyard --- tests/bios-tables-test.c | 114 --- 1 file changed, 109 insertions(+), 5 deletions(-) diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c index 735ac61..8266d5e 100644 --- a/tests/bios

[Qemu-devel] [PATCH v3 07/16] ipmi: Add documentation

2015-06-08 Thread minyard
From: Corey Minyard Add some basic documentation for the IPMI device. Signed-off-by: Corey Minyard --- qemu-options.hx | 52 1 file changed, 52 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index 319d971..f2bc344 100644 --- a

[Qemu-devel] [PATCH v3 09/16] ipmi: Add a firmware configuration repository

2015-06-08 Thread minyard
From: Corey Minyard Add a way for IPMI devices to register their firmware information with the IPMI subsystem so that various firmware entities can pull that information later for adding to firmware tables. Signed-off-by: Corey Minyard --- hw/ipmi/ipmi.c | 25 +

[Qemu-devel] [PATCH v3 12/16] pc: Postpone SMBIOS table installation to post machine init

2015-06-08 Thread minyard
From: Corey Minyard This is the same place that the ACPI SSDT table gets added, so that devices can add themselves to the SMBIOS table. Signed-off-by: Corey Minyard --- hw/i386/pc.c | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/hw/i38

[Qemu-devel] [PATCH v3 10/16] ipmi: Add firmware registration to the ISA interface

2015-06-08 Thread minyard
From: Corey Minyard Signed-off-by: Corey Minyard --- hw/ipmi/isa_ipmi_bt.c | 15 +++ hw/ipmi/isa_ipmi_kcs.c | 15 +++ 2 files changed, 30 insertions(+) diff --git a/hw/ipmi/isa_ipmi_bt.c b/hw/ipmi/isa_ipmi_bt.c index 03eb9cc..6696da9 100644 --- a/hw/ipmi/isa_ipmi_bt.c

Re: [Qemu-devel] [PATCH v3 23/38] blockdev: Pull out blockdev option extraction

2015-06-08 Thread Fam Zheng
On Wed, 06/03 21:44, Max Reitz wrote: > Extract some of the blockdev option extraction code from blockdev_init() > into its own function. This simplifies blockdev_init() and will allow > reusing the code in a different function added in a follow-up patch. > > Signed-off-by: Max Reitz > Reviewed-b

[Qemu-devel] [PATCH v5 1/2] OvmfPkg/PlatformPei: Query Host Bridge DID only once

2015-06-08 Thread Paulo Alcantara
Make HostBridgeDevId global so MemMapInitialization() can also use it to conditionally add RCRB MMIO address to HOB. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Paulo Alcantara --- OvmfPkg/PlatformPei/Platform.c | 17 +++-- 1 file changed, 11 insertions(+),

[Qemu-devel] [PATCH v5 2/2] OvmfPkg/PlatformPei: Initialise RCBA (B0:D31:F0 0xf0) register

2015-06-08 Thread Paulo Alcantara
This patch initialises root complex register block BAR in order to support TCO watchdog emulation features (e.g. reboot upon NO_REBOOT bit not set) on QEMU. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Paulo Alcantara --- OvmfPkg/Include/IndustryStandard/Q35MchIch9.h |

Re: [Qemu-devel] [PATCH v2 0/4] acpi: xsdt support

2015-06-08 Thread Laszlo Ersek
On 06/08/15 20:14, Michael S. Tsirkin wrote: > XSDT support allows using ACPI 2 features while > avoiding breaking legacy windows XP guests: > ACPI 2 tables are linked from XSDT only, > ACPI 1 tables from both RSDT and XSDT, this way > XP does not see ACPI 2 tables. > > As a first step, this patch

Re: [Qemu-devel] [edk2] [PATCH v3] OvmfPkg/PlatformPei: Initialise RCBA (B0:D31:F0 0xf0) register

2015-06-08 Thread Laszlo Ersek
On 06/09/15 01:30, Paulo Alcantara wrote: > On Tue, 09 Jun 2015 01:09:19 +0200 > Laszlo Ersek wrote: > >> On 06/09/15 00:49, Jordan Justen wrote: >>> On 2015-06-08 15:07:13, Paulo Alcantara wrote: This patch initialises root complex register block BAR in order to support TCO watchdog em

Re: [Qemu-devel] [edk2] [PATCH v3] OvmfPkg/PlatformPei: Initialise RCBA (B0:D31:F0 0xf0) register

2015-06-08 Thread Paulo Alcantara
On Tue, 09 Jun 2015 01:09:19 +0200 Laszlo Ersek wrote: > On 06/09/15 00:49, Jordan Justen wrote: > > On 2015-06-08 15:07:13, Paulo Alcantara wrote: > >> This patch initialises root complex register block BAR in order to > >> support TCO watchdog emulation features (e.g. reboot upon > >> NO_REBOOT

[Qemu-devel] [PATCH v2 2/9] target-microblaze: Convert use-mmu to a CPU property

2015-06-08 Thread Peter Crosthwaite
From: Alistair Francis Originally the use-mmu PVR bits were manually set for each machine. This is a hassle and difficult to read, instead set them based on the CPU properties. Signed-off-by: Alistair Francis --- V2: - Fix up variable name target-microblaze/cpu-qom.h |1 + target-microbl

[Qemu-devel] [PATCH v2 3/9] target-microblaze: Convert dcache-writeback to a CPU property

2015-06-08 Thread Peter Crosthwaite
From: Alistair Francis Originally the dcache-writeback PVR bits were manually set for each machine. This is a hassle and difficult to read, instead set them based on the CPU properties. Signed-off-by: Alistair Francis Reviewed-by: Edgar E. Iglesias --- hw/microblaze/petalogix_ml605_mmu.c |

[Qemu-devel] [PATCH] macio: remove nonexistent interrupt on pin 1

2015-06-08 Thread Cormac O'Brien
The current macio device implementation declares an interrupt that doesn't seem to exist in the actual hardware or any other emulators. Mac OS 9 counts the presence of this interrupt as a fatal error and progresses further without it. Signed-off-by: Cormac O'Brien --- hw/misc/macio/macio.c | 2

Re: [Qemu-devel] [edk2] [PATCH v3] OvmfPkg/PlatformPei: Initialise RCBA (B0:D31:F0 0xf0) register

2015-06-08 Thread Laszlo Ersek
On 06/09/15 00:49, Jordan Justen wrote: > On 2015-06-08 15:07:13, Paulo Alcantara wrote: >> This patch initialises root complex register block BAR in order to >> support TCO watchdog emulation features (e.g. reboot upon NO_REBOOT bit >> not set) on QEMU. >> >> Contributed-under: TianoCore Contribut

Re: [Qemu-devel] [edk2] [PATCH v3] OvmfPkg/PlatformPei: Initialise RCBA (B0:D31:F0 0xf0) register

2015-06-08 Thread Jordan Justen
On 2015-06-08 15:07:13, Paulo Alcantara wrote: > This patch initialises root complex register block BAR in order to > support TCO watchdog emulation features (e.g. reboot upon NO_REBOOT bit > not set) on QEMU. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Paulo Alcan

Re: [Qemu-devel] [PATCH v4] OvmfPkg/PlatformPei: Initialise RCBA (B0:D31:F0 0xf0) register

2015-06-08 Thread Laszlo Ersek
On 06/09/15 00:42, Paulo Alcantara wrote: > This patch initialises root complex register block BAR in order to > support TCO watchdog emulation features (e.g. reboot upon NO_REBOOT bit > not set) on QEMU. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Paulo Alcantara

[Qemu-devel] [PATCH v4] OvmfPkg/PlatformPei: Initialise RCBA (B0:D31:F0 0xf0) register

2015-06-08 Thread Paulo Alcantara
This patch initialises root complex register block BAR in order to support TCO watchdog emulation features (e.g. reboot upon NO_REBOOT bit not set) on QEMU. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Paulo Alcantara --- OvmfPkg/Include/IndustryStandard/Q35MchIch9.h |

Re: [Qemu-devel] [PATCH v3] OvmfPkg/PlatformPei: Initialise RCBA (B0:D31:F0 0xf0) register

2015-06-08 Thread Laszlo Ersek
On 06/09/15 00:07, Paulo Alcantara wrote: > This patch initialises root complex register block BAR in order to > support TCO watchdog emulation features (e.g. reboot upon NO_REBOOT bit > not set) on QEMU. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Paulo Alcantara

[Qemu-devel] [PATCH v3] OvmfPkg/PlatformPei: Initialise RCBA (B0:D31:F0 0xf0) register

2015-06-08 Thread Paulo Alcantara
This patch initialises root complex register block BAR in order to support TCO watchdog emulation features (e.g. reboot upon NO_REBOOT bit not set) on QEMU. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Paulo Alcantara --- OvmfPkg/Include/IndustryStandard/Q35MchIch9.h |

Re: [Qemu-devel] armv7m/stm32f205 not starting if code linked from 0x08000000

2015-06-08 Thread Liviu Ionescu
> On 09 Jun 2015, at 00:39, Peter Maydell wrote: > > Right, but only for your debugger. yes, but this is consistent with other debuggers, my debug plug-ins use the same strategy for j-link and openocd too, i.e. after flashing a new image a reset is issued, to be sure that execution starts whe

Re: [Qemu-devel] armv7m/stm32f205 not starting if code linked from 0x08000000

2015-06-08 Thread Peter Maydell
On 8 June 2015 at 20:35, Liviu Ionescu wrote: > >> On 08 Jun 2015, at 22:27, Peter Maydell wrote: >> >> That would also fix this problem, yes. It would still leave one >> use case wrong: >> * start QEMU >> * [cpu reset happens here; we load sp/pc] >> * in the debugger load an image (with a vector

Re: [Qemu-devel] [PATCH] OvmfPkg/PlatformPei: Initialise RCBA (B0:D31:F0 0xf0) register

2015-06-08 Thread Paulo Alcantara
On Mon, 08 Jun 2015 11:06:40 +0200 Laszlo Ersek wrote: > On 06/06/15 21:10, Paulo Alcantara wrote: > > This patch initialises root complex register block BAR in order to > > support TCO watchdog emulation features (e.g. reboot upon NO_REBOOT > > bit not set) on QEMU. > > > > Contributed-under: T

[Qemu-devel] [PATCH v2 4/4] xen: Fix map/unmap of pcidev to ioreq server

2015-06-08 Thread Don Slutz
The commit 707ff80021ccd7a68f4b3d2c44eebf87efbb41c4 added usage of xc_hvm_map_pcidev_from_ioreq_server() and xc_hvm_unmap_pcidev_from_ioreq_server(). These routines only correctly work if the PCI BDF of a PCI device is unique. The 3 parts (bus, device, and function) of a PCI BDF are not required

[Qemu-devel] [PATCH v2 2/4] Extend device listener interface for PCI to PCI bridges

2015-06-08 Thread Don Slutz
The commit 707ff80021ccd7a68f4b3d2c44eebf87efbb41c4 assumed that a PCI device has a static address. This is not true for PCI devices that are on the secondary bus of a PCI to PCI bridge. BIOS and/or guest OS can change the secondary bus number to a new value at any time. Extend the device listen

[Qemu-devel] [PATCH v2 3/4] xen: Add usage of device listener interface for PCI to PCI bridges

2015-06-08 Thread Don Slutz
Signed-off-by: Don Slutz CC: Don Slutz --- include/hw/xen/xen_common.h | 10 ++ xen-hvm.c | 13 - 2 files changed, 18 insertions(+), 5 deletions(-) diff --git a/include/hw/xen/xen_common.h b/include/hw/xen/xen_common.h index 38f29fb..6579b78 100644 --- a/in

[Qemu-devel] [PATCH v2 0/4] Fix device listener interface for PCI to PCI bridges

2015-06-08 Thread Don Slutz
changes v1 to v2: Split v1 patch into 3. Added a BUG FIX patch (#1: "exec: Do not use MemoryRegion after free"). Technically this bug fix should be a separate patch, however this issue only seems to reproduce when this patch set is applied. Michael S. Tsirkin: "You need some

[Qemu-devel] [BUGFIX][PATCH v2 1/4] exec: Do not use MemoryRegion after free

2015-06-08 Thread Don Slutz
Here is gdb output that shows this happening: Breakpoint 3, object_finalize (data=0x7fdf32a14010) at qom/object.c:417 417 obj->free(obj); (gdb) bt #0 object_finalize (data=0x7fdf32a14010) at qom/object.c:417 #1 0x007329d4 in object_unref (obj=0x7fdf32a14010) at qom

Re: [Qemu-devel] [PATCH] block: record new size in bdrv_dirty_bitmap_truncate

2015-06-08 Thread Eric Blake
On 06/08/2015 02:49 PM, John Snow wrote: > ce1ffea8 neglected to update the BdrvDirtyBitmap structure > itself for internal consistency. It's currently not an issue, > but for migration and persistence series this will cause headaches. > > Signed-off-by: John Snow > --- > block.c | 1 + > 1 file

Re: [Qemu-devel] [edk2] [PATCH] OvmfPkg/PlatformPei: Initialise RCBA (B0:D31:F0 0xf0) register

2015-06-08 Thread Laszlo Ersek
On 06/08/15 21:07, Jordan Justen wrote: > On 2015-06-08 02:06:40, Laszlo Ersek wrote: >> On 06/06/15 21:10, Paulo Alcantara wrote: >>> diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec >>> index 4cb70dc..a6586f3 100644 >>> --- a/OvmfPkg/OvmfPkg.dec >>> +++ b/OvmfPkg/OvmfPkg.dec >>> @@ -78,6 +7

[Qemu-devel] [Bug 1463143] [NEW] Kernel Panic on Guest VM

2015-06-08 Thread ryan
Public bug reported: Hi, I've recently attempted to move a stack to qemu vm's that I have run successfully on both hard metal and ec2. I'm not sure where to even begin debugging, could someone please point me in the right direction? [781785.483343] RIP: 0010:[] [] ata_sff_hsm_move+0x1b0/0x

Re: [Qemu-devel] armv7m/stm32f205 not starting if code linked from 0x08000000

2015-06-08 Thread Liviu Ionescu
> On 08 Jun 2015, at 22:27, Peter Maydell wrote: > > On 8 June 2015 at 20:18, Liviu Ionescu wrote: >> >> aha, in this case the problem is the two step load, not the reset itself, >> or even more accurate, it is a problem of making the reset calls in the >> proper order. > > That would also fi

  1   2   3   4   5   >