[Qemu-devel] [Bug 1458121] [NEW] USB2 is five times slower than native on qemu-kvm

2015-05-22 Thread Toddandmargo-n
Public bug reported: Dear Qemu, Spice told me to report this over here. Scientific Linux 6.6 $ uname -r 2.6.32-504.16.2.el6.x86_64 $ cat /etc/redhat-release Scientific Linux release 6.6 (Carbon) $ rpm -qa qemu\* qemu-img-0.12.1.2-2.448.el6_6.3.x86_64 qemu-kvm-0.12.1.2-2.448.el6_6.3.x86_64 I

Re: [Qemu-devel] Announcing qboot, a minimal x86 firmware for QEMU

2015-05-22 Thread Kevin O'Connor
On Fri, May 22, 2015 at 07:23:27PM -0400, Kevin O'Connor wrote: > On Thu, May 21, 2015 at 03:51:43PM +0200, Paolo Bonzini wrote: > > Some of you may have heard about the "Clear Containers" initiative from > > Intel, which couple KVM with various kernel tricks to create extremely > > lightweight vir

Re: [Qemu-devel] [RFC/RFT PATCH v2 1/3] arm/arm64: pageattr: add set_memory_nc

2015-05-22 Thread Mario Smarduch
On 05/18/2015 08:53 AM, Catalin Marinas wrote: > On Thu, May 14, 2015 at 02:46:44PM +0100, Andrew Jones wrote: >> On Thu, May 14, 2015 at 01:05:09PM +0200, Christoffer Dall wrote: >>> On Wed, May 13, 2015 at 01:31:52PM +0200, Andrew Jones wrote: Provide a method to change normal, cacheable mem

Re: [Qemu-devel] [PATCH 22/23] userfaultfd: avoid mmap_sem read recursion in mcopy_atomic

2015-05-22 Thread Andrea Arcangeli
On Fri, May 22, 2015 at 02:18:30PM -0700, Andrew Morton wrote: > > There's a more serious failure with i386 allmodconfig: > > fs/userfaultfd.c:145:2: note: in expansion of macro 'BUILD_BUG_ON' > BUILD_BUG_ON(sizeof(struct uffd_msg) != 32); > > I'm surprised the feature is even reachable on i38

Re: [Qemu-devel] Announcing qboot, a minimal x86 firmware for QEMU

2015-05-22 Thread Kevin O'Connor
On Thu, May 21, 2015 at 03:51:43PM +0200, Paolo Bonzini wrote: > Some of you may have heard about the "Clear Containers" initiative from > Intel, which couple KVM with various kernel tricks to create extremely > lightweight virtual machines. The experimental Clear Containers setup > requires only

Re: [Qemu-devel] How Qemu timer interrupts code emulation?

2015-05-22 Thread Bastian Koppelmann
On 05/22/2015 06:26 PM, Nguyen Anh Quynh wrote: On Sat, May 23, 2015 at 12:13 AM, Peter Maydell mailto:peter.mayd...@linaro.org>> wrote: On 22 May 2015 at 16:36, Jun Koi mailto:junkoi2...@gmail.com>> wrote: > In general, we would have timer & code execution run in parallel, No

Re: [Qemu-devel] [PATCH 19/20] monitor: Rename monitor_ctrl_mode() to monitor_is_qmp()

2015-05-22 Thread Eric Blake
On 05/22/2015 05:36 AM, Markus Armbruster wrote: > ... and change return type to bool. > > Signed-off-by: Markus Armbruster > --- > monitor.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) > See also my review on 16 about a usage in monitor_init(). Reviewed-by: Eric Blak

Re: [Qemu-devel] [PATCH 20/20] monitor: Change return type of monitor_cur_is_qmp() to bool

2015-05-22 Thread Eric Blake
On 05/22/2015 05:36 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > include/monitor/monitor.h | 2 +- > monitor.c | 6 -- > stubs/mon-is-qmp.c| 2 +- > 3 files changed, 6 insertions(+), 4 deletions(-) > > +++ b/stubs/mon-is-qmp.c > @@ -1,7 +1,

Re: [Qemu-devel] [PATCH 18/20] monitor: Turn int command_mode into bool in_command_mode

2015-05-22 Thread Eric Blake
On 05/22/2015 05:36 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > monitor.c | 23 --- > 1 file changed, 12 insertions(+), 11 deletions(-) > Might be worth mentioning in the commit message that... > > -static inline int qmp_cmd_mode(const Monitor

Re: [Qemu-devel] [PATCH 17/20] monitor: Drop do_qmp_capabilities()'s superfluous QMP check

2015-05-22 Thread Eric Blake
On 05/22/2015 05:36 AM, Markus Armbruster wrote: > Superfluous since commit 30f5041 removed it from HMP. > > Signed-off-by: Markus Armbruster > --- > monitor.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301

Re: [Qemu-devel] [PATCH 16/20] monitor: Unbox Monitor member mc and rename to qmp

2015-05-22 Thread Eric Blake
On 05/22/2015 05:36 AM, Markus Armbruster wrote: > While there, rename its type as well, from MonitorControl to > MonitorQMP. > > Signed-off-by: Markus Armbruster > --- > monitor.c | 35 --- > 1 file changed, 16 insertions(+), 19 deletions(-) > > @@ -5255,14 +52

Re: [Qemu-devel] [PATCH 1/4] iotests: fix exclusion option

2015-05-22 Thread John Snow
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 05/22/2015 04:31 PM, Eric Blake wrote: > On 05/22/2015 02:17 PM, John Snow wrote: >> If you are running out-of-tree, the -x option to exclude a >> certain iotest is broken. >> >> Replace porcelain usage of ls with a sturdier grep command. >> >

Re: [Qemu-devel] [PATCH 15/20] monitor: Rename monitor_control_read(), monitor_control_event()

2015-05-22 Thread Eric Blake
On 05/22/2015 05:36 AM, Markus Armbruster wrote: > ... to monitor_qmp_read(), monitor_qmp_event(). > > Signed-off-by: Markus Armbruster > --- > monitor.c | 14 -- > 1 file changed, 4 insertions(+), 10 deletions(-) Not a trivial rename based on diffstat, but... > > diff --git a/mon

Re: [Qemu-devel] [PATCH 14/20] monitor: Rename handle_user_command() to handle_hmp_command()

2015-05-22 Thread Eric Blake
On 05/22/2015 05:36 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > monitor.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvir

Re: [Qemu-devel] [PATCH 13/20] monitor: Limit QError use to command handlers

2015-05-22 Thread Eric Blake
On 05/22/2015 05:36 AM, Markus Armbruster wrote: > The previous commits narrowed use of QError to handle_qmp_command() > and its helpers monitor_protocol_emitter(), build_qmp_error_dict(). > Narrow it further to just the command handler call: instead of > converting Error to QError throughout handl

Re: [Qemu-devel] [PATCH v4 06/11] block: add refcount to Job object

2015-05-22 Thread John Snow
On 05/20/2015 05:27 AM, Stefan Hajnoczi wrote: > On Tue, May 19, 2015 at 06:15:23PM -0400, John Snow wrote: >> On 05/18/2015 11:45 AM, Stefan Hajnoczi wrote: >>> On Mon, May 11, 2015 at 07:04:21PM -0400, John Snow wrote: If we want to get at the job after the life of the job, we'll need

Re: [Qemu-devel] [PATCH 12/20] monitor: Inline monitor_has_error() into its only caller

2015-05-22 Thread Eric Blake
On 05/22/2015 05:36 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > monitor.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/monitor.c b/monitor.c > index c732203..71ca03f 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -377,11 +377,6 @@ st

Re: [Qemu-devel] [PATCH 11/20] monitor: Wean monitor_protocol_emitter() off mon->error

2015-05-22 Thread Eric Blake
On 05/22/2015 05:36 AM, Markus Armbruster wrote: > Move mon->error handling to its caller handle_qmp_command(). > > Signed-off-by: Markus Armbruster > --- > monitor.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake eblake redha

Re: [Qemu-devel] [PATCH 10/20] monitor: Propagate errors through qmp_check_input_obj()

2015-05-22 Thread Eric Blake
On 05/22/2015 05:36 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > monitor.c | 19 ++- > 1 file changed, 10 insertions(+), 9 deletions(-) > > @@ -4948,27 +4948,27 @@ static QDict *qmp_check_input_obj(QObject *input_obj) > } > } els

Re: [Qemu-devel] [PATCH 09/20] monitor: Propagate errors through qmp_check_client_args()

2015-05-22 Thread Eric Blake
On 05/22/2015 05:36 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > monitor.c | 65 > --- > 1 file changed, 33 insertions(+), 32 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1

Re: [Qemu-devel] [PATCH 08/20] monitor: Drop unused "new" HMP command interface

2015-05-22 Thread Eric Blake
On 05/22/2015 05:36 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > monitor.c | 22 +- > 1 file changed, 1 insertion(+), 21 deletions(-) > Goodbye! Nice knowing you! (For how many incomplete conversions we have scattered throughout the tree, it's in

Re: [Qemu-devel] [PATCH 07/20] monitor: Use trad. command interface for HMP pcie_aer_inject_error

2015-05-22 Thread Eric Blake
On 05/22/2015 05:36 AM, Markus Armbruster wrote: > All QMP commands use the "new" handler interface (mhandler.cmd_new). > Most HMP commands still use the traditional interface (mhandler.cmd), > but a few use the "new" one. Complicates handle_user_command() for no > gain, so I'm converting these to

Re: [Qemu-devel] [PATCH] arch_init: Use stateless configuration for default target_${target}.conf

2015-05-22 Thread Eric Blake
On 05/22/2015 09:42 AM, Ikey Doherty wrote: meta-comment: > 1.9.1 > > - > Intel Corporation (UK) Limited > Registered No. 1134945 (England) > Registered Office: Pipers Way, Swindon SN3 1RJ > VAT No: 860 2173 47 > > This e-mail

Re: [Qemu-devel] [PATCH 06/20] monitor: Use traditional command interface for HMP device_add

2015-05-22 Thread Eric Blake
On 05/22/2015 05:36 AM, Markus Armbruster wrote: > All QMP commands use the "new" handler interface (mhandler.cmd_new). > Most HMP commands still use the traditional interface (mhandler.cmd), > but a few use the "new" one. Complicates handle_user_command() for no > gain, so I'm converting these to

Re: [Qemu-devel] [PATCH 22/23] userfaultfd: avoid mmap_sem read recursion in mcopy_atomic

2015-05-22 Thread Andrea Arcangeli
On Fri, May 22, 2015 at 01:18:22PM -0700, Andrew Morton wrote: > On Thu, 14 May 2015 19:31:19 +0200 Andrea Arcangeli > wrote: > > > If the rwsem starves writers it wasn't strictly a bug but lockdep > > doesn't like it and this avoids depending on lowlevel implementation > > details of the lock.

Re: [Qemu-devel] ABNT2 keys again

2015-05-22 Thread Joao Luis Meloni Assirati
>> > Anyone having such a keyboard and willing to run some tests? [...] > (c) Then use 'input-events ' to get a input event log > printed to the terminal. Type each missing key once. > > (d) Send me the log (with annotation which key is which). There are two missing keys: / (which is also ?

Re: [Qemu-devel] How Qemu timer interrupts code emulation?

2015-05-22 Thread Nguyen Anh Quynh
On Sat, May 23, 2015 at 12:13 AM, Peter Maydell wrote: > On 22 May 2015 at 16:36, Jun Koi wrote: > > In general, we would have timer & code execution run in parallel, > > No code has to actually run when there's an active timer; > the event loop thread mostly sits blocked waiting for > something

Re: [Qemu-devel] ABNT2 keys again

2015-05-22 Thread Joao Luis Meloni Assirati
> 22.05.2015 13:01, Gerd Hoffmann wrote: [...] The solution appears to be trivial (see also some background at http://blog.nielshorn.net/2011/03/qemu-and-brazilian-keyboards/ ), but the problem is definitely still here. This is the patch that works: --- ui/x_keymap.c~ +++ ui/x_ke

[Qemu-devel] [PATCH] arch_init: Use stateless configuration for default target_${target}.conf

2015-05-22 Thread Ikey Doherty
The goal of stateless, and thus this change, is to separate OS configuration from system administrator configuration. With this change we will read the default configuration data from /usr/share/defaults/qemu, in the absence of an overriding site administrator configuration in /etc/qemu. A key adv

Re: [Qemu-devel] [PATCH 05/20] monitor: Use traditional command interface for HMP drive_del

2015-05-22 Thread Eric Blake
On 05/22/2015 05:36 AM, Markus Armbruster wrote: > All QMP commands use the "new" handler interface (mhandler.cmd_new). > Most HMP commands still use the traditional interface (mhandler.cmd), > but a few use the "new" one. Complicates handle_user_command() for no > gain, so I'm converting these to

Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI

2015-05-22 Thread Eric Blake
On 05/22/2015 05:36 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > hmp-commands.hx | 3 +-- > hmp.c| 17 + > hmp.h| 1 + > monitor.c| 42 ++ > qapi-schema.json | 20

Re: [Qemu-devel] [PATCH 03/20] monitor: Improve and document client_migrate_info protocol error

2015-05-22 Thread Eric Blake
On 05/22/2015 05:36 AM, Markus Armbruster wrote: > Protocol must be spice, vnc isn't implemented. Fix up documentation. > > Attempts to use vnc or any other unknown protocol yield the misleading > error message "Invalid parameter 'protocol'". Improve it to > "Parameter 'protocol' expects spice".

Re: [Qemu-devel] [PATCH 02/20] monitor: Clean up after previous commit

2015-05-22 Thread Eric Blake
On 05/22/2015 05:36 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- Commit message is sparse; I would have mentioned [1] and [2]. > monitor.c | 40 +++- > 1 file changed, 11 insertions(+), 29 deletions(-) > > > -static void handler_au

Re: [Qemu-devel] [PATCH 22/23] userfaultfd: avoid mmap_sem read recursion in mcopy_atomic

2015-05-22 Thread Andrew Morton
There's a more serious failure with i386 allmodconfig: fs/userfaultfd.c:145:2: note: in expansion of macro 'BUILD_BUG_ON' BUILD_BUG_ON(sizeof(struct uffd_msg) != 32); I'm surprised the feature is even reachable on i386 builds?

Re: [Qemu-devel] [PATCH 01/20] monitor: Drop broken, unused asynchronous command interface

2015-05-22 Thread Eric Blake
On 05/22/2015 05:36 AM, Markus Armbruster wrote: > The asynchronous monitor command interface goes back to commit 940cc30 > (Jan 2010). Added a third case to command execution. The hope back > then according to the commit message was that all commands get > converted to the asynchronous interface

[Qemu-devel] [PULL 16/19] qtest: pre-buffer hex nibs

2015-05-22 Thread John Snow
Instead of converting each byte one-at-a-time and then sending each byte over the wire, use sprintf() to pre-compute all of the hex nibs into a single buffer, then send the entire buffer all at once. This gives a moderate speed boost to memread() and memwrite() functions. Signed-off-by: John Snow

[Qemu-devel] [PULL 15/19] libqos/ahci: Swap memread/write with bufread/write

2015-05-22 Thread John Snow
Where it makes sense, use the new faster primitives. For generally small reads/writes such as for the PRDT and FIS packets, stick with the more wasteful but easier to debug memread/memwrite. For ahci-test (before migration tests): With this patch: real0m3.675s user0m2.582s sys 0m1.718s

Re: [Qemu-devel] [PATCH 1/4] iotests: fix exclusion option

2015-05-22 Thread John Snow
On 05/22/2015 04:31 PM, Eric Blake wrote: > On 05/22/2015 02:17 PM, John Snow wrote: >> If you are running out-of-tree, the -x option to exclude a >> certain iotest is broken. >> >> Replace porcelain usage of ls with a sturdier grep command. >> >> Signed-off-by: John Snow --- >> tests/qemu-io

Re: [Qemu-devel] [PATCH 1/4] iotests: fix exclusion option

2015-05-22 Thread Eric Blake
On 05/22/2015 02:17 PM, John Snow wrote: > If you are running out-of-tree, the -x option to exclude > a certain iotest is broken. > > Replace porcelain usage of ls with a sturdier grep command. > > Signed-off-by: John Snow > --- > tests/qemu-iotests/common | 3 ++- > 1 file changed, 2 insertion

Re: [Qemu-devel] [PATCH v6 3/4] cpu/apic: drop icc bus/bridge

2015-05-22 Thread Andreas Färber
Am 22.05.2015 um 18:56 schrieb Eduardo Habkost: > On Fri, May 22, 2015 at 03:44:53PM +0800, Chen Fan wrote: >> static void x86_cpu_apic_realize(X86CPU *cpu, Error **errp) >> @@ -2801,8 +2793,6 @@ static void x86_cpu_realizefn(DeviceState *dev, Error >> **errp) >> } >> >> #ifndef CONFIG_USER_

Re: [Qemu-devel] [PATCH v4 4/8] block: Fix dirty bitmap in bdrv_co_discard

2015-05-22 Thread Eric Blake
On 05/21/2015 09:40 PM, Fam Zheng wrote: > Unsetting dirty globally with discard is not very correct. The discard may > zero > out sectors (depending on can_write_zeroes_with_unmap), we should replicate > this change to destinition side to make sure that the guest sees the same > data. s/destini

Re: [Qemu-devel] [PATCH v4 3/8] mirror: Do zero write on target if sectors not allocated

2015-05-22 Thread Eric Blake
On 05/21/2015 09:40 PM, Fam Zheng wrote: > If guest discards a source cluster, mirroring with bdrv_aio_readv is overkill. > Some protocols do zero upon discard, where it's best to use > bdrv_aio_write_zeroes, otherwise, bdrv_aio_discard will be enough. > > Signed-off-by: Fam Zheng > --- > block/

[Qemu-devel] [PATCH 2/4] iotests: Add dependency info to groups list

2015-05-22 Thread John Snow
Add a few external dependency groups to the iotests groups list, such as "qemu", "nbd", and "scm". This will assist us in knowing which tests need to be re-run when those dependencies are updated, or by helping us to avoid tests that we know are broken for a certain file. qemu-img and qemu-io are

[Qemu-devel] [PATCH 1/4] iotests: fix exclusion option

2015-05-22 Thread John Snow
If you are running out-of-tree, the -x option to exclude a certain iotest is broken. Replace porcelain usage of ls with a sturdier grep command. Signed-off-by: John Snow --- tests/qemu-iotests/common | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/common

Re: [Qemu-devel] [PATCH 22/23] userfaultfd: avoid mmap_sem read recursion in mcopy_atomic

2015-05-22 Thread Andrew Morton
On Thu, 14 May 2015 19:31:19 +0200 Andrea Arcangeli wrote: > If the rwsem starves writers it wasn't strictly a bug but lockdep > doesn't like it and this avoids depending on lowlevel implementation > details of the lock. > > ... > > @@ -229,13 +246,33 @@ static __always_inline ssize_t __mcopy_at

[Qemu-devel] [PATCH 0/4] iotests: skip tests with unchanged dependencies

2015-05-22 Thread John Snow
This patchset is a little off the beaten path, but: Add the ability to skip tests that have already been run whose external dependencies have remained unchanged since the last test run. This is useful for, say, re-running a test set to see if a failure was a one-off or is reproducible by just re-

[Qemu-devel] [PATCH 3/4] iotests: add timestamp skip feature

2015-05-22 Thread John Snow
Like a makefile, try to skip tests if we know they have already been executed using the current set of external dependencies. If a user passes the -ts option to ./check, if a test or its output or its dependencies (qemu, qemu-nbd, qemu-io, qemu-img, socket-scm-helper) have been modified, the test

[Qemu-devel] [PATCH 4/4] iotests: clarify help text

2015-05-22 Thread John Snow
Split the help text to highlight the groups of options a little better, carving out a clear "format" and "protocols" section. Signed-off-by: John Snow --- tests/qemu-iotests/common | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/common b/tests/qemu-iot

[Qemu-devel] [PULL 17/19] macio: move unaligned DMA read code into separate pmac_dma_read() function

2015-05-22 Thread John Snow
From: Mark Cave-Ayland This considerably helps simplify the complexity of the macio read routines and by switching macio CDROM accesses to use the new code, fixes the issue with the CDROM device being detected intermittently by Darwin/OS X. [Maintainer edit: printf format codes adjusted for 32/6

[Qemu-devel] [PULL 18/19] macio: move unaligned DMA write code into separate pmac_dma_write() function

2015-05-22 Thread John Snow
From: Mark Cave-Ayland Similarly switch the macio IDE routines over to use the new function and tidy-up the remaining code as required. [Maintainer edit: printf format codes adjusted for 32/64bit. --js] Signed-off-by: Mark Cave-Ayland Acked-by: John Snow Message-id: 1425939893-14404-3-git-sen

[Qemu-devel] [PULL 19/19] ahci: do not remap clb/fis unconditionally

2015-05-22 Thread John Snow
This continues the IOMMU fix from 2.3, where we should not attempt to remap the CLB or FIS RX buffers if the AHCI device is currently running. The same applies to migration: keep our mitts off these registers unless the device is supposed to be on. Does not impact backwards compatibility for the

[Qemu-devel] [PULL 09/19] qtest/ahci: add flush migrate test

2015-05-22 Thread John Snow
Use blkdebug to inject an error on first flush, then attempt to flush on the first guest. When the error halts the VM, migrate to the second VM, and attempt to resume the command. Signed-off-by: John Snow Reviewed-by: Kevin Wolf Message-id: 1430417242-11859-8-git-send-email-js...@redhat.com ---

[Qemu-devel] [PULL 10/19] qtest/ahci: add halted dma test

2015-05-22 Thread John Snow
If we're going to test the migration of halted DMA jobs, we should probably check to make sure we can resume them locally as a first step. Signed-off-by: John Snow Reviewed-by: Kevin Wolf Message-id: 1430417242-11859-9-git-send-email-js...@redhat.com --- tests/ahci-test.c | 60 +

[Qemu-devel] [PULL 13/19] qtest: Add base64 encoded read/write

2015-05-22 Thread John Snow
For larger pieces of data that won't need to be debugged and viewing the hex nibbles is unlikely to be useful, we can encode data using base64 instead of encoding each byte as %02x, which leads to some space savings and faster reads/writes. For now, the default is left as hex nibbles in memwrite()

[Qemu-devel] [PULL 11/19] qtest/ahci: add migrate halted dma test

2015-05-22 Thread John Snow
Test migrating a halted DMA transaction. Resume, then test data integrity. Signed-off-by: John Snow Reviewed-by: Kevin Wolf Message-id: 1430417242-11859-10-git-send-email-js...@redhat.com --- tests/ahci-test.c | 75 ++- 1 file changed, 74 inse

[Qemu-devel] [PULL 07/19] qtest/ahci: Add migration test

2015-05-22 Thread John Snow
Notes: * The migration is performed on QOSState objects. * The migration is performed in such a way that it does not assume consistency between the allocators attached to each. That is to say, you can use each QOSState object completely independently and then at an arbitrary point deci

[Qemu-devel] [PULL 14/19] qtest: add memset to qtest protocol

2015-05-22 Thread John Snow
Previously, memset was just a frontend to write() and only stupidly sent the pattern many times across the wire. Let's not discuss who stupidly wrote it like that in the first place. (Hint: It was me.) Signed-off-by: John Snow Message-id: 1430864578-22072-4-git-send-email-js...@redhat.com --- q

[Qemu-devel] [PULL 08/19] qtest/ahci: add migrate dma test

2015-05-22 Thread John Snow
Write to one guest, migrate, and then read from the other. adjust ahci_io to clear any buffers it creates, so that we can use ahci_io safely on both guests knowing we are using empty buffers and not accidentally re-using data. Signed-off-by: John Snow Reviewed-by: Kevin Wolf Message-id: 14304172

[Qemu-devel] [PULL 02/19] glib: remove stale compat functions

2015-05-22 Thread John Snow
Since we're bumping the version to 2.22+, remove the now-stale compat functions. Signed-off-by: John Snow Reviewed-by: Markus Armbruster Reviewed-by: Alex Bennée Message-id: 1431469140-22208-2-git-send-email-js...@redhat.com --- include/glib-compat.h | 35 --- 1

[Qemu-devel] [PULL 12/19] qtest: allow arbitrarily long sends

2015-05-22 Thread John Snow
qtest currently has a static buffer of size 1024 that if we overflow, ignores the additional data silently which leads to hangs or stream failures. Use glib's string facilities to allow arbitrarily long data, but split this off into a new function, qtest_sendf. Static data can still be sent using

[Qemu-devel] [PULL 03/19] libqos/ahci: Add halted command helpers

2015-05-22 Thread John Snow
Sometimes we want a command to halt the VM instead of complete successfully, so it'd be nice to let the libqos/ahci functions cope with such scenarios. Signed-off-by: John Snow Reviewed-by: Kevin Wolf Message-id: 1430417242-11859-2-git-send-email-js...@redhat.com --- tests/libqos/ahci.c | 27 ++

[Qemu-devel] [PULL 05/19] libqos: Add migration helpers

2015-05-22 Thread John Snow
libqos.c: -set_context for addressing which commands go where -migrate performs the actual migration malloc.c: - Structure of the allocator is adjusted slightly with a second-tier malloc to make swapping around the allocators easy when we "migrate" the lists from the source

[Qemu-devel] [PULL 06/19] ich9/ahci: Enable Migration

2015-05-22 Thread John Snow
Lift the flag preventing the migration of the ICH9/AHCI devices. Signed-off-by: John Snow Reviewed-by: Kevin Wolf Message-id: 1430417242-11859-5-git-send-email-js...@redhat.com --- hw/ide/ahci.c | 1 - hw/ide/ich.c | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahc

[Qemu-devel] [PULL 01/19] configure: require glib 2.22

2015-05-22 Thread John Snow
This provides g_ptr_array_new_with_free_func, as well as a few other functions that we've been hacking around in glib-compat.h. Cleaning up the compatibility headers will come later. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow Reviewed-by: Markus Armbruster Reviewed-by: Alex Bennée M

[Qemu-devel] [PULL 00/19] Ide patches

2015-05-22 Thread John Snow
The following changes since commit bb2fa17f182ee0b45b53474f76679944fc891f04: Merge remote-tracking branch 'remotes/bkoppelmann/tags/pull-tricore-20150522' into staging (2015-05-22 16:22:42 +0100) are available in the git repository at: https://github.com/jnsnow/qemu.git tag

[Qemu-devel] [PULL 04/19] libqos/ahci: Fix sector set method

2015-05-22 Thread John Snow
|| probably does not mean the same thing as |. Additionally, allow users to submit a prd_size of 0 to indicate that they'd like to continue using the default. Signed-off-by: John Snow Reviewed-by: Kevin Wolf Message-id: 1430417242-11859-3-git-send-email-js...@redhat.com --- tests/libqos/ahci.c

Re: [Qemu-devel] [PATCH v4 2/8] qmp: Add optional bool "unmap" to drive-mirror

2015-05-22 Thread Eric Blake
On 05/21/2015 09:40 PM, Fam Zheng wrote: > If specified as "true", it allows discarding on target sectors where source is > not allocated. > > Signed-off-by: Fam Zheng > --- > block/mirror.c| 7 +-- > blockdev.c| 5 + > hmp.c | 2 +- > incl

Re: [Qemu-devel] [RFC 0/2] macio: split out unaligned DMA access into separate functions

2015-05-22 Thread Mark Cave-Ayland
On 22/05/15 19:20, John Snow wrote: >>> Code fails 32 bit build due to %lx debug prints. I'll edit them >>> accordingly if that is OK by you. >> >> Please go right ahead :) Do you need a proper re-spin without the RFC >> prefix? If so, I can make the changes there if that helps? >> >> >> ATB, >>

Re: [Qemu-devel] [RFC PATCH] net: Enable vlans and dump for -netdev, too,

2015-05-22 Thread Eric Blake
On 05/22/2015 01:22 PM, Thomas Huth wrote: > So far, it is not possible to use the network dump interface > with the "-netdev" option yet, it only works with the legacy > "-net" option. To be able to use it with "-netdev", too, this > patch now enables the "vlan" packet distribution for the > "-net

Re: [Qemu-devel] [PATCH v4 1/8] block: Add "base" option to bdrv_get_block_status

2015-05-22 Thread Eric Blake
On 05/21/2015 09:40 PM, Fam Zheng wrote: > Now this function follows the backing chain until seeing BDRV_BLOCK_ALLOCATED. > Base is not included, and it can be NULL just like bdrv_is_allocated_above(). > > Existing callers pass in bs->backing_hd to keep the old behavior. > > Signed-off-by: Fam Zh

Re: [Qemu-devel] [PATCH v6 2/4] apic: convert ->busdev.qdev casts to C casts

2015-05-22 Thread Eduardo Habkost
On Wed, May 20, 2015 at 10:40:47AM +0800, Zhu Guihua wrote: > Use C casts to avoid accessing ICCDevice's qdev field > directly. > > Signed-off-by: Zhu Guihua Applied to the x86 tree. Thanks. -- Eduardo

[Qemu-devel] [RFC PATCH] net: Enable vlans and dump for -netdev, too,

2015-05-22 Thread Thomas Huth
So far, it is not possible to use the network dump interface with the "-netdev" option yet, it only works with the legacy "-net" option. To be able to use it with "-netdev", too, this patch now enables the "vlan" packet distribution for the "-netdev" option, too, so that you can now dump network pa

Re: [Qemu-devel] [PATCH v6 1/4] apic: map APIC's MMIO region at each CPU's address space

2015-05-22 Thread Eduardo Habkost
On Wed, May 20, 2015 at 10:40:46AM +0800, Zhu Guihua wrote: > From: Chen Fan > > Replace mapping APIC at global system address space with > mapping it at per-CPU address spaces. > > Signed-off-by: Chen Fan > Signed-off-by: Zhu Guihua Applied to the x86 tree. Thanks. -- Eduardo

Re: [Qemu-devel] [PATCH v5] target-i386: Register QOM properties for feature flags

2015-05-22 Thread Eduardo Habkost
On Tue, Apr 14, 2015 at 12:28:24PM -0300, Eduardo Habkost wrote: > This uses the feature name arrays to register QOM properties for feature > flags. This simply adds properties that can be configured using -global, > but doesn't change x86_cpu_parse_featurestr() to use them yet. > > Signed-off-by:

Re: [Qemu-devel] [RFC 0/2] macio: split out unaligned DMA access into separate functions

2015-05-22 Thread John Snow
On 05/22/2015 02:16 PM, Mark Cave-Ayland wrote: > On 22/05/15 18:55, John Snow wrote: > >> On 03/09/2015 06:24 PM, Mark Cave-Ayland wrote: >>> This patchset attempts to separate out the IDE/ATAPI logic from the >>> unaligned >>> DMA access logic for macio which provides the following benefits:

Re: [Qemu-devel] [RFC 0/2] macio: split out unaligned DMA access into separate functions

2015-05-22 Thread Mark Cave-Ayland
On 22/05/15 18:55, John Snow wrote: > On 03/09/2015 06:24 PM, Mark Cave-Ayland wrote: >> This patchset attempts to separate out the IDE/ATAPI logic from the unaligned >> DMA access logic for macio which provides the following benefits: >> >> 1) Reduced code complexity >> >> The existing macio IDE/

Re: [Qemu-devel] [RFC 0/2] macio: split out unaligned DMA access into separate functions

2015-05-22 Thread John Snow
On 03/09/2015 06:24 PM, Mark Cave-Ayland wrote: > This patchset attempts to separate out the IDE/ATAPI logic from the unaligned > DMA access logic for macio which provides the following benefits: > > 1) Reduced code complexity > > The existing macio IDE/ATAPI functions were becoming extremely d

Re: [Qemu-devel] [PATCH v15 00/10] KVM platform device passthrough

2015-05-22 Thread Vikram Sethi
Hi Eric, Tested the latest patchset from your vfio_integ_v15 branch on a platform device with 2 mmio regions. Works fine. Tested-by: Vikram Sethi Thanks, Vikram On 05/06/15 01:37, Eric Auger wrote: > Dear All, > > Please ignore the previous void message. For unknown reason the reply > systemati

Re: [Qemu-devel] [PATCH] qapi: add dirty bitmap status

2015-05-22 Thread John Snow
On 05/22/2015 04:52 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 05/12/2015 01:53 PM, John Snow wrote: >>> Bitmaps can be in a handful of different states with potentially >>> more to come as we tool around with migration and persistence patches. >>> >>> Instead of having a bunch o

Re: [Qemu-devel] [PATCH] qapi: add dirty bitmap status

2015-05-22 Thread John Snow
On 05/22/2015 07:49 AM, Kevin Wolf wrote: > Am 22.05.2015 um 10:31 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >>> Am 21.05.2015 um 23:48 hat John Snow geschrieben: On 05/20/2015 04:20 AM, Markus Armbruster wrote: > John Snow writes: > >> On 05/12/2015

Re: [Qemu-devel] [PATCH RFC 4/4] Initial implementation of vGICv3.

2015-05-22 Thread Pavel Fedin
Hi! > Looks GICv3 common class currently miss this security_extn field + > parent_fiq so it does not compile without changes. Or did I miss something? Just throw this if(...) away. It's my fault. Actually i have rebased Shlomo's patches on yesterday's master, and during this i added parent_fiq

Re: [Qemu-devel] [PATCH v6 3/4] cpu/apic: drop icc bus/bridge

2015-05-22 Thread Eduardo Habkost
On Fri, May 22, 2015 at 03:44:53PM +0800, Chen Fan wrote: > On 05/20/2015 10:53 PM, Igor Mammedov wrote: > >On Wed, 20 May 2015 10:40:48 +0800 > >Zhu Guihua wrote: > > > >>From: Chen Fan > >> > >>After CPU hotplug has been converted to BUS-less hot-plug infrastructure, > >>the only function ICC b

Re: [Qemu-devel] [PATCH 00/23] userfaultfd v4

2015-05-22 Thread Kirill Smelkov
Hi Andrea, On Thu, May 21, 2015 at 05:52:51PM +0200, Andrea Arcangeli wrote: > Hi Kirill, > > On Thu, May 21, 2015 at 04:11:11PM +0300, Kirill Smelkov wrote: > > Sorry for maybe speaking up too late, but here is additional real > > Not too late, in fact I don't think there's any change required

Re: [Qemu-devel] [PULL 00/10] tricore-patches

2015-05-22 Thread Peter Maydell
ble in the git repository at: > > https://github.com/bkoppelmann/qemu-tricore-upstream.git > tags/pull-tricore-20150522 > > for you to fetch changes up to 9371557115a734412974f8d4096cbe8a62ca2731: > > target-tricore: add RR_DIV and RR_DIV_U instructi

Re: [Qemu-devel] How Qemu timer interrupts code emulation?

2015-05-22 Thread Peter Maydell
On 22 May 2015 at 16:36, Jun Koi wrote: > In general, we would have timer & code execution run in parallel, No code has to actually run when there's an active timer; the event loop thread mostly sits blocked waiting for something interesting to happen (io or a timer firing). When it does then the

[Qemu-devel] [PATCH] iotests: remove assertIsNotNone call

2015-05-22 Thread John Snow
RHEL6 doesn't have Python 2.7, so replace this call with assertNotEqual(x, None) which will work just as well. Reported-by: Kevin Wolf Signed-off-by: John Snow --- tests/qemu-iotests/124 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/124 b/tests/qemu-iote

[Qemu-devel] [PULL 22/22] MAINTAINERS: Split "Block QAPI, monitor, command line" off core

2015-05-22 Thread Kevin Wolf
From: Markus Armbruster Kevin and Stefan asked me to take care of this part. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9ff7c36..0463696 100644 --- a/MAINTAINERS +++ b/M

[Qemu-devel] [PULL 16/22] qcow2/qcow: protect against uninitialized encryption key

2015-05-22 Thread Kevin Wolf
From: "Daniel P. Berrange" When a qcow[2] file is opened, if the header reports an encryption method, this is used to set the 'crypt_method_header' field on the BDRVQcow[2]State struct, and the 'encrypted' flag in the BDRVState struct. When doing I/O operations, the 'crypt_method' field on the B

[Qemu-devel] [PULL 21/22] MAINTAINERS: Add header files to Block Layer Core section

2015-05-22 Thread Kevin Wolf
Suggested-by: Markus Armbruster Reviewed-by: Alberto Garcia Signed-off-by: Kevin Wolf --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index b3552b2..9ff7c36 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -785,6 +785,7 @@ S: Supported F: block* F: b

Re: [Qemu-devel] [PATCH v6 19/21] iotests: add simple incremental backup case

2015-05-22 Thread Kevin Wolf
Am 22.05.2015 um 17:29 hat John Snow geschrieben: > > > On 05/22/2015 11:02 AM, Kevin Wolf wrote: > > Am 18.04.2015 um 01:50 hat John Snow geschrieben: > >> Signed-off-by: John Snow > >> Reviewed-by: Max Reitz > >> --- > >> tests/qemu-iotests/124 | 174 > >> +++

[Qemu-devel] [PULL 20/22] tests: add test case for encrypted qcow2 read/write

2015-05-22 Thread Kevin Wolf
From: "Daniel P. Berrange" Add a simple test case for qemu-iotests that covers read/write with encrypted qcow2 files. Signed-off-by: Daniel P. Berrange Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- tests/qemu-iotests/134 | 69 ++ tests/

[Qemu-devel] How Qemu timer interrupts code emulation?

2015-05-22 Thread Jun Koi
Hi, I am wondering how the timer interrupt works in softmmu TCG mode (on X86)? In general, we would have timer & code execution run in parallel, then once in a while, the timer would interrupt the code execution to switch it out to execute the timer interrupt. I looked at the code, but still co

Re: [Qemu-devel] [PATCH v6 19/21] iotests: add simple incremental backup case

2015-05-22 Thread John Snow
On 05/22/2015 11:02 AM, Kevin Wolf wrote: > Am 18.04.2015 um 01:50 hat John Snow geschrieben: >> Signed-off-by: John Snow >> Reviewed-by: Max Reitz >> --- >> tests/qemu-iotests/124 | 174 >> +++-- >> tests/qemu-iotests/124.out | 4 +- >> 2 files c

[Qemu-devel] [PULL 19/22] qemu-io: prompt for encryption keys when required

2015-05-22 Thread Kevin Wolf
From: "Daniel P. Berrange" The qemu-io tool does not check if the image is encrypted so historically would silently corrupt the sectors by writing plain text data into them instead of cipher text. The earlier commit turns this mistake into a fatal abort, so check for encryption and prompt for key

[Qemu-devel] [PULL 14/22] qemu-iotests: qemu-img info on afl VMDK image with a huge capacity

2015-05-22 Thread Kevin Wolf
From: Fam Zheng The image is contributed by Richard W.M. Jones. Cc: Richard W.M. Jones Signed-off-by: Fam Zheng Reviewed-by: Alberto Garcia Reviewed-by: Markus Armbruster Signed-off-by: Kevin Wolf --- tests/qemu-iotests/059 | 5 + tests/qemu-iotests/059.out

Re: [Qemu-devel] [PATCH] qapi: add dirty bitmap status

2015-05-22 Thread John Snow
On 05/22/2015 04:22 AM, Kevin Wolf wrote: > Am 21.05.2015 um 23:48 hat John Snow geschrieben: >> >> >> On 05/20/2015 04:20 AM, Markus Armbruster wrote: >>> John Snow writes: >>> On 05/12/2015 04:06 PM, Eric Blake wrote: > On 05/12/2015 01:53 PM, John Snow wrote: >> Bitmaps can be in

[Qemu-devel] [PULL 15/22] qemu-iotests: Make debugging python tests easier

2015-05-22 Thread Kevin Wolf
From: Fam Zheng Adding "-d" option. The output goes to "tee" so it appears in your console. Also, raise the verbosity of unnitest runner. When testing a topic branch, it's possible that a bug introduced by a code change makes the python test case hang, with debug output, it is much easier to loc

[Qemu-devel] [PULL 11/22] qcow2: style fixes in qcow2-cache.c

2015-05-22 Thread Kevin Wolf
From: Alberto Garcia Fix pointer declaration to make it consistent with the rest of the code. Signed-off-by: Alberto Garcia Reviewed-by: Stefan Hajnoczi Reviewed-by: Max Reitz Signed-off-by: Kevin Wolf --- block/qcow2-cache.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[Qemu-devel] [PULL 08/22] qcow2: remove qcow2_cache_find_entry_to_replace()

2015-05-22 Thread Kevin Wolf
From: Alberto Garcia A cache miss means that the whole array was traversed and the entry we were looking for was not found, so there's no need to traverse it again in order to select an entry to replace. Signed-off-by: Alberto Garcia Reviewed-by: Stefan Hajnoczi Reviewed-by: Max Reitz Signed-

[Qemu-devel] [PULL 17/22] util: move read_password method out of qemu-img into osdep/oslib

2015-05-22 Thread Kevin Wolf
From: "Daniel P. Berrange" The qemu-img.c file has a read_password() method impl that is used to prompt for passwords on the console, with impls for POSIX and Windows. This will be needed by qemu-io.c too, so move it into the QEMU osdep/oslib files where it can be shared without code duplication

  1   2   3   >