Re: [Qemu-devel] [PATCH 19/31] q35: add config space wmask for SMRAM and ESMRAMC

2015-05-11 Thread Gerd Hoffmann
On Mo, 2015-05-11 at 15:49 +0200, Paolo Bonzini wrote: > From: Gerd Hoffmann [ more verbose commit message for squashing in ] Not all bits in SMRAM and ESMRAMC can be changed by the guest. Add wmask defines accordingly and set them in mch_reset(). > Signed-off-by: Gerd Hoffmann > Signed-off-by

Re: [Qemu-devel] [PATCH 0/6] ui/cocoa: Fix OSX 10.10 warnings (and drop 10.4 support)

2015-05-11 Thread Peter Maydell
On 12 May 2015 at 00:45, Programmingkid wrote: > On May 10, 2015, at 6:19 PM, Peter Maydell wrote: >> I've chosen to implement some of them by simply dropping the >> backward-compatibility support for OSX 10.4. This is basically >> a pragmatic decision since I don't think we can support ancient >>

Re: [Qemu-devel] [PATCH 18/31] q35: fix ESMRAMC default

2015-05-11 Thread Gerd Hoffmann
On Mo, 2015-05-11 at 15:49 +0200, Paolo Bonzini wrote: > From: Gerd Hoffmann [ more verbose commit message for squashing in ] The cache bits in ESMRAMC are hardcoded to 1 (=disabled) according to the q35 mch specs. Add and use a define with this default. While being at it also update the SMRAM

[Qemu-devel] [PATCHv3 2/2] stubs: Provide parallel_mm_init stub version

2015-05-11 Thread mrezanin
From: Miroslav Rezanina mips build fail with link error in case PARALLEL_CONFIG is disabled as hw/mips/mips_jazz.c calls parallel_mm_init. Due to dependecies to content of parallel.c we can't simply move it to hw/isa/isa-devices.c. This patch adds stubs/parallel.c file that contains stub version

[Qemu-devel] [PATCHv3 1/2] Move parallel_hds_isa_init to hw/isa/isa-bus.c

2015-05-11 Thread mrezanin
From: Miroslav Rezanina Disabling CONFIG_PARALLEL cause removing parallel_hds_isa_init defined in parallel.c. This function is called during initialization of some boards so disabling CONFIG_PARALLEL cause build failure. This patch moves parallel_hds_isa_init to hw/isa/isa-bus.c so it is include

[Qemu-devel] [PATCHv3 0/2] parallel: Allow to disable CONFIG_PARALLEL

2015-05-11 Thread mrezanin
From: Miroslav Rezanina There's few uncoditional calls to functions in hw/char/parallel.c so disabling CONFIG_PARALLEL can cause build failure. This series allow building with CONFIG_PARALLEL disabled. In addition, it changes behavior so the run of "qemu -parallel" will abort in case target expec

Re: [Qemu-devel] [PATCH v2 2/6] block: Fix dirty bitmap in bdrv_co_discard

2015-05-11 Thread Fam Zheng
On Mon, 05/11 15:22, John Snow wrote: > > > On 05/06/2015 12:52 AM, Fam Zheng wrote: > > Unsetting dirty globally with discard is not very correct. The discard may > > zero > > out sectors (depending on can_write_zeroes_with_unmap), we should replicate > > this change to destinition side to make

[Qemu-devel] [PATCH v6 3/3] qemu-iotests: Test unaligned sub-block zero write

2015-05-11 Thread Fam Zheng
Test zero write in byte range 512~1024 for 4k alignment. Signed-off-by: Fam Zheng Reviewed-by: Stefan Hajnoczi --- tests/qemu-iotests/033 | 13 + tests/qemu-iotests/033.out | 30 ++ 2 files changed, 43 insertions(+) diff --git a/tests/qemu-iotests/03

[Qemu-devel] [PATCH v6 2/3] block: Fix NULL deference for unaligned write if qiov is NULL

2015-05-11 Thread Fam Zheng
For zero write, callers pass in NULL qiov (qemu-io "write -z" or scsi-disk "write same"). Commit fc3959e466 fixed bdrv_co_write_zeroes which is the common case for this bug, but it still exists in bdrv_aio_write_zeroes. A simpler fix would be in bdrv_co_do_pwritev which is the NULL dereference poi

[Qemu-devel] [PATCH v6 0/3] block: Fix unaligned bdrv_aio_write_zeroes

2015-05-11 Thread Fam Zheng
An unaligned zero write causes NULL deferencing in bdrv_co_do_pwritev. That path is reachable from bdrv_co_write_zeroes and bdrv_aio_write_zeroes. You can easily trigger through the former with qemu-io, as the test case added by 61815d6e0aa. For bdrv_aio_write_zeroes, in common cases there's alway

[Qemu-devel] [PATCH v6 1/3] Revert "block: Fix unaligned zero write"

2015-05-11 Thread Fam Zheng
This reverts commit fc3959e4669a1c2149b91ccb05101cfc7ae1fc05. The core write code already handles the case, so remove this duplication. Because commit 61007b316 moved the touched code from block.c to block/io.c, the change is manually reverted. Signed-off-by: Fam Zheng Reviewed-by: Stefan Hajno

Re: [Qemu-devel] [PATCH 0/4] qga: disk and volume info for Windows guest

2015-05-11 Thread Denis V. Lunev
On 02/05/15 13:13, Denis V. Lunev wrote: Functionality match with Linux. Patches 1 and 2 are very useful for consistent backups of Windows guests. Signed-off-by: Olga Krishtal Signed-off-by: Denis V. Lunev CC: Michael Roth ping

[Qemu-devel] [PATCH 2/2] block: align bounce buffers to page

2015-05-11 Thread Denis V. Lunev
The following sequence int fd = open(argv[1], O_RDWR | O_CREAT | O_DIRECT, 0644); for (i = 0; i < 10; i++) write(fd, buf, 4096); performs 5% better if buf is aligned to 4096 bytes. The difference is quite reliable. On the other hand we do not want at the moment to enforce

[Qemu-devel] [PATCH v6 0/2] block: enforce minimal 4096 alignment in qemu_blockalign

2015-05-11 Thread Denis V. Lunev
I have used the following program to test #define _GNU_SOURCE #include #include #include #include #include #include int main(int argc, char *argv[]) { int fd = open(argv[1], O_RDWR | O_CREAT | O_DIRECT, 0644); void *buf; int i = 0, align = atoi(argv[2]); do { buf =

[Qemu-devel] [PATCH 1/2] block: minimal bounce buffer alignment

2015-05-11 Thread Denis V. Lunev
The patch introduces new concept: minimal memory alignment for bounce buffers. Original so called "optimal" value is actually minimal required value for aligment. It should be used for validation that the IOVec is properly aligned and bounce buffer is not required. Though, from the performance poi

[Qemu-devel] [PATCH v2 0/3] Bitmap based CPU enumeration

2015-05-11 Thread Bharata B Rao
This patch changes the way cpu_index is handed out to newly created CPUs by tracking the allocted CPUs in a bitmap. More information and the need for this patch is described in patch 2/3 of this series. These generic changes are needed to support CPU hot plug/unplug on PowerPC. An open question is

[Qemu-devel] [PATCH v2 3/3] ppc: Move cpu_exec_init() call to realize function

2015-05-11 Thread Bharata B Rao
Move cpu_exec_init() call from instance_init to realize. This allows any failures from cpu_exec_init() to be handled appropriately. Also add corresponding cpu_exec_exit() call from unrealize. Signed-off-by: Bharata B Rao Reviewed-by: David Gibson --- target-ppc/translate_init.c | 9 +++-- 1

[Qemu-devel] [PATCH v2 2/3] cpus: Convert cpu_index into a bitmap

2015-05-11 Thread Bharata B Rao
Currently CPUState.cpu_index is monotonically increasing and a newly created CPU always gets the next higher index. The next available index is calculated by counting the existing number of CPUs. This is fine as long as we only add CPUs, but there are architectures which are starting to support CPU

[Qemu-devel] [PATCH v2 1/3] cpus: Add Error argument to cpu_exec_init()

2015-05-11 Thread Bharata B Rao
Add an Error argument to cpu_exec_init() to let users collect the error. This is in preparation to change the CPU enumeration logic in cpu_exec_init(). With the new enumeration logic, cpu_exec_init() can fail if cpu_index values corresponding to max_cpus have already been handed out. Since all cur

[Qemu-devel] [PATCH 7/7] hw/arm/virt: Add gpio-keys node for Poweroff using DT

2015-05-11 Thread shannon . zhao
From: Shannon Zhao Add a gpio-keys node. This is used for Poweroff for the systems which use DT not ACPI. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/arm/virt.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 354b020.

[Qemu-devel] [PATCH 3/7] hw/arm/virt-acpi-build: Add power button device in ACPI DSDT table

2015-05-11 Thread shannon . zhao
From: Shannon Zhao Add power button device in ACPI DSDT table. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/arm/virt-acpi-build.c | 13 + 1 file changed, 13 insertions(+) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index e505c16..b582047 100

[Qemu-devel] [PATCH 6/7] hw/arm/virt: Add QEMU powerdown notifier and hook it to GPIO Pin 3

2015-05-11 Thread shannon . zhao
From: Shannon Zhao Currently mach-virt model doesn't support powerdown request. Guest VM doesn't react to system_powerdown from monitor console (or QMP) because there is no communication mechanism for such requests. This patch registers GPIO Pin 3 with powerdown notification. So guest VM can rece

[Qemu-devel] [PATCH 2/7] hw/arm/virt-acpi-build: Add GPIO controller in ACPI DSDT table

2015-05-11 Thread shannon . zhao
From: Shannon Zhao Add GPIO controller in ACPI DSDT table. It can be used for gpio event. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/arm/virt-acpi-build.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-b

[Qemu-devel] [PATCH 1/7] hw/arm/virt: Add a GPIO controller

2015-05-11 Thread shannon . zhao
From: Shannon Zhao ACPI 5.0 supports GPIO-signaled ACPI Events. This can be used for powerdown, hotplug evnets. Add a GPIO controller in machine virt, to support powerdown, maybe can be used for cpu hotplug. And here we use pl061. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw

[Qemu-devel] [PATCH 5/7] hw/arm/virt-acpi-build: Add _E03 for Power Button

2015-05-11 Thread shannon . zhao
From: Shannon Zhao Here GPIO pin 3 is used for Power Button, add _E03 in ACPI DSDT table. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/arm/virt-acpi-build.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c i

[Qemu-devel] [PATCH 4/7] hw/acpi/aml-build: Add aml_gpio_int() term

2015-05-11 Thread shannon . zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/acpi/aml-build.c | 60 + include/hw/acpi/aml-build.h | 16 2 files changed, 76 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.

[Qemu-devel] [PATCH 0/7] Add system_powerdown support on ARM through ACPI and DT

2015-05-11 Thread shannon . zhao
From: Shannon Zhao ACPI SPEC 5.0 defines GPIO-signaled ACPI Events for Hardware-reduced platforms(like ARM). It uses GPIO pin to trigger an event to the guest. For QEMU, here we add PL061 GPIO controller and use PIN 3 for system_powerdown, reserving PIN 0, 1, 2 for PCI hotplug, CPU hotplug and me

Re: [Qemu-devel] [PATCH v2] Fixes key mapping so all keys work

2015-05-11 Thread Programmingkid
On May 10, 2015, at 2:45 PM, Peter Maydell wrote: > On 15 January 2015 at 21:13, Programmingkid wrote: >> Fixes keyboard mapping so right shift, right command, right option, right >> control, keypad period, keypad '=', keypad enter, and F13 all work. >> >> Signed-off-by: John Arbuckle >> >>

Re: [Qemu-devel] [PATCH 2/2] s390x: Add laa and laag instructions

2015-05-11 Thread Richard Henderson
On 05/07/2015 06:12 PM, Alexander Graf wrote: > +static ExitStatus op_laa(DisasContext *s, DisasOps *o) > +{ > +TCGv_i64 m2 = tcg_temp_new_i64(); > + > +/* XXX should be atomic */ > +tcg_gen_qemu_ld32s(m2, o->in2, get_mem_index(s)); > + > +/* Set r1 to the unmodified contents of m2

Re: [Qemu-devel] [PATCH 1/2] s390x: Add some documentation in opcode list

2015-05-11 Thread Richard Henderson
On 05/07/2015 06:12 PM, Alexander Graf wrote: > I find it really hard to grasp what each field in the opcode list means. > Slowly walking through its semantics myself, I figured I'd write a small > summary at the top of the file to make life easier for me and whoever > looks at the file next. > >

Re: [Qemu-devel] [Qemu-block] [PATCH v5 2/3] block: Fix NULL deference for unaligned write if qiov is NULL

2015-05-11 Thread Fam Zheng
On Mon, 05/11 15:43, Stefan Hajnoczi wrote: > On Tue, May 05, 2015 at 10:51:14AM +0800, Fam Zheng wrote: > > This function is complex. I had to draw a diagram to remember the > relationships between the variables. It would be nice to split it if > that can be done in a way that makes the code ni

[Qemu-devel] [PATCH 6/6] Add comma after DEFINE_PROP_END_OF_LIST()

2015-05-11 Thread shannon . zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/audio/intel-hda.c | 2 +- hw/char/virtio-serial-bus.c| 2 +- hw/core/platform-bus.c | 2 +- hw/dma/i82374.c| 2 +- hw/i386/kvm/ioapic.c | 2 +-

[Qemu-devel] [PATCH 5/6] hw/arm/spitz: Remove meaningless blank Property

2015-05-11 Thread shannon . zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/arm/spitz.c | 5 - 1 file changed, 5 deletions(-) diff --git a/hw/arm/spitz.c b/hw/arm/spitz.c index 5bf032a..fdb1010 100644 --- a/hw/arm/spitz.c +++ b/hw/arm/spitz.c @@ -1060,10 +1060,6 @@ static VMStateDes

[Qemu-devel] [PATCH 4/6] hw/gpio/zaurus: Remove meaningless blank Property

2015-05-11 Thread shannon . zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/gpio/zaurus.c | 5 - 1 file changed, 5 deletions(-) diff --git a/hw/gpio/zaurus.c b/hw/gpio/zaurus.c index 24a7727..aa8ee5f 100644 --- a/hw/gpio/zaurus.c +++ b/hw/gpio/zaurus.c @@ -235,10 +235,6 @@ static co

[Qemu-devel] [PATCH 2/6] hw/virtio/virtio-balloon: Remove meaningless blank Property

2015-05-11 Thread shannon . zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/virtio/virtio-balloon.c | 5 - 1 file changed, 5 deletions(-) diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c index 484c3c3..a3f5709 100644 --- a/hw/virtio/virtio-balloon.c +++ b/hw/virt

[Qemu-devel] [PATCH 3/6] hw/virtio/virtio-pci: Remove meaningless blank Property

2015-05-11 Thread shannon . zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/virtio/virtio-pci.c | 5 - 1 file changed, 5 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 5c173c4..47be00f 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virtio-pci.c

[Qemu-devel] [PATCH 1/6] hw/s390x/s390-virtio-bus: Remove meaningless blank Property

2015-05-11 Thread shannon . zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/s390x/s390-virtio-bus.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/hw/s390x/s390-virtio-bus.c b/hw/s390x/s390-virtio-bus.c index 1a72b56..273bd9c 100644 --- a/hw/s390x/s390-virtio-bus.c +

[Qemu-devel] [PATCH 0/6] Blank property cleanup

2015-05-11 Thread shannon . zhao
From: Shannon Zhao After [1]"s390-virtio: use common features" and [2]"virtio: Move host features to backends" applied, there are some Property arrays which only contain the list terminator DEFINE_PROP_END_OF_LIST. This patchset removes those arrays and other meaningless Property arrays and also

[Qemu-devel] How qemu performs CMOVcc instruction in target-i386/translate.c?

2015-05-11 Thread Pang Wing
Hi, I'm still trying to understanding how disas_insn in *target-i386/translate.c* works. Currently I met "*case 0x140 ... 0x14f: /* cmov Gv, Ev */*", I thought it just check the condition and execute the MOV according to the condition. However, in *gen_cmovcc1 *function, I have no idea where th

Re: [Qemu-devel] [Xen-devel] [PATCH v6 2/6] Qemu-Xen-vTPM: Xen frontend driver infrastructure

2015-05-11 Thread Xu, Quan
> -Original Message- > From: xen-devel-boun...@lists.xen.org > [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of Stefano Stabellini > Sent: Friday, May 08, 2015 1:26 AM > To: Xu, Quan > Cc: wei.l...@citrix.com; stef...@linux.vnet.ibm.com; > stefano.stabell...@eu.citrix.com; qemu-devel

Re: [Qemu-devel] Bug report - Windows XP guest failure

2015-05-11 Thread Peter Crosthwaite
On Thu, May 7, 2015 at 2:34 AM, Michael Tokarev wrote: > 07.05.2015 09:47, Michael Tokarev wrote: >> 07.05.2015 09:12, Michael Tokarev wrote: >>> 07.05.2015 04:11, G 3 wrote: Did you boot Windows XP to the desktop? I have tested Windows 95, Windows 2000, and Windows XP. All of them fail

Re: [Qemu-devel] [PATCH v2] rules.mak: Force CFLAGS for all objects in DSO

2015-05-11 Thread Fam Zheng
On Tue, 05/12 00:24, Andreas Färber wrote: > Am 07.05.2015 um 08:55 schrieb Fam Zheng: > > Because of the trick of process-archive-undefs, all .mo objects, even > > with --enable-modules, are dependencies of executables. > > > > This breaks CFLAGS propogation because the compiling of module object

Re: [Qemu-devel] [PATCH 05/10 v10] target-tilegx/opcode_tilegx.h: Modify it to fit qemu using

2015-05-11 Thread gchen gchen
For me, I still stick to uint8_t, since all callers and callee always treat it as uint8_t. It will make the code more clearer for readers. > Date: Mon, 11 May 2015 15:06:48 -0700 > From: r...@twiddle.net > To: xili_gchen_5...@hotmail.com; peter.mayd...@linaro.org; afaer...@suse.de; > cmetc...@ez

Re: [Qemu-devel] [patch 0/3] ui/cocoa.m: Add Machine menu

2015-05-11 Thread Peter Crosthwaite
On Mon, May 11, 2015 at 4:40 PM, Programmingkid wrote: > > On May 11, 2015, at 7:11 PM, Peter Crosthwaite wrote: > >> On Mon, May 11, 2015 at 3:08 PM, Programmingkid >> wrote: >>> This patch series adds a machine menu to the Macintosh interface. >>> Patch 1/3 adds the machine menu with pause and

Re: [Qemu-devel] [PATCH 0/6] ui/cocoa: Fix OSX 10.10 warnings (and drop 10.4 support)

2015-05-11 Thread Programmingkid
On May 10, 2015, at 6:19 PM, Peter Maydell wrote: > This patchset fixes a number of new compile warnings when building > on OSX10.10 which were not present on 10.9, which are mostly fixes > to avoid deprecated APIs. > > I've chosen to implement some of them by simply dropping the > backward-comp

Re: [Qemu-devel] [patch 0/3] ui/cocoa.m: Add Machine menu

2015-05-11 Thread Programmingkid
On May 11, 2015, at 7:11 PM, Peter Crosthwaite wrote: > On Mon, May 11, 2015 at 3:08 PM, Programmingkid > wrote: >> This patch series adds a machine menu to the Macintosh interface. >> Patch 1/3 adds the machine menu with pause and resume menu items. >> Patch 2/3 adds menu items for all devices

[Qemu-devel] [Bug 1450881] Re: qemu-system-sparc MUTEX_HELD assert and libC lock errors

2015-05-11 Thread Serge Hallyn
** No longer affects: qemu (Ubuntu) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1450881 Title: qemu-system-sparc MUTEX_HELD assert and libC lock errors Status in QEMU: New Bug description:

Re: [Qemu-devel] [patch 0/3] ui/cocoa.m: Add Machine menu

2015-05-11 Thread Peter Crosthwaite
On Mon, May 11, 2015 at 3:08 PM, Programmingkid wrote: > This patch series adds a machine menu to the Macintosh interface. > Patch 1/3 adds the machine menu with pause and resume menu items. > Patch 2/3 adds menu items for all devices that are available. > Patch 3/3 adds Reset and Power Down menu

[Qemu-devel] [PATCH v4 10/11] iotests: 124 - transactional failure test

2015-05-11 Thread John Snow
Use a transaction to request an incremental backup across two drives. Coerce one of the jobs to fail, and then re-run the transaction. Verify that no bitmap data was lost due to the partial transaction failure. Signed-off-by: John Snow Reviewed-by: Max Reitz --- tests/qemu-iotests/124 | 12

[Qemu-devel] [PATCH v4 05/11] block: add transactional callbacks feature

2015-05-11 Thread John Snow
The goal here is to add a new method to transactions that allows developers to specify a callback that will get invoked only once all jobs spawned by a transaction are completed, allowing developers the chance to perform actions conditionally pending complete success, partial failure, or complete f

[Qemu-devel] [PATCH v4 11/11] qmp-commands.hx: Update the supported 'transaction' operations

2015-05-11 Thread John Snow
From: Kashyap Chamarthy Although the canonical source of reference for QMP commands is qapi-schema.json, for consistency's sake, update qmp-commands.hx to state the list of supported transactionable operations, namely: drive-backup blockdev-backup blockdev-snapshot-internal-sync

[Qemu-devel] [PATCH v4 09/11] block: drive_backup transaction callback support

2015-05-11 Thread John Snow
This patch actually implements the transactional callback system for the drive_backup action. (1) We manually pick up a reference to the bitmap if present to allow its cleanup to be delayed until after all drive_backup jobs launched by the transaction have fully completed. (2) We create a

[Qemu-devel] [PATCH v4 06/11] block: add refcount to Job object

2015-05-11 Thread John Snow
If we want to get at the job after the life of the job, we'll need a refcount for this object. This may occur for example if we wish to inspect the actions taken by a particular job after a transactional group of jobs runs, and further actions are required. Signed-off-by: John Snow Reviewed-by:

[Qemu-devel] [PATCH v4 08/11] qmp: Add an implementation wrapper for qmp_drive_backup

2015-05-11 Thread John Snow
We'd like to be able to specify the callback given to backup_start manually in the case of transactions, so split apart qmp_drive_backup into an implementation and a wrapper. Switch drive_backup_prepare to use the new wrapper, but don't overload the callback and closure yet. Signed-off-by: John S

[Qemu-devel] [PATCH v4 03/11] block: rename BlkTransactionState and BdrvActionOps

2015-05-11 Thread John Snow
These structures are misnomers, somewhat. (1) BlockTransactionState is not state for a transaction, but is rather state for a single transaction action. Rename it "BlkActionState" to be more accurate. (2) The BdrvActionOps describes operations for the BlkActionState, above. This name

[Qemu-devel] [PATCH v4 00/11] block: incremental backup transactions

2015-05-11 Thread John Snow
Patch 1 adds basic support for add and clear transactions. Patch 2 tests this basic support. Patches 3-4 refactor transactions a little bit, to add clarity. Patch 5 adds the framework for error scenarios where only some jobs that were launched by a transaction complete successfully, and we

[Qemu-devel] [PATCH v4 07/11] block: add delayed bitmap successor cleanup

2015-05-11 Thread John Snow
Allow bitmap successors to carry reference counts. We can in a later patch use this ability to clean up the dirty bitmap according to both the individual job's success and the success of all jobs in the transaction group. The code for cleaning up a bitmap is also moved from backup_run to backup_c

[Qemu-devel] [PATCH v4 01/11] qapi: Add transaction support to block-dirty-bitmap operations

2015-05-11 Thread John Snow
This adds two qmp commands to transactions. block-dirty-bitmap-add allows you to create a bitmap simultaneously alongside a new full backup to accomplish a clean synchronization point. block-dirty-bitmap-clear allows you to reset a bitmap back to as-if it were new, which can also be used alongsid

[Qemu-devel] [PATCH v4 02/11] iotests: add transactional incremental backup test

2015-05-11 Thread John Snow
Test simple usage cases for using transactions to create and synchronize incremental backups. Signed-off-by: John Snow Reviewed-by: Max Reitz Reviewed-by: Stefan Hajnoczi --- tests/qemu-iotests/124 | 54 ++ tests/qemu-iotests/124.out | 4 ++-- 2

[Qemu-devel] [PATCH v4 04/11] block: re-add BlkTransactionState

2015-05-11 Thread John Snow
Now that the structure formerly known as BlkTransactionState has been renamed to something sensible (BlkActionState), re-introduce an actual BlkTransactionState that actually manages state for the entire Transaction. In the process, convert the old QSIMPLEQ list of actions into a QTAILQ, to let us

Re: [Qemu-devel] Help with deadlock when using sound

2015-05-11 Thread Programmingkid
On May 10, 2015, at 10:54 AM, Paolo Bonzini wrote: > > > On 06/05/2015 18:40, Programmingkid wrote: >> When I try to use the pcspk sound hardware, QEMU freezes and uses >> 100% of the cpu time. This is the command I use: >> >> qemu-system-i386 -cdrom -soundhw pcspk >> >> This looks like a de

Re: [Qemu-devel] [PATCH v2] rules.mak: Force CFLAGS for all objects in DSO

2015-05-11 Thread Andreas Färber
Am 07.05.2015 um 08:55 schrieb Fam Zheng: > Because of the trick of process-archive-undefs, all .mo objects, even > with --enable-modules, are dependencies of executables. > > This breaks CFLAGS propogation because the compiling of module object > will happen too early before building for DSO. >

[Qemu-devel] [PATCH 3/3] ui/cocoa.m: Add Reset and Power Down menu items to Machine menu

2015-05-11 Thread Programmingkid
Adds Reset and Power Down menu items to the Machine menu. Signed-off-by: John Arbuckle --- ui/cocoa.m | 24 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 5e558ea..2c4a61a 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -828

[Qemu-devel] [PATCH 2/3] ui/cocoa.m: Adds device menu items to Machine menu

2015-05-11 Thread Programmingkid
Adds all removable devices to the Machine menu as a Change and Eject menu item pair. ide-cd0 would have a "Change ide-cd0..." and "Eject ide-cd0" menu items. Signed-off-by: John Arbuckle --- ui/cocoa.m | 113 ++-- 1 files changed, 110

[Qemu-devel] [PATCH 1/3] ui/cocoa.m: adds Machine menu with pause and resume menu items

2015-05-11 Thread Programmingkid
Adds a Machine menu to the Macintosh interface that pause and resume menu items. These items can either pause or resume execution of the guest operating system. Signed-off-by: John Arbuckle --- ui/cocoa.m | 79 1 files changed, 79 i

[Qemu-devel] [patch 0/3] ui/cocoa.m: Add Machine menu

2015-05-11 Thread Programmingkid
This patch series adds a machine menu to the Macintosh interface. Patch 1/3 adds the machine menu with pause and resume menu items. Patch 2/3 adds menu items for all devices that are available. Patch 3/3 adds Reset and Power Down menu items.

Re: [Qemu-devel] [PATCH 05/10 v10] target-tilegx/opcode_tilegx.h: Modify it to fit qemu using

2015-05-11 Thread Richard Henderson
On 05/11/2015 02:06 PM, Chen Gang wrote: > On 5/12/15 00:01, Richard Henderson wrote: >> On 05/10/2015 03:42 PM, Chen Gang wrote: >>> -static __inline unsigned int >>> +static inline uint8_t >>> get_BFEnd_X0(tilegx_bundle_bits num) >> >> Do not change these casts to uint8_t. It's unnecessary chur

Re: [Qemu-devel] Bug report - Windows XP guest failure

2015-05-11 Thread Programmingkid
On May 7, 2015, at 5:34 AM, Michael Tokarev wrote: > 07.05.2015 09:47, Michael Tokarev wrote: >> 07.05.2015 09:12, Michael Tokarev wrote: >>> 07.05.2015 04:11, G 3 wrote: Did you boot Windows XP to the desktop? I have tested Windows 95, Windows 2000, and Windows XP. All of them fail to

Re: [Qemu-devel] [PATCH 09/10 v10] target-tilegx: Generate tcg instructions to execute to _init_malloc in glib

2015-05-11 Thread Chen Gang
Firstly, thank you very much for your response quickly! On 5/12/15 00:55, Richard Henderson wrote: > On 05/10/2015 03:45 PM, Chen Gang wrote: >> +static void gen_cmpltsi(struct DisasContext *dc, >> +uint8_t rdst, uint8_t rsrc, int8_t imm8) >> +{ >> +qemu_log_mask(CPU_L

Re: [Qemu-devel] [PATCH 05/10 v10] target-tilegx/opcode_tilegx.h: Modify it to fit qemu using

2015-05-11 Thread Chen Gang
On 5/12/15 00:01, Richard Henderson wrote: > On 05/10/2015 03:42 PM, Chen Gang wrote: >> -static __inline unsigned int >> +static inline uint8_t >> get_BFEnd_X0(tilegx_bundle_bits num) > > Do not change these casts to uint8_t. It's unnecessary churn. > For me, it is enough to return uint8_t, a

[Qemu-devel] [PATCH 11/13] piix: Move pc-0.13 virtio-9p-pci compat to PC_COMPAT_0_13

2015-05-11 Thread Eduardo Habkost
The compat property was added by commit 9dbcca5aa13cb9ab40788ac4c56bc227d94ca920, and the pc-0.12 and older machine-types were not changed because virtio-9p-pci was introduced on QEMU 0.13 (commit 9f10751365b26b13b8a9b67e0e90536ae3d282df). The only problem is that this breaks the PC_COMPAT_* nestin

Re: [Qemu-devel] [PATCH 17/33] spapr_drc: initial implementation of sPAPRDRConnector device

2015-05-11 Thread Alexander Graf
On 08.05.15 02:01, David Gibson wrote: > On Fri, May 08, 2015 at 12:39:20AM +0200, Alexander Graf wrote: >> >> >> On 07.05.15 07:33, David Gibson wrote: >>> From: Michael Roth >>> >>> This device emulates a firmware abstraction used by pSeries guests to >>> manage hotplug/dynamic-reconfiguration

[Qemu-devel] [PATCH 12/13] piix: Move pc-0.1[23] rombar compat props to PC_COMPAT_0_13

2015-05-11 Thread Eduardo Habkost
The VGA and vmware-svga rombar compat properties were added by commit 281a26b15b4adcecb8604216738975abd754bea8, but only to pc-0.13 and pc-0.12. This breaks the PC_COMPAT_* nesting pattern we currently follow. The new variables will now be inherited by pc-0.11 and older, but pc-0.11 and pc-0.10 al

[Qemu-devel] [PATCH 13/13] pc_piix: Define PC_COMPAT_0_10

2015-05-11 Thread Eduardo Habkost
Move compat_props from pc-0.10 to the macro, to make it consistent with the other machines. Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c | 47 +-- 1 file changed, 25 insertions(+), 22 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_pi

[Qemu-devel] [PATCH 09/13] piix: Move pc-0.14 qxl compat properties to PC_COMPAT_0_14

2015-05-11 Thread Eduardo Habkost
Those properties were introduced by commit 3827cdb1c3aa17a792d1658161195b9d7173c26b. They were not duplicated into pc-0.13 and older because 0.14 was the first QEMU version supporting qxl. The only problem is that this breaks the PC_COMPAT_* nesting pattern we currently use. So, move the propertie

[Qemu-devel] [PATCH 07/13] spapr: Use HW_COMPAT_* inside SPAPR_COMPAT_* macros

2015-05-11 Thread Eduardo Habkost
SPAPR_COMPAT_2_1 will need to include both HW_COMPAT_2_2 and HW_COMPAT_2_1, so include HW_COMPAT_2_1 inside SPAPR_COMPAT_2_1 and HW_COMPAT_2_2 inside SPAPR_COMPAT_2_2. Signed-off-by: Eduardo Habkost --- hw/ppc/spapr.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/pp

[Qemu-devel] [PATCH 08/13] spapr: define SPAPR_COMPAT_2_3

2015-05-11 Thread Eduardo Habkost
Don't add the pseries-2.3 machine yet, but define the corresponding SPAPR_COMPAT macro to make sure both pseries-2.2 and pseries-2.1 will inherit HW_COMPAT_2_3. Signed-off-by: Eduardo Habkost --- hw/ppc/spapr.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr

[Qemu-devel] [PATCH 05/13] hw: Define empty HW_COMPAT_2_[23] macros

2015-05-11 Thread Eduardo Habkost
Now we can make everything consistent and define the macros even if they are still empty. Signed-off-by: Eduardo Habkost --- include/hw/compat.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/hw/compat.h b/include/hw/compat.h index c56a698..4a43466 100644 --- a/include/hw/comp

[Qemu-devel] [PATCH 10/13] piix: Move pc-0.11 drive version compat props to PC_COMPAT_0_11

2015-05-11 Thread Eduardo Habkost
The current code setting ide-drive.ver and scsi-disk.ver on pc-0.11 breaks the PC_COMPAT_* nesting pattern we currently use. As those variables are overwritten in pc-0.10 too, they can be inherited by pc-0.10 with no side-effects at all. Cc: Gerd Hoffmann Signed-off-by: Eduardo Habkost --- hw/

[Qemu-devel] [PATCH 03/13] pc: Move commas inside PC_COMPAT_* macros

2015-05-11 Thread Eduardo Habkost
Changing the convention to include commas inside the macros will allow macros containing empty lists to be defined and used without compilation errors. Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c| 62 ++-- hw/i386/pc_q35.c | 10 +++

[Qemu-devel] [PATCH 01/13] pc: Replace tab with spaces

2015-05-11 Thread Eduardo Habkost
Coding style change only. Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c| 2 +- include/hw/i386/pc.h | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 1fe7bfb..b4ec3ce 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i

[Qemu-devel] [PATCH 06/13] pc: Define PC_COMPAT_2_[123] macros

2015-05-11 Thread Eduardo Habkost
Once we start adding compat code for pc-2.3, the usage of HW_COMPAT_2_1 in pc-*-2.2 won't be enough, as it also has to include PC_COMPAT_2_3 inside it. To ensure that, define PC_COMPAT_2_3, PC_COMPAT_2_2, and PC_COMPAT_2_1 macros. Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c| 10

[Qemu-devel] [PATCH 00/13] pc, hw, spapr: Cleanup of {HW, PC, SPAPR}_COMPAT_* macros

2015-05-11 Thread Eduardo Habkost
This series does some changes to make the macros more consistent. Now every pc and pseries version has a corresponding compat macro defined. Eduardo Habkost (13): pc: Replace tab with spaces hw: Move commas inside HW_COMPAT_2_1 macro pc: Move commas inside PC_COMPAT_* macros spapr: Move co

[Qemu-devel] [PATCH 04/13] spapr: Move commas inside SPAPR_COMPAT_* macros

2015-05-11 Thread Eduardo Habkost
Changing the convention to include commas inside the macros will allow macros containing empty lists to be defined and used without compilation errors. Signed-off-by: Eduardo Habkost --- hw/ppc/spapr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/

[Qemu-devel] [PATCH 02/13] hw: Move commas inside HW_COMPAT_2_1 macro

2015-05-11 Thread Eduardo Habkost
Changing the convention to include commas inside the macros will allow macros containing empty lists to be defined and used without compilation errors. Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c| 2 +- hw/i386/pc_q35.c | 2 +- hw/ppc/spapr.c | 2 +- include/hw/compat.h |

Re: [Qemu-devel] [PATCH v2 6/6] iotests: Use event_wait in wait_ready

2015-05-11 Thread John Snow
On 05/06/2015 12:52 AM, Fam Zheng wrote: > Only poll the specific type of event we are interested in, to avoid > stealing events that should be consumed by someone else. > > Suggested-by: John Snow > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/iotests.py | 9 ++--- > 1 file change

Re: [Qemu-devel] [PULL 3/6] console-gl: add opengl rendering helper functions

2015-05-11 Thread Alexander Graf
On 08.05.15 08:24, Gerd Hoffmann wrote: > On Fr, 2015-05-08 at 00:28 +0200, Alexander Graf wrote: >> >> On 05.05.15 11:43, Gerd Hoffmann wrote: >>> Signed-off-by: Gerd Hoffmann >>> Reviewed-by: Max Reitz >>> --- >> >> [...] >> >>> +void surface_gl_create_texture(ConsoleGLState *gls, >>> +

Re: [Qemu-devel] [RFC PATCH 02/34] tcg+qom: QOMify core CPU defintions

2015-05-11 Thread Richard Henderson
On 05/11/2015 03:24 AM, Paolo Bonzini wrote: > > > On 11/05/2015 12:18, Andreas Färber wrote: +int (*cpu_mmu_index)(CPUState *cpu); +void (*cpu_get_tb_cpu_state)(CPUState *cpu, + void *pc, /* target_long * */ +

Re: [Qemu-devel] [PATCH 1/1] Add support for PCI Enhanced Allocation "BARs"

2015-05-11 Thread Sean O. Stalley
On Mon, May 11, 2015 at 09:26:08PM +0200, Michael S. Tsirkin wrote: > On Mon, May 11, 2015 at 11:56:44AM -0700, Sean O. Stalley wrote: > > PCI Enhanced Allocation is a new method of allocating MMIO & IO > > resources for PCI devices & bridges. It can be used instead > > of the traditional PCI metho

Re: [Qemu-devel] [PATCH v2 5/6] qemu-iotests: Add test case for mirror with unmap

2015-05-11 Thread John Snow
On 05/06/2015 12:52 AM, Fam Zheng wrote: > This checks that the discard on mirror source that effectively zeroes > data is also reflected by the data of target. > > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/131 | 59 > ++ > tests/qemu-

Re: [Qemu-devel] [PATCH 02/17] ipmi: Add a PC ISA type structure

2015-05-11 Thread Corey Minyard
On 05/11/2015 02:42 PM, Paolo Bonzini wrote: > > On 11/05/2015 19:26, Andreas Färber wrote: >> Another problem is that you're using object_new() in realize at all, >> which means that it's too late for any management interface to tweak >> properties on the new device. One possible solution would be

Re: [Qemu-devel] [PATCH v2 4/6] qemu-iotests: Make block job methods common

2015-05-11 Thread John Snow
On 05/06/2015 12:52 AM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/041| 66 > ++- > tests/qemu-iotests/iotests.py | 28 ++ > 2 files changed, 43 insertions(+), 51 deletions(-) > > diff --git a/tests/qe

Re: [Qemu-devel] [PATCH 02/17] ipmi: Add a PC ISA type structure

2015-05-11 Thread Paolo Bonzini
On 11/05/2015 19:26, Andreas Färber wrote: > Another problem is that you're using object_new() in realize at all, > which means that it's too late for any management interface to tweak > properties on the new device. One possible solution would be to create > the object in a property setter, befo

Re: [Qemu-devel] [PATCH 1/1] Add support for PCI Enhanced Allocation "BARs"

2015-05-11 Thread Michael S. Tsirkin
On Mon, May 11, 2015 at 11:56:44AM -0700, Sean O. Stalley wrote: > PCI Enhanced Allocation is a new method of allocating MMIO & IO > resources for PCI devices & bridges. It can be used instead > of the traditional PCI method of using BARs. > > EA entries are hardware-initialized to a fixed address

Re: [Qemu-devel] [PATCH v2 2/6] block: Fix dirty bitmap in bdrv_co_discard

2015-05-11 Thread John Snow
On 05/06/2015 12:52 AM, Fam Zheng wrote: > Unsetting dirty globally with discard is not very correct. The discard may > zero > out sectors (depending on can_write_zeroes_with_unmap), we should replicate > this change to destinition side to make sure that the guest sees the same > data. > > Cal

Re: [Qemu-devel] [PATCH v2 3/6] block: Remove bdrv_reset_dirty

2015-05-11 Thread John Snow
On 05/06/2015 12:52 AM, Fam Zheng wrote: > Using this function would always be wrong because a dirty bitmap must > have a specific owner that consumes the dirty bits and calls > bdrv_reset_dirty_bitmap(). > Good point. > Remove the unused function to avoid future misuse. > > Reviewed-by: Eric

[Qemu-devel] [PATCH 1/1] Add support for PCI Enhanced Allocation "BARs"

2015-05-11 Thread Sean O. Stalley
PCI Enhanced Allocation is a new method of allocating MMIO & IO resources for PCI devices & bridges. It can be used instead of the traditional PCI method of using BARs. EA entries are hardware-initialized to a fixed address. Unlike BARs, regions described by EA are cannot be moved. Because of this

[Qemu-devel] [PULL 11/14] qtest: Add base64 encoded read/write

2015-05-11 Thread John Snow
For larger pieces of data that won't need to be debugged and viewing the hex nibbles is unlikely to be useful, we can encode data using base64 instead of encoding each byte as %02x, which leads to some space savings and faster reads/writes. For now, the default is left as hex nibbles in memwrite()

[Qemu-devel] [PULL 14/14] qtest: pre-buffer hex nibs

2015-05-11 Thread John Snow
Instead of converting each byte one-at-a-time and then sending each byte over the wire, use sprintf() to pre-compute all of the hex nibs into a single buffer, then send the entire buffer all at once. This gives a moderate speed boost to memread() and memwrite() functions. Signed-off-by: John Snow

[Qemu-devel] [PULL 12/14] qtest: add memset to qtest protocol

2015-05-11 Thread John Snow
Previously, memset was just a frontend to write() and only stupidly sent the pattern many times across the wire. Let's not discuss who stupidly wrote it like that in the first place. (Hint: It was me.) Signed-off-by: John Snow Message-id: 1430864578-22072-4-git-send-email-js...@redhat.com --- q

  1   2   3   4   >