Re: [Qemu-devel] [PATCH for-2.3? 7/7] tests/tcg: Enable runcom test by default

2015-04-11 Thread Andreas Färber
Am 11.04.2015 um 23:33 schrieb Peter Maydell: > On 11 April 2015 at 21:28, Andreas Färber wrote: >> Are you sure that QEMU / runcom / pi_10.com still try to map to that >> address zero? > > It's the first thing runcom.c's main() does after checking you've > passed it enough command line arguments

Re: [Qemu-devel] [PATCH for-2.3? 7/7] tests/tcg: Enable runcom test by default

2015-04-11 Thread Peter Maydell
On 11 April 2015 at 21:28, Andreas Färber wrote: > Are you sure that QEMU / runcom / pi_10.com still try to map to that > address zero? It's the first thing runcom.c's main() does after checking you've passed it enough command line arguments. -- PMM

Re: [Qemu-devel] make test fails on Mac OS X

2015-04-11 Thread Peter Maydell
On 11 April 2015 at 21:25, Andreas Färber wrote: > Similar in spirit to some of those tests, I had been thinking about > testing linux-user by running host binaries, comparing native and > emulated output. make check only covers the softmmus today. Yeah. I run the linux-user-test binaries from ht

Re: [Qemu-devel] [PATCH for-2.3? 7/7] tests/tcg: Enable runcom test by default

2015-04-11 Thread Andreas Färber
Am 11.04.2015 um 22:22 schrieb Peter Maydell: > On 11 April 2015 at 19:34, Andreas Färber wrote: >> The comment of it requiring root appears outdated - makes no difference. > > This depends on what your system has set for the tunable > /proc/sys/vm/mmap_min_addr. On my system it is 65536 (I think

Re: [Qemu-devel] make test fails on Mac OS X

2015-04-11 Thread Andreas Färber
Am 11.04.2015 um 17:52 schrieb Peter Maydell: > On 11 April 2015 at 16:46, Andreas Färber wrote: >> On Mac OS X, executing qemu-i386 (as opposed to qemu-system-i386) won't >> work though, as darwin-user is no longer available. >> >> Also, the Makefile seems to assume that it's running on x86. > >

Re: [Qemu-devel] [PATCH for-2.3? 7/7] tests/tcg: Enable runcom test by default

2015-04-11 Thread Peter Maydell
On 11 April 2015 at 19:34, Andreas Färber wrote: > The comment of it requiring root appears outdated - makes no difference. This depends on what your system has set for the tunable /proc/sys/vm/mmap_min_addr. On my system it is 65536 (I think Ubuntu and Debian ship like this), and in that case yo

Re: [Qemu-devel] [PATCH RFC 04/19] qapi: Rename generate_enum_full_value() to c_enum_const()

2015-04-11 Thread Eric Blake
On 04/02/2015 11:28 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > scripts/qapi-event.py | 5 ++--- > scripts/qapi-types.py | 6 +++--- > scripts/qapi-visit.py | 4 ++-- > scripts/qapi.py | 6 +++--- > 4 files changed, 10 insertions(+), 11 deletions(-) Nicer name.

Re: [Qemu-devel] [PATCH RFC 02/19] qapi: Fix C identifiers generated for names containing '.'

2015-04-11 Thread Eric Blake
On 04/06/2015 05:25 PM, Eric Blake wrote: > On 04/02/2015 11:28 AM, Markus Armbruster wrote: >> c_fun() maps '.' to '_', c_var() doesn't. Nothing prevents '.' in >> QAPI names that get passed to c_var(). >> >> Which QAPI names get passed to c_fun(), to c_var(), or to both is not >> obvious. Names

[Qemu-devel] [PATCH for-2.3? 5/7] tests/tcg: Fix run-runcom target

2015-04-11 Thread Andreas Färber
The path had not been updated after relocating the TCG tests. Fix this to allow executing the test via `make -C tests/tcg run-runcom`. Signed-off-by: Andreas Färber --- tests/tcg/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/tcg/Makefile b/tests/tcg/Makefile

[Qemu-devel] [PATCH for-2.3? 6/7] tests/tcg: Prettify run-runcom output

2015-04-11 Thread Andreas Färber
Executing the binary pi_10.com terminates without a trailing newline. As it does not seem to be caused by the runcom program and since we can't easily fix pi_10.com, add an echo after executing it. This places "make:" output (or that of a target following it) on a new line as expected. Signed-off

[Qemu-devel] [PATCH for-2.3? 1/7] tests/tcg: Fix test_path build

2015-04-11 Thread Andreas Färber
tests/tcg/test_path.c incorporates source files that rely on GLib. Add GLIB_CFLAGS to QEMU_CFLAGS to fix the build. Signed-off-by: Andreas Färber --- tests/tcg/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/tcg/Makefile b/tests/tcg/Makefile index 89e3342..64f661a 100644 --- a

[Qemu-devel] [PATCH for-2.3? 0/7] tests: Fix TCG make test

2015-04-11 Thread Andreas Färber
Hello, In my quest to improve our test coverage, in light of the recent cpu_copy() breakage, I've taken a stab at make test and actually managed to get most of it to work on x86_64. Regards, Andreas Andreas Färber (7): tests/tcg: Fix test_path build tests/tcg: Fix linux-test build tests/

[Qemu-devel] [PATCH for-2.3? 2/7] tests/tcg: Fix linux-test build

2015-04-11 Thread Andreas Färber
Include a missing system header for struct rusage / getrusage(). Signed-off-by: Andreas Färber --- tests/tcg/linux-test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/tcg/linux-test.c b/tests/tcg/linux-test.c index 1c6c013..15c9d7f 100644 --- a/tests/tcg/linux-test.c +++ b/tests/tcg

[Qemu-devel] [PATCH for-2.3? 7/7] tests/tcg: Enable runcom test by default

2015-04-11 Thread Andreas Färber
The comment of it requiring root appears outdated - makes no difference. pi_10.com terminates reproducibly with "...10559240190274216248". Signed-off-by: Andreas Färber --- tests/tcg/Makefile | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tests/tcg/Makefile b/tests/tcg/M

[Qemu-devel] [PATCH for-2.3? 4/7] tests/tcg: Fix running x86_64 tests

2015-04-11 Thread Andreas Färber
When ARCH != i386, the wrong test target was being added to the list of tests to run. Fix this to have test-x86_64 run as well. Note that test-x86_64 produces two build warnings on gcc 4.8.3, but we don't use -Werror for these tests: test-i386.c:2110:1: warning: specifying vector types with __a

[Qemu-devel] [PATCH for-2.3? 3/7] tests/tcg: Disable hanging test-mmap runs

2015-04-11 Thread Andreas Färber
All three invocations of test-mmap with -p parameters hang without producing any output. Don't call them for now, to let `make test` proceed. Signed-off-by: Andreas Färber --- tests/tcg/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/tcg/Makefile b/tests

[Qemu-devel] [PATCH v2 3/4] qapi: Correctly handle downstream extensions in more locations

2015-04-11 Thread Eric Blake
Now that c_var() handles '.' in downstream extension names, fix the generator to support such names as additional types, enums, members within an enum, branches of a union or alternate, and in arrays. Signed-off-by: Eric Blake --- scripts/qapi-commands.py | 4 ++-- scripts/qapi-types.py| 27

[Qemu-devel] [PATCH v2 4/4] qapi: Test name mangling of downstream extensions

2015-04-11 Thread Eric Blake
So that we don't regress in supporting downstream extensions, make sure that our testsuite covers downstream naming choices in as many places as possible. Signed-off-by: Eric Blake --- tests/qapi-schema/qapi-schema-test.json | 19 +++ tests/qapi-schema/qapi-schema-test.out | 21

[Qemu-devel] [PATCH v2 2/4] qapi: Drop duplicate c_fun() in favor of c_var()

2015-04-11 Thread Eric Blake
Now that the two functions are identical, we only need one of them. Signed-off-by: Eric Blake --- scripts/qapi-commands.py | 15 --- scripts/qapi-event.py| 2 +- scripts/qapi-types.py| 4 ++-- scripts/qapi-visit.py| 4 ++-- scripts/qapi.py | 5 + 5 files

[Qemu-devel] [PATCH v2 1/4] qapi: Fix C identifiers generated for names containing '.'

2015-04-11 Thread Eric Blake
From: Markus Armbruster c_fun() maps '.' to '_', c_var() doesn't. Nothing prevents '.' in QAPI names that get passed to c_var(). Which QAPI names get passed to c_fun(), to c_var(), or to both is not obvious. Names of command parameters and struct type members get passed to c_var(). c_var() st

[Qemu-devel] [PATCH v2 0/4] Fix C identifiers generated for names containing '.'

2015-04-11 Thread Eric Blake
This series of 4 replaces the RFC v1 of 02/19 of Markus' series: https://lists.gnu.org/archive/html/qemu-devel/2015-04/msg00361.html and requires as prereq: v6 of my nested qapi series (currently at 38/36): https://lists.gnu.org/archive/html/qemu-devel/2015-04/msg00486.html as well as prereq: v2

Re: [Qemu-devel] Very poor IO performance which looks like some design problem.

2015-04-11 Thread ein
On 04/11/2015 03:09 PM, Paolo Bonzini wrote: > On 10/04/2015 22:38, ein wrote: >> Qemu creates more than 70 threads and everyone of them tries to write to >> disk, which results in: >> 1. High I/O time. >> 2. Large latency. >> 2. Poor sequential read/write speeds. >> >> When I limited number of cor

Re: [Qemu-devel] make test fails on Mac OS X

2015-04-11 Thread Peter Maydell
On 11 April 2015 at 16:46, Andreas Färber wrote: > On Mac OS X, executing qemu-i386 (as opposed to qemu-system-i386) won't > work though, as darwin-user is no longer available. > > Also, the Makefile seems to assume that it's running on x86. Yes, it has all sorts of problems. We should probably s

Re: [Qemu-devel] make test fails on Mac OS X

2015-04-11 Thread Andreas Färber
Am 10.04.2015 um 19:56 schrieb Programmingkid: > The 'make test' command fails to build on Mac OS X. This is because of a > missing header file. Here is the error: > > include/glib-compat.h:19:18: fatal error: glib.h: No such file or directory > #include On Linux, this gets me past that point,

Re: [Qemu-devel] [Qemu-block] Migration sometimes fails with IDE and Qemu 2.2.1

2015-04-11 Thread Peter Lieven
Am 11.04.2015 um 15:11 schrieb Peter Lieven: > Am 09.04.2015 um 17:17 schrieb Paolo Bonzini: >> On 09/04/2015 16:54, Peter Lieven wrote: >>> #define BM_MIGRATION_COMPAT_STATUS_BITS \ >>> (IDE_RETRY_DMA | IDE_RETRY_PIO | \ >>> IDE_RETRY_READ | IDE_RETRY_FLUSH) >>> >>> Why is there no

Re: [Qemu-devel] Failing iotests in v2.3.0-rc2 / master

2015-04-11 Thread Andreas Färber
Am 11.04.2015 um 05:41 schrieb Andreas Färber: > Hi, > > 001 seems to hang for -qcow (or is not reasonably "quick": >5 min). > > 033 is failing for -vhdx. 067 is failing for -qcow2 on ppc64 (no $QEMU_PROG => qemu-system-ppc64). Seems to hang after the below output. Andreas $ tests/qemu-iotests

Re: [Qemu-devel] [Qemu-block] Migration sometimes fails with IDE and Qemu 2.2.1

2015-04-11 Thread Peter Lieven
Am 09.04.2015 um 17:17 schrieb Paolo Bonzini: > > On 09/04/2015 16:54, Peter Lieven wrote: >> #define BM_MIGRATION_COMPAT_STATUS_BITS \ >> (IDE_RETRY_DMA | IDE_RETRY_PIO | \ >> IDE_RETRY_READ | IDE_RETRY_FLUSH) >> >> Why is there no IDE_RETRY_WRITE ? > Because that's represented by

Re: [Qemu-devel] Very poor IO performance which looks like some design problem.

2015-04-11 Thread Paolo Bonzini
On 10/04/2015 22:38, ein wrote: > > Qemu creates more than 70 threads and everyone of them tries to write to > disk, which results in: > 1. High I/O time. > 2. Large latency. > 2. Poor sequential read/write speeds. > > When I limited number of cores, I guess I limited number of threads as > wel

Re: [Qemu-devel] [PATCH 01/14] memory: Define API for MemoryRegionOps to take attrs and return status

2015-04-11 Thread Edgar E. Iglesias
On Fri, Apr 10, 2015 at 03:51:07PM +0100, Peter Maydell wrote: > On 10 April 2015 at 03:07, Edgar E. Iglesias wrote: > > On Thu, Apr 09, 2015 at 11:21:26AM +0200, Paolo Bonzini wrote: > >> On 09/04/2015 11:04, Peter Maydell wrote: > >> > We discussed this last time round, I think. Whether structs

Re: [Qemu-devel] [PATCH for-2.3] cris: memory: Replace memory_region_init_ram with memory_region_allocate_system_memory

2015-04-11 Thread Edgar E. Iglesias
On Fri, Apr 10, 2015 at 03:29:56PM +0100, Peter Maydell wrote: > On 9 April 2015 at 04:47, Edgar E. Iglesias wrote: > > On Sat, Apr 04, 2015 at 02:15:10PM +0200, Dirk Müller wrote: > >> Commit 0b183fc871:"memory: move mem_path handling to > >> memory_region_allocate_system_memory" split memory_reg