Re: [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary

2015-03-31 Thread Marcel Apfelbaum
On 03/31/2015 05:21 PM, Tony Krowiak wrote: Commit 49d2e648e8087d154d8bf8b91f27c8e05e79d5a6 removed the QemuOptDesc elements from the *desc* field of the *qemu_machine_opts *array defined in vl.c. Since applying that patch to qemu on my system, I can not start a guest from libvirt when certain

Re: [Qemu-devel] [PATCH v2] spapr: populate ibm,loc-code

2015-03-31 Thread Nikunj A Dadhania
Michael Roth writes: > Quoting Alexey Kardashevskiy (2015-03-29 22:08:17) >> On 03/30/2015 01:25 PM, David Gibson wrote: >> > On Mon, Mar 30, 2015 at 01:18:01PM +1100, Alexey Kardashevskiy wrote: >> >> On 03/27/2015 08:49 PM, Nikunj A Dadhania wrote: >> >>> Each hardware instance has a platform u

Re: [Qemu-devel] [PATCH 1/2] vfio-pci: add flag to identify vfio pci device

2015-03-31 Thread Nikunj A Dadhania
Alex Williamson writes: > On Thu, 2015-03-26 at 12:12 +0530, Nikunj A Dadhania wrote: >> From PCIDevice there is no way to know if the device has a backing >> vfio device. >> >> sPAPR guests inherits the "ibm,loc-code" from the pci pass through >> device in hypervisor. This helps in identifying

[Qemu-devel] [PATCH] mirror: hold aio_context before bdrv_drain

2015-03-31 Thread Bin Wu
From: Bin Wu Signed-off-by: Bin Wu --- block/mirror.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/mirror.c b/block/mirror.c index 4056164..08372df 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -530,7 +530,9 @@ static void coroutine_fn mirror_run(void *opaque)

Re: [Qemu-devel] [PATCH v5 5/7] vfio-pci: pass the aer error to guest

2015-03-31 Thread Chen Fan
On 03/25/2015 10:41 AM, Alex Williamson wrote: On Wed, 2015-03-25 at 09:53 +0800, Chen Fan wrote: On 03/16/2015 10:09 PM, Alex Williamson wrote: On Mon, 2015-03-16 at 15:35 +0800, Chen Fan wrote: On 03/16/2015 11:52 AM, Alex Williamson wrote: On Mon, 2015-03-16 at 11:05 +0800, Chen Fan wrote

Re: [Qemu-devel] [RFC PATCH v2 04/23] spapr: Support ibm, lrdr-capacity device tree property

2015-03-31 Thread Bharata B Rao
On Wed, Mar 25, 2015 at 11:15:55AM +1100, David Gibson wrote: > On Mon, Mar 23, 2015 at 07:05:45PM +0530, Bharata B Rao wrote: > > Add support for ibm,lrdr-capacity since this is needed by the guest > > kernel to know about the possible hot-pluggable CPUs and Memory. With > > this, pseries kernels

[Qemu-devel] virtio-scsi + iothread : segfault on drive_del

2015-03-31 Thread Alexandre DERUMIER
Hi, I'm currently testing virtio-scsi and iothread, and I'm seeing qemu segfault when I try to remove an scsi drive on top of an virtio-scsi controller with iothread enabled. virtio-blk + iothread drive_del is supported since this patch http://comments.gmane.org/gmane.comp.emulators.qemu/291

Re: [Qemu-devel] [PATCH v3 1/2] VFIO: Clear stale MSIx table during EEH reset

2015-03-31 Thread Gavin Shan
On Tue, Mar 31, 2015 at 07:16:43PM -0600, Alex Williamson wrote: >On Wed, 2015-04-01 at 11:20 +1100, Gavin Shan wrote: >> On Tue, Mar 31, 2015 at 01:36:30PM -0600, Alex Williamson wrote: >> >On Mon, 2015-03-30 at 20:34 +1100, Gavin Shan wrote: >> >> On Mon, Mar 30, 2015 at 01:39:16PM +1100, David G

[Qemu-devel] [PATCH] qom: Change prototype of user_creatable_complete.

2015-03-31 Thread Lin Ma
>From void user_creatable_complete(Object *obj, Error **errp) to void user_creatable_complete(UserCreatable *uc, Error **errp) Signed-off-by: Lin Ma --- hw/block/dataplane/virtio-blk.c | 4 +++- hw/virtio/virtio-rng.c | 3 ++- include/qom/object_interfaces.h | 4 ++-- qmp.c

Re: [Qemu-devel] [PATCH 2/6] Remove monitor.c dependency on CONFIG_I8259

2015-03-31 Thread David Gibson
On Tue, Mar 31, 2015 at 11:57:28AM +0200, Markus Armbruster wrote: > David Gibson writes: > > > On Mon, Mar 30, 2015 at 10:37:45AM +0200, Markus Armbruster wrote: > [...] > >> This adds "info irq" and "info pic" to the targets that didn't have them > >> before, implemented by i8259.c's hmp_info_p

Re: [Qemu-devel] Bouncing maintainers

2015-03-31 Thread Fam Zheng
On Tue, 03/31 12:01, Markus Armbruster wrote: > John Snow writes: > > > On 03/26/2015 09:19 AM, Kevin Wolf wrote: > >> Am 25.03.2015 um 16:45 hat John Snow geschrieben: > >>> > >>> > >>> On 03/25/2015 10:48 AM, Markus Armbruster wrote: > I just had another cc: to an address gotten from MAINT

[Qemu-devel] [PATCH v2 0/3] null driver patches

2015-03-31 Thread Fam Zheng
v2: Change patch 01 to use realtime clock, that way we don't need to check the VCPU state. [Stefan] Added Eric's rev-by in 2&3. Change title to "Null block driver" in 3. [Eric] The second patch allows testing commit to a null image. The third adds a stanza to MAINTAINERS. Fam Zheng

Re: [Qemu-devel] [PATCH v2 1/2] cpu/apic: drop icc bus/bridge/

2015-03-31 Thread Chen Fan
On 04/01/2015 09:40 AM, Chen Fan wrote: On 03/31/2015 05:51 PM, Igor Mammedov wrote: On Tue, 31 Mar 2015 16:54:43 +0800 Chen Fan wrote: On 03/30/2015 08:45 PM, Igor Mammedov wrote: On Mon, 30 Mar 2015 18:12:06 +0800 Chen Fan wrote: On 03/23/2015 05:43 PM, Igor Mammedov wrote: On Mon, 2

[Qemu-devel] [PATCH v2 3/3] MAINTAINERS: Add Fam Zheng as Null block driver maintainer

2015-03-31 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Eric Blake --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index d7e9ba2..56013b3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1172,6 +1172,12 @@ S: Supported F: block/gluster.c T: git git://github.com/

[Qemu-devel] [PATCH v2 2/3] block/null: Support reopen

2015-03-31 Thread Fam Zheng
Reopen is used in block-commit. With this always-succeed operation, it is now possible to test committing to a null drive, by specifying "null-aio://" or "null-co://" as the backing image when creating the qcow2 image. Signed-off-by: Fam Zheng Reviewed-by: Eric Blake --- block/null.c | 8 ++

[Qemu-devel] [PATCH v2 1/3] block/null: Latency simulation by adding new option "latency-ns"

2015-03-31 Thread Fam Zheng
Aio context switch should just work because the requests will be drained, so the scheduled timer(s) on the old context will be freed. Signed-off-by: Fam Zheng --- block/null.c | 58 ++-- qapi/block-core.json | 5 - 2 files changed, 56

Re: [Qemu-devel] [PATCH] e1000: work around win 8.0 boot hang

2015-03-31 Thread Jason Wang
On Tue, Mar 31, 2015 at 6:17 PM, Radim Krčmář wrote: 2015-03-31 13:26+0800, Jason Wang: On 02/20/2015 03:24 AM, Radim Krčmář wrote: > Window 8.0 driver has a particular behavior for a small time frame after > it enables rx interrupts: the interrupt handler never clears > E1000_ICR_RXT

Re: [Qemu-devel] [PATCH v2 1/2] cpu/apic: drop icc bus/bridge/

2015-03-31 Thread Chen Fan
On 03/31/2015 05:51 PM, Igor Mammedov wrote: On Tue, 31 Mar 2015 16:54:43 +0800 Chen Fan wrote: On 03/30/2015 08:45 PM, Igor Mammedov wrote: On Mon, 30 Mar 2015 18:12:06 +0800 Chen Fan wrote: On 03/23/2015 05:43 PM, Igor Mammedov wrote: On Mon, 23 Mar 2015 17:07:29 +0800 Chen Fan wrote:

Re: [Qemu-devel] [PATCH 3/3] MAINTAINERS: Add Fam Zheng as Null block driver maintainer

2015-03-31 Thread Fam Zheng
On Mon, 03/30 06:53, Eric Blake wrote: > On 03/30/2015 03:23 AM, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > --- > > MAINTAINERS | 6 ++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index d7e9ba2..30073a3 100644 > > --- a/MAINTAINERS > > +++ b/

Re: [Qemu-devel] [PATCH v3 1/2] VFIO: Clear stale MSIx table during EEH reset

2015-03-31 Thread Alex Williamson
On Wed, 2015-04-01 at 11:20 +1100, Gavin Shan wrote: > On Tue, Mar 31, 2015 at 01:36:30PM -0600, Alex Williamson wrote: > >On Mon, 2015-03-30 at 20:34 +1100, Gavin Shan wrote: > >> On Mon, Mar 30, 2015 at 01:39:16PM +1100, David Gibson wrote: > >> >On Thu, Mar 26, 2015 at 04:35:01PM +1100, Gavin Sh

Re: [Qemu-devel] [v3][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-31 Thread Chen, Tiejun
On 2015/3/30 17:19, Ian Campbell wrote: On Mon, 2015-03-30 at 09:28 +0800, Chen, Tiejun wrote: Sounds it should be a legacy fix to qemu-xen-tranditional :) So lets do it now, @@ -326,6 +326,10 @@ static char ** libxl__build_device_model_args_old(libxl__gc *gc, } if (libxl_

Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns

2015-03-31 Thread John Snow
On 03/31/2015 08:29 PM, Ed Maste wrote: On 31 March 2015 at 17:55, Ed Maste wrote: feynman% ./tests/ahci-test /i386/ahci/sanity: OK /i386/ahci/pci_spec: OK /i386/ahci/pci_enable: OK /i386/ahci/hba_spec: OK /i386/ahci/hba_enable: OK /i386/ahci/identify: OK /i386/ahci/io/pio/lba28/simple: ** E

Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns

2015-03-31 Thread Ed Maste
On 31 March 2015 at 17:55, Ed Maste wrote: > > feynman% ./tests/ahci-test > /i386/ahci/sanity: OK > /i386/ahci/pci_spec: OK > /i386/ahci/pci_enable: OK > /i386/ahci/hba_spec: OK > /i386/ahci/hba_enable: OK > /i386/ahci/identify: OK > /i386/ahci/io/pio/lba28/simple: ** > ERROR:tests/ahci-test.c:790

Re: [Qemu-devel] [PATCH v3 1/2] VFIO: Clear stale MSIx table during EEH reset

2015-03-31 Thread Gavin Shan
On Tue, Mar 31, 2015 at 01:36:30PM -0600, Alex Williamson wrote: >On Mon, 2015-03-30 at 20:34 +1100, Gavin Shan wrote: >> On Mon, Mar 30, 2015 at 01:39:16PM +1100, David Gibson wrote: >> >On Thu, Mar 26, 2015 at 04:35:01PM +1100, Gavin Shan wrote: >> >> The PCI device MSIx table is cleaned out in h

Re: [Qemu-devel] [PATCH v5 06/28] qapi: Add some union tests

2015-03-31 Thread Eric Blake
On 03/30/2015 04:45 PM, Eric Blake wrote: > On 03/26/2015 09:58 AM, Markus Armbruster wrote: > /home/armbru/work/qemu/.git/rebase-apply/patch:325: new blank line at EOF. >>> >>> Huh. I thought I had git set up to reject me from making commits like >>> that locally, but obviously not. >> >> Th

Re: [Qemu-devel] ppc vga output breakage since commit c3c1bb99

2015-03-31 Thread Mark Cave-Ayland
On 30/03/15 12:47, Paolo Bonzini wrote: > On 30/03/2015 13:45, Peter Crosthwaite wrote: >> Can the address_space_translate_address() length clamp be made >> conditional on non-MMIO access as the RC fix? I submitted >> c3c1bb99d1c11978d9ce94d1bdcf0705378c1459 as I think its the right >> thing to do

Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns

2015-03-31 Thread John Snow
On 03/31/2015 05:55 PM, Ed Maste wrote: On 31 March 2015 at 17:44, John Snow wrote: My apologies; Not at all, thanks for your help! Head into your build directory and try this: make tests/ahci-test export QTEST_QEMU_BINARY=i386-softmmu/qemu-system-i386 export QTEST_QEMU_IMG=./qemu-img ./

Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns

2015-03-31 Thread Ed Maste
On 31 March 2015 at 17:44, John Snow wrote: > > My apologies; Not at all, thanks for your help! > Head into your build directory and try this: > >> make tests/ahci-test >> export QTEST_QEMU_BINARY=i386-softmmu/qemu-system-i386 >> export QTEST_QEMU_IMG=./qemu-img >> ./tests/ahci-test > > This sho

Re: [Qemu-devel] [PATCH for-2.3 0/3] ioport fixes

2015-03-31 Thread Mark Cave-Ayland
On 30/03/15 12:45, Paolo Bonzini wrote: > These fix the problem with OpenBIOS's accesses to the VBE DISPI ports. > The problem stems from weird memory regions created by ioport.c. > > Patches 1-3 simplify some of the MemoryRegionPortio arrays. This makes it > easier to ascertain the effect of pa

Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns

2015-03-31 Thread John Snow
On 03/31/2015 05:29 PM, Ed Maste wrote: On 31 March 2015 at 16:58, John Snow wrote: which test case does it fail under? io_rw_simple is shared by a number of different tests. I'm not sure off hand how to run an individual test to confirm, but the testrun output up to the failure is: LI

Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns

2015-03-31 Thread Ed Maste
On 31 March 2015 at 16:58, John Snow wrote: > > which test case does it fail under? io_rw_simple is shared by a number of > different tests. I'm not sure off hand how to run an individual test to confirm, but the testrun output up to the failure is: LINK tests/spapr-phb-test GTESTER check-qte

Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns

2015-03-31 Thread John Snow
On 03/31/2015 04:55 PM, Ed Maste wrote: On 23 March 2015 at 12:56, John Snow wrote: My pattern was cyclical every 256 bytes, so it missed a fairly obvious failure case. Add some rand() pepper into the test pattern, and for large patterns that exceed 256 sectors, start writing an ID per-sector

Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns

2015-03-31 Thread Ed Maste
On 23 March 2015 at 12:56, John Snow wrote: > My pattern was cyclical every 256 bytes, so it missed a fairly obvious > failure case. Add some rand() pepper into the test pattern, and for large > patterns that exceed 256 sectors, start writing an ID per-sector so that > we never generate identical

Re: [Qemu-devel] [PATCH v5 06/28] qapi: Add some union tests

2015-03-31 Thread Markus Armbruster
Kevin Wolf writes: > Am 26.03.2015 um 16:04 hat Eric Blake geschrieben: >> On 03/26/2015 07:18 AM, Markus Armbruster wrote: >> > Eric Blake writes: >> >> Meanwhile, it would be nice to allow >> >> 'discriminator':'EnumType' without 'base' for creating a simple union >> >> tha

Re: [Qemu-devel] [PATCH v4 12/15] Add optional parameters to QMP command query-cpu-definitions

2015-03-31 Thread Michael Mueller
On Tue, 31 Mar 2015 16:46:56 -0300 Eduardo Habkost wrote: > On Mon, Mar 30, 2015 at 04:28:25PM +0200, Michael Mueller wrote: > [...] > > ## > > # @query-cpu-definitions: > > # > > # Return a list of supported virtual CPU definitions > > # > > +# @machine: #optional machine type (since 2.4) >

Re: [Qemu-devel] [PATCH v5 17/28] qapi: Allow true, false and null in schema json

2015-03-31 Thread Markus Armbruster
Kevin Wolf writes: > Am 24.03.2015 um 21:03 hat Eric Blake geschrieben: >> From: Fam Zheng >> >> In the near term, we will use it for a sensible-looking >> 'gen':false inside command declarations, instead of the >> current ugly 'gen':'no'. >> >> In the long term, it will allow conversion from

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-03-31 Thread Michael Mueller
On Tue, 31 Mar 2015 15:35:26 -0300 Eduardo Habkost wrote: > On Mon, Mar 30, 2015 at 04:28:24PM +0200, Michael Mueller wrote: > > This patch implements a new QMP request named 'query-cpu-model'. > > It returns the cpu model of cpu 0 and its backing accelerator. > > > > request: > > {"execute" :

Re: [Qemu-devel] [PATCH v4 12/15] Add optional parameters to QMP command query-cpu-definitions

2015-03-31 Thread Eric Blake
On 03/31/2015 01:46 PM, Eduardo Habkost wrote: > On Mon, Mar 30, 2015 at 04:28:25PM +0200, Michael Mueller wrote: > [...] >> ## >> # @query-cpu-definitions: >> # >> # Return a list of supported virtual CPU definitions >> # >> +# @machine: #optional machine type (since 2.4) >> +# >> +# @accel:

Re: [Qemu-devel] [PATCH 2/2] tpm: Modify DPRINTF to enable -Wformat checking

2015-03-31 Thread Eric Blake
On 03/31/2015 12:49 PM, Stefan Berger wrote: > Modify DPRINTF to always enable -Wformat checking. > > Signed-off-by: Stefan Berger > --- > hw/tpm/tpm_passthrough.c | 16 +++- > hw/tpm/tpm_tis.c | 14 ++ > 2 files changed, 13 insertions(+), 17 deletions(-) > Revi

Re: [Qemu-devel] [PATCH 1/2] tpm: Cast 64bit variables to int when used in DPRINTF

2015-03-31 Thread Eric Blake
On 03/31/2015 12:49 PM, Stefan Berger wrote: > Cast 64bit variables to int when used in DPRINTF. They only contain > 32bit of data. > > Signed-off-by: Stefan Berger > --- > hw/tpm/tpm_tis.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) The --cover-letter option is nice when se

Re: [Qemu-devel] [PATCH v4 12/15] Add optional parameters to QMP command query-cpu-definitions

2015-03-31 Thread Eduardo Habkost
On Mon, Mar 30, 2015 at 04:28:25PM +0200, Michael Mueller wrote: [...] > ## > # @query-cpu-definitions: > # > # Return a list of supported virtual CPU definitions > # > +# @machine: #optional machine type (since 2.4) > +# > +# @accel: #optional accelerator id (since 2.4) > +# > # Returns: a l

[Qemu-devel] [PATCH 3/3] TPM2 ACPI table support

2015-03-31 Thread Stefan Berger
Add a TPM2 ACPI table if a TPM2 is used in the backend. Rename tpm_find() to tpm_get_version() and have this function return the version of the TPM found, TPMVersion_Unspec if no TPM is found. Use the version number to build version specific ACPI tables. Signed-off-by: Stefan Berger --- hw/i386

[Qemu-devel] [PATCH 0/3] tpm: Upgrade TPM TIS for support of a TPM 2

2015-03-31 Thread Stefan Berger
The following series of patches is targeted for QEMU 2.4. After the previous upgrade of the TPM TIS to version 1.3, we now upgrade it to support a TPM 2 in the backend. Stefan Berger (3): Extend TPM TIS interface to version 2.0 tpm: Probe for connected TPM1.2 or TPM2.0 TPM2 ACPI tables supp

[Qemu-devel] [PATCH 1/3] Extend TPM TIS interface to version 2.0

2015-03-31 Thread Stefan Berger
Following the recent upgrade to version 1.3, extend the TPM TIS interface with capabilities introduced for support of a TPM 2. TPM TIS for TPM 2 introduced the following extensions beyond the TPM TIS 1.3 (used for TPM 1.2): - A new 32bit interface Id register was introduced. - New flags for the s

[Qemu-devel] [PATCH 2/3] tpm: Probe for connected TPM 1.2 or TPM 2

2015-03-31 Thread Stefan Berger
In the TPM passthrough backend driver, modify the probing code so that we can check whether a TPM 1.2 or TPM 2 is being used and adapt the behavior of the TPM TIS accordingly. Move the code that tested for a TPM 1.2 into tpm_utils.c and extend it with test for probing for TPM 2. Have the function

Re: [Qemu-devel] [PATCH v3 1/2] VFIO: Clear stale MSIx table during EEH reset

2015-03-31 Thread Alex Williamson
On Mon, 2015-03-30 at 20:34 +1100, Gavin Shan wrote: > On Mon, Mar 30, 2015 at 01:39:16PM +1100, David Gibson wrote: > >On Thu, Mar 26, 2015 at 04:35:01PM +1100, Gavin Shan wrote: > >> The PCI device MSIx table is cleaned out in hardware after EEH PE > >> reset. However, we still hold the stale MSI

Re: [Qemu-devel] [PATCH] bios-tables-test: handle false-positive smbios signature matches

2015-03-31 Thread Bruce Rogers
>>> On 3/31/2015 at 12:32 PM, "Gabriel L. Somlo" wrote: > Rather than stopping at the first match for the SMBIOS signature > ("_SM_") in the f-segment (0xF-0xF), continue scanning > until either a valid entry point table is found, or the f-segment > has been exhausted. > > Signed-off-by:

Re: [Qemu-devel] [Migration Bug? ] Occasionally, the content of VM's memory is inconsistent between Source and Destination of migration

2015-03-31 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > On 2015/3/30 15:59, Dr. David Alan Gilbert wrote: > >* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > >>On 2015/3/27 18:18, Dr. David Alan Gilbert wrote: > >>>* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > On 2015/3/2

[Qemu-devel] [PATCH 1/2] tpm: Cast 64bit variables to int when used in DPRINTF

2015-03-31 Thread Stefan Berger
Cast 64bit variables to int when used in DPRINTF. They only contain 32bit of data. Signed-off-by: Stefan Berger --- hw/tpm/tpm_tis.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c index 815c8ea..cb9c7c8 100644 --- a/hw/tpm/tpm_tis.

[Qemu-devel] [PATCH 2/2] tpm: Modify DPRINTF to enable -Wformat checking

2015-03-31 Thread Stefan Berger
Modify DPRINTF to always enable -Wformat checking. Signed-off-by: Stefan Berger --- hw/tpm/tpm_passthrough.c | 16 +++- hw/tpm/tpm_tis.c | 14 ++ 2 files changed, 13 insertions(+), 17 deletions(-) diff --git a/hw/tpm/tpm_passthrough.c b/hw/tpm/tpm_passthrough.c i

[Qemu-devel] [PATCH] bios-tables-test: handle false-positive smbios signature matches

2015-03-31 Thread Gabriel L. Somlo
Rather than stopping at the first match for the SMBIOS signature ("_SM_") in the f-segment (0xF-0xF), continue scanning until either a valid entry point table is found, or the f-segment has been exhausted. Signed-off-by: Gabriel Somlo --- tests/bios-tables-test.c | 76 +++

Re: [Qemu-devel] [PATCH v5 06/28] qapi: Add some union tests

2015-03-31 Thread Eric Blake
On 03/31/2015 12:15 PM, Eric Blake wrote: >>> Cool. Or more concretely, >>> >>> { 'union': 'Simple', 'data': { 'one': 'str', 'two': 'int' } } >>> >>> is identical on the wire to: >>> >>> { 'enum': 'MyEnum', 'data': ['one', 'two'] } >>> { 'type': 'Base', 'data': { 'type': 'MyEnum' } } >>> { 'type'

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-03-31 Thread Eduardo Habkost
On Mon, Mar 30, 2015 at 04:28:24PM +0200, Michael Mueller wrote: > This patch implements a new QMP request named 'query-cpu-model'. > It returns the cpu model of cpu 0 and its backing accelerator. > > request: > {"execute" : "query-cpu-model" } > > answer: > {"return" : {"name": "2827-ga2", "

Re: [Qemu-devel] [PATCH v5 06/28] qapi: Add some union tests

2015-03-31 Thread Kevin Wolf
Am 31.03.2015 um 20:15 hat Eric Blake geschrieben: > On 03/31/2015 11:13 AM, Kevin Wolf wrote: > > >> [3] > >> { 'union':'SimpleAndSafe', 'discriminator':'MyEnum', > >> 'data':{ 'one':'str', 'two':'int' }} > >> > >> {"execute":"foo", "arguments":{'type':'one', 'data':'hello'}} > > > > This woul

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-03-31 Thread Eduardo Habkost
On Tue, Mar 31, 2015 at 01:21:05PM +0200, Michael Mueller wrote: > On Mon, 30 Mar 2015 17:17:21 -0300 > Eduardo Habkost wrote: > > > On Mon, Mar 30, 2015 at 04:28:24PM +0200, Michael Mueller wrote: > > > This patch implements a new QMP request named 'query-cpu-model'. > > > It returns the cpu mod

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-31 Thread Andrey Korolyov
On Tue, Mar 31, 2015 at 9:04 PM, Bandan Das wrote: > Bandan Das writes: > >> Andrey Korolyov writes: >> ... >>> http://xdel.ru/downloads/kvm-e5v2-issue/another-tracepoint-fail-with-apicv.dat.gz >>> >>> Something a bit more interesting, but the mess is happening just >>> *after* NMI firing. >> >>

Re: [Qemu-devel] [PATCH] balloon: improve error msg when adding second device

2015-03-31 Thread Eric Blake
On 03/31/2015 11:32 AM, Luiz Capitulino wrote: > A VM supports only one balloon device, but due to several changes > in infrastructure the error message got messed up when trying > to add a second device. Fix it. > > Before this fix > > After this fix [nice comparison snipped] > > Signed-off-

Re: [Qemu-devel] [PATCH 1/2] vfio-pci: add flag to identify vfio pci device

2015-03-31 Thread Alex Williamson
On Thu, 2015-03-26 at 12:12 +0530, Nikunj A Dadhania wrote: > From PCIDevice there is no way to know if the device has a backing > vfio device. > > sPAPR guests inherits the "ibm,loc-code" from the pci pass through > device in hypervisor. This helps in identifying the device if there is > any fail

Re: [Qemu-devel] [PATCH v5 06/28] qapi: Add some union tests

2015-03-31 Thread Eric Blake
On 03/31/2015 11:13 AM, Kevin Wolf wrote: >> [3] >> { 'union':'SimpleAndSafe', 'discriminator':'MyEnum', >> 'data':{ 'one':'str', 'two':'int' }} >> >> {"execute":"foo", "arguments":{'type':'one', 'data':'hello'}} > > This would overload 'discriminator' with two different meanings: > > * In cas

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-31 Thread Bandan Das
Bandan Das writes: > Andrey Korolyov writes: > ... >> http://xdel.ru/downloads/kvm-e5v2-issue/another-tracepoint-fail-with-apicv.dat.gz >> >> Something a bit more interesting, but the mess is happening just >> *after* NMI firing. > > What happens if NMI is turned off on the host ? Sorry, I mean

Re: [Qemu-devel] [PATCH v2] tpm_tis: fix format for 64bit variable

2015-03-31 Thread Stefan Berger
On 03/31/2015 12:50 PM, Eric Blake wrote: On 03/31/2015 09:05 AM, Stefan Berger wrote: Signed-off-by: Stefan Berger --- hw/tpm/tpm_tis.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake Then let me withdraw this one and fix it as you suggested now. Stefa

Re: [Qemu-devel] [PATCH 1/2] CVE-2015-1779: incrementally decode websocket frames

2015-03-31 Thread Peter Maydell
On 23 March 2015 at 22:58, Daniel P. Berrange wrote: > -if (*payload_size < 126) { > -header_size = 6; > -mask = header->u.m; > -} else if (*payload_size == 126 && input->offset >= 8) { > -*payload_size = be16_to_cpu(header->u.s16.l16); > -header_size = 8; >

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-31 Thread Bandan Das
Andrey Korolyov writes: ... > http://xdel.ru/downloads/kvm-e5v2-issue/another-tracepoint-fail-with-apicv.dat.gz > > Something a bit more interesting, but the mess is happening just > *after* NMI firing. What happens if NMI is turned off on the host ?

Re: [Qemu-devel] [PATCH v2] spapr: populate ibm,loc-code

2015-03-31 Thread Michael Roth
Quoting Alexey Kardashevskiy (2015-03-29 22:08:17) > On 03/30/2015 01:25 PM, David Gibson wrote: > > On Mon, Mar 30, 2015 at 01:18:01PM +1100, Alexey Kardashevskiy wrote: > >> On 03/27/2015 08:49 PM, Nikunj A Dadhania wrote: > >>> Each hardware instance has a platform unique location code. The OF

Re: [Qemu-devel] [PATCH 1/2] CVE-2015-1779: incrementally decode websocket frames

2015-03-31 Thread Peter Maydell
On 23 March 2015 at 22:58, Daniel P. Berrange wrote: > +int vncws_decode_frame_payload(Buffer *input, > + size_t *payload_remain, WsMask *payload_mask, > + uint8_t **payload, size_t *payload_size) > +{ > +size_t i; > +uint32_t *pa

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-31 Thread Andrey Korolyov
On Tue, Mar 31, 2015 at 7:45 PM, Radim Krčmář wrote: > 2015-03-31 17:56+0300, Andrey Korolyov: >> > Chasing the culprit this way could take a long time, so a new tracepoint >> > that shows if 0xef is set on entry would let us guess the bug faster ... >> > >> > Please provide a failing trace with t

[Qemu-devel] [PATCH] balloon: improve error msg when adding second device

2015-03-31 Thread Luiz Capitulino
A VM supports only one balloon device, but due to several changes in infrastructure the error message got messed up when trying to add a second device. Fix it. Before this fix Command-line: qemu-qmp: -device virtio-balloon-pci,id=balloon0: Another balloon device already registered qemu-qmp: -de

Re: [Qemu-devel] [PATCH] replaced get_ticks_per_sec() with constant

2015-03-31 Thread Emil Condrea
Thanks, Stefan. On Mon, Mar 30, 2015 at 4:01 PM, Stefan Hajnoczi wrote: > On Sat, Mar 28, 2015 at 06:22:11PM +0200, Emil Condrea wrote: > > This replaces all calls to get_ticks_per_sec() with > > NSEC_PER_SEC defined in /include/qemu/timer.h > > > > Signed-off-by: Emil Condrea > > --- > > audi

Re: [Qemu-devel] [PATCH v5 01/28] qapi: Document type-safety considerations

2015-03-31 Thread Kevin Wolf
Am 31.03.2015 um 19:07 hat Eric Blake geschrieben: > On 03/31/2015 09:09 AM, Kevin Wolf wrote: > > Am 24.03.2015 um 21:03 hat Eric Blake geschrieben: > >> Go into more details about the various types of valid expressions > >> in a qapi schema, including tweaks to document fixes being done > >> late

Re: [Qemu-devel] [PATCH v5 06/28] qapi: Add some union tests

2015-03-31 Thread Kevin Wolf
Am 26.03.2015 um 16:04 hat Eric Blake geschrieben: > On 03/26/2015 07:18 AM, Markus Armbruster wrote: > > Eric Blake writes: > >> Meanwhile, it would be nice to allow > >> 'discriminator':'EnumType' without 'base' for creating a simple union > >> that is type-safe rather than o

Re: [Qemu-devel] [SeaBIOS] [PATCH] smbios: ensure comparison SMBIOS string can't be paragraph aligned

2015-03-31 Thread Bruce Rogers
>>> On 3/31/2015 at 10:46 AM, Kevin O'Connor wrote: > On Tue, Mar 31, 2015 at 12:37:30PM -0400, Gabriel L. Somlo wrote: >> On Tue, Mar 31, 2015 at 08:49:58AM -0600, Bruce Rogers wrote: >> > >>> On 3/30/2015 at 10:02 PM, Kevin O'Connor wrote: >> > > On Mon, Mar 30, 2015 at 05:06:30PM -0600, Bruc

Re: [Qemu-devel] [PATCH v5 01/28] qapi: Document type-safety considerations

2015-03-31 Thread Eric Blake
On 03/31/2015 09:09 AM, Kevin Wolf wrote: > Am 24.03.2015 um 21:03 hat Eric Blake geschrieben: >> Go into more details about the various types of valid expressions >> in a qapi schema, including tweaks to document fixes being done >> later in the current patch series. Also fix some stale and missi

Re: [Qemu-devel] Bouncing maintainers

2015-03-31 Thread John Snow
On 03/31/2015 06:01 AM, Markus Armbruster wrote: John Snow writes: On 03/26/2015 09:19 AM, Kevin Wolf wrote: Am 25.03.2015 um 16:45 hat John Snow geschrieben: On 03/25/2015 10:48 AM, Markus Armbruster wrote: I just had another cc: to an address gotten from MAINTAINERS bounce with "user

Re: [Qemu-devel] [PATCH] qga/commands-posix: Fix bug in guest-fstrim

2015-03-31 Thread Eric Blake
On 03/31/2015 10:52 AM, Paolo Bonzini wrote: >> -# Returns: Nothing. >> +# Returns: Number of bytes trimmed by this call. > > It's better to add "(since 2.4)" here. > > Apart from this, looks good. Changing a "return":{} to "return":0 is not backwards-compatible. > > I'm CCing the qemu-ga mai

Re: [Qemu-devel] [PATCH] qga/commands-posix: Fix bug in guest-fstrim

2015-03-31 Thread Eric Blake
On 03/31/2015 09:14 AM, Justin Ossevoort wrote: > The FITRIM ioctl updates the fstrim_range structure it receives. This > way the caller can determine how many bytes were trimmed. The > guest-fstrim logic reuses the same fstrim_range for each filesystem, > effectively limiting each filesystem to tr

Re: [Qemu-devel] [PATCH] qga/commands-posix: Fix bug in guest-fstrim

2015-03-31 Thread Paolo Bonzini
On 31/03/2015 17:14, Justin Ossevoort wrote: > The FITRIM ioctl updates the fstrim_range structure it receives. This > way the caller can determine how many bytes were trimmed. The > guest-fstrim logic reuses the same fstrim_range for each filesystem, > effectively limiting each filesystem to tri

Re: [Qemu-devel] [PATCH v2] tpm_tis: fix format for 64bit variable

2015-03-31 Thread Eric Blake
On 03/31/2015 09:05 AM, Stefan Berger wrote: > Signed-off-by: Stefan Berger > --- > hw/tpm/tpm_tis.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake However; > > diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c > index 815c8ea..3f42982 100644 > --- a/hw/tpm/tp

Re: [Qemu-devel] [SeaBIOS] [PATCH] smbios: ensure comparison SMBIOS string can't be paragraph aligned

2015-03-31 Thread Kevin O'Connor
On Tue, Mar 31, 2015 at 12:37:30PM -0400, Gabriel L. Somlo wrote: > On Tue, Mar 31, 2015 at 08:49:58AM -0600, Bruce Rogers wrote: > > >>> On 3/30/2015 at 10:02 PM, Kevin O'Connor wrote: > > > On Mon, Mar 30, 2015 at 05:06:30PM -0600, Bruce Rogers wrote: > > >> The SMBIOS anchor string _SM_ is sto

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-31 Thread Radim Krčmář
2015-03-31 17:56+0300, Andrey Korolyov: > > Chasing the culprit this way could take a long time, so a new tracepoint > > that shows if 0xef is set on entry would let us guess the bug faster ... > > > > Please provide a failing trace with the following patch: > > Thanks, please see below: > > http:

Re: [Qemu-devel] [SeaBIOS] [PATCH] smbios: ensure comparison SMBIOS string can't be paragraph aligned

2015-03-31 Thread Gabriel L. Somlo
On Tue, Mar 31, 2015 at 08:49:58AM -0600, Bruce Rogers wrote: > >>> On 3/30/2015 at 10:02 PM, Kevin O'Connor wrote: > > On Mon, Mar 30, 2015 at 05:06:30PM -0600, Bruce Rogers wrote: > >> The SMBIOS anchor string _SM_ is stored within SeaBIOS to validate > >> an SMBIOS entry point structure. There

[Qemu-devel] [PATCH] qga/commands-posix: Fix bug in guest-fstrim

2015-03-31 Thread Justin Ossevoort
The FITRIM ioctl updates the fstrim_range structure it receives. This way the caller can determine how many bytes were trimmed. The guest-fstrim logic reuses the same fstrim_range for each filesystem, effectively limiting each filesystem to trim at most as much as the previous was able to trim. If

[Qemu-devel] [PATCH v2 4/4] target-arm: kvm - add support for HW assisted debug

2015-03-31 Thread Alex Bennée
From: Alex Bennée This adds basic support for HW assisted debug. The ioctl interface to KVM allows us to pass an implementation defined number of break and watch point registers. When KVM_GUESTDBG_USE_HW_BP is specified these debug registers will be installed in place on the world switch into the

[Qemu-devel] [PATCH v2 0/4] QEMU support for KVM Guest Debug on arm64

2015-03-31 Thread Alex Bennée
Hi, I thought I'd sent V1 to the list but apparently not. Anyway this patch series provides the QEMU side of guest debug support for arm64. I'm assuming the first patch will be dropped when a proper merge of the linux-headers is done once the kernel side is upstreamed. There is nothing particular

[Qemu-devel] [PATCH v2 3/4] target-arm: kvm - support for single step

2015-03-31 Thread Alex Bennée
This adds support for single-step. There isn't much to do on the QEMU side as after we set-up the request for single step via the debug ioctl it is all handled within the kernel. Signed-off-by: Alex Bennée --- v2 - convert to using HSR_EC diff --git a/target-arm/kvm.c b/target-arm/kvm.c index

[Qemu-devel] [PATCH v2 1/4] linux-headers: partial sync from my kernel tree (DEV)

2015-03-31 Thread Alex Bennée
I assume I'll properly merge the KVM Headers direct from Linux when done. These headers came from: https://git.linaro.org/people/alex.bennee/linux.git/shortlog/refs/heads/guest-debug/4.0-rc6-v2 Signed-off-by: Alex Bennée --- v2 - update ABI to include ->far diff --git a/linux-headers/asm-arm

[Qemu-devel] [PATCH v2 2/4] target-arm: kvm - implement software breakpoints

2015-03-31 Thread Alex Bennée
These don't involve messing around with debug registers, just setting the breakpoint instruction in memory. GDB will not use this mechanism if it can't access the memory to write the breakpoint. All the kernel has to do is ensure the hypervisor traps the breakpoint exceptions and returns to usersp

Re: [Qemu-devel] [PATCH] tpm_tis: fix format for 64bit variable

2015-03-31 Thread Stefan Berger
On 03/31/2015 10:15 AM, Eric Blake wrote: On 03/31/2015 08:09 AM, Eric Blake wrote: On 03/31/2015 07:27 AM, Stefan Berger wrote: Signed-off-by: Stefan Berger --- hw/tpm/tpm_tis.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c index 81

Re: [Qemu-devel] [PATCH v5 17/28] qapi: Allow true, false and null in schema json

2015-03-31 Thread Kevin Wolf
Am 24.03.2015 um 21:03 hat Eric Blake geschrieben: > From: Fam Zheng > > In the near term, we will use it for a sensible-looking > 'gen':false inside command declarations, instead of the > current ugly 'gen':'no'. > > In the long term, it will allow conversion from shorthand > with defaults ment

[Qemu-devel] [Bug 1438572] [NEW] kvm does not support KVM_CAP_USER_MEMORY Please upgrade to at least kernel 2.6.29 or recent kvm-kmod (see http://sourceforge.net/projects/kvm)

2015-03-31 Thread Jitendra Aggarwal
Public bug reported: We have a machine which is having QEMU+KVM on below configuration of linux uname -a Linux cairotrior 2.6.18-308.13.1.el5 #1 SMP Thu Jul 26 05:45:09 EDT 2012 x86_64 x86_64 x86_64 GNU/Linux cat /etc/issue Red Hat Enterprise Linux Server release 5.8 (Tikanga) Kernel \r on an \m

Re: [Qemu-devel] [PATCH v5 01/28] qapi: Document type-safety considerations

2015-03-31 Thread Kevin Wolf
Am 24.03.2015 um 21:03 hat Eric Blake geschrieben: > Go into more details about the various types of valid expressions > in a qapi schema, including tweaks to document fixes being done > later in the current patch series. Also fix some stale and missing > documentation in the QMP specification. >

[Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary

2015-03-31 Thread Tony Krowiak
Commit 49d2e648e8087d154d8bf8b91f27c8e05e79d5a6 removed the QemuOptDesc elements from the *desc* field of the *qemu_machine_opts *array defined in vl.c. Since applying that patch to qemu on my system, I can not start a guest from libvirt when certain machine options are configured for the guest

[Qemu-devel] [PATCH v2] tpm_tis: fix format for 64bit variable

2015-03-31 Thread Stefan Berger
Signed-off-by: Stefan Berger --- hw/tpm/tpm_tis.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c index 815c8ea..3f42982 100644 --- a/hw/tpm/tpm_tis.c +++ b/hw/tpm/tpm_tis.c @@ -814,7 +814,7 @@ static void tpm_tis_mmio_write_intern(void *opa

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-31 Thread Andrey Korolyov
On Tue, Mar 31, 2015 at 4:45 PM, Radim Krčmář wrote: > 2015-03-30 22:32+0300, Andrey Korolyov: >> On Mon, Mar 30, 2015 at 9:56 PM, Radim Krčmář wrote: >> > 2015-03-27 13:16+0300, Andrey Korolyov: >> >> On Fri, Mar 27, 2015 at 12:03 AM, Bandan Das wrote: >> >> > Radim Krčmář writes: >> >> >> I s

Re: [Qemu-devel] [SeaBIOS] [PATCH] smbios: ensure comparison SMBIOS string can't be paragraph aligned

2015-03-31 Thread Bruce Rogers
>>> On 3/30/2015 at 10:02 PM, Kevin O'Connor wrote: > On Mon, Mar 30, 2015 at 05:06:30PM -0600, Bruce Rogers wrote: >> The SMBIOS anchor string _SM_ is stored within SeaBIOS to validate >> an SMBIOS entry point structure. There is the possibility (observed) >> that this comparison string ends up

Re: [Qemu-devel] [PATCH RFC 0/3] iothread: release iothread around aio_poll

2015-03-31 Thread Stefan Hajnoczi
On Tue, Mar 31, 2015 at 12:35:16PM +0200, Paolo Bonzini wrote: > > > On 20/02/2015 17:26, Paolo Bonzini wrote: > > Right now, iothreads are relying on a "contention callback" to release > > the AioContext (e.g. for block device operations or to do bdrv_drain_all). > > This is necessary because ai

[Qemu-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

2015-03-31 Thread Stefano Stabellini
From: Jan Beulich Otherwise the guest can abuse that control to cause e.g. PCIe Unsupported Request responses (by disabling memory and/or I/O decoding and subsequently causing [CPU side] accesses to the respective address ranges), which (depending on system configuration) may be fatal to the host

Re: [Qemu-devel] QTest information needed

2015-03-31 Thread Stefan Hajnoczi
On Mon, Mar 30, 2015 at 11:22:10PM +0200, Andreas Färber wrote: > Am 30.03.2015 um 20:48 schrieb Nidugala Muralikrishna: > > Can anyone point me to any reference document / Wiki on "QTest" like how > > to write the Tests, build test suite, compile etc. > > Search linux-kvm.org for KVM Forum presen

Re: [Qemu-devel] [PATCH] replaced get_ticks_per_sec() with constant

2015-03-31 Thread Stefan Hajnoczi
On Tue, Mar 31, 2015 at 09:46:32AM +1000, Peter Crosthwaite wrote: > On Tue, Mar 31, 2015 at 7:52 AM, Peter Maydell > wrote: > > On 30 March 2015 at 14:01, Stefan Hajnoczi wrote: > >> On Sat, Mar 28, 2015 at 06:22:11PM +0200, Emil Condrea wrote: > >>> diff --git a/target-arm/helper.c b/target-ar

Re: [Qemu-devel] [Migration Bug? ] Occasionally, the content of VM's memory is inconsistent between Source and Destination of migration

2015-03-31 Thread Stefan Hajnoczi
On Tue, Mar 31, 2015 at 03:54:51PM +0800, Wen Congyang wrote: > On 03/27/2015 04:56 PM, Stefan Hajnoczi wrote: > > On Thu, Mar 26, 2015 at 11:29:43AM +0100, Juan Quintela wrote: > >> Wen Congyang wrote: > >>> On 03/25/2015 05:50 PM, Juan Quintela wrote: > zhanghailiang wrote: > > Hi all,

Re: [Qemu-devel] [PATCH] tpm_tis: fix format for 64bit variable

2015-03-31 Thread Eric Blake
On 03/31/2015 08:09 AM, Eric Blake wrote: > On 03/31/2015 07:27 AM, Stefan Berger wrote: >> Signed-off-by: Stefan Berger >> --- >> hw/tpm/tpm_tis.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c >> index 815c8ea..52e0148 100644 >> -

  1   2   >