On Fri, Mar 13, 2015 at 11:19:06AM +, Dr. David Alan Gilbert wrote:
> * David Gibson (da...@gibson.dropbear.id.au) wrote:
> > On Wed, Feb 25, 2015 at 04:51:46PM +, Dr. David Alan Gilbert (git)
> > wrote:
> > > From: "Dr. David Alan Gilbert"
> > >
> > > Once postcopy is enabled (with migr
On Fri, Mar 13, 2015 at 10:19:54AM +, Dr. David Alan Gilbert wrote:
> * David Gibson (da...@gibson.dropbear.id.au) wrote:
> > On Wed, Feb 25, 2015 at 04:51:43PM +, Dr. David Alan Gilbert (git)
> > wrote:
> > > From: "Dr. David Alan Gilbert"
> > >
> > > Modify save_live_pending to return
On Fri, Mar 13, 2015 at 01:47:53PM +, Dr. David Alan Gilbert wrote:
> * David Gibson (da...@gibson.dropbear.id.au) wrote:
> > On Wed, Feb 25, 2015 at 04:51:49PM +, Dr. David Alan Gilbert (git)
> > wrote:
> > > From: "Dr. David Alan Gilbert"
[snip]
> > > +mis->postcopy_pmi.state0[B
On Fri, Mar 13, 2015 at 10:41:53AM +, Dr. David Alan Gilbert wrote:
> * David Gibson (da...@gibson.dropbear.id.au) wrote:
> > On Wed, Feb 25, 2015 at 04:51:45PM +, Dr. David Alan Gilbert (git)
> > wrote:
> > > From: "Dr. David Alan Gilbert"
> > >
> > > Provide a check to see if the OS we
On Fri, Mar 13, 2015 at 11:51:42AM +, Dr. David Alan Gilbert wrote:
> * David Gibson (da...@gibson.dropbear.id.au) wrote:
> > On Wed, Feb 25, 2015 at 04:51:41PM +, Dr. David Alan Gilbert (git)
> > wrote:
> > > From: "Dr. David Alan Gilbert"
> > >
> > > MIG_CMD_PACKAGED is a migration com
Shannon Zhao writes:
> It's detected by coverity. As max of sockaddr_un.sun_path is
> sizeof(helper.sun_path), should check the length of source
> and use strncpy instead of strcpy.
updated such that,
The socket name specified should fit in the sockadd_un.sun_path. If not
abort.
with that appl
Shannon Zhao writes:
> It's detected by coverity. Check the return value of proxy_marshal.
>
> Signed-off-by: Shannon Zhao
> Signed-off-by: Shannon Zhao
Applied
> ---
> fsdev/virtfs-proxy-helper.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev
On 03/13/2015 05:05 PM, Fam Zheng wrote:
> On Fri, 03/13 17:01, Wen Congyang wrote:
>> On 03/11/2015 02:49 PM, Fam Zheng wrote:
>>> On Wed, 03/11 14:44, Wen Congyang wrote:
On 03/03/2015 03:59 PM, Fam Zheng wrote:
> On Tue, 03/03 15:53, Wen Congyang wrote:
>> I test qcow2_make_empty()'
On Sun, 03/15 10:16, Paolo Bonzini wrote:
> monitor_fdset_add_fd returns an AddfdInfo struct (used by the QMP
> command add_fd). Free it.
>
> Signed-off-by: Paolo Bonzini
Reviewed-by: Fam Zheng
> ---
> v1->v2: line length [Fam], pass &error_abort [Shannon]
> v2->v3: use "!!" ins
If DMA's owning thread cancels the IO while the bounce buffer's owning thread
is notifying the "cpu client list", a use-after-free happens:
continue_after_map_failure dma_aio_cancel
--
aio_bh_new
There could be a race condition when two processes call
address_space_map concurrently and both want to use the bounce buffer.
Add an in_use flag in BounceBuffer to sync it.
Signed-off-by: Fam Zheng
---
exec.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/exec.c b/exec
So that accesses from multiple threads are safe.
Signed-off-by: Fam Zheng
---
exec.c | 24 +++-
1 file changed, 15 insertions(+), 9 deletions(-)
diff --git a/exec.c b/exec.c
index 4080044..3e54580 100644
--- a/exec.c
+++ b/exec.c
@@ -429,15 +429,6 @@ address_space_translate_
v3: Address Paolo's comments:
Use atomic_xchg for bounce buffer.
Use mutex and BH for map_client_list.
The global bounce buffer used for non-direct memory access is not thread-safe:
1) Access to "bounce" is not atomic.
2) Access to "map_client_list" is not atomic.
3) In dma_blk_cb, t
The caller's workflow is like
if (!address_space_map()) {
...
cpu_register_map_client();
}
If bounce buffer became available after address_space_map() but before
cpu_register_map_client(), the caller could miss it and has to wait for the
next bounce buffer notify, which ma
On Fri, Mar 13, 2015 at 02:28:20PM +0800, Fam Zheng wrote:
> On Fri, 03/13 14:07, Fam Zheng wrote:
> > On Thu, 03/12 12:15, Michael S. Tsirkin wrote:
> > > On Thu, Mar 12, 2015 at 11:04:33AM +, Peter Maydell wrote:
> > > > On 12 March 2015 at 10:57, Michael S. Tsirkin wrote:
> > > > > This isn
On Mon, Mar 09, 2015 at 05:43:19PM +1030, Rusty Russell wrote:
> > I think it's a good idea to merge these patches (maybe except the
> > !TASK_RUNNING thing) sooner rather than later, to make sure people have
> > the time to test the fixes properly. Would you like me to pack up (some
> > of them)
On Mon, Mar 16, 2015 at 01:44:22PM +1030, Rusty Russell wrote:
> "Michael S. Tsirkin" writes:
> > On Fri, Mar 13, 2015 at 11:47:18AM +1030, Rusty Russell wrote:
> >> Here's my proposed spec patch, which spells this out:
> >>
> >> diff --git a/content.tex b/content.tex
> >> index 6ba079d..b6345a8
On 03/06/2015 12:17 AM, Alexander Graf wrote:
On 05.03.15 02:56, Alexey Kardashevskiy wrote:
At the moment when running in KVM mode, QEMU registers "host" class to
match the current CPU PVR value. It also registers another CPU class
with a CPU family name os if we run QEMU on POWER7 machine, "
On Mon, Mar 16, 2015 at 10:52:52AM +0800, Chen Fan wrote:
> Cc: Michael S. Tsirkin
>
> On 03/12/2015 06:23 PM, Chen Fan wrote:
> >For now, for vfio pci passthough devices when qemu receives
> >an error from host aer report, there just terminate the guest,
> >but usually user want to know what erro
On 2015/3/16 9:27, zhanghailiang wrote:
> On 2015/3/14 17:52, Shannon Zhao wrote:
>> It's detected by coverity. Close the dirfd.
>>
>
> Reviewed-by: zhanghailiang
>
Hi zhanghailiang,
Thanks for your review.
Shannon
>> Signed-off-by: Shannon Zhao
>> Signed-off-by: Shannon Zhao
>> ---
>>
On 2015/3/14 17:56, Stefan Weil wrote:
> Am 14.03.2015 um 10:52 schrieb Shannon Zhao:
>> It's detected by coverity. Close the dirfd.
>>
>> Signed-off-by: Shannon Zhao
>> Signed-off-by: Shannon Zhao
>> ---
>> v1->v2: close after use [Stefan Weil]
>> ---
>> qga/commands-posix.c | 1 +
>> 1
Hi Team,
Can anyone please provide their point of views related to my below query.
Thanks & Regards
Arkajit Ghosh
-Arkajit Ghosh/DEL/TCS wrote: -
To: qemu-devel@nongnu.org
From: Arkajit Ghosh/DEL/TCS
Date: 03/12/2015 02:28PM
Subject: Re: [Qe
On Mon, 2015-03-16 at 12:04 +1100, Gavin Shan wrote:
>
>
> (2) QEMU sends IOCTL commands to host to disable MSIx and enable INTx. At
> this stage the INTx is still masked. At later point, the guest is requesting
> unmasking INTx, which is captured by host. Host checks and founds pending
> INTx, w
On 03/13/2015 10:45 PM, Alexey Kardashevskiy wrote:
The changelog is:
> virtio: Fix vring allocation
> helpers: Fix SLOF_alloc_mem_aligned to meet callers expectation
> Set default palette according to "16-color Text Extension" document
> Fix rectangle drawing functions to work also w
2ed1ebcf6 "timer: replace time() with QEMU_CLOCK_HOST" broke compile
when configured with --enable-profiler. Turned out the profiler has been
broken for a while.
This does s/qemu_time/tcg_time/ as the profiler only works in a TCG mode.
This also fixes the compile error.
This changes profile_getcl
On Mon, 2015-03-16 at 11:05 +0800, Chen Fan wrote:
> On 03/14/2015 06:34 AM, Alex Williamson wrote:
> > On Thu, 2015-03-12 at 18:23 +0800, Chen Fan wrote:
> >> when the vfio device encounters an uncorrectable error in host,
> >> the vfio_pci driver will signal the eventfd registered by this
> >> vf
"Michael S. Tsirkin" writes:
> On Fri, Mar 13, 2015 at 11:47:18AM +1030, Rusty Russell wrote:
>> Here's my proposed spec patch, which spells this out:
>>
>> diff --git a/content.tex b/content.tex
>> index 6ba079d..b6345a8 100644
>> --- a/content.tex
>> +++ b/content.tex
>> @@ -600,10 +600,19 @@ t
On 03/14/2015 06:34 AM, Alex Williamson wrote:
On Thu, 2015-03-12 at 18:23 +0800, Chen Fan wrote:
when the vfio device encounters an uncorrectable error in host,
the vfio_pci driver will signal the eventfd registered by this
vfio device, the results in the qemu eventfd handler getting
invoked.
Cc: Michael S. Tsirkin
On 03/12/2015 06:23 PM, Chen Fan wrote:
For now, for vfio pci passthough devices when qemu receives
an error from host aer report, there just terminate the guest,
but usually user want to know what error occurred but stop the
guest, so this patches add aer capability suppo
On 03/14/2015 06:38 AM, Alex Williamson wrote:
On Thu, 2015-03-12 at 18:23 +0800, Chen Fan wrote:
for piix4 chipset, we don't need to expose aer, so introduce
PC_I440FX_COMPAT for all piix4 machines to disable aercap,
and add HW_COMPAT_2_2 to disable aercap for all lower
than 2.3.
440FX is not
On 03/14/2015 06:38 AM, Alex Williamson wrote:
On Thu, 2015-03-12 at 18:23 +0800, Chen Fan wrote:
for piix4 chipset, we don't need to expose aer, so introduce
PC_I440FX_COMPAT for all piix4 machines to disable aercap,
and add HW_COMPAT_2_2 to disable aercap for all lower
than 2.3.
440FX is not
On 03/14/2015 06:25 AM, Alex Williamson wrote:
On Thu, 2015-03-12 at 18:23 +0800, Chen Fan wrote:
pcie_aer_init was used to emulate an aer capability for pcie device,
but for vfio device, the aer config space size is mutable and is not
always equal to PCI_ERR_SIZEOF(0x48). it depends on where t
On Fri, 03/13 13:28, Paolo Bonzini wrote:
>
>
> On 13/03/2015 13:23, Alberto Garcia wrote:
> > On Fri, Mar 13, 2015 at 02:35:29PM +0800, Fam Zheng wrote:
> >
> >> Throttle timers won't make any progress when VCPU is not running,
> >> which is prone to stall the request queue in cases like utils,
On 2015/3/14 17:52, Shannon Zhao wrote:
It's detected by coverity. Close the dirfd.
Reviewed-by: zhanghailiang
Signed-off-by: Shannon Zhao
Signed-off-by: Shannon Zhao
---
v1->v2: close after use [Stefan Weil]
---
qga/commands-posix.c | 1 +
1 file changed, 1 insertion(+)
diff --g
It's detected by coverity. Check the return value of proxy_marshal.
Signed-off-by: Shannon Zhao
Signed-off-by: Shannon Zhao
---
fsdev/virtfs-proxy-helper.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
index c1da2d7..bf2e5f3 100
On 2015/3/13 18:11, Ian Campbell wrote:
On Fri, 2015-03-13 at 09:39 +0800, Chen, Tiejun wrote:
I don't think you can abort here, since a user can set
b_info->u.hvm.gfx_passthru_kind to default. You would need to
return an error.
Then, looks I should do this,
LOG(ERROR, "No supported IGD to pa
On Fri, Mar 13, 2015 at 03:51:27PM -0600, Alex Williamson wrote:
>On Wed, 2015-03-11 at 17:11 +1100, Gavin Shan wrote:
>> When Linux guest recovers from EEH error on the following Emulex
>> adapter, the MSIx interrupts are disabled and the INTx emulation
>> is enabled. One INTx interrupt is injecte
On 03/13/2015 07:07 PM, Igor Mammedov wrote:
On Fri, 13 Mar 2015 14:05:08 +0800
Zhu Guihua wrote:
ping...
I can't find v4 series in my mailbox nor on list archives,
perhaps it got lost somewhere, could you resend rebased
version on top of current master, pls?
OK, I will resend v4 ASAP.
Th
On Sun, Mar 15, 2015 at 16:10:21 -0700, Richard Henderson wrote:
> On 03/15/2015 03:00 AM, Emilio G. Cota wrote:
> > On a TLB hit this is trivial (just do nothing), but on
> > a TLB miss I'm lost on what to do--I cannot even follow
> > where helper_ld/st go (grep doesn't help), although I
> > suspe
On 3/16/15 07:44, Peter Maydell wrote:
> On 15 March 2015 at 23:08, Chen Gang wrote:
>> On 3/16/15 00:50, Andreas Färber wrote:
>>> Am 15.03.2015 um 15:19 schrieb Chen Gang:
If no additional reply of this thread within 3 days, I shall send a new
patch which will include system call imple
On 3/16/15 07:45, Peter Maydell wrote:
> On 14 March 2015 at 06:03, Chen Gang wrote:
>> QEMU TILE-Gx can decode bundle, disassemble code, and generate tcg code
>> for 1st TB block (__start). Then directly jump to __libc_start_main (2nd
>> TB block).
>>
>> In __libc_start_main, it can continue exec
On 14 March 2015 at 06:03, Chen Gang wrote:
> QEMU TILE-Gx can decode bundle, disassemble code, and generate tcg code
> for 1st TB block (__start). Then directly jump to __libc_start_main (2nd
> TB block).
>
> In __libc_start_main, it can continue executing to the first function
> call _dl_aux_ini
On 15 March 2015 at 23:08, Chen Gang wrote:
> On 3/16/15 00:50, Andreas Färber wrote:
>> Am 15.03.2015 um 15:19 schrieb Chen Gang:
>>> If no additional reply of this thread within 3 days, I shall send a new
>>> patch which will include system call implementation.
>>
>> Please use a proper subject
On 03/15/2015 03:00 AM, Emilio G. Cota wrote:
> On a TLB hit this is trivial (just do nothing), but on
> a TLB miss I'm lost on what to do--I cannot even follow
> where helper_ld/st go (grep doesn't help), although I
> suspect it's TCG backend ops and I don't see an obvious
> way of adding a new op
On 3/16/15 00:50, Andreas Färber wrote:
> Am 15.03.2015 um 15:19 schrieb Chen Gang:
>> If no additional reply of this thread within 3 days, I shall send a new
>> patch which will include system call implementation.
>
> Please use a proper subject then, saying what it does (rather what works
> afte
On Fri, Mar 13, 2015 at 03:33:50PM -0600, Alex Williamson wrote:
>On Wed, 2015-03-11 at 17:11 +1100, Gavin Shan wrote:
>> The PCI device MSIx table is cleaned out in hardware after EEH PE
>> reset. However, we still hold the stale MSIx entries in QEMU, which
>> should be cleared accordingly. Otherw
Am 15.03.2015 um 15:19 schrieb Chen Gang:
> If no additional reply of this thread within 3 days, I shall send a new
> patch which will include system call implementation.
Please use a proper subject then, saying what it does (rather what works
afterwards). In particular don't forget "target-tilegx
qga/vss-win32/Makefile.objsi filters out -fstack-protector-all option from C++
flags,
but with commit 63678e17c configure script may add option
-fstack-protector-strong,
depending on availability. The suggested change filters out both option for
qga-vss.dll
linking.
Regards,
Jos
Signed-off-by: Joseph Hindin
---
qga/vss-win32/Makefile.objs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qga/vss-win32/Makefile.objs b/qga/vss-win32/Makefile.objs
index 6a69d50..7c96c6b 100644
--- a/qga/vss-win32/Makefile.objs
+++ b/qga/vss-win32/Makefile.objs
@@ -3,7 +3,7
At present, I finished the first system call successfully (it is uname
called by glibc).
If no additional reply of this thread within 3 days, I shall send a new
patch which will include system call implementation.
Thanks.
On 3/14/15 14:03, Chen Gang wrote:
> QEMU TILE-Gx can decode bundle, disa
On 15/03/2015 11:23, Michael Tokarev wrote:
> Or, alternatively, to keep this `data' pointer in sdp to use it in
> bt_l2cap_sdp_close_ch().
Yes.
>> > In any case, it seems simpler to just leave this code aside.
> How many times this code is called?
>
> We have many many places in qemu where re
Hi ALL:
IO port 0x61 is used by pc speaker and NMI reason port.
This is ambiguous. How to distinguish in QEMU?
I see that NMI reason port is not realized in QEMU.
But linux guest will access this port to determine what the NMI reason code
means.
It will access pc speaker's io port. Is this a
On 13/03/15 19:26, Richard Henderson wrote:
> As seen with ubuntu-5.10-live-powerpc.iso.
>
> Reported-by: Mark Cave-Ayland
> Signed-off-by: Richard Henderson
> ---
> tcg/optimize.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tcg/optimize.c b/tcg/optimize.c
> i
On 14 March 2015 at 15:12, Stefan Weil wrote:
> This fixes a warning from Coverity:
> "Dereference null return value (NULL_RETURNS)"
>
> Signed-off-by: Stefan Weil
> ---
> linux-user/flatload.c |8 +---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/linux-user/flatloa
On 14 March 2015 at 13:54, Wenjie Liu wrote:
> Hi all,
> Recently, I am trying to get the memory trace from qemu.
> Since I am using qemu by Marss, so the version of qemu is 0.14.
For upstream QEMU, 0.14 is extremely ancient history by now,
I'm afraid (it's four years old, and the codebase has ch
15.03.2015 12:21, Paolo Bonzini wrote:
> On 14/03/2015 11:07, Stefan Weil wrote:
>>
>> This fixes the memory leak, but I still don't understand what is done here.
>> data is allocated, then filled with values, now it is also deallocated.
>> But I'm missing the part where all those data is used.
>
On 14/03/2015 11:07, Stefan Weil wrote:
>
> This fixes the memory leak, but I still don't understand what is done here.
> data is allocated, then filled with values, now it is also deallocated.
> But I'm missing the part where all those data is used.
"data" escapes in record->attribute_list[rec
monitor_fdset_add_fd returns an AddfdInfo struct (used by the QMP
command add_fd). Free it.
Signed-off-by: Paolo Bonzini
---
v1->v2: line length [Fam], pass &error_abort [Shannon]
v2->v3: use "!!" instead of "? true : false" [Markus]
---
vl.c | 6 --
1 file changed, 4 insert
On 13/03/2015 22:30, Patchew Tool wrote:
> This series passed Patchew automatic testing, but there are some warnings.
>
> Find the log fragments below, or open the following URL to see the full log:
>
> http://qemu.patchew.org/testing/log/<20150313212337.31142.3991.stgit@bahia.local>
I'll fix
Hi,
after upgrading the host kernel from 3.12 to 3.18 live migration fails
with the following qemu output (guest running on a host with 3.12 =>
host with 3.18):
kvm: Features 0x30afffe3 unsupported. Allowed features: 0x79bfbbe7
qemu: warning: error while loading state for instance 0x0 of devi
60 matches
Mail list logo
