Am 14.03.2015 um 04:42 schrieb Shannon Zhao:
Free data in function sdp_attr_write after use.
Signed-off-by: Shannon Zhao
Signed-off-by: Shannon Zhao
---
hw/bt/sdp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/bt/sdp.c b/hw/bt/sdp.c
index 218e075..8e6d5e3 100644
--- a/hw/bt/sdp.c
Am 14.03.2015 um 04:30 schrieb Shannon Zhao:
It's detected by coverity. Close the dirfd.
Signed-off-by: Shannon Zhao
Signed-off-by: Shannon Zhao
---
qga/commands-posix.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index d5bb5cb..cbf1c80
Delete set_usb_string(), usb_ep_get_ifnum(), usb_ep_get_max_packet_size()
usb_ep_get_max_streams() and usb_ep_set_pipeline() since they are
not used anymore.
Signed-off-by: Thomas Huth
Reviewed-by: Gerd Hoffmann
---
hw/usb/core.c| 41 -
include/hw/u
Here are some more patches to remove completely unused functions
from QEMU. Please review carefully, some of the functions might
still get usefull in the future again, so if you discover one,
please let me know, then I'll remove it from the patch series
again.
v2: Changed series according to revie
The function ich9_d2pbr_init() is completely unused and
thus can be deleted.
Signed-off-by: Thomas Huth
Cc: Michael S. Tsirkin
---
hw/pci-bridge/i82801b11.c | 21 -
include/hw/i386/ich9.h|1 -
2 files changed, 0 insertions(+), 22 deletions(-)
diff --git a/hw/pci-b
The functions tpm_backend_thread_tpm_reset(), serial_set_frequency()
and iothread_find() are completely unused, let's remove them.
Signed-off-by: Thomas Huth
---
backends/tpm.c | 11 ---
hw/char/serial.c |7 ---
include/hw/char/serial.h
migrate_rdma_pin_all(), qsb_clone() and qsb_set_length()
are completely unused and thus can be deleted.
Signed-off-by: Thomas Huth
Cc: Juan Quintela
Cc: Amit Shah
---
include/migration/migration.h |1 -
include/migration/qemu-file.h |2 -
migration/migration.c |9 ---
m
Delete the unused functions qemu_signalfd_available(),
qemu_send_full() and qemu_recv_full().
Signed-off-by: Thomas Huth
---
include/qemu-common.h |4 ---
include/qemu/compatfd.h |1 -
util/compatfd.c | 19 -
util/osdep.c| 66
The functions ringbuf_read_completion() and monitor_get_rs()
are not used anywhere anymore, so let's remove them.
Signed-off-by: Thomas Huth
Cc: Luiz Capitulino
---
hmp.h |1 -
include/monitor/monitor.h |1 -
monitor.c | 13 -
3 files ch
The function is not used anymore and thus can be deleted.
Signed-off-by: Thomas Huth
Cc: Dmitry Fleytman
---
hw/net/vmxnet_rx_pkt.c |7 ---
hw/net/vmxnet_rx_pkt.h |9 -
2 files changed, 0 insertions(+), 16 deletions(-)
diff --git a/hw/net/vmxnet_rx_pkt.c b/hw/net/vmxnet_rx_
QEMU TILE-Gx can decode bundle, disassemble code, and generate tcg code
for 1st TB block (__start). Then directly jump to __libc_start_main (2nd
TB block).
In __libc_start_main, it can continue executing to the first function
call _dl_aux_init().
Signed-off-by: Chen Gang
---
target-tilegx/cpu-q
On Sat, 14 Mar 2015 06:33:35 +0100
Thomas Huth wrote:
> Boards that do not include an USB controller should not provide
> USB devices. However, when running "qemu-system-s390x -device help"
By the way, in case somebody wants to test the above example, and
wonders why there are also U/O/E/XHCI co
Boards that do not include an USB controller should not provide
USB devices. However, when running "qemu-system-s390x -device help"
for example, there's still a usb-hub, usb-kbd, usb-mouse and
usb-tablet in the list of "supported" devices. Let's fix that
by compiling and linking the USB files only
Public bug reported:
When the code segment register (%cs) selects an executable segment with
no read permission, mov instructions that read from the segment via %cs
prefix can still succeed without causing a general protection error.
** Affects: qemu
Importance: Undecided
Status: Ne
On Thu, Mar 12, 2015 at 12:58 PM, Stefan Hajnoczi wrote:
> On Thu, Mar 12, 2015 at 03:03:45PM +, Peter Maydell wrote:
>> On 12 March 2015 at 14:43, Peter Maydell wrote:
>> > On 12 March 2015 at 14:33, Stefan Hajnoczi wrote:
>> >> v4:
>> >> * Drop clang 3.5.0 fixes since they break with olde
From: Scott Feldman
Signed-off-by: Scott Feldman
Signed-off-by: Jiri Pirko
---
MAINTAINERS |6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index d7e9ba2..8cbf013 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -754,6 +754,12 @@ S: Maintained
F: hw/net/vmxn
From: David Ahern
Signed-off-by: David Ahern
Signed-off-by: Scott Feldman
Signed-off-by: Jiri Pirko
---
hw/net/rocker/rocker.h | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/hw/net/rocker/rocker.h b/hw/net/rocker/rocker.h
index 6ae74ff..b3310b6 100644
--- a/
From: Scott Feldman
Signed-off-by: Scott Feldman
Signed-off-by: Jiri Pirko
---
docs/specs/pci-ids.txt |1 +
include/hw/pci/pci.h |1 +
2 files changed, 2 insertions(+)
diff --git a/docs/specs/pci-ids.txt b/docs/specs/pci-ids.txt
index c6732fe..e4a4490 100644
--- a/docs/specs/pci-ids
From: Scott Feldman
We can use this in virtio-net code as well as new Rocker driver code, so
up-level this.
Signed-off-by: Scott Feldman
Reviewed-by: Eric Blake
---
include/net/net.h |1 +
net/net.c |7 +++
2 files changed, 8 insertions(+)
diff --git a/include/net/net.h b
From: Scott Feldman
This is the register programming guide for the Rocker device. It's intended
for driver writers and device writers. It covers the device's PCI space,
the register set, DMA interface, and interrupts.
Signed-off-by: Scott Feldman
Signed-off-by: Jiri Pirko
---
docs/specs/roc
From: Scott Feldman
Rocker is an ethernet switch device, so add 'other' network device class as
defined by PCI to cover these types of devices.
Signed-off-by: Scott Feldman
Signed-off-by: Jiri Pirko
---
include/hw/pci/pci_ids.h |1 +
1 file changed, 1 insertion(+)
diff --git a/include/hw
From: Scott Feldman
Add some basic test for rocker to test L2/L3/L4 functionality. Requires an
external test environment, simp, located here:
https://github.com/scottfeldman/simp
To run tests, simp environment must be installed and a suitable VM image built
and installed with a Linux 3.18 (or
From: Scott Feldman
v8:
- From Stefan Hajnoczi's net-pull-request v3, merge in these changes:
- Squash David Ahern's clang struct definition warnings fix
- Squash in Jiri's fix for rocker format string specifiers [Peter]
- Squash in Windows build fix [Peter]
- In addition, fix
From: Scott Feldman
Signed-off-by: Scott Feldman
Reviewed-by: Eric Blake
---
hw/net/virtio-net.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 27adcc5..321bef4 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/vir
Free data in function sdp_attr_write after use.
Signed-off-by: Shannon Zhao
Signed-off-by: Shannon Zhao
---
hw/bt/sdp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/bt/sdp.c b/hw/bt/sdp.c
index 218e075..8e6d5e3 100644
--- a/hw/bt/sdp.c
+++ b/hw/bt/sdp.c
@@ -735,6 +735,7 @@ static void
It's detected by coverity. Close the dirfd.
Signed-off-by: Shannon Zhao
Signed-off-by: Shannon Zhao
---
qga/commands-posix.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index d5bb5cb..cbf1c80 100644
--- a/qga/commands-posix.c
+++ b/qga/comma
On 3/14/15 08:22, Richard Henderson wrote:
> On 03/13/2015 04:07 PM, Chen Gang wrote:
>>> UNARY_RRR_0_OPCODE_X0.
>>>
+if ((get_UnaryOpcodeExtension_X0(bundle) == 0x03) && !rsrc &&
!rdst) {
>>>
>>> FNOP_UNARY_OPCODE_X0.
>>
>> OK, thanks.
>>
>>> There are enou
It's detected by coverity. As max of sockaddr_un.sun_path is
sizeof(helper.sun_path), should check the length of source
and use strncpy instead of strcpy.
Signed-off-by: Shannon Zhao
Signed-off-by: Shannon Zhao
---
v1->v2: Still use strcpy [Paolo]
---
hw/9pfs/virtio-9p-proxy.c | 1 +
1 file
It's detected by coverity. As max of sockaddr_un.sun_path is
sizeof(helper.sun_path), should check the length of source
and use strncpy instead of strcpy.
Signed-off-by: Shannon Zhao
Signed-off-by: Shannon Zhao
---
v1->v2: Still use strcpy [Paolo]
---
fsdev/virtfs-proxy-helper.c | 1 +
1 fi
On 2015/3/13 20:50, Paolo Bonzini wrote:
>
>
> On 13/03/2015 12:09, Shannon Zhao wrote:
>> +g_assert(strlen(path) < sizeof(helper.sun_path));
>
> Ok.
>
>> sockfd = socket(AF_UNIX, SOCK_STREAM, 0);
>> if (sockfd < 0) {
>> fprintf(stderr, "failed to create socket: %s\n", st
On 2015/3/13 20:55, Paolo Bonzini wrote:
> monitor_fdset_add_fd returns an AddfdInfo struct (used by the QMP
> command add_fd). Free it.
>
> Signed-off-by: Paolo Bonzini
> ---
> v1->v2: line length [Fam], pass &error_abort [Shannon]
> ---
> vl.c | 7 +--
> 1 file changed, 5 insertions
On 03/13/2015 04:07 PM, Chen Gang wrote:
>> UNARY_RRR_0_OPCODE_X0.
>>
>>> +if ((get_UnaryOpcodeExtension_X0(bundle) == 0x03) && !rsrc &&
>>> !rdst) {
>>
>> FNOP_UNARY_OPCODE_X0.
>
> OK, thanks.
>
>> There are enough of these it's probably worth splitting
>> out deco
On Fri, Mar 13, 2015 at 10:18:39PM +0100, Gerhard Wiesinger wrote:
> Hello,
>
> Any updates for the
> http://fedorapeople.org/groups/virt/virt-preview/fedora-virt-preview.repo
> repo to qemu 2.2.1 planned?
The above is maintained by Fedora Virtualization maintainers. I added
Cole Robinson, who ma
On 03/13/2015 07:26 PM, Richard Henderson wrote:
As seen with ubuntu-5.10-live-powerpc.iso.
Reported-by: Mark Cave-Ayland
Signed-off-by: Richard Henderson
---
tcg/optimize.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tcg/optimize.c b/tcg/optimize.c
index 067917
Firstly, thank you very much for your reviewing, and I shall send patch
v3 within this week end (2015-03-15).
On 3/14/15 02:20, Richard Henderson wrote:
> On 03/12/2015 09:06 AM, Chen Gang wrote:
>> +#define TILEGX_GEN_SAVE_PREP(rdst) \
>> +dc->tmp_regcur->idx = rdst; \
>> +dc->tmp_regcu
On Thu, 2015-03-12 at 18:23 +0800, Chen Fan wrote:
> for piix4 chipset, we don't need to expose aer, so introduce
> PC_I440FX_COMPAT for all piix4 machines to disable aercap,
> and add HW_COMPAT_2_2 to disable aercap for all lower
> than 2.3.
440FX is not PCIe, so it doesn't seem like we need to d
On Thu, 2015-03-12 at 18:23 +0800, Chen Fan wrote:
> when the vfio device encounters an uncorrectable error in host,
> the vfio_pci driver will signal the eventfd registered by this
> vfio device, the results in the qemu eventfd handler getting
> invoked.
>
> this patch is to pass the error to gue
On Thu, 2015-03-12 at 18:23 +0800, Chen Fan wrote:
> For vfio device, we need to propagate the aer error to
> Guest OS. we use the pcie_aer_msg() to send aer error
> to guest.
This also would need to go in through the QEMU PCI tree, or at least get
an ack from Michael. Thanks,
Alex
> Signed-of
On Thu, 2015-03-12 at 18:23 +0800, Chen Fan wrote:
> Calling pcie_aer_init to initilize aer related registers for
> vfio device, then reload physical related registers to expose
> device capability.
>
> Signed-off-by: Chen Fan
> ---
> hw/vfio/pci.c | 45 ++
On Thu, 2015-03-12 at 18:23 +0800, Chen Fan wrote:
> pcie_aer_init was used to emulate an aer capability for pcie device,
> but for vfio device, the aer config space size is mutable and is not
> always equal to PCI_ERR_SIZEOF(0x48). it depends on where the TLP Prefix
> register required, so here we
Gerd Hoffmann wrote:
> Rename config option from "glx" to "opengl", glx will not be the only
> option for opengl in near future. Also switch over to pkg-config for
> opengl support detection.
I had before this patch enabled --enable-glx
> +if test "$opengl" != "no" ; then
> + opengl_pkgs="gl
On Wed, 2015-03-11 at 17:11 +1100, Gavin Shan wrote:
> When Linux guest recovers from EEH error on the following Emulex
> adapter, the MSIx interrupts are disabled and the INTx emulation
> is enabled. One INTx interrupt is injected to the guest by host
> because of detected pending INTx interrupts
Many bits in the CMD register are supposed to be strictly read-only.
We should not be deleting them on every write.
As a side-effect: pay explicit attention to when a guest marks off
the FIS Receive or Start bits, and disable the status bits ourselves,
instead of letting them implicitly fall off.
Currently, the AHCI device tries to re-map guest memory every time
the low or high address registers are written to, whether or not the
AHCI device is currently active. If the other register has stale
information in it, this may lead to runtime failures.
Reconfigure the AHCI device to ignore write
The FIS Receive Buffer and Command List Buffer pointers
should not be edited while the FIS receive engine or
Command Receive engines are running.
Currently, we attempt to re-map the buffers every time they
are adjusted, but while the AHCI engines are off, these registers
may contain stale values,
On Wed, 2015-03-11 at 17:11 +1100, Gavin Shan wrote:
> The PCI device MSIx table is cleaned out in hardware after EEH PE
> reset. However, we still hold the stale MSIx entries in QEMU, which
> should be cleared accordingly. Otherwise, we will run into another
> (recursive) EEH error and the PCI dev
This series passed Patchew automatic testing, but there are some warnings.
Find the log fragments below, or open the following URL to see the full log:
http://qemu.patchew.org/testing/log/<20150313212337.31142.3991.stgit@bahia.local>
--8<-
=== Starting docker ===
Copying test
KVM expects host endian values. Hosts that don't use the default endianness
need to negate the swap performed in adjust_endianness().
Suggested-by: Paolo Bonzini
Signed-off-by: Greg Kurz
---
kvm-all.c | 24 ++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git
Hello,
Any updates for the
http://fedorapeople.org/groups/virt/virt-preview/fedora-virt-preview.repo repo
to qemu 2.2.1 planned?
Thank you.
Ciao,
Gerhard
This series passed Patchew automatic testing, but there are some warnings.
Find the log fragments below, or open the following URL to see the full log:
http://qemu.patchew.org/testing/log/<1426278193-15317-1-git-send-email-...@twiddle.net>
--8<-
total: 0 errors, 0 warnings, 159
On 02/25/2015 08:14 AM, Bastian Koppelmann wrote:
> Bastian Koppelmann (6):
> target-tricore: Add instructions of RRR1 opcode format, which have
> 0xa3 as first opcode
> target-tricore: Add instructions of RRR1 opcode format, which have
> 0x63 as first opcode
> target-tricore: Add ins
On Mar 13, 2015, at 1:31 PM, Paolo Bonzini wrote:
>
>
> On 13/03/2015 15:48, Programmingkid wrote:
>>
>> On Mar 13, 2015, at 5:51 AM, Peter Maydell wrote:
>>
>>> On 13 March 2015 at 04:35, Programmingkid wrote:
Laptop users usually have keyboards that are missing the page up and page
>
On 03/13/2015 02:09 PM, Markus Armbruster wrote:
> We've steered users away from QCOW/QCOW2 encryption for a while,
> because it's a flawed design (commit 136cd19 Describe flaws in
> qcow/qcow2 encryption in the docs).
>
> In addition to flawed crypto, we have comically bad usability, and
> plain
Pre-allocating 512 of them per TB is a waste.
Reviewed-by: Bastian Koppelmann
Signed-off-by: Richard Henderson
---
tcg/tcg.c | 31 ++-
tcg/tcg.h | 16 +---
2 files changed, 23 insertions(+), 24 deletions(-)
diff --git a/tcg/tcg.c b/tcg/tcg.c
index 97aa51
Reviewed-by: Bastian Koppelmann
Signed-off-by: Richard Henderson
---
tcg/ia64/tcg-target.c | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/tcg/ia64/tcg-target.c b/tcg/ia64/tcg-target.c
index 6bc9924..1c01fd9 100644
--- a/tcg/ia64/tcg-target.c
+++ b/tcg/ia
This is improved type checking for the translators -- it's no longer
possible to accidentally swap arguments to the branch functions.
Note that the code generating backends still manipulate labels as int.
With notable exceptions, the scope of the change is just a few lines
for each target, so it'
This is less about improved type checking than enabling a
subsequent change to the representation of labels.
Acked-by: Claudio Fontana
Tested-by: Claudio Fontana
Cc: Andrzej Zaborowski
Cc: Peter Maydell
Cc: Aurelien Jarno
Cc: Blue Swirl
Cc: Stefan Weil
Reviewed-by: Bastian Koppelmann
Signe
Pre-allocating 640 of them per TB is a waste.
Reviewed-by: Bastian Koppelmann
Signed-off-by: Richard Henderson
---
tcg/tcg-be-ldst.h | 26 --
1 file changed, 12 insertions(+), 14 deletions(-)
diff --git a/tcg/tcg-be-ldst.h b/tcg/tcg-be-ldst.h
index 429cba2..4a45102 1006
4:
user-exec.c: fix build on NetBSD/sparc64 and NetBSD/arm (2015-03-13 15:57:00
+)
are available in the git repository at:
git://github.com/rth7680/qemu.git tags/tcg-pull-20150313
for you to fetch changes up to 37ed3bf1ee07bb1a26adca0df8718f601f231c0b:
tcg: Complete handling of ALWAYS
Missing from movcond, and brcondi_i32 (but not brcondi_i64).
Signed-off-by: Richard Henderson
---
tcg/tcg-op.c | 22 +-
1 file changed, 17 insertions(+), 5 deletions(-)
diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c
index 6674bb4..f7a2767 100644
--- a/tcg/tcg-op.c
+++ b/tcg/tcg-op
I fat-fingered Dan's e-mail address. I apologize for the inconvenience.
Eric Blake writes:
> On 03/13/2015 11:51 AM, Markus Armbruster wrote:
>> Error classes are a leftover from the days of "rich" error objects.
>> New code should always use ERROR_CLASS_GENERIC_ERROR.
>
> More precisely, new code should use ERROR_CLASS_GENERIC_ERROR unless
> there is a good reason w
We've steered users away from QCOW/QCOW2 encryption for a while,
because it's a flawed design (commit 136cd19 Describe flaws in
qcow/qcow2 encryption in the docs).
In addition to flawed crypto, we have comically bad usability, and
plain old bugs. Let me show you.
= Example images =
I'm going to
This series passed Patchew automatic testing, but there are some warnings.
Find the log fragments below, or open the following URL to see the full log:
http://qemu.patchew.org/testing/log/<1426275924-1904-1-git-send-email-jwh...@codeweavers.com>
--8<-
total: 0 errors, 0 warning
* Richard Henderson (r...@twiddle.net) wrote:
> On 03/03/2015 07:47 AM, Dr. David Alan Gilbert wrote:
> > That works for ARM where you have to terminate a ldrex with a strex or
> > clrex,
> > but not all architectures have the equivalent of a clrex; most as I remember
> > just let you do an ldrex
A physical smartcard with an ATR of
3B 95 95 40 FF AE 01 0E 00 00
was parsed incorrectly.
The '40' should have been the second TD; instead
the FF is used, incorrectly.
Signed-off-by: Jeremy White
---
hw/usb/ccid-card-passthru.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
Ping: The series this is based on has been bumped to v2, but it does not
change the context for this patchset.
Requires: <1426274523-22661-1-git-send-email-js...@redhat.com>
On 03/10/2015 04:14 PM, John Snow wrote:
This series is based on:
"[Qemu-devel] [PATCH 0/2] ahci: test varying sector of
This series passed Patchew automatic testing, but there are some warnings.
Find the log fragments below, or open the following URL to see the full log:
http://qemu.patchew.org/testing/log/<1426275418-8411-1-git-send-email-konrad.w...@oracle.com>
--8<-
docker run --net=none -v
That option can be achieved using -e "use_hw=yes hw_type=passthru"
Signed-off-by: Jeremy White
---
libcacard/vscclient.c | 16 +++-
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c
index fa6041d..8573f50 100644
--- a/libca
This uses libpcsclite to provide direct communication with a smartcard.
Signed-off-by: Jeremy White
---
Makefile.objs|5 +
libcacard/capcsc.c | 498 ++
libcacard/capcsc.h | 18 ++
libcacard/card_7816.c|2 +-
libca
Signed-off-by: Jeremy White
---
libcacard/vcard.c |2 +-
libcacard/vcard.h |2 +-
libcacard/vcard_emul_nss.c | 29 -
libcacard/vcard_emul_type.c |3 ++-
4 files changed, 32 insertions(+), 4 deletions(-)
diff --git a/libcacard/vcard.
As far as I can tell, the vreader_remove_reader function is not presently in
use anywhere; I have an upcoming patch set that uses it.
Signed-off-by: Jeremy White
---
libcacard/vreader.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libcacard/vreader.c b/libcacard/vreader
This is a resend of my outstanding patches, gathered together
as one series. I'm hoping to agitate for this whole set to be considered.
Changes since v2:
* Include outstanding patches not strictly related to passthru mode
* Include a fix for read binary transactions
* Mitigate some performa
Signed-off-by: Jeremy White
---
configure | 38 ++
1 file changed, 38 insertions(+)
diff --git a/configure b/configure
index b858756..f22dbae 100755
--- a/configure
+++ b/configure
@@ -307,6 +307,7 @@ trace_file="trace"
spice=""
rbd=""
smartcard_nss=""
+
Also add an alias of 'nssemul' for the default card
of hw=yes hw_type=cac, and an alias of 'passthru' for
the new card type of hw=yes hw_type=passthru.
This allows the spice-gtk client to take a more human
friendly set of arguments and relay them through to this code.
Signed-off-by: Jeremy White
On Fri, Mar 13, 2015 at 08:25:19PM +0100, Andreas Färber wrote:
> Am 13.03.2015 um 20:09 schrieb Eduardo Habkost:
> > With the Intel microcode update that removed HLE and RTM, there will be
> > different kinds of Haswell and Broadwell CPUs out there: some that still
> > have the HLE and RTM feature
On 03/03/2015 07:47 AM, Dr. David Alan Gilbert wrote:
> That works for ARM where you have to terminate a ldrex with a strex or clrex,
> but not all architectures have the equivalent of a clrex; most as I remember
> just let you do an ldrex equivalent, decide you don't want to do the strex
> equiva
As the libxc library follows (mostly) the return negative
for failure and stashes the error value in errno.
Signed-off-by: Konrad Rzeszutek Wilk
---
hw/xen/xen_pt.c | 4 ++--
hw/xen/xen_pt_msi.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/xen/xen_pt.c b/hw/xen
.errors - as it will most likely have the proper error value.
Signed-off-by: Konrad Rzeszutek Wilk
---
xen-hvm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen-hvm.c b/xen-hvm.c
index 7548794..3d6fed3 100644
--- a/xen-hvm.c
+++ b/xen-hvm.c
@@ -348,7 +348,7 @@ go_phys
Hey,
I've just posted on xen-devel patches that make these two set of
xc_* function conform to the style of returning -1 for error and
stashing the Exx in errno. See:
http://lists.xen.org/archives/html/xen-devel/2015-03/msg01766.html
and
http://lists.xen.org/archives/html/xen-devel/2015-03/msg017
On 03/12/2015 04:38 PM, Mark Cave-Ayland wrote:
> Ah great, you're able to reproduce the same issue locally. Hopefully
> this will give you both enough information to figure out what is
> happening in the optimiser...
Yep, just sent a simple fix.
r~
As seen with ubuntu-5.10-live-powerpc.iso.
Reported-by: Mark Cave-Ayland
Signed-off-by: Richard Henderson
---
tcg/optimize.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tcg/optimize.c b/tcg/optimize.c
index 067917c..37c1110 100644
--- a/tcg/optimize.c
+++ b/tcg/optim
This will enable the testing of high offsets without
wasting a lot of disk space, and does not impact the
previous tests.
mkimg and mkqcow2 are added to libqos for other tests.
Signed-off-by: John Snow
---
tests/Makefile| 1 +
tests/ahci-test.c | 16 ++--
tests/libqos/l
Am 13.03.2015 um 20:09 schrieb Eduardo Habkost:
> With the Intel microcode update that removed HLE and RTM, there will be
> different kinds of Haswell and Broadwell CPUs out there: some that still
> have the HLE and RTM features, and some that don't have the HLE and RTM
> features. On both cases pe
This is a re-send of patches 7 & 8 from an earlier series,
"[PATCH v2 0/8] ahci: add more IO tests" which ultimately got bounced
back because I used some glib functions that were too new.
v2:
- Patchew caught a pathing problem with the qemu-img binary;
the relative path produced by the Makefile
Test sector offset 0, 1, and the last sector(s)
in LBA28 and LBA48 modes.
Signed-off-by: John Snow
---
tests/ahci-test.c | 68 +++--
tests/libqos/ahci.c | 10
tests/libqos/ahci.h | 4 ++--
3 files changed, 63 insertions(+), 19 deletions
On 03/13/2015 11:48 AM, Markus Armbruster wrote:
> Markus Armbruster writes:
>
>> Error classes are a leftover from the days of "rich" error objects.
>> New code should always use ERROR_CLASS_GENERIC_ERROR. Commit 1d0d59f
>> added a use of ERROR_CLASS_DEVICE_NOT_FOUND. Replace it.
"always" is
This reverts commit 13704e4c455770d500d6b87b117e32f0d01252c9.
With the Intel microcode update that removed HLE and RTM, there will be
different kinds of Haswell and Broadwell CPUs out there: some that still
have the HLE and RTM features, and some that don't have the HLE and RTM
features. On both c
On 03/13/2015 11:51 AM, Markus Armbruster wrote:
> Error classes are a leftover from the days of "rich" error objects.
> New code should always use ERROR_CLASS_GENERIC_ERROR.
More precisely, new code should use ERROR_CLASS_GENERIC_ERROR unless
there is a good reason where a caller knowing a differ
With the Intel microcode update that removed HLE and RTM, there will be
different kinds of Haswell and Broadwell CPUs out there: some that still
have the HLE and RTM features, and some that don't have the HLE and RTM
features. On both cases people may be willing to use the pc-*-2.3
machine-types.
With the Intel microcode update that removed HLE and RTM, there will be
different kinds of Haswell and Broadwell CPUs out there: some that still
have the HLE and RTM features, and some that don't have the HLE and RTM
features. On both cases people may be willing to use the pc-*-2.3
machine-types.
On 03/12/2015 09:45 AM, Eric Blake wrote:
> On 03/12/2015 09:29 AM, Richard Henderson wrote:
>> On 02/25/2015 02:45 AM, Markus Armbruster wrote:
>>> return 0x8000u >> (clz64(value - 1) - 1);
>>
>> I realize this was weeks ago, but it would certainly be preferable to shift a
>> small con
On 02/27/2015 06:09 AM, Pavel Dovgalyuk wrote:
> This patch adds global variables, defines, functions declarations,
s/functions/function/
> and function stubs for deterministic VM replay used by external modules.
>
> Reviewed-by: Paolo Bonzini
> Reviewed-by: Eric Blake
>
> Signed-off-by: Pave
On 03/13/2015 01:56 PM, Peter Maydell wrote:
On 13 March 2015 at 17:50, Patchew Tool wrote:
This series passed Patchew automatic testing, but there are some warnings.
Find the log fragments below, or open the following URL to see the full log:
http://qemu.patchew.org/testing/log/<142626858
We treat this field with a variety of different types everywhere
in the code. Now it's just uint32_t.
Reviewed-by: Eric Blake
Reviewed-by: Max Reitz
Reviewed-by: Stefan Hajnoczi
Signed-off-by: John Snow
---
block.c | 11 ++-
block/mirror.c| 4 ++--
inclu
We add a bitmap merge operation to assist in error cases
where we wish to combine two bitmaps together.
This is algorithmically O(bits) provided HBITMAP_LEVELS remains
constant. For a full bitmap on a 64bit machine:
sum(bits/64^k, k, 0, HBITMAP_LEVELS) ~= 1.01587 * bits
We may be able to improve
The general approach is to set bits close to the boundaries of
where we are truncating and ensure that everything appears to
have gone OK.
We test growing and shrinking by different amounts:
- Less than the granularity
- Less than the granularity, but across a boundary
- Less than sizeof(unsigned
On 03/12/2015 09:06 AM, Chen Gang wrote:
> +#define TILEGX_GEN_SAVE_PREP(rdst) \
> +dc->tmp_regcur->idx = rdst; \
> +dc->tmp_regcur->val = tcg_temp_new_i64();
> +
> +#define TILEGX_GEN_SAVE_TMP_1(func, rdst, x1) \
> +TILEGX_GEN_SAVE_PREP(rdst) \
> +func(dc->tmp_regcur->val, x1);
> +
Signed-off-by: John Snow
Reviewed-by: Max Reitz
---
block.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/block.c b/block.c
index 5f73697..6b6539a 100644
--- a/block.c
+++ b/block.c
@@ -60,11 +60,11 @@
* or enabled. A frozen bitmap can only abdicate() or re
Add bdrv_clear_dirty_bitmap and a matching QMP command,
qmp_block_dirty_bitmap_clear that enables a user to reset
the bitmap attached to a drive.
This allows us to reset a bitmap in the event of a full
drive backup.
Signed-off-by: John Snow
---
block.c | 8
blockdev.c
1 - 100 of 236 matches
Mail list logo
