Re: [Qemu-devel] [PATCH v2] migration: Convert 'status' of MigrationInfo to use an enum type

2015-03-03 Thread Markus Armbruster
Eric Blake writes: > On 03/03/2015 12:15 AM, zhanghailiang wrote: > Yes, this is the reason ..., agreed, i don't like the abbreviate, But there is already a 'MigrationState' type defined: >>> So, what about MigrationStatus ? ;) >>> >>> That would be fine with me. >>>

Re: [Qemu-devel] [vhost] link new devices

2015-03-03 Thread Vasile Catalin-B50542
I'm not yet very accustomed to qemu sources and I usually associate source code modules integration with type_init(). Related to vhost-net, I later found out that it is an API like source code, it is used/called by virtio-net. On Fri, Feb 13, 2015 at 05:33:25PM +0200, Vasile Catalin-B50542 wro

Re: [Qemu-devel] [PATCH] configure: require glib 2.22

2015-03-03 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Tue, Mar 03, 2015 at 04:24:15PM +0100, Paolo Bonzini wrote: >> This provides g_ptr_array_new_with_free_func, as well as a few >> other functions that we've been hacking around in glib-compat.h. >> Cleaning up the compatibility headers will come later. >> >> Sign

[Qemu-devel] [vhost] vq_index from struct vhost_dev

2015-03-03 Thread Vasile Catalin-B50542
Why does the field vq_index exist in each struct vhost_dev? Why isn't each vhost_dev using a vqs pointer starting directly from their first usable vq?

Re: [Qemu-devel] [PATCH] iotests: Fix 051's reference output

2015-03-03 Thread Markus Armbruster
Max Reitz writes: > Commit c4bacafb717de55538311b80a185ce9166b8daa2 changed (improved) > qdev_init_nofail()'s error reporting, which affects iotest 051. Fix the > reference output. > > Signed-off-by: Max Reitz I apologize for neglecting to run iotests. Lost sight of it while rambling around in

Re: [Qemu-devel] Delaying -rc0?

2015-03-03 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Mon, Mar 02, 2015 at 01:33:23PM +0100, Paolo Bonzini wrote: >> Looks like there are still a few pull requests pending, and Peter is on >> vacation. Should we really enter hard feature freeze tomorrow? The 2.3 >> planning page in the end never got out the "draft

Re: [Qemu-devel] Delaying -rc0?

2015-03-03 Thread Markus Armbruster
Peter Maydell writes: > On 4 March 2015 at 00:07, Marcel Apfelbaum wrote: >> In the mean time this series depends on Igor's ACPI dynamic series that took >> a lot of time to review and even Michael's PULL request with it is not yet >> in master. > > You can view this as an argument against enorm

Re: [Qemu-devel] [PATCH] Introduce machine specific default memory size

2015-03-03 Thread Markus Armbruster
Nikunj A Dadhania writes: > Qemu default memory of 128MB is not enough to boot spapr > guest. Introduce a property in the machine class to override the > default memory size enforced by qemu. > > Signed-off-by: Nikunj A Dadhania > --- > hw/ppc/spapr.c | 1 + > include/hw/boards.h|

Re: [Qemu-devel] [PATCH 9/9] throttle: add name of ThrottleGroup to BlockDeviceInfo

2015-03-03 Thread Alberto Garcia
On Wed, Mar 04, 2015 at 08:09:22AM +0100, Markus Armbruster wrote: > >> { 'type': 'ThrottleGroupInfo', > >> 'data': { 'name': 'str', 'nodes': ['BlockDeviceInfo'] } } > >> > >> { 'command': 'query-block-throttle', > >> 'returns': ['ThrottleGroupInfo'] } > We need a coherent set of block queri

Re: [Qemu-devel] [PATCH] error: Replace error_report() & error_free() with error_report_err()

2015-03-03 Thread Markus Armbruster
Eric Blake writes: > On 03/03/2015 02:55 AM, zhanghailiang wrote: >> Signed-off-by: zhanghailiang >> --- > > Might have been nice to mention this was a continuation of the work > started in commit 565f65d27. Yes. Perhaps the -trivial maintainer can stick in a reference on commit. >> hw/arm/v

Re: [Qemu-devel] [PATCH 9/9] throttle: add name of ThrottleGroup to BlockDeviceInfo

2015-03-03 Thread Markus Armbruster
Eric Blake writes: > On 02/26/2015 06:56 AM, Alberto Garcia wrote: >> On Wed, Feb 25, 2015 at 08:23:10AM -0700, Eric Blake wrote: >> >>> How about query-block-throttle, returning an array of dicts. >>> >>> => { "execute":"query-block-throttle" } >>> <= { "return": [ >>> { "name": "throttle1

Re: [Qemu-devel] [PATCH] hw/arm/virt: fix cmdline parsing bug with CPU options and smp > 1

2015-03-03 Thread Ard Biesheuvel
On 3 March 2015 at 19:25, Greg Bellows wrote: > > > On Tue, Mar 3, 2015 at 11:06 AM, Ard Biesheuvel > wrote: >> >> The recently introduced feature that allows 32 bit guests to be >> executed under KVM on a 64-bit host incorrectly handles the case >> where more than 1 cpu is specified using '-smp

[Qemu-devel] QEMU Setup Support

2015-03-03 Thread Manjula Dissanayake
Hi All One of my engineers is in the process of setting up QEMU for Arm 11 (T1) emulation on Embedded Linux 3.11 kernel. We need some one on one support (paid even is fine) as I feel it would be the fastest way to make progress. Please inbox me or suggest any individuals who would be able to h

Re: [Qemu-devel] [PATCH v5 04/13] quorum: Fix close path

2015-03-03 Thread Fam Zheng
On Tue, 03/03 15:13, Max Reitz wrote: > bdrv_unref() can lead to bdrv_close(), which in turn will result in > bdrv_drain_all(). This function will later be called blk_drain_all() and > iterate only over the BlockBackends for which blk_is_inserted() holds > true; therefore, bdrv_is_inserted() and th

Re: [Qemu-devel] [PATCH v5 03/13] iotests: Add test for eject under NBD server

2015-03-03 Thread Fam Zheng
On Tue, 03/03 15:13, Max Reitz wrote: > This patch adds a test for ejecting the BlockBackend an NBD server is > connected to (the NBD server is supposed to stop). > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/096 | 90 > ++ > tests/qemu-

[Qemu-devel] [PULL] qemu-sparc update

2015-03-03 Thread Mark Cave-Ayland
Hi Peter, Here are the updates from my qemu-sparc tree. Please pull. ATB, Mark. The following changes since commit b8a173b25c887a606681fc35a46702c164d5b2d0: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-pull-request' into staging (2015-03-02 14:25:48 +) are available in the

Re: [Qemu-devel] [PATCH v5 02/13] iotests: Make redirecting qemu's stderr optional

2015-03-03 Thread Fam Zheng
On Tue, 03/03 15:13, Max Reitz wrote: > Redirecting qemu's stderr to stdout makes working with the stderr output > difficult due to the other file descriptor magic performed in > _launch_qemu ("ambiguous redirect"). > > Add an option which specifies whether stderr should be redirected to > stdout

Re: [Qemu-devel] [PATCH v5 01/13] iotests: Move _filter_nbd into common.filter

2015-03-03 Thread Fam Zheng
On Tue, 03/03 15:12, Max Reitz wrote: > _filter_nbd can be useful for other NBD tests, too, therefore it should > reside in common.filter, and it should support URLs of the "nbd://" > format and export names. > > The NBD log lines ("/your/source/dir/nbd.c:function():line: error") > should not be c

Re: [Qemu-devel] [PATCH v6 07/15] spapr_rtas: add ibm, configure-connector RTAS interface

2015-03-03 Thread Michael Roth
Quoting David Gibson (2015-03-02 23:33:39) > On Mon, Mar 02, 2015 at 10:40:16PM -0600, Michael Roth wrote: > > Quoting David Gibson (2015-03-02 01:02:46) > > > On Thu, Feb 26, 2015 at 09:11:07PM -0600, Michael Roth wrote: > > > > This interface is used to fetch an OF device-tree nodes that describe

Re: [Qemu-devel] [PATCH v3 02/10] acpi, mem-hotplug: Add acpi_memory_slot_status() to get MemStatus.

2015-03-03 Thread Zhu Guihua
On 03/03/2015 09:43 PM, Michael S. Tsirkin wrote: On Tue, Mar 03, 2015 at 10:18:12AM +0800, Zhu Guihua wrote: On 03/02/2015 01:31 AM, Michael S. Tsirkin wrote: On Thu, Feb 26, 2015 at 09:16:44AM +0800, Zhu Guihua wrote: From: Tang Chen Add a new API named acpi_memory_slot_status() to obtain

[Qemu-devel] [PATCH v4 3/5] target-i386: Move CPUX86State.cpuid_apic_id to X86CPU.apic_id

2015-03-03 Thread Eduardo Habkost
The field doesn't need to be inside CPUState, and it is not specific for the CPUID instruction, so move and rename it. Reviewed-by: Paolo Bonzini Reviewed-by: Andreas Färber Signed-off-by: Eduardo Habkost --- target-i386/cpu-qom.h | 1 + target-i386/cpu.c | 15 +++ target-i386

[Qemu-devel] [PATCH v4 5/5] target-i386: Require APIC ID to be explicitly set before CPU realize

2015-03-03 Thread Eduardo Habkost
On softmuu, instead of setting APIC ID automatically when creating a X86CPU, require the property to be set before realizing the object (which is already done by the CPU creation code on PC). Keep apic_id = 0 by default on *-user so it can simply create a new CPU object and realize it without extr

[Qemu-devel] [PATCH v4 2/5] target-i386: Remove unused APIC ID default code

2015-03-03 Thread Eduardo Habkost
The existing apic_id = cpu_index code has no visible effect: the PC code already initializes the APIC ID according to the topology on pc_new_cpu(), and linux-user memcpy()s the CPU state (including cpuid_apic_id) on cpu_copy(). Remove the dead code and simply let APIC ID to to be 0 by default. Thi

[Qemu-devel] [PATCH v4 0/5] target-i386: Simplify APIC ID initialization, move compat code to pc.c

2015-03-03 Thread Eduardo Habkost
This series removes the APIC ID initialization code from x86_cpu_initfn() (getting us one step closer to making object_new() of X86CPU have no dependency on cpu_exec_init() and other global QEMU state), and moves the APIC ID compatibility logic from target-i386/cpu.c to hw/i386/pc.c. Changes v3 ->

[Qemu-devel] [PATCH v4 1/5] target-i386: Move topology.h to include/hw/i386

2015-03-03 Thread Eduardo Habkost
This will allow the PC code to use the header, and lets us eliminate the QEMU_INCLUDES hack inside tests/Makefile. Reviewed-by: Paolo Bonzini Reviewed-by: Andreas Färber Signed-off-by: Eduardo Habkost --- {target-i386 => include/hw/i386}/topology.h | 6 +++--- target-i386/cpu.c

[Qemu-devel] [PATCH v4 4/5] target-i386: Move APIC ID compatibility code to pc.c

2015-03-03 Thread Eduardo Habkost
The APIC ID compatibility code is required only for PC, and now that x86_cpu_initfn() doesn't use x86_cpu_apic_id_from_index() anymore, that code can be moved to pc.c. Reviewed-by: Paolo Bonzini Reviewed-by: Andreas Färber Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 35 +

Re: [Qemu-devel] [PATCH v3 2/5] target-i386: Move CPUX86State.cpuid_apic_id to X86CPU.apic_id

2015-03-03 Thread Eduardo Habkost
On Mon, Mar 02, 2015 at 06:51:44PM +0100, Andreas Färber wrote: > Am 26.02.2015 um 22:42 schrieb Eduardo Habkost: > > The field doesn't need to be inside CPUState, and it is not specific for > > the CPUID instruction, so move and rename it. > > > > Reviewed-by: Paolo Bonzini > > Signed-off-by: Ed

[Qemu-devel] [PATCH] target-ppc: Add versions to server CPU descriptions

2015-03-03 Thread Alexey Kardashevskiy
5b79b1c "target-ppc: Create versionless CPU class per family if KVM" added a dynamic CPU class registration with the name of the CPU family which QEMU is running on. For example, this allowed specifying "-cpu POWER7" on every version of POWER7 machine, not just the one which POWER7 was an alias of.

Re: [Qemu-devel] [PATCH 2/2] virtio-pci: switch to modern accessors for 1.0

2015-03-03 Thread Rusty Russell
"Michael S. Tsirkin" writes: > virtio 1.0 config space is in LE format for all > devices, use modern wrappers when accessed through > the 1.0 BAR. Hmm, I'm not so sure about these patches. It's easy to miss the existence of the _modern variants, and they're 90% the same as the legacy variants.

Re: [Qemu-devel] [RFC PATCH] vfio: spapr: Move SPAPR-related code to a separate file

2015-03-03 Thread Alexey Kardashevskiy
On 03/04/2015 07:24 AM, Alex Williamson wrote: On Mon, 2015-02-23 at 19:22 +1100, Alexey Kardashevskiy wrote: This moves SPAPR bits to a separate file to avoid pollution of x86 code. This is a mechanical patch. Signed-off-by: Alexey Kardashevskiy --- There is another patch coming with DMA me

Re: [Qemu-devel] [PATCH v2 14/17] block: Resize bitmaps on bdrv_truncate

2015-03-03 Thread John Snow
On 03/03/2015 04:27 PM, Max Reitz wrote: On 2015-03-03 at 16:24, John Snow wrote: On 03/03/2015 11:02 AM, Max Reitz wrote: On 2015-03-02 at 18:20, John Snow wrote: Signed-off-by: John Snow --- block.c| 22 include/block/block.h | 1 + include/qem

Re: [Qemu-devel] [PATCHv2] Add testcase for scsi-hd devices without drive property

2015-03-03 Thread Stefan Hajnoczi
On Tue, Mar 03, 2015 at 03:59:26PM +0100, Christian Borntraeger wrote: > Lets add a test for scsi devices without a drive. This was broken > by a recent block patch, thus indicating that we need a testcase. > > Suggested-by: Kevin Wolf > Signed-off-by: Christian Borntraeger > --- > tests/qemu-i

Re: [Qemu-devel] [PATCH] Revert "target-ppc: Create versionless CPU class per family if KVM"

2015-03-03 Thread Alexey Kardashevskiy
On 03/04/2015 07:43 AM, Alexander Graf wrote: On 03.03.15 01:42, Alexey Kardashevskiy wrote: On 03/03/2015 12:51 AM, Alexander Graf wrote: On 02.03.15 14:42, Andreas Färber wrote: Am 02.03.2015 um 14:37 schrieb Alexander Graf: On 01.03.15 01:31, Andreas Färber wrote: This reverts commit

Re: [Qemu-devel] [PATCH 1/2] iotests: Remove 006

2015-03-03 Thread Max Reitz
On 2015-03-03 at 17:05, Eric Blake wrote: On 03/03/2015 02:22 PM, Max Reitz wrote: vpc does support images > 127 GB if done correctly. qemu does it correctly. Remove the test pretending otherwise. Signed-off-by: Max Reitz --- tests/qemu-iotests/006 | 54 --

Re: [Qemu-devel] [PATCH 1/2] iotests: Remove 006

2015-03-03 Thread Eric Blake
On 03/03/2015 02:22 PM, Max Reitz wrote: > vpc does support images > 127 GB if done correctly. qemu does it > correctly. Remove the test pretending otherwise. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/006 | 54 > -- > tests/qemu-iote

Re: [Qemu-devel] [PATCH 2/2] iotests: Drop vpc from 004's and 104's format list

2015-03-03 Thread Eric Blake
On 03/03/2015 02:22 PM, Max Reitz wrote: > Both tests require the test image to have a specific size; this cannot > be guaranteed by vpc (unless tuning the test specifically for that > format). > > It is safe to exclude vpc from 004 because what is tested there is > implemented in a generic part i

Re: [Qemu-devel] [PATCH v2 14/17] block: Resize bitmaps on bdrv_truncate

2015-03-03 Thread Max Reitz
On 2015-03-03 at 16:24, John Snow wrote: On 03/03/2015 11:02 AM, Max Reitz wrote: On 2015-03-02 at 18:20, John Snow wrote: Signed-off-by: John Snow --- block.c| 22 include/block/block.h | 1 + include/qemu/hbitmap.h | 10 + util/hbitmap.c

[Qemu-devel] [PATCH 0/2] iotests: Make tests pass for vpc

2015-03-03 Thread Max Reitz
iotest 006 is simply outdated, and the vpc format has certain attributes that make tests 004 and 104 fail. It's safe to exclude vpc from these tests, so do that. Max Reitz (2): iotests: Remove 006 iotests: Drop vpc from 004's and 104's format list tests/qemu-iotests/004 | 2 +- tests/q

Re: [Qemu-devel] [PATCH v2 14/17] block: Resize bitmaps on bdrv_truncate

2015-03-03 Thread John Snow
On 03/03/2015 11:02 AM, Max Reitz wrote: On 2015-03-02 at 18:20, John Snow wrote: Signed-off-by: John Snow --- block.c| 22 include/block/block.h | 1 + include/qemu/hbitmap.h | 10 + util/hbitmap.c | 55 +

[Qemu-devel] [PATCH 1/2] iotests: Remove 006

2015-03-03 Thread Max Reitz
vpc does support images > 127 GB if done correctly. qemu does it correctly. Remove the test pretending otherwise. Signed-off-by: Max Reitz --- tests/qemu-iotests/006 | 54 -- tests/qemu-iotests/006.out | 6 -- tests/qemu-iotests/group | 2 +

[Qemu-devel] [PATCH 2/2] iotests: Drop vpc from 004's and 104's format list

2015-03-03 Thread Max Reitz
Both tests require the test image to have a specific size; this cannot be guaranteed by vpc (unless tuning the test specifically for that format). It is safe to exclude vpc from 004 because what is tested there is implemented in a generic part in the block layer and not format-specific. It is saf

Re: [Qemu-devel] [PATCH v2 0/9] Block Throttle Group Support

2015-03-03 Thread Stefan Hajnoczi
On Fri, Feb 13, 2015 at 06:06:08PM +0200, Alberto Garcia wrote: > after having agreed it with him, I'm taking over Benoît Canet's work > to add support for throttle groups for block devices. The locking rules are undocumented so it's hard to review the patches. I think the intent is for throttlin

Re: [Qemu-devel] [PATCH v2 0/5] block/vpc optimizations

2015-03-03 Thread Max Reitz
On 2015-03-03 at 05:41, Peter Lieven wrote: This series covers VPC format changes discussed during the last weeks. Peter v1->v2: Patch 1: added comment why we can exit after the first allocated sector [Max] Patch 2: Fixed gemotry in commit msg [Max] Patch 3: Fixed comparision from > to

Re: [Qemu-devel] [PATCH 7/9] throttle: Add throttle group support

2015-03-03 Thread Stefan Hajnoczi
On Fri, Feb 13, 2015 at 06:06:15PM +0200, Alberto Garcia wrote: > The throttle group support use a cooperative round robin scheduling algorithm. > > The principles of the algorithm are simple: > - Each BDS of the group is used as a token in a circular way. > - The active BDS compute if a wait must

Re: [Qemu-devel] Fedora FC21 - Bug: 100% CPU and hangs in gettimeofday(&tp, NULL); forever

2015-03-03 Thread Gerhard Wiesinger
On 03.03.2015 14:18, Gerhard Wiesinger wrote: On 03.03.2015 13:28, Gerhard Wiesinger wrote: On 03.03.2015 10:12, Gerhard Wiesinger wrote: On 02.03.2015 18:15, Gerhard Wiesinger wrote: On 02.03.2015 16:52, Gerhard Wiesinger wrote: On 02.03.2015 10:26, Paolo Bonzini wrote: On 01/03/2015 11:36

Re: [Qemu-devel] [PATCH 0/4] block: Convert bdrv_find to blk_by_name and drop it

2015-03-03 Thread Max Reitz
On 2015-03-02 at 06:36, Fam Zheng wrote: This is a small step towards a more complete separation from BlockDriverState to block backend users. Fam Zheng (4): monitor: Convert bdrv_find to blk_by_name migration: Convert bdrv_find to blk_by_name blockdev: Convert bdrv_find to blk_by_name

Re: [Qemu-devel] [PATCH] Revert "target-ppc: Create versionless CPU class per family if KVM"

2015-03-03 Thread Alexander Graf
On 03.03.15 01:42, Alexey Kardashevskiy wrote: > On 03/03/2015 12:51 AM, Alexander Graf wrote: >> >> >> On 02.03.15 14:42, Andreas Färber wrote: >>> Am 02.03.2015 um 14:37 schrieb Alexander Graf: On 01.03.15 01:31, Andreas Färber wrote: > This reverts commit 5b79b1cadd3e565b6d1a5ba59764b

Re: [Qemu-devel] [PATCH RFC 1/1] s390x/pci: Extend pci representation by new zpci device

2015-03-03 Thread Alexander Graf
On 03.03.15 14:25, Frank Blaschka wrote: > On Tue, Mar 03, 2015 at 10:33:05AM +0100, Alexander Graf wrote: >> >> >> >>> Am 03.03.2015 um 09:06 schrieb Frank Blaschka : >>> On Thu, Feb 26, 2015 at 04:34:06PM +0100, Alexander Graf wrote: > On 26.02.15 16:27, Frank Blaschka wrote:

Re: [Qemu-devel] [PATCH V14 2/3] pc: add a Virtual Machine Generation ID device

2015-03-03 Thread Igor Mammedov
On Tue, 3 Mar 2015 18:35:39 +0100 "Michael S. Tsirkin" wrote: > On Tue, Mar 03, 2015 at 05:18:14PM +0100, Igor Mammedov wrote: > > Based on Microsoft's sepecifications (paper can be dowloaded from > > http://go.microsoft.com/fwlink/?LinkId=260709), add a device > > description to the SSDT ACPI ta

Re: [Qemu-devel] [RFC PATCH] vfio: spapr: Move SPAPR-related code to a separate file

2015-03-03 Thread Alex Williamson
On Mon, 2015-02-23 at 19:22 +1100, Alexey Kardashevskiy wrote: > This moves SPAPR bits to a separate file to avoid pollution of x86 code. > > This is a mechanical patch. > > Signed-off-by: Alexey Kardashevskiy > --- > > There is another patch coming with DMA memory preregistration which will >

[Qemu-devel] [PATCH v5 04/13] quorum: Fix close path

2015-03-03 Thread Max Reitz
bdrv_unref() can lead to bdrv_close(), which in turn will result in bdrv_drain_all(). This function will later be called blk_drain_all() and iterate only over the BlockBackends for which blk_is_inserted() holds true; therefore, bdrv_is_inserted() and thus quorum_is_inserted() will probably be calle

[Qemu-devel] [PATCH v5 08/13] block: Make bdrv_close() static

2015-03-03 Thread Max Reitz
There are no users of bdrv_close() left, except for one of bdrv_open()'s failure paths, bdrv_close_all() and bdrv_delete(), and that is good. Make bdrv_close() static so nobody makes the mistake of directly using bdrv_close() again. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- block.c

[Qemu-devel] [PATCH v5 11/13] block: Add blk_remove_all_bs()

2015-03-03 Thread Max Reitz
When bdrv_close_all() is called, instead of force-closing all root BlockDriverStates, it is better to just drop the reference from all BlockBackends and let them be closed automatically. This prevents BDS from getting closed that are still referenced by other BDS, which may result in loss of cached

[Qemu-devel] [PATCH v5 09/13] block: Add list of all BlockDriverStates

2015-03-03 Thread Max Reitz
Signed-off-by: Max Reitz --- block.c | 10 ++ include/block/block_int.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/block.c b/block.c index e84fa0c..9698b1d 100644 --- a/block.c +++ b/block.c @@ -94,6 +94,9 @@ static QTAILQ_HEAD(, BlockDriverState) bdrv_stat

[Qemu-devel] [PATCH v5 05/13] block: Move BDS close notifiers into BB

2015-03-03 Thread Max Reitz
The only remaining user of the BDS close notifiers is NBD which uses them to determine when a BDS tree is being ejected. This patch removes the BDS-level close notifiers and adds a notifier list to the BlockBackend structure that is invoked whenever a BDS is removed. Symmetrically to that, another

[Qemu-devel] [PATCH v5 13/13] iotests: Add test for multiple BB on BDS tree

2015-03-03 Thread Max Reitz
This adds a test for having multiple BlockBackends in one BDS tree. In this case, there is one BB for the protocol BDS and one BB for the format BDS in a simple two-BDS tree (with the protocol BDS and BB added first). When bdrv_close_all() is executed, no cached data from any BDS should be lost; t

[Qemu-devel] [PATCH v5 10/13] blockdev: Keep track of monitor-owned BDS

2015-03-03 Thread Max Reitz
Signed-off-by: Max Reitz --- block.c| 2 ++ blockdev.c | 18 ++ include/block/block_int.h | 4 stubs/Makefile.objs| 1 + stubs/blockdev-close-all-bdrv-states.c | 5 + 5 files

[Qemu-devel] [PATCH v5 12/13] block: Rewrite bdrv_close_all()

2015-03-03 Thread Max Reitz
This patch rewrites bdrv_close_all(): Until now, all root BDSs have been force-closed. This is bad because it can lead to cached data not being flushed to disk. Instead, try to make all reference holders relinquish their reference voluntarily: 1. All BlockBackend users are handled by making all B

[Qemu-devel] [PATCH v5 03/13] iotests: Add test for eject under NBD server

2015-03-03 Thread Max Reitz
This patch adds a test for ejecting the BlockBackend an NBD server is connected to (the NBD server is supposed to stop). Signed-off-by: Max Reitz --- tests/qemu-iotests/096 | 90 ++ tests/qemu-iotests/096.out | 16 + tests/qemu-iotests/grou

[Qemu-devel] [PATCH v5 02/13] iotests: Make redirecting qemu's stderr optional

2015-03-03 Thread Max Reitz
Redirecting qemu's stderr to stdout makes working with the stderr output difficult due to the other file descriptor magic performed in _launch_qemu ("ambiguous redirect"). Add an option which specifies whether stderr should be redirected to stdout or not (allowing for other modes to be added in th

[Qemu-devel] [PATCH v5 00/13] block: Rework bdrv_close_all()

2015-03-03 Thread Max Reitz
Currently, bdrv_close_all() force-closes all BDSs with a BlockBackend, which can lead to data corruption (see the iotest added in the final patch of this series) and is most certainly very ugly. This series reworks bdrv_close_all() to instead eject the BDS trees from all BlockBackends and then clo

[Qemu-devel] [PATCH v5 01/13] iotests: Move _filter_nbd into common.filter

2015-03-03 Thread Max Reitz
_filter_nbd can be useful for other NBD tests, too, therefore it should reside in common.filter, and it should support URLs of the "nbd://" format and export names. The NBD log lines ("/your/source/dir/nbd.c:function():line: error") should not be converted to empty lines but removed altogether. S

[Qemu-devel] [PATCH v5 06/13] block: Use blk_remove_bs() in blk_delete()

2015-03-03 Thread Max Reitz
Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- block/block-backend.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/block/block-backend.c b/block/block-backend.c index 755262d..76e6893 100644 --- a/block/block-backend.c +++ b/block/block-backend.c @@ -163,12 +

[Qemu-devel] [PATCH v5 07/13] blockdev: Use blk_remove_bs() in do_drive_del()

2015-03-03 Thread Max Reitz
Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- blockdev.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/blockdev.c b/blockdev.c index 56498ea..546acfe 100644 --- a/blockdev.c +++ b/blockdev.c @@ -2224,11 +2224,7 @@ int hmp_drive_del(Monitor *mon, const QDict *qdi

[Qemu-devel] [PATCH] iotests: Fix 061's reference output

2015-03-03 Thread Max Reitz
As of commit dc523cd348c47372faa7271c9aab2030f94c290d, passing an unkown option name for image creation no longer results in that option's name printed. This affects iotest 061's output, fix it. Signed-off-by: Max Reitz --- tests/qemu-iotests/061.out | 1 - 1 file changed, 1 deletion(-) diff --

Re: [Qemu-devel] [PATCH] target-arm: Fix multi-pass virt CPU feature parsing

2015-03-03 Thread Greg Bellows
Just saw that Ard sent out a similar fix. Disregard this patch if we decide to go with his (< 1425402380-10488-1-git-send-email-ard.biesheu...@linaro.org>). Greg On Tue, Mar 3, 2015 at 1:02 PM, Greg Bellows wrote: > Fixes issue when combining CPU features and smp. The issue is caused by > pars

Re: [Qemu-devel] [PATCH] hw/arm/virt: fix cmdline parsing bug with CPU options and smp > 1

2015-03-03 Thread Greg Bellows
On Tue, Mar 3, 2015 at 11:06 AM, Ard Biesheuvel wrote: > The recently introduced feature that allows 32 bit guests to be > executed under KVM on a 64-bit host incorrectly handles the case > where more than 1 cpu is specified using '-smp N' > > For instance, this invocation of qemu > > qemu-syst

[Qemu-devel] [PATCH] target-arm: Fix multi-pass virt CPU feature parsing

2015-03-03 Thread Greg Bellows
Fixes issue when combining CPU features and smp. The issue is caused by parse_feature's use of strtok which modifies the input feature string that is needed for each smp CPU pass. This patch restores the feature string for each pass. Signed-off-by: Greg Bellows --- hw/arm/virt.c | 14 +++

Re: [Qemu-devel] [PATCH] vl: take iothread lock very early

2015-03-03 Thread Oliver Francke
Hi, > Am 03.03.2015 um 18:32 schrieb Paolo Bonzini : > > > > On 03/03/2015 18:19, Oliver Francke wrote: >> >> #0 __GI_exit (status=1) at exit.c:104 >> #1 0x5575cf15 in os_daemonize () at os-posix.c:227 >> #2 0x55773f2e in main (argc=50, argv=0x7fffe0d8, >> envp=0x7ff

Re: [Qemu-devel] [PATCH 0/2] kvm_stat: add man page and tui column headers

2015-03-03 Thread Wei Huang
On 03/02/2015 05:29 PM, Stefan Hajnoczi wrote: > This series makes kvm_stat easier to learn for newcomers by adding a man page > and text UI column headers. > > Stefan Hajnoczi (2): > kvm_stat: add column headers to text UI > kvm_stat: add kvm_stat.1 man page > > Makefile

Re: [Qemu-devel] [PATCH 2/2] docs: add memory-hotplug.txt

2015-03-03 Thread Luiz Capitulino
On Tue, 03 Mar 2015 10:40:23 -0700 Eric Blake wrote: > On 03/02/2015 03:14 PM, Luiz Capitulino wrote: > > This document describes how to use memory hotplug in QEMU. > > > > Signed-off-by: Luiz Capitulino > > --- > > docs/memory-hotplug.txt | 76 > >

Re: [Qemu-devel] [PATCH 9/9] throttle: add name of ThrottleGroup to BlockDeviceInfo

2015-03-03 Thread Eric Blake
On 02/26/2015 06:56 AM, Alberto Garcia wrote: > On Wed, Feb 25, 2015 at 08:23:10AM -0700, Eric Blake wrote: > >> How about query-block-throttle, returning an array of dicts. >> >> => { "execute":"query-block-throttle" } >> <= { "return": [ >> { "name": "throttle1", "bps_max": 10, >>

Re: [Qemu-devel] [PATCH 2/2] docs: add memory-hotplug.txt

2015-03-03 Thread Eric Blake
On 03/02/2015 03:14 PM, Luiz Capitulino wrote: > This document describes how to use memory hotplug in QEMU. > > Signed-off-by: Luiz Capitulino > --- > docs/memory-hotplug.txt | 76 > + > 1 file changed, 76 insertions(+) > create mode 100644 docs/

Re: [Qemu-devel] [PATCH] virtio-pci: make pci bar layout more flexible.

2015-03-03 Thread Michael S. Tsirkin
On Tue, Mar 03, 2015 at 02:55:13PM +0100, Gerd Hoffmann wrote: > This patch makes the bar layout for virtio pci devices configurable. > This is used to > (a) create different layouts for legacy/transitional vs. modern > devices. > (b) make sure we use unused pci bars, by checking >

Re: [Qemu-devel] [PULL v2] pci, pc, virtio fixes and cleanups

2015-03-03 Thread Michael S. Tsirkin
On Tue, Mar 03, 2015 at 11:37:27PM +0900, Peter Maydell wrote: > On 27 February 2015 at 01:59, Michael S. Tsirkin wrote: > > Exactly the same thing as v1 but rebased to master to > > help Peter resolve conflicts, so I'm not bothering > > with resending all patches. > > > > A huge patchset, but the

Re: [Qemu-devel] [PATCH V14 2/3] pc: add a Virtual Machine Generation ID device

2015-03-03 Thread Michael S. Tsirkin
On Tue, Mar 03, 2015 at 05:18:14PM +0100, Igor Mammedov wrote: > Based on Microsoft's sepecifications (paper can be dowloaded from > http://go.microsoft.com/fwlink/?LinkId=260709), add a device > description to the SSDT ACPI table and its implementation. > > The GUID is set using "vmgenid.uuid" pr

Re: [Qemu-devel] [PATCH] vl: take iothread lock very early

2015-03-03 Thread Paolo Bonzini
On 03/03/2015 18:19, Oliver Francke wrote: > > #0 __GI_exit (status=1) at exit.c:104 > #1 0x5575cf15 in os_daemonize () at os-posix.c:227 > #2 0x55773f2e in main (argc=50, argv=0x7fffe0d8, > envp=0x7fffe270) at vl.c:3770 > > compiled with "--enable-debug" and in gdb "

[Qemu-devel] [PATCH] sdl2: Fix RGB555

2015-03-03 Thread Max Reitz
Reproducable with: $ x86_64-softmmu/qemu-system-x86_64 \ -kernel $vmlinuz_of_your_choice \ -append vga=0x313 -sdl Signed-off-by: Max Reitz --- include/ui/console.h | 5 + ui/sdl2-2d.c | 15 +-- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/incl

Re: [Qemu-devel] [PULL 00/69] Block patches

2015-03-03 Thread Max Reitz
On 2015-03-03 at 12:29, Christian Borntraeger wrote: Am 03.03.2015 um 15:52 schrieb Peter Maydell: On 28 February 2015 at 03:57, Stefan Hajnoczi wrote: On Fri, Feb 27, 2015 at 6:17 PM, Stefan Hajnoczi wrote: Ekaterina Tumanova (5): block: add bdrv functions for geometry and blocksize r

[Qemu-devel] [PULL v4 0/2] pci, pc, virtio fixes and cleanups

2015-03-03 Thread Michael S. Tsirkin
As previously, only sending incremental patches added since v3. This is an update of the previous pull request. Tree was not rebased so you can do both pulls if ou like. The following changes since commit 11d39a131020cc5c54ff9bc86d3259f7d32bf849: Merge remote-tracking branch 'remotes/borntraege

Re: [Qemu-devel] [PULL v2] pci, pc, virtio fixes and cleanups

2015-03-03 Thread Michael S. Tsirkin
On Tue, Mar 03, 2015 at 03:44:29PM +0100, Paolo Bonzini wrote: > > > On 03/03/2015 15:37, Peter Maydell wrote: > > Doesn't build with our minimum glib requirement, I'm afraid: > > > > /home/petmay01/linaro/qemu-for-merges/hw/acpi/aml-build.c:313: > > undefined reference to `g_ptr_array_new_with_

Re: [Qemu-devel] [PATCH] configure: require glib 2.22

2015-03-03 Thread Daniel P. Berrange
On Tue, Mar 03, 2015 at 04:24:15PM +0100, Paolo Bonzini wrote: > This provides g_ptr_array_new_with_free_func, as well as a few > other functions that we've been hacking around in glib-compat.h. > Cleaning up the compatibility headers will come later. > > Signed-off-by: Paolo Bonzini > --- > con

Re: [Qemu-devel] [PATCH] vl: take iothread lock very early

2015-03-03 Thread Paolo Bonzini
On 03/03/2015 17:03, Oliver Francke wrote: > > /usr/local/qemu-2.3.0/bin/qemu-system-x86_64 -daemonize -usbdevice > tablet -enable-kvm -pidfile /var/run/qemu-server/3371.pid -monitor > unix:/var/run/qemu-server/3371.mon,server,nowait -vnc > unix:/var/run/qemu-server/3371.vnc,password -qmp > unix

Re: [Qemu-devel] [PATCH 6/9] throttle: Add a way to fire one of the timers asap like a bottom half

2015-03-03 Thread Stefan Hajnoczi
On Fri, Feb 13, 2015 at 06:06:14PM +0200, Alberto Garcia wrote: > diff --git a/include/qemu/throttle.h b/include/qemu/throttle.h > index 69aa7c2..f846e5a 100644 > --- a/include/qemu/throttle.h > +++ b/include/qemu/throttle.h > @@ -127,6 +127,8 @@ bool throttle_schedule_timer(ThrottleState *ts, >

[Qemu-devel] Fwd: [RFC] Adding multithreads to LDREX/STREX.

2015-03-03 Thread Mark Burton
Paolo - here is a partially cleaned up patch - it’s still not quite right - but maybe its enough so that you can see what we’re doing. There are changes in here that wouldn’t be sensible to upstream - like changing the address from a 64 to a 32 bit and needlessly moving it about - thats just bec

[Qemu-devel] [PATCH V14 2/3] pc: add a Virtual Machine Generation ID device

2015-03-03 Thread Igor Mammedov
Based on Microsoft's sepecifications (paper can be dowloaded from http://go.microsoft.com/fwlink/?LinkId=260709), add a device description to the SSDT ACPI table and its implementation. The GUID is set using "vmgenid.uuid" property. Example of using vmgenid device: -device vmgenid,id=FOO,uuid="3

Re: [Qemu-devel] [RFC] Adding multithreads to LDREX/STREX.

2015-03-03 Thread Mark Burton
> On 3 Mar 2015, at 18:09, Paolo Bonzini wrote: > > > > On 03/03/2015 17:47, Mark Burton wrote: >> +inline void arm_exclusive_lock(void) >> +{ >> +if (!cpu_have_exclusive_lock) { >> +qemu_mutex_lock(&cpu_exclusive_lock); >> +cpu_have_exclusive_lock = true; >> +} >> +} >

Re: [Qemu-devel] Fwd: [RFC] Adding multithreads to LDREX/STREX.

2015-03-03 Thread Paolo Bonzini
On 03/03/2015 17:47, Mark Burton wrote: > +inline void arm_exclusive_lock(void) > +{ > +if (!cpu_have_exclusive_lock) { > +qemu_mutex_lock(&cpu_exclusive_lock); > +cpu_have_exclusive_lock = true; > +} > +} > + > +inline void arm_exclusive_unlock(void) > +{ > +if (cpu_h

[Qemu-devel] [PATCH V14 1/3] docs: vm generation id device's description

2015-03-03 Thread Igor Mammedov
From: Gal Hammer Signed-off-by: Gal Hammer Signed-off-by: Igor Mammedov --- v2: - ammend doc since no more MMIO occupied by vmgenid device and device became PCIDevice --- docs/specs/vmgenid.txt | 36 1 file changed, 36 insertions(+) create mode 100644

Re: [Qemu-devel] [PATCH 0/2] kvm_stat: add man page and tui column headers

2015-03-03 Thread Ademar Reis
On Mon, Mar 02, 2015 at 05:29:05PM -0600, Stefan Hajnoczi wrote: > This series makes kvm_stat easier to learn for newcomers by adding a man page > and text UI column headers. > > Stefan Hajnoczi (2): > kvm_stat: add column headers to text UI > kvm_stat: add kvm_stat.1 man page > > Makefile

Re: [Qemu-devel] [PATCH 4/9] throttle: Prepare to have multiple timers for one ThrottleState

2015-03-03 Thread Stefan Hajnoczi
On Fri, Feb 13, 2015 at 06:06:12PM +0200, Alberto Garcia wrote: > From: Benoît Canet > > This patch transform the timer_pending call into two boolean values in the > ThrottleState structure. > > This way we are sure that when multiple timers will be used only > one can be armed at a time. > > S

[Qemu-devel] [PATCH] hw/arm/virt: fix cmdline parsing bug with CPU options and smp > 1

2015-03-03 Thread Ard Biesheuvel
The recently introduced feature that allows 32 bit guests to be executed under KVM on a 64-bit host incorrectly handles the case where more than 1 cpu is specified using '-smp N' For instance, this invocation of qemu qemu-system-aarch64 -M virt -cpu cortex-a57,aarch64=off -smp 2 produces the f

Re: [Qemu-devel] [PATCH 4/4] sdl2: add support for display rendering using opengl.

2015-03-03 Thread Max Reitz
On 2015-03-03 at 07:07, Gerd Hoffmann wrote: Add new sdl2-gl.c file, with display rendering functions using opengl. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 1 + include/ui/sdl2.h| 11 + ui/Makefile.objs | 3 ++ ui/sdl.c | 10 + ui/sdl2-2d.

Re: [Qemu-devel] [PATCH v2] migration: Convert 'status' of MigrationInfo to use an enum type

2015-03-03 Thread Eric Blake
On 03/03/2015 12:15 AM, zhanghailiang wrote: >>> >>> Yes, this is the reason ..., agreed, i don't like the abbreviate, >>> But there is already a 'MigrationState' type defined: >>> >> >>> >>> So, what about MigrationStatus ? ;) >> >> That would be fine with me. >> > > Bad news, this name has also

[Qemu-devel] [PATCH V14 0/3] Virtual Machine Generation ID

2015-03-03 Thread Igor Mammedov
Changes since v13: * fix comment style to /*... */ in testcase * make BAR TARGET_PAGE_SIZE as required by spec * make BAR prefetchable, spec also says that it shouldn't be marked as non cached * ACPI part * merge separate VGID device with PCI device description * mark device as not s

Re: [Qemu-devel] [PULL 00/69] Block patches

2015-03-03 Thread Christian Borntraeger
Am 03.03.2015 um 15:52 schrieb Peter Maydell: > On 28 February 2015 at 03:57, Stefan Hajnoczi wrote: >> On Fri, Feb 27, 2015 at 6:17 PM, Stefan Hajnoczi wrote: >>> Ekaterina Tumanova (5): >>> block: add bdrv functions for geometry and blocksize >>> raw-posix: Factor block size detection out o

[Qemu-devel] [PULL v4 2/2] vhost user:support vhost user nic for non msi guests

2015-03-03 Thread Michael S. Tsirkin
From: Haifeng Gao Currently, vhost user nic doesn't support non msi guests(like pxe stage) by default. Vhost user nic can't fall back to qemu like normal vhost net nic does. So we should enable it for non msi guests. Signed-off-by: Haifeng Gao Reviewed-by: Michael S. Tsirkin Signed-off-by: M

Re: [Qemu-devel] [PATCH 1/4] opengl: some shader infrastructure

2015-03-03 Thread Max Reitz
On 2015-03-03 at 07:07, Gerd Hoffmann wrote: --- Makefile | 14 ++ scripts/shaderinclude.pl | 16 2 files changed, 30 insertions(+) create mode 100644 scripts/shaderinclude.pl With your S-o-b added: Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCH] vl: take iothread lock very early

2015-03-03 Thread Oliver Francke
First bt try below... On 03/03/2015 05:51 PM, Paolo Bonzini wrote: On 03/03/2015 17:03, Oliver Francke wrote: /usr/local/qemu-2.3.0/bin/qemu-system-x86_64 -daemonize -usbdevice tablet -enable-kvm -pidfile /var/run/qemu-server/3371.pid -monitor unix:/var/run/qemu-server/3371.mon,server,nowait -

[Qemu-devel] [PATCH V14 3/3] tests: add a unit test for the vmgenid device.

2015-03-03 Thread Igor Mammedov
* test that guest can read UUID provided on CLI from buffer accessing it at HPA which is available via 'vmgid-addr' property when device is inintialized. * test setting UUID at runtime and check that it's updated at expected HPA. Signed-off-by: Gal Hammer Signed-off-by: Igor Mammedov --- v

  1   2   3   >