Re: [Qemu-devel] [PATCH] target-tilegx: Finish decoding the first TB block.

2015-02-21 Thread Chen Gang S
On 2/22/15 09:08, Chen Gang S wrote: > On 2/22/15 08:25, Chris Metcalf wrote: [...] >> Similarly, if any pipeline takes an exception (a TLB fault from a memory op, >> a GPV fault from an illegal mfspr, etc) then no pipeline completes its >> action. >> > > Oh, really !! And I guess, Richard's co

Re: [Qemu-devel] [PATCH] target-tilegx: Finish decoding the first TB block.

2015-02-21 Thread Chen Gang S
On 2/22/15 08:25, Chris Metcalf wrote: > On 2/21/2015 7:25 PM, Chen Gang S wrote: >> On 2/22/15 00:33, Richard Henderson wrote: >>> >On 02/21/2015 07:31 AM, Chen Gang S wrote: >> >> - We can still use the original pipes order: "y0, y2, y1" and "x0, x1". >>> > >>> >I guess, sure, though I

Re: [Qemu-devel] [PATCH] target-tilegx: Finish decoding the first TB block.

2015-02-21 Thread Chris Metcalf
On 2/21/2015 7:25 PM, Chen Gang S wrote: On 2/22/15 00:33, Richard Henderson wrote: >On 02/21/2015 07:31 AM, Chen Gang S wrote: >> >> - We can still use the original pipes order: "y0, y2, y1" and "x0, x1". > >I guess, sure, though I don't think that'll help as much as you imagine. > OK, tha

Re: [Qemu-devel] [PATCH] target-tilegx: Finish decoding the first TB block.

2015-02-21 Thread Chen Gang S
On 2/22/15 00:33, Richard Henderson wrote: > On 02/21/2015 07:31 AM, Chen Gang S wrote: >> >> - We can still use the original pipes order: "y0, y2, y1" and "x0, x1". > > I guess, sure, though I don't think that'll help as much as you imagine. > >> - y0, y2, and x0 need to use tcg temporary vari

[Qemu-devel] [Bug 1424220] Re: Add manpage and usage message for qemu-bridge-helper

2015-02-21 Thread Karl-Philipp Richter
How about giving that information to the user when it _is_ invoked directly. The current usage information is misleading. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1424220 Title: Add manpage an

[Qemu-devel] [Bug 1424220] Re: Add manpage and usage message for qemu-bridge-helper

2015-02-21 Thread Paolo Bonzini
This is not necessary. qemu-bridge-helper is only started by QEMU itself, you are not supposed to invoke it directly. ** Changed in: qemu Status: New => Won't Fix -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.la

Re: [Qemu-devel] [PATCH v2 2/2] integrator/cp: Implement CARDIN and WPROT signals

2015-02-21 Thread Peter Crosthwaite
On Thu, Feb 19, 2015 at 9:53 AM, Jan Kiszka wrote: > This allows to use the SD card emulation of the board: Forward the > signals from the pl181 top the CP control register emulation, report the > current state via CP_INTREG, deliver CARDIN IRQ to the secondary > interrupt controller and also supp

Re: [Qemu-devel] [PATCH v2 1/2] integrator/cp: Model CP control registers as sysbus device

2015-02-21 Thread Peter Crosthwaite
On Thu, Feb 19, 2015 at 9:53 AM, Jan Kiszka wrote: > No new features yet, just encapsulation. > > Signed-off-by: Jan Kiszka > --- > hw/arm/integratorcp.c | 43 +++ > 1 file changed, 35 insertions(+), 8 deletions(-) > > diff --git a/hw/arm/integratorcp.c b/

Re: [Qemu-devel] [PATCH 4/4] scsi: Convert remaining PCI HBAs to realize()

2015-02-21 Thread Peter Crosthwaite
On Fri, Feb 20, 2015 at 11:20 AM, Markus Armbruster wrote: > These are "am53c974", "dc390", "lsi53c895a", "lsi53c810", "megasas", > "megasas-gen2". > > Signed-off-by: Markus Armbruster Reviewed-by: Peter Crosthwaite > --- > hw/scsi/esp-pci.c| 30 +++--- > hw/scsi/l

Re: [Qemu-devel] [PATCH 3/4] scsi: Improve error reporting for invalid drive property

2015-02-21 Thread Peter Crosthwaite
On Fri, Feb 20, 2015 at 11:19 AM, Markus Armbruster wrote: > When setting "realized" fails, scsi_bus_legacy_add_drive() passes the > error to qerror_report_err(), then returns an unspecific "Setting > drive property failed" error, which is reported further up the call > chain. > > Example: > >

Re: [Qemu-devel] [PATCH 2/4] hw: Propagate errors through qdev_prop_set_drive()

2015-02-21 Thread Peter Crosthwaite
On Fri, Feb 20, 2015 at 11:19 AM, Markus Armbruster wrote: > Three kinds of callers: > > 1. On failure, report the error and abort > >Passing &error_abort does the job. No functional change. > > 2. On failure, report the error and exit() > >This is qdev_prop_set_drive_nofail(). Error rep

Re: [Qemu-devel] [PATCH 1/4] scsi: Clean up duplicated error in legacy if=scsi code

2015-02-21 Thread Peter Crosthwaite
On Fri, Feb 20, 2015 at 11:19 AM, Markus Armbruster wrote: > Commit a818a4b changed scsi_bus_legacy_handle_cmdline() to report > errors from scsi_bus_legacy_add_drive() with error_report() in > addition to returning them. That's inappropriate. > > Two kinds of callers: > > 1. realize methods (dev

Re: [Qemu-devel] [PATCH v4 0/2] Reworked Zynq GPIO model

2015-02-21 Thread Peter Crosthwaite
On Mon, Feb 9, 2015 at 10:06 PM, Peter Crosthwaite wrote: > On Sun, Jan 25, 2015 at 11:51 AM, Colin Leitner > wrote: >> Hello everyone, >> >> this is the fourth version of the Zynq GPIO model patch. It includes >> >> * removal of unneeded memset in zynq_gpio_realize >> * some minor code cleanup

Re: [Qemu-devel] [PATCH v2 1/2] arm: Add the cortex-a9 CPU to the a9mpcore device

2015-02-21 Thread Peter Crosthwaite
On Tue, Feb 17, 2015 at 7:59 PM, Alistair Francis wrote: > This patch adds the Cortex-A9 ARM CPU to the A9MPCore. > > The CPU is only created if the num-cpu property is set. > > This patch allows the midr and reset-cbar properties to be set > > Signed-off-by: Alistair Francis > --- > V2: > - Ren

[Qemu-devel] [Bug 1424220] [NEW] Add manpage and usage message for qemu-bridge-helper

2015-02-21 Thread Karl-Philipp Richter
Public bug reported: `qemu-bridge-helper -h/--help` should display a usage message explaining the options and arguments of the program/script. experienced with 2.1.0 on Ubuntu 14.10 amd64 ** Affects: qemu Importance: Undecided Status: New ** Description changed: `qemu-bridge-he

Re: [Qemu-devel] [PATCH v11 4/5] stm32f205: Add the stm32f205 SoC

2015-02-21 Thread Peter Crosthwaite
On Tue, Feb 17, 2015 at 4:38 AM, Alistair Francis wrote: > This patch adds the stm32f205 SoC. This will be used by the > Netduino 2 to create a machine. > > Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite > --- > V11: > - Update the headers to only include the required files >

Re: [Qemu-devel] [PATCH] target-tilegx: Finish decoding the first TB block.

2015-02-21 Thread Richard Henderson
On 02/21/2015 07:31 AM, Chen Gang S wrote: > > Oh, we can not only assume y1 and x1 is the last execution in a bundle, > e.g. in __libc_start_main: > >11330: c6f106c685928d8a{ addi r10, sp, 40 ; addi r13, sp, 32 > ; st r25, r30 } >11338: 286201401fca{ move

Re: [Qemu-devel] [PATCH v3] Makefile.target: set icon for binary file on Mac OS X

2015-02-21 Thread Programmingkid
On Feb 21, 2015, at 7:14 AM, Peter Maydell wrote: > On 20 February 2015 at 05:51, Programmingkid > wrote: >> This patch sets the icon for the QEMU binary on Mac OS X. >> >> Signed-off-by: John Arbuckle >> >> --- >> Added conditional code to make the icon setting happen only on Mac OS X. >>

Re: [Qemu-devel] [PATCH v3] Makefile.target: set icon for binary file on Mac OS X

2015-02-21 Thread Programmingkid
On Feb 20, 2015, at 8:05 PM, Peter Maydell wrote: > On 21 February 2015 at 02:25, Paolo Bonzini wrote: >> I honestly don't know which versions are supported. 10.5 was released >> in 2007 and it is enough for Darwin/PPC, so it's probably okay. > > Yes, I think 10.5 is the earliest we currently

Re: [Qemu-devel] [PATCH] target-tilegx: Finish decoding the first TB block.

2015-02-21 Thread Chen Gang S
I guess, y2 does not need tcg temporary variables either, since it is only for ld/st operation (all memory operations must be only processed by y2 or x1). At present, I can generate the tcg code for _start TB block, and can execute to 2nd TB block __libc_start_main (although I don't know whether

Re: [Qemu-devel] [PATCH] target-tilegx: Finish decoding the first TB block.

2015-02-21 Thread Chen Gang S
Oh, we can not only assume y1 and x1 is the last execution in a bundle, e.g. in __libc_start_main: 11330: c6f106c685928d8a{ addi r10, sp, 40 ; addi r13, sp, 32 ; st r25, r30 } 11338: 286201401fca{ moveli r10, 0 ; st r10, r0 } In this case, r10 will be over

Re: [Qemu-devel] [PATCH v3] Makefile.target: set icon for binary file on Mac OS X

2015-02-21 Thread Peter Maydell
On 20 February 2015 at 05:51, Programmingkid wrote: > This patch sets the icon for the QEMU binary on Mac OS X. > > Signed-off-by: John Arbuckle > > --- > Added conditional code to make the icon setting happen only on Mac OS X. > > Makefile.target |4 + > pc-bios/qemu.rsrc | 1504 > ++

Re: [Qemu-devel] [PATCH] Makefile.target: set icon for binary file on Mac OS X

2015-02-21 Thread Paolo Bonzini
> > > When I was inspecting the icon using the genie feature of Mac OS X's > > > dock, the icon looked very sharp at full size, so I didn't see a > > > problem with it. What size do you have in mind? > > > > I was thinking of 16x16, 32x32, 48x48 and 128x128. > > What advantages do you think this