[Qemu-devel] Port Problem

2015-02-16 Thread Jc Chua
Hi, I notice qemu is using slirp.. I was wondering why when I disconnect the device without exiting properly, the slirp hold on to the port number and i cannot use that port number again. can anyone help me with this? it causing my program to crashed for i think slirp is forking and causes the

Re: [Qemu-devel] [PATCH] virtio-blk: Check return value of blk_aio_ioctl

2015-02-16 Thread Paolo Bonzini
On 17/02/2015 04:29, Fam Zheng wrote: > Since commit 1dc936aa84 (virtio-blk: Use blk_aio_ioctl) we silently lose > the request if blk_aio_ioctl returns NULL (not implemented). > > Fix it by directly returning VIRTIO_BLK_S_UNSUPP as we used to do. > > Signed-off-by: Fam Zheng > --- > hw/block/

Re: [Qemu-devel] [PATCH v7 07/10] qmp: add rocker device support

2015-02-16 Thread Paolo Bonzini
On 16/02/2015 23:37, Scott Feldman wrote: >> > I would just merge the other nine patches for 2.3. > I disagree. qmp/hmp is very important to rocker. It would be nearly > impossible to debug large/complicated networking setups without having > a back-door view into the device. qmp/hmp are perfe

Re: [Qemu-devel] [PATCHv4 1/2] m48t59: introduce new base-year qdev property

2015-02-16 Thread Hervé Poussineau
Le 17/02/2015 00:38, Mark Cave-Ayland a écrit : Currently the m48t59 device uses the hardware model in order to determine whether the year value is offset from the hardware value. As this will soon be required by the x59 model, create a qdev base-year property to represent the base year and updat

Re: [Qemu-devel] [PATCH v2 1/4] virtio-pci: add flags to enable/disable legacy/modern

2015-02-16 Thread Fam Zheng
On Mon, 02/16 17:33, Gerd Hoffmann wrote: > Add VIRTIO_PCI_FLAG_DISABLE_LEGACY and VIRTIO_PCI_FLAG_DISABLE_MODERN > for VirtIOPCIProxy->flags. Also add properties for them. They can be > used to disable modern (virtio 1.0) or legacy (virtio 0.9) modes. By > default both are advertized and the gu

[Qemu-devel] [PATCH v5] ui/cocoa.m: Machine menu patch for Mac OS X

2015-02-16 Thread Programmingkid
Added features: Menu items to switch floppy and CD image files. Menu items to eject floppy and CD image files. Menu item to use /dev/cdrom. Verifies with the user before quitting QEMU by displaying a dialog box. Pause and resume menu items with the word paused displayed on the window. Signed-off-b

[Qemu-devel] [PATCH v4] ui/cocoa.m: Machine menu patch for Mac OS X

2015-02-16 Thread Programmingkid
Added features: Menu items to switch floppy and CD image files. Menu items to eject floppy and CD image files. Menu item to use /dev/cdrom. Verifies with the user before quitting QEMU by displaying a dialog box. Pause and resume menu items with the word pause displayed on the window. Signed-off-by

Re: [Qemu-devel] [PATCH v7 07/10] qmp: add rocker device support

2015-02-16 Thread Scott Feldman
On Mon, Feb 16, 2015 at 5:16 PM, Paolo Bonzini wrote: > > > On 16/02/2015 22:47, sfel...@gmail.com wrote: >> From: Scott Feldman >> >> Add QMP/HMP support for rocker devices. This is mostly for debugging >> purposes >> to see inside the device's tables and port configurations. Some examples: >

Re: [Qemu-devel] [RFC PATCH v1 11/13] spapr: Initialize hotplug memory address space

2015-02-16 Thread Bharata B Rao
On Mon, Feb 16, 2015 at 03:56:24PM +1100, David Gibson wrote: > > > > diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h > > > > index ae8b4e1..64681c4 100644 > > > > --- a/include/hw/ppc/spapr.h > > > > +++ b/include/hw/ppc/spapr.h > > > > @@ -482,6 +482,9 @@ struct sPAPRTCETable { > > >

[Qemu-devel] [PATCH] virtio-blk: Check return value of blk_aio_ioctl

2015-02-16 Thread Fam Zheng
Since commit 1dc936aa84 (virtio-blk: Use blk_aio_ioctl) we silently lose the request if blk_aio_ioctl returns NULL (not implemented). Fix it by directly returning VIRTIO_BLK_S_UNSUPP as we used to do. Signed-off-by: Fam Zheng --- hw/block/virtio-blk.c | 9 +++-- 1 file changed, 7 insertions

[Qemu-devel] [PATCH 08/10] qga: implement qmp_guest_get_memory_block_size() for Linux with sysfs

2015-02-16 Thread Michael Roth
From: zhanghailiang The size of a memory block is architecture dependent, it represents the logical unit upon which memory online/offline operations are to be performed. Signed-off-by: zhanghailiang Signed-off-by: Michael Roth --- qga/commands-posix.c | 29 +++-- 1 fil

[Qemu-devel] [PATCH 03/10] guest agent: guest-file-open: refactoring

2015-02-16 Thread Michael Roth
From: Simon Zolin Moved the code that sets non-blocking flag on fd into a separate function. Signed-off-by: Simon Zolin Reviewed-by: Roman Kagan Signed-off-by: Denis V. Lunev CC: Michael Roth CC: Eric Blake Signed-off-by: Michael Roth --- qga/commands-posix.c | 31 +++-

[Qemu-devel] [PATCH 07/10] qga: implement qmp_guest_set_memory_blocks() for Linux with sysfs

2015-02-16 Thread Michael Roth
From: zhanghailiang We can change guest's online/offline state of memory blocks, by using command 'guest-set-memory-blocks'. Signed-off-by: zhanghailiang Signed-off-by: Michael Roth --- qga/commands-posix.c | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-)

[Qemu-devel] [PATCH 06/10] qga: implement qmp_guest_get_memory_blocks() for Linux with sysfs

2015-02-16 Thread Michael Roth
From: zhanghailiang We can get guest's memory block information by using command "guest-get-memory-blocks", the returned value contains a list of memory block info, such as phys-index, online state, can-offline info. Signed-off-by: zhanghailiang *replaced guest-triggerable assertion with an er

[Qemu-devel] [PATCH 09/10] qga: add memory block command that unsupported

2015-02-16 Thread Michael Roth
From: zhanghailiang For memory block command, we only support for linux with sysfs. Signed-off-by: zhanghailiang Reviewed-by: Michael Roth Signed-off-by: Michael Roth --- qga/commands-posix.c | 4 +++- qga/commands-win32.c | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a

[Qemu-devel] [PATCH 04/10] qga: implement file commands for Windows guest

2015-02-16 Thread Michael Roth
From: Olga Krishtal The following commands are implemented: - guest_file_open - guest_file_close - guest_file_write - guest_file_read - guest_file_seek - guest_file_flush Motivation is quite simple: Windows guests should be supported with the same set of features as Linux one. Also this patch is

[Qemu-devel] [PULL 00/10] Fixes and new commands for QEMU Guest Agent

2015-02-16 Thread Michael Roth
The following changes since commit cd2d5541271f1934345d8ca42f5fafff1744eee7: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20150212' into staging (2015-02-13 11:44:50 +) are available in the git repository at: git://github.com/mdroth/qemu.git tags/qga-pull-2015-02-16-tag for

[Qemu-devel] [PATCH 02/10] utils: drop strtok_r from envlist_parse

2015-02-16 Thread Michael Roth
From: Olga Krishtal The problem is that mingw 4.9.1 fails to compile the code with the following warning: /mingw/include/string.h:88:9: note: previous declaration of 'strtok_r' was here char *strtok_r(char * __restrict__ _Str, const char * __restrict__ _Delim,

[Qemu-devel] [PATCH 05/10] qga: introduce three guest memory block commmands with stubs

2015-02-16 Thread Michael Roth
From: zhanghailiang Introduce three new guest commands: guest-get-memory-blocks, guest-set-memory-blocks, guest-get-memory-block-size. With these three commands, we can support online/offline guest's memory block (logical memory hotplug/unplug) as required from host. Signed-off-by: zhanghailian

[Qemu-devel] [PATCH 01/10] qga: add guest-set-user-password command

2015-02-16 Thread Michael Roth
From: "Daniel P. Berrange" Add a new 'guest-set-user-password' command for changing the password of guest OS user accounts. This command is needed to enable OpenStack to support its API for changing the admin password of guests running on KVM/QEMU. It is not practical to provide a command at the

[Qemu-devel] [PATCH 10/10] qemu-ga-win: Fail loudly on bare 'set-time'

2015-02-16 Thread Michael Roth
From: Michal Privoznik The command is not implemented correctly yet. The documentation allows to not pass any value to set, in which case the time is re-read from RTC. However, reading CMOS on Windows is not trivial to implement. So instead of pretending we've set the correct time, fail explicitl

Re: [Qemu-devel] [PATCH 1/5] target-tile: Firstly add to qemu with minimized features

2015-02-16 Thread Chen Gang S
And of cause, it is not the excuse to let me stop: - I shall integrate binutils disassembler firstly in my own branch for the related test and learning. - According to binutils disassembler implementation, I shall write translate.c step by step. - After finish translate.c, I shall send

Re: [Qemu-devel] [PATCH 1/5] target-tile: Firstly add to qemu with minimized features

2015-02-16 Thread Chen Gang S
On 2/17/15 10:48, Chen Gang S wrote: > On 2/17/15 08:11, Chris Metcalf wrote: >> On 2/16/2015 6:46 PM, Peter Maydell wrote: >>> On 17 February 2015 at 08:08, Chen Gang S wrote: On 2/16/15 23:24, Max Filippov wrote: > Disassembler is not a crucial part of QEMU target. For me, it is ne

Re: [Qemu-devel] [PATCH 1/6 v2] target-tilegx: Firstly add to qemu with minimized features

2015-02-16 Thread Chen Gang S
On 2/17/15 10:15, Richard Henderson wrote: > On 02/16/2015 02:51 PM, Chen Gang S wrote: >> And excuse me, I still want to know, is there a real world register as a >> PC register for tile (e.g. just like 'rip' for x86_64) which can be used >> by software programer? (is it in SPR?) > > Do you actua

[Qemu-devel] [Bug 1422285] Re: The guest will be destroyed when hot plug the VF to guest for the second time.

2015-02-16 Thread chao zhou
the first bad commit: commit 374f2981d1f10bc4307f250f24b2a7ddb9b14be0 Author: Paolo Bonzini Date: Fri May 17 12:37:03 2013 +0200 memory: protect current_map by RCU Replace the flat_view_mutex with RCU, avoiding futex contention for dataplane on large systems and many iothreads

[Qemu-devel] [Bug 1422285] Re: The guest will be destroyed when hot plug the VF to guest for the second time.

2015-02-16 Thread chao zhou
please ignore comment 1. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1422285 Title: The guest will be destroyed when hot plug the VF to guest for the second time. Status in QEMU: New Bug de

Re: [Qemu-devel] [PATCH 1/5] target-tile: Firstly add to qemu with minimized features

2015-02-16 Thread Chen Gang S
On 2/17/15 08:11, Chris Metcalf wrote: > On 2/16/2015 6:46 PM, Peter Maydell wrote: >> On 17 February 2015 at 08:08, Chen Gang S wrote: >>> On 2/16/15 23:24, Max Filippov wrote: Disassembler is not a crucial part of QEMU target. >>> For me, it is necessary. We need disassemble target binary i

Re: [Qemu-devel] [PATCH v7 07/10] qmp: add rocker device support

2015-02-16 Thread David Ahern
On 2/16/15 3:37 PM, Scott Feldman wrote: On Mon, Feb 16, 2015 at 5:16 PM, Paolo Bonzini wrote: On 16/02/2015 22:47, sfel...@gmail.com wrote: From: Scott Feldman Add QMP/HMP support for rocker devices. This is mostly for debugging purposes to see inside the device's tables and port configu

Re: [Qemu-devel] [PATCH v4 18/18] vfio: Enable in-kernel acceleration via VFIO KVM device

2015-02-16 Thread Alexey Kardashevskiy
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/05/2015 03:49 PM, David Gibson wrote: > On Thu, Jan 29, 2015 at 08:27:30PM +1100, Alexey Kardashevskiy wrote: >> TCE hypercalls (H_PUT_TCE, H_PUT_TCE_INDIRECT, H_STUFF_TCE) use a >> logical bus number (LIOBN) to identify which TCE table the reque

Re: [Qemu-devel] [PATCH v4 08/18] vfio: Add DMA memory registering [repost]

2015-02-16 Thread Alexey Kardashevskiy
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Repost as I think I pressed "crtl-r" and thunberbird killed the formatting :) On 02/02/2015 06:04 PM, David Gibson wrote: > On Thu, Jan 29, 2015 at 08:27:20PM +1100, Alexey Kardashevskiy wrote: >> This makes use of the new "memory registering" featur

[Qemu-devel] [RFC PATCH v3 10/11] hw/arm/virt-acpi-build: Generate RSDP table

2015-02-16 Thread Shannon Zhao
RSDP points to RSDT which in turn points to other tables. Signed-off-by: Shannon Zhao --- hw/arm/virt-acpi-build.c | 32 1 files changed, 32 insertions(+), 0 deletions(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index 245770a..bfbddbe 1

Re: [Qemu-devel] [PATCH 1/6 v2] target-tilegx: Firstly add to qemu with minimized features

2015-02-16 Thread Richard Henderson
On 02/16/2015 02:51 PM, Chen Gang S wrote: > And excuse me, I still want to know, is there a real world register as a > PC register for tile (e.g. just like 'rip' for x86_64) which can be used > by software programer? (is it in SPR?) Do you actually have the manual for this chip? If you're asking

[Qemu-devel] [RFC PATCH v3 08/11] hw/arm/virt-acpi-build: Generate GTDT table

2015-02-16 Thread Shannon Zhao
ACPI v5.1 defines GTDT for ARM devices as a place to describe timer related information in the system. The Arch Timer interrupts must be provided for GTDT. Signed-off-by: Shannon Zhao --- hw/arm/virt-acpi-build.c| 31 +++ include/hw/acpi/acpi-defs.h | 37 +

[Qemu-devel] [RFC PATCH v3 07/11] hw/arm/virt-acpi-build: Generate MADT table

2015-02-16 Thread Shannon Zhao
MADT describes GIC enabled ARM platforms. The GICC and GICD subtables are used to define the GIC regions. Signed-off-by: Shannon Zhao --- hw/arm/virt-acpi-build.c | 62 ++ include/hw/acpi/acpi-defs.h | 36 +- include/hw/arm

[Qemu-devel] [RFC PATCH v3 11/11] hw/arm/virt: Enable dynamic generation of ACPI v5.1 tables

2015-02-16 Thread Shannon Zhao
Expose the needed device information to the table generation insfrastructure and register a machine_init_done notify to call virt_acpi_build(). Add CONFIG_ACPI to arm-softmmu.mak. Maybe this way is not right, fix me please. Signed-off-by: Shannon Zhao --- default-configs/arm-softmmu.mak |

Re: [Qemu-devel] [PATCH v4 08/18] vfio: Add DMA memory registering

2015-02-16 Thread Alexey Kardashevskiy
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/02/2015 06:04 PM, David Gibson wrote: > On Thu, Jan 29, 2015 at 08:27:20PM +1100, Alexey Kardashevskiy wrote: >> This makes use of the new "memory registering" feature. The idea is >> to provide the guest ability to notify the host kernel about

[Qemu-devel] [RFC PATCH v3 01/11] hw/i386: Move ACPI header definitions in an arch-independent location

2015-02-16 Thread Shannon Zhao
The ACPI related header file acpi-defs.h, includes definitions that apply on other architectures as well. Move it in `include/hw/acpi/` to sanely include it from other architectures. Signed-off-by: Alvise Rigo Signed-off-by: Shannon Zhao --- hw/i386/acpi-build.c|2 +- hw/i386/acpi-d

[Qemu-devel] [RFC PATCH v3 00/11] Generate ACPI v5.1 tables and expose it to guest over fw_cfg on ARM

2015-02-16 Thread Shannon Zhao
This patch series generate six ACPI v5.1 tables for machine virt on ARM. The set of generated tables are: - RSDP - RSDT - MADT - GTDT - FADT - DSDT These tables are created dynamically using the function of acpi-build-utils.c, taking into account the needed information passed from the virt machine

[Qemu-devel] [RFC PATCH v3 05/11] hw/arm/virt-acpi-build: Generation of DSDT table for virt devices

2015-02-16 Thread Shannon Zhao
DSDT consists of the usual common table header plus a definition block in AML encoding which describes all devices in the platform. After initializing DSDT with header information the namespace is created which is followed by the device encodings. The devices are described using the Resource Templ

[Qemu-devel] [RFC PATCH v3 06/11] hw/arm/virt-acpi-build: Generate FADT table and update ACPI headers

2015-02-16 Thread Shannon Zhao
In the case of mach virt, it is used to set the Hardware Reduced bit and enable PSCI SMP booting through HVC. So ignore FACS and FADT points to DSDT. Update the header definitions for FADT taking into account the new additions of ACPI v5.1 in `include/hw/acpi/acpi-defs.h` Signed-off-by: Shannon Z

[Qemu-devel] [RFC PATCH v3 04/11] hw/acpi/aml-build: Add aml_memory32_fixed() and aml_interrupt()

2015-02-16 Thread Shannon Zhao
Add aml_memory32_fixed() for describing device mmio region in resource template. Add aml_interrupt() for describing device interrupt in resource template. These can be used to generating DSDT table for ACPI on ARM. Signed-off-by: Shannon Zhao --- hw/acpi/aml-build.c | 40 ++

[Qemu-devel] [RFC PATCH v3 09/11] hw/arm/virt-acpi-build: Generate RSDT table

2015-02-16 Thread Shannon Zhao
RDST points to other tables FADT, MADT, GTDT. Signed-off-by: Shannon Zhao --- hw/arm/virt-acpi-build.c | 31 ++- 1 files changed, 30 insertions(+), 1 deletions(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index bee2e7f..245770a 100644 --- a/h

Re: [Qemu-devel] [PATCH v2 0/5] qga: add three logical memory hotplug related commands

2015-02-16 Thread Michael Roth
Quoting zhanghailiang (2015-01-21 20:40:01) > This patch series add three guest commands about memory block: > guest-get-memory-blocks, guest-set-memory-blocks, guest-get-memory-block-size. > > With these three commands, we can get information about guest's memory block > online/offline status and

[Qemu-devel] [RFC PATCH v3 02/11] hw/i386/acpi-build: move generic acpi building helpers into dedictated file

2015-02-16 Thread Shannon Zhao
Move generic acpi building helpers into dedictated file and this can be shared with other machines. Signed-off-by: Shannon Zhao --- hw/acpi/aml-build.c | 58 hw/i386/acpi-build.c| 104 +-- hw/i386/acpi-build.h

Re: [Qemu-devel] [PATCH v3] qga: add guest-set-user-password command

2015-02-16 Thread Michael Roth
Quoting Daniel P. Berrange (2015-02-11 05:26:12) > Add a new 'guest-set-user-password' command for changing the password > of guest OS user accounts. This command is needed to enable OpenStack > to support its API for changing the admin password of guests running > on KVM/QEMU. It is not practical

[Qemu-devel] [RFC PATCH v3 03/11] hw/arm/virt-acpi-build: Basic framework for building ACPI tables on ARM

2015-02-16 Thread Shannon Zhao
Introduce a preliminary framework in virt-acpi-build.c with the main ACPI build functions. It exposes the generated ACPI contents to guest over fw_cfg. The required ACPI v5.1 tables for ARM are: - RSDP: Initial table that points to XSDT - RSDT: Points to FADT GTDT MADT tables - FADT: Generic infor

Re: [Qemu-devel] [PATCH v3] qga: add guest-set-user-password command

2015-02-16 Thread Michael Roth
Quoting Olga Krishtal (2015-02-13 06:26:09) > On 11/02/15 14:26, Daniel P. Berrange wrote: > > Add a new 'guest-set-user-password' command for changing the password > > of guest OS user accounts. This command is needed to enable OpenStack > > to support its API for changing the admin password of gu

Re: [Qemu-devel] [PATCH 0/3] qemu guest agent: support guest-file-* command for Windows

2015-02-16 Thread Michael Roth
Quoting Denis V. Lunev (2015-02-06 11:59:52) > This was a part of patchset implemented guest-exec command. > It was suggested to submit it separately by Michael. > > The set contains small refactoring to fix mingw 4.9.1 compilation > and safe part of the rework of posix file interface plus main >

Re: [Qemu-devel] [PATCH] qemu-ga-win: Fail loudly on bare 'set-time'

2015-02-16 Thread Michael Roth
Quoting Michal Privoznik (2015-01-21 05:09:50) > The command is not implemented correctly yet. The documentation allows > to not pass any value to set, in which case the time is re-read from > RTC. However, reading CMOS on Windows is not trivial to implement. So > instead of pretending we've set th

Re: [Qemu-devel] [PATCH 1/5] target-tile: Firstly add to qemu with minimized features

2015-02-16 Thread Chris Metcalf
Yes, I think there is a bit less documentation on tilegx SPRs available. If this becomes a blocker for you, let me know and I will see if there is anything we can do about it. Probably best to wait until you have made more progress on qemu before trying to make a case for it internally, though.

Re: [Qemu-devel] [PATCH 1/6 v2] target-tilegx: Firstly add to qemu with minimized features

2015-02-16 Thread Chen Gang S
On 2/17/15 08:28, Chris Metcalf wrote: > On 2/16/2015 5:51 PM, Chen Gang S wrote: > >> And excuse me, I still want to know, is there a real world register as a >> PC register for tile (e.g. just like 'rip' for x86_64) which can be used >> by software programer? (is it in SPR?) > > There is no reg

Re: [Qemu-devel] [PATCH 1/5] target-tile: Firstly add to qemu with minimized features

2015-02-16 Thread Chen Gang S
On 2/17/15 08:29, Chris Metcalf wrote: > Yes, I think there is a bit less documentation on tilegx SPRs available. > If this becomes a blocker for you, let me know and I will see if there is > anything > we can do about it. Probably best to wait until you have made more progress > on qemu before t

Re: [Qemu-devel] [PATCH v3] ui/cocoa.m: Machine menu patch for Mac OS X

2015-02-16 Thread Programmingkid
On Feb 16, 2015, at 6:41 PM, Peter Maydell wrote: > On 17 February 2015 at 01:22, Kevin Wolf wrote: >> You could still apply some translation table to the menu entry string, >> like: >> >> floppy0 => Floppy drive A >> floppy1 => Floppy drive B >> ide0-cd0=> IDE CD-ROM (Primary Maste

Re: [Qemu-devel] [PATCH v4 15/18] spapr_pci_vfio: Enable multiple groups per container

2015-02-16 Thread Alexey Kardashevskiy
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/05/2015 03:19 PM, David Gibson wrote: > On Thu, Jan 29, 2015 at 08:27:27PM +1100, Alexey Kardashevskiy wrote: >> This enables multiple IOMMU groups in one VFIO container which >> means that multiple devices from different groups can share the sam

Re: [Qemu-devel] [PATCH 1/6 v2] target-tilegx: Firstly add to qemu with minimized features

2015-02-16 Thread Chris Metcalf
On 2/16/2015 5:51 PM, Chen Gang S wrote: And excuse me, I still want to know, is there a real world register as a PC register for tile (e.g. just like 'rip' for x86_64) which can be used by software programer? (is it in SPR?) There is no register you can read that holds the current PC. You ca

Re: [Qemu-devel] [PATCH 1/5] target-tile: Firstly add to qemu with minimized features

2015-02-16 Thread Chris Metcalf
On 2/16/2015 6:46 PM, Peter Maydell wrote: On 17 February 2015 at 08:08, Chen Gang S wrote: On 2/16/15 23:24, Max Filippov wrote: Disassembler is not a crucial part of QEMU target. For me, it is necessary. We need disassemble target binary instructions (recognize them), then translate them in

Re: [Qemu-devel] [PATCH RFC v3 17/27] COLO: Add new command parameter 'colo_nicname' 'colo_script' for net

2015-02-16 Thread Eric Blake
On 02/11/2015 08:17 PM, zhanghailiang wrote: > The 'colo_nicname' should be assigned with network name, > for exmple, 'eth2'. It will be parameter of 'colo_script', s/exmple/example/ > 'colo_script' should be assigned with an scirpt path. s/an scirpt/a script/ > > We parse these parameter in t

Re: [Qemu-devel] [PATCH RFC v3 14/27] COLO failover: Introduce a new command to trigger a failover

2015-02-16 Thread Eric Blake
On 02/11/2015 08:17 PM, zhanghailiang wrote: > We leave users to use whatever heartbeat solution they want, if the heartbeat > is lost, or other errors they detect, they can use command > 'colo_lost_heartbeat' to tell COLO to do failover, COLO will do operations > accordingly. > > For example, > I

Re: [Qemu-devel] [PATCH 1/5] target-tile: Firstly add to qemu with minimized features

2015-02-16 Thread Peter Maydell
On 17 February 2015 at 08:08, Chen Gang S wrote: > On 2/16/15 23:24, Max Filippov wrote: >> Disassembler is not a crucial part of QEMU target. > > For me, it is necessary. We need disassemble target binary instructions > (recognize them), then translate them into tcg instructions which are > group

Re: [Qemu-devel] [PATCH v3] ui/cocoa.m: Machine menu patch for Mac OS X

2015-02-16 Thread Peter Maydell
On 17 February 2015 at 01:22, Kevin Wolf wrote: > You could still apply some translation table to the menu entry string, > like: > > floppy0 => Floppy drive A > floppy1 => Floppy drive B > ide0-cd0=> IDE CD-ROM (Primary Master) > ide0-cd1=> IDE CD-ROM (Primary Slave) > ide1-cd0

[Qemu-devel] [PATCHv4 2/2] m48t59: add m48t59 sysbus device

2015-02-16 Thread Mark Cave-Ayland
This is for subsequent use by the sun4u machine. Signed-off-by: Mark Cave-Ayland Reviewed-by: Hervé Poussineau --- hw/timer/m48t59.c |4 1 file changed, 4 insertions(+) diff --git a/hw/timer/m48t59.c b/hw/timer/m48t59.c index d3d8079..8ab683d 100644 --- a/hw/timer/m48t59.c +++ b/hw/ti

[Qemu-devel] [PATCHv4 1/2] m48t59: introduce new base-year qdev property

2015-02-16 Thread Mark Cave-Ayland
Currently the m48t59 device uses the hardware model in order to determine whether the year value is offset from the hardware value. As this will soon be required by the x59 model, create a qdev base-year property to represent the base year and update the callers appropriately. Signed-off-by: Mark

[Qemu-devel] [PATCHv4 0/2] m48t59: add year offset and sysbus device

2015-02-16 Thread Mark Cave-Ayland
This patchset lays the groundwork for switching sun4u over from ioport NVRAM access to MMIO NVRAM access. Patch 1 introduces a new base-year property which represents the base year of the zero hardware year value. In particular, Sun hardware has a base year of 1968 used to extend the date range o

Re: [Qemu-devel] [PATCH 09/13] qemu-img: Suppress unhelpful extra errors in convert, amend

2015-02-16 Thread Eric Blake
On 02/16/2015 07:44 AM, Markus Armbruster wrote: > img_convert() and img_amend() use qemu_opts_do_parse(), which reports > errors with qerror_report_err(). Its error messages aren't helpful > here, the caller reports one that actually makes sense. Reproducer: > > $ qemu-img convert -o backin

Re: [Qemu-devel] [PATCH 1/5] target-tile: Firstly add to qemu with minimized features

2015-02-16 Thread Chen Gang S
On 2/16/15 23:00, Chris Metcalf wrote: > On 2/16/2015 9:44 AM, Chen Gang S wrote: >> Excuse me, after comparing the code details between kernel version >> disassembler and binutils version disassembler, I am sure the kernel >> version disassembler is the part of the binutils version disassembler: >

Re: [Qemu-devel] [PATCH RFC v3 04/27] migration: Integrate COLO checkpoint process into migration

2015-02-16 Thread Eric Blake
On 02/11/2015 08:16 PM, zhanghailiang wrote: > Add a migrate state: MIG_STATE_COLO, enter this migration state > after the first live migration successfully finished. > > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > Signed-off-by: Lai Jiangshan > --- > include/migration/migration-co

Re: [Qemu-devel] [PATCH RFC v3 03/27] COLO: migrate colo related info to slave

2015-02-16 Thread Eric Blake
On 02/11/2015 08:16 PM, zhanghailiang wrote: > We can know if we should go into COLO mode by the info that > has been migrated from PVM. > > Signed-off-by: zhanghailiang > Signed-off-by: Yang Hongyang > Signed-off-by: Lai Jiangshan > Signed-off-by: Gonglei > --- > include/migration/migration-

Re: [Qemu-devel] [PATCH 08/13] QemuOpts: Propagate errors through opts_parse()

2015-02-16 Thread Eric Blake
On 02/16/2015 07:44 AM, Markus Armbruster wrote: > Since I'm touching qemu_opts_parse() anyway, write a function comment > for it. > > Signed-off-by: Markus Armbruster > --- > util/qemu-option.c | 29 - > 1 file changed, 20 insertions(+), 9 deletions(-) > Reviewed-b

Re: [Qemu-devel] [PATCH 1/5] target-tile: Firstly add to qemu with minimized features

2015-02-16 Thread Chen Gang S
On 2/16/15 23:24, Max Filippov wrote: > On Mon, Feb 16, 2015 at 5:44 PM, Chen Gang S wrote: >> I guess, for qemu, we need !DISASM_ONLY, and may need BFD_RELOC, and may >> need the latest decode_X1_fsm, and also may need !__KERNEL__ -- which >> means we will use the full binutils version disassembl

Re: [Qemu-devel] [PATCH 07/13] QemuOpts: Propagate errors through opts_do_parse()

2015-02-16 Thread Eric Blake
On 02/16/2015 07:44 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > util/qemu-option.c | 25 + > 1 file changed, 17 insertions(+), 8 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualizat

Re: [Qemu-devel] [PATCH 06/13] QemuOpts: Drop qemu_opt_set(), rename qemu_opt_set_err(), fix use

2015-02-16 Thread Eric Blake
On 02/16/2015 07:44 AM, Markus Armbruster wrote: > qemu_opt_set() is a wrapper around qemu_opt_set() that reports the > error with qerror_report_err(). > > Most of its users assume the function can't fail. Make them use > qemu_opt_set_err() with &error_abort, so that should the assumption > ever

Re: [Qemu-devel] [PATCH 1/6 v2] target-tilegx: Firstly add to qemu with minimized features

2015-02-16 Thread Chen Gang S
On 2/17/15 00:25, Richard Henderson wrote: > On 02/16/2015 05:49 AM, Chen Gang S wrote: >> +#define TILEGX_R_PC 55 /* LR register, pc pointer */ > > No, register 55 is the link register, not the PC. > I.e. it is only special in that it receives the > return address from the JAL instructions. >

Re: [Qemu-devel] [PATCH v7 07/10] qmp: add rocker device support

2015-02-16 Thread Scott Feldman
On Mon, Feb 16, 2015 at 5:16 PM, Paolo Bonzini wrote: > > > On 16/02/2015 22:47, sfel...@gmail.com wrote: >> From: Scott Feldman >> >> Add QMP/HMP support for rocker devices. This is mostly for debugging >> purposes >> to see inside the device's tables and port configurations. Some examples: >

Re: [Qemu-devel] [PATCHv3 1/2] m48t59: introduce new base_year qdev property

2015-02-16 Thread Mark Cave-Ayland
On 14/02/15 18:16, Hervé Poussineau wrote: > Hi, > > Le 14/02/2015 09:52, Mark Cave-Ayland a écrit : >> Currently the m48t59 device uses the hardware model in order to determine >> whether the year value is offset from the hardware value. As this will >> soon be required by the x59 model, create

[Qemu-devel] [PATCH] send-email: ask confirmation if given encoding name is very short

2015-02-16 Thread Junio C Hamano
Sometimes people respond "y" (or "yes") when asked this question: Which 8bit encoding should I declare [UTF-8]? We already have a mechanism to avoid accepting a mistyped e-mail address (we ask to confirm when the given address lacks "@" in it); reuse it to trigger the same confirmation when g

Re: [Qemu-devel] [PATCH 4/4] block: Remove unused functions

2015-02-16 Thread Max Reitz
On 2015-02-16 at 16:41, Thomas Huth wrote: qemu_try_blockalign0() and nbd_export_close_all() are not used anymore and thus can be removed. Signed-off-by: Thomas Huth Cc: Kevin Wolf Cc: Stefan Hajnoczi Cc: Paolo Bonzini --- block.c | 11 --- include/block/block.h |

Re: [Qemu-devel] [PATCH 05/13] block: Suppress unhelpful extra errors in bdrv_img_create()

2015-02-16 Thread Eric Blake
On 02/16/2015 07:44 AM, Markus Armbruster wrote: > bdrv_img_create() uses qemu_opt_set(), which reports errors with > qerror_report_err(). Its error messages aren't helpful here, the > caller reports one that actually makes sense. I don't know how to > trigger the error conditions, though. > > S

Re: [Qemu-devel] [PATCH v7 07/10] qmp: add rocker device support

2015-02-16 Thread Paolo Bonzini
On 16/02/2015 22:47, sfel...@gmail.com wrote: > From: Scott Feldman > > Add QMP/HMP support for rocker devices. This is mostly for debugging purposes > to see inside the device's tables and port configurations. Some examples: > > (qemu) info rocker sw1 > name: sw1 > id: 0x013512005452 >

[Qemu-devel] [PATCH v7 10/10] rocker: timestamp on the debug logs helps correlate with events in the VM

2015-02-16 Thread sfeldma
From: David Ahern Signed-off-by: David Ahern Signed-off-by: Scott Feldman Signed-off-by: Jiri Pirko --- hw/net/rocker/rocker.h | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/hw/net/rocker/rocker.h b/hw/net/rocker/rocker.h index ef77487..5ae8aff 100644 --- a/

[Qemu-devel] [PATCH v7 08/10] rocker: add tests

2015-02-16 Thread sfeldma
From: Scott Feldman Add some basic test for rocker to test L2/L3/L4 functionality. Requires an external test environment, simp, located here: https://github.com/scottfeldman/simp To run tests, simp environment must be installed and a suitable VM image built and installed with a Linux 3.18 (or

Re: [Qemu-devel] [PATCH RFC v3 02/27] migration: Introduce capability 'colo' to migration

2015-02-16 Thread Eric Blake
On 02/11/2015 08:16 PM, zhanghailiang wrote: > This capability allows Primary VM (PVM) to be continuously checkpointed > to secondary VM. > > Signed-off-by: zhanghailiang > Signed-off-by: Yang Hongyang > Signed-off-by: Gonglei > Signed-off-by: Lai Jiangshan > --- > include/migration/migration

[Qemu-devel] [PATCH v7 01/10] net: add MAC address string printer

2015-02-16 Thread sfeldma
From: Scott Feldman We can use this in virtio-net code as well as new Rocker driver code, so up-level this. Signed-off-by: Scott Feldman Reviewed-by: Eric Blake --- include/net/net.h |1 + net/net.c |7 +++ 2 files changed, 8 insertions(+) diff --git a/include/net/net.h b

[Qemu-devel] [PATCH v7 07/10] qmp: add rocker device support

2015-02-16 Thread sfeldma
From: Scott Feldman Add QMP/HMP support for rocker devices. This is mostly for debugging purposes to see inside the device's tables and port configurations. Some examples: (qemu) info rocker sw1 name: sw1 id: 0x013512005452 ports: 4 (qemu) info rocker-ports sw1 ena/speed/

Re: [Qemu-devel] [PATCH v3] qga: add guest-set-user-password command

2015-02-16 Thread Michael Roth
Quoting Daniel P. Berrange (2015-02-12 08:05:56) > On Thu, Feb 12, 2015 at 04:21:09PM +0300, Roman Kagan wrote: > > On Wed, Feb 11, 2015 at 11:26:12AM +, Daniel P. Berrange wrote: > > > Add a new 'guest-set-user-password' command for changing the password > > > of guest OS user accounts. This c

[Qemu-devel] [PATCH v7 03/10] rocker: add register programming guide

2015-02-16 Thread sfeldma
From: Scott Feldman This is the register programming guide for the Rocker device. It's intended for driver writers and device writers. It covers the device's PCI space, the register set, DMA interface, and interrupts. Signed-off-by: Scott Feldman Signed-off-by: Jiri Pirko --- docs/specs/roc

[Qemu-devel] [PATCH v7 04/10] pci: add rocker device ID

2015-02-16 Thread sfeldma
From: Scott Feldman Signed-off-by: Scott Feldman Signed-off-by: Jiri Pirko --- docs/specs/pci-ids.txt |1 + include/hw/pci/pci.h |1 + 2 files changed, 2 insertions(+) diff --git a/docs/specs/pci-ids.txt b/docs/specs/pci-ids.txt index c6732fe..e4a4490 100644 --- a/docs/specs/pci-ids

[Qemu-devel] [PATCH v7 09/10] MAINTAINERS: add rocker

2015-02-16 Thread sfeldma
From: Scott Feldman Signed-off-by: Scott Feldman Signed-off-by: Jiri Pirko --- MAINTAINERS |6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8c06739..2ea3625 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -741,6 +741,12 @@ S: Maintained F: hw/net/vmxn

[Qemu-devel] [PATCH v3 16/17] standard-headers: add s390 virtio headers

2015-02-16 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- include/standard-headers/asm-s390/kvm_virtio.h | 64 ++ include/standard-headers/asm-s390/virtio-ccw.h | 21 + 2 files changed, 85 insertions(+) create mode 100644 include/standard-headers/asm-s390/kvm_virtio.h create mode 10

[Qemu-devel] [PATCH v7 05/10] pci: add network device class 'other' for network switches

2015-02-16 Thread sfeldma
From: Scott Feldman Rocker is an ethernet switch device, so add 'other' network device class as defined by PCI to cover these types of devices. Signed-off-by: Scott Feldman Signed-off-by: Jiri Pirko --- include/hw/pci/pci_ids.h |1 + 1 file changed, 1 insertion(+) diff --git a/include/hw

Re: [Qemu-devel] HEAD is failing virt-test on migration tests

2015-02-16 Thread Paolo Bonzini
On 16/02/2015 22:08, Alexander Graf wrote: > > Can you make it a capability? > When did live migration start to have capability negotiation? :) Only capability without negotiation. :) Negotiation is done above QEMU. Paolo

[Qemu-devel] [PATCH v7 02/10] virtio-net: use qemu_mac_strdup_printf

2015-02-16 Thread sfeldma
From: Scott Feldman Signed-off-by: Scott Feldman Reviewed-by: Eric Blake --- hw/net/virtio-net.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 45da34a..698156f 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/vir

[Qemu-devel] [PATCH v3 17/17] s390: use standard headers

2015-02-16 Thread Michael S. Tsirkin
Drop duplicated macros in favor of values from standard headers. Tested-by: Cornelia Huck Signed-off-by: Michael S. Tsirkin --- hw/s390x/s390-virtio-bus.h | 36 +++- hw/s390x/s390-virtio.h | 7 ++- 2 files changed, 21 insertions(+), 22 deletions(-) diff

[Qemu-devel] [PATCH v7 00/10] rocker: add new rocker ethernet switch device

2015-02-16 Thread sfeldma
From: Scott Feldman v7: - Per Stefan Hajnoczi comments: - #ifdef CONFIG_ROCKER wrapper around qmp/hmp to fix compile when PCI is disabled or rocker is disabled. v6: - Per Stefan Hajnoczi review: - Move tests to tests/rocker - Fix some mem leaks - Fix doc grammer/sp

[Qemu-devel] [PATCH 0/4] Remove unused functions

2015-02-16 Thread Thomas Huth
There are quite a lot of completely unused functions scattered around in the QEMU sources - here are some patches to remove at least some of them. Thomas Huth (4): migration: Remove unused functions ui/console: Removed unused functions util: Remove unused functions block: Remove unused fun

[Qemu-devel] [PATCH 4/4] block: Remove unused functions

2015-02-16 Thread Thomas Huth
qemu_try_blockalign0() and nbd_export_close_all() are not used anymore and thus can be removed. Signed-off-by: Thomas Huth Cc: Kevin Wolf Cc: Stefan Hajnoczi Cc: Paolo Bonzini --- block.c | 11 --- include/block/block.h |1 - include/block/nbd.h |1 - nbd.c

[Qemu-devel] [PATCH v3 14/17] virtio-pci: use standard headers

2015-02-16 Thread Michael S. Tsirkin
Drop duplicate code. Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.c | 54 +- 1 file changed, 5 insertions(+), 49 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index dde1d73..4b17ecb 100644 --- a/hw/virtio/

[Qemu-devel] [PATCH v3 10/17] virtio-scsi: use standard-headers

2015-02-16 Thread Michael S. Tsirkin
Drop duplicated code. Signed-off-by: Michael S. Tsirkin --- include/hw/virtio/virtio-scsi.h | 120 +++- hw/scsi/virtio-scsi.c | 1 + 2 files changed, 10 insertions(+), 111 deletions(-) diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virt

[Qemu-devel] [PATCH v3 15/17] scripts: add arch specific standard-headers

2015-02-16 Thread Michael S. Tsirkin
Copy arch specific virtio headers. ATM this applies to s390 only. Signed-off-by: Michael S. Tsirkin --- scripts/update-linux-headers.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh index 5ab3914..9680e27 100755 --- a/scri

[Qemu-devel] [PATCH 2/4] ui/console: Removed unused functions

2015-02-16 Thread Thomas Huth
Remove dpy_gfx_update_dirty(), qemu_console_get_head(), qemu_console_get_ui_info(), qemu_console_get_width(), qemu_console_get_height(), emu_console_displaystate(), qemu_different_endianness_pixelformat(), void cpkey(), qemu_pixman_linebuf_copy(), qemu_pixman_color(), emu_remove_kbd_event_handler()

[Qemu-devel] [PATCH v3 13/17] linux-headers: use standard-headers

2015-02-16 Thread Michael S. Tsirkin
Drop duplicated code. Signed-off-by: Michael S. Tsirkin --- linux-headers/linux/virtio_config.h | 58 + linux-headers/linux/virtio_ring.h | 164 +--- 2 files changed, 2 insertions(+), 220 deletions(-) diff --git a/linux-headers/linux/virtio_config.

  1   2   3   4   5   >