Re: [Qemu-devel] [PATCH v4 0/1] block: enforce minimal 4096 alignment in qemu_blockalign

2015-02-12 Thread Denis V. Lunev
On 06/02/15 20:37, Denis V. Lunev wrote: The following sequence int fd = open(argv[1], O_RDWR | O_CREAT | O_DIRECT, 0644); for (i = 0; i < 10; i++) write(fd, buf, 4096); iperforms 5% better if buf is aligned to 4096 bytes rather then to 512 bytes. I have used the follo

Re: [Qemu-devel] [PATCH 0/3] qemu guest agent: support guest-file-* command for Windows

2015-02-12 Thread Denis V. Lunev
On 06/02/15 20:59, Denis V. Lunev wrote: This was a part of patchset implemented guest-exec command. It was suggested to submit it separately by Michael. The set contains small refactoring to fix mingw 4.9.1 compilation and safe part of the rework of posix file interface plus main Windows file c

Re: [Qemu-devel] [PATCH v6 0/5] Geometry and blocksize detection for backing devices.

2015-02-12 Thread Kevin Wolf
Am 12.02.2015 um 17:42 hat Christian Borntraeger geschrieben: > Am 12.02.2015 um 16:46 schrieb Stefan Hajnoczi: > > On Mon, Jan 19, 2015 at 03:34:56PM +0100, Ekaterina Tumanova wrote: > >> Updates v5 -> v6: > >> > >> Minor Updates according the last review from Stefan Hajnoczi: > >> 1. Do not chang

Re: [Qemu-devel] [PATCH] cocoa.m: Adds console items to the view menu

2015-02-12 Thread Gerd Hoffmann
Hi, > We're going to need to automatically create and update > the menu entries based on which consoles get created > if we want this to work properly, I think. Gerd, any > suggestions? Is there a hook for "list of active > consoles has changed"? No. consoles are not hotpluggable. > What's t

Re: [Qemu-devel] Help on TLB Flush

2015-02-12 Thread Mark Burton
> On 13 Feb 2015, at 08:24, Peter Maydell wrote: > > On 13 February 2015 at 07:16, Mark Burton wrote: >> If the kernel is doing this - then effectively - for X86, each CPU only >> flush’s it’s own TLB (from the perspective of Qemu) - correct? >> (in which case, for Qemu itself - for x86) - we d

Re: [Qemu-devel] Help on TLB Flush

2015-02-12 Thread Peter Maydell
On 13 February 2015 at 07:16, Mark Burton wrote: > If the kernel is doing this - then effectively - for X86, each CPU only > flush’s it’s own TLB (from the perspective of Qemu) - correct? > (in which case, for Qemu itself - for x86) - we dont need to implement > a global flush, and hence we dont n

Re: [Qemu-devel] Help on TLB Flush

2015-02-12 Thread Mark Burton
Up top - thanks Peter, I think you may give us an idea ! > On 12 Feb 2015, at 23:10, Lluís Vilanova wrote: > > Mark Burton writes: > >>> On 12 Feb 2015, at 16:38, Alexander Graf wrote: >>> >>> >>> >>> On 12.02.15 15:58, Peter Maydell wrote: On 12 February 2015 at 14:45, Alexander Graf

Re: [Qemu-devel] [RFC PATCH 01/14] docs: block replication's description

2015-02-12 Thread Fam Zheng
On Fri, 02/13 13:09, Wen Congyang wrote: > What is image fleecing? > It's the name of the feature which enables the built-in NBD server to exporting a thin point-in-time snapshot created via drive-backup sync=none. It's for host side data scanning tool to access a disk snapshot of running VM. Th

Re: [Qemu-devel] [PATCH] tile: Can load elf64 tilegx binary successfully for linux-user.

2015-02-12 Thread Chen Gang S
On 2/13/15 13:43, Peter Maydell wrote: > On 13 February 2015 at 05:44, Chen Gang S wrote: >> Which issue of correctness will occur? I can not enum it. > > If the Linux kernel does not implement these syscalls then > QEMU must not either. Attempting them should fail, same as > if you attempted the

Re: [Qemu-devel] [PATCH 0/3] hmp: Normalize HMP command handler names

2015-02-12 Thread Jason Wang
On Thu, Feb 12, 2015 at 6:52 PM, Markus Armbruster wrote: When I can't guess a handler's name, I have to look it up in hmp-commands.hx. Happens often enough to annoy me. Let's make them more predictable. Touches several subsystems because HMP command handlers are still spread far and wide,

Re: [Qemu-devel] [PATCH] bitops.h: sextract64() return type should be int64_t, not uint64_t

2015-02-12 Thread Richard Henderson
On 02/06/2015 06:02 AM, Peter Maydell wrote: > The documentation for sextract64() claims that the return type is > an int64_t, but the code itself disagrees. Fix the return type to > conform to the documentation and to bring it into line with > sextract32(), which returns int32_t. > > Signed-off-b

[Qemu-devel] QOM q1

2015-02-12 Thread boddu pavan
Hi, I have some question on using QOM, new to QEMU and will be great if i can put some answers for below question. 1) If QEMU is considered to be OOP, How is the relation between a Class and Object. I see in c++ we do not create a classobject there will be a object of a class. But here i see bot

[Qemu-devel] [PULL 07/12] target-arm: Add 32/64-bit register sync

2015-02-12 Thread Peter Maydell
From: Greg Bellows Add AArch32 to AArch64 register sychronization functions. Replace manual register synchronization with new functions in aarch64_cpu_do_interrupt() and HELPER(exception_return)(). Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell Message-id: 1423736974-14254-4-git-send-e

[Qemu-devel] [PULL 02/12] pci: Add generic PCIe host bridge

2015-02-12 Thread Peter Maydell
From: Alexander Graf With simple exposure of MMFG, ioport window, mmio window and an IRQ line we can successfully create a workable PCIe host bridge that can be mapped anywhere and only needs to get described to the OS using whatever means it likes. This patch implements such a "generic" host br

[Qemu-devel] [PULL 06/12] target-arm: Add feature parsing to virt

2015-02-12 Thread Peter Maydell
From: Greg Bellows Added machvirt parsing of feature keywords added to the -cpu command line option. Parsing occurs during machine initialization. Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell Message-id: 1423736974-14254-3-git-send-email-greg.bell...@linaro.org Signed-off-by: Peter

[Qemu-devel] [PULL 12/12] target-arm: A64: Avoid signed shifts in disas_ldst_pair()

2015-02-12 Thread Peter Maydell
Avoid shifting potentially negative signed offset values in disas_ldst_pair() by keeping the offset in a uint64_t rather than an int64_t. Signed-off-by: Peter Maydell Message-id: 1423233250-15853-5-git-send-email-peter.mayd...@linaro.org --- target-arm/translate-a64.c | 2 +- 1 file changed, 1 i

[Qemu-devel] [PULL 01/12] pci: Allocate PCIe host bridge PCI ID

2015-02-12 Thread Peter Maydell
From: Alexander Graf We are going to introduce a PCIe host controller that doesn't exist that way in real hardware, but still needs to expose some PCIe root device which has PCI IDs. Allocate a PCI ID in the Red Hat space that we use for other devices of this kind. Signed-off-by: Alexander Graf

[Qemu-devel] [PULL 03/12] arm: Add PCIe host bridge in virt machine

2015-02-12 Thread Peter Maydell
From: Alexander Graf Now that we have a working "generic" PCIe host bridge driver, we can plug it into ARM's virt machine to always have PCIe available to normal ARM VMs. I've successfully managed to expose a Bochs VGA device, XHCI and an e1000 into an AArch64 VM with this and they all lived hap

[Qemu-devel] [PULL 08/12] target-arm: Add AArch32 guest support to KVM64

2015-02-12 Thread Peter Maydell
From: Greg Bellows Add 32-bit to/from 64-bit register synchronization on register gets and puts. Set EL1_32BIT feature flag passed to KVM Signed-off-by: Greg Bellows Message-id: 1423736974-14254-5-git-send-email-greg.bell...@linaro.org Signed-off-by: Peter Maydell --- target-arm/kvm64.c | 36

[Qemu-devel] [PULL 04/12] pci: Move PCI VGA to pci.mak

2015-02-12 Thread Peter Maydell
From: Alexander Graf Every platform that supports PCI can also spawn the Bochs VGA PCI adapter. Move it to pci.mak to enable it for everyone. Signed-off-by: Alexander Graf Signed-off-by: Peter Maydell --- default-configs/alpha-softmmu.mak| 2 -- default-configs/i386-softmmu.mak | 2 --

[Qemu-devel] [PULL 05/12] target-arm: Add CPU property to disable AArch64

2015-02-12 Thread Peter Maydell
From: Greg Bellows Adds registration and get/set functions for enabling/disabling the AArch64 execution state on AArch64 CPUs. By default AArch64 execution state is enabled on AArch64 CPUs, setting the property to off, will disable the execution state. The below QEMU invocation would have AArch6

[Qemu-devel] [PULL 11/12] target-arm: A64: Avoid left shifting negative integers in disas_pc_rel_addr

2015-02-12 Thread Peter Maydell
Shifting a negative integer left is undefined behaviour in C. Avoid it by assembling and shifting the offset fields as unsigned values and then sign extending as the final action. Signed-off-by: Peter Maydell Message-id: 1423233250-15853-4-git-send-email-peter.mayd...@linaro.org --- target-arm/t

[Qemu-devel] [PULL 10/12] target-arm: A64: Fix handling of rotate in logic_imm_decode_wmask

2015-02-12 Thread Peter Maydell
The code in logic_imm_decode_wmask attempts to rotate a mask value within the bottom 'e' bits of the value with mask = (mask >> r) | (mask << (e - r)); This has two issues: * if the element size is 64 then a rotate by zero results in a shift left by 64, which is undefined behaviour * if th

[Qemu-devel] [PULL 09/12] target-arm: A64: Fix shifts into sign bit

2015-02-12 Thread Peter Maydell
Fix attempts to shift into the sign bit of an int, which is undefined behaviour in C and warned about by the clang sanitizer. Signed-off-by: Peter Maydell Message-id: 1423233250-15853-2-git-send-email-peter.mayd...@linaro.org --- target-arm/translate-a64.c | 6 +++--- 1 file changed, 3 insertion

[Qemu-devel] [PULL 00/12] target-arm queue

2015-02-12 Thread Peter Maydell
The following changes since commit 449008f86418583a1f0fb946cf91ee7b4797317d: Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20150210.0' into staging (2015-02-11 05:14:41 +) are available in the git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/

[Qemu-devel] [PULL 8/8] tcg: Remove unused opcodes

2015-02-12 Thread Richard Henderson
We no longer need INDEX_op_end to terminate the list, nor do we need 5 forms of nop, since we just remove the TCGOp instead. Reviewed-by: Bastian Koppelmann Signed-off-by: Richard Henderson --- tcg/tcg-opc.h | 9 - tcg/tcg.c | 7 ++- tci.c | 13 - 3 files c

[Qemu-devel] [PULL 0/8] Linked list for tcg ops

2015-02-12 Thread Richard Henderson
iam/tags/vfio-update-20150210.0' into staging (2015-02-11 05:14:41 +) are available in the git repository at: git://github.com/rth7680/qemu.git tags/pull-tcg-20150212 for you to fetch changes up to 15fc7daa770764cc795158cbb525569f156f3659: tcg: Remove unused opcodes (

[Qemu-devel] [PULL 2/8] tcg: Reduce ifdefs in tcg-op.c

2015-02-12 Thread Richard Henderson
Almost completely eliminates the ifdefs in this file, improving confidence in the lesser used 32-bit builds. Reviewed-by: Bastian Koppelmann Signed-off-by: Richard Henderson --- tcg/tcg-op.c | 449 +++ 1 file changed, 207 insertions(+), 24

[Qemu-devel] [PULL 7/8] tcg: Implement insert_op_before

2015-02-12 Thread Richard Henderson
Rather reserving space in the op stream for optimization, let the optimizer add ops as necessary. Reviewed-by: Bastian Koppelmann Signed-off-by: Richard Henderson --- tcg/optimize.c | 57 +++-- tcg/tcg-op.c | 21 - tcg/tc

[Qemu-devel] [PULL 6/8] tcg: Remove opcodes instead of noping them out

2015-02-12 Thread Richard Henderson
With the linked list scheme we need not leave nops in the stream that we need to process later. Reviewed-by: Bastian Koppelmann Signed-off-by: Richard Henderson --- tcg/optimize.c | 14 +++--- tcg/tcg.c | 28 tcg/tcg.h | 1 + 3 files changed, 32 i

[Qemu-devel] [PULL 3/8] tcg: Move emit of INDEX_op_end into gen_tb_end

2015-02-12 Thread Richard Henderson
Reviewed-by: Bastian Koppelmann Signed-off-by: Richard Henderson --- include/exec/gen-icount.h | 2 ++ target-alpha/translate.c | 2 +- target-arm/translate-a64.c| 1 - target-arm/translate.c| 1 - target-cris/translate.c | 2 +- target-i386/translate.c | 2 +- t

[Qemu-devel] [PULL 5/8] tcg: Put opcodes in a linked list

2015-02-12 Thread Richard Henderson
The previous setup required ops and args to be completely sequential, and was error prone when it came to both iteration and optimization. Reviewed-by: Bastian Koppelmann Signed-off-by: Richard Henderson --- include/exec/gen-icount.h | 22 ++- tcg/optimize.c| 286 ++

[Qemu-devel] [PULL 4/8] tcg: Introduce tcg_op_buf_count and tcg_op_buf_full

2015-02-12 Thread Richard Henderson
The method by which we count the number of ops emitted is going to change. Abstract that away into some inlines. Reviewed-by: Bastian Koppelmann Signed-off-by: Richard Henderson --- target-alpha/translate.c | 14 +++--- target-arm/translate-a64.c| 9 +++-- target-arm/tran

[Qemu-devel] QOM q1

2015-02-12 Thread boddu pavan
Hi, I have some question on using QOM, new to QEMU and will be great if i can put some answers for below question. 1) If QEMU is considered to be OOP, How is the relation between a Class and Object. I see in c++ we do not create a classobject there will be a object of a class. But here i see bot

Re: [Qemu-devel] [PATCH] tile: Can load elf64 tilegx binary successfully for linux-user.

2015-02-12 Thread Peter Maydell
On 13 February 2015 at 05:44, Chen Gang S wrote: > Which issue of correctness will occur? I can not enum it. If the Linux kernel does not implement these syscalls then QEMU must not either. Attempting them should fail, same as if you attempted them with the real kernel. > - linux-user already b

Re: [Qemu-devel] [PATCH] tile: Can load elf64 tilegx binary successfully for linux-user.

2015-02-12 Thread Chen Gang S
On 2/13/15 12:56, Peter Maydell wrote: > On 13 February 2015 at 04:43, Chen Gang S wrote: >> Originally, I have tried to remove TARGET_NR_open and others, they can >> not pass building, and I also noticed about NR_openat. But at last, I >> still remain TARGET_NR_open and others (with related comme

Re: [Qemu-devel] [RFC PATCH 01/14] docs: block replication's description

2015-02-12 Thread Wen Congyang
On 02/12/2015 06:26 PM, f...@redhat.com wrote: > On Thu, 02/12 18:11, Wen Congyang wrote: >> On 02/12/2015 05:44 PM, Fam Zheng wrote: >>> On Thu, 02/12 17:33, Wen Congyang wrote: On 02/12/2015 04:44 PM, Fam Zheng wrote: > On Thu, 02/12 15:40, Wen Congyang wrote: >> On 02/12/2015 03:21

Re: [Qemu-devel] [PATCH] tile: Can load elf64 tilegx binary successfully for linux-user.

2015-02-12 Thread Peter Maydell
On 13 February 2015 at 04:43, Chen Gang S wrote: > Originally, I have tried to remove TARGET_NR_open and others, they can > not pass building, and I also noticed about NR_openat. But at last, I > still remain TARGET_NR_open and others (with related comments): > > - Another platforms (e.g. microbl

Re: [Qemu-devel] [PATCH] tile: Can load elf64 tilegx binary successfully for linux-user.

2015-02-12 Thread Chen Gang S
On 2/13/15 06:31, Chris Metcalf wrote: > On 2/11/2015 10:32 PM, Chen Gang S wrote: >> And excuse me, my English is not quite well, I don't quite understand: >> >>"fixing anything that breaks as a result". >> >> Could you provide more details? Thanks. > > So if you undefine TARGET_NR_open, etc,

Re: [Qemu-devel] [PATCH v4] sheepdog: selectable object size support

2015-02-12 Thread Teruaki Ishizaki
(2015/02/13 11:01), Liu Yuan wrote: On Fri, Feb 13, 2015 at 10:33:04AM +0900, Teruaki Ishizaki wrote: (2015/02/12 11:55), Liu Yuan wrote: On Thu, Feb 12, 2015 at 11:33:16AM +0900, Teruaki Ishizaki wrote: (2015/02/12 11:19), Liu Yuan wrote: On Thu, Feb 12, 2015 at 10:51:25AM +0900, Teruaki Ish

[Qemu-devel] [RFC 2/3] hw/vfio/common: vfio_kvm_device_fd moved in the common header

2015-02-12 Thread Eric Auger
the device is now used in platform for forwarded IRQ setup Signed-off-by: Eric Auger --- hw/vfio/common.c | 3 ++- include/hw/vfio/vfio-common.h | 5 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index c5d1551..be72ad6 100644

[Qemu-devel] [RFC 1/3] linux-headers: Update KVM header for KVM-VFIO FORWARD/UNFORWARD

2015-02-12 Thread Eric Auger
Integrate updated KVM-VFIO API related to forwarded IRQ Update according to header found in http://git.linaro.org/people/eric.auger/linux.git branch irqfd_integ_v9 Signed-off-by: Eric Auger --- v8 -> v9: use new kvm_vfio_dev_irq struct --- linux-headers/linux/kvm.h | 23 --

[Qemu-devel] [RFC 3/3] hw/vfio/platform: add forwarded irq support

2015-02-12 Thread Eric Auger
Tests whether the forwarded IRQ modality is available. In the positive device IRQs are forwarded. This control is achieved with KVM-VFIO device. with such a modality injection still is handled through irqfds. However end of interrupt is not trapped anymore. As soon as the guest completes its virtua

[Qemu-devel] [RFC 0/3] VFIO Platform device featuring IRQ forwarding

2015-02-12 Thread Eric Auger
This series adds IRQ forwarding support in the VFIO platform device. The VFIO platform device uses the KVM-VFIO device to enable IRQ forwarding. Dependency List: - KVM platform device passthrough PATCH v10 and all its dependencies + following kernel dependencies: - [RFC PATCH 0/9] ARM: Forwardi

Re: [Qemu-devel] [PATCH] sheepdog: Fix misleading error messages in sd_snapshot_create()

2015-02-12 Thread Liu Yuan
On Thu, Feb 12, 2015 at 02:49:50PM +0100, Markus Armbruster wrote: > If do_sd_create() fails, it first reports the error returned, then > reports a another one with strerror(errno). errno is meaningless at > that point. > > Report just one error combining the valid information from both > message

Re: [Qemu-devel] [PATCH v3 1/2] linux-headers: update KVM headers from KVM_DEV_ARM_VGIC_GRP_CTRL

2015-02-12 Thread Eric Auger
On 02/13/2015 04:42 AM, Peter Maydell wrote: > On 13 February 2015 at 03:37, Eric Auger wrote: >> Add a new group/attribute in VGIC KVM device enabling to force >> vgic init: KVM_DEV_ARM_VGIC_GRP_CTRL/KVM_DEV_ARM_VGIC_CTRL_INIT >> >> Update according to 3.19 headers. > > Is this really a full hea

Re: [Qemu-devel] [PATCH] tile: Can load elf64 tilegx binary successfully for linux-user.

2015-02-12 Thread Chen Gang S
On 2/13/15 06:32, Chris Metcalf wrote: > On 2/11/2015 10:48 PM, Chen Gang S wrote: >> On 2/12/15 11:32, Chen Gang S wrote: >>> >>> >> +#define EM_TILE 191 /* Tile */ >>> >>> >>+#define EM_TILE_OLD 0x2597 /* Tile compat */ > >> > > >> >No need for EM_TILE_OLD - it never reall

Re: [Qemu-devel] [PATCH] sheepdog: fix confused return values

2015-02-12 Thread Liu Yuan
On Fri, Feb 13, 2015 at 11:45:42AM +0800, Liu Yuan wrote: > From: Liu Yuan > > These functions mix up -1 and -errno in return values and would might cause > trouble error handling in the call chain. > > This patch let them return -errno and add some comments. > > Reported-by: Markus Armbruster

[Qemu-devel] [PATCH v10 6/7] hw/arm/sysbus-fdt: enable vfio-calxeda-xgmac dynamic instantiation

2015-02-12 Thread Eric Auger
vfio-calxeda-xgmac now can be instantiated using the -device option. The node creation function generates a very basic dt node composed of the compat, reg and interrupts properties Signed-off-by: Eric Auger --- v8 -> v9: - properly free resources in case of errors in add_calxeda_midway_xgmac_f

[Qemu-devel] [PATCH v10 7/7] hw/vfio/platform: add irqfd support

2015-02-12 Thread Eric Auger
This patch aims at optimizing IRQ handling using irqfd framework. Instead of handling the eventfds on user-side they are handled on kernel side using - the KVM irqfd framework, - the VFIO driver virqfd framework. the virtual IRQ completion is trapped at interrupt controller This removes the need

[Qemu-devel] [PATCH v10 4/7] hw/vfio/platform: add capability to start IRQ propagation

2015-02-12 Thread Eric Auger
Add a reset notify function that enables to start the propagation of interrupts to the guest. Signed-off-by: Eric Auger --- v8 -> v9: - handle failure in vfio_irq_starter --- hw/vfio/platform.c | 52 + include/hw/vfio/vfio-platform.h | 8 ++

[Qemu-devel] [PATCH v10 5/7] hw/vfio: calxeda xgmac device

2015-02-12 Thread Eric Auger
The platform device class has become abstract. This patch introduces a calxeda xgmac device that can be be instantiated on command line using such option. -device vfio-calxeda-xgmac,host="fff51000.ethernet" Signed-off-by: Eric Auger --- v8 -> v9: - renamed calxeda_xgmac.c into calxeda-xgmac.c

[Qemu-devel] [PATCH v10 3/7] hw/vfio/platform: add irq assignment

2015-02-12 Thread Eric Auger
This patch adds the code requested to assign interrupts to a guest. The interrupts are mediated through user handled eventfds only. The mechanics to start the IRQ handling is not yet there through. Signed-off-by: Eric Auger --- v8 -> v9: - free irq related resources in case of error in vfio_po

[Qemu-devel] [PATCH v10 2/7] hw/vfio/platform: vfio-platform skeleton

2015-02-12 Thread Eric Auger
Minimal VFIO platform implementation supporting register space user mapping but not IRQ assignment. Signed-off-by: Kim Phillips Signed-off-by: Eric Auger --- v9 -> v10: - vfio_populate_device no more called in common vfio_get_device but in vfio_base_device_init v8 -> v9: - irq management is

[Qemu-devel] [PATCH v10 1/7] linux-headers: update VFIO header for VFIO platform drivers

2015-02-12 Thread Eric Auger
Update according to vfio.h header found in http://git.linaro.org/people/eric.auger/linux.git branch irqfd_integ_v9 Signed-off-by: Eric Auger --- v9 -> v10: - AMBA removed v8 -> v9: - rewording of the commit message --- linux-headers/linux/vfio.h | 31 ++- 1 file ch

[Qemu-devel] [PATCH v10 0/7] KVM platform device passthrough

2015-02-12 Thread Eric Auger
This series aims at enabling KVM platform device passthrough. It implements a VFIO platform device, derived from VFIO PCI device. The VFIO platform device uses the host VFIO platform driver which must be bound to the assigned device prior to the QEMU system start. - the guest can directly access

[Qemu-devel] [PATCH] sheepdog: fix confused return values

2015-02-12 Thread Liu Yuan
From: Liu Yuan These functions mix up -1 and -errno in return values and would might cause trouble error handling in the call chain. This patch let them return -errno and add some comments. Reported-by: Markus Armbruster Signed-off-by: Liu Yuan --- block/sheepdog.c | 11 +++ 1 file c

Re: [Qemu-devel] [PATCH v3 1/2] linux-headers: update KVM headers from KVM_DEV_ARM_VGIC_GRP_CTRL

2015-02-12 Thread Peter Maydell
On 13 February 2015 at 03:37, Eric Auger wrote: > Add a new group/attribute in VGIC KVM device enabling to force > vgic init: KVM_DEV_ARM_VGIC_GRP_CTRL/KVM_DEV_ARM_VGIC_CTRL_INIT > > Update according to 3.19 headers. Is this really a full header sync? I'd have expected it to have non-ARM changes

[Qemu-devel] [PATCH v3 0/2] explicit VGIC initialization in finalize function

2015-02-12 Thread Eric Auger
With current implementation the vgic is initialized implicitly, on-demand. This patch forces the init in the vgic finalize function. At that point all the dimensioning parameters are known. A new group/attribute in VGIC KVM device is used for that: KVM_DEV_ARM_VGIC_GRP_CTRL/KVM_DEV_ARM_VGIC_CTRL_I

[Qemu-devel] [PATCH v3 2/2] hw/intc/arm_gic: Initialize the vgic in the realize function

2015-02-12 Thread Eric Auger
This patch forces vgic initialization in the vgic realize function. It uses a new group/attribute that allows such operation. This earlier initialization allows, for example, to setup VFIO signaling and irqfd after vgic initialization, on a reset notifier. Signed-off-by: Eric Auger --- hw/intc/

[Qemu-devel] [PATCH v3 1/2] linux-headers: update KVM headers from KVM_DEV_ARM_VGIC_GRP_CTRL

2015-02-12 Thread Eric Auger
Add a new group/attribute in VGIC KVM device enabling to force vgic init: KVM_DEV_ARM_VGIC_GRP_CTRL/KVM_DEV_ARM_VGIC_CTRL_INIT Update according to 3.19 headers. Signed-off-by: Eric Auger --- linux-headers/asm-arm/kvm.h | 5 + linux-headers/asm-arm64/kvm.h | 5 + 2 files changed, 10 in

Re: [Qemu-devel] [PATCH] memory: Fix double unref of flatview

2015-02-12 Thread Matthew Rosato
On 02/12/2015 03:43 PM, Paolo Bonzini wrote: > > > On 12/02/2015 20:32, Matthew Rosato wrote: >> Could it be that the order in which flatview_unref (and therefore >> memory_region_unref) vs object_unparent(mr) matters (ie, object_unparent >> should always happen last)? Prior to RCUification, see

Re: [Qemu-devel] [PATCH 1/4] target-arm: A64: Fix shifts into sign bit

2015-02-12 Thread Greg Bellows
On Fri, Feb 6, 2015 at 8:34 AM, Peter Maydell wrote: > Fix attempts to shift into the sign bit of an int, which is undefined > behaviour in C and warned about by the clang sanitizer. > > Signed-off-by: Peter Maydell > --- > target-arm/translate-a64.c | 6 +++--- > 1 file changed, 3 insertions(+

Re: [Qemu-devel] [PATCH v7 0/5] block: Add a qemu-iotests case for IO throttling

2015-02-12 Thread Fam Zheng
On Thu, 02/12 16:50, Stefan Hajnoczi wrote: > On Fri, Jan 30, 2015 at 10:49:41AM +0800, Fam Zheng wrote: > > v7: Remove any "{iops,bps}_max" in 093 completely. (Max) > > > > v6: Less resource demanding patch 5. (Max) > > Add rev-by of Max to other patches. > > > > v5: Rebase and improve the t

Re: [Qemu-devel] [PATCH v3 4/4] bootdevice: update boot_order in MachineState

2015-02-12 Thread Gonglei
On 2015/2/12 18:21, Markus Armbruster wrote: > writes: > >> From: Dinar Valeev >> >> on sPAPR we need to update boot_order in MachineState in case it >> got changed on reset. >> >> Signed-off-by: Dinar Valeev >> Reviewed-by: Alexey Kardashevskiy >> Signed-off-by: Gonglei >> --- >> bootdevice

Re: [Qemu-devel] [PATCH 0/6] migration: differentiate between pages and bytes

2015-02-12 Thread Li, Liang Z
> (Li special edition) > > Current migration code returns number of bytes transferred and from there > we decide if we.have sent something or not. Problem, we need two results: > number of pages written, and number of bytes written (depending on > compression, zero pages, etc, it is not possible

Re: [Qemu-devel] [PATCH v3 2/4] bootdevice: check boot order argument validation before vm running

2015-02-12 Thread Gonglei
On 2015/2/12 18:19, Markus Armbruster wrote: > writes: > >> From: Gonglei >> >> Either 'once' option or 'order' option can take effect for -boot at >> the same time, that is say initial startup processing can check only >> one. And pc.c's set_boot_dev() fails when its boot order argument >> is i

Re: [Qemu-devel] [PATCH v3 1/4] bootdevice: remove the check about boot_set_handler

2015-02-12 Thread Gonglei
On 2015/2/12 18:19, Markus Armbruster wrote: > writes: > >> From: Gonglei >> >> The reset logic can be done by both machine reset and >> boot handler. So we shouldn't return error when the boot >> handler callback don't be set. >> >> Signed-off-by: Gonglei >> Reviewed-by: Alexander Graf >> ---

[Qemu-devel] Fwd: [PATCH 2/5] linux-user: tile: Firstly add architecture related features

2015-02-12 Thread Chen Gang S
Excuse me, I have to foward this mail, for the original mail failed to send to qemu-devel mailing list (so try again). Thanks. Forwarded Message Subject: [PATCH 2/5] linux-user: tile: Firstly add architecture related features Date: Fri, 13 Feb 2015 05:16:52 +0800 From: Chen Gan

Re: [Qemu-devel] [PATCH v4] sheepdog: selectable object size support

2015-02-12 Thread Liu Yuan
On Fri, Feb 13, 2015 at 10:33:04AM +0900, Teruaki Ishizaki wrote: > (2015/02/12 11:55), Liu Yuan wrote: > >On Thu, Feb 12, 2015 at 11:33:16AM +0900, Teruaki Ishizaki wrote: > >>(2015/02/12 11:19), Liu Yuan wrote: > >>>On Thu, Feb 12, 2015 at 10:51:25AM +0900, Teruaki Ishizaki wrote: > (2015/02/

Re: [Qemu-devel] [PATCH v4] sheepdog: selectable object size support

2015-02-12 Thread Teruaki Ishizaki
(2015/02/12 11:55), Liu Yuan wrote: On Thu, Feb 12, 2015 at 11:33:16AM +0900, Teruaki Ishizaki wrote: (2015/02/12 11:19), Liu Yuan wrote: On Thu, Feb 12, 2015 at 10:51:25AM +0900, Teruaki Ishizaki wrote: (2015/02/10 20:12), Liu Yuan wrote: On Tue, Jan 27, 2015 at 05:35:27PM +0900, Teruaki Ish

Re: [Qemu-devel] [PATCH 3/3] virtio-scsi-dataplane: Use main thread BH to set BDS' aio context

2015-02-12 Thread Fam Zheng
On Thu, 02/12 15:29, Paolo Bonzini wrote: > > > On 12/02/2015 06:21, Fam Zheng wrote: > > Before processing a request, virtio-scsi dataplane will check if the > > backend runs on the same context with it. If not, it has to be moved, > > with bdrv_set_aio_context. > > > > However this function is

Re: [Qemu-devel] [Xen-devel] [v2][PATCH] libxl: add one machine property to support IGD GFX passthrough

2015-02-12 Thread Chen, Tiejun
Ian, Just ping this, or do you think I should send this as a patch? Thanks Tiejun On 2015/2/11 10:45, Chen, Tiejun wrote: On 2015/2/9 19:05, Ian Campbell wrote: On Mon, 2015-02-09 at 14:28 +0800, Chen, Tiejun wrote: What about this? I've not read the code in detail,since I'm travelling bu

Re: [Qemu-devel] [PATCH] hw/arm/virt: "bus-range"/end is off by one

2015-02-12 Thread Peter Maydell
On 13 February 2015 at 01:12, Alexander Graf wrote: > > > On 12.02.15 19:50, Laszlo Ersek wrote: >> According to "PCI Bus Binding to IEEE Std 1275-1994", 3.1.2. Bus-specific >> Properties for Bus Nodes, the second integer in "bus-range" is an >> inclusive limit. >> >> This seems to be consistent w

Re: [Qemu-devel] [PATCH] hw/arm/virt: "bus-range"/end is off by one

2015-02-12 Thread Alexander Graf
On 12.02.15 19:50, Laszlo Ersek wrote: > According to "PCI Bus Binding to IEEE Std 1275-1994", 3.1.2. Bus-specific > Properties for Bus Nodes, the second integer in "bus-range" is an > inclusive limit. > > This seems to be consistent with several *.dtsi files in the kernel tree, > where examples

Re: [Qemu-devel] HEAD is failing virt-test on migration tests

2015-02-12 Thread Alexander Graf
On 13.02.15 01:29, Lucas Meneghel Rodrigues wrote: > Copying Alex. > > OK, after bisecting, this is what I've got: > > 8118f0950fc77cce7873002a5021172dd6e040b5 is the first bad commit > commit 8118f0950fc77cce7873002a5021172dd6e040b5 > Author: Alexander Graf mailto:ag...@suse.de>> > Date: Thu

Re: [Qemu-devel] HEAD is failing virt-test on migration tests

2015-02-12 Thread Lucas Meneghel Rodrigues
from guest 9 times >>> 22:58:13 INFO | [qemu output] (Process terminated with status 0) >>> 22:58:13 DEBUG| VM virt-tests-vm1 down (shell) >>> 22:58:14 DEBUG| Host does not support OpenVSwitch: Missing command: >>> ovs-vswitchd >>> 22:58:14 DEBUG| Checkin

[Qemu-devel] [Bug 1368815] Re: qemu-img convert intermittently corrupts output images

2015-02-12 Thread Davanum Srinivas (DIMS)
Marking as Wont-Fix. ** Changed in: nova Status: In Progress => Won't Fix -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1368815 Title: qemu-img convert intermittently corrupts output images

Re: [Qemu-devel] [PATCH] tile: Can load elf64 tilegx binary successfully for linux-user.

2015-02-12 Thread Chris Metcalf
On 2/11/2015 10:48 PM, Chen Gang S wrote: On 2/12/15 11:32, Chen Gang S wrote: >>> >> +#define EM_TILE 191 /* Tile */ >>> >>+#define EM_TILE_OLD 0x2597 /* Tile compat */ >> > >> >No need for EM_TILE_OLD - it never really got out into the wild. >> > >> >Also, 191 is EM_TILEGX in , so you

Re: [Qemu-devel] [PATCH v3 4/4] numa: Print warning if no node is assigned to a CPU

2015-02-12 Thread Eduardo Habkost
On Thu, Feb 12, 2015 at 07:22:37PM +0100, Paolo Bonzini wrote: > On 12/02/2015 18:50, Eduardo Habkost wrote: > > + > > +if (!bitmap_full(seen_cpus, max_cpus)) { > > +char *msg; > > +bitmap_complement(seen_cpus, seen_cpus, max_cpus); > > +msg = enumerate_cpus(seen_cpus, m

Re: [Qemu-devel] HEAD is failing virt-test on migration tests

2015-02-12 Thread Lucas Meneghel Rodrigues
t; 22:58:14 DEBUG| Checking image file >>> /mnt/kvm/src/virt-test/shared/data/images/jeos-20-64.qcow2 >>> 22:58:14 DEBUG| Running '/bin/qemu-img info >>> /mnt/kvm/src/virt-test/shared/data/images/jeos-20-64.qcow2' >>> 22:58:14 DEBUG| Running '/bin/qemu-img check >>> /mnt/kvm/src/virt-test/shared/data/images/jeos-20-64.qcow2' >>> 22:58:14 ERROR| [stdout] >>> 22:58:14 ERROR| [stdout] 1 errors were found on the image. >>> 22:58:14 ERROR| [stdout] Data may be corrupted, or further writes to the >>> image may corrupt it. >>> 22:58:14 ERROR| [stdout] 13495/163840 = 8.24% allocated, 0.03% >>> fragmented, 0.00% compressed clusters >>> 22:58:14 ERROR| [stdout] Image end offset: 885129216 >>> 22:58:14 ERROR| [stderr] ERROR cluster 13505 refcount=1 reference=2 >>> 22:58:14 ERROR| Errors found on image: >>> '/mnt/kvm/src/virt-test/shared/data/images/jeos-20-64.qcow2' >>> 22:58:14 WARNI| virt-tests-vm1 is not alive. Can not query the register >>> status >>> 22:58:14 DEBUG| Thread quit. Used to failed to get register info from >>> guest 20150212-225320-Mb1E4VV7 for 1 times. >>> >>> >> >> >> -- >> Lucas >> > > > > -- > Lucas > -- Lucas

Re: [Qemu-devel] HEAD is failing virt-test on migration tests

2015-02-12 Thread Lucas Meneghel Rodrigues
rc/virt-test/shared/data/images/jeos-20-64.qcow2' >> 22:58:14 ERROR| [stdout] >> 22:58:14 ERROR| [stdout] 1 errors were found on the image. >> 22:58:14 ERROR| [stdout] Data may be corrupted, or further writes to the >> image may corrupt it. >> 22:58:14 ERROR| [stdout] 13495/163840 = 8.24% allocated, 0.03% >> fragmented, 0.00% compressed clusters >> 22:58:14 ERROR| [stdout] Image end offset: 885129216 >> 22:58:14 ERROR| [stderr] ERROR cluster 13505 refcount=1 reference=2 >> 22:58:14 ERROR| Errors found on image: >> '/mnt/kvm/src/virt-test/shared/data/images/jeos-20-64.qcow2' >> 22:58:14 WARNI| virt-tests-vm1 is not alive. Can not query the register >> status >> 22:58:14 DEBUG| Thread quit. Used to failed to get register info from >> guest 20150212-225320-Mb1E4VV7 for 1 times. >> >> > > > -- > Lucas > -- Lucas

Re: [Qemu-devel] [PATCH] tile: Can load elf64 tilegx binary successfully for linux-user.

2015-02-12 Thread Chris Metcalf
On 2/11/2015 10:32 PM, Chen Gang S wrote: + */ +#define TARGET_NR_io_setup 0 +#define TARGET_NR_io_destroy1 +#define TARGET_NR_io_submit 2 [...] Isn't there a way to say "use the asm-generic syscalls"? What does ARM64 do, for exampl

Re: [Qemu-devel] [PULL 06/37] target-ppc: VXSQRT Should Not Be Set for NaNs

2015-02-12 Thread Maciej W. Rozycki
On Wed, 7 Jan 2015, Alexander Graf wrote: > diff --git a/target-ppc/fpu_helper.c b/target-ppc/fpu_helper.c > index 7f74466..81db60f 100644 > --- a/target-ppc/fpu_helper.c > +++ b/target-ppc/fpu_helper.c > @@ -920,14 +923,16 @@ uint64_t helper_fsqrt(CPUPPCState *env, uint64_t arg) > > farg.l

Re: [Qemu-devel] HEAD is failing virt-test on migration tests

2015-02-12 Thread Lucas Meneghel Rodrigues
tes to the > image may corrupt it. > 22:58:14 ERROR| [stdout] 13495/163840 = 8.24% allocated, 0.03% fragmented, > 0.00% compressed clusters > 22:58:14 ERROR| [stdout] Image end offset: 885129216 > 22:58:14 ERROR| [stderr] ERROR cluster 13505 refcount=1 reference=2 > 22:58:14 ERROR| Errors found on image: > '/mnt/kvm/src/virt-test/shared/data/images/jeos-20-64.qcow2' > 22:58:14 WARNI| virt-tests-vm1 is not alive. Can not query the register > status > 22:58:14 DEBUG| Thread quit. Used to failed to get register info from > guest 20150212-225320-Mb1E4VV7 for 1 times. > > -- Lucas

[Qemu-devel] HEAD is failing virt-test on migration tests

2015-02-12 Thread Juan Quintela
atus 22:58:14 DEBUG| Thread quit. Used to failed to get register info from guest 20150212-225320-Mb1E4VV7 for 1 times.

Re: [Qemu-devel] Help on TLB Flush

2015-02-12 Thread Lluís Vilanova
Mark Burton writes: >> On 12 Feb 2015, at 16:38, Alexander Graf wrote: >> >> >> >> On 12.02.15 15:58, Peter Maydell wrote: >>> On 12 February 2015 at 14:45, Alexander Graf wrote: almost nobody except x86 does global flushes >>> >>> All ARM TLB maintenance operations have both "this CPU

[Qemu-devel] [PATCH 4/6] save_xbzrle_page: change calling convention

2015-02-12 Thread Juan Quintela
Add a parameter to pass the number of bytes written, and make it return the number of pages written instead. Signed-off-by: Juan Quintela --- arch_init.c | 44 +--- 1 file changed, 25 insertions(+), 19 deletions(-) diff --git a/arch_init.c b/arch_init.c i

[Qemu-devel] [PATCH 3/6] ram_save_page: change calling covention

2015-02-12 Thread Juan Quintela
Add a parameter to pass the number of bytes written, and make it return the number of pages written instead. Signed-off-by: Juan Quintela --- arch_init.c | 57 ++--- 1 file changed, 38 insertions(+), 19 deletions(-) diff --git a/arch_init.c b/

[Qemu-devel] [PATCH 6/6] rename save_block_hdr to save_page_header

2015-02-12 Thread Juan Quintela
It has always been a page header, not a block header. Once there, the flag argument was only passed to make a bit or with it, just do the or on the caller. Signed-off-by: Juan Quintela --- arch_init.c | 27 +++ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git

[Qemu-devel] [PATCH 2/6] ram_find_and_save_block: change calling convention

2015-02-12 Thread Juan Quintela
Add a parameter to pass the number of bytes written, and make it return the number of pages written instead. Signed-off-by: Juan Quintela --- arch_init.c | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/arch_init.c b/arch_init.c i

[Qemu-devel] [PATCH 5/6] save_block_hdr: we can recalculate the cont parameter here

2015-02-12 Thread Juan Quintela
No need to pass it through all the callers. Once there, update last_sent_block here. Signed-off-by: Juan Quintela --- arch_init.c | 47 --- 1 file changed, 24 insertions(+), 23 deletions(-) diff --git a/arch_init.c b/arch_init.c index 834f40c..95a61e

[Qemu-devel] [PATCH 0/6] migration: differentiate between pages and bytes

2015-02-12 Thread Juan Quintela
Hi (Li special edition) Current migration code returns number of bytes transferred and from there we decide if we.have sent something or not. Problem, we need two results: number of pages written, and number of bytes written (depending on compression, zero pages, etc, it is not possible to deriv

Re: [Qemu-devel] [PATCH] cocoa.m: Adds console items to the view menu

2015-02-12 Thread Programmingkid
On Feb 11, 2015, at 10:39 PM, Peter Maydell wrote: > On 24 January 2015 at 01:56, Programmingkid wrote: >> This patch adds these consoles to the View menu: >> VGA >> QEMU Monitor >> Parallel >> Serial >> >> Signed-off-by: John Arbuckle > >> +/* Displays the VGA screen */ >> +- (void)displayVG

[Qemu-devel] [PATCH 1/6] ram: make all save_page functions take a uint64_t parameter

2015-02-12 Thread Juan Quintela
It used to be an int, but then we can't pass directly the bytes_transferred parameter, that would happen later in the series. Signed-off-by: Juan Quintela --- arch_init.c | 11 --- include/migration/migration.h | 2 +- include/migration/qemu-file.h | 2 +- migration/q

Re: [Qemu-devel] Help on TLB Flush

2015-02-12 Thread Peter Maydell
On 12 February 2015 at 15:38, Alexander Graf wrote: > On 12.02.15 15:58, Peter Maydell wrote: >> All ARM TLB maintenance operations have both "this CPU only" >> and "all TLBs in the Inner Shareable domain" [that's ARM-speak >> for "every CPU core in the cluster"] variants (the latter >> being the

Re: [Qemu-devel] Help on TLB Flush

2015-02-12 Thread Peter Maydell
On 12 February 2015 at 15:19, Alexander Graf wrote: > On 12.02.15 16:08, Mark Burton wrote: >> Our question is - do we need this ‘sync’ (before the flush), >> or can we actually allow CPU’s to flush themselves asynchronously…. > > The respective target architecture specs will tell you. And I very

[Qemu-devel] [PATCH 5/5] linux-user: Support tile architecture in linux-user

2015-02-12 Thread Chen Gang S
Add main working flow feature and loading elf64 tilegx binary feature, based on Linux kernel tilegx 64-bit implementation. After this patch, qemu can successfully load elf64 tilegx binary for linux-user, and the working flow reaches 1st instruction "__start". Signed-off-by: Chen Gang --- includ

[Qemu-devel] [PATCH 4/5] linux-user: Support tile architecture in syscall

2015-02-12 Thread Chen Gang S
Add tile architecture in "syscall_defs.h", all related features (ioctrl, and stat) are based on Linux kernel tilegx 64-bit implementation. Signed-off-by: Chen Gang --- linux-user/syscall_defs.h | 34 +++--- 1 file changed, 31 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH 3/5] linux-user: tile: Add target features support within qemu

2015-02-12 Thread Chen Gang S
They are for target features within qemu which independent from outside. Signed-off-by: Chen Gang --- linux-user/tile/target_cpu.h | 35 + linux-user/tile/target_signal.h | 28 +++ linux-user/tile/target_structs.h | 48

  1   2   3   >