Re: [Qemu-devel] [PATCH v3 0/4] bootdevcie: change the boot order validation logic

2015-02-11 Thread Gonglei
On 2015/2/7 15:20, Gonglei (Arei) wrote: > From: Gonglei > > The reset logic can be done by both machine reset and > boot handler. So we shouldn't return error when the boot > handler callback don't be set in patch 1. > > Patch 2 check boot order argument validation > before vm running. > > Pat

Re: [Qemu-devel] [RFC PATCH v8 21/21] replay: recording of the user input

2015-02-11 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 22/01/2015 09:53, Pavel Dovgalyuk wrote: > > +void replay_input_event(QemuConsole *src, InputEvent *evt) > > +{ > > +if (replay_mode == REPLAY_MODE_PLAY) { > > +/* Nothing */ > > +} else if (re

[Qemu-devel] [PATCH] object: fix typo, 'my_class_init' -> 'derived_class_init'

2015-02-11 Thread arei.gonglei
From: Zhoujian Signed-off-by: Zhoujian Signed-off-by: Gonglei --- include/qom/object.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qom/object.h b/include/qom/object.h index 89c3092..8757573 100644 --- a/include/qom/object.h +++ b/include/qom/object.h @@ -273,7 +

Re: [Qemu-devel] [v5 08/12] migration: Add the core code of multi-thread compression

2015-02-11 Thread Li, Liang Z
> -Original Message- > From: Juan Quintela [mailto:quint...@redhat.com] > Sent: Wednesday, February 11, 2015 7:45 PM > To: Li, Liang Z > Cc: qemu-devel@nongnu.org; ebl...@redhat.com; amit.s...@redhat.com; > lcapitul...@redhat.com; arm...@redhat.com; dgilb...@redhat.com; Zhang, > Yang Z > Su

Re: [Qemu-devel] [sheepdog] [PATCH v4] sheepdog: selectable object size support

2015-02-11 Thread Liu Yuan
On Thu, Feb 12, 2015 at 04:28:01PM +0900, Hitoshi Mitake wrote: > At Thu, 12 Feb 2015 15:00:49 +0800, > Liu Yuan wrote: > > > > On Thu, Feb 12, 2015 at 03:19:21PM +0900, Hitoshi Mitake wrote: > > > At Tue, 10 Feb 2015 18:35:58 +0800, > > > Liu Yuan wrote: > > > > > > > > On Tue, Feb 10, 2015 at 0

Re: [Qemu-devel] [PATCH] nbd: Fix overflow return value

2015-02-11 Thread Fam Zheng
On Thu, 02/12 06:21, Yik Fang wrote: > The value of reply.error should be the type unsigned int. > > Signed-off-by: Yik Fang > --- > nbd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/nbd.c b/nbd.c > index e56afbc1..30e2f3b 100644 > --- a/nbd.c > +++ b/nbd.c > @@ -12

Re: [Qemu-devel] [RFC PATCH 01/14] docs: block replication's description

2015-02-11 Thread Wen Congyang
On 02/12/2015 03:21 PM, Fam Zheng wrote: > Hi Congyang, > > On Thu, 02/12 11:07, Wen Congyang wrote: >> +== Workflow == >> +The following is the image of block replication workflow: >> + >> ++--+++ >> +|Primary Write Requests|

Re: [Qemu-devel] [PATCH] softfloat: roundAndPackFloat16 should return FPInfinity and FPMaxNormal based on overflow_to_inf.

2015-02-11 Thread Xiangyu Hu
On Wed, Feb 11, 2015 at 5:23 AM, Peter Maydell wrote: > On 9 February 2015 at 14:56, Xiangyu Hu wrote: > > Flag overflow_to_inf is specified by ARM manual to decide if > > FPInfinity(sign) or FPMaxNormal(sign) is returned. Current > > codepath fails to check it. > > Fixed by adding overflow_to_i

Re: [Qemu-devel] [PATCH] tile: Can load elf64 tilegx binary successfully for linux-user.

2015-02-11 Thread Chris Metcalf
On 2/12/15 08:00, Chen Gang S wrote: After load elf64 tilegx binary for linux-user, the working flow reaches the first correct instruction postion "__start". Congratulations on getting started. I hope you have success with the emulation part. index f185dd0..d9e0dec 100755 --- a/configure ++

[Qemu-devel] [PATCH] nbd: Fix overflow return value

2015-02-11 Thread Yik Fang
The value of reply.error should be the type unsigned int. Signed-off-by: Yik Fang --- nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nbd.c b/nbd.c index e56afbc1..30e2f3b 100644 --- a/nbd.c +++ b/nbd.c @@ -1295,7 +1295,7 @@ static void nbd_trip(void *opaque) defau

Re: [Qemu-devel] [sheepdog] [PATCH v4] sheepdog: selectable object size support

2015-02-11 Thread Hitoshi Mitake
At Thu, 12 Feb 2015 15:00:49 +0800, Liu Yuan wrote: > > On Thu, Feb 12, 2015 at 03:19:21PM +0900, Hitoshi Mitake wrote: > > At Tue, 10 Feb 2015 18:35:58 +0800, > > Liu Yuan wrote: > > > > > > On Tue, Feb 10, 2015 at 06:56:33PM +0900, Teruaki Ishizaki wrote: > > > > (2015/02/10 17:58), Liu Yuan wr

Re: [Qemu-devel] [v5 02/12] migration: Add the framework of multi-thread compression

2015-02-11 Thread Li, Liang Z
> Reviewing patch 8, I found that we need to fix some things here. > > > +static int ram_save_compressed_page(QEMUFile *f, RAMBlock *block, > > +ram_addr_t offset, bool > > +last_stage) { > > +int bytes_sent = -1; > > + > > +/* To be done*/ > > + > > +

Re: [Qemu-devel] [RFC PATCH 01/14] docs: block replication's description

2015-02-11 Thread Fam Zheng
Hi Congyang, On Thu, 02/12 11:07, Wen Congyang wrote: > +== Workflow == > +The following is the image of block replication workflow: > + > ++--+++ > +|Primary Write Requests||Secondary Write Requests| > ++-

Re: [Qemu-devel] [sheepdog] [PATCH v4] sheepdog: selectable object size support

2015-02-11 Thread Liu Yuan
On Thu, Feb 12, 2015 at 03:19:21PM +0900, Hitoshi Mitake wrote: > At Tue, 10 Feb 2015 18:35:58 +0800, > Liu Yuan wrote: > > > > On Tue, Feb 10, 2015 at 06:56:33PM +0900, Teruaki Ishizaki wrote: > > > (2015/02/10 17:58), Liu Yuan wrote: > > > >On Tue, Feb 10, 2015 at 05:22:02PM +0900, Teruaki Ishiz

[Qemu-devel] [PATCH v7 3/4] target-arm: Add 32/64-bit register sync

2015-02-11 Thread Greg Bellows
Add AArch32 to AArch64 register sychronization functions. Replace manual register synchronization with new functions in aarch64_cpu_do_interrupt() and HELPER(exception_return)(). Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell --- v6 -> v7 -Fix comment issues v5 -> v6 - Add r14 set in

[Qemu-devel] [PATCH v7 2/4] target-arm: Add feature parsing to virt

2015-02-11 Thread Greg Bellows
Added machvirt parsing of feature keywords added to the -cpu command line option. Parsing occurs during machine initialization. Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell --- v3 -> v4 - Fix misspelling v1 -> v2 - Fix multiple property handling --- hw/arm/virt.c | 20

[Qemu-devel] [PATCH v7 4/4] target-arm: Add AArch32 guest support to KVM64

2015-02-11 Thread Greg Bellows
Add 32-bit to/from 64-bit register synchronization on register gets and puts. Set EL1_32BIT feature flag passed to KVM Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell --- v4 -> v5 - Fix target check v3 -> v4 - Add check that to make sure KVM64 is only being used on AArch64 family of

[Qemu-devel] [PATCH v7 1/4] target-arm: Add CPU property to disable AArch64

2015-02-11 Thread Greg Bellows
Adds registration and get/set functions for enabling/disabling the AArch64 execution state on AArch64 CPUs. By default AArch64 execution state is enabled on AArch64 CPUs, setting the property to off, will disable the execution state. The below QEMU invocation would have AArch64 execution state dis

[Qemu-devel] [PATCH v7 0/4] target-arm: ARM64: Adding EL1 AARCH32 guest support

2015-02-11 Thread Greg Bellows
Added support for running an AArch32 guest on a AArch64 KVM host. Support has only been added to the QEMU machvirt machine. The addition of CPU properties specifiable from the command line were added to allow disablement of AArch64 execution state hereby forcing EL1 to be AArch32. The new CPU co

Re: [Qemu-devel] [RFC PATCH 02/14] quorom: add a new read pattern

2015-02-11 Thread Gonglei
On 2015/2/12 11:07, Wen Congyang wrote: > To block replication, we only need to read from the first child. > > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > Cc: Luiz Capitulino > Cc: Michael Roth A little typo in title of patch 2 and patch 5: s/quorom/

Re: [Qemu-devel] [PATCH] softfloat: roundAndPackFloat16 should return FPInfinity and FPMaxNormal based on overflow_to_inf.

2015-02-11 Thread Peter Maydell
On 12 February 2015 at 06:25, Xiangyu Hu wrote: > On Wed, Feb 11, 2015 at 5:23 AM, Peter Maydell > wrote: >> >> On 9 February 2015 at 14:56, Xiangyu Hu wrote: >> > Flag overflow_to_inf is specified by ARM manual to decide if >> > FPInfinity(sign) or FPMaxNormal(sign) is returned. Current >> > co

Re: [Qemu-devel] [PATCH] softfloat: roundAndPackFloat16 should return FPInfinity and FPMaxNormal based on overflow_to_inf.

2015-02-11 Thread Xiangyu Hu
On Wed, Feb 11, 2015 at 9:23 PM, Peter Maydell wrote: > On 9 February 2015 at 14:56, Xiangyu Hu wrote: > > Flag overflow_to_inf is specified by ARM manual to decide if > > FPInfinity(sign) or FPMaxNormal(sign) is returned. Current > > codepath fails to check it. > > Fixed by adding overflow_to_i

[Qemu-devel] [RFC] net: 'Remove vhostforce option in addition to vhost param'

2015-02-11 Thread Pankaj Gupta
vhostforce was added to enable use of vhost when guest don't have MSI-X support. Now, we have scenarios which dont use interrupts like DPDK and still use vhost. Also, performance of guests without MSI-X support is getting less popular. Its ok to remove this extra option and enable vhost on

Re: [Qemu-devel] [sheepdog] [PATCH v4] sheepdog: selectable object size support

2015-02-11 Thread Hitoshi Mitake
At Tue, 10 Feb 2015 18:35:58 +0800, Liu Yuan wrote: > > On Tue, Feb 10, 2015 at 06:56:33PM +0900, Teruaki Ishizaki wrote: > > (2015/02/10 17:58), Liu Yuan wrote: > > >On Tue, Feb 10, 2015 at 05:22:02PM +0900, Teruaki Ishizaki wrote: > > >>(2015/02/10 12:10), Liu Yuan wrote: > > >>>On Tue, Jan 27,

Re: [Qemu-devel] [RFC PATCH v1 12/13] spapr: Support ibm, dynamic-reconfiguration-memory

2015-02-11 Thread David Gibson
On Thu, Jan 08, 2015 at 11:40:19AM +0530, Bharata B Rao wrote: > Parse ibm,architecture.vec table obtained from the guest and enable > memory node configuration via ibm,dynamic-reconfiguration-memory if guest > supports it. This is in preparation to support memory hotplug for > sPAPR guests. > > T

Re: [Qemu-devel] [PATCH v17 1/2] sPAPR: Implement EEH RTAS calls

2015-02-11 Thread Gavin Shan
On Thu, Feb 12, 2015 at 04:15:01PM +1100, David Gibson wrote: >On Wed, Feb 11, 2015 at 02:13:59PM +1100, Gavin Shan wrote: >> The emulation for EEH RTAS requests from guest isn't covered >> by QEMU yet and the patch implements them. >> >> The patch defines constants used by EEH RTAS calls and adds

Re: [Qemu-devel] [PATCH v6 3/4] target-arm: Add 32/64-bit register sync

2015-02-11 Thread Peter Maydell
On 12 February 2015 at 05:53, Greg Bellows wrote: > Add AArch32 to AArch64 register sychronization functions. > Replace manual register synchronization with new functions in > aarch64_cpu_do_interrupt() and HELPER(exception_return)(). > > Signed-off-by: Greg Bellows > > --- > > v5 -> v6 > - Add r

[Qemu-devel] [PATCH v6 3/4] target-arm: Add 32/64-bit register sync

2015-02-11 Thread Greg Bellows
Add AArch32 to AArch64 register sychronization functions. Replace manual register synchronization with new functions in aarch64_cpu_do_interrupt() and HELPER(exception_return)(). Signed-off-by: Greg Bellows --- v5 -> v6 - Add r14 set in 32_to_64 - Reorder conditionals in 64_to_32 fomr reg order

[Qemu-devel] [PATCH v6 2/4] target-arm: Add feature parsing to virt

2015-02-11 Thread Greg Bellows
Added machvirt parsing of feature keywords added to the -cpu command line option. Parsing occurs during machine initialization. Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell --- v3 -> v4 - Fix misspelling v1 -> v2 - Fix multiple property handling --- hw/arm/virt.c | 20

[Qemu-devel] [PATCH v6 4/4] target-arm: Add AArch32 guest support to KVM64

2015-02-11 Thread Greg Bellows
Add 32-bit to/from 64-bit register synchronization on register gets and puts. Set EL1_32BIT feature flag passed to KVM Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell --- v4 -> v5 - Fix target check v3 -> v4 - Add check that to make sure KVM64 is only being used on AArch64 family of

[Qemu-devel] [PATCH v6 0/4] target-arm: ARM64: Adding EL1 AARCH32 guest support

2015-02-11 Thread Greg Bellows
Added support for running an AArch32 guest on a AArch64 KVM host. Support has only been added to the QEMU machvirt machine. The addition of CPU properties specifiable from the command line were added to allow disablement of AArch64 execution state hereby forcing EL1 to be AArch32. The new CPU co

[Qemu-devel] [PATCH v6 1/4] target-arm: Add CPU property to disable AArch64

2015-02-11 Thread Greg Bellows
Adds registration and get/set functions for enabling/disabling the AArch64 execution state on AArch64 CPUs. By default AArch64 execution state is enabled on AArch64 CPUs, setting the property to off, will disable the execution state. The below QEMU invocation would have AArch64 execution state dis

Re: [Qemu-devel] [RFC PATCH v1 11/13] spapr: Initialize hotplug memory address space

2015-02-11 Thread Bharata B Rao
On Thu, Feb 12, 2015 at 04:19:36PM +1100, David Gibson wrote: > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > > index 44405b2..9ff08ff 100644 > > --- a/hw/ppc/spapr.c > > +++ b/hw/ppc/spapr.c > > @@ -120,6 +120,8 @@ struct sPAPRMachineState { > > > > /*< public >*/ > > char *kvm_type

[Qemu-devel] [PATCH 1/1] block/raw-posix: fix compilation warning on OSX

2015-02-11 Thread Denis V. Lunev
block/raw-posix.c:947:19: warning: unused variable 's' [-Wunused-variable] BDRVRawState *s = aiocb->bs->opaque; This variable is used only when on of the following macros are defined CONFIG_XFS, CONFIG_FALLOCATE, CONFIG_FALLOCATE_PUNCH_HOLE or CONFIG_FALLOCATE_ZERO_RANGE. Fortunately, CONFIG_F

Re: [Qemu-devel] [v5 05/12] arch_init: Alloc and free data struct for compression

2015-02-11 Thread Li, Liang Z
Hi Juan, Have you reviewed the 04 patch of the patch series? I didn't see the reply email. Liang > -Original Message- > From: Juan Quintela [mailto:quint...@redhat.com] > Sent: Wednesday, February 11, 2015 5:03 PM > To: Li, Liang Z > Cc: qemu-devel@nongnu.org; ebl...@redhat.com; a

Re: [Qemu-devel] [RFC PATCH v1 11/13] spapr: Initialize hotplug memory address space

2015-02-11 Thread David Gibson
On Thu, Jan 08, 2015 at 11:40:18AM +0530, Bharata B Rao wrote: > Initialize a hotplug memory region under which all the hotplugged > memory is accommodated. Also enable memory hotplug by setting > CONFIG_MEM_HOTPLUG. > > Modelled on i386 memory hotplug. > > Signed-off-by: Bharata B Rao > --- >

Re: [Qemu-devel] [PATCH v3] Fixes several full screen issues on Mac OS X

2015-02-11 Thread Peter Maydell
On 12 February 2015 at 04:42, Programmingkid wrote: >> (2) Maybe zoom-to-fit should be the default? I think that's >> how we handle fullscreen on other UIs, and it seems like the >> most intuitive thing for it to do. > > Zoom To Fit makes the screen look weird and text unreadable. > I would prefer

[Qemu-devel] [PATCH 3/3] virtio-scsi-dataplane: Use main thread BH to set BDS' aio context

2015-02-11 Thread Fam Zheng
Before processing a request, virtio-scsi dataplane will check if the backend runs on the same context with it. If not, it has to be moved, with bdrv_set_aio_context. However this function is unsafe to be called from IOThread outside BQL. The reason is that it calls bdrv_drain_all(), to acquire and

[Qemu-devel] [PATCH 1/3] block: Forbid bdrv_set_aio_context outside BQL

2015-02-11 Thread Fam Zheng
Even if the caller has the old #AioContext, there can be a deadlock, due to the leading bdrv_drain_all: Suppose there are three io threads (a, b, c) with each owning a BDS (bds_a, bds_b, bds_c), and a and b want to move their own BDS to c at the same time: iothread a i

[Qemu-devel] [PATCH 0/3] virtio-scsi: Fix unsafe bdrv_set_aio_context calls

2015-02-11 Thread Fam Zheng
It is not safe to call bdrv_set_aio_context outside BQL (see patch 1), so move the call to main thread (patch 3). And as a bonus, the two loops in virtio-scsi.c and virtio-scsi-dataplane.c for cmd queue handling are converged (patch 2). Fam Zheng (3): block: Forbid bdrv_set_aio_context outside

[Qemu-devel] [PATCH 2/3] virtio-scsi: Deduplicate cmd queue handling code of dataplane

2015-02-11 Thread Fam Zheng
The common logic of cmd handling will grow, now there is repeat, converge them to one place. Signed-off-by: Fam Zheng --- hw/scsi/virtio-scsi-dataplane.c | 15 +++ hw/scsi/virtio-scsi.c | 27 ++- include/hw/virtio/virtio-scsi.h | 8 ++-- 3 files

Re: [Qemu-devel] [PATCH v17 1/2] sPAPR: Implement EEH RTAS calls

2015-02-11 Thread David Gibson
On Wed, Feb 11, 2015 at 02:13:59PM +1100, Gavin Shan wrote: > The emulation for EEH RTAS requests from guest isn't covered > by QEMU yet and the patch implements them. > > The patch defines constants used by EEH RTAS calls and adds > callbacks sPAPRPHBClass::{eeh_set_option, eeh_get_state, eeh_res

Re: [Qemu-devel] [PULL 05/42] block/raw-posix: refactor handle_aiocb_write_zeroes a bit

2015-02-11 Thread Denis V. Lunev
On 12/02/15 05:29, Peter Maydell wrote: On 6 February 2015 at 16:40, Kevin Wolf wrote: From: "Denis V. Lunev" move code dealing with a block device to a separate function. This will allow to implement additional processing for ordinary files. +static ssize_t handle_aiocb_write_zeroes(RawPosix

Re: [Qemu-devel] [PATCH v3] Fixes several full screen issues on Mac OS X

2015-02-11 Thread Programmingkid
On Feb 11, 2015, at 10:06 PM, Peter Maydell wrote: > On 21 January 2015 at 19:25, Programmingkid wrote: >> This patch makes several changes: >> - Minimizes distorted full screen display by respecting aspect >> ratios. >> - Makes full screen mode available on Mac OS 10.7 and higher. >> - Allows u

Re: [Qemu-devel] [PATCH v2] Machine menu patch for Mac OS X

2015-02-11 Thread Programmingkid
On Feb 11, 2015, at 9:41 PM, Peter Maydell wrote: > On 20 January 2015 at 17:22, Programmingkid wrote: >> Features: >> Menu items to switch floppy and CD image files. >> Menu items to eject floppy and CD image files. >> Menu item to use /dev/cdrom. >> Verifies with the user before quitting QEMU

Re: [Qemu-devel] [PATCH 0/4] gdbstub: improve query packet parsing, add qAttached support

2015-02-11 Thread Peter Maydell
On 7 February 2015 at 08:38, Jan Kiszka wrote: > This addresses the review comments on the previews two patches to add > qAttached support. No longer trivial, so maybe you can pick it up, > Peter. > > Jan > > > CC: Fabien Chouteau > CC: Jan Kiszka Reviewed-by: Peter Maydell If you can find a

Re: [Qemu-devel] [PATCH 1/4] gdbstub: Fix qOffsets packet detection

2015-02-11 Thread Peter Maydell
On 7 February 2015 at 08:38, Jan Kiszka wrote: > From: Jan Kiszka > > qOffsets has no additional optional parameters. So match the complete > string to avoid stumbling over possible future commands with identical > prefix. > > Signed-off-by: Jan Kiszka > --- > gdbstub.c | 2 +- > 1 file changed

Re: [Qemu-devel] [PATCH v5 3/4] target-arm: Add 32/64-bit register sync

2015-02-11 Thread Peter Maydell
On 12 February 2015 at 02:59, Greg Bellows wrote: > Add AArch32 to AArch64 register sychronization functions. > Replace manual register synchronization with new functions in > aarch64_cpu_do_interrupt() and HELPER(exception_return)(). > > Signed-off-by: Greg Bellows > > --- > > v4 -> v5 > - Rewor

Re: [Qemu-devel] [PATCH v5 4/4] target-arm: Add AArch32 guest support to KVM64

2015-02-11 Thread Peter Maydell
On 12 February 2015 at 02:59, Greg Bellows wrote: > Add 32-bit to/from 64-bit register synchronization on register gets and puts. > Set EL1_32BIT feature flag passed to KVM > > Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v5 1/4] target-arm: Add CPU property to disable AArch64

2015-02-11 Thread Peter Maydell
On 12 February 2015 at 02:59, Greg Bellows wrote: > Adds registration and get/set functions for enabling/disabling the AArch64 > execution state on AArch64 CPUs. By default AArch64 execution state is > enabled > on AArch64 CPUs, setting the property to off, will disable the execution > state. >

Re: [Qemu-devel] [PATCH] tile: Can load elf64 tilegx binary successfully for linux-user.

2015-02-11 Thread Chen Gang S
On 2/12/15 11:32, Chen Gang S wrote: >>> >> +#define EM_TILE 191 /* Tile */ >>> >> +#define EM_TILE_OLD 0x2597 /* Tile compat */ >> > >> > No need for EM_TILE_OLD - it never really got out into the wild. >> > >> > Also, 191 is EM_TILEGX in , so you really should use the same name >> > he

Re: [Qemu-devel] [PATCH] cocoa.m: Adds console items to the view menu

2015-02-11 Thread Peter Maydell
On 24 January 2015 at 01:56, Programmingkid wrote: > This patch adds these consoles to the View menu: > VGA > QEMU Monitor > Parallel > Serial > > Signed-off-by: John Arbuckle > +/* Displays the VGA screen */ > +- (void)displayVGA:(id)sender > +{ > +console_select(0); > +} > + > +/* Displays

Re: [Qemu-devel] [PATCH v1 1/2] vhost-user: support SET_MEM_TABLE waite the result of mmap

2015-02-11 Thread Linhaifeng
>> >> No.May be the existing slaves need add reply in their codes. > > So that's not good. We need a way to negotiate the capability, > we can't just deadlock with legacy slaves. > Hi,Michael Do you have any suggestions?

[Qemu-devel] [PATCH RFC v3 06/27] migration: Don't send vm description in COLO mode

2015-02-11 Thread zhanghailiang
Commit 8118f09 add vm description to the end of migration stream, but in COLO mode, we use the migration channel to send control code, so the additional info been send will cause slave receive unexpect control msg, so just do not send vm description when migrate under COLO mode. Signed-off-by: zha

[Qemu-devel] [PATCH RFC v3 14/27] COLO failover: Introduce a new command to trigger a failover

2015-02-11 Thread zhanghailiang
We leave users to use whatever heartbeat solution they want, if the heartbeat is lost, or other errors they detect, they can use command 'colo_lost_heartbeat' to tell COLO to do failover, COLO will do operations accordingly. For example, If send the command to PVM, Primary will exit COLO mode, and

[Qemu-devel] [PATCH RFC v3 25/27] COLO: Disable qdev hotplug when VM is in COLO mode

2015-02-11 Thread zhanghailiang
COLO do not support qdev hotplug migration, disable it. Signed-off-by: zhanghailiang Signed-off-by: Yang Hongyang --- migration/colo.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/migration/colo.c b/migration/colo.c index 874971c..aadecc5 100644 --- a/migration/colo.c +++ b/

[Qemu-devel] [PATCH RFC v3 11/27] COLO RAM: Load PVM's dirty page into SVM's RAM cache temporarily

2015-02-11 Thread zhanghailiang
The ram cache is initially the same as SVM/PVM's memory. At checkpoint, we cache the dirty RAM of PVM into RAM cache in the slave (so that RAM cache always the same as PVM's memory at every checkpoint), we will flush cached RAM to SVM after we receive all PVM's vmstate (RAM/device). Signed-off-by

[Qemu-devel] [PATCH RFC v3 05/27] migration: Integrate COLO checkpoint process into loadvm

2015-02-11 Thread zhanghailiang
Switch from normal migration loadvm process into COLO checkpoint process if COLO mode is enabled. Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian Signed-off-by: Lai Jiangshan Signed-off-by: Yang Hongyang --- include/migration/migration-colo.h | 14 +- migration/colo-comm.c

[Qemu-devel] [PATCH RFC v3 26/27] COLO: Implement shutdown checkpoint

2015-02-11 Thread zhanghailiang
For SVM, we forbid it shutdown directly when in COLO mode, FOR PVM's shutdown, we should do some work to ensure the consistent action between PVM and SVM. Signed-off-by: zhanghailiang Signed-off-by: Lai Jiangshan Signed-off-by: Li Zhijian --- include/migration/migration-colo.h | 1 + include/

[Qemu-devel] [PATCH RFC v3 23/27] COLO: Improve checkpoint efficiency by do additional periodic checkpoint

2015-02-11 Thread zhanghailiang
Besides normal checkpoint which according to the result of net packets comparing, We do additional checkpoint periodically, it will reduce the number of dirty pages when do one checkpoint, if we don't do checkpoint for a long time (This is a special case when the net packets is always consistent).

[Qemu-devel] [PATCH RFC v3 24/27] COLO NIC: Implement NIC checkpoint and failover

2015-02-11 Thread zhanghailiang
Signed-off-by: zhanghailiang Signed-off-by: Gao feng --- include/net/colo-nic.h | 3 ++- migration/colo.c | 22 ++ net/colo-nic.c | 19 +++ 3 files changed, 39 insertions(+), 5 deletions(-) diff --git a/include/net/colo-nic.h b/include/net/colo

[Qemu-devel] [PATCH RFC v3 19/27] COLO NIC: Implement colo nic device interface configure()

2015-02-11 Thread zhanghailiang
Implement colo nic device interface configure() add a script to configure nic devices: ${QEMU_SCRIPT_DIR}/colo-proxy-script.sh Signed-off-by: zhanghailiang Signed-off-by: Gao feng Signed-off-by: Li Zhijian --- net/colo-nic.c | 56 +++- scripts/colo-proxy-s

Re: [Qemu-devel] [PATCH] tile: Can load elf64 tilegx binary successfully for linux-user.

2015-02-11 Thread Chen Gang S
On 2/12/15 08:24, Chris Metcalf wrote: > On 2/12/15 08:00, Chen Gang S wrote: >> After load elf64 tilegx binary for linux-user, the working flow reaches >> the first correct instruction postion "__start". > > Congratulations on getting started. I hope you have success with the > emulation part.

[Qemu-devel] [PATCH RFC v3 22/27] COLO: Do checkpoint according to the result of net packets comparing

2015-02-11 Thread zhanghailiang
Only do checkpoint, when the VMs' output net packets are inconsistent. Signed-off-by: zhanghailiang Signed-off-by: Gao feng --- include/net/colo-nic.h | 2 ++ migration/colo.c | 23 +++ net/colo-nic.c | 41 + 3 files cha

[Qemu-devel] [PATCH RFC v3 27/27] COLO: Add block replication into colo process

2015-02-11 Thread zhanghailiang
Make sure master start block replication after slave's block replication started Signed-off-by: zhanghailiang Signed-off-by: Wen Congyang Signed-off-by: Yang Hongyang --- migration/colo.c | 94 +--- 1 file changed, 89 insertions(+), 5 deletio

[Qemu-devel] [PATCH RFC v3 20/27] COLO NIC : Implement colo nic init/destroy function

2015-02-11 Thread zhanghailiang
When in colo mode, call colo nic init/destroy function. Signed-off-by: zhanghailiang Signed-off-by: Gao feng Signed-off-by: Li Zhijian --- include/net/colo-nic.h | 2 ++ migration/colo.c | 17 +++ net/colo-nic.c | 80 ++ 3

[Qemu-devel] [PATCH RFC v3 03/27] COLO: migrate colo related info to slave

2015-02-11 Thread zhanghailiang
We can know if we should go into COLO mode by the info that has been migrated from PVM. Signed-off-by: zhanghailiang Signed-off-by: Yang Hongyang Signed-off-by: Lai Jiangshan Signed-off-by: Gonglei --- include/migration/migration-colo.h | 21 ++ migration/Makefile.objs

[Qemu-devel] [PATCH RFC v3 18/27] COLO NIC: Init/remove colo nic devices when add/cleanup tap devices

2015-02-11 Thread zhanghailiang
When COLO mode, we will do some init work for nic that will be used for COLO. Signed-off-by: zhanghailiang Signed-off-by: Gao feng Signed-off-by: Li Zhijian --- include/net/colo-nic.h | 20 ++ net/Makefile.objs | 1 + net/colo-nic.c | 73 ++

[Qemu-devel] [PATCH RFC v3 16/27] COLO failover: Don't do failover during loading VM's state

2015-02-11 Thread zhanghailiang
Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian Signed-off-by: Lai Jiangshan --- migration/colo.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/migration/colo.c b/migration/colo.c index bcde1ec..82459ec 100644 --- a/migration/colo.c +++ b/migration/colo.c

[Qemu-devel] [PATCH RFC v3 17/27] COLO: Add new command parameter 'colo_nicname' 'colo_script' for net

2015-02-11 Thread zhanghailiang
The 'colo_nicname' should be assigned with network name, for exmple, 'eth2'. It will be parameter of 'colo_script', 'colo_script' should be assigned with an scirpt path. We parse these parameter in tap. Signed-off-by: zhanghailiang Signed-off-by: Gao feng Signed-off-by: Li Zhijian --- include

[Qemu-devel] [PATCH RFC v3 21/27] COLO NIC: Some init work related with proxy module

2015-02-11 Thread zhanghailiang
Implement communication protocol with proxy module by using netlink, and do some init work. Signed-off-by: zhanghailiang Signed-off-by: Gao feng --- net/colo-nic.c | 171 + 1 file changed, 171 insertions(+) diff --git a/net/colo-nic.c b/n

[Qemu-devel] [PATCH RFC v3 15/27] COLO failover: Implement COLO master/slave failover work

2015-02-11 Thread zhanghailiang
If failover is requested, after some cleanup work, PVM or SVM will exit COLO mode, and resume to normal run. Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian Signed-off-by: Lai Jiangshan --- include/migration/migration-colo.h | 14 include/migration/migration-failover.h | 2 +

[Qemu-devel] [PATCH RFC v3 12/27] COLO VMstate: Load VM state into qsb before restore it

2015-02-11 Thread zhanghailiang
We should cache the device state to ensure the data is intact before restore it. Signed-off-by: zhanghailiang Signed-off-by: Yang Hongyang Signed-off-by: Gonglei --- migration/colo.c | 53 ++--- 1 file changed, 50 insertions(+), 3 deletions(-) d

[Qemu-devel] [PATCH RFC v3 13/27] COLO RAM: Flush cached RAM into SVM's memory

2015-02-11 Thread zhanghailiang
We only need to flush RAM that is both dirty on PVM and SVM since last checkpoint. Besides, we must ensure flush RAM cache before load device state. Signed-off-by: zhanghailiang a Signed-off-by: Lai Jiangshan Signed-off-by: Li Zhijian Signed-off-by: Yang Hongyang Signed-off-by: Gonglei --- ar

[Qemu-devel] [PATCH RFC v3 09/27] QEMUSizedBuffer: Introduce two help functions for qsb

2015-02-11 Thread zhanghailiang
Introduce two new QEMUSizedBuffer APIs which will be used by COLO to buffer VM state: One is qsb_put_buffer(), which put the content of a given QEMUSizedBuffer into QEMUFile, this is used to send buffered VM state to secondary. Another is qsb_fill_buffer(), read 'size' bytes of data from the file i

[Qemu-devel] [PATCH RFC v3 04/27] migration: Integrate COLO checkpoint process into migration

2015-02-11 Thread zhanghailiang
Add a migrate state: MIG_STATE_COLO, enter this migration state after the first live migration successfully finished. Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Lai Jiangshan --- include/migration/migration-colo.h | 2 ++ include/migration/migration.h | 13 +++

[Qemu-devel] [PATCH RFC v3 00/27] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service

2015-02-11 Thread zhanghailiang
This is the 3th version of COLO, it is only COLO frame part, include: VM checkpoint, failover, proxy API, block replication API, not include block replication. The block part has been sent by wencongyang: '[RFC PATCH 00/14] Block replication for continuous checkpoints' You can get the integrated

[Qemu-devel] [PATCH RFC v3 10/27] COLO: Save VM state to slave when do checkpoint

2015-02-11 Thread zhanghailiang
We should save PVM's RAM/device to slave when needed. For VM state, we will cache them in slave, we use QEMUSizedBuffer to store the data, we need know the data size of VM state, so in master, we use qsb to store VM state temporarily, and then migrate the data to slave. Signed-off-by: zhanghaili

[Qemu-devel] [PATCH RFC v3 07/27] COLO: Implement colo checkpoint protocol

2015-02-11 Thread zhanghailiang
We need communications protocol of user-defined to control the checkpoint process. The new checkpoint request is started by Primary VM, and the interactive process like below: Checkpoint synchronizing points, Primary Secondary NEW @

[Qemu-devel] [PATCH RFC v3 08/27] COLO: Add a new RunState RUN_STATE_COLO

2015-02-11 Thread zhanghailiang
Guest will enter this state when paused to save/restore VM state under colo checkpoint. Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Lai Jiangshan --- qapi-schema.json | 5 - vl.c | 8 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a

[Qemu-devel] [PATCH RFC v3 02/27] migration: Introduce capability 'colo' to migration

2015-02-11 Thread zhanghailiang
This capability allows Primary VM (PVM) to be continuously checkpointed to secondary VM. Signed-off-by: zhanghailiang Signed-off-by: Yang Hongyang Signed-off-by: Gonglei Signed-off-by: Lai Jiangshan --- include/migration/migration.h | 1 + migration/migration.c | 15 +++

[Qemu-devel] [PATCH RFC v3 01/27] configure: Add parameter for configure to enable/disable COLO support

2015-02-11 Thread zhanghailiang
configure --enable-colo/--disable-colo to switch COLO support on/off. COLO support is on by default. Signed-off-by: zhanghailiang Signed-off-by: Yang Hongyang Signed-off-by: Gonglei Signed-off-by: Lai Jiangshan --- configure | 14 ++ 1 file changed, 14 insertions(+) diff --git a/

Re: [Qemu-devel] [PATCH v3] Fixes several full screen issues on Mac OS X

2015-02-11 Thread Peter Maydell
On 21 January 2015 at 19:25, Programmingkid wrote: > This patch makes several changes: > - Minimizes distorted full screen display by respecting aspect > ratios. > - Makes full screen mode available on Mac OS 10.7 and higher. > - Allows user to decide if video should be stretched to fill the > scr

[Qemu-devel] [RFC PATCH 08/14] block: add a new API to create a hidden BlockBackend

2015-02-11 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- block/block-backend.c | 29 - include/sysemu/block-backend.h | 2 ++ 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/block/block-backend.c b/block/block-backe

[Qemu-devel] [RFC PATCH 11/14] allow writing to the backing file

2015-02-11 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- block.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 067c44b..96cf973 100644 --- a/block.c +++ b/block.c @@ -856,8 +856,8 @@ static int bdrv_inherited_flags(int

[Qemu-devel] [RFC PATCH 13/14] COW: move cow interfaces to a seperate file

2015-02-11 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- Makefile.objs | 2 +- block/backup.c| 52 --- blockcow.c| 52 +++ include/block/block.

[Qemu-devel] [RFC PATCH 12/14] Add disk buffer for block replication

2015-02-11 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- block/Makefile.objs| 1 + block/blkcolo-buffer.c | 324 + block/blkcolo.h| 35 ++ 3 files changed, 360 insertions(+) create mode 100644 block/b

[Qemu-devel] [RFC PATCH 14/14] COLO: implement a new block driver

2015-02-11 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- block/Makefile.objs | 2 +- block/blkcolo.c | 409 2 files changed, 410 insertions(+), 1 deletion(-) create mode 100644 block/blkcolo.c diff --git a/b

[Qemu-devel] [RFC PATCH 10/14] allow the backing image access the origin BlockDriverState

2015-02-11 Thread Wen Congyang
Block replication needs this feature. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- block.c | 2 ++ include/block/block_int.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/block.c b/block.c index a7a8932..067c44b 100644 --- a/blo

[Qemu-devel] [PATCH] virtio: validate the existence of handle_output before calling it

2015-02-11 Thread Jason Wang
We don't validate the existence of handle_output which may let a buggy guest to trigger a SIGSEV easily. Fix this by validate its existence before. Cc: qemu-sta...@nongnu.org Cc: Anthony Liguori Cc: Michael S. Tsirkin Signed-off-by: Jason Wang --- hw/virtio/virtio.c | 4 1 file changed, 4

[Qemu-devel] [RFC PATCH 03/14] quorum: ignore 0-length child

2015-02-11 Thread Wen Congyang
We connect to NBD server when starting block replication, so the length is 0 before starting block replication. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- block/quorum.c | 5 + 1 file changed, 5 insertions(+) diff --git a/block/quorum.c b/block/quo

[Qemu-devel] [RFC PATCH 07/14] NBD client: implement block driver interfaces for block replication

2015-02-11 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- block/nbd.c | 55 +++ 1 file changed, 55 insertions(+) diff --git a/block/nbd.c b/block/nbd.c index 19b9200..1ff6ecf 100644 --- a/block/nbd.c +++ b/block/nbd.

[Qemu-devel] [RFC PATCH 04/14] Add new block driver interfaces to control disk replication

2015-02-11 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- block.c | 36 include/block/block.h | 10 ++ include/block/block_int.h | 12 3 files changed, 58 insertions(+) diff --git a/block.

[Qemu-devel] [RFC PATCH 09/14] block: give backing image its own BlockBackend

2015-02-11 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- block.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/block.c b/block.c index 2335af1..a7a8932 100644 --- a/block.c +++ b/block.c @@ -1218,6 +1218,7 @@ int bdrv_open_backing_fil

[Qemu-devel] [RFC PATCH 06/14] NBD client: connect to nbd server later

2015-02-11 Thread Wen Congyang
The secondary qemu starts later than the primary qemu, so we cannot connect to nbd server in bdrv_open(). Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- block/nbd.c | 100 1 file changed, 87 inser

[Qemu-devel] [RFC PATCH 02/14] quorom: add a new read pattern

2015-02-11 Thread Wen Congyang
To block replication, we only need to read from the first child. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Cc: Luiz Capitulino Cc: Michael Roth --- block/quorum.c | 5 +++-- qapi/block-core.json | 4 +++- 2 files changed, 6 insertions(+), 3 deletio

[Qemu-devel] [RFC PATCH 05/14] quorom: implement block driver interfaces for block replication

2015-02-11 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- block/quorum.c | 69 ++ 1 file changed, 69 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index e6aff5f..c8479b4 100644 --- a/block/quorum.c +

[Qemu-devel] [RFC PATCH 01/14] docs: block replication's description

2015-02-11 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: Paolo Bonzini Signed-off-by: Yang Hongyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- docs/block-replication.txt | 129 + 1 file changed, 129 insertions(+) create mode 100644 docs/block-replic

[Qemu-devel] [RFC PATCH 00/14] Block replication for continuous checkpoints

2015-02-11 Thread Wen Congyang
Block replication is a very important feature which is used for continuous checkpoints(for example: COLO). Usage: Primary: -drive if=xxx,driver=quorum,read-pattern=first,\ children.0.file.filename=1.raw,\ children.0.driver=raw,\ children.1.file.driver=nbd+colo,\

[Qemu-devel] [PATCH v5 3/4] target-arm: Add 32/64-bit register sync

2015-02-11 Thread Greg Bellows
Add AArch32 to AArch64 register sychronization functions. Replace manual register synchronization with new functions in aarch64_cpu_do_interrupt() and HELPER(exception_return)(). Signed-off-by: Greg Bellows --- v4 -> v5 - Rework sync routines a bit more. v3 -> v4 - Rework sync routines to cove

  1   2   3   >